patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -735,8 +735,10 @@ class Toolbox(QObject, Extension):
self.openLicenseDialog(package_info["package_id"], license_content, file_path)
return
- self.install(file_path)
- self.subscribe(package_info["package_id"])
+ package_id = self.install(file_path)
+ if package... | [Toolbox->[resetMaterialsQualitiesAndUninstall->[_resetUninstallVariables,closeConfirmResetDialog],_onDownloadFailed->[resetDownload],launch->[_restart],_makeRequestByType->[_updateRequestHeader],_updateInstalledModels->[_convertPluginMetadata],_onDataRequestFinished->[isLoadingComplete],install->[_updateInstalledModel... | Called when the download is complete. | ... and then what? :-) |
@@ -14,9 +14,12 @@ def download(app, ref, package_ids, remote, recipe, recorder, remotes):
hook_manager.execute("pre_download", reference=ref, remote=remote)
try:
- ref = remote_manager.get_recipe(ref, remote)
+ _, ref = remote_manager.get_recipe_manifest(ref, remote)
except NotFoundExcep... | [_download_binaries->[_download->[info,get_package,str,PackageReference],_download,ThreadPool,join,close,info,map],download->[get_recipe,conanfile,list,keys,info,_download_binaries,search_packages,RecipeNotFoundException,str,load_basic,retrieve_exports_sources,ScopedOutput,isinstance,warn,ref_layout,full_str,execute]] | Download a single package. | We should probably avoid file transfers just to get the revision. Isn't there any other endpoint better than the manifest. I think in Conan 2.0 the manifest retrieval can actually be dropped in whole codebase. |
@@ -285,11 +285,13 @@ def get_supported(versions=None, noarch=False, platform=None,
# support macosx-10.6-intel on macosx-10.9-x86_64
match = _osx_arch_pat.match(arch)
if match:
- name, major, minor, actual_arch = match.groups()
+ # # https://github.c... | [get_impl_tag->[get_impl_ver,get_abbr_impl],get_abi_tag->[get_impl_ver,get_flag,get_abbr_impl,get_config_var],get_impl_ver->[get_abbr_impl,get_config_var],get_platform->[get_platform,_is_running_32bit],is_manylinux2010_compatible->[get_platform],get_darwin_arches->[_supports_arch->[_supports_arch],_supports_arch],get_s... | Return a list of supported tags for each version specified in versions. This function returns a list of all possible missing items in a system. Returns a list of all possible cross - version compatible C ++ objects. | Again, please try avoiding `# noqa`. |
@@ -9,6 +9,18 @@
#include "emu.h"
#include "gdrom.h"
+#define LOG_WARN (1U << 0)
+#define LOG_CMD (1U << 1)
+#define LOG_XFER (1U << 2)
+
+#define VERBOSE (LOG_WARN | LOG_CMD)
+//#define LOG_OUTPUT_STREAM std::cout
+#include "logmacro.h"
+
+#define LOGWARN(...) LOGMASKED(LOG_WARN, __VA_ARGS__)
+#defi... | [No CFG could be retrieved] | This function is a wrapper for the GD -ROM security - related functions. - > Mil - CD. | Another file inappropriately using bit zero with the logging macros. |
@@ -182,13 +182,13 @@ function karmaBrowserStart_() {
* @return {!Promise<number>}
*/
async function createKarmaServer(config) {
- let resolver, browsers_, results_;
+ let resolver, results_;
const deferred = new Promise((resolverIn) => {
resolver = resolverIn;
});
const karmaServer = new Server(... | [No CFG could be retrieved] | Creates and starts a karma server for the given test case. | This noop doesn't feel like a noop because it only functions if you consider the cross-file changes... I'd split this change into a separate PR |
@@ -29,7 +29,9 @@ module Search
},
"title" => hit["name"],
"path" => hit["path"],
- "id" => hit["id"]
+ "id" => hit["id"],
+ "class_name" => "User",
+ "positive_reactions_count" => hit["positive_reactions_count"]
}
end
| [User->[search_documents->[search,dig,prepare_doc,paginate_hits,as_hash,set_query_size,map],index_settings->[production?],freeze]] | prepare_doc - prepares the document for the missing document. | Couple more fields need to render users into the articleHTML template in the main feed. |
@@ -281,7 +281,7 @@ func NewRemoteInboxSource(g *globals.Context, ri func() chat1.RemoteInterface) *
return s
}
-func (s *RemoteInboxSource) Clear(ctx context.Context, uid gregor1.UID) error {
+func (s *RemoteInboxSource) Clear(ctx context.Context, uid gregor1.UID, opts types.ClearOpts) error {
return nil
}
| [Clear->[Clear,createInbox],Localize->[maybeNuke,Localize],MergeLocalMetadata->[maybeNuke,MergeLocalMetadata,createInbox],TeamTypeChanged->[getConvLocal,handleInboxError,createInbox,TeamTypeChanged],ReadUnverified->[setDefaultParticipantMode,Read,IsOffline,maybeNuke,fetchRemoteInbox,createInbox],SetTeamRetention->[SetT... | Clear will read an inbox from the remote server. | Should just have it take `nil` with an explicit default setup so it isn't so dependent on default values |
@@ -330,7 +330,7 @@ namespace DotNetNuke.UI.Skins
/// <param name="skinFile">The File Name without extension</param>
private static string FormatSkinName(string skinFolder, string skinFile)
{
- if (skinFolder.ToLower() == "_default")
+ if (skinFolder.ToLowerInvariant() =... | [SkinController->[GetHostSkins->[AddSkinFiles],ProcessSkinsFolder->[AddSkinFiles],GetSkins->[GetPortalSkins,GetHostSkins],DeleteSkin->[DeleteSkin],UploadLegacySkin->[UploadLegacySkin,FormatMessage],UpdateSkin->[UpdateSkin],UpdateSkinPackage->[UpdateSkin,UpdateSkinPackage],DeleteSkinPackage->[DeleteSkinPackage],AddSkin-... | FormatSkinName - function to format the name of a skin. | Please use `String#Equals(String, StringComparison)` |
@@ -160,6 +160,8 @@ public class JpaOutboundGatewayParserTests extends AbstractRequestHandlerAdvice
assertEquals(PersistMode.PERSIST, persistMode);
+ assertEquals(new Integer(100), TestUtils.getPropertyValue(jpaExecutor, "flushSize", Integer.class));
+ assertTrue(TestUtils.getPropertyValue(jpaExecutor, "cleanO... | [JpaOutboundGatewayParserTests->[testRetrievingJpaOutboundGatewayParserWithFirstResultExpression->[assertNotNull,getPropertyValue,setUp,assertEquals,getClass],withBothFirstResultAndFirstResultExpressionPresent->[assertTrue,startsWith,getClass,fail,ClassPathXmlApplicationContext],testRetrievingJpaOutboundGatewayParserWi... | Method to update JpaOutboundGateway parser. Test if a JPA outbound gateway is advised. | should probably be Integer.valueOf(100) purely for consistency reasons. |
@@ -390,7 +390,7 @@ export default function initAdmin( jQuery ) {
} );
// Handle the Company or Person select.
- jQuery( "#company_or_person" ).change( function() {
+ jQuery( "#company_or_person" ).on( "change", function() {
var companyOrPerson = jQuery( this ).val();
if ( "company" === companyOrPerso... | [No CFG could be retrieved] | Toggle the Zapier connection section. Change the variable usage in the template and the input. | 1. Go to `SEO` > `Search Appearance` > `General` > `Knowledge Graph and Schema.org`. 2. Make sure the `Choose whether the site represents an organization or a person.` toggle still works. 3. No `JQMIGRATE: jQuery.fn.change() event shorthand is deprecated` warning should be thrown. |
@@ -124,7 +124,8 @@ public class DefaultJnlpSlaveReceiver extends JnlpAgentReceiver {
Channel ch = computer.getChannel();
if (ch != null) {
String cookie = event.getProperty(JnlpConnectionState.COOKIE_KEY);
- if (cookie != null && MessageDigest.isEqual(cookie.getBytes(StandardC... | [DefaultJnlpSlaveReceiver->[afterProperties->[getDelegate]]] | Checks if a connection is refusal and rejects if it is. Checks if a connection is refusal and rejects if it is. | One of the confusing bits is that this would previously throw a NullPointerException. |
@@ -0,0 +1,15 @@
+module Users
+ class ServiceProviderInactiveController < ApplicationController
+ include FullyAuthenticatable
+
+ def index
+ analytics.track_event(Analytics::SP_INACTIVE_VISIT)
+
+ @sp_name = sp_from_sp_session&.friendly_name ||
+ I18n.t('service_providers.errors.gene... | [No CFG could be retrieved] | No Summary Found. | sorry I'm late to the party, but would we want to also store which SP it is in the analytics? |
@@ -90,6 +90,15 @@ public class QueryDatabaseTable extends AbstractDatabaseFetchProcessor {
.addValidator(StandardValidators.NON_NEGATIVE_INTEGER_VALIDATOR)
.build();
+ public static final PropertyDescriptor MAX_ROWS_PER_FLOW_FILE = new PropertyDescriptor.Builder()
+ .name("Max... | [QueryDatabaseTable->[setup->[setup],onTrigger->[getValue,getQuery,setState,create,toMap,getMetaData,getURL,getElapsed,info,remove,executeQuery,yield,getLocalizedMessage,getStateManager,AtomicLong,createSession,set,isEmpty,asList,intValue,MaxValueResultSetRowCollector,valueOf,transfer,ProcessException,getState,error,de... | This class is used to provide a table that fetches records that have a maximum number of values Get the set of relationships. | Good idea! I like it :) Lately we've been encouraging folks to add the "friendly" name (like "Max Rows in Flow File") using displayName() in the builder, and something like "qdbt-max-rows" as the name(), to help with internationalization. I realize the other properties don't follow this, and it's not a requirement, jus... |
@@ -35,8 +35,8 @@ class BaseExporter:
options: :doc:`export.options` to allow configuration for the exporter
"""
- def __init__(self, **options):
- options = ExporterOptions(**options)
+ def __init__(self, **kwargs):
+ options = ExporterOptions(**kwargs)
parsed_connection_st... | [is_retryable_code->[bool],BaseExporter->[_transmit_from_storage->[list,get,gets,lease,_transmit,delete],_transmit->[error,append,is_retryable_code,len,as_dict,info,warning,put,track,map],__init__->[AzureMonitorClient,LocalFileStorage,ExporterOptions,ConnectionStringParser,gettempdir,RetryPolicy,join]],getLogger] | Initialize a new AzureMonitor object. | We have `**options` in ``AzureMonitorTraceExporter` but `**kwargs` in `BaseExporter`? |
@@ -202,9 +202,9 @@ class MatrixTransport:
# TODO: Add greenlet that regularly refreshes our presence state
self._client.set_presence_state(UserPresence.ONLINE.value)
+ self._send_queued_messages() # uses property instead of initial_queues
- gevent.spawn_later(1, self._send_queued_m... | [MatrixTransport->[_handle_presence_change->[UserPresence],_get_room_id_for_address->[_set_room_id_for_address],_send_queued_messages->[start_health_check,send_async],_update_address_presence->[_get_user_presence],_get_user_presence->[UserPresence],_validate_userid_signature->[_recover],_cachegetter]] | Starts the protocol. | Is it possible to have private information in the config dictionary? If it is then it must not be logged. |
@@ -123,11 +123,15 @@ public class LogAttribute extends AbstractProcessor {
protected String processFlowFile(final ProcessorLog logger, final DebugLevels logLevel, final FlowFile flowFile, final ProcessSession session, final ProcessContext context) {
final Set<String> attributeKeys = getAttributesToLog(fl... | [LogAttribute->[onTrigger->[processFlowFile,transferChunk]]] | Process a flow file and return a formatted message. Debug and Warn are handled by the console. | Since we are changing the output format would like to see a String.format or something similar to give a consistent width with number of dashes. |
@@ -3637,7 +3637,7 @@ function SimpleChange(previous, current) {
SimpleChange.prototype.isFirstChange = function() { return this.previousValue === _UNINITIALIZED_VALUE; };
-var PREFIX_REGEXP = /^((?:x|data)[:\-_])/i;
+var PREFIX_REGEXP = /^((?:x|data)*[:\-_])/i;
var SPECIAL_CHARS_REGEXP = /[:\-_]+(.)/g;
/**
| [No CFG could be retrieved] | Provides a list of all possible values for a single element - attribute. Available attributes for the element with a name that is not in the DOM. | The `*` is wrong. Use `?` instead. |
@@ -37,9 +37,6 @@ func TestSpoutPachctl(t *testing.T) {
defer tu.DeleteAll(t)
c := tu.GetAuthenticatedPachClient(t, auth.RootUser)
- dataRepo := tu.UniqueString("TestSpoutAuth_data")
- require.NoError(t, c.CreateRepo(dataRepo))
-
// create a spout pipeline
pipeline := tu.UniqueString("pipelinespoutauth"... | [NewBranch,YesError,NewPFSInput,InspectCommit,WriteHeader,JoinHostPort,ResolveTCPAddr,SubscribeCommit,Close,GetAuthenticatedPachClient,NewSystemRepo,CreateRepo,NoErrorWithinTRetry,SquashCommitSet,New,Short,Ctx,NewPipeline,Errorf,Skip,NewWriter,GetFile,Equal,CreatePipeline,GetPachClient,NoError,InspectPipeline,NewTestin... | TestSpoutPachctl tests that the pachyderm pps pach elinespoutauth is a poutauth. | `dataRepo` gets created in a bunch of these tests but it's not used, remove it. |
@@ -17,7 +17,7 @@ module RepositoryRows
def call
return self unless valid?
- ActiveRecord::Base.transaction do
+ @repository_row.with_lock do
# Update invetory row's cells
params[:repository_cells]&.each do |column_id, value|
column = @repository_row.repository.repos... | [UpdateRepositoryRowService->[call->[changed?,data_changed?,transaction,present?,attributes,update_data!,save!,full_messages,destroy!,raise,create_with_value!,find_by,valid?,blank?,each,last_modified_by,id,underscore],succeed?->[none?],valid?->[compact],attr_reader,extend]] | Initialize a new object. | Metrics/BlockLength: Block has too many lines. [30/25] |
@@ -89,7 +89,7 @@ module SubmissionsHelper
def construct_file_manager_table_row(file_name, file)
table_row = {}
table_row[:id] = file.object_id
- table_row[:filter_table_row_contents] = render_to_string :partial => 'submissions/table_row/filter_table_row', :locals => {:file_name => file_name, :file => f... | [construct_file_manager_table_rows->[construct_file_manager_table_row]] | Construct a filter table row for the file manager. | Line is too long. [154/80]<br>Space inside { missing.<br>Space inside } missing. |
@@ -122,13 +122,14 @@ class CommonFunctionsTest extends \PHPUnit_Framework_TestCase
public function testIsValidHostname()
{
$this->assertTrue(is_valid_hostname('a'), 'a');
- $this->assertTrue(is_valid_hostname('a.'), 'a.');
$this->assertTrue(is_valid_hostname('0'), '0');
$thi... | [CommonFunctionsTest->[testStrContains->[assertTrue,assertFalse],testStringToClass->[assertSame],testDisplay->[assertEquals],testSetNull->[assertEquals,assertNull],testEndsWith->[assertTrue,assertFalse],testRrdDescriptions->[assertEquals],testStartsWith->[assertTrue,assertFalse],testIsValidHostname->[assertTrue,assertF... | Test if hostname is valid. | This is not a valid domain name anyway, according to me. |
@@ -81,8 +81,10 @@ module TwoFactorAuthentication
handle_valid_otp_for_authentication_context
if decorated_user.identity_verified? || decorated_user.password_reset_profile.present?
redirect_to manage_personal_key_url
+ elsif MfaPolicy.new(current_user, user_session[:signing_up]).sufficient_f... | [PersonalKeyVerificationController->[generate_new_personal_key_for_verified_users_otherwise_retire_the_key_and_ensure_two_mfa->[create],password_reset_profile->[password_reset_profile]]] | Handles a valid OTP for the user. If the user is not authenticated or the password. | Not sure if this was the cleanest way to do this so suggestions welcome! The elsif/else statements are basically the same logic as `two_2fa_setup` in `application_controller.rb`, but I copied it over and changed the `else` to redirect to `two_factor_options_url`, because you don't want to see the `two_factor_options_su... |
@@ -138,8 +138,8 @@ public class ShiroAuthenticationService implements AuthenticationService {
@Override
public Collection<Realm> getRealmsList() {
String key = ThreadContext.SECURITY_MANAGER_KEY;
- DefaultWebSecurityManager defaultWebSecurityManager = (DefaultWebSecurityManager) ThreadContext.get(key);
-... | [ShiroAuthenticationService->[getAssociatedRoles->[getRealmsList,isAuthenticated,getPrincipal],extractPrincipal->[getPrincipal],isAuthenticated->[isAuthenticated],getMatchedUsers->[getRealmsList],getMatchedRoles->[getRealmsList]]] | This method returns the list of realms that are registered in the security manager. | Using a less specific class made it easier to test (hit a weird issue trying to create a DefaultWebSecurityManager and it seemed unnecessary) |
@@ -122,7 +122,7 @@ public final class SystemSessionProperties
public static final String QUERY_MAX_TOTAL_MEMORY_PER_NODE = "query_max_total_memory_per_node";
public static final String IGNORE_DOWNSTREAM_PREFERENCES = "ignore_downstream_preferences";
public static final String ITERATIVE_COLUMN_PRUNING = ... | [SystemSessionProperties->[getQueryMaxScanPhysicalBytes->[getSystemProperty,ofNullable],isUnwrapCasts->[getSystemProperty],isDictionaryAggregationEnabled->[getSystemProperty],isOptimizeTopNRowNumber->[getSystemProperty],getFilterAndProjectMinOutputPageRowCount->[getSystemProperty],isPushTableWriteThroughUnion->[getSyst... | The name of the session class. System session properties. | we could have a validation that all standard properties eg match `[a-z][a-z0-9]*(_[a-z0-9]+)*` |
@@ -190,6 +190,7 @@ func main() {
log.Fatal().Err(err).Msg("Failed to initialize ingress client")
}
+
meshCatalog := catalog.NewMeshCatalog(
namespaceController,
kubeClient,
| [StringVar,IssueCertificate,RegisterExitHandlers,BuildConfigFromFlags,CoreV1,Msgf,NewGrpc,NewADSServer,NewMeshSpecClient,NewProvider,Info,GetExpiration,IntVar,NewForConfigOrDie,Int,Error,Format,Secrets,New,NewConfigurator,GetConfigMap,StringVarP,Start,GetIssuingCA,NewClient,GetCertificateChain,GetRootCertificate,SetLog... | Initialize the object xds_discovery is a server that serves the aggregated discovery service. | file can be omitted. |
@@ -43,6 +43,10 @@ public class JmsConstants
public static final String CACHE_JMS_SESSIONS_PROPERTY = "cacheJmsSessions";
public static final String DISABLE_TEMP_DESTINATIONS_PROPERTY = "disableTemporaryReplyToDestinations";
public static final String RETURN_ORIGINAL_MESSAGE_PROPERTY = "returnOriginalMes... | [JmsConstants->[asList,unmodifiableSet,HashSet]] | JMS - related properties names. | Make more sense to have these constant declared on LdapJndiNameResolver |
@@ -197,7 +197,7 @@ namespace System.DirectoryServices.AccountManagement
default:
sb.Append(@"\\");
- sb.Append(c.ToString()); // \x --> \x
+ sb.Append(c); // \x --> \x
... | [SAMUtils->[Principal->[IsOfObjectClass],GetOSVersion->[IsOfObjectClass]]] | This method converts a PAPI query string to a regular expression string. | This call can be also changed to `Append(char)`, because its logic is simpler. |
@@ -54,7 +54,6 @@ plugins {
apply plugin: 'java'
sourceCompatibility=<%= JAVA_VERSION %>
targetCompatibility=<%= JAVA_VERSION %>
-// Until JHipster supports JDK 9
assert System.properties['java.specification.version'] == '1.8'
apply plugin: 'maven'
| [No CFG could be retrieved] | Repositories for the Unreal - bundled version of the NPM package. Package name version and description. | isn't this line preventing a project to built by gradle, if you try this with JDK 11? |
@@ -26,11 +26,11 @@ const maxMegabytes = 3008
var DefaultLambdaConfig = &lambdaConfig{
MemorySize: 128 * 1024 * 1024,
Timeout: time.Second * 3,
- Concurrency: 0, // unreserve
+ Concurrency: 5,
}
type lambdaConfig struct {
- Concurrency int `config:"concurrency" validate:"positive"`
+ Co... | [Validate->[Megabytes,Errorf],Unpack->[Deprecate,ParseBytes,Errorf],IsDigit] | Invite a single to an AWS Lambda function. Unpack unpacks a size from a human readable format into bytes. | I'm wondering, is 1000 as hard maximum in AWS? |
@@ -25,10 +25,12 @@ import com.fasterxml.jackson.databind.module.SimpleModule;
import com.google.common.collect.ImmutableList;
import com.google.inject.Binder;
import org.apache.druid.guice.JsonConfigProvider;
+import org.apache.druid.guice.annotations.LoadOn;
import org.apache.druid.initialization.DruidModule;
... | [MaterializedViewMaintenanceDruidModule->[getJacksonModules->[registerSubtypes,NamedType,of],configure->[bind]]] | Gets the list of Jackson modules for the NestedViewSupervisor. | Two nits. First, can we make the name a bit clearer? Maybe `DruidRole` or `RoleScope` or some such that gives a bit more of a hit of the purpose? Second, can we provide constants for the allowed loads? Will allow the compiler to catch fat-finger errors rather than trying to debug them at runtime: `"borker"` instead of ... |
@@ -170,7 +170,15 @@ namespace Dynamo.DSEngine
/// </summary>
public string Description
{
- get { return !String.IsNullOrEmpty(Summary) ? Summary : string.Empty; }
+ get { return !String.IsNullOrEmpty(Summary) ? Summary + "\n\n" + Signature : Signature; }
+ }
+
+ ... | [FunctionDescriptor->[Equals->[Equals],GetHashCode->[GetHashCode]]] | Relations of functions that can be used to construct a node object. This function returns the string representation of the UnqualifedClass. | Hi @aosyatnik, I'm expecting the `DynamoToolTip` inside `NodeView.xaml` to be changed -- add another `TextBlock` for `Signature` property below `TextBlock` for `Description`. Is that possible? I don't think we should change at this level. |
@@ -0,0 +1,15 @@
+class CreateMonthlySpAuthCounts < ActiveRecord::Migration[5.1]
+ disable_ddl_transaction!
+
+ def change
+ create_table :monthly_sp_auth_counts do |t|
+ t.string :issuer, null: false
+ t.integer :ial, null: false, limit: 1
+ t.string :year_month, null: false
+ t.integer :user_... | [No CFG could be retrieved] | No Summary Found. | Do we need to build the index concurrently index for a new table? I think we could drop that and allow this migration to run in a transaction. |
@@ -196,3 +196,7 @@ print '
}
});
});'."\n";
+// hide topmenus disabled
+if (!empty($conf->global->MAIN_BUTTON_HIDE_UNAUTHORIZED) && (!$user->admin)) {
+ print '$("li:has(.tmenudisabled)").hide();';
+}
| [transnoentities] | \ n. | there is already an option into setup - menus - other called MAIN_MENU_HIDE_UNAUTHORIZED May be we can move both option MAIN_BUTTON_HIDE_UNAUTHORIZED and MAIN_MENU_HIDE_UNAUTHORIZED into setup "Display" ? |
@@ -25,7 +25,7 @@ from mypyc.primitives.registry import (
name_ref_op('builtins.int',
result_type=object_rprimitive,
error_kind=ERR_NEVER,
- emit=simple_emit('{dest} = (PyObject *)&PyLong_Type;'),
+ emit=name_emit('(PyObject *)&PyLong_Type'),
is_borrowed=Tru... | [int_compare_op->[int_binary_op],int_unary_op,int_compare_op,int_binary_op] | Integer primitive ops. Create an object that represents an integer value of the specified type. | The cast makes this look potentially problematic later on. |
@@ -0,0 +1,14 @@
+import torch
+from nni.nas.pytorch.mutator import Mutator
+from nni.nas.pytorch.mutables import LayerChoice
+
+
+class NASBench201Mutator(Mutator):
+ def reset(self, matrix):
+ result = dict()
+ for mutable in self.mutables:
+ if isinstance(mutable, LayerChoice):
+ ... | [No CFG could be retrieved] | No Summary Found. | We don't need a mutator here. |
@@ -413,6 +413,14 @@ int dt_init(int argc, char *argv[], const int init_gui, lua_State *L)
}
#endif
+ if(!dt_openmp_init_stacksize())
+ {
+ fprintf(stderr, "[dt_init] your system uses a low default stacksize and we could not set\n");
+ fprintf(stderr, "[dt_init] the OMP_STACKSIZE environment variable to %... | [No CFG could be retrieved] | finds the n - th user id and if it is not found it is assumed that set_env = TRUE if DARKTABLE_SHAREDIR is not already in there. | If you're going to make dt complain about a low value here, then you should return the detected value from dt_openmp_init_stacksize() so that you can provide the user with information about how far off the minimum they are. is SAFESTACKSIZE a minimum or a maximum? This information should also be provided to the user. |
@@ -27,6 +27,9 @@ import org.reactivestreams.Publisher;
*/
public abstract class AbstractFilteringMessageProcessor extends AbstractInterceptingMessageProcessor {
+ public static final String FILTER_ON_UNACCEPTED_NOT_STOP_PARENT_FLOW =
+ SYSTEM_PROPERTY_PREFIX + "filterOnUnacceptedNotStopParentFlow";
+
/**... | [AbstractFilteringMessageProcessor->[handleUnaccepted->[process]]] | Abstract filtering message processor. Process the next . | Why add this flag in 4.x? |
@@ -57,10 +57,11 @@ export class SubscriptionPlatform {
pingback(unusedSelectedPlatform) {}
/**
- * Tells if this platform supports the current viewer.
- * @return {boolean}
+ * Tells if the platform supports a score factor
+ * @param {string} unusedFactor
+ * @return {!Promise<number>}
*/
- supp... | [No CFG could be retrieved] | Returns true if the current viewer supports it. | maybe rename this to "getSupportedScoreFactor" to make this method more clear (also in other places it is used) |
@@ -20,9 +20,9 @@ import shutil
import sys
import importlib
import paddle.dataset
-import cPickle
+import pickle
import glob
-import cPickle as pickle
+import pickle as pickle
__all__ = [
'DATA_HOME',
| [fetch_all_recordio->[must_mkdirs],download->[md5file],convert->[write_data,reader],must_mkdirs] | Creates a new object. Download a file from a given URL and return its hash. | Why this file has two imports. |
@@ -3,6 +3,7 @@ package grpcserver
import (
"context"
"strings"
+ "time"
"github.com/golang/protobuf/proto"
gpStruct "github.com/golang/protobuf/ptypes/struct"
| [GetRunsCounts->[GetRunsCounts],GetSuggestions->[GetSuggestions],GetNodesCounts->[GetNodesCounts],GetPolicyCookbooks->[GetPolicyCookbooks]] | NewCfgMgmtServer returns a new server instance based on the provided client GetCookbooks returns a list of response. Cookbooks that are locked by the. | This contains the main change for this PR. Instead of just checking if the node exists with the allowed projects, we are now pulling the projects that are tagged on the associated node. |
@@ -440,7 +440,7 @@ func (sg *stepGenerator) generateSteps(event RegisterResourceEvent) ([]Step, res
// If the user requested only specific resources to update, and this resource was not in
// that set, then do nothin but create a SameStep for it.
- if !sg.isTargetedForUpdate(urn) {
+ if !sg.isTargetedForUpda... | [AnalyzeResources->[getProviderResource],GenerateSteps->[isTargetedUpdate],generateSteps->[isTargetedForUpdate,isTargetedReplace],determineAllowedResourcesToDeleteFromTargets->[getTargetIncludingChildren],diff->[isTargetedReplace,providerChanged],calculateDependentReplacements->[loadResourceProvider],generateStepsFromD... | generateSteps generates all the steps that need to be performed for the given resource event This function is called by the checkpoint manager to populate the checkpoint file with the new state object Check if the resource has a known identifier and if it has an ImportID look at that Issue check errors for a resource T... | Wondering what's goal.Dependencies here in the context, immediate or transitive dependencies of resource identified by urn, or something else? How does it relate to ResourceGraph? Also I have a premonition that the engine on the update path observes the dependency graph incrementally; does it observe enough of it to do... |
@@ -121,6 +121,15 @@ module Engine
])
end
+ def action_processed(action)
+ super
+
+ case action
+ when Action::BuyCompany
+ mine_update_text(action.entity) if action.company == imc && action.entity.corporation?
+ end
+ end
+
def revenue_for(route,... | [G18CO->[revenue_str->[east_west_bonus],par_prices->[par_prices]]] | Creates a new auction round with no action. | When the IMC is bought in, the text on the Ability needs to be updated to reflect the change in mine value and total. |
@@ -638,3 +638,18 @@ def _gl_score(estimators, scoring, X, y):
score = np.zeros(shape, dtype)
score[ii, jj, ...] = _score
return score
+
+
+def _fix_auc(scoring, y):
+ from sklearn.preprocessing import LabelEncoder
+ # This fixes sklearn's inability to compute roc_auc when y not... | [_sl_transform->[transform],_gl_transform->[transform],_SearchLight->[decision_function->[_transform],score->[_check_Xy],predict_proba->[_transform],transform->[_transform],predict->[_transform]],_gl_score->[score],_sl_fit->[fit],_sl_score->[score],_GeneralizationLight->[decision_function->[_transform],score->[_check_X... | Score _GeneralizationLight in parallel. Predict and score each slice of data. | can you avoid the 4 if and use just one with some 'and' thx |
@@ -43,7 +43,7 @@ class LeNetDygraph(fluid.dygraph.Layer):
class TestLayerChildren(unittest.TestCase):
- def test_apply_init_weight(self):
+ def func_apply_init_weight(self):
with fluid.dygraph.guard():
net = LeNetDygraph()
net.eval()
| [TestLayerChildren->[test_apply_init_weight->[LeNetDygraph]]] | Test apply init weight. | Make sure all these tests run in eager mode with correct res |
@@ -152,8 +152,15 @@ public class ClusterRestApi {
return new JsonResponse(Response.Status.OK, "", nodes).build();
}
- private String formatIntpLink(String intpName) {
- return String.format("<a href=\"/#/cluster/%s\">%s</a>", intpName, intpName);
+ private String formatDateTime(Object localDateTime) {
+... | [ClusterRestApi->[getClusterAddress->[getClusterAddress]]] | This method returns a list of nodes that are not yet in the cluster. This method is used to calculate the best sort property for the cluster. This method returns a JSON response with a list of nodes that can be found in the cluster. | i think the function should be strongly types? one approach is `private String formatDateTime(LocalDateTime localDateTime)` and then `String dateTime = formatDateTime((LocalDateTime)serverStartTime);` I think this will be more maintainable. |
@@ -208,7 +208,9 @@ public class ConfigValidationUtils {
List<URL> urls = UrlUtils.parseURLs(address, map);
for (URL url : urls) {
-
+ if (url == null) {
+ continue;
+ }
url = UR... | [ConfigValidationUtils->[validateReferenceConfig->[validateAbstractInterfaceConfig],checkParameterName->[checkNameHasSymbol],validateServiceConfig->[validateAbstractInterfaceConfig],checkMultiExtension->[checkMultiExtension],checkHost->[checkName]]] | load registries. | Here maybe fixed by #8208 |
@@ -67,7 +67,8 @@ func (i *LibpodAPI) GetVolumes(call iopodman.VarlinkCall, args []string, all boo
Labels: v.Labels(),
MountPoint: v.MountPoint(),
Name: v.Name(),
- Options: v.Options(),
+ // TODO change types here to be correct
+ //Options: v.Options(),
}
volumes = append(volume... | [VolumeRemove->[RemoveVolumes,ReplyErrorOccurred,Error,ReplyVolumeRemove],GetVolumes->[GetAllVolumes,Error,Options,ReplyGetVolumes,Name,GetVolume,Driver,Labels,ReplyErrorOccurred,MountPoint],VolumesPrune->[PruneVolumes,ReplyVolumesPrune,Error],VolumeCreate->[ReplyVolumeCreate,Error,WithVolumeOptions,NewVolume,Name,With... | GetVolumes gets all volumes from the container. | Don't we need the options as well? |
@@ -224,12 +224,12 @@ namespace Dynamo.Nodes
if (string.IsNullOrEmpty(fullCategoryName))
return string.Empty;
- var catName = fullCategoryName.Replace(Configurations.CategoryDelimiter.ToString(), " " + Configurations.ShortenedCategoryDelimiter + " ");
+ var catName ... | [Utilities->[NormalizeAsResourceName->[Append,Empty,Where,IsNullOrWhiteSpace,ToString,IsLetterOrDigit,Length],LoadTraceDataFromXmlDocument->[SessionTraceDataXmlTag,Any,DocumentElement,GetAttribute,ToList,ElementAt,ChildNodes,NodeIdAttribName,Parse,Add,Equals],PreprocessTypeName->[IsNullOrEmpty,Remove,Replace,Substring,... | ShortenCategoryName - Shorten the category name. | Can we not keep `ShortenedCategoryDelimiter` (which is a `char`) instead of doing this `ToCharArray` method call (which is more expensive)? |
@@ -454,7 +454,13 @@ func handleSBSSingle(ctx context.Context, g *libkb.GlobalContext, teamID keybase
}
// Send chat welcome message
- if !team.IsImplicit() {
+ if team.IsImplicit() {
+ assertion := fmt.Sprintf("%s@%s", string(invite.Name), ityp)
+ g.Log.CDebugf(ctx,
+ "sending resolution message for s... | [SecureByteArrayEq,V2,GetFastTeamLoader,FindActiveInviteByID,WithForcePoll,CancelInvite,CompleteInviteByID,CombineErrors,HandleTeamExit,Eq,PurgeCache,GetEKLib,GenerateAcceptanceKey,WithLogTag,AddMemberBySBS,GenerateTeamInviteID,GetTeambotMemberKeyer,RunEngine2,ForceRepollUntil,myRole,C,WithUID,CDebugf,IsOpen,Warning,Ch... | assertCanAcceptKeybaseInvite checks if the user has the right role and if so sends HandleOpenTeamAccessRequest handles open team access requests for the given chain UIDs. | this is no good. what about email? |
@@ -19,8 +19,13 @@ type queues struct {
maxUserQueueSize int
- // Number of connections per querier.
- querierConnections map[string]int
+ // How long to wait before removing a querier which has got disconnected
+ // but hasn't notified about a graceful shutdown.
+ forgetDelay time.Duration
+
+ // Tracks queriers... | [getOrAddQueue->[ShuffleShardSeed],removeQuerierConnection->[SearchStrings,recomputeUserQueriers],addQuerierConnection->[Strings,recomputeUserQueriers],Intn,New,NewSource] | queuesimport imports a struct from CiliumProject. Find existing or new queue for a given user. | suggestion: I would prefer to move `forgetDelay` out of `queues` struct, and pass `forgetTime` (when to forget given querier, or zero time if immediately) to `removeQuerierConnection` and only `threshold` to `forgetDisconnectedQueriers`. It's a small change, but helps to minimize change to the `queues` struct, which is... |
@@ -96,7 +96,8 @@ public class GcpApiSurfaceTest {
classesInPackage("org.apache.beam"),
classesInPackage("org.apache.commons.logging"),
classesInPackage("org.codehaus.jackson"),
- classesInPackage("org.joda.time"));
+ classesInPackage("org.joda.time"),
+ ... | [GcpApiSurfaceTest->[testGcpApiSurface->[pruningPattern,of,assertThat,getPackage,equalTo,containsOnlyClassesMatching,classesInPackage,getClassLoader]]] | Tests that the api surface is in a Google Cloud. Checks that all the possible classes in the apiSurface are matched by the given matchers. | What is this dependency? Does it need to be on the API surface? |
@@ -20,12 +20,13 @@ namespace System.Net.NetworkInformation
private const int MaxIpHeaderLengthInBytes = 60;
private static bool SendIpHeader => OperatingSystem.IsMacOS();
private static bool NeedsConnect => OperatingSystem.IsLinux();
+ private static bool IsOSXLike = OperatingSystem.I... | [Ping->[SendIcmpEchoRequestOverRawSocketAsync->[TryGetPingReply],PingReply->[TryGetPingReply]]] | Send a ping request over the core socket. | This will not work on watchOS (lack of Sockets support). Instead, we should mark the whole assembly to throw PNSE on watchOS |
@@ -208,8 +208,8 @@ END
"cr1:\n weight: monstrously heavy\n"}
assert_response :redirect
- assert_not_nil set_the_flash.to(
- I18n.t('rubric_criteria.upload.error') + ' ' + 'cr1')
+ assert_not_nil set_flash.to(
+ t('rubric_criteria.upload.error') + ' cr1')
@... | [RubricsControllerTest->[position,find,size,level_4_description,render_template,post_as,level_1_description,fixture_file_upload,rubric_criteria,assert_raise,assignment,put,should,level_2_description,to,find_by_assignment_id_and_rubric_criterion_name,assert_equal,respond_with,level_1_name,body,returns,level_3_name,assig... | Checks if the user has deals with bad weight on yaml file check if the user has provided a specific criterion. | Indent the first parameter one step more than the previous line. |
@@ -87,6 +87,7 @@ import org.apache.nifi.stream.io.util.TextLineDemarcator.OffsetInfo;
@WritesAttribute(attribute = "fragment.count", description = "The number of split FlowFiles generated from the parent FlowFile"),
@WritesAttribute(attribute = "segment.original.filename ", description = "The filename of the... | [SplitText->[onTrigger->[process->[getMessage,error,computeHeader,debug,add,get,set,nanoTime,isDebugEnabled,nextSplit,getBytes,TextLineDemarcator],size,AtomicBoolean,get,generateSplitFlowFiles,read,toString,isEmpty,InputStreamCallback,copyAttributesToOriginal,transfer],computeHeader->[getCrlfLength,getLength,IllegalSta... | A SplitText class is used to split text from a given parent FlowFile into a new. | I would again add a description here that indicates that it's not buffering the content in memory but rather just storing the FlowFile w/ its attributes in memory and that if generating too many splits, a two-phase approach may be necessary. |
@@ -9,6 +9,7 @@ import (
"github.com/ethereum/go-ethereum/core/types"
"github.com/ethereum/go-ethereum/rpc"
"github.com/smartcontractkit/chainlink/utils"
+ "math/big"
)
// EthClient holds the CallerSubscriber interface for the Ethereum blockchain.
| [UnmarshalJSON->[ParseUint,HexToHash,Unmarshal],Unconfirmed->[EmptyHash],GetTxReceipt->[Call,String],GetBlockNumber->[HexToUint64,Call],GetNonce->[HexToUint64,Call,Hex],Subscribe->[EthSubscribe,Background],SendRawTx->[Call]] | GetNonce returns the nonce for a given address. GetBlockNumber returns the block number of the current network. | Hey @jordanbonilla, you should set up whatever text editor/IDE you're using to automatically run `gofmt` for you so things like this don't slip through. |
@@ -20,14 +20,14 @@ import org.junit.Test;
*/
public class HibernateSearchPropertyHelperTest {
- @Rule
- public SearchFactoryHolder factoryHolder = new SearchFactoryHolder(TestEntity.class);
-
private HibernateSearchPropertyHelper propertyHelper;
@Before
public void setup() {
- propertyHelpe... | [HibernateSearchPropertyHelperTest->[convertToPropertyType->[convertToPropertyType]]] | This method is called before the application is started. | @fax4ever Unless I'm mistaken, you're not closing the search mapping, which leads to the test failures in CI mentioning "leaked threads". There are other test failures mentioning thread leaks, maybe you should have a look at them? The name of the test generally appears somewhere in the stack trace. |
@@ -151,7 +151,7 @@ namespace Microsoft.Xna.Framework
protected override void CreateFrameBuffer()
{
-#if true
+#if !GL20
try
{
GLContextVersion = GLContextVersion.Gles2_0;
| [AndroidGameWindow->[OnUpdateFrame->[OnUpdateFrame,ResetElapsedTime],OnTouchEvent->[UpdateTouchPosition,OnTouchEvent],CreateFrameBuffer->[Initialize,CreateFrameBuffer],OnRenderFrame->[OnRenderFrame]]] | Create a frame buffer with the specified name. | I've been using "ES11" as my macro |
@@ -324,12 +324,16 @@ class Document(NotificationsMixin, models.Model):
@cache_with_field('body_html')
def get_body_html(self, *args, **kwargs):
- html = self.rendered_html and self.rendered_html or self.html
+ html = self.rendered_html or self.html
sections_to_hide = ('Quick_Links', ... | [Document->[_get_new_parent->[valid_slug_parent],get_full_url->[get_absolute_url],get_redirect_document->[from_url,get_redirect_url],_raise_if_collides->[_existing],acquire_translated_topic_parent->[save],parent_trees_watched_by->[tree_is_watched_by],render->[regenerate_cache_with_fields],_post_move_redirects->[Documen... | Return the body of the page as a string. | Sorry, this is not really necessary for this PR. It just bugged me! |
@@ -15,7 +15,7 @@ namespace Content.Server.Cargo
{
Id = id;
CurrentOrderSize = 0;
- MaxOrderSize = 20;
+ MaxOrderSize = 25;
}
public int Id { get; private set; }
| [CargoOrderDatabase->[Clear->[Clear],ApproveOrder->[AddOrder]]] | Creates a CargoOrderDatabase object that represents a single Cargo order. Adds an order to the list of Cargo orders. | Why did you change this? |
@@ -14,6 +14,14 @@ admin.autodiscover()
badger.autodiscover()
+# Handle 404 and 500 errors
+def _error_page(request, status):
+ """Render error pages with jinja2."""
+ return render(request, '%d.html' % status, status=status)
+handler403 = lambda r: _error_page(r, 403)
+handler404 = lambda r: _error_page(r, ... | [_error_page->[render],_error_page,include,lstrip,redirect,autodiscover,patterns,url,cache_page,staticfiles_urlpatterns] | Displays a single object. Get a list of all attachment IDs and urls. | Can I ask why these are now here? Aren't we covering this in `settings.py`? |
@@ -180,6 +180,13 @@ class PythonAPI(object):
cstr = self.context.insert_const_string(self.module, name)
return self.builder.call(fn, [dic, cstr])
+ def dict_getitem(self, dic, name):
+ """Returns a borrowed reference
+ """
+ fnty = Type.function(self.pyobj, [self.pyobj, self... | [PythonAPI->[raise_exception->[err_set_object],object_dump->[call],object_str->[call],from_tuple->[tuple_new,tuple_setitem,from_native_value],raise_missing_name_error->[err_set_string],list_pack->[list_setitem,list_new,incref],number_subtract->[_call_number_operator],extract_record_data->[call,_get_function],release_re... | Returns a borrowed reference to a string in a dictionary. | This docstring doesn't really describe what the function does. How about "Lookup _name_ inside dict. Returns a borrowed reference"? |
@@ -255,6 +255,12 @@ func (ctx *Context) RegisterResource(
// Create resolvers for the resource's outputs.
res := makeResourceState(custom, props)
+ providers := mergeProviders(t, opts...)
+
+ for k, v := range providers {
+ res.providers[k] = v
+ }
+
// Kick off the resource registration. If we are actually ... | [ReadResource->[ReadResource,DryRun],getOpts->[URN],Invoke->[Invoke],resolve->[resolve],prepareResourceInputs->[DryRun],RegisterResourceOutputs->[beginRPC,RegisterResourceOutputs,DryRun,endRPC],Close->[Close],resolveProviderReference->[ID,URN],RegisterResource->[DryRun,RegisterResource]] | RegisterResource registers a resource with the context. RegisterResource registers a resource with the server. | No need to copy--might as well just slam the returned map into `res`. |
@@ -119,14 +119,15 @@ namespace System.Windows.Forms
/// Called when the mainForm is closed. The default implementation
/// of this will call ExitThreadCore.
/// </summary>
- protected virtual void OnMainFormClosed(object sender, EventArgs e) => ExitThreadCore();
+ protected v... | [ApplicationContext->[Dispose->[Dispose],OnMainFormDestroy->[OnMainFormClosed],OnMainFormClosed->[ExitThreadCore]]] | OnMainFormClosed - - This is called when the main form is closed. | needs to be nullable in order to be accepted as `EventHandler`, but there is no way to call `HandleDestroyed` with a null sender |
@@ -124,6 +124,8 @@ namespace Dynamo.DSEngine
/// </summary>
private string summary;
+ private BitmapImage iconSmall;
+
public FunctionDescriptor(string name, IEnumerable<TypedParameter> parameters, FunctionType type)
: this(null, null, name, parameters, null, type)
... | [FunctionDescriptor->[Equals->[Equals],GetHashCode->[GetHashCode],ToString],FunctionGroup->[Equals->[Equals],AddFunctionDescriptor->[Equals],GetHashCode->[GetHashCode]],LibraryServices->[PreloadLibraries->[PreloadLibraries,Reset],AddImportedFunctions->[AddFunctionDescriptor],AddBuiltinFunctions->[AddFunctionDescriptor]... | Creates a FunctionDescriptor for a given node. The assembly of the function. | I tend to think we should rename `iconSmall` to `smallIcon` (and all other parameters, methods, etc.). |
@@ -0,0 +1,16 @@
+<div class="modal fade" id="deleteRepositoryColumn" tabindex="-1" role="dialog" aria-labelledby="deleteRepositoryColumnLabel">
+ <div class="modal-dialog" role="document">
+ <div class="modal-content">
+ <div class="modal-header">
+ <button type="button" class="close" data-dismiss="mod... | [No CFG could be retrieved] | No Summary Found. | You added new partial `views/repository_columns/_delete_column_modal.html.erb`, so you should remove the old one `app/views/repositories/_delete_column_modal.html.erb`. |
@@ -1681,7 +1681,11 @@ def create_info(ch_names, sfreq, ch_types=None, montage=None):
raise ValueError('ch_types and ch_names must be the same length '
'(%s != %s)' % (len(ch_types), nchan))
info = _empty_info(sfreq)
- info['meas_date'] = np.array([0, 0], np.int32)
+ # The ... | [write_info->[write_meas_info],write_meas_info->[_check_consistency],create_info->[copy,_update_redundant,_check_consistency],_empty_info->[Info,_update_redundant,_check_consistency],Info->[copy->[Info],__repr__->[_summarize_str]],_simplify_info->[Info,_update_redundant],read_meas_info->[_read_dig_fif,read_bad_channels... | Create a basic Info instance suitable for use with create_raw. Compute a single nanomon index for a given set of channels. Get info from a list of montages. | Instead of triaging based on system, let's just always do `86400, 86400`. It's better if we don't have values based on the system someone is using. |
@@ -755,6 +755,8 @@ if (! empty($conf->propal->enabled) && $user->rights->propal->lire)
$companystatic->client=$obj->client;
$companystatic->code_client = $obj->code_client;
$companystatic->code_fournisseur = $obj->code_fournisseur;
+ $companystatic->entity = $objp-... | [plimit,free,query,getNomUrl,loadLangs,trans,num_rows,fetch_object,jdate,LibStatut,getDocumentsLink,close,getLibCustProspStatut,load] | Generate HTML for a single element in the multidir prints a sequence of missing objects. | $objp is object from other query |
@@ -822,7 +822,9 @@ public class Wallet {
public AssetIssueList getAssetIssueList() {
AssetIssueList.Builder builder = AssetIssueList.newBuilder();
- dbManager.getAssetIssueStoreFinal().getAllAssetIssues()
+ getAssetIssueStoreFinal(dbManager.getDynamicPropertiesStore(),
+ dbManager.getAssetIssueS... | [Wallet->[getMerkleTreeVoucherInfo->[updateWitnesses,getBlockNumber,createWitness,validateInput,getFullNodeAllowShieldedTransaction,updateLowWitness],getBlockNumber->[getFullNodeAllowShieldedTransaction,getBlockNumber],getAccountNet->[setAssetNetLimit],queryNoteByIvk->[getBlocksByLimitNext],getAddress->[getAddress],get... | Get the list of all asset issues. | Please use chainBaseManager instead of dbManager. |
@@ -164,10 +164,10 @@ class CheckVersion:
logger.log(u"We can't proceed with the update. New update has a old DB version. It's not possible to downgrade", logger.ERROR)
return False
else:
- logger.log(u"We can't proceed with the update. Unabl... | [CheckVersion->[list_remote_branches->[list_remote_branches],safe_to_update->[showupdate_safe,postprocessor_safe,db_safe],update->[update]],SourceUpdateManager->[need_update->[_find_installed_branch,_check_github_for_update],set_newest_text->[get_update_url],__init__->[_find_installed_branch,get_github_repo,get_github_... | Checks if the current object is safe to update. | What's the difference between `repr` and `ex`? Why use one rather than the other? |
@@ -456,7 +456,9 @@ export default class LargeVideoManager {
if (presenceLabelContainer.length) {
ReactDOM.render(
<Provider store = { APP.store }>
- <PresenceLabel participantID = { id } />
+ <I18nextProvider i18n = { i18next }>
+ ... | [No CFG could be retrieved] | Resizes all containers of a given type. Removes the messages about the displayed participant s presence status. | Isn't there a central place to put this I18nextProvider component into so then all other pages inherit it? |
@@ -16,7 +16,7 @@
See the License for the specific language governing permissions and
limitations under the License.
-%>
-import { browser, element, by, ExpectedConditions as ec } from 'protractor';
+import { browser, element, by, ExpectedConditions } from 'protractor';
import { NavBarPage, SignInPage<%_ if (au... | [No CFG could be retrieved] | Reads an object from the page object and imports it into the page objects. Missing element in page. | Why make this change? I prefer to type `ec` over `ExpectedConditions`. |
@@ -43,7 +43,7 @@ class NpmResolver(Subsystem, NodeResolverBase):
'including node_remote_module and other node dependencies. However, this is '
'not fully supported.')
self._emit_package_descriptor(node_task, target, results_dir, node_paths)
- result, npm_install = node_task.... | [NpmResolver->[resolve_target->[get_package_manager_for_target,reference,execute_npm,info,execute_yarnpkg,_copy_sources,_emit_package_descriptor,pushd,format,warn,exists,TaskError],_emit_package_descriptor->[dump,reference,debug,pop,isfile,node_path,TaskError,has_key,format,join,open,load,is_node_module],register_optio... | Resolve dependencies for a given target. Execute pkg_command and return the exit code. | Should this be exposed as an option on the task? |
@@ -282,6 +282,8 @@ def mixed_norm(evoked, forward, noise_cov, alpha, loose=0.2, depth=0.8,
that are parallel (tangential) to the cortical surface. If loose
is 0 or None then the solution is computed with fixed orientation.
If loose is 1, it corresponds to free orientations.
+ Default ... | [tf_mixed_norm->[_make_sparse_stc,_reapply_source_weighting,_prepare_gain,_make_dipoles_sparse,_compute_residual,_window_evoked],mixed_norm->[_reapply_source_weighting,_prepare_gain,_make_sparse_stc,_compute_residual,_make_dipoles_sparse],_prepare_gain->[_prepare_gain_column],_prepare_gain_column->[_prepare_weights]] | Mixed - norm estimate. Parameters for the algorithm to use. Computes a single residue of the n - th residue in the network. Compute the active dipoles given a mixed - norm model. Computes a from the active set. | These changes should go in #4312 |
@@ -80,6 +80,12 @@ type Resource struct {
Parent resource.URN `json:"parent,omitempty" yaml:"parent,omitempty"`
// Protect is set to true when this resource is "protected" and may not be deleted.
Protect bool `json:"protect,omitempty" yaml:"protect,omitempty"`
+ // Status has the mutation status of this resource
... | [No CFG could be retrieved] | Custom is true when the resource should be deleted during the next provisioning. Name string json or yaml. | Note that I think we use camelCase in other places for JSON/YAML serialized properties. I myself am a fan of underscore_case for such things, but we should be consistent. Can you check w/ @chrsmith and @pgavlin? |
@@ -114,6 +114,7 @@ class QueryStreamWriter implements StreamingOutput {
}
private void write(final OutputStream output, final StreamedRow row) throws IOException {
+ System.out.println("Writing row: " + row);
objectMapper.writeValue(output, row);
output.write(",\n".getBytes(StandardCharsets.UTF_8)... | [QueryStreamWriter->[drain->[buildRow,write],close->[close],write->[write],outputException->[write]]] | Writes a row to the output stream. | did you mean to commit this? |
@@ -414,7 +414,7 @@ public class SqlQueryExecution
// plan query
PlanNodeIdAllocator idAllocator = new PlanNodeIdAllocator();
- LogicalPlanner logicalPlanner = new LogicalPlanner(stateMachine.getSession(), planOptimizers, idAllocator, metadata, sqlParser, statsCalculator, costCalculator, stat... | [SqlQueryExecution->[SqlQueryExecutionFactory->[createQueryExecution->[getQueryId,SqlQueryExecution]],recordHeartbeat->[recordHeartbeat],waitForMinimumWorkers->[waitForMinimumWorkers],getQueryInfo->[getQueryId],getExecutionStartTime->[getExecutionStartTime],addStateChangeListener->[addStateChangeListener],getUserMemory... | analyze query - do analyze query - do fragmented plan - do analyze query - do. | should it based to `SqlQueryExecution` constructor? |
@@ -6692,6 +6692,7 @@ func init() {
autoConvert_api_ObjectReference_To_v1beta3_ObjectReference,
autoConvert_api_Parameter_To_v1beta3_Parameter,
autoConvert_api_PersistentVolumeClaimVolumeSource_To_v1beta3_PersistentVolumeClaimVolumeSource,
+ autoConvert_api_PodSecurityContext_To_v1beta3_PodSecurityContext,
... | [Convert_unversioned_Time_To_unversioned_Time,AddGeneratedConversionFuncs,StatusReason,ResourceName,BuildTriggerType,NamespacePhase,TLSTerminationType,InsecureEdgeTerminationPolicyType,DeploymentTriggerType,DefaultingInterface,BuildPhase,StorageMedium,RestartPolicy,TypeOf,Protocol,DNSPolicy,Convert,FinalizerName,RouteI... | Convert all api sources to v1beta3. Converts all of the methods in the Swagger spec to the corresponding v1beta3 spec. | also interesting, this is still generated and registered but not used. Same thing occurs for the other custom conversion functions in v1beta3/conversion.go |
@@ -82,6 +82,7 @@ func BindMasterArgs(args *MasterArgs, flags *pflag.FlagSet, prefix string) {
flags.Var(&args.DNSBindAddr, prefix+"dns", "The address to listen for DNS requests on.")
flags.BoolVar(&args.PauseControllers, prefix+"pause", false, "If true, wait for a signal before starting the controllers.")
+ flag... | [GetAssetPublicAddress->[GetMasterPublicAddress],BuildSerializeableMasterConfig->[GetPolicyFile],GetMasterPublicAddress->[GetMasterAddress],GetEtcdPeerAddress->[GetEtcdAddress],Validate->[Validate],GetEtcdAddress->[GetMasterAddress]] | BindMasterArgs binds the given flags to the given master args. NewDefaultMasterArgs creates a new masterArgs object with default values set. | I still don't think this is commonly changed enough to warrant flag exposure. @smarterclayton, wdyt? |
@@ -36,4 +36,16 @@ public interface VaultClient {
VaultDatabaseCredentials generateDatabaseCredentials(String token, String databaseCredentialsRole);
+ VaultTransitEncrypt encrypt(String token, String keyName, VaultTransitEncryptBody body);
+
+ VaultTransitDecrypt decrypt(String token, String keyName, Va... | [No CFG could be retrieved] | Generate database credentials for vault. | Please keep these 3 methods in the Test VaultClient for now, same as we did it earlier for other Vault methods like init since they are not used in the main source. |
@@ -1506,7 +1506,7 @@ class Installer
if (!$this->optimizeAutoloader) {
// Force classMapAuthoritative off when not optimizing the
// autoloader
- $this->setClassMapAuthoritative(false);
+ $this->setClassMapAuthoritative();
}
return $this;
| [Installer->[disablePlugins->[disablePlugins],setClassMapAuthoritative->[setOptimizeAutoloader]]] | Set whether or not to optimize the autoloader. | I would keep it here, as this makes the code much easier to understand |
@@ -89,6 +89,14 @@ final class SerializerContextBuilder implements SerializerContextBuilderInterfac
unset($context[DocumentationNormalizer::SWAGGER_DEFINITION_NAME]);
+ if (
+ isset($this->patchFormats['json'])
+ && !isset($context['skip_null_values'])
+ && in_array(... | [SerializerContextBuilder->[createFromRequest->[getAttribute,create,getMethod,getRequestUri,get,getTypedOperationAttribute,getUri]]] | Creates a new context from a request. Get the context for a sub - resource. | does this mean it will not be possible to null a value during a PATCH? Is this standard PATCH semantics? |
@@ -0,0 +1,13 @@
+package jenkins;
+
+import org.junit.Test;
+
+class Junit4TestsRanTest {
+
+ @Test
+ void anything() {
+ // intentionally blank.
+ // we just want a test that runs with junit 4 so that if tests get skipped due to the introduction of jupiter engine we are alerted
+ }
+
+}
| [No CFG could be retrieved] | No Summary Found. | it helps if the test class is `public` |
@@ -61,7 +61,15 @@ class WPSEO_Utils {
$software = sanitize_text_field( wp_unslash( $_SERVER['SERVER_SOFTWARE'] ) );
- return stripos( $software, 'apache' ) !== false;
+ if ( stripos( $software, 'apache' ) !== false ) {
+ $abool = true;
+ }
+ elseif ( stripos( $software, 'litespeed' ) !== false ) {
+ $ab... | [WPSEO_Utils->[get_site_name->[get_site_name],get_title_separator->[get_title_separator],standardize_whitespace->[standardize_whitespace],is_yoast_seo_page->[is_yoast_seo_page],strip_shortcode->[strip_shortcode],is_valid_datetime->[is_valid_datetime]]] | Checks if the current PHP server is Apache. | PHPCS failed because "else" isn't enclosed in the curly braces. Please check travis log. |
@@ -60,5 +60,6 @@ PYLINT_ACCEPTABLE_FAILURES = [
"azure-messaging-nspkg",
"azure-agrifood-farming",
"azure-ai-language-questionanswering",
- "azure-ai-language-conversations"
+ "azure-ai-language-conversations",
+ "azure-eventhub"
]
| [No CFG could be retrieved] | azure - messaging - nspkg. | Could we open an issue to re-enable any analysis/test passes we've opted out of? |
@@ -286,7 +286,9 @@ namespace Microsoft.Extensions.Primitives
object value = _values;
if (value is string[] values)
{
- return values;
+ var valuesCopy = new string[values.Length];
+ values.CopyTo(valuesCopy, 0);
+ return... | [StringValues->[IndexOf->[IndexOf],GetHashCode->[GetHashCode],CopyTo->[CopyTo],IsNullOrEmpty->[IsNullOrEmpty],GetStringValue->[ToString],IEnumerator->[GetEnumerator],Equals->[Equals],Contains->[IndexOf],GetEnumerator->[GetEnumerator],Equals]] | Get array value. | FYI the canonical way to write this is `T[] copy = (T[])oldArray.Clone();`. |
@@ -22,8 +22,9 @@ def setup_args(parser=None):
if parser is None:
parser = ParlaiParser(True, True)
# Get command line arguments
- parser.add_argument('-ne', '--num-examples', type=int, default=10)
- parser.add_argument('-mdl', '--max-display-len', type=int, default=1000)
+ parser.add_argume... | [setup_args->[ParlaiParser,set_defaults,add_argument],display_data->[print,RepeatLabelAgent,num_episodes,epoch_done,num_examples,create_task,format,parley,range,display],setup_args,parse_args,seed,display_data] | Setup command line arguments for the task. | changing this flag just here could be confusing because we use the same name elsewhere but with '-' instead of '_' (see for instance scripts/display_model.py, scripts/eval_model.py, scripts/convert_data_to_parlai_format.py, etc). maybe we should change it everywhere or nowhere? |
@@ -1350,7 +1350,7 @@ class BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin,
return new
@verbose
- def save(self, fname, split_size='2GB', fmt='single', verbose=True):
+ def save(self, fname, split_size='2GB', fmt='single', overwrite=False, verbose=True):
"""Save epochs in a fif ... | [_save_split->[_pack_reject_params],BaseEpochs->[equalize_event_counts->[drop,drop_bad],plot_drop_log->[plot_drop_log],copy->[_set_times],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_good_epoch,_project_epoch],get_data->[_get_data],_compute_aggregate->[fun],drop_bad->[_reject_setup],crop->[_set_times],save... | Save a sequence of epochs in a FITS file. Save the split data to a file. | This would be a change of behavior, no? Previously, people who used `epochs.save` consecutively on their scripts would not have their scripts running anymore |
@@ -74,9 +74,12 @@ module Repository
index = repo.index
index.add(path: 'README.md', oid: oid, mode: 0100644)
index.write
- Rugged::Commit.create(repo,
- commit_options(repo, 'Markus',
- 'Initial commit and add readme.'))
+ ... | [GitRevision->[initialize->[get_repos]],GitRepository->[delete_bulk_permissions->[add_user],expand_path->[expand_path],remove_user->[add_user],add_file->[path_exists_for_latest_revision?],latest_revision_number->[get_revision_number],remove_file->[commit_options,create],create->[commit_options,create],access->[open],ma... | Creates a repository at the given path and returns the node ID. | Align the parameters of a method call if they span more than one line.<br>Tab detected. |
@@ -276,8 +276,8 @@ class ESAddonSerializer(BaseESSerializer, AddonSerializer):
self._attach_fields(
obj, data,
('average_daily_users', 'bayesian_rating', 'created',
- 'default_locale', 'guid', 'hotness', 'icon_type',
- 'is_experimental', 'is_listed',
+ ... | [AddonSerializer->[get_icon_url->[get_icon_url],AddonAuthorSerializer,PreviewSerializer,SimpleVersionSerializer],VersionSerializer->[LicenseSerializer],SimpleVersionSerializer->[FileSerializer],ESAddonSerializer->[ESPreviewSerializer]] | Create a fake object from ES data. Items method for object. | This too looks like it would be better as a single-item-per-line list. Unrelated but "hotness" is such a weird attributes name, I'd love to rename it. |
@@ -69,7 +69,10 @@ def set_importer(repo_id, importer_type_id, repo_plugin_config):
:raises exceptions.InvalidValue: if the values passed to create the importer are invalid
"""
repo = model.Repository.objects.get_repo_or_missing_resource(repo_id)
- validate_importer_config(repo.repo_id, importer_type_... | [validate_importer_config->[clean_config_dict],update_importer_config->[validate_importer_config],queue_update_importer_config->[get_valid_importer],set_importer->[clean_config_dict]] | Sets an importer to be used for the given repository. Returns the serialized data node ID. | You didn't write the `plugin_api.is_valid_importer()`, but I'll write my suggestion here anyway. Overall rather than having a caller check the return code of something like `is_valid_importer()` consider having `is_valid_importer()` raise the `PulpCodedValidationException` itself, if it's not valid. This would be a muc... |
@@ -648,6 +648,9 @@ class ChannelManager(object):
else:
other = peer1
+ if self.proxy.getChannelWith(other) != '0' * 40:
+ raise Exception('Channel already exists')
+
transaction_hash = self.proxy.newChannel.transact(
other,
settle_timeout,
| [Registry->[tokenadded_filter->[Filter,new_filter]],ChannelManager->[channelnew_filter->[Filter,new_filter]],BlockChainService->[next_block->[block_number],manager_by_token->[token],deploy_and_register_token->[deploy_contract],__init__->[patch_send_transaction,patch_send_message]],Filter->[changes->[decode_topic]],Nett... | Creates a new networkting channel. | I don't think this is the best solution. I can see at least one case where this would not work even though it should. This is due to the "not optimal" way that we are currently deleting a channel. This check would fail after a channel has been settled and two parties then try to open a new channel. My suggestion would ... |
@@ -75,6 +75,10 @@ def make_parameter_groups(
The dictionary's return type is labeled as `Any`, because it can be a `List[torch.nn.Parameter]`
(for the "params" key), or anything else (typically a float) for the other keys.
"""
+ # The RegexOptimizer passes in the `groups` argument as False so this fu... | [AdamaxOptimizer->[__init__->[make_parameter_groups]],SgdOptimizer->[__init__->[make_parameter_groups]],AveragedSgdOptimizer->[__init__->[make_parameter_groups]],HuggingfaceAdamWOptimizer->[__init__->[make_parameter_groups]],DenseSparseAdam->[step->[make_sparse],__init__->[make_parameter_groups]],AdamWOptimizer->[__ini... | Takes a list of model parameters along with a grouping and prepares the parameter groups. Determines the last n - tuple of nanoseconds. Construct the list of unused parameter groups and parameters that can be optimized. | I'm not super happy about altering the type of `groups` (e.g. can now be `Any`) but it seemed to be the least invasive way of not touching any of the code when the individual optimizers are initialized (where they call this function with the `model_parameters` and `parameter_groups`) |
@@ -71,7 +71,7 @@ public class NotebookRestApi {
Gson gson = new Gson();
private Notebook notebook;
private NotebookServer notebookServer;
- private SearchService notebookIndex;
+ private SearchService noteIndex;
private NotebookAuthorization notebookAuthorization;
public NotebookRestApi() {
| [NotebookRestApi->[insertParagraph->[insertParagraph],runParagraph->[getParagraph],getNoteParagraphJobStatus->[getParagraph],runParagraphSynchronously->[getParagraph],deleteParagraph->[getParagraph],getParagraph->[getParagraph],cloneNote->[cloneNote],stopParagraph->[getParagraph],createNote->[createNote],moveParagraph-... | rest api for Notebook Get the permissions for a given note. | Term `noteIndex` is little bit confusing for me. Since you are working on naming, how about changing it into `noteSearchService`? |
@@ -0,0 +1,17 @@
+package io.quarkus.vault.runtime.config;
+
+import java.util.Map;
+
+import io.quarkus.runtime.annotations.ConfigGroup;
+import io.quarkus.runtime.annotations.ConfigItem;
+
+@ConfigGroup
+public class VaultTransitConfig {
+
+ /**
+ * keys
+ */
+ @ConfigItem
+ public Map<String, Transi... | [No CFG could be retrieved] | No Summary Found. | This is not needed any longer |
@@ -282,7 +282,7 @@ class Jetpack_Protect_Blocked_Login_Page {
$content = "<style>html{ background-color: #fff; } #error-page { margin:0 auto; padding: 1em; box-shadow: none; } </style>" . $content;
}
- wp_die( $content, $this->page_title, array( 'back_link' => $back_link ) );
+ wp_die( $content, $this->page... | [Jetpack_Protect_Blocked_Login_Page->[render_recovery_success->[protect_die],render_recovery_form->[protect_die]]] | This function is used to display a page with a security error message. | Nice catch, but aren't we dropping `wp_die()` altogether in #8274 ? |
@@ -87,7 +87,17 @@ class AmpSocialShare extends AMP.BaseElement {
const hrefWithVars = addParamsToUrl(this.shareEndpoint_, this.params_);
const urlReplacements = Services.urlReplacementsForDoc(this.getAmpDoc());
- urlReplacements.expandAsync(hrefWithVars).then(href => {
+ const bindingVars = typeConfi... | [No CFG could be retrieved] | This method is called when the user opens a link to a share endpoint. Handle key presses on the link element. | Nit: We could probably move this to the `let bindings` above (making it a `const`). |
@@ -2094,11 +2094,10 @@ namespace DotNetNuke.Entities.Modules
/// <remarks>empty SettingValue will relove the setting</remarks>
public void UpdateTabModuleSetting(int tabModuleId, string settingName, string settingValue)
{
- IDataReader dr = null;
+ IDataReader dr = data... | [ModuleController->[UpdateModuleOrder->[ClearCache,UpdateModuleOrder],UpdateTabModuleOrder->[ClearCache,UpdateModuleOrder],DeleteModuleSetting->[ClearModuleSettingsCache,UpdateTabModuleVersionsByModuleID,DeleteModuleSetting],UpdateModule->[UpdateModuleSettings,UpdateContentItem,GetTabModulesByModule,HasModuleOrderOrPan... | Updates a specific setting of a specific tab module. | Why not use a single using statement here? |
@@ -183,8 +183,8 @@ public abstract class IpAdapterParserUtils {
static String getPort(Element element, ParserContext parserContext) {
String port = element.getAttribute(IpAdapterParserUtils.PORT);
if (!StringUtils.hasText(port)) {
- parserContext.getReaderContext().error(IpAdapterParserUtils.PORT +
- " i... | [IpAdapterParserUtils->[getPort->[getAttribute,hasText,error],addConstuctorValueIfAttributeDefined->[getAttribute,addConstructorArgValue,hasText],addPortToConstructor->[addConstructorArgValue,getPort],addCommonSocketOptions->[setValueIfAttributeDefined],getMulticast->[getAttribute,hasText],addHostAndPortToConstructor->... | Get the port attribute of the given element. | This method is used from the `UdpInboundChannelAdapterParser` as well. Therefore `outbound` word here isn't correct. The change should be reverted. |
@@ -183,6 +183,17 @@ public class AMQPConnectionContext extends ProtonInitializable implements EventH
}
public void close(ErrorCondition errorCondition) {
+ synchronized (schedulingLock) {
+ isSchedulingCancelled = true;
+
+ if (scheduledPool != null && scheduledPool instanceof ThreadPool... | [AMQPConnectionContext->[checkDataReceived->[checkDataReceived],onFlow->[onFlow],runNow->[runNow],onAuthFailed->[close],onAuthInit->[close],pushBytes->[onTransport],onLocalDetach->[close],getAmqpLowCredits->[getAmqpLowCredits],close->[close],scheduledFlush->[scheduledFlush],addEventHandler->[addEventHandler],ScheduleRu... | Close the session extension. | I suggest another approach that doesn't require a specific type of Runnable and ThreadPoolExecutor to work |
@@ -12,6 +12,7 @@ module Pii
end
def decrypt(ciphertext, user_access_key)
+ raise EncryptionError unless sane_payload?(ciphertext)
encrypted_d, encrypted_c = split_into_segments(ciphertext)
hash_e = if user_access_key.unlocked?
user_access_key.hash_e
| [PasswordEncryptor->[decrypt->[unlocked?,split_into_segments,unlock,decrypt_and_test_payload,hash_e],encrypt->[hash_e,encrypt,fingerprint_and_concat,join_segments,encryption_key,make],initialize->[encrypted_key_maker,new],attr_accessor]] | Decrypts the ciphertext using the specified user_access_key. If the user_access. | Should we create a separate `DecryptionError` class? Or add a message here, ex "can't decrypt incorrectly delimited payload" ? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.