patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -473,11 +473,14 @@ static int try_cert(struct extracted_param_data_st *data, OSSL_STORE_INFO **v,
&& (strcasecmp(data->data_type, PEM_STRING_X509_TRUSTED) == 0))
ignore_trusted = 0;
+ /* Discard DER decoding errors, it only means we return "empty handed" */
+ ERR_set_mark();... | [ossl_store_handle_load_result->[try_name,RESET_ERR_MARK,OSSL_PARAM_get_utf8_string_ptr,memset,SET_ERR_MARK,OSSL_PARAM_get_octet_string_ptr,try_crl,try_cert,try_pkcs12,CLEAR_ERR_MARK,OSSL_STORE_LOADER_provider,ossl_provider_libctx,OSSL_PARAM_get_int,OSSL_PARAM_locate_const,try_key],EVP_PKEY->[EVP_KEYMGMT_free,X509_SIG_... | try_cert - try to find a certificate in the store. | Again, should we clear the errors if data->object_type == OSSL_OBJECT_CERT ? |
@@ -60,6 +60,8 @@ class RingOverlay {
_getHtmlStr(callee) {
let callingLabel = this.isRinging? "<p>Calling...</p>" : "";
let callerStateLabel = this.isRinging? "" : " isn't available";
+ let audioHTML = this.dontPlayAudio? "" :
+ `<audio id="${this._audioContainerId}" src="./so... | [No CFG could be retrieved] | Displays a ring overlay of a user s token. Renders and clears all the objects related to the ring overlay. | I think that the new formatting rules would request a space before the ? and the : should be on the new line together with what follows them. |
@@ -47,7 +47,7 @@ func prefixes(token string) (res []string) {
continue
}
// Skip any prefixes longer than 20 to limit the index size.
- if i >= 20 {
+ if i >= 10 {
break
}
res = append(res, token[:i])
| [Join,ParseAny,Sprintf,StemWithoutLowerCasing,ToSlice,FindStringSubmatch,ToLower,FindAllStringIndex,Replace,SearchableText,FindAllStringSubmatch,MustCompile,ToTime,Split,PresentMessageUnboxed,TrimSpace,Trim] | getIndexTokens returns a map of tokens to aliases normalized to lowercase. tokenMap is a map of tokens to their aliases. | can you move the min/max to constants? |
@@ -71,6 +71,7 @@ class AsyncInfoController < ApplicationController
moderator_for_tags: @user.moderator_for_tags,
config_body_class: @user.config_body_class,
pro: @user.pro?,
+ feed_style: SiteConfig.feed_style,
created_at: @user.created_at
}
end.to_json
| [AsyncInfoController->[user_cache_key->[last_sign_in_at,updated_at,blocking_others_count,pro?,reactions_count,checked_code_of_conduct,last_followed_at,saw_onboarding,id,articles_count],base_data->[user_signed_in?,decorate,render,respond_to,discard,json,blank?,remember_me,remember_me!],occasionally_update_analytics->[ra... | User data missing - return nil if user doesn t exist. | Can we find a better place to serve this from? This hash is all comprised of `user_data` and this is a Site configuration. It feels like this should be its own standalone endpoint if we want a way to serve SiteConfigs to our views. |
@@ -469,7 +469,7 @@ class ManualAdvancement extends AdvancementConfig {
const target = dev().assertElement(event.target);
if (this.canShowTooltip_(event) &&
- matches(target, TOOLTIP_TRIGGERABLE_SELECTORS.join(','))) {
+ matches(target, Object.values(tooltipDelegatableSelectors()).join(','))) {
... | [No CFG could be retrieved] | Determines if the specified event is a clickable element to trigger a tooltip and if so performs This function is called when a user clicks on a page that has a offset. | Isn't this list of selectors constant? Can't we calculate it just once? |
@@ -784,8 +784,17 @@ module.exports = class binance extends Exchange {
});
}
+ costToPrecision (symbol, cost) {
+ return this.decimalToPrecision (cost, TRUNCATE, this.markets[symbol].precision.quote, this.precisionMode, this.paddingMode);
+ }
+
currencyToPrecision (currency, fee) {
- ... | [No CFG could be retrieved] | Get a list of assets that can be processed by a user. Get the last known time in milliseconds. | I don't think there is any need to rewrite this code since it is in the superclass |
@@ -294,15 +294,15 @@ class GraphManager(object):
continue
# Packages with PACKAGE_ID_UNKNOWN might be built in the future, need build requires
if (node.binary not in (BINARY_BUILD, BINARY_EDITABLE, BINARY_UNKNOWN)
- and node.recipe != RECIPE_CONSUMER):
+ ... | [load_deps_info->[get_forbidden_access_object->[InfoObjectNotDefined],get_forbidden_access_object],_RecipeBuildRequires->[__call__->[add],update->[add]],GraphManager->[_recurse_build_requires->[_recurse_build_requires,_get_recipe_build_requires],_load_graph->[_recurse_build_requires,load_graph],load_consumer_conanfile-... | Recurse through the graph and build requires and add missing packages to the build requires. Add missing build_requires to the build_requires list. | Can we put this in EditorConfig? My configuration complains this is bad and needs an indent. |
@@ -736,6 +736,14 @@ public class DruidCoordinator
}
}
+ BalancerStrategyFactory factory= null;
+ if (COST.equals(config.getCoordinatorBalancerStrategy()))
+ factory = new CostBalancerStrategyFactory();
+ else if (RANDOM.equals(config.getCoordinatorBalancerStrategy())... | [DruidCoordinator->[moveSegment->[execute->[execute],execute],dropSegment->[dropSegment,execute],becomeLeader->[start,createNewLeaderLatch],enableDatasource->[enableDatasource],start->[start],getCurrentLeader->[isLeader],removeSegment->[removeSegment],CoordinatorRunnable->[run->[stopBeingLeader,run]],removeDatasource->... | This method is called when a node is detected to be leader. | the balancer strategy should be put into the dynamic config |
@@ -60,8 +60,8 @@ const (
updateCallbackName = "sync:run_after_update"
)
-// NewStatsPusher returns a new event queuer
-func NewStatsPusher(orm *orm.ORM, url *url.URL, accessKey, secret string, afters ...utils.Afterer) StatsPusher {
+// NewStatsPusher returns a new StatsPusher service
+func NewStatsPusher(orm *orm... | [GetStatus->[Status],syncEvent->[RawDB,New,Unmarshal,Receive,Wrap,Delete,Send,Inc],GetURL->[Url],Start->[Start,eventLoop,Background,WithCancel],Close->[Create,Unlock,Callback,RawDB,Remove,Close,Lock,cancel,Update],eventLoop->[Error,Duration,Debugw,pusherLoop,After,Done,Warnw],pusherLoop->[pushEvents,After,Done],pushEve... | NewStatsPusher initializes a new StatsPusher object and pushes events to Explorer. GetURL - get url of the server. | Mutex never gets unlocked if we return error |
@@ -79,5 +79,7 @@ func (s *PublicHarmonyAPI) GetNodeMetadata() NodeMetadata {
header.Epoch().Uint64(),
blockEpoch,
cfg.Role().String(),
+ cfg.DNSZone,
+ cfg.GetArchival(),
}
}
| [GasPrice->[NewInt],GetNodeMetadata->[Header,ShardID,GetDefaultConfig,GetNetworkType,Role,GetShardID,CurrentBlock,Uint64,IsLeader,InstanceForEpoch,GetVersion,Epoch,BlocksPerEpoch,String,SerializeToHexStr,ChainConfig]] | GetNodeMetadata returns the node metadata for the current node. | why DNSZone is configured in this PR? |
@@ -42,12 +42,12 @@ define([
*/
var endUserOptions = queryToObject(window.location.search.substring(1));
- var imageryProvider;
- if (endUserOptions.tmsImageryUrl) {
- imageryProvider = createTileMapServiceImageryProvider({
- url : endUserOptions.tmsImageryUrl
- });
- }
+
... | [No CFG could be retrieved] | The main function of the functions. Initialize the viewer and show error panel if an error occurs. | I'm sure you noticed this already, but these changes need to be reverted. |
@@ -92,6 +92,7 @@ var (
transferReceiverPtr = transferCommand.String("to", "", "Specify the receiver account")
transferAmountPtr = transferCommand.Float64("amount", 0, "Specify the amount to transfer")
transferShardIDPtr = transferCommand.Int("shardID", 0, "Specify the shard ID for the transfer")
+ trans... | [ConstructTransactionListMessageAccount,Find,SerializeToHexStr,Info,RunServices,Done,ReadFile,New,Export,Accounts,Bytes,Bool,TerminalFormat,GetFreeToken,GenKeyP2P,Seed,Println,Parsed,GetPublicKey,GetHost,OpenFile,NewClientGroupIDByShardID,GenBlsKeyWithPassPhrase,Mul,LoadBlsKeyWithPassPhrase,Now,Close,IsEqual,Exit,Add,N... | Creates a command line interface to export a private key to a private key store. c - n - bls - import - command. | Specify the destination shard ID for the cross shard transfer |
@@ -414,11 +414,13 @@ function decodeBase64(string, encoding = 'utf-8') {
* Get all the generator configuration from the .yo-rc.json file
* @param {Generator} generator the generator instance to use
* @param {boolean} force force getting direct from file
+ * @param {String} base path where the .yo-rc.json file is... | [No CFG could be retrieved] | Get all the fields from the YubiKey s Yo - RC. json file and Get the configuration object for the . | Can you check if this is exposed anywhere binnour public API if so we need to take care of backwards compatibility |
@@ -251,8 +251,9 @@ namespace Content.Server.Singularity.EntitySystems
state = EmitterVisualState.Off;
}
+ var locked = EntityManager.TryGetComponent(component.Owner.Uid, out LockComponent? lockComp) && lockComp.Locked;
component.Appearance.SetData(EmitterVisuals.... | [EmitterSystem->[ShotTimerCallback->[ShotTimerCallback],Initialize->[Initialize]]] | Updates the appearance of the given component. | no need to update the the locked state at all here. the visualizer should be listening to `StorageVisuals.Locked` instead, since thats the enum the locksystems sends data over |
@@ -46,7 +46,7 @@ public class FetchAccessTokenTestCase extends AbstractMuleContextTestCase implem
this.objectStore = new InMemoryObjectStore<Serializable>();
this.event = getTestEvent("");
- event.getMessage().setProperty("state", "<<MULE_EVENT_ID=whatever>>", PropertyScope.INBOUND);
+ ... | [FetchAccessTokenTestCase->[inMemoryObjectStore->[Thread,start,await,store,interrupt,fail],doSetUp->[setAccessTokenObjectStore,doSetUp,mock,setMuleContext,setAccessTokenId,getTestEvent,setProperty,OAuth2FetchAccessTokenMessageProcessor,CountDownLatch,TestOAuth2Manager],run->[process,countDown]]] | Override doSetUp to add the necessary objects. | This makes no sense. What's the point of putting that suffix if there's no prefix? It doesn't serve it's purpose. Either replace both suffix and prefix for non conflictive characters or remove both. |
@@ -2382,6 +2382,7 @@ if ( ! class_exists( 'WPSEO_Option_XML' ) ) {
/**
* Uses enrich_defaults to add more along the lines of:
+ * - 'user_role-' . strtolower( $user_role['name'] ) . '-not_in_sitemap' => bool
* - 'post_types-' . $pt->name . '-not_in_sitemap' => bool
* - 'taxonomies-' . $tax->n... | [WPSEO_Option->[clean->[get_original_option],get_original_option->[add_option_filters,remove_option_filters,add_default_filters,remove_default_filters],array_filter_merge->[get_defaults],wp37_add_default_filters->[add_default_filters],validate->[get_defaults,remove_default_filters],import->[update_site_option,get_defau... | Provides a class for the XML - related options. Construct the object. | Hi Andy, can you please add this one to the enrich_defaults method too ? Otherwise the defaults won't be in place and it will break the principle behind it. |
@@ -50,6 +50,9 @@ namespace ProtoCore.DSASM
public ProtoCore.DSASM.ProcedureTable[] procedureTable { get; set; }
public ProtoCore.DSASM.SymbolTable[] runtimeSymbols { get; set; }
+ public List<CodeBlock> CodeBlocks { get; set; }
+ public List<CodeBlock> CompleteCodeBlocks { get; set; }... | [CodeBlock->[IsMyAncestorBlock->[parent,codeBlockId],Count,RuntimeIndex,codeBlockId,guid,Add,ProcNode],Executable->[Reset],InstructionStream->[kInvalidIndex]] | The InstructionStream class is used to create a stream of instructions that can be executed in the Enumerates all the fields of a CodeBlock. | Will `CodeBlocks` be set somewhere else? If not, I'd suggest to make it a private set and use `IEnumerable<CodeBlock>` as its type, or if indexing is necessary, we could return `IList<CodeBlock>`. Same for `CompleteCodeBlocks`. |
@@ -120,10 +120,7 @@ func (o *CancelBuildOptions) Complete(f kcmdutil.Factory, cmd *cobra.Command, ar
fmt.Fprintf(o.ErrOut, "error: %s\n", err.Error())
}
- // FIXME: this double printers should not be necessary
- o.PrinterCancel = &printers.NamePrinter{Operation: "cancelled"}
- o.PrinterRestart = &printers.NameP... | [Validate->[Errorf],RunCancelBuild->[RESTClient,IsConflict,PrintObj,IsTerminalPhase,Clone,Done,Add,NewBuildLogClient,New,Poll,Errorf,AsDefaultVersionedOrOriginal,Wait,Do,ReportError,Fprint,ToLower,Get,Logs,Update,Raw,Fprintf],Complete->[BuildV1,BuildConfigBuilds,Fprintf,Error,ToRESTConfig,ResolveResource,Seconds,ToRawK... | Complete completes the cancellation of a build BuildConfigBuilds returns a list of all the builds in the build config. | I think we should probably have constructors for all these printers. |
@@ -1310,12 +1310,13 @@ namespace Microsoft.Xna.Framework.Graphics
/// <param name="startIndex">The index within the index buffer to start drawing from.</param>
/// <param name="primitiveCount">The number of primitives in a single instance.</param>
/// <param name="instanceCount">The number o... | [GraphicsDevice->[Reset->[PlatformReset,Reset],DrawUserPrimitives->[DrawUserPrimitives],SetVertexBuffers->[Clear],DrawInstancedPrimitives->[DrawInstancedPrimitives],DrawIndexedPrimitives->[DrawIndexedPrimitives],ApplyRenderTargets->[Clear],Dispose->[Clear,Dispose],GetBackBufferData->[GetBackBufferData],SetVertexBuffer-... | DrawInstancedPrimitives draws all instances of the given primitive type with no additional information. | This one change the signature of DrawInstancedPrimitives(). It's an API change and will break existing code. The new functionality should be implemented as a new method. |
@@ -156,7 +156,8 @@ public class RouteCalculatorTest {
final double[] testData = new double[1000];
Arrays.setAll(testData, Double::valueOf);
final List<Path2D> paths = routeCalculator.getAllNormalizedLines(testData, testData);
- final Iterator<AffineTransform> transforms = routeCalculator.getPossibleT... | [RouteCalculatorTest->[testPossiblePoints->[point],testClosestPoint->[point],testMatrixTransposal->[point]]] | Tests whether all given lines are contained in the returned paths. | To avoid accidental drift between these arguments and those used to create the `RouteCalculator` above, would it be better to extract local constants in this method to avoid the duplication? Or alternatively add getters to `RouteCalculator` and call those getters on this line instead of using the constants/literals? |
@@ -25,7 +25,7 @@ module Engine
include Transfer
attr_accessor :ipoed, :par_via_exchange, :max_ownership_percent, :float_percent, :capitalization, :max_share_price
- attr_reader :companies, :min_price, :name, :full_name, :fraction_shares, :type
+ attr_reader :companies, :min_price, :name, :full_name, ... | [Corporation->[buy_multiple?->[buy_multiple?],counts_for_limit->[counts_for_limit],remove_ability->[remove_ability]]] | Initializes a new object with the given options. | tokens is unnecessary here |
@@ -7,6 +7,8 @@ from typing import TYPE_CHECKING, Iterable, List, Optional
import graphene
from django.db.models import F, QuerySet, Sum
+from saleor.core.prices import quantize_price, quantize_price_fields
+
from ..attribute.models import AttributeValueTranslation
from ..checkout.models import Checkout
from ..c... | [generate_sample_payload->[generate_product_payload,_generate_sample_order_payload,_get_sample_object,generate_fulfillment_payload,generate_customer_payload,_remove_token_from_checkout,generate_page_payload,generate_checkout_payload],generate_product_payload->[serialize_product_channel_listing_payload],_generate_sample... | import for a node This function is an entry in the neccessary array of all known attributes of a. | Let's use relative import as the rest of the imports |
@@ -884,7 +884,7 @@ public class PubsubUnboundedSource extends PTransform<PBegin, PCollection<Pubsub
if (current == null) {
throw new NoSuchElementException();
}
- return new PubsubMessage(current.elementBytes, current.attributes);
+ return new PubsubMessage(current.elementBytes, curren... | [PubsubUnboundedSource->[PubsubReader->[pull->[pull,InFlightState,now],retire->[now],stats->[now],getWatermark->[now],getCheckpointMark->[PubsubCheckpoint],extend->[InFlightState,extendBatch,now],maybeCloseClient->[close],advance->[pull,retire,stats,now,extend],newFun],expand->[of,apply,StatsFn],StatsFn->[populateDispl... | Returns the current message in the queue or null if there is no current message in the queue. | Should that be `current.messageId`? |
@@ -49,7 +49,6 @@ def _collect_paths(
)
else:
logger.warning("'%s' was not found at: '%s'.", path_info, rev)
- continue
target_infos.append(path_info)
return target_infos
| [collect->[_collect_outs,_collect_paths,_filter_duplicates]] | Collect paths from a list of targets and a . | Removing - even if we want to have a warning that some file does not exist, we need to try to open that file later, so that we get `FileNotFound` in results, for API consistiency. |
@@ -965,7 +965,7 @@ define([
var max = Math.max(g0, Math.max(g1, g2));
var edge;
- var mid;
+ var mid = new Cartesian3();
if (max > granularity) {
if (g0 === max) {
| [No CFG could be retrieved] | Creates a list of triangles that need to be subdivided and then splits the triangles into two Adds the n - th edge to the list of possible duplicate triangles. | You can remove this now that you changed the code below to assign a new cartesian to `mid`. |
@@ -163,6 +163,9 @@ static bool got_log_verbose = false;
static bool got_default_address = false;
static bool got_bidir_giop = false;
static bool got_thread_status_interval = false;
+static bool got_relay_thread_key = false;
+static bool got_relay_thread_hwm = false;
+static bool got_relay_thread_lwm = false;
stati... | [No CFG could be retrieved] | This static method is used to determine if a transport is available. Missing constants for all the configuration options. | This should not appear in OpenDDS proper. These are solely for the benefit of the rtps relay so it should be handled entirely in the relay. |
@@ -36,8 +36,8 @@ describe( "mapEditorDataToPreview", () => {
expect( actual.url ).toEqual( expected );
} );
- it( "Doesn't hyphenate trailing spaces.", () => {
- const exampleURL = "my URL is awesome ";
+ it( "Doesn't hyphenate prefixing or trailing spaces.", () => {
+ const exampleURL = " my URL is aweso... | [No CFG could be retrieved] | It doesn t hyphenate trailing spaces. | Very minor, but I guess the correct term in English is "leading" spaces. |
@@ -251,8 +251,16 @@ outer:
go serve(socket, driver)
}
- // write and close ReadyFD (convention is same as slirp4netns --ready-fd)
logrus.Info("ready")
+
+ // https://github.com/containers/podman/issues/11248
+ // Copy /dev/null to stdout and stderr to prevent SIGPIPE errors
+ if f, err := os.OpenFile("/dev/nu... | [Write->[Infof],RemoveAll,ValidatePortSpec,RemovePort,Warn,Fd,Close,TempDir,GetNS,ListPorts,Wrap,Info,AddPort,NewFile,Exit,Dup2,NewChildDriver,Stop,Error,Marshal,New,Notify,Start,RunParentDriver,Wait,RunChildDriver,Join,Infof,Do,Kill,ReadAll,Accept,Register,NewDecoder,OpaqueForChild,MkdirAll,Command,Write,Println,Liste... | wait for the parent to connect to the child handler is a handler for the protocol. It is used to check if a node. | Nit: Could have used os.DevNull, LGTM |
@@ -16,6 +16,9 @@ import {
HDSegwitElectrumSeedP2WPKHWallet,
HDAezeedWallet,
MultisigHDWallet,
+ SLIP39SegwitP2SHWallet,
+ SLIP39LegacyP2PKHWallet,
+ SLIP39SegwitBech32Wallet,
} from './';
const encryption = require('../blue_modules/encryption');
const Realm = require('realm');
| [No CFG could be retrieved] | The main function of the module. The object that holds the key and value of the object. | btw, we have colors for each wallet (`class/wallet-gradient.js`) i assume for SLIP39 wallets colors should be the same as for their class parents..? |
@@ -1352,6 +1352,16 @@ func (s *BoltState) AddVolume(volume *Volume) error {
return errors.Wrapf(err, "error marshalling volume %s config to JSON", volume.Name())
}
+ // Volume state is allowed to not exist
+ var volStateJSON []byte
+ if volume.state != nil {
+ stateJSON, err := json.Marshal(volume.state)
+ if... | [AddContainer->[addContainer,Wrapf],HasPod->[Bucket,Equal,getDBCon,deferredCloseDBCon,Get,View],Pod->[getPodFromDB,View,deferredCloseDBCon,getDBCon],SaveContainer->[ID,Wrapf,Bucket,Marshal,Update,Put,Delete,deferredCloseDBCon,getDBCon],AddPod->[ID,Wrapf,Marshal,Update,Put,Name,CreateBucket,deferredCloseDBCon,Get,getDBC... | AddVolume adds a volume to the state store the configuration of the volume in the all volumes bucket. | any reason not to volStateJSON, err = json.Marshal? |
@@ -715,6 +715,10 @@ public class Preferences extends AppCompatPreferenceActivity implements Preferen
getCol().getConf().put("dueCounts", ((android.preference.CheckBoxPreference) pref).isChecked());
getCol().setMod();
break;
+ case "showLarge... | [Preferences->[setDayOffset->[getCol],getCol->[getCol],initSubscreen->[getCol,getPreferenceScreen,addPreferencesFromResource,getPreferenceSubscreenIntent],getCustomFonts->[getCustomFonts],attachBaseContext->[attachBaseContext],onActivityResult->[onActivityResult],SettingsFragment->[onPause->[onPause],onCreate->[onCreat... | Updates the preferences based on the key. region Private methods CheckBox preference. This method is called when the user clicks on a dialog which has no token. | Can we have this in shared preferences rather than conf |
@@ -85,6 +85,8 @@ class Repo(object):
self.tmp_dir = os.path.join(self.dvc_dir, "tmp")
makedirs(self.tmp_dir, exist_ok=True)
+ self.index_dir = os.path.join(self.dvc_dir, "index")
+ makedirs(self.index_dir, exist_ok=True)
hardlink_lock = self.config["core"].get("hardlink_loc... | [Repo->[find_out_by_relpath->[find_outs_by_path],used_cache->[collect_granular],unprotect->[unprotect],collect_granular->[collect],init->[init,Repo],find_dvc_dir->[find_root],graph->[_collect_graph],open_by_relpath->[find_out_by_relpath],close->[close]]] | Initialize object with all necessary objects. | Forgetting to gitignore it :) But actually, maybe let's use `.dvc/tmp/index` instead? |
@@ -272,6 +272,7 @@ class Guardian
if object.is_a?(Topic) && object.private_message?
return false unless SiteSetting.enable_personal_messages?
+ return false if object.reached_recipients_limit? && !is_staff?
end
if object.is_a?(Topic) && object.category
| [Guardian->[can_revoke_moderation?->[moderator?],can_see_group?->[blank?,is_staff?,is_admin?],can_approve?->[is_staff?,approved?],is_not_me?->[blank?,is_me?],can_do?->[method_name_for,authenticated?],can_activate?->[is_staff?],can_send_multiple_invites?->[staff?],can_send_private_message?->[is_silenced?,is_staff?,has_t... | Checks if the user can invite to the object. | I think we should update the specs to reflect this change. |
@@ -465,4 +465,17 @@ def get_meminfo() -> Dict[str, Any]:
meminfo = process.memory_info()
res['memory_rss_mib'] = meminfo.rss / MiB
res['memory_vms_mib'] = meminfo.vms / MiB
+ if sys.platform == 'win32':
+ res['memory_maxrss_mib'] = meminfo.peak_wset / MiB
+ else:
+ ... | [Server->[find_changed->[find_changed],update_changed->[update_changed]]] | Get memory info of a node. | @gvanrossum I wasn't entirely sure what to do here, so I refactored things to be a bit more reliant on psutil existing. I could manually get the max memory used with win32 APIs if psutil isn't installed if you prefer, but I felt this was cleaner. |
@@ -71,6 +71,7 @@ type Label struct {
IsChecked bool `xorm:"-"`
QueryString string
IsSelected bool
+ IsExcluded bool
}
// APIFormat converts a Label to the api.Label format
| [ForegroundColor->[ParseUint,HasPrefix,CSS],LoadSelectedLabelsAfterClick->[Join,FormatInt],APIFormat->[TrimLeft],Commit,Find,Close,Delete,In,AllCols,MatchString,Errorf,MustCompile,TrimSpace,SplitN,ID,Asc,Join,Where,Desc,Cols,Get,NewSession,Split,Update,Begin,Table,Insert,loadRepo] | APIFormat returns a string representing the Label in the API format. | Why we need this new column? |
@@ -44,8 +44,12 @@ class PluginUpdate(BaseMutation):
@classmethod
def perform_mutation(cls, root, info, **data):
plugin_id = data.get("id")
- input = data.get("input")
- instance = cls.get_node_or_error(info, plugin_id, only_type=Plugin)
+ data = data.get("input")
manage... | [PluginUpdate->[Arguments->[PluginUpdateInput],perform_mutation->[PluginUpdate]]] | Perform a mutation on a plugin configuration. | Instead of hardcoded `not_found` we shuold use the code from enum, probably from `ExtensionsError` in this case. |
@@ -76,6 +76,8 @@ public class OzoneClientProducer {
private OzoneClient getClient(OzoneConfiguration config) throws IOException {
try {
+ Boolean isAclEnable = config.getBoolean(
+ OZONE_ACL_ENABLED, OZONE_ACL_ENABLED_DEFAULT);
if (OzoneSecurityUtil.isSecurityEnabled(config)) {
... | [OzoneClientProducer->[createClient->[getClient],getClient->[getAwsAccessId,getKind,setAwsAccessId,Token,setOwner,isSecurityEnabled,trace,getSignature,setSignature,Text,getStringToSign,getRpcClient,debug,error,setStrToSign,OzoneTokenIdentifier,getBytes,isTraceEnabled,setTokenType,addToken,setLoginUser,createRemoteUser]... | Get the client. | Do we still need this? |
@@ -21,6 +21,10 @@ package org.sonar.api.test;
import java.util.List;
+/**
+ * @deprecated since 5.6 feature will be removed soon
+ */
+@Deprecated
public interface CoverageBlock {
TestCase testCase();
| [No CFG could be retrieved] | TestCase testable test case. | The message is not clear enough. I suggest `@deprecated since 5.6. Feature will be removed without any alternatives`. |
@@ -12,8 +12,14 @@ namespace Microsoft.Xna.Framework.Graphics
internal void ClearTargets(GraphicsDevice device, RenderTargetBinding[] targets)
{
- ClearTargets(targets, device._d3dContext.VertexShader);
- ClearTargets(targets, device._d3dContext.PixelShader);
+ if (_... | [TextureCollection->[ClearTargets->[ClearTargets]]] | Clear the texture if it has no other texture. | @tgjones - I wonder if we're better off just passing the DX pixel shader or vertex shader context on construction of the TextureCollection. At least that cuts out some of the extra branches at runtime. |
@@ -163,7 +163,7 @@ export default class ScanLndInvoice extends React.Component {
>
<TextInput
onChangeText={text => {
- if (text.toLowerCase().startsWith('lnb')) {
+ if (text.toLowerCase().startsWith('lnb') || text.toLowerCase().startsWith(... | [No CFG could be retrieved] | Renders a single node of type nagios. Displays a hidden block of the nagios that are shown on the scan bar. | lntb is for lightning testnet. we dont officially support it, but ok |
@@ -59,6 +59,7 @@ class CI_Email {
public $crlf = "\n"; // The RFC 2045 compliant CRLF for quoted-printable is "\r\n". Apparently some servers,
// even on the receiving end think they need to muck with CRLFs, so using "\n", while
// distasteful, is the only thing that seems to work for all env... | [CI_Email->[_write_headers->[_get_protocol],_send_command->[_get_encoding],_build_message->[_write_headers,word_wrap,_get_content_type,_get_alt_message,_get_mime_message,_set_boundaries,_get_encoding,_get_protocol],_build_headers->[_set_header,_get_message_id,clean_email],batch_bcc_send->[_set_header,clean_email,_build... | Defines the mail protocol and configuration options. The base class for all of the neccesary variables. | Needs to be in PHP5 style (public instead of var). Also there's this quote after FALSE which will cause a syntax error. |
@@ -127,16 +127,12 @@ func resourceAwsLbListenerCreate(d *schema.ResourceData, meta interface{}) error
var err error
log.Printf("[DEBUG] Creating LB listener for ARN: %s", d.Get("load_balancer_arn").(string))
resp, err = elbconn.CreateListener(params)
- if awsErr, ok := err.(awserr.Error); ok {
- if awsErr.... | [DescribeListeners,CreateListener,StringInSlice,Set,Code,NonRetryableError,ModifyListener,GetOk,New,Errorf,SetId,RetryableError,Wrapf,ToUpper,Id,DeleteListener,Int64,Get,Printf,String,IntBetween,Retry] | create listener for the given load balancer resourceAwsLbListenerRead retrieves the from the resource data. | Nitpick: Do you mind making a similar change in `isListenerNotFound` at the bottom of this file, so we can get rid of the `awserr` package import? |
@@ -86,7 +86,8 @@ class AgeFilter(IPairList):
return True
if daily_candles is not None:
- if len(daily_candles) >= self._min_days_listed:
+ if len(daily_candles) >= self._min_days_listed and \
+ len(daily_candles) <= self._max_days_listed:
... | [AgeFilter->[filter_pairlist->[int,deepcopy,log_once,len,refresh_latest_ohlcv,remove,_validate_pair_loc,utcnow],short_desc->[plural],__init__->[ohlcv_candle_limit,super,get,OperationalException],_validate_pair_loc->[int,log_once,len,plural,utcnow]],getLogger] | Validate the pair location and return True if the pair can stay false if the pair can stay. | You will want to be careful with this - as `max_days_listed` can be None - this check will fail with `TypeError: '<=' not supported between instances of 'int' and 'NoneType'` should the first condition ever evaluate to False. |
@@ -0,0 +1,10 @@
+from enum import Enum
+
+
+class StockErorrCode(Enum):
+ ALREADY_EXISTS = "already_exists"
+ GRAPHQL_ERROR = "graphql_error"
+ INVALID = "invalid"
+ NOT_FOUND = "not_found"
+ REQUIRED = "required"
+ UNIQUE = "unique"
| [No CFG could be retrieved] | No Summary Found. | It's recommended to use inheritance from (str, Enum) |
@@ -174,6 +174,9 @@ class Elementor implements Integration_Interface {
* @return void
*/
public function init() {
+ $this->social_is_enabled = $this->options->get( 'opengraph', false ) || $this->options->get( 'twitter', false );
+ $this->is_advanced_metadata_enabled = $this->capability->current_use... | [Elementor->[determine_scope->[get_metabox_post],get_metabox_script_data->[get_metabox_post],current_post_type_has_taxonomies->[get_metabox_post],get_replace_vars->[get_metabox_post],get_recommended_replace_vars->[get_metabox_post]]] | Initializes the plugin. | @Xyfi Initializing `$this->social_is_enabled` here instead of in the constructor will break the `if ( $this->social_is_enabled ) {` check in `save_postdata()` as that function will be called via AJAX and the class will not have been constructed by then and the `$this->social_is_enabled` will equal to `null`. With the l... |
@@ -105,7 +105,9 @@ class Checkout(ProcessManager):
def clear_storage(self):
del self.request.session[STORAGE_SESSION_KEY]
- self.request.cart.clear()
+ del self.request.session[CART_SESSION_KEY]
+ del self.request.cart
+ self.cart.clear()
def __iter__(self):
... | [Checkout->[create_order->[save],__init__->[CheckoutStorage]]] | Clear the storage of the cart and all of its steps. | Shouldn't `self.cart.clear()` be enough? Especially deleting `request.cart` does not look like a good idea. Code that expects the attribute to always be there will fail instead of getting an empty cart. |
@@ -103,7 +103,8 @@ def decode_text(text, encoding="auto"):
def touch(fname, times=None):
- os.utime(fname, times)
+ with open(fname, 'a'):
+ os.utime(fname, times)
def touch_folder(folder):
| [load->[decode_text],md5->[md5],tar_extract->[safemembers->[badpath],safemembers],touch_folder->[walk],decode_text->[_detect_encoding],make_read_only->[walk],list_folder_subdirs->[walk],exception_message_safe->[decode_text],remove->[remove],relative_dirs->[walk],merge_directories->[walk,is_excluded,link_to_rel],save_fi... | touch file and all subdirectories of fname. | small fix. os.utime requires the created file first. |
@@ -546,11 +546,12 @@ export class AmpStoryPlayer {
);
});
- const customControls =
- this.playerConfig_ && this.playerConfig_['controls'];
-
- if (customControls) {
- messaging.sendRequest('customDocumentUI', customControls, false);
+ if (this.... | [No CFG could be retrieved] | Initializes the handshake for the messaging. Initialize loading listeners. | This is going to sound very nitpicky but it'll be easier to maintain: `this.playerConfig_` should contain all the config passed by the publisher, and here you should create a new JsonObject `{"controls": this.playerConfig_.controls}`. Two benefits: - When you'll add the `behavior` key to the config you'll have to do th... |
@@ -108,7 +108,7 @@ class Parser:
self.errors.set_file('<input>')
def parse(self, s: str) -> MypyFile:
- self.tok = lex.lex(s)
+ self.tok = lex.lex(s, pyversion = self.pyversion)
self.ind = 0
self.imports = []
self.future_options = []
| [unwrap_parens->[unwrap_parens],token_repr->[repr],parse->[parse],Parser->[skip_until_break->[current,skip],skip_until_next_line->[current,skip,skip_until_break],eol->[current],parse_type_comment->[parse_error_at],parse_try_stmt->[parse_block],parse_tuple_expr->[parse_expression],parse_decorated_function_or_class->[par... | Parse a sequence of tokens and return a MypyFile object. | Minor nit: redundant spaces around = |
@@ -356,9 +356,11 @@ class MTurkAgent(Agent):
time.sleep(shared_utils.THREAD_SHORT_SLEEP)
i += 1
sync_attempts = 0
- while not self.hit_is_complete and \
- self.manager.get_agent_work_status(self.assignment_id) != \
- self.ASSIGNMENT_DONE:
+ ... | [MTurkAgent->[approve_work->[_print_not_available_for,approve_work],email_worker->[email_worker],block_worker->[block_worker],shutdown->[wait_for_hit_completion],wait_for_hit_completion->[set_hit_is_abandoned],act->[request_message,prepare_timeout,get_new_act_message],pay_bonus->[_print_not_available_for,pay_bonus],rej... | Waits for a hit to be marked as complete. Checks if a node in the queue has a lease. If it is the last one in. | so a sync attempt happens every 15 minutes? |
@@ -1096,16 +1096,6 @@ class Jetpack {
return $locale;
}
- /**
- * Device Pixels support
- * This improves the resolution of gravatars and wordpress.com uploads on hi-res and zoomed browsers.
- */
- function devicepx() {
- if ( Jetpack::is_active() && ! Jetpack_AMP_Support::is_amp_request() ) {
- wp_enqueu... | [Jetpack->[verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],admin_notices->[opt_in_jetpack_manage_notice,can_display_jetpack_manage_notice],authenticate_jetpack->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user,can_display_jetpack_manage_notice],wp_rest_authenti... | Get the current locale. | I couldn't think of reasons to keep it. The most typical way to remove `devicepx` seems to be `wp_dequeue_script( 'devicepx' );` so we should be good. |
@@ -1696,8 +1696,13 @@ void BaseSolidElement::CalculateLumpedMassVector(
// LUMPED MASS MATRIX
const double total_mass = GetGeometry().DomainSize() * density * thickness;
- Vector lumping_factors;
- lumping_factors = GetGeometry().LumpingFactors( lumping_factors );
+ Vector lumping_factors(number_o... | [No CFG could be retrieved] | This function calculates the lumped mass vector and damping matrix of a node based KRATOS_TRY - Find the node in the network with the highest priority. | See @philbucher, a const_cast is needed and I don't like that |
@@ -220,6 +220,13 @@ public class Executor extends Thread implements ModelObject {
try {
workUnit.context.synchronizeStart();
+ // this code handles the behavior of null Executables returned
+ // by tasks. In such case Jenkins starts the workUnit in order
+... | [Executor->[getEstimatedRemainingTimeMillis->[getElapsedTime],doStop->[interrupt],getEstimatedDurationFor->[getEstimatedDurationFor],start->[start],interrupt->[interrupt],getTimestampString->[getElapsedTime],getIdleStartMilliseconds->[isIdle],getEstimatedRemainingTime->[getElapsedTime]]] | This method is called when the executor is running. die peacefully - interrupted interrupted - die die unstarted instance . | This is not very helpful for two reasons. First, an `Error` implies that something is seriously broken, which is not necessarily true. It may simply be that a project was scheduled, and then just before it was passed off from the queue to an `Executor` it got disabled. Second, the message does not specify what the `tas... |
@@ -119,14 +119,10 @@ class PathPlanner():
if not one_blinker or below_lane_change_speed:
self.lane_change_state = LaneChangeState.off
elif torque_applied:
- self.lane_change_state = LaneChangeState.laneChangeStarting
-
- # starting
- elif self.lane_change_state == LaneCh... | [PathPlanner->[update->[calc_states_after_delay]]] | Update the state of the object based on the state machine state. Initialize the MPC weights. Update the d_poly and the mpc_solution. This method is called when the last MPC is reached. change_direction - Change direction of in pathPlan. | laneChangeStarting is gone now. Can you remove it from the dict at the top of the file? |
@@ -129,7 +129,7 @@ module.exports = class extends needleClientBase {
addEntityServiceToMainImport(entityName, entityClass, entityFileName, entityFolderName) {
const errorMessage = `${chalk.yellow('Reference to entity ') + entityClass} ${chalk.yellow('not added to import in main.\n')}`;
- const filePath = ... | [No CFG could be retrieved] | Adds a single entity to main import and a service to main import Adds the entity service to the main file model. | I don't understand why you rename main.ts to bootstrap.ts ? Is there any special reason ? |
@@ -1080,9 +1080,6 @@ bool WScriptJsrt::Initialize()
IfFalseGo(WScriptJsrt::InstallObjectsOnObject(wscript, "SerializeObject", SerializeObject));
IfFalseGo(WScriptJsrt::InstallObjectsOnObject(wscript, "Deserialize", Deserialize));
- // ToDo Remove
- IfFalseGo(WScriptJsrt::InstallObjectsOnObject(wscrip... | [No CFG could be retrieved] | This function installs all methods that are not in the same order as the WScriptJsrt Creates a string containing the CPU and architecture of the . | if we're deleting this can we also delete the EmptyCallback below and from the header? (Though I note I've not seen the full test suite run through yet - are there test cases that call this useless function? - I'd assumed that was why it wasn't removed before) |
@@ -329,9 +329,7 @@ public class DefaultFuture implements ResponseFuture {
lock.lock();
try {
response = res;
- if (done != null) {
- done.signal();
- }
+ done.signalAll();
} finally {
lock.unlock();
}
| [DefaultFuture->[TimeoutCheckTask->[run->[isDone,received]],setCallback->[isDone],doReceived->[invokeCallback],get->[get],newFuture->[DefaultFuture,timeoutCheck],closeChannel->[getFuture]]] | Called when a response is received. | Hi, this change is irrelevant. And is addressed in #3681 . Please rebase with the master and send the pull request again. |
@@ -474,7 +474,8 @@ export class Resources {
const parentResource = Resource.forElement(parentElement);
subElements = elements_(subElements);
- this.discoverResourcesForArray_(parentResource, subElements, resource => {
+ this.discoverResourcesForArray_(parentResource, subElements,
+ /* deepSubtree ... | [No CFG could be retrieved] | Schedules layout for specified sub - elements that are children of the specified parent element. Schedules unlayout of children of the given parent element. | Shouldn't the parent be in charge of unlayout-ing it's children? We have it being responsible for the layout. |
@@ -15,6 +15,15 @@ namespace Pulumi
public Runner(IDeploymentInternal deployment)
=> _deployment = deployment;
+ public Task<int> RunAsync<TStack>() where TStack : Stack, new()
+ {
+ var stack = new TStack();
+ // Stack doesn't call Reg... | [Deployment->[Runner->[WhileRunningAsync->[LoggedErrors,Clear,Count,Remove,Keys,ConfigureAwait,AddRange],RunAsync->[WhileRunningAsync,DataTask,RegisterTask],HandleExceptionAsync->[HideStack,Error,Message,GetEntryAssembly,ConfigureAwait,ToString,Debug],RegisterTask->[Add]]]] | Run async. | can you show what the behavior is if their constructor blows up? |
@@ -101,6 +101,8 @@ public class InfoResource
private final DatabaseSegmentManager databaseSegmentManager;
private final DatabaseRuleManager databaseRuleManager;
private final IndexingServiceClient indexingServiceClient;
+ private final JacksonConfigManager configManager;
+
@Inject
public InfoResource... | [InfoResource->[getDataSources->[apply->[getDataSources]],getDataSource->[apply->[getDataSource]]]] | Produces a function that returns a Map of the specified . Gets the cluster info. | Can we create a new Resource for the config management? |
@@ -40,7 +40,8 @@ public interface LeaderElectionManager {
void register(String roleName, LeaderElectionStateChangeListener listener);
/**
- * Adds a new role for which a leader is required, providing the given value for this node as the Participant ID
+ * Adds a new role for which a leader is requi... | [No CFG could be retrieved] | This class is used to manage the leader elections for all registered roles. Unregiste leadership role. | Does this mean that in the future this node could never become the leader? |
@@ -1424,7 +1424,7 @@ def fix_mag_coil_types(info):
info._check_consistency()
-def _get_T1T2_mag_inds(info):
+def _get_T1T2_mag_inds(info): # noqa: N802
"""Find T1/T2 magnetometer coil types."""
picks = pick_types(info, meg='mag')
old_mag_inds = []
| [_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types],pick_channels->[pick_channels]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],find_ch_connectivity->[read_ch_connectivity],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels->[rename_channels],... | Find T1 and T2 magnetometer coil types. | I would ignore N802 too. |
@@ -33,7 +33,6 @@ import static util.ItUtils.setServerProperty;
*/
public class DebtConfigurationRule extends ExternalResource {
- private static final String HOURS_IN_DAY_PROPERTY = "sonar.technicalDebt.hoursInDay";
private static final String DEV_COST_PROPERTY = "sonar.technicalDebt.developmentCost";
priv... | [DebtConfigurationRule->[resetProperty->[setProperty],create->[DebtConfigurationRule]]] | This rule is used to configure the technical debt properties. Create a new DebtConfigurationRule. | have you checked Governance for the use of this property? |
@@ -49,17 +49,6 @@ const SUPPORTED_CSS_GRID_ATTRIBUTES_SELECTOR = Object.keys(
*/
const TEMPLATE_ATTRIBUTE_NAME = 'template';
-/**
- * A mapping of template attribute values to CSS class names.
- * @const {!Object<string, string>}
- */
-export const GRID_LAYER_TEMPLATE_CLASS_NAMES = {
- 'fill': 'i-amphtml-story-g... | [No CFG could be retrieved] | A mapping of attribute names to CSS Grid properties. AmpStoryGridLayer exports an AmpStoryGridLayer with preset details. | This is used by in animation-presets.js. it's `setStyleForPreset` method might need to be updated to read attributes instead of class names. |
@@ -49,7 +49,9 @@ if ($metadata) {
if ($title_link) {
echo "<h3>$title_link</h3>";
}
-echo "<div class=\"elgg-subtext\">$subtitle</div>";
+if ($subtitle) {
+ echo "<div class=\"elgg-subtext\">$subtitle</div>";
+}
echo $tags;
echo elgg_view('object/summary/extend', $vars);
| [getURL] | Generate a header and content. | Maybe should still output an empty string if set to ''? |
@@ -33,15 +33,10 @@ ModelPart& ModelPartCombinationUtilities::CombineModelParts(Parameters ThisParam
const int echo_level = ThisParameters["echo_level"].GetInt();
// Retrieve the ModelParts to combine
- std::vector<std::string> model_parts_names;
- const auto& r_model_parts_names = ThisParameters["mod... | [RecursiveAddOfModelPartsToList->[RecursiveAddOfModelPartsToList],RecursiveAddEntities->[RecursiveAddEntities],Parameters->[Parameters]] | Combine ModelParts - Combine ModelParts Check that the sub - modelparts are not repeated. r_combined_model_part - r_combined_model_part ;. | I am not sure that this works, at least in python it does not In any case I would use `GetStringArray` which does the same job |
@@ -1,5 +1,15 @@
'use strict';
+// We need to be able to detect IE8 so we can use the right AJAX method below
+var ie = (function(v, p, needle, undef) {
+ needle = p.getElementsByTagName('br');
+ while(
+ p.innerHTML = '<!--[if gt IE ' + (++v) + ']><br><![endif]-->',
+ needle[0]
+ );
+ return v > 4 ? v : u... | [No CFG could be retrieved] | Provides a service that returns an XMLHttpRequest object or JSONP object. Function to call when data is received from the server. | none of this is needed. just use `msie` variable that we expose internally |
@@ -1572,6 +1572,12 @@ function createBaseCustomElementClass(win) {
* @package @final @this {!Element}
*/
toggleFallback(state) {
+ // Do not show fallback if element has not been scheduled layout yet
+ if (state && (this.getResourceState_() == ResourceState.NOT_BUILT ||
+ this.getRe... | [No CFG could be retrieved] | Gets an optional fallback element if available. Checks if the element has a loading indicator enabled. | Let's cache `#getResourceState` and test against that. |
@@ -452,6 +452,11 @@ module.exports = class bibox extends Exchange {
}
parseOrder (order, market = undefined) {
+ let keys = Object.keys (order);
+ let numKeys = keys.length;
+ if (numKeys < 1) {
+ throw new OrderNotFound ('Order ' + order + ' does not exist on ' + this.id + ... | [No CFG could be retrieved] | Create a new order on the Yelp Bitfinex account Get order remaining and cost for a given order. | Sorry, my bad, just edited it again to make it pass ) |
@@ -0,0 +1,18 @@
+"""Test for fact op"""
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+
+import os.path
+
+import tensorflow as tf
+from tensorflow.core.user_ops import fact_op
+
+class FactTest(tf.test.TestCase):
+ def testFact(self):
+ with self... | [No CFG could be retrieved] | No Summary Found. | You can remove this I think |
@@ -1003,11 +1003,7 @@ LargeHeapBlock::VerifyMark()
unsigned char attributes = header->GetAttributes(this->heapInfo->recycler->Cookie);
- // In case of OOM we may not have completed processing of trackable objects and the NewFinalizeBit may not have been cleared.
- if ((attributes & (TrackBit... | [No CFG could be retrieved] | Returns the address of the next unused object in the block. Check if an object is reserved by this object. | This undoes my earlier fix for this bug. |
@@ -18,7 +18,7 @@ describe Analytics do
it 'identifies the user and sends the event to the backend' do
user = build_stubbed(:user, uuid: '123')
- analytics = Analytics.new(user, FakeRequest.new)
+ analytics = Analytics.new(user: user, request: FakeRequest.new, sp: 'http://localhost:3000')
... | [user_agent,to,it,new,let,track_event,describe,build_stubbed,host,uuid,before,merge,instance_double,pid,with,remote_ip,require,and_return] | Describe the neccesary conditions for the event tracking. | service_provider from L10 isn't in scope here, right? (learning) |
@@ -144,7 +144,7 @@ func (r *buildConfigReactor) ImageChanged(obj runtime.Object, tagRetriever trigg
continue
}
if p.Paused {
- glog.V(5).Infof("Skipping paused build on bc: %s/%s for trigger: %s", bc.Namespace, bc.Name, t)
+ glog.V(5).Infof("Skipping paused build on bc: %s/%s for trigger: %+v", bc.Namesp... | [Index->[DeepEqual],ImageChanged->[HandleError,Infof,Error,GetInputReference,ImageStreamTag,V,Errorf,Event,Instantiate],StartRecordingToSink,GetInputReference,New,NewRecorder,Events,NewBroadcaster] | ImageChanged is called when an image in the build config has changed. This function is called by the build - config - trigger - builder service to instantiate a new. | the trigger is full of pointers. Does it actually look helpful? |
@@ -1624,6 +1624,13 @@ public class TestHoodieDeltaStreamer extends UtilitiesTestBase {
}
}
+ public static class TestTableLevelGenerator extends SimpleKeyGenerator {
+
+ public TestTableLevelGenerator(TypedProperties props) {
+ super(props);
+ }
+ }
+
public static class DummyAvroPayload exte... | [TestHoodieDeltaStreamer->[teardown->[teardown],testParquetDFSSourceWithoutSchemaProviderAndTransformer->[testParquetDFSSource],testCsvDFSSourceWithHeaderWithoutSchemaProviderAndNoTransformer->[testCsvDFSSource],testInlineClustering->[deltaStreamerTestRunner,makeConfig],testCsvDFSSourceNoHeaderWithoutSchemaProviderAndN... | Adds a new field haversine_distance to the row. | Why do we need this new class? `TestGenerator` already exists in `TestHoodieDeltaStreamer`. See if you can use the same. |
@@ -53,6 +53,13 @@ func DefineNetFlags(cmd *cobra.Command) {
)
_ = cmd.RegisterFlagCompletionFunc(ipFlagName, completion.AutocompleteNone)
+ ip6FlagName := "ip6"
+ netFlags.String(
+ ip6FlagName, "",
+ "Specify a static IPv6 address for the container",
+ )
+ _ = cmd.RegisterFlagCompletionFunc(ip6FlagName, compl... | [GetBool,StringSlice,ValidateExtraHost,DNSServers,Wrap,HardwareAddr,CreatePortBindings,IsDefault,Errorf,Bool,ParseMAC,Flags,RegisterFlagCompletionFunc,ValidateDomain,StringArray,GetStringSlice,StringSliceP,ParseIP,IsBridge,DNSSearches,ParseNetworkFlag,Changed,GetString,String,DNSOptions,GetStringArray] | Add a custom host - to - IP mapping Publish a container s port or range of ports to the host. | Ugh, I hate the ip6 name, but it's compliant with Docker. I'd much prefer ipv6, but that's probably just my OCD kicking in. |
@@ -868,13 +868,16 @@ public abstract class AbstractRemoteFileOutboundGateway<F> extends AbstractReply
return mGetWithRecursion(message, session, remoteDirectory, remoteFilename);
}
else {
+ remoteDirectory = (remoteDirectory != null
+ ? remoteDirectory
+ : "." + this.remoteFileTemplate.getRemoteFil... | [AbstractRemoteFileOutboundGateway->[setTemporaryFileSuffix->[setTemporaryFileSuffix],putLocalDirectory->[putLocalDirectory,doPut],listFilesInRemoteDir->[listFilesInRemoteDir],setOptions->[toOption],mGetWithoutRecursion->[get],setRenameExpressionString->[setRenameExpression],handleRequestMessage->[doInSession->[doInSes... | This method is used to retrieve a list of files from a remote server. This method is called when a remote file is missing from the remote directory. | No; we need to support MGET with a null path; especially if no recursion - but we should allow, even with recursion. |
@@ -73,8 +73,7 @@ KIT_NY.LPFS = [10, 20, 50, 100, 200, 500, 1000, 2000]
KIT_AD.nchan = 256
KIT_AD.nmegchan = 208
KIT_AD.nrefchan = 16
-KIT_AD.ntrigchan = 8
-KIT_AD.nmiscchan = 24
+KIT_AD.nmiscchan = 32
KIT_AD.n_sens = KIT_AD.nmegchan + KIT_AD.nrefchan
# 16-bit A-to-D converter, one bit for signed integer. range +/... | [Bunch] | This function is used to get the values of the ethernet_network_flags field. This function is used to set the values of the KIT_AD fields. | why do those have to be lowercase? |
@@ -385,12 +385,16 @@ class TableClient(TablesBaseClient):
:dedent: 8
:caption: Updating an already exiting entity in a Table
"""
+ match_condition = kwargs.pop("match_condition", None)
+ etag = kwargs.pop("etag", None)
+ if match_condition and not etag:
+... | [TableClient->[update_entity->[update_entity],delete_entity->[delete_entity],upsert_entity->[update_entity]]] | Updates an entity in a table. Merge the specified lease. | This one's missing the try/except? |
@@ -1731,6 +1731,8 @@ def search(request):
return render(request, 'devhub/devhub_search.html', {'query': query})
+@login_required
+@waffle_switch('signing-api')
def api_key_agreement(request):
next_step = reverse('devhub.api_key')
return render_agreement(request, 'devhub/api/agreement.html', next_st... | [upload_image->[ajax_upload_image],upload_detail->[_compat_result,json_upload_detail],version_delete->[delete],submit_bump->[_step_url],submit_addon->[_step_url,auto_sign_file,check_validation_override],ownership->[mail_user_changes],submit->[_step_url],ajax_dependencies->[AddonDependencySearch],remove_locale->[remove_... | Show a list of API keys that have been authorized to access the API. | this also needs `@waffle_switch('signing-api')` |
@@ -16,7 +16,7 @@ namespace Microsoft.Extensions.Configuration
/// <summary>
/// The default instance.
/// </summary>
- public static ConfigurationKeyComparer Instance { get; } = new ConfigurationKeyComparer();
+ public static ConfigurationKeyComparer Instance { get; } = new();
... | [ConfigurationKeyComparer->[Compare->[TryParse,Min,Compare,RemoveEmptyEntries,OrdinalIgnoreCase,Length,Array],Compare,KeyDelimiter]] | Creates an instance of ConfigurationKeyComparer which can compare strings. c - c - c - c - c - c - c - c - c -. | Please don't make unnecessary changes in these PRs. This causes more work on reviewers. It also unnecessarily fills source control history when people are looking at past changes. Can you revert these kinds of changes? |
@@ -92,8 +92,8 @@ class GroupAlsoByWindowEvaluatorFactory implements TransformEvaluatorFactory {
}
/**
- * A transform evaluator for the pseudo-primitive {@link GroupAlsoByWindow}. Windowing is ignored;
- * all input should be in the global window since all output will be as well.
+ * A transform evaluato... | [GroupAlsoByWindowEvaluatorFactory->[forApplication->[createEvaluator],GroupAlsoByWindowEvaluator->[finishBundle->[commitState,build],dropExpiredWindows->[apply->[getOnlyElement,debug,getWindows,inc,getTimestamp,isBefore,currentInputWatermarkTime],filter],processElement->[getValue,create,createKeyedBundle,timerInternal... | Creates an evaluator for the given application. Evaluates the group by window evaluation. | Windowing is ignored in `DirectGroupAlsoByWindow` ? |
@@ -11,7 +11,7 @@
<div class="col-xs-6 col-sm-6 col-md-4">
<div class="badge-icon bg-primary">
- <% if can_edit_module(@my_module) then %>
+ <% if can_manage_experiment?(@my_module.experiment) then %>
<%= link_to due_date_my_module_path(@my_module, format: :json), remote: true, class: "due-... | [No CFG could be retrieved] | Renders the content of the n - ary module header. renders the header of the n - ary module. | remote "then" is useless here |
@@ -1,15 +1,3 @@
-const mock = () => {
- let storage = {};
- return {
- getItem: key => (key in storage ? storage[key] : null),
- setItem: (key, value) => (storage[key] = value || ''),
- removeItem: key => delete storage[key],
- clear: () => (storage = {})
- };
-};
-
-Object.defineP... | [No CFG could be retrieved] | Mocks localStorage and sessionStorage. | why removing this? Are they mocked by jest himself? |
@@ -97,7 +97,7 @@ def peak_finder(x0, thresh=None, extrema=1, verbose=None):
length -= 1
# Preallocate max number of maxima
- maxPeaks = int(ceil(length / 2.0))
+ maxPeaks = int(np.ceil(length / 2.0))
peak_loc = np.zeros(maxPeaks, dtype=np.int)
peak_mag = np.z... | [peak_finder->[int,asanyarray,max,finfo,info,min,len,atleast_1d,argmax,where,ValueError,isinstance,sign,concatenate,ceil,zeros,diff]] | Noise - tolerant fast peak - finding algorithm. This function is used to find the index of the non - negative peaks and valleys This function is called to reset the c_ind and peak_mag variables. Compute peak indices and peak mags from a nanomagnetic array. | No need to convert to `int` since `maxPeaks` is only used in `np.zeros`, which works with integer floats as well. |
@@ -229,7 +229,7 @@ class Stage(object):
if self.is_callback:
logger.warning(
- "DVC-file '{fname}' is a 'callback' stage "
+ "DVC-file '{fname}' is an 'callback' stage "
"(has a command and no dependencies) and thus always "
"consi... | [Stage->[_run->[_warn_if_fish,_check_missing_deps,StageCmdFailedError],dumpd->[relpath],_check_stage_path->[StagePathOutsideError,StagePathNotFoundError,StagePathNotDirectoryError],_changed_md5->[changed_md5],relpath->[relpath],is_stage_file->[is_valid_filename],remove->[unprotect_outs,remove_outs],_check_file_exists->... | Check if any of the dependencies of this DVC have changed. | why "an" though? Is "callback" a vowel sound? |
@@ -93,8 +93,14 @@ class GitDownloader extends VcsDownloader
$this->filesystem->removeDirectory($path);
}
}
- throw new \RuntimeException('Failed to checkout ' . $url .' via git, https and http protocols, aborting.' . "\n\n" . $this->process->getErrorOutput(... | [GitDownloader->[doUpdate->[setPushUrl,write,getSourceUrl,runCommand,getSourceReference],setPushUrl->[getSourceUrl,execute],doDownload->[setPushUrl,write,getSourceUrl,runCommand,getSourceReference],outputHandler->[isVerbose,write],runCommand->[getErrorOutput,removeDirectory,execute],enforceCleanDirectory->[getErrorOutp... | Runs a command on a given URL. | no need for `else` as the `if` leaves the function because of the exception |
@@ -433,10 +433,12 @@ def conv2d_transpose(input,
first half of the input channels, while the second half of the
filters is only connected to the second half of the input channels.
Default: groups = 1.
- use_cudnn(bool, optional): Use cudnn kernel or not, it is valid only w... | [conv2d->[_update_padding_nd],_update_padding_nd->[_zero_padding_in_batch_and_channel,_exclude_padding_in_batch_and_channel,_is_list_or_tuple],conv2d_transpose->[_update_padding_nd],conv3d_transpose->[_update_padding_nd],conv3d->[_update_padding_nd]] | 2 - D Transpose layer for 2 - D convolution. 4 - D Tensor with [ N C H W W ) or [ N C H W The convolution kernel a Tensor with shape [ C g kH kW ). The dilation size of the kernel points. Missing element in the network. | support variable as input. |
@@ -0,0 +1,13 @@
+package config
+
+import (
+ "regexp"
+
+ "github.com/elastic/apm-server/sourcemap"
+)
+
+type Config struct {
+ LibraryPattern *regexp.Regexp
+ ExcludeFromGrouping *regexp.Regexp
+ SmapMapper sourcemap.Mapper
+}
| [No CFG could be retrieved] | No Summary Found. | we have so many configs that i would prefer to have more explicit names for each one, like eg. `FrontendConfig` for this one, but up to you |
@@ -10,6 +10,16 @@
#include "ec_lcl.h"
#include <openssl/err.h>
+int EC_GROUP_check_named_curve(const EC_GROUP *group, int nist_only)
+{
+ int nid;
+
+ nid = ec_curve_nid_from_params(group);
+ if (nid > 0 && nist_only && EC_curve_nid2nist(nid) == NULL)
+ nid = 0;
+ return nid;
+}
+
int EC_GROUP_... | [EC_GROUP_check->[EC_POINT_new,EC_GROUP_get0_order,EC_POINT_mul,EC_POINT_is_at_infinity,EC_POINT_is_on_curve,EC_POINT_free,EC_GROUP_check_discriminant,BN_CTX_free,BN_is_zero,BN_CTX_new,ECerr]] | EC_GROUP_check checks if a missing key in the group is found in the curve free the new context and point. | `ec_curve_nid_from_params()` is calling functions that might fail with an error (e.g., `EC_GROUP_cmp()`): should we allow it (and this) to return `-1` in case of unexpected errors? |
@@ -137,7 +137,11 @@ describe('amp-list component', () => {
it('should fail to load b/c data is absent', () => {
xhrMock.expects('fetchJson')
- .returns(Promise.resolve({})).once();
+ .returns(Promise.resolve({
+ json() {
+ return Promise.resolve({});
+ },
+ });.once();... | [No CFG could be retrieved] | This test tests the layout of a list and the templates of a list. findAndRenderTemplateArray - findAndRenderTemplateArray. | Ditto (This looks unintentional) |
@@ -257,10 +257,14 @@ func (p *provider) Diff(urn resource.URN, id resource.ID,
return DiffResult{}, err
}
- // If this function is called, we must have complete configuration for the underlying provider. Per DiffConfig,
- // any unknown input will cause the provider to be replaced, which will cause all of its r... | [Check->[label,getClient,Check],Create->[label,Create,getClient],Delete->[label,Delete,getClient],Invoke->[label,Invoke,getClient],Update->[label,Update,getClient],GetPluginInfo->[label,GetPluginInfo],Read->[label,Read,getClient],Error->[Error],Configure->[label,Pkg,Configure],Close->[Close],Diff->[label,Diff,getClient... | Diff performs a diff operation on the underlying provider. DiffResult returns a DiffResult object with all the properties that have been changed. | "cannot diff" sounds like an error and not a warning and this warning isn't actionable for users. Could we do something like: "This resource provider has inputs that are not known. Diffs of resources using this provider may be incorrect or unreliable." |
@@ -1,7 +1,12 @@
require "rails_helper"
require Rails.root.join("lib/data_update_scripts/20200410152018_resync_elasticsearch_documents.rb")
-describe DataUpdateScripts::ResyncElasticsearchDocuments, elasticsearch: true do
+describe DataUpdateScripts::ResyncElasticsearchDocuments, elasticsearch: %w[FeedContent User ... | [index_real_and_mock_documents->[id,index],refresh_indexes->[refresh_index],create,to,clear_all,describe,not_to,eq,join,run,sidekiq_perform_enqueued_jobs,index_real_and_mock_documents,it,require,raise_error,count] | This method synchronizes the given object s attributes with the corresponding Elasticsearch documents. This method mock documents that are indexed by the article comment and user. | We only need to refresh after specs that have bulk updates so rather than do this for every Elasticsearch spec I choose to keep it to the ones that were bulk update specific |
@@ -62,8 +62,14 @@ function $SnifferProvider() {
// older webkit browser (533.9) on Boxee box has exactly the same problem as Android has
// so let's not use the history API also
// We are purposefully using `!(android < 4)` to cover the case when `android` is undefined
+
+ // XPCNativeWrapper... | [No CFG could be retrieved] | Check if a key has a history object. Return an array of all the possible configuration values for a specific CSP. | I'm not sure how I feel about this (this is not intended to sound mean or anything, I apologize in advance if it comes across that way). What if there was an exported way to just force the sniffer not to use history api, instead? |
@@ -106,8 +106,9 @@ public class BeamFileSystemArtifactRetrievalService
.findFirst()
.orElseThrow(
() ->
- new FileNotFoundException(
- String.format("Artifact location not found in manifest: %s", name)));
+ ... | [BeamFileSystemArtifactRetrievalService->[create->[BeamFileSystemArtifactRetrievalService]]] | Gets an artifact from the proxy. Check if there is a in the cache. | Change to be extracted: proper error reporting (search for StatusRuntimeException in the PR - regular exceptions show up on the client as UNKNOWN) |
@@ -51,6 +51,7 @@ KNOWN_PRECISIONS = {
}
KNOWN_TASK_TYPES = {
'action_recognition',
+ 'sound_classification',
'classification',
'colorization',
'detection',
| [FileSourceHttp->[deserialize->[validate_string]],Model->[deserialize->[DeserializationError,validate_string,deserialization_context,validate_string_enum,deserialize]],TaggedBase->[deserialize->[DeserializationError]],run_in_parallel->[start->[JobWithQueuedOutput,QueuedOutputContext],complete,cancel],PostprocUnpackArch... | IMPORTS OF THE MODEL INFORMATION AND THE PROGRAM INFORMATION A class to create a JobContext object that will print a single unique identifier. | Please move this so that the list remains sorted (ditto for the `README`). |
@@ -161,6 +161,17 @@ public class Http2ConnectionHandler extends ByteToMessageDecoder implements Http
connection().remote().createStream(HTTP_UPGRADE_STREAM_ID, true);
}
+ @Override
+ public void flush(ChannelHandlerContext ctx) throws Http2Exception {
+ // Trigger pending writes in the rem... | [Http2ConnectionHandler->[BaseDecoder->[channelInactive->[connection]],close->[close],decode->[decode],checkCloseConnection->[operationComplete,isGracefulShutdownComplete],onHttpServerUpgrade->[prefaceSent],handlerRemoved0->[handlerRemoved],closeStream->[close],exceptionCaught->[exceptionCaught],channelInactive->[chann... | This method is invoked when a server - side HTTP upgrade is requested. | The old code doesn't have this ... why do we need this if all we're doing is coalescing data frames? |
@@ -654,8 +654,9 @@ class MatrixTransport:
self._userids_to_address.pop(user_id, None)
try:
- # FIXME: This should probably use ecrecover instead
- address = self._address_from_user_id(user_id)
+ user = self._client.get_user(user_id)
+ address = self._vali... | [MatrixTransport->[_maybe_invite_user->[start_health_check],_handle_presence_change->[UserPresence],_send_queued_messages->[send_queue->[send_async]]]] | Handle a user presence change event. | If I read the code right the `binascii.Error` shouldn't happen anymore and the assert can also be handled with a condition, so I'd say it would be more readable to remove the `try` block. |
@@ -185,6 +185,14 @@ MACHINE_CONFIG_START(coco_multipak_device::device_add_mconfig)
MCFG_COCO_CARTRIDGE_HALT_CB(DEVWRITELINE(DEVICE_SELF, coco_multipak_device, multi_slot4_halt_w))
MACHINE_CONFIG_END
+INPUT_PORTS_START( coco_multipack )
+ PORT_START( "MPI Slot Switch" )
+ PORT_DIPNAME( 0x03, 0x03, "Multi-Pak Slot ... | [No CFG could be retrieved] | MCFG_COCO_CARTRIDGE_CART_CB - Callback - Function to attach to the multipak device - constructor - machine config - end of network. | Is this actually a DIP switch? If it's some other kind of configuration switch or jumpers, it should use `PORT_CONFNAME` and `PORT_CONFSETTING`. DIP switches should be real DIP switches. |
@@ -552,6 +552,16 @@ class TypeChecker(NodeVisitor[Type]):
self.fail(messages.RETURN_TYPE_CANNOT_BE_CONTRAVARIANT,
typ.ret_type)
+ # check that Generator functions have the appropriate return type
+ if defn.is_generator:
+ if not self... | [TypeChecker->[visit_op_expr->[visit_op_expr],visit_operator_assignment_stmt->[accept,check_indexed_assignment],visit_unicode_expr->[visit_unicode_expr],visit_yield_from_expr->[accept],visit_func_expr->[visit_func_expr],visit_ellipsis->[visit_ellipsis],try_infer_partial_type_from_indexed_assignment->[accept],check_func... | Type check a function definition. Type check for the next argument in the function or method. | I wasn't sure how to write a unit test for this, but it should probably have one. |
@@ -52,6 +52,7 @@ module Users
end
def delete
+ send_delete_email_notification
result = DeleteUserEmailForm.new(current_user, email_address).submit
analytics.track_event(Analytics::EMAIL_DELETION_REQUEST, result.to_h)
if result.success?
| [EmailsController->[verify->[email,redirect_to,render,new,blank?],edit->[new],show->[new],handle_successful_delete->[t,create_user_event],process_updates->[email_changed?,redirect_to,t],email_address->[find],update->[to_h,new,render,track_event,bypass_sign_in,success?,submit],authorize_user_to_edit_email->[user],proces... | Deletes a single user s email address by ID. If the deletion is successful the browser will. | Won't this send an email even if the email is not deleted? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.