patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -950,4 +950,8 @@ export class BaseElement {
* @public
*/
onLayoutMeasure() {}
+
+ user() {
+ return user(this.element);
+ }
}
| [No CFG could be retrieved] | The onLayoutMeasure method is called when the user has requested a layout measure. | I get @lannka suggestion on using `user(this).error()`. But then I thought we are going to use `user(ampdoc).error()` in future. Then we have `this.user().error()` `user(element).error()` `user(ampdoc).error()` which is confusing to me. Do you think it's better to let `user().error` to accept `{Element|AmpElement|Ampdo... |
@@ -26,7 +26,6 @@ from tensorflow.python.ops import check_ops
from tensorflow.python.ops import control_flow_ops
from tensorflow.python.ops import math_ops
from tensorflow.python.ops import sparse_ops
-from tensorflow.python.util import deprecation
from tensorflow.python.util.tf_export import tf_export
| [confusion_matrix->[remove_squeezable_dimensions]] | Remove squeezable dimensions from the last dimension of the op. If the predictions and labels are missing or incompatible with the last rank of the last rank of. | Keep this import. It is still used below in this file. |
@@ -239,8 +239,8 @@ func NewRunRequest(requestParams JSON) *RunRequest {
// TaskRun stores the Task and represents the status of the
// Task to be ran.
type TaskRun struct {
- ID *ID `json:"id" gorm:"primary_key;not null"`
- JobRunID *ID `json... | [ApplyOutput->[SetError,SetStatus,HasError],PreviousTaskRun->[NextTaskRunIndex],Cancel->[SetStatus,NextTaskRun],ApplyBridgeRunResult->[SetError,SetStatus,HasError],NextTaskRun->[NextTaskRunIndex],TasksRemain->[NextTaskRunIndex],SetError->[SetStatus],String->[String]] | ErrorString returns the error message of the parent run. SetError sets the error of the task run and saves the error message. | Would be good to use either `uuid` type or `null.UUID` if it is nullable, and remove this `*ID` thing completely |
@@ -26,9 +26,15 @@ import (
const (
ByteDim int = iota
KeyDim
+ QueryDim
DimLen
)
+func IsSelectedDim(dim int) bool {
+ // TODO: configure
+ return dim == ByteDim || dim == KeyDim
+}
+
type dimStat struct {
typ RegionStatKind
Rolling *movingaverage.TimeMedian // it's used to statistic hot de... | [Clone->[GetLoad],Get->[Get],GetLoads->[GetLoad],Add->[Add],isFullAndHot->[isFull,isLastAverageHot],clearLastAverage->[clearLastAverage],GetLoad->[Get]] | Creates a dimStat object from a given key type and a length of the array. Get returns the number of times for the last average of the hot peer and the current value. | What is the purpose of this function? |
@@ -6,7 +6,7 @@ class Simpsons < PackageSpec
# go-to-def on a reference to Bart within the package goes here, but go-to-def on Bart in `import Bart` goes to the
# package.
import Bart
- # ^^^^ symbol-search: "Bart", name = "Simpsons::Bart", container = "Simpsons"
+ # ^^^^ symbol-search: "... | [Simpsons->[import,export]] | PackageSpec = PackageSpec. | It looks like you've regressed symbol search in `--stripe-packages` mode. We'll soon be using this mode internally at Stripe. Can we restore the container being part of the name in this case? |
@@ -228,11 +228,13 @@ class TypeJoinVisitor(TypeVisitor[Type]):
items = OrderedDict([
(item_name, s_item_type)
for (item_name, s_item_type, t_item_type) in self.s.zip(t)
- if is_equivalent(s_item_type, t_item_type)
+ if (is_equivalent(s_item_t... | [TypeJoinVisitor->[default->[default],visit_callable_type->[join_types],visit_instance->[join_types],join->[join_types],visit_overloaded->[join_types]],join_instances->[join_types],join_type_list->[join_types],join_similar_callables->[join_types],combine_similar_callables->[join_types],join_instances_via_supertype->[jo... | Visit a TypedDictType. | Why is the `set(items.keys()) &` part needed? Is there ever a TypedDict whose required_keys is not a subset of its items? |
@@ -75,7 +75,18 @@ class Timemory(CMakePackage):
else:
args.append('-DTIMEMORY_USE_MPI=OFF')
+ if '+gotcha' in spec:
+ args.append('-DTIMEMORY_USE_GOTCHA=ON')
+ else:
+ args.append('-DTIMEMORY_USE_GOTCHA=OFF')
+
+ if '+cuda' in spec:
+ args.a... | [Timemory->[cmake_args->[append,format],variant,depends_on,version,extends]] | Return a list of arguments for the CMake command. | You can remove this line now. |
@@ -8,7 +8,7 @@ import (
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
- gwAuthzRes "github.com/chef/automate/components/automate-gateway/api/authz/response"
+ gwAuthzRes "github.com/chef/automate/components/automate-gateway/api/iam/v2/response"
)
// FindStringSubmatch returns an array.
| [ReplaceAllString,Join,MatchString,FindStringSubmatch,Compile,Errorf,MustCompile,Split,FindAllStringSubmatch] | pairs import imports the given code into the given array. InvertMapParameterized reverses the method map with a compound key of resource & action. | I was thinking we would move these files under `authz` under `iam` as well. otherwise i'm not sure what the distinction between `authz` and `iam` is at this point |
@@ -122,7 +122,13 @@ public class HoodieHFileWriter<T extends HoodieRecordPayload, R extends IndexedR
@Override
public void writeAvro(String recordKey, IndexedRecord object) throws IOException {
- byte[] value = HoodieAvroUtils.avroToBytes((GenericRecord)object);
+ byte[] value = HoodieAvroUtils.avroToByt... | [HoodieHFileWriter->[close->[write->[write],close],getBytesWritten->[getBytesWritten]]] | Write an object to the avro file. | why do the avroToBytes twice? better to check the condition first.? |
@@ -328,12 +328,8 @@ function profile_content(App $a, $update = 0) {
$o .= conversation($a,$items,'profile',$update);
- if(! $update) {
- if(!get_config('system', 'old_pager')) {
- $o .= alt_pager($a,count($items));
- } else {
- $o .= paginate($a);
- }
+ if (!$update) {
+ $o .= alt_pager($a,count($items))... | [profile_content->[set_pager_itemspage,set_pager_total],profile_init->[get_hostname]] | Profile content. The main entry point for the contact visitor. Displays the block - based ACL and status editor. Get permissions SQL - if update is true then the SQL will update the permissions SQL - if check if there are any tags that are blocked on the item and if so get the total user has not specified a network for... | And this is the last one. |
@@ -401,6 +401,9 @@ public class UserPrefsAccessor extends Prefs
}-*/;
public final native int getAdditionalSourceColumns() /*-{
+ if (!this.additional_source_columns)
+ return 0;
+
return this.additional_source_columns;
}-*/;
| [UserPrefsAccessor->[allPrefs->[styleDiagnostics,useInternet2,disabledAriaLiveAnnouncements,handleErrorsInUserCodeOnly,launcherJobsSort,codeCompletionOther,hideObjectFiles,visualMarkdownCodeEditor,editorKeybindings,showLineNumbers,terminalInitialDirectory,gitDiffIgnoreWhitespace,serverEditorFont,warnVariableDefinedButN... | Get the additional_source_columns property. | @melissa-barca This was returning undefined for me and I couldn't open the global options. Unfortunately Java doesn't have the tools to check if a primitive type is undefined. Transpiling is so . I noticed that you were checking if this was defined in other places but I think because of the order of Ginjection this wa... |
@@ -159,7 +159,7 @@ class ProjectsController < ApplicationController
end
@project.last_modified_by = current_user
- if @project.update(project_params)
+ if !return_error && @project.update(project_params)
# Add activities if needed
if message_visibility.present?
Activity.create(... | [ProjectsController->[samples_index->[new],new->[new],create->[new,create],update->[archive,create,update]]] | Updates a node - lease project Displays a single nag ag with a success message and a success message if the user is. | Is this correct? This would mean that user which doesn't have archive/restore permissions can't update the project (e.g. `can_manage_project` permission). |
@@ -28,6 +28,10 @@ public final class CodeGenUtil {
return PARAM_NAME_PREFIX + index;
}
+ public static String schemaName(int index) {
+ return SCHEMA_NAME_PREFIX + index;
+ }
+
public static String functionName(FunctionName fun, int index) {
return fun.name() + "_" + index;
}
| [CodeGenUtil->[functionName->[name]]] | paramName - param name. | why 'schema'? Surely... 'struct'? |
@@ -28,12 +28,10 @@ import (
"os/exec"
"path"
"path/filepath"
- "runtime"
"sort"
"strings"
"time"
- "github.com/jstemmer/go-junit-report/formatter"
"github.com/jstemmer/go-junit-report/parser"
"github.com/magefile/mage/mg"
"github.com/magefile/mage/sh"
| [String->[Strings,Fprintf,Fprintln,TrimRight,String],Failures->[String,TrimRight,Fprintln,TrimSpace],Test,Now,Close,Wrap,Clean,JUnitReportXML,Failures,ReadDir,Errorf,Bytes,RunV,Since,NewBuffer,Wrapf,Join,Create,Name,ToLower,MultiWriter,Ext,Split,Printf,Println,IsDir,TrimSuffix,Sprintf,Version,RunCmd,Environ,Replace,Par... | This function is responsible for adding additional information to the given object. makeJUnitXMLTestArgs creates a JUnit XML test report from the given . | Is it still needed? |
@@ -59,6 +59,16 @@ public class ApiClientTest extends BaseApiTest {
"query=+%22.%2B%22",
queryParamWithDoubleQuotes.getQuery());
+ final URL queryParamWithColon = api.get(EmptyResponse.class).path("/some/resource").queryParam("query", "mac:00\\:12\\:f0\\:53\\:42\\:2b").node(no... | [ApiClientTest->[testParallelExecution->[assertTrue,path,all,create,executeOnAll,setupNodes,isExpectationsFulfilled,iterator,toString,isEmpty,setHttpClient,assertFalse,next,expectResponse,prepareUrl],testSingleExecute->[assertNotNull,assertTrue,execute,create,any,setupNodes,isExpectationsFulfilled,timeout,toString,setH... | Test build target. | Why do backslashes need to be URL-encoded? |
@@ -31,3 +31,12 @@ class RepeatQueryAgent(Agent):
reply['text'] = 'Nothing to repeat yet.'
reply['episode_done'] = False
return Message(reply)
+
+ def batch_act(self, observations):
+ batch_reply = []
+ original_obs = self.observation
+ for obs in observations:
+ ... | [RepeatQueryAgent->[act->[Message,split,get,getID],__init__->[super]]] | Get the last message from the observation. | Why should we save the `original_obs`? Not quite sure if I understand the logic here. |
@@ -6,10 +6,12 @@
<h4 class="modal-title"><%= t '.title', resource_name: project.name %></h4>
</div>
<div class="modal-body">
- <% project.users.each do |user| %>
- <%= render('access_permissions/partials/project_member_field.html.erb', user: user, project: project, update_path: update_path) %>
+ ... | [No CFG could be retrieved] | Renders a modal window showing the user - assigned resource ID. | can you move it to the scope in assignable concern? |
@@ -229,7 +229,7 @@ mv %{?buildroot}/%{_prefix}/etc/bash_completion.d %{?buildroot}/%{_sysconfdir}
%pre server
getent group daos_admins >/dev/null || groupadd -r daos_admins
-getent passwd daos_server >/dev/null || useradd -M daos_server
+getent passwd daos_server >/dev/null || useradd -s /sbin/nologin -r daos_serv... | [No CFG could be retrieved] | \ - q - setup - q - setup - setup - setup - list of files in system. | Didn't you also want to make this a system account so it doesn't have a home directory? |
@@ -169,7 +169,6 @@ namespace System.Net.Tests
}
[Fact]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/30284")]
public void ListenerRestart_BeginGetContext_Success()
{
using (HttpListenerFactory factory = new HttpListenerFactory())
| [SimpleHttpTests->[BasicTest_StartCloseAbort_NoException->[Start,Close,Abort],ListenerRestart_BeginGetContext_Success->[BeginGetContext,Start,Stop,GetListener],BasicTest_StartAbortClose_NoException->[Start,Close,Abort],Dispose->[Dispose],BasicTest_StopNoStart_NoException->[Close,Stop],BasicTest_AbortNoStart_NoException... | ListenerRestart_BeginGetContext_Success - No listener restarts the context if there is. | Can you expand this test to give the same level of coverage as the sync test below? However, the catch block around Start() should be more discriminating about what exceptions it considers a port conflict. |
@@ -19,10 +19,10 @@
</span>
</a>
<% if comment.user.twitter_username.present? %>
- <a href="http://twitter.com/<%= comment.user.twitter_username %>" rel="noopener noreferrer" target="_blank"<%= image_tag("twitter-logo.svg", class:"icon-img") %></a>
+ <a href="htt... | [No CFG could be retrieved] | Renders a single node with a hidden hidden node and a list of comments that can be deleted displays a dropdown showing the user s nag and its permalinks. | Think this is on us, but if you could add a `>` between the `"blank"` and `<%= image_tag` to close out the `a` tag that'd be great! |
@@ -301,13 +301,7 @@ RSpec.describe "Articles", type: :request do
expect { get "#{article.path}/stats" }.to raise_error(Pundit::NotAuthorizedError)
end
- it "returns unauthorized if the user is not pro" do
- article = create(:article, user: user)
- expect { get "#{article.path}/stats" }.to ra... | [create,include_context,let,describe,build_stubbed,match_array,slug,it,name,map,to,user_feed_path,before,body,profile_image_90,shared_context,let!,require,username,organization,include,parse,user,have_http_status,url,title,id,add_role,path,context,get,not_to,eq,tag_feed_path,sign_in,tag_list,take,raise_error] | checks that the user is authorized to view the page. | This test no longer applies since we are no longer authorizing against the `:pro` role at all for the `/stats` route of an article, so I removed it! |
@@ -253,14 +253,14 @@ class TableTestAsync(AsyncTableTestCase):
await self._create_table(ts, prefix + str(i), table_names)
# Act
- generator1 = ts.list_tables(query_options=QueryOptions(top=2)).by_page()
+ generator1 = ts.list_tables(results_per_page=2).by_page()
tables1 =... | [TableTestAsync->[test_list_tables_with_marker->[_create_table],test_create_table->[_get_table_reference],test_delete_table_with_non_existing_table_fail_not_exist->[_get_table_reference],test_account_sas->[_create_table,_delete_table],test_list_tables_with_num_results->[_create_table],test_list_tables->[_create_table],... | This test tests list tables with marker. | Why are we no longer using async loops here? |
@@ -1,4 +1,5 @@
-"""Utilities to support packages."""
+
+""" Utilities to support packages """
# NOTE: This module must remain compatible with Python 2.3, as it is shared
# by setuptools for distribution with Python 2.3 and up.
| [get_data->[load_module,get_loader,get_data],iter_importers->[get_importer,ImpImporter],walk_packages->[walk_packages,seen],ImpLoader->[_get_delegate->[ImpImporter],get_code->[read_code,_fix_name,_reopen],is_package->[_fix_name],get_source->[_fix_name,_reopen],load_module->[load_module],get_filename->[_get_delegate,_fi... | Utilities to support packages. Yields for all modules recursively and submodules of the given package. | This kind of change is pure, useless noise in a diff. Please try to avoid such changes in pull requests. |
@@ -2194,8 +2194,11 @@ func (d *driver) getFile(ctx context.Context, file *pfs.File, offset int64, size
if err != nil {
return nil, err
}
+ if len(paths) <= 0 {
+ return nil, fmt.Errorf("no file(s) found that match %v", file.Path)
+ }
- var objects []*pfs.Object
+ objects := []*pfs.Object{}
var totalSize in... | [getTreeForOpenCommit->[scratchFilePrefix],upsertPutFileRecords->[scratchFilePrefix],deleteFile->[makeCommit,getPachClient,inspectCommit,checkIsAuthorized],listRepo->[getAccessLevel],scratchFilePrefix->[scratchCommitPrefix],getTreeForFile->[inspectCommit,getTreeForCommit],listBranch->[getPachClient,checkIsAuthorized],c... | getFile returns a reader for the given file. | Any reason you changed this? Doing it with `var` is more standard for our codebase. And it's slightly shorter, 25 characters vs 26, think of all the bits we'll save. |
@@ -1085,12 +1085,12 @@ function builtin_activity_puller($item, &$conv_responses) {
// $id = item id
// returns formatted text
-if(! function_exists('format_like')) {
+if (! function_exists('format_like')) {
function format_like($cnt,$arr,$type,$id) {
$o = '';
$expanded = '';
- if($cnt == 1) {
+ if ($cnt ==... | [localize_item->[attributes],get_responses->[get_id],conversation->[add_thread,get_template_data]] | Format like like like dislike like dislike like and attend maybe like like and like generate the content of a single node if (!expanded ). | Standards: Please add a space after commas. |
@@ -57,6 +57,13 @@ def build_argparser():
required=True, type=str)
args.add_argument("-i", "--input", help="Required. Path to a folder with images or path to an image files",
required=True, type=str, nargs="+")
+ args.add_argument("-c", "--classes", help="Optional. ... | [build_argparser->[add_argument_group,ArgumentParser,add_argument],main->[basicConfig,argmax,transpose,imwrite,info,enumerate,Exception,infer,int,expand_dims,min,imread,ndarray,build_argparser,zeros,warning,range,add_extension,len,format,read_network,iter,next,splitext,resize,load_network,IECore],exit,main] | Build the argument parser for the command. | Please, rename it to `--labels`. |
@@ -72,8 +72,9 @@ public class SecurityResourceFilterTest extends ResourceFilterTestHelper
getRequestPathsWithAuthorizer(StatusResource.class),
getRequestPathsWithAuthorizer(SelfDiscoveryResource.class),
getRequestPathsWithAuthorizer(BrokerQueryResource.class),
- getReq... | [SecurityResourceFilterTest->[testResourcesFilteringAccess->[filter,replay,setUpMockExpectations,verify],testResourcesFilteringNoAccess->[verify,setUpMockExpectations,replay,filter,fail],data->[concat,copyOf,getRequestPathsWithAuthorizer],setUp->[setUp]]] | This method returns a collection of all resources that can be accessed by the application. | Indentation for `)` seems off |
@@ -8,5 +8,6 @@ type Status int
const (
StatusOK Status = iota
+ StatusPartialFailure
StatusUnknown
)
| [No CFG could be retrieved] | Create a new ethernet ethernet status object. | anything bad likely to happen by adding an enum value in the middle here? are these values persisted or used outside this one binary? |
@@ -35,12 +35,15 @@ import io.prestosql.spi.connector.ConnectorTableHandle;
import io.prestosql.spi.connector.ConnectorTableMetadata;
import io.prestosql.spi.connector.ConnectorTableProperties;
import io.prestosql.spi.connector.ConnectorViewDefinition;
+import io.prestosql.spi.connector.Constraint;
+import io.presto... | [MemoryMetadata->[createView->[checkSchemaExists],renameView->[checkSchemaExists]]] | Imports all the fields of the given object. Method to import all the elements of a Collection. | What is the motivation behind this? What is the difference if engine would apply predicate or if predicate is applied by connector? |
@@ -175,7 +175,17 @@ public interface TimerInternals {
*/
public static TimerData of(
String timerId, StateNamespace namespace, Instant timestamp, TimeDomain domain) {
- return new AutoValue_TimerInternals_TimerData(timerId, namespace, timestamp, domain);
+ return new AutoValue_TimerIntern... | [TimerDataCoder->[decode->[of,decode],verifyDeterministic->[verifyDeterministic],of->[TimerDataCoder],encode->[getTimestamp,getTimerId,encode],of],TimerData->[of->[of],compareTo->[getTimerId,getNamespace]]] | Create a timer data object for the given timer id namespace timestamp and time domain. | We need to make sure existing state remains compatible |
@@ -10,17 +10,6 @@ from ..remote import InvalidRPCMethod
from .. import nonces # for monkey patching NONCE_SPACE_RESERVATION
-@pytest.fixture(autouse=True)
-def clean_env(monkeypatch):
- # Workaround for some tests (testsuite/archiver) polluting the environment
- monkeypatch.delenv('BORG_PASSPHRASE', False)... | [TestNonceManager->[test_empty_cache->[MockRepository,expect_iv_and_advance,MockEncCipher,cache_nonce],test_transaction_abort_old_server->[set_cache_nonce,cache_nonce,expect_iv_and_advance,MockEncCipher,MockOldRepository],test_transaction_abort_no_cache->[MockRepository,expect_iv_and_advance,MockEncCipher,cache_nonce],... | Clean environment variables that are not needed by the test suite. | btw one can actually import fixtures like anything else, it works like you'd expect. |
@@ -46,7 +46,6 @@ import java.net.URLConnection;
import java.net.URLEncoder;
import java.util.ArrayList;
import java.util.List;
-import java.util.concurrent.TimeUnit;
import java.util.logging.Level;
import java.util.logging.Logger;
import jenkins.model.DownloadSettings;
| [DownloadService->[DownloadableListener->[installListener->[DownloadableListener]],Downloadable->[load->[getDataFile],getData->[getDataFile],getUrls->[getUrl],updateNow->[getId,load,loadJSONHTML],get->[all],doPostBack->[getInterval]]]] | Imports the given object as an extension of a given type. Provides a Service that can be used to download a single . | @daniel-beck : this line's removal needs to be unremoved. |
@@ -46,7 +46,14 @@ public class JsonPathEvaluator extends JsonPathBaseEvaluator {
Object result = null;
try {
result = documentContext.read(compiledJsonPath);
+ } catch (PathNotFoundException pnf) {
+ // it is valid for a path not to be found, keys may not be there
+ ... | [JsonPathEvaluator->[evaluate->[getValue,getResultRepresentation,error,StringQueryResult,getDocumentContext,read,getPath,getJsonPath],getLogger]] | Evaluate the . | Should be wrapped in a `isDebuggedEnabled` check |
@@ -192,9 +192,15 @@ public class QueryMaker
morePages.set(false);
final AtomicBoolean gotResult = new AtomicBoolean();
+ queryWithPagination = (SelectQuery) QueryMaker.withDefaultTimeoutAndMaxScatterGatherBytes(
+ queryWithPagination,
+ ... | [QueryMaker->[rep->[ISE,contains,of],executeTopN->[apply->[getValue,size,getMetric,getSqlTypeName,get,getIndex,simple,add,coerce],newHashMap,concat,getFieldList,run,map],runQuery->[isUseApproximateTopN,executeTopN,IllegalStateException,getQueryContext,executeGroupBy,toTimeseriesQuery,executeSelect,executeTimeseries,get... | Executes a Select query with a single page of results. private boolean morePages = false ;. | IMO, non-finals that are redefined halfway through a method make things difficult to follow. Why not apply this to `queryWithPagination` directly when it's created? |
@@ -3579,6 +3579,14 @@ void commit_params(struct dt_iop_module_t *self, dt_iop_params_t *params, dt_dev
d->green_eq = DT_IOP_GREEN_EQ_NO;
d->color_smoothing = 0;
d->median_thrs = 0.0f;
+
+ if((pipe->image.flags & DT_IMAGE_RAW) && dt_dev_pixelpipe_uses_downsampled_input(pipe))
+ {
+ // Always e... | [No CFG could be retrieved] | This function is called from DT_IOP_DEMOSAIC_DEM - - - - - - - - - - - - - - - - - -. | hard to tell from the crippled diff on github. but this is only disabling opencl for the monochrome case, right? |
@@ -260,7 +260,7 @@ func (r *SourceRepository) RemoteURL() (*url.URL, bool, error) {
case "file":
gitRepo := git.NewRepository()
remote, ok, err := gitRepo.GetOriginURL(r.url.Path)
- if err != nil && err != git.ErrGitNotAvailable {
+ if err != git.ErrGitNotAvailable {
return nil, false, err
}
if !ok... | [LocalPath->[String],Detect->[Detect],String->[String],NotUsed->[InUse],IsDockerBuild,RemoteURL,ContextDir,Info,Contents] | RemoteURL returns the remote URL of the repository. | This changes the behavior of the method. With this change if you have a `nil` error and `ok == true`, you'll return here with an incorrect (`false`) return value. |
@@ -292,4 +292,8 @@ module ApplicationHelper
def admin_config_description(content)
tag.p(content, class: "crayons-field__description") unless content.empty?
end
+
+ def role_display_name(role)
+ role.name == "banned" ? "Suspended" : role.name.titlecase
+ end
end
| [title_with_timeframe->[title],community_emoji->[community_emoji],community_name->[community_name],sanitized_referer->[sanitized_referer],invite_only_mode?->[invite_only_mode?]] | Generates a description tag for the admin config field. | I pulled this out into a helper method to clean up the admin views a bit and make this code more reusable per @citizen428 's suggestion on my previous PR! |
@@ -31,7 +31,7 @@ module Idv
end
def applicant_from_params
- app_vars = applicant_params.delete_if { |_key, value| value.blank? }
+ app_vars = idv_params.merge(financial_params.delete_if { |_key, value| value.blank? })
Proofer::Applicant.new(app_vars)
end
| [SessionsController->[create->[redirect_to,t,success,init_questions_and_profile],pick_a_vendor->[test?,sample],applicant_from_params->[new,delete_if,blank?],available_vendors->[map],applicant_params->[slice],start_idv_session->[new,vendor,start,idv_applicant,proofing_requires_kbv?,idv_vendor],init_questions_and_profile... | This method is called when the user has requested to access the applicant object. | Could you please explain the reasoning behind extracting the financial_params out of the applicant_params? It seems like the only place the `financial_params` are used is here, to merge them back again with the applicant params. |
@@ -364,9 +364,13 @@ class Options extends Module {
public function jetpack_sync_core_icon() {
$url = get_site_icon_url();
- require_once JETPACK__PLUGIN_DIR . 'modules/site-icon/site-icon-functions.php';
+ $jetpack_url = \Jetpack_Options::get_option( 'site_icon_url' );
+ if ( function_exists( 'jetpack_site_i... | [Options->[send_full_sync_actions->[send_action],whitelist_options->[is_whitelisted_option,filter_theme_mods,is_contentless_option],set_defaults->[update_options_contentless,update_options_whitelist],get_all_options->[filter_theme_mods],expand_options->[get_all_options]]] | Syncs the core icon with the Jetpack core icon. | Oof, same here, this is too long and not very readable, can we fix it please? |
@@ -0,0 +1,5 @@
+from azure.core.trace.abstract_span import AbstractSpan
+from azure.core.trace.context import tracing_context
+
+__all__ = ["tracing_context", "AbstractSpan"]
+
| [No CFG could be retrieved] | No Summary Found. | I'd call the package `tracing`. |
@@ -2158,6 +2158,8 @@ namespace System.Net.Sockets
internal IAsyncResult UnsafeBeginConnect(EndPoint remoteEP, AsyncCallback? callback, object? state, bool flowContext = false)
{
+ if (SocketsTelemetry.Log.IsEnabled()) SocketsTelemetry.Log.ConnectStart(remoteEP);
+
if (CanUse... | [Socket->[DoBeginSendTo->[SocketError],SetIPProtectionLevel->[SetIPProtectionLevel],SetLingerOption->[SetLingerOption],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanUseConnectEx,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],... | UnsafeBeginConnect - begin a connect operation with a specific end point. | Style-wise I've always found it preferable to eliminate these IsEnabled() calls entirely and rely on the checks that occur inside the EventSource, but I think the mono-linker will fully remove this pattern so its purely style and tiny perf at this point. Style is best decided by the folks who have to work on the code r... |
@@ -21,7 +21,7 @@ export const SEGMENT_CONFIG = /** @type {!JsonObject} */ ({
'image': true,
},
'vars': {
- 'anonymousId': 'CLIENT_ID(segment_amp_id)',
+ 'anonymousId': 'CLIENT_ID(_ga)',
},
'requests': {
'host': 'https://api.segment.io/v1/pixel',
| [No CFG could be retrieved] | Provides a JSON object with the data required to handle a specific . A segment is a segment that is not a proxy. | can you change this to `CLIENT_ID(AMP_ECID_GOOGLE,,_ga)` |
@@ -53,8 +53,8 @@ public class CreateBucketHandler extends BucketHandler {
enum AllowedBucketLayouts {FILE_SYSTEM_OPTIMIZED, OBJECT_STORE}
- @Option(names = { "--type", "-t" },
- description = "Allowed Bucket Types: ${COMPLETION-CANDIDATES}",
+ @Option(names = { "--bucketlayout", "-l" },
+ descriptio... | [CreateBucketHandler->[execute->[getVolume,toString,printf,createBucket,getVolumeName,printObjectAsJson,IllegalArgumentException,getBucket,getBucketName,getQuotaInNamespace,isEmpty,addMetadata,setQuotaInNamespace,valueOf,isNullOrEmpty,isVerbose,getQuotaInBytes,setBucketEncryptionKey,setBucketLayout,setQuotaInBytes,buil... | Creates a new bucket in a given volume. Replies the object that holds the optional optional bucket encryption key. | Can we simplify `bucketlayout` to `layout`? The command name `... bucket create` implies the layout is for the bucket. Also, should we keep `--type`, `-t` as alias for compatibility? |
@@ -146,12 +146,9 @@ public class TestJdbcMetadata
private void unknownTableMetadata(JdbcTableHandle tableHandle)
{
- try {
- metadata.getTableMetadata(SESSION, tableHandle);
- fail("Expected getTableMetadata of unknown table to throw a TableNotFoundException");
- }
- ... | [TestJdbcMetadata->[testCreateAndAlterTable->[getTableMetadata],testDropTableTable->[getTableMetadata],unknownTableMetadata->[getTableMetadata],applyFilter->[applyFilter],getColumnMetadata->[getColumnMetadata],getTableMetadata->[getTableMetadata]]] | Checks that all schemas and tables are in the session. | shall we also validated a message? |
@@ -238,6 +238,7 @@ class StopIteration(Exception):
def any(i: Iterable[T]) -> bool: pass
def all(i: Iterable[T]) -> bool: pass
+def sum(i: Iterable[T]) -> int: pass
def reversed(object: Sequence[T]) -> Iterator[T]: ...
def id(o: object) -> int: pass
# This type is obviously wrong but the test stubs don't have S... | [TypeVar] | Checks if an iterable is a sequence of objects. | Ah, this will need to take a start argument. It looks like that is the cause of a bunch of the test failures. |
@@ -124,6 +124,14 @@ void SmallStrainIsotropicDamage3D::InitializeMaterial(
//************************************************************************************
//************************************************************************************
+bool SmallStrainIsotropicDamage3D::RequiresInitializeMaterialResp... | [Check->[Has],load->[save],save->[save],EvaluateHardeningLaw->[EvaluateHardeningModulus],CalculateValue->[EvaluateHardeningLaw]] | Initialize Material Response Cauchy. | maybe move to header for readability |
@@ -33,7 +33,13 @@ func isGitFolder(path string) bool {
func isRepositoryFolder(path string) bool {
info, err := os.Stat(path)
- return err == nil && info.IsDir() && info.Name() == BookkeepingDir
+ if err == nil && info.IsDir() && info.Name() == BookkeepingDir {
+ // make sure it has a settings.json file in it
+ ... | [Join,Stat,IsDir,TrimSuffix,WalkUp,Name,Ext] | DetectPackage finds the closest package in the given path. IsDir - Check if the name of the missing file is expected. | Nit: Use a full sentence, capital M and end with a period. |
@@ -68,6 +68,7 @@ public class HoodieTableConfig extends HoodieConfig implements Serializable {
private static final Logger LOG = LogManager.getLogger(HoodieTableConfig.class);
public static final String HOODIE_PROPERTIES_FILE = "hoodie.properties";
+ public static final String DEFAULT_HOODIE_TABLE_KEY_GENERAT... | [HoodieTableConfig->[getPartitionFields->[empty,contains,toArray,of],getPreCombineField->[getString],getLogFileFormat->[getStringOrDefault,valueOf],getTableName->[getString],getArchivelogFolder->[getStringOrDefault],createHoodieProperties->[Path,create,IllegalArgumentException,equals,mkdirs,setDefaultValue,key,setValue... | This class is used to provide a base path for Hoodie tables. This is a config property that is used to precombine fields before actual write. | call this the default is very confusing. |
@@ -148,7 +148,7 @@ import org.kohsuke.stapler.interceptor.RequirePOST;
@ExportedBean
public class UpdateCenter extends AbstractModelObject implements Saveable, OnMaster {
- private static final String UPDATE_CENTER_URL = SystemProperties.getString(UpdateCenter.class.getName()+".updateCenterUrl","https://updates... | [UpdateCenter->[getConnectionCheckJob->[getSite,getConnectionCheckJob],updateDefaultSite->[getSite],getAvailables->[getAvailables],getCategorizedAvailables->[getAvailables],UpdateCenterJob->[submit->[submit]],isRestartScheduled->[getJobs],HudsonDowngradeJob->[getURL->[getData],onSuccess->[Success],run->[onSuccess,_run,... | Updates center with a specific configuration. Creates an alias for the _upload string. | Although maybe adding `//TODO: revert when integrating into master` (or something like that) would be good. |
@@ -194,6 +194,14 @@ func (r *Runtime) removeContainer(ctx context.Context, c *Container, force bool)
// Lock the pod while we're removing container
pod.lock.Lock()
defer pod.lock.Unlock()
+ if err := pod.updatePod(); err != nil {
+ return err
+ }
+
+ infraID := pod.state.InfraContainerID
+ if c.ID() == ... | [GetRunningContainers->[GetContainers],LookupContainer->[LookupContainer],removeContainer->[RemoveContainer],HasContainer->[HasContainer],GetContainersByList->[LookupContainer],GetLatestContainer->[GetAllContainers]] | removeContainer removes a container from the runtime Remove a container from the system Cleanup the container and its storage and delete it. | Suggest rewording to "container %s is the infra container of pod %s and cannot be removed without removing the pod" |
@@ -60,6 +60,7 @@ func init() {
check.Suite(&TimeoutSuite{})
check.Suite(&TracingSuite{})
check.Suite(&WebsocketSuite{})
+ check.Suite(&HostResolverSuite{})
}
if *host {
// tests launched from the host
| [TearDownSuite->[Stop],cmdTraefik->[Command],adaptFile->[ExecuteTemplate,TempFile,Sync,ParseFiles,Name,Close,Assert,Split],traefikCmd->[Failed,displayTraefikLog,cmdTraefik],createComposeProject->[InterfaceAddrs,To4,Sprintf,IsLoopback,CreateProject,Setenv,String,Assert,ParseCIDR],displayTraefikLog->[Printf,Println,TestN... | Test creates a function that runs the integration tests. createComposeProject creates a compose project for integration tests. | Can you insert your test suite after `HealthCheckSuite` (alphabetical order)? |
@@ -26,10 +26,6 @@
public List<MessageHandler> GetHandlersFor(Type messageType)
{
Guard.AgainstNull(nameof(messageType), messageType);
- if (!conventions.IsMessageType(messageType))
- {
- return noMessageHandlers;
- }
var mess... | [MessageHandlerRegistry->[CacheMethod->[DebugFormat,Add,GetMethod],RegisterHandler->[nameof,TryGetValue,AgainstNull,ValidateHandlerType,IsAbstract,GetMessageTypesBeingHandledBy,CacheHandlerMethods],Clear->[Clear],GetMethod->[MakeGenericType,ParameterType,FirstOrDefault,IsAssignableFrom,Compile,Convert,GetParameters,Cal... | Get all message handlers for a given message type. | Looks like this is the only place that `noMessageHandlers` was used, so the static field can be removed. |
@@ -105,9 +105,11 @@ namespace Microsoft.Xna.Framework.Graphics
private Rectangle _scissorRectangle;
private bool _scissorRectangleDirty;
-
- private VertexBuffer _vertexBuffer;
- private bool _vertexBufferDirty;
+
+ private int _numVertexBufferSlots;
+ private ... | [GraphicsDevice->[Flush->[Flush],Clear->[Clear],SetRenderTarget->[SetRenderTarget],SetUserVertexBuffer->[Dispose,SetVertexBuffer],DrawPrimitives->[ApplyState,PrimitiveTopology],Present->[Present,Clear],DrawUserPrimitives->[SetUserVertexBuffer,GraphicsDevice,DrawUserPrimitives,ApplyState,PrimitiveTopology],Initialize->[... | Create a new object that represents a single object that can be used to render a single object Shader for the vertex and pixel shader. | I guess this is really the `_numActiveVertexBufferSlots`? |
@@ -125,8 +125,8 @@ class WindowEvaluatorFactory implements TransformEvaluatorFactory {
}
@Override
- public Collection<? extends BoundedWindow> windows() {
- return value.getWindows();
+ public BoundedWindow window() {
+ return Iterables.getOnlyElement(value.getWindows());
}
}
| [WindowEvaluatorFactory->[WindowIntoEvaluator->[assignWindows->[assignWindows]]]] | Returns a collection of all windows in this histogram. | The evaluator doesn't currently explode input windows, so this will break for any element that enters in multiple windows - I've authored #313 to cover this |
@@ -1033,9 +1033,12 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
public void setInstallState(@Nonnull InstallState newState) {
InstallState prior = installState;
installState = newState;
- if (!prior.equals(newState)) {
+ LOGGER.info("setInstal... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],_cleanUpCloseDNSMulticast->[add],getViewActions->[getActions],getJDK->[getJDKs],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[getActiveInstance]... | Sets the install state. | Is it safe to save the entire Jenkins instance at the current state. IIUC it may be not fully initialized though the state should likely indicate it |
@@ -144,7 +144,10 @@ public class SQLMetadataSegmentManager implements MetadataSegmentManager
delay.getMillis(),
TimeUnit.MILLISECONDS
);
- started = true;
+ lifecycleLock.started();
+ }
+ finally {
+ lifecycleLock.exitStart();
}
}
| [SQLMetadataSegmentManager->[getAllDatasourceNames->[withHandle->[fold],withHandle],getSegmentsTable->[getSegmentsTable],removeSegment->[withHandle],removeDatasource->[withHandle],enableSegment->[withHandle]]] | Start polling for a . | Here, there is no guarantee that `dataSourcesRef` is safe. it may be updated in `for loop` above. @jihoonson @gianm @jon-wei |
@@ -9800,12 +9800,9 @@ LRestart:
break;
case tkID:
+ case tkLET:
if (m_token.GetIdentifier(this->GetHashTbl()) == wellKnownPropertyPids.let)
{
- if (labelledStatement)
- {
- Error(ERRLabelBeforeLexicalDeclaration);
- }
// ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - Parse an identifier that can be used to parse a variable declaration. | Does this not also apply to const? |
@@ -77,6 +77,10 @@ class BinaryInstaller
$this->io->writeError(' <warning>Skipped installation of bin '.$bin.' for package '.$package->getName().': file not found in package</warning>');
continue;
}
+ if (is_dir($binPath)) {
+ $this->io->writeE... | [BinaryInstaller->[initializeBinDir->[ensureDirectoryExists],generateWindowsProxyCode->[findShortestPath],installFullBinaries->[installUnixyProxyBinaries,generateWindowsProxyCode,writeError,getName],removeBinaries->[initializeBinDir,isDirEmpty,unlink,getBinaries],installUnixyProxyBinaries->[generateUnixyProxyCode],inst... | Installs all binaries of a package. | do you have a test whether the binary installer works if the binary target is a symlink? |
@@ -57,10 +57,9 @@ StructureModel.AddModelPart(main_model_part)
## Print model_part and properties
if ((parallel_type == "OpenMP") or (mpi.rank == 0)) and (echo_level > 1):
- print("")
- print(main_model_part)
+ Logger.PrintInfo(main_model_part)
for properties in main_model_part.Properties:
- p... | [PrintOutput,SetValue,AddDofs,ExecuteAfterOutputStep,ExecuteFinalize,PrettyPrintJsonString,CreateSolver,ExecuteBeforeSolutionLoop,Has,GiDOutputProcessMPI,ProjectParameters,GetComputingModelPart,ImportModelPart,Parameters,AddModelPart,ExecuteBeforeOutputStep,KratosProcessFactory,ModelPart,print,AddVariables,Solve,read,c... | Creates a model part from the main model part and its properties. Initialize the processes and the solver. | The first argument here should be label! if you want to use it as a print you may use the `Logger.Print()` method. |
@@ -25,12 +25,14 @@ use Composer\Config;
*/
class VcsRepositoryTest extends \PHPUnit_Framework_TestCase
{
+ private static $composerHome;
private static $gitRepo;
private $skipped;
protected function initialize()
{
$oldCwd = getcwd();
+ self::$composerHome = sys_get_temp_dir... | [VcsRepositoryTest->[tearDownAfterClass->[removeDirectory],testLoadVersions->[assertEmpty,getPackages,getPrettyVersion,dump,fail],initialize->[find,getErrorOutput,execute],setUp->[initialize,markTestSkipped]]] | Initializes the node - git branch and commits the git repository. create tag with wrong version in it . | The home dir must be configured because the cache dir is relative to it. |
@@ -251,7 +251,7 @@ public class TransactionCapsule implements ProtoCapsule<Transaction> {
} catch (ContractValidateException | InvalidProtocolBufferException e) {
logger.debug(e.getMessage(), e);
}
- return null;
+ return new byte[0];
}
public static byte[] hashShieldTransaction(Transact... | [TransactionCapsule->[getToAddress->[getToAddress],getTimestamp->[getTimestamp],validateSignature->[validatePubSignature,getOwner,checkWeight],checkWeight->[getWeight],getContractRet->[getContractRet],getCallValue->[getCallValue],addSign->[getWeight,sign,getOwner,checkWeight],validContractProto->[validContractProto,par... | This method is used to get the ShieldedTransfer contract from a Transaction. | the class of TransactionUtil has a similar function. Please modify it and check the function where invoked to determine the return value whether null or new byte[0]. |
@@ -26,7 +26,7 @@ class CarController():
left_line, right_line, lead, left_lane_depart, right_lane_depart):
# gas and brake
- if CS.CP.enableGasInterceptor and enabled:
+ if CS.CP.enableGasInterceptor and CS.CP.openpilotLongitudinalControl and enabled:
MAX_INTERCEPTOR_GAS = 0.5
... | [CarController->[__init__->[CANPacker],update->[round,make_can_msg,int,create_lta_steer_command,append,create_fcw_command,create_gas_interceptor_command,create_accel_command,create_acc_cancel_command,copy,apply_toyota_steer_torque_limits,clip,create_steer_command,interp,create_ui_command]]] | Update the car with the given parameters. can send a message if the frame is on a channel and the channel is on a channel command to send a message if it is not already in the list This function returns a list of actions that can be sent to the card if there is something. | It's fine to make the `interceptor_gas_cmd`. You want to gate the sending on line 103 |
@@ -78,9 +78,9 @@ class WikiTablesParserPredictor(Predictor):
with open(logical_form_filename, 'w') as temp_file:
temp_file.write(logical_form + '\n')
- table_dir = os.path.join(SEMPRE_DIR, 'csv/')
+ table_dir = os.path.join(SEMPRE_DIR, 'tsv/')
os.makedirs(table_dir, exist... | [WikiTablesParserPredictor->[predict_json->[_json_to_instance]]] | Executes the given logical form on the given table. get - if line contains only one node return it. | Why did this crash before? Seems odd that this would make a difference. |
@@ -16,11 +16,12 @@ use Sulu\Component\Content\StructureInterface;
use Sulu\Component\Util\ArrayableInterface;
use JMS\Serializer\Annotation\Exclude;
use JMS\Serializer\Annotation\Type;
+use Sulu\Component\Content\PageInterface;
/**
* This structure represents a page in the CMS
*/
-abstract class Page extends... | [Page->[toArray->[getOriginTemplate,getNodeState,getNavContexts],copyFrom->[setOriginTemplate,getNodeState,getUrls,setExt,getExt,getOriginTemplate,setNodeState,setUrls],extToArray->[toArray]]] | A page is a structure representing a single node that contains a content node that holds the internal Constructor for a node object. | For some reason the Page was not implementing the `PageInterface` |
@@ -44,8 +44,7 @@
},
"include": [
"<%= MAIN_SRC_DIR %>app/typing.d.ts",
- "<%= MAIN_SRC_DIR %>app/**/*",
- "<%= TEST_SRC_DIR %>**/*"
+ "<%= MAIN_SRC_DIR %>app/**/*"
],
"exclude": [
"node_modules"
| [No CFG could be retrieved] | Missing modules are not included in the generated code. | shouldn't this also include the files used for jest tests? |
@@ -88,6 +88,10 @@ class TableQuestionKnowledgeGraph(KnowledgeGraph):
question_tokens: List[Token]) -> None:
super().__init__(entities, neighbors, entity_text)
self.question_tokens = question_tokens
+ entity_extractor = QuestionEntityExtractor( '/u/murtyjay/allennlp_fork/stop_... | [TableQuestionKnowledgeGraph->[_get_cell_parts->[_normalize_string]]] | Initialize the entity list with a sequence of entities neighbors and entity text. | How big is the stop words list? If it is not huge, may be you can define the list as a constant in the module instead of reading from a local file? |
@@ -42,9 +42,17 @@ func newDestroyCmd() *cobra.Command {
"all of this stack's resources and associated state will be gone.\n" +
"\n" +
"Warning: although old snapshots can be used to recreate a stack, this command\n" +
- "is generally irreversable and should be used with great care.",
+ "is generally ir... | [Sprintf,Name,RunFunc,New,StringSliceVar,Colorization,StringVarP,VarP,IntVarP,QName,Destroy,Wrap,BoolVarP,PersistentFlags,BoolVar] | newDestroyCmd returns a new command that deletes an existing stack and its resources. uninstall - destroy a node with optional confirmation. | Perhaps "must be run interactively ..."? |
@@ -419,11 +419,8 @@ def _accumulate_normals(tris, tri_nn, npts):
#
nn = np.zeros((npts, 3))
for verts in tris.T: # note this only loops 3x (number of verts per tri)
- counts = np.bincount(verts, minlength=npts)
- reord = np.argsort(verts)
- vals = np.r_[np.zeros((1, 3)), np.cumsum(... | [get_head_surf->[read_bem_surfaces],_nearest_tri_edge->[_get_tri_dist],_read_surface_geom->[read_surface,_complete_surface_info,_normalize_vectors],decimate_surface->[_decimate_surface],read_surface->[_fread3,_fread3_many],_tessellate_sphere->[_norm_midpt],read_bem_solution->[read_bem_surfaces],read_curvature->[_fread3... | Efficiently accumulate triangle normals and neighbors. This function is used to get the neighbor triangulation of the triangulation. | use `weights=tri_nn[:, idx]` makes it more readable for those not that familiar with bincount ;) |
@@ -242,7 +242,8 @@ class ApiTest extends DatabaseTest
* Test the api_login() function without any login.
* @return void
* @runInSeparateProcess
- * @expectedException Friendica\Network\HTTPException\UnauthorizedException
+ *
+ * @expectedException \Friendica\Network\HTTPException\UnauthorizedException
*... | [ApiTest->[testApiGetUserWithWrongUser->[assertOtherUser],testApiUsersLookupWithUserId->[assertOtherUser],testApiGetUserWithZeroUser->[assertSelfUser],testApiStatusesShowWithConversation->[assertStatus],testApiStatusesShowWithId->[assertStatus],testApiStatusesMentionsWithRss->[assertXml],testApiUsersSearchWithXml->[ass... | Test API login without login. | I think both forms are valid (but I don't have a strong preference). |
@@ -1,3 +1,8 @@
class SpReturnLog < ApplicationRecord
+ # rubocop:disable Rails/InverseOf
belongs_to :user
+ belongs_to :service_provider,
+ foreign_key: 'issuer',
+ primary_key: 'issuer'
+ # rubocop:enable Rails/InverseOf
end
| [SpReturnLog->[belongs_to]] | The SpReturnLog class contains information about the application record that is being logged. | I added these for convenience when creating these records in specs, I think in prod we'd want to discourage looking up rows in this DB so am leaving out the inverse relations for now |
@@ -164,6 +164,12 @@ func findCertPaths(op trace.Operation, vchName, certPath string) []string {
}
func (d *Dispatcher) ShowVCH(conf *config.VirtualContainerHostConfigSpec, key string, cert string, cacert string, envfile string, certpath string) {
+ moref := new(types.ManagedObjectReference)
+ if ok := moref.FromSt... | [InspectVCH->[LoadCertificate,Join,Error,Begin,X509Certificate,Sprintf,Debug,VerifyClientCert,PowerState,End,IsNil,String,Errorf,IsUnspecifiedIP,ShowVCH,NewKeyPair,GetTLSFriendlyHostIP,Debugf],ShowVCH->[Infof,GetDockerAPICommand,String,Info,WriteFile],GetDockerAPICommand->[Join,Stat,IsDir,Warn,Sprintf,Name,IsNil,Abs,In... | ShowVCH displays the VCH configuration. | is !ok expected? |
@@ -8,7 +8,7 @@ namespace System.Drawing.Tests
{
public class GdiplusTests
{
- [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsOSX))]
+ [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsApple))]
public void IsAtLeastLibgdiplus6()
{
... | [GdiplusTests->[IsAtLeastLibgdiplus6->[GetIsWindowsOrAtLeastLibgdiplus6,True,IsOSX,nameof]]] | Checks if the current OS is at least Windows or at least Libgdiplus6. | I don't think `libgdiplus` will be installed in the simulator/iphones, @akoeplinger do you know? I think this test should stay as is. |
@@ -112,8 +112,8 @@ public class ThreadPoolTest {
public void run() {
synchronized (this) {
try {
- wait(10);
- } catch (final InterruptedException ie) {
+ Thread.sleep(10L);
+ } catch (final InterruptedException e) {
Thread.currentThread().interrupt();
... | [ThreadPoolTest->[testRunOneTask->[assertTrue,isDone,runTask,ThreadPool,Task,waitForAll],threadTestBlock->[assertTrue,isDone,runTask,shutDown,BlockedTask,ThreadPool,add,waitForAll],BlockedTask->[run->[wait,interrupt,run]],testSimple->[assertTrue,isDone,runTask,shutDown,ThreadPool,add,Task,waitForAll],testSingleThread->... | Override run method to wait for a nanomsg to be available. | we've a thread util class out there to help avoid the need to catch interrupted exception, a small simplification possible here. NBD though either way :+1: |
@@ -83,7 +83,9 @@ import static org.testng.Assert.assertTrue;
* Generic test for connectors exercising connector's read and write capabilities.
*
* @see AbstractTestIntegrationSmokeTest
+ * @deprecated Use {@link BaseConnectorTest} instead.
*/
+@Deprecated
public abstract class AbstractTestDistributedQueries
... | [AbstractTestDistributedQueries->[testCommentColumn->[supportsCommentOnColumn],testColumnName->[testColumnName],DataMappingTestSetup->[asUnsupported->[DataMappingTestSetup]],testDataMappingSmokeTest->[dataMappingTableName],testCompatibleTypeChangeForView->[supportsViews],testInsertArray->[supportsArrays],testViewMetada... | Returns true if this object supports the deletion of a sequence number. | "Extend from BaseConnectorTest instead. This class is going to be removed." |
@@ -37,9 +37,10 @@ public class MockThriftMetastoreClientFactory
}
@Override
- public ThriftMetastoreClient create(HostAndPort address)
+ public ThriftMetastoreClient create(HostAndPort address, Optional<String> delegationToken)
throws TTransportException
{
+ checkArgument(!de... | [MockThriftMetastoreClientFactory->[create->[remove,checkState,isEmpty,TTransportException],empty,NoHiveMetastoreAuthentication,requireNonNull]] | Creates a new ThriftMetastoreClient with a specific lease. | `checkArgument(!delegationToken.isPresent(), "delegation token is not supported")` |
@@ -100,9 +100,6 @@ module.exports = {
stripPrefix: 'test-bin/',
},
- // TODO(rsimha, #15510): Sauce labs on Safari doesn't reliably support
- // 'localhost' addresses. See #14848 for more info.
- // Details: https://support.saucelabs.com/hc/en-us/articles/115010079868
hostname: 'localhost',
browse... | [No CFG could be retrieved] | The main entry point for the globby. Config for the module. | What about Safari on GitHub Actions? Is this what karma-safarinative-launcher fixed? |
@@ -709,9 +709,7 @@ func resourceContainerClusterRead(d *schema.ResourceData, meta interface{}) erro
}
d.Set("name", cluster.Name)
-
d.Set("network_policy", flattenNetworkPolicy(cluster.NetworkPolicy))
-
d.Set("zone", cluster.Zone)
locations := schema.NewSet(schema.HashString, convertStringArrToInterface(... | [Unlock,GetChange,NewSet,CIDRNetwork,SetPartial,SetNetworkPolicy,RelativeLink,Delete,StringInSlice,Partial,NonRetryableError,Add,Set,SetLogging,MatchString,GetOk,FindStringSubmatch,HasChange,LessThan,Lock,Errorf,SetId,MustCompile,RetryableError,HasSuffix,Create,Wrapf,Equal,Timeout,Do,Contains,Remove,HashResource,Id,New... | getContainerCluster returns a resource. Resource representing a single container - cluster. missing - master - auth - master - authorized - networks - config - initial - nod -. | Could we check the error on these? Complex types with `d.Set` can sometimes get tricky. :/ |
@@ -11,14 +11,15 @@
namespace Sulu\Bundle\ContactBundle\Content\Types;
+use PHPCR\NodeInterface;
use Sulu\Bundle\ContactBundle\Api\Account;
use Sulu\Bundle\ContactBundle\Contact\AccountManager;
use Sulu\Bundle\WebsiteBundle\ReferenceStore\ReferenceStoreInterface;
use Sulu\Component\Content\Compat\PropertyInter... | [SingleAccountSelection->[preResolve->[getValue,add],getContentData->[getValue,getById,getLanguageCode]]] | Creates a single object. | Is this not the same as for the `SingleContactSelection` think there we need to change it also? |
@@ -386,6 +386,9 @@ describe('form', function() {
doc = jqLite('<form ng-submit="submitMe()">' +
'<input type="submit" value="submit">' +
'</form>');
+ // Support: Chrome 60+ (on Windows)
+ // We need to add the form to the DOM in order for `submit` events to b... | [No CFG could be retrieved] | changeInputValue - Change input value on form controls with nested forms The following functions are used to prevent memory leak in test. | Aren't all of these memory leaks? Or is there some global cleanup between tests? |
@@ -128,7 +128,7 @@ async function fetchCoverage_(outDir) {
const zipFilename = path.join(outDir, 'coverage.zip');
const zipFile = fs.createWriteStream(zipFilename);
- await new Promise((resolve, reject) => {
+ await /** @type {Promise<void>} */ (new Promise((resolve, reject) => {
http
.get(
... | [No CFG could be retrieved] | Fetches aggregated coverage data from server and adds it to a Mocha instance. Runs e2e tests on all files under test. | I wish TS did a better job with Promises. (I can't think of a better way to fix this error.) |
@@ -87,8 +87,8 @@ namespace Microsoft.Xna.Framework.Audio
afs.ParseBytes (audiodata, false);
Size = (int)afs.DataByteCount;
- _data = new byte[afs.DataByteCount];
- Array.Copy (audiodata, afs.DataOffset, _data, 0, afs.DataByteCount);
+ buf... | [SoundEffect->[PlatformSetupInstance->[InitializeSound],PlatformShutdown->[DestroyInstance],PlatformLoadAudioStream->[DataFormat,Stereo16,Stereo8,Duration,WAVE,Copy,GetValueOrDefault,ParseBytes,Mono8,DataByteCount,Position,Dispose,FromSeconds,CanSeek,Read,FromData,NumberOfChannels,ChannelsPerFrame,DataOffset,CopyTo,Bit... | PlatformLoadAudioStream - Load the audio stream. region AVAudioPlayer Implementation. | Need to declare buffer before the using statement so it is visibleto the call to BindDataBuffer later. |
@@ -27,12 +27,12 @@ class Command(BaseCommand):
'Please provide at least one addon id to sign. If you want to '
'sign them all, use the "process_addons --task sign_addons" '
'management command.')
- signing_server = options.get('signing_server', settings.SIGNING... | [Command->[handle->[sign_addons,int,CommandError,get,len,override_settings],make_option]] | Signs the addons with the specified id. | Just double checking that this calls the Python function directly and doesn't use the task `delay` to use celery. I imagine this is fine since it's a management command and you may want to run in the command and see output, etc. |
@@ -808,8 +808,6 @@ namespace Dynamo.ViewModels
{
PackageManagerExtension.PackageLoader.LoadPackages(new List<Package> { dynPkg });
packageDownloadHandle.DownloadState = PackageDownloadHandle.State.Installed;
-
- dynPkg.LoadState.SetAsLoaded();
... | [PackageManagerClientViewModel->[PublishNewPackage->[Execute],ShowNodePublishInfo->[Execute],PublishCurrentWorkspace->[Execute],PublishSelectedNodes->[Execute],DownloadAndInstallPackage->[ShowTermsOfUseDialog],PublishCustomNode->[Execute],ListAll->[ListAll],ExecutePackageDownload->[JoinPackageNames]],TermsOfUseHelper->... | Set the package state. | This was wrong. LoadState is set inside the PackageManagerExtension.PackageLoader.LoadPackages method (which can be different from Loaded) |
@@ -188,9 +188,8 @@ public class CombineTranslationTest {
SdkComponents sdkComponents = SdkComponents.create();
sdkComponents.registerEnvironment(Environments.createDockerEnvironment("java"));
- CombinePayload payload =
- CombineTranslation.CombineGloballyPayloadTranslator.payloadForCombin... | [CombineTranslationTest->[TestCombineFn->[hashCode->[hashCode],equals->[equals]],TestCombineFnWithContext->[hashCode->[hashCode]]]] | This method is called when a node in the pipeline has a side input. | Can we just remove this? Or does it have some side effect? |
@@ -96,7 +96,7 @@ export default class Question extends Component {
const { question, answer } = this.props.attributes;
let newAnswer = answer.slice();
- let image = <img key={ media.id } alt={ media.alt } src={ media.url } />;
+ const image = <img key={ media.id } alt={ media.alt } src={ media.url } ... | [No CFG could be retrieved] | Creates a mover buttons and an image src from the step contents. Returns the content of the content element that is rendered in a WordPress post. | Please fix manual alignment |
@@ -19,6 +19,7 @@ class RRcppannoy(RPackage):
url = "https://cloud.r-project.org/src/contrib/RcppAnnoy_0.0.12.tar.gz"
list_url = "https://cloud.r-project.org/src/contrib/Archive/RcppAnnoy"
+ version('0.0.18', sha256='e4e7ddf071109b47b4fdf285db6d2155618ed73da829c30d8e64fc778e63c858')
version('0.... | [RRcppannoy->[depends_on,version]] | This site shows the list of all packages that are part of the RCP - ANS. | The current release has no version constraints on rcpp |
@@ -65,7 +65,7 @@ class TXTGenerator(Generator):
@staticmethod
def _loads_cpp_info(text):
- pattern = re.compile("^\[([a-zA-Z0-9_:-]+)\]([^\[]+)", re.MULTILINE)
+ pattern = re.compile("^\[([a-zA-Z0-9_:-^.]+)\]([^\[]+)", re.MULTILINE)
result = DepsCppInfo()
try:
| [DepsCppTXT->[__init__->[replace,join]],TXTGenerator->[_loads_cpp_info->[group,split,error,setattr,append,getattr,ConanException,CppInfo,len,DepsCppInfo,str,setdefault,strip,compile,format_exc,finditer],content->[DepsCppTXT,append,sorted,format,items,join],loads->[_loads_cpp_info,_loads_deps_user_info,find],_loads_deps... | Loads a DepsCppInfo object from a conanbuildinfo. txt file. | This RE is not good. It will allow "[includedirs_My_Other^Lib]" too. `:-^.` is any character between ^ and . ascii codes. The right ER could be: `re.compile(r"^\[([a-zA-Z0-9_:-\\.]+)\]([^\[]+)", re.MULTILINE)` |
@@ -521,8 +521,13 @@ static int cipher_test_parse(EVP_TEST *t, const char *keyword,
if (strcmp(keyword, "Ciphertext") == 0)
return parse_bin(value, &cdat->ciphertext, &cdat->ciphertext_len);
if (cdat->aead) {
- if (strcmp(keyword, "AAD") == 0)
- return parse_bin(value, &cdat->aad, &... | [No CFG could be retrieved] | This function is only called in the CIPH_CCM_MODE mode. This function checks if the specified cipher is encrypted or not. | hm, should we have AAD1 AAD2 etc tags instead? |
@@ -483,9 +483,11 @@ func (c *Container) stop(ctx context.Context, waitTime *int32) error {
log.Infof("power off %s task skipped due to guest shutdown", c.ExecConfig.ID)
return nil
}
- }
+ log.Warnf("hard power off failed due to: %#v", terr)
- log.Warnf("hard power off failed due to: %#v", ter... | [Commit->[refresh],shutdown->[waitForPowerState],stop->[shutdown],Signal->[startGuestProgram],start->[Error],Error->[Error],Remove->[Remove],String,Error] | stop stops the container Get the err object. | might use another message, to show the error type GenericVmConfigFault, similar to the InvalidPowerState. |
@@ -92,6 +92,7 @@ namespace System.Net.Http.HPack
private State _state = State.Ready;
private byte[]? _headerName;
+ private int _headerStaticIndex;
private int _stringIndex;
private int _stringLength;
private int _headerNameLength;
| [HPackDecoder->[OnString->[Decode],Parse->[ParseDynamicTableSizeUpdate,ParseHeaderFieldIndex],ParseHeaderNameLength->[ParseHeaderNameLengthContinue],ParseHeaderName->[ParseHeaderValueLength],ParseLiteralHeaderField->[ParseHeaderNameLength,ParseHeaderNameIndex,ParseHeaderValueLength],ParseHeaderNameIndex->[ParseHeaderVa... | Construct a decoder that decodes a sequence of bytes into a single header. Decode - This method is called when a header value cannot be found. | Nit: this function is now really GetDynamicHeader, right? Can we rename? |
@@ -159,7 +159,7 @@ func (mgr *connectionsManager) Close() {
// GetClient returns a single client by id
func (mgr *connectionsManager) GetClient(id int64) (pb.FeedsManagerClient, error) {
conn, ok := mgr.connections[id]
- if !ok {
+ if !ok || !conn.connected {
return nil, errors.New("feeds manager is not connect... | [Close->[cancel,Wait,Lock,Unlock],Disconnect->[Unlock,Infow,New,Lock,cancel],GetClient->[New],Connect->[WrapRecover,Done,WithBlock,Unlock,Infof,DialWithContext,OnConnect,Infow,Background,WithCancel,RegisterNodeServiceServer,Close,Lock,Err,PublicKey,NewFeedsManagerClient,WithTransportCreds,Add]] | GetClient returns the client for the given connection id. | Not sure I follow how this helps since it gets set to true the same time we set connections[id] ? |
@@ -31,6 +31,9 @@ namespace ILCompiler.DependencyAnalysis
/// </remarks>
public abstract int ClassCode { get; }
+ // Custom sort order. Used to override the default sorting mechanics.
+ public int CustomSort = int.MaxValue;
+
// Note to implementers: the type of `other` is act... | [SortableDependencyNode->[CompareImpl->[CompareToImpl]]] | Compares this node to another node. | Could you move SortableDependencyNode out of Common and into the ReadyToRun specific portion of the compiler? |
@@ -0,0 +1,13 @@
+using Pulumi;
+
+class MyStack : Stack
+{
+ public MyStack()
+ {
+ // out of bounds exception
+ #pragma warning disable
+ string[] arr = null;
+ #pragma warning disable
+ var x = arr[0];
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | You could do something simple like `throw new ApplicationException("thrown for testing");` |
@@ -378,12 +378,13 @@ func (f *StoreStateFilter) anyConditionMatch(typ int, opt *config.PersistOptions
var funcs []conditionFunc
switch typ {
case leaderSource:
- funcs = []conditionFunc{f.isTombstone, f.isDown, f.pauseLeaderTransfer, f.isDisconnected}
+ funcs = []conditionFunc{f.isTombstone, f.isDown, f.pauseL... | [Source->[anyConditionMatch],Target->[anyConditionMatch]] | anyConditionMatch returns true if any of the conditions in the filter match. | I think slow store can be the source of transfer leader. |
@@ -100,7 +100,7 @@ function setPercyBranch() {
*/
function setPercyTargetCommit() {
if (process.env.TRAVIS && !argv.master) {
- process.env['PERCY_TARGET_COMMIT'] = gitBranchPointFromMaster();
+ process.env['PERCY_TARGET_COMMIT'] = gitMergeBaseTravisMaster();
}
}
| [No CFG could be retrieved] | Sets the environment variables for the and launches a web server if it is up Serve the web server and return a promise that resolves when the server is ready. | Aha. Were we getting spurious diffs as a result of this error? |
@@ -1406,10 +1406,14 @@ class Exchange:
except ccxt.BaseError as e:
raise OperationalException(f'Could not fetch trade data. Msg: {e}') from e
+ def batch_size(self) -> int:
+ return 1000
+
async def _async_get_trade_history_id(self, pair: str,
... | [available_exchanges->[ccxt_exchanges],validate_exchanges->[available_exchanges,validate_exchange,ccxt_exchanges],Exchange->[fetch_ticker->[fetch_ticker,markets],validate_pairs->[markets,get_pair_quote_currency],fetch_order_or_stoploss_order->[fetch_order],_async_get_trade_history->[_async_get_trade_history_time,_async... | Asyncronously gets trades from the API asynchronously. Fetch the trades from the API. | Is this a constant (per exchange) that defines how many trades we expect per trade? If yes, then please move it to `_ft_has` (per exchange?). `ohlcv_candle_limit` does basically the same but for candle data. |
@@ -257,10 +257,6 @@ class RoutableSubscriber implements EventSubscriberInterface
$this->getRoutePathPropertyName($localizedDocument, $locale),
$route->getPath()
);
-
- $propertyName = $this->getRoutePathPropertyName($localizedDocument, $locale);
- $n... | [RoutableSubscriber->[handleRemove->[find,flush,getDocument,getUuid,findByEntity,remove,getLocales,getClass],getRoutePathPropertyName->[getPropertyName,hasTag,getStructureMetadata,getName],handleCopy->[getNode,resolve,find,getRoutePathPropertyName,generate,getDocument,getCopiedPath,setProperty,setRoutePath,getLocales,g... | Handles a copy event. | exactly the same logic is executed 5 lines above |
@@ -82,10 +82,10 @@ INSTALLED_APPS = [app for app in INSTALLED_APPS if app != 'debug_toolbar']
# These are the default languages. If you want a constrainted set for your
# tests, you should add those in the tests.
AMO_LANGUAGES = (
- 'af', 'ar', 'bg', 'ca', 'cs', 'da', 'de', 'el', 'en-US', 'es', 'eu', 'fa',
- ... | [_cleanup->[write,rmtree],MockProductDetails->[__init__->[update],dict,now],_polite_tmpdir->[add,mkdtemp],lazy,_polite_tmpdir,dict,get,register,MockProductDetails,set,lower] | Creates a cache of the given object. The main entry point for the Task. | Should we stop constraining the test languages btw? the list is huge now, I don't really see the point. |
@@ -1641,6 +1641,10 @@ class ArgKind(Enum):
# In an argument list, keyword-only and also optional
ARG_NAMED_OPT = 5
+ def __int__(self) -> int:
+ # All items in `ArgKind` are `int`s, but `IntEnum` is not supported by `mypyc`.
+ return cast(int, self)
+
def is_positional(self, star: boo... | [ClassDef->[serialize->[serialize],is_generic->[is_generic],deserialize->[ClassDef,deserialize]],TypeAlias->[serialize->[serialize]],FuncDef->[serialize->[serialize],deserialize->[FuncDef]],Decorator->[serialize->[serialize],deserialize->[Decorator,deserialize]],TypeVarExpr->[serialize->[serialize],deserialize->[TypeVa... | Checks if the node is positional or optional. | Shouldn't this return `self.value`? |
@@ -9,7 +9,11 @@ if ($service['service_param']) {
if ($service['service_ip']) {
$resolver = $service['service_ip'];
} else {
- $resolver = $service['hostname'];
+ if ($service['overwrite_ip']) {
+ $resolver = $service['overwrite_ip'];
+ } else {
+ $resolver = $service['hostname'];
+ }
... | [No CFG could be retrieved] | Check if a given host is a known host or a service IP. | why not using elseif to avoid leveled if statements? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.