patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -26,6 +26,17 @@ public class KubernetesConfigRecorder {
KubernetesClientUtils.createClient(clientConfig)));
}
+ public void warnAboutSecrets(KubernetesConfigSourceConfig config, KubernetesConfigBuildTimeConfig buildTimeConfig) {
+ if (config.enabled
+ && config.secret... | [KubernetesConfigRecorder->[configSources->[createClient,emptyRuntimeValue,debug,KubernetesConfigSourceProvider],emptyRuntimeValue->[EmptyConfigSourceProvider],EmptyConfigSourceProvider->[getConfigSources->[emptyList]],getLogger]] | Returns a runtime value that can be used to obtain the configuration from the Kubernetes API server. | Is it just me, or does the last sentence seem out of place? |
@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class AddBanneredUntil < ActiveRecord::Migration[6.1]
+ def change
+ add_column :topics, :bannered_until, :datetime, null: true
+
+ add_index :topics, :bannered_until, where: 'bannered_until IS NOT NULL'
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I think we need a partial index here. Otherwise, the ensure consistency query is going to be very slow since we have to query against the entire topics table. |
@@ -214,7 +214,9 @@ class CreateListing extends Component {
/>
</FormGroup>
</div>
- <div style={{ flex: 1 }}>
+ </div>
+ <div style={{ display: 'flex' }}>
+ <div style={{ flex: 1, marginRight: 30 }}>
... | [No CFG could be retrieved] | Displays a list of elements that can be used to display a single unique identifier. This is a demo example of how to display a single unique identifier. | I moved this to another row simply to make it and multi unit more readable, but I can put it back where it was. |
@@ -2806,14 +2806,10 @@ function api_format_items_activities(&$item, $type = "json")
'attendmaybe' => [],
];
- $items = q(
- 'SELECT * FROM `item`
- WHERE `uid` = %d AND `thr-parent` = "%s" AND `visible` AND NOT `deleted`',
- intval($item['uid']),
- dbesc($item['uri'])
- );
+ $condition = ['uid' => $item['u... | [api_oauth_access_token->[fetch_access_token,getMessage],api_oauth_request_token->[fetch_request_token,getMessage],api_friendica_notification->[getAll],api_error->[getMessage],api_friendica_notification_seen->[getByID,setSeen],api_statusnet_config->[get_hostname],api_saved_searches_list->[fetch],api_statuses_mediap->[p... | format items activities add user data into xml output. | Code clarity: Please rename `$i` to `$activity_item`. |
@@ -379,7 +379,9 @@ public class HoodieCopyOnWriteTable<T extends HoodieRecordPayload> extends Hoodi
List<InsertBucket> targetBuckets = partitionPathToInsertBuckets.get(keyLocation._1().getPartitionPath());
// pick the target bucket to use based on the weights.
double ... | [HoodieCopyOnWriteTable->[getUpsertPartitioner->[UpsertPartitioner],deleteFilesFunc->[PartitionCleanStat,addDeleteFilePatterns,addDeletedFileResult],UpsertPartitioner->[assignInserts->[addUpdateBucket,BucketInfo,InsertBucket],addUpdateBucket->[BucketInfo],getSmallFiles->[SmallFile]],handleInsertPartition->[handleUpsert... | Returns the bucket number of the partition that the given key is in. | should this be `getWorkloadStat(partitionPath).getNumInserts()` and not the global one right.. guess it does not matter? |
@@ -154,7 +154,8 @@ Markus::Application.configure do
###################################################################
# Location of the public and private key for the git user on the system
GITOLITE_SETTINGS = { public_key: "/home/git/git.pub",
- private_key: "/home/git/.ssh/id_rsa" }... | [fallbacks,env,perform_caching,to_s,perform_deliveries,consider_all_requests_local,delivery_method,cache_classes,log_level,weeks,deprecation,whiny_nils,allow_forgery_protection,raise_delivery_errors,configure,css_compressor,js_compressor] | This method is used to set the directories where the authentication keys and the images are stored. | Align the elements of a hash literal if they span more than one line.<br>Prefer single-quoted strings when you don't need string interpolation or special symbols.<br>Tab detected. |
@@ -61,5 +61,14 @@ gradleEnterprise {
publishAlways()
}
}
+
+buildCache {
+ local { enabled = true }
+ remote(HttpBuildCache) {
+ push = true
+ enabled = false // Disabled as this might not always desired
+ url = '<%= gradleEnterpriseHost %>/cache/' // note the trailing slash!
... | [No CFG could be retrieved] | publish always - > publish rootProject. | Why not always enable it? |
@@ -2344,15 +2344,6 @@ namespace Dynamo.Graph.Nodes
///
internal void RequestValueUpdate(EngineController engine)
{
- // A NodeModel should have its cachedMirrorData reset when it is
- // requested to update its value. When the QueryMirrorDataAsyncTask
- // re... | [No CFG could be retrieved] | This is a base class for all of the methods that are related to a node model. Missing variable name in the code block. | can the mutex be removed? What else locks on it? Why remove it? |
@@ -1196,6 +1196,16 @@ function put_item_in_cache(&$item, $update = false)
$item["rendered-html"] = prepare_text($item["body"]);
$item["rendered-hash"] = hash("md5", $item["body"]);
+ // Force an update if the generated values differ from the existing ones
+ if ($rendered_hash != $item["rendered-hash"]) {
+ ... | [dlogger->[save_timestamp],get_intltext_template->[save_timestamp],get_plink->[remove_baseurl],replace_macros->[save_timestamp,template_engine,getMessage,replaceMacros],text_highlight->[factory,setRenderer,highlight],load_view_file->[save_timestamp],logger->[save_timestamp],get_markup_template->[save_timestamp,template... | put item in cache. | Wait, if we ignore the item cache, we shouldn't store it, right? |
@@ -384,6 +384,7 @@ func (e *Identify2WithUID) loadMe(ctx *Context) (err error) {
func (e *Identify2WithUID) loadThem(ctx *Context) (err error) {
arg := libkb.NewLoadUserArg(e.G())
arg.UID = e.arg.Uid
+ arg.ResolveBody = e.ResolveBody
e.them, err = libkb.LoadUser(arg)
if e.them == nil {
return libkb.UserNot... | [runIdentifyUI->[maybeCacheResult,insertTrackToken,checkRemoteAssertions],toUserPlusKeys->[getNow],CCLCheckCompleted->[unblock],loadUsers->[loadThem,loadMe],createIdentifyState->[getTrackChainLink]] | loadThem loads the user with the given UID. | We can save an RT to the server if we plumb the other fields from resolve through to the identification call. |
@@ -271,11 +271,14 @@ def _get_tensorrt_rewriter_config(conversion_params,
# need to run constant folding again.
rewriter_config_with_trt.optimizers.extend(
["constfold", "layout", "constfold"])
+
rewriter_config_with_trt.meta_optimizer_iterations = (
rewriter_config_pb2.RewriterConfig.ONE)... | [_TRTEngineResourceDeleter->[destroy_resource->[_get_resource_handle]],_TRTEngineResource->[_create_resource->[_get_resource_handle],__init__->[_TRTEngineResourceDeleter]],_check_conversion_params->[supported_precision_modes],get_tensorrt_rewriter_config->[_get_tensorrt_rewriter_config],TrtGraphConverter->[_convert_gra... | Returns a RewriterConfig proto for a TensorRTOptimizer. Run constant folding and layout optimizers. With - Trt optimization. | This is the only change you will need to fix the bug, right? |
@@ -217,4 +217,8 @@ public class UnusedMethodParameterCheck extends IssuableSubscriptionVisitor {
// no need to check which side of method reference, from an identifierTree, it's the only possibility as direct parent
.anyMatch(identifier -> identifier.parent().is(Tree.Kind.METHOD_REFERENCE));
}
+
+ pr... | [UnusedMethodParameterCheck->[isOverriding->[isOverriding]]] | Checks if the given method tree is used as a method reference. | This method is duplicated 3 times, we should move it to a helper. |
@@ -138,7 +138,7 @@ func validate(client Client, commit *pfs.Commit, files []*file) (retErr error) {
}
files = files[1:]
return nil
- })
+ }, true)
if pfsserver.IsFileNotFoundErr(err) && len(files) == 0 {
return nil
}
| [WithModifyFileClient->[WithModifyFileClient],PutFile->[PutFile],DeleteFile->[DeleteFile]] | validate - validates a list of files against a specific commit. PutFile - Put a file from a reader. | Is this the don't use all the memory flag? |
@@ -34,9 +34,11 @@ def check_order_status(func):
@receiver(status_changed)
def order_status_change(sender, instance, **kwargs):
+ """Handles payment status change and sets suitable order status."""
order = instance.order
if order.is_fully_paid():
- order.change_status(OrderStatus.FULLY_PAID)
+ ... | [cancel_order->[cancel_delivery_group,all,save],add_variant_to_delivery_group->[allocate_stock,create,display_product,add_variant_to_existing_lines,InsufficientStock,refresh_from_db,get_price_per_item,select_stockrecord],merge_duplicated_lines->[save,sum,filter,exclude,count],attach_order_to_user->[store_user_address,s... | This is called when an order status changes. It creates a history entry for the order and. | This function is a signal receiver and it's used in a different way than other functions in this module. Maybe we should move it to a separate file. e.g. `signals.py`? |
@@ -249,7 +249,7 @@ public class DeltaSync implements Serializable {
}
} else {
this.commitTimelineOpt = Option.empty();
- String partitionColumns = HoodieWriterUtils.getPartitionColumns(keyGenerator);
+ String partitionColumns = HoodieSparkWriterUtils.getPartitionColumnsFromKeyGenerator(ke... | [DeltaSync->[getHoodieClientConfig->[getHoodieClientConfig],syncMeta->[getSyncClassShortName],syncHive->[syncHive],registerAvroSchemas->[registerAvroSchemas],syncOnce->[refreshTimeline],close->[close]]] | Refresh the commit timeline. | such a long name. :) lets just keep it short. |
@@ -1634,9 +1634,14 @@ module.exports = class okex extends Exchange {
const feeCostString = this.safeString (order, 'fee');
let amount = undefined;
let cost = undefined;
- if (side === 'buy' && type === 'market') {
+ // spot market buy: "sz" can refer either to base currency uni... | [No CFG could be retrieved] | parse order header and return order id Get an order object with the necessary fields. | I would suggest using `market['spot']` (bool) instead of `market['type'] === 'spot'` (string comparison) here for efficiency. |
@@ -18,7 +18,7 @@ class ModelTestCase(AllenNlpTestCase):
with added methods for testing :class:`~allennlp.models.model.Model` subclasses.
"""
def set_up_model(self, param_file, dataset_file):
- # pylint: disable=attribute-defined-outside-init
+
self.param_file = param_file
params... | [ModelTestCase->[assert_fields_equal->[assert_fields_equal]]] | Set up the model and vocabulary based on the missing - value sequence number. | This one is actually useful. Looks like flake8 doesn't check for that? Would mypy? |
@@ -18,6 +18,7 @@ function findpeople_widget() {
require_once 'include/Contact.php';
$a = get_app();
+ $global_dir = Config::get('system', 'directory');
if (get_config('system', 'invitation_only')) {
$x = get_pconfig(local_user(), 'system', 'invites_remaining');
| [No CFG could be retrieved] | find people widget. | Your indentation is again in spaces ;-) |
@@ -233,6 +233,8 @@ def clean_up(a: List[str]) -> List[str]:
remove trailing carriage returns.
"""
res = []
+ pwd = os.getcwd()
+ driver = pwd + '/driver.py'
for s in a:
prefix = os.sep
ss = s
| [assert_equal->[good_repr],assert_target_equivalence->[assert_string_arrays_equal],copy_and_fudge_mtime->[retry_on_error],assert_type->[typename],testcase_pyversion->[testfile_pyversion],parse_options->[testcase_pyversion],check_test_output_files->[normalize_error_messages,assert_string_arrays_equal],assert_module_equi... | Remove common directory prefix from all strings in a. . | What was going on here? |
@@ -323,9 +323,13 @@ namespace MonoGame.Framework
}
}
+ [DllImport("user32.dll")]
+ private static extern short VkKeyScanEx(char ch, IntPtr dwhkl);
+
private void OnKeyPress(object sender, KeyPressEventArgs e)
{
- OnTextInput(sender, new TextInputEventA... | [WinFormsGameWindow->[UpdateMouseState->[GetCursorPos,MapWindowPoints],OnPresentationChanged->[ChangeClientSize],MinimizeFullScreen->[RedrawWindow],UpdateWindows->[UpdateMouseState],ExitFullScreen->[RedrawWindow],Dispose->[Dispose,UnregisterFromAllWindows],RefreshAdapter->[RefreshAdapter]]] | OnMouseLeave event. | Wait, this works O o, never realized that XNA Keys enum was based off of this one. Anyway, are you sure there is no better way of doing this like abusing other events to get more accurate information like I did for UWP? |
@@ -76,8 +76,12 @@ class Fleet(object):
self._util = None
def init(self, role_maker):
+ #if paddle.fluid.framework.in_dygraph_mode():
+ # self.dy_strategy = paddle.fluid.dygraph.parallel.prepare_context()
+ # return
self._role_maker = role_maker
self.strateg... | [Fleet->[barrier_worker->[barrier_worker],worker_num->[worker_num],is_worker->[is_worker],server_index->[server_index],is_server->[is_server],minimize->[minimize],worker_index->[worker_index],is_first_worker->[is_first_worker]]] | Initialize the node. | remove this to init rolemaker in dygraph. |
@@ -0,0 +1,6 @@
+from parlai.core.torch_agent import TorchAgent, Output
+
+class ParrotAgent(TorchAgent):
+ def eval_step(self, batch):
+ # for each row in batch, convert tensor to string
+ return Output([str(row) for row in batch.text_vec])
| [No CFG could be retrieved] | No Summary Found. | ? So it outputs a string of numbers? You don't want to use vec2txt? |
@@ -1022,7 +1022,7 @@ class RaidenService(Runnable):
target: TargetAddress,
identifier: PaymentID,
fee: FeeAmount = MEDIATION_FEE,
- secret: Secret = None,
+ secret: Optional[Secret] = None,
secrethash: SecretHash = None,
) -> PaymentStatus:
""" Transfer `... | [RaidenService->[_initialize_monitoring_services_queue->[update_services_from_balance_proof],_callback_new_block->[handle_and_track_state_change],handle_state_change->[_redact_secret,update_services_from_balance_proof],on_message->[on_message],stop->[stop],_start_alarm_task->[start],_start_transport->[start],handle_and... | Transfer amount between this node and target. | I'll remove `secrethash` here. Anyway `secrethash` is computed from `secret` later in `start_mediated_transfer_with_secret()`. (First I want to see the tests pass.) |
@@ -298,3 +298,13 @@ class EvolutionTuner(Tuner):
indiv = Individual(config=params, result=reward)
self.population.append(indiv)
+
+ def feed_tuning_data(self, data):
+ assert "parameter" in data
+ _params = data["parameter"]
+ assert "value" in data
+ _value = extract... | [json2paramater->[json2paramater],EvolutionTuner->[receive_trial_result->[Individual],update_search_space->[json2paramater,Individual,json2space],generate_parameters->[_split_index,json2paramater,json2space],__init__->[OptimizeMode]],json2space->[json2space]] | This method is called when a trial has received a result from a trial. It records the. | @xuehui1991 Is this method implemented right? |
@@ -4,8 +4,8 @@
using System;
using System.Diagnostics;
using System.Security.Cryptography;
-
using Internal.Cryptography;
+using System.Runtime.Versioning;
namespace System.Security.Cryptography
{
| [HMACSHA256->[HashFinal->[FinalizeHashAndReset],HashCore->[AppendHashData],TryHashFinal->[TryFinalizeHashAndReset],Dispose->[Dispose],ChangeKey,GenerateRandom,nameof,HashSizeInBits,SHA256,HashName,ActualKey,Key]] | Creates a HMAC - SHA256 hash object. Finalizes the hash and resets the hash. | Nit: Can we keep System* grouped together? |
@@ -656,7 +656,12 @@ public class DataflowPipelineTranslator {
Map<String, Object> outputInfo = new HashMap<>();
addString(outputInfo, PropertyNames.OUTPUT_NAME, Long.toString(id));
- addString(outputInfo, PropertyNames.USER_NAME, value.getName());
+
+ String stepName = getString(properties, P... | [DataflowPipelineTranslator->[StepTranslator->[addCollectionToSingletonOutput->[get,addOutput],addInput->[addInput,getProducer,getProperties,asOutputReference],getProperties->[getProperties],addEncodingInput->[getProperties],addOutput->[get,addOutput,registerOutputName,getProperties],addDisplayData->[getProperties]],Tr... | Adds a new output to the pipeline. | Tuples are arbitrarily ordered; do we care that we don't have a strong definition of what the expected names are? What about named TupleTags (with non-generated IDs)? |
@@ -42,6 +42,9 @@ public class MemorySizeConverter implements Converter<MemorySize> {
* @return {@link MemorySize} - a memory size represented by the given value
*/
public MemorySize convert(String value) {
+ if (value.isEmpty()) {
+ return null;
+ }
Matcher matcher = ... | [MemorySizeConverter->[convert->[group,IllegalArgumentException,find,MemorySize,BigInteger,get,multiply,matcher,format,toUpperCase],pow,put,valueOf,compile]] | Convert a string representation of a MemorySize into a MemorySize object. | Should we trim this? |
@@ -566,7 +566,7 @@ class Grouping < ActiveRecord::Base
# Should we write repository permissions for this grouping?
def write_repo_permissions?
- MarkusConfigurator.markus_config_repository_admin? &&
+ MarkusConfigurator.get_config_value('is_repository_admin') &&
self.repository_external_commits_... | [Grouping->[deletable_by?->[inviter,is_valid?],update_repository_permissions->[is_valid?],write_repo_permissions?->[repository_external_commits_only?],revoke_repository_permissions_for_membership->[write_repo_permissions?],remove_member->[membership_status],remove_rejected->[membership_status],assign_tas_by_csv->[add_t... | if the user has write permissions on the node return the list of tas assigned to the. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -16,12 +16,11 @@ import org.slf4j.LoggerFactory;
*/
public class DefaultRayRuntimeFactory implements RayRuntimeFactory {
- private static final Logger LOGGER = LoggerFactory.getLogger(DefaultRayRuntimeFactory.class);
+ private final Logger logger = LoggerFactory.getLogger(DefaultRayRuntimeFactory.class);
... | [DefaultRayRuntimeFactory->[createRayRuntime->[create,RuntimeException,error,init,start,RayNativeRuntime,RayDevRuntime],getLogger]] | Create a new runtime for the ray. | loggers are better defined as static, otherwise they won't be accessible from static methods. |
@@ -135,6 +135,14 @@ func ValidateMasterConfig(config *api.MasterConfig) ValidationResults {
validationResults.AddErrors(fielderrors.NewFieldInvalid("kubernetesMasterConfig", config.KubernetesMasterConfig, "kubernetesMasterConfig and masterClients.externalKubernetesKubeConfig are mutually exclusive"))
}
+ if len... | [Prefix->[Prefix],AddErrors,Prefix,AddWarnings,Append] | ValidateEtcdStorageConfig validates the given etcd storage config. | Does it have to match or does it have to cover? |
@@ -327,4 +327,14 @@ public final class MuleExtensionAnnotationParser
{
return (annotations.contains(ParameterGroup.class) || annotations.contains(MetadataKeyId.class)) && parameterType instanceof ObjectType;
}
+
+ public static void parseConnectionAnnotation(Class<?> annotatedFieldClass, HasModel... | [MuleExtensionAnnotationParser->[doParseParameter->[getAliasName],parseDisplayAnnotations->[parseDisplayAnnotations,parseDisplayNameAnnotation,parsePlacementAnnotation],parseGroupParameters->[parseGroupParameters],getAliasName->[getAliasName]]] | Checks if the parameter is a container. | can't thse two methods have package visibility? |
@@ -765,7 +765,7 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
// doing this early allows InitStrategy to set environment upfront
final InitStrategy is = InitStrategy.get(Thread.currentThread().getContextClassLoader());
- Trigger.timer = new T... | [Jenkins->[getAllItems->[getAllItems],getUser->[get],getPlugin->[getPlugin],getViewActions->[getActions],getJDK->[getJDKs],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getViews->[getViews],doDoFingerprintCheck->[cleanUp,isUseCrumbs],checkJobName->[getItem,checkGoodName],deleteView->[deleteView],doConfigSu... | Creates a new instance of Jenkins. Checks if the secret. key is generated by the version of Jenkins post SECURITY - 49. | Unfortunately you have to still initialize `Trigger.timer` for compatibility, even if you know that most of the time it will never be used and will just be a useless thread. (Unless @kohsuke's bytecode compatibility library can be enhanced to allow a field to be replaced by a method.) |
@@ -50,7 +50,7 @@ public class WebJarLocatorDevModeTest {
.statusCode(200);
// Test using version in url of existing Web Jar
- RestAssured.get("/webjars/jquery/3.4.1/jquery.min.js").then()
+ RestAssured.get("/webjars/jquery/3.5.1/jquery.min.js").then()
.statusC... | [WebJarLocatorDevModeTest->[testDevMode->[modifySourceFile,equalTo,body,replace,is,statusCode],StringAsset,addAsResource,setArchiveProducer]] | Tests if a resource is missing in dev mode. missing endpoint missing missing endpoint. | @gsmet Isn't that going to break as soon as someone bumps the value of the property? A sustainable solution would be to reuse the property here. |
@@ -898,11 +898,11 @@ namespace System.Text.Encodings.Web
}
}
- internal static unsafe bool TryCopyCharacters(char[] source, char* destination, int destinationLength, out int numberOfCharactersWritten)
+ internal static bool TryCopyCharacters(string source, Span<char> destination, ... | [TextEncoder->[FindFirstCharacterToEncodeUtf8->[WillEncode],EncodeCore->[TryEncodeUnicodeScalar,WillEncode],OperationStatus->[TryEncodeUnicodeScalar,WillEncode,FindFirstCharacterToEncode],Write->[Write],Encode->[Encode,FindFirstCharacterToEncode],GetAsciiEncoding->[WillEncode],InitializeAsciiCache->[WillEncode],FindFir... | This method is used to find the first character to encode in UTF - 8. Checks if the source value contains any non - ASCII byte. This method is called to determine if a character in the UTF - 8 string is a reserved TryCopyCharacters - Copy the characters from the source array to the destination array. | Could throw NRE in debug builds when we'd rather it assert. Suggest using `Debug.Assert(!string.IsNullOrEmpty(source))` or `Debug.Assert(source?.Length > 0)`. |
@@ -117,7 +117,7 @@ func (o *ImageOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []st
o.ChangeCause = f.Command(cmd, false)
o.DryRun = cmdutil.GetDryRunFlag(cmd)
o.Output = cmdutil.GetFlagString(cmd, "output")
- o.ResolveImage = f.ResolveImage
+ o.ResolveImage = resolveImageFactory(f, cmd)
o.Cmd ... | [Validate->[NewAggregate,Errorf,IsFilenameSliceEmpty],Run->[ChangeResourcePatch,Patch,Fprintf,InternalVersionJSONEncoder,PrintSuccess,NewAggregate,ContainsChangeCause,Errorf,Refresh,Encode,UpdatePodSpecForObject,ResolveImage,AsVersioned,PrintObject,NewHelper],Complete->[ContinueOnError,ShouldIncludeUninitialized,Infos,... | Complete completes the options for the image command. | can we get rid of this field for set image and just call the function directly in Run() ? Also remove it from upstream factory as it is not used anywhere else. |
@@ -116,11 +116,11 @@ ModelPart& CreateScalarVariableTestModelPart(
BufferSize);
if (DoInitializeElements) {
- r_model_part.Elements().front().Initialize();
+ r_model_part.Elements().front().Initialize(r_model_part.GetProcessInfo());
}
if (DoInitializeConditions) {
- r_m... | [No CFG could be retrieved] | Create a new random variable test model part. RandomFillContainerVariable - Fills the random values of an . | Shouldn't we create a `const` reference in here? |
@@ -541,7 +541,7 @@ abstract class CommonDocGenerator
'line_up_locale'=>price($line->subprice, 0, $outputlangs),
'line_total_up'=>price2num($line->subprice * $line->qty),
'line_total_up_locale'=>price($line->subprice * $line->qty, 0, $outputlangs),
- 'line_qty'=>$line->qty,
+ 'line_qty'=>price($line->qt... | [CommonDocGenerator->[pdfTabTitles->[getColumnStatus],printColDescContent->[printStdColumnContent],defineColumnExtrafield->[insertNewColumnDef],printStdColumnContent->[getColumnContentXStart],insertNewColumnDef->[getColumnRank],getExtrafieldsInHtml->[getExtrafieldContent],get_substitutionarray_each_var_object->[get_sub... | Returns an array of substitutions for all lines of a line. Outputs a formatted price object for the given line. Retrieve the total_ttc_locale for a single line of the order Load product data optional fields to the line. | line_qty must be the brut value, so for example 123456789,12345 When you say you want the formatting of function price. Do you mean you want the locale formatting (with space between thousand for example ?). If yes, you must introduce another tag 'line_qty_locale' and price function should have $outputlangs as paramete... |
@@ -37,14 +37,14 @@ public final class Search {
}
/**
- * Create an event filter out of an Ickle query string.
+ * Creates an event filter from an Ickle query string.
*/
public static <K, V> CacheEventFilterConverter<K, V, ObjectFilter.FilterResult> makeFilter(String queryString) {
retur... | [Search->[getSearchStatistics->[getSearchStatistics],makeFilter->[makeFilter],getIndexer->[getIndexer,getAdvancedCache],getAdvancedCache->[getAdvancedCache]]] | Makes a filter for the given query string. | @gustavonalle There are no descriptions for `getSearchStatistics`, `getClusteredSearchStatistics`, or `getIndexer` - Shall I add them or is there a reason why we shouldn't add descriptions? |
@@ -881,8 +881,13 @@ func (b *cloudBackend) runEngineAction(
}()
// The backend.SnapshotManager and backend.SnapshotPersister will keep track of any changes to
- // the Snapshot (checkpoint file) in the HTTP backend.
- persister := b.newSnapshotPersister(ctx, u.update, u.tokenSource, op.SecretsManager)
+ // the S... | [GetStack->[GetStack],RenameStack->[RenameStack],GetLogs->[GetStack],CloudConsoleURL->[CloudURL],tryNextUpdate->[CloudURL],GetPolicyPack->[CloudURL,Name,parsePolicyPackReference],CancelCurrentUpdate->[GetStack],GetLatestConfiguration->[GetLatestConfiguration],GetStackTags->[GetStack],DoesProjectExist->[DoesProjectExist... | runEngineAction runs an engine action on the given stackRef and stackRef with the given NewScope creates a new scope for the given state. | What are the cases where these might not be compatible? And what is the experience in those cases? |
@@ -85,6 +85,13 @@ class Command(BaseCommand):
cursor.execute(commands.getvalue())
def handle(self, *args, **options):
+ # set only our custom plugin to not call external API when preparing
+ # example database
+ settings.PLUGINS = [
+ "saleor.payment.gateways.dummy.p... | [Command->[handle->[make_database_faster,sequence_reset]]] | Handle command line options. | @mirumee/saleor Please change this to be on one line, these two look like separate entries and it will lead to a bug when someone edits the list and either adds a comma or inserts a line between those two. |
@@ -173,6 +173,13 @@ func updateProjectBoard(e Engine, board *ProjectBoard) error {
fieldToUpdate = append(fieldToUpdate, "title")
}
+ if len(board.Color) != 0 {
+ if !BoardColorPattern.MatchString(board.Color) {
+ return fmt.Errorf("bad color code: %s", board.Color)
+ }
+ }
+ fieldToUpdate = append(fieldToU... | [LoadIssues->[LoadComments,LoadIssues],ID,Commit,Begin,TimeStampNow,Find,removeIssues,OrderBy,Close,Delete,Insert,Where,Cols,Get,NewSession,Update] | GetProjectBoard fetches the current project board and all the default boards related to a project getDefaultBoard returns default board if no board exists. | Can be combined into a single if |
@@ -224,6 +224,9 @@ class ElggCoreRegressionBugsTest extends \ElggCoreUnitTest {
'already anchor <a href="http://twitter.com/">twitter</a> test' =>
'already anchor <a href="http://twitter.com/">twitter</a> test',
+ 'already anchor with link text <a href="http://twitter.com/">http://twitter.com</a> test' =>... | [ElggCoreRegressionBugsTest->[testElggObjectDeleteAnnotations->[assertEqual,annotate,save,deleteAnnotations,countAnnotations,delete],test_disabling_annotations_infinite_loop->[assertTrue,getAnnotations,annotate,save,delete],test_update_handlers_can_change_attributes->[remove,save,assertEqual,delete],test_ElggXMLElement... | Parse urls for test Example. org section expects a list of urls in the web archive. | We need to make sure that regex is not greedy. Needs a test with more than one anchor tag. Maybe a mix of different tags. And an anchor tag within another tag. |
@@ -520,7 +520,7 @@ class Pruning(object):
thresholds = get_thresholds()
for index, mask in enumerate(masks):
if not self._exists_in_do_not_prune_list(mask.name):
- summary.scalar(mask.name + '/sparsity', nn_impl.zero_fraction(mask))
+ summary.scalar(mask.op.name + '/sparsity', ... | [Pruning->[_get_mask_assign_ops->[_exists_in_do_not_prune_list,get_masks,get_thresholds,get_weights,_maybe_update_block_mask],mask_update_op->[_get_mask_assign_ops],__init__->[get_pruning_hparams],conditional_mask_update_op->[mask_update_op->[mask_update_op],maybe_update_masks],_maybe_update_block_mask->[_update_mask],... | Adds summaries for this pruning spec. | Shouldn't this be `for mask, threshold in zip(masks,thresholds):` (optional) |
@@ -254,11 +254,13 @@ namespace Kratos
KRATOS_TEST_CASE_IN_SUITE(WeightedGap1, KratosContactStructuralMechanicsFastSuite)
{
Model this_model;
- ModelPart& r_model_part = this_model.CreateModelPart("Contact", 2);
+ ModelPart& r_model_part = this_model.CreateModelPart(... | [CreateModelPart->[CreatePlaneCilynderProblem,CreateModelPart]] | This test case is used to test if a node is not in a system and if it inode. FastGetSolutionStepValue - weighted_gap_corrected - normal_. | does this have to be historical? ;) |
@@ -57,6 +57,9 @@ func (m *PushMirror) GetRemoteName() string {
// InsertPushMirror inserts a push-mirror to database
func InsertPushMirror(m *PushMirror) error {
+ if setting.Mirror.DisableNewPush {
+ return fmt.Errorf("creation of new push mirror's are disabled")
+ }
_, err := x.Insert(m)
return err
}
| [AfterLoad->[Error],ID,Unix,New,Find,Now,Delete,Insert,Where,Iterate,And,Get,AllCols,Update] | PushMirror is a constructor for PushMirror objects. GetPushMirrorByID returns push - mirror information by ID. | I would like to move it out of the function and put it in router level. |
@@ -34,6 +34,11 @@ func GenerateTokens(numTokens int, takenTokens []uint32) []uint32 {
i++
}
+ // Ensure returned tokens are sorted.
+ sort.Slice(tokens, func(i, j int) bool {
+ return tokens[i] < tokens[j]
+ })
+
return tokens
}
| [GetAllHealthy,NewTicker,Now,Search,Done,Strings,Stop,New,Since,Wait,GetFirstAddressOf,UnixNano,GetInstanceState,Uint32,Ongoing,Err,NewSource,WithTimeout,NewBackoff] | Ring import imports a single instance of the network from the ring. WaitRingStability waits until the provided operation is in the ring topology. | In the ring lifecycler it's already guaranteed all tokens are sorted. I've introduced sorting here as well to have same guarantee in tests too. |
@@ -1,7 +1,9 @@
-namespace DynamoWebServer.Responses
+using System.Collections.Generic;
+
+namespace DynamoWebServer.Responses
{
public class ComputationResponse : Response
{
- public string Nodes { get; set; }
+ public IEnumerable<object> Nodes { get; set; }
}
}
| [No CFG could be retrieved] | DynamoWebServer. Response. ComputationResponse. | I don't see where `ComputationResponse.Nodes` list is used, it is only set once but no one is reading it. Are we sure this is intended for this pull request (which removes ASP.NET dependency)? Also, we can use a stronger type than just `object`? It seems like the caller expects this to be `ExecutedNode`. |
@@ -294,7 +294,7 @@ namespace Content.Server.Explosion.EntitySystems
int heavyImpactRange = 0,
int lightImpactRange = 0,
int flashRange = 0,
- EntityUid? user = null,
+ EntityUid user = default,
ExplosiveComponent? explosive = null,
... | [ExplosionSystem->[SpawnExplosion->[FlashInRange,DamageTilesInRange,DamageEntitiesInRange,CameraShakeInRange,SpawnExplosion]]] | Spawns an explosion with the specified parameters. | same here, if it's optional use nullable `EntityUid` |
@@ -2489,7 +2489,8 @@ namespace System.Net.Sockets.Tests
_server = new Socket(address.AddressFamily, SocketType.Stream, ProtocolType.Tcp);
}
- port = _server.BindToAnonymousPort(address);
+ _portLease = _server.BindToPoolPort(address);
+ ... | [No CFG could be retrieved] | The SocketServer class. Dispose of the object. | Isn't BindToAnonymousPort still preferable to BindToPoolPort in non dualMode cases? |
@@ -152,6 +152,10 @@ public class CachingSessionFactory implements SessionFactory, DisposableBean {
public void mkdir(String directory) throws IOException {
this.targetSession.mkdir(directory);
}
+
+ public boolean isDirExists(String path) {
+ return this.targetSession.isDirExists(path);
+ }
}
}
| [CachingSessionFactory->[getSession->[getSession],CachedSession->[mkdir->[mkdir],write->[write],isOpen->[isOpen],remove->[remove],close->[close],list->[list],read->[read],rename->[rename]]]] | This method creates a directory in the target session. | could this method just be named 'exists'? |
@@ -751,9 +751,11 @@ export class AmpPanZoom extends AMP.BaseElement {
if (this.scale_ <= 1) {
this.unregisterPanningGesture_();
this.toggleZoomButtonIn_();
+ this.content_.classList.remove('i-amphtml-pan-zoom-scrollable');
} else {
this.registerPanningGesture_();
... | [No CFG could be retrieved] | private private methods Animation animation. | shouldn't this be `if (this.scale_ <= this.minScale_)`? |
@@ -227,6 +227,7 @@ type StakeInfoFinder interface {
func New(host p2p.Host, ShardID uint32, leader p2p.Peer, blsPriKey *bls.SecretKey) (*Consensus, error) {
consensus := Consensus{}
consensus.host = host
+ consensus.msgSender = NewMessageSender(host)
consensus.blockNumLowChan = make(chan struct{})
// pbft r... | [FindStakeInfoByNodeKey->[New,GetLogInstance,FromLibBLSPublicKey,Log15,WithCause],IndexEnabled,GetDefaultConfig,Info,SerializeToHexStr,GetSelfPeer,Add,ToLibBLSPublicKey,Error,WithCallerSkip,SetMask,GetMemProfiling,Cmp,New,GetLogInstance,AddBalance,FromLibBLSPublicKey,FindCommitteeByID,Errorf,Sub,Logger,WithCause,Debug,... | New returns a new consensus object with the given consensus key. make map of leader to true if it s a leader. | If not used, we can remove consensus.host |
@@ -1316,6 +1316,8 @@ def last_seq(input,
:type name: basestring
:param input: Input layer name.
:type input: LayerOutput
+ :param stride: parameter of stride window.
+ :type stride: Int
:param layer_attr: extra layer attributes.
:type layer_attr: ExtraLayerAttribute.
:return: Laye... | [priorbox_layer->[LayerOutput],fc_layer->[LayerOutput],recurrent_group->[mixed_layer,identity_projection,is_single_input,targetInlink_in_inlinks,memory],scaling_layer->[LayerOutput],last_seq->[LayerOutput],img_cmrnorm_layer->[__img_norm_layer__],seq_concat_layer->[LayerOutput],conv_shift_layer->[LayerOutput],out_prod_l... | Get the last sequence of a sequence. | parameter of stride window --> window size |
@@ -260,7 +260,7 @@ namespace Teuchos {
counter().start(reset);
#ifdef HAVE_TEUCHOS_ADD_TIME_MONITOR_TO_STACKED_TIMER
if (nonnull(stackedTimer_))
- stackedTimer_->start(counter().name());
+ stackedTimer_->start(counter().name(),false);
#endif
}
}
| [zeroOutTimers->[reset,counters,end,begin,TEUCHOS_TEST_FOR_EXCEPTION,isRunning,name],PerformanceMonitorBase<Time>->[start,nonnull,counter,isRecursiveCall]] | TimeMonitor - base implementation of TimeMonitor. | So, if you use teuchos you don't get the kokkos injection but you do if you use stacked timer directly? Should they be the same? |
@@ -1359,6 +1359,10 @@ module.exports = class Exchange {
return this.safeValue (units, decimals)
}
+ addFloat (value1, value2) {
+ return parseFloat (BigNumber (value1).plus (value2));
+ }
+
fromWei (amount, unit = 'ether', decimals = 18) {
if (amount === undefined) {
... | [No CFG could be retrieved] | 2016 - 11 - 15 Get the unit of nanoseconds. | There's a `this.sum` function for this, do we really need a new method? |
@@ -830,7 +830,11 @@ module.exports = class binance extends Exchange {
let success = this.safeValue (response, 'success', true);
if (!success) {
if ('msg' in response)
- response = JSON.parse (response['msg']);
+ try {
... | [No CFG could be retrieved] | check for legacy errors in order response. | Shouldn't this line be like `response = {};` ? ;) |
@@ -161,6 +161,9 @@ Rails.application.routes.draw do
get '/events/disavow' => 'event_disavowal#new', as: :event_disavowal
post '/events/disavow' => 'event_disavowal#create', as: :events_disavowal
+ get '/users/rules_of_use' => 'users/rules_of_use#new'
+ post '/users/rules_of_use' => 'users/rules_of_us... | [draw,namespace,root,scope,enable_gpo_verification?,redirect,get,enable_test_routes,post,devise_scope,join,patch,devise_for,each,match,put,delete] | This method is used to provide a list of all of the user s routes. List of registered webauthn routes. | sorry I totally misrememberd.... we use the `account/` prefix for these -- that was what I was thinking. anyways URL doesn't matter that much, just wanted us to find a good home for these |
@@ -209,12 +209,12 @@ def _cwt(X, Ws, mode="same", decim=1, use_fft=True):
if use_fft:
fft_Ws = np.empty((n_freqs, fsize), dtype=np.complex128)
for i, W in enumerate(Ws):
- if len(W) > n_times:
- raise ValueError('At least one of the wavelets is longer than the '
- ... | [AverageTFR->[plot->[copy],__iadd__->[_check_compat],__isub__->[_check_compat],__add__->[copy,_check_compat],__sub__->[copy,_check_compat],plot_topo->[copy]],_get_data->[data],tfr_morlet->[_tfr_aux],_tfr_aux->[_compute_tfr],tfr_multitaper->[_tfr_aux],tfr_array_morlet->[_compute_tfr],_time_frequency_loop->[_cwt],cwt->[_... | Compute cwt with fft based convolutions or temporal convolutions. Iterate over the signal wavelets and return the corresponding signal. | I'd rather make this an error. If people hit use cases maybe we can add an explicit argument to pad the signal or something. |
@@ -374,6 +374,9 @@ export class HistoryBindingNatural_ {
// On pop, stack is not allowed to go prior to the starting point.
stackIndex = Math.max(stackIndex, this.startIndex_);
return this.whenReady_(() => {
+ // Popping history forget the last navigated hash since we can't really
+ // know wh... | [No CFG could be retrieved] | Adds event listeners to the history object. The navigation forward and backward logic is based on the navigation backward logic. | Shouldn't this be whatever the hash is after `#back` is called? |
@@ -4,11 +4,11 @@
* Copyright (C) 2005-2009 MaNGOS <http://getmangos.com/>
*/
+#include <inttypes.h>
#include "Cell.h"
#include "CellImpl.h"
#include "Chat.h"
#include "CreatureTextMgr.h"
-#include "DatabaseEnv.h"
#include "GameEventMgr.h"
#include "GossipDef.h"
#include "GridDefines.h"
| [ProcessEventsFor->[],UpdateTimer->[ProcessEvent],ProcessEvent->[,GetTargets,ProcessTimedAction,GetWorldObjectsInDist,ProcessAction],OnUpdate->[InstallEvents,ProcessEventsFor,UpdateTimer],GetScript->[GetScript,FillScript],OnMoveInLineOfSight->[ProcessEventsFor],OnInitialize->[GetScript,InstallEvents,ProcessEventsFor,In... | A core string builder for a list of objects. Private methods - Private functions - Private functions - Private functions - Private functions - Private functions -. | shouldnt < > includes be at the bottom? |
@@ -230,7 +230,7 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
# No matches, search for the default
for vhost in self.vhosts:
- if "_defualt_:443" in vhost.addrs:
+ if "_default_:443" in vhost.addrs:
return vhost
return None
| [ApacheConfigurator->[get_virtual_hosts->[_create_vhost],make_server_sni_ready->[is_name_vhost,add_name_vhost],cleanup->[restart],_create_vhost->[_add_servernames],make_vhost_ssl->[is_name_vhost,_create_vhost,add_name_vhost],dvsni_perform->[choose_virtual_host,restart,make_server_sni_ready],create_redirect_vhost->[_cre... | Selects a virtual host based on the given target name. | I guess this is the "severe one"... Shall we have a unittest for that? @jdkasten? |
@@ -523,6 +523,9 @@ class Installer
foreach ($operations as $operation) {
// collect suggestions
if ('install' === $operation->getJobType()) {
+ if (!$this->installExtensions && $operation->getPackage()->getType() == 'extension') {
+ $this->io->writeError('<warning>This packag... | [Installer->[whitelistUpdateDependencies->[packageNameToRegexp],disablePlugins->[disablePlugins]]] | Installs the package. Checks if packages that are not installed or installed are not fixed to a version in lock. Checks if the current package is not installed in the lock file and if so installs it. Finds a node - level package that can be installed and install it if it can. | @nadernan this is actually where it skips extension. I suppose the part in the other file is not required anymore, right? Can test again tomorrow but advice's welcome |
@@ -51,9 +51,9 @@ public class Plumbers
try {
inputRow = firehose.nextRow();
}
- catch (ParseException e) {
- if (reportParseExceptions) {
- throw e;
+ catch (ParseException | IOException e) {
+ if (e instanceof ParseException && reportParseExceptions) {
+ throw (ParseExce... | [Plumbers->[addNextRow->[nextRow,incrementDedup,debug,getRowCount,incrementThrownAway,incrementProcessed,add,ISE,getReasonOfNotAdded,incrementUnparseable],Logger]] | Adds the next row in the queue. | I think `IOException` is different in spirit from `ParseException` and should not be treated the same. Could you modify `Plumbers.addNextRow` to `throws IOException` instead of catching the `IOException` here? |
@@ -41,6 +41,9 @@ namespace Dynamo.Migration
}
}
+ /// <summary>
+ /// A class which provides functionality for managing migration of Dynamo workspaces
+ /// </summary>
public class MigrationManager : LogSourceBase
{
/// <summary>
| [NodeMigrationData->[CreateConnector->[GetGuidFromXmlElement]],MigrationManager->[ProcessWorkspace->[ProcessWorkspace]]] | Creates a base class which represents a single version of a managed system that can be used to This collection of types which contain migration methods. | This class contains methods and properties used for migration of Dynamo workspaces. |
@@ -1424,7 +1424,7 @@ def test_staff_create(
)
-@patch("saleor.dashboard.emails._send_set_user_password_email_with_url.delay")
+@patch("saleor.core.emails._send_set_user_password_email_with_url.delay")
def test_staff_create_send_password_with_url(
_send_set_user_password_email_with_url_mock,
staff_a... | [test_password_reset_email_non_existing_user->[post_graphql,get_graphql_content,assert_not_called],test_password_change_incorrect_old_password->[check_password,post_graphql,get_graphql_content,refresh_from_db],test_user_with_cancelled_fulfillments->[upper,len,post_graphql,to_global_id,get_graphql_content,add],test_me_q... | Test staff create send password with url mock. | All the above: maybe it would be better to move those tasks to `saleor.account.emails`? |
@@ -65,8 +65,8 @@ print "Sensors names : %s" % significant_sensors_names
import matplotlib.pyplot as plt
# load sensor layout
-from mne.layouts import read_layout
-layout = read_layout('Vectorview-grad')
+from mne.layouts import find_layout
+layout = find_layout(epochs.info)
# Extract mask and indices of active ... | [read_events,permutation_t_test,figure,figtext,show,dict,get_data,squeeze,read_layout,zeros,mean,data_path,len,axis,scatter,index,Raw,logical_and,Epochs,pick_types] | Plot the position of the active sensors in the vector view. Show the ectree of the current color. | @agramfort thanks for your patience -- this now open for discussion / review ;-) And we directly hit into the first issue we did not consider. Our clean Layout object now does not match with the old channel names in raw. As a consequence, in this example no sensors significant are shown. Options: 1) repeat the property... |
@@ -25,10 +25,17 @@ RuntimeThreadData::RuntimeThreadData()
this->hevntInitialScriptCompleted = CreateEvent(NULL, TRUE, FALSE, NULL);
this->hevntReceivedBroadcast = CreateEvent(NULL, FALSE, FALSE, NULL);
this->hevntShutdown = CreateEvent(NULL, TRUE, FALSE, NULL);
+ this->hSemaphore = nullptr;
+ this... | [No CFG could be retrieved] | This function initializes a single - word object that can be used to retrieve the current state of Gets an array buffer of the given number of elements. | is there a reason not to do these in an initializer list, or better yet, in class initialization? |
@@ -0,0 +1,9 @@
+package checks;
+
+import org.junit.jupiter.api.Test;
+
+public class NoTestsInProductionFile { // Noncompliant [[sc=14;ec=35]] {{Move this test class to a separate assembly in this solution.}}
+
+ public void not_a_test(){}
+
+}
| [No CFG could be retrieved] | No Summary Found. | Remove this `Noncompliant` message, and replace it by `compliant`, as we do not expect any issue here. I guess it's a copy-paste issue, but this is misleading. |
@@ -216,4 +216,18 @@ public class CommonCoderTest {
byte[] encoded = CoderUtils.encodeToByteArray(coder, testValue, context);
assertThat(testSpec.toString(), encoded, equalTo(testSpec.getSerialized()));
}
+
+ /**
+ * Utility for adding new entries to the common coder spec -- prints the serialized bytes ... | [CommonCoderTest->[convertValue->[convertValue,getUrn],data->[loadStandardCodersSuite],executeSingleTest->[convertValue,getValue,getNested,getSerialized,assertCoderIsKnown,instantiateCoder,getCoder],assertCoderIsKnown->[assertCoderIsKnown,getUrn,getComponents],instantiateCoder->[instantiateCoder,getUrn,getComponents],l... | Test if a single value is encoded in a coder. | This could instead do something like below, to be consistent with python? You would get `\u` instead of `\x` for non-ascii chars and ascii ones are printed as is. ` objectMapper.writeValueAsString(new String(bytes, StandardCharsets.ISO_8859_1);); ` |
@@ -424,7 +424,7 @@ class ContactController extends AbstractRestController implements ClassResourceI
}
/**
- * @param $id
+ * @param int|string $id
*
* @return \Symfony\Component\HttpFoundation\Response
*/
| [ContactController->[initFieldDescriptors->[getFieldDescriptors],getList->[getFieldDescriptors]]] | Updates a contact node. | should be `int` |
@@ -52,6 +52,8 @@ int ssl3_send_alert(SSL *s, int level, int desc)
* protocol_version alerts */
if (desc < 0)
return -1;
+ if (s->shutdown & SSL_SENT_SHUTDOWN && desc != SSL_AD_CLOSE_NOTIFY)
+ return -1;
/* If a fatal one, remove from cache */
... | [ssl3_dispatch_alert->[msg_callback,cb,do_ssl3_write,BIO_flush],ssl3_do_change_cipher_spec->[change_cipher_state,ERR_raise,setup_key_block],ssl3_send_alert->[SSL_CTX_remove_session,SSL_TREAT_AS_TLS13,ssl_dispatch_alert,RECORD_LAYER_write_pending,alert_value,tls13_alert_code]] | Send an SSL 3. 0 alert. | There is perhaps a subtle philosophical question of whether attempting to send a fatal alert after shutdown should remove the session from the cache ... I am not sure there is a clear right answer, so the answer that's here is probably tolerable. |
@@ -461,8 +461,11 @@ void MarlinUI::clear_lcd() { } // Automatically cleared by Picture Loop
void MenuItem_sdbase::draw(const bool sel, const uint8_t row, PGM_P const, CardReader &theCard, const bool isDir) {
if (mark_as_selected(row, sel)) {
- if (isDir) lcd_put_wchar(LCD_STR_FOLDER[0]);
- ... | [No CFG could be retrieved] | Draw a boxed string in the LCD. UBL LCD plot. | One character position was reserved for directory icon, but for regular files this leads to one place of filename were always blank. |
@@ -650,11 +650,16 @@ export class AmpStoryPlayer {
}
/**
- * Reacts to touchstart events and caches its coordinates.
+ * Reacts to touchstart events, caches its coordinates,
+ * and ends the autoplay mode if activated.
* @param {!Event} event
* @private
*/
onTouchStart_(event) {
+ if (t... | [No CFG could be retrieved] | React to selectDocument events and cache the visibility state of the story. On swipeX event. | Doing this check in `touchStart_` won't work for desktop. |
@@ -2,7 +2,7 @@ require 'fingerprinter'
require 'identity_validations'
class ServiceProvider < ApplicationRecord
- self.ignored_columns = %w[deal_id agency aal]
+ self.ignored_columns = %w[deal_id agency aal fingerprint]
belongs_to :agency
| [ServiceProvider->[encryption_opts->[encrypt_responses?]]] | Initialize a model instance. load_cert load_cert load_cert load_redirect_uris load_cert load. | this was a very old column and adding it here makes sure we don't reference it at all |
@@ -9,7 +9,8 @@ export const SettingsConstants = keyMirror(
SET_PIN: null,
SET_BIOMETRY_TYPE: null,
SET_LANGUAGE: null,
- SET_CURRENCY: null
+ SET_CURRENCY: null,
+ SET_PIN_STATUS: null
},
'SETTINGS'
)
| [No CFG could be retrieved] | Create a Settings object from a key object. | No longer used? |
@@ -36,6 +36,7 @@ public class CodecSupport {
private static final Logger logger = LoggerFactory.getLogger(CodecSupport.class);
private static Map<Byte, Serialization> ID_SERIALIZATION_MAP = new HashMap<Byte, Serialization>();
private static Map<Byte, String> ID_SERIALIZATIONNAME_MAP = new HashMap<Byte, ... | [CodecSupport->[deserialize->[deserialize,getSerialization],getSerialization->[getSerializationById]]] | PUBLIC METHODS This class imports all the required packages and imports all the necessary packages. This method returns the Serialization object for the given ID. | **SERIALIZATIONNAME_ID_MAP** is better, in my opinion. |
@@ -305,7 +305,7 @@ function permissions_sql($owner_id, $remote_verified = false, $groups = null)
if ($remote_verified) {
$gs = '<<>>'; // should be impossible to match
- if (is_array($groups) && count($groups)) {
+ if (is_array($groups)) {
foreach ($groups as $g) {
$gs .= '|<' . intval($g) . '>... | [No CFG could be retrieved] | Get the SQL to check permissions for a contact SQL for deny and deny_cid and deny_gid. | The count is not needed as the foreach wont loop over an empty array? |
@@ -181,6 +181,8 @@ class CarState(object):
elif CP.carFingerprint == "HONDA ACCORD 2016 TOURING":
# fake civic
self.accord = True
+ elif CP.carFingerprint == "HONDA CR-V 2016 TOURING":
+ self.crv = True
else:
raise ValueError("unsupported car %s" % CP.carFingerprint)
| [CarState->[__init__->[ValueError,get_can_parser],update->[update_can,any,interp,abs]],get_can_parser->[append,CANParser]] | Initialize the object with the information from the CP. | do you need to init it with False ahead, like line #175 - line #176 |
@@ -361,8 +361,9 @@ class NginxParser(object):
except errors.MisconfigurationError as err:
raise errors.MisconfigurationError("Problem in %s: %s" % (filename, str(err)))
- def duplicate_vhost(self, vhost_template, remove_singleton_listen_params=False,
- only_directives=None):
+ def ... | [_add_directive->[_parse_ssl_options,_find_location,comment_directive,can_append,_is_whitespace_or_comment,_comment_out_directive],_update_or_add_directive->[_is_whitespace_or_comment,_update_directive,_find_location,_add_directive],_parse_ssl_options->[load],_do_for_subarray->[_do_for_subarray],_update_directive->[com... | Modify server directives based on a new block. Add a new vhost to the list of enclosing blocks and update the host path and the host. | Shouldn't the type of `only_directives` be wrapped in `Optional`? |
@@ -128,6 +128,7 @@ class Task:
self.ph_child_last = None # Paring heap
self.ph_next = None # Paring heap
self.ph_rightmost_parent = None # Paring heap
+ self.shield = False
def __iter__(self):
if not hasattr(self, "waiting"):
| [ph_pairing->[ph_meld],TaskQueue->[push_sorted->[ph_meld],remove->[ph_delete],push_head->[push_sorted],pop_head->[ph_pairing]],Task->[__iter__->[TaskQueue],cancel->[remove,push_head],__next__->[push_head]],ph_delete->[ph_pairing]] | Initialize a new Task object. | Adding this here means increasing the size of all tasks, even those that don't use shield, and would ideally be avoided. In the C implementation of `Task` you can see that the size of the task is 8 words, so increasing it by one will mean it now needs 3 GC blocks rather than 2 (there are 4 words per GC block). Would be... |
@@ -992,6 +992,8 @@ int dt_view_image_expose(dt_view_image_expose_t *vals)
int32_t py = vals->py;
gboolean full_preview = vals->full_preview;
gboolean image_only = vals->image_only;
+ gboolean no_deco = vals->no_deco;
+ if(image_only) no_deco = TRUE;
float full_zoom = vals->full_zoom;
float full_x = va... | [dt_view_guess_image_over->[dt_view_process_image_over],dt_view_filmstrip_set_active_image->[dt_view_filmstrip_scroll_to_image],dt_view_image_only_expose->[dt_view_image_expose],dt_view_image_expose->[dt_view_process_image_over]] | check missing image Color thumbs are colored according to the user s settings. dt_GUI_COLOR_THUMBNAIL_HOVER_FONT dt_ free all of the image - no need to call this function Missing color in image count missing images read lock for read lock and read lock for write lock missing - color missing - color missing - color miss... | const gboolean no_deco = image_only ? TRUE : vals->no_deco; |
@@ -241,6 +241,16 @@ def resolve_allowed_tags(model_obj, tags_curr, tags_new,
return tags_out
+class IPBanManager(models.Manager):
+ def active(self, ip):
+ return super(IPBanManager, self).filter(ip=ip, deleted__isnull=True)
+
+ def delete_old(self, days=30):
+ cutoff_date = date.today() -... | [resolve_allowed_tags->[parse_tag_namespaces,allows_tag_namespace_for],_PrefetchTaggableManager->[get_prefetch_query_set->[get_query_set]],_NamespacedTaggableManager->[set_ns->[add_ns,clear_ns]],PrefetchTaggableManager->[__get__->[_PrefetchTaggableManager]]] | Get existing tags or lack thereof tags. | `self.filter(..)` is enough, the call to `get_query_set` is implied when using `self` |
@@ -753,6 +753,7 @@ export function installUrlReplacementsServiceForDoc(ampdoc) {
* @param {*} varSource
*/
export function installUrlReplacementsForEmbed(ampdoc, embedWin, varSource) {
+ installVarSubstitutionForEmbed(ampdoc, embedWin, varSource);
installServiceInEmbedScope(embedWin, 'url-replace',
- new... | [GlobalVariableSource->[setTimingResolver_->[getTimingDataAsync,getTimingDataSync],constructor->[shareTrackingForOrNull,variantForOrNull],getAccessValue_->[getter,user],getQueryParamData_->[user,search,parseQueryString,parseUrl],getDocInfoValue_->[getter,documentInfoForDoc],initialize->[cidFor,create,outgoingFragment,l... | Installs UrlReplacements for AMP doc in the embed window. | Do we need to install `installVarSubstitutionServiceForDoc`? |
@@ -1224,7 +1224,7 @@ func (display *ProgressDisplay) getStepInProgressDescription(step engine.StepEve
return op.Color() + getDescription() + colors.Reset
}
-func writeString(b *bytes.Buffer, s string) {
+func writeString(b io.StringWriter, s string) {
_, err := b.WriteString(s)
contract.IgnoreError(err)
}
| [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | getStepInProgressDescription returns a description of the step in progress. | Just guessing this is due to the newer compiler helpfully telling us to make this change? |
@@ -516,7 +516,8 @@ class TrainLoop:
cnt = valid_world.report().get('exs') or 0
valid_report = valid_world.report()
- valid_world.reset() # make sure world doesn't remember valid data
+ if opt.get('validation_share_agent', False):
+ valid_world.reset() # make sure worl... | [TrainModel->[run->[TrainLoop,train],setup_args->[setup_args]],TrainLoop->[validate->[load_eval_worlds,save_model],train->[save_model,_run_eval,load_eval_worlds,validate,log],log->[_sync_metrics,_compute_eta],_run_eval->[_run_single_eval]]] | Run single - validation evaluation on a list of validation worlds. Print out the report and metrics for a . | so we're sure this is only necessary if `validation_share_agent` is `True`? |
@@ -64,6 +64,17 @@ void getValidParameters(Teuchos::ParameterList& params)
params.set("fact: iluk level-of-fill", (int)1);
params.set("fact: iluk level-of-overlap", (int)0);
+ // Ifpack2_Chebyshev
+ params.set("chebyshev: max eigenvalue",STS::nan());
+ params.set("chebyshev: ratio eigenvalue",STS::nan());
+ ... | [getValidParameters->[sublist,set]] | Get valid parameters from the block of unused parameters. Missing params. - - - - - - - - - - - - - - - - - - missing partitioner parameters. | 1. Avoid C-style casts; use C++ casts (either `double(30.0)` or `static_cast<double>(30.0)` -- I prefer the latter for integer casts, which may be a source of bugs). 2. The type of the literal `30.0` is `double`. |
@@ -299,6 +299,16 @@ class HTTPError(DvcException):
super().__init__(f"'{code} {reason}'")
+class WebDAVConfigError(DvcException):
+ def __init__(self, host):
+ super().__init__(f"Configuration for WebDAV {host} is invalid.")
+
+
+class WebDAVConnectionError(DvcException):
+ def __init__(self,... | [GitHookAlreadyExistsError->[__init__->[format_link,super,format]],DownloadError->[__init__->[super]],FileMissingError->[__init__->[super]],RecursiveAddingWhileUsingFilename->[__init__->[super]],CircularDependencyError->[__init__->[super,format,isinstance]],CheckoutErrorSuggestGit->[__init__->[super]],NoPlotsError->[__... | Exception class for the failure of checkout. Raises an exception if the target is not an output or a stage name in dvc. | These are only used in webdav.py, so let's move them there. Also i'm not sure we need a special WebDAVConfigError exception. We could just raise ConfigError or at least inherit from it. |
@@ -504,6 +504,15 @@ class PexLayoutField(StringField):
)
+class PexIncludeRequirementsField(BoolField):
+ alias = "include_requirements"
+ default = True
+ help = (
+ "Whether to include the third party requirements the binary depends on in the "
+ "packaged PEX file."
+ )
+
+
class... | [parse_requirements_file->[parse,format_invalid_requirement_string_error],_PipRequirementSequenceField->[compute_value->[parse,format_invalid_requirement_string_error]],PexScriptField->[compute_value->[ConsoleScript]],PythonResolveField->[validate->[UnrecognizedResolveNamesError],resolve_and_lockfile->[validate]],PexEn... | A field that specifies the layout used for the PEX binary. Get the fields of the object that are not part of the object. | Maybe mention a sentence for why this can be useful? > this can be useful, for example, if you provide the dependencies through the external environment and want a smaller binary. |
@@ -282,12 +282,12 @@ class Middleware::RequestTracker
type = 60
limiter60.performed!
false
- rescue RateLimiter::LimitExceeded
+ rescue RateLimiter::LimitExceeded => e
if warn
Discourse.warn("Global IP rate limit exceeded for #{ip}: #{type} second rate limit", u... | [log_request_info->[get_data],call->[populate_request_queue_seconds!,call,log_request_info],log_later->[log_request],rate_limit->[call,is_private_ip?]] | rate limit the given node if it is not already in the request and if it is not check if there are too many requests per IP. | Ditto ^^. What does `available_in` mean ? |
@@ -17,7 +17,10 @@ module View
def render
@tile.towns.map do |town|
if @tile.lawson?
- h(Part::TownDot, region_use: @region_use, color: color_for(town))
+ h(Part::TownDot, tile: @tile, region_use: @region_use, color: color_for(town))
+ elsif @tile.paths.empty?
+... | [Towns->[color_for->[paths,town,class,find_index,any?,paths_for,map],render->[h,lawson?,color_for,flat_map,map],needs,freeze],require] | Renders a list of missing keys in the Hilbert Layout. | this looks exactly the same, how about tile.lawson? || empty |
@@ -311,4 +311,16 @@ var _ = Describe("Podman logs", func() {
logs.WaitWithDefaultTimeout()
Expect(logs).To(Not(Exit(0)))
})
+
+ It("follow output stopped container", func() {
+ containerName := "logs-f"
+
+ logc := podmanTest.Podman([]string{"run", "--name", containerName, "-d", ALPINE})
+ logc.WaitWithDefa... | [WaitWithDefaultTimeout,CombinedOutput,OutputToStringArray,Cleanup,ExitCode,Should,Sprintf,ErrorToString,Contains,OutputToString,To,SeedImages,Podman,Exit,Setup,Command] | Wait until the process exits with a non - zero status. | I'm not comfortable with this usage (relying on ALPINE's entrypoint to exit immediately). Could you add an explicit command such as `true`? |
@@ -120,7 +120,7 @@ func (r *shootQuotaReconciler) Reconcile(ctx context.Context, request reconcile.
expirationTime = shoot.CreationTimestamp.Add(time.Duration(*clusterLifeTime*24) * time.Hour).Format(time.RFC3339)
metav1.SetMetaDataAnnotation(&shoot.ObjectMeta, common.ShootExpirationTimestamp, expirationTime)
... | [Reconcile->[SetMetaDataAnnotation,Now,Duration,Shoots,Delete,Info,Add,Format,Lister,UTC,Errorf,DefaultUpdateOptions,After,Infof,ConfirmDeletion,SecretBindings,Get,Update,ForGarden,CoreV1beta1,Client,Quotas,GardenCore,Parse,GetClient,IsNotFound],shootQuotaDelete->[DeletionHandlingMetaNamespaceKeyFunc,Done],shootQuotaAd... | Reconcile is responsible for reconciling the Shoot object This function is used to reconcile the Shoot s lifetime with the expiration timestamp. | Switch to c-r here? |
@@ -132,10 +132,6 @@ def handle_worker_offline(event):
"""
event_info = _parse_and_log_event(event)
- # if this is the resource_manager do nothing
- if _is_resource_manager(event):
- return
-
msg = _("Worker '%(worker_name)s' shutdown") % event_info
_logger.info(msg)
_delete_work... | [handle_worker_heartbeat->[_parse_and_log_event,_is_resource_manager],handle_worker_offline->[_parse_and_log_event,_is_resource_manager]] | Handle a worker offline event. | Oh neat, so the resource_manager also gets tracked now. Makes sense. Hopefully we have protections to keep it from assigning work to itself or the scheduler? (I'm only like 33% through this PR ) |
@@ -45,6 +45,7 @@ public class PlainTextKafkaProducerFactory
.collect(joining(",")))
.put(ACKS_CONFIG, "all")
.put(LINGER_MS_CONFIG, 5)
+ .putAll(Maps.fromProperties(kafkaConfig.getSecurityConfigProperties()))
.build();
}
| [PlainTextKafkaProducerFactory->[create->[ByteArraySerializer],build,copyOf,getNodes,requireNonNull]] | Creates a KafkaProducer with the properties set in the constructor. | We can do a static import for `fromProperties` |
@@ -136,12 +136,16 @@ class Command(object):
# and when it is done, isinstance is not needed anymore
if isinstance(status, int):
exit = status
+ except NeedSetuptools:
+ # XXX assume we are in the install command
+ self.run(options, ['setuptools'])... | [Command->[_copy_option_group->[_copy_options],main->[setup_logging,merge_options]]] | Entry point for the command line interface. This function returns True if the user has successfully selected a . | a few things here: 1) as you know, "pip wheel" needs setuptools too, so just overtly stating this has to change for that 2) I think each pip version should set a setuptools requirement (based on our testing), not just "setuptools" 3) If setuptools is installed and doesn't meet the requirement, I think we should prompt ... |
@@ -186,6 +186,7 @@ class JSONRPCClient:
gasprice: int = None,
nonce_update_interval: float = 5.0,
nonce_offset: int = 0,
+ web3: Web3 = None,
):
if privkey is None or len(privkey) != 32:
| [JSONRPCClient->[poll->[block_number],nonce->[nonce_update_from_node,nonce_needs_update],send_transaction->[check_startgas,nonce],__init__->[make_connection_test_middleware],deploy_solidity_contract->[new_contract_proxy,dependencies_order_of_build,deploy_dependencies_symbols]]] | Initializes the object with the given private key. | you added a lot of commas, but miss one here |
@@ -34,6 +34,16 @@ public final class SqlPrimitiveType extends SqlType {
.put(SqlBaseType.STRING, new SqlPrimitiveType(SqlBaseType.STRING))
.build();
+ private static final ImmutableSet<String> PRIMITIVE_TYPE_NAMES = ImmutableSet.<String>builder()
+ .addAll(TYPES.keySet().stream().map(SqlB... | [SqlPrimitiveType->[toString->[toString],of->[of],equals->[equals]]] | Returns the SqlPrimitiveType for the given primitive type name. | Now that `INT` and `VARCHAR` are used in two places let's declare them as constants. |
@@ -8,10 +8,8 @@ use Friendica\Core\Config;
use Friendica\Core\L10n;
use Friendica\Core\Protocol;
use Friendica\Database\DBA;
-use Friendica\Model\Contact;
-use Friendica\Model\Profile;
-
-require_once 'mod/contacts.php';
+use Friendica\Model;
+use Friendica\Module\Contact;
function crepair_init(App $a)
{
| [No CFG could be retrieved] | This function is called when the user is not logged in and is not in a system. | Although this is correct, please write `use Friendica\Module;` and later `Module\Contact::getTabsHTML` to prevent any immediate confusion. |
@@ -957,6 +957,8 @@ ROM_START(orica)
ROMX_LOAD( "bas122sw_le.rom", 0, 0x04000, CRC(e7fd57a4) SHA1(c75cbf7cfafaa02712dc7ca2f972220aef86fb8d), ROM_BIOS(22))
ROM_SYSTEM_BIOS( 23, "ver122uk", "Basic 1.22 UK")
ROMX_LOAD( "bas122uk_le.rom", 0, 0x04000, CRC(9865bcd7) SHA1(2a92e2d119463e682bf10647e3880e26656d65b5), ROM_B... | [No CFG could be retrieved] | Return list of supported BIOS ROMs. SHA - 1 - 1 - 2 - 15 - - - - - - - - - - - - - - - - - -. | If it's not for the Atmos, it shouldn't be here. |
@@ -66,7 +66,8 @@ def train(use_cuda, save_dirname):
train_func=train_program,
infer_func=inference_program,
place=place,
- optimizer=optimizer)
+ optimizer=optimizer,
+ parallel=True)
def event_handler(event):
if isinstance(event, fluid.EndEpochEvent):
| [train->[train],train_program->[inference_program],infer->[infer],main->[train,infer],main] | Trains the model on the n - node node. reader for nseq file. | Move parallel to trainer's constructor. It cannot be changed after we create a trainer. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.