patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -245,13 +245,16 @@ describe Idv::ConfirmationsController do
expect(@analytics).to have_logged_event(Analytics::IDV_DOWNLOAD_PERSONAL_KEY, success: true)
end
- it 'recovers pii with the code' do
+ it 'recovers pii and verifies personal key digest with the code' do
get :show
get :down... | [stub_idv_session->[profile_id,to,new,and_return,stub_sign_in,pii_attributes,save_profile,personal_key,user_session,applicant,id,pii,resolution_successful],index->[render],create,phone,let,to_not,describe,personal_key,it,session,to,profile_id,create_profile_from_applicant_with_password,user_phone_confirmation,vendor_ph... | finds the personal_key in the session and checks the response contains the code. | if we're no longer using `normalize_personal_key` we can remove `include PersonalKeyValidator` up top, and probably want to update the spec on like 111 to check pii as well |
@@ -217,11 +217,14 @@ class SegmentationDIAcc(PerImageEvaluationMetric):
result = np.zeros(shape=self.classes)
annotation_data = annotation.mask
- prediction_data = np.argmax(prediction.mask, axis=0) if self.use_argmax else prediction.mask.astype('int64')
+ prediction_data = prediction... | [SegmentationMetric->[update->[confusion_matrix]],SegmentationDIAcc->[parameters->[update]]] | Update the n - node metric. | I think use_argmax should be stayed here, because not all models use resample postprocessing |
@@ -41,11 +41,16 @@ module View
end
def render_title
+ bg_color = if setting_for(:show_player_colors, @game)
+ player_colors(@game.players)[@player] || color_for(:bg2)
+ else
+ color_for(:bg2)
+ end
props = {
... | [Player->[render_priority_deal->[h],render_corporation_shares->[h,logo,president?,setting_for,sum,name,simple_logo],render->[h,empty?,any?,render_minors,can_act?],render_next_sr_position->[next_sr_position,h,ordinal],render_body->[h,any?],render_title->[name,color_for,h],render_info->[bidding_token_per_player,priority_... | Renders a hidden tag with a . | I don't really care about it, but something like `convert_hex_to_rgba(route_prop(idx % ROUTE_COLORS.size, 'color'), 0.5)` for players 9+ in `player_colors` might work. => no merge, because I'm not sure if you want to invest more time into this. |
@@ -210,5 +210,11 @@ func newDestroyCmd() *cobra.Command {
&eventLogPath, "event-log", "",
"Log events to a file at this path")
}
+
+ // internal flag
+ cmd.PersistentFlags().StringVar(&execKind, "exec-kind", "", "")
+ // ignore err, only happens if flag does not exist
+ _ = cmd.PersistentFlags().MarkHidden("... | [Printf,StringVar,GetGlobalColorization,Error,RunResultFunc,StringArrayP,New,PersistentFlags,IntVarP,StringVarP,FromError,Destroy,Ref,Wrap,Interactive,BoolVarP,URN,BoolVar] | Log events to a file at this path. | Any benefit to making this a flag vs just an env var? Seems an env var might offer more flexibility? Also - any reason to constrain the values vs just allow consuming code to set this to whatever they want? |
@@ -752,6 +752,8 @@ namespace System.Net
}
}
} while (!_tokenizer.Eof && !_tokenizer.EndOfCookie);
+ if (!expiresSet && cookie != null)
+ cookie.Expires = DateTime.MaxValue;
return cookie;
}
| [CookieParser->[Cookie->[InternalSetNameMethod]],CookieTokenizer->[CookieToken->[IsEqualTo,Extract]]] | Gets the next cookie. Get the next cookie in the cookie - token. This method is called to find the next non - null cookie in the header. end of cookie. | nit: style guide says to have a blank line before this 'if' block. |
@@ -367,7 +367,7 @@ class FulfillmentLine(models.Model):
OrderLine, related_name='+', on_delete=models.CASCADE)
fulfillment = models.ForeignKey(
Fulfillment, related_name='lines', on_delete=models.CASCADE)
- quantity = models.IntegerField(validators=[MinValueValidator(1)])
+ quantity = mode... | [Order->[can_capture->[can_capture,get_last_payment],get_payment_status_display->[get_last_payment],can_charge->[can_charge,get_last_payment],can_void->[can_void,get_last_payment],total_authorized->[get_last_payment],total_captured->[get_last_payment],can_refund->[can_refund,get_last_payment],get_payment_status->[get_l... | Returns an iterator over the objects in the order. The order event class. | With this change, this field basically becomes a `PositiveIntegerField`. |
@@ -44,10 +44,16 @@ class SCMData(object):
return self.revision
raise ConanException("Not implemented recipe revision for %s" % self.type)
+ @property
+ def shallow(self):
+ return self._shallow in [None, "True"]
+
def __repr__(self):
d = {"url": self.url, "revision": ... | [SCM->[get_revision->[get_revision],get_remote_url->[get_remote_url],excluded_files->[excluded_files],get_local_path_to_url->[clean_url,get_repo_root,SCM],get_qualified_remote_url->[get_qualified_remote_url,get_remote_url],is_local_repository->[is_local_repository],get_repo_root->[get_repo_root],checkout->[checkout],is... | Return a string representation of the object in JSON format. | The below is already filtering for None values |
@@ -223,10 +223,9 @@ class JSONRPCClient:
gas_limit = self.web3.eth.getBlock(location)['gasLimit']
return gas_limit * 8 // 10
- def gas_price(self, transaction: Dict = None) -> int:
- if transaction is None:
- transaction = dict()
- return int(self.web3.eth.generateGasPri... | [JSONRPCClient->[poll->[block_number],send_transaction->[check_startgas,gas_price],__init__->[monkey_patch_web3],deploy_solidity_contract->[new_contract_proxy,get_transaction_receipt,dependencies_order_of_build,deploy_dependencies_symbols],check_startgas->[gaslimit]],monkey_patch_web3->[make_connection_test_middleware]... | Returns the gas limit for the current block. | Why remove the transaction argument? |
@@ -165,6 +165,7 @@ $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."accounting_system as asy ON aa.fk_pcg_vers
if ($db->type == 'pgsql') $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."accounting_account as a2 ON a2.rowid = CAST(aa.account_parent AS INTEGER)";
else $sql .= " LEFT JOIN ".MAIN_DB_PREFIX."accounting_account as a2 ON a2.row... | [fetch,plimit,query,getNomUrl,executeHooks,formconfirm,trans,num_rows,account_activate,fetch_object,account_desactivate,close,multiSelectArrayWithCheckbox,fetch_row,order,showFilterAndCheckAddButtons,load] | Displays the list of accounts in the system. Search for a number of national cGroup records. | If you put the AND here, you break the LEFT JOIN. It become an OUTER JOIN. Don't think it 's expected. the AND must be after the ON ... on the LEFT join line. |
@@ -47,7 +47,7 @@ namespace NServiceBus
}
}
- public async Task Initialize()
+ public async Task Initialize(IBuilder builder)
{
if (IsSendOnly)
{
| [ReceiveComponent->[AddReceivers->[Create,RecoverabilityPolicy,Add,BuildMessagePump,TransactionMode,RuntimeSettings,Name,SatelliteDefinitions,PushRuntimeSettings,ReceiveAddress,RequiredTransportTransactionMode,InstanceSpecificQueue,LocalAddress,PurgeOnStartup,builder,CreateDefault],BindQueues->[SatelliteDefinitions,Rec... | Binds queues to the pipeline. | This would then also have a cancellation token |
@@ -369,12 +369,14 @@ namespace System.Xml
{
_nameTableFromSettings = true;
}
+
_nameTable = nt;
_namespaceManager = new XmlNamespaceManager(nt);
}
else
{
SetupFromParserConte... | [No CFG could be retrieved] | Creates a new instance of this class. Missing comments. | Do we still need this |
@@ -600,6 +600,7 @@ dc_array_create(tse_task_t *task)
D_GOTO(err_put2, rc);
}
+ tse_task_schedule(open_task, false);
tse_task_schedule(update_task, false);
tse_sched_progress(tse_task2sched(task));
| [No CFG could be retrieved] | Create the object metadata write tasks This function is called from the array open handling routines. | I tend to think we probably should check pid (or other cookie) to make sure those completion callbacks will only be executed by its own threads. i.e. we only share the tse over different threads. |
@@ -35,7 +35,10 @@ import (
"github.com/streamrail/concurrent-map"
)
-var oxyLogger = &OxyLogger{}
+var (
+ oxyLogger = &OxyLogger{}
+ backend2FrontendMap map[string]string
+)
// Server is the reverse-proxy/load-balancer engine
type Server struct {
| [Close->[Stop,Close],prepareServer->[createTLSConfig],listenSignals->[Stop],loadConfig->[buildEntryPoints]] | Package that imports all of the modules that are imported by the package. NewServer creates a new server object with the given global configuration. | Not sure this map is thread-safe. And I also don't think it should be globale. You are creating a new map at each config reload. And there is also one in `middlewares/logger.go`. Do you really need this one ? |
@@ -236,10 +236,7 @@ public abstract class AbstractAi extends AbstractBasePlayer implements ITripleAP
final Collection<String> myAlliances =
new HashSet<>(getGameData().getAllianceTracker().getAlliancesPlayerIsIn(getPlayerId()));
myAlliances.retainAll(getGameData().getAllianceTracker().getAlliancesPl... | [AbstractAi->[whatShouldBomberBomb->[getMatches,next,isEmpty,unitCanProduceUnitsAndCanBeDamaged],selectKamikazeSuicideAttacks->[getValue,size,getInt,getResourcesCopy,shuffle,put,getPlayerId,min,getKey,getHitPoints,next,entrySet,removeKey,getOrDefault,get,random,add,getSuicideAttackResources,keySet],pause->[sleep,intVal... | Method that checks if the player is in the alliance tracker and if so it can This method is used to assign random attacks to each unit in the territory. kamikazeSuicideAttacks - add resource to attackTokens - remove. | General note. We shouldn't rely on Math.random() for anything game-related. It's not random enough. |
@@ -1271,6 +1271,9 @@ struct KeyCache {
void KeyCache::populate()
{
+ key[KEYMAP_ID_DIG] = getKeySetting("keymap_dig");
+ key[KEYMAP_ID_PLACE] = getKeySetting("keymap_place");
+
key[KEYMAP_ID_FORWARD] = getKeySetting("keymap_forward");
key[KEYMAP_ID_BACKWARD] = getKeySetting("keymap_backward"... | [No CFG could be retrieved] | This method is called by the UI when a key is pressed. It populates the KeyCache Get Key Key. | The equal signs should be on the same level, just like below. |
@@ -20,7 +20,7 @@ public class AnnotationsTest extends TestCase {
try (Analyzer analyzer = new Analyzer();) {
TypeRef typeref = analyzer.getTypeRefFromFQN(ActualAnnotation.class.getName());
Map<String, Object> annMap = Collections.singletonMap("a", 5);
- Annotation annotation = new Annotation(typeref, annM... | [AnnotationsTest->[testNestedAnnotations->[assertNotNull,getName,createConfigurable,singletonMap,getTypeRefFromFQN,Annotation,Analyzer,a,assertEquals,ann]]] | This method test nested annotations. | Why this change if you have a constructor which supplies the `-1`? |
@@ -368,7 +368,7 @@ namespace DebuggerTests
{
a_obj = TObject("Object"),
b_arr = TArray("Array", 2)
- }, "obj_own", num_fields: 3);
+ }, "obj_own", num_fields: 2);
});
[Theory]
| [CallFunctionOnTests->[Task->[Value,IsOk,test_fn,TIgnore,CheckValueType,Count,Ordinal,AssertEqual,CheckValue,False,RunCallFunctionOn,TGetter,PAUSE,Add,WaitFor,Error,CheckProps,Empty,CompletedTask,GetPropertiesAndCheckAccessors,CheckDateTimeValue,get_args_fn,Type,Array,SendCommand,GetObjectOnLocals,Any,DeepEquals,Invoke... | This task runs on JSObject with a specific object id. On Array Return Object ArrayByValue. | Same here, `num_fields` can be dropped. |
@@ -298,9 +298,6 @@ class ProductFilter(django_filters.FilterSet):
collections = GlobalIDMultipleChoiceFilter(method=filter_collections)
categories = GlobalIDMultipleChoiceFilter(method=filter_categories)
has_category = django_filters.BooleanFilter(method=filter_has_category)
- price = ObjectTypeFilte... | [filter_stock_availability->[filter_products_by_stock_availability],filter_minimal_price->[filter_products_by_minimal_price],ProductTypeFilter->[filter_fields_containing_value],AttributeFilter->[filter_fields_containing_value],filter_attributes->[filter_products_by_attributes],filter_categories->[filter_products_by_cat... | Filters products by type stock amount and price. Filter for product stock. | Although we remove this field from the product model, I think it would be still useful to be able to filter products by price. We could rewrite the filter logic to use variant prices instead. |
@@ -1941,7 +1941,6 @@ func genPulumiPluginFile(pkg *schema.Package) ([]byte, error) {
plugin := &plugin.PulumiPluginJSON{
Resource: true,
Name: pkg.Name,
- Version: "${PLUGIN_VERSION}",
Server: pkg.PluginDownloadURL,
}
return plugin.JSON()
| [resourceType->[modNameAndName],genInit->[hasTypes,genHeader,unqualifiedImportName,submodulesExist,isEmpty,fullyQualifiedImportName],pyType->[pyType,resourceType],isEmpty->[isEmpty],walkSelfWithDescendants->[walkSelfWithDescendants],fullyQualifiedImportName->[fullyQualifiedImportName,unqualifiedImportName],genMethods->... | genPackageMetadata generates the package metadata for a non - code package. Package name - > InstallPluginCommand. | Nice. I like this. Now, when this codegen change is adopted by the providers we aren't forced to make a change to the `Makefile` to search/replace this value. We can do it at our leisure. And we can use `jq` to add the `version` property. I do think we'll end up wanting to update our provider `Makefiles` to do this, be... |
@@ -29,6 +29,10 @@ class ApplicationController < ActionController::Base
private
+ def decorated_user
+ UserDecorator.new(current_user)
+ end
+
def after_sign_in_path_for(resource)
analytics.track_event('Authentication Successful')
stored_location_for(resource) || session[:saml_request_url] || p... | [ApplicationController->[confirm_two_factor_authenticated->[user_fully_authenticated?]]] | After sign in path for the given resource returns the path to the next page in the page. | Is it worth caching this value with ||= ? I'm not really sure how expensive the constructor is here. |
@@ -124,7 +124,7 @@ class H2OAutoML(H2OAutoMLBaseMixin, Keyed):
"""
def __init__(self,
- nfolds=5,
+ nfolds="AUTO",
balance_classes=False,
class_sampling_factors=None,
max_after_balance_size=5.0,
| [_aml_property->[_fset->[attr_name],_fget->[attr_name]],H2OAutoML->[__validate_modeling_plan->[assert_is_step_def],predict->[predict],train->[clean_params->[clean_params],clean_params],_extract_params_doc,_aml_property]] | Initialize an H2OAutoML object with the given parameters. This function is used to control the maximum time the AutoML run will dedicate to each This function is used to train more models on a single run. | As much as I like explicit values, I think we should privilege API consistency here. Each time we currently use `-1` to represent an automatic value in int estimator params, we leave it to `-1` and just mention in the doc that it means the value is set automatically on backend. We've been educating users to this, and w... |
@@ -546,6 +546,18 @@ public class GrpcServerProcessor {
}
}
+ @BuildStep
+ BeanArchivePredicateBuildItem additionalBeanArchives() {
+ return new BeanArchivePredicateBuildItem(new Predicate<ApplicationArchive>() {
+
+ @Override
+ public boolean test(ApplicationArchive a... | [GrpcServerProcessor->[registerBeans->[FeatureBuildItem,debug,unremovableOf,AdditionalBeanBuildItem,produce,current,isEmpty],registerAdditionalInterceptors->[AdditionalGlobalInterceptorBuildItem,produce,getName],extensionSslNativeSupport->[ExtensionSslNativeSupportBuildItem],validateBindableServices->[test->[contains],... | Configures the metrics. | is `archive.getIndex()` always `!= null`? |
@@ -33,8 +33,6 @@ namespace System.Windows.Forms.ComponentModel.Com2Interop {
#if DEBUG
private static TraceSwitch DbgTypeInfoProcessorSwitch = new TraceSwitch("DbgTypeInfoProcessor", "Com2TypeInfoProcessor: debug Com2 type info processing");
- #else
- private static TraceSwitc... | [Com2TypeInfoProcessor->[FindTypeInfos->[FindTypeInfo],Com2Properties->[FindTypeInfos],InternalGetProperties->[GetNameDispId],PropInfo->[GetHashCode->[GetHashCode]]]] | Creates a class that can be used to build a COM2 type descriptor. Find the type information for an object. | Why not just unconditionally assign a value to `DbgTypeInfoProcessorSwitch` (even in Release builds)? In other words, can we use the current change except also remove the `#if DEBUG` lines around the field and inside the `Trace` method? |
@@ -3797,7 +3797,7 @@ namespace DotNetNuke.Services.Upgrade
/// <remarks>
/// </remarks>
/// -----------------------------------------------------------------------------
- public static int AddPortal(XmlNode node, bool status, int indent)
+ public static int AddPortal(XmlNode n... | [Upgrade->[UpgradeToVersion520->[AddModuleDefinition,AddModuleToPage,AddModuleControl,GetModuleDefinition],UpgradeToVersion720->[AddModuleDefinition,AddModuleControl,Upgrade],UpgradeToVersion600->[RemoveModuleControl,AddIconToAllowedFiles,FavIconsToPortalSettings,AddDefaultModuleIcons,GetModuleDefinition,RemoveModule,A... | Adds a new portal with the specified name and status. Create a new portal folder with the specified name and alias. Updates the user with the given portalId if it exists and returns the new portalId. | You are going to need to mark the old AddPortal function obsolete and removed in v11. Otherwise the changes look good! Thanks for tracking down the issue and getting a fix submitted! |
@@ -179,10 +179,11 @@ function adoptShared(global, opts, callback) {
if (!global.AMP.extension) {
/**
* @param {string} unusedName
+ * @param {string} unusedVersion
* @param {function(!Object)} installer
* @const
*/
- global.AMP.extension = function(unusedName, installer) {
+ g... | [No CFG could be retrieved] | Adds a shared AMP object to the global AMP object. Registers an extended template and an ampdoc service. | Can we go ahead and replace this `if` with `minified` or whatever `if` that will strip this function from PROD version? |
@@ -487,7 +487,7 @@ namespace Microsoft.Xna.Framework.Graphics
#else //PSM
internal void ReadEffect(BinaryReader reader)
{
- var effectPass = new EffectPass(this, "Pass", null, null, BlendState.AlphaBlend, DepthStencilState.Default, RasterizerState.CullNone, new EffectAnnotationCollection());
+ var effectPas... | [Effect->[FlushCache->[Dispose],Dispose->[Dispose]]] | ReadEffect reads the BasicEffect from the binary stream. | EffectAnnotationCollection() no longer exists, or was not pushed? A parameter is required, so I will pass in null. |
@@ -3626,13 +3626,13 @@ describe InfoRequest do
context 'when there is no value stored in the database' do
it 'returns the date a response is required by' do
- time_travel_to(Date.parse('2014-12-31')) do
+ time_travel_to(Time.zone.parse('2014-12-31')) do
info_request.send(:write_a... | [apply_filters->[request_list,map],create_old_unclassified_no_user->[awaiting_description,save,create],create_old_unclassified_holding_pen->[awaiting_description,save,create],create_old_unclassified_described->[create],create_old_unclassified_request->[awaiting_description,save,create],create_recent_unclassified_reques... | adds some tests to the message object expects date a response is very overdue after. | Place the . on the previous line, together with the method call receiver. |
@@ -814,9 +814,13 @@ export class AmpStoryInteractive extends AMP.BaseElement {
* @param {boolean} toggle
*/
toggleTabbableElements_(toggle) {
- // TODO: Revise tabbable elements on components when considering #31747.
this.rootEl_.querySelectorAll('button, a').forEach((el) => {
- el.setAttribute... | [AmpStoryInteractive->[updateToPostSelectionState_->[classList],handleOptionSelection_->[optionIndex_],adjustGridLayer_->[tagName,dev,classList,closest,parentElement],initializeListeners_->[CURRENT_PAGE_ID,tryCloseDisclaimer,RTL_STATE],getInteractiveId_->[documentInfoForDoc,deduplicateInteractiveIds,base64UrlEncodeFrom... | toggle tabbable elements. | Why do you need to check if it's an option element? What else could it be? If you really need to check that, let's test for a class or something. Doing a querySelector + a loop within a loop should be improved |
@@ -82,6 +82,13 @@ func NewClient(
index: index,
params: params,
}
+
+ client.Connection.onConnectCallback = func() error {
+ if onConnectCallback != nil {
+ return onConnectCallback(client)
+ }
+ return nil
+ }
return client
}
| [execRequest->[SetBasicAuth,Warn,NewRequest,Do,Errorf,ReadAll,Add],CheckTemplate->[request],request->[execRequest,Warn,NewReader,Marshal,Debug],Ping->[execRequest],Connect->[Ping],LoadTemplate->[Info,execRequest,Errorf],PublishEvent->[Index,Warn,Debug],PublishEvents->[Flush,Add,init,Now,Len,Bytes,Sub,Err,startBulkReque... | Clone returns a new instance of the client with the same connection information as the given client. | wrapping func once again is a little annoying. Why not have `type connectCallback func(*Client) error` and reuse type all over the place with `var noneCallback connectCallback = func(*Client) error { return nil}`. Set `noneCallback` on `&Client` and if parameter `!= nil` assign it. |
@@ -587,6 +587,7 @@ public class AncientDataMotionStrategy implements DataMotionStrategy {
if (cacheData != null) {
cacheMgr.deleteCacheObject(cacheData);
}
+ _snapshotService.markFailedSnapshot(destData.getId());
throw new CloudRuntimeException(e.toStr... | [AncientDataMotionStrategy->[pickCacheScopeForCopy->[getZoneScope],copyObject->[pickCacheScopeForCopy,copyObject,needCacheStorage],cloneVolume->[addFullCloneFlagOnVMwareDest],copyAsync->[copyObject,cloneVolume,migrateVolumeToPool,copyVolumeBetweenPools,copyVolumeFromSnapshot],copyVolumeBetweenPools->[getZoneScope,addFu... | Copy snapshot from source to destination. check if there is a cache entry and if so delete it. | @Spaceman1984 the copy callback should mark the snapshot state accordingly, based on the operation result (success / fail). Not required to set the state explicitly. |
@@ -442,6 +442,8 @@ class Algorithm(object):
def ReadFluidModelParts(self):
self.fluid_algorithm.ReadFluidModelPart()
+ for node in self.fluid_model_part.Nodes:
+ print(self.fluid_model_part)
def DispersePhaseInitialize(self):
self.spheres_model_part = self.disperse_pha... | [Algorithm->[FluidInitialize->[Initialize],TellTime->[flush],SetInletWatcher->[SetInlet],DispersePhaseInitialize->[Initialize],Initialize->[SetAllModelParts,SetUpResultsDatabase,flush],__init__->[Logger],CloneTimeStep->[CloneTimeStep],SetDragOutput->[write,flush],RunMainTemporalLoop->[flush],TellFinalSummary->[flush],F... | Reads the Fluid model parts. | Are you sure you want to print this?? |
@@ -110,6 +110,7 @@ class AddonSerializerOutputTestMixin(object):
average_rating=4.21,
bayesian_rating=4.22,
category=cat1,
+ contributions=u'https://paypal.me/foobar/',
description=u'My Addôn description',
developer_comments=u'Dévelopers Addôn... | [TestESAddonAutoCompleteSerializer->[test_translations->[serialize],test_basic->[serialize],test_icon_url_persona_with_no_persona_id->[serialize],serialize->[search],test_icon_url_with_persona_id->[serialize]],TestSimpleVersionSerializerOutput->[test_license_included_without_text->[serialize]],TestLanguageToolsSerializ... | Test basic data. AddonUser. objects. create_or_update_object is called when a user Check if the data structure is correct. Checks that the data in the result dictionary is consistent with the data in the addon. | stupid me, I wonder why we called the model field `contributions` and not `contributions_url` heh |
@@ -169,6 +169,18 @@ public interface KeyManager extends OzoneManagerFS, IOzoneAcl {
List<RepeatedOmKeyInfo> listTrash(String volumeName, String bucketName,
String startKeyName, String keyPrefix, int maxKeys) throws IOException;
+ /**
+ * Recover trash allows the user to recover the keys
+ * that were ... | [No CFG could be retrieved] | List all keys in trash. | Same here, this can be removed. |
@@ -73,7 +73,8 @@ def write_complex128(fid, kind, data):
def write_string(fid, kind, data):
"""Writes a string tag"""
data_size = 1
- _write(fid, str(data), kind, data_size, FIFF.FIFFT_STRING, '>c')
+ str_data = text_type(data).encode('utf8')
+ _write(fid, str_data, kind, data_size, FIFF.FIFFT_STRIN... | [write_float->[_write],write_dau_pack16->[_write],start_file->[write_id,write_int],start_block->[write_int],write_complex64->[_write],write_double->[_write],write_name_list->[write_string],write_complex128->[_write],write_string->[_write],end_block->[write_int],_generate_meas_id->[get_machid],write_int->[_write]] | Writes a string tag to a file. | @Eric89GXL This is a bit tricky. My first attempt was to write the raw string and pass '>U' as type. While this doesn't throw an error the size calculation get's messed up resulting in empty tags on reading. As long as it works, I'm happy. |
@@ -158,6 +158,18 @@ func (v *CmdConfigSet) Run() error {
if err != nil {
return err
}
+ // Might need to locate this in the service for GUI access
+ if v.Path == "mountdir" {
+ var val keybase1.ConfigValue
+ val, err = cli.GetValue(context.TODO(), v.Path)
+ if v.Value.S != nil {
+ v.G().Log.Info("config se... | [Run->[Printf,SetValue,G,GetDumbOutputUI,GetConfigFilename,GetValue,ClearValue,TODO],ParseArgv->[looksLikeBool,Args,ParseBool,Errorf,IsSet,ParseInt,Bool],NewContextified,ChooseCommand] | Run - Runs the command. | This code can't be triggered from Electron since the GUI never calls into any code in `client/` |
@@ -577,9 +577,11 @@ class PublishStep(PluginStep):
def publish(self):
"""
+ DEPRECATED
+
Perform the publish action for the repo
- A compatability method. process_lifecycle() should be called directly instead.
+ A compatibility method. process_lifecycle() should be calle... | [PublishStep->[publish->[process_lifecycle],get_distributor_type->[get_plugin_type]],PluginStep->[process_lifecycle->[get_working_dir,_build_final_report],get_config->[get_config],_build_final_report->[get_progress_report_summary,get_progress_report,get_conduit],get_working_dir->[get_working_dir],get_repo->[get_repo],g... | Perform the publish action for the repository . | Do we want to just remove this method? |
@@ -81,6 +81,7 @@ def fc(input,
num_flatten_dims=1,
param_attr=None,
bias_attr=None,
+ use_mkldnn=False,
act=None,
name=None):
"""
| [conv2d->[_get_default_param_initializer],sequence_first_step->[sequence_pool],matmul->[__check_input],sequence_last_step->[sequence_pool],lstm_unit->[fc]] | A simple non - linear network with a single base layer. Adding a n - dimensional tensor to the network creates a n - dimensional tensor and adds a Add a non - zero weight to the network. | Why softmax PR would change fc? |
@@ -42,6 +42,7 @@ class PaymentChannel:
token_network=token_network,
channel_identifier=channel_identifier,
contract_manager=contract_manager,
+ from_block=token_network.metadata.filters_start_at,
)
if not participants:
| [PaymentChannel->[unlock->[unlock],set_total_deposit->[set_total_deposit],can_transfer->[can_transfer],token_address->[token_address],set_total_withdraw->[set_total_withdraw],update_transfer->[update_transfer],settle->[settle],detail->[detail],close->[close]]] | Initialize a channel with a specific lease. | This is part of the fix. It will use the deploy block of `TokenNetworkRegistry` instead of the genesis block. |
@@ -2351,6 +2351,8 @@ class SectionEditingResourceTests(TestCaseBase):
def test_raw_with_editing_links_source(self):
"""The raw source for a document can be requested, with section editing
links"""
+ raise SkipTest("Section editing is disabled & broken for now")
+
client = Localiz... | [DocumentSEOTests->[test_seo_title->[_make_doc],test_seo_script->[make_page_and_compare_seo]],ViewTests->[test_children_view->[_make_doc,_depth_test]],AttachmentTests->[test_new_attachment->[_post_new_attachment],test_attachment_raw_requires_attachment_host->[_post_new_attachment]],DocumentEditingTests->[test_discard_l... | Test that the raw source for a document can be requested with section editing links h1 - > test - > . | Oh, has this been broken for a while? Shouldn't we clean this up (by removing it completely? |
@@ -64,7 +64,7 @@ func (l Listener) authorizeHandler(protected http.Handler) http.Handler {
user, ok, err := l.Authenticator.AuthenticateRequest(req)
if err != nil {
glog.V(3).Infof("Unable to authenticate: %v", err)
- http.Error(w, "Unable to authenticate due to an error", http.StatusInternalServerError)
+... | [handler->[Handle,Handler,InstallHandler,authorizeHandler,NewServeMux,HandleFunc],authorizeHandler->[Authorize,Error,Infof,Sprintf,HandlerFunc,ServeHTTP,AuthenticateRequest,V,BasicAuth,HasPrefix],Listen->[Match,Any,Error,Listen,Infof,Contains,New,handler,NewListener,Fatal,HTTP1Fast,Serve]] | authorizeHandler returns a http. Handler that will authorize the request using the configured Authenticator and Record ServeHTTP - HTTP handler for the NestedNetworkNetwork interface. | Hrm, this is not correct, because we aren't checking `ok` (which is the normal 401). What was the actual error? |
@@ -256,7 +256,7 @@ def test_initiator_skips_used_routes():
)
)
init_action = factories.initiator_make_init_action(
- channels=channels, routes=routes, transfer=transfer
+ channels=channels, routes=routes, transfer=transfer, estimated_fee=0
)
transition_result = handle_init_in... | [test_initiator_accounts_for_fees_when_selecting_routes->[make_mediated_transfer_state_change]] | This function checks if the initiator does not skip any routes that are used in the chain. This function is called when a lock is not locked. It is called by the client when. | Shouldn't this be `FeeAmount(0)`? |
@@ -77,6 +77,13 @@ class ParDoTranslator<InputT, OutputT>
PCollection<InputT> input = context.getInput();
List<PCollectionView<?>> sideInputs = transform.getSideInputs();
+ DoFnSchemaInformation doFnSchemaInformation;
+ try {
+ doFnSchemaInformation = ParDoTranslation.getSchemaInformation(context... | [ParDoTranslator->[addSideInputs->[unionSideInputs,size,getViewInput,get,addStream],SplittableProcessElementsTranslator->[translate->[getValue,toMap,size,equals,checkArgument,getWindowingStrategy,put,getInput,newProcessFn,getFn,getAll,getSimpleName,getKey,getCoder,addStream,isEmpty,getPipelineOptions,getStateBackend,ge... | Translates a single untransformed DoFn or DoFn that is not part of the pipeline region OperatorTransform Implementation. | This exception handling is duplicated all over. Should it be moved into `getSchemaInformation`? When does the IOException get raised? Is there any value in forcing callers to handle it? If you wouldn't make `getSchemaInformation` return a `oneof` then it shouldn't throw a checked exception. |
@@ -9,8 +9,8 @@ namespace System.Security.Principal
{
public class GenericIdentity : ClaimsIdentity
{
- private readonly string m_name;
- private readonly string m_type;
+ private readonly string m_name = null!; // Init-ed in parameterized constructors
+ private readonly string m... | [GenericIdentity->[AddNameClaim->[AddClaim,NameClaimType,String,DefaultIssuer],m_name,nameof,AddNameClaim,Equals,m_type,Claims]] | Creates a new ClaimsIdentity object that is a copy of the current object except for the name This method is called from the constructor to add a name claim to the name list. | I'm assuming this is needed because of the default constructor. Is that being used anywhere? |
@@ -5,8 +5,6 @@ using Robust.Shared.Serialization;
namespace Content.Shared.Administration;
-[NetSerializable]
-[Serializable]
public class GamePrototypeLoadMessage : NetMessage
{
public override MsgGroups MsgGroup => MsgGroups.String;
| [GamePrototypeLoadMessage->[WriteToBuffer->[Write],ReadFromBuffer->[ReadString],String,Empty]] | The GamePrototypeLoadMessage class is used to load the game s prototypes from the. | There will also be 2 unused imports |
@@ -53,7 +53,7 @@ import java.util.Iterator;
* <p>
* byte 1: version (0x1)
* byte 2 == 0x1 =>; allowReverseLookup
- * bytes 3-6 =>; numBytesUsed
+ * bytes 3-6 =>; numBytesUsed, It will be -1 for null values.
* bytes 7-10 =>; numElements
* bytes 10-((numElements * 4) + 10): integers representing *end* offsets ... | [GenericIndexed->[getVersionTwo->[copyBufferAndGet,checkIndex],compare->[compare],BufferIndexed->[bufferedIndexedGet->[fromByteBuffer],getClazz->[getClazz],iterator->[iterator],indexOf->[indexOf]],fromIterableVersionOne->[size,writeTo,compare,iterator],singleThreadedVersionOne->[get->[bufferedIndexedGet,checkIndex],Buf... | Imports a single - dimensional array of bytes and a header file. The generic indexed class. | This addition should be at line 59, not here |
@@ -206,6 +206,16 @@ export class AmpStoryPageAttachment extends DraggableDrawer {
},
true /** useCapture */
);
+
+ // Closes the remote attachment drawer when navigation deeplinked to an app.
+ if (this.type_ === AttachmentType.REMOTE) {
+ const ampdoc = this.getAmpDoc();
+ ampdoc.on... | [No CFG could be retrieved] | Adds event listeners to the attachment. Private method for opening a remote attachment. | this works? do you know why is the ampdoc visible when navigating to a different app? |
@@ -101,7 +101,7 @@ namespace Content.Server.Database
[Column("priority")] public DbJobPriority Priority { get; set; }
}
- public enum DbJobPriority
+ public enum DbJobPriority : byte
{
// These enum values HAVE to match the ones in JobPriority in Shared.
Never = 0,
| [ServerDbContext->[OnModelCreating->[IsUnique]]] | Table of all the information about a character. Table Antag. | I'm not sure on changing the DB stuff, probably best to leave it as it might need a new migration. |
@@ -271,6 +271,10 @@ namespace DotNetNuke.Services.Installer.Installers
{
this._upgradeScript = file;
}
+ else if (file.Name.StartsWith("schema.", StringComparison.InvariantCultureIgnoreCase))
+ {
+ this._schemaScrip... | [ScriptInstaller->[ProcessFile->[ProcessFile,IsCorrectType],InstallScriptFile->[IsValidScript,ExecuteSql],Commit->[Commit],UnInstall->[UnInstall],UnInstallFile->[UnInstallFile],Rollback->[Rollback]]] | Override the ProcessFile method to set up the necessary information for the file processing. | While we are in here, can we cleanup some of the logic to remove duplication and to make this more clear. For example for the first conditional, make it check for either name starting with "install" or a type of install. Also, while we are here is it appropriate that "the no match" is uninstall? That seems a bit danger... |
@@ -40,7 +40,10 @@ func (r ReplicationSet) Do(ctx context.Context, delay time.Duration, f func(cont
}
result, err := f(ctx, ing)
if err != nil {
- errs <- err
+ errs <- instanceError{
+ err: err,
+ instance: ing,
+ }
} else {
resultsChan <- result
}
| [Do->[Stop,NewTimer,WithCancel,Err,Done],Includes->[GetAddr],Equal,Sort] | Do executes the given function f on all the ingesters in the set. If delay. | Number of failures within the zone is not used. To avoid confusion about why using `int` as value type, we can use `map[string]struct{}` instead. |
@@ -113,7 +113,9 @@ class Jetpack_Sync_Actions {
if ( Jetpack::is_staging_site() ) {
return false;
}
- if ( ! Jetpack::is_active() ) {
+
+ $connection_manager = Jetpack_Sync_Main::init()->get_connection_manager();
+ if ( ! $connection_manager->is_active() ) {
if ( ! doing_action( 'jetpack_user_authoriz... | [Jetpack_Sync_Actions->[do_cron_sync_by_type->[do_full_sync]]] | Checks if sync is allowed. | Rather than exposing the entire connection here, this condition (and all the others above it) could just be moved into the Jetpack_Sync_Main class. This prevents us from leaking the connection object outside the class. |
@@ -22,6 +22,13 @@ def resolve_attributes(info, qs=None, in_category=None, in_collection=None, **_k
return qs.distinct()
+def resolve_category_by_slug(info, slug):
+ try:
+ return models.Category.objects.get(slug=slug)
+ except models.Category.DoesNotExist:
+ return None
+
+
def resolve_ca... | [resolve_report_product_sales->[all,Sum,order_by,annotate,filter,filter_by_period,exclude],resolve_categories->[prefetch_related,filter,distinct],resolve_product_variants->[get_database_id,filter,visible_to_user],resolve_product_types->[all],resolve_digital_contents->[all],resolve_collections->[visible_to_user],resolve... | Return a list of all categories in the category hierarchy. | Use `first()`, way faster and one line of code |
@@ -66,6 +66,7 @@ const SELF_CLOSING_TAGS = {
'col': true,
'hr': true,
'img': true,
+ 'input': true,
'source': true,
'track': true,
'wbr': true,
| [No CFG could be retrieved] | Imports and validates a single tag. Sanitizes the provided HTML by removing any whitespace and sanitizing the tag s attributes. | Are there any other I missed? I'd rather have a full list there, even if it's blacklisted tags. |
@@ -28,10 +28,11 @@ type userState struct {
ingestedSamples *ewmaRate
}
-func newUserStates(rateUpdatePeriod time.Duration) *userStates {
+func newUserStates(rateUpdatePeriod time.Duration, maxSeriesPerUser int) *userStates {
return &userStates{
states: map[string]*userState{},
rateUpdatePeriod: ... | [gc->[length,Lock,Unlock],unlockedGet->[mapFP,Unlock,get,Lock,add,FastFingerprint,put],numUsers->[RUnlock,RLock],get->[RUnlock,RLock],getOrCreate->[unlockedGetOrCreate,Unlock,GetID,RLock,Lock,Errorf,RUnlock],cp->[RUnlock,RLock],numSeries->[RUnlock,length,RLock],forSeriesMatching->[Match,Unlock,SplitFiltersAndMatchers,g... | cp returns a copy of the user states. | I'd probably propagated the whole of Config struct here, as we're already passing two things through. Or better yet, make a new Config struct (`UserLimitsConfig`), embed that in Config and pass that here? |
@@ -52,6 +52,18 @@ func (s *BaseSuite) TearDownSuite(c *check.C) {
func (s *BaseSuite) createComposeProject(c *check.C, name string) {
projectName := fmt.Sprintf("integration-test-%s", name)
composeFile := fmt.Sprintf("resources/compose/%s.yml", name)
+
+ addrs, err := net.InterfaceAddrs()
+ c.Assert(err, checker.... | [adaptFile->[ExecuteTemplate,TempFile,Sync,ParseFiles,Name,Close,Assert,Split],TearDownSuite->[Stop],traefikCmd->[RunCommand,Commentf,Assert],createComposeProject->[Sprintf,CreateProject],adaptFileForHost->[Getenv,adaptFile],TestingT,Suite] | createComposeProject creates a compose project for the given name. | @trecloux care to explain this change ? :angel: |
@@ -856,7 +856,8 @@ TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL(Tpetra_MatMat, operations_test,SC,LO, GO, NT)
if(numProcs > 0 && comm->getSize() != numProcs) continue;
- double epsilon = currentSystem.get<double> ("epsilon", defaultEpsilon);
+ double epsilon = currentSystem.get<double> ("epsilon",
+ ... | [No CFG could be retrieved] | Reads the matrix - specific maps from the specified file. read matrix - level map files. | Would be nicer if these were the magnitude type based on SC, instead of double. That would make this work with `__float128` etc. |
@@ -401,9 +401,14 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
return;
}
this.win['dbclk_a4a_viz_change'] = true;
- addExperimentIdToElement(
- isExperimentOn(this.win, 'a4a-safeframe-preloading-off') ?
- '21061136' : '21061135', this.element);
+ if (isExperimentOn(t... | [AmpAdNetworkDoubleclickImpl->[extractSize->[getPublisherSpecifiedRefreshInterval,width,height,extractAmpAnalyticsConfig,get,setGoogleLifecycleVarsFromHeaders,Number],getBlockParameters_->[serializeTargeting_,dev,user,isInManualExperiment,Number,assign,join,googleBlockParameters,getMultiSizeDimensions,map],constructor-... | Build the identity token for the current element. This is a private property that can be used to determine if a page correlator should. | You really want to use src/experiments#randomlySelectUnsetExperiments which will do this for you by passing the branches: const sfPreloadExpName = 'a4a-safeframe-preloading-off'; const experimentInfoMap = /** @type {!Object<string, !ExperimentInfo>} */ (sfPreloadExpName); experimentInfoMap[] = { isTrafficEligible: () =... |
@@ -61,6 +61,11 @@ threshold_bonferroni = stats.t.ppf(1.0 - alpha / n_tests, n_samples - 1)
reject_fdr, pval_fdr = fdr_correction(pval, alpha=alpha, method='indep')
threshold_fdr = np.min(np.abs(T)[reject_fdr])
+X_ = X.reshape(-1)
+qvals = local_fdr_correction(X_)
+sort_xq = np.argsort(qvals)
+threshold_lfdr = np.i... | [read_events,ppf,hlines,show,dict,get_data,ttest_1samp,min,abs,fdr_correction,ylabel,plot,print,data_path,close,bonferroni_correction,xlabel,Raw,xlim,legend,Epochs,pick_types] | Plot the estimated value of the n - channel in the data. | would it be possible to have the same API for local_fdr_correction as for fdr_correction? |
@@ -342,6 +342,10 @@ func ReadB64() (res string, err error) {
}
n, err := conn.Read(buffer)
if n > 0 && err == nil {
+ if n == bufferSize {
+ kbCtx.Log.Info("ReadB64 %d bytes (full buffer)", n)
+ fmt.Printf("ReadB64 %d bytes (full buffer)\n", n)
+ }
str := base64.StdEncoding.EncodeToString(buffer[0:n])
... | [GetServers->[processExternalResult,GetServers],GetServers] | WriteB64 sends a base64 encoded msgpack rpc payload and returns the string. Version returns semantic version of the application. | Is this output useful? |
@@ -25,15 +25,15 @@ namespace System.Reflection.Internal
public override void Dispose()
{
- _provider = null;
+ _provider = null!;
}
- public unsafe override byte* Pointer => _provider.Pointer + _start;
+ public unsafe override byte* Pointer => _provide... | [ByteArrayMemoryBlock->[GetContentUnchecked->[Create,Array],Pointer]] | Override method to return an immutable array of the specified length. | `_provider` is non-nullable why do we need a `!`? |
@@ -14,6 +14,10 @@ use Detection\MobileDetect;
use Exception;
+define ('APP_MODE_NORMAL', 0);
+define ('APP_MODE_INSTALL', 1);
+define ('APP_MODE_MAINTENANCE', 2);
+
require_once 'boot.php';
require_once 'include/text.php';
| [App->[get_useragent->[get_baseurl],maxload_reached->[is_backend],init_pagehead->[get_baseurl],remove_baseurl->[get_baseurl],proc_run->[min_memory_reached,get_basepath],getSenderEmailAddress->[get_hostname],init_page_end->[get_baseurl]]] | The main application structure. A theme - controllable class. | Please define these constants inside the `App` class. |
@@ -628,7 +628,8 @@ namespace cryptonote
}
}
- bool r = construct_tx_with_tx_key(sender_account_keys, subaddresses, sources, destinations, change_addr, extra, tx, unlock_time, tx_key, additional_tx_keys, rct, rct_config, msout);
+ bool shuffle_outs = true;
+ bool r = construct_tx_with_t... | [get_block_longhash->[get_block_longhash],construct_tx_with_tx_key->[get_destination_view_key_pub,input_generation_context_data,classify_addresses],construct_tx->[construct_tx_and_get_tx_key],construct_tx_and_get_tx_key->[construct_tx_with_tx_key,classify_addresses]] | construct a new transaction with the specified parameters and return the key. | Ah, because the default value can't be used with an explicit `use_view_tags`. These function signatures are disturbing, but that's not your fault. |
@@ -506,7 +506,7 @@ module.exports = class huobipro extends Exchange {
return this.parseOHLCVs (response['data'], market, timeframe, since, limit);
}
- async loadAccounts (reload = false) {
+ async loadAccounts (reload = false, params = {}) {
if (reload) {
this.accounts = awa... | [No CFG could be retrieved] | Get the most recent order order trades for a given symbol. Get currencies settings. | Forgot to pass `params` to `fetchAccounts` here ) |
@@ -826,6 +826,11 @@ public class JmsConnector extends AbstractConnector implements ExceptionListener
{
stopping = true;
connection.stop();
+ if(Boolean.valueOf( System.getProperty(MULE_JMS_CLOSE_CONNECTION_FACTORY_ON_STOP, "false")))
+ {
+ ... | [JmsConnector->[createOperationResource->[createSession],createSession->[createSession],doConnect->[createConnection],connect->[onNotification->[connect],connect],createConnection->[isConnectionFactoryRetrievedThroughJndi,createConnection,createConnectionFactory],getSession->[getSession,createSession,getSessionFromTran... | Stop the connection and the jndiName resolver if there is one. | Remove space. Use static import if possible |
@@ -56,7 +56,7 @@ from llnl.util.tty.log import log_output
from llnl.util.tty.color import colorize
from spack.filesystem_view import YamlFilesystemView
from spack.util.executable import which
-from spack.stage import Stage, ResourceStage, StageComposite
+from spack.stage import _stage_prefix, Stage, ResourceStage, ... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],check_for_unfinished_installation->[remove_prefix],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_install->[build_process->[do_stage,_stage_and_write_lock,do_fak... | Creates a new object from a single object. The phase of the object is a class that provides hooks to execute arbitrary callbacks before and after. | Two points: * If something is being imported, then it should be "promoted" to omit the leading `_`. * I think it was also requested that the prefix of the stage dir name would be `spack-` rather than `spack-stage` (so a new variable might be needed) |
@@ -60,8 +60,7 @@ func (consensus *Consensus) checkDoubleSign(recvMsg *FBFTMessage) bool {
return true
}
- addr, err := subComm.AddressForBLSKey(offender)
-
+ addr, err := subComm.AddressForBLSKey(*offender)
if err != nil {
consensus.getLogger().Err(err).Str("msg", recvMsg.Stri... | [couldThisBeADoubleSigner->[Str,Msg,HasMatchingPrepared,HasMatchingAnnounce,Uint64,getLogger,String,Debug],checkDoubleSign->[AddressForBLSKey,Hash,Now,IsEqual,SerializeToHexStr,CurrentHeader,ToLibBLSPublicKey,GetBlocksByNumber,FindCommitteeByID,Hex2Bytes,FromLibBLSPublicKeyUnsafe,UnixNano,Uint64,Uint32,ReadBallot,Err,D... | checkDoubleSign checks if a message is a double sign message. This function is used to create a new BLS key. - > Boolean. | it will blow up here too. Just return if offender is nil |
@@ -1271,7 +1271,7 @@ public final class FilePath implements Serializable {
private static final long serialVersionUID = 1L;
@Override
public Void invoke(File f, VirtualChannel channel) throws IOException {
- deleteRecursive(deleting(f));
+ Util.deleteRecursive(deleting(... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | Delete a file and all its sub - directories. | The previous implementation of `deleteRecursive` would call `deleting(...)` on each file in the directory. Does the new `Util.deleteRecursive` still do this? If not, I think this might be a problem for agent-master security. |
@@ -190,7 +190,7 @@ class Accuracy(Metric):
model.prepare(
optim,
- loss_function=CrossEntropy(average=False),
+ loss_function=CrossEntropyLoss(),
metrics=Accuracy(),
inputs=inputs,
labels=labels)
| [Metric->[accumulate->[format,NotImplementedError],reset->[format,NotImplementedError],name->[format,NotImplementedError],update->[format,NotImplementedError]],Accuracy->[accumulate->[zip,float,append],reset->[len],add_metric_op->[cast,argsort],update->[append,len,sum,float,enumerate],_init_name->[format],__init__->[_i... | A metric class that encapsulates accuracy of the n - tuple of objects. Sort the list of labels in descending order. | Might it be `CrossEntropyLoss(reduction="sum")` |
@@ -62,11 +62,11 @@ namespace NServiceBus
}
/// <summary>
- /// Moves expired messages using the "time to reach queue" setting to the dead letter queue instead of discarding them.
+ /// Moves messages that have expired their TimeToBeReceived to the dead letter queue instead of discardi... | [MsmqConfigurationExtensions->[UseDeadLetterQueueForMessagesWithTimeToReachQueue->[UseDeadLetterQueueForMessagesWithTimeToReachQueue]]] | Use dead letter queue for messages with time to reach queue. | How about "Moves messages that have **exceeded** their TimeToBeReceived" instead? Using "expired" in this context sounds awkward. |
@@ -100,13 +100,14 @@ class PythonSetup(Subsystem):
register(
"--resolver-jobs",
type=int,
- default=multiprocessing.cpu_count() // 2,
+ default=CPU_COUNT // 2,
+ default_help_repr="#cores/2",
advanced=True,
help=(
- ... | [PythonSetup->[compatibilities_or_constraints->[compatibility_or_constraints]]] | Register options for the n - tuple command. Adds a list of paths to search for interpreter binaries that match your project s requirements. | Not for this PR, but it seems to me the verbage is now false when a repo is setup with a "lockfile". In that case we should be resolving once and we should be bottlenecking on that resolve and so we could be using full Pex default parallelism (we'd still do tool resolves separately, but ... maybe uninmportant?). |
@@ -25,6 +25,18 @@ define([
var scratchColor = new Color();
+ var scratchColorIndex = 0;
+ var scratchColors = [new Color()];
+
+ function getScratchColor() {
+ if (scratchColorIndex >= scratchColors.length) {
+ scratchColors.push(new Color());
+ }
+ var scratchColor = ... | [No CFG could be retrieved] | Constructs a new object. Construct a new expression object. | Good catch. For better cohesion, can you put this into a small static class (still in this file), e.g., with an `initialize`/`reset`/whatever function that sets this to zero, and then the `getScratchColor` function? |
@@ -497,7 +497,7 @@ public abstract class WindowedValue<T> {
// right, and cast the window type away here.
@SuppressWarnings({"unchecked", "rawtypes"})
Coder<Collection<? extends BoundedWindow>> collectionCoder =
- (Coder) CollectionCoder.of(this.windowCoder);
+ (Coder) ListCoder.... | [WindowedValue->[TimestampedValueInGlobalWindow->[hashCode->[getPane,getValue],toString->[toString],withValue->[getTimestamp,getPane],equals->[getValue,getTimestamp,getPane,equals]],of->[of],getValueOnlyCoder->[of],FullWindowedValueCoder->[decode->[createWithoutValidation,decode],verifyDeterministic->[verifyDeterminist... | Get the window coder. | Will this break DataflowRunner's update by changing all these coders? |
@@ -84,6 +84,14 @@ class Jetpack_Sync_Module_Users extends Jetpack_Sync_Module {
return null;
}
+ public function add_invitation_accepted_flag( $user ) {
+ if ( empty( $user ) ) {
+ $this->invitation_accepted = true;
+ } else {
+ do_action( 'jetpack_sync_invitation_accepted', $user );
+ }
+ }
+
public f... | [Jetpack_Sync_Module_Users->[sanitize_user_and_expand->[expand_user,sanitize_user,get_user],sanitize_user->[get_user],maybe_save_user_meta->[get_flags,add_flags],add_flags->[get_flags],expand_logout_username->[sanitize_user],expand_action->[sanitize_user_and_expand],expand_login_username->[sanitize_user]]] | Get a user object from the database. | why not use `add_flags` directly here? |
@@ -34,7 +34,7 @@ public class ReferenceConfigTest {
registry.setAddress("multicast://224.5.6.7:1234");
ProtocolConfig protocol = new ProtocolConfig();
- protocol.setName("dubbo");
+ protocol.setName("mockprotocol");
ServiceConfig<DemoService> demoService;
demoServi... | [ReferenceConfigTest->[testInjvm->[assertTrue,equalsIgnoreCase,ApplicationConfig,setName,getProtocol,setProtocol,DemoServiceImpl,setRef,setInterface,setRegistry,unexport,setInjvm,setApplication,setAddress,export,getName,ProtocolConfig,get,RegistryConfig],testReferenceRetry->[assertTrue,ApplicationConfig,assertNull,setN... | Tests if the configuration is in the Injvm environment. | Should we create a test constant for this, as we might be using it many places. It will be easier to change in case in future if have to do. |
@@ -84,6 +84,11 @@ public class UpdateProjectCmd extends BaseAsyncCmd {
return _projectService.getProjectOwner(id).getId();
}
+ @Override
+ public List<Long> getEntityOwnerIds() {
+ return _projectService.getProjectOwners(id);
+ }
+
//////////////////////////////////////////////////... | [UpdateProjectCmd->[getEntityOwnerId->[getId],execute->[getCommandName,getId,getAccountName,getDisplayText]]] | This method is invoked by the UI thread and is called by the UI thread. | If the second condition is not missing any other condition, then parenthesis can be removed |
@@ -827,7 +827,7 @@ out_pool:
dc_pool_put(pool);
out:
if (rc != 0)
- D_ERROR("dc_pool_l2g failed, rc: "DF_RC"\n", DP_RC(rc));
+ D_ERROR("failed, rc: "DF_RC"\n", DP_RC(rc));
return rc;
}
| [No CFG could be retrieved] | finds all the n - OV buffer in the ioreg - pool and if finds the n - ary pool in the DRS and returns the index of the n. | curious as to why make this change (for the three errors in this file)? |
@@ -91,6 +91,10 @@ class ImplicitMechanicalSolver(solid_mechanics_implicit_dynamic_solver.ImplicitM
if self.settings["rotation_dofs"].GetBool():
# Add specific variables for the problem (rotation dofs)
self.main_model_part.AddNodalSolutionStepVariable(KratosMultiphysics.StructuralMech... | [ImplicitMechanicalSolver->[AddVariables->[AddVariables]]] | Adds variables to the implicit mechanical solver. | I would not add those values. the SLAVE flag is already there, the SLAVES list can be obtained by looping the nodes and seeing which ones are marked as SLAVE |
@@ -58,7 +58,8 @@ def do_work(infiles):
for order, ident, qstr in sorted(qstrs.values(), key=lambda x: x[0]):
qhash = compute_hash(qstr)
qlen = len(qstr)
- print('Q({}, (const byte*)"\\x{:02x}\\x{:02x}\\x{:02x}\\x{:02x}" "{}")'.format(ident, qhash & 0xff, (qhash >> 8) & 0xff, qlen & 0xff, ... | [do_work->[group,ord,print,'Q,sub,len,sorted,strip,open,match,values,compute_hash],main->[add_argument,print,ArgumentParser,parse_args,do_work,exit],compute_hash->[ord],ord,python_version_tuple,main] | This function processes the input files and returns a boolean value indicating whether the file was successfully processed. | Are you using Python 3 to run this script? For me it fails, because `qstr` is a str and str's don't have the `decode` method. `qstr` should be bytes, or don't use decode. |
@@ -225,13 +225,13 @@ abstract class DoFnPTransformRunnerFactory<
throw new IllegalArgumentException("Malformed ParDoPayload", exn);
}
- ImmutableListMultimap.Builder<TupleTag<?>, FnDataReceiver<WindowedValue<?>>>
- tagToConsumerBuilder = ImmutableListMultimap.builder();
+ Immutable... | [DoFnPTransformRunnerFactory->[Context->[parseFrom,getValue,create,equals,checkArgument,getCoderId,windowCoder,getKeyCoder,windowMappingFnFromProto,getWindowingStrategy,getWindowingStrategyId,getDoFn,put,builder,getValueCoder,IllegalArgumentException,forComponents,getKey,getCoder,getInputsOrThrow,getWindowMappingFn,dif... | Reads the input payload and creates a TupleTag object. | Thanks for removing the TupleTag usage. Unfortunately, it looks like we're still using it all over the place even in portable code. :/ |
@@ -439,11 +439,15 @@ public abstract class AbstractChannel extends DefaultAttributeMap implements Cha
if (!promise.setUncancellable() || !ensureOpen(promise)) {
return;
}
+ boolean firstRegistration = neverRegistered;
doRegister();
... | [AbstractChannel->[read->[read],disconnect->[disconnect],toString->[localAddress,remoteAddress],flush->[flush],writeAndFlush->[writeAndFlush],AbstractUnsafe->[closeIfClosed->[close,voidPromise],beginRead->[close,voidPromise],flush0->[close,voidPromise],close->[run->[close],close,voidPromise,deregister],bind->[equals],r... | Register a channel with the event loop. | @fbarberamzn shouldn't one name and variable be enough? |
@@ -2131,6 +2131,10 @@ namespace Dynamo.Graph.Nodes
CrossProduct
};
+ /// <summary>
+ /// Enum, that is used when mouse enters, leaves or clicks port.
+ /// It's used for snapping ports.
+ /// </summary>
public enum PortEventType
{
MouseEnter,
| [NodeModel->[BuildAst->[BuildOutputAst],DeserializeCore->[MarkDownStreamNodesAsModified],ComputeUpstreamOnDownstreamNodes->[ComputeUpstreamCache],RegisterOutputPorts->[OnNodeModified],OnPortConnected->[ValidateConnections,OnConnectorAdded,ConnectOutput,OnNodeModified,ConnectInput],Warning->[Warning],UpdateValueCore->[U... | Replies if the node has an explicit . | Defines Enum for Mouse events. Used in port snapping. |
@@ -97,7 +97,7 @@ public class BeansXmlTest {
public void run(WeldManager beanManager) {
ModuleEnablement enabled = ((BeanManagerImpl) beanManager).getEnabled();
- assertEquals(2, enabled.getInterceptors().size());
+ assertEquals(3, enabled.getInterceptors()... | [BeansXmlTest->[testNotDefaultNamespacedBeansXml->[run],testMergeBeansXmls->[run],testInterceptorsEnabled->[run],testNonPrettyPrintedXML->[run],testDecoratorsEnabled->[run],testNamespacedBeansXml->[run]]] | Test if interceptor is enabled. | Had to change unit tests here - from what I gathered, this tests all enabled interceptors in given module. In this case one interceptor is from test itself, 2 others come from weld core. |
@@ -127,10 +127,10 @@ final class TracingServerInterceptor implements ServerInterceptor {
Span.fromContext(context).setAttribute("grpc.canceled", true);
}
} catch (Throwable e) {
- tracer.endExceptionally(context, e);
+ instrumenter.end(context, request, null, e);
throw... | [TracingServerInterceptor->[TracingServerCall->[close->[close]],TracingServerCallListener->[onComplete->[onComplete],onHalfClose->[onHalfClose],onCancel->[onCancel],onReady->[onReady],onMessage->[onMessage]],interceptCall->[interceptCall]]] | Override onCancel method to capture exceptionally and end the trace. | I think ending in `close` handles this, either that or we don't have any unit test covering this case |
@@ -37,6 +37,11 @@ namespace System.Net.Http
internal static bool IsSecureWebSocketScheme(string scheme) =>
string.Equals(scheme, "wss", StringComparison.OrdinalIgnoreCase);
+#if TARGETS_BROWSER
+ internal static bool IsNonSecureBlobScheme(string scheme) =>
+ string.Equals(sche... | [HttpUtilities->[IsSecureWebSocketScheme->[OrdinalIgnoreCase,Equals],IsSupportedSecureScheme->[OrdinalIgnoreCase,IsSecureWebSocketScheme,Equals],Task->[Default,None,ContinueWith,ExecuteSynchronously],IsHttpUri->[IsSupportedScheme,Scheme,Assert],IsNonSecureWebSocketScheme->[OrdinalIgnoreCase,Equals],IsSupportedNonSecure... | Checks if the given string is a secure WebSocket scheme. | nit: `IsBlobScheme`, assuming there is no secure blob scheme. |
@@ -493,7 +493,9 @@ public class ApiResponseHelper implements ResponseGenerator {
snapshotInfo = (SnapshotInfo)snapshot;
} else {
DataStoreRole dataStoreRole = getDataStoreRole(snapshot, _snapshotStoreDao, _dataStoreMgr);
-
+ if (dataStoreRole == null){
+ ret... | [ApiResponseHelper->[createSite2SiteVpnGatewayResponse->[populateAccount,populateDomain],findUserVmById->[findUserVmById],createStoragePoolResponse->[createStoragePoolResponse],toSerializedString->[toSerializedString],createTemplateUpdateResponse->[createTemplateUpdateResponse],createUsageResponse->[findTemplateById],c... | Creates a snapshot response. Object name of snapshot. | I would say the default should be DataStoreRole.Image for getDataStoreRole and so getDataStoreRole should probably never return null. |
@@ -239,7 +239,7 @@ def test_AUTO_stopping_metric_with_no_sorting_metric_binomial():
non_se = get_partitioned_model_names(aml.leaderboard).non_se
first = [m for m in non_se if 'XGBoost_1' in m]
others = [m for m in non_se if m not in first]
- check_model_property(first, 'stopping_metric', True, "AUTO"... | [test_leaderboard_for_regression_with_custom_sorting->[check_leaderboard,prepare_data],test_custom_leaderboard->[prepare_data],test_leaderboard_with_all_algos->[check_leaderboard,prepare_data],get_partitioned_model_names->[Obj],test_leaderboard_for_multinomial_with_custom_sorting->[check_leaderboard,prepare_data],test_... | Test for auto - stopping metric with no sorting metric for binomial. Check if the leader model is a non - critical model. | but `stopping_rounds` is set to 3 by defaut in AutoML? |
@@ -35,6 +35,12 @@ func TestBootstrappedConstraints(t *testing.T) {
if !reflect.DeepEqual(u, constraint.Users) {
t.Errorf("unexpected user access for %s. Found %v, wanted %v", constraint.Name, constraint.Users, u)
}
+
+ for _, expectedVolume := range expectedVolumes {
+ if !supportsFSType(expectedVolume, ... | [MakeUsername,Errorf,DeepEqual] | TestBootstrappedConstraintsWithAddedUser tests that the specified security context constraints are valid. unexpected user access. | or has "*", right? |
@@ -1,12 +1,12 @@
-#include "sixkeyboard.h"
+#include QMK_KEYBOARD_H
#include "matrix.h"
const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {
-[0] = {
- {KC_A, KC_B, KC_C},
- {KC_D, KC_E, KC_F}
- }
+ [0] = LAYOUT(
+ KC_A, KC_B, KC_C, \
+ KC_D, KC_E, KC_F \
+ )
};
const uint16_t PROGMEM fn... | [No CFG could be retrieved] | region keymaps. h. | Not sure we need matrix.h here. |
@@ -201,6 +201,13 @@ module SiteSettings::Validations
validate_error :cors_origins_should_not_have_trailing_slash
end
+ def validate_slow_down_crawler_user_agents(new_val)
+ return if new_val.blank?
+ if new_val.split("|").any? { |crawler| crawler.size < 3 }
+ validate_error :slow_down_crawler_use... | [validate_default_categories_watching->[validate_default_categories,validate_category_ids],validate_cors_origins->[validate_error],validate_share_quote_buttons->[validate_error],validate_enable_local_logins->[validate_error],validate_s3_upload_bucket->[validate_error],validate_enable_s3_inventory->[validate_error],vali... | Checks if the value passed in is a cross - origin cross - domain request. | I see about wanting the extra validation here, I guess we can test on not matching `["gecko","mozilla","firefox","khtml","windows","linux","apple","webkit"]` and a few other obvious strings. |
@@ -596,6 +596,9 @@ dependencies {
<%_ if (messageBroker === 'kafka') { _%>
testImplementation "org.testcontainers:kafka"
<%_ } _%>
+ <%_ if (cacheProvider === 'redis') { %>
+ testImplementation "org.testcontainers:testcontainers"
+ <%_ } _%>
//jhipster-needle-gradle-dependency - JHipster w... | [No CFG could be retrieved] | test runtime - only requires that the dependencies are installed. | For maven we just use `org.testcontainers:testcontainers`. `database-commons` depends on `testcontainers` so not problem with that, just curious why explicitly using `database-commons` here |
@@ -125,6 +125,18 @@ public class FilteredDeckOptions extends AppCompatPreferenceActivity implements
for (Entry<String, Object> entry : mUpdate.valueSet()) {
Timber.i("Change value for key '%s': %s", entry.getKey(), entry.getValue());
+ if (mPref.mSecondFilter)... | [FilteredDeckOptions->[removePreference->[removePreference],updateSummaries->[contains,getString],onDestroy->[onDestroy],onCreate->[getLong,contains,registerOnSharedPreferenceChangeListener,onCreate,DeckPreferenceHack,getString],buildLists->[getString],onKeyDown->[onKeyDown],closeDeckOptions->[getLong],DeckPreferenceHa... | This method is called when the database changes. if there is no such key in the deck then it will be saved. | extract the common code: `JSONArray ar = mDeck.getJSONArray("terms");` out of the if/else chain |
@@ -176,10 +176,10 @@ class WPSEO_Post_Type_Sitemap_Provider implements WPSEO_Sitemap_Provider {
$url = apply_filters( 'wpseo_sitemap_entry', $url, 'post', $post );
if ( ! empty( $url ) ) {
- $links[] = $url;
- $stacked_urls[] = $url['loc'];
+ $links[] = $url;
}
}
+
unset( $p... | [WPSEO_Post_Type_Sitemap_Provider->[get_post_type_count->[get_var,get_sql_where_clause],get_posts->[prepare,get_results,get_sql_where_clause],get_index_links->[get_post_type_count,prepare,get_col],save_post->[is_valid_post_type],get_url->[calculate_priority,get_images],get_sitemap_links->[get_post_type_count,get_first_... | Get the links for a given post type. Filter URL entry before it gets added to the sitemap. | If we remove this line that would kinda defeat the purpose of line 162. |
@@ -15,6 +15,7 @@ import (
"code.gitea.io/gitea/modules/cache"
"code.gitea.io/gitea/modules/cron"
"code.gitea.io/gitea/modules/highlight"
+ "code.gitea.io/gitea/modules/indexer/issues"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/mailer"
"code.gitea.io/gitea/modules/markup"
| [Title,NewEngine,NewServices,InitSyncMirrors,InitIssueIndexer,Info,InitOAuth2,Init,NewGitLogger,Trace,InitDeliverHooks,Debug,Key,Join,Section,InitRepoIndexer,InitTestPullRequests,LoadRepoConfig,Listen,NewRepoContext,CheckLFSVersion,String,Fatal,LoadConfigs,Sleep,NewContext] | Initialize the given object. GlobalInit is the main function for the ORM engine initialization. It is called by the ORM. | you should probably also use `issue_indexer` here to be consistent in all places |
@@ -276,8 +276,8 @@ func (m *Manager) update() {
}
// we have a valid license, notify watchers and sleep until next check.
- m.log.Info(
- "valid license retrieved, license mode: %s, type: %s, status: %s",
+ m.log.Infof(
+ "valid license retrieved, license mode: %v, type: %v, status: %v",
licen... | [saveAndNotify->[notify],invalidate->[saveAndNotify],update->[Get]] | update is a long running routine that will retrieve the license from the fetcher and update it if. | This calls for `Infow` |
@@ -125,13 +125,13 @@ def calculate_checkout_quantity(lines: Iterable["CheckoutLineInfo"]):
def add_variants_to_checkout(
- checkout, variants, quantities, channel_slug, skip_stock_check=False
+ checkout, variants, quantities, channel_slug, skip_stock_check=False, replace=False
):
"""Add variants to ch... | [change_shipping_address_in_checkout->[_check_new_checkout_address],add_voucher_to_checkout->[get_voucher_discount_for_checkout],get_prices_of_discounted_specific_product->[get_discounted_lines],add_variant_to_checkout->[check_variant_in_stock],get_voucher_discount_for_checkout->[_get_products_voucher_discount,_get_shi... | Add variants to checkout. | Please add a similar description to the mutation description, it helps a lot during API client development. |
@@ -434,15 +434,16 @@ public class BoundedConcurrentHashMap<K, V> extends AbstractMap<K, V>
private final Segment<K,V> segment;
private final int maxBatchQueueSize;
private final int trimDownSize;
- private final float batchThresholdFactor;
+ private final float batchThresholdFactorAndQue... | [BoundedConcurrentHashMap->[contains->[containsValue],KeySet->[size->[size],contains->[containsKey],remove->[remove],clear->[clear],isEmpty->[isEmpty],iterator->[KeyIterator]],get->[hash,hashCode,get],remove->[hash,hashCode,remove],LRUHashEntry->[equals->[equals]],LRU->[onEntryMiss->[clear],execute->[clear],removeEldes... | Execute the eviction. | Why not batchQueueSizeThreshold? |
@@ -38,7 +38,7 @@ export function taboola(global, data) {
// copy none blacklisted attribute to the 'params' map
Object.keys(data).forEach(k => {
- if (blackList.indexOf(k) === -1) {
+ if (!blackList.includes(k)) {
params[k] = data[k];
}
});
| [No CFG could be retrieved] | Creates a taboola object from the given data object. Load the taboola if the user has changed their height. | So everything in this file cannot be updated, because the ads directory is run in foreign iframes. This means they will not have the Array#includes polyfill installed in them. |
@@ -132,7 +132,8 @@ public abstract class AbstractTrafficShapingHandler extends ChannelDuplexHandler
}
/**
- * Constructor using default Check Interval
+ * Constructor using default Check Interval value of {@value #DEFAULT_CHECK_INTERVAL} ms and
+ * default max time as delay allowed value of {@v... | [AbstractTrafficShapingHandler->[setCheckInterval->[configure],write->[isHandlerActive],configure->[configure],channelRead->[ReopenReadTimerTask],toString->[toString],read->[read,isHandlerActive]]] | This class is used to set the TrafficCounter for the TrafficShapingHandler. The check interval. | missing '.' at end of line. |
@@ -1564,6 +1564,9 @@ function getPluginApi(version) {
owner.registry.register("plugin-api:main", pluginApi, {
instantiate: false,
});
+ } else {
+ // If we are re-using an instance, make sure the container is correct
+ pluginApi.container = owner;
}
// We are recycling t... | [No CFG could be retrieved] | Create a new label key. Provides a function to call with the plugin API object. | Small nit: can you swap `if` branches/invert the condition? |
@@ -113,7 +113,7 @@ def read_inverse_operator(fname, verbose=None):
"""
check_fname(fname, 'inverse operator', ('-inv.fif', '-inv.fif.gz',
'_inv.fif', '_inv.fif.gz'))
-
+ fname = _check_fname(fname=fname, must_exist=True, overwrite='read')
#
# Open t... | [prepare_inverse_operator->[copy,combine_xyz,InverseOperator],estimate_snr->[prepare_inverse_operator,_check_reference,_check_ch_names,compute_rank_inverse,_pick_channels_inverse_operator],apply_inverse_cov->[_apply_inverse,_pick_channels_inverse_operator],InverseOperator->[copy->[InverseOperator]],read_inverse_operato... | Read the inverse operator decomposition from a FIF file. Read the MNE tag and return the data in the dictionary inv. Read a single node in the FITS file. Get the inverse solution of a single node in the tree. | Might be better / simpler just to make `check_fname` call `_check_fname` internally and return the `str`-ified absolute path, then our code ends up more DRY. It seems like every time we `check_fname` we probably want to call `_check_fname` anyway... Or we could go the other way and make `_check_fname` accept a `ext` ar... |
@@ -373,7 +373,7 @@ class Stripe extends CommonObject
);
$return = new Stripe($this->db);
try {
- if (empty($conf->stripeconnect->enabled))
+ if (empty($conf->stripeconnect->enabled) || $conf->entity==1)
{
if (preg_match('/acct_/i', $source))
{
| [Stripe->[createPaymentStripe->[getStripeAccount]]] | Create a payment for a customer This function returns an object that can be used to create a payment or order. Stripe \ Payment Stripe s API error handling This function is used to handle errors that occur during Stripe s network communication. | Entity defined on wich company we are working. Code and behaviour must be same whatever is entity. It can depends on setup that differs according to entity but not on the fact we are on an entity or another |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.