patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -170,11 +170,13 @@ class BatchLoads<DestinationT>
new DoFn<Void, String>() {
@ProcessElement
public void getTempFilePrefix(ProcessContext c) {
- c.output(
- resolveTempLocation(
- ... | [BatchLoads->[validate->[IllegalArgumentException,checkArgument,getTempLocation,isNullOrEmpty,fromUri,format],expand->[getSideInputs,asIterable,newArrayList,randomUUIDString,withOutputTags,of,withSideInputs,asMultimap,apply,setCoder,asSingleton,pCollections,discardingFiredPanes,addAll,in,getPipeline,withCoder],BigQuery... | Expands the given input into a new global window. A private method to create a sequence of records that can be spilled to files. This transform transforms a batch of files into multiple partitions and then partition them into multiple partitions. | This one is no longer equal to the one at line 197 - is this expected? |
@@ -1,4 +1,4 @@
-!function(t){if("object"==typeof exports&&"undefined"!=typeof module)module.exports=t();else if("function"==typeof define&&define.amd)define([],t);else{var e;e="undefined"!=typeof window?window:"undefined"!=typeof global?global:"undefined"!=typeof self?self:this,e.vg=t()}}(function(){var t;return funct... | [No CFG could be retrieved] | This module is not available in the browser but it s not available in the browser. Define modules for the D3 D3 D3 transforms. | We should avoid changing third_party code. |
@@ -42,6 +42,9 @@ tasks = {
Q(**{current_autoapprovalsummary + 'verdict': amo.AUTO_APPROVED}) &
~Q(**{current_autoapprovalsummary + 'confirmed': True})
]},
+ 'constantly_recalculate_post_review_weight': {
+ 'method': recalculate_post_review_weight,
+ 'qs': get_recalc_... | [Command->[add_arguments->[add_argument],handle->[group,chord,keys,CommandError,chunked,append,get,distinct,update,apply_async,task,filter,join]],datetime,version_int,Q,get_armagaddon_ratings_filters] | Imports all tasks that are not part of the April project. A list of functions that can be called to determine if a theme is required. | nit: IMHO this function doesn't need to live outside this file (as least not for the moment) |
@@ -201,7 +201,7 @@ public class DatePartitionedNestedRetriever implements PartitionAwareFileRetriev
return new PathFilter() {
@Override
public boolean accept(Path path) {
- return path.getName().endsWith(extension);
+ return path.getName().endsWith(extension) && !path.getName().equals(... | [DatePartitionedNestedRetriever->[initDatePartition->[initDatePartitionFromPattern,initDatePartitionFromGranularity],constructSourcePath->[Path,append,print,toString,isEmpty,StringBuilder],init->[Path,initDatePartition,getLeadTimeDurationFromConfig,getProp,HadoopFsHelper,setDefault,forID],getFileFilter->[accept->[endsW... | Returns a filter that returns true if the file name ends with the expected extension. | What if someone is using a custom metadata file name? |
@@ -746,7 +746,9 @@ public class ReferenceCountedOpenSslEngine extends SSLEngine implements Referenc
// We produced / consumed some data during the handshake, signal back to the caller.
// If there is a handshake exception and we have produced data, we should send the d... | [ReferenceCountedOpenSslEngine->[getSSLParameters->[getSSLParameters],needPendingStatus->[isOutboundDone,isInboundDone],retain->[retain],sslReadErrorResult->[shutdownWithError],getOcspResponse->[getOcspResponse],setKeyMaterial->[setKeyMaterial],getDelegatedTask->[run->[run]],wrap->[release,writePlaintextData,isBytesAva... | Wrap the given bytes in the given buffer. Checks if a chunk of data is available in the network and flushes it if it is Checks if a chunk of data is available in the buffer and if so returns the status of Checks if there is enough space to write the plaintext application data. | cc @Scottmitch could I trouble you to check this out since it has your name on it :wink: |
@@ -76,6 +76,14 @@ func resourceAwsEfsFileSystemCreate(d *schema.ResourceData, meta interface{}) er
createOpts.PerformanceMode = aws.String(v.(string))
}
+ if v, ok := d.GetOk("encrypted"); ok {
+ createOpts.Encrypted = aws.Bool(v.(bool))
+ }
+
+ if v, ok := d.GetOk("kms_key_id"); ok {
+ createOpts.KmsKeyId = ... | [Printf,CreateFileSystem,DescribeTags,DeleteFileSystem,Error,GetOk,UniqueId,Sprintf,PrefixedUniqueId,WaitForState,Id,String,Errorf,DescribeFileSystems,SetId,Set,Code] | resourceAwsEfsFileSystemCreate creates an EFS file system with the given ID. not - found returns the EFS file system and its life cycle state. | We should check that `Encrypted` is true if `KmsKeyId` is set, and catch the related Exception if the API call is made (BadRequest perhaps?). |
@@ -26,7 +26,7 @@ import java.util.Optional;
@AutoValue
public abstract class Titles {
- private static final String KEY_WIDGETS = "widget";
+ public static final String KEY_WIDGETS = "widget";
@JsonValue
public abstract Map<String, Map<String, String>> titles();
| [Titles->[empty->[emptyMap,of],of->[AutoValue_Titles],widgetTitle->[get,ofNullable]]] | A Titles object that represents a sequence of titles. | Instead of making this public, could we introduce `Titles#withWidgetTitle(String widgetId, String title)` which returns a modified instance of `Titles` with the widget title being added? |
@@ -32,10 +32,10 @@ import (
)
const (
- SYN = 0x16
- ACK = 0x06
- DEBUG_ACK = 0x07
- NAK = 0x15
+ CodeSync = 0x16
+ CodeAck = 0x06
+ CodeDebugAck = 0x07
+ CodeNak = 0x15
)
// PurgeIncoming is used to clear a channel of bytes prior to handshaking
| [Write,ReadFull,Add,Error,Infof,Sprintf,Debug,Compare,Begin,New,Now,Duration,Deadline,End,Errorf,Read,SetReadDeadline,Debugf] | PurgeIncoming is used to clear a channel of bytes prior to handshaking read the expected SYN - ACK and ACK from the connection. | What was the lint warning? I'd rather not have `Code` in const name. And `Syn` is probably fine. |
@@ -222,6 +222,11 @@ public class PasswordManagementProperties implements Serializable {
*/
private boolean securityQuestionsEnabled = true;
+ /**
+ * Add serviceUrl to the password reset url
+ */
+ private boolean addServiceToPasswordResetUrl = false;
+
/**
... | [PasswordManagementProperties->[Reset->[setText,EncryptionJwtSigningJwtCryptographyProperties,setAttributeName,setKeySize,setSubject,EmailProperties],ForgotUsername->[setAttributeName,setText,setSubject,EmailProperties],Jdbc->[PasswordEncoderProperties],Groovy,ForgotUsername,Reset,Ldap,Jdbc,Json,Rest]] | A class that implements the Negotiation of a Negotiation resource. | Remove this setting and make this the default behavior. |
@@ -921,7 +921,11 @@ public class ServerSessionPacketHandler implements ChannelHandler {
}
if (response != null) {
- channel.send(response);
+ try {
+ channel.send(response);
+ } finally {
+ releaseResponse(response);
+ }
}
if (closeC... | [ServerSessionPacketHandler->[onSessionSend->[createNullResponseMessage],internaltransferConnection->[transferConnection],slowPacketHandler->[close,getID],onActiveMQExceptionWhileHandlePacket->[convertToExceptionPacket],sendResponse->[onError->[convertToExceptionPacket]],doConfirmAndResponse->[close],close->[close,clos... | Do confirm and response. | is this blocking or async the handling of the packet within the channel, i ask, because if its async you need to be careful, putting back the object into the pool, as it may not be finished with, and i thought within netty bits like that are handed off, i could be wrong... |
@@ -0,0 +1,9 @@
+/**
+ * The type of Redux action which changes Google API state.
+ *
+ * {
+ * type: SET_GOOGLE_API_STATE
+ * }
+ * @public
+ */
+export const SET_GOOGLE_API_STATE = Symbol('SET_GOOGLE_API_STATE');
| [No CFG could be retrieved] | No Summary Found. | Looking forward at outlook, would outlook have its own feature folder? I'm playing around with the idea of having an integrations feature, for example. |
@@ -96,7 +96,10 @@ func (t *UpgradeTest) Setup(f *framework.Framework) {
// Hit it once before considering ourselves ready
ginkgo.By("hitting pods through the service's LoadBalancer")
timeout := service.LoadBalancerLagTimeoutAWS
- service.TestReachableHTTP(tcpIngressIP, svcPort, timeout)
+ // require five passing... | [Setup->[ExpectNoError,WaitForLoadBalancer,AddRCAntiAffinity,By,CreatePDB,GetIngressPoint,TestReachableHTTP,GetServiceLoadBalancerCreationTimeout,CreateTCPService,Run,NewTestJig],Test->[ExpectNoError,LoadClientset,StartRecordingToSink,By,WaitForServiceDeletedWithFinalizer,Background,EventsV1beta1,WithCancel,Now,NewReco... | Setup creates a test for the upgrade test Catch all the tests that are required to run in a loop. | are the requests for reachability made back to back? or is there/should there be a delay between retries? |
@@ -86,7 +86,8 @@ public class JavaScriptPostAggregator implements PostAggregator
private final List<String> fieldNames;
private final String function;
- private final Function fn;
+ // This variable is lazily initialized to avoid unnecessary JavaScript compilation during JSON serde
+ private Function fn;
... | [JavaScriptPostAggregator->[hashCode->[hashCode],compute->[apply],equals->[equals],compile]] | Creates a post - aggregator that aggregates a number of values. Computes the for the given fields. | Similar thread-safety questions to the other files. |
@@ -84,7 +84,7 @@ def cli_args(request, tmpdir, raiden_testchain, removed_args, changed_args, envi
# This assumes that there is only one Raiden instance per CLI test
base_logfile = os.path.join(
- get_artifacts_storage(str(tmpdir)), request.node.name, "raiden_nodes", "cli_test.log"
+ get_artif... | [raiden_testchain->[setup_raiden,mkdtemp,print,setup_testchain,str,EthClient,join,makedirs,get_artifacts_storage,monotonic],cli_args->[append,dirname,copy,str,replace,join,items,makedirs,get_artifacts_storage],raiden_spawner->[spawn_raiden->[addfinalizer,copy,startswith,str,items,spawn]],fixture] | Build command line arguments for raiden_nodes. | `request.node.name` only contains the test name, if any of the tests are parametrized they would overwrite each other. You can use `request.node.nodeid` to get the uniqe id including parametrization but that may contain characters not suitable for file names. |
@@ -107,7 +107,11 @@ def cloud(name, project, version, watch, logs):
click.secho("{} not found".format(name), fg="red")
return
- flow_run_id = client.create_flow_run(flow_id=flow_id)
+ loaded_params = None
+ if parameters:
+ loaded_params = json.load(open(parameters))
+
+ flow_run... | [cloud->[create_flow_run,with_args,tabulate,append,sleep,Client,EnumValue,graphql,len,format,secho,echo],option,group,command] | Get a specific lease in Prefect Cloud Get a from the graph of a flow run. Check if state is Success or Failed. | this looks like it could leave the file open, we should probably use a context manager |
@@ -27,7 +27,7 @@ import { <%=angularXAppName%>SharedModule } from 'app/shared';
import {
adminState,
- <%_ if (databaseType !== 'no' && databaseType !== 'cassandra') { _%>
+ <%_ if ((databaseType !== 'no' ? true : authenticationType === 'uaa') && databaseType !== 'cassandra') { _%>
AuditsComponent,
... | [No CFG could be retrieved] | This file is part of the JHipster project. It is part of the J JHipster - needle - add - admin - module. | I think that's just `(databaseType !== 'no' || authenticationType === 'uaa')` |
@@ -13,12 +13,8 @@ def validate_storefront_url(url):
"""
try:
parsed_url = urlparse(url)
+ domain, _ = split_domain_port(parsed_url.netloc)
except ValueError as error:
raise ValidationError({"redirectUrl": str(error)})
- if not validate_host(parsed_url.netloc, settings.ALLOWED... | [validate_storefront_url->[str,validate_host,ValidationError,urlparse]] | Validate the storefront URL. Raise ValidationError if URL isn t in RFC 1808 format or. | We should change the `ALLOWED_STOREFRONT_HOSTS` setting name to something more generic as it is used with either storefronts or dashboard. Maybe `ALLOWED_CLIENT_HOSTS`? |
@@ -525,6 +525,8 @@ public class NfsSecondaryStorageResource extends ServerResourceBase implements S
bufferWriter.write("\n");
long size = _storage.getSize(destFileFullPath);
bufferWriter.write("size=" + size);
+ bufferWriter.close();
+ ... | [NfsSecondaryStorageResource->[swiftDelete->[execute],findFile->[getFile],getTemplateOrVolumePostUploadCmd->[getPostUploadPSK],copySnapshotToTemplateFromNfsToNfs->[copySnapshotToTemplateFromNfsToNfsXenserver],configure->[retrieveNfsVersionFromParams,configure],execute->[swiftDelete,copyFromS3ToNfs,copyFromNfsToImage,ge... | copy snapshot from source nfs to dest nfs Copy a single template object to the destination file. | LGTM, however, should we consider a `try-with-resource` syntax that can handle proper cleanup of resources in case of errors and valid closures. |
@@ -38,12 +38,14 @@ import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.mapreduce.InputFormat;
import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
... | [HIFIOWithEmbeddedCassandraTest->[testHIFReadForCassandraQuery->[apply],startCassandra->[createCassandraData]]] | Imports the given package for HIFIO with embedded cassandra. This class is used to provide the partitioner class for the Murmur3 input. | If it is already tested by the other test, why not remove it entirely? |
@@ -302,6 +302,7 @@ from .property.numeric import NonNegativeInt; NonNegativeInt
from .property.numeric import Percent; Percent
from .property.numeric import PositiveInt; PositiveInt
from .property.numeric import Size; Size
+from .property.numeric import Base64String; Base64String
from .property.override import O... | [getLogger] | Dev API for importing a property. | imports must be alphabetized |
@@ -355,6 +355,12 @@ class DataParallel(layers.Layer):
layers(Layer): The module that should be executed by data parallel.
strategy(ParallelStrategy, optional): (deprecated) The strategy of data parallelism,
contains environment configuration related to parallel execution. Default: None.... | [scale_loss->[ParallelEnv],_build_default_parallel_strategy->[ParallelEnv],DataParallel->[set_state_dict->[set_state_dict],state_dict->[state_dict],__init__->[_build_default_parallel_strategy]],_split_tensors->[_reshape_inplace],apply_collective_grads->[_build_default_parallel_strategy,_coalesce_tensors,_split_tensors,... | The data paralleled module. Linear 2 - D model. | groupgroupbuffer_size? comm_buffer_size last_comm_buffer_size |
@@ -105,6 +105,7 @@ test_setup_pool_create(void **state, struct test_pool *ipool,
else
print_message("setup: created pool "DF_UUIDF"\n",
DP_UUID(outpool->pool_uuid));
+ uuid_unparse(outpool->pool_uuid, outpool->pool_str);
if (rank_list)
d_rank_list_free(rank_list);
}
| [test_setup_next_step->[test_setup_pool_create],test_get_leader->[test_pool_get_info],daos_exclude_server->[daos_exclude_target],get_daos_prop_with_user_acl_perms->[get_daos_prop_with_owner_and_acl,get_daos_acl_with_owner_perms],test_teardown->[test_teardown_cont_hdl,pool_destroy_safe,test_teardown_cont],get_daos_prop_... | This function is called by the pool_create routine. It creates a new test pool from D - MMG - POOL CREATE MPI_Bcast - Bcast - Bcast - Bcast - Bcast -. | so why not just switch to using labels in the entire testsuite instead of uuid_str? |
@@ -251,7 +251,7 @@ namespace System.Windows.Forms
if (value != null && !value.Equals(text))
{
- if (value != null && value.Length > 63)
+ if (value != null && value.Length > 127)
{
throw new Argument... | [NotifyIcon->[ShowBalloonTip->[ShowBalloonTip],WmMouseMove->[OnMouseMove],NotifyIconNativeWindow->[OnThreadException->[OnThreadException],WndProc->[WndProc]],WmMouseUp->[OnMouseClick,OnClick,OnMouseUp],WmTaskbarCreated->[UpdateIcon],Dispose->[Dispose],WmMouseDown->[OnMouseDown,OnMouseDoubleClick,OnDoubleClick],WndProc-... | Relations for the context menu. Relations to the object that can be used to create a control tag. | The text of the error must be updated as well. |
@@ -22,8 +22,8 @@ namespace Content.Server.GameObjects.Components.Mobs
[RegisterComponent]
public class MindComponent : Component, IExamine
{
- [DataField("show_examine_info")]
- private bool _showExamineInfo;
+ //[DataField("show_examine_info")]
+ //private bool _showExamineI... | [MindComponent->[Shutdown->[ghost,RunLevel,CharacterName,IoCManager,TransferTo,GridExists,GetObserverSpawnPoint,Empty,EntityManager,TryGetComponent,SpawnEntity,Name,Shutdown,GetGridId,Spawn,Coordinates,Invalid,InRound,CanReturnToBody],Examine->[Owner,IsDead,AddMarkup,GetString],ReadWrite]] | Component that implements the Mind interface. Magic number of entities that can be covered by Mind. | Just delete this, there's another one with the same name that's an auto-property instead |
@@ -52,6 +52,10 @@ public class FtpMessageHandler extends FileTransferringMessageHandler<FTPFile> {
super(remoteFileTemplate, mode);
}
+ public FtpMessageHandler(RemoteFileTemplate<FTPFile> remoteFileTemplate) {
+ super(remoteFileTemplate);
+ }
+
@Override
public boolean isChmodCapable() {
return true;
| [FtpMessageHandler->[doChmod->[UncheckedIOException,executeWithClient,sendSiteCommand,toOctalString],FtpRemoteFileTemplate,setExistsMode]] | Returns true if the user has permission to change the file. | No, we can't introduce this ctor: the `FtpMessageHandler` can only rely on the `FtpRemoteFileTemplate`. We have to deprecate those methods in DSL part and introduce new based on the proper implementation. |
@@ -35,15 +35,10 @@ class AzureCliCredential(object):
"""Authenticates by requesting a token from the Azure CLI.
This requires previously logging in to Azure via "az login", and will use the CLI's currently logged in identity.
-
- :keyword bool allow_multitenant_authentication: when True, enables the cre... | [_run_command->[sanitize_output,get_safe_working_dir]] | Initialize a class attribute. | Suggest deleting these no-op initializers |
@@ -48,6 +48,10 @@ def numpy_array_reshape(arr, newshape):
return np.reshape(arr, newshape)
+def numpy_broadcast_to(arr, shape):
+ return np.broadcast_to(arr, shape)
+
+
def flatten_array(a):
return a.flatten()
| [expand_dims->[expand_dims],atleast_3d->[atleast_3d],TestArrayManipulation->[test_array_transpose_axes->[check->[run],check_err_axis_repeated->[run],check_err_invalid_args->[run],check_err_axis_oob->[run],check_err_invalid_args,check_err_axis_repeated,from_generic,check_issue_4708,check_err_axis_oob,check],check_atleas... | Flatten an array of arrays. | Do these tests need a copy of `np.broadcast_to`? |
@@ -53,7 +53,10 @@ func (c *Container) cleanupCgroups() error {
}
if err := cgroup.Delete(); err != nil {
- return err
+ // For now we are going to only warn on failures to clean up cgroups
+ // We have a conflict with running podman containers cleanup in same cgroup as container
+ logrus.Warnf("Ignoring Erro... | [cleanupCgroups->[ID,StaticPath,Join,Sprintf,Delete,save,Load,Debugf],mountSHM->[FormatMountLabel,Wrapf,Mount],prepare->[ID,cleanupStorage,mountStorage,createNetNS,Errorf],generateSpec->[Mounts,RootGID,Path,IsRootless,Warnf,Hostname,CGroupPath,GetUser,SetProcessGID,SetLinuxCgroupsPath,HasPrefix,Format,NewFromSpec,AddPr... | cleanupCgroups removes the cgroup from the container s cgroups directory. | You changed the behaviour. Now we do not cleanup storage if the cgroup cleanup fails. Why did you make this change? It might be better to go back to the original code. SInce I am not totally sure if this ignore is necessary since we removed cleanup from stop. I did not have time to check it out. You could test the theo... |
@@ -143,6 +143,8 @@ def compute_epochs_psd(epochs, picks=None, fmin=0, fmax=np.inf, tmin=None,
to be <= n_fft.
proj : bool
Apply SSP projection vectors.
+ method : 'welch' | 'multitaper'
+ The method to use in calculating the PSD.
n_jobs : int
Number of CPUs to use in the ... | [compute_raw_psd->[int,make_projector_info,parallel,parallel_func,info,arange,len,my_pwelch,time_as_index,float,_check_nfft,dot,array],_pwelch->[welch_fun],_compute_psd->[psd,array],compute_epochs_psd->[int,make_projector_info,parallel_func,_time_mask,get_data,arange,len,zip,empty,array_split,my_pwelch,info,slice,float... | Compute the power spectral density with average periodograms. - window data. | Can you explain in one line what each method does? For details, we should add references in the manual |
@@ -748,10 +748,13 @@ class Enumerate(AbstractTemplate):
def generic(self, args, kws):
assert not kws
- [it] = args
+ it = args[0]
+ if len(args) > 1 and not args[1] in types.integer_domain:
+ raise TypingError("Only integers supported as start value in enumerate")
+
... | [GetItemUniTuple->[generic->[normalize_index]],SetItemArray->[generic->[normalize_index]],PrintOthers->[generic->[accepted_types]],GetItemArray->[generic->[normalize_index]]] | Generic function for the enumerate_type. | len(args) > 2 should always fail, too. |
@@ -18,9 +18,12 @@
package mage
import (
+ "fmt"
"io/ioutil"
+ "log"
"os"
"path/filepath"
+ "regexp"
"sort"
"strings"
| [IsNotExist,Title,Join,ReadFile,IsDir,New,Unmarshal,Name,ReadDir,Repeat,Slice,WriteFile] | Reads and parses the YML file containing the configuration of a single . moduleDashes returns the name of the module and the short config. | Why has the reference config different access right? |
@@ -523,6 +523,15 @@ describe 'An Assignment' do
locale: 'en')
end
+ it 'routes POST update_submissions properly' do
+ expect(post: sub_path + '/update_submissions').to route_to(
+ controller: sub_ctrl,
+ action: 'update_submissions',
+ assignment_id: assignmen... | [context,to,create,let,to_s,describe,not_to,route_to,it,require] | route_to - controller for all sub - components of a group routes POST manually_collect_and_begin_grading properly. | Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. |
@@ -26,8 +26,6 @@ export default Component.extend({
inviteIcon: "envelope",
invitingExistingUserToTopic: false,
- isAdmin: alias("currentUser.admin"),
-
init() {
this._super(...arguments);
this.setDefaultSelectedGroups();
| [No CFG could be retrieved] | The default component that is used to show a list of groups and users. Checks if the username is valid and can be invited to a private topic via email. | This removal seem to be missing a matching addition of `isAdmin: readOnly( )`? |
@@ -347,10 +347,12 @@ def plot_raw(raw, events=None, duration=10.0, start=0.0, n_channels=20,
scalebars_visible=show_scalebars,
window_title=title)
- fig = _browse_figure(**params)
+ fig = _get_browser(**params)
+
fig._update_picks()
- # make channel selection dia... | [_setup_channel_selections->[_get_stim_channel,pick_channels,read_vectorview_selection,len,_check_option,_get_ch_info,ValueError,in1d,concatenate,OrderedDict,_divide_to_regions,pick_types,intersect1d],plot_raw_psd->[_psd_figure,plt_show,min,time_as_index,isfinite,diff],plot_raw->[_compute_scalings,round,,_make_event_co... | Plot a sequence of raw data with a single color. A function to apply the a to the traces. Additional parameters for the filter that are applied when displaying data. A function to plot a single - channel noise covariance object. | Why the newline here? |
@@ -0,0 +1,14 @@
+class CreateUserCounters < ActiveRecord::Migration[5.2]
+ def change
+ create_table :user_counters do |t|
+ t.references :user, index: { unique: true }
+ t.jsonb :data, null: false, default: {}
+
+ t.timestamps null: false
+ end
+
+ add_foreign_key :user_counters, :users, on_d... | [No CFG could be retrieved] | No Summary Found. | unique to make sure that we only have 1 row per user |
@@ -143,7 +143,11 @@ public class JobWorker implements Serializable {
* Used by upstream streaming queue to send data to this actor
*/
public void onReaderMessage(byte[] buffer) {
- transferHandler.onReaderMessage(buffer);
+ if (task != null) {
+ task.onReaderMessage(buffer);
+ } else {
+ ... | [JobWorker->[onWriterMessageSync->[onWriterMessageSync],onWriterMessage->[onWriterMessage],onReaderMessage->[onReaderMessage],start->[start],onReaderMessageSync->[onReaderMessageSync]]] | Called when a reader message is received. | Why `task` can be null when call `onReaderMessage ` |
@@ -174,6 +174,9 @@ class ConanFile(object):
"but self.user is used in conanfile")
return self._user
+ def hasattr(self, attr):
+ return attr in self.__dict__
+
def collect_libs(self, folder="lib"):
self.output.warn("Use 'self.collect_libs' is dep... | [ConanFile->[collect_libs->[collect_libs],__init__->[create_exports,create_options,create_requirements,create_settings,create_exports_sources]]] | object that represents the user s package. | Remove from here, give it the minimum necessary scope (i.e. in packager.py) |
@@ -928,6 +928,7 @@ func importSpec(spec PackageSpec, languages map[string]Language, loader Loader)
}
for _, t := range types.objects {
typeList = append(typeList, t)
+ typeList = append(typeList, t.InputShape)
}
for _, t := range types.arrays {
typeList = append(typeList, t)
| [bindProperties->[bindType],bindResourceType->[bindResourceTypeDetails],bindEnumTypeDetails->[bindType],bindObjectType->[bindObjectTypeDetails],bindType->[bindTypeSpecRef,String,bindType,bindPrimitiveType],bindEnumType->[bindEnumTypeDetails],bindTypeSpecRef->[GetType,GetResourceType,parseTypeSpecRef],bindObjectTypeDeta... | is the serializable form of an object type. | Just trying to understand. Why do we append `InputShape` here, but not `PlainShape`? |
@@ -100,7 +100,10 @@ class MechanicalSolver(PythonSolver):
"materials_filename": ""
},
"time_stepping" : { },
+ "strain_dofs": false,
"rotation_dofs": false,
+ "pressure_dofs": false,
+ "displacement_control": false,
"... | [MechanicalSolver->[AddDofs->[AddDofs],_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_constitutive_laws],Initialize->[Initialize],_create_line_search_strategy->[GetComputingModelPart,get_solution_scheme,get_builder_and... | Returns the default settings for the MechanicalSolver. | maybe this is better "volumetric_strain_dofs" |
@@ -1147,11 +1147,10 @@ DataReaderImpl::get_matched_publication_data(
DDS::ReturnCode_t
DataReaderImpl::enable()
{
- //According spec:
- // - Calling enable on an already enabled Entity returns OK and has no
- // effect.
+ // According to spec:
+ // - Calling enable on an already enabled Entity has no effect an... | [No CFG could be retrieved] | This function is called from DDS_Ace_Abstract. It is called by D - > 0 ;. | Why are these lines changed in this PR? Doesn't seem related to this task. |
@@ -623,6 +623,13 @@ class TokenNetwork:
if not isinstance(total_deposit, int):
raise ValueError('total_deposit needs to be an integral number.')
+ if not self.client.can_query_state_for_block(block_identifier):
+ # This can happen if we shutdown with a deposit transaction save... | [TokenNetwork->[all_events_filter->[events_filter],_check_channel_state_before_settle->[detail_channel],update_transfer->[channel_is_settled,_update_preconditions,detail_channel],new_netting_channel->[_new_channel_preconditions,_new_channel_postconditions],_check_channel_state_after_settle->[_check_channel_state_before... | Checks the preconditions for deposit. Check if a new total deposit is available for the current node. This method is called when a user fails to approve a lease. | latest **is not a valid value**, that is *the reason why we have done the work for the consistent blockchain view.* (This also applies to the other cases in this PR) |
@@ -146,6 +146,11 @@ public class ExpectedLogsTest {
}
}
+ @Test
+ public void testLogsCleared() {
+ expectedLogs.verifyNotLogged(TEAR_DOWN_MESSAGE);
+ }
+
// Generates a random fake error message.
private String generateRandomString() {
return "Fake error message: " + random.nextInt();
| [ExpectedLogsTest->[testWhenNoExpectations->[generateRandomString,error],testVerifyNotLoggedWhenMatchedWithException->[verifyNotLogged,generateRandomString,error,IOException],testVerifyWhenMatchedWithExceptionBeingLogged->[verifyError,generateRandomString,error,IOException],testVerifyWhenNotMatched->[verifyError,genera... | Test thread safety of log saver. | Look at RestoreDataflowLoggingMDCTest to see how to create a test rule and validate the before/after state. |
@@ -123,7 +123,7 @@ func (w *terminationFileWriter) Write(bs []byte) (int, error) {
Compress: false,
}
w.logger = l
- klog.Infof("Redirecting termination logs to %q", w.fn)
+ fmt.Fprintf(os.Stderr, "Copying termination logs to %q\n", w.fn)
}
if n, err := w.logger.Write(bs); err != nil {
ret... | [Write->[Write,Infof],Chtimes,Now,Close,Signal,Exit,Done,Set,Add,IsNotExist,Stop,Stat,Args,Notify,Wait,Create,Local,Infof,ExitCode,InitFlags,Remove,Command,Println,SetOutput,String,Parse,Run] | Write writes the bytes to the termination file. | with the recursive `klog.Infof` there was no logging at all. |
@@ -8,6 +8,10 @@ import (
"strings"
"time"
+ "k8s.io/client-go/informers"
+
+ "k8s.io/apiserver/pkg/admission/initializer"
+
"github.com/golang/glog"
lru "github.com/hashicorp/golang-lru"
| [SetDefaultRegistryFunc->[RegistryNameMatcher],Mutate->[DeepCopy,Mutate,Infof,DeepEqual,V,Errorf,ObjectGoPrintSideBySide],ValidateInitialization->[Errorf],Validate->[admit],resolveImageReference->[Before,Exact,Images,resolveImageStreamTag,Matches,Errorf,Get,Add],SetRESTClientConfig->[NewForConfig,HandleError],resolveIm... | Package that imports all the components of the object that are not part of the imagepolicy. Register registers the plugin for the . | That goland of yours is causing me headaches :stuck_out_tongue_closed_eyes: |
@@ -265,13 +265,13 @@ func (ctx *Context) LookupTypeToken(node diag.Diagable, tok tokens.Type, require
}
}
- // The type was not found; issue an error, and return an error type so we can proceed with typechecking.
+ // The type was not found; issue an warning, and return the dynamic type so we can proceed with t... | [RequireVariable->[RequireDefinition],LookupTypeToken->[LookupSymbol],RequireClassMember->[LookupSymbol],RequireToken->[LookupSymbol],RegisterType->[HasType],RequireType->[HasType],LookupFunctionType->[LookupType],lookupSymbolCore->[LookupClassMember],lookupBasicType->[LookupTypeToken],RequireFunction->[RequireDefiniti... | LookupTypeToken looks up a type token in the given node. If the type is not. | Nit, `an warning` => `a warning`. |
@@ -446,12 +446,10 @@ class Optimizer(object):
for param_and_grad in parameters_and_grads:
if param_and_grad[1] is None:
continue
- with param_and_grad[0].block.program._optimized_guard(
- param_and_grad):
- if p... | [MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],PipelineOptimizer->[_extract_section_ops->[_is_opt_role_op],_find_input_output->[update],minimize->[minimize,_create_vars,_split_program],_split_program->[_extract_section_ops,_find_persistable_vars,u... | Create an optimization pass for the missing constraint. Get the ops that are needed to optimize the . | array append array |
@@ -3,10 +3,12 @@
# This source code is licensed under the BSD-style license found in the
# LICENSE file in the root directory of this source tree. An additional grant
# of patent rights can be found in the PATENTS file in the same directory.
-"""This file contains a list of all the models in the model zoo,
-the pat... | [No CFG could be retrieved] | The model zoo file contains a list of all the models in the model zoo agents. | just realized this says `interactive.lua`, could you possibly change to `interactive.py` |
@@ -85,7 +85,7 @@ func NewClient(cfg Config, codec codec.Codec) (*Client, error) {
return nil, err
}
c := &Client{
- kv: consulMetrics{client.KV()},
+ kv: client.KV(),
codec: codec,
cfg: cfg,
}
| [Get->[Get],List->[List],Delete->[Delete],cas->[CAS],Put->[Put]] | RegisterFlags registers flags for Consul. CAS atomically modifies a value in a callback. | Previously we could see individual `CAS` calls to consul. Now we will only see "CAS loop". |
@@ -35,3 +35,12 @@ maps = make_field_map(evoked, trans_fname, subject='sample',
# explore several points in time
[evoked.plot_field(maps, time=time) for time in [0.09, .11]]
+
+# Compute the field maps to project MEG and EEG fields both in
+# scalp surface
+maps = make_field_map(evoked, trans_fname, subject='sample... | [make_field_map,read_evokeds,print,data_path,plot_field] | Explore several points in time. | does it crash if I want both eeg and meg on the scalp? |
@@ -83,12 +83,12 @@ SCALA_PARSER_ARTIFACT_REQUIREMENTS = ArtifactRequirements(
@dataclass(frozen=True)
class ScalaSourceDependencyAnalysis:
- package: str
+ provided_names: FrozenOrderedSet[str]
@classmethod
def from_json_dict(cls, d: dict) -> ScalaSourceDependencyAnalysis:
return cls(
- ... | [analyze_scala_source_dependencies->[FallibleScalaSourceDependencyAnalysisResult],setup_scala_parser_classfiles->[ScalaParserCompiledClassfiles]] | Create a ScalaSourceDependencyAnalysis object from a JSON dict. | Is the removal of `package` because the providedNames are already prefixed with the package? |
@@ -282,6 +282,13 @@ func (data *resourceRowData) IsDone() bool {
return true
}
+ if isRootStack(data.step) {
+ // the root stack only becomes 'done' once the program has completed (i.e. the condition
+ // checked just above this). If the program is not finished, then always show the root
+ // stack as not d... | [ColorizedColumns->[IsDone],ColorizedSuffix->[IsDone],RecordPolicyViolationEvent->[recordDiagEventPayload]] | IsDone returns true if the data is done. | For my own understanding, what are the cases where `data.ContainsOutputsStep(data.step.Op)` returns "true" but the stack is not actually done updating? I would have assume that we would not see the outputs until the entire stack has completed updating? |
@@ -0,0 +1,12 @@
+require_dependency 'discourse_ip_info'
+
+module Jobs
+ class UpdateMaxMindDb < Jobs::Scheduled
+ every 7.days
+
+ def execute(args)
+ DiscourseIpInfo.update!
+ DiscourseIpInfo.reload
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I think `update!` should take care of calling `reload`. |
@@ -19,7 +19,7 @@ class UrlTest extends \PHPUnit_Framework_TestCase
{
return [
['de', 'at', 'de', 'at', true],
- ['de', '', 'de', null, true],
+ ['de', '', 'de', '', true],
['de', null, 'de', null, true],
[null, null, 'en', 'gb', true],
... | [UrlTest->[testIsValidLocale->[isValidLocale,assertEquals,setLanguage,setCountry],testToArray->[setRedirect,setMain,setSegment,setAnalyticsKey,toArray,setCountry,setUrl,setLanguage,assertEquals]]] | provide a valid locale for the locale. | @danrot here I'm not sure if I should change Url.php#L248 from `===` to `==` so this test case match. Before it did return true because empty($this->getCountry()) was true and it did never the equal check. |
@@ -201,6 +201,12 @@ export class IntersectionObserverPolyfill {
this.threshold_[this.threshold_.length - 1] <= 1,
'Threshold should be in the range from "[0, 1]"');
+ /** @private {?./layout-rect.LayoutRectDef} */
+ this.lastViewportRect_ = null;
+
+ /** @private {./layout-rect.LayoutRectD... | [No CFG could be retrieved] | Provides a way to observe an element s intersection data. observe element once. | Instance/class vars cannot have `opt_` prefix. Please remove. |
@@ -795,6 +795,7 @@ namespace Dynamo.Models
{
NodeFactory.AddTypeFactoryAndLoader(type.Type);
NodeFactory.AddAlsoKnownAs(type.Type, type.AlsoKnownAs);
+ type.IsPackageMember = true;
AddNodeTypeToSearch(type);
... | [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Copy],RemoveWorkspace->[Dispose],ResetEngine->[ResetEngine],ShutDown->[OnShutdownStarted,OnShutdownCompleted],DumpLibraryToXml->[DumpLibraryToXml],ResetEngineInternal->[RegisterCustomNodeDefinitionWithEngine,Dispose],AddWork... | Load the node library. | Case for "Interactive" dlls. E.g. Color Range. |
@@ -266,6 +266,9 @@ public class ParallelRunner implements Closeable {
if (group.isPresent()) {
HadoopUtils.setGroup(dstFs, dst, group.get());
}
+ if (commitAction != null) {
+ commitAction.apply();
+ }
}
return null;
... | [ParallelRunner->[deletePath->[call->[deletePath]],renamePath->[call->[renamePath]],movePath->[call->[movePath]]]] | Move a file or directory from one location to another. | Why do you call `apply()` after moving every single file? Shouldn't it only be called once, after all files of a task have been moved? |
@@ -3269,6 +3269,17 @@ static void print_stuff(BIO *bio, SSL *s, int full)
BIO_printf(bio, " i:");
X509_NAME_print_ex(bio, X509_get_issuer_name(sk_X509_value(sk, i)), 0, get_nameopt());
BIO_puts(bio, "\n");
+ public_key = X509_get_pubkey(sk_X509_value(... | [No CFG could be retrieved] | Prints the stuff that can be done by the server. The is the last entry in the chain. | This line seems to be too long |
@@ -413,6 +413,12 @@ def plot_epochs(epochs, picks=None, scalings=None, n_epochs=20,
title : str | None
The title of the window. If None, epochs name will be displayed.
Defaults to None.
+ events : None, array, shape (n_events, 3)
+ Events to show with vertical bars.
+ event_colors :... | [_plot_onkey->[_plot_traces,_plot_window],_mouse_click->[plot_epochs_image,_pick_bad_epochs,_plot_window],_toggle_labels->[_plot_vert_lines],_epochs_navigation_onclick->[_draw_epochs_axes]] | Visualize a series of bad epochs. Plots a single missing key. | can add a note that this will only work if epochs have not been resampled? |
@@ -1997,12 +1997,6 @@ namespace System.Windows.Forms
case WindowMessages.WM_RBUTTONUP:
mousePressed = false;
mouseEvents = false;
- //set the mouse capture .. this is the Child Wndproc..
- //
- if (Conte... | [ComboBox->[FindString->[FindString],ACNativeWindow->[ClearNullACWindows->[Remove,Add],WndProc->[Remove,WndProc],RegisterACWindow->[Remove,Add],Add],OnFontChanged->[OnFontChanged],ComboBoxChildEditUiaProvider->[GetPropertyValue->[GetPropertyValue],FragmentNavigate->[GetChildFragmentCount,FragmentNavigate,GetPropertyVal... | This method processes the child message. Checks if a child window can be found in the child list box. if fireSetFocus is true this will fire the focus events twice in the combobox and This function is called when the user clicks on the left mouse and the right mouse is pressed Mouse down and left button on the combo bo... | This looks like a bug, originally `CaptureInternal = true` if `ContextMenu != null || ContextMenuStrip != null`, however it was reverted only in case of `ContextMenu != null`... |
@@ -22,6 +22,17 @@ public interface EvictionManager<K, V> {
/**
* Handles notifications of evicted entries
* @param evicted The entries that were just evicted
+ * @return stage that when complete the notifications are complete
*/
- CompletionStage<Void> onEntryEviction(Map<K, Map.Entry<K, V>> ev... | [No CFG could be retrieved] | This method is called when the entry is evicted from the cache. | How about also switching from a map to a single entry? |
@@ -293,6 +293,7 @@ func (c *client) getOrCreateGRPCConn(addr string) (*grpc.ClientConn, error) {
defer c.connMu.Unlock()
if old, ok := c.connMu.clientConns[addr]; ok {
cc.Close()
+ log.Warn("use old connection", zap.String("target", cc.Target()), zap.String("state", cc.GetState().String()))
return old, nil
... | [ScatterRegion->[ScatterRegion,leaderClient],updateLeader->[updateURLs],GetAllStores->[leaderClient,ScheduleCheckLeader,GetAllStores],GetStore->[leaderClient,ScheduleCheckLeader,GetStore],GetPrevRegion->[leaderClient,ScheduleCheckLeader,GetPrevRegion,GetRegion],UpdateGCSafePoint->[leaderClient,ScheduleCheckLeader,Updat... | getOrCreateGRPCConn returns a grpc. ClientConn for the given address or returns an error. | Maybe Info or Debug? It is expected when there multiple goroutines trying to create connection at the same time? |
@@ -35,7 +35,7 @@ def _path(opt):
class FlickrDataset(Dataset):
"""A Pytorch Dataset utilizing streaming"""
- def __init__(self, opt):
+ def __init__(self, opt, shared=None):
self.opt = opt
self.use_hdf5 = opt.get('use_hdf5', False)
self.datatype = self.opt.get('datatype')
| [DefaultTeacher->[next_example->[next_example,submit_load_request,get],num_episodes->[num_examples],__init__->[_path,_setup_data]],FlickrDataset->[num_examples->[num_episodes],num_images->[num_episodes],__init__->[_path]]] | Initialize the object with the given options. | do datasets need the shared param? |
@@ -74,10 +74,11 @@ module Engine
train = route.train
leased = ' '
if train.owner && @game.train_owner(train) != entity
- @game.game_error("Cannot run another corporation's train. refresh")
- @game.game_error('Cannot run train that operated') if train.ope... | [Route->[actions->[empty?,legal_route?,insolvent?,operator?,check_insolvency!],help->[name,receivership?,insolvent?],can_afford_depot_train?->[cash,min_depot_price,positive?],process_run_routes->[insolvent?,pass!,any?,name,nationalization,revenue,format_currency,routes,revenue_str,train,empty?,legal_route?,train_owner,... | Process run routes. | This one was intentional for rubocop (it pointed out that the `if train.operated` line could not be reached) but possibly a mistake -- @roseundy what is correct here? |
@@ -313,8 +313,9 @@ class DomainLanguage:
return_type = signature.return_annotation
# TODO(mattg): this might need to just call PredicateType.get_type, or something - what if
# one of these is a function?
- argument_nltk_types: List[PredicateType] = [BasicType(arg_type) for arg_type in... | [nltk_tree_to_logical_form->[nltk_tree_to_logical_form],DomainLanguage->[_get_function_transitions->[_get_transitions,ParsingError],_construct_node_from_actions->[_construct_node_from_actions,ParsingError],add_predicate->[BasicType,get_function_type],__init__->[BasicType],_execute_expression->[ExecutionError,_execute_e... | Adds a predicate to this domain language. | This TODO is done, right? The code below calls ``PredicateType.get_type`` |
@@ -82,7 +82,15 @@ func mergeConfigFiles(configFiles []string, config *Config) error {
return fmt.Errorf("Failed to read %s: %s", file, err)
}
- config.Prospectors = append(config.Prospectors, tmpConfig.Filebeat.Prospectors...)
+ if len(tmpConfig.Filebeat.Prospectors) > 0 {
+ cfgwarn.Deprecate("7.0.0", "pr... | [FetchConfigs->[Fatal,Info,Deprecate,Resolve],Stat,IsDir,Glob,Errorf,Read,Info] | FetchConfigs fetches all config files given by configFiles and merges them into config object. mergeConfigFiles merges configFiles into config. | Some system tests for this would also be nice. |
@@ -142,11 +142,12 @@ class NavigationTwigExtension extends \Twig_Extension implements NavigationTwigE
$webspaceKey = $this->requestAnalyzer->getWebspace()->getKey();
$locale = $this->requestAnalyzer->getCurrentLocalization()->getLocale();
- return $this->navigationMapper->getBreadcrumb(
- ... | [NavigationTwigExtension->[flatRootNavigationFunction->[getLocale,getRootNavigation,getKey],flatNavigationFunction->[getNavigation,getKey,getUuid,getLocale,loadBreadcrumb],breadcrumbFunction->[getLocale,getBreadcrumb,getKey],treeNavigationFunction->[getNavigation,getKey,getUuid,getLocale,loadBreadcrumb],treeRootNavigat... | Returns breadcrumb for given UUID. | should this not also be added to all the other functions basing on the uuid |
@@ -57,7 +57,7 @@ class TranslatedField(models.ForeignKey):
if value is not None:
self._db_column = value
- def contribute_to_class(self, cls, name):
+ def contribute_to_class(self, cls, name, private_only=False, **kwargs):
"""Add this Translation to ``cls._meta.translated_fields`... | [TranslatedField->[validate->[validate]],LocaleList->[extend->[extend],zip->[zip]],TranslationDescriptor->[translation_from_dict->[__set__,translation_from_string],__set__->[switch]]] | Set the DB column of the object. | should `private_only` be passed down to the `super(...).contribute_to_class(...)` ? |
@@ -45,6 +45,7 @@ class PluginUpdate(BaseMutation):
@classmethod
def perform_mutation(cls, root, info, **data):
plugin_id = data.get("id")
+ channel_slug = data.get("channel")
data = data.get("input")
manager = info.context.plugins
plugin = manager.get_plugin(plugin_... | [PluginUpdate->[Arguments->[PluginUpdateInput],perform_mutation->[PluginUpdate]]] | Perform a mutation on a . | Shouldn't we have here the same channel validation as it was added to `PaymentInitialize`? |
@@ -36,11 +36,11 @@ class CmdPipelineShow(CmdBase):
from dvc.stage import Stage
from dvc.repo.graph import get_pipeline
- stage = Stage.load(self.repo, target)
- G = get_pipeline(self.repo.pipelines, stage)
+ target_stage = Stage.load(self.repo, target)
+ G = get_pipeline... | [add_parser->[add_parser],CmdPipelineShow->[_show_ascii->[__build_graph],_show_dependencies_tree->[__build_graph],run->[_show,_show_ascii,_show_dependencies_tree,__write_dot],__write_dot->[__build_graph]]] | Build a graph of nodes edges and whether the pipeline is a tree. | So we are not using `to_stage` here anymore, looks like a bug. |
@@ -36,6 +36,9 @@ class Configuration(object):
# Add the strategy file to use
config.update({'strategy': self.args.strategy})
+ if self.args.strategy_path:
+ config.update({'strategy_path': self.args.strategy_path})
+
# Load Common configuration
config = self._loa... | [Configuration->[_load_common_config->[getLevelName,get,update,basicConfig,info],_load_backtesting_config->[info,get,update],_load_config_file->[critical,_validate_config,info,open,exit,load],load_config->[_load_common_config,_load_backtesting_config,_load_config_file,update,_load_hyperopt_config,info],_validate_config... | Load the configuration file and return the configuration dictionary. | Does this mean the path can also be configured in the settings (which would be great!)? if so, you should also add it in `config_full.json.example` for reference ... |
@@ -10,6 +10,10 @@ class MyModuleGroup < ApplicationRecord
optional: true
has_many :my_modules, inverse_of: :my_module_group, dependent: :nullify
+ scope :active, (lambda do
+ joins(:my_modules).where('my_modules.archived = ?', false).distinct
+ end)
+
def deep_clone_to_experiment(current_use... | [MyModuleGroup->[deep_clone_to_experiment->[deep_clone_to_experiment]]] | Clone the modules from this group and all its children to the given experiment. | Ok cool. Maybe only naming is a bit confused here. This is why I have been confused before and didn't get what I was looking on... We are scoping `my_modules_groups` but on `my_module` condition. What do you think to rename scope to something like `without_archived_modules`... Than `my_moudle_groups.without_archived_mo... |
@@ -53,6 +53,10 @@ def make_install_req_from_link(link, parent):
hashes=parent.hash_options
),
)
+ if ireq.link is None:
+ ireq.link = link
+ # TODO: Handle wheel cache resolution.
+ return ireq
def make_install_req_from_editable(link, parent):
| [ExtrasCandidate->[__ne__->[__eq__]],EditableCandidate->[__init__->[make_install_req_from_editable]],_InstallRequirementBackedCandidate->[dist->[_prepare],__ne__->[__eq__],_prepare->[_prepare_abstract_distribution],get_dependencies->[_get_requires_python_specifier],get_install_requirement->[_prepare]],LinkCandidate->[_... | Make install_req_from_link function for install_req_from_editable. | @uranusjr here is a track to explore. Is it correct that what you want to do here is create a new InstallRequirement that is identical to `parent` except for `link`? In that case it is important that the new ireq preserves parent's `original_link`. |
@@ -70,7 +70,7 @@ public class DefaultPolicyManager implements PolicyManager, Initialisable {
// TODO MULE-11141 - This is the case of a filtered flow. This will eventually go away.
if (flowExecutionResult == null) {
flowExecutionResult =
- Event.builder(sourceEvent).me... | [DefaultPolicyManager->[createOperationPolicy->[getOriginatingFlowName,findOperationParameterizedPolicies,CompositeOperationPolicy,lookupOperationParametersTransformer,isEmpty,createOperationPointcutParameters,execute],initialise->[DefaultSourcePolicyProcessorFactory,InitialisationException,DefaultOperationPolicyProces... | Creates a source policy instance. | would it make sense to have this null payload message as a constant somewhere? i've seen it many tiomes already |
@@ -16,5 +16,10 @@ namespace Microsoft.Xna.Framework.Content.Pipeline
var content = new VideoContent(filename);
return content;
}
+
+ public override VideoContent Import(Stream input, string virtualFilename, ContentImporterContext context)
+ {
+ throw new NotS... | [No CFG could be retrieved] | Override to add a video content. | This isn't ideal; I'm assuming MonoGame expects developers to copy out the video files (and audio files) as-is when compiling content, since the importer doesn't actually import the file into any form of memory structure (VideoContent and AudioContent just store the file path). Alternatively, we could add a `Stream` pr... |
@@ -15,7 +15,14 @@ type SnapshotManager interface {
// snapshot. It provides the step that it intends to execute. Based on that step, BeginMutation
// will record this intent in the global snapshot and return a `SnapshotMutation` that, when ended,
// will complete the transaction.
- BeginMutation() (SnapshotMutat... | [No CFG could be retrieved] | SnapshotManager is responsible for maintaining the in - memory representation of the global . | I don't think that we want this method to have the described semantics. In particular, even failed operations should be committed, even if that implies that no additional data is written to the snapshot. FWIW, I think that I would prefer a single method--end--that accepted a `succeeded bool` or `status resource.Status`... |
@@ -70,7 +70,7 @@ module Engine
corps.each { |corp, _k| corps[corp] = :prev }
end
- @current_actions = []
+ @round.player_actions = []
end
# Returns if a share can be bought via a normal buy actions
| [BuySellParShares->[sell_shares->[can_sell?],can_ipo_any?->[can_buy?],can_buy_any_from_market?->[can_buy?],can_sell_any?->[can_sell?],can_buy_any_from_ipo?->[can_buy?],can_buy_any?->[can_buy_any_from_ipo?,can_buy_any_from_market?],pass!->[pass!],purchasable_companies->[purchasable_companies]]] | Sets the action to prev if there is no action with the key nak. | is this needed? shouldn't the initializer do that? |
@@ -373,6 +373,15 @@ var messageHandler = {
enablePopups: function (enable) {
popupEnabled = enable;
+ },
+
+ /**
+ * Returns true if dialog is opened
+ * false otherwise
+ * @returns {boolean} isOpened
+ */
+ isDialogOpened: function () {
+ return !!$.prompt.getCurrentSt... | [No CFG could be retrieved] | Message handler for the ethernet ethernet message. | Very minor thing. I would rename this to isDialogVisible, which fits better the way we name such methods in general. |
@@ -292,12 +292,12 @@ func (h *Harvester) newLogFileReader() (reader.Reader, error) {
var r reader.Reader
var err error
- fileReader, err := reader.NewLogFile(h.file, readerConfig, h.done)
+ logInput, err := NewLogFile(h.file, readerConfig)
if err != nil {
return nil, err
}
- r, err = reader.NewEncode(fi... | [sendStateUpdate->[sendEvent],newLogFileReader->[newLogFileReaderConfig],close->[sendStateUpdate]] | newLogFileReader returns a new log file reader. | does `LogFile` reader close file handle? Do we have 2 code-pathes potentially closing h.file now? |
@@ -62,9 +62,7 @@ def test_io_set_raw(fnames, tmpdir):
"""Test importing EEGLAB .set files."""
tmpdir = str(tmpdir)
raw_fname, raw_fname_onefile = fnames
- with warnings.catch_warnings(record=True) as w:
- warnings.simplefilter('always')
- # main tests, and test missing event_id
+ wit... | [test_io_set_raw->[round,any,catch_warnings,read_events_eeglab,filter,savemat,copyfile,join,loadmat,raises,enumerate,simplefilter,assert_array_almost_equal,assert_equal,epochs,replace,_test_raw_reader,zeros,range,LooseVersion,SkipTest,assert_array_equal,find_events,len,zip,deepcopy,read_raw_eeglab,random,str,Epochs,arr... | Test import of raw EEGLAB. set files. 80 with - 8 with_raw_eeglab_read_raw_e read_raw_eeglab - > read_raw_eeglab - > test reading of eeglab file with no event - id This function creates a structured array of channel locations and channel locations for a single channel in the read the n - th channel name from set and p... | maybe we could define a regex and use match |
@@ -2,7 +2,7 @@ module Ahoy
class Visit < ApplicationRecord
self.table_name = "ahoy_visits"
- has_many :events, class_name: "Ahoy::Event"
+ has_many :events, class_name: "Ahoy::Event", dependent: :destroy
belongs_to :user, optional: true
end
end
| [Visit->[table_name,has_many,belongs_to]] | Ahoy is a class that can be instantiated by a user. | an event belonging to a visit should be destroyed if the visit gets destroyed |
@@ -582,11 +582,10 @@ class TaskBase(SubsystemClientMixin, Optionable, AbstractClass):
def _report_targets(self, prefix, targets, suffix, logger=None):
logger = logger or self.context.log.info
- logger(
- prefix,
- items_to_report_element([t.address.reference() for t in targets], 'target'),
- ... | [TaskBase->[_build_invalidator->[stable_name],get_passthru_args->[supports_passthru_args,stable_name],invalidate->[_build_invalidator],implementation_version_str->[implementation_version],invoke_prepare->[_scoped_options],_options_fingerprint->[supports_passthru_args],_should_cache_target_dir->[artifact_cache_writes_en... | Reports a list of targets with a critical critical target. | no action needed here. but i'd advise separate functional change away from refactoring in the future. same for other instances. |
@@ -225,8 +225,8 @@ public class SecurityProcessor {
* Handle additional secured classes by adding the denyAll check to all public non-static methods
* that don't have security annotations
*/
- for (ClassInfo additionalSecureClassInfo : additionalSecuredClasses) {
- for (... | [SecurityProcessor->[gatherSecurityAnnotations->[gatherSecurityAnnotations]]] | Gathers all security annotations that are associated with a specific security class. determines if there are any classes that have a security check. | You could have used `values()` here. |
@@ -112,10 +112,11 @@ class Subcommand(metaclass=ABCMeta):
self.parser = parser
args = getattr(self, 'args', ())
for arg in args:
- flags = arg[0]
+ flags, spec = arg
if not isinstance(flags, tuple):
flags = (flags,)
- self.parser... | [Subcommand->[invoke->[NotImplementedError],__init__->[getattr,isinstance,add_argument]],getLogger] | Initialize the subcommand with the parser and arguments. | This could just be `spec.__dict__` |
@@ -35,11 +35,12 @@ public class JettyRequestLog extends AbstractLifeCycle implements RequestLog
{
if (logger.isDebugEnabled()) {
logger.debug(
- "%s %s %s %s",
+ "%s %s %s %s %s",
request.getRemoteAddr(),
request.getMethod(),
request.getHttpURI().toStri... | [JettyRequestLog->[log->[getMethod,debug,getRemoteAddr,toString,isDebugEnabled,getProtocol],Logger]] | Log a failure if the request has a . | the `getStatus` returns type of int, the format specifier here should be `%d` |
@@ -219,6 +219,10 @@ func (b *Boxer) boxMessageV1(ctx context.Context, msg chat1.MessagePlaintextV1,
}
}
+ if len(msg.ClientHeader.TlfName) == 0 {
+ return nil, libkb.ChatBoxingError{Msg: fmt.Sprintf("blank TLF name received: original: %s canonical: %s", tlfName, msg.ClientHeader.TlfName)}
+ }
+
if recentKey ... | [verifyMessage->[NewChatHeaderVersionError,Version,verifyMessageHeaderV1,V1],verify->[Verify],boxMessageWithKeysV1->[NewBodyPlaintextWithV1,hashV1,signMarshal,seal,NewHeaderPlaintextWithV1],unmarshal->[Decode,NewDecoderBytes],UnboxMessage->[unboxMessageWithKey,Sprintf,Error,Find],unboxMessageWithKey->[verifyMessage,New... | boxMessageV1 takes a chat1. MessagePlaintextV1 and a signing keypair. | Actually on a second thought, this should never happen as long as the RPC call to kbfs works as expected. Otherwise, it would just either fail at the `len(tlfName)` check above, or one of the error checks for kbfs rpc calls. Did you see this happening? |
@@ -125,6 +125,7 @@ export const StateProperty = {
SYSTEM_UI_IS_VISIBLE_STATE: 'systemUiIsVisibleState',
TOOLTIP_ELEMENT: 'tooltipElement',
UI_STATE: 'uiState',
+ EXPAND_COMPONENT: 'expandComponent',
// App data.
ACTIONS_WHITELIST: 'actionsWhitelist',
| [No CFG could be retrieved] | Enumerate all App - related actions. This function is used to register all actions that are allowed to be performed. | Super nitty: `EXPAND_COMPONENT` sounds like an action, when it's really a state that some other component is going to react to. It doesn't really matter, but I think `EXPANDED_COMPONENT` would make more sense, especially if ever need to do something like `storeService.get(EXPANDED_COMPONENT)`. |
@@ -1265,6 +1265,7 @@ class App {
* @return bool Is it a known backend?
*/
function is_backend() {
+ /// @Should be made static to speedup things
$backend = array();
$backend[] = "_well_known";
$backend[] = "api";
| [get_temppath->[get_hostname],get_guid->[get_hostname],login->[get_baseurl],killme->[is_backend],proc_run->[proc_run],App->[get_useragent->[get_baseurl],maxload_reached->[is_backend],max_processes_reached->[is_backend],init_pagehead->[get_baseurl],remove_baseurl->[remove_baseurl,get_baseurl],proc_run->[get_baseurl],get... | Check if the module is a backend. | Wait, you changed it from static to this, you just have to revert your own changes! |
@@ -0,0 +1,4 @@
+from .OrderEvent import OrderEvent
+
+__all__ = [
+ "OrderEvent"]
| [No CFG could be retrieved] | No Summary Found. | Is there really a need for separate files for each model? I think we won't have that many of them. Let's think of such improvements when there is really an identified problem. Also, the `OrderEvents.py` filename doesn't follow the naming convention for Python modules that we use. |
@@ -333,8 +333,8 @@ class Git(Base):
# /en/2.1.11/reference.html#git.objects.base.Object.__str__
commits.append(a_commit)
commits.append(b_commit)
- trees[DIFF_A_TREE] = self.get_tree(commits[0])
- trees[DIFF_B_TREE] = self.get_tree(commits[1])
+ t... | [Git->[_verify_dvc_hooks->[_verify_hook],is_dirty->[is_dirty],track_file->[add],ignore->[_ignored,_get_gitignore],install->[_install_hook],cleanup_ignores->[ignore_remove],commit->[commit],get_diff_trees->[_get_diff_trees],checkout->[checkout],branch->[branch],_get_diff_trees->[get_tree],tag->[tag],add->[add],close->[c... | Private method for getting the trees and commit hashes of two git tag references. Returns the d Diff_Dct = True if the node in commits is not a node in trees. | SCM code should not know anything about clean trees. |
@@ -4760,10 +4760,11 @@ def matmul(x, y, transpose_x=False, transpose_y=False, alpha=1.0, name=None):
if x_shape[-1] != y_shape[-2]:
raise ValueError("Invalid inputs for matmul.")
- if len(y_shape) > 2:
+ if len(y_shape) > 2 and len(x_shape) > 2:
for i, dim_x in enumer... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],nce->[_init_by_numpy_array],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d... | Applies matrix multiplication to two tensors. Matrix - wise cross product of two variables. Compute the missing element in the cross product between two matrices. | If the len(y_shape) and `len(x_shape) > 2` are equal, the value of `y_shape[0:-2]` and `x_shape[0:-2]` should be equal. |
@@ -60,12 +60,15 @@ public class TestLayoutComponent extends NXRuntimeTestCase {
private WebLayoutManager service;
- @Before
+ @Override
public void setUp() throws Exception {
- super.setUp();
deployBundle("org.nuxeo.ecm.platform.forms.layout.core");
deployContrib("org.nuxeo... | [TestLayoutComponent->[testComplexLayoutRegistration->[assertNotNull,getName,getWidgetDefinition,getLayoutDefinition,getSchemaName,assertNull,getRows,getType,getFieldDefinitions,getFieldName,getColumns,getSubWidgetDefinitions,getWidgetReferences,assertEquals],testLayoutSubWidgetsRegistration->[assertNotNull,getName,get... | This method is called before the layout is initialized. Checks that the widget s title and subjects are all equal. Checks if there are any items in the list. | Use of `deployContrib` with a test contribution |
@@ -180,4 +180,18 @@ class Test_Jetpack_Admin_Menu extends WP_UnitTestCase {
);
$this->assertContains( $customize_submenu_item, $submenu[ $slug ] );
}
+
+ /**
+ * Tests add_plugins_menu
+ *
+ * @covers ::add_plugins_menu
+ */
+ public function test_add_plugins_menu() {
+ global $menu;
+
+ static::$admin_m... | [Test_Jetpack_Admin_Menu->[test_add_tools_menu->[add_tools_menu,assertContains],test_add_appearance_menu->[assertContains,add_appearance_menu],wpSetUpBeforeClass->[create,get_site_suffix],test_add_wp_admin_menu->[add_wp_admin_menu,assertSame],test_add_jetpack_menu->[assertContains,add_jetpack_menu]]] | Test add appearance menu. | Do we need an assertion to check that when `add_plugins_menu` is given `false`? |
@@ -25,9 +25,9 @@ module Engine
super
end
- def upgraded_track(_from, to, _hex)
+ def track_upgrade?(_from, to, _hex)
# this also takes care of adding small stations, since that is never yellow to yellow
- @round.upgraded_track = true if to.color != :y... | [Track->[legal_tile_rotation?->[neighbors,all?,max,size,adding_town?,include?,tile,flatten,exits,map],actions->[receivership?,skip_round,corporation?,lner],available_hex->[hex_neighbors,size,get_tile_lay,zero?,include?,color,id],upgraded_track->[to_s,upgraded_track,color],lay_tile_action->[raise,entity,to_s,get_tile_la... | This is a hack to handle the case where a tile is not in the game. | why are you changing other games? |
@@ -1,6 +1,6 @@
# pylint: disable=unused-import
import warnings
-from allennlp.predictors.predictor import Predictor, DemoModel, DEFAULT_PREDICTORS
+from allennlp.predictors.predictor import Predictor, DEFAULT_PREDICTORS
warnings.warn("allennlp.service.predictors.* has been deprecated."
" Please use... | [warn] | Deprecated. Use allennlp. service. predictors. Predictor instead. | Leave the DemoModel import here (change it to it's new location) to preserve backwards compatibility |
@@ -23,7 +23,7 @@ if __name__ == "__main__":
parser = ArgumentParser("enas")
parser.add_argument("--batch-size", default=128, type=int)
parser.add_argument("--log-frequency", default=10, type=int)
- parser.add_argument("--search-for", choices=["macro", "micro"], default="macro")
+ # parser.add_argu... | [train,parameters,add_argument,get_dataset,ArchitectureCheckpoint,ArgumentParser,parse_args,getLogger,CrossEntropyLoss,MicroNetwork,EnasTrainer,EnasMutator,enable_visualization,LRSchedulerCallback,SGD,CosineAnnealingLR,GeneralNetwork] | Creates a model object from a given network. Creates a CosineAnnealingLR model. | Revert changes to example. |
@@ -380,6 +380,9 @@ class Padding(Preprocessor):
),
'use_numpy': BoolField(
optional=True, default=False, description="Allow to use numpy for padding instead default OpenCV."
+ ),
+ 'numpy_pad_mode': StringField(
+ optional=True, default='c... | [Crop3D->[process->[process_data->[],setdefault,crop_center,GeometricOperationMetadata],crop_center->[min,max],parameters->[NumberField,super,update],configure->[get_size_3d_from_config]],Crop->[process->[process_data->[fromarray,round,int,resize,GeometricOperationMetadata,tuple,setdefault,ceil,array],process_data,isin... | Return a dictionary of parameters for the OpenCV model. | it makes sense to have the list of possible values for this parameter. please specify it with `choices` argument |
@@ -606,10 +606,12 @@ class Jetpack_Carousel {
! preg_match( '/wp-block-jetpack-slideshow_image/', $image_html ) ) {
$attachment_id = absint( $class_id[2] );
/**
- * If exactly the same image tag is used more than once, overwrite it.
- * All identical tags will be replaced later with 'str_replace... | [Jetpack_Carousel->[carousel_display_comments_callback->[settings_checkbox],carousel_display_geo_callback->[settings_checkbox],carousel_display_geo_sanitize->[sanitize_1or0_option],carousel_enable_it_callback->[settings_checkbox],carousel_enable_it_sanitize->[sanitize_1or0_option],carousel_display_comments_sanitize->[s... | Add data img tags and enqueue assets This function is called to add attributes to the content of the tag. | PHPCS is complaining that `in_array (` has a gap between the function name and the parenthesis, and that `in_array` isn't providing `true` as its third argument. |
@@ -1595,7 +1595,7 @@ namespace System.Net.Sockets
if (NetEventSource.IsEnabled) NetEventSource.Info(this, $"SRC:{LocalEndPoint} DST:{RemoteEndPoint}");
int bytesTransferred;
- errorCode = SocketPal.Receive(_handle, buffers, ref socketFlags, out bytesTransferred);
+ err... | [Socket->[DoBeginSendTo->[SocketError],SetIPProtectionLevel->[SetIPProtectionLevel],SetLingerOption->[SetLingerOption],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanUseConnectEx,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],... | Receive a block of data from the socket. | This didn't have to be a `ref`, so I removed it. |
@@ -535,6 +535,12 @@ def generate_list_gateways_payload(
return json.dumps(payload)
+def _generate_payload_for_shipping_method(method: ShippingMethod):
+ payload = asdict(method)
+ payload["id"] = graphene.Node.to_global_id("ShippingMethod", payload["id"])
+ return payload
+
+
def generate_excluded_s... | [generate_sample_payload->[generate_product_payload,_generate_sample_order_payload,_get_sample_object,generate_fulfillment_payload,generate_customer_payload,_remove_token_from_checkout,generate_page_payload,generate_checkout_payload],generate_product_payload->[serialize_product_channel_listing_payload],_generate_sample... | Generate a JSON payload that includes the order data and the excluded shipping methods. | Change 1: Conversion from the Django type to the GraphQL type when serialising the webhook payload. |
@@ -141,7 +141,7 @@ class Adagrad(optimizer_v2.OptimizerV2):
An optimizer instance.
"""
if 'initial_accumulator_value' not in config:
- config['initial_accumulator_value'] = 0.
+ config['initial_accumulator_value'] = 0.1
if 'lr' in config:
config['learning_rate'] = config.pop('l... | [Adagrad->[_resource_apply_dense->[,resource_apply_adagrad_v2,get_slot,_fallback_apply_state],from_config->[cls,pop],set_weights->[super,array,len],_resource_apply_sparse->[,get_slot,_fallback_apply_state,resource_sparse_apply_adagrad_v2],_prepare_local->[apply_state,dict,convert_to_tensor_v2,super,zeros],_create_slots... | Creates an optimizer from its config. | Were was the 0.1 default set for other types? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.