patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -21,6 +21,8 @@ namespace System.Linq.Expressions.Interpreter
public override string InstructionName => "DefaultValue";
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2077:UnrecognizedReflectionPattern",
+ Justification = "_type is a ValueType. You can always create an instance of a ValueType.")]
public override int Run(InterpretedFrame frame)
{
frame.Push(Activator.CreateInstance(_type));
| [DefaultValueInstruction->[Run->[CreateInstance,Push],IsNullableType,Assert,IsValueType]] | This method is called when the frame is not empty. | Note: this usage of `Activator.CreateInstance` and the ones below in LocalAccess.cs should be changed to `GetUninitializedObject` with #45397. |
@@ -45,7 +45,7 @@ type PachdFullConfiguration struct {
type PachdSpecificConfiguration struct {
StorageConfiguration
NumShards uint64 `env:"NUM_SHARDS,default=32"`
- StorageBackend string `env:"STORAGE_BACKEND,default="`
+ StorageBackend string `env:"STORAGE_BACKEND,default=LOCAL"`
StorageHostPath string `env:"STORAGE_HOST_PATH,default="`
EtcdPrefix string `env:"ETCD_PREFIX,default="`
PFSEtcdPrefix string `env:"PFS_ETCD_PREFIX,default=pachyderm_pfs"`
| [No CFG could be retrieved] | Assigns the configuration of a specific pachd instance to the global pachd configuration. Required environment variables for missing values. | I don't think it's helpful to have this default. It seems like when this is not set, it is better to error than silently switch to local. |
@@ -33,7 +33,7 @@ module Idv
def reset_doc_auth
user_session.delete('idv/doc_auth')
- user_session['idv'] = { params: {}, step_attempts: { phone: 0 } }
+ user_session['idv'] = {}
end
def cancel_document_capture_session
| [CancellationsController->[new->[call,merge,hybrid_session?,track_event],document_capture_session->[find_by],location_params->[symbolize_keys],reset_doc_auth->[delete],destroy->[track_event,return_to_sp_failure_to_proof_path,clear,hybrid_session?],cancel_document_capture_session->[now,update],before_action,include]] | reset the user session and cancel any pending document capture session. | I think we may want to leave this default setting thing in to keep things smooth during a deploy, with old servers expecting data in the session hash, and new servers ignoring it then follow up with another PR to drop it next deploy |
@@ -507,3 +507,15 @@ func (c *NameLookupCache) DeleteBranch(op trace.Operation, img *image.Image, kee
return deletedImages, nil
}
+
+func (c *NameLookupCache) ImageStorageUsage() int64 {
+ c.storeCacheLock.Lock()
+ defer c.storeCacheLock.Unlock()
+ return c.imageStorageUsage
+}
+
+func (c *NameLookupCache) SetImageStorageUsage(value int64) {
+ c.storeCacheLock.Lock()
+ defer c.storeCacheLock.Unlock()
+ c.imageStorageUsage = value
+}
| [Owners->[Owners],ListImages->[GetImage,GetImageStore],GetImage->[GetImage,GetImageStore],DeleteBranch->[GetImage,DeleteImage],URL->[URL],Import->[Import],DeleteImage->[GetImage,DeleteImage],GetImageStore->[isRetry,GetImageStore],WriteImage->[WriteImage],Export->[Export],NewDataSource->[NewDataSource],CreateImageStore->[CreateImageStore,GetImageStore]] | DeleteBranch deletes a branch from the cache. DeleteBranch deletes all images in the branch that are not the scratch layer. | Rename to GetImageStorageUsage? |
@@ -132,7 +132,7 @@ def test_spam_no_permission(
)
# Redirects to login page when without permission.
assert response.status_code == 302
- assert response["Location"].endswith("users/signin?next={}".format(url))
+ assert response["Location"].endswith(f"{reverse(settings.LOGIN_URL)}?next={url}")
assert_no_cache_header(response)
# No RevisionAkismetSubmission record should exist.
| [akismet_wiki_user->[add],enable_akismet_submissions->[override_flag],test_spam_valid_response->[get,assert_no_cache_header,len,post,reverse,loads],akismet_mock_requests->[encode,post],permission_add_revisionakismetsubmission->[get],test_spam_with_many_response->[RevisionAkismetSubmission,assert_no_cache_header,len,post,filter,reverse,save,loads,count],test_spam_revision_does_not_exist->[count,assert_no_cache_header,post,filter,reverse,delete],test_disallowed_methods->[reverse,getattr,assert_no_cache_header],akismet_wiki_user_2->[add],test_spam_no_permission->[assert_no_cache_header,post,filter,response,format,reverse,count],parametrize] | Test spam of a specific . | Instead of messing with `settings.MULTI_AUTH_ENABLED` in this unimportant test, how about we just using `settings.LOGIN_URL` correctly? |
@@ -196,6 +196,14 @@ func (s *storeTestSuite) TestStore(c *C) {
limit2 = leaderServer.GetRaftCluster().GetStoreLimitByType(2, storelimit.RemovePeer)
c.Assert(limit2, Equals, float64(25))
+ // store limit all <key> <value> <rate> <type>
+ args = []string{"-u", pdAddr, "store", "limit", "all", "zone", "uk", "20", "remove-peer"}
+ _, output, err = pdctl.ExecuteCommandC(cmd, args...)
+ c.Log(string(output))
+ c.Assert(err, IsNil)
+ limit1 = leaderServer.GetRaftCluster().GetStoreLimitByType(1, storelimit.RemovePeer)
+ c.Assert(limit1, Equals, float64(20))
+
// store limit all 0 is invalid
args = []string{"-u", pdAddr, "store", "limit", "all", "0"}
_, output, err = pdctl.ExecuteCommandC(cmd, args...)
| [TestStore->[MustPutStore,GetConfig,GetClientURL,GetStoreLimitByType,GetRaftCluster,GetServer,GetEcho,Assert,Destroy,InitCommand,Contains,DefaultScene,ExecuteCommandC,BootstrapCluster,WaitLeader,Background,WithCancel,Unmarshal,RunInitialServers,NewTestCluster,CheckStoresInfo,GetLeader]] | TestStore tests store state ExecuteCommandC - execute a command that does not return an error. - u label label1 label1. Value label1. Key label1. Value label RaftCluster limits commands RaftCluster. GetStoreLimitByType - gets store limit by type This function checks that all the command - line options are met. | can we add a simpler command for TiFlash? cc @rleungx |
@@ -79,8 +79,8 @@ func init() {
}
}
-func New(b *beat.Beat, rawConfig *common.Config) (beat.Beater, error) {
- config := config.Config{
+func initialConfig() config.Config {
+ return config.Config{
Interfaces: config.InterfacesConfig{
File: *cmdLineArgs.file,
Loop: *cmdLineArgs.loop,
| [setupFlows->[IsEnabled,ConnectWith,NewFlows,New],Stop->[Info,Stop],init->[setupFlows,setupSniffer,Error,Critical,NewTransactionPublisher,Init,Errorf,Info,Debug],createWorker->[NewTCP,NewUDP,New,CreateReporter,Enabled,icmpConfig],icmpConfig->[New,Enabled,Unpack],setupSniffer->[BpfFilter,New,IsEnabled,Enabled,icmpConfig],Run->[Done,Stop,Wait,Duration,Start,Errorf,Sleep,Run,Add,ProfileEnabled,Debug],Unpack,Int,init,String,Err,Bool] | New - returns new instance of the beat object init - creates a packetbeat object. | Could the changes on packetbeat move to its own independent PR to decouple it from adding it to the agent? |
@@ -32,9 +32,13 @@ class ServiceProviderSessionDecorator # rubocop:disable Metrics/ClassLength
def sp_msg(section, args = {})
args = args.merge(sp_name: sp_name)
args = args.merge(sp_create_link: sp_create_link)
- return t("service_providers.#{sp_alert_name}.#{section}", args) if custom_alert?
-
- t("service_providers.default.#{section}", args)
+ if custom_alert?(section) && !FeatureManagement.use_dashboard_service_providers?
+ SP_CONFIG[sp.issuer]&.dig("help_text")&.dig(I18n.locale.to_s)&.dig(section) % args
+ elsif custom_alert?(section) && FeatureManagement.use_dashboard_service_providers?
+ sp.help_text[section][I18n.locale.to_s] % args
+ else
+ t("service_providers.help_text.default.#{section}", args)
+ end
end
def sp_logo
| [ServiceProviderSessionDecorator->[failure_to_proof_url->[failure_to_proof_url]]] | Returns the message for the alert or the logo if no alert is configured. | You can call `dig` with multiple arguments, i.e., `SP_CONFIG[sp.issuer]&.dig("help_text", I18n.locale.to_s, section)` |
@@ -302,4 +302,12 @@ public class StreamerUtil {
long oldTime = Long.parseLong(oldInstant);
return String.valueOf(oldTime + milliseconds);
}
+
+ /**
+ * Subtract the old instant time with given milliseconds and returns.
+ * */
+ public static String instantTimeSubtract(String oldInstant, long milliseconds) {
+ long oldTime = Long.parseLong(oldInstant);
+ return String.valueOf(oldTime - milliseconds);
+ }
}
| [StreamerUtil->[getHoodieClientConfig->[getHoodieClientConfig],getSourceSchema->[getSourceSchema],createWriteClient->[getHadoopConf,getHoodieClientConfig],getTablePath->[getTablePath],initTableIfNotExists->[getHadoopConf],getHadoopConf->[getHadoopConf]]] | Instant time plus milliseconds. | Remove this method. |
@@ -388,6 +388,17 @@ ActiveRecord::Schema.define(version: 2020_02_24_153122) do
t.datetime "updated_at", null: false
end
+ create_table "email_authorizations", force: :cascade do |t|
+ t.datetime "created_at", null: false
+ t.jsonb "json_data", default: {}, null: false
+ t.string "type_of", null: false
+ t.datetime "updated_at", null: false
+ t.bigint "user_id"
+ t.datetime "verified_at"
+ t.index ["user_id", "type_of"], name: "index_email_authorizations_on_user_id_and_type_of", unique: true
+ t.index ["user_id"], name: "index_email_authorizations_on_user_id"
+ end
+
create_table "events", force: :cascade do |t|
t.string "category"
t.string "cover_image"
| [jsonb,bigint,decimal,text,string,add_foreign_key,datetime,integer,enable_extension,create_table,float,boolean,index,define,inet] | Create a table with the properties of the object Table for the messages. | ...not sure if this last index should be here? |
@@ -472,8 +472,14 @@ class OutputTimer(object):
class FnApiUserStateContext(userstate.UserStateContext):
"""Interface for state and timers from SDK to Fn API servicer of state.."""
- def __init__(
- self, state_handler, transform_id, key_coder, window_coder, timer_specs):
+ def __init__(self,
+ state_handler,
+ transform_id, # type: str
+ key_coder, # type: coders.Coder
+ window_coder, # type: coders.Coder
+ timer_specs # type: MutableMapping[str, beam_runner_api_pb2.TimerSpec]
+ ):
+ # type: (...) -> None
"""Initialize a ``FnApiUserStateContext``.
Args:
| [CombiningValueRuntimeState->[_commit->[_commit],read->[_read_accumulator],add->[_read_accumulator,add],clear->[clear]],BundleProcessor->[monitoring_infos->[monitoring_infos,inject_pcollection],metrics->[progress_metrics],reset->[reset],create_execution_tree->[topological_height->[topological_height],get_operation->[get_operation],is_side_input,get_operation],finalize_bundle->[finalize_bundle],process_bundle->[set_output_stream,process_encoded,start,finish],try_split->[try_split,add],_fix_output_tags->[fix_only_output_tag->[only_element],fix_only_output_tag]],SynchronousBagRuntimeState->[read->[_StateBackedIterable,_ConcatIterable],_commit->[clear]],StateBackedSideInputMap->[__getitem__->[MultiMap->[],MultiMap,_StateBackedIterable]],BeamTransformFactory->[get_only_output_coder->[get_output_coders,only_element],get_output_coders->[get_windowed_coder],get_input_coders->[get_windowed_coder],__init__->[_StateBackedIterable],get_only_input_coder->[get_input_coders,only_element],get_windowed_coder->[get_coder]],create->[WindowIntoDoFn,augment_oldstyle_op,get_coder,only_element,TimerConsumer,get_only_output_coder,DataInputOperation,MapWindows,_create_simple_pardo_operation,get_only_input_coder,DataOutputOperation],_create_combine_phase_operation->[get_only_output_coder,augment_oldstyle_op],FnApiUserStateContext->[commit->[_commit],_create_state->[CombiningValueRuntimeState,SynchronousSetRuntimeState,SynchronousBagRuntimeState],get_timer->[OutputTimer]],_create_pardo_operation->[augment_oldstyle_op,StateBackedSideInputMap,get_output_coders,mutate_tag,get_input_coders,FnApiUserStateContext,set,get_windowed_coder],_create_simple_pardo_operation->[_create_pardo_operation],SynchronousSetRuntimeState->[_compact_data->[_StateBackedIterable,_ConcatIterable,clear],read->[_compact_data],add->[_compact_data,add,clear],_commit->[clear]],register_urn] | Initialize a new object of type NestedContext. | Is it Mutable at this point? |
@@ -112,7 +112,7 @@ namespace Internal.JitInterface
table.Add(CorInfoIntrinsics.CORINFO_INTRINSIC_GetRawHandle, "AllocatorOf", "System", "Activator");
// If this assert fails, make sure to add the new intrinsics to the table above and update the expected count below.
- Debug.Assert((int)CorInfoIntrinsics.CORINFO_INTRINSIC_Count == 34, "Please update intrinsic hash table");
+ Debug.Assert((int)CorInfoIntrinsics.CORINFO_INTRINSIC_Count == 32, "Please update intrinsic hash table");
return table;
}
| [CorInfoImpl->[IntrinsicKey->[GetHashCode->[GetHashCode]],IntrinsicHashtable->[GetValueHashCode->[GetHashCode],CompareValueToValue->[Equals],CompareKeyToValue->[Equals],GetKeyHashCode->[GetHashCode],Add]]] | Initialize IntrinsicHashtable. Adds the methods of the interfaces that are intrinsics to the table. Private method to add the intrinsics to the hash table. | I think it would better to just delete this assert. It made sense when this was a separate project in CoreRT. It is not the case anymore. |
@@ -30,7 +30,7 @@ const successAlert = (
<Translate contentKey="activate.messages.success">
<strong>Your user account has been activated.</strong> Please
</Translate>
- <Link to="/login" className="alert-link">
+ <Link to="/account/login" className="alert-link">
<Translate contentKey="global.messages.info.authenticated.link">sign in</Translate>
</Link>.
</Alert>
| [No CFG could be retrieved] | This file is part of the JHipster project. It is exported to a file Show activation action. | Lets not add the `account` path prefix to `login` route path. |
@@ -28,7 +28,7 @@ public class LogReaderTest {
public void testStreamSplittingArray() throws Exception {
final LogReader reader = new LogReader(stream, area, Boolean.TRUE::booleanValue, console);
final String testString = "Some Test String";
- final byte[] testByteArray = testString.getBytes();
+ final byte[] testByteArray = testString.getBytes(Charset.defaultCharset());
reader.getStream().write(testByteArray);
verify(stream).write(testByteArray, 0, testByteArray.length);
SwingUtilities.invokeAndWait(() -> verify(area).append(testString));
| [LogReaderTest->[testConsolePopup->[getBytes,setVisible,write,invokeAndWait],testStreamSplittingInt->[LogReader,codePointAt,write,append,invokeAndWait],testStreamSplittingArray->[LogReader,write,append,getBytes,invokeAndWait],testWriteInvisible->[LogReader,write,append,getBytes,invokeAndWait]]] | Test stream splitting array. | I used the default charset in this test fixture because the target stream is always wrapped in a `PrintStream` (in `GenericConsole`), which hard-codes usage of the default charset. |
@@ -261,7 +261,13 @@ public final class LdapServiceRegistryDao implements ServiceRegistryDao {
* @return true, if successful
*/
private boolean hasResults(final Response<SearchResult> response) {
- return response.getResult() != null && response.getResult().getEntry() != null;
+ if (response.getResult() != null && response.getResult().getEntry() != null) {
+ return true;
+ }
+
+ logger.trace("Requested ldap operation did not return a result or an ldap entry. Code: {}, Message: {}",
+ response.getResultCode(), response.getMessage());
+ return false;
}
/**
| [LdapServiceRegistryDao->[init->[getIdAttribute,getObjectClass],findServiceById->[mapToRegisteredService,getMessage,error,getEntry,searchForServiceById,hasResults,closeConnection,getConnection],searchForServiceById->[setParameter,executeSearchOperation,SearchFilter],update->[getMessage,error,AttributeModification,toArray,ModifyOperation,add,searchForServiceById,hasResults,closeConnection,ModifyRequest,getConnection,getBaseDn,getId,getAttributes,mapFromRegisteredService,getDn,execute],hasResults->[getEntry,getResult],newRequest->[getDerefAliases,setSizeLimit,getBinaryAttributes,setFollowReferrals,getSearchReferenceHandlers,getFollowReferrals,getSortBehavior,setSearchEntryHandlers,setTypesOnly,getReturnAttributes,SearchRequest,setSearchReferenceHandlers,getTypesOnly,setDerefAliases,getBaseDn,getSearchScope,setReturnAttributes,setTimeLimit,getTimeLimit,getControls,setBinaryAttributes,setSearchScope,getSearchEntryHandlers,setControls,getSizeLimit,setSortBehavior],executeSearchOperation->[debug,newRequest,toString,SearchOperation,execute],save->[getMessage,error,AddRequest,update,closeConnection,getConnection,getBaseDn,getId,getAttributes,AddOperation,mapFromRegisteredService,getDn,execute],load->[mapToRegisteredService,getMessage,error,SearchFilter,getEntries,hasResults,closeConnection,getConnection,add,executeSearchOperation],delete->[getResultCode,DeleteRequest,getMessage,error,DeleteOperation,getEntry,searchForServiceById,hasResults,closeConnection,getConnection,getId,getDn,execute],DefaultLdapServiceMapper,getLogger,getClass]] | Returns true if the response contains a result. | Maybe I would create an temporary property `result = response.getResult()`. |
@@ -79,11 +79,10 @@ Rails.application.routes.draw do
delete '/openid_connect/authorize' => 'openid_connect/authorization#destroy',
as: :openid_connect_deny
- get '/openid_connect/certs' => 'openid_connect/certs#index'
-
- post '/openid_connect/token' => 'openid_connect/token#create'
-
- get '/openid_connect/userinfo' => 'openid_connect/user_info#show'
+ get '/openid_connect/certs' => 'openid_connect/certs#index', as: :old_openid_connect_certs
+ post '/openid_connect/token' => 'openid_connect/token#create', as: :old_openid_connect_token
+ get '/openid_connect/userinfo' => 'openid_connect/user_info#show',
+ as: :old_openid_connect_userinfo
get '/otp/send' => 'users/two_factor_authentication#send_code'
get '/phone_setup' => 'users/two_factor_authentication_setup#index'
| [draw,namespace,new,root,match,get,post,devise_scope,mount,put,patch,devise_for,require,enable_test_routes,delete] | Route to view a user s password. links to sign - up page. | What is the purpose of making this change backwards compatible? Since we haven't launched yet, can't we tell any clients that might be using the old endpoints to use the new endpoints? |
@@ -7,7 +7,7 @@
'dsn' => 'mysql:host=127.0.0.1;dbname=installer',
'username' => 'root',
'password' => 'root',
- 'charset' => 'utf8',
+ 'charset' => 'utf8mb4',
),
'user' =>
array (
| [No CFG could be retrieved] | Return an array of all known components. | @rabuzarus where is this file needed for? |
@@ -845,6 +845,16 @@ namespace System.Windows.Forms
protected virtual void OnItemCheck(ItemCheckEventArgs ice)
{
_onItemCheck?.Invoke(this, ice);
+
+ if (IsAccessibilityObjectCreated)
+ {
+ AccessibleObject checkedItem = AccessibilityObject.GetChild(ice.Index);
+
+ if (checkedItem is not null)
+ {
+ checkedItem.RaiseAutomationPropertyChangedEvent(UiaCore.UIA.ToggleToggleStatePropertyId, ice.CurrentValue, ice.NewValue);
+ }
+ }
}
protected override void OnMeasureItem(MeasureItemEventArgs e)
| [CheckedListBox->[WmReflectCommand->[WmReflectCommand,LbnSelChange],OnBackColorChanged->[OnBackColorChanged],OnFontChanged->[OnFontChanged],OnSelectedIndexChanged->[OnSelectedIndexChanged],OnMeasureItem->[OnMeasureItem],LbnSelChange->[InvalidateItem],SetItemCheckState->[InvalidateItem,OnItemCheck],RefreshItems->[RefreshItems],WndProc->[WmReflectVKeyToItem,GetItemChecked,WndProc,SetItemChecked],OnKeyPress->[LbnSelChange,OnKeyPress],OnClick->[OnClick],OnHandleCreated->[OnHandleCreated],SetItemChecked->[SetItemCheckState]]] | onItemCheck is called when an item is checked. | Can the `checkedItem` variable be `null`? |
@@ -11,9 +11,8 @@ $guid = get_input('guid');
$page = get_entity($guid);
if (pages_is_page($page)) {
// only allow owners and admin to delete
- if (elgg_is_admin_logged_in() || elgg_get_logged_in_user_guid() == $page->getOwnerGuid()) {
- $container = get_entity($page->container_guid);
-
+ $container = get_entity($page->container_guid);
+ if (elgg_is_admin_logged_in() || elgg_get_logged_in_user_guid() == $page->getOwnerGuid()||(elgg_instanceof($container, 'group')&& $container->canEdit())) {
// Bring all child elements forward
$parent = $page->parent_guid;
$children = elgg_get_entities_from_metadata(array(
| [getGUID,getOwnerGuid,getURL,delete] | Remove a page or children from a page tree Get the URL of the page that can be deleted. | This logic looks right but should be moved to a function like pages_can_delete_page(). We should also not assume we can load the container. I think `$container->canEdit()` will simplify this, too. |
@@ -1131,6 +1131,10 @@ inline void tmc_standby_setup() {
* - Set Marlin to RUNNING State
*/
void setup() {
+ #ifdef HAL_STM32
+ FastIO_init();
+ #endif
+
#ifdef BOARD_PREINIT
BOARD_PREINIT(); // Low-level init (before serial init)
#endif
| [No CFG could be retrieved] | Setup - Sets up a single host - specific . - - - - - - - - - - - - - - - - - -. | we can have FASTIO_INIT macro pointing to `FastIO_init` function and use `#TERN_(FASTIO_INIT, FASTIO_INIT())`, so any hal can define it in the future |
@@ -363,7 +363,7 @@ public interface ActiveMQMessageBundle {
ActiveMQSessionCreationException sessionLimitReached(String username, int limit);
@Message(id = 229111, value = "Too many queues created by user ''{0}''. Queues allowed: {1}.", format = Message.Format.MESSAGE_FORMAT)
- ActiveMQSessionCreationException queueLimitReached(String username, int limit);
+ ActiveMQSecurityException queueLimitReached(String username, int limit);
@Message(id = 229112, value = "Cannot set MBeanServer during startup or while started")
IllegalStateException cannotSetMBeanserver();
| [getBundle] | Too many queues created by user. Queues are not allowed. | before anyone asks.. this was supposed to be a SecurityException :) |
@@ -73,13 +73,14 @@ def test_force_anonymous_session_middleware(rf, settings):
def test_restricted_endpoints_middleware(rf, settings):
settings.ATTACHMENT_HOST = 'demos'
settings.ENABLE_RESTRICTIONS_BY_HOST = True
+ settings.ALLOWED_HOSTS.append('demos')
middleware = RestrictedEndpointsMiddleware()
request = rf.get('/foo', HTTP_HOST='demos')
middleware.process_request(request)
assert request.urlconf == 'kuma.urls_untrusted'
- request = rf.get('/foo', HTTP_HOST='not-demos')
+ request = rf.get('/foo', HTTP_HOST='testserver')
middleware.process_request(request)
assert not hasattr(request, 'urlconf')
| [test_slash_middleware_removes_slash->[response,get],test_restricted_whitenoise_middleware->[RestrictedWhiteNoiseMiddleware,object,get,process_request],test_restricted_endpoints_middleware->[get,hasattr,RestrictedEndpointsMiddleware,process_request],test_slash_middleware_adds_slash->[response,get],test_legacy_domain_redirects_middleware->[LegacyDomainRedirectsMiddleware,get,process_request],test_slash_middleware_retains_querystring->[response,get],test_set_remote_addr_from_forwarded_for->[RequestFactory,SetRemoteAddrFromForwardedFor,get,process_request],test_slash_middleware_keep_404->[get],test_force_anonymous_session_middleware->[ForceAnonymousSessionMiddleware,process_response,get,MagicMock,process_request],parametrize] | Test that the restricted_endpoints_middleware is not used in the context of the request. | I dont know, if we can set `*` while tests! |
@@ -3206,8 +3206,13 @@ class Grunion_Contact_Form_Field extends Crunion_Contact_Form_Shortcode {
$field_label = $this->get_attribute( 'label' );
$field_required = $this->get_attribute( 'required' );
$field_placeholder = $this->get_attribute( 'placeholder' );
+ $field_width = $this->get_attribute( 'width' );
$class = 'date' === $field_type ? 'jp-contact-form-date' : $this->get_attribute( 'class' );
+ if ( ! empty( $field_width ) ) {
+ $class .= 'grunion-field-width-' . $field_width;
+ }
+
/**
* Filters the "class" attribute of the contact form input
*
| [Grunion_Contact_Form_Plugin->[download_feedback_as_csv->[get_export_data_for_posts],_internal_personal_data_exporter->[get_post_content_for_csv_export,get_parsed_field_contents_of_post,get_post_meta_for_csv_export,map_parsed_field_contents_of_post_to_field_names],get_export_data_for_posts->[get_post_content_for_csv_export,get_parsed_field_contents_of_post,get_post_meta_for_csv_export,map_parsed_field_contents_of_post_to_field_names],widget_shortcode_hack->[add_shortcode]],Crunion_Contact_Form_Shortcode->[__toString->[esc_attr]],Grunion_Contact_Form_Field->[render_checkbox_field->[is_error],render_select_field->[get_attribute,get_option_value,render_label],__construct->[get_attribute,unesc_attr],render_textarea_field->[render_label],render_date_field->[render_input_field,render_label],render_label->[is_error],render_field->[render_select_field,render_textarea_field,render_date_field,render_radio_field,render_default_field,render_telephone_field,render_email_field,render_url_field,render_checkbox_multiple_field,render_checkbox_field],render_radio_field->[get_attribute,get_option_value,render_label,is_error],render_default_field->[render_input_field,render_label],render_telephone_field->[render_input_field,render_label],validate->[get_attribute,add_error],render->[get_attribute],render_email_field->[render_input_field,render_label],render_url_field->[render_input_field,render_label],render_checkbox_multiple_field->[get_attribute,get_option_value,render_label,is_error],add_error->[get_attribute]],Grunion_Contact_Form->[__construct->[get_attribute,parse_content],parse_contact_field->[get_attribute],success_message->[get_attribute],get_field_ids->[get_attribute],parse->[get_attribute],process_submission->[get_field_ids,get_attribute,prepare_for_akismet],addslashes_deep->[addslashes_deep],get_compiled_form->[get_attribute]]] | Renders the contact form input This function is used to render the field in the Contact form. It will automatically fill the. | I haven't followed the output chain but I assume this is being properly escaped? |
@@ -35,6 +35,7 @@
#endif // FreeBSD or unix ?
#endif // _WIN32 ?
+#pragma prefast(disable:26444, "This warning unfortunately raises false positives when auto is used for declaring the type of an iterator in a loop.")
#ifdef HAS_ICU
#define INTL_LIBRARY_TEXT "icu"
#elif defined(_WIN32)
| [No CFG could be retrieved] | Create a new object with the name of the module record that is not defined in the W This function maps all module - record - > script - record - > scriptDir - >. | >26444 [](start = 24, length = 5) suppress by name macro instead of number? |
@@ -9,13 +9,14 @@
#include "bio_lcl.h"
#include "internal/thread_once.h"
+#include "internal/glock.h"
CRYPTO_RWLOCK *bio_type_lock = NULL;
static CRYPTO_ONCE bio_type_init = CRYPTO_ONCE_STATIC_INIT;
DEFINE_RUN_ONCE_STATIC(do_bio_type_init)
{
- bio_type_lock = CRYPTO_THREAD_glock_new("bio_type");
+ bio_type_lock = global_locks[CRYPTO_GLOCK_BIO_TYPE];
return bio_type_lock != NULL;
}
| [CRYPTO_THREAD_glock_new->[CRYPTO_THREAD_glock_new]] | private static final int bio_type_index ;. | It still might be appropriate to make it a function call. I mean with enum as argument, as alternative to indexing an array. |
@@ -13,6 +13,7 @@ require "pundit/rspec"
require "webmock/rspec"
require "test_prof/recipes/rspec/before_all"
require "test_prof/recipes/rspec/let_it_be"
+require "test_prof/recipes/rspec/sample"
# Requires supporting ruby files with custom matchers and macros, etc, in
# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
| [disable_net_connect!,clear_cache,hash_token_secrets,define_negated_matcher,info,fixture_path,infer_spec_type_from_file_location!,filter_rails_from_backtrace!,root,toggle_live,before,logger,require,to_rack,include,key?,use_transactional_fixtures,include?,to_json,production?,around,each,turned_off,disable,test_mode,abort,after,ignore_hosts,configure,run,allow_net_connect!,maintain_test_schema!,to_return,expand_path] | Requires all required files in the support directory and all subdirectories. Requires all required modules and runs tests. | I need this to run a sample number of tests :) |
@@ -317,6 +317,7 @@ class DataInputOperation(RunnerIOOperation):
def finish(self):
# type: () -> None
with self.splitting_lock:
+ self.index += 1
self.started = False
| [create_combine_per_key_precombine->[get_only_output_coder,augment_oldstyle_op,get_input_windowing],StateBackedSideInputMap->[__getitem__->[MultiMap->[],MultiMap,_StateBackedIterable]],create_read_from_impulse_python->[get_only_output_coder],create_source_java->[get_only_output_coder,augment_oldstyle_op],create_assign_windows->[WindowIntoDoFn,_create_simple_pardo_operation],create_deprecated_read->[augment_oldstyle_op],CombiningValueRuntimeState->[commit->[commit],read->[_read_accumulator],add->[_read_accumulator,add],clear->[clear]],BundleProcessor->[monitoring_infos->[monitoring_infos],reset->[reset],create_execution_tree->[topological_height->[topological_height],get_operation->[get_operation],is_side_input,get_operation],finalize_bundle->[finalize_bundle],process_bundle->[set_output_stream,finish,start],try_split->[try_split,add]],DataInputOperation->[_compute_split->[is_valid_split_point,try_split]],_create_pardo_operation->[augment_oldstyle_op,StateBackedSideInputMap,get_output_coders,get_input_coders,FnApiUserStateContext,set,get_windowed_coder],create_identity_dofn->[get_only_output_coder,augment_oldstyle_op],SynchronousBagRuntimeState->[commit->[clear],read->[_StateBackedIterable,_ConcatIterable]],BeamTransformFactory->[extract_timers_info->[TimerInfo],get_input_windowing->[only_element],get_only_output_coder->[get_output_coders,only_element],get_output_coders->[get_windowed_coder],get_input_coders->[get_windowed_coder],__init__->[_StateBackedIterable],get_only_input_coder->[get_input_coders,only_element],get_windowed_coder->[get_coder]],create_flatten->[get_only_output_coder,augment_oldstyle_op],_create_combine_phase_operation->[get_only_output_coder,augment_oldstyle_op],FnApiUserStateContext->[commit->[commit],_create_state->[CombiningValueRuntimeState,SynchronousSetRuntimeState,SynchronousBagRuntimeState],get_timer->[OutputTimer]],create_source_runner->[DataInputOperation,get_coder],_create_simple_pardo_operation->[_create_pardo_operation],create_map_windows->[MapWindows,_create_simple_pardo_operation],SynchronousSetRuntimeState->[_compact_data->[_StateBackedIterable,_ConcatIterable,clear],commit->[clear],read->[_compact_data],add->[_compact_data,add,clear]],create_sink_runner->[DataOutputOperation,get_coder],register_urn] | Finishes the sequence of missing keys. | It doesn't seem like the index should be incremented here. |
@@ -1283,8 +1283,18 @@ class ComposerRepository extends ArrayRepository implements ConfigurableReposito
return true;
}
}
+
+ // todo: throw new LogicException('Should not happen');
+ return true;
}
+ /**
+ * @param string $filename
+ * @param string $cacheKey
+ * @param string|null $lastModifiedTime
+ *
+ * @return \React\Promise\PromiseInterface
+ */
private function asyncFetchFile($filename, $cacheKey, $lastModifiedTime = null)
{
$retries = 3;
| [ComposerRepository->[createPackages->[getRepoName,configurePackageTransportOptions,loadPackages],addPackage->[configurePackageTransportOptions],getPackageNames->[getPackages],initializePartialPackages->[loadRootServerFile],loadIncludes->[loadIncludes],loadRootServerFile->[getPackagesJsonUrl],loadProviderListings->[loadProviderListings],loadDataFromServer->[loadRootServerFile],search->[getPackageNames]]] | Fetches a file from the remote repository if it has a last - modified date. Asynchronously downloads a file from the remote repository. Returns the data from the last download request if it is a valid package. | Previously, the code might implicitly return null here. I added `return true` just to satisfy PHPStan and I think it's better to throw here. |
@@ -25,7 +25,6 @@ def is_same_type(left: Type, right: Type) -> bool:
# types can be simplified to non-union types such as Union[int, bool]
# -> int. It would be nice if we always had simplified union types but
# this is currently not the case, though it often is.
- left = simplify_union(left)
right = simplify_union(right)
return left.accept(SameTypeVisitor(right))
| [is_same_types->[is_same_type],SameTypeVisitor->[visit_union_type->[is_same_type],visit_callable_type->[is_same_type,is_same_types],visit_typeddict_type->[is_same_type],visit_instance->[is_same_types],visit_type_alias_type->[is_same_types],visit_tuple_type->[is_same_type,is_same_types],visit_type_type->[is_same_type],visit_overloaded->[is_same_types],visit_literal_type->[is_same_type]]] | Checks if left and right are the same type. | Unfortunately this doesn't work for cases like checking whether `Union[A, B]` is the same type as `Union[B, A]`, where `B` is a subclass of `A`. One possible way to fix this would be to use a simpler replacement for `is_same_type` in `is_protocol_implementation`. Maybe we can just use type equality (==)? |
@@ -197,6 +197,10 @@ def _save_response_content(response, destination, chunk_size=32768):
pbar.close()
+def _is_tarxz(filename):
+ return filename.endswith(".tar.xz")
+
+
def _is_tar(filename):
return filename.endswith(".tar")
| [extract_archive->[_is_zip,_is_targz,_is_gzip,_is_tar],check_md5->[calculate_md5],download_url->[check_integrity,gen_bar_updater,makedir_exist_ok],download_and_extract_archive->[extract_archive,download_url],verify_str_arg->[iterable_to_str],check_integrity->[check_md5],download_file_from_google_drive->[check_integrity,makedir_exist_ok]] | Check if filename ends with. tar or. tar. gz. | If this doesn't work on Python 2, can we maybe skip support for this format for Python 2? |
@@ -1,5 +1,6 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
+#nullable disable
// Used to indicate to the compiler that the .locals init flag should not be set in method headers.
[module: System.Runtime.CompilerServices.SkipLocalsInit]
| [No CFG could be retrieved] | License the. NET Foundation for a given version of a given module. | Is it correct to disable nullability on files inside of the Common folder? |
@@ -238,10 +238,10 @@ class Assignment < Assessment
end
# Returns the maximum possible mark for a particular assignment
- def max_mark(user_visibility = :ta)
- # TODO: sum method does not work with empty arrays. Consider updating/replacing gem:
+ def max_mark(user_visibility = :ta_visible)
+ # TODO: sum method does not work with empty arrays. Consider updating/replacing gem``:
# see: https://github.com/thirtysixthspan/descriptive_statistics/issues/44
- max_marks = get_criteria(user_visibility).map(&:max_mark)
+ max_marks = criteria.select(&user_visibility).map(&:max_mark)
s = max_marks.empty? ? 0 : max_marks.sum
s.nil? ? 0 : s.round(2)
end
| [Assignment->[to_json->[to_json],summary_json->[group_by],get_marks_list->[max_mark],group_by->[group_assignment?],current_submission_data->[group_by],average_annotations->[get_num_marked,get_num_annotations],percentage_grades_array->[calculate_total_percent],get_num_marked->[is_criteria_mark?,get_num_assigned],summary_csv->[max_mark],past_all_collection_dates?->[past_collection_date?],zip_automated_test_files->[autotest_files_dir],create_autotest_dirs->[autotest_files_dir,autotest_path],reset_collection_time->[reset_collection_time],to_xml->[to_xml],grouping_past_due_date?->[past_all_due_dates?]]] | Returns the max_mark value of the node in the tree. | Delete the `` |
@@ -1184,3 +1184,13 @@ class Link(object):
# An object to represent the "link" for the installed version of a requirement.
# Using Inf as the url makes it sort higher.
INSTALLED_VERSION = Link(Inf)
+
+
+Search = namedtuple('Search', 'supplied canonical formats')
+"""Capture key aspects of a search.
+
+:attribute user: The user supplied package.
+:attribute canonical: The canonical package name.
+:attribute formats: The formats allowed for this package. Should be a set
+ with 'binary' or 'source' or both in it.
+"""
| [PackageFinder->[_sort_locations->[sort_path],_get_index_urls_locations->[mkurl_pypi_url],find_requirement->[_find_all_versions,InstallationCandidate,_sort_versions],_link_package_versions->[_log_skipped_link,InstallationCandidate],_find_all_versions->[_sort_locations,_validate_secure_origin,_get_index_urls_locations],_package_versions->[_sort_links]],Link->[splitext->[splitext],ext->[splitext]],Link] | The link object for the installed version of a requirement. | glad you did the change but you forgot the docstring :) |
@@ -102,6 +102,7 @@ GCP_REQUIREMENTS = [
'google-apitools>=0.5.6,<1.0.0',
'proto-google-cloud-datastore-v1==0.90.0',
'googledatastore==7.0.0',
+ 'google-cloud-bigquery>=0.22.1,<1.0.0',
]
| [get_version->[open,exec],find_packages,get_distribution,system,get_version,format,warn,cythonize,setup,StrictVersion] | However is recommended. Package hierarchy for all packages. | @sb2nov I think this deserves a new category `GCP_TEST_PACKAGES` |
@@ -1358,13 +1358,13 @@ cond_test(void **state)
start_epoch = epoch + 1;
}
-/** Making the oid generation deterministic, I get to 304 before I hit a false
+/** Making the oid generation deterministic, I get to 102 before I hit a false
* collision on the oid. This may indicate the hashing needs to be improved
* but for now, it's good enough. In general, the chance of a single
* collision is very high well before we get close to saturation due
* to the birthday paradox.
*/
-#define NUM_OIDS 304
+#define NUM_OIDS 102
static void
multiple_oid_cond_test(void **state)
{
| [No CFG could be retrieved] | VOS_OF_COND_DKEY_UPDATE should fail due to later read Special case for akey - based read - conflict punching. | @jolivier23 with this patch applied, somehow i hit RESTART error earlier, i am not sure maybe because oid generation policy change. |
@@ -64,12 +64,10 @@ func newUninstallCmd(config *action.Configuration, in io.Reader, out io.Writer)
}
f := cmd.Flags()
- //add mesh name flag
f.StringVar(&uninstall.meshName, "mesh-name", defaultMeshName, "Name of the service mesh")
- //add force uninstall flag
f.BoolVarP(&uninstall.force, "force", "f", false, "Attempt to uninstall the osm control plane instance without prompting for confirmation. If the control plane with specified mesh name does not exist, do not display a diagnostic message or modify the exit status to reflect an error.")
- //add uninstall namespace flag
f.BoolVar(&uninstall.deleteNamespace, "delete-namespace", false, "Attempt to delete the namespace after control plane components are deleted")
+ f.Uint16VarP(&uninstall.localPort, "local-port", "p", constants.OSMHTTPServerPort, "Local port to use for port forwarding")
return cmd
}
| [run->[Fprintf,Sprintf,CoreV1,Background,WithCancel,Cause,Delete,Errorf,run,Namespace,Run,Namespaces],RESTClientGetter,StringVar,ToRESTConfig,ExactArgs,NewForConfig,Errorf,run,NewUninstall,BoolVarP,Flags,BoolVar] | run runs the uninstall OSM command. | Suggest adding "Default is 9091" to the description |
@@ -87,7 +87,9 @@ public class TagRouter extends AbstractRouter implements Comparable<Router>, Con
return invokers;
}
- if (tagRouterRule == null || !tagRouterRule.isValid() || !tagRouterRule.isEnabled()) {
+ // since the rule can be changed by config center, we should dump one to use.
+ TagRouterRule dump = tagRouterRule;
+ if (dump == null || !dump.isValid() || !dump.isEnabled()) {
return filterUsingStaticTag(invokers, url, invocation);
}
| [TagRouter->[isRuntime->[isRuntime],isForce->[isForce],notify->[process,getUrl],route->[getUrl]]] | Route the given list of invokers to the given URL. filter by tag key. | Shall we mark it as final? Also I don't quite understand why it is named as dump? If it is just a copy, will a name called `tagRouterRuleCopy` be better? |
@@ -256,6 +256,11 @@ obj_bulk_transfer(crt_rpc_t *rpc, crt_bulk_op_t bulk_op, bool bulk_bind,
crt_bulk_perm_t bulk_perm;
int i, rc, *status, ret;
+ if (remote_bulks == NULL) {
+ D_ERROR("No remote bulks provided\n");
+ return -DER_INVAL;
+ }
+
bulk_perm = bulk_op == CRT_BULK_PUT ? CRT_BULK_RO : CRT_BULK_RW;
rc = ABT_eventual_create(sizeof(*status), &arg.eventual);
if (rc != 0)
| [No CFG could be retrieved] | Reads the object from the server and creates the object from the object. takes in a list of bulk segments and returns the first non - empty object found. | seems NULL remote_bulks is impossible? if so maybe just assert it. |
@@ -13,8 +13,9 @@ class Rocblas(CMakePackage):
homepage = "https://github.com/ROCmSoftwarePlatform/rocBLAS/"
url = "https://github.com/ROCmSoftwarePlatform/rocBLAS/archive/rocm-3.5.0.tar.gz"
- maintainers = ['haampie']
+ maintainers = ['srekolam', 'arjun-raj-kuppala']
+ version('3.9.0', sha256='3ecd2d9fd2be0e1697a191d143a2d447b53a91ae01afb50231d591136ad5e2fe')
version('3.8.0', sha256='568a9da0360349b1b134d74cc67cbb69b43c06eeca7c33b50072cd26cd3d8900')
version('3.7.0', sha256='9425db5f8e8b6f7fb172d09e2a360025b63a4e54414607709efc5acb28819642')
version('3.5.0', sha256='8560fabef7f13e8d67da997de2295399f6ec595edfd77e452978c140d5f936f0')
| [Rocblas->[setup_build_environment->[set],cmake_args->[join_path,format,join,append],depends_on,resource,version,patch,variant]] | Creates a single object from a list of objects. requires that all of the resources of the given version are installed. | @haampie are you okay with this? We could also have all 3 of you as maintainers on all rocm packages. |
@@ -65,13 +65,16 @@ describe Idv::PhoneController do
expect(response).to redirect_to idv_phone_errors_failure_url
end
- it 'shows phone form if async process times out' do
+ it 'shows phone form if async process times out and allows successful resubmission' do
# setting the document capture session to a nonexistent uuid will trigger async
# timed_out behavior
subject.idv_session.idv_phone_step_document_capture_session_uuid = 'abc123'
get :new
expect(response).to render_template :new
+ put :create, params: { idv_phone_form: { phone: good_phone } }
+ get :new
+ expect(response).to redirect_to idv_review_path
end
it 'shows waiting interstitial if async process is in progress' do
| [step_attempts,create,let,to_not,describe,stub_verify_steps_one_and_two,it,put,to,user_phone_confirmation,vendor_phone_confirmation,before,with,idv_phone_step_document_capture_session_uuid,t,require,include,have_actions,store_proofing_pii_from_doc,receive,now,id,redirect_to,context,hash_including,build,uuid,get,eq,render_template] | adds some checks to the session and checks if the phone number has been confirmed missing - idv - phone - form - error 555 - 0130. | can/should we put an expectation about rendering a flash message too here? |
@@ -333,8 +333,9 @@ func (s *Server) bootstrapCluster(clusterID uint64, req *pdpb.BootstrapRequest)
cancel()
if err != nil {
return errors.Trace(err)
- } else if !resp.Succeeded {
- return errors.Errorf("bootstrap cluster %d fail, we may not leader", clusterID)
+ }
+ if !resp.Succeeded {
+ return errors.Errorf("bootstrap cluster %d fail, we may be not leader", clusterID)
}
log.Infof("bootstrap cluster %d ok", clusterID)
| [bootstrapCluster->[getClusterRootPath,newCluster],closeClusters->[Close],getCluster->[getClusterRootPath,newCluster]] | bootstrapCluster creates a new cluster with the specified ID and request. regionValue is the region that will be searched for in the cluster. | why move below? |
@@ -524,6 +524,10 @@ describe('q', function() {
expect(typeof promise['finally']).toBe('function');
});
+ it('should have a get method', function() {
+ expect(typeof promise.get).toBe('function');
+ });
+
describe('then', function() {
it('should allow registration of a success callback without an errback or progressback ' +
| [No CFG could be retrieved] | The following methods are defined in the constructor of the promise class. Allows registration of an errback without a success or progress callback and resolve. | sorry, but we need a more solid test than this :) |
@@ -121,7 +121,7 @@ func handleSignIn(resp http.ResponseWriter, req *http.Request, sess SessionStore
_ = sess.Delete("openid_determined_username")
_ = sess.Delete("twofaUid")
_ = sess.Delete("twofaRemember")
- _ = sess.Delete("u2fChallenge")
+ _ = sess.Delete("webauthnAssertion")
_ = sess.Delete("linkAccount")
err = sess.Set("uid", user.ID)
if err != nil {
| [UpdateUserCols,Error,Language,MatchString,Sprintf,TypeOf,Init,RegenerateSession,Locale,DeleteCSRFCookie,Delete,String,SetLocaleCookie,Free,MustCompile,HasPrefix,Set] | isGitRawReleaseOrLFSPath checks if the request is a git raw release or Set the locale cookie and delete the CSRF cookie if it has right now. | Do we still need to delete every key in session? If yes, there is a `webauthnRegistration` (`registration`) |
@@ -100,7 +100,7 @@ import org.slf4j.LoggerFactory;
* An unbounded source and a sink for <a href="http://kafka.apache.org/">Kafka</a> topics.
* Kafka version 0.9 and 0.10 are supported. If you need a specific version of Kafka
* client(e.g. 0.9 for 0.9 servers, or 0.10 for security features), specify explicit
- * kafka-client dependency.
+ * kafka-client dependency with Maven property ${kafka.clients.version}.
*
* <h3>Reading from Kafka topics</h3>
*
| [KafkaIO->[TypedWithoutMetadata->[expand->[apply]],KafkaWriter->[setup->[getProducerFactoryFn,apply],teardown->[close],processElement->[getTopic],getKeyCoder,getProducerConfig,getValueCoder],UnboundedKafkaSource->[generateInitialSplits->[getConsumerConfig,getTopics,build,apply,getTopicPartitions],validate->[validate],getDefaultOutputCoder->[getKeyCoder,getValueCoder]],Write->[updateProducerProperties->[updateKafkaProperties,getProducerConfig,build],expand->[apply],withProducerFactoryFn->[build],withKeyCoder->[build],values->[build],validate->[getKeyCoder,getValueOnly,getValueCoder,getTopic],withValueCoder->[build],withTopic->[build]],Read->[withTopicPartitions->[build],withConsumerFactoryFn->[build],withWatermarkFn2->[build],expand->[withMaxReadTime,getMaxNumRecords,withMaxNumRecords,getMaxReadTime],withWatermarkFn->[withWatermarkFn2],withKeyCoder->[build],withMaxReadTime->[build],validate->[getKeyCoder,getValueCoder],unwrapKafkaAndThen->[apply->[apply]],withTopics->[build],updateConsumerProperties->[getConsumerConfig,build],withMaxNumRecords->[build],withValueCoder->[build],withTimestampFn2->[build],withTimestampFn->[withTimestampFn2]],KafkaValueWrite->[expand->[apply]],UnboundedKafkaReader->[getSplitBacklogBytes->[approxBacklogInBytes],start->[run->[consumerPollLoop],getConsumerConfig,apply,nextBatch,getTopicPartitions],getWatermark->[getWatermarkFn,apply],updateLatestOffsets->[setLatestOffset],close->[close],advance->[getKeyCoder,nextBatch,getValueCoder,recordConsumed,getTimestampFn,apply],apply->[PartitionState],decode->[decode],getTopicPartitions]]] | Imports a single from the Kafka server. Consumes a single Nagios header from Kafka. | I think we should remove this update. Uses are not building beam or beam modules by themselves, rather are just using published mvn artifacts. This property is not irrelevant to them. |
@@ -547,7 +547,8 @@ class BinaryInstaller(object):
conanfile.cpp_info.public_deps = public_deps
# Once the node is build, execute package info, so it has access to the
# package folder and artifacts
- with pythonpath(conanfile): # Minimal pythonpath, not the whole context, make it 50% slower
+ conan_v2 = get_env(CONAN_V2_MODE_ENVVAR, False)
+ with pythonpath(conanfile) if not conan_v2 else no_op(): # Minimal pythonpath, not the whole context, make it 50% slower
with tools.chdir(package_folder):
with conanfile_exception_formatter(str(conanfile), "package_info"):
conanfile.package_folder = package_folder
| [_PackageBuilder->[build_package->[_package,_build,_get_build_folder,_prepare_sources],_get_build_folder->[build_id]],build_id->[build_id],BinaryInstaller->[install->[_build],_propagate_info->[add_env_conaninfo],_download->[_download],_build->[_handle_system_requirements,_download,_raise_missing,_classify],_handle_node_cache->[_download_pkg],_raise_missing->[raise_package_not_found_error],_build_package->[_PackageBuilder,build_package]]] | Call the package_info method of the conanfile. | Better to define a different ``pythonpath`` context as ``no_op``, in its definition, instead of everywhere it is called. |
@@ -904,7 +904,7 @@ zfs_do_create(int argc, char **argv)
if (nvlist_add_uint64(props,
zfs_prop_to_name(ZFS_PROP_VOLSIZE), intval) != 0)
nomem();
- volsize = intval;
+ volsize = P2ROUNDUP(intval, align);
break;
case 'p':
parents = B_TRUE;
| [No CFG could be retrieved] | - s flag applies only to volumes - p flag applies only to volumes - b flag applies - s - o - s - o - s - o - s - o - o. | This macro requires you to pass in the requested power-of-two alignment as the `align` parameter above (in this case the block size). Which is going to be a bit of a problem since at this point in we're still parsing arguments so we can't know if they're provided a different block size. Plus it looks like setting the `volsize` value here isn't going to be enough. The volume size is passed to the kernel via the `ZFS_PROP_VOLSIZE` property in the nvlist a few lines up, so that will need to be updated as well. The best way to go about handling this would be to move the needed logic down after the argument parsing where we have access to the volume size and block size. It's probably worth adding a small helper function to do what's needed, that `zvol_volsize_to_reservation()` provides a nice example. |
@@ -17,11 +17,8 @@
package org.apache.nifi.processors.standard;
import org.apache.commons.lang3.StringUtils;
-import org.apache.nifi.annotation.behavior.EventDriven;
-import org.apache.nifi.annotation.behavior.InputRequirement;
+import org.apache.nifi.annotation.behavior.*;
import org.apache.nifi.annotation.behavior.InputRequirement.Requirement;
-import org.apache.nifi.annotation.behavior.Stateful;
-import org.apache.nifi.annotation.behavior.WritesAttribute;
import org.apache.nifi.annotation.documentation.CapabilityDescription;
import org.apache.nifi.annotation.documentation.Tags;
import org.apache.nifi.annotation.lifecycle.OnScheduled;
| [QueryDatabaseTable->[setup->[setup],onTrigger->[getValue,getQuery,setState,create,toMap,getMetaData,getURL,getElapsed,info,remove,executeQuery,yield,getLocalizedMessage,getStateManager,AtomicLong,createSession,set,isEmpty,asList,intValue,MaxValueResultSetRowCollector,valueOf,transfer,ProcessException,getState,error,debug,asInteger,receive,createStatement,getConnection,split,write,setFetchSize,getLogger,get,putAttribute,setQueryTimeout,commit,convertToAvroStream,StopWatch,asControllerService],MaxValueResultSetRowCollector->[processRow->[getMaxValueFromRow,getName,getMetaData,getColumnCount,get,IOException,toLowerCase,getObject,put]],getQuery->[IllegalArgumentException,getSelectStatement,toMap,size,getName,append,getLiteralByType,add,get,toString,isEmpty,StringBuilder,toLowerCase,join,getVersion],build,unmodifiableList,add,unmodifiableSet]] | Imports a single object. Imports all the necessary components of the NIFC Processor. | Our coding standards discourage the use of star imports, mind replacing this with the individual imports? Please and thanks! |
@@ -347,7 +347,7 @@ public class Site2SiteVpnManagerImpl extends ManagerBase implements Site2SiteVpn
if (conn.isPassive()) {
conn.setState(State.Disconnected);
} else {
- conn.setState(State.Connected);
+ conn.setState(State.Connecting);
}
_vpnConnectionDao.persist(conn);
return conn;
| [Site2SiteVpnManagerImpl->[deleteCustomerGatewayByAccount->[doDeleteCustomerGateway],reconnectDisconnectedVpnByVpc->[startVpnConnection],deleteVpnGateway->[doDeleteVpnGateway],createCustomerGateway->[checkCustomerGatewayCidrList],resetVpnConnection->[startVpnConnection,stopVpnConnection],cleanupVpnGatewayByVpc->[doDeleteVpnGateway],updateCustomerGateway->[checkCustomerGatewayCidrList],setupVpnConnection->[startVpnConnection]]] | This method acquires a lock on the connection and applies the necessary information to it. | Is there any FSM or logic that ensures that connections don't get stuck in the new `Connecting` state? |
@@ -76,7 +76,7 @@ Rails.application.configure do
config.hosts << ENV["APP_DOMAIN"] unless ENV["APP_DOMAIN"].nil?
if (gitpod_workspace_url = ENV["GITPOD_WORKSPACE_URL"])
- config.hosts << URI.parse(gitpod_workspace_url).host
+ config.hosts << /.*#{URI.parse(gitpod_workspace_url).host}/
end
config.app_domain = "localhost:3000"
| [app_domain,warn_on_records_fetched_greater_than,perform_deliveries,new,hosts,formatter,file_watcher,after_initialize,raise_delivery_errors,preview_path,join,configure,headers,freeze,nil?,consider_all_requests_local,log_formatter,cache_classes,host,deprecation,add_footer,exist?,logger,verbose_query_logs,enabled,to_i,migration_error,debug,delivery_method,eager_load,include?,default_url_options,enable,present?,scripts_to_run?,cache_store,perform_caching,rails_logger,digest,quiet,log_level,raise,raise_runtime_errors,add_whitelist,smtp_settings,console] | Configure the assets. Configure the action view to raise errors if missing translations. | Since you mentioned `port-<workspace-url>`, do we want to be more specific here, i.e.`\d*` instead of `.*`? |
@@ -15,7 +15,8 @@ try {
setNetwork(process.env.NETWORK || 'test', {
performanceMode: false,
- useMetricsProvider: process.env.USE_METRICS_PROVIDER === 'true'
+ useMetricsProvider: process.env.USE_METRICS_PROVIDER === 'true',
+ proxyAccountsEnabled: process.env.PROXY_ACCOUNTS_ENABLED === 'true'
})
const schema = makeExecutableSchema({
| [No CFG could be retrieved] | Create a schema that represents a single . The former is the client and the former is the client. | I don't see that used anywhere so I assume it is for future ? |
@@ -6314,7 +6314,7 @@ bool wallet2::sign_tx(unsigned_tx_set &exported_txs, std::vector<wallet2::pendin
// normally, the tx keys are saved in commit_tx, when the tx is actually sent to the daemon.
// we can't do that here since the tx will be sent from the compromised wallet, which we don't want
// to see that info, so we save it here
- if (store_tx_info() && ptx.tx_key != crypto::null_skey)
+ if (store_tx_info() && tx_key != crypto::null_skey)
{
const crypto::hash txid = get_transaction_hash(ptx.tx);
m_tx_keys.insert(std::make_pair(txid, tx_key));
| [No CFG could be retrieved] | This function is called when a new transaction is submitted. - - - - - - - - - - - - - - - - - -. | I believe we don't need the `tx_key != crypto::null_skey` check either. |
@@ -1284,7 +1284,8 @@ export class AmpStory extends AMP.BaseElement {
const uiState = this.getUIType_();
this.storeService_.dispatch(Action.TOGGLE_UI, uiState);
- if (uiState !== UIType.MOBILE) {
+ if (uiState !== UIType.MOBILE ||
+ this.getSupportedOrientations_().includes('landscape')) {
this.storeService_.dispatch(Action.TOGGLE_LANDSCAPE, false);
return;
}
| [AmpStory->[pauseCallback->[TOGGLE_PAUSED,PAUSED_STATE],buildSystemLayer_->[element],onPausedStateUpdate_->[PLAYING,PAUSED],registerAndPreloadBackgroundAudio_->[upgradeBackgroundAudio,childElement,tagName],constructor->[documentStateFor,timerFor,forElement,getStoreService,registerServiceBuilder,platformFor,TOGGLE_RTL,isRTL,for,createPseudoLocale],initializeStandaloneStory_->[classList],isSwipeLargeEnoughForHint_->[abs],next_->[dev,element,next,ADVANCE_TO],setHistoryStatePageId_->[replaceState,isAd],getPageDistanceMapHelper_->[getAdjacentPageIds],upgradeCtaAnchorTagsForTracking_->[element,scopedQuerySelectorAll,setAttribute,prototype],showBookend_->[TOGGLE_BOOKEND],initializeListeners_->[CURRENT_PAGE_ID,AD_STATE,NEXT_PAGE,PREVIOUS_PAGE,MUTED_STATE,getMode,SHOW_NO_PREVIOUS_PAGE_HELP,setWhitelist,PAGE_PROGRESS,BOOKEND_STATE,CAN_SHOW_PREVIOUS_PAGE_HELP,UI_STATE,DISPATCH_ACTION,REPLAY,SIDEBAR_STATE,PAUSED_STATE,ACTIONS_WHITELIST,getDetail,actionServiceForDoc,SUPPORTED_BROWSER_STATE,SWITCH_PAGE,debounce],addPage->[isAd],isBrowserSupported->[Boolean,CSS],getPageContainingElement_->[findIndex,element,closest],getUIType_->[DESKTOP,DESKTOP_FULLBLEED,MOBILE,isExperimentOn],isStandalone_->[STANDALONE],onUIStateUpdate_->[DESKTOP,MOBILE,DESKTOP_FULLBLEED],validateConsent_->[tagName,dev,indexOf,childElementByTag,removeChild,forEach,length,childElements],updateAudioIcon_->[TOGGLE_STORY_HAS_BACKGROUND_AUDIO,TOGGLE_STORY_HAS_AUDIO],onResize->[TOGGLE_LANDSCAPE,isLandscape,TOGGLE_UI,MOBILE],buildCallback->[setAttribute,TOGGLE_UI],initializeStoryAccess_->[hasAttribute,areFirstAuthorizationsCompleted,removeAttribute,user,accessServiceForDocOrNull,onApplyAuthorizations],getPagesByDistance_->[keys],replay_->[then,BOOKEND_STATE,removeAttributeInMutate,dev,VISITED],onAccessApplyAuthorizations_->[element,TOGGLE_ACCESS],insertPage->[setAttribute,RETURN_TO,AUTO_ADVANCE_TO,isAd,ADVANCE_TO,dev,CAN_INSERT_AUTOMATIC_AD,element,id],onKeyDown_->[BOOKEND_STATE,RTL_STATE,key,LEFT_ARROW,RIGHT_ARROW],getNextPage->[getNextPageId],updateBackground_->[url,computedStyle,color],onSupportedBrowserStateUpdate_->[dev],layoutCallback->[resolve,isBrowserSupported,TOGGLE_SUPPORTED_BROWSER],toggleElementsOnBookend_->[resetStyles,DESKTOP,scopedQuerySelectorAll,prototype,setImportantStyles,UI_STATE],previous_->[dev,previous],buildPaginationButtons_->[create],switchTo_->[setState,isAd,shift,MUTED_STATE,removeAttributeInMutate,TOGGLE_AD,VISITED,UI_STATE,muteAllMedia,NOT_ACTIVE,CHANGE_PAGE,AUTO_ADVANCE_AFTER,PAUSED_STATE,beforeVisible,PLAYING,element,length,resolve,DESKTOP,AD_SHOWING,unqueueStepInRAF,TOGGLE_ACCESS,setAttributeInMutate,getNextPageId],performTapNavigation_->[DESKTOP,PREVIOUS,NEXT,UI_STATE],initializeBookend_->[dict,getImpl,createElementWithAttributes],preloadPagesByDistance_->[forEach,setDistance],getPageIndexById->[findIndex,user,element],hasBookend_->[components,resolve,CAN_SHOW_BOOKEND,MOBILE,UI_STATE],setDesktopPositionAttributes_->[element,escapeCssSelectorIdent,removeAttribute,getPreviousPageId,DESKTOP_POSITION,scopedQuerySelectorAll,prototype,getNextPageId,forEach,push],getBackgroundUrl_->[dev,querySelector,getAttribute],updateViewportSizeStyles_->[vmax,vmin,vw,max,min,vh,px],isLayoutSupported->[CONTAINER],triggerActiveEventForPage_->[actionServiceForDoc,HIGH],onSidebarStateUpdate_->[some,HIGH,attributeName,actionServiceForDoc,TOGGLE_SIDEBAR,execute],getElementDistance->[getDistance],installGestureRecognizers_->[SYSTEM_UI_IS_VISIBLE_STATE,BOOKEND_STATE,CAN_SHOW_NAVIGATION_OVERLAY_HINT,get,data,event,ACCESS_STATE,TOOLTIP_ELEMENT,onGesture],pauseStoryUntilConsentIsResolved_->[getConsentPolicyState,then,TOGGLE_PAUSED],getMaxMediaElementCounts->[min,VIDEO,AUDIO],lockBody_->[setImportantStyles,documentElement,body],initializeListenersForDev_->[getMode,getDetail,DEV_LOG_ENTRIES_AVAILABLE],getPageById->[dev],maybeLockScreenOrientation_->[mozLockOrientation,dev,message,lockOrientation,msLockOrientation],layoutStory_->[setState,then,id,NOT_ACTIVE,build,user,MOBILE,viewerForDoc,UI_STATE],onAdStateUpdate_->[MUTED_STATE],initializeSidebar_->[TOGGLE_HAS_SIDEBAR,ADD_TO_ACTIONS_WHITELIST],initializeStyles_->[querySelector],hideBookend_->[TOGGLE_BOOKEND],getPageIndex->[findIndex],rewriteStyles_->[textContent,isExperimentOn],forceRepaintForSafari_->[DESKTOP,toggle,UI_STATE],initializePages_->[all,SET_PAGES_COUNT,prototype,getImpl,length],resumeCallback->[TOGGLE_PAUSED],markStoryAsLoaded_->[INI_LOAD,STORY_LOADED,dispatch],setThemeColor_->[content,getPropertyValue,name,computedStyle],whenPagesLoaded_->[all,DESKTOP,whenLoaded,filter,UI_STATE],getHistoryStatePageId_->[ampStoryPageId,getState],BaseElement],registerElement,VIDEO,AUDIO,extension] | On resize action. | is this right? shouldn't it be `!this.getSupportedOrientations_().includes('landscape')`? |
@@ -470,7 +470,7 @@ class TaskRule(Rule):
self._output_type = output_type
self.input_selectors = input_selectors
self.input_gets = input_gets
- self.func = func
+ self.func = func # type: ignore
self._dependency_rules = dependency_rules or ()
self._dependency_optionables = dependency_optionables or ()
self.cacheable = cacheable
| [_make_rule->[wrapper->[resolve_type,_RuleVisitor,_get_starting_indent,optionable_rule]],union->[non_member_error_message->[non_member_error_message]],RuleIndex->[normalized_rules->[NormalizedRules],create->[add_rule->[add_root_rule,add_rule,add_task],add_type_transition_rule,add_rule]],_RuleVisitor->[visit_Call->[_is_get],_stmt_is_at_end_of_parent_list->[_maybe_end_of_stmt_list],visit_Yield->[_is_get,_stmt_is_at_end_of_parent_list,_generate_ast_error_message,YieldVisitError]],console_rule->[rule],rule->[_ensure_type_annotation,_make_rule]] | Initialize a object. | NB: these ignores will have error codes once we can land MyPy 0.730 / 0.740. This is currently blocked by the change to use implicit namespace packages in Pants. |
@@ -44,7 +44,8 @@ class WorldMapController extends WidgetController
'init_lng' => Config::get('leaflet.default_lng', 0),
'init_zoom' => Config::get('leaflet.default_zoom', 2),
'group_radius' => Config::get('leaflet.group_radius', 80),
- 'status' => '0,1',
+ 'status' => '0,1', // Show all devices
+ 'maintenance' => '0', // Hide devices under maintenance
'device_group' => null,
];
}
| [WorldMapController->[getSettingsView->[getSettings],getView->[coordinatesValid,getSettings,get,isUnderMaintenance,filter]]] | This method is called when the constructor of the object is not called. | Any reason you are using textual numbers instead of just numbers? |
@@ -55,6 +55,15 @@ const Messages = props => (
const room = get(props, 'match.params.room')
const active = room || get(conversations, '0.id')
+ const displayUnreadCount = ({ messages }) => {
+ const unreadCount = messages.reduce((result, msg) => {
+ if (msg.status === 'unread' && msg.address !== props.wallet)
+ return [...result, msg]
+ return result
+ }, []).length
+
+ return unreadCount > 0 && unreadCount
+ }
return (
<div className="row">
<div className="col-md-3">
| [No CFG could be retrieved] | Create a view of a single message in a conversation. A component that exports a single . | I think we can have an extra field in GraphQL for 'unreadCount` and move this logic there |
@@ -93,9 +93,8 @@ func (w *Worker) SelectTransactionsForNewBlock(newBlockNum uint64, txs types.Tra
unselected := types.Transactions{}
invalid := types.Transactions{}
for _, tx := range txs {
- if tx.ShardID() != w.shardID && tx.ToShardID() != w.shardID {
+ if tx.ShardID() != w.shardID {
invalid = append(invalid, tx)
- continue
}
sender, flag := w.throttleTxs(selected, recentTxsStats, txsThrottleConfig, tx)
| [CommitTransactions->[commitTransaction],Commit->[CommitWithCrossLinks],SelectTransactionsForNewBlock->[throttleTxs],makeCurrent] | SelectTransactionsForNewBlock selects transactions that are currently in the given block and returns them. Transaction Throttle flag. | this is a bug fix. this is causing stress testing to fail on s3 @harmony-ek @LeoHChen |
@@ -49,6 +49,14 @@ export class AbstractWallet {
this.userHasSavedExport = value;
}
+ getHideTransactionsInWalletsList() {
+ return this.hideTransactionsInWalletsList;
+ }
+
+ setHideTransactionsInWalletsList(value) {
+ this.hideTransactionsInWalletsList = value;
+ }
+
/**
*
* @returns {string}
| [No CFG could be retrieved] | Create an abstract wallet class. Returns the delta of unconfirmed balance. | lets make private properties prefixed with `_` |
@@ -595,7 +595,7 @@ func packageAgent(requiredPackages []string, packagingFn func()) {
defer os.RemoveAll(dropPath)
defer os.Unsetenv(agentDropPath)
- packedBeats := []string{"filebeat", "heartbeat", "metricbeat"}
+ packedBeats := []string{"filebeat", "heartbeat", "metricbeat", "osquerybeat"}
for _, b := range packedBeats {
pwd, err := filepath.Abs(filepath.Join("..", b))
| [Package->[Setenv,Getenv],Build->[Setenv,Getenv,Deps],GoLint->[Output,Append,Contains,Deps,RunV,Split],Clean->[RemoveAll],TestBinaries->[Join],All->[SerialDeps,Deps],Changes->[Fprintln,New,Output,Errorf],Env->[Deps],Coverage->[Join,Deps],License->[RunV,Deps],Unit->[DefaultGoTestUnitArgs,Deps,GoTest],Binary->[DefaultBuildArgs,Build,Deps],GenerateConfig->[Copy,Join,Deps],BinaryOSS->[DefaultBuildArgs,Build,Deps],RemoveAll,Exec,FieldDocs,Now,Setenv,BuildGoDaemon,LookupEnv,TestPackages,XPackBeatDir,Walk,Copy,DefaultGolangCrossBuildArgs,Stat,Append,Filter,ParseBool,CrossBuild,Errorf,RegisterDeps,RunV,Since,Chdir,SplitN,CrossBuildGoDaemon,Join,OSSBeatDir,Output,NewPlatformList,CommitHash,Contains,Deps,Name,GolangCrossBuild,ToLower,CreateDir,Unsetenv,DefaultConfigFileParams,Get,GenerateFieldsYAMLTo,MkdirAll,Config,Sleep,Command,Printf,SerialDeps,Println,IsDir,RegisterCheckDeps,Sprintf,Version,Environ,Replace,GoCmd,Abs,Getenv,Run] | packageAgent creates a package agent with the given name and version. selectedPackageTypes - list of packages to be installed in the build distribution drop - all packages. | I'm curious if we checked how the image size changes with this PR. |
@@ -44,6 +44,7 @@ function nullFormRenameControl(control, name) {
* - `pattern`
* - `required`
* - `url`
+ * - `date`
*
* @description
* `FormController` keeps track of all its controls and nested forms as well as the state of them,
| [No CFG could be retrieved] | Component controller for validation tokens. View value of the national number field in the form. | Why not also add the other ones? `datetimelocal`, `time`, `week`, `month` |
@@ -322,7 +322,7 @@ class FormRecognizerClient(object):
return prepare_form_result(analyze_result, model_id)
deserialization_callback = cls if cls else analyze_callback
- return self._client.begin_analyze_with_custom_model(
+ return self._client.begin_analyze_with_custom_model( # type: ignore
file_stream=form,
model_id=model_id,
include_text_details=include_field_elements,
| [FormRecognizerClient->[close->[close],__exit__->[__exit__],__enter__->[__enter__]]] | Starts a new LRO poller that recognizes a custom form with a model trained with Analyze a single . | Why type ignore? what's the error |
@@ -226,8 +226,9 @@ class Petsc(Package):
else:
options.append('--with-clanguage=C')
- # Help PETSc pick up Scalapack from MKL:
- if 'scalapack' in spec:
+ # Help PETSc pick up Scalapack from MKL
+ # 'satisfies' is used to only pick up scalapack when needed
+ if spec.satisfies('+mumps+mpi~int64'):
scalapack = spec['scalapack'].libs
options.extend([
'--with-scalapack-lib=%s' % scalapack.joined(),
| [Petsc->[install->[join_path,satisfies,append,working_dir,Executable,joined,mpi_dependent_options,extend,format,add_default_arg,run,python,make,cc],headers->[find_headers],mpi_dependent_options->[join,format,RuntimeError],setup_dependent_environment->[unset,set],setup_environment->[unset,set],depends_on,conflicts,version,patch,variant]] | Installs a bunch of unknown options. Returns a list of options to configure a single . The main entry point for the petsc - ugen. Ex50 - Mumps - Hypre and superlu_dist are not supported. | could you please add a note here that `+mumps+mpi~int64` is the pre-condition to use `scalapack`. |
@@ -527,11 +527,11 @@ static Status migrateV1V2(void) {
}
for (const auto& key : keys) {
- std::smatch match;
- if (std::regex_match(key, match, re)) {
+ const auto pos = key.find(audit_str);
+ if (pos != std::string::npos) {
std::string value;
- const std::string new_key =
- match[1].str() + ".auditeventpublisher." + match[2].str();
+ std::string new_key = key;
+ new_key.replace(pos, audit_str.length(), ".auditeventpublisher.");
s = getDatabaseValue(kEvents, key, value);
if (!s.ok()) {
| [No CFG could be retrieved] | Get the next unique key from the database and update it with the next unique value. Deletes the database entry for the given key and upgrades it to the new version. | nit: maybe don't define `audit_str` and just put the constant here like we use `".auditeventpublisher."`. |
@@ -36,4 +36,6 @@ public interface EndPointSelector {
EndPoint select(Scope scope, Long storeId);
EndPoint select(DataStore store, String downloadUrl);
+
+ EndPoint selectHypervisorHostByType(Scope scope, HypervisorType htype);
}
| [No CFG could be retrieved] | endPoint select for download. | This method is never used. You can delete it. |
@@ -11,10 +11,8 @@
#
# Indexes
#
-# channel_works_channel_id_idx (channel_id)
-# channel_works_user_id_idx (user_id)
-# channel_works_user_id_work_id_channel_id_key (user_id,work_id,channel_id) UNIQUE
-# channel_works_work_id_idx (work_id)
+# index_channel_works_on_user_id_and_work_id (user_id,work_id)
+# index_channel_works_on_user_id_and_work_id_and_channel_id (user_id,work_id,channel_id) UNIQUE
#
class ChannelWork < ActiveRecord::Base
| [ChannelWork->[current_channel->[present?,channel,id,find_by],belongs_to]] | Table names for channel works. | Line is too long. [97/90] |
@@ -1842,9 +1842,12 @@ Java_io_daos_dfs_DaosFsClient_dunsResolvePath(JNIEnv *env, jclass clientClass,
void *buf = NULL;
jbyteArray barray = NULL;
jbyte *bytes = NULL;
-
- int rc = duns_resolve_path(path, &attr);
-
+ const char *prefix = "daos://";
+ bool has_prefix = strncmp(prefix, path, strlen(prefix)) == 0;
+ int rc;
+
+ attr.da_no_prefix = !has_prefix;
+ rc = duns_resolve_path(path, &attr);
if (rc) {
char *tmp = "Failed to resolve UNS path, %s";
char *msg;
| [No CFG could be retrieved] | Resolve extended attributes from given file path. get the uuid of the attribute. | (style) trailing whitespace |
@@ -29,7 +29,7 @@ from selfdrive.loggerd.config import ROOT
from selfdrive.swaglog import cloudlog
ATHENA_HOST = os.getenv('ATHENA_HOST', 'wss://athena.comma.ai')
-HANDLER_THREADS = os.getenv('HANDLER_THREADS', 4)
+HANDLER_THREADS = int(os.getenv('HANDLER_THREADS', "4"))
LOCAL_PORT_WHITELIST = set([8022])
dispatcher["echo"] = lambda s: s
| [takeSnapshot->[b64jpeg],reboot->[do_reboot->[reboot]],main->[backoff,handle_long_poll],main] | Creates a new object that represents a single . Handle exception of exception. | why make the default a string? |
@@ -110,7 +110,7 @@ public abstract class HoodieLogBlock {
* Type of the log block WARNING: This enum is serialized as the ordinal. Only add new enums at the end.
*/
public enum HoodieLogBlockType {
- COMMAND_BLOCK, DELETE_BLOCK, CORRUPT_BLOCK, AVRO_DATA_BLOCK
+ COMMAND_BLOCK, DELETE_BLOCK, CORRUPT_BLOCK, AVRO_DATA_BLOCK, HFILE_DATA_BLOCK
}
/**
| [HoodieLogBlock->[inflate->[getBlockEndPos,getContentPositionInLogFile,getBlockSize,inflate]]] | Abstract class for storing the contents of a HoodieLogBlock. region Public API Methods. | correct me if I am wrong. we may not have a separate delete block for hfile, since everything is a key, value in bytes. So, we might have to fetch all values and resolve to the latest one to find if the value represents delete or active. |
@@ -437,7 +437,8 @@ def test_pkg_install_paths(install_mockery):
shutil.rmtree(log_dir)
-def test_pkg_install_log(install_mockery):
+def test_pkg_install_log_no_log(install_mockery, monkeypatch):
+ """Test the installer log function with no log file."""
# Get a basic concrete spec for the trivial install package.
spec = Spec('trivial-install-test-package').concretized()
| [test_partial_install_keep_prefix->[MockStage],MockStage->[destroy->[destroy],create->[create]],test_partial_install_delete_prefix_and_stage->[RemovePrefixChecker,MockStage]] | Test if the trivial install package has a log file. | Do we need `monkeypatch` here? |
@@ -54,6 +54,11 @@ class Sensor extends DeviceRelatedModel
return collect(self::$icons)->get($this->sensor_class, 'delicius');
}
+ public static function getTypes()
+ {
+ return ['Voltage', 'Temperature', 'Fanspeed'];
+ }
+
// for the legacy menu
public static function getIconMap()
{
| [Sensor->[icon->[get],events->[morphMany],classDescr->[get]]] | Get the icon map for this sensor. | @murrant you mean like this? |
@@ -150,8 +150,8 @@ def consider_sys_version_info(expr: Expression, pyversion: Tuple[int, ...]) -> i
return TRUTH_VALUE_UNKNOWN
-def consider_sys_platform(expr: Expression, platform: str) -> int:
- """Consider whether expr is a comparison involving sys.platform.
+def consider_sys_platform(expr: Expression, platform: str, platform_system: str) -> int:
+ """Consider whether expr is a comparison involving sys.platform
Return ALWAYS_TRUE, ALWAYS_FALSE, or TRUTH_VALUE_UNKNOWN.
"""
| [contains_sys_version_info->[isinstance,is_sys_attr],infer_condition_value->[infer_condition_value,consider_sys_platform,consider_sys_version_info,isinstance],assert_will_always_fail->[infer_condition_value],infer_reachability_of_if_statement->[infer_condition_value,len,mark_block_unreachable,Block,mark_block_mypy_only,range],consider_sys_version_info->[fixed_comparison,contains_sys_version_info,len,isinstance,contains_int_or_tuple_of_ints],consider_sys_platform->[fixed_comparison,len,startswith,isinstance,is_sys_attr],mark_block_unreachable->[MarkImportsUnreachableVisitor,accept],mark_block_mypy_only->[MarkImportsMypyOnlyVisitor,accept],is_sys_attr->[isinstance],contains_int_or_tuple_of_ints->[append,tuple,literal,isinstance],TypeVar] | Consider whether expr is a comparison involving sys. platform. | Please update the docstring to add that this also considers `platform.system` (see below). |
@@ -187,6 +187,13 @@ window.OPENSHIFT_CONFIG = {
oauth_client_id: "{{ .OAuthClientID | js}}",
logout_uri: "{{ .LogoutURI | js}}"
},
+ {{ with .LimitRequestOverrides }}
+ limitRequestOverrides: {
+ limitCPUToMemoryPercent: {{ .LimitCPUToMemoryPercent }},
+ cpuRequestToLimitPercent: {{ .CPURequestToLimitPercent }},
+ memoryRequestToLimitPercent: {{ .MemoryRequestToLimitPercent }}
+ },
+ {{ end }}
loggingURL: "{{ .LoggingURL | js}}",
metricsURL: "{{ .MetricsURL | js}}"
};
| [Write->[Write,Header,Get,Set,DetectContentType],HandlerFunc,Close,HasPrefix,Set,Add,HandleError,ServeHTTP,New,Errorf,MustCompile,Bytes,HasSuffix,NewWriter,Join,Execute,Contains,Must,Sort,Get,Split,Header,Write,Sprintf,TrimPrefix,Replace,Parse,EncodeToString,WriteHeader] | The configuration for the given object. KubernetesPrefix is the name of the Kubernetes API that is not in the list of. | Can you make a test to confirm this works nicely with `nil`? |
@@ -402,6 +402,7 @@ func (procStats *Stats) GetOne(pid int) (common.MapStr, error) {
}
e := procStats.getProcessEvent(p)
+ procStats.ProcsMap = newProcs
return e, nil
}
| [getSingleProcess->[matchProcess,getDetails],GetOne->[getProcessEvent],Get->[getProcessEvent]] | GetOne returns a single process by pid. | I don't fully get why is this updated, could you explain a bit about it? sorry, I'm not very familiar with this part of the code :innocent: |
@@ -146,10 +146,13 @@ class Core_Command extends WP_CLI_Command {
}
try {
- return Requests::get( $url, $headers, $options );
+ $request = Requests::get( $url, $headers, $options );
+ unlink( $options['verify'] );
+ return $request;
} catch( Requests_Exception $ex ) {
// Handle SSL certificate issues gracefully
WP_CLI::warning( $ex->getMessage() );
+ unlink( $options['verify'] );
$options['verify'] = false;
try {
return Requests::get( $url, $headers, $options );
| [Core_Command->[install->[_install],_request->[getMessage],download->[import,has,get_download_url,get_download_offer],_copy_overwrite_files->[isDir,getSubPathName],_extract->[extractTo,getFileName],update->[upgrade,get_download_url,get_error_code],_rmdir->[isDir,getRealPath],multisite_install->[_install,_multisite_convert],create_initial_blog->[set_permalink_structure,insert],_multisite_convert->[get_error_message,tables,get_error_code],multisite_convert->[_multisite_convert]]] | Makes a request to the given URL using cURL. | In both cases, let's only `unlink()` if we created the file previously. |
@@ -48,6 +48,5 @@ def execute(args, parser):
for_user = False
anaconda_prompt = on_win and args.anaconda_prompt
- anaconda_prompt = on_win # TODO: probably remove and leave --anaconda-prompt as a flag
return initialize(context.conda_prefix, selected_shells, for_user, args.system,
anaconda_prompt)
| [execute->[install,dashlist,initialize_dev,len,sorted,tuple,ArgumentError,initialize],getLogger] | Execute the command. | I must have put that in just for debug or something |
@@ -47,7 +47,7 @@ def _get_cdn_urls(version=None, minified=True):
container = dev_container if _DEV_PAT.match(version) else rel_container
if version.endswith(('dev', 'rc')):
- logger.warn("Getting CDN URL for local dev version will not produce usable URL")
+ logger.debug("Getting CDN URL for local dev version will not produce usable URL")
result = {
'js_files' : ['%s/%s/bokeh-%s%s.js' % (base_url, container, version, _min)],
| [Resources->[_js_paths->[_file_paths],_css_paths->[_file_paths],__init__->[_get_server_urls,_get_cdn_urls,_inline]],_get_cdn_urls->[_cdn_base_url],Resources] | Get the list of files to be downloaded from the CDN. | Thanks for this... was very annoying... |
@@ -108,6 +108,13 @@ interface ListBuilderInterface
*/
public function search($search);
+ /**
+ * @param array $filters
+ *
+ * @return ListBuilderInterface
+ */
+ public function filter($filters);
+
/**
* Adds a field by which the table is sorted.
*
| [No CFG could be retrieved] | Search for a string in the database. | you are not using `$filters` as plural in other places |
@@ -6,5 +6,11 @@ namespace NServiceBus
{
//TODO: remove when we update to 4.6 and can use Task.CompletedTask
public static readonly Task Completed = Task.FromResult(0);
+
+ // ReSharper disable once UnusedParameter.Global
+ public static void Ignore(this Task task)
+ {
+ // Intentionally left blank
+ }
}
}
\ No newline at end of file
| [TaskEx->[FromResult]] | A Task. CompletedTask is a Task that will be completed when the Task is completed. | We're intentionally ignoring the ignore :) |
@@ -74,7 +74,7 @@ class _SansIOHTTPPolicyRunner(HTTPPolicy, Generic[HTTPRequestType, HTTPResponseT
raise
else:
_await_result(self._policy.on_response, request, response)
- return response
+ return response # type: ignore
class _TransportRunner(HTTPPolicy):
| [Pipeline->[run->[_TransportRunner,send,_prepare_multipart],__init__->[_SansIOHTTPPolicyRunner,_TransportRunner],_prepare_multipart_mixed_request->[prepare_requests->[_prepare_multipart_mixed_request]],_prepare_multipart->[_prepare_multipart_mixed_request],__exit__->[__exit__],__enter__->[__enter__]],_SansIOHTTPPolicyRunner->[send->[send]],_TransportRunner->[send->[send]]] | Modifies the request and sends to the next policy in the chain. is the. | mypy is right to warn about this though. The annotation is wrong: this method now returns `Optional[PipelineResponse]` |
@@ -240,6 +240,10 @@ def read_events(filename, include=None, exclude=None):
event_list = event_list[1:]
event_list = pick_events(event_list, include, exclude)
+
+ if mask is not None:
+ event_list = _mask_trigs(event_list, mask)
+
return event_list
| [_find_events->[_find_stim_steps],read_events->[pick_events,_read_events_fif],find_stim_steps->[_find_stim_steps],find_events->[_find_events]] | Reads events from a file or FIF format. Write events to a file in binary FITS format. | I think `mask=0` is the same as no mask, right? In that case, I would do `mask=0` by default. You can then make the check `if mask != 0` here for efficiency, or remove it completely for simplicity. WDYT? |
@@ -35,9 +35,12 @@ public class TaskInfo<EntryType, StatusType>
private final String dataSource;
@Nullable
private final EntryType task;
+ @Nullable
+ private final String groupId;
public TaskInfo(
String id,
+ String groupId,
DateTime createdTime,
StatusType status,
String dataSource,
| [TaskInfo->[checkNotNull]] | Creates a class which represents a single which is used to store task information. Get the status of the entry. | This information is duplicate since it's already in `task`. The caller can get `groupId` by calling `getTask().getGroupId()`. |
@@ -1686,10 +1686,11 @@ int main(int argc, char *argv[])
{"randomize-endpoints", no_argument, 0, 'q'},
{"path", required_argument, 0, 'p'},
{"nopmix", no_argument, 0, 'n'},
+ {"use-daos-agent-env", no_argument, 0, 'u'},
{0, 0, 0, 0}
};
- c = getopt_long(argc, argv, "g:m:e:s:r:i:a:btnqp:",
+ c = getopt_long(argc, argv, "g:m:e:s:r:i:a:btnqp:u:",
long_options, NULL);
if (c == -1)
break;
| [main->[parse_message_sizes_string,parse_endpoint_string]] | Main entry point for CRT log. Parse command line options and return a list of options. Parse command line options and return a list of tuples. This function is called by parse_message_sizes_string and parse_message_sizes This function checks if the arguments are valid and if so checks if the arguments are valid. | should this not be just 'u' without ':'? ':' usually means there needs to be parameter after -u |
@@ -228,4 +228,18 @@ defineSuite(['Core/Color',
it('toString produces correct results', function() {
expect(new Color(0.1, 0.2, 0.3, 0.4).toString()).toEqual('(0.1, 0.2, 0.3, 0.4)');
});
+
+ it('can convert to and from RGBA', function() {
+ // exact values will depend on endianness, but it should round-trip.
+ var color = Color.fromBytes(0xFF, 0xCC, 0x00, 0xEE);
+
+ var rgba = color.toRgba();
+ expect(rgba).toBeGreaterThan(0);
+
+ var newColor = Color.fromRgba(rgba);
+ expect(color).toEqual(newColor);
+
+ var newRgba = newColor.toRgba();
+ expect(rgba).toEqual(newRgba);
+ });
});
| [toEqual,toThrow,fromBytes,new,toBeUndefined,clone,defineSuite,function,var,toBytes,toEqualEpsilon,it] | It produces correct results for Color objects. | This is true indeed. I was curious to see if anyone would notice. Good eye. |
@@ -133,8 +133,13 @@ class BigQueryClient
TableResult query(String sql)
{
+ JobInfo jobInfo = JobInfo.of(QueryJobConfiguration.of(sql));
try {
- return bigQuery.query(QueryJobConfiguration.of(sql));
+ Job job = bigQuery.create(jobInfo).waitFor();
+ if (job.getStatus().getError() != null) {
+ throw convertToBigQueryException(job.getStatus().getError());
+ }
+ return job.getQueryResults();
}
catch (InterruptedException e) {
Thread.currentThread().interrupt();
| [BigQueryClient->[getProjectId->[getProjectId],selectSql->[selectSql],update->[update],create->[create],getTable->[getTable],query->[query],fullTableName->[getTable]]] | Query BigQuery for a single table. | Can you explain why this fixes an issue. It is not obvious what is happening here (at least to me). |
@@ -0,0 +1,9 @@
+module LiquidTags
+ class UserSubscriptionTag < ApplicationRecord
+ resourcify
+ # This class exists to take advantage of Rolify for limiting authorization
+ # on internal reports.
+ # NOTE: It is not backed by a database table and should not be expected to
+ # function like a traditional Rails model
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | `Rolify` only works with model resources . I chose this setup to avoid naming conflicts and organize these into one directory. |
@@ -112,6 +112,14 @@ export class AmpSlideScroll extends BaseSlides {
/** @private {?../../../src/service/action-impl.ActionService} */
this.action_ = null;
+
+ /** @private {boolean} */
+ this.isDisableCssSnapExperimentOn_ = isExperimentOn(this.win,
+ 'slidescroll-disable-css-snap');
+
+ /** @private {boolean} */
+ this.shouldDisableCssSnap_ = startsWith(
+ platformFor(this.win).getIosVersionString(), '10.3');
}
/** @override */
| [AmpSlideScroll->[hideRestOfTheSlides_->[indexOf,setStyle],triggerAnalyticsEvent_->[dev,abs],updateViewportState->[dev],analyticsEvent_->[triggerAnalyticsEvent],constructor->[isIos,platformFor],cancelTouchEvents_->[stopPropagation],isLayoutSupported->[isLayoutSizeDefined],moveSlide->[dev],touchMoveHandler_->[timerFor],animateScrollLeft_->[resolve,interpolate,dev,numeric,animate,bezierCurve],onLayoutMeasure->[dev],showSlideWhenReady_->[user,isFinite,parseInt],layoutCallback->[resolve],scrollHandler_->[timerFor],buildSlides->[getAttribute,appendChild,actionServiceForDoc,args,toString,classList,getStyle],touchEndHandler_->[timerFor],showSlide_->[dev,setStyle,forEach,push],getNextSlideIndex_->[round]]] | private private methods. | bring in the experiment here and use one boolean. |
@@ -130,6 +130,7 @@ def get_ext_modules():
"numba/_npymath_exports.c",
"numba/_random.c",
"numba/_dictobject.c",
+ "numba/_str_lower.c",
"numba/mathnames.inc",],
**np_compile_args)
| [get_ext_modules->[check_file_at_path,is_building_wheel],find_packages->[rec->[rec],rec],get_ext_modules,find_packages,is_building] | Get a list of extensions that are available for the numba module. Adds a critical extension to the NPYUfunc. Check if a TBB file is available and if so set the necessary flags. Add extension for the Numba workqueue implementation. | Given this is `#include`'d in `helperlib.c` I don't think this is needed. |
@@ -863,11 +863,15 @@ export class AmpA4A extends AMP.BaseElement {
return true;
}
- removeChildren(this.element);
+ // Remove rendering frame, if it exists.
+ if (this.iframe) {
+ this.element.removeChild(this.iframe);
+ this.iframe = null;
+ }
+
this.adPromise_ = null;
this.adUrl_ = null;
this.creativeBody_ = null;
- this.iframe = null;
this.isVerifiedAmpCreative_ = false;
this.experimentalNonAmpCreativeRenderMethod_ =
platformFor(this.win).isIos() ? XORIGIN_MODE.SAFEFRAME : null;
| [AmpA4A->[constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,generateSentinel,platformFor,protectFunctionWrapper,now,SAFEFRAME,cryptoFor],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,user,getContextMetadata,getDefaultBootstrapBaseUrl,stringify,SAFEFRAME,reject,length],verifyCreativeSignature_->[cryptoKey,then,some,resolve,round,keys,dev,user,getMode,serviceName,reject,map],onLayoutMeasure->[status,size,dev,isAdPositionAllowed,getMode,isEnumValue,headers,creative,reject,CLIENT_CACHE,arrayBuffer,height,utf8Decode,byteLength,user,extensionsFor,cancellation,loadExtension,width,customElementExtensions,resolve,checkStillCurrent,bytes,signature,viewerForDoc],preconnectCallback->[forEach,getDefaultBootstrapBaseUrl],renderNonAmpCreative_->[NAMEFRAME,resolve,incrementLoadingAds,user,SAFEFRAME],viewportCallback->[setFriendlyIframeEmbedVisible],buildCallback->[AmpAdUIHandler],renderAmpCreative_->[installFriendlyIframeEmbed,customElementExtensions,setFriendlyIframeEmbedVisible,setStyle,round,dev,whenIniLoaded,customStylesheets,iframe,body,protectFunctionWrapper,win,installAnchorClickInterceptor,createElementWithAttributes,minifiedCreative,getTimingDataAsync,push,installUrlReplacementsForEmbed],getKeyInfoSets_->[resolve,isArray,keys,dev,xhrFor,user,endsWith,getMode,serviceName,isObject],getAmpAdMetadata_->[customElementExtensions,isArray,dev,parse,customStylesheets,lastIndexOf,minifiedCreative,slice,length,isObject],onCrossDomainIframeCreated->[dev],layoutCallback->[user,round,resolve,cancellation],renderOutsideViewport->[is3pThrottled,getAmpAdRenderOutsideViewport],isLayoutSupported->[isLayoutSizeDefined],forceCollapse->[dev,LOADED_NO_CONTENT,LOADING],renderViaCachedContentIframe_->[xhrFor,stringify,getContextMetadata],registerAlpHandler_->[viewerForDoc,document,handleClick,isExperimentOn],iframeRenderHelper_->[AmpAdXOriginIframeHandler,dev,protectFunctionWrapper,assign,createElementWithAttributes],getSigningServiceNames->[getMode],unlayoutCallback->[removeChildren,platformFor,NOT_LAID_OUT,SAFEFRAME],promiseErrorHandler_->[isCancellation,dev,user,ignoreStack,message,getMode,args,random],sendXhrRequest_->[xhrFor],BaseElement],apply,unshift] | UnlayoutCallback - called when the ad slot is cleared. | We're assuming that the frame is nested directly beneath the element which is likely fine. Other option would be to do this.iframe.parentElement.removeChild(this.iframe). At the very least, can you wrap this with dev().assert(...) as it should return the element that was removed |
@@ -65,13 +65,15 @@ public class UserUpdater {
private final DbClient dbClient;
private final UserIndexer userIndexer;
private final System2 system2;
+ private final SecurityRealmFactory realmFactory;
- public UserUpdater(NewUserNotifier newUserNotifier, Settings settings, DbClient dbClient, UserIndexer userIndexer, System2 system2) {
+ public UserUpdater(NewUserNotifier newUserNotifier, Settings settings, DbClient dbClient, UserIndexer userIndexer, System2 system2, SecurityRealmFactory realmFactory) {
this.newUserNotifier = newUserNotifier;
this.settings = settings;
this.dbClient = dbClient;
this.userIndexer = userIndexer;
this.system2 = system2;
+ this.realmFactory = realmFactory;
}
/**
| [UserUpdater->[deactivateUserByLogin->[deactivateUserByLogin],validateLoginFormat->[checkNotEmptyParam],index->[index],validatePasswords->[checkNotEmptyParam],validateNameFormat->[checkNotEmptyParam],updateUser->[update]]] | Creates a new user. Updates the user with the new user information. | what is this SecurityRealmFactory ? |
@@ -295,6 +295,9 @@ crt_rpc_complete(struct crt_rpc_priv *rpc_priv, int rc)
else
rpc_priv->crp_state = RPC_STATE_COMPLETED;
+ if (rc == -DER_TIMEDOUT)
+ d_tm_increment_counter(&rpc_timeouts, "RPC", "timeouts", NULL);
+
if (rpc_priv->crp_complete_cb != NULL) {
struct crt_cb_info cbinfo;
| [No CFG could be retrieved] | Initializes the given CRT context. END of function . | This function is called on the client side too. Could you please elaborate on what happens there? On the server side, i think we said that this should be reported per target. |
@@ -60,12 +60,9 @@ class WikiTablesParserPredictor(Predictor):
question_text = json_dict["question"]
table_rows = json_dict["table"].split('\n')
- # pylint: disable=protected-access
- tokenized_question = self._dataset_reader._tokenizer.tokenize(question_text.lower()) # type: ignore
# pylint: enable=protected-access
instance = self._dataset_reader.text_to_instance(question_text, # type: ignore
- table_rows,
- tokenized_question=tokenized_question)
+ table_rows)
return instance
@overrides
| [WikiTablesParserPredictor->[predict_json->[_json_to_instance]]] | Convert a JSON object to a single object. This function will get a list of all beam snapshots that have a in the model. | Does this need additional processing? Does this have to be formatted as a corenlp-tagged table? |
@@ -140,6 +140,8 @@ class SiteConfig < RailsSettings::Base
field :rate_limit_follow_count_daily, type: :integer, default: 500
field :rate_limit_comment_creation, type: :integer, default: 9
field :rate_limit_comment_antispam_creation, type: :integer, default: 1
+ # Explicitly defaults to 7 to accommodate DEV Top 7 Posts
+ field :rate_limit_mention_creation, type: :integer, default: 7
field :rate_limit_listing_creation, type: :integer, default: 1
field :rate_limit_published_article_creation, type: :integer, default: 9
field :rate_limit_published_article_antispam_creation, type: :integer, default: 1
| [SiteConfig->[local?->[include?],get_default->[get_field],freeze,exists?,cache_prefix,year,proc,current,local_image,field,table_name]] | Required fields for the MailChimp API. description of method rate_limit_feedback_message_creation. | @citizen428, maybe you know the answer to this: do I actually need to add this here? I added it because I followed the pattern that was set for the other values in `Settings::RateLimit`, but since this is a _new_ value, maybe it's not necessary? |
@@ -128,7 +128,12 @@ public class BeamIOPushDownRule extends RelOptRule {
// 1. Calc only does projects and renames.
// And
// 2. Predicate can be completely pushed-down to IO level.
- if (isProjectRenameOnlyProgram(program) && tableFilter.getNotSupported().isEmpty()) {
+ // And
+ // 3. And IO supports project push-down OR all fields are projected by a Calc.
+ if (isProjectRenameOnlyProgram(program)
+ && tableFilter.getNotSupported().isEmpty()
+ && (beamSqlTable.supportsProjects()
+ || calc.getRowType().getFieldCount() == calcInputRowType.getFieldCount())) {
// Tell the optimizer to not use old IO, since the new one is better.
call.getPlanner().setImportance(ioSourceRel, 0.0);
call.transformTo(ioSourceRel.copy(calc.getRowType(), newSchema.getFieldNames(), tableFilter));
| [BeamIOPushDownRule->[reMapRexNodeToNewInputs->[reMapRexNodeToNewInputs],BeamIOPushDownRule]] | onMatch - Find the n - th node in the input table that is used by the Checks if a new node can be added to the new schema. remap all projects to new inputs and add them to the list of new projects. | I think this needs to verify the order as well as the count. |
@@ -17,7 +17,6 @@ import (
"github.com/hashicorp/terraform-plugin-sdk/helper/hashcode"
"github.com/hashicorp/terraform-plugin-sdk/helper/resource"
"github.com/hashicorp/terraform-plugin-sdk/helper/schema"
- "github.com/terraform-providers/terraform-provider-aws/aws/internal/flatmap"
)
// cloudFrontRoute53ZoneID defines the route 53 zone ID for CloudFront. This
| [StringValueSlice,NewSet,UniqueId,BoolValue,Set,Add,Atoi,Itoa,Int64Value,GetOk,Len,Bool,Int64,Get,StringValue,Sprintf,List,Flatten,String,WriteString] | expandDistributionConfig creates a DistributionConfig from a Terraform resource data. Returns a description of the configuration options for a missing header. | The `aws/internal/flatmap` code can be fully removed as part of this PR. |
@@ -169,13 +169,13 @@ def match_detections(predicted_data, gt_data, min_iou):
matches = []
visited_gt = np.zeros(len(gt_bboxes), dtype=np.bool)
- for i in xrange(len(sorted_predicted_bboxes)):
+ for i in range(len(sorted_predicted_bboxes)):
predicted_id = sorted_predicted_bboxes[i][0]
predicted_bbox = sorted_predicted_bboxes[i][1]
best_overlap = 0.0
best_gt_id = -1
- for gt_id in xrange(len(gt_bboxes)):
+ for gt_id in range(len(gt_bboxes)):
if visited_gt[gt_id]:
continue
| [process_tracks->[extract_events],calculate_metrics->[match_events],match_detections->[iou],main->[split_to_tracks,process_tracks,calculate_metrics,match_detections,add_matched_predictions,load_annotation,load_detections],extract_events->[_extrapolate,_merge,_interpolate,_filter,_smooth],main] | Carry out matching between predicted and ground truth bboxes. Get all matches with a non - empty nanoseconds. | According usage of `range` function in the code it looks like we can eliminate the `range` function at all: replace `for i in range(len())` construction onto `for i, _ in enumerate()` and so on. |
@@ -3,7 +3,7 @@ package org.ray.api;
/**
* Handle of a Python actor.
*/
-public interface RayPyActor extends RayActor {
+public interface RayPyActor<A> extends RayActor, PyActorCall<A> {
/**
* @return Module name of the Python actor class.
| [No CFG could be retrieved] | Returns the module name. | The generic type `A` shouldn't be needed? |
@@ -124,7 +124,10 @@ public class JLineReader implements io.confluent.ksql.cli.console.LineReader {
@Override
public String readLine() throws IOException {
- final String line = lineReader.readLine(prompt);
+ final String line = lineReader
+ .readLine(prompt)
+ .replace("\n", "");
+
history.add(line);
history.save();
return line;
| [JLineReader->[KsqlExpander->[expandHistory->[expandHistory]],getHistory->[getHistory],readLine->[readLine],KsqlExpander]] | Read a line from the input stream. | Replace "" with " ". Without space the two lines will be concatenated without any space in between. |
@@ -99,7 +99,9 @@ type templateData struct {
// the directory that files will be written to, defaults to /var/lib/containers/router
WorkingDir string
// the routes
- State map[string]ServiceUnit
+ State map[string](ServiceAliasConfig)
+ // the service lookup
+ ServiceUnits map[string]ServiceUnit
// full path and file name to the default certificate
DefaultCertificate string
// peers
| [DeleteServiceUnit->[FindServiceUnit],RemoveRoute->[routeKey],AddRoute->[FindServiceUnit,routeKey],AddEndpoints->[FindServiceUnit],DeleteEndpoints->[FindServiceUnit]] | rateLimitedCommitFunction returns a channel that can be used to rate limit the number of create a new Router. | This makes it even harder to refactor to use route objects internally, which concerns me because we need to be moving in that direction. |
@@ -233,6 +233,8 @@ type PersistentVolumeSource struct {
// ISCSIVolumeSource represents an ISCSI resource that is attached to a
// kubelet's host machine and then exposed to the pod.
ISCSI *ISCSIVolumeSource `json:"iscsi"`
+ // CephFS represents a Ceph FS mount on the host that shares a pod's lifetime
+ CephFS *CephFSVolumeSource `json:"cephfs"`
}
type PersistentVolumeClaimVolumeSource struct {
| [No CFG could be retrieved] | Exactly one of its members must be set. Efficiently assign a single object to a sequence of objects. | Elsewhere in this PR, `omitempty` is added to the json tag for ISCSI, but not here. |
@@ -29,7 +29,17 @@ def CreateMapper(origin_model_part, destination_model_part, mapper_settings):
"integration_method" : "gauss_integration",
"number_of_gauss_points" : 5,
"in_plane_morphing" : false,
- "in_plane_morphing_settings" : {}
+ "in_plane_morphing_settings" : {},
+ "plane_symmetry" : false,
+ "plane_symmetry_settings" : {
+ "point" : [0.0, 0.0, 0.0],
+ "normal": [1.0, 0.0, 0.0]
+ },
+ "revolution" : false,
+ "revolution_settings" : {
+ "point" : [0.0, 0.0, 0.0],
+ "normal": [0.0, 0.0, 1.0]
+ }
}""")
mapper_settings.ValidateAndAssignDefaults(default_settings)
| [CreateMapper->[ValidateAndAssignDefaults,mapper_settings,MapperVertexMorphing,ValueError,Parameters,MapperVertexMorphingImprovedIntegration,InPlaneVertexMorphingMapper,MapperVertexMorphingMatrixFree]] | Creates a mapper for a morphing graph. | Wouldnt it makes more sense to leave every entry zero and then, during validation of the settings, make sure a reasonable value is specified? I mean, even if one wants to use those default settings it would be better to directly see them in the application settings rather an assuming the user knows this somewhat arbitrary default behavior. |
@@ -75,6 +75,7 @@ func Create(ctx *context.APIContext, form api.CreateOrgOption) {
// parameters:
// - name: organization
// in: body
+ // description: "'visibility' can be \"public\", \"limited\" or \"private\""
// required: true
// schema: { "$ref": "#/definitions/CreateOrgOption" }
// responses:
| [DeleteOrganization,UpdateUserCols,Status,GetOrganizations,Error,Written,IsErrUserAlreadyExist,IsErrNamePatternNotAllowed,ToOrganization,NotFound,GetUserByParams,IsErrNameReserved,JSON,CreateOrganization,CanCreateOrganization,HasOrgVisible] | ListUserOrgs list a user s organizations Get creates a new organization and returns it. | You should use enum to provide the valid values |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.