patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -128,6 +128,14 @@ class Task(object):
"""
return self.state == STATE_RUNNING
+ def was_accepted(self):
+ """
+ Indicates if the task was accepted by the agent.
+
+ :rtype: bool
+ """
+ return self.state == STATE_ACCEPTED
+
def is_completed(self):
"""
Indicates if the task has finished running and will not begin again,
| [Task->[__str__->[_],__init__->[append,Task,get]],Response->[is_async->[isinstance],__str__->[_]],BlockingReason->[__str__->[_]]] | Checks if the task is in the running state. | Can we use the verb "is" instead of "was", for consistency? |
@@ -101,7 +101,8 @@ export class Pass {
cancel() {
if (this.scheduled_ != -1) {
timer.cancel(this.scheduled_);
- this.scheduled_ = -1;
}
+ this.scheduled_ = -1;
+ this.nextTime_ = 0;
}
}
| [No CFG could be retrieved] | cancel the scheduled task. | Does this mean there was a bug? Is a unit test needed to verify this? Asking since this is a widely used class. |
@@ -198,6 +198,12 @@ const actions = (state, action, data) => {
case Action.TOGGLE_RTL:
return /** @type {!State} */ (Object.assign(
{}, state, {[StateProperty.RTL_STATE]: !!data}));
+ case Action.TOGGLE_SIDEBAR:
+ return /** @type {!State} */ (Object.assign(
+ {}, state, {[StateProperty.SIDEBAR_STATE]: !!data}));
+ case Action.TOGGLE_STORY_HAS_SIDEBAR:
+ return /** @type {!State} */ (Object.assign(
+ {}, state, {[StateProperty.CAN_SHOW_SIDEBAR_BUTTON]: !!data}));
case Action.TOGGLE_SUPPORTED_BROWSER:
return /** @type {!State} */ (Object.assign(
{}, state, {[StateProperty.SUPPORTED_BROWSER_STATE]: !!data}));
| [No CFG could be retrieved] | Get the state of the action. private state for action. | Nit: I think the `STORY` part of the name is not needed |
@@ -47,8 +47,16 @@ public class SortBlob extends AbstractTransientBlobComputation {
public static final String NAME = "sortBlob";
+ public static final String SORT_PARAMETER = "sort";
+
+ protected static final String ZIP_STREAM = OUTPUT_1;
+
+ protected static final String EXPOSE_BLOB_STREAM = OUTPUT_2;
+
+ protected static final int NB_OUTPUT_STREAMS = 2;
+
public SortBlob() {
- super(NAME);
+ super(NAME, NB_OUTPUT_STREAMS);
}
@Override
| [SortBlob->[processRecord->[flush,produceRecord,decode,storeBlob,getBlob,toFile,getTransientStoreKey,getCommandId,of,copy,getDataBucketCodec,askForCheckpoint,getAction,error,sort,getStream,getData,getCount,getDataAsString,delete,DataBucket,createTemp,write,FileBlob,FileOutputStream,getFooter,encode,getHeader],sort->[createTemp,error,FileBlob,sort,getFile,toFile],getLogger]] | Process a record. | `zip` should be a local variable, not a field. |
@@ -7,15 +7,15 @@ import numpy as np
from ..parallel import parallel_func
from ..io.proj import make_projector_info
from ..io.pick import pick_types
-from ..utils import logger, verbose, _time_mask
+from ..utils import logger, verbose, deprecated, _time_mask
@verbose
+@deprecated('This will be deprecated in release v0.13, see psd_ functions.')
def compute_raw_psd(raw, tmin=0., tmax=None, picks=None, fmin=0,
fmax=np.inf, n_fft=2048, n_overlap=0,
proj=False, n_jobs=1, verbose=None):
"""Compute power spectral density with average periodograms.
-
Parameters
----------
raw : instance of Raw
| [compute_raw_psd->[int,make_projector_info,parallel,parallel_func,info,arange,len,my_pwelch,time_as_index,float,_check_nfft,dot,array],_pwelch->[welch_fun],_compute_psd->[psd,array],compute_epochs_psd->[int,make_projector_info,parallel_func,_time_mask,get_data,arange,len,zip,empty,array_split,my_pwelch,info,slice,float,pick_types,_check_nfft,dot,parallel]] | Compute power spectral density with average periodograms. Get the n - nanoseconds windowed data. | typically we don't touch lines unless you add / remove logic or make a pep8 fix. |
@@ -3253,6 +3253,8 @@ namespace System.Threading.Tasks
lock (continuations) { }
int continuationCount = continuations.Count;
+ bool etwIsEnabled = log.IsEnabled();
+
// Fire the asynchronous continuations first. However, if we're not able to run any continuations synchronously,
// then we can skip this first pass, since the second pass that tries to run everything synchronously will instead
// run everything asynchronously anyway.
| [CompletionActionInvoker->[Execute->[Invoke]],Task->[InternalCancel->[AtomicStateUpdate],FinishStageTwo->[RemoveFromActiveTasks,SetCompleted,UnregisterCancellationCallback],RecordInternalCancellationRequest->[AddException,RecordInternalCancellationRequest],SetNotificationForWaitCompletion->[AtomicStateUpdate],AddExceptionsForCompletedTask->[GetExceptions,UpdateExceptionObservedStatus],Wait->[NotifyDebuggerOfWaitCompletionIfNecessary,ThrowIfExceptional,Wait],MarkStarted->[AtomicStateUpdate],TrySetException->[AtomicStateUpdate,Finish,AddException],AddTaskContinuation->[AddTaskContinuationComplex],WhenAny->[WhenAny,ContinueWith,FromResult],SpinThenBlockingWait->[Wait],TwoTaskWhenAnyPromise->[Invoke->[RemoveFromActiveTasks,RemoveContinuation,TrySetResult],AddToActiveTasks,AddCompletionAction,RemoveContinuation],ContinueWithCore->[AssignCancellationToken],WaitAllBlockingCore->[Wait,AddCompletionAction,RemoveContinuation],WaitAnyCore->[Wait],ProcessChildCompletion->[FinishStageTwo],DelayPromiseWithCancellation->[CompleteCanceled->[Cleanup,TrySetCanceled],Cleanup->[Dispose,Cleanup]],InternalRunSynchronously->[MarkStarted],GetDelegatesFromContinuationObject->[GetDelegateContinuationsForDebugger,Invoke,GetDelegatesFromContinuationObject],InternalWaitCore->[WrappedTryRunInline],TrySetResult->[AtomicStateUpdate,SetCompleted,NotifyParentIfPotentiallyAttachedTask],FromCanceled->[TrySetCanceled],WhenAllPromise->[Invoke->[TrySetResult,SetNotificationForWaitCompletion,GetExceptionDispatchInfos,RemoveFromActiveTasks,TrySetException,GetCancellationExceptionDispatchInfo,TrySetCanceled],Invoke,AddToActiveTasks,AddCompletionAction,AnyTaskRequiresNotifyDebuggerOfWaitCompletion],ExecuteWithThreadLocal->[Finish],CancellationCleanupLogic->[FinishStageThree,SetCompleted,UnregisterCancellationCallback,RemoveFromActiveTasks],NotifyDebuggerOfWaitCompletion->[SetNotificationForWaitCompletion],ThrowIfExceptional->[GetExceptions],RunOrQueueCompletionAction->[Invoke],ScheduleAndStart->[MarkStarted,AddToActiveTasks],HandleException->[AddException],FromException->[TrySetException],AddCompletionAction->[Invoke],AddExceptionsFromChildren->[AddException],Run->[Run,Task],DelayPromise->[CompleteTimedOut->[RemoveFromActiveTasks,TrySetResult],AddToActiveTasks],Start->[Start],AddException->[AddException],GetExceptionDispatchInfos->[GetExceptionDispatchInfos],FinishSlow->[AtomicStateUpdate],WaitAllCore->[WrappedTryRunInline,NotifyDebuggerOfWaitCompletionIfNecessary],Dispose->[Dispose],TrySetCanceled->[CancellationCleanupLogic,RecordInternalCancellationRequest,AtomicStateUpdate,TrySetCanceled],ExecuteEntry->[AtomicStateUpdate],NewId],UnwrapPromise->[ProcessInnerTask->[AddCompletionAction,TrySetCanceled,TrySetFromTask],InvokeCoreAsync->[InvokeCore],TrySetFromTask->[TrySetResult,GetExceptionDispatchInfos,RemoveFromActiveTasks,TrySetException,GetCancellationExceptionDispatchInfo,TrySetCanceled],AddToActiveTasks,AddCompletionAction]] | This method is called when a continuation is needed. It is called by the TaskContinuation This method runs the task asynchronously if it is not already running. This method runs the next continuation in the list. | Are we concerned that `IsEnabled()` may have changed in-between the above check and now? I assume that is why the existing code is written the way it was. cc @stephentoub |
@@ -179,4 +179,18 @@ public abstract class AbstractTask implements Task
{
return toolbox.getTaskActionClient().submit(new LockListAction());
}
+
+ @Override
+ @JsonProperty
+ public Map<String, Object> getContext()
+ {
+ return context;
+ }
+
+ @Override
+ public Object getContextValue(String key)
+ {
+ return context == null ? null : context.get(key);
+ }
+
}
| [AbstractTask->[hashCode->[hashCode],toString->[toString],success->[success,getId],equals->[equals]]] | Get all the locks for the current task. | not sure if we are gaining anything by using generics in this case? |
@@ -75,6 +75,10 @@ class Configuration:
# Normalize config
if 'internals' not in config:
config['internals'] = {}
+ # TODO: This can be deleted along with removal of deprecated
+ # experimental settings
+ if 'ask_strategy' not in config:
+ config['ask_strategy'] = {}
# validate configuration before returning
logger.info('Validating configuration ...')
| [Configuration->[_process_common_options->[_process_logging_options],_process_optimize_options->[_process_datadir_options],load_config->[load_from_files],from_files->[get_config,Configuration]]] | Load configuration from files. | Are you sure that this can be removed after remoing ot the experimental settings? assuming a user doesn't set this in config (but in strategy instead) - then this dict would be missing completely, which means that we'll need to handle missing this dict throughout the code ... ? |
@@ -169,6 +169,8 @@ class Indexation_Integration implements Integration_Interface {
/**
* Renders the indexation modal.
*
+ * @codeCoverageIgnore It echos the indexation modal.
+ *
* @return void
*/
public function render_indexation_modal() {
| [Indexation_Integration->[get_total_unindexed->[get_total_unindexed]]] | Renders the indexation modal. | Please write test for this. You can test this by using `expectOutput` or `expectOutputContains` |
@@ -30,7 +30,7 @@ type paddedMutex struct {
// the same mutex twice).
type fingerprintLocker struct {
fpMtxs []paddedMutex
- numFpMtxs uint
+ numFpMtxs uint32
}
// newFingerprintLocker returns a new fingerprintLocker ready for use. At least
| [Lock->[HashFP,Lock],Unlock->[HashFP,Unlock],Sizeof] | newFingerprintLocker returns a new fingerprintLocker that can be used to lock the given. | Does this really make enough difference? Just curious if it does. |
@@ -47,11 +47,15 @@ using namespace pybind11;
void AddCustomConstitutiveLawsToPython(pybind11::module& m)
{
-
+
class_< TrussConstitutiveLaw, typename TrussConstitutiveLaw::Pointer, ConstitutiveLaw >
(m, "TrussConstitutiveLaw").def(init<>() )
;
+ class_< TrussPlasticityConstitutiveLaw, typename TrussPlasticityConstitutiveLaw::Pointer, ConstitutiveLaw >
+ (m, "TrussPlasticityConstitutiveLaw").def(init<>() )
+ ;
+
class_< BeamConstitutiveLaw, typename BeamConstitutiveLaw::Pointer, ConstitutiveLaw >
(m, "BeamConstitutiveLaw").def(init<>() )
;
| [AddCustomConstitutiveLawsToPython->[]] | AddCustomConstitutiveLawsToPython adds custom constitutive law private int nul_names = 0 ;. | please do not introduce whitespace changes => I recommend setting your ide to deleting trailing whitespaces on saving |
@@ -115,7 +115,7 @@ final class IdentifiersExtractor implements IdentifiersExtractorInterface
// TODO: php 8 remove method_exists
if (is_scalar($identifierValue) || method_exists($identifierValue, '__toString') || $identifierValue instanceof \Stringable) {
- return (string) $identifierValue;
+ return (string)$identifierValue;
}
// TODO: remove this in 3.0
| [IdentifiersExtractor->[resolveIdentifierValue->[getIdentifierValue]]] | Resolves the identifier value. | This should be reverted too. PHP CS Fixer should do it automatically. |
@@ -273,6 +273,13 @@ static int dw_dma_start(struct dma_chan_data *channel)
irq_local_disable(flags);
+ /*
+ * it's a case after pause-release, then dma already is in active state after release
+ * but dai still try to re-start controller, because this step is needed for other dmac.
+ */
+ if (channel->status == COMP_STATE_ACTIVE)
+ goto out;
+
/* check if channel idle, disabled and ready */
if ((channel->status != COMP_STATE_PREPARE &&
channel->status != COMP_STATE_PAUSED) ||
| [int->[dw_dma_interrupt_status,DW_DSR,spin_unlock_irq,dw_dma_interrupt_mask,atomic_init,ARRAY_SIZE,dw_dma_stop,DW_FIFO_CHy,DW_CFG_HIGH,platform_dw_dma_set_transfer_size,dw_dma_start,DW_CFG_LOW,dw_dma_avail_data_size,DW_FIFO_CHx,dcache_writeback_region,notifier_event,DW_DMA_LLI_ADDRESS,rfree,rmalloc,dma_base,irq_local_enable,bzero,dw_dma_verify_transfer,DW_CTRL_LOW,dw_dma_interrupt_clear,DW_CHAN_UNMASK,DW_CTLH_DONE,DW_CTLL_DST_WIDTH,pm_runtime_get_sync,dma_reg_read,DW_CFGH_DST,DW_LLP,platform_dw_dma_llp_config,DW_CTLL_SRC_MSIZE,poll_for_register_delay,platform_dw_dma_set_class,DW_CTRL_HIGH,tr_err,DW_DSR_DSC,DW_CTLL_DST_MSIZE,DW_CHAN_MASK,dw_dma_interrupt_unmask,dw_dma_increment_pointer,dw_dma_mask_address,timer_get,spin_lock_irq,dma_chan_get_data,pm_runtime_put_sync,platform_dw_dma_llp_disable,DW_CHAN,DW_CFGH_SRC,DW_DSR_DSI,platform_dw_dma_llp_enable,DW_DAR,DW_SAR,tr_info,dw_dma_setup,dma_chan_set_data,dw_dma_free_data_size,rzalloc,cpu_get_id,dma_reg_write,tr_dbg,timer_get_system,irq_local_disable,DW_CTLL_SRC_WIDTH],uint32_t->[DW_CHAN,dma_reg_read],inline->[DW_CTRL_HIGH,DW_SAR,DW_CTRL_LOW,DW_CHAN_UNMASK,dma_reg_read,DW_CFG_HIGH,dma_reg_write,dma_chan_get_data,DW_CFG_LOW,DW_CHAN,DW_DAR],dma_chan_data->[tr_info,spin_unlock_irq,tr_err,spin_lock_irq,notifier_register,atomic_add],void->[tr_info,dw_dma_interrupt_mask,spin_unlock_irq,DW_CHAN_UNMASK,atomic_sub,DW_CTLH_DONE,DW_CHAN_MASK,notifier_unregister_all,spin_lock_irq,dma_reg_write,dma_chan_get_data,dcache_invalidate_region,dw_dma_channel_put_unlocked,dcache_writeback_region,platform_dw_dma_lli_get,DW_CHAN,rfree],DECLARE_TR_CTX,DECLARE_SOF_UUID,SOF_UUID] | Start a DMA channel. program all registers that are not part of the state machine enable the channel. | @ktrzcinx what makes you think the SSP is managed with a timer-based scheduling? It's clearly not true for legacy platforms. I also don't know what this means for SSP slave cases. |
@@ -46,7 +46,7 @@ class AddUserEmailForm
attr_reader :success, :email_address
def valid_form?
- @allow && valid?
+ valid?
end
def process_successful_submission
| [AddUserEmailForm->[existing_user->[find_with_email,new],user->[new],process_successful_submission->[call,save!],valid_form?->[valid?],extra_analytics_attributes->[merge],email_address_record->[confirmation_token,new,find_with_email,uuid,now,confirmation_sent_at,id],model_name->[new],submit->[email_address_record,valid_form?,messages,new],attr_reader,attr_writer,include]] | Checks if a node ID is valid and if so sends an email to the user. | maybe we don't even need a separate `valid_form?` method now? |
@@ -1,4 +1,7 @@
-<% if @current_user.admin? %>
+<% if @current_user.ta? %>
+ <% manage_assignments = GraderPermission.find_by(user_id: @current_user.id).manage_assignments %>
+<% end %>
+<% if @current_user.admin? || @current_user.ta?%>
<% if (controller.controller_name == 'assignments' &&
controller.action_name != 'index' &&
controller.action_name != 'new' &&
| [No CFG could be retrieved] | Displays a list of all the pages of a n - node node that is a part of Displays a list of all possible n - node links for the user. | Please use a policy |
@@ -48,15 +48,16 @@ import org.springframework.util.xml.DomUtils;
*/
public class GatewayParser implements BeanDefinitionParser {
+ private static final String NAME_ATTRIBUTE = "name";
+
private final MessagingGatewayRegistrar registrar = new MessagingGatewayRegistrar();
@Override
- @SuppressWarnings("rawtypes")
public BeanDefinition parse(final Element element, ParserContext parserContext) {
boolean isNested = parserContext.isNested();
final Map<String, Object> gatewayAttributes = new HashMap<String, Object>();
- gatewayAttributes.put("name", element.getAttribute(AbstractBeanDefinitionParser.ID_ATTRIBUTE));
+ gatewayAttributes.put(NAME_ATTRIBUTE, element.getAttribute(AbstractBeanDefinitionParser.ID_ATTRIBUTE));
gatewayAttributes.put("defaultPayloadExpression", element.getAttribute("default-payload-expression"));
gatewayAttributes.put("defaultRequestChannel",
element.getAttribute(isNested ? "request-channel" : "default-request-channel"));
| [GatewayParser->[parse->[getRegistry,createExpressionDefinitionFromValueOrExpression,size,toArray,genericBeanDefinition,getChildElementsByTagName,registerBeanDefinition,put,hasText,setValueIfAttributeDefined,isEmpty,getAttribute,getBeanDefinition,parse,hasLength,addPropertyValue,hasAttribute,state,isNested,add],MessagingGatewayRegistrar]] | Parses the given element and returns the bean definition. This method creates a BeanDefinition for each attribute in the XML response. This method is called to parse the header element and create the gateway bean definition. | There is a `AbstractBeanDefinitionParser.NAME_ATTRIBUTE` instead which we may consider to reuse... |
@@ -122,4 +122,15 @@ public abstract class MessageToMessageDecoder<I, O>
* @throws Exception is thrown if an error accour
*/
protected abstract O decode(ChannelHandlerContext ctx, I msg) throws Exception;
+
+ /**
+ * Is called after a message was processed via {@link #decode(ChannelHandlerContext, Object)} to free
+ * up any resources that is held by the inbound message. You may want to override this if your implementation
+ * just pass-through the input message or need it for later usage.
+ *
+ * @throws Exception thrown when an error accour
+ */
+ protected void freeInboundMessage(I msg) throws Exception {
+ ChannelHandlerUtil.freeMessage(msg);
+ }
}
| [MessageToMessageDecoder->[newInboundBuffer->[messageBuffer],inboundBufferUpdated->[unfoldAndAdd,inboundMessageBuffer,isDecodable,poll,decode,DecoderException,fireInboundBufferUpdated,addToNextInboundBuffer,fireExceptionCaught],isDecodable->[acceptMessage],acceptedMessageTypes]] | Decodes the message. | Exception is by contract thrown when an error occurs. This description is unnecessary. |
@@ -524,7 +524,11 @@ def test_030_db_sanity_from_another_process(mutable_database):
with mutable_database.write_transaction():
_mock_remove('mpileaks ^zmpi')
- p = multiprocessing.Process(target=read_and_modify, args=())
+ if sys.version_info >= (3,): # novm
+ p = multiprocessing.get_context('fork').Process(
+ target=read_and_modify, args=())
+ else:
+ p = multiprocessing.Process(target=read_and_modify, args=())
p.start()
p.join()
| [_check_db_sanity->[_check_merkleiness],_print_ref_counts->[add_rec],_check_remove_and_add_package->[_check_db_sanity],test_110_no_write_with_exception_on_install->[fail_while_writing->[_mock_install],fail_while_writing],test_115_reindex_with_packages_not_in_repo->[_check_db_sanity],test_060_remove_and_add_root_package->[_check_remove_and_add_package],test_026_reindex_after_deprecate->[_check_db_sanity],test_025_reindex->[_check_db_sanity],test_030_db_sanity_from_another_process->[read_and_modify->[_check_db_sanity,_mock_remove]],test_020_db_sanity->[_check_db_sanity],test_070_remove_and_add_dependency_package->[_check_remove_and_add_package],test_100_no_write_with_exception_on_remove->[fail_while_writing->[_mock_remove],fail_while_writing]] | Test for bug in MDB with MDB bug in MDB. | Refactor using `ForkProcess` to be less duplicative. |
@@ -0,0 +1,16 @@
+package org.baeldung.security;
+
+import org.springframework.stereotype.Controller;
+import org.springframework.web.bind.annotation.RequestMapping;
+
+import javax.servlet.http.HttpServletRequest;
+import javax.servlet.http.HttpServletResponse;
+
+@Controller
+@RequestMapping("/")
+public class HomeController {
+ @RequestMapping("")
+ public String home(HttpServletRequest request, HttpServletResponse response) {
+ return "home";
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | `request` and `response` here are unnecessary. Let's remove them so that readers can spend more time looking at the relevant code in your article and less at the boilerplate. |
@@ -231,7 +231,13 @@ public class FileAwareInputStreamDataWriter extends InstrumentedDataWriter<FileA
if (isInstrumentationEnabled()) {
copier.withCopySpeedMeter(this.copySpeedMeter);
}
- this.bytesWritten.addAndGet(copier.copy());
+ long numBytes = copier.copy();
+ long fileSize = copyableFile.getFileStatus().getLen();
+ if (fileSize > 0 && numBytes != fileSize) {
+ throw new IOException(String.format("Number of bytes copied doesn't match filesize for file %s.",
+ copyableFile.getOrigin().getPath()));
+ }
+ this.bytesWritten.addAndGet(numBytes);
if (isInstrumentationEnabled()) {
log.info("File {}: copied {} bytes, average rate: {} B/s", copyableFile.getOrigin().getPath(),
this.copySpeedMeter.getCount(), this.copySpeedMeter.getMeanRate());
| [FileAwareInputStreamDataWriter->[setRecursivePermission->[safeSetPathPermission],writeImpl->[writeImpl],commit->[setFilePermissions,getStagingFilePath,getOutputFilePath],getOutputFilePath->[getPartitionOutputRoot],ensureDirectoryExists->[addExecutePermissionToOwner,ensureDirectoryExists]]] | Write the given input stream to the given path. This method creates a StreamCopier and copies the contents of the input stream into the output. | I think this check will break if encryption is turned on in the OutputStream -- can you make sure there is a test verifying this? |
@@ -133,6 +133,7 @@ public abstract class AbstractReferenceCountedByteBuf extends AbstractByteBuf {
int rawCnt = nonVolatileRawCnt(), realCnt = toLiveRealCnt(rawCnt, decrement);
if (decrement == realCnt) {
if (refCntUpdater.compareAndSet(this, rawCnt, 1)) {
+ maxCapacity(-rawMaxCapacity());
deallocate();
return true;
}
| [AbstractReferenceCountedByteBuf->[release0->[nonVolatileRawCnt],refCnt->[realRefCnt],retain0->[realRefCnt],internalRefCnt->[realRefCnt,nonVolatileRawCnt]]] | Release a non - final non - volatile counter. | should we assert that this value will never be positive ? |
@@ -172,6 +172,9 @@ class Geant4(CMakePackage):
'-DQT_QMAKE_EXECUTABLE=%s' %
spec['qt'].prefix.bin.qmake)
+ if '+vtk' in spec:
+ options.append('-DGEANT4_USE_VTK=ON')
+
# Python
if spec.version > Version('10.6.1'):
options.append(self.define_from_variant('GEANT4_USE_PYTHON',
| [Geant4->[cmake_args->[join_path,append,Version,format,define_from_variant],depends_on,extends,conflicts,version,patch,variant]] | Return a list of CMake command line options for the object. Returns a list of options that can be used to specify a specific option for the Gear. | Does define from variant not work when the variant is optional? I would use that shortcut and wrap in a 'if spec.version >= 11'. |
@@ -291,6 +291,16 @@ OSSL_STORE_INFO *OSSL_STORE_INFO_new_PKEY(EVP_PKEY *pkey)
return info;
}
+OSSL_STORE_INFO *OSSL_STORE_INFO_new_PUBKEY(EVP_PKEY *pkey)
+{
+ OSSL_STORE_INFO *info = store_info_new(OSSL_STORE_INFO_PUBKEY, pkey);
+
+ if (info == NULL)
+ OSSL_STOREerr(OSSL_STORE_F_OSSL_STORE_INFO_NEW_PUBKEY,
+ ERR_R_MALLOC_FAILURE);
+ return info;
+}
+
OSSL_STORE_INFO *OSSL_STORE_INFO_new_CERT(X509 *x509)
{
OSSL_STORE_INFO *info = store_info_new(OSSL_STORE_INFO_CERT, x509);
| [ossl_store_info_new_EMBEDDED->[OSSL_STORE_INFO_free]] | OSSL_STORE_INFO_NEW_PKEY OSSL_STORE_INFO_. | This is unnecessary. An `EVP_PKEY` is an `EVP_PKEY` is an `EVP_PKEY`. It's *contents* determines if it only contains a public key or if it also contains the private bits, and `EVP_PKEY_print_private` is perfectly capable of displaying the key correctly depending on its content. |
@@ -756,7 +756,7 @@ class NumpyArrayInitializer(Initializer):
values = [int(v) for v in self._value.flat]
else:
raise ValueError("Unsupported dtype %s", self._value.dtype)
- if self._value.size > 1024 * 1024 * 5:
+ if self._value.size > 1024 * 1024 * 1024:
raise ValueError("The size of input is too big. Please consider "
"saving it to file and 'load_op' to load it")
op = block._prepend_op(
| [init_on_cpu->[force_init_on_cpu],MSRAInitializer->[__call__->[_compute_fans]],ConstantInitializer->[__call__->[force_init_on_cpu]],XavierInitializer->[__call__->[_compute_fans]]] | Adds constant initialization ops for a variable in which to be initialized by a variable . | why change this? |
@@ -4,7 +4,10 @@
using System.Collections.Generic;
using System.Linq;
using Logging;
+ using System.ComponentModel;
+ [Obsolete("This is a prototype API. May change in minor version releases.")]
+ [EditorBrowsable(EditorBrowsableState.Never)]
public class MessageMetadataRegistry
{
public MessageMetadata GetMessageDefinition(Type messageType)
| [MessageMetadataRegistry->[PlaceInMessageHierarchy->[Count,BaseType,IsInterface],GetAllMessages->[Values],GetMessageTypes->[GetType,MessageType,DebugFormat,WarnFormat,TryGetValue,FirstOrDefault,Count,IsNullOrEmpty,FullName,Id,Publish,EnclosedMessageTypes,Split,Add,MessageIntent],MessageMetadata->[NewLine,FullName,Format,TryGetValue],HasDefinitionFor->[ContainsKey],GetParentTypes->[BaseType,GetInterfaces],RegisterMessageType->[IsExpressMessageType,ToList,Concat,MessageHierarchy,TimeToBeReceivedAction,Recoverable],GetLogger]] | Get the message definition for the given message type. | "This is a prototype API" really? `MessageMetadataRegistry` has been around for a long time! |
@@ -304,7 +304,7 @@ func (wh *webhook) mustInject(pod *corev1.Pod, namespace string) (bool, error) {
log.Error().Err(errNamespaceNotFound).Msgf("Error retrieving namespace %s", namespace)
return false, err
}
- nsInjectAnnotationExists, nsInject, err := isAnnotatedForInjection(ns.Annotations)
+ nsInjectAnnotationExists, nsInject, err := isAnnotatedForInjection(ns.Annotations, ns.Kind, ns.Name)
if err != nil {
log.Error().Err(err).Msg("Error determining if namespace %s is enabled for sidecar injection")
return false, err
| [podCreationHandler->[getAdmissionReqResp],mustInject->[isNamespaceInjectable]] | mustInject checks if the pod is annotated for injection and if it is enabled for injection. | Lets just pass the entire ns object here? |
@@ -171,6 +171,12 @@ public interface Expr
throw Exprs.cannotVectorize(this);
}
+ @Override
+ default byte[] getCacheKey()
+ {
+ return new CacheKeyBuilder(EXPR_CACHE_KEY).appendString(stringify()).build();
+ }
+
/**
* Mechanism to supply input types for the bindings which will back {@link IdentifierExpr}, to use in the aid of
* inferring the output type of an expression with {@link #getOutputType}. A null value means that either the binding
| [BindingAnalysis->[withScalarArguments->[BindingAnalysis,getIdentifierExprIfIdentifierExpr],with->[analyzeInputs,BindingAnalysis,with],withArrayArguments->[BindingAnalysis,getIdentifierExprIfIdentifierExpr],withArrayOutput->[BindingAnalysis],removeLambdaArguments->[BindingAnalysis],withArrayInputs->[BindingAnalysis]],canVectorize->[canVectorize],areScalar->[getOutputType,areScalar],areNumeric->[getOutputType,areNumeric]] | buildVectorized - build vectorized processor. | `stringify` is somewhat expensive and this will be called once per segment. Can we cache it, like we cache the original and parsed expressions? Best way I can think of right now is to implement that caching in ExpressionFilter, ExpressionVirtualColumn, etc. Btw, that caching should be lazy, for two reasons: - otherwise we'll waste time computing it when it'll never be needed - sometimes the cache key will be incomputable (lookup doesn't exist, or error retrieving it) and we don't want that to totally prevent instantiating the VirtualColumn or DimFilter objects |
@@ -119,7 +119,7 @@ CSP_REPORT_URI = '/csp-report'
HTTP_GA_SRC = 'http://www.google-analytics.com'
CSP_FRAME_SRC += ('https://www.sandbox.paypal.com',)
CSP_IMG_SRC += (HTTP_GA_SRC,)
-CSP_SCRIPT_SRC += (HTTP_GA_SRC,)
+CSP_SCRIPT_SRC += (HTTP_GA_SRC, "'self'")
# If you have settings you want to overload, put them in a local_settings.py.
try:
| [path,sub,get,getenv,join] | Get the CSP report URI for a given neccesary element. | I am just forgetful of the settings maze here. This is for local dev only and _won't_ be used elsewhere (prod where CDN is used), right? |
@@ -142,6 +142,7 @@ class CheckoutLineInput(graphene.InputObjectType):
class CheckoutCreateInput(graphene.InputObjectType):
+ channel_slug = graphene.String(description="Channel slug for current checkout.")
lines = graphene.List(
CheckoutLineInput,
description=(
| [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save]],CheckoutCreate->[process_checkout_lines->[check_lines_quantity],clean_input->[retrieve_billing_address,retrieve_shipping_address,process_checkout_lines],Arguments->[CheckoutCreateInput],perform_mutation->[save,CheckoutCreate,clean_input],save->[save,save_addresses]],CheckoutShippingAddressUpdate->[process_checkout_lines->[check_lines_quantity],perform_mutation->[update_checkout_shipping_method_if_invalid,save,process_checkout_lines,CheckoutShippingAddressUpdate]],update_checkout_shipping_method_if_invalid->[clean_shipping_method],CheckoutLineDelete->[perform_mutation->[update_checkout_shipping_method_if_invalid,CheckoutLineDelete]],CheckoutShippingMethodUpdate->[perform_mutation->[CheckoutShippingMethodUpdate,save,clean_shipping_method]],CheckoutRemovePromoCode->[perform_mutation->[CheckoutRemovePromoCode]],CheckoutAddPromoCode->[perform_mutation->[CheckoutAddPromoCode]],CheckoutEmailUpdate->[perform_mutation->[save,CheckoutEmailUpdate]],CheckoutLinesAdd->[perform_mutation->[CheckoutLinesAdd,update_checkout_shipping_method_if_invalid,check_lines_quantity]],CheckoutComplete->[perform_mutation->[CheckoutComplete]],CheckoutCustomerAttach->[perform_mutation->[save,CheckoutCustomerAttach]],CheckoutCustomerDetach->[perform_mutation->[save,CheckoutCustomerDetach]]] | Adds a new item to the checkout. Check out if a new cart checkout was created or the current active checkout was returned. | Maby it should be required? |
@@ -60,7 +60,8 @@ func (n NodeAuthorizerAttributesGetter) GetRequestAttributes(u user.Info, r *htt
APIVersion: "v1",
APIGroup: "",
Verb: apiVerb,
- Resource: "nodes/proxy",
+ Resource: "nodes",
+ Subresource: "proxy",
ResourceName: n.nodeName,
URL: r.URL.Path,
}
| [GetRequestAttributes->[KubernetesAuthorizerAttributes,V,Infof],HasPrefix,NewAuthorizer,TrimSuffix] | GetRequestAttributes returns the attributes of the request. | the ones below referenced as constants need changing as well |
@@ -24,7 +24,7 @@ class BuildMode(object):
return
assert isinstance(params, list)
- if len(params) == 0:
+ if len(params) == 0 or "*" in params or "" in params:
self.all = True
else:
for param in params:
| [BuildMode->[allowed->[info],forced->[remove,fnmatchcase,copy_clear_rev,repr,info],report_matches->[error],__init__->[list,append,ConanException,endswith,len,replace,isinstance]]] | Initialize the object. | If `--build`, `--build=` or `--build=*` is passed, build ALL from sources. |
@@ -17,6 +17,7 @@ import re
import requests
import sys
+from acme import crypto_util
from acme import errors
from acme import jws
from acme import messages
| [ClientV2->[new_order->[_authzr_from_response],new_account->[_regr_from_response],poll_authorizations->[_authzr_from_response]],Client->[agree_to_tos->[update_registration],request_challenges->[_authzr_from_response],check_cert->[_get_cert],fetch_chain->[_get_cert],refresh->[check_cert],poll_and_request_issuance->[retry_after,poll,request_issuance],request_domain_challenges->[request_challenges],register->[_regr_from_response]],ClientNetwork->[_get_nonce->[_add_nonce,head],_post_once->[_check_response,_wrap_in_jws,_send_request,_add_nonce,_get_nonce],get->[_check_response,_send_request],head->[_send_request]],BackwardsCompatibleClientV2->[new_account_and_tos->[agree_to_tos,_assess_tos,new_account,register],__init__->[ClientV2,Client]],ClientBase->[poll->[_authzr_from_response],update_registration->[_send_recv_regr],deactivate_registration->[update_registration],_send_recv_regr->[_regr_from_response],query_registration->[_send_recv_regr]]] | Creates an instance of the class. Create a registration resource from a response. | I think cryptography is an unused import now that lint will yell about. |
@@ -662,7 +662,10 @@ def _concat_partitions_with_op(partition_tensor_list, tensor, partition_index,
def _init_comm_for_send_recv():
- if not PROCESS_GROUP_MAP["global_group"].is_instantiate():
+ if not PROCESS_GROUP_MAP:
+ genv = _get_global_env()
+ PROCESS_GROUP_MAP["global_group"] = ProcessGroup(
+ 0, list(range(genv.world_size)))
PROCESS_GROUP_MAP["global_group"].instantiate()
| [reshard->[remove_no_need_in_main,find_op_desc_seq,_need_reshard,remove_no_need_in_startup,parse_op_desc],remove_no_need_in_main->[_remove_no_need_vars,_remove_no_need_ops],_concat_partitions->[_compute_concat_info,_concat_partitions],_compute_partition_index->[_compute_process_index,_compute_partition_shape],find_op_desc_seq->[_concat_partitions,_compute_partition_index,_compute_complete_shape,RecvOpDesc,SendOpDesc,ConcatOpDesc,SliceOpDesc,AllGatherOpDesc],_concat_partitions_with_op->[_concat_partitions_with_op,_insert_concat_op,_compute_concat_info],_insert_allgather_op->[_insert_split_op,_insert_fill_constant_op],parse_op_desc->[_insert_slice_op,_concat_partitions_with_op,_insert_allgather_op,_insert_send_op,_insert_recv_op,_init_comm_for_send_recv]] | Initialize the comm for send and receive. | LGTM but later in next prwe need to move the group instantiate step into parallelizer.py in order to unify the comm group instantiation. |
@@ -943,6 +943,12 @@ public class FormulaFactory {
@SuppressWarnings("unchecked")
private static boolean hasMonitoringDataEnabled(Map<String, Object> formData) {
Map<String, Object> exporters = (Map<String, Object>) formData.get("exporters");
+ // If we cannot extract the exporters from the form data the form data file might
+ // come from an older version of the prometheus-exporters formula package and we will
+ // use the example file instead
+ if (exporters == null) {
+ exporters = (Map<String, Object>) FormulaFactory.getPillarExample(PROMETHEUS_EXPORTERS).get("exporters");
+ }
return exporters.values().stream()
.map(exporter -> (Map<String, Object>) exporter)
.anyMatch(exporter -> (boolean) exporter.get("enabled"));
| [FormulaFactory->[getFormulaValuesByNameAndMinionId->[getPillarDir],getClusterProviderFormulaLayout->[getClusterProviderMetadata,getFormulaLayoutByName],saveServerFormulaData->[getPillarDir],saveGroupFormulaData->[getGroupPillarDir],saveFormulaOrder->[getOrderDataFile,orderFormulas,listFormulaNames],saveServerFormulas->[getServerDataFile,validateFormulaPresence,saveServerFormulaData],serverHasMonitoringFormulaEnabled->[getFormulasByMinionId],deleteServerFormulaData->[getPillarDir],getFormulasByGroupId->[getGroupDataFile],validateFormulaPresence->[listFormulaNames],getCombinedFormulasByServerId->[getFormulasByMinionId],getFormulasByMinionId->[getServerDataFile],deleteGroupFormulaData->[getGroupPillarDir],formulaHasType->[getMetadata],getGroupFormulaValuesByNameAndGroupId->[getGroupPillarDir],getClusterProviderMetadata->[getClusterProviderMetadata],listFormulas->[listFormulaNames],getGroupFormulasByServerId->[getGroupDataFile],saveGroupFormulas->[getGroupDataFile,saveGroupFormulaData]]] | Checks if the monitoring data is enabled. | This will change the function logic and return `true` even if exporters has been explicitly disabled in the old `formData`. |
@@ -28,7 +28,7 @@ import org.apache.kafka.common.header.Headers;
* KafkaRecord contains key and value of the record as well as metadata for the record (topic name,
* partition id, and offset).
*/
-public class KafkaRecord<K, V> implements Serializable {
+public class KafkaRecord<K, V> {
// This is based on {@link ConsumerRecord} received from Kafka Consumer.
// The primary difference is that this contains deserialized key and value, and runtime
// Kafka version agnostic (e.g. Kafka version 0.9.x does not have timestamp fields).
| [KafkaRecord->[getHeaders->[RuntimeException],hashCode->[deepHashCode],equals->[equal,equals],of]] | Construct a new instance of a KafkaRecord from a given base record. for testing purposes only. | `KafkaRecord` should be Serializable. Or something deeply changed in the IO, Isn't this the payload of the Reader (aka what is sent in the network?) |
@@ -286,8 +286,10 @@ class GlobalOptionsRegistrar(SubsystemClientMixin, Optionable):
'The `--pants-distdir` and `--pants-workdir` locations are inherently ignored.')
register('--glob-expansion-failure', advanced=True,
default=GlobMatchErrorBehavior.warn, type=GlobMatchErrorBehavior,
- help="Raise an exception if any targets declaring source files "
- "fail to match any glob provided in the 'sources' argument.")
+ help="What to do when any filesystem specs cannot be found or any files in a target's "
+ "`sources` argument may not be found. This happens when the files specified do "
+ "not exist on your machine or when they are ignored by the `--pants-ignore` "
+ "option.")
# TODO(#7203): make a regexp option type!
register('--exclude-target-regexp', advanced=True, type=list, default=[], daemon=False,
| [GlobalOptions->[__getattr__->[__getattr__]],GlobalOptionsRegistrar->[register_options->[register_bootstrap_options]],ExecutionOptions] | Register bootstrap options. Optionally provide a way to specify the maximum number of unique elements to be used in a Registers all required packages and options. A sequence number that can be used to identify a specific node. | Should the second message be included in the error message? When there are multiple warnings, then I think it should only be rendered once to avoid verbosity. |
@@ -1470,6 +1470,8 @@ void dt_dev_read_history_ext(dt_develop_t *dev, const int imgid, gboolean no_ima
dev->iop_order_version = 0;
+ dt_ioppr_convert_onthefly(imgid);
+
DT_DEBUG_SQLITE3_PREPARE_V2(dt_database_get(darktable.db), "SELECT iop_order_version FROM main.images WHERE id = ?1",
-1, &stmt, NULL);
DT_DEBUG_SQLITE3_BIND_INT(stmt, 1, imgid);
| [No CFG could be retrieved] | read history of the given image read the history of the device. | Maybe this routine could return the iop_order_version for imgid and then we can remove the code below that is reading back iop_order_version from db? |
@@ -453,11 +453,13 @@ public class StateConsumerImpl implements StateConsumer {
private void fetchClusterListeners(CacheTopology cacheTopology) {
if (configuration.clustering().cacheMode().isDistributed() || configuration.clustering().cacheMode().isScattered()) {
- Collection<DistributedCallable> callables = getClusterListeners(cacheTopology);
- for (DistributedCallable callable : callables) {
- callable.setEnvironment(cache.wired(), null);
+ Collection<ClusterListenerReplicateCallable<Object, Object>> callables = getClusterListeners(cacheTopology);
+ Cache<Object, Object> cache = this.cache.wired();
+ for (ClusterListenerReplicateCallable<Object, Object> callable : callables) {
try {
- callable.call();
+ // TODO: need security check?
+ // We have to invoke a separate method as we can't retrieve the cache as it is still starting
+ callable.accept(cache.getCacheManager(), cache);
} catch (Exception e) {
log.clusterListenerInstallationFailure(e);
}
| [StateConsumerImpl->[requestSegments->[findSources],getSegment->[getSegment],onTopologyUpdate->[stopApplyingState],notifyEndOfStateTransferIfNeeded->[hasActiveTransfers,stopApplyingState],onTaskCompletion->[removeTransfer,notifyEndOfStateTransferIfNeeded],requestTransactions->[applyTransactions,findSources],addTransfer->[requestSegments,addTransfer]]] | Fetch cluster listeners. | TBH I always found it odd that we'd get back a `Callable` instead of a POJO with the information we need to register the listener ourselves. If we did the registration ourselves we'd just call a method on the `CacheNotifier`, we wouldn't need the cache. |
@@ -158,7 +158,8 @@ namespace System.Security.Cryptography
iv: iv.ToArray(),
encrypting: false,
paddingMode,
- CipherMode.CBC);
+ CipherMode.CBC,
+ feedbackSizeInBits: 0);
using (transform)
{
| [AesCng->[GenerateIV->[GenerateIV],GetPaddingSize->[GetPaddingSize],Dispose->[Dispose],GenerateKey->[GenerateKey]]] | TryDecryptCbcCore attempts to decrypt a single block of data using a UniversalCryptoTransform. | This is our detection mechanism to determine if `BasicSymmetricCipherNCrypt` or `BasicSymmetricCipherBCrypt` is going to be used. The former does not correctly handle feedback sizes other than CFB8. |
@@ -169,6 +169,14 @@ function updateReporters(config) {
if (argv.saucelabs) {
config.reporters.push('saucelabs');
}
+
+ const testTypeAllowList = new Set(['unit', 'integration']);
+ if (isTravisPushBuild() && testTypeAllowList.has(config.testType)) {
+ config.reporters.push('json-result');
+ config.jsonResultReporter = {
+ outputFile: `results_${config.testType}.json`,
+ };
+ }
}
class RuntimeTestConfig {
| [No CFG could be retrieved] | Creates a new object with the unit test paths and the test reporters. The main entry point for the karma plugin. | extreme bike-shedding: "allow list" doesn't seem right here (we allow all types of tests, we generate a JSON report for only some) - so how about calling it something like "JSON_REPORT_TEST_TYPES"? (also, make this a module-level constant and make it all caps :) ) |
@@ -119,10 +119,6 @@ namespace System.Runtime.InteropServices.Tests
{
yield return new object[] { new DispatchWrapper(10), VarEnum.VT_DISPATCH, IntPtr.Zero, null };
}
- else
- {
- Assert.Throws<PlatformNotSupportedException>(() => new DispatchWrapper(10));
- }
yield return new object[] { new ErrorWrapper(10), VarEnum.VT_ERROR, (IntPtr)10, 10 };
yield return new object[] { new CurrencyWrapper(10), VarEnum.VT_CY, (IntPtr)100000, 10m };
yield return new object[] { new BStrWrapper("a"), VarEnum.VT_BSTR, (IntPtr)(-1), "a" };
| [GetNativeVariantForObjectTests->[GetNativeVariantForObject_TypeMissing_Success->[GetNativeVariantForObject_RoundtrippingPrimitives_Success]]] | GetNativeVariantForObject_NonRoundtrippingPrimitives_TestData - Get native Dispatch objects. region Private Methods 9. 2. 4. 2. | These `!PlatformDetection.IsNetCore` checks can be delete too. |
@@ -86,6 +86,8 @@ class Conll2003DatasetReader(DatasetReader):
feature_labels: Sequence[str] = (),
coding_scheme: str = "IOB1",
label_namespace: str = "labels",
+ *,
+ convert_to_coding_scheme: Optional[str] = None,
**kwargs,
) -> None:
super().__init__(**kwargs)
| [_is_divider->[strip,split],Conll2003DatasetReader->[text_to_instance->[SequenceLabelField,to_bioul,Instance,TextField,ConfigurationError,MetadataField],__init__->[SingleIdTokenIndexer,super,set,format,ConfigurationError],_read->[text_to_instance,list,Token,cached_path,groupby,zip,strip,info,open]],register,getLogger] | Initialize a object. | I'm not sure we should add the `*` here |
@@ -103,7 +103,7 @@ function jetpack_has_site_logo() {
function jetpack_the_site_logo() {
$logo = site_logo()->logo;
$logo_id = get_theme_mod( 'custom_logo' ); // Check for WP 4.5 Site Logo
- $logo_id = $logo_id ? $logo_id : $logo['id']; // Use WP Core logo if present, otherwise use Jetpack's.
+ $logo_id = $logo_id ? $logo_id : ( isset( $logo['id'] ) ? $logo['id'] : false ); // Use WP Core logo if present, otherwise use Jetpack's.
$size = site_logo()->theme_size();
$html = '';
| [jetpack_has_site_logo->[has_site_logo],jetpack_the_site_logo->[theme_size],jetpack_get_site_logo_dimensions->[theme_size],jetpack_is_customize_preview->[is_preview]] | This function is used to display the logo of the site jetpack_the_site_logo is the default logo for the site. | Is this is `false` should we better handle the `$html` at line 123 instead of passing `false` to `wp_get_attachment_image`? |
@@ -907,7 +907,13 @@ define([
++tileProvider._usedDrawCommands;
- command.debugShowBoundingVolume = (tile === tileProvider._debug.boundingSphereTile);
+ if (tile === tileProvider._debug.boundingSphereTile) {
+ if (defined(surfaceTile.orientedBoundingBox)) {
+ createDebugOrientedBoundingBox(surfaceTile.orientedBoundingBox, Color.RED).update(context, frameState, commandList);
+ } else if (defined(surfaceTile.boundingSphere3D)) {
+ createDebugSphere(surfaceTile.boundingSphere3D, Color.RED).update(context, frameState, commandList);
+ }
+ }
Cartesian4.clone(initialColor, uniformMap.initialColor);
uniformMap.oceanNormalMap = oceanNormalMap;
| [No CFG could be retrieved] | Creates a command that draws a single tile. region TileImagery. | Here and below leak the debug primitive on each frame. We should keep a reference to it so we can call `destroy`. Stop by and I can explain more. |
@@ -62,7 +62,7 @@ def conv_model(features, labels, mode):
# Densely connected layer with 1024 neurons.
h_fc1 = tf.layers.dense(h_pool2_flat, 1024, activation=tf.nn.relu)
if mode == tf.estimator.ModeKeys.TRAIN:
- h_fc1 = tf.layers.dropout(h_fc1, rate=0.5)
+ h_fc1 = tf.layers.dropout(h_fc1, rate=0.5, training=mode == tf.estimator.ModeKeys.TRAIN)
# Compute logits (1 per class) and compute loss.
logits = tf.layers.dense(h_fc1, N_DIGITS, activation=None)
| [conv_model->[max_pooling2d,softmax,EstimatorSpec,variable_scope,dense,sparse_softmax_cross_entropy,get_global_step,accuracy,argmax,GradientDescentOptimizer,minimize,reshape,conv2d,dropout],main->[,train,Estimator,astype,print,numpy_input_fn,evaluate,set_verbosity,LinearClassifier,numeric_column],run] | 2 - layer convolution model. EstimatorSpec for . | It is equivalent to `training=True` |
@@ -213,7 +213,6 @@ class RaidenAPI:
try:
registry = self.raiden.chain.token_network_registry(registry_address)
- # LEFTODO: Supply a proper block id
return registry.add_token(
token_address=token_address,
given_block_identifier='latest',
| [transfer_tasks_view->[flatten_transfer,get_transfer_from_task],RaidenAPI->[get_pending_transfers->[transfer_tasks_view,get_channel],get_raiden_events_payment_history_with_timestamps->[event_filter_for_payments],start_health_check_for->[start_health_check_for],get_raiden_events_payment_history->[get_raiden_events_payment_history_with_timestamps],get_blockchain_events_channel->[get_channel_list]]] | Register a token in the token network. | What about the block hash in this file? Will it be done in a follow up PR? |
@@ -1328,8 +1328,7 @@ describe('ngAnimate $animateCss', function() {
animator.end();
expect(element.data(ANIMATE_TIMER_KEY)).toBeUndefined();
- $timeout.flush();
- expect(function() {$timeout.verifyNoPendingTasks();}).not.toThrow();
+ $timeout.verifyNoPendingTasks();
}));
});
| [No CFG could be retrieved] | Tests that the animation is ended normally. cache frequent calls to getComputedStyle before the next animation frame kicks in. | This is an example of how this change can be "breaking" for some tests. |
@@ -378,14 +378,14 @@ func (consensus *Consensus) onPrepare(msg *msg_pb.Message) {
Str("validatorPubKey", validatorPubKey.SerializeToHexStr()).Logger()
// proceed only when the message is not received before
- signed := consensus.Decider.ReadSignature(quorum.Prepare, validatorPubKey)
+ signed := consensus.Decider.ReadSignature(quorum.Announce, validatorPubKey)
if signed != nil {
logger.Debug().
Msg("[OnPrepare] Already Received prepare message from the validator")
return
}
- if consensus.Decider.IsQuorumAchieved(quorum.Prepare) {
+ if consensus.Decider.IsQuorumAchieved(quorum.Announce) {
// already have enough signatures
logger.Debug().Msg("[OnPrepare] Received Additional Prepare Message")
return
| [Start->[announce,Start,handleMessageUpdate,finalizeCommits]] | onPrepare is called when a message is received from the sender. This function is called when a message is received from the validator This function sends a message to the leader with a specific signature. | why Announce here, instead of Prepare? |
@@ -167,6 +167,7 @@ public class IndexSpec
int result = bitmapSerdeFactory != null ? bitmapSerdeFactory.hashCode() : 0;
result = 31 * result + (dimensionCompression != null ? dimensionCompression.hashCode() : 0);
result = 31 * result + (metricCompression != null ? metricCompression.hashCode() : 0);
+ result = 31 * result + (spatialDimensionDelimiter != null ? spatialDimensionDelimiter.hashCode() : 0);
return result;
}
}
| [IndexSpec->[hashCode->[hashCode],equals->[equals]]] | This method returns the hashCode of the object. | spatialDimensionDelimiter is non-null, this line could be simplified |
@@ -913,6 +913,12 @@ namespace System.Windows.Forms
base.OnLayoutResuming(performLayout);
}
+ protected override void OnMove(EventArgs e)
+ {
+ base.OnMove(e);
+ ResetToolTip();
+ }
+
/// <summary>
/// Called when the parent changes. Container controls prefer to have their parents scale
/// themselves, but when a parent is first changed, and as a result the font changes as
| [ContainerControl->[OnFrameWindowActivate->[FocusActiveControlInternal],SuspendAllLayout->[SuspendAllLayout],OnFontChanged->[OnFontChanged],LayoutScalingNeeded->[EnableRequiredScaling],ValidateInternal->[ValidateInternal],Validate->[Validate],ResetActiveAndFocusedControlsRecursive->[ResetActiveAndFocusedControlsRecursive],ProcessDialogChar->[ProcessDialogChar],OnLayout->[OnLayout],PerformAutoScale->[EnableRequiredScaling,PerformAutoScale],ActivateControl->[ActivateControl],ScaleContainer->[ResumeAllLayout,Size,SuspendAllLayout,OnFontChanged],OnLayoutResuming->[OnLayoutResuming],ResumeAllLayout->[ResumeAllLayout],ValidateThroughAncestor->[SetActiveControl],OnChildLayoutResuming->[OnChildLayoutResuming],ProcessMnemonic->[CanProcessMnemonic,ProcessMnemonic],CanProcessMnemonic->[CanProcessMnemonic],RescaleConstantsForDpi->[RescaleConstantsForDpi,OnFontChanged],AdjustFormScrollbars->[AdjustFormScrollbars],SetActiveControl->[FocusActiveControlInternal,ActivateControl,AssignActiveControlInternal,HasFocusableChild],OnParentChanged->[OnParentChanged],ValidateChildren->[ValidateChildren],OnCreateControl->[OnCreateControl,AxContainerFormCreated],ProcessCmdKey->[ProcessCmdKey],WmSetFocus->[FocusActiveControlInternal,ActivateControl],ProcessDialogKey->[ProcessDialogKey,ProcessArrowKey],EnableRequiredScaling->[EnableRequiredScaling],Size->[Size],Scale->[Scale],PerformNeededAutoScaleOnLayout->[PerformAutoScale],Dispose->[Dispose],WndProc->[WmSetFocus,WndProc]]] | Override OnLayoutResuming to perform AutoScale on layout if necessary. | what about the ancestor container being re-sized? Is resize handled by focus change? |
@@ -1409,7 +1409,11 @@ def get_size(start_path='.'):
for dirpath, dirnames, filenames in ek.ek(os.walk, start_path):
for f in filenames:
fp = ek.ek(os.path.join, dirpath, f)
- total_size += ek.ek(os.path.getsize, fp)
+ try:
+ total_size += ek.ek(os.path.getsize, fp)
+ except OSError, e:
+ logger.log(u"Unable to get size for file " + fp + ": " + repr(e) + " / " + str(e),
+ logger.DEBUG)
return total_size
def generateApiKey():
| [get_all_episodes_from_absolute_number->[findCertainShow],getURL->[_getTempDir],is_hidden_folder->[is_hidden],arithmeticEval->[_eval->[_eval],_eval],moveAndSymlinkFile->[copyFile],symlink->[symlink],link->[link],hardlinkFile->[copyFile],update_anime_support->[is_anime_in_show_list],restoreConfigZip->[path_leaf],verify_freespace->[disk_usage,pretty_filesize],decrypt->[encrypt],get_show->[full_sanitizeSceneName,searchIndexerForShowID,findCertainShow],chmodAsParent->[fileBitFilter],rename_ep_file->[make_dirs],indentXML->[indentXML],download_file->[_getTempDir,chmodAsParent,_remove_file_failed],_check_against_names->[full_sanitizeSceneName],moveFile->[copyFile],searchIndexerForShowID->[findCertainShow],listMediaFiles->[isMediaFile,listMediaFiles]] | Get the total size of a node in a directory. | @ElmerLastdrager Try to use `except OSError as e:` instead, we are trying to write the new code to be as much possible compatible with python3 to make it easier to port one day. |
@@ -66,6 +66,17 @@ class WelcomePage extends AbstractWelcomePage {
* @returns {void}
*/
componentDidMount() {
+ // FIXME: This is not the best place for this logic. Ideally we should
+ // use features/base/lib-jitsi-meet#initLib() action for this use case.
+ // But currently lib-jitsi-meet#initLib()'s logic works for mobile only
+ // (on web it ends up with infinite loop over initLib).
+ JitsiMeetJS.init({
+ enableAnalyticsLogging: isAnalyticsEnabled(APP.store),
+ ...config
+ }).then(() => {
+ initAnalytics(APP.store);
+ });
+
if (this.state.generateRoomnames) {
this._updateRoomname();
}
| [No CFG could be retrieved] | Constructor for the component. Displays a hidden element with a hidden element with a title text description and a form that displays. | I'm not reviewing this PR, I'm only mentioning concerns after hearing about this PR in today's morning standup: 1. If it's limited to Web only, it's fine with mobile. But when we're developing we should always account for our end-of-year goal to have Web and mobile merged as much as possible. I'll presume that's been accounted for here and the result is guided by higher priorities. 2. If it ever moves to mobile, please note that the WelcomePage is optional, we have a production use case in which the WelcomePage is disabled, and the WelcomePage only knows about the default domain (which is also configurable in Settings). As this PR currently only does Web-specific modifications, that's fine for now. |
@@ -77,9 +77,9 @@ namespace System.Xml.Serialization
return ImportSchemaType(typeName, baseType, false);
}
- public XmlTypeMapping ImportSchemaType(XmlQualifiedName typeName, Type baseType, bool baseTypeCanBeIndirect)
+ public XmlTypeMapping ImportSchemaType(XmlQualifiedName typeName, Type? baseType, bool baseTypeCanBeIndirect)
{
- TypeMapping typeMapping = ImportType(typeName, typeof(TypeMapping), baseType, TypeFlags.CanBeElementValue, true);
+ TypeMapping typeMapping = ImportType(typeName, typeof(TypeMapping), baseType, TypeFlags.CanBeElementValue, true)!;
typeMapping.ReferencedByElement = false;
ElementAccessor accessor = new ElementAccessor();
| [XmlSchemaImporter->[ImportSubstitutionGroupMember->[GetEquivalentElements],AddScopeElements->[AddScopeElement],MemberMapping->[AddScopeElements],TypeMapping->[ImportDerivedTypes,GenerateUniqueTypeName],ImportGroupMembers->[ImportGroupMembers],AttributeAccessor->[RunSchemaExtensions],ArrayMapping->[IsMixed,ImportDerivedTypes],IsMixed->[IsMixed],SpecialMapping->[IsMixed,RunSchemaExtensions],IsCyclicReferencedType->[IsCyclicReferencedType],ImportAttributeGroupMembers->[ImportAttributeGroupMembers,ImportAttributeMember,ImportAnyAttributeMember],ImportAny->[RunSchemaExtensions],ImportXmlnsDeclarationsMember->[KeepXmlnsDeclarations],ElementComparer->[Compare->[Compare]],GatherGroupChoices->[GatherGroupChoices],ImportElementMember->[AddScopeElement,ImportSubstitutionGroupMember],EnumMapping->[GenerateUniqueTypeName],StructMapping->[GenerateUniqueTypeName]]] | Imports a type from the schema. | On line 76: `baseType` should be nullable to have parity with overload on line 81. |
@@ -2234,6 +2234,8 @@ define([
* @param {Matrix4} [options.endTransform] Transform matrix representing the reference frame the camera will be in when the flight is completed.
* @param {Boolean} [options.convert=true] When <code>true</code>, the destination is converted to the correct coordinate system for each scene mode. When <code>false</code>, the destination is expected
* to be in the correct coordinate system.
+ * @param {Number} [options.altitude] The maximum altitude at the peak of the flight.
+ * @param {EasingFunction|EasingFunction~Callback} [options.easingFunction] Controls how the time is interpolated over the duration of the flight.
*
* @exception {DeveloperError} If either direction or up is given, then both are required.
*
| [No CFG could be retrieved] | Flies the camera from its current position to a new position. Fly to a position with an orientation using unit vectors. | Throughout Cesium, we call this `height`. We should do the same here unless we have a compelling reason. |
@@ -37,9 +37,6 @@ import org.springframework.transaction.interceptor.TransactionInterceptor;
import org.springframework.util.Assert;
import org.springframework.util.StringUtils;
import org.springframework.util.xml.DomUtils;
-import org.w3c.dom.Element;
-import org.w3c.dom.Node;
-import org.w3c.dom.NodeList;
/**
* Shared utility methods for integration namespace parsers.
| [IntegrationNamespaceUtils->[parseInnerHandlerDefinition->[createElementDescription],setValueIfAttributeDefined->[setValueIfAttributeDefined],configureHeaderMapper->[setReferenceIfAttributeDefined],setReferenceIfAttributeDefined->[setReferenceIfAttributeDefined],configureAdviceChain->[configureTransactionAttributes],configureAndSetAdviceChainIfPresent->[configureAndSetAdviceChainIfPresent]]] | Method to import the given bean definition from the System. The base class name for the integration class. | Cool! I haven't done it, but my IDEA is very smart :smile: |
@@ -14,8 +14,6 @@ export function getSvgStyles({$theme, $size, $color}: StyledComponentParamsT) {
$size = $theme.sizing[$size];
} else if (typeof $size === 'number') {
$size = `${$size}px`;
- } else {
- $size = $theme.sizing.scale600;
}
} else {
$size = $theme.sizing.scale600;
| [No CFG could be retrieved] | Creates a new element with the given styles. | The custom size string still won't work I think. |
@@ -10,8 +10,11 @@ use Friendica\Core\Cache;
*
* @author Hypolite Petovan <mrpetovan@gmail.com>
*/
-class MemcachedCacheDriver extends BaseObject implements ICacheDriver
+class MemcachedCacheDriver extends BaseObject implements IMemoryCacheDriver
{
+ use TraitCompareSet;
+ use TraitCompareDelete;
+
/**
* @var Memcached
*/
| [MemcachedCacheDriver->[delete->[delete],set->[set],get->[get]]] | This class is used to provide a Memcached cache driver. | Is there a reason why you only use these traits here? |
@@ -388,6 +388,12 @@ public class ParquetIO {
abstract Builder<T> setParseFn(SerializableFunction<GenericRecord, T> parseFn);
+ abstract Builder<T> setConfiguration(SerializableConfiguration configuration);
+
+ Builder<T> setHadoopConfigurationFlags(Map<String, String> flags) {
+ return setConfiguration(makeHadoopConfigurationUsingFlags(flags));
+ }
+
abstract Builder<T> setSplittable(boolean splittable);
abstract Parse<T> build();
| [ParquetIO->[Parse->[from->[from,build],withSplit->[build],expand->[getFilepattern,build]],Read->[expand->[getAvroDataModel,getEncoderSchema,getFilepattern,isSplittable,getProjectionSchema,withAvroDataModel,withProjection],withSplit->[build],populateDisplayData->[populateDisplayData],from->[from,build],withAvroDataModel->[build],withProjection->[build]],Sink->[withConfiguration->[build],write->[write],withCompressionCodec->[build],BeamOutputStream->[close->[close],write->[write],flush->[flush]],open->[build,getConfiguration,getJsonSchema]],ParseFiles->[withSplit->[build],expand->[getParseFn,isSplittable],inferCoder->[getParseFn,isGenericRecordOutput]],GenericRecordPassthroughFn->[GenericRecordPassthroughFn],sink->[build],ReadFiles->[BlockTracker->[getProgress->[getProgress]],ReadFn->[processElement->[read,build]],expand->[getSchema,getEncoderSchema,isSplittable,getProjectionSchema],SplitReadFn->[processElement->[getSchema,read,build],getSize->[getSize],split->[getParquetFileReader],getInitialRestriction->[getParquetFileReader],getRecordCountAndSize->[getParquetFileReader],getParquetFileReader->[build]],withSplit->[build],withAvroDataModel->[build],withProjection->[build]]]] | Abstract class for building Parse objects. | Please remove all definitions of this method and replace its uses with setConfiguration(makeHadoopConfiguration(...)) in all classes where it appears |
@@ -171,10 +171,14 @@ public final class Environment
.with(timeout, retry)
.with(executorService);
- ImmutableList.copyOf(containers.values())
- .stream()
- .filter(DockerContainer::isRunning)
- .forEach(container -> executor.run(container::tryStop));
+ for (DockerContainer container : ImmutableList.copyOf(containers.values())) {
+ try {
+ executor.runAsync(container::tryStop).get();
+ }
+ catch (InterruptedException | ExecutionException e) {
+ log.warn("Could not stop container %s due to %s", container.getLogicalName(), e);
+ }
+ }
this.listener.ifPresent(listener -> listener.environmentStopped(this));
pruneEnvironment();
| [Environment->[tryStart->[getContainerNames],close->[stop],Builder->[removeContainers->[removeContainer],removeContainer->[close],setContainerOutputConsumer->[configureContainers],build->[Environment,build]],awaitTestsCompletion->[stop]]] | Stops the environment if it is running. | Why do we need to copy the list? It appears the map is not modified after this class is constructed, though the constructor should really do a defensive copy. |
@@ -243,6 +243,10 @@ func RunImportImage(f *clientcmd.Factory, out io.Writer, cmd *cobra.Command, arg
}
fmt.Fprintln(out, info)
+
+ if r := result.Status.Repository; r != nil && len(r.AdditionalTags) > 0 {
+ fmt.Fprintf(out, "\ninfo: The remote repository contained %d additional tags which were not imported: %s\n", len(r.AdditionalTags), strings.Join(r.AdditionalTags, ", "))
+ }
return nil
}
| [Error->[Sprintf],ParseDockerImageReference,FollowTagReference,IsZero,Stop,GetFlagString,Errorf,Watch,CheckErr,Bool,Clients,DefaultNamespace,Create,Fprintln,GetFlagBool,Fprint,ResultChan,Get,Out,Update,Describe,ImageStreams,Sprintf,UsageError,String,Import,IsNotFound,Parse,Flags,OneTermEqualSelector] | Import a Docker image from a repository or a tag check if the import has completed successfully. | Shouldn't we inform the user why they weren't imported? |
@@ -70,7 +70,7 @@ func do(appEnvObj interface{}) error {
etcdClient := getEtcdClient(appEnv)
if appEnv.Init {
if err := setClusterID(etcdClient); err != nil {
- return err
+ return fmt.Errorf("error connecting to etcd, if this error persists it likely indicates that kubernetes services are not working correctly. See https://github.com/pachyderm/pachyderm/blob/master/SETUP.md#pachd-or-pachd-init-crash-loop-with-error-connecting-to-etcd for more info")
}
if err := persist_server.InitDBs(fmt.Sprintf("%s:28015", appEnv.DatabaseAddress), appEnv.DatabaseName); err != nil && !isDBCreated(err) {
return err
| [RegisterInternalJobAPIServer,NewInternalAPIServer,NewAPIServer,NewInCluster,CheckDBs,WithInsecure,ReportMetrics,Exit,RegisterAPIServer,NewSharder,Set,RegisterBlockAPIServer,Error,ListRepo,NewRouter,New,NewFromAddress,Errorf,RegisterFrontends,Main,InitDBs,AssignRoles,Contains,NewEtcdClient,ExternalIP,Register,Get,NewDriver,NewWithoutDashes,Serve,NewBlockAPIServer,Printf,RegisterInternalAPIServer,NewHasher,Sprintf,NewDialer,Parse,Getenv,NewRethinkAPIServer,BoolVar] | Initialization of the n - node node. NewInCluster creates a new node in a cluster. | This link is broken right now, but will unbreak when we merge this PR. |
@@ -156,6 +156,15 @@ const (
// EgressUpdated is the type of announcement emitted when we observe an update to egress.policy.openservicemesh.io
EgressUpdated AnnouncementType = "egress-updated"
+
+ // Config
+ ConfigAdded AnnouncementType = "config-added"
+
+ // ConfigDeleted the type of announcement emitted when we observe a deletion of config.policy.openservicemesh.io
+ ConfigDeleted AnnouncementType = "config-deleted"
+
+ // ConfigUpdated is the type of announcement emitted when we observe an update to config.policy.openservicemesh.io
+ ConfigUpdated AnnouncementType = "config-updated"
)
// Announcement is a struct for messages between various components of OSM signaling a need for a change in Envoy proxy configuration
| [No CFG could be retrieved] | EgressAdded EgressDeleted EgressUpdated Announcement is the type of announcement emitted when. | To be MultiClusterServiceAdded |
@@ -31,7 +31,7 @@
<% if !@privacy %>
<div class="flex py-2 items-center">
<%= link_to "Privacy Policy", privacy_path %>
- <%= link_to "Override", new_admin_page_path(slug: "privacy"), class: "ml-auto crayons-btn crayons-btn--s crayons-btn--danger" %>
+ <%= link_to "Override", new_admin_page_path(slug: "privacy"), class: "ml-auto crayons-btn crayons-btn--s crayons-btn--danger" %>
</div>
<% end %>
<% if !@terms %>
| [No CFG could be retrieved] | Outputs a list of all of the possible items in the system. Hides the content of a cantonenumber. | This removes an extra space |
@@ -1027,7 +1027,13 @@ public class IndexIO
columns.put(Column.TIME_COLUMN_NAME, deserializeColumn(mapper, smooshedFiles.mapFile("__time")));
final QueryableIndex index = new SimpleQueryableIndex(
- dataInterval, cols, dims, segmentBitmapSerdeFactory.getBitmapFactory(), columns, smooshedFiles, metadata
+ dataInterval,
+ cols,
+ dims,
+ segmentBitmapSerdeFactory.getBitmapFactory(),
+ columns,
+ smooshedFiles,
+ metadata
);
log.debug("Mapped v9 index[%s] in %,d millis", inDir, System.currentTimeMillis() - startTime);
| [IndexIO->[convertSegment->[convertSegment,loadIndex,getVersionFromDir,validateTwoSegments],DefaultIndexIOHandler->[convertV8toV9->[size->[size],get->[get],size,get]],validateTwoSegments->[validateTwoSegments],LegacyIndexLoader->[load->[get,size,mapDir]]]] | Loads the index from the given directory. This method returns a queryable index that can be used to load the next segment. | Looks like there is no reason to change this file, please leave it untouched in that case. |
@@ -3,10 +3,15 @@ package utils
import (
"bytes"
"encoding/binary"
+ "encoding/json"
+ "fmt"
+ "io"
"log"
+ "os"
"os/exec"
"regexp"
"strconv"
+ "sync"
"github.com/dedis/kyber"
"github.com/harmony-one/harmony/crypto"
| [Write,ReplaceAllString,Printf,SetInt64,Println,Panic,Scalar,Start,Compile,GetPublicKeyFromScalar,Fatal,Bytes,Wait,Atoi,Command] | ConvertFixedDataIntoByteArray converts an empty interface data into a byte array. GenKey generates a random key given ip and port. | This is a lock for beacon only. Please be specific of the name of the variable |
@@ -175,7 +175,12 @@ func (m *metricHints) getHostsWithPort(hints common.MapStr, port int) []string {
}
}
- return result
+ if len(thosts) > 0 && len(result) == 0 {
+ logp.Debug("hints.builder", "no hosts selected for port %d with hints: %+v", port, thosts)
+ return nil, false
+ }
+
+ return result, true
}
func (m *metricHints) getNamespace(hints common.MapStr) string {
| [getHostsWithPort->[GetHintAsList,Contains,Sprintf],getNamespace->[GetHintString],getMetricSets->[GetHintAsList,MetricSets,DefaultMetricSets],getPeriod->[GetHintString],getModules->[GetHintAsConfigs],getSSLConfig->[GetHintMapStr],getTimeout->[GetHintString],CreateConfig->[getModule,getHostsWithPort,getNamespace,NewConfigFrom,getMetricSets,TryToInt,getPeriod,getModules,getSSLConfig,String,ApplyConfigTemplate,getTimeout,getProcessors,Debug],getProcessors->[GetProcessors],getModule->[GetHintString],AddBuilder,Unpack,Errorf,Beta] | getHostsWithPort returns a list of hosts that have port on current event. | Should we make the switch to m.logger here instead of logp? not sure if putting them in same pr is good or not. |
@@ -399,7 +399,6 @@ func NewApplication(cfg *config.Config, ethClient eth.Client, advisoryLocker pos
return nil
}})
}
- app.HeadTracker = headTracker
// Log Broadcaster waits for other services' registrations
// until app.LogBroadcaster.DependentReady() call (see below)
| [NewBox->[NewBox],ArchiveJob->[ArchiveJob],stop->[Stop],Start->[Start],AddServiceAgreement->[AddJob],ReplayFromBlock->[ReplayFromBlock],AddJob->[AddJob]] | SetServiceLogger sets the Logger for a given service. setupConfig sets the logger for the service. | Do we need to remove this field from the application struct |
@@ -0,0 +1,12 @@
+#include "osquery/events/linux/tests/audit_tests_common.h"
+#include <ctime>
+#include <sstream>
+
+namespace osquery {
+std::string generateAuditId(std::uint32_t event_id) noexcept {
+ std::stringstream str_helper;
+ str_helper << std::time(nullptr) << ".000:" << event_id;
+
+ return str_helper.str();
+}
+}
| [No CFG could be retrieved] | No Summary Found. | wut? why use another file? |
@@ -400,7 +400,7 @@ main(int argc, char **argv)
}
/** For the second timer, let's use the process clock */
- rc = d_tm_mark_duration_start(&timer2, D_TM_CLOCK_PROCESS_CPUTIME,
+ rc = d_tm_mark_duration_start(&timer2, false, D_TM_CLOCK_PROCESS_CPUTIME,
__FILE__, __func__,
"10000 iterations with process clock",
NULL);
| [main->[test_function2,use_manually_added_metrics,test_close_handle,test_open_handle,test_function1,timer_snapshot,add_metrics_manually]] | This is the entry point for the D_TM_node_tango_counter module This function is used to find the next metric in a loop. It is called by the This function is called by d_tm_mark_duration and d_tm_mark This function is used to add the metrics to the node list and to avoid the cost of. | (style) line over 80 characters |
@@ -256,10 +256,10 @@ describe('injector', function() {
describe('es6', function() {
- /*jshint -W061 */
if (support.ES6Function) {
// The functions are generated using `eval` as just having the ES6 syntax can break some browsers.
it('should be possible to annotate functions that are declared using ES6 syntax', function() {
+ // eslint-disable-next-line no-eval
expect(annotate(eval('({ fn(x) { return; } })').fn)).toEqual(['x']);
});
}
| [No CFG could be retrieved] | Checks that the given function has no arguments and that it has a single argument and that it Checks that all functions have been annotated with a value. | Does ESLint also catch spelling mistakes? :stuck_out_tongue: |
@@ -626,7 +626,7 @@ class ConanAPIV1(object):
deps_graph, _ = self._graph_manager.load_graph(reference, None, graph_info, ["missing"],
check_updates, False, remotes,
recorder)
- return deps_graph.build_order(build_order)
+ return deps_graph.build_order(build_order), deps_graph
@api_method
def info_nodes_to_build(self, reference, build_modes, settings=None, options=None, env=None,
| [_get_conanfile_path->[_make_abs_path],ConanAPIV1->[export_alias->[export_alias],export->[_get_conanfile_path],info->[_info_args],install->[_get_conanfile_path,install,_make_abs_path,_init_manager],source->[_get_conanfile_path,_make_abs_path],imports_undo->[_make_abs_path],remove->[remove],imports->[_get_conanfile_path,_make_abs_path],_info_args->[_get_conanfile_path,_make_abs_path],upload->[upload],remove_locks->[remove_locks],users_list->[users_list],user_set->[user_set],download->[download],invalidate_caches->[invalidate_caches],get_package_revisions->[get_remote_by_name,get_package_revisions],search_recipes->[search_recipes],export_pkg->[export_pkg,_get_conanfile_path,_make_abs_path],factory->[ConanAPIV1],remove_system_reqs->[info],info_nodes_to_build->[_info_args],users_clean->[users_clean],editable_add->[_get_conanfile_path],test->[_get_conanfile_path,_init_manager],read_profile->[read_profile],remote_remove->[remove],get_path->[get_path],authenticate->[authenticate],inspect->[_get_conanfile_path],remove_system_reqs_by_pattern->[remove_system_reqs,search_recipes],info_build_order->[_info_args],install_reference->[_make_abs_path,_init_manager],search_packages->[search_packages],package->[_get_conanfile_path,_make_abs_path],create->[_get_conanfile_path,create,_init_manager],get_recipe_revisions->[get_remote_by_name,get_recipe_revisions],build->[_get_conanfile_path,_make_abs_path,build],editable_remove->[remove]]] | Returns a function that can be used to provide information about a given dependency graph. | Just a note, this will break to all users using this via the conan_api. I know it is not stable, it is just a note, that some users will break. This is a very strong candidate method that might be used via the python conan_api by CI systems of users. |
@@ -2591,7 +2591,7 @@ type BoolInput interface {
type Bool bool
var (
- True = BoolPtr(true)
+ True = BoolPtr(true)
False = BoolPtr(false)
)
| [ToInt8PtrOutput->[ToInt8PtrOutputWithContext],ToURNPtrOutputWithContext->[ToURNPtrOutputWithContext,ToURNOutputWithContext],ToIDPtrOutput->[ToIDPtrOutputWithContext],ToUint32PtrOutputWithContext->[ToUint32OutputWithContext,ToUint32PtrOutputWithContext],ToIntPtrOutputWithContext->[ToIntPtrOutputWithContext,ToIntOutputWithContext],ToStringOutput->[ToStringOutputWithContext],ToFloat32PtrOutputWithContext->[ToFloat32OutputWithContext,ToFloat32PtrOutputWithContext],ToStringPtrOutputWithContext->[ToStringPtrOutputWithContext,ToStringOutputWithContext],ToInt16PtrOutput->[ToInt16PtrOutputWithContext],ToBoolPtrOutputWithContext->[ToBoolPtrOutputWithContext,ToBoolOutputWithContext],ToUint64PtrOutput->[ToUint64PtrOutputWithContext],ToAssetOrArchiveOutputWithContext->[ToAssetOrArchiveOutputWithContext,ToAssetOutputWithContext,ToArchiveOutputWithContext],ToFloat64PtrOutput->[ToFloat64PtrOutputWithContext],ToInt64PtrOutput->[ToInt64PtrOutputWithContext],ToInt64PtrOutputWithContext->[ToInt64OutputWithContext,ToInt64PtrOutputWithContext],ToURNPtrOutput->[ToURNPtrOutputWithContext],ToBoolPtrOutput->[ToBoolPtrOutputWithContext],ToIDPtrOutputWithContext->[ToIDOutputWithContext,ToIDPtrOutputWithContext],ToInt8PtrOutputWithContext->[ToInt8OutputWithContext,ToInt8PtrOutputWithContext],ToFloat64PtrOutputWithContext->[ToFloat64PtrOutputWithContext,ToFloat64OutputWithContext],ToFloat32PtrOutput->[ToFloat32PtrOutputWithContext],ToIntPtrOutput->[ToIntPtrOutputWithContext],ToUint8PtrOutputWithContext->[ToUint8OutputWithContext,ToUint8PtrOutputWithContext],ToAssetOrArchiveOutput->[ToAssetOrArchiveOutputWithContext],ToInt32PtrOutputWithContext->[ToInt32PtrOutputWithContext,ToInt32OutputWithContext],ToUint32PtrOutput->[ToUint32PtrOutputWithContext],ToUintPtrOutputWithContext->[ToUintOutputWithContext,ToUintPtrOutputWithContext],ToStringOutputWithContext->[ToIDOutputWithContext,ToURNOutputWithContext,ToStringOutputWithContext],ToInt32PtrOutput->[ToInt32PtrOutputWithContext],ToInt16PtrOutputWithContext->[ToInt16PtrOutputWithContext,ToInt16OutputWithContext],ToUint8PtrOutput->[ToUint8PtrOutputWithContext],ToUint16PtrOutputWithContext->[ToUint16OutputWithContext,ToUint16PtrOutputWithContext],ToUintPtrOutput->[ToUintPtrOutputWithContext],ToUint64PtrOutputWithContext->[ToUint64PtrOutputWithContext,ToUint64OutputWithContext],ToStringPtrOutput->[ToStringPtrOutputWithContext],ToUint16PtrOutput->[ToUint16PtrOutputWithContext],Elem] | ElementType returns the reflect. Type of the element. | The lint step was breaking because this file wasn't gofmt'd |
@@ -100,4 +100,14 @@ var _ = Describe("Catalog tests", func() {
Expect(actual).To(Equal(expected))
})
})
+
+ Context("Test ListPermittedIncomingServerNames()", func() {
+ It("returns the list of server names allowed to communicate with the hosted service", func() {
+ mc := NewFakeMeshCatalog(testclient.NewSimpleClientset())
+ actualList, err := mc.ListAllowedPeerServices(tests.BookstoreService)
+ Expect(err).ToNot(HaveOccurred())
+ expectedList := []service.NamespacedService{tests.BookbuyerService}
+ Expect(actualList).To(Equal(expectedList))
+ })
+ })
})
| [NewSimpleClientset,NewFakeProvider,NewFakeCertManager,Sprintf,ListTrafficPolicies,TrafficSpecMatchName,ToNot,NewFakeMeshSpecClient,To,TrafficSpecName,getTrafficSpecName,getHTTPPathsPerRoute,NewFakeIngressMonitor] | Expects actual and expected values to be equal. | nit: change the context name to represent the correct function it is testing |
@@ -1557,12 +1557,7 @@ void the_game(bool &kill, bool random_input, InputHandler *input,
/*
Find out size of crack animation
*/
- int crack_animation_length = 5;
- {
- video::ITexture *t = tsrc->getTexture("crack_anylength.png");
- v2u32 size = t->getOriginalSize();
- crack_animation_length = size.Y / size.X;
- }
+ int crack_animation_length = 16;
/*
Add some gui stuff
| [No CFG could be retrieved] | After all content has been received create the necessary objects and add them to the GUI. Adds the guitext for the given block of code. | This shouldn't be hard-coded. Some people use longer or shorter crack animations. |
@@ -24,11 +24,13 @@
<div class ='sub_block'>
<% acc = 0 %>
<% if @penalty.type == "GracePeriodSubmissionRule" %>
+ <%# Relative remaining grace credits for the grouping %>
<span class='prop_label'>
- <%= t('grace_period_submission_rules.deadline_html') %>
+ <%= t('grace_period_submission_rules.deadline_html') %>
</span>
- <%# Relative remaining grace credits for the grouping %>
- <% if !@grouping.nil? %>
+ <% if @grouping.nil? %>
+ <%= t('grace_period_submission_rules.no_group_yet') %>
+ <% else %>
<% remaining_credits = @grouping.available_grace_credits %>
<% @enum_penalty.each do |p| %>
<% unless remaining_credits <= 0 %>
| [No CFG could be retrieved] | This is a pretty - printed view of the user - defined node which is a list of A list of all possible values for a node with penalty type. | Delete the new space here. |
@@ -39,6 +39,8 @@ export const MessageType = {
// For amp-inabox
SEND_POSITIONS: 'send-positions',
POSITION: 'position',
+ SEND_POSITIONS_HIGH_FIDELITY: 'send-positions-high-fidelity',
+ POSITION_HIGH_FIDELITY: 'position_high-fidelity',
};
| [No CFG could be retrieved] | Listens for events on the specified element and writes them to an AMP post message. Serializes a object to a JSON string. | Why does this mix underscores and dashes? |
@@ -31,6 +31,9 @@ public class SQLAuditManagerConfig
@JsonProperty
private boolean includePayloadAsDimensionInMetric = false;
+ @JsonProperty
+ private long maxPayloadSizeBytes = -1;
+
public long getAuditHistoryMillis()
{
return auditHistoryMillis;
| [No CFG could be retrieved] | Returns the auditHistoryMillis of the given . | Could this property declared as type of `HumanReadableBytes` ? |
@@ -2851,9 +2851,10 @@ public class UnitAttachment extends DefaultAttachment {
: (support.getOffence() ? "Attack" : "Defense"));
final String text = String.valueOf(support.getBonus())
+ (moreThanOneSupportType ? " " + support.getBonusType() : "")
- + (support.getStrength() && support.getRoll()
- ? " Power & Rolls"
- : (support.getStrength() ? " Power" : " Rolls"))
+ + " "
+ + (support.getDice() == null ? ""
+ : support.getDice().replace(":", " & ").replace("AAroll", "Targeted Roll")
+ .replace("AAstrength", "Targeted Power").replace("roll", "Roll").replace("strength", "Power"))
+ " to " + support.getNumber()
+ (support.getAllied() && support.getEnemy()
? " Allied & Enemy "
| [UnitAttachment->[getAaKey->[getIsAaForFlyOverOnly,getIsAaForCombatOnly,getIsAaForBombingThisUnitOnly],getAllowedBombingTargetsIntersection->[get,getBombingTargets],getAllOfTypeAas->[getTypeAa],setIsTwoHit->[setIsTwoHit],getMaximumNumberOfThisUnitTypeToReachStackingLimit->[getPlacementLimit,getAttackingLimit,getMovementLimit,get,getIsAaForCombatOnly,getIsAaForBombingThisUnitOnly],getUnitsWhichReceivesAbilityWhenWith->[getReceivesAbilityWhenWithMap],setIsAaMovement->[setIsAaMovement],get->[get],addAaDescription->[getIsAaForCombatOnly,getIsAaForBombingThisUnitOnly,getMaxRoundsAa,getIsAaForFlyOverOnly,getMaxAaAttacks,getTypeAa],getReceivesAbilityWhenWithMap->[getReceivesAbilityWhenWith,getUnitTypesFromUnitList],toStringShortAndOnlyImportantDifferences->[getCreatesResourcesList,getFuelFlatCost,getIsStrategicBomber,getMaxScrambleDistance,playerHasMechInf,getCanOnlyBePlacedInTerritoryValuedAtX,getAirAttack,getBombingMaxDieSides,getCreatesUnitsList,getAttackAa,getIsMarine,getMaxBuiltPerPlayer,get,getRequiresUnitsToMove,getIsAir,getIsRocket,getCanBeDamaged,getBombard,getIsSea,getIsSuicide,getCarrierCost,getIsCombatTransport,getReceivesAbilityWhenWith,getCanAirBattle,getAirDefense,getAttackRolls,getTransportCost,getPlacementLimit,getRequiresUnits,getIsSuicideOnHit,getDefense,getIsDestroyer,getTransportCapacity,getIsSub,getBlockade,getIsInfrastructure,getRepairsUnits,getIsLandTransport,getAttack,getOffensiveAttackAa,playerHasRockets,getBombingBonus,getMaxDamage,getFuelCost,getCanBlitz,getCarrierCapacity,getHitPoints,getIsAirBase,getIsAaForCombatOnly,getIsKamikaze,getIsAirTransport,getConsumesUnits,getIsAirTransportable,getMovement,getCanProduceXUnits,playerHasParatroopers,getCanProduceUnits,getMaxOperationalDamage,getIsLandTransportable,getAttackingLimit,getUnitPlacementRestrictions,getCanNotMoveDuringCombatMove,getCanDieFromReachingMaxDamage,getGivesMovement,getCanScramble,getOffensiveAttackAaMaxDieSides,getMovementLimit,getIsConstruction,getAttackAaMaxDieSides,getCanIntercept,getIsAaForBombingThisUnitOnly,getDefenseRolls,getCanBombard,getCanEscort],setIsFactory->[setIsFactory],setIsAa->[setIsAa,setIsInfrastructure],setDestroyedWhenCapturedFrom->[setDestroyedWhenCapturedBy]]] | Returns a String describing the short and only importsant differences. This method is called when a player has had a Defense. It is called by the Gets the value of the last possible match. This method is used to generate a list of tuples that describe the possible result of a call Get all possible tuples for this player that can perform raids. | Might be a tad easier to read with the second expression on its own line, similar to the conditional operators in the surrounding context that span multiple lines. |
@@ -153,11 +153,17 @@ export default Component.extend({
this.set("composer.featuredLink", this.get("composer.title"));
const $h = $(html),
- heading = $h.find("h3").length > 0 ? $h.find("h3") : $h.find("h4"),
composer = this.composer;
composer.appendText(this.get("composer.title"), null, { block: true });
+ if ($h.hasClass("twitterstatus")) {
+ this.set("composer.title", "");
+ return;
+ }
+
+ const heading = $h.find("h3").length > 0 ? $h.find("h3") : $h.find("h4");
+
if (heading.length > 0 && heading.text().length > 0) {
this.changeTitle(heading.text());
} else {
| [No CFG could be retrieved] | Ajax method to load a single post or link. Check if the given title is an absolute URL. | This might be a good opportunity to replace this with regular JS, since the jQuery here is doing nothing special. |
@@ -510,7 +510,7 @@ class SpackCommand(object):
Use this to invoke Spack commands directly from Python and check
their output.
"""
- def __init__(self, command_name):
+ def __init__(self, command_name, log=False):
"""Create a new SpackCommand that invokes ``command_name`` when called.
Args:
| [_profile_wrapper->[_invoke_command],SpackArgumentParser->[format_help_sections->[add_subcommand_group->[add_group],add_all_commands,index_commands,add_group,add_subcommand_group],add_command->[add_subparsers,add_parser],format_help->[format_help_sections]],print_setup_info->[shell_set],main->[_profile_wrapper,get_version,setup_main_options,print_setup_info,format_help,_invoke_command,add_command,make_argument_parser,set_working_dir],SpackCommand->[__call__->[_invoke_command],__init__->[add_command,make_argument_parser]],_invoke_command->[allows_unknown_args],make_argument_parser->[SpackArgumentParser]] | Create a new SpackCommand that invokes command_name when called. | No longer used |
@@ -23,3 +23,9 @@ class Voropp(MakefilePackage):
filter_file(r'PREFIX=/usr/local',
'PREFIX={0}'.format(self.prefix),
'config.mk')
+ if '+pic' in spec:
+ # We can safely replace the default CFLAGS which are:
+ # CFLAGS=-Wall -ansi -pedantic -O3
+ filter_file(r'CFLAGS=.*',
+ 'CFLAGS={0}'.format(self.compiler.pic_flag),
+ 'config.mk')
| [Voropp->[edit->[filter_file,format],version]] | Edit the configuration file. | Should we inject `spack_cxxflags`, too and also for the `~pic` case? |
@@ -10,14 +10,16 @@ import io.quarkus.deployment.devmode.HotReplacementSetup;
import io.quarkus.undertow.runtime.UndertowDeploymentRecorder;
public class UndertowHotReplacementSetup implements HotReplacementSetup {
-
+ // TODO: This is marked as protected but I don't see anyone else (other than this class) using it.
+ // get rid of this if not used anywhere else or at least make it private
protected static final String META_INF_SERVICES = "META-INF/resources";
@Override
public void setupHotDeployment(HotReplacementContext context) {
List<Path> resources = new ArrayList<>();
for (Path i : context.getResourcesDir()) {
- Path resolved = i.resolve(META_INF_SERVICES);
+ final String nameSeparator = i.getFileSystem().getSeparator();
+ Path resolved = i.resolve("META-INF" + nameSeparator + "resources");
if (Files.exists(resolved)) {
resources.add(resolved);
}
| [UndertowHotReplacementSetup->[close->[setHotDeploymentResources],setupHotDeployment->[setHotDeploymentResources,resolve,getResourcesDir,add,exists]]] | Setup hot deployment. | I agree this is theoretically more correct but we use `File.separator` everywhere in Quarkus so we could use that in the constant instead. |
@@ -275,10 +275,7 @@ public final class TestRun
.build()))
.addAll(testArguments)
.addAll(reportsDirOptions(reportsDirBase))
- .build().toArray(new String[0]))
- // this message marks that environment has started and tests are running
- .waitingFor(forLogMessage(".*\\[TestNG] Running.*", 1)
- .withStartupTimeout(ofMinutes(15)));
+ .build().toArray(new String[0]));
});
builder.setAttached(attach);
| [TestRun->[call->[build,runCommand],TestRunOptions->[toModule->[toInstance]],Execution->[call->[getStackTraceAsString,error,tryExecuteTests,get,info],tryExecuteTests->[getStackTraceAsString,awaitTestsCompletion,warn,startEnvironment,toIntExact],mountReportsDir->[isNullOrEmpty,withFileSystemBind,toString,info,cleanOrCreateHostPath],reportsDirOptions->[isNullOrEmpty,toString,of],getEnvironment->[withStartupTimeout,configureContainer,withEnv,getOrDefault,splitToList,getStandardListeners,setLogsBaseDir,ofMinutes,build,setAttached,getBoolean,exposePort,add,waitingFor],startEnvironment->[ExistingNetwork,setNetwork,start,getEnvironment,getContainers,collect,info,getContainer,dependsOn,toImmutableList],copyOf,requireNonNull],getAdditionalEnvironments,TestRunOptions,EnvironmentOptions,get]] | Returns an Environment instance that can be used to run the environment. This message marks that environment has started and running and logs are attached. | Add rationale to commit message and/or the code. |
@@ -172,11 +172,7 @@ describe AlaveteliPro::SubscriptionsController, feature: :pro_pricing do
context 'with a successful transaction' do
before do
- post :create, 'stripeToken' => token,
- 'stripeTokenType' => 'card',
- 'stripeEmail' => user.email,
- 'plan_id' => 'pro',
- 'coupon_code' => ''
+ post :create, params: { 'stripeToken' => token, 'stripeTokenType' => 'card', 'stripeEmail' => user.email, 'plan_id' => 'pro', 'coupon_code' => '' }
end
include_examples 'successful example'
| [successful_signup->[email,post],email,create,new,let,be,describe,start,create_test_helper,first,it,create_pro_account,map,to,stripe_customer_id,plan_path,before,prepare_error,post,let!,prepare_card_error,require,signin_path,dirname,stop,shared_examples,enable_actor,generate_card_token,match,id,create_plan,enabled?,customer,update!,redirect_to,default_source,context,delete,token,include_examples,get,not_to,eq,after,reload,create_coupon,raise_error,and_return,expand_path] | expects a response to redirect to the dashboard and redirects to the alaveteli enables pop polling for the user. | Line is too long. [157/80] |
@@ -47,6 +47,11 @@ public class DefaultPromise<V> extends AbstractFuture<V> implements Promise<V> {
private volatile Object result;
private final EventExecutor executor;
+
+ // It is fine to not make this volatile as even if we override the value in there it does not matter as
+ // DefaultFutureCompletionStage has no state itself and is just a wrapper around this CompletableFuture instance.
+ private DefaultFutureCompletionStage<V> stage;
+
/**
* One or more listeners. Can be a {@link GenericFutureListener} or a {@link DefaultFutureListeners}.
* If {@code null}, it means either 1) no listeners were added yet or 2) all listeners were notified.
| [DefaultPromise->[sync->[await],rethrowIfFailed->[cause],setValue0->[notifyListeners],syncUninterruptibly->[awaitUninterruptibly],checkDeadLock->[toString,checkDeadLock],notifyProgressiveListeners->[executor],toString->[toString],await0->[isDone,decWaiters,checkDeadLock,incWaiters,toString],notifyListeners->[executor]]] | Creates a new default promise which will be executed when the future is completed. Ejecuta un error. | Nit: a wrapper around this _promise_ instance rather? |
@@ -201,7 +201,8 @@ class MyLib(ConanFile):
client.save({"conanfile.py": conanfile % "True"})
client.run("build", ignore_error=True)
- self.assertIn("Execute 'conan install -g txt' first", client.user_io.out)
+ self.assertIn("self.deps_cpp_info not defined. If you need it for a local command run "
+ "'conan install -g txt'", client.user_io.out)
client.run("install -g txt")
client.run("build")
| [CMakeFlagsTest->[targets_flags_test->[_get_line],transitive_flags_test->[_get_line],transitive_targets_flags_test->[_get_line],flags_test->[_get_line],targets_own_flags_test->[_get_line]]] | Test CMake build with shared flag. | I am confused why this message has changed. I think the code about this is not related to this PR. I have difficulties comparing some refactors, movement of functions |
@@ -429,10 +429,6 @@ int main(int argc, char *argv[])
delete problem3;
delete ia3;
-#ifdef HAVE_ZOLTAN2_MPI
- MPI_Finalize();
-#endif
-
if (rank == 0)
std::cout << "PASS" << std::endl;
}
| [main->[MPI_Init,rand,MPI_Comm_size,resize,MPI_Finalize,MPI_Comm_rank,srand,getComm,solve,getWeightImbalance,set,scalar_t,resetParameters,getPartListView,getSolution,printMetrics,setPartSizes,getObjectCountImbalance]] | This is the entry point for the Zoltan2 library. This function creates a Zoltan2 problem with a Teuchos problem with no weights weights - the weights of the missing components no - op multiple objectives that have a weight imbalance and no weights -------------- - This function checks if a specific object in the system has a non - zero number delete all the neccesary objects from the system. | Best practice is to use `unique_ptr` for objects that need to be managed by pointer, yet have local scope. |
@@ -8,8 +8,10 @@ import (
"github.com/prometheus/client_golang/prometheus/promauto"
)
+type IntervalFn func(r Request) time.Duration
+
// SplitByIntervalMiddleware creates a new Middleware that splits requests by a given interval.
-func SplitByIntervalMiddleware(interval time.Duration, limits Limits, merger Merger, registerer prometheus.Registerer) Middleware {
+func SplitByIntervalMiddleware(interval IntervalFn, limits Limits, merger Merger, registerer prometheus.Registerer) Middleware {
return MiddlewareFunc(func(next Handler) Handler {
return splitByInterval{
next: next,
| [Do->[MergeResponse,Add],GetStart,WithStartEnd,GetEnd,GetStep,NewCounter,With] | SplitByIntervalMiddleware creates a middleware that splits requests by a given interval and limits. nextIntervalBoundary returns a list of requests that can be used to request a specific interval. | What are the requirements on this function? Can it really return different interval for each request? How will that interact with the caching? |
@@ -101,6 +101,13 @@ Status AuditProcessEventSubscriber::ProcessEvents(
continue;
}
+ const AuditEventRecord* cwd_record =
+ GetEventRecord(event, AUDIT_CWD);
+ if (cwd_record == nullptr) {
+ VLOG(1) << "Malformed AUDIT_CWD event";
+ continue;
+ }
+
Row row = {};
CopyFieldFromMap(row, syscall_event_record->fields, "auid", "0");
| [No CFG could be retrieved] | Reserve all row of audit events. build the audit record from the AUDIT_EXECVE record. | nit: for consistency call it `cwd_event_record`. |
@@ -75,7 +75,7 @@ function getMode_(win) {
// amp-geo override
geoOverride: hashQuery['amp-geo'],
test: coreMode.isTest(win),
- log: hashQuery['log'],
+ log: parseInt(hashQuery['log'], 10),
version: coreMode.version(),
rtvVersion: getRtvVersion(win),
};
| [No CFG could be retrieved] | Returns the mode definition of the current window. Determines if the window is in development mode. | nit: `mode.log` is only used by `src/log.js`. can leave it here for this PR, but IMO this should be moved to `src/log.js` |
@@ -328,7 +328,7 @@ final class UnsafeByteBufUtil {
static void setBytes(AbstractByteBuf buf, long addr, int index, ByteBuf src, int srcIndex, int length) {
buf.checkIndex(index, length);
checkNotNull(src, "src");
- if (AbstractByteBuf.isInvalid(srcIndex, length, src.capacity())) {
+ if (isOutOfBounds(srcIndex, length, src.capacity())) {
throw new IndexOutOfBoundsException("srcIndex: " + srcIndex);
}
| [UnsafeByteBufUtil->[getLong->[getLong,getByte],getBytes->[setBytes],setBytes->[getBytes],getUnsignedMedium->[getByte,getShort],getInt->[getByte,getInt],getShort->[getByte,getShort],getByte->[getByte]]] | region > setBytes. | Also I would prefer if you revert all of these changes above as these not belong to the header change if you ask me. |
@@ -31,6 +31,11 @@ namespace ApiPlatform\Core\Api;
*/
interface UrlGeneratorInterface
{
+ /**
+ * Allow to generate url using the globally configured strategy.
+ */
+ public const DEFAULT = -1;
+
/**
* Generates an absolute URL, e.g. "http://example.com/dir/file".
*/
| [No CFG could be retrieved] | This class is a class that implements the standard standard standard for generating a single object Returns a path for a specific route. | Maybe would it be more consistent zither the rest of the API to use null instead? Not really sure, just asking. |
@@ -77,9 +77,8 @@ def create_default_subject(mne_root=None, fs_home=None, update=False,
Parameters
----------
- mne_root : None | str
- The mne root directory (only needed if MNE_ROOT is not specified as
- environment variable).
+ mne_root : None
+ This argument is not used anymore.
fs_home : None | str
The freesurfer home directory (only needed if FREESURFER_HOME is not
specified as environment variable).
| [_is_mri_subject->[_find_head_bem],fit_matched_points->[_trans_from_params],scale_bem->[_scale_params],_scale_params->[read_mri_cfg],fit_point_cloud->[_trans_from_params],scale_source_space->[_scale_params],scale_mri->[scale_bem,_write_mri_config,scale_labels,_find_mri_paths],create_default_subject->[_make_writable_recursive],_is_scaled_mri_subject->[_is_mri_subject],_make_writable_recursive->[_make_writable],scale_labels->[_find_label_paths,read_mri_cfg]] | Create a default subject for a given MRI. Check if a is present in the system and if not create it. copy fsaverage from mne directory to dest directory. | Is there a better way to handle the first argument which became redundant? |
@@ -175,7 +175,7 @@ function generate_device_link($device, $text = null, $vars = array(), $start = 0
$class = devclass($device);
if (!$text) {
- $text = $device['hostname'];
+ $text = format_hostname($device['hostname']);
}
$text = format_hostname($device, $text);
| [getlocations->[hasGlobalRead],get_postgres_databases->[getFirstComponentID,getComponents],get_zfs_pools->[getFirstComponentID,getComponents],get_fail2ban_jails->[getFirstComponentID,getComponents],get_dashboards->[all],get_portactivity_ports->[getFirstComponentID,getComponents],bill_permitted->[hasGlobalRead],device_permitted->[hasGlobalRead]] | Generate a link to a device Generate a link to the overlib graph. | Did i miss something? As i see $text will be formated directly after this if statement with `$text = format_hostname($device, $text);` |
@@ -225,6 +225,17 @@ function ciBuildSha() {
return isPullRequestBuild() ? ciPullRequestSha() : ciCommitSha();
}
+/**
+ * Signal to dependent jobs that they should be skipped.
+ *
+ * Currently only relevant for CircleCI builds.
+ */
+function signalGracefulHalt() {
+ if (isCircleciBuild()) {
+ fs.closeSync(fs.openSync('/tmp/workspace/.CI_GRACEFULLY_HALT', 'w'));
+ }
+}
+
module.exports = {
ciBuildId,
ciBuildSha,
| [No CFG could be retrieved] | Returns the commit SHA being tested by a push or PR build. | Since `ci.js` only provides existing state from the environment, I think this function should live in `utils.js`. |
@@ -614,9 +614,15 @@ def lcmv_raw(raw, forward, noise_cov, data_cov, reg=0.05, label=None,
@verbose
def _lcmv_source_power(info, forward, noise_cov, data_cov, reg=0.05,
- label=None, picks=None, pick_ori=None,
- rank=None, verbose=None):
+ label=None, picks=None, pick_ori=None, rank=None,
+ weight_norm=None, verbose=None):
"""Linearly Constrained Minimum Variance (LCMV) beamformer."""
+
+ if weight_norm not in [None, 'unit-noise-gain']:
+ raise ValueError('Unrecognized weight normalization option in '
+ 'weight_norm, available choices are None and '
+ '"unit-noise-gain".')
+
if picks is None:
picks = pick_types(info, meg=True, eeg=True, ref_meg=False,
exclude='bads')
| [_lcmv_source_power->[_prepare_beamformer_input,_reg_pinv],lcmv_raw->[_setup_picks,_apply_lcmv],lcmv->[_setup_picks,_apply_lcmv],tf_lcmv->[_setup_picks,_lcmv_source_power],lcmv_epochs->[_setup_picks,_apply_lcmv],_apply_lcmv->[_reg_pinv]] | Linearly Constrained Minimum Variance ( LCMV. Estimate the source power and source orientation of a node in the graph. | . Got %s") % weight_norm |
@@ -8,13 +8,15 @@
namespace Builder {
-Topic::Topic(const TopicConfig& config, DDS::DomainParticipant_var& participant)
+Topic::Topic(const TopicConfig& config, DDS::DomainParticipant_var& participant,
+ std::map<std::string, DDS::ContentFilteredTopic_var>& content_filtered_topics_map)
: name_(config.name.in())
, type_name_((strlen(config.type_name.in()) == 0 && TypeSupportRegistry::get_type_names().size() == 1) ? TypeSupportRegistry::get_type_names().front() : config.type_name.in())
, listener_type_name_(config.listener_type_name.in())
, listener_status_mask_(config.listener_status_mask)
, listener_properties_(config.listener_properties)
, transport_config_name_(config.transport_config_name.in())
+ , content_filtered_topics_(config.content_filtered_topics)
, participant_(participant)
{
Log::log()
| [name_->[bind_config,create_listener,strlen,c_str,str,empty,get_default_topic_qos,create_topic,get_type_names,in,APPLY_QOS_MASK]] | Topic creation procedure. Adds missing values to the QoS policy masks. Private method for creating a new topic and listener. | use your map typedef |
@@ -78,6 +78,7 @@ class ExplicitStrategy(BaseExplicitStrategy):
self.SetOneOrZeroInProcessInfoAccordingToBoolValue(self.spheres_model_part, POISSON_EFFECT_OPTION, self.poisson_effect_option)
self.SetOneOrZeroInProcessInfoAccordingToBoolValue(self.spheres_model_part, SHEAR_STRAIN_PARALLEL_TO_BOND_OPTION, self.shear_strain_parallel_to_bond_option)
self.spheres_model_part.ProcessInfo.SetValue(MAX_NUMBER_OF_INTACT_BONDS_TO_CONSIDER_A_SPHERE_BROKEN, self.max_number_of_intact_bonds_to_consider_a_sphere_broken)
+ self.spheres_model_part.ProcessInfo.SetValue(SIGMA_3_AVERAGE, 0.0)
for properties in self.spheres_model_part.Properties:
ContinuumConstitutiveLawString = properties[DEM_CONTINUUM_CONSTITUTIVE_LAW_NAME]
| [ExplicitStrategy->[ModifyProperties->[ModifyProperties],Initialize->[Initialize],__init__->[__init__]]] | Creates a new CPlusPlusStrategy. Updates the cplusplus_strategy and cplusplus_strategy attributes. | Are we adding this for all DEM computations? We must find an alternative solution. |
@@ -47,9 +47,13 @@ class ShardedDatasetReader(DatasetReader):
"""
Just delegate to the base reader text_to_instance.
"""
- return self.reader.text_to_instance(*args, **kwargs) # type: ignore
+ return self.reader.text_to_instance(*args, **kwargs)
+
+ @overrides
+ def ensure_instance(self, raw_data) -> Instance:
+ return self.reader.ensure_instance(raw_data)
- def _read(self, file_path: str) -> Iterable[Instance]:
+ def _read(self, file_path: str):
shards = glob.glob(file_path)
# Ensure a consistent order.
shards.sort()
| [ShardedDatasetReader->[text_to_instance->[text_to_instance]]] | A function to read the text file and return an instance of the class. | Why remove the type annotation? |
@@ -1,5 +1,7 @@
<?php
+jetpack_require_lib( 'class.jetpack-service-helpers' );
+
class Publicize extends Publicize_Base {
function __construct() {
| [Publicize->[get_services->[get_connections],save_publicized_facebook_account->[get_connection_meta],save_publicized_twitter_account->[get_connection_meta],get_connections->[get_all_connections],admin_page_load->[disconnect],test_connection->[get_connection_id,refresh_url],options_page_tumblr->[get_all_connections],set_remote_publicize_options->[globalization],save_publicized->[get_all_connections],options_page_facebook->[get_all_connections],set_post_flags->[get_all_connections],get_all_connections_for_user->[get_all_connections],enhaced_twitter_cards_site_tag->[get_connection_meta,get_connections],options_save_other->[globalization]]] | Constructor for the class This function is used to add filters to the publicize page. | You forgot to rename this to `class.jetpack-service-helper` |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.