patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -258,7 +258,7 @@ def install_req_from_line(
elif '=' in req and not any(op in req for op in operators):
add_msg = "= is not a valid operator. Did you mean == ?"
else:
- add_msg = traceback.format_exc()
+ add_msg = ""
raise InstallationError(
"Invalid requirement: '%s'\n%s" % (req, add_msg)
)
| [install_req_from_editable->[parse_editable],parse_editable->[_strip_extras],install_req_from_line->[deduce_helpful_msg,_strip_extras]] | Creates an InstallRequirement from a line of setup. py filename or URL. Install a missing - check constraint for a missing - check requirement. | Ideally, I'd say we'd llike an additional `logger.debug()` to have the traceback in verbose mode |
@@ -0,0 +1,18 @@
+#!/usr/local/bin/node
+const execSync = require( "child_process" ).execSync;
+
+const homeDirectory = execSync( `echo $HOME` ).toString().split( "\n" )[ 0 ];
+const yarnLinkDir = homeDirectory + "/.config/yarn/link";
+
+const toRemove = execSync( `ls`, { cwd: yarnLinkDir } ).toString().split( "\n" ).filter( value => value.includes( "yoast" ) );
+
+// Remove the symlinks from the yarn link directory.
+var x;
+for ( x in toRemove ) {
+ execSync( `rm -rf ${ toRemove[ x ] }`, { cwd: yarnLinkDir } );
+}
+
+// Remove the symlinks from node_modules.
+execSync( `rm -rf *yoast*`, { cwd: "./node_modules/" } );
+
+console.log( "All previously linked yoast packages have been unlinked." );
| [No CFG could be retrieved] | No Summary Found. | Identical blocks of code found in 2 locations. Consider refactoring. |
@@ -94,7 +94,7 @@ namespace DotNetNuke.Services.Upgrade.Internals
connectionConfig.Password = value;
break;
case "integrated security":
- connectionConfig.Integrated = (value.ToLower() == "true");
+ connectionConfig.Integrated = (value.ToLowerInvariant() == "true");
break;
case "attachdbfilename":
connectionConfig.File = value.Replace("|DataDirectory|", "");
| [InstallControllerImpl->[TestDatabaseConnection->[TestDatabaseConnection]]] | This method returns a ConnectionConfig object from the web. xml file. | Please use `String#Equals(String, StringComparison)` |
@@ -13,6 +13,7 @@ class PyAutopep8(PythonPackage):
homepage = "https://github.com/hhatto/autopep8"
url = "https://pypi.io/packages/source/a/autopep8/autopep8-1.2.4.tar.gz"
+ version('1.4.4', sha256='4d8eec30cc81bc5617dbf1218201d770dc35629363547f17577c61683ccfb3ee')
version('1.3.3', sha256='ff787bffb812818c3071784b5ce9a35f8c481a0de7ea0ce4f8b68b8788a12f30')
version('1.2.4', sha256='38e31e266e29808e8a65a307778ed8e402e1f0d87472009420d6d18146cdeaa2')
version('1.2.2', sha256='ecc51614755c7f697e83478f87eb6bbd009075a397c15080f0311aaecbbdfca8')
| [PyAutopep8->[depends_on,version,extends]] | Creates a class that automatically formats Python code to conform to the PEP. | The required version of `py-pycodestyle` has changed. |
@@ -13,4 +13,14 @@ final class SubstituteStringUtil {
@RecomputeFieldValue(kind = RecomputeFieldValue.Kind.Reset)
private static SecureRandom rnd;
+ @Substitute
+ public static String randomIdentifer(int len) {
+ SecureRandom rnd = new SecureRandom();
+ final String AB = "ABCDEFGHIJKLMNOPQRSTUVWXYZ";
+
+ StringBuilder sb = new StringBuilder(len);
+ for (int i = 0; i < len; i++)
+ sb.append(AB.charAt(rnd.nextInt(AB.length())));
+ return sb.toString();
+ }
}
| [No CFG could be retrieved] | This method is called when the field is recomputed. | I wonder if we could use `NewInstance` instead of `Reset` and get rid of the method substitution. |
@@ -133,13 +133,6 @@ public final class OMConfigKeys {
"ozone.om.ratis.log.purge.gap";
public static final int OZONE_OM_RATIS_LOG_PURGE_GAP_DEFAULT = 1000000;
- // OM Snapshot configurations
- public static final String OZONE_OM_RATIS_SNAPSHOT_AUTO_TRIGGER_THRESHOLD_KEY
- = "ozone.om.ratis.snapshot.auto.trigger.threshold";
- public static final long
- OZONE_OM_RATIS_SNAPSHOT_AUTO_TRIGGER_THRESHOLD_DEFAULT
- = 400000;
-
// OM Ratis server configurations
public static final String OZONE_OM_RATIS_SERVER_REQUEST_TIMEOUT_KEY
= "ozone.om.ratis.server.request.timeout";
| [OMConfigKeys->[valueOf]] | region Public API Documentation Get the name of the configuration that should be used for the Ratis server. | We need this config to be able to control the snapshot trigger from Ratis side for testing purposes. For some tests (TestOzoneManagerHA, OM HA robot tests) we need to set a lower value for auto trigger threshold so that logs can be purged which in turn can instantiate install snapshots. We can keep it as an internal config and not expose it to users. |
@@ -234,9 +234,8 @@ public class TestCaseTest {
private TopologyTestDriverContainer getSampleTopologyTestDriverContainer() {
return TopologyTestDriverContainer.of(
topologyTestDriver,
- ImmutableList.of(new KsqlTopic("FOO", "foo_kafka", new KsqlJsonSerdeFactory(), false)),
- new KsqlTopic("BAR", "bar_kafka", new KsqlJsonSerdeFactory(), false),
- new Pair<>(WindowType.NO_WINDOW, Long.MIN_VALUE)
+ ImmutableList.of(new Topic("FOO", Optional.empty(), new StringSerdeSupplier(), 1, 1)),
+ new Topic("BAR", Optional.empty(), new StringSerdeSupplier(), 1, 1)
);
}
| [TestCaseTest->[shouldProcessInputRecords->[processInput,pipeInput,getName,value,timestamp,topic,equalTo,key,String,getSampleTopologyTestDriverContainer,capture,assertThat],shouldValidateOutputCorrectly->[thenReturn,verifyOutput,getSampleTopologyTestDriverContainer],shouldFailForIncorrectOutput->[expect,verifyOutput,thenReturn,expectMessage,getSampleTopologyTestDriverContainer],shouldRegisterSchemaInInitialization->[of,mock,Topic,AvroSerdeSupplier,empty,emptyMap,emptyList,register,none,TestCase,initializeTopics],shouldVerifyTopology->[setGeneratedTopologies,of,empty,TopologyAndConfigs,setExpectedTopology,verifyTopology],shouldFailForInvalidToplogy->[setGeneratedTopologies,expect,of,expectMessage,empty,TopologyAndConfigs,setExpectedTopology,verifyTopology],shouldFilterNonSourceTopics->[processInput,KsqlTopic,pipeInput,of,any,KsqlJsonSerdeFactory],getSampleTopologyTestDriverContainer->[KsqlTopic,of,KsqlJsonSerdeFactory],shouldCreateTopicInInitialization->[mock,createTopic,initializeTopics],of,Topic,empty,emptyMap,emptyList,none,StringSerdeSupplier,TestCase,Record]] | get sample topology test driver container. | any reason not to use `topic` here? |
@@ -90,8 +90,16 @@ public class JandexDiscoveryStrategy extends AbstractDiscoveryStrategy {
while (classIterator.hasNext()) {
String className = classIterator.next();
ClassInfo cinfo = cindex.getClassByName(DotName.createSimple(className));
- if (!containsBeanDefiningAnnotation(cinfo, className)) {
- classIterator.remove();
+ if (cinfo != null) {
+ if (!containsBeanDefiningAnnotation(cinfo, className)) {
+ classIterator.remove();
+ }
+ } else {
+ //if ClassInfo is not available (e.g for WEB-INF/lib/jars) then fallback to reflection
+ Class<?> clazz = Reflections.loadClass(resourceLoader, className);
+ if (clazz == null || !Reflections.hasBeanDefiningAnnotation(clazz, initialBeanDefiningAnnotations)) {
+ classIterator.remove();
+ }
}
}
return builder.build();
| [JandexDiscoveryStrategy->[isDeclaredOnBeanClass->[getValue,equals],processAnnotatedDiscovery->[hasNext,getClassIterator,build,getClassByName,remove,next,containsBeanDefiningAnnotation,createSimple],beforeDiscovery->[getAttribute,create,JandexClassFileServices,buildBeanDefiningAnnotationSet,add],buildBeanDefiningAnnotationSet->[getName,build,flags,getAnnotations,asClass,add,name,isMetaAnnotation,target,builder,createSimple],isMetaAnnotation->[equals,getAnnotation,value],containsBeanDefiningAnnotation->[isDeclaredOnBeanClass,loadClass,getClassByName,hasBeanDefiningMetaAnnotationSpecified,getKey,getAnnotations,contains,entrySet],registerHandler,JandexFileSystemBeanArchiveHandler,JandexIndexBeanArchiveHandler]] | Process annotated discovery. | One last thing - we should add `if (clazz != null)` to avoid possible NPE... |
@@ -96,7 +96,7 @@ function events_post(App $a) {
$action = ($event_id == '') ? 'new' : "event/" . $event_id;
$onerror_url = App::get_baseurl() . "/events/" . $action . "?summary=$summary&description=$desc&location=$location&start=$start_text&finish=$finish_text&adjust=$adjust&nofinish=$nofinish";
- if (strcmp($finish,$start) < 0 && !$nofinish) {
+ if (strcmp($finish, $start) < 0 && !$nofinish) {
notice( t('Event can not end before it has started.') . EOL);
if (intval($_REQUEST['preview'])) {
echo( t('Event can not end before it has started.'));
| [No CFG could be retrieved] | Post an event to the event store This is the main entry point for the event system. It can be called after the event This function is used to create a new event object. This function is used to display a single event in the event store. | Standards: Please remove parentheses from language constructs. (also works for `include`/`require`, `return`, etc...) |
@@ -35,11 +35,16 @@ namespace Microsoft.DotNet.CoreSetup.Test.HostActivation
.CaptureStdErr();
}
- public static Command DotNetRoot(this Command command, string dotNetRoot)
+ public static Command DotNetRoot(this Command command, string dotNetRoot, string architecture = null)
{
- return command
+ command = command
.EnvironmentVariable("DOTNET_ROOT", dotNetRoot)
.EnvironmentVariable("DOTNET_ROOT(x86)", dotNetRoot);
+ if (!string.IsNullOrEmpty(architecture))
+ command = command
+ .EnvironmentVariable($"DOTNET_ROOT_{architecture.ToUpper()}", dotNetRoot);
+
+ return command;
}
public static Command MultilevelLookup(this Command command, bool enable)
| [CommandExtensions->[Command->[EnvironmentVariable,TestArtifactsPath,Exists,TraceFileEnvironmentVariable,Delete,CaptureStdErr,TraceLevelEnvironmentVariable,Combine,ToString]]] | Enable tracing and capture outputs in a command. | I think this should only set the architecture specific one if the `architecture` is specified - to allow for testing cases where only one is set. |
@@ -21,9 +21,12 @@ if ($object) {
$url = elgg_normalize_url('activity');
}
+$site_url = parse_url(elgg_get_site_url());
+$domain = htmlspecialchars($site_url['host']);
+
$html = <<<__HTML
<item>
- <guid>$item->id</guid>
+ <guid isPermaLink="false">$domain::$item->id</guid>
<pubDate>$timestamp</pubDate>
<link>$url</link>
<title><![CDATA[$title]]></title>
| [getSubjectEntity,getTimePosted,getURL,getObjectEntity] | Print the item s . | These aren't GUIDs even in the siloed Elgg site. Wouldn't it have to be $domain::river::id or something similar? |
@@ -193,8 +193,6 @@ class EventHubProducer(
raise ValueError(
"The partition_key does not match the one of the EventDataBatch"
)
- for message in event_data.message._body_gen: # pylint: disable=protected-access
- add_link_to_send(message, span)
wrapper_event_data = event_data # type:ignore
else:
if partition_key:
| [EventHubProducer->[send->[_send_event_data_with_retry,_wrap_eventdata],_send_event_data->[_set_msg_timeout]]] | Wraps an EventData object with a new EventDataBatch. | need `trace_message` for message in the _body_gen? otherwise it looks like we're not handling OT in this case. |
@@ -44,7 +44,17 @@ final class ChainItemDataProvider implements ItemDataProviderInterface
continue;
}
- return $dataProvider->getItem($resourceClass, $id, $operationName, $context);
+ $identifier = $id;
+ if (!$dataProvider instanceof DenormalizedIdentifiersAwareItemDataProviderInterface && $identifier && \is_array($identifier)) {
+ if (\count($identifier) > 1) {
+ @trigger_error(sprintf('Receiving "$id" as non-array in an item data provider is deprecated in 2.3 in favor of implementing "%s".', DenormalizedIdentifiersAwareItemDataProviderInterface::class), E_USER_DEPRECATED);
+ $identifier = http_build_query($identifier, '', ';');
+ } else {
+ $identifier = current($identifier);
+ }
+ }
+
+ return $dataProvider->getItem($resourceClass, $identifier, $operationName, $context);
} catch (ResourceClassNotSupportedException $e) {
@trigger_error(sprintf('Throwing a "%s" is deprecated in favor of implementing "%s"', \get_class($e), RestrictedDataProviderInterface::class), E_USER_DEPRECATED);
continue;
| [ChainItemDataProvider->[getItem->[getItem,supports]]] | Returns the item with the given id. | Update done @dunglas, do you want me to move this statement up to avoid the `else` ? |
@@ -1523,7 +1523,8 @@ def main():
set_grpc_build_flags()
set_cc_opt_flags(environ_cp)
- set_build_strip_flag()
+ if "BAZEL_NO_STRIP" not in environ_cp:
+ set_build_strip_flag()
set_windows_build_flags()
if get_var(
| [set_cc_opt_flags->[is_windows,write_to_bazelrc,is_ppc64le],set_build_var->[write_to_bazelrc,get_var],set_computecpp_toolkit_path->[toolkit_exists->[is_linux],prompt_loop_or_load_from_env,write_action_env_to_bazelrc],get_python_major_version->[run_shell],set_clang_cuda_compiler_path->[write_action_env_to_bazelrc,get_from_env_or_user_or_default],create_android_ndk_rule->[cygpath,is_windows,prompt_loop_or_load_from_env,is_cygwin,is_macos,write_action_env_to_bazelrc],set_build_strip_flag->[write_to_bazelrc],set_tf_cuda_clang->[set_action_env_var],set_tf_cudnn_version->[UserInputError,run_shell,cygpath,is_windows,is_cygwin,is_macos,get_from_env_or_user_or_default,is_linux,write_action_env_to_bazelrc,reformat_version_sequence],set_trisycl_include_dir->[write_action_env_to_bazelrc,get_from_env_or_user_or_default],setup_python->[cygpath,is_windows,get_input,is_cygwin,get_python_major_version,write_to_bazelrc,get_python_path,write_action_env_to_bazelrc],check_ndk_level->[is_cygwin,cygpath,is_windows],set_host_c_compiler->[prompt_loop_or_load_from_env,write_action_env_to_bazelrc],main->[set_cc_opt_flags,is_windows,config_info_line,set_build_var,set_computecpp_toolkit_path,is_macos,set_clang_cuda_compiler_path,create_android_ndk_rule,set_build_strip_flag,set_tf_cuda_clang,set_tf_cudnn_version,set_trisycl_include_dir,cleanup_makefile,setup_python,set_host_c_compiler,set_tf_download_clang,set_gcc_host_compiler_path,set_tf_nccl_install_path,set_other_mpi_vars,is_linux,set_tf_cuda_compute_capabilities,write_action_env_to_bazelrc,set_action_env_var,set_windows_build_flags,create_android_sdk_rule,set_other_cuda_vars,get_var,set_tf_tensorrt_install_path,set_grpc_build_flags,write_to_bazelrc,check_bazel_version,reset_tf_configure_bazelrc,set_tf_cuda_version,set_host_cxx_compiler,set_mpi_home],set_tf_download_clang->[set_action_env_var],set_gcc_host_compiler_path->[prompt_loop_or_load_from_env,write_action_env_to_bazelrc],set_tf_nccl_install_path->[UserInputError,cygpath,is_windows,is_cygwin,is_macos,get_from_env_or_user_or_default,is_linux,write_action_env_to_bazelrc,reformat_version_sequence],set_other_mpi_vars->[sed_in_place,symlink_force],set_tf_cuda_compute_capabilities->[get_from_env_or_user_or_default,write_action_env_to_bazelrc,get_native_cuda_compute_capabilities],write_action_env_to_bazelrc->[write_to_bazelrc],set_windows_build_flags->[write_to_bazelrc,is_windows],set_action_env_var->[get_var,write_action_env_to_bazelrc],create_android_sdk_rule->[cygpath,is_windows,prompt_loop_or_load_from_env,is_cygwin,is_macos,write_action_env_to_bazelrc],get_native_cuda_compute_capabilities->[run_shell],set_other_cuda_vars->[write_to_bazelrc,write_action_env_to_bazelrc,is_windows],get_var->[UserInputError,get_input],prompt_loop_or_load_from_env->[UserInputError,get_from_env_or_user_or_default],set_tf_tensorrt_install_path->[is_compatible->[run_shell,convert_version_to_int],UserInputError,find_libs,is_compatible,get_var,run_shell,convert_version_to_int,get_from_env_or_user_or_default,is_linux,write_action_env_to_bazelrc],set_grpc_build_flags->[write_to_bazelrc],check_bazel_version->[run_shell,convert_version_to_int],get_python_path->[run_shell],reset_tf_configure_bazelrc->[is_windows],set_tf_cuda_version->[UserInputError,cygpath,is_windows,is_cygwin,is_macos,get_from_env_or_user_or_default,is_linux,write_action_env_to_bazelrc,reformat_version_sequence],get_from_env_or_user_or_default->[get_input],set_host_cxx_compiler->[prompt_loop_or_load_from_env,write_action_env_to_bazelrc],set_mpi_home->[prompt_loop_or_load_from_env],main] | Entry point for the bazel - cz CLI. Find and return a node in the system that matches the specified constraint. Get the node id from the system. Set flags for a specific node. | Can we do environ_cp.get('BAZEL_NO_STRIP') == '1' instead just to be safe? |
@@ -113,7 +113,7 @@ func NewServer(logger *logp.Logger, cfg *config.Config, tracer *apm.Tracer, proc
var fetcher *agentcfg.Fetcher
if cfg.Kibana.Enabled {
client = kibana.NewConnectingClient(&cfg.Kibana)
- fetcher = agentcfg.NewFetcher(client, cfg.AgentConfig.Cache.Expiration)
+ fetcher = agentcfg.NewFetcher(client, cfg.KibanaAgentConfig.Cache.Expiration)
}
RegisterGRPCServices(
srv.grpc.server,
| [serveHTTP->[Serve,Addr,Infof],Stop->[Infof,Background,GracefulStop,Shutdown,Close,Errorf],serveGRPC->[Serve,Addr,Infof],Serve->[Wait,Go],ForPrivilege,Wrap,NewConnectingClient,NewFetcher,NewUnaryServerInterceptor,WithTracer,RegisterCollectorServiceServer,WithRecovery,Named,Timeout,RegisterSamplingManagerServer,NewTLS,Logging,Creds,NewBuilder,ChainUnaryInterceptor,Listen,NewServer,Metrics] | registers the necessary services for a specific tag. RegisterGRPCServices registers Jaeger gRPC services with a gRPC server. | We should be using the DirectFetcher here too. Can you either change the code to pass a shared Fetcher into all the places it's needed, or add a TODO to do that in a followup? |
@@ -1,9 +1,12 @@
require 'rails_helper'
-feature 'saml api' do
+class MockSession; end
+
+shared_examples 'saml api' do |cloudhsm_enabled|
include SamlAuthHelper
include IdvHelper
+ before { enable_cloudhsm(cloudhsm_enabled) }
let(:user) { create(:user, :signed_up) }
context 'SAML Assertions' do
| [visit,create,text,new,let,find,issuer,feature,join,first,it,domain_name,sort_by,travel,to,soft,sign_in_before_2fa,return,strict_encode64,to_der,before,html,click_button,idp_sso_target_url,second,destroy,t,require,header,login_two_factor_path,change,include,sign_in_and_2fa_user,saml_response,to_json,read,from_issuer,fill_in,context,name_identifier_value,value,timeout_in,uuid,fingerprint_cert,decode64,idp_slo_target_url,eq,after,to_return,assertion_consumer_service_url,and_return,idp_cert_fingerprint] | Provides a simple interface to the SAML 2. 0 API. Template binding with XML response. | I think we could probably get away with just one happy path spec that tests that CloudHSM is called instead of running through all the specs with CloudHSM. |
@@ -153,7 +153,7 @@ TEST_F(EventsDatabaseTests, test_record_range) {
for (size_t j = 0; j < 30; j++) {
// 110 is 10 below an index (60.2).
- sub->testAdd(110 + j);
+ sub->testAdd(110 + static_cast<int>(j));
}
indexes = sub->getIndexes(110, 0);
| [No CFG could be retrieved] | Get all of the records in a specific index. - - - - - - - - - - - - - - - - - -. | You could also change the signature for this method. |
@@ -175,14 +175,6 @@ func Migrate(ctx *context.APIContext, form api.MigrateRepoOptions) {
err = errors.New(buf.String())
}
- if err == nil {
- repo.Status = models.RepositoryReady
- if err := models.UpdateRepositoryCols(repo, "status"); err == nil {
- notification.NotifyMigrateRepository(ctx.User, repoOwner, repo)
- return
- }
- }
-
if repo != nil {
if errDelete := models.DeleteRepository(ctx.User, repoOwner.ID, repo.ID); errDelete != nil {
log.Error("DeleteRepository: %v", errDelete)
| [NotifyMigrateRepository,IsErrNameCharsNotAllowed,GetUserByID,MigrateRepository,Stack,CreateRepository,Error,ToRepo,GetErrMsg,URLSanitizedError,New,Errorf,IsErrReachLimitOfRepo,IsErrNameReserved,IsErrInvalidCloneAddr,HasError,IsOrganization,ToGitServiceType,Trace,JSON,MaxCreationLimit,IsTwoFactorAuthError,IsErrNamePatternNotAllowed,IsOwnedBy,Contains,IsErrUserNotExist,GetUserByName,DeleteRepository,GetManager,Fprintf,IsRateLimitError,IsErrMigrationNotAllowed,IsErrRepoFilesAlreadyExist,UpdateRepositoryCols,Sprintf,ParseRemoteAddr,HammerContext,String,IsErrRepoAlreadyExist] | Creates a new repository in the database. This function is called when a repository already exists. | Why no migration notification? |
@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+module ChatChannels
+ class IndexingJob < ApplicationJob
+ queue_as :chat_channels_indexing
+
+ def perform(chat_channel_id:)
+ chat_channel = ChatChannel.find_by(id: chat_channel_id)
+
+ return unless chat_channel
+
+ chat_channel.index!
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I'm thinking `chat_channels_index` might be more appropriate, as in the action "to index". Even better probably "AddToIndex". What do you think? Just an idea, there's no enforced rule on that in the code, some jobs are named after actions, some are not. |
@@ -636,6 +636,7 @@ Any pachctl command that can take a Commit ID, can take a branch name instead.`,
createBranch.Flags().StringVar(&trigger.CronSpec, "trigger-cron", "", "The cron spec to use in triggering.")
createBranch.Flags().StringVar(&trigger.Size_, "trigger-size", "", "The data size to use in triggering.")
createBranch.Flags().Int64Var(&trigger.Commits, "trigger-commits", 0, "The number of commits to use in triggering.")
+ createBranch.Flags().BoolVar(&trigger.All, "trigger-all", false, "Only trigger when all conditions are met, rather than when any are met.")
commands = append(commands, cmdutil.CreateAlias(createBranch, "create branch"))
inspectBranch := &cobra.Command{
| [StringVar,Pull,PrintDetailedCommitInfo,TempFile,TempDir,SubscribeCommit,Acquire,HasPrefix,CreateRepo,DeleteCommit,UintVar,Walk,RunFixedArgs,Flush,New,CreateDocsAlias,NewPutFileClient,PrintDetailedBranchInfo,StartCommit,NewWriter,GetFile,MarkFlagCustom,Split,PutFile,Println,Stdin,AddFlagSet,Finish,IntVarP,SameFlag,PushFile,BoolVar,Dir,FinishCommit,Close,ParseBranch,Is,PrintDetailedFileInfo,RunBoundedArgs,Marshal,Page,WithGZIPCompression,LookPath,Release,FlushCommit,CopyFile,Create,Next,StringSliceVarP,NewPuller,PrintDiffFileInfo,MkdirAll,ListBranch,Printf,ParseBranches,IsDir,PrintFileInfo,PrintDetailedRepoInfo,CreateAlias,TrimPrefix,FilesystemCompletion,GetTag,CreateBranch,PutFileSplit,PutFileURL,InspectCommit,WithMaxConcurrentStreams,GlobFile,FileCompletion,Clean,DiffFile,Stat,NewScanner,Text,Wrapf,InspectBranch,PutFileOverwrite,PrintCommitInfo,Name,ParseHistory,Get,NewRepo,Scan,ParseFile,PrintBranch,PrintRepoInfo,InspectRepo,String,Parse,Open,RegisterCompletionFunc,Run,BoolVarP,Flags,DeleteFile,RemoveAll,GetObject,NewCommit,Fields,ParseCommit,DeleteBranch,NewFile,Mode,ListRepo,Go,Ctx,StringVarP,VarP,Errorf,DeleteRepo,LoadOrStore,Wait,InspectFile,Join,ExitCode,ListCommitF,InspectPipeline,ListFileF,NewFlagSet,Command,Int64Var,Fprintf,NewOnUserMachine,WithActiveTransaction,NewCommitProvenance,Fsck,CreateBranchTrigger,ScrubGRPC,ParseCommits,AndCacheFunc] | returns the unique identifier of the branch to create. c returns a list of branch ids that can be used to find a branch in a. | This exposes a trigger parameter I forgot to expose in the first pass on this. |
@@ -122,7 +122,7 @@ namespace System.Text.Json.Serialization.Tests
@"""MyDateTime"" : ""2019-01-30T12:01:02.0000000Z""," +
@"""MyDateTimeOffset"" : ""2019-01-30T12:01:02.0000000+01:00""," +
@"""MyGuid"" : ""1B33498A-7B7D-4DDA-9C13-F6AA4AB449A6""," +
- @"""MyUri"" : ""https://github.com/dotnet/corefx""," +
+ @"""MyUri"" : ""https://github.com/dotnet/runtime""," +
@"""MyEnum"" : 2," + // int by default
@"""MyInt64Enum"" : -9223372036854775808," +
@"""MyUInt64Enum"" : 18446744073709551615," +
| [SimpleTestClass->[Initialize->[Utc,Max,Two,MinNegative,CreateRange,Add],Verify->[Value,Count,False,Max,First,One,MyString,Null,MyInt32Array,Key,Equal,Current,MyInt64,Contains,Name,GetEnumerator,MoveNext,Utc,EnumerateObject,Two,MinNegative,GetString,True],GetBytes]] | A class to store the JSON representation of a variable number of nanoseconds. Returns a string representation of the given . | These changes are causing failures in the System.Text.Json tests |
@@ -722,7 +722,6 @@ Parser.prototype = {
ensureSafeObject(context, expressionText);
ensureSafeFunction(fn, expressionText);
- // IE stupidity! (IE doesn't have apply for some native functions)
var v = fn.apply
? fn.apply(context, args)
: fn(args[0], args[1], args[2], args[3], args[4]);
| [No CFG could be retrieved] | Parses a function call which can be a function call a function call a function call a function END of function parseArrayLiteral. | I've asked if this is still factual, if it's not true of IE9 we can probably just delete this (yay!) |
@@ -59,10 +59,11 @@ function writeFiles() {
writeJhipsterConsole() {
if (this.jhipsterConsole) {
- this.template('console/_logstash-config.yml', 'console/logstash-config.yml');
+ // this.template('console/_logstash-config.yml', 'console/logstash-config.yml');
this.template('console/_jhipster-elasticsearch.yml', 'console/jhipster-elasticsearch.yml');
this.template('console/_jhipster-logstash.yml', 'console/jhipster-logstash.yml');
this.template('console/_jhipster-console.yml', 'console/jhipster-console.yml');
+ this.template('console/_jhipster-dashboard-console.yml', 'console/jhipster-dashboard-console.yml');
}
},
| [No CFG could be retrieved] | Generates a template for the configuration files that are needed by the application. region Config Loader. | can we remove it if not needed? |
@@ -122,4 +122,9 @@ public enum Element {
final Element element = MAP.get(localName);
return element == null ? UNKNOWN : element;
}
+
+ @Override
+ public String toString() {
+ return name;
+ }
}
| [forName->[get],getLocalName,values,put] | Get the element with the given name. | Do we want to put the class name? |
@@ -177,8 +177,8 @@ public class TestShowStats
@Test
public void testShowStatsWithSelectFunctionCallFails()
{
- assertQueryFails("SHOW STATS FOR (SELECT sin(orderkey) FROM orders)", ".*Only SELECT \\* is supported in SHOW STATS SELECT clause");
- assertQueryFails("SHOW STATS FOR (SELECT count(*) FROM orders)", ".*Only SELECT \\* is supported in SHOW STATS SELECT clause");
+ assertQueryFails("SHOW STATS FOR (SELECT sin(orderkey) FROM orders)", ".*Only table columns names are supported in SHOW STATS SELECT clause");
+ assertQueryFails("SHOW STATS FOR (SELECT count(*) FROM orders)", ".*Only table columns names are supported in SHOW STATS SELECT clause");
}
@Test
| [TestShowStats->[createQueryRunner->[build],testShowStatsWithSelectFunctionCallFails->[assertQueryFails],testShowStatsWithNonPushDownFilterFails->[assertQueryFails],testShowStatsWithoutFromFails->[assertQueryFails],testShowStats->[assertQuery],testShowStatsWithMultipleFromFails->[assertQueryFails],setUp->[assertUpdate],testShowStatsWithHavingFails->[assertQueryFails],testShowStatsWithSelectDistinctFails->[assertQueryFails],testShowStatsSelectNonStarFails->[assertQueryFails],testShowStatsWithGroupByFails->[assertQueryFails]]] | This test fails if the SHOW STATS query fails and there are no conditions that can be. | This belongs to the first commit |
@@ -166,7 +166,7 @@ public class DefaultLoginAPIAuthenticatorCmd extends BaseCmd implements APIAuthe
throw new CloudAuthenticationException("Unable to find the domain from the path " + domain);
}
final UserAccount userAccount = _accountService.getActiveUserAccount(username[0], domainId);
- if (userAccount == null || !(User.Source.UNKNOWN.equals(userAccount.getSource()) || User.Source.LDAP.equals(userAccount.getSource()))) {
+ if (userAccount != null && User.Source.SAML2 == userAccount.getSource()) {
throw new CloudAuthenticationException("User is not allowed CloudStack login");
}
return ApiResponseSerializer.toSerializedString(_apiServer.loginUser(session, username[0], pwd, domainId, domain, remoteAddress, params),
| [DefaultLoginAPIAuthenticatorCmd->[authenticate->[loginUser,fetchDomainId,getMessage,equals,getActiveUserAccount,invalidate,warn,toSerializedString,getSource,ServerApiException,getMethod,endsWith,CloudAuthenticationException,valueOf,append,findDomainByIdOrPath,startsWith,getHttpCode,get,getSerializedApiError,parseLong,getId],execute->[ServerApiException],getLogger,getName]] | Authenticates a user using the specified command and parameters. Method to authenticate a user. | Why do we need to remove the check `userAccount == null`? Comparision against Source.SAML2 is fine as long as there are no other user sources other than LDAP, SAML2 and UNKNOWN. (UNKNOWN should be NATIVE though) |
@@ -31,8 +31,7 @@ const gulp = $$.help(require('gulp'));
exports.createModuleCompatibleES5Bundle = function(src) {
return gulp.src('dist/' + src)
.pipe($$.sourcemaps.init({loadMaps: true}))
- .pipe($$.rename(src.replace(/\.js$/, '-module.js')))
- .pipe($$.regexpSourcemaps(/(global\?global:\w*})\(this\)/, '$1(self)', 'module-global'))
+ .pipe($$.regexpSourcemaps(/(window.global\?window.global:\w*)this/, '$1self', 'module-global'))
.pipe($$.sourcemaps.write('./'))
.pipe(gulp.dest('dist'));
};
| [No CFG could be retrieved] | Create a new bundle for module - compatible. js. | just for my own knowledge how is the regexp name used (what is its usefulness)? |
@@ -1108,7 +1108,10 @@ class UsersController < ApplicationController
user = fetch_user_from_params
guardian.ensure_can_edit!(user)
- if !SiteSetting.log_out_strict && params[:token_id]
+ if params[:token_id]
+ token = UserAuthToken.find_by(id: params[:token_id], user_id: user.id)
+ # The user should not be able to revoke the auth token of current session.
+ raise Discourse::NotFound if guardian.auth_token == token.auth_token
UserAuthToken.where(id: params[:token_id], user_id: user.id).each(&:destroy!)
else
UserAuthToken.where(user_id: user.id).each(&:destroy!)
| [UsersController->[destroy->[destroy],admin_login->[create],update->[update],username->[username],read_faq->[read_faq],check_username->[changing_case_of_own_username,check_username],my_redirect->[username],create->[username],account_created->[username]]] | revoke auth token lease. | NotFound is not really the right error message, I would go with a simple 400 here Discourse::InvalidParameters (will change it in a follow up commit) |
@@ -132,7 +132,8 @@ export class Cid {
'[a-zA-Z0-9-_.]+\nInstead found: %s',
getCidStruct.scope);
const viewer = Services.viewerForDoc(this.ampdoc);
-
+ // TODO(zhouyx): Cleanup after tracing #11888
+ const trace = new Error('History trace for: ');
return consent.then(() => {
return viewer.whenFirstVisible();
}).then(() => {
| [Cid->[getExternalCid_->[setCidCookie,isProxyOrigin,getOrCreateCookie,cookieName,scope,getBaseCid,getProxySourceOrigin,OPT_OUT,parseUrl,cryptoFor],optOut->[optOutOfCid],get->[then,timerFor,isOptedOutOfCid,user,cookieName,scope,rethrowAsync,whenFirstVisible,test,viewerForDoc,whenNextVisible],constructor->[create,win]],all,origin,isExpired,getEntropy,createCookieIfNotPresent,isTrustedViewer,base64UrlEncodeFromBytes,setCidCookie,baseCid_,then,localStorage,location,Math,dict,scope,shouldUpdateStoredTime,stringify,set,tryParseJson,parseJson,screen,win,time,storageForDoc,cookieName,user,createCidData,sendMessageAwaitResponse,read,now,cid,getNewCidForCookie,registerServiceBuilderForDoc,getSourceOrigin,getCryptoRandomBytesArray,whenNextVisible,ampdoc,getCookie,resolve,getServiceForDoc,setCookie,isProxyOrigin,cryptoFor,get,isIframed,viewerBaseCid,store,String,viewerForDoc,externalCidCache_] | Get a CID from the AMP doc. | nit: `// TODO(zhouyx, #11888)` so Dima's tool can find these. |
@@ -0,0 +1,3 @@
+<?php
+$version = trim(snmp_get($device, ".1.3.6.1.4.1.5454.1.80.1.1.2.0", "-Oqv", "GIGA-PLUS-MIB"), '"');
+$hardware = "Trango " . trim(snmp_get($device, ".1.3.6.1.2.1.1.1.0", "-Oqv", "GIGA-PLUS-MIB"), '"');
| [No CFG could be retrieved] | No Summary Found. | You are using numerical OIDs here but referencing the MIB, you can either change to using the named OID or drop the MIB name as it won't be used. Same for the below. |
@@ -789,12 +789,15 @@ module.exports = class wavesexchange extends Exchange {
// "9fRAAQjF8Yqg7qicQCL884zjimsRnuwsSavsM1rUdDaoG8mThku"
// ]
// }
+ const currency = this.safeValue (response, 'currency');
+ const networkId = this.safeString (currency, 'platform_id');
const addresses = this.safeValue (response, 'deposit_addresses');
const address = this.safeString (addresses, 0);
return {
'address': address,
'code': code,
'tag': undefined,
+ 'network': networkId,
'info': response,
};
}
| [No CFG could be retrieved] | Get a list of deposit addresses for a given currency code. Get the id of the last match asset. | I think this should be returned as a unified network name, not an exchange-specific id - the user should be able to reuse that in withdraw() and with other calls. |
@@ -159,11 +159,6 @@ func (uc *upgradeCmd) loadCluster(cmd *cobra.Command) error {
return errors.Wrap(err, "error getting list of available upgrades")
}
- // Add the current version to account for failed upgrades.
- orchestratorInfo.Upgrades = append(orchestratorInfo.Upgrades, &api.OrchestratorProfile{
- OrchestratorType: uc.containerService.Properties.OrchestratorProfile.OrchestratorType,
- OrchestratorVersion: uc.containerService.Properties.OrchestratorProfile.OrchestratorVersion})
-
// Validate desired upgrade version and set goal state.
found := false
for _, up := range orchestratorInfo.Upgrades {
| [loadCluster->[IsNotExist,LoadContainerServiceFromFile,Join,Infoln,Stat,ReadFile,WithTimeout,GetOrchestratorVersionProfile,Sprintf,Background,New,Unmarshal,validateAuthArgs,getClient,Errorf,HasWindows,Wrap,EnsureResourceGroup],validate->[LoadTranslations,NormalizeAzureRegion,New,Usage,Duration,Wrap],run->[NewEntry,SerializeContainerService,SaveFile,validate,New,String,Fatalf,UpgradeCluster,loadCluster,GenerateKubeConfig],StringVar,StringVarP,run,Flags,IntVar] | loadCluster loads the cluster from the specified location This function is used to add the current version to the list of upgrades to the orchestr asserts data from the template parameters and creates a new cluster object. | This was adding the current version to the allowed upgrade matrix, making the Cmd validation pass. the upgrade process however was re validating the same thing, disallowing same-version upgrades, and skipping validation alltogether for HostedMaster. I chose to move the validation in the cmd and let the underlying library (operations/upgradecluster) do the upgrades as it pleases. |
@@ -488,13 +488,16 @@ func (d *driver) MakeDirectory(file *pfs.File, shard uint64) (retErr error) {
}
diffInfo.Appends[path.Clean(file.Path)] = _append
}
+ // The fact that this is a directory is signified by setting Children
+ // to non-nil
+ _append.Children = make(map[string]bool)
return nil
}
func (d *driver) GetFile(file *pfs.File, filterShard *pfs.Shard, offset int64, size int64, from *pfs.Commit, shard uint64) (io.ReadCloser, error) {
d.lock.RLock()
defer d.lock.RUnlock()
- fileInfo, blockRefs, err := d.inspectFile(file, filterShard, shard, from, false)
+ fileInfo, blockRefs, err := d.inspectFile(file, filterShard, shard, from, false, false)
if err != nil {
return nil, err
}
| [FinishCommit->[getBlockClient],AddShard->[getBlockClient],DeleteRepo->[getBlockClient],GetFile->[getBlockClient],Read->[Read,blockRef],PutFile->[getBlockClient],CreateRepo->[getBlockClient],DeleteFile->[ListFile,InspectFile,DeleteFile],branchParent->[canonicalCommit]] | MakeDirectory creates a directory in the repository size is the size of the file in bytes from the given commit and shard. | Seems reasonable, was this something we should have been doing before or did the changes here require this? |
@@ -45,13 +45,13 @@ namespace Internal.TypeSystem
get;
}
- public ModuleDesc SystemModule
+ public EcmaModule SystemModule
{
get;
private set;
}
- protected void InitializeSystemModule(ModuleDesc systemModule)
+ protected void InitializeSystemModule(EcmaModule systemModule)
{
Debug.Assert(SystemModule == null);
SystemModule = systemModule;
| [TypeSystemContext->[FieldForInstantiatedTypeKey->[FieldForInstantiatedTypeKeyHashtable->[FieldForInstantiatedType->[InstantiatedType]]],MethodForInstantiatedTypeKey->[MethodForInstantiatedTypeKeyHashtable->[MethodForInstantiatedType->[InstantiatedType]]]]] | InitializeSystemModule - initialize SystemModule if not already initialized. | The common/reusable type system context cannot reference ECMA things because that makes it no longer reusable. Please revert this. Also the change to MetadataTypeSystemContext. |
@@ -66,7 +66,7 @@ func main() {
return _zero, err
}
json0 := string(tmpJSON0)
- return pulumi.String(json0), nil
+ return json0, nil
}).(pulumi.StringOutput),
})
if err != nil {
| [ID,ApplyT,NewBucket,Sprintf,Marshal,Name,NewFileAsset,Export,NewBucketObject,ReadDir,NewBucketPolicy,String,TypeByExtension,Run,Ext] | returns a json object with all the keys that are not in the bucket. | We can return a string here, even though the result type is `pulumi.String`? |
@@ -288,14 +288,14 @@ public:
infostream<<"Audio: Initializing..."<<std::endl;
m_device = alcOpenDevice(NULL);
- if(!m_device){
+ if (!m_device){
infostream<<"Audio: No audio device available, audio system "
<<"not initialized"<<std::endl;
return;
}
m_context = alcCreateContext(m_device, NULL);
- if(!m_context){
+ if (!m_context){
error = alcGetError(m_device);
infostream<<"Audio: Unable to initialize audio context, "
<<"aborting audio initialization ("<<alcErrorString(error)
| [No CFG could be retrieved] | Constructor for OpenALSoundManager. region Audio Audio Audio Audio Audio Audio Audio Audio Audio. | add space before { |
@@ -352,7 +352,7 @@ func PostgresService(local bool, opts *AssetOpts) *v1.Service {
{
Port: 5432,
Name: "client-port",
- NodePort: clientNodePort,
+ NodePort: opts.PostgresOpts.Port,
},
},
},
| [String,Sprintf,Join,MustParse] | PostgresService generates a Service for the pachyderm postgres instance. GRANT ALL PRIVILEGES ON postgres ;. | So this lets us run two postgreses. Do you think we will need to add additional parameters to make the enterprise server's postgres more lightweight? |
@@ -91,12 +91,14 @@ public abstract class BeamKafkaTable extends SchemaBaseBeamTable {
return PCollection.IsBounded.UNBOUNDED;
}
- public abstract PTransform<PCollection<KV<byte[], byte[]>>, PCollection<Row>>
+ protected abstract PTransform<PCollection<KV<byte[], byte[]>>, PCollection<Row>>
getPTransformForInput();
- public abstract PTransform<PCollection<Row>, PCollection<KV<byte[], byte[]>>>
+ protected abstract PTransform<PCollection<Row>, PCollection<KV<byte[], byte[]>>>
getPTransformForOutput();
+ protected abstract BeamKafkaTable getTable();
+
@Override
public PCollection<Row> buildIOReader(PBegin begin) {
return begin
| [BeamKafkaTable->[computeRate->[computeRate],getTableStatistics->[getTopics]]] | This is a override of the base class to provide a sequence of partitions that can be read. | I don't think `BeamKafkaTable#getTable` is used, can we get rid of it? |
@@ -127,6 +127,7 @@ public class KsqlConfig extends AbstractConfig {
ksqlConfigProps.put(KSQL_PERSISTENT_QUERY_NAME_PREFIX_CONFIG, KSQL_PERSISTENT_QUERY_NAME_PREFIX_DEFAULT);
ksqlConfigProps.put(KSQL_TRANSIENT_QUERY_NAME_PREFIX_CONFIG, KSQL_TRANSIENT_QUERY_NAME_PREFIX_DEFAULT);
ksqlConfigProps.put(KSQL_TABLE_STATESTORE_NAME_SUFFIX_CONFIG, KSQL_TABLE_STATESTORE_NAME_SUFFIX_DEFAULT);
+ ksqlConfigProps.put(KSQL_QUERY_CLOSE_WAIT_TIME_CONFIG, KSQL_QUERY_CLOSE_WAIT_TIME_DEFAULT);
if (props.containsKey(DEFAULT_SINK_NUMBER_OF_PARTITIONS)) {
ksqlConfigProps.put(SINK_NUMBER_OF_PARTITIONS_PROPERTY,
| [KsqlConfig->[put->[put],get->[get],clone->[KsqlConfig]]] | The default configuration for the KsqlConfig class. ksqlConfigProps ethernetSinkWindowChangeLogAdditionalRetention - The number of replication. | I may be missing something, but I don't see a `get` for this property. Is it being used? If so, how? |
@@ -495,6 +495,12 @@ bool Ros::getModelCallback(webots_ros::get_string::Request &req, webots_ros::get
return true;
}
+bool Ros::getUrdfCallback(webots_ros::get_string::Request &req, webots_ros::get_string::Response &res) {
+ assert(mRobot);
+ res.value = mRobot->getUrdf();
+ return true;
+}
+
bool Ros::getDataCallback(webots_ros::get_string::Request &req, webots_ros::get_string::Response &res) {
assert(mRobot);
res.value = mRobot->getData();
| [shutdown->[shutdown],run->[publishClockIfNeeded,launchRos]] | This function is called from the Ros API when a Model or Data is not available in. | So in ros there is no way to add a prefix? |
@@ -837,7 +837,7 @@ class ChildTagMatcher {
this.numChildTagsSeen_++; // Increment this first to allow early exit.
if (childTags.childTagNameOneof.length > 0) {
const names = childTags.childTagNameOneof;
- if (names.indexOf(tagName) === -1) {
+ if (!names.includes(tagName)) {
if (!amp.validator.LIGHT) {
const allowedNames = '[\'' + names.join('\', \'') + '\']';
context.addError(
| [TagStack->[matchChildTagName->[matchChildTagName]],info->[info],Context->[setChildTagMatcher->[setLineCol],setReferencePointMatcher->[setLineCol],addError->[getCol,getLine],setCdataMatcher->[setLineCol]],warn->[warn],ParsedValidatorRules->[getReferencePointName->[getSpec],maybeEmitAlsoRequiresTagValidationErrors->[getExtensionUnusedUnlessTagPresent,getAlsoRequiresTagWarning,getDocLocator,getRules,getSpec,addError,satisfiesCondition,getTagspecsValidated,requires],maybeEmitMandatoryAlternativesSatisfiedErrors->[addError,getRules,getMandatoryAlternativesSatisfied,getDocLocator],maybeEmitMandatoryTagValidationErrors->[getTagspecsValidated,addError,getDocLocator],getByTagSpecId->[shouldRecordTagspecValidated],constructor->[registerTagSpec,registerDispatchKey]],error->[error],ParsedTagSpec->[mergeAttrs->[getByAttrSpecId,getSpec,getNameByAttrSpecId]],validateTag->[matchingDispatchKey,allTagSpecs,hasDispatchKeys,hasTagSpecs],endTag->[exitParentTag],UrlErrorInAttrAdapter->[disallowedDomain->[addError,getDocLocator],invalidUrlProtocol->[addError,getDocLocator],invalidUrl->[addError,getDocLocator],disallowedRelativeUrl->[addError,getDocLocator],missingUrl->[addError,getDocLocator]],UrlErrorInStylesheetAdapter->[disallowedDomain->[addError],invalidUrlProtocol->[addError],invalidUrl->[addError],disallowedRelativeUrl->[addError],missingUrl->[addError]],startTag->[match],cdata->[match],ReferencePointMatcher->[explainsAttribute->[hasAttrWithName],constructor->[empty]],markManufacturedBody,markUrlSeen,info,getSpec,isDisallowedDomain,addError,endTag,pcdata,getMandatoryValuePropertyNames,isReferencePoint,getValuePropertiesOrNull,getAttrsByName,getImplicitAttrspecs,getMandatoryAttrIds,getParsedReferencePoints,rcdata,getId,shouldRecordTagspecValidated,error,warn,startDoc,getReferencePoints,getValuePropertyByName,setReferencePointMatcher,recordTagspecValidated,disallowedRelativeUrl,match,getValueUrlSpec,hasReferencePoints,hasSeenUrl,firstSeenUrlTagName,recordMandatoryAlternativeSatisfied,getDocLocator,getRules,invalidUrlProtocol,satisfyCondition,cdata,getNameByAttrSpecId,endDoc,getMandatoryOneofs,getTagStack,containsUrl,disallowedDomain,setChildTagMatcher,isAllowedProtocol,setCdataMatcher,explainsAttribute,getByAttrSpecId,invalidUrl,Result,startTag,requires,missingUrl] | Match the child tag name of the current tag with the given name. | Another special file that can't be updated. |
@@ -20,6 +20,7 @@ use ApiPlatform\Core\Metadata\Property\PropertyMetadata;
use ApiPlatform\Core\Metadata\Resource\Factory\ResourceMetadataFactoryInterface;
use ApiPlatform\Core\Metadata\Resource\ResourceMetadata;
use ApiPlatform\Core\Swagger\Serializer\DocumentationNormalizer;
+use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\PropertyInfo\Type;
use Symfony\Component\Serializer\NameConverter\NameConverterInterface;
use Symfony\Component\Serializer\Normalizer\AbstractNormalizer;
| [SchemaFactory->[buildSchema->[getAttribute,isWritable,create,normalize,getDescription,getMetadata,buildDefinitionName,getTypedOperationAttribute,isReadable,getDefinitions,buildPropertySchema,isRequired,getIri,getVersion],getMetadata->[getAttribute,create,getTypedOperationAttribute,getSerializerContext],buildDefinitionName->[getMetadata,getShortName],getSerializerContext->[getAttribute,getTypedOperationAttribute],buildPropertySchema->[isWritable,getAttribute,isNullable,isInitializable,getBuiltinType,getDescription,isCollection,getClassName,getType,isReadable,getDefinitions,getAttributes,getIri,getCollectionValueType,getVersion,isReadableLink]]] | Constructor for a single missing - node schema. Adds a format to the list of distinct values of a missing type. | We don't want this part of the code to depend of HttpFoundation. Use the name of the methods as strings directly. |
@@ -501,9 +501,11 @@ class InteractiveEnvironment(object):
is specified, evicts for all pipelines.
"""
if pipeline:
+ discarded = set()
for pcoll in self._computed_pcolls:
if pcoll.pipeline is pipeline:
- self._computed_pcolls.discard(pcoll)
+ discarded.add(pcoll)
+ self._computed_pcolls -= discarded
else:
self._computed_pcolls = set()
| [InteractiveEnvironment->[cleanup->[cleanup],is_terminated->[pipeline_result],evict_cache_manager->[cleanup],set_cache_manager->[cleanup],track_user_pipelines->[cleanup,get_cache_manager,watching]],new_env->[current_env]] | Evicts all computed PCollections for the given pipeline. If no pipeline is specified evicts. | Don't you need to call discard on `_computed_pcolls`? |
@@ -346,6 +346,11 @@ namespace System.Windows.Forms
}
}
+ /// <summary>
+ /// Gets or sets whether the container needs to be scaled when <see cref="DpiChangedEventHandler" />, irrespective whether the font was inherited or set explicitly.
+ /// </summary>
+ internal bool IsDpiChangeScalingRequired { get; set; }
+
/// <summary>
/// Indicates the form that the scrollable control is assigned to. This property is read-only.
/// </summary>
| [ContainerControl->[OnFrameWindowActivate->[FocusActiveControlInternal],SuspendAllLayout->[SuspendAllLayout],OnFontChanged->[OnFontChanged],LayoutScalingNeeded->[EnableRequiredScaling],ValidateInternal->[ValidateInternal],Validate->[Validate],ResetActiveAndFocusedControlsRecursive->[ResetActiveAndFocusedControlsRecursive],ProcessDialogChar->[ProcessDialogChar],OnLayout->[OnLayout],PerformAutoScale->[EnableRequiredScaling,PerformAutoScale],ActivateControl->[ActivateControl],ScaleContainer->[ResumeAllLayout,Size,SuspendAllLayout,OnFontChanged],OnLayoutResuming->[OnLayoutResuming],ResumeAllLayout->[ResumeAllLayout],OnMove->[OnMove],ValidateThroughAncestor->[SetActiveControl],OnChildLayoutResuming->[OnChildLayoutResuming],ProcessMnemonic->[CanProcessMnemonic,ProcessMnemonic],CanProcessMnemonic->[CanProcessMnemonic],OnResize->[OnResize],RescaleConstantsForDpi->[RescaleConstantsForDpi,OnFontChanged],AdjustFormScrollbars->[AdjustFormScrollbars],SetActiveControl->[FocusActiveControlInternal,ActivateControl,AssignActiveControlInternal,HasFocusableChild],OnParentChanged->[OnParentChanged],ValidateChildren->[ValidateChildren],OnCreateControl->[OnCreateControl,AxContainerFormCreated],ProcessCmdKey->[ProcessCmdKey],WmSetFocus->[FocusActiveControlInternal,ActivateControl],ProcessDialogKey->[ProcessDialogKey,ProcessArrowKey],EnableRequiredScaling->[EnableRequiredScaling],Size->[Size],Scale->[Scale],PerformNeededAutoScaleOnLayout->[PerformAutoScale],Dispose->[Dispose],WndProc->[WmSetFocus,WndProc]]] | XmlContainerControl for a sizeF object. Activate a control in the container. | Please open a follow up item to move this field to a bitfield, or do it now |
@@ -22,6 +22,17 @@ type policies struct {
Services []*corev1.Service `json:"services"`
}
+func (ds debugServer) getOSMConfigHandler() http.Handler {
+ return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ confJSON, err := ds.configurator.GetConfigMap()
+ if err != nil {
+ log.Error().Err(err)
+ return
+ }
+ _, _ = fmt.Fprint(w, string(confJSON))
+ })
+}
+
func (ds debugServer) getSMIPoliciesHandler() http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
| [getSMIPoliciesHandler->[ListSMIPolicies,Msg,Error,Marshal,HandlerFunc,Fprint,Err]] | getSMIPoliciesHandler returns a http. Handler that lists all smIPolicies. | I know there's more work to do to propagate changes to the ConfigMap to the controller Pod, but at this point should this endpoint always match `kubectl get` (after a polling cycle at least)? I'm not seeing the endpoint return the same config as `kubectl get`. |
@@ -135,10 +135,10 @@ async def prepare_unstripped_python_sources(
SourceRootRequest.for_file(representative_path_from_address(tgt.address)),
)
for tgt in request.targets
- if tgt.has_field(PythonSources) or tgt.has_field(ResourcesSources)
+ if not tgt.has_field(FilesSources)
)
source_root_paths = {source_root_obj.path for source_root_obj in source_root_objs}
- return UnstrippedPythonSources(init_injected.snapshot, tuple(sorted(source_root_paths)))
+ return UnstrippedPythonSources(sources.snapshot, tuple(sorted(source_root_paths)))
def rules():
| [rules->[rules],prepare_unstripped_python_sources->[UnstrippedPythonSources],prepare_stripped_python_sources->[StrippedPythonSources]] | Prepare a UnstrippedPythonSources object for the given node. | @benjyw @stuhood this is a bug fix. PTAL, including the below tests. |
@@ -105,8 +105,6 @@ class ChatChannel < ApplicationRecord
def pusher_channels
if invite_only?
"presence-channel-#{id}"
- elsif open?
- "open-channel-#{id}"
else
chat_channel_memberships.pluck(:user_id).map { |id| "private-message-notifications-#{id}" }
end
| [ChatChannel->[adjusted_slug->[direct?],pusher_channels->[invite_only?,open?],user_obj->[last_opened_at]]] | Returns the key value for the missing channel node in the system. | does this mean that open channels become private channels? |
@@ -672,11 +672,12 @@ class TestEditThemeForm(TestCase):
- On approving, it would see 'footer.png' !== 'leg.png'
- It run move_stored_file('footer.png', 'leg.png').
- But footer.png does not exist. BAM BUG.
+
+ Footer has been removed in issue # 5379
"""
make_checksum_mock.return_value = 'comechecksome'
self.theme.header = 'Legacy-header3H.png'
- self.theme.footer = 'Legacy-footer3H-Copy.jpg'
self.theme.save()
data = self.get_dict(header_hash='arthro')
| [TestCompatForm->[test_form_choices->[_test_form_choices_expect_all_versions],test_static_theme->[_test_form_choices_expect_all_versions],test_form_choices_mozilla_signed_legacy->[_test_form_choices_expect_all_versions],test_form_choices_no_compat->[_test_form_choices_expect_all_versions],test_form_choices_language_pack->[_test_form_choices_expect_all_versions]],TestEditThemeForm->[test_reupload_no_footer->[get_dict],test_reupload_legacy_header_only->[get_dict],test_success_twice->[save_success],setUp->[populate],test_reupload_duplicate->[get_dict],save_success->[get_dict],test_reupload->[get_dict],test_localize_name_description->[get_dict],test_initial->[get_dict],test_success->[save_success]],TestThemeForm->[test_slug_unique->[post],test_img_attrs->[get_img_urls,post],test_slug_length->[post],test_header_hash_required->[post],test_name_required->[post],test_slug_required->[post],test_license_required->[post],test_footer_hash_optional->[post],test_description_optional->[post],test_textcolor_optional->[post],test_dupe_persona->[post],test_accentcolor_invalid->[post],test_description_length->[post],test_categories_required->[post],test_name_length->[post],test_textcolor_invalid->[post],test_accentcolor_optional->[post],post->[get_dict],test_success->[get_img_urls,post,get_dict]]] | This test tests that reupload a legacy theme with header only. | Let's add a link to the issue if possible. |
@@ -40,9 +40,11 @@ class CryptographyClient(AsyncKeyVaultClientBase):
if isinstance(key, Key):
self._key = key
self._key_id = parse_vault_id(key.id)
+ self._allowed_ops = frozenset(self._key.key_material.key_ops)
elif isinstance(key, str):
self._key = None
self._key_id = parse_vault_id(key)
+ self._allowed_ops = None # type: Optional[FrozenSet]
self._get_key_forbidden = None # type: Optional[bool]
else:
raise ValueError("'key' must be a Key instance or a key ID string including a version")
| [CryptographyClient->[get_key->[get_key],decrypt->[decrypt],verify->[verify],sign->[sign],encrypt->[encrypt]]] | Initialize a CryptographyClient with a key or key ID. | Could an empty `frozenset` be sensibly interpreted the same as this case? (is there a way to spare downstream code from having to condition on whether the value is `None` or not) |
@@ -34,6 +34,7 @@ public class AkkaActorInstrumentationModule extends InstrumentationModule {
map.put(Runnable.class.getName(), State.class.getName());
map.put(Callable.class.getName(), State.class.getName());
map.put(AkkaForkJoinTaskInstrumentation.TASK_CLASS_NAME, State.class.getName());
+ map.put("akka.dispatch.Envelope", State.class.getName());
return Collections.unmodifiableMap(map);
}
| [AkkaActorInstrumentationModule->[contextStore->[put,getName,unmodifiableMap],typeInstrumentations->[asList,AkkaForkJoinPoolInstrumentation,AkkaForkJoinTaskInstrumentation]]] | This method is overridden to provide a map of the classes and names of the classes that are. | Why not "Envelope.class.getName()" ? AFAIK the class is available for reference at this point. Not that it changes a lot ;) |
@@ -662,8 +662,8 @@ namespace System.PrivateUri.Tests
[MemberData(nameof(Iri_ExpandingContents_AllowedSize))]
public static void Iri_ExpandingContents_DoesNotThrowIfSizeAllowed(string input)
{
- Uri itemUri = new Uri(input);
- Assert.True(Uri.TryCreate(input, UriKind.Absolute, out Uri itemUri2));
+ _ = new Uri(input);
+ Assert.True(Uri.TryCreate(input, UriKind.Absolute, out Uri _));
}
}
}
| [IriTest->[Iri_ValidateVeryLongInputString_EscapeDataString->[GetUnicodeString],Iri_ValidateVeryLongInputString_Ctor->[GetUnicodeString],Iri_ValidateVeryLongInputString_EscapeUriString->[GetUnicodeString]]] | Checks if the given string is a . | For all of these `_ = new Uri(input);`, do we even need the discard? Can't they just be `new Uri(input);`? |
@@ -67,8 +67,12 @@ public class NettyTransport implements Transport {
this.configuration = configuration;
// Need to initialize these in constructor since they require configuration
- masterGroup = buildEventLoop(1, new DefaultThreadFactory(threadNamePrefix + "-ServerMaster"));
- ioGroup = buildEventLoop(configuration.ioThreads(), new DefaultThreadFactory(threadNamePrefix + "-ServerIO"));
+ masterGroup = serverEventLoop(1, new DefaultThreadFactory(threadNamePrefix + "-ServerMaster"));
+ if (shouldShutdownIOGroup = cacheManager == null) {
+ ioGroup = serverEventLoop(configuration.ioThreads(), new DefaultThreadFactory(threadNamePrefix + "-ServerIO"));
+ } else {
+ ioGroup = cacheManager.getGlobalComponentRegistry().getComponent(EventLoopGroup.class);
+ }
serverChannels = new DefaultChannelGroup(threadNamePrefix + "-Channels", ImmediateEventExecutor.INSTANCE);
acceptedChannels = new DefaultChannelGroup(threadNamePrefix + "-Accepted", ImmediateEventExecutor.INSTANCE);
| [NettyTransport->[getTotalBytesRead->[getTotalBytesRead],getNumberOfLocalConnections->[getNumberOfLocalConnections],getPort->[getPort],getTotalBytesWritten->[getTotalBytesWritten],getHostName->[getHostName],getNumberOfGlobalConnections->[getNumberOfGlobalConnections]]] | Creates a new NettyTransport component. | Please move the assignment to its own line, have you been reading lots of JDK code lately? :) |
@@ -197,4 +197,7 @@ public class Author {
}
+ @XNode("@class")
+ Class<?> klass;
+
}
| [Author->[setField3->[fail],setField1->[fail],setField2->[fail]]] | Empirical cases where the node is a list of nodes. | What is the usage in the Author class? Is it only for testing purpose? |
@@ -423,13 +423,11 @@ nameof(offset),
if (binaryForm.Length - offset < SecurityIdentifier.MinBinaryLength)
{
- throw new ArgumentOutOfRangeException(
-nameof(binaryForm),
- SR.ArgumentOutOfRange_ArrayTooSmall);
+ throw new ArgumentOutOfRangeException(nameof(binaryForm), SR.ArgumentOutOfRange_ArrayTooSmall);
}
- IdentifierAuthority Authority;
- int[] SubAuthorities;
+ IdentifierAuthority authority;
+ Span<int> subAuthorities = stackalloc int[MaxSubAuthorities];
//
// Extract the elements of a SID
| [SecurityIdentifier->[IsValidTargetType->[IsValidTargetTypeStatic],GetHashCode->[GetHashCode],CreateFromBinaryForm->[CreateFromParts],ToString->[ToString],IsEqualDomainSid->[IsEqualDomainSid],CreateFromParts,CreateFromBinaryForm]] | Creates a new sub - authority from the given binary form. Get the list of subauthorities in the binary form. | Does this need to be defined up here, or can it instead be moved down to where it's assigned about 30 lines later? |
@@ -1809,7 +1809,7 @@ void Temperature::isr() {
for (uint8_t e = 0; e < COUNT(temp_dir); e++) {
const int tdir = temp_dir[e], rawtemp = current_temperature_raw[e] * tdir;
- if (rawtemp > maxttemp_raw[e] * tdir) max_temp_error(e);
+ if (rawtemp > maxttemp_raw[e] * tdir && target_temperature[e] > 0.0f) max_temp_error(e);
if (rawtemp < minttemp_raw[e] * tdir && !is_preheating(e) && target_temperature[e] > 0.0f) {
#ifdef MAX_CONSECUTIVE_LOW_TEMPERATURE_ERROR_ALLOWED
if (++consecutive_low_temperature_error[e] >= MAX_CONSECUTIVE_LOW_TEMPERATURE_ERROR_ALLOWED)
| [No CFG could be retrieved] | finds the best match for the given temperature values - - - - - - - - - - - - - - - - - -. | Should I check for `!is_preheating(e)` like MINTEMP below? It didn't seem safe to add. |
@@ -232,10 +232,16 @@ func (d *Distributor) queryIngesterStream(ctx context.Context, userID string, re
return nil, validation.LimitError(fmt.Sprintf(errMaxChunksPerQueryLimit, util.LabelMatchersToString(matchers), chunksLimit))
}
}
+
for _, series := range resp.Chunkseries {
if limitErr := queryLimiter.AddSeries(series.Labels); limitErr != nil {
return nil, limitErr
}
+ for _, chunks := range series.Chunks {
+ if chunkBytesLimitErr := queryLimiter.AddChunkBytes(chunks.Size()); chunkBytesLimitErr != nil {
+ return nil, chunkBytesLimitErr
+ }
+ }
}
for _, series := range resp.Timeseries {
if limitErr := queryLimiter.AddSeries(series.Labels); limitErr != nil {
| [queryIngesterStream->[QueryStream],queryIngesters->[Query]] | queryIngesterStream sends a stream of samples from multiple ingesters. Parse any errors in the response This function merge the existing and series samples into the query stream response. | Do we want to divide the size here by the replication factor to handle replicated series on the ingester? |
@@ -365,12 +365,13 @@ public abstract class HoodieTable<T extends HoodieRecordPayload, I, K, O> implem
/**
* Run Compaction on the table. Compaction arranges the data so that it is optimized for data access.
*
- * @param context HoodieEngineContext
+ * @param context HoodieEngineContext
* @param compactionInstantTime Instant Time
+ * @param writeClient Write client
*/
public abstract HoodieWriteMetadata<O> compact(HoodieEngineContext context,
- String compactionInstantTime);
-
+ String compactionInstantTime,
+ AbstractHoodieWriteClient writeClient);
/**
* Schedule clustering for the instant time.
| [HoodieTable->[getSliceView->[getFileSystemView],deleteInvalidFilesByPartitions->[delete],getRollbackTimeline->[getRollbackTimeline],getBaseFileOnlyView->[getFileSystemView],getHoodieView->[getFileSystemView],validateSchema->[getMetaClient],validateUpsertSchema->[validateSchema],validateInsertSchema->[validateSchema],getLogFileFormat->[getLogFileFormat],getActiveTimeline->[getActiveTimeline],reconcileAgainstMarkers->[getInvalidDataPaths,deleteInvalidFilesByPartitions],requireSortedRecords->[getBaseFileFormat],getHadoopConf->[getHadoopConf],getLogDataBlockFormat->[getBaseFileFormat],getBaseFileFormat->[getBaseFileFormat]]] | Compacts the write metadata for a given node. | Should we avoid having WriteClient inside HoodieTable? this looks like a nested dependency. |
@@ -143,4 +143,10 @@ public class ParameterizedQueryTemplateFactoryBean implements FactoryBean<QueryT
{
return false;
}
+
+ private String buildNotDefinedInParamErrorMessage(String name)
+ {
+ return "Parameter with name " + name + ", used in the query text, does not match any defined query parameter name.";
+ }
+
}
| [ParameterizedQueryTemplateFactoryBean->[getObject->[remove,QueryTemplate,getName,parse,IllegalStateException,buildUnresolvedParamErrorMsg,add,findOverriddenParam,getSqlText,getType,overrideParam,isEmpty,getParams],buildUnresolvedParamErrorMsg->[append,insert,toString,StringBuilder,length],findOverriddenParam->[evaluate->[getName,equals],find,Predicate],overrideParam->[getValue,DefaultOutputQueryParam,DefaultInOutQueryParam,getName,getIndex,getType,DefaultInputQueryParam]]] | Returns true if the node is a singleton node. | Use String format and change the string to be like "Parameter with name 'xxx', used ..." |
@@ -130,6 +130,17 @@ static unsigned int psk_server_cb(SSL *ssl, const char *identity,
if (s_debug)
BIO_printf(bio_s_out, "psk_server_cb\n");
+
+ if (SSL_version(ssl) >= TLS1_3_VERSION) {
+ /*
+ * This callback is designed for use in TLSv1.2. It is possible to use
+ * a single callback for all protocol versions - but it is preferred to
+ * use a dedicated callback for TLSv1.3. For TLSv1.3 we have
+ * psk_find_session_cb.
+ */
+ return 0;
+ }
+
if (identity == NULL) {
BIO_printf(bio_err, "Error: client did not send PSK identity\n");
goto out_err;
| [No CFG could be retrieved] | The main entry point for the server. find the first N bytes of the PSK key and put it into the buffer of callback. | I guess a bare `return 0;` does make sense here, rather than `goto out_err;` that will print some diagnostics that are unwarranted in this case. The existing usage of that label is quite inconsistent, though, and might merit a re-think (in a separate PR). |
@@ -82,6 +82,9 @@ def get_monitor_group(subparser):
monitor_group.add_argument(
'--monitor', action='store_true', dest='use_monitor', default=False,
help="interact with a montor server during builds.")
+ monitor_group.add_argument(
+ '--monitor-save-local', action='store_true', dest='monitor_save_local',
+ default=False, help="save monitor results to .spack instead of server.")
monitor_group.add_argument(
'--monitor-no-auth', action='store_true', dest='monitor_disable_auth',
default=False, help="the monitoring server does not require auth.")
| [write_json->[write_file],read_json->[read_file],SpackMonitorClient->[prepare_request->[reset],get_build_id->[do_request],fail_task->[update_build],send_analyze_metadata->[do_request,get_build_id],authenticate_request->[do_request,set_basic_auth],issue_request->[prepare_request,issue_request],service_info->[do_request],do_request->[prepare_request,issue_request],upload_specfile->[do_request],set_basic_auth->[set_header],update_build->[do_request,get_build_id],send_phase->[do_request,get_build_id],new_configuration->[do_request]]] | Retrieve the monitor group for the argument parser. | Instead of adding an option to save locally, wouldn't it make more sense to: 1. Save locally by default. 2. Don't have a default `127.0.0.1` monitor host (just make it `None`) 3. Only upload if `--monitor-host` is provided You could also fall back to saving locally if upload fails. I think this would simplify the options. |
@@ -149,7 +149,7 @@ public class ExtensionAnnotationProcessor extends AbstractProcessor {
return;
}
final URI uri = tempResource.toUri();
- tempResource.delete();
+// tempResource.delete();
Path path;
try {
path = Paths.get(uri).getParent();
| [ExtensionAnnotationProcessor->[processConfigGroup->[recordConfigJavadoc],processTemplate->[recordConfigJavadoc],getRelativeBinaryName->[getRelativeBinaryName]]] | Finishes the processing of the BSC and JDP files. Method that is called when a file or directory is visited. care about the neccesary properties. | This looks fine, it's an empty file anyway and should do no harm I would think if it stays around. |
@@ -57,7 +57,7 @@ class LanguageModelingReader(DatasetReader):
tokenized_text = self._tokenizer.tokenize(all_text)
num_tokens = self._tokens_per_instance
tokenized_strings = []
- for index in range(0, len(tokenized_text) - num_tokens, num_tokens):
+ for index in tqdm.tqdm(range(0, len(tokenized_text) - num_tokens, num_tokens)):
tokenized_strings.append(tokenized_text[index:index + num_tokens])
else:
tokenized_strings = [self._tokenizer.tokenize(s) for s in instance_strings]
| [LanguageModelingReader->[from_params->[LanguageModelingReader,from_params]]] | Reads a file and returns a list of Instance objects. Missing Dataset object. | Can you put a logging statement above all calls to tqdm like this, saying what's being iterated over? |
@@ -91,6 +91,14 @@ class BoundedSource(object):
positions passed to the method ``get_range_tracker()`` are ``None``
(2) Method read() will be invoked with the ``RangeTracker`` obtained in the
previous step.
+
+ **Mutability**
+
+ A ``BoundedSource`` object should be fully mutated before being submitted
+ for reading. A ``BoundedSource`` object should not be mutated while
+ its methods (for example, ``read()``) are being invoked by a runner. Runner
+ implementations may invoke methods of ``BoundedSource`` objects through
+ multi-threaded and/or re-entrant execution modes.
"""
def estimate_size(self):
| [_finalize_write->[close,finalize_write,open_writer],Read->[_infer_output_coder->[default_output_coder]],_WriteBundleDoFn->[finish_bundle->[close],process->[write,open_writer]],_write_keyed_bundle->[close,write,open_writer],WriteImpl->[apply->[initialize_write]]] | Estimates the size of the source in bytes. | "fully mutated" sounds odd. I would simply cut this first sentence. |
@@ -69,8 +69,8 @@ module PaginationHelper
when 'repo_name' then to_include = [:group]
when 'section' then to_include = [:group]
when 'revision_timestamp' then to_include = [:current_submission_used]
- when 'marking_state' then to_include = [{:current_submission_used => :results}]
- when 'total_mark' then to_include = [{:current_submission_used => :results}]
+ when 'marking_state' then to_include = [{current_submission_used: :results}]
+ when 'total_mark' then to_include = [{current_submission_used: :results}]
when 'grace_credits_used' then to_include = [:grace_period_deductions]
end
items = hash[:filters][filter][:proc].call(object_hash, to_include)
| [get_filters->[each],handle_paginate_event->[size,include?,clone,raise,blank?,get_filtered_items],get_filtered_items->[call,reverse!,blank?,sort],require] | get_filtered_items - returns an array of items filtered by the given filter sort_. | Indent `when` as deep as `case`.<br>Line is too long. [82/80]<br>Space inside { missing.<br>Space inside } missing. |
@@ -20,12 +20,12 @@ const (
func NewProcessor() pr.Processor {
schema := pr.CreateSchema(errorSchema, processorName)
return &processor{
- &Payload{},
+ &payload{},
schema}
}
type processor struct {
- payload *Payload
+ payload pr.Payload
schema *jsonschema.Schema
}
| [Validate->[Validate],Transform->[Transform],AddProcessor,CreateSchema] | Transform is part of the beat. Processor interface. | Why did you change this? I think it's good to depend on the local payload. We should change it to the same as we have in the `transaction` processor. |
@@ -207,7 +207,7 @@ class Task(Model):
"""
self.state = Task.FAILED
self.finished_at = timezone.now()
- self.result = exception_to_dict(exc, einfo.traceback)
+ self.error = exception_to_dict(exc, einfo.traceback)
self.save()
| [ReservedResource->[ForeignKey,OneToOneField,TextField],TaskTag->[ForeignKey,TextField],WorkerManager->[get_unreserved_worker->[DoesNotExist,annotate,filter,Count]],TaskLock->[DateTimeField,TextField],Worker->[save_heartbeat->[save],DateTimeField,WorkerManager,TextField],Task->[set_failed->[save,exception_to_dict,now],set_running->[warning,save,now,_],set_completed->[warning,save,now,_],JSONField,DateTimeField,ForeignKey,UUIDField,TextField],getLogger] | Sets this task to the failed state and saves it. | The docstring of this function needs updating. |
@@ -66,12 +66,12 @@ def start_juggler(fn=None, dbc=None, layout=None):
extra_args = ""
if fn is not None:
- extra_args += f"-d {fn}"
+ extra_args += f" -d {fn}"
if layout is not None:
- extra_args += f"-l {layout}"
+ extra_args += f" -l {layout}"
- subprocess.call(f'plotjuggler --plugin_folders {INSTALL_DIR} {extra_args}',
- shell=True, env=env, cwd=juggle_dir)
+ cmd = f'plotjuggler --plugin_folders {INSTALL_DIR}{extra_args}'
+ subprocess.call(cmd, shell=True, env=env, cwd=juggle_dir)
def juggle_route(route_name, segment_number, segment_count, qlog, can, layout):
| [juggle_route->[start_juggler],install,juggle_route,start_juggler] | Start a juggler with the given parameters. Load all segments of objects from logs and return them as a log file. | why remove the space between INSTALL_DIR and extra_args? |
@@ -162,8 +162,8 @@ export class AmpAd3PImpl extends AMP.BaseElement {
/** @private @const {function()|null} */
this.renderStartResolve_ = null;
- /** @private @const {!Promise} */
- this.renderStartPromise_ = new Promise(resolve => {
+ /** @const {!Promise} */
+ this.renderStartPromise = new Promise(resolve => {
this.renderStartResolve_ = resolve;
});
}
| [No CFG could be retrieved] | Provides access to the properties of an amp - ad. add a preconnect url to the element. | This should not be a public var. |
@@ -9,7 +9,10 @@ public class VertxTemplate {
public BeanContainerListener configureVertx(VertxConfiguration config) {
return container -> {
VertxProducer instance = container.instance(VertxProducer.class);
- instance.configure(config);
+ //require a null check, if nothing is using it then this can be auto removed by ArC
+ if(instance != null) {
+ instance.configure(config);
+ }
};
}
}
| [VertxTemplate->[configureVertx->[configure,instance]]] | Configure the vertx producer. | I think in this particular case we should rather modify `org.jboss.shamrock.vertx.VertxProcessor.registerBean()` to use unremovable additional bean, just like this: ` new AdditionalBeanBuildItem(false, VertxProducer.class).` |
@@ -283,6 +283,12 @@ export class ViewportBindingInabox {
/** @override */
getRootClientRectAsync() {
+ if (this.canInspectTopWindow_()) {
+ return new Promise(resolve => {
+ resolve(layoutRectFromDomRect(
+ this.win.frameElement./*OK*/getBoundingClientRect()));
+ });
+ }
if (!this.requestPositionPromise_) {
this.requestPositionPromise_ = new Promise(resolve => {
this.iframeClient_.requestOnce(
| [No CFG could be retrieved] | Updates the viewport box rect. Private method for handling the fixed container leave overlay mode. | This needs to be gated by the experiment too, right? |
@@ -145,6 +145,9 @@ public class ArtifactArchiver extends Recorder implements SimpleBuildStep {
if (caseSensitive == null) {
caseSensitive = true;
}
+ if (flattenDirectories == null) {
+ flattenDirectories = false;
+ }
return this;
}
| [ArtifactArchiver->[perform->[perform,listenerWarnOrError],Migrator->[onLoaded->[setFingerprint]],ListFiles->[invoke->[setCaseSensitive]]]] | readResolve - This method is called by the read method of the class. | Could just be a `boolean` then. This is only needed if the default isn't `false`. |
@@ -738,6 +738,8 @@ func RegisterRoutes(m *macaron.Macaron) {
m.Post("/labels", reqRepoIssuesOrPullsWriter, repo.UpdateIssueLabel)
m.Post("/milestone", reqRepoIssuesOrPullsWriter, repo.UpdateIssueMilestone)
m.Post("/assignee", reqRepoIssuesOrPullsWriter, repo.UpdateIssueAssignee)
+ m.Post("/request_review", reqRepoIssuesOrPullsWriter, repo.UpdatePullReviewRequest)
+ m.Post("/re_request_review", reqRepoIssuesOrPullsReader, repo.UpdatePullReviewRequest)
m.Post("/status", reqRepoIssuesOrPullsWriter, repo.UpdateIssueStatus)
}, context.RepoMustNotBeArchived())
m.Group("/comments/:id", func() {
| [Status,StatusText,NewWithLogger,CORS,Redirect,RequireRepoReaderOr,Post,New,Locale,ServerError,Any,Middleware,RequireRepoWriter,ColoredTime,Register,ColoredStatus,RepoAssignment,Csrfer,Cacher,RepoRefByType,Contexter,UnitGlobalDisabled,ColoredMethod,GetLevel,GetCommitsCount,RegisterRoutes,Dir,Now,RequireRepoReader,RepoRef,SetURLPrefix,MultipartForm,Static,Captchaer,Route,Since,Logger,NewBuffer,I18n,Next,Head,Recovery,Log,Custom,InitMailRender,SetAutoHead,OrgAssignment,Toolboxer,Fatal,Combo,RequestURI,JSONRenderer,JSRenderer,GetBranchCommit,RequireRepoWriterOr,NotFound,AddBindingRules,Execute,ServeFileContent,StaticHandler,Get,RepoIDAssignment,Use,String,Parse,Group,NewCollector,RemoteAddr,Mailer,HTML,Error,Seconds,NewLoggerAsWriter,SendLog,Join,Toggle,RequireRepoAdmin,Sessioner,MustRegister,RepoMustNotBeArchived,GitHookService,HTMLRenderer,UnitTypes,GetLogger] | post - post routes for all components of the application m. Post is a group of milestones. | It seems that this function doesn't allow the PR creator to request reviews unless they have special permissions. |
@@ -198,7 +198,7 @@ public class HypervisorHostHelper {
if (UNTAGGED_VLAN_NAME.equalsIgnoreCase(vlanId)) {
return "cloud.public.untagged";
} else {
- return "cloud.public." + vlanId;
+ return "cloud.public." + vlanId + ".";
}
}
| [HypervisorHostHelper->[createVSSecurityPolicy->[getDefaultSecurityDetails],prepareNetwork->[createVSSecurityPolicy,prepareNetwork,createPortGroup,isSpecMatch,updatePortProfile,createPortProfile,composeCloudNetworkName],createNvpPortGroup->[createPortGroup],createOvfFile->[createWorkerVM],updatePortProfile->[getValidatedVsmCredentials,updatePortProfile],createDVSSecurityPolicy->[getDefaultSecurityDetails],importVmFromOVF->[removeOVFNetwork,resolveHostNameInUrl],createPortProfile->[getValidatedVsmCredentials],readOVF->[removeOVFNetwork]]] | Composes the name of the public network with the specified prefix. | @Pearl1594 would that be wrong or cause compatibility issues post upgrade? Generally port group names don't end in period (`.`) cc @PaulAngus @andrijapanicsb @borisstoyanov @vladimirpetrov? |
@@ -25,6 +25,11 @@ level = "short"
def setup_parser(subparser):
+ subparser.add_argument(
+ '-n', '--name',
+ action='store', dest='module_set_name', default='default',
+ help="Named module set to use from modules configuration."
+ )
sp = subparser.add_subparsers(metavar='SUBCOMMAND', dest='subparser_name')
refresh_parser = sp.add_parser('refresh', help='regenerate module files')
| [find->[one_spec_or_raise],one_spec_or_raise->[MultipleSpecsMatch,NoSpecMatches]] | Setup a subparser to manage a specific module. | can this support a comma-separated list of names? |
@@ -8,7 +8,7 @@ def make_can_msg(addr, dat, alt):
def create_lkas11(packer, car_fingerprint, apply_steer, steer_req, cnt, enabled, lkas11, hud_alert, keep_stock=False):
values = {
- "CF_Lkas_Icon": 3 if enabled else 0,
+ "CF_Lkas_Icon": 2 if car_fingerprint in FEATURES["icon_basic"] else 3 if enabled else 0,
"CF_Lkas_LdwsSysState": 3 if steer_req else 1,
"CF_Lkas_SysWarning": hud_alert,
"CF_Lkas_LdwsLHWarning": lkas11["CF_Lkas_LdwsLHWarning"] if keep_stock else 0,
| [create_1156->[make_can_msg],create_1191->[make_can_msg],create_clu11->[make_can_msg],create_lkas12->[make_can_msg],create_lkas11->[make_can_msg]] | Create a new Lkas11 object. CF_Lkas_Chksum CF_Lkas_Fcw. | hard to read :) can we move the if/else outside the dict? |
@@ -203,7 +203,7 @@ namespace Content.Server.GameTicking
if (PlayerManager.PlayerCount == 0)
_roundStartCountdownHasNotStartedYetDueToNoPlayers = true;
else
- _roundStartTimeUtc = DateTime.UtcNow + LobbyDuration;
+ _roundStartTimeTicks = IoCManager.Resolve<IGameTiming>().RealTime.Ticks + LobbyDuration.Ticks;
_sendStatusToAll();
| [GameTicker->[ToggleDisallowLateJoin->[UpdateLateJoinStatus],SetStartPreset->[SetStartPreset,TryGetPreset,StartRound],SpawnPlayer->[SpawnPlayer,ApplyCharacterProfile,MakeObserve],Initialize->[Initialize],PlayerStatusChanged->[PlayerStatusChanged],TogglePause->[PauseStart],StartRound->[RestartRound,ReqWindowAttentionAll]]] | Restarts a round if it is not already running. | Again, you have an `IGameTiming` dependency so use that instead of resolving every time. And don't use ticks please. |
@@ -0,0 +1,12 @@
+namespace Pulumi.Automation
+{
+ public enum UpdateKind
+ {
+ Update,
+ Preview,
+ Refresh,
+ Rename,
+ Destroy,
+ Import,
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | The name feels odd... do we use it in other language SDKs too? |
@@ -74,7 +74,10 @@ public class MuleEventToHttpRequest
for (String outboundProperty : event.getMessage().getOutboundPropertyNames())
{
- builder.addHeader(outboundProperty, event.getMessage().getOutboundProperty(outboundProperty).toString());
+ if (!builder.getHeaders().containsKey(outboundProperty))
+ {
+ builder.addHeader(outboundProperty, event.getMessage().getOutboundProperty(outboundProperty).toString());
+ }
}
builder.setEntity(createRequestEntity(builder, event, resolvedMethod));
| [MuleEventToHttpRequest->[create->[getHeaders,createRequestEntity,getRequestBuilder,getQueryParams,HttpRequestBuilder,addHeader,setMethod,setHeaders,getOutboundPropertyNames,toString,setEntity,setQueryParams,setUri],createRequestEntity->[equals,evaluate,isEmptyBody,createRequestEntityFromPayload,getPayload,isEmpty,getSource,setPayload,EmptyHttpEntity],doStreaming->[equalsIgnoreCase,debug,get,getPayload,removeHeader,isDebugEnabled,resolveStreamingType],resolveSendBodyMode->[valueOf,resolveStringValue],isEmptyBody->[resolveSendBodyMode,getPayload,contains,isEmpty],createRequestEntityFromPayload->[ByteArrayHttpEntity,getMessage,getEncoding,equals,doStreaming,getPayloadAsBytes,get,addHeader,InputStreamHttpEntity,MessagingException,getPayload,isEmpty,encodeString,getBytes,ByteArrayInputStream,createMultiPart],resolveStreamingType->[valueOf,resolveStringValue],createMultiPart->[newHashMap,createFrom,MultipartHttpEntity,getOutboundAttachmentNames,getOutboundAttachment,put],getLogger]] | Create a HttpRequestBuilder with the given event and method and URI. | Wouldn't this make the 3.6.x branch different from 3.x? Outbound properties take precedence over the request builder AFAIK. Why is this needed? |
@@ -398,9 +398,14 @@ def dump_packages(spec, path):
source = spack.store.layout.build_packages_path(node)
source_repo_root = os.path.join(source, node.namespace)
- # There's no provenance installed for the source package. Skip it.
- # User can always get something current from the builtin repo.
- if not os.path.isdir(source_repo_root):
+ # If there's no provenance installed for the package, skip it.
+ # If it's external, skip it because it either:
+ # 1) it wasn't built with Spack, so it has no Spack metadata
+ # 2) it was built by another Spack instance, and we do not
+ # (currently) use Spack metadata to associate repos with externals
+ # built be other Spack instances.
+ # Spack can always get something current from the builtin repo.
+ if node.external or not os.path.isdir(source_repo_root):
continue
# Create a source repo and get the pkg directory out of it.
| [PackageInstaller->[_check_deps_status->[_check_db,package_id],__repr__->[__repr__],_init_queue->[_check_deps_status,package_id,_add_bootstrap_compilers],_ensure_install_ready->[package_id],install->[_init_queue,_pop_task,package_id,_cleanup_all_tasks,_print_installed_pkg,_handle_external_and_upstream,_ensure_locked,_update_installed,_prepare_for_install,_update_failed,_check_last_phase,_install_task,_requeue_task,_cleanup_task],__init__->[package_id],_ensure_locked->[_cleanup_all_tasks,package_id],_prepare_for_install->[_update_explicit_entry_in_db,_check_db],_update_failed->[_update_failed,_remove_task],_update_installed->[_push_task],_push_task->[package_id],_install_task->[build_process->[package_id,_print_installed_pkg,_hms,_do_fake_install,log],install_msg,_install_from_cache,package_id],_requeue_task->[_push_task,install_msg],_cleanup_task->[package_id],_add_bootstrap_compilers->[_packages_needed_to_bootstrap_compiler,package_id]],BuildTask->[__repr__->[__repr__],__init__->[package_id]],log->[dump_packages],_try_install_from_binary_cache->[_process_binary_cache_tarball]] | Dump all packages from a given Spack spec and its dependencies into a build packages directory. Package name is not installed. | typo: be -> by Other than that LGTM - thanks! |
@@ -1,4 +1,7 @@
-<h2><%= @user.username %></h2>
+<div class='user-crawler'>
+ <img src='<%= get_absolute_image_url(@user.small_avatar_url) %>' alt='Image of <%= @user.username %>' title='<%= @user.username %>' />
+ <h2 class='username'><%= @user.username %></h2>
+</div>
<% unless @restrict_fields %>
<p><%= raw @user.user_profile.bio_processed %></p>
| [No CFG could be retrieved] | Displays a list of the user s nacuary number. | The alt should be localized |
@@ -22,13 +22,10 @@ var DateDisplayDef = {};
/**
* @typedef {{
* children: (?PreactDef.Renderable|undefined),
- * datetime: (string|undefined),
+ * datetime: (?Date|number|undefined),
* displayIn: (string|undefined),
* locale: (string|undefined),
* render: (function(!JsonObject, (?PreactDef.Renderable|undefined)):PreactDef.Renderable),
- * offsetSeconds: (number|undefined),
- * timestampMs: (number|undefined),
- * timestampSeconds: (number|undefined),
* }}
*/
DateDisplayDef.Props;
| [No CFG could be retrieved] | Displays a single object. | Should we be supporting `string`, too? |
@@ -25,11 +25,12 @@ import {removeElement} from '../../../src/dom';
import {setStyle} from '../../../src/style';
import {userAssert} from '../../../src/log';
-import {CSS} from '../../../build/amp-delight-player-0.1.css';
-
/** @const */
const TAG = 'amp-delight-player';
+/** @private @const */
+const ANALYTICS_EVENT_TYPE_PREFIX = 'video-custom-';
+
/** @const @enum {string} */
const DelightEvent = {
READY: 'x-dl8-to-parent-ready',
| [No CFG could be retrieved] | Provides a function to create a new object with a specific name. Get the list of HTML elements that are defined in the DL8 header. | Can you add a TODO to export this from a lower level, like `src`? (No need to do for this PR, I'll take care of it) |
@@ -185,7 +185,12 @@ func EVMTranscodeJSONWithFormat(value gjson.Result, format string) ([]byte, erro
switch format {
case FormatBytes:
return EVMTranscodeBytes(value)
-
+ case FormatPreformattedHexArguments:
+ if !HasHexPrefix(value.Str) {
+ return nil, fmt.Errorf("%s input must be 0x-prefixed, got %s",
+ FormatPreformattedHexArguments, value.Str)
+ }
+ return hex.DecodeString(RemoveHexPrefix(value.Str))
case FormatUint256:
data, err := EVMTranscodeUint256(value)
if err != nil {
| [ForEach,Wrap,Add,PutUint64,Exp,Int,Cmp,New,Neg,Errorf,Bytes,Sub,Sign,Join,LeftPadBytes,SetInt64,Sprintf,NewFloat,BitLen,NewInt,Div,SetString,ParseFloat] | EVMTranscodeJSONWithFormat converts a JSON input to an EVM uint256 int EVMWordUint64 returns a uint64 or signed big. Int as an EVM. | This should have a test case. |
@@ -421,7 +421,7 @@ if ( ! class_exists( 'WPSEO_OpenGraph' ) ) {
array_push( $this->shown_images, $img );
- $this->og_tag( 'og:image', esc_url( $img ) );
+ $this->og_tag( $og_meta, esc_url( $img ) );
return true;
}
| [WPSEO_OpenGraph->[type->[og_tag],website_facebook->[og_tag],og_title->[og_tag],site_owner->[og_tag],locale->[og_tag],image_output->[og_tag],category->[og_tag],description->[og_tag],site_name->[og_tag],tags->[og_tag],url->[og_tag],article_author_facebook->[og_tag],publish_date->[og_tag],image->[image_output]]] | Image output for OpenGraph. | Simple mod to make this og tag definable. The new defined default is 'og:image:url'. |
@@ -115,6 +115,14 @@ def get_module_cmd_from_bash(bashopts=''):
return module_cmd
+def unload_module(mod):
+ """Takes a module name and unloads the module from the environment. It does
+ not check whether conflicts arise from the unloaded module"""
+ modulecmd = get_module_cmd()
+ exec(compile(modulecmd('unload', mod, output=str, error=str), '<string>',
+ 'exec'))
+
+
def load_module(mod):
"""Takes a module name and removes modules until it is possible to
load that module. It then loads the provided module. Depends on the
| [get_path_from_module->[get_argument_from_module_line,get_module_cmd],load_module->[get_module_cmd]] | Takes a module name removes modules until it is possible to load that module. It then loads. | Part of above PR with `unload_module` in `build_environment.py` |
@@ -316,12 +316,12 @@ func (a *InternalAPIEngine) consumeHeaders(resp *http.Response) error {
func (a *InternalAPIEngine) fixHeaders(arg APIArg, req *http.Request) {
if arg.NeedSession {
tok, csrf := a.sessionArgs(arg)
- if len(tok) > 0 {
+ if len(tok) > 0 && a.G().Env.GetTorMode().UseSession() {
req.Header.Add("X-Keybase-Session", tok)
} else {
G.Log.Warning("fixHeaders: need session, but session token empty")
}
- if len(csrf) > 0 {
+ if len(csrf) > 0 && a.G().Env.GetTorMode().UseCSRF() {
req.Header.Add("X-CSRF-Token", csrf)
} else {
G.Log.Warning("fixHeaders: need session, but session csrf empty")
| [GetHTML->[getCommon],Get->[getURL,PrepareGet,getCommon],PostResp->[getURL,PreparePost],postCommon->[DoRequest,PreparePost],fixHeaders->[sessionArgs],Post->[getURL,PreparePost,postCommon],GetDecode->[GetResp],GetResp->[getURL,PrepareGet],PostHTML->[postCommon],PostJSON->[getURL,PreparePost],GetText->[getCommon],PostDecode->[PostResp],getCommon->[DoRequest,PrepareGet],getCli] | fixHeaders adds session and csrf headers to the request. | Do we also want to strip out `User-Agent` and `X-Keybase-Client` headers? Should we just have a policy of "Tor mode = no headers"? |
@@ -112,9 +112,8 @@ public class ConsoleProxySecureServerFactoryImpl implements ConsoleProxyServerFa
SSLServerSocket srvSock = null;
SSLServerSocketFactory ssf = sslContext.getServerSocketFactory();
srvSock = (SSLServerSocket)ssf.createServerSocket(port);
- srvSock.setEnabledProtocols(SSLUtils.getRecommendedProtocols());
- srvSock.setEnabledCipherSuites(SSLUtils.getRecommendedCiphers());
-
+ srvSock.setEnabledProtocols(SSLUtils.getSupportedProtocols(srvSock.getEnabledProtocols()));
+ srvSock.setEnabledCipherSuites(SSLUtils.getSupportedProtocols(srvSock.getEnabledCipherSuites()));
s_logger.info("create SSL server socket on port: " + port);
return srvSock;
} catch (Exception ioe) {
| [ConsoleProxySecureServerFactoryImpl->[init->[init]]] | create a new server socket on the specified port. | Let's keep the configured list of cipher suites. Check and fix this. |
@@ -55,7 +55,9 @@ def per_instance(*args, **kwargs):
return equal_args(*instance_and_rest, **kwargs)
-def memoized(func=None, key_factory=equal_args, cache_factory=dict):
+def memoized(
+ func: Optional[F] = None, *, key_factory=equal_args, cache_factory=dict,
+) -> F:
"""Memoizes the results of a function call.
By default, exactly one result is memoized for each unique combination of function arguments.
| [testable_memoized_property->[setter->[put],memoized_method,forget],memoized_staticproperty->[memoized_staticmethod],memoized_method->[memoized],memoized_staticmethod->[memoized],per_instance->[equal_args,InstanceKey],memoized_classproperty->[memoized_classmethod],memoized->[clear->[clear]],memoized_classmethod->[memoized_method],memoized_property->[memoized_method,forget]] | A function that memoizes the results of a function call. A memoized decorator that caches the result of the function call. | I think this might be a breaking API change? It might be annoying to formulate this as a `deprecated_conditional()` if `key_factory` or `cache_factory` are specified as positional arguments, but we might be able to make some utility for that. |
@@ -228,7 +228,8 @@ pool_set_attr_hdlr(struct cmd_args_s *ap)
(const void * const*)&ap->value_str,
(const size_t *)&value_size, NULL);
if (rc != 0) {
- fprintf(stderr, "pool set attr failed: %d\n", rc);
+ fprintf(stderr, "failed to set attribute %s for pool "DF_UUIDF
+ ": %s\n", ap->attrname_str, ap->p_uuid, d_errdesc(rc));
D_GOTO(out_disconnect, rc);
}
| [No CFG could be retrieved] | Protected get - property hdlr get the n - ary pool object. | (style) line over 80 characters |
@@ -22,4 +22,17 @@ class Indexable_Error_Page_Presentation extends Indexable_Presentation {
return $this->robots_helper->after_generate( $robots );
}
+
+ /**
+ * @inheritDoc
+ */
+ public function generate_title() {
+ if ( $this->model->title ) {
+ return $this->model->title;
+ }
+
+ $title = $this->options_helper->get_title_default( 'title-404-wpseo' );
+
+ return $title;
+ }
}
| [Indexable_Error_Page_Presentation->[generate_robots->[get_base_values,after_generate]]] | Generate robots. txt. | You could return right away here. |
@@ -1,15 +1,15 @@
# frozen_string_literal: true
-class OrganizationDecorator < ApplicationDecorator
+module OrganizationDecorator
include PersonOrgDecoratorCommon
def db_detail_link(options = {})
name = options.delete(:name).presence || self.name
- h.link_to name, h.edit_db_organization_path(self), options
+ link_to name, edit_db_organization_path(self), options
end
def grid_description(staff)
- staff.decorate.role_name
+ ActiveDecorator::Decorator.instance.decorate(staff).role_name
end
def to_values
| [OrganizationDecorator->[to_values->[send,decode,link_to,present?,each_with_object],grid_description->[role_name],db_detail_link->[presence,name,edit_db_organization_path,link_to],include]] | Returns a link to the n - ary in the database. | Lint/UriEscapeUnescape: URI.decode method is obsolete and should not be used. Instead, use CGI.unescape, URI.decode_www_form or URI.decode_www_form_component depending on your specific use case. |
@@ -1336,6 +1336,12 @@ public class NotebookServer extends WebSocketServlet implements
}
}
notebookServer.broadcastNote(note);
+
+ try {
+ notebookServer.broadcastUpdateNotebookJobInfo(System.currentTimeMillis() - 5000);
+ } catch (IOException ioe) {
+ LOG.error("can not broadcast for job manager {}", ioe.getMessage());
+ }
}
/**
| [NotebookServer->[pushAngularObjectToRemoteRegistry->[broadcastExcept],broadcastInterpreterBindings->[broadcast],checkpointNotebook->[serializeMessage],onRemove->[broadcast,notebook],onLoad->[broadcast],updateParagraph->[permissionError,getOpenNoteId,broadcast],unicastNoteList->[generateNotebooksInfo,unicast],onOutputAppend->[broadcast],broadcast->[serializeMessage],sendNote->[permissionError,serializeMessage,addConnectionToNote],broadcastExcept->[serializeMessage],insertParagraph->[permissionError,getOpenNoteId,broadcastNote,insertParagraph],saveInterpreterBindings->[notebook],generateNotebooksInfo->[notebook],clearParagraphOutput->[permissionError,getOpenNoteId,clearParagraphOutput,broadcastNote],cancelParagraph->[permissionError,getOpenNoteId],onStatusChange->[broadcast],ParagraphListenerImpl->[onOutputAppend->[broadcast],onProgressUpdate->[broadcast],onOutputUpdate->[broadcast],afterStatusChange->[broadcastNote]],removeNote->[permissionError,removeNote,broadcastNoteList],broadcastNote->[broadcast],unicastUpdateNotebookJobInfo->[serializeMessage],removeAngularFromRemoteRegistry->[broadcastExcept],onMessage->[notebook],onUpdate->[broadcast,notebook],createNote->[broadcastNoteList,createNote,serializeMessage,addConnectionToNote],sendAllConfigurations->[serializeMessage],unicastNotebookJobInfo->[serializeMessage],broadcastNoteList->[generateNotebooksInfo,broadcastAll],updateNote->[permissionError,broadcastNote,broadcastNoteList],getNoteByRevision->[getNoteByRevision,serializeMessage],broadcastToNoteBindedInterpreter->[notebook],onOutputUpdated->[broadcast],removeConnectionFromAllNote->[removeConnectionFromNote],getParagraphJobListener->[ParagraphListenerImpl],sendHomeNote->[permissionError,serializeMessage,addConnectionToNote,removeConnectionFromAllNote],angularObjectUpdated->[broadcastExcept],removeParagraph->[permissionError,getOpenNoteId,broadcastNote,removeParagraph],sendAllAngularObjects->[serializeMessage],broadcastReloadedNoteList->[generateNotebooksInfo,broadcastAll],getInterpreterBindings->[getInterpreterBindings,serializeMessage,notebook],moveParagraph->[permissionError,getOpenNoteId,broadcastNote,moveParagraph],permissionError->[serializeMessage],runParagraph->[permissionError,getOpenNoteId,broadcast],unicast->[serializeMessage],completion->[getOpenNoteId,serializeMessage,completion],importNote->[broadcastNoteList,importNote,broadcastNote],pushAngularObjectToLocalRepo->[broadcastExcept],removeAngularObjectFromLocalRepo->[broadcastExcept],broadcastAll->[serializeMessage],cloneNote->[broadcastNoteList,getOpenNoteId,serializeMessage,addConnectionToNote,cloneNote],listRevisionHistory->[listRevisionHistory,serializeMessage]]] | This method is called after status change. | LOG.error("can not broadcast for job manager {}", e) instead |
@@ -245,6 +245,9 @@ namespace Dynamo.Graph.Nodes.CustomNodes
}
}
+ /// <summary>
+ /// Represents input of Custom Node instance.
+ /// </summary>
[NodeName("Input")]
[NodeCategory(BuiltinNodeCategories.CORE_INPUT)]
[NodeDescription("SymbolNodeDescription",typeof(Properties.Resources))]
| [Output->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]],Function->[BuildAst->[BuildAst],SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],ResyncWithDefinition->[ValidateDefinition]],Symbol->[SerializeCore->[SerializeCore],DeserializeCore->[DeserializeCore],UpdateValueCore->[UpdateValueCore]]] | This is the base implementation of the IonNodeModel class. It is the base implementation Get or set the input symbol. | Incorrect. You have to explain the usage of Symbol class. |
@@ -91,6 +91,7 @@ void AddItemsSetItem(Player* player, Item* item)
}
// spell casted only if fit form requirement, in other case will casted at form change
+ if (sScriptMgr->CanItemApplyEquipSpell(player, item))
player->ApplyEquipSpell(spellInfo, NULL, true);
eff->spells[y] = spellInfo;
break;
| [SetEnchantment->[GetOwner,SetState],DeleteFromDB->[DeleteFromDB],UpdatePlayedTime->[SetNotRefundable,time,SetState],BuildUpdate->[GetOwner],SetNotRefundable->[DeleteRefundDataFromDB,SetState],IsRefundExpired->[GetPlayedTime],CanBeTraded->[GetOwner],SendUpdateSockets->[GetOwner],DeleteFromInventoryDB->[DeleteFromInventoryDB],ClearSoulboundTradeable->[SetState],CheckSoulboundTradeExpire->[GetOwner,ClearSoulboundTradeable],SetEnchantmentDuration->[SetState],CreateItem->[Create,SetItemRandomProperties],SetEnchantmentCharges->[GetOwner,SetState],time->[time],CloneItem->[CreateItem],GetPlayedTime->[time],ClearEnchantment->[GetOwner,SetState],SetItemRandomProperties->[GetOwner]] | AddItemsSetItem - add an item to the ItemSet. check if there is a free slot in the set and if so add it to the list. | it's not clear what this `if` is controlling. So please use brackets and indentation |
@@ -56,12 +56,7 @@ namespace System.Windows.Forms
/// </returns>
protected override AccessibleObject CreateAccessibilityInstance()
{
- if (AccessibilityImprovements.Level1)
- {
- return new DataGridViewTextBoxCellAccessibleObject(this);
- }
-
- return base.CreateAccessibilityInstance();
+ return new DataGridViewTextBoxCellAccessibleObject(this);
}
private DataGridViewTextBoxEditingControl EditingTextBox
| [DataGridViewTextBoxCell->[DataGridViewTextBoxCellAccessibleObject->[GetPropertyValue->[GetPropertyValue]],InitializeEditingControl->[InitializeEditingControl],KeyEntersEditMode->[KeyEntersEditMode],DetachEditingControl->[DetachEditingControl],ToString->[ToString],PositionEditingControl->[Size]]] | Create an AccessibleObject that can be used to access this cell. | is the "old" class still needed? |
@@ -261,3 +261,12 @@ def test_unknown_subcommand_help(capsys):
captured = capsys.readouterr()
help_output = captured.out
assert output == help_output
+
+
+def test_cli_suggestions():
+ try:
+ _ = parse_args(["psh"])
+ _ = parse_args(["fileas"])
+ raise AssertionError
+ except DvcParserError:
+ assert True
| [TestFindRoot->[test->[A,Cmd]],TestCd->[test->[A,Cmd]]] | Test that the command - line argument is unknown and has the correct output. | We could use `with pytest.raises` here |
@@ -26,6 +26,10 @@ fname_data = op.join(data_path, 'MEG', 'sample',
fname_label = op.join(data_path, 'MEG', 'sample', 'labels', 'Aud-lh.label')
warnings.simplefilter('always')
+inverse_operator = read_inverse_operator(fname_inv)
+inv = prepare_inverse_operator(inverse_operator, nave=1,
+ lambda2=1. / 9., method="dSPM")
+
@sample.requires_sample_data
def test_tfr_with_inverse_operator():
| [test_tfr_with_inverse_operator->[assert_array_almost_equal,Raw,list,all,source_induced_power,max,keys,dict,read_label,arange,find_events,assert_true,len,source_band_induced_power,read_inverse_operator,Epochs,pick_types],test_source_psd_epochs->[assert_array_almost_equal,Raw,drop_bad_epochs,any,multitaper_psd,dict,read_label,compute_source_psd_epochs,find_events,catch_warnings,assert_true,len,str,read_inverse_operator,apply_inverse_epochs,Epochs,simplefilter,pick_types],test_source_psd->[Raw,compute_source_psd,read_label,assert_true,sum,argmax,read_inverse_operator],simplefilter,data_path,join] | Test time freq with MNE inverse computation Generate a sequence of intervals for a single residue. | This will require the sample data :( |
@@ -514,7 +514,7 @@ RSpec.describe Dependabot::FileUpdaters::JavaScript::NpmAndYarn do
"0c6b15a88bc10cd47f67a09506399dfc9ddc075d")
expect(updated_yarn_lock.content).to include("is-number")
- expect(updated_yarn_lock.content).to_not include("0c6b15a88bc")
+ expect(updated_yarn_lock.content).to include("0c6b15a88bc")
expect(updated_yarn_lock.content).to_not include("af885e2e890")
expect(updated_yarn_lock.content).
to include("is-number@git+ssh://git@github.com:jonschlinkert")
| [updated_dependency_files,new,let,find,to_not,describe,match_array,named_captures,subject,it,name,its,to,before,specify,exist?,require,it_behaves_like,change,include,parse,fixture,content,require_relative,each,entries,context,be_a,to_stdout,eq,mkdir,raise_error] | This method checks that the package - lock. json file is updated and that the package - when updating another dependency does not remove the git dependency. | looks like this previously installed the latest version of is-number |
@@ -295,7 +295,7 @@ angular.module('ngResource', ['ng']).
});
query.sort();
url = url.replace(/\/*$/, '');
- return url + (query.length ? '?' + query.join('&') : '');
+ return url + (query.length ? '?' + query.join('&') : '') + '/'; // append slashes to urls
}
};
| [No CFG could be retrieved] | Creates a route that can be used to retrieve a specific resource by using a template. END METHODS END METHODS. | Are you sure? You append a slash at the end of the url. > > return url + (query.length ? '?' + query.join('&') : '') + '/'; > > foo?query1=1&query2=2/ I would made a bid for a line 297 |
@@ -0,0 +1,7 @@
+package logutil
+
+import "github.com/go-kit/kit/log"
+
+var (
+ Logger = log.NewNopLogger()
+)
| [No CFG could be retrieved] | No Summary Found. | I'd suggest not repeating "util" suffix in these package names, and only use non-conflicting names on imports. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.