patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -670,6 +670,10 @@ class KillPublishService(BasePublishService):
super().__init__(datasource=datasource, backend=backend)
def on_update(self, updates, original):
+ # check if we are trying to kill and item that is contained in normal non takes package
+ if is_item_in_package(original):
+... | [ArchivePublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items,filter_subscribers]],CorrectPublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items,filter_subscribers]],KillPublishService->[get_subscribers->[_get_subscribers_for_previously_sent_items],_publish_kill_for_takes-... | When an item is killed kill the item. | Why this is missed out from being `SuperdeskApiError.badRequestError()`? |
@@ -131,12 +131,17 @@ public class KeyAffinityServiceImpl<K> implements KeyAffinityService<K> {
} finally {
maxNumberInvariant.readLock().unlock();
}
+ try{
+ Thread.currentThread().sleep(POOL_INTERVAL);
+ }catch(InterruptedException e){
+ ... | [KeyAffinityServiceImpl->[handleCacheStopped->[stop],stop->[stop],getDistributionManager->[getDistributionManager],isKeyGeneratorThreadActive->[isActive]]] | Returns the key associated with the given address. | I think we could poll the queue here instead of waiting for a fixed amount of time: `queue.poll(POOL_INTERVAL, TimeUnit.MILLISECONDS);` |
@@ -0,0 +1,8 @@
+env = Figaro.env
+ttl = env.service_provider_request_ttl_hours || DEFAULT_TTL_HOURS
+REDIS_POOL = ConnectionPool.new(size: 10) do
+ Readthis::Cache.new(
+ expires_in: ttl.to_i.hours.to_i,
+ redis: { url: env.redis_throttle_url, driver: :hiredis },
+ )
+end
| [No CFG could be retrieved] | No Summary Found. | This always uses the secondary redis for these requests...is that intentional? |
@@ -132,8 +132,7 @@ function getListenForEvents(parentWin, sentinel, origin, triggerWin) {
if (!contentWindow) {
setTimeout(dropListenSentinel, 0, listenSentinel);
} else if (sentinel === 'amp') {
- // A non-3P code path, origin must match.
- if (we.origin === origin && contentWindow == trigg... | [No CFG could be retrieved] | Returns a mapping of event names to listenFor listeners. Checks if a window is a descendant of another window. | Thanks @samjacoby! @dvoytenko @lannka: When a message comes from `srcdoc`, the `origin` is `null` by design. Do you remember why we check origin of message in non-3P case in addition to contentWindow? The 3P case never checks origin. I am hoping this is safe to remove. Thoughts? (Maybe a safer solution is checking whet... |
@@ -46,6 +46,9 @@ def is_parameter(var):
def is_persistable(var):
+ if var.desc.type() == core.VarDesc.VarType.FEED_MINIBATCH or \
+ var.desc.type() == core.VarDesc.VarType.FETCH_LIST:
+ return False
return var.persistable
| [get_parameter_value_by_name->[get_parameter_value],save_persistables->[save_vars],load_persistables_if_exist->[_is_presistable_and_exist_->[is_persistable],load_vars],load_vars->[_clone_var_in_block_,load_vars],load_inference_model->[get_fetch_targets_names,load_persistables_if_exist,get_feed_targets_names],load_persi... | Returns True if the variable is persistable. | @Xreki I have changed the code and go with option 3 using your suggestion. For option 2, there is problem. Because in the python side of the code, the operator `op` field of var will only be associated with the operator that have this variable as its output. So for feed variable, since it is not the output of any opera... |
@@ -272,9 +272,11 @@ public abstract class AbstractCorrelatingMessageHandler extends AbstractMessageH
}
public void setDiscardChannelName(String discardChannelName) {
+ Assert.hasText(discardChannelName, "'discardChannelName' must not be empty");
this.discardChannelName = discardChannelName;
}
+ @Override... | [AbstractCorrelatingMessageHandler->[completeGroup->[completeGroup],onInit->[onInit],setTaskScheduler->[setTaskScheduler],forceComplete->[afterRelease],setSendTimeout->[setSendTimeout]]] | Set the name of the channel to discard. | Redundand method: super class does the same. So, just remove it from here |
@@ -155,14 +155,14 @@ describe GradeEntryFormsController do
if grade_entry_form.show_total
csv_array = [
- ['', grade_entry_form_with_data.grade_entry_items[0].name,I18n.t('grade_entry_forms.grades.total')],
- [I18n.t('grade_entry_forms.column_out_of'), String(grade_entry_form_with_d... | [create,let,to_not,describe,fixture_file_upload,first,it,name,to,before,post,xit,second,with,t,require,out_of,generate,show_total,puts,redirect_to,short_identifier,context,user_name,build,grades_grade_entry_form_path,get,eq,head,and_return] | tests that action csv_downloads returns OK parse header object to check for the right disposition returns attachment as attachment. | Metrics/LineLength: Line is too long. [121/120] |
@@ -121,6 +121,7 @@ public class V20161125142400_EmailAlarmCallbackMigration extends Migration {
final AlarmCallbackConfiguration alarmCallbackConfiguration = alarmCallbackService.create(stream.getId(),
CreateAlarmCallbackRequest.create(
EmailAlarmCallback.class.getCan... | [V20161125142400_EmailAlarmCallbackMigration->[migrateStream->[getCanonicalName,create,getDefaultEmailAlarmCallbackConfig,debug,of,error,empty,getId,save],getDefaultEmailAlarmCallbackConfig->[getRequestedConfiguration,toMap,getDefaultValue,collect],MigrationCompleted->[create->[AutoValue_V20161125142400_EmailAlarmCallb... | Create a new email alarm callback for the given stream. | Shouldn't this be "Email Alert Notification"? |
@@ -2339,6 +2339,7 @@ namespace DotNetNuke.Entities.Urls
private static bool IgnoreRequestForWebServer(string requestedPath)
{
if (requestedPath.ToLowerInvariant().IndexOf("synchronizecache.aspx", StringComparison.Ordinal) > 1
+ || requestedPath.ToLowerInvariant().IndexOf("... | [AdvancedUrlRewriter->[IgnoreRequest->[IgnoreRequestForWebServer,IgnoreRequestForInstall],RewriteAsChildAliasRoot->[RewriteUrl],IdentifyPortalAlias->[RedirectPortalAlias,ConfigurePortalAliasRedirect,IsPortalAliasIncorrect],Handle404OrException->[ShowDebugData],ConfigurePortalAliasRedirect->[CheckIfAliasIsCustomTabAlias... | Returns true if the request should be ignored for a web server and false if it should be. | Let's put the `synchronizeoutputcache.aspx` as a static readonly field of `MemoryCacheSynchonizationHandler` |
@@ -111,8 +111,9 @@ class ExceptionSink:
# to properly setup global state.
_log_dir = None
# We need an exiter in order to know what to do after we log a fatal exception or handle a
- # catchable signal.
- _exiter: Optional[Exiter] = None
+ # catchable signal. We default to `sys.exit` to configure the behav... | [ExceptionSink->[ignoring_sigint->[_ignoring_sigint],toggle_ignoring_sigint_v2_engine->[_toggle_ignoring_sigint_v2_engine],_log_unhandled_exception_and_exit->[log_exception,_exit_with_failure,_format_unhandled_exception_log],_handle_signal_gracefully->[log_exception,_format_traceback,_exit_with_failure],trapped_signals... | The signal handler to return. Set whether a backtrace gets printed to the terminal error stream on a fatal error. | @cosmicexplorer can you please sanity check that it is safe to move the default from line 546 to this line? It greatly simplifies the type hints for all this `ExceptionSink/Exiter` related code because `ExceptionSink._exiter` no longer needs to be `Optional`. |
@@ -141,13 +141,14 @@ public abstract class BaseFlinkCommitActionExecutor<T extends HoodieRecordPayloa
result.setWriteStats(writeStats);
// Finalize write
finalizeWrite(instantTime, writeStats, result);
- syncTableMetadata();
try {
LOG.info("Committing " + instantTime + ", action Type " + ... | [BaseFlinkCommitActionExecutor->[commit->[commit,getCommitActionType],getCommitActionType->[getCommitActionType]]] | Commit the current write. | here means we take syncing to metadata table into a commit. more reasonable than making sync table metadata in `postCommit` |
@@ -369,7 +369,7 @@ class Sessions(WindowFn):
to_merge = []
for w in sorted(merge_context.windows, key=lambda w: w.start):
if to_merge:
- if end > w.start:
+ if end > w.start: # pylint: disable=used-before-assignment
to_merge.append(w)
if w.end > end:
e... | [FixedWindows->[assign->[IntervalWindow]],WindowedValue->[with_value->[WindowedValue]],IntervalWindow->[union->[IntervalWindow]],SlidingWindows->[assign->[IntervalWindow]],GlobalWindows->[get_window_coder->[GlobalWindow],windowed_value->[WindowedValue,GlobalWindow],assign->[GlobalWindow]],Sessions->[merge->[merge,Inter... | Merge this window with another window. | Here, explicitly assigning `end` to some idempotent element would improve readability and remove the need for the pylint suppression. Am I missing something special? |
@@ -156,8 +156,6 @@ class AzfsResourceId implements ResourceId {
@Override
public ResourceId resolve(String other, ResolveOptions resolveOptions) {
checkState(isDirectory(), "Expected this resource to be a directory, but was [%s]", toString());
- // TODO: check if resolve options are an illegal name in an... | [AzfsResourceId->[getCurrentDirectory->[fromComponents,isDirectory],equals->[equals],getFilename->[isDirectory],fromUri->[fromComponents],resolve->[equals,fromUri,isDirectory,fromComponents,toString],fromComponents->[AzfsResourceId]]] | Resolves this resource id to a new resource id based on the given other resource id. | Is this resolved now? |
@@ -158,10 +158,10 @@ public class CoordinatorServerView implements InventoryView
synchronized (lock) {
log.debug("Removing segment[%s] from server[%s].", segmentId, server);
- final SegmentLoadInfo segmentLoadInfo = segmentLoadInfos.get(segmentId);
+ SegmentLoadInfo segmentLoadInfo = segmentLoa... | [CoordinatorServerView->[getInventoryValue->[getInventoryValue],getInventory->[getInventory],serverRemovedSegment->[removeServer],clear->[clear]]] | Remove a segment from the server. | Maybe should rephrase the logging statement now since and change level to "info"? |
@@ -173,3 +173,14 @@ func (w *getTarConditionalWriter) Write(data []byte) (int, error) {
w.bytesWritten += int64(len(data))
return len(data), nil
}
+
+func (a *apiServer) ListFileNS(req *pfs.ListFileRequest, server pfs.API_ListFileNSServer) error {
+ pachClient := a.env.GetPachClient(server.Context())
+ err := a.d... | [Write->[Write,Send],GetTarConditional->[Context,NewWriterSize,Flush,getFilesConditional,ReportRequestWithThroughput,Now,Log,Errorf,Send,Get,Info,Recv,Since],PutTar->[Context,SendAndClose,NewReader,ReportRequestWithThroughput,Now,withFileSet,Log,Errorf,Recv,Since,Put],Read->[Read,Recv,NewReader,Len],GetTar->[Context,Ne... | Write - writes data to the archive. | Similar to above, you can just return the result of the function call. |
@@ -48,6 +48,11 @@ def primary_email_change_event(profile, changed_date, email):
@user_profile_from_uid
def delete_user_event(user, deleted_date):
"""Process the delete user event."""
- user.delete(addon_msg='Deleted via FxA account deletion')
- log.info(
- 'Account pk [%s] deleted from FxA on %s' %... | [user_profile_from_uid->[wrapper->[f,info,get,fromtimestamp,warning],wraps],primary_email_change_event->[info,warning,update],delete_user_event->[info,delete],getLogger] | Process the delete user event. | It matters less for things that don't go in sentry, so that doesn't block this PR, but we should try to always let `logging` to the formatting to allow for grouping - So we should do logging formatting with `log.info('foo %s', bar)` and not `log.info('foo %s' % bar)`, `log.info('foo {bar}')` or `log.info('foo {}'.forma... |
@@ -740,12 +740,15 @@ int EVP_PKEY_assign(EVP_PKEY *pkey, int type, void *key)
}
# endif
-const void *EVP_PKEY_get0(const EVP_PKEY *pkey)
+void *EVP_PKEY_get0(EVP_PKEY *pkey)
{
if (pkey == NULL)
return NULL;
- return evp_pkey_get_legacy((EVP_PKEY *)pkey);
+ if (!evp_pkey_is_provided(pkey))
+ ... | [No CFG could be retrieved] | private private methods ASN. 1_OCTET_STRING - > bytes. | Please do not remove the const on the parameter. That is actually an API break as we have const there in 1.1.1 already. |
@@ -255,8 +255,13 @@ def set_config(key, value, home_dir=None, set_env=True):
--------
get_config
"""
+
if key is None:
+ warn('set_config(key=None, value=None) to get a list of valid keys '
+ 'has been deprecated and will be removed in version 0.19. Use '
+ 'get_confi... | [_get_stim_channel->[get_config],get_subjects_dir->[get_config],get_config->[get_config_path,_load_config],set_config->[get_config_path,_load_config]] | Set a MNE - Python preference key in the config file and environment. Write the missing node ID in the config file. | Travis was not happy with this insertion |
@@ -1465,9 +1465,11 @@ def repro_dir(tmp_dir, dvc, run_copy):
stages["dir_file_copy"] = stage
last_stage = tmp_dir / "dir" / DVC_FILE
+ deps = [os.fspath(origin_copy_2), os.fspath(dir_file_copy)]
stage = dvc.run(
+ cmd="echo {}".format(" ".join(deps)),
fname=os.fspath(last_stage),
- ... | [TestReproChangedDir->[test->[_run,_get_stage_target]],TestReproAllPipelines->[test->[_run]],TestReproCyclicGraph->[test->[_run]],TestReproChangedCode->[test->[_get_stage_target]],TestRepro->[setUp->[_run]],TestNonExistingOutput->[test->[_get_stage_target]],TestReproForce->[test->[_get_stage_target]],TestReproNoCommit-... | Reproutes the base directory of a node. Context manager for DVC_FILECOFFS. | For these kind of stage that does not generate any outs, I have used `echo` or `ls` or `cat` as a `cmd`. |
@@ -47,14 +47,7 @@ export type OverridesT = {
};
// Basically React.Node minus React.Portal and Iterable
-export type ChildT =
- | void
- | null
- | boolean
- | number
- | string
- // eslint-disable-next-line flowtype/no-weak-types
- | React.Element<any>;
+export type ChildT = void | null | boolean | number ... | [No CFG could be retrieved] | Imports a React object containing all of the properties of the top - level popover. Props for a stateful popover. | wonder if this can be replaced with `React.Node` type |
@@ -200,14 +200,14 @@ func (bc *BasicCluster) PutRegion(region *core.RegionInfo) error {
return nil
}
-// UpdateWriteStatus update the write status
-func (bc *BasicCluster) UpdateWriteStatus(region *core.RegionInfo) {
+// IsUpdateWriteStatus update the write status
+func (bc *BasicCluster) IsUpdateWriteStatus(regi... | [GetLeaderStore->[GetStore],GetStore->[GetStore],RandLeaderRegion->[RandLeaderRegion],GetRegionStores->[GetStore],UnblockStore->[UnblockStore],RandFollowerRegion->[RandFollowerRegion],GetRegion->[GetRegion],GetStores->[GetStores],BlockStore->[BlockStore],GetFollowerStores->[GetStore]] | PutRegion - Put a region in the cluster. | I suppose the second return value is always the region's id, we can load it from region info, so don't need to return it. |
@@ -1,8 +1,11 @@
# pylint: disable=invalid-name,line-too-long
+
+import pytest
+
from allennlp.data.dataset_readers.semantic_parsing.grammar_based_text2sql import GrammarBasedText2SqlDatasetReader
from allennlp.common.testing import AllenNlpTestCase
-
+@pytest.mark.skip(reason="Mark will fix in a nearby PR.")
cla... | [TestGrammarBasdText2SqlDatasetReader->[test_reader_can_read_data_with_entity_pre_linking->[print,list,read,len],setUp->[str,GrammarBasedText2SqlDatasetReader,super]]] | Set up the properties of the object. | Minor typo: `GrammarBasd` |
@@ -163,10 +163,4 @@ public class HiveUtils {
return conf;
}
- /**
- * @return true if {@link Table} is partitioned.
- */
- public static boolean isPartitioned(Table table) {
- return table.isPartitioned();
- }
}
| [HiveUtils->[getInputFormat->[getInputFormat],isPartitioned->[isPartitioned],getPartitions->[getPartitions]]] | Gets the hadoop configuration. | Please leave the method and mark as deprecated. It is possible other products are relying on this method as a library. |
@@ -93,11 +93,11 @@ public class HoodieLogFormatWriter implements HoodieLogFormat.Writer {
}
if (!isAppendSupported) {
this.logFile = logFile.rollOver(fs, rolloverLogWriteToken);
- LOG.info("Append not supported.. Rolling over to " + logFile);
+ LOG.info("Append not supported.. Roll... | [HoodieLogFormatWriter->[handleAppendExceptionOrRecoverLease->[createNewFile],close->[close],flush->[flush],rolloverIfNeeded->[HoodieLogFormatWriter]]] | Create a writer that writes a block of data to a log file. Reads the header of the HoodieLogBlock and writes it to the output. | Shall we use `logFile.getPath()` here? |
@@ -68,7 +68,7 @@ class ConfigCache
*
* @return null|mixed Returns the value of the Config entry or null if not set
*/
- public function get($cat, $key = null)
+ public function get(string $cat, $key = null)
{
if (isset($this->config[$cat][$key])) {
return $this->config[$cat][$key];
| [ConfigCache->[setDefault->[set],load->[setDefault,set],__construct->[load]]] | Get a configuration value. | Why did you remove the `string` type-hint fromthe `$key` parameter in this specific method while the type-hint is present in the adapters? |
@@ -198,7 +198,7 @@ class DefineWakeProcess2D(KratosMultiphysics.Process):
elem.SetValue(CPFApp.KUTTA, True)
@staticmethod
- def CheckIfElemIsCutByWake(elem):
+ def __CheckIfElemIsCutByWake(elem):
nneg=0
distances = elem.GetValue(KratosMultiphysics.ELEMENTAL_DISTANCES)
... | [DefineWakeProcess2D->[MarkWakeTEElement->[CheckIfElemIsCutByWake],__init__->[__init__]]] | Checks if an element is cut by wake. | Note that in here you are retrieving the discontinuous elemental distances, which might not coincide with the nodal ones if you call this method after using the modify distance process. |
@@ -999,7 +999,9 @@ public abstract class SeekableStreamSupervisor<PartitionIdType, SequenceOffsetTy
throws ExecutionException, InterruptedException, TimeoutException, JsonProcessingException
{
possiblyRegisterListener();
+ stateManager.setStateIfNoSuccessfulRunYet(SeekableStreamSupervisorStateManager... | [SeekableStreamSupervisor->[possiblyRegisterListener->[statusChanged->[RunNotice]],stopTasksInGroup->[stopTask,killTask],buildRunTask->[RunNotice],tryInit->[toString,handle],generateSequenceName->[toString],getTaskLocation->[getTaskId],addTaskGroupToActivelyReadingTaskGroup->[TaskData,TaskGroup],makeSequenceNumber->[ma... | This method is called by the TaskManager when it is ready to run. | Hm, I feel like it would be cleaner if the state manager handled the decision of whether to transition to a particular state based on whether a successful run has occurred or not (I don't think the caller should have to know that it needs to call either `setStateIfNoSuccessfulRunYet` or `setState` depending on the stat... |
@@ -270,10 +270,9 @@ public class DescribableList<T extends Describable<T>, D extends Descriptor<T>>
}
public Object unmarshal(HierarchicalStreamReader reader, UnmarshallingContext context) {
- CopyOnWriteList core = copyOnWriteListConverter.unmarshal(reader, context);
-
try ... | [DescribableList->[contains->[get],toArray->[toArray],buildDependencyGraph->[buildDependencyGraph],toMap->[toMap],rebuild->[get,rebuild],remove->[remove],get->[get],ConverterImpl->[unmarshal->[unmarshal],ConverterImpl]]] | Unmarshall a HierarchicalStreamReader into a List of objects. | `asSubclass` ensures that even if the problem occurs, we will get a `ClassCastException`, which is easier to diagnose than a `NoSuchMethodException`. |
@@ -26,7 +26,8 @@ for attribute in dir(std_os):
if not hasattr(ourselves, attribute):
setattr(ourselves, attribute, getattr(std_os, attribute))
-# Similar to os.path, allow certbot.compat.os.path to behave as a module
+# Import our path module, then allow certbot.compat.os.path to behave as a module (li... | [chmod->[RuntimeError],replace->[RuntimeError],rename->[RuntimeError],mkdir->[RuntimeError],open->[RuntimeError],makedirs->[RuntimeError],chown->[RuntimeError],dir,getattr,hasattr,setattr] | This is the first round of wrapping. It will import all the attributes from the core os it states that the appropriate permissions will be set for the owner. | If we add this `type: ignore`, is all type checking disabled on all calls to all functions in `certbot.compat.os.path`? I suspect this is the case which doesn't seem great. Is there an easy way to avoid this `type: ignore`? |
@@ -15,7 +15,12 @@ def test_estimate_gas_fail(deploy_client):
assert len(deploy_client.web3.eth.getCode(to_checksum_address(address))) > 0
check_block = deploy_client.get_checking_block()
- assert not contract_proxy.estimate_gas(check_block, "fail")
+
+ msg = "Estimate gas should return None if the tr... | [test_estimate_gas_defaults_to_pending->[poll,estimate_gas,get_block,deploy_rpc_test_contract,transact,get_transaction_receipt],test_estimate_gas_fails_if_startgas_is_higher_than_blockgaslimit->[deploy_rpc_test_contract,blockhash_from_blocknumber,estimate_gas,get_block],test_estimate_gas_fail->[getCode,estimate_gas,len... | Test estimate gas fail if a block_identifier is not available in the contract. | should be "require" instead of "revert" |
@@ -508,9 +508,16 @@ public class RServerEvaluator {
// direct graphical output
String tryCode;
connection.eval("do.call(svg,c(list('" + file + "'), beaker::saved_svg_options))");
- tryCode = "beaker_eval_=withVisible(try({ " + j.codeToBeExecuted + "\n},silent=TRUE))\n"... | [RServerEvaluator->[cancelExecution->[cancelExecution],exit->[cancelExecution],autocomplete->[autocomplete],writeRserveScript->[openTemp,makeTemp],getSvgResults->[getImage,MyTranscoder,fixSvgResults],evaluate->[jobDescriptor],workerThread->[run->[makeTemp,isVisible,startRserve,isError,getSvgResults],startRserve->[write... | Runs the RPlot. This method is called when a beaker object is being processed. | instead of using variables named "warn" and "err", use "beaker_warn_" and "beaker_err_" to avoid any conflicts with user code. |
@@ -476,6 +476,18 @@ PYTHON_DEMOS = [
})
)),
+ PythonDemo(name='face_detection_mtcnn_demo', device_keys=['-d'], test_cases=combine_cases(
+ TestCase(options={'--no_show': None,
+ '-i': image_net_arg('00000002')}),
+ [
+ TestCase(options={
+ ... | [combine_cases->[join_cases],PythonDemo,single_option_cases,combine_cases,CppDemo] | Example of how to use the CVX - C2 model. Missing test cases. | This can be merged with previous `TestCase` instance. |
@@ -54,7 +54,9 @@ public abstract class AbstractExpressionEvaluator implements BeanFactoryAware, I
private volatile BeanFactory beanFactory;
- private volatile MessageBuilderFactory messageBuilderFactory;
+ private volatile MessageBuilderFactory messageBuilderFactory = new DefaultMessageBuilderFactory();
+
+ priv... | [AbstractExpressionEvaluator->[setConversionService->[setConversionService],afterPropertiesSet->[getMessageBuilderFactory],setBeanFactory->[setBeanFactory],evaluateExpression->[evaluateExpression,getEvaluationContext],getEvaluationContext->[getEvaluationContext]]] | Set the bean factory. | This class has a bug in the `afterPropertiesSet()` will be fixed tomorrow |
@@ -337,6 +337,17 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
/** @private {?./safeframe-host.SafeframeHostApi} */
this.safeframeApi_ = null;
+
+ /** @private {boolean} whether safeframe forced via tag */
+ this.forceSafeframe_ = false;
+ if ('forceSafeframe' in this.element.datase... | [AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dev,dict,stringify,now,userAgent],extractSize->[height,extractAmpAnalyticsConfig,get,setGoogleLifecycleVarsFromHeaders,width],getBlockParameters_->[serializeTargeting_,dev,user,isInManualExperiment,Number,assign,join,googleBlockParameters,getMultiSizeDimensions,m... | Initializes a missing node in the DOM. Private methods for handling any unknown node type. if vpRange = false return vpRange ;. | Why do we need to check for 1/true/True, and not just 1? |
@@ -438,9 +438,7 @@ def test_pex_execution(rule_runner: RuleRunner) -> None:
assert result.stdout == b"from main\n"
-# TODO(John Sirois): Add VenvPex to the pex_type parameter list once Pants is upgraded to Pex with
-# a fix for: https://github.com/pantsbuild/pex/issues/1239
-@pytest.mark.parametrize("pex_typ... | [test_group_field_sets_by_constraints_with_unsorted_inputs->[create_for_test],test_entry_point->[create_pex_and_get_pex_info],test_pex_execution->[create_pex_and_get_all_data],parse_requirements->[parse],create_pex_and_get_pex_info->[create_pex_and_get_all_data],test_platforms->[create_pex_and_get_all_data],ExactRequir... | Test if a pex or venv pex is available in the environment. | The VenvPex parametrization fails trying to extract PEX-INFO with PEX_TOOLS before the script fix. |
@@ -797,7 +797,7 @@ if ($resql)
// Label
if (! empty($arrayfields['p.label']['checked']))
{
- print '<td class="tdoverflowmax200">'.dol_trunc($obj->label, 40).'</td>';
+ print '<td class="tdoverflowmax220">'.dol_trunc($obj->label, 70).'</td>';
if (! $i) $totalarray['nbfield']++;
}
| [selectMassAction,fetch_object,order,selectyesno,getNomUrl,print_all_ways,selectarray,display_price_product_fournisseur,initHooks,find_min_price_product_fournisseur,load,plimit,executeHooks,loadLangs,select_categories,LibStatut,escape,getDefaultLang,showCheckAddButtons,close,textwithpicto,load_stock,free,query,fetch_na... | Get product static data from object Print barcodes for calendar component. | The css style tdoverflowmax220 does not exists. |
@@ -237,7 +237,7 @@ class Contact extends ApiWrapper
/**
* Sets current position.
*
- * @param $position
+ * @param string $position
*/
public function setCurrentPosition($position)
{
| [Contact->[setMainUrl->[setMainUrl],getCreated->[getCreated],addCategory->[addCategory],addPhone->[addPhone],getTitle->[getId,getTitle],getChanged->[getChanged],getPosition->[getPosition,getId],getFormOfAddress->[getFormOfAddress],addFax->[addFax],setLastName->[setLastName],removeEmail->[removeEmail],setMiddleName->[se... | Set current position. | this is not a string but a `Position` (`Sulu\Bundle\ContactBundle\Entity\Position`) entity |
@@ -313,7 +313,7 @@ class AnnotationsControllerTest < AuthenticatedControllerTest
end
should 'recognize action to destroy' do
- assert_recognizes( {:action => 'destroy', :controller => 'annotations'},
- {:path => 'annotations', :method => 'delete'} )
+ assert_recognizes({ action: 'de... | [AnnotationsControllerTest->[create,post_as,should,assert,post,assigns,assert_not_nil,delete_as,content,put_as,make,id,delete,context,assert_response,get,render_template,setup,assert_recognizes],join,require,expand_path,dirname] | - > find all annotations with action to destroy - > find all annotations with method delete. | Align the parameters of a method call if they span more than one line. |
@@ -122,6 +122,9 @@ namespace System.Net.Sockets.Tests
[InlineData(false, 2)]
public void CtorAndAccept_SocketNotKeptAliveViaInheritance(bool validateClientOuter, int acceptApiOuter)
{
+ // 300 ms should be long enough to connect if the socket is actually present & listening.
+ ... | [CreateSocket->[Ctor_Netcoreapp_Throws->[Raw,Linux,ControllerAreaNetwork,Assert,Packet],DualMode_Failure->[Assert,nameof],Ctor_Raw_NotSupported_ExpectedError->[AnyUnix,Icmp,Raw,SocketErrorCode,ProtocolNotSupported,nameof,InterNetworkV6,Contains,IcmpV6,Udp,AccessDenied,Tcp,Assert,InterNetwork],Ctor_Raw_Supported_Success... | Creates a child process that is not alive via inheritance. This method checks that the child process is alive and that it is not able to accept new. | I'm wondering if this could go to SocketTestHelper.cs just in case we need to adjust it for ARM runs. |
@@ -637,6 +637,8 @@ func (ss *StateSync) getMaxPeerHeight() uint64 {
wg.Add(1)
go func() {
defer wg.Done()
+ //debug
+ //utils.GetLogInstance().Warn("[Sync] getMaxPeerHeight", "IP", peerConfig.ip, "Port", peerConfig.port)
response := peerConfig.client.GetBlockChainHeight()
ss.syncMux.Lock()
if... | [SyncLoop->[purgeAllBlocksFromCache,getMaxPeerHeight,purgeOldBlocksFromCache,RegisterNodeInfo,ProcessStateSync],GetBlockHashesConsensusAndCleanUp->[getHowManyMaxConsensus,cleanUpPeers],GetBlocks->[GetBlocks],purgeAllBlocksFromCache->[ForEachPeer],getMaxConsensusBlockFromParentHash->[ForEachPeer],getMaxPeerHeight->[ForE... | getMaxPeerHeight returns the maximum height of all peers in the system. | please remove the debug code or use Debug() |
@@ -820,7 +820,12 @@ class TorchAgent(Agent):
"""
self._set_text_vec(obs, truncate, split_lines)
self._set_label_vec(obs, add_start, add_end, truncate)
- self._set_label_cands_vec(obs, add_start, add_end, truncate)
+ # vectorize label candidates if and only if we are using inlin... | [TorchAgent->[add_cmdline_args->[optim_opts,dictionary_class],get_dialog_history->[_add_person_tokens],vectorize->[_set_text_vec,_set_label_cands_vec,_set_label_vec],receive_metrics->[_is_lr_warming_up],load->[load],init_optim->[optim_opts],observe->[get_dialog_history,last_reply,vectorize],__init__->[dictionary_class]... | This function is used to vectorize the text and label_vec fields of an observation. This function is a base class method that can be used to create a sequence of missing missing Batch implementation of . | can we move this logic instead into `_set_label_cand_vec`? Then we can say in its docstring that it becomes a no-op in `-cands batch`? |
@@ -103,7 +103,7 @@ public class HudsonPrivateSecurityRealm extends AbstractPasswordBasedSecurityRea
* in Java {@code \w} is equivalent to {@code [A-Za-z0-9_]} (take care of "_")
*/
private static final String DEFAULT_ID_REGEX = "^[\\w-]+$";
-
+
/**
* If true, sign up is not allowed.
... | [HudsonPrivateSecurityRealm->[hash->[encodePassword],doCreateFirstAccount->[loginAndTakeBack,hasSomeUser],doFilter->[doFilter],getACL->[getACL],loginAndTakeBack->[authenticate],isPasswordValid->[isPasswordValid,encodePassword],encodePassword->[encodePassword],getAllowsSignup->[allowsSignup],checkPermission->[checkPermi... | Creates a private security realm that uses the given user ID check. Adds a filter that asks the user to create a new user account. | nit: remove the whitespace change there |
@@ -16,7 +16,7 @@ struct timer_data {
void *arg2;
};
-static struct timer_data xtimer[3] = {};
+static struct timer_data xtimer[ARCH_TIMER_COUNT] = {};
void timer_64_handler(void *arg)
{
| [timer_64_handler->[handler2,xthal_get_ccompare,xthal_set_ccompare,arch_timer_clear],arch_timer_get_system->[arch_interrupt_global_disable,xthal_get_ccount,arch_interrupt_global_enable,xthal_get_ccompare,arch_interrupt_get_status],arch_timer_set->[arch_interrupt_global_enable,xthal_set_ccompare,arch_interrupt_global_di... | timer_64_handler - timer_64_handler cant be a cortex. | @tlauda please make this change also for imx: src/platform/imx8/include/platform/drivers/timer.h Working on multiple platforms comes with the responsability of keeping the code consistent and a change should cover all existing platforms. |
@@ -360,6 +360,7 @@ module.exports = class extends BaseGenerator {
saveConfig() {
this.config.set('jhipsterVersion', packagejs.version);
+ this.config.set('applicationType', this.applicationType);
this.config.set('baseName', this.baseName);
... | [No CFG could be retrieved] | Configure the global configuration. Missing properties - config options. | if this is added here then you need to do it for client sub gen as well |
@@ -263,7 +263,7 @@ export default {
}
}}
/>
- <Checkbox onChange={onChange} inputRef={inputRef} autoFocus={isFocused}>
+ <Checkbox onChange={onChange} inputRef={inputRef}>
Focused checkbox
</Checkbox>
</div>
| [No CFG could be retrieved] | onChange - Focus checkbox if checkbox is not active. | so after removing `autoFocus` it doesnt' work as expected in this example |
@@ -104,6 +104,17 @@ class FundCommand extends BaseCommand
$io->write("");
$io->write("Please consider following these links and sponsoring the work of package authors!");
$io->write("Thank you!");
+ } elseif ($fundings && $format === 'json') {
+ $fundingJson = a... | [FundCommand->[insertFundingData->[getFunding,getPrettyName],execute->[isDefaultBranch,write,getName,getRepositories,getFunding,loadPackages,getComposer,getPackages,getLocalRepository,getIO,insertFundingData],configure->[setDescription]]] | Executes the command. Writes a line to the console. | this looks wrong to me. If there is no funding links found, the output should still be in JSON rather than plaintext when requesting json. |
@@ -0,0 +1,18 @@
+# Copyright 2013-2019 Lawrence Livermore National Security, LLC and other
+# Spack Project Developers. See the top-level COPYRIGHT file for details.
+#
+# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+
+from spack import *
+
+
+class PyDeprecation(PythonPackage):
+ """The deprecation library provid... | [No CFG could be retrieved] | No Summary Found. | Missing dependency on `py-packaging`. |
@@ -51,7 +51,7 @@ module ActiveRecord
::File.join(fixtures_directory, fs_name))
end
- all_loaded_fixtures.update(fixtures_map)
+ update_all_loaded_fixtures fixtures_map
connection.transaction(:requires_new => true) do
# Patch - replace this...
| [FixtureSet->[create_fixtures->[disable_referential_integrity]]] | Creates all fixtures in the given directory. finds missing record in database. | Link to commit sha / line or something that shows where this comes from would be good |
@@ -13,7 +13,7 @@
* @author LibreNMS Contributors
*/
-$alert_severities = [
+$alert_severities = array(
// alert_rules.status is enum('ok','warning','critical')
'ok' => 1,
'warning' => 2,
| [toArray,hasGlobalRead] | This method is used to find all alert rules that have a specific number of devices. count of alert log entries that have been logged. | please change "array()" back to "[.,..]" "array()" is old style |
@@ -419,6 +419,8 @@ public class Geonetwork implements ApplicationHandler {
Log.error(Geonet.DB, "Error occurred while trying to execute SQL", t);
throw new RuntimeException(t);
}
+
+ context.getBean(IsoLanguagesMapper.class).init();
}
}
| [Geonetwork->[fillCaches->[run->[ServletWebRequest,MockFilterChain,toString,info,MockHttpServletRequest,loginAs,setAttribute,of,doFilter,getBean,set,setUsername,getAttribute,findAll,getServletContext,setAsThreadLocal,setSession,getNumberOfElements,MockHttpServletResponse,getUserSession,exec,getId,MockHttpSession],Threa... | import database data if it has not been imported. | maybe is renit better, as init would append entries at the end of existing ones, they are maybe figures where entries are already there whene this init call is done. |
@@ -153,13 +153,6 @@ namespace System
1e80
};
- // Used to fill uninitialized stack variables with non-zero pattern in debug builds
- [Conditional("DEBUG")]
- private static unsafe void DebugPoison<T>(ref T s) where T : unmanaged
- {
- ... | [Decimal->[DecDivMod1E9->[DecDivMod1E9,AsMutable],DecCalc->[VarDecModFull->[Div128By96,Div96By64,UInt32x32To64,DebugPoison],VarDecCmpSub->[UInt32x32To64],SearchScale->[Decimal],ScaleResult->[Decimal],Div128By96->[UInt32x32To64],VarDecDiv->[Add32To96,DebugPoison,IncreaseScale,Div96By64,Decimal,Div128By96,SearchScale,Ove... | Debug poison method for testing if a single object is missing a non - zero value. | great that you can delete it now, maybe keep their pattern "0xCD" in the general case? |
@@ -103,11 +103,13 @@ type beatConfig struct {
// elastic stack 'setup' configurations
Dashboards *common.Config `config:"setup.dashboards"`
- Template *common.Config `config:"setup.template"`
Kibana *common.Config `config:"setup.kibana"`
- // ILM Config options
- ILM *common.Config `config:"output.elas... | [launch->[InitWithSettings,createBeater],TestConfig->[createBeater,Init],Setup->[createBeater,Init],createBeater->[BeatConfig],configure->[BeatConfig],Init->[InitWithSettings]] | Beat is a type that can be used to create a Beat instance. Initialize and run a Beater implementation. | why not `[]index.Config`? We seem to unpack the Indices config in a few places. |
@@ -13,5 +13,14 @@ class AlaveteliPro::DashboardController < AlaveteliPro::BaseController
@page = 1 if @page < 1
@per_page = 10
@activity_list = AlaveteliPro::ActivityList::List.new(@user, @page, @per_page)
+ @phase_counts = @user.request_summaries.
+ joins(:request_summary_catego... | [index->[to_i,new]] | This method returns the next n - item in the index. | This and the identical code in `info_requests_controller.rb` should be refactored to a single method. I'm thinking probably the `User` model would be a good place for it. That method should have some specs and should also handle the conversion of the counts to integers currently being done in templates. |
@@ -0,0 +1,15 @@
+module Middlewares
+ # Since we must explicitly set the cookie domain in session_store before SiteConfig is available,
+ # this ensures we properly set the cookie to SiteConfig.app_domain at runtime.
+ class SetCookieDomain
+ def initialize(app)
+ @app = app
+ end
+
+ def call(env)
+ ... | [No CFG could be retrieved] | No Summary Found. | added a `Middlewares` module for grouping |
@@ -1,4 +1,3 @@
-require "pusher"
require "pusher/push_notifications"
Pusher.app_id = ApplicationConfig["PUSHER_APP_ID"]
| [secret_key,cluster,instance_id,secret,key,logger,encrypted,require,app_id,configure] | Initialize PushNotifications with the application configuration. | pusher is automatically loaded |
@@ -241,7 +241,7 @@ describe AdminCensorRuleController do
context 'request_id param' do
before(:each) do
- @censor_rule_params = FactoryGirl.build(:info_request_censor_rule).serializable_hash
+ @censor_rule_params = FactoryGirl.attributes_for(:info_request_censor_rule)
# last_edit_e... | [create_censor_rule->[post,id],create,admin_request_censor_rules_path,describe,match_array,it,put,serializable_hash,map,to,before,post,admin_user_path,public_body,require,user,dirname,receive,id,delete,redirect_to,context,admin_body_censor_rules_path,build,admin_body_path,get,admin_user_censor_rules_path,basic_auth_log... | adds some checks to the censor rules administration page successfully saving the censor rule persists the censor rule and checks the flash message. | Line is too long. [83/80] |
@@ -49,11 +49,11 @@ type MetricsStore struct {
/*
* Certificate metrics
*/
- // CertXdsIssuedCount is the metric counter for the number of xds certificates issued
- CertXdsIssuedCount prometheus.Counter
+ // CertIssuedCount is the metric counter for the number of certificates issued
+ CertIssuedCount prometheus... | [Start->[MustRegister],Handler->[InstrumentMetricHandler,HandlerFor],Stop->[Unregister],NewCounterVec,NewGauge,NewHistogramVec,NewRegistry,NewCounter] | Metrics for the number of non - terminal metrics represents the number of namespaces monitored by OSM controller. | These metrics only pertain to XDS certs, why are they being removed from the variable names? |
@@ -25,4 +25,17 @@ export function doGetJSON(url) {
return Promise.reject(error);
});
+
+ if (retry) {
+ return timeoutPromise(fetchPromise, RETRY_TIMEOUT)
+ .catch(response => {
+ if (response.status >= 400 && response.status < 500) {
+ ret... | [No CFG could be retrieved] | reject if error. | We have this in jitsi-meet-spot as well. You want to shove something into js-utils so both repos can share it? |
@@ -1000,12 +1000,12 @@ class Flow:
)
@cache
- def build_environment(self) -> bytes:
+ def build_environment(self) -> dict:
"""
Build the flow's environment.
Returns:
- - bytes of a key that can be used to access the environment.
+ - dict: a key t... | [Flow->[copy->[copy],upstream_tasks->[edges_to],update->[add_edge,add_task],reference_tasks->[terminal_tasks],chain->[add_edge],edges_to->[all_upstream_edges],set_dependencies->[add_edge,add_task],run->[parameters,run],edges_from->[all_downstream_edges],generate_local_task_ids->[all_upstream_edges,sorted_tasks,copy,ser... | Build the flow s environment. | this wording is confusing to me; strictly speaking in the python world, dicts can be keys because they're mutable, but I'm guessing you're using the word "key" slightly differently. Could you clarify? |
@@ -199,7 +199,6 @@ class TestCalibrationForResnet50(unittest.TestCase):
def run_program(self, model_path, generate_int8=False, algo='direct'):
image_shape = [3, 224, 224]
- os.environ['FLAGS_use_mkldnn'] = 'True'
fluid.memory_optimize(fluid.default_main_program())
| [process_image->[resize_short,crop_image],val->[_reader_creator],TestCalibrationForResnet50->[download_data->[cache_unzipping],download_model->[download_data],run_program->[val],test_calibration->[download_model,run_program]],TestCalibrationForMobilenetv1->[download_model->[download_data]]] | Run the n - tuple model on the given model. time - related functions. | Since there is `os.environ['FLAGS_use_mkldnn'] = True`, do you need `FLAGS_use_mkldnn=true python test_calibration.py` again? |
@@ -52,12 +52,8 @@ static int test_standard_exts()
tmp = standard_exts;
TEST_error("Extensions out of order!");
for (i = 0; i < STANDARD_EXTENSION_COUNT; i++, tmp++)
- fprintf(stderr, "%d : %s\n", (*tmp)->ext_nid,
- OBJ_nid2sn((*tmp)->ext_nid));
- } else {
- ... | [register_tests->[ADD_TEST],int->[OBJ_nid2sn,TEST_error,OSSL_NELEM,fprintf]] | test_standard_exts - Test if standard extensions have a specific extension. | Same here - changing output to not have "Order OK" ... is that intentional? |
@@ -305,6 +305,8 @@ function list_devices(Illuminate\Http\Request $request)
if ($type == 'all' || empty($type)) {
$sql = '1';
+ } elseif ($type == 'device_id') {
+ $sql = "`d`.`device_id` = $query";
} elseif ($type == 'active') {
$sql = "`d`.`ignore`='0' AND `d`.`disabled`='0'";
... | [get_graphs->[route],search_ports->[route,get,where,isEmpty,select,orWhere],edit_location->[route,getContent],update_device->[route,getContent],get_port_stack->[route,get],get_vlans->[route],get_vrf->[route],get_inventory_for_device->[route],get_device->[route],get_bill_history_graph->[route,get],get_devices_by_group->... | List all devices in the system. Queries for all nodes that are not associated with any host. Get a list of all devices that have a node id. | This introduces a sql vulnerability |
@@ -251,9 +251,17 @@ module Engine
private
def init_bank
+ return Bank.new(self.class::BANK_CASH[players.size], log: @log) if self.class::BANK_CASH.is_a?(Hash)
+
Bank.new(self.class::BANK_CASH, log: @log)
end
+ def init_cert_limit
+ return self.class::CERT_LIMIT[play... | [Base->[current_entity->[current_entity],trains->[trains],process_action->[process_action],end_game->[format_currency],inspect->[title],rollback->[clone]]] | Initializes the object variables related to a sequence of Banks Phases and Auctions. | it might just be cleaner to do cash = self.class::BANK_CASH cash = cash[players.size] if cash.is_a?(Hash) |
@@ -327,7 +327,8 @@ public class ServerGroupManager {
validateAccessCredentials(loggedInUser, sg, sg.getName());
validateAdminCredentials(loggedInUser);
- SystemManager.addServersToServerGroup(servers, sg);
+ SystemManager systemManager = new SystemManager(ServerFactory.SINGLETON, Serv... | [ServerGroupManager->[dissociateAdmins->[validateAdminCredentials,remove,validateAccessCredentials],associateAdmins->[validateAdminCredentials,validateAccessCredentials],lookupEntitled->[lookupEntitled],listAdministrators->[listAdministrators,validateAdminCredentials,validateAccessCredentials],create->[validateAdminCre... | Adds a collection of servers to a server group. | this system manager should not be passed as a class field instead of being created on each method invocation? |
@@ -1133,7 +1133,6 @@ class FreqtradeBot(LoggingMixin):
Buy cancel - cancel order
:return: True if order was fully cancelled
"""
- # TODO-lev: Pay back borrowed/interest and transfer back on leveraged trades
was_trade_fully_canceled = False
# Cancelled orders may ha... | [FreqtradeBot->[cleanup->[cleanup],fee_detection_from_trades->[apply_fee_conditional],execute_trade_exit->[handle_insufficient_funds,_safe_exit_amount],execute_entry->[leverage_prep,update],_safe_exit_amount->[update],handle_cancel_enter->[_notify_enter_cancel,update],handle_cancel_exit->[update],get_real_amount->[appl... | Handle cancel enter. This function is called when the order is fully cancelled. | Created a trello task with the margin label |
@@ -310,9 +310,17 @@ module.exports = class bitcoincoid extends Exchange {
}
async cancelOrder (id, symbol = undefined, params = {}) {
+ if (!symbol)
+ throw new ExchangeError (this.id + ' cancelOrder requires a symbol argument');
+ if ('side' in params)
+ if (!params['si... | [No CFG could be retrieved] | Create a new order on a given symbol Get a single from the API. | One single comma missing at the end of this line to satisfy the syntax checkers. UPD: Ah, nvm, it's ok )) |
@@ -1264,7 +1264,7 @@ public class MovePanel extends AbstractMovePanel {
// is the only one for
// which the route may actually change much)
if (unitsThatCanMoveOnRoute.size() < selectedUnits.size() && (unitsThatCanMoveOnRoute.size() == 0
- || Match.allMatchNotEmpty... | [MovePanel->[updateUnitsThatCanMoveOnRoute->[sortUnitsToMove],cancelMoveAction->[updateRouteAndMouseShadowUnits,setFirstSelectedTerritory,setSelectedEndpointTerritory],getRouteForced->[getRoute],getUnitsToUnload->[sortTransportsToUnload,sortUnitsToMove],getRouteNonForced->[getUnitOwner],deselectUnits->[updateRouteAndMo... | Called when the user mouses the mouse. | Parentheses are not required here, but it may make it easier to read due to the `||`. |
@@ -64,7 +64,7 @@ func (l *zapLogger) Named(name string) Logger {
func (l *zapLogger) NewRootLogger(lvl zapcore.Level) (Logger, error) {
newLogger := *l
- newLogger.config.Level = zap.NewAtomicLevelAt(lvl)
+ newLogger.config.LogLevel = lvl
zl, err := newLogger.config.Build()
if err != nil {
return nil, err
| [Sync->[Sync],NewRootLogger->[With,Named],Named->[Named],ErrorIfClosing->[Helper],With->[With],ErrorIf->[Helper]] | NewRootLogger creates a new Logger that will log to the root logger. | It looks like `l` and `newLogger` point to the same config here now? |
@@ -268,14 +268,15 @@ def _resnet(arch, Block, depth, pretrained, **kwargs):
def resnet18(pretrained=False, **kwargs):
- """ResNet 18-layer model
-
+ """ResNet 18-layer model from
+ `"Deep Residual Learning for Image Recognition" <https://arxiv.org/pdf/1512.03385.pdf>`_
+
Args:
pretraine... | [resnet50->[_resnet],resnet152->[_resnet],resnet101->[_resnet],resnet34->[_resnet],resnet18->[_resnet],_resnet->[ResNet]] | ResNet 18 - layer model with pre - trained weight on ImageNet . | .. code-block import bug ~ |
@@ -148,6 +148,8 @@ public class DubboBootstrap {
private final AtomicBoolean awaited = new AtomicBoolean(false);
+ private volatile BootstrapTakeoverState bootstrapTakeoverState = BootstrapTakeoverState.AUTO;
+
private final Lock lock = new ReentrantLock();
private final Condition condition = l... | [DubboBootstrap->[await->[await],clearConfigs->[destroy],destroy->[unexportServices,unreferServices,unexportMetadataService,unregisterServiceInstance],onStop->[onStop],service->[service],shutdown->[shutdown,isShutdown],reset->[reset],getMetadataType->[getMetadataType],protocol->[protocol],start->[start,initialize,isOnl... | This class is designed to be used to create a singleton Dubbo object. | Use a short name? `private volatile BootstrapTakeoverState takeoverState = BootstrapTakeoverState.AUTO;` |
@@ -1649,9 +1649,9 @@ static int dmic_remove(struct dai *dai)
interrupt_unregister(dmic->irq, dai);
/* The next end tasks must be passed if another DAI FIFO still runs */
- dai_info(dai, "dmic_remove(), dmic_active_fifos_mask = 0x%x",
- uncached_dmic_active_fifos_mask);
- if (uncached_dmic_active_fifos_mask)
+ ... | [No CFG could be retrieved] | Initialize DMIC start sequence handler Get the offset of the DMIC FIFO in the SOF DAO. | This is really problematic. There's no actual reference counting in cavs_pm_runtime_dis_dmic_clk_gating() and the "dai->index" passed to pm_runtime_put_sync() is just printed out. The problem is that if we switch to pm_runtime_put_sync() that actual does refcounting, this code will break. FYI @lgirdwood @lyakh @marc-hb... |
@@ -160,9 +160,8 @@ public final class ReferenceMatcher {
Set<HelperReferenceWrapper.Method> plainMethods = new HashSet<>();
collectMethodsFromTypeHierarchy(helperWrapper, abstractMethods, plainMethods);
- Set<HelperReferenceWrapper.Method> unimplementedMethods =
- Sets.difference(abstractMethods,... | [ReferenceMatcher->[findMethod->[findMethod],checkThirdPartyTypeMatch->[matches],findField->[findField,matchesPrimitive],collectMethodsFromTypeHierarchy->[collectMethodsFromTypeHierarchy]]] | Checks if a helper class matches a given type pool. | I think there is a change of behaviour here: in the new version you mutate `abstractMethods`, the old version did not that, did it? |
@@ -911,7 +911,7 @@ class Assignment < ApplicationRecord
end
def create_peer_review_assignment_if_not_exist
- if has_peer_review and Assignment.where(parent_assignment_id: id).empty?
+ if assignment_properties.has_peer_review && Assignment.where(parent_assignment_id: id).empty?
peerreview_assignmen... | [Assignment->[summary_json->[group_by],get_marks_list->[max_mark],group_by->[group_assignment?],current_submission_data->[group_by],average_annotations->[get_num_marked,get_num_annotations],percentage_grades_array->[calculate_total_percent],get_num_marked->[is_criteria_mark?,get_num_assigned],summary_csv->[max_mark],pa... | create a new peerreview assignment if the record doesn t already exist. | Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression. |
@@ -18,10 +18,10 @@
mock_client: (DocAuthRouter.doc_auth_vendor == 'mock').presence,
document_capture_session_uuid: flow_session[:document_capture_session_uuid],
endpoint: FeatureManagement.document_capture_async_uploads_enabled? ?
- idv_doc_auth_step_path(step: :verify_document) :
+ send(@step_url, step... | [No CFG could be retrieved] | Renders a list of tags that can be used to verify a document. Renders the object. | reason this is needed: In the non-hybrid flow, we link to `/idv/doc_auth` etc endpoints. However, in the hybrid flow, the mobile path hits `/idv/capture_doc/` versions of the corresponding endpoints, so this needed to be updated to be dynamic based on the flow |
@@ -14,6 +14,7 @@ import static org.junit.Assert.assertThat;
import static org.junit.Assert.fail;
import static org.mule.extension.validation.internal.ImmutableValidationResult.error;
import static org.mule.extension.validation.internal.ValidationExtension.DEFAULT_LOCALE;
+
import org.mule.api.MuleEvent;
import or... | [BasicValidationTestCase->[email->[assertValid,assertInvalidEmail,getTestEvent],getTimeEvent->[getTestEvent,setFlowVariable],isFalse->[failedBooleanValidation,assertValid,assertInvalid,getTestEvent],size->[assertSize,asList,put],TestCustomValidator->[validate->[error]],assertCustomValidator->[getMessage,assertThat,getR... | Creates a new validation test case using the CPAL specification. Test if the ip is in the list of valid IPs. | remove empty line |
@@ -131,6 +131,10 @@ T_RequestMonitoring = TypeVar(
bound='raiden.messages.RequestMonitoring',
)
+T_UpdatePFS = TypeVar(
+ 'T_UpdatePFS',
+ bound='raiden.messages.UpdatePFS',
+)
T_TransactionHash = bytes
TransactionHash = NewType('TransactionHash', T_TransactionHash)
| [NewType,TypeVar] | Create a type for the next block of signature. | There's no need to introduce a type for every class we introduce. |
@@ -48,14 +48,6 @@ module ApplicationHelper
(sp_session[:issuer].blank? || sp_session[:ial2_strict])
end
- def sign_up_or_idv_no_js_link
- if user_signing_up?
- destroy_user_path
- elsif user_verifying_identity?
- idv_doc_auth_url
- end
- end
-
def cancel_link_text
if user_signi... | [cancel_link_text->[user_signing_up?],sign_up_or_idv_no_js_link->[user_verifying_identity?,user_signing_up?],liveness_checking_enabled?->[liveness_checking_enabled?]] | Check if there is a nexus node in the system that can be used to perform l. | With this removal, `user_verifying_identity?` may now be unused as well? |
@@ -1149,9 +1149,11 @@ class TestMasksToBoxes:
class TestStochasticDepth:
+ @pytest.mark.parametrize("seed", range(10))
@pytest.mark.parametrize("p", [0.2, 0.5, 0.8])
@pytest.mark.parametrize("mode", ["batch", "row"])
- def test_stochastic_depth(self, mode, p):
+ def test_stochastic_depth_random... | [TestPSRoIPool->[expected_fn->[get_slice],test_boxes_shape->[_helper_boxes_shape]],TestBoxIou->[test_iou->[iou_check]],TestMasksToBoxes->[test_masks_box->[masks_box_check,_create_masks,_get_image]],TestBoxArea->[test_box_area->[area_check]],TestDeformConv->[test_forward->[get_fn_args,expected_fn],test_backward->[script... | Test the stochastic depth. | We maintain the original test because it allows us to check that the different `mode` values operate as expected. Using p values in the interval (0, 1) is critical because for p=0 and p=1 the two modes behave the same. The mitigation for the flakiness here is to set the seed. |
@@ -171,8 +171,11 @@ export class AmpConsent extends AMP.BaseElement {
() => this.handleAction_(ACTION_TYPE.DISMISS));
this.registerAction('prompt', invocation => {
const args = invocation.args;
- const consentId = args && args['consent'];
- this.handlePostPrompt_(consentId);
+ let c... | [No CFG could be retrieved] | Registers user action functions that can be invoked by the consent policy manager. If consent UI is not available register it. | This is just getting a random key, rather than the first. Is that ok? |
@@ -33,7 +33,7 @@ namespace System.Text.Json.Serialization
Type type = typeof(T);
Debug.Assert(!type.IsAbstract);
- Debug.Assert(type.GetConstructors(BindingFlags.Public | BindingFlags.Instance).Contains(constructor));
+ Debug.Assert(Array.IndexOf(type.GetConstructors(B... | [ReflectionMemberAccessor->[CreateAddMethodDelegate->[Invoke,ObjectType,GetMethod],CreateImmutableEnumerableCreateRangeDelegate->[GetImmutableEnumerableCreateRangeMethod,CreateDelegate],CreateImmutableDictionaryCreateRangeDelegate->[CreateDelegate,GetImmutableDictionaryCreateRangeMethod],CreatePropertyGetter->[Invoke,G... | Creates a parameterized constructor that can be called with the given arguments. | @stephentoub why don't we have an `Array.Contains` helper for this scenario? Could `Array.Exists` be used here with some predicate, or is that not worth it. |
@@ -305,11 +305,14 @@ public class BytecodeVisitor extends ClassVisitor {
if (bytecodeNames == null) {
return ImmutableList.of();
}
- ImmutableList.Builder<JavaType> types = ImmutableList.builder();
+ List<JavaType> types = new ArrayList<>();
for (String bytecodeName : bytecodeNames) {
- ... | [BytecodeVisitor->[defineOuterClass->[getClassSymbol],getCompletedClassSymbolsType->[getClassSymbol],convertAsmType->[getClassSymbol,convertAsmType],ReadGenericSignature->[boundVisitor->[visitEnd->[visitEnd]],visitClassType->[getClassSymbol],visitSuperclass->[visitEnd->[visitEnd]],visitInterface->[visitEnd->[visitEnd]]... | Returns the complete list of class symbols type. | We should not remove unknown exception types, or we will fail on replacing thrown types later with `IndexOutOfBoundExceptions`. |
@@ -71,6 +71,17 @@ public class DefaultHostListener implements HypervisorHostListener {
assert (answer instanceof ModifyStoragePoolAnswer) : "Well, now why won't you actually return the ModifyStoragePoolAnswer when it's ModifyStoragePoolCommand? Pool=" +
pool.getId() + "Host=" + hostId;
M... | [DefaultHostListener->[hostConnect->[getCapacityBytes,getResult,setUsedBytes,info,setLocalPath,getDataCenterId,replaceAll,getDataStore,getDetails,CloudRuntimeException,StoragePoolHostVO,setCapacityBytes,findByPoolHost,getAvailableBytes,persist,update,sendAlert,getPodId,easySend,ModifyStoragePoolCommand,findById,getId],... | Connect to a host return true if host is not found. | Might want to put a space after the colon for readability. |
@@ -226,9 +226,11 @@ module.exports = {
sameWalletAsInvoiceError: 'Você não pode pagar uma fatura com a mesma carteira que a criou.',
},
pleasebackup: {
- title: 'Your wallet is created...',
+ title: 'Sua carteira foi criada...',
text:
- "Please take a moment to write down this mnemonic phras... | [No CFG could be retrieved] | Você não pagar uma fatura com a mes. | there's an error in "sequencia", no? |
@@ -359,7 +359,7 @@ func (d *Dispatcher) configIso(conf *config.VirtualContainerHostConfigSpec, vm *
log.Errorf("Failed to create Cdrom device for appliance: %s", err)
return nil, err
}
- cdrom = devices.InsertIso(cdrom, fmt.Sprintf("[%s] %s/appliance.iso", conf.ImageStores[0].Host, d.vmPathName))
+ cdrom = dev... | [createAppliance->[createApplianceSpec,GenerateExtensionName],createApplianceSpec->[addIDEController,addNetworkDevices,addParaVirtualSCSIController],makeSureApplianceRuns->[waitForKey,applianceConfiguration],reconfigureApplianceSpec->[configIso],checkExistence->[isVCH]] | configIso creates a virtual machine with the specified configuration. create a new virtual machine in the system settings. Extension = types. Extension This function is called by the init function of the virtual machine. | Should we be using the actual path of the appliance VM rather than composing in this fashion. It'll currently work because we use ImageStores[0] as the applianceVM datastore, but if that ever changes then this will break. |
@@ -11,6 +11,7 @@ $yoast_seo_block_title = sprintf( __( '%1$s Recipe', 'wordpress-seo' ), 'Yoast'
$yoast_seo_block_template = [
[ 'yoast/recipe-name' ],
[ 'core/image' ],
+ [ 'yoast/recipe-description' ],
[ 'yoast/ingredients' ],
[ 'yoast/steps' ],
];
| [No CFG could be retrieved] | Yoast Recipe block template. Yoast Seo Block. | The two functions in line 9 should also be preceded by `\`. |
@@ -1373,13 +1373,13 @@ namespace ProtoCore
protected void Backpatch(int bp, int pc)
{
if (ProtoCore.DSASM.OpCode.JMP == codeBlock.instrStream.instrList[bp].opCode
- && ProtoCore.DSASM.AddressType.LabelIndex == codeBlock.instrStream.instrList[bp].op1.optype)
+ ... | [CodeGen->[EmitJgz->[GetDebugObject],DFSGetSymbolList->[DFSGetSymbolList],EmitThrow->[AppendInstruction,SetEntry],EmitBounceIntrinsic->[SetEntry],EmitAlloc->[SetEntry],EmitPopString->[SetEntry],EmitPushReplicationGuide->[SetEntry],DFSGetSymbolList_Simple->[DFSGetSymbolList_Simple],EmitJlz->[GetDebugObject],EmitPushArra... | Backpatch method. | Can you remind me why we decided to use methods here, not properties? I seem to remember discussing this, but I don't remember the outcome |
@@ -63,6 +63,9 @@ public abstract class MessageProducerSupport extends AbstractEndpoint implements
@Override
protected void onInit() {
Assert.notNull(this.outputChannel, "outputChannel is required");
+ if (this.getBeanFactory() != null) {
+ this.messagingTemplate.setBeanFactory(this.getBeanFactory());
+ }
... | [MessageProducerSupport->[setSendTimeout->[setSendTimeout]]] | On init. | We don't really need it here because `MPS` only send()s messages. But I guess it doesn't hurt. |
@@ -190,6 +190,8 @@ OSSL_PROVIDER *ossl_provider_new(OPENSSL_CTX *libctx, const char *name,
if (prov == NULL)
CRYPTOerr(CRYPTO_F_OSSL_PROVIDER_NEW, ERR_R_MALLOC_FAILURE);
+ else
+ prov->store = store;
/*
* At this point, the provider is only partially "loaded". To be
| [No CFG could be retrieved] | Returns a provider object that can be used to provide the given name. Frees the given OSSL_PROVIDER object. | Shouldn't this happen inside the lock since prov is already pushed into the store? |
@@ -49,9 +49,9 @@ namespace System.Data.OleDb
public override object? ExecuteScalar() { throw null; }
public override void Prepare() { }
public void ResetCommandTimeout() { }
- System.Data.IDataReader System.Data.IDbCommand.ExecuteReader() { throw null; }
- System.Data.IDataRead... | [OleDbParameter->[All],OleDbConnection->[Hidden,All],OleDbException->[Content],OleDbParameterCollection->[Hidden],OleDbCommand->[All,Both,Content,Hidden,Text],OleDbConnectionStringBuilder->[All]] | Method to prepare the command. | Was this just a missed auto-gen the ref code from a previous commit? |
@@ -623,12 +623,14 @@ def new_document(request):
'show_toc': True
})
+ allow_add_attachment = Attachment.objects.allow_add_attachment_by(request.user)
return jingo.render(request, 'wiki/new_document.html',
{'is_template': is_template,
... | [edit_document->[_join_slug,_split_slug,_format_attachment_obj],mindtouch_to_kuma_redirect->[mindtouch_namespace_redirect],new_attachment->[_format_attachment_obj],_version_groups->[split_slug],translate->[_join_slug,_split_slug],document->[set_common_headers,get_seo_description,_split_slug,_format_attachment_obj],_ver... | Create a new wiki document. Adds a new to the document. | nit: our view methods seem to accumulate more ad-hoc context var's over time. is it possible to create a `@attachment_permission` decorator that will automatically add this? |
@@ -627,6 +627,11 @@ class TypeChecker(NodeVisitor[None]):
if has_any_from_unimported_type(arg_type):
prefix = "Argument {} to \"{}\"".format(idx + 1, fdef.name())
self.msg.unimported_type_becomes_any(prefix, arg_... | [TypeChecker->[analyze_async_iterable_item_type->[accept],visit_try_without_finally->[check_assignment,accept],visit_class_def->[accept],iterable_item_type->[lookup_typeinfo],visit_for_stmt->[accept_loop],visit_operator_assignment_stmt->[check_assignment,accept],check_return_stmt->[get_generator_return_type,accept],vis... | Type check a function definition. Check that return type is not imported from any function. Add a to the function definition. Check if the type of self is missing for a non - static method or a class method Check if a function return a . | This same piece of code gets repeated almost identically many times. Can you refactor this into a function or a few functions? |
@@ -162,7 +162,7 @@ class DistributedAdam(DistributedOptimizerImplBase):
opt_info["fleet_desc"] = ps_param
opt_info["worker_skipped_ops"] = worker_skipped_ops
opt_info["use_cvm"] = strategy.get("use_cvm", False)
-
+ opt_info["dump_slot"] = True
for loss in losses:
... | [DistributedAdam->[__init__->[super],_minimize->[add_data_norm_table,add_dense_table,DownpourServer,PSParameter,Merge,get_desc,extend,find_distributed_lookup_table_inputs,i,program_configs,range,find_distributed_lookup_table_outputs,append,add_sparse_table,DownpourWorker,len,sorted,read,open,id,find_distributed_lookup_... | Minimizes the given by using a distributed optimizer. Adds the necessary tables to the network. Adds a dense table to the model and outputs the necessary parameters. | why dump_slot is default true and user can not set it from strategy ? what if a user doesn't need dump_slot |
@@ -301,7 +301,8 @@ func (s *APIServer) RegisterContainersHandlers(r *mux.Router) error {
// - in: query
// name: detachKeys
// type: string
- // description: needs description
+ // description: "Override the key sequence for detaching a container. Format is a single character [a-Z] or ctrl-<value> w... | [RegisterContainersHandlers->[HandleFunc,Methods]] | RegisterContainersHandlers registers the http handlers for the containers API swagger - specification This function returns a description of a container. swagger - operation GET - containers swagger - specification - specification - description This function allows you to start a container with a timeout before sending... | The value of description should not be quoted. |
@@ -91,8 +91,15 @@ dfuse_cb_create(fuse_req_t req, struct dfuse_inode_entry *parent,
oh->doh_dfs = parent->ie_dfs->dfs_ns;
oh->doh_ie = ie;
- if (fi->direct_io)
- fi_out.direct_io = 1;
+ if (!fs_handle->dpi_info->di_no_direct_io) {
+ if (parent->ie_dfs->dfs_attr_timeout == 0) {
+ fi_out.direct_io = 1;
+ } el... | [dfuse_cb_create->[D_GOTO,dfs_ostat,LOG_FLAGS,dfs_dup,DFUSE_REPLY_ERR_RAW,DFUSE_TRA_UP,D_FREE,dfuse_reply_entry,DFUSE_TRA_INFO,LOG_MODES,DFUSE_TRA_DEBUG,dfs_release,dfs_open,fuse_req_userdata,strncpy,atomic_fetch_add,D_ALLOC_PTR]] | Private function to handle the creation of a node node. open a fuse handle for a file return the new inode data and keep the parent ref. | Just a minor nit. This would read nicer if it were positive rather than a double negative e.g. if (fs_handle->dpi_info->di_direct_io) so it would require changing the option parsing above |
@@ -42,11 +42,15 @@ class Jetpack_Autoupdate {
add_action( 'shutdown', array( $this, 'log_results' ) );
}
- // Anytime WordPress saves update data, we'll want to update our Jetpack option as well.
if ( is_main_site() ) {
+ // Anytime WordPress saves update data, we'll want to update our Jetpack option as... | [Jetpack_Autoupdate->[autoupdate_theme->[expect],log_results->[log,do_stats,log_items],autoupdate_plugin->[expect],log_items->[get_error_message,get_successful_updates,query,stat]]] | This method is called by the Jetpack plugin when a user is opted in. | Good idea :) but this won't work as `blog_token` is stored inside the option `jetpack_private_options`. I would add a new hook `do_action( 'jetpack_site_registered' )` to the `register` method inside `class.jetpack.php`. It could be useful in the future! |
@@ -68,6 +68,8 @@ public class StickyTest {
invokers.add(invoker2);
clusterinvoker = new StickyClusterInvoker<StickyTest>(dic);
+
+ ExtensionLoader.resetExtensionLoader(LoadBalance.class);
}
@Test
| [StickyTest->[testMethodStickyNoCheck->[testSticky,assertTrue,println],StickyClusterInvoker->[doInvoke->[select]],testStickyForceCheck->[testSticky,assertTrue],testSticky->[getSelectedInvoker,setPort,willReturn,invoke,setMethodName,addParameter,assertEquals,valueOf],testMethodStickyForceCheck->[testSticky,assertTrue],t... | This method is called before any other test. | I am not convinced either. Why we need to reset extension loader here? |
@@ -363,7 +363,11 @@ public class ReferenceCountedOpenSslEngine extends SSLEngine implements Referenc
// setMode may impact the overhead.
calculateMaxWrapOverhead();
} catch (Throwable cause) {
- SSL.freeSSL(ssl);
+ // Call shutdown so we are ... | [ReferenceCountedOpenSslEngine->[getSSLParameters->[getSSLParameters],needPendingStatus->[isOutboundDone,isInboundDone],retain->[retain],sslReadErrorResult->[shutdownWithError],getOcspResponse->[getOcspResponse],wrap->[release,writePlaintextData,isBytesAvailableEnoughForWrap,wrap,resetSingleSrcBuffer,singleSrcBuffer],c... | Sets the OCSP response. Gets the OCSP response. | @normanmaurer I thought the reference counted openssl engine didn't use a finalizer? |
@@ -433,7 +433,7 @@ class StorageTableClientTest(TableTestCase):
tables = list(service.list_tables(raw_response_hook=callback))
self.assertIsInstance(tables, list)
- # @pytest.mark.skip("pending")
+ @pytest.mark.skip("pending")
@GlobalStorageAccountPreparer()
def test_user_agent_cust... | [StorageTableClientTest->[test_create_service_protocol->[validate_standard_account_endpoints],test_create_service_with_connection_string->[validate_standard_account_endpoints],test_create_service_with_socket_timeout->[validate_standard_account_endpoints],test_create_service_with_key->[validate_standard_account_endpoint... | Test user agent for default storage account. | Is there a reason this one is skipped? |
@@ -231,11 +231,11 @@ module.exports = function (grunt) {
ngtemplates: {
dist: {
cwd: 'src/main/webapp',
- src: ['scripts/app/**/*.html', 'scripts/components/**/*.html',],
+ src: ['app/app/**/*.html', 'app/components/**/*.html',],
... | [No CFG could be retrieved] | Yeoman s config. js JS app. js. | Shouldn't one app be removed from app/app |
@@ -2153,6 +2153,7 @@ static void _manage_editor_save(dt_lib_module_t *self)
// update the preset in the database
dt_lib_presets_update(d->edit_preset, self->plugin_name, self->version(), newname, "", params, strlen(params));
g_free(params);
+ d->edit_preset = g_strdup(newname);
// if name has changed, w... | [No CFG could be retrieved] | This function is called when the user enters the group editor. It is called when the remove a module from the modules list. | don't we need to free d->edit_preset first ? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.