patch
stringlengths
18
160k
callgraph
stringlengths
4
179k
summary
stringlengths
4
947
msg
stringlengths
6
3.42k
@@ -89,11 +89,15 @@ function createProviders(networkIds) { } // Private key takes precedence if (privateKey) { - console.log(`Network=${networkId} URL=${providerUrl} Using private key`) + if (process.env.NODE_ENV !== 'test') { + console.log(`Network=${networkId} URL=${providerUrl} Using ...
[No CFG could be retrieved]
Create a Provider for the given network id.
Not in this PR but we should decouple the transfer tool from the faucet. Perhaps a shared `origin-utils` npm package where we put common utilities could be a way to go.
@@ -274,7 +274,14 @@ public class ConfigurationKeys { * Configuration properties for the data publisher. */ public static final String DATA_PUBLISHER_PREFIX = "data.publisher"; + + /** + * @deprecated Use {@link #TASK_DATA_PUBLISHER_TYPE} and {@link #JOB_DATA_PUBLISHER_TYPE}. + */ + @Deprecated publ...
[ConfigurationKeys->[name,toString,toMillis]]
region > create methods for the class region Configuration properties.
Can you switch the order of `task.` and `DATA_PUBLISHER_PREFIX`, otherwise its not really a prefix. Same for the the `job` param above.
@@ -1,3 +1,4 @@ +# -*- coding: utf-8 -*- # Copyright 2013-2020 Lawrence Livermore National Security, LLC and other # Spack Project Developers. See the top-level COPYRIGHT file for details. #
[Coreutils->[version]]
Creates a new object.
This change probably isn't necessary.
@@ -1,13 +1,14 @@ """Manages source control systems (e.g. Git).""" -from dvc.scm.base import Base +from dvc.scm.base import Base, NoSCMError from dvc.scm.git import Git # Syntactic sugar to signal that this is an actual implementation for a DVC # project under no SCM control. class NoSCM(Base): - pass + ...
[SCM->[NoSCM,Git]]
Returns a SCM instance that corresponds to a repository at the specified path.
A bit worried about this being too radical of a change, as it might be used somewhere. But no tests failed and I don't see any obvious issues right now, so let's try and see. :+1:
@@ -51,11 +51,11 @@ class ValueLogger(): # -------------------------------------------------------------------------- def GetValue( self, key, iteration ): - return self.value_history[key][iteration] + return self.history[key][iteration] # -----------------------------------------------...
[ValueLogger->[__IsFirstLog->[keys],__CreateCompleteLogFileName->[optimization_settings,join],__LogAdditionalValuesToHistory->[__IsFirstLog,items],__LogObjectiveValuesToHistory->[getValue,specified_objectives,__IsFirstLog,print,getStandardizedValue,abs],LogCurrentValues->[_WriteCurrentValuesToConsole,__LogValuesToHisto...
Get the value of a key in the model.
The name `GetValue` and `GetValueHistory` are now a little bit misleading because you can get other things then the value as well, e.g. the relative change. Not a big issue though
@@ -65,6 +65,11 @@ module Api render "show", status: :ok end + def me + # Is pagination required? + @articles = @user.articles.order("published_at DESC").decorate + end + private def article_params
[ArticlesController->[create->[url,create!,render],show->[decorate,includes],allowed_to_change_org_id?->[nil?,exists?,user,any_admin?,org_admin?],article_params->[permit,allowed_to_change_org_id?],update->[call,render],onboarding->[split,new,present?,get,each,sample],index->[set_surrogate_key_header,get,join],permit!,r...
Updates the nag - commit tag.
Yes, it's always a good idea :-) You never know how many articles a person might have in the future.
@@ -1318,12 +1318,11 @@ def batched_span_select(target: torch.Tensor, spans: torch.LongTensor) -> torch. # inclusive, so we want to include indices which are equal to span_widths rather # than using it as a non-inclusive upper bound. span_mask = max_span_range_indices <= span_widths - raw_span_indices...
[has_tensor->[has_tensor],masked_topk->[get_mask_from_sequence_lengths,replace_masked_values],_get_combination->[_get_combination],flatten_and_batch_shift_indices->[get_device_of],batched_index_select->[flatten_and_batch_shift_indices],max_value_of_dtype->[info_value_of_dtype],add_positional_features->[get_range_vector...
Batched span select. Returns the embeddings and mask of the missing - block block in the batch.
This sentence is truncated?
@@ -332,6 +332,17 @@ dss_nvme_poll_ult(void *args) D_ASSERT(dx->dx_main_xs); while (!dss_xstream_exiting(dx)) { + uint64_t now = 0; + + daos_gettime_coarse(&now); + if (dmi->dmi_last_nvme_poll_time == 0) { + dmi->dmi_last_nvme_poll_time = now; + } else if (dmi->dmi_last_nvme_poll_time + + PROGRESS_MESG...
[No CFG could be retrieved]
dss_nvme_poll_ult - Poll all other ULTs ULT wait all ULTs in the current thread.
(style) Comparisons should place the constant on the right side of the test
@@ -99,5 +99,4 @@ Registrable._registry[Activation] = { "softsign": (torch.nn.Softsign, None), "tanhshrink": (torch.nn.Tanhshrink, None), "selu": (torch.nn.SELU, None), - "gelu": (torch.nn.GELU, None), }
[_ActivationLambda->[forward->[_func],__init__->[super]],tanh,sigmoid,_ActivationLambda,softplus]
Replies the sequence of all the network interfaces that are supported by the network.
Why remove this?
@@ -0,0 +1,10 @@ +module Payments + class PaymentsError < StandardError + end + + class InvalidRequestError < PaymentsError + end + + class CardError < PaymentsError + end +end
[No CFG could be retrieved]
No Summary Found.
Using custom exceptions to avoid exposing Stripe's to the controller. In case in the future we'll have more than one payment system but also generally to separate responsibilities
@@ -146,7 +146,7 @@ export class AmpLiveList extends AMP.BaseElement { /** @private {boolean} */ this.isReverseOrder_ = false; - /** @private @const {!Object<string, string>} */ + /** @private @const {!Object<string, number>} */ this.knownItems_ = Object.create(null); /** @private @const {...
[No CFG could be retrieved]
Component class that handles updates to the underlying children dom. Count of items we treat as active.
technically this should be `time` instead of `number`
@@ -6,10 +6,10 @@ { public bool SupportsDtc => false; public bool SupportsCrossQueueTransactions => true; - public bool SupportsNativePubSub => true; + public bool SupportsNativePubSub => false; public bool SupportsNativeDeferral => true; public bool SupportsOutbox...
[No CFG could be retrieved]
Configure the transport and persistence configuration for the test execution.
this change is for testing purposes and needs to be reverted again, but we can't test MDPS with the acceptance tests in core otherwise
@@ -645,15 +645,10 @@ func main() { for { select { case sig := <-osSignal: - if sig == os.Kill || sig == syscall.SIGTERM { + if sig == os.Kill || sig == syscall.SIGTERM || sig == os.Interrupt { fmt.Printf("Got %s signal. Gracefully shutting down...\n", sig) currentNode.ShutDown() } - ...
[Warn,LastCommitBitmap,SerializeToHexStr,Info,RunServices,GetMetricsFlag,WriteLastCommits,Rollback,SetShardIDProvider,Stop,ReadFile,Serialize,SupportSyncing,GetMemProfiling,New,GetLogInstance,Bool,SetBeaconGroupID,FindAccount,GetHandler,Split,Seed,UpdateConsensusInformation,Network,FatalErrMsg,Println,SetPushgatewayIP,...
osSignal is a channel that notifies the goroutine that the process is going to be killed and.
Very little time available in interrupt , do the print after
@@ -48,7 +48,7 @@ module BootstrapFormHelper end res << "<input type='datetime' class='form-control' name='#{input_name}' id='#{id}' readonly data-ts='#{timestamp}' />" if options[:clear] then - res << "<span class='input-group-addon' id='#{id}_clear'><span class='glyphicon glyphicon-remove'...
[color_picker_btn_group->[html_safe,to_s,humanize,each_with_index],datetime_picker->[to_s,to_i,html_safe,humanize,t],tiny_mce_editor->[text_area,merge!],smart_text_area->[nil?,join,text_area,try,delete],color_picker_select->[each,html_safe,to_s],enum_btn_group->[send,to_s,new,pluralize,humanize,collect,each,html_safe]]
date timepicker datetimepicker end of method show_missing.
Metrics/LineLength: Line is too long. [113/80]
@@ -158,9 +158,12 @@ class CI_DB_sqlsrv_driver extends CI_DB { function _execute($sql) { $sql = $this->_prep_query($sql); + if(stripos($sql,'UPDATE') !== FALSE || stripos($sql,'INSERT') !== FALSE) { + return sqlsrv_query($this->conn_id, $sql, null, array()); + } return sqlsrv_query($this->conn_id, $sql, n...
[CI_DB_sqlsrv_driver->[_update->[_escape_table],db_pconnect->[db_connect],_insert->[_escape_table],_delete->[_escape_table]]]
Execute a query and return the number of rows affected.
Please follow the CodeIgniter style guide. `if(` should be `if (` and the `{` needs to be on a new line.
@@ -362,10 +362,7 @@ public abstract class LazyBuildMixIn<JobT extends Job<JobT,RunT> & Queue.Task & if (r == null) { // having two neighbors pointing to each other is important to make RunMap.removeValue work - JobT _parent = asRun().getParent(); - ...
[LazyBuildMixIn->[RunMixIn->[getPreviousBuild->[none,createReference,getRunMixIn,asRun],createReference->[asRun],dropLinks->[getRunMixIn],getNextBuild->[none,createReference,getRunMixIn,asRun]],ItemListenerImpl->[onLocationChanged->[getLazyBuildMixIn]],_getRuns->[asJob],onLoad->[asJob],createHistoryWidget->[asJob],load...
Returns the previous build of this job.
A more direct way of expressing the same concept that also aids the static analyzer.
@@ -6,9 +6,11 @@ JobRunner::Runner.add_config JobRunner::JobConfiguration.new( name: 'Send GPO letter', interval: 24 * 60 * 60, timeout: 300, - callback: lambda { + callback: lambda do + UspsDailyTestSender.new.run + UspsConfirmationUploader.new.run unless CalendarService.weekend_or_holiday?(Time.zon...
[call,new,weekend_or_holiday?,today,require,run,lambda,add_config]
Add configuration for a specific Send Agency User Counts Report to S3.
It seemed easier to add this step to the existing daily job, rather than worry about race conditions across multiple daily jobs? I did add the top-level rescue to minimize the chances that this job will break the actual upload run
@@ -3,7 +3,7 @@ // --------------------------------------------------------------------------- const Exchange = require ('./base/Exchange'); -const { ExchangeError, ArgumentsRequired, ExchangeNotAvailable, InsufficientFunds, OrderNotFound, InvalidOrder, AccountSuspended, InvalidNonce, NotSupported, BadRequest, Auth...
[No CFG could be retrieved]
Provides a base class for a KuCoin exchange. Return a boolean indicating if the Kucoin API is able to retrieve the status of the.
is it possible to move all the edits related to kucoinfutures into the new exchange class kucoinfutures? would make this much easier to merge
@@ -125,8 +125,8 @@ public class ModuleOperationMessageProcessorChainBuilder extends ExplicitMessage if (!returnsVoid) { return from(publisher) .concatMap(request -> just(request) - .map(event -> createEventWithParameters(event)) - .transform(s -> super.apply(s...
[ModuleOperationMessageProcessorChainBuilder->[ModuleOperationProcessorChain->[addMessageProcessorPathElements->[addMessageProcessorPathElements],doProcess->[doProcess]]]]
Override to return a sequence of events that can be delivered to the server.
The whole message needs to go as value for the target variable, not just the payload
@@ -55,7 +55,7 @@ def qrs_detector(sfreq, ecg, thresh_value=0.6, levels=2.5, n_thresh=3, filtecg = filter_data(ecg, sfreq, l_freq, h_freq, None, filter_length, 0.5, 0.5, phase='zero-double', fir_window='hann', - fir_design='firwin2') + ...
[find_ecg_events->[qrs_detector],create_ecg_epochs->[find_ecg_events]]
QRS component in ECG channels. This function tries to find the best threshold for a given threshold value. Get the index of the first non - zero element in the clean_events array.
No need to do this based on how `verbose` works
@@ -294,6 +294,12 @@ func (rm *resmon) RegisterResource(ctx context.Context, custom := req.GetCustom() parent := resource.URN(req.GetParent()) protect := req.GetProtect() + + dependencies := make([]resource.URN, 0) + for _, dependingURN := range req.GetDependencies() { + dependencies = append(dependencies, resou...
[Invoke->[Package,GetArgs,Wrapf,Invoke,Infof,UnmarshalProperties,Sprintf,Provider,GetTok,V,Errorf,ModuleMember,MarshalProperties],RegisterResourceOutputs->[Wrapf,Infof,UnmarshalProperties,Sprintf,GetUrn,GetOutputs,New,V,URN],Next->[Infof,V,Goal,Assert,Outputs,URN],RegisterResource->[GetType,GetParent,Infof,UnmarshalPro...
RegisterResource registers a resource with the resource monitor unpack the response into a RegisterResourceResponse object that can be sent back to the language runtime.
nit: `dependencies := []resource.URN{}` Or if you want to be very slightly more efficient by avoiding reallocations in `append`, you could do `dependencies := make([]resource.URN, 0, len(req.GetDependencies()))`
@@ -559,8 +559,9 @@ class UpdateChannelsMixin(object): Parameters ---------- - ch_names : list - The list of channels to remove. + ch_names : str | list + Name of the channel to remove, or the list of channels to + remove. Returns --...
[ContainsMixin->[__contains__->[_contains_ch_type]],_get_T1T2_mag_inds->[pick_types],UpdateChannelsMixin->[pick_types->[pick_types],_pick_drop_channels->[inst_has]],read_ch_connectivity->[_recursive_flatten],fix_mag_coil_types->[pick_types],SetChannelsMixin->[set_channel_types->[_check_set],rename_channels->[rename_cha...
Drop some channels from the list of channels.
I would stick to list API typing [] is for me not that painful...
@@ -39,6 +39,12 @@ T.assert_type!([1,2].repeated_permutation(1) {}, T::Array[Integer]) T.assert_type!([1,2].combination(1) {}, T::Array[Integer]) T.assert_type!([1,2].repeated_combination(1) {}, T::Array[Integer]) +# assignments +arr = [1, 2, 3] +T.assert_type!(arr[0] = 1, Integer) +T.assert_type!(arr[1..2] = 3, In...
[any,new,to_i,to_f,repeated_combination,nan?,sum,nilable,zip,combination,permutation,assert_type!,repeated_permutation]
Tests if the missing method is present on the Integer component of T. any.
We still have some tests that use `T.assert_type!` but we generally don't like using them in new tests because their meaning can subtly change over time. e.g., asserting that something is a `T::Enumerable[Integer]` when in fact a change has caused it to become a `T::Array[Integer]` silently. `T.reveal_type` would captu...
@@ -71,10 +71,9 @@ function getMode_(win) { const IS_DEV = true; const IS_MINIFIED = false; - const localDevEnabled = !!AMP_CONFIG.localDev; const runningTests = - !!AMP_CONFIG.test || (IS_DEV && !!(win.__AMP_TEST || win.__karma__)); - const isLocalDev = IS_DEV && (localDevEnabled || runningTests); + ...
[No CFG could be retrieved]
Provides info about the current app. Checks if a given is present in the system.
I don't think all of our `gulp` test commands set `IS_DEV`.
@@ -596,7 +596,7 @@ static void xtrans_markesteijn_interpolate(float *out, const float *const in, else { // mirror a border pixel if beyond image edge - const int c = FCxtrans(row + yoff + 18, col + xoff + 18, NULL, xtrans); + const int c = FCxtrans(row + yoff + ...
[No CFG could be retrieved]
region System Functions - - - - - - - - - - - - - - - - - -.
@dtorop demosaic is the only place we're still doing these increments. Wouldn't it be better to just change the FCxtrans() function to just do +36 or something safely high like that and not need these magic numbers all throughout the code?
@@ -1749,6 +1749,10 @@ vos_agg_ev(daos_handle_t ih, vos_iter_entry_t *entry, return rc; } + /* Aggregation Yield for testing purpose */ + while (DAOS_FAIL_CHECK(DAOS_CONT_AGG_YIED)) + ABT_thread_yield(); + /* Aggregation */ D_DEBUG(DB_EPC, "oid:"DF_UOID", lgc_ext:"DF_EXT", " "phy_ext:"DF_EXT", epoch:"DF_...
[No CFG could be retrieved]
Delete the logical entry from the aggregation window. vos_iter_entry_t - iterator for vos_iter_entry_.
It's better mark VOS_ITER_CB_YIELD by "*act |= VOS_ITER_CB_YIELD". (though your test doesn't update VOS tree while yielding)
@@ -137,8 +137,8 @@ public class PullPhysicalPlanBuilder { while (true) { AbstractPhysicalOperator currentPhysicalOp = null; - if (currentLogicalNode instanceof ProjectNode) { - currentPhysicalOp = translateProjectNode((ProjectNode)currentLogicalNode); + if (currentLogicalNode instanceof ...
[PullPhysicalPlanBuilder->[buildPullPhysicalPlan->[addChild,IllegalArgumentException,PullPhysicalPlan,orElseThrow,size,IllegalStateException,getOutputSchema,get,translateFilterNode,translateProjectNode,translateDataSourceNode,isWindowed,invalidWhereClauseException,isEmpty,getSource,KsqlException],uniqueQueryId->[curren...
Builds a pull physical plan from the given logical node. Returns a new PullPhysicalPlan with a sequence of unknown keys.
What exactly is the difference between FinalProjectNode and ProjectNode?
@@ -214,7 +214,8 @@ public class NodeProvisioner { int plannedCapacitySnapshot = 0; - for (Iterator<PlannedNode> itr = pendingLaunches.iterator(); itr.hasNext(); ) { + List<PlannedNode> snapPendingLaunches = new ArrayList<PlannedNode>(pendingLaunches.get())...
[NodeProvisioner->[NodeProvisionerInvoker->[doRun->[update]],StrategyState->[toString->[toString],recordPendingLaunches->[recordPendingLaunches]],StandardStrategyImpl->[apply->[getLabel,getQueueLengthLatest,getSnapshot,getPlannedCapacitySnapshot,getAdditionalPlannedCapacity,recordPendingLaunches,getConnectingExecutorsL...
Updates the queue if the n - th node is not already in the queue. This method is called when a slave is not available. check if provisioning is complete.
NIT: maybe call `getPendingLaunches`. Seeing as you have it, you may as well use it.
@@ -150,7 +150,6 @@ class DependencyVisitor(TraverserVisitor): # TODO (incomplete): # from m import * # await - # named tuples # TypedDict # protocols # metaclasses
[dump_all_dependencies->[get_dependencies],DependencyVisitor->[add_attribute_dependency->[add_dependency],add_attribute_dependency_for_expr->[add_attribute_dependency],add_iter_dependency->[add_attribute_dependency],visit_for_stmt->[process_lvalue],add_operator_method_dependency_for_type->[add_operator_method_dependenc...
Create a DependencyVisitor for a module. Add dependencies to the object.
If you are removing the TODO item also from here, then it is better to be sure that Python 3.6 class syntax for named tuples also works.
@@ -271,7 +271,7 @@ func saveEnv(env *resource.Env, snap resource.Snapshot, file string, existok boo // If it's not ok for the file to already exist, ensure that it doesn't. if !existok { - if _, err := os.Stat(file); err == nil { + if _, locerr := os.Stat(file); locerr == nil { cmdutil.Sink().Errorf(errors...
[Close->[Close],Dir,EnvPath,Sink,Close,DeserializeEnvfile,Settings,WriteFile,IsNotExist,ColorizeText,Save,ReadFile,Marshal,Stat,New,Errorf,Assert,AddCommand,SerializeEnvfile,ReadString,Detect,QName,Ext,Require,MkdirAll,Printf,Fprintf,NewReader,Sprintf,Decode,Unmarshal,NewContext,Getwd,Rename,Success]
file is the name of the file to write out the new object to. It is.
Is there a linter rule that disallows shadowing?
@@ -78,6 +78,12 @@ When creating a BigQuery input transform, users should provide either a query or a table. Pipeline construction will fail with a validation error if neither or both are specified. +When reading from BigQuery using `BigQuerySource`, bytes are returned as +base64-encoded bytes. When reading via `Re...
[RowAsDictJsonCoder->[RowAsDictJsonCoder],BigQueryReader->[BigQueryReader],_JsonToDictCoder->[_decode_with_schema->[_decode_with_schema],_convert_to_tuple->[_convert_to_tuple],decode->[decode]],_StreamToBigQuery->[expand->[InsertIdPrefixFn,BigQueryWriteFn]],WriteToBigQuery->[expand->[_compute_method,_StreamToBigQuery],...
This function is intended to be called from a side input to a table in a BigQuery service.
Can we add some guidance when to use which?
@@ -19,6 +19,7 @@ const ( ) var ( + httpStatusOK = strconv.Itoa(http.StatusOK) booksBought = 0 booksBoughtV1 = 0 booksBoughtV2 = 0
[Msgf,GetEnv,Now,Info,Int,Format,NewRouter,HandleFunc,Methods,Execute,ParseFiles,ListenAndServe,Err,EscapeString,Printf,Msg,Sprintf,NewPretty,GetBooks,String,Fatal,Parse]
main import imports the given and returns a handler which renders the HTML template debugServer is a function that prints out the current count of items in the bookstore.
Would you be so kind to change this to `const httpStatusOK = "200"`
@@ -133,8 +133,12 @@ def main(config=None, args=sys.argv[1:]): zope.component.provideUtility(display_util.FileDisplay(sys.stdout)) - cli_config = configuration.RenewerConfiguration( - _create_parser().parse_args(args)) + args = _create_parser().parse_args(cli_args) + + le_util.make_or_verify_di...
[renew->[_AttrDict],_create_parser->[_paths_parser],main->[renew,_create_parser]]
Main function for the autorenewer script. Returns the c that is available for this cert.
You might know more about this than I do, but should the `renewer` always be setting up a `StreamHandler`? I wonder if this will cause issues on some systems when invoked automatically.
@@ -25,6 +25,7 @@ func DefaultConfigRequest() *ConfigRequest { c.V1.Sys.Service.Host = w.String("0.0.0.0") c.V1.Sys.Service.Port = w.Int32(10134) c.V1.Sys.Log.Level = w.String("info") + c.V1.Sys.Service.PurgeEventFeedAfterDays = w.Int32(7) return c }
[SetGlobalConfig->[GetLevel,GetLog,GetV1,GetValue],Int32,String]
NewConfigRequest returns a new ConfigRequest with zero values. Get the log level.
Having a default to keep 7 days of event feed data.
@@ -375,6 +375,11 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A { this.troubleshootData_.slotId = this.element.getAttribute('data-slot'); this.troubleshootData_.slotIndex = this.element.getAttribute('data-amp-slot-index'); + if (!this.isFluidRequest_) { + const multiSizeStr = thi...
[AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dev,dict,stringify,now,userAgent],extractSize->[get,height,extractAmpAnalyticsConfig,width],getBlockParameters_->[width,height,dev,isInManualExperiment,serializeTargeting,assign,googleBlockParameters,Number],constructor->[user,extensionsFor],tearDownSlot->[remove...
This method is called when the UI is built.
I'm confused how this interacts with setting `isFluidRequest_` in `isLayoutSupported`. Does the AMP runtime guarantee that `isLayoutSupported` will be called? And is it called before `buildCallback`?
@@ -0,0 +1,6 @@ +from setuptools import find_packages, setup + +setup(name='Requires_Capitalized', + version='0.1', + install_requires=['simple==1.0'] + )
[No CFG could be retrieved]
No Summary Found.
`find_packages` isn't used
@@ -242,7 +242,7 @@ if ( ! function_exists('increment_string')) */ function increment_string($str, $separator = '_', $first = 1) { - preg_match('/(.+)'.$separator.'([0-9]+)$/', $str, $match); + preg_match('/(.+)' . preg_quote($separator) . '([0-9]+)$/', $str, $match); return isset($match[2]) ? $match[1].$se...
[No CFG could be retrieved]
Increments a number in a string.
Should be `preg_quote($separator, '/')` instead, to account for the specific delimiter. Also, please remove the spaces around concatenation.
@@ -70,6 +70,12 @@ fini(void) return 0; } +static int +setup(void) +{ + return dss_ult_create_all(ds_cont_aggregate_ult, NULL, false); +} + static struct crt_corpc_ops ds_cont_tgt_destroy_co_ops = { .co_aggregate = ds_cont_tgt_destroy_aggregator, .co_pre_forward = NULL,
[int->[D_GOTO,ds_cont_iv_fini,ds_cont_cache_fini,ds_oid_iv_fini,ds_cont_iv_init,ds_cont_cache_init,ds_oid_iv_init],void->[D_FREE,ds_cont_child_cache_destroy,ds_cont_child_cache_create,ds_cont_hdl_hash_destroy,ds_cont_hdl_hash_create,D_ERROR,D_ALLOC_PTR]]
Method to free resources of a n - node object.
This seems to create an aggregation ULT for every system, target, helper xstream. We should only create one for every target xstream.
@@ -128,5 +128,11 @@ if ( function_exists( 'register_rest_field' ) ) { add_action( 'rest_api_init', 'wpme_rest_register_shortlinks' ); } -// Register Gutenberg plugin -jetpack_register_plugin( 'shortlinks' ); +/** + * Set the Shortlink Gutenberg extension as available. + */ +function wpme_set_extension_available()...
[wpme_get_shortlink->[get_queried_object_id]]
Register WordPress REST API actions.
lets prefix this with `jetpack_` instead of `wpme`. What is wpme? anyway.
@@ -3,6 +3,9 @@ class AnnotationText < ApplicationRecord belongs_to :creator, class_name: 'User', foreign_key: :creator_id belongs_to :last_editor, class_name: 'User', foreign_key: :last_editor_id, optional: true + after_update :update_mark_deductions + before_update :check_if_released + # An AnnotationTex...
[AnnotationText->[escape_content->[gsub],validates_associated,belongs_to,has_many]]
Annotations that are destroyed when an AnnotationText is destroyed.
Look into the Ruby safe navigation operator to simplify this method.
@@ -31,7 +31,7 @@ public class ComboProperty<T> extends AbstractEditableProperty<T> { final T defaultValue, final Collection<T> possibleValues) { super(name, description); - this.possibleValues = new ArrayList<>(possibleValues); + this.possibleValues = Collections.unmodifiableCollection(new Arr...
[ComboProperty->[validate->[contains],getEditorComponent->[setSelectedItem,addActionListener,newComboBoxModel,getSelectedIndex,getItemAt],IllegalStateException,contains]]
Creates a new instance of ComboProperty that uses a list for selecting the value.
In this case ImmutableList would've been a shorter version, but I guess that works too
@@ -7453,6 +7453,14 @@ void Parser::TransformAsyncFncDeclAST(ParseNodePtr *pnodeBody, bool fLambda) // meaning post-parsing that won't match the actual parameter list of the generator. pnodeFncGenerator->sxFnc.SetHasNonSimpleParameterList(hasNonSimpleParameterList); + // We always merge the param scope a...
[No CFG could be retrieved]
Parse the inner generator function. Adds a node to the list of nodes that can be parsed.
Just curious -- is there a specific reason we always merge these scopes? Can async methods not have default parameter values? Or is the support a TODO?
@@ -47,6 +47,9 @@ module GobiertoAdmin rescue CSVRowInvalid => e errors.add(:base, :invalid_row, row_data: e.message) false + rescue ActiveRecord::RecordNotDestroyed => e + errors.add(:base, :used_resource) + false end def csv_file_format
[PlanDataForm->[clear_previous_data->[save],import_nodes->[save]]]
save_plan_data_nhs - saves the nhs in plan_data.
Useless assignment to variable - e.
@@ -105,6 +105,7 @@ class CompliantSysLogHandler(logging.handlers.SysLogHandler): [2] https://tools.ietf.org/html/rfc5424#section-6.4 """ MAX_MSG_LENGTH = 2041 + log_id = "({pid}-{tid})".format(pid=str(os.getpid()), tid=thread.get_ident()) def emit(self, record): """
[start_logging->[_blacklist_loggers],CompliantSysLogHandler->[emit->[emit]]]
This method is called when a log message needs to get emitted. It will break the message.
This code could get called before any threads are split off, which could cause the tid to be incorrect when the handler is used later. I would recommend moving this line somewhere in the handling methods, and make sure it only gets called when it's needed (i.e., a message is getting split).
@@ -52,6 +52,7 @@ def expr_to_unanalyzed_type(expr: Expression) -> Type: result = parse_type_comment(expr.value, expr.line, None) except SyntaxError: raise TypeTranslationError() + assert result is not None return result elif isinstance(expr, EllipsisExpr): ...
[expr_to_unanalyzed_type->[TypeTranslationError,expr_to_unanalyzed_type]]
Translate an expression to the corresponding type.
Could be moved closer to the assignment (inside the try block)?
@@ -17,6 +17,10 @@ class Rclone(Package): depends_on("go", type='build') + def setup_environment(self, spack_env, run_env): + # Point GOPATH at the top of the staging dir for the build step. + spack_env.prepend_path('GOPATH', self.stage.path) + def install(self, spec, prefix): go...
[Rclone->[install->[install,mkdirp,go],depends_on,version]]
Installs a new package.
would this variable be better set to a cache path that spack already has?
@@ -60,10 +60,17 @@ public class NotDimFilter implements DimFilter return ByteBuffer.allocate(1 + subKey.length).put(DimFilterUtils.NOT_CACHE_ID).put(subKey).array(); } + @SuppressWarnings("ObjectEquality") @Override public DimFilter optimize() { - return new NotDimFilter(this.getField().optimize...
[NotDimFilter->[getCacheKey->[getCacheKey],optimize->[optimize,NotDimFilter],equals->[equals],toFilter->[toFilter],hashCode->[hashCode],getDimensionRangeSet->[getDimensionRangeSet],getRequiredColumns->[getRequiredColumns]]]
This method returns cache key for this DimFilter and a field.
Why not use the recommended resolution `FalseDimFilter.instance().equals(optimized)`
@@ -71,8 +71,7 @@ public class FlinkStreamerConfig extends Configuration { + "hoodie client, schema provider, key generator and data source. For hoodie client props, sane defaults are " + "used, but recommend use to provide basic things like metrics endpoints, hive configs etc. For sources, refer" ...
[FlinkStreamerConfig->[getName,getProperty]]
Required parameter for the schema file. Key generator class.
Does this config cause any problem? AFAIK, it copied from deltastreamer.
@@ -31,7 +31,7 @@ class ActivityAdmin extends Admin const LIST_VIEW = 'sulu_activity.activities.list'; - const EDIT_FORM_ACTIVITY_VERSION_TAB_VIEW = 'sulu_page.page_edit_form.activity_version_tab'; + const PAGE_EDIT_FORM_ACTIVITY_TAB_VIEW = 'sulu_page.page_edit_form.activity_version_tab'; /** ...
[ActivityAdmin->[configureViews->[setParent,has,hasPermission,add,addToolbarActions],configureNavigationItems->[addChild,setView,hasPermission,setPosition]]]
Constructor for a specific activity. Configures the navigation items.
@alexander-schranz should we move these views into the `PageAdmin`/`MediaAdmin` or should we leave them here?
@@ -79,6 +79,9 @@ export class AmpStoryPageAttachment extends DraggableDrawer { this.element.classList.add(DARK_THEME_CLASS); } + // Add manual tap handler class to prevent advancement on tap + this.element.classList.add('i-amphtml-story-handle-tap-manually'); + const templateEl = this.element....
[No CFG could be retrieved]
Constructor for the attachment. Initializes the listeners of the attachments.
This change might require more discussions. To not block the work on positioning the quiz element, can we keep it for another PR?
@@ -231,6 +231,13 @@ with_identical_updates(void *const *state, uint32_t iod_type, int csum_type, daos_size_t delta; int rc; + if (dedup_type == DAOS_PROP_CO_DEDUP_MEMCMP && + dedup_is_nvme_enabled(*state)) { + print_message("DAOS_PROP_CO_DEDUP_MEMCMP " + "doesn't support NVMe.\n"); + skip(); + }...
[run_daos_dedup_test->[MPI_Barrier,cmocka_run_group_tests_name,ARRAY_SIZE,run_daos_sub_tests],void->[iov_alloc,assert_success,setup_cont_obj,uuid_generate,daos_prop_free,assert_non_null,get_size,daos_obj_open,dts_oid_gen,strlen,dts_sgl_init_with_strings_repeat,fail_msg,ctx_update,setup_fetch_iod,assert_int_equal,daos_p...
This function checks if there is an update of the node with the same data and if so return null if not found.
If you skip only the MEMCMP cases, the get_size() needs be improved to check NVMe free size when NVMe is enabled. (Seems the dedup threshold is larger than 4k in all dedup tests, so update will be landed to NVMe when NVMe is enabled, and we need to check NVMe free space respectively).
@@ -9,13 +9,17 @@ from mypy.nodes import Context def apply_generic_arguments(callable: CallableType, orig_types: Sequence[Optional[Type]], - msg: MessageBuilder, context: Context) -> CallableType: + msg: MessageBuilder, context: Context, + ...
[apply_generic_arguments->[list,all,any,incompatible_typevar_value,len,expand_type,is_same_type,isinstance,enumerate,copy_modified,is_subtype]]
Apply generic type arguments to a callable type. A copy of the object that represents a that may retain some type vars.
Is this docstring correct? It seems to me that the type is not replaced at all if it's unsatisfied.
@@ -133,6 +133,7 @@ func newSMIClient(kubeClient *kubernetes.Clientset, smiTrafficSplitClient *smiTr informerCollection.TrafficSplit.AddEventHandler(k8s.GetKubernetesEventHandlers("TrafficSplit", "SMI", client.announcements, shouldObserve)) informerCollection.TrafficSpec.AddEventHandler(k8s.GetKubernetesEventHandle...
[GetService->[GetByKey],ListServices->[Msg,Error,List,Err,IsMonitoredNamespace],ListTrafficSplits->[List,IsMonitoredNamespace],ListHTTPTrafficSpecs->[List,IsMonitoredNamespace],run->[Join,Msg,Msgf,WaitForCacheSync,Info,Run],ListServiceAccounts->[List,IsMonitoredNamespace],ListTrafficTargets->[List,IsMonitoredNamespace]...
ListTrafficSplits returns a list of traffic splits and traffic targets. returns the last route group that is not monitored.
I'd wrap this with `if enableBackpressureExperimental {` so that these handlers are added only if the flag is on.
@@ -240,6 +240,7 @@ class CloudTaskRunner(TaskRunner): return state + @tail_recursive def run( self, state: State = None,
[CloudTaskRunner->[initialize_run->[exception,Failed,get,update,ENDRUN,get_task_run_info,repr,format,super],check_task_is_cached->[,get_latest_cached_states,debug,get,len,format,isinstance,items,cache_validator,utcnow,to_result],_heartbeat->[exception,get,interrupt_main,graphql,format,update_task_run_heartbeat],run->[,...
Checks if the task is cached in the DB and whether any of the caches are still valid This method is the main method of the TaskRunners. It is the base method of Override run method to add version information to context and update run_info.
for my own understanding, is this decorator necessary because the standard `TaskRunner` uses `self.run` within its recursive raise?
@@ -48,6 +48,7 @@ class CAR: MALIBU = "CHEVROLET MALIBU PREMIER 2017" ACADIA = "GMC ACADIA DENALI 2018" BUICK_REGAL = "BUICK REGAL ESSENCE 2018" + ESCALADE_ESV = "CADILLAC ESCALADE ESV 2016" class CruiseButtons: INIT = 0
[dbc_dict]
This function is used to set the default values for the n - tuple of the n - Alephic - Marca - Marca - Marca - M The list of valid numbers.
is the ESV actually important? can we just call this `ESCALADE`?
@@ -57,6 +57,8 @@ public class Blockchain { private byte[] lastHash; private byte[] currentHash; + private Client client; + /** * create new blockchain *
[Blockchain->[signTransaction->[build,toByteArray,getTxID,toHexString,sign,getVinList,put],addBlock->[parseFrom,copyFromUtf8,putData,equals,broadcast,copyFrom,getIncreaseNumber,getBlockchain,getData,toByteArray,Message,putMessage1,getNumber,printStackTrace,toHexString,fromString,newBlock],receiveBlock->[putData,equals,...
Creates a new blockchain object. This method initializes the DB object.
I'm wondering if it is possible to inject the database when initializing the Blockchain for the first time from this constructor: `public Blockchain(String address, String type) {` Doing so would avoid making the Blockchain responsible for setting the database connection, which to me isn't an intuitive responsibility o...
@@ -343,7 +343,7 @@ public class ConsumeEWS extends AbstractProcessor { try { //Get Folder - Folder folder = getFolder(service); + Folder folder = getFolder(service, context); ItemView view = new ItemView(messageQueue.remainingCapacity());...
[ConsumeEWS->[receiveMessage->[fillMessageQueueIfNecessary],fillMessageQueueIfNecessary->[initializeIfNecessary],flushRemainingMessages->[transfer],transfer->[transfer]]]
This method fills the message queue if it is empty. if nesde nesde nesde nesde nesde nes.
I'd suggest moving `String MailboxProperty = context.getProperty(MAILBOX).getValue();` up here, and passing in the MAILBOX as an optional parameter to `getFolder`. Then you can keep `getFolder` as an Exchange only method.
@@ -6,6 +6,7 @@ module ModelExporters class ModelExporter attr_accessor :assets_to_copy attr_accessor :tiny_mce_assets_to_copy + include ActiveStorage::Downloading def initialize @assets_to_copy = []
[ModelExporter->[step->[assets_data,table,checklist,to_a,step_assets,step_comments,step_tables,present?,push,map],assets_data->[blob,attached?],protocol->[protocol_protocol_keywords,step,map],table->[nil?,encode64,data_vector,as_json,contents],checklist->[checklist_items],copy_files->[binmode,path,new,write,flush,downl...
Initialize the missing assets.
Not needed here anymore
@@ -0,0 +1,15 @@ +package com.baeldung.lombok.getter; + + +import lombok.Getter; + +/** + * Related Article Sections: + * 4. Using @Getter on a Boolean Field + * + */ +public class GetterBoolean { + + @Getter + private Boolean running = true; +}
[No CFG could be retrieved]
No Summary Found.
Let's name this GetterBooleanType
@@ -307,6 +307,7 @@ func TestServices_NewInitiatorSubscription_EthLog_ReplayFromBlock(t *testing.T) defer cleanup() ethClient := new(mocks.Client) + defer ethClient.AssertExpectations(t) store.EthClient = ethClient currentHead := cltest.Head(test.currentHead)
[LoadInt32,CountOf,NewAddress,StartJobSubscription,Hash,IDToHexTopic,NewGomegaWithT,EmptyMockSubscription,NewStore,Eventually,Set,NewBig,CreateJob,Should,EventuallyAllCalled,MockEthOnStore,RegisterSubscription,StringToVersionedLogData20190207withoutIndexes,NewJob,NotNil,CallbackOrTimeout,AddInt32,NewJobWithRunLogInitia...
TestServices_NewInitiatorSubscription_EthLog_ReplayFromBlock test - New Missing topics are topics for all topics that are subscribed to a single job.
Hmm, what does this do wrt line numbers when expectations fail? Does it show from the end of the block or from the defer, if it's from the defer I think it could be a little confusing.
@@ -31,6 +31,7 @@ type JobRun struct { CreationHeight *utils.Big `json:"creationHeight"` ObservedHeight *utils.Big `json:"observedHeight"` Overrides JSON `json:"overrides"` + InitialMeta JSON `json:"initialMeta" gorm:"default:'{}'"` DeletedAt null.Time `json:"-" gorm:"index"`...
[PreviousTaskRun->[NextTaskRunIndex],Cancel->[NextTaskRun],ApplyBridgeRunResult->[SetError,HasError],NextTaskRun->[NextTaskRunIndex],setStatus->[TasksRemain],ApplyOutput->[SetError,HasError],TasksRemain->[NextTaskRunIndex],String->[String]]
Get a JobRun from a list of TaskRun objects. ForLogger formats a JobRun into a list of strings that can be logged.
Should the default be set on the database level? Maybe it would be best to do when creating the Job Runs.
@@ -181,8 +181,8 @@ func (d *Dispatcher) Dispatch(conf *metadata.VirtualContainerHostConfigSpec, set return err } - if err = d.removeApplianceIfForced(conf); err != nil { - return errors.Errorf("%s", err) + if err = d.checkExistence(conf); err != nil { + return err } if err = d.createAppliance(conf, sett...
[uploadImages->[UploadFile,Add,Infof,Warnf,Errorf,Base,Wait,Done],RegisterExtension->[Infoln,Vim25,NewExtensionManager,SetCertificate,Errorf,Register],UnregisterExtension->[Vim25,NewExtensionManager,Unregister,Errorf],Dispatch->[WaitForResult,Error,Sprintf,uploadImages,makeSureApplianceRuns,RegisterExtension,New,create...
Dispatch creates a virtual container host and starts the container.
We should change the name of Dispatch to Create or Deploy - doesn't need to be done in this PR, but at the moment it's single purpose with a general purpose name which is confusing
@@ -65,7 +65,8 @@ public class InputRowSerde { ValueType getType(); - void serialize(ByteArrayDataOutput out, Object value, boolean reportParseExceptions); + @Nullable + String serialize(ByteArrayDataOutput out, Object value, boolean reportParseExceptions); T deserialize(ByteArrayDataInput in)...
[InputRowSerde->[fromBytes->[fromBytes,readBytes,getType,readString,get,deserialize],toBytes->[serialize,toBytes,get],readStringArray->[readString],writeString->[writeBytes],writeStringArray->[writeString]]]
getTypeHelperMap - returns a map of type - helper for the given dimensions.
I'm not sure about returning an exception message. Probably it's possible that this method always throws a `ParseException` on parsing errors and `reportParseExceptions` can be handled by the caller.
@@ -85,7 +85,8 @@ public class AppScriptServlet extends DefaultServlet { int endIndex = script.indexOf(endReplaceString, startIndex); if (startIndex >= 0 && endIndex >= 0) { - String replaceString = "this.getPort=function(){return " + websocketPort + "};"; + String replaceString = "this.getPort=fu...
[AppScriptServlet->[doGet->[getResource,append,indexOf,getRequestURI,getInputStream,println,doGet,available,read,String,contains,StringBuffer,replace,toString,length],asList]]
This method is overridden to read the script file chunk by chunk by chunk and write the script.
This will set an incorrect internal local port of the zeppelin instance (e.g. 8080) where it is possible that there is a reverse proxy (nginx with HTTPS for example) in front of zeppelin. Actually I think this whole Servlet is no longer needed since the websocket port is now the http port, so the browser can simply ass...
@@ -96,6 +96,8 @@ class Runner { if ( is_numeric( $user ) ) { $user_id = (int) $user; + } else if ( is_email( $user ) ) { + $user_id = email_exists( $user ); } else { $user_id = (int) username_exists( $user ); }
[Runner->[_run_command->[run_command],before_wp_load->[wp_exists,init_config,_run_command,find_command_to_run,cmd_starts_with,init_colorization,init_logger,get_wp_config_code,check_wp_version,do_early_invoke],run_command->[find_command_to_run],init_logger->[in_color],after_wp_load->[_run_command],check_wp_version->[wp_...
Sets the current user.
How about using the fetcher here too?
@@ -640,6 +640,13 @@ module Repository end # end case end + # Helper method to readd the Gitolite admin key after repo perm changes + def self.readd_admin_key + admin_key = Gitolite::SSHKey.from_file( + GITOLITE_SETTINGS[:public_key]) + ga_repo.add_key(admin_key) + end + #...
[GitRevision->[initialize->[get_repos]],GitRepository->[delete_bulk_permissions->[add_user],expand_path->[expand_path],remove_user->[add_user],add_file->[path_exists_for_latest_revision?],latest_revision_number->[get_revision_number],remove_file->[commit_options,create],create->[commit_options,create],access->[open],ma...
Translates permission string from file to a negative integer.
Indent the first parameter one step more than the previous line.
@@ -2807,6 +2807,18 @@ public class NetworkOrchestrator extends ManagerBase implements NetworkOrchestra } } + @Override + public DnsServiceProvider getDnsServiceProvider(final Network network) { + final String dnsProvider = _ntwkSrvcDao.getProviderForServiceInNetwork(network.getId(), Servic...
[NetworkOrchestrator->[reallocate->[doInTransactionWithoutResult->[cleanupNics,allocate]],prepare->[implementNetwork],setupNetwork->[setupNetwork],removeNic->[release,releaseNic,removeNic],getElementForServiceInNetwork->[getProvidersForServiceInNetwork],setRestartRequired->[setRestartRequired],releaseNic->[doInTransact...
Replies the DhcpServiceProvider for the given network.
Should this message be logged as `WARN` instead of `DEBUG`?
@@ -350,7 +350,8 @@ public final class JpaJandexScavenger { // we need to check for enums for (FieldInfo fieldInfo : classInfo.fields()) { Type fieldType = fieldInfo.type(); - if (Type.Kind.PRIMITIVE == fieldType.kind()) { + if (Type.Kind.CLASS != fieldType.kind()) {...
[JpaJandexScavenger->[addClassHierarchyToReflectiveList->[addClassHierarchyToReflectiveList],collectEmbeddedTypes->[collectEmbeddedTypes],collectHbmXmlEmbeddedTypes->[collectHbmXmlEmbeddedTypes]]]
Adds all classes in the hierarchy to reflection list.
Hm, this would also skip parameterized types. I don't know if it could be a problem in the context of hibernate extension... just saying.
@@ -100,6 +100,10 @@ public class DoubleDimensionHandler implements DimensionHandler<Double, Double, @Override public Double getEncodedKeyComponentFromColumn(Closeable column, int currRow) { - return ((GenericColumn) column).getDoubleSingleValueRow(currRow); + GenericColumn genericColumn = (GenericColumn...
[DoubleDimensionHandler->[getSubColumn->[getGenericColumn],makeIndexer->[DoubleDimensionIndexer],compareSortedEncodedKeyComponents->[compareTo],validateSortedEncodedKeyComponents->[SegmentValidationException,equals],makeMerger->[DoubleDimensionMergerV9],getEncodedKeyComponentFromColumn->[getDoubleSingleValueRow]]]
Get encoded key component from a column.
This method should be `@Nullable`
@@ -98,11 +98,6 @@ class _Activator(object): def hook(self, auto_activate_base=None): builder = [] builder.append(self._hook_preamble()) - - # here - condabin_dir = self.path_conversion(join(context.conda_prefix, "condabin")) - self.export_var_tmpl % ("PATH", self.pathsep_joi...
[main->[execute,__init__],_Activator->[reactivate->[_finalize],deactivate->[_finalize],_replace_prefix_in_path->[index_of_path,_get_path_dirs2,_get_starting_path_list],_add_prefix_to_path->[_get_path_dirs2,_get_starting_path_list],activate->[_finalize]],native_path_to_unix->[ensure_fs_path_encoding],main]
Returns a string containing the code of the hook.
This apparently snuck in through #7773, and should have been removed before the PR was merged. It's dead code and has no effect.
@@ -0,0 +1,13 @@ +# Generated by Django 2.2.6 on 2019-11-29 11:06 + +from django.db import migrations + + +class Migration(migrations.Migration): + + dependencies = [("product", "0110_auto_20191108_0340")] + + operations = [ + migrations.RemoveField(model_name="productvariant", name="quantity"), + m...
[No CFG could be retrieved]
No Summary Found.
I don't know if you already did that, but definitely we have to move values from quantity and allocated to stock objects before we drop these fields.
@@ -139,11 +139,13 @@ export const StateProperty = { export const Action = { ADD_TO_ACTIONS_WHITELIST: 'addToActionsWhitelist', CHANGE_PAGE: 'setCurrentPageId', + TOGGLE_EMBEDDED_COMPONENT: 'toggleEmbeddedComponent', SET_CONSENT_ID: 'setConsentId', SET_PAGES_COUNT: 'setPagesCount', TOGGLE_ACCESS: 'togg...
[No CFG could be retrieved]
Enumerate all app - specific actions. A function to compare a data structure from the previous state to the new state and detect a.
Instead of having two actions, can we have one action that would accept an object parameter `{component: !Element, state: !ComponentState}`?
@@ -22,5 +22,5 @@ package org.apache.hudi.metrics; * Types of the reporter. Right now we only support Graphite. We can include JMX and CSV in the future. */ public enum MetricsReporterType { - GRAPHITE, INMEMORY, JMX, DATADOG + GRAPHITE, INMEMORY, JMX, DATADOG, USER_DEFINED }
[No CFG could be retrieved]
Types of the reporter.
would remove USER_DEFINED.
@@ -44,7 +44,7 @@ urlpatterns = patterns('', #url(r'^', include('dashboards.urls')), # Users - #('', include('users.urls')), + ('', include('users.urls')), # Services and sundry. #(r'', include('sumo.urls')),
[_error_page->[render],_error_page,include,lstrip,autodiscover,patterns]
Returns a view that renders the error pages with Jinja2. The root of the media.
Looks like this needs another redirect in configs/htaccess, something like: RewriteRule ^(((en-US|de|el|es|fr|fy-NL|ga|hr|hu|id|ja|ko|nl|pl|pt-BR|pt-PT|ro|sl|sq|th|x-testing|zh-TW|zh-CN)/)?users.*?)$ /mwsgi/$1 [PT,L]
@@ -276,3 +276,18 @@ class CustomerEvent(models.Model): def __repr__(self): return f"{self.__class__.__name__}(type={self.type!r}, user={self.user!r})" + + +class StaffNotificationRecipient(models.Model): + user = models.OneToOneField( + User, + related_name="staff_notification", + ...
[UserManager->[create_superuser->[create_user]],User->[UserManager],Address->[get_copy->[as_data],PossiblePhoneNumberField],ServiceAccount->[has_perm->[_get_permissions],has_perms->[_get_permissions]]]
Return a string representation of the object.
I think that we actually don't need this relationship. I thought we will use `SiteSettings` model to store these addresses but since it's a separate model, is there any use case for that?
@@ -19,7 +19,7 @@ def main(serialization_directory, device): The device to run the evaluation on. """ - config = Params.from_file(os.path.join(serialization_directory, "model_params.json")) + config = Params.from_file(os.path.join(serialization_directory, "config.json")) dataset_reader = Data...
[main->[BasicIterator,tqdm,decode,join,model,index_with,from_params,extend,fields,load,print,write_to_conll_eval_file,read,format,iterator,close,zip,open,from_file],abspath,add_argument,insert,dirname,ArgumentParser,parse_args,join,main]
Main function for the n - node evaluation.
If you could make this backward compatible that would be great, maybe just with a `try except` or something.
@@ -495,6 +495,9 @@ class Serve(Subcommand): log_level = getattr(logging, args.log_level.upper()) logging.basicConfig(level=log_level, format=args.log_format) + if args.host is not None and len(args.host) > 0: + warnings.warn("The --hosts parameter is no longer needed or necessary ...
[Serve->[invoke->[show_callback->[show,keys],die,add_callback,upper,sign_sessions,keys,getattr,basicConfig,len,sorted,secret_key_bytes,Server,getpid,run_until_shutdown,report_server_init_errors,RuntimeError,info,Application,build_single_handler_applications],dict,nice_join],dict,getLogger,nice_join,replace,format]
Invoke the server. Start the Bokeh server with a specific node id.
`warnings.warn` good? Seems better than a log message.
@@ -57,6 +57,11 @@ function tagrm_content(App $a) // NOTREACHED } + if ($a->argc == 3) { + update_tags($a->argv[1], [hex2bin(notags(trim($a->argv[2])))]); + $a->internalRedirect($_SESSION['photo_return']); + } + $item_id = (($a->argc > 1) ? intval($a->argv[1]) : 0); if (!$item_id) { $a->internalRedirect...
[tagrm_content->[internalRedirect],tagrm_post->[internalRedirect]]
This function will render the tagrm input nope nope nope.
When is this form used? I thought hex-converted tags were separated by commas? How does it go through `hex2bin()`?
@@ -365,11 +365,12 @@ public class KafkaSupervisor implements Supervisor notices.add(new ShutdownNotice()); } - long endTime = System.currentTimeMillis() + SHUTDOWN_TIMEOUT_MILLIS; + long shutdownTimeoutMillis = tuningConfig.getShutdownTimeout().getMillis(); + long e...
[KafkaSupervisor->[createKafkaTasksForGroup->[generateSequenceName,getRandomId],discoverTasks->[apply->[TaskData,TaskGroup]],buildRunTask->[run->[RunNotice]],runInternal->[possiblyRegisterListener],GracefulShutdownNotice->[handle->[handle]],getKafkaConsumer->[getRandomId],createNewTasks->[TaskGroup],addDiscoveredTaskTo...
Stop the managed tasks.
[nit] `%,d` is more readable for potentially long values.
@@ -4,7 +4,7 @@ RSpec.describe ApplicationMailer, type: :mailer do let(:user) { create(:user) } let(:email) { VerificationMailer.with(user_id: user.id).account_ownership_verification_email } - xdescribe "#set_perform_deliveries" do + describe "#set_perform_deliveries" do it "changes perform_deliveries fr...
[create,to,perform_deliveries,let,have_received,describe,account_ownership_verification_email,deliver_now,xdescribe,receive,it,require,and_return]
region Private Methods.
nitpick, non-blocking: I think this is a Deliverable test, not specifically an ApplicationMailer test.
@@ -195,9 +195,11 @@ public class TestPipelinePlacementPolicy { int nodesRequired = HddsProtos.ReplicationFactor.THREE.getNumber(); thrownExp.expect(SCMException.class); - thrownExp.expectMessage("enough space for even a single container"); + thrownExp.expectMessage("Unable to find enough nodes that m...
[TestPipelinePlacementPolicy->[overWriteLocationInNodes->[overwriteLocationInNode],setupSkewedRacks->[initTopology],testValidatePlacementPolicyOK->[getNodesWithRackAwareness,initTopology],insertHeavyNodesIntoNodeManager->[mockPipelineIDs],testValidatePlacementPolicySingleRackInCluster->[initTopology],testChooseNodeNotE...
testPickNodeNotEnoughSpace - test if there is enough space for even a single Checks if a node is evenly used.
Here should have a single space, then the failed ut should pass I think.
@@ -13,7 +13,11 @@ class WebhookCreateInput(graphene.InputObjectType): name = graphene.String(description="The name of the webhook.", required=False) target_url = graphene.String(description="The url to receive the payload.") events = graphene.List( - WebhookEventTypeEnum, description="The events ...
[WebhookUpdate->[save->[save],Arguments->[WebhookUpdateInput]],WebhookCreate->[save->[save],Arguments->[WebhookCreateInput]]]
Create a new webhook. check_permission - Check if cleaned_data has app_id or app instance assigned to.
Can we recommend which hook to use instead?
@@ -0,0 +1,10 @@ +#include "ergodox_ez.h" +#include "version.h" + +#define LONGPRESS_DELAY 180 +#define LAYER_TOGGLE_DELAY 350 + +#include "tapdances.c" +#include "keymap-mac.c" +//#include "keymap-win.c" +//#include "keymap-mw2.c"
[No CFG could be retrieved]
No Summary Found.
Sooo, what's up with all these keymaps? Why not just merge them?
@@ -41,6 +41,7 @@ public class CoordinatorDynamicConfig @JsonProperty("maxSegmentsToMove") int maxSegmentsToMove, @JsonProperty("replicantLifetime") int replicantLifetime, @JsonProperty("replicationThrottleLimit") int replicationThrottleLimit, + @JsonProperty("costBalancerThreads") int costBal...
[CoordinatorDynamicConfig->[Builder->[build->[CoordinatorDynamicConfig]]]]
Displays a dynamic configuration for a single . Limit of the number of non - nanomorphies.
this doesn't have to be cost balancer specific, we can just call this `balancerComputeThreads`
@@ -528,7 +528,7 @@ def get_sqd_params(rawfile): """ sqd = dict() sqd['rawfile'] = rawfile - with open(rawfile, 'rb') as fid: + with open(rawfile, 'rb+') as fid: fid.seek(KIT.BASIC_INFO) basic_offset = unpack('i', fid.read(KIT.INT))[0] fid.seek(basic_offset)
[RawKIT->[_set_dig_neuromag->[append,enumerate,ValueError,asarray],_set_stimchannels->[NotImplementedError,str,ValueError,isinstance,pick_types],__repr__->[join,basename,len],_read_segment->[sum,fromfile,info,int,copy,range,list,unpack,len,read,ValueError,float,open,vstack,NotImplementedError,arange,seek,reshape,array]...
Extracts all the information from the sqd file. Computes the base parameters of a specific node. load a single record of a specific .
@warrd any reason this would make a difference? It does. I don't think it should need to be there, so I'd rather come up with a different solution. It comes up a couple of times.
@@ -582,7 +582,15 @@ parse_device_info(struct json_object *smd_dev, device_list *devices, for (i = 0; i < dev_length; i++) { dev = json_object_array_get_idx(smd_dev, i); - strcpy(devices[*disks].host, strtok(host, ":") + 1); + + if (strlen(host + 2) <= DSS_HOSTNAME_MAX_LEN) + strcpy(devices[*disks].host, str...
[No CFG could be retrieved]
parse the n - ary info for a device function to find the index of the target device and rank of the target device in the system.
Does (host+2) instead of (host) points to the real host name? devices[*disks].host is an 50bytes array: typedef struct { uuid_t device_id; char state[10]; int rank; char host[50]; int tgtidx[MAX_TEST_TARGETS_PER_DEVICE]; int n_tgtidx; } device_list; and #define DSS_HOSTNAME_MAX_LEN 255 Won't there still a risk of Copy ...
@@ -56,6 +56,11 @@ class FreezeCommand(Command): action='store_true', default=False, help='Only output packages installed in user-site.') + self.cmd_opts.add_option( + '--path', + dest='path', + action='append', + help='Use the sp...
[FreezeCommand->[__init__->[add_option,insert_option_group,super,join],run->[freeze,WheelCache,write,cleanup,dict,update,set,FormatControl]]]
Adds options related to the FreezeCommand and adds a option to the command line.
I would end this with "(can be used multiple times)", and then end with a period. I also think it might be clearer to begin the sentence with "Restrict to the ..." or "Use only ..." to make clear that these paths aren't being considered in addition to what is already considered.
@@ -403,7 +403,7 @@ public class GameRunner { .isLessThan(latestEngineOut.getLatestVersionOut())) { SwingUtilities .invokeLater(() -> EventThreadJOptionPane.showMessageDialog(null, latestEngineOut.getOutOfDateComponent(), - "Please Update TripleA", JOptionPane.INFORMATION...
[GameRunner->[getChat->[getChat],joinGame->[showConfirmDialog,joinGame,showMessageDialog],showConfirmDialog->[showConfirmDialog],checkForLatestEngineVersionOut->[showMessageDialog],Title->[of->[Title]],quitGame->[dispatchEvent],clientLeftGame->[showMainFrame],setupLogging->[dispatchEvent->[dispatchEvent]],hasChat->[get...
Checks if the latest engine version is out of the system.
This change will cause a conflict with #2284, but the resolution should be pretty easy since this code is slated for deletion.
@@ -87,6 +87,7 @@ public class CliBroker extends ServerRunnable binder.bind(CachingClusteredClient.class).in(LazySingleton.class); binder.bind(BrokerServerView.class).in(LazySingleton.class); binder.bind(TimelineServerView.class).to(BrokerServerView.class).in(LazySingleton.class);...
[CliBroker->[getModules->[configure->[install,addResource,to,CacheModule,bind,register,in],Module,LookupModule,of],Logger]]
Provides the modules that are used by the broker. This method is used to create a new object.
the broker should be using its own internal cache, not calling to the coordinator
@@ -154,7 +154,7 @@ class GatewayHandler extends Handler { 'SELECT * FROM issues WHERE journal_id = ? AND year = ? AND published = 1 ORDER BY current DESC, year ASC, volume ASC, number ASC', array($journal->getId(), $year) ); - $issues = new DAOResultFactory($result, $issueDao, '_returnIssueFromRow'...
[GatewayHandler->[clockss->[getAll,setupTemplate,validate,redirect,display,RecordCount,getUserVar,assign,retrieve,getSupportedLocaleNames,getId,getJournal,getSetting],plugin->[fetch,validate,redirect],index->[redirect],lockss->[getAll,setupTemplate,validate,redirect,display,RecordCount,getUserVar,assign,retrieve,getSup...
ClockSS action for the issue list view This function returns all the issues that have been published for a given year.
This makes the above query unnecessary, I think -- you should be able to remove those 4 lines.
@@ -225,7 +225,6 @@ stride_buf_op(int opc, char *buf, unsigned offset, int size) * old version will be fully overwritten */ if (ts_single && opc == STRIDE_BUF_SET) { - stride_buf.sb_buf[pos] = 0; continue; } return 0;
[run_commands->[find_test,pause_test,run_one],main->[run_commands,ts_abt_fini,ts_abt_init]]
This method is used to perform a partial operation on the buffer buffer and stride buffer buffer.
I don't think we can remove this, otherwise daos_perf will report data corruption if overwriting a large single value with a smaller value.
@@ -54,7 +54,7 @@ class SignUpCompletionsShow def title if requested_ial == 'ial2' - I18n.t('titles.sign_up.verified') + I18n.t('titles.sign_up.verified', app: APP_NAME) else I18n.t( 'titles.sign_up.completion_html',
[SignUpCompletionsShow->[requested_ial->[user_verified?]]]
title - returns the title missing in the sign - up page or the title missing in.
~I think this is supposed to be `service_provider.friendly_name` instead of `APP_NAME`~ **EDIT**: nevermind
@@ -65,7 +65,7 @@ using namespace Js; JS_ETW(EventWriteJSCRIPT_RECYCLER_ALLOCATE_FUNCTION(scriptFunction, EtwTrace::GetFunctionId(functionProxy))); JavascriptGeneratorFunction* genFunc = nullptr; - if (functionProxy->IsAsync()) + if (functionProxy->IsAsync() && !functionProxy->IsModule...
[No CFG could be retrieved]
Creates a new generator function object. This function is called when a new scr function is called.
I am not sure what this does, is this the module entry point case? > TODO: investigate the odd case of a module that is both a root module/main entry point AND is dynamically imported - not sure if error handling works correctly for this - also need a test for that case. I have looked through the rest of the PR and eve...
@@ -70,11 +70,8 @@ func (s *scanner) Start(done <-chan struct{}) (<-chan Event, error) { // scan iterates over the configured paths and generates events for each file. func (s *scanner) scan() { - if logp.IsDebug(metricsetName) { - debugf("%v File system scanner is starting for paths [%v].", - s.logID, strings.J...
[walkDir->[throttle,newScanEvent,IsDir,Mode,New,Now,IsExcludedPath,Since,Walk],throttle->[Take,NewTimer],scan->[walkDir,IsDebug,Join,Warn,EvalSymlinks,Now,LoadUint64,Bytes,Info,Since],Start->[NewBucketWithRate,Bytes,scan,TakeAvailable],newScanEvent->[AddUint64],Sprintf,AddUint32]
scan is the main scan function. It walks the paths in the config. Paths and.
+1 to remove the conditionals check.
@@ -0,0 +1 @@ +from ._raft.raft import RAFT, raft, raft_small
[No CFG could be retrieved]
No Summary Found.
We should expose the building blocks as well, stuff like `ResidualBlock`, `FeatureEncoder`, etc. Should we expose these in a `models.optical_flow.raft` namespace? I remember @datumbox mentioning a few issues when we have both a module and a function with the same name. Ideally, I'd like to keep the `raft()` name for th...
@@ -82,7 +82,7 @@ public final class ResourceDomainConfiguration extends GlobalConfiguration { @Restricted(NoExternalUse.class) @POST public FormValidation doCheckUrl(@QueryParameter("url") String resourceRootUrlString) { - Jenkins.get().checkPermission(Jenkins.ADMINISTER); + Jenkins.get()....
[ResourceDomainConfiguration->[isResourceRequest->[getUrl],isResourceDomainConfigured->[getUrl],setUrl->[checkUrl]]]
Checks if the given URL is valid. This method checks if the current Jenkins instance has the correct public key. This method is called when an URL is malformed or an IOException occurs during the instance identity check.
Revert, this seems like an admin thing.
@@ -500,7 +500,7 @@ def _find_clusters_1dir(x, x_in, connectivity, max_step, t_power, ndimage): if x.ndim == 1: # slices clusters = ndimage.find_objects(labels, n_labels) - if len(clusters) == 0: + if not clusters: sums = list() else...
[_get_1samp_orders->[bin_perm_rep],_get_partitions_from_connectivity->[_find_clusters],_get_clusters_spatial->[_where_first,_get_buddies],_find_clusters_1dir->[_get_clusters_st,_masked_sum_power,_masked_sum,_get_components],_get_clusters_st_multistep->[_get_selves,_where_first,_get_buddies],spatio_temporal_cluster_test...
This function is called when clustering algorithm is called from the 1 - D directory.
I find this less clear actually because before it was clear we were considering if there were any elements in an iterable (len-0), with the current code it's not clear if it's checking for boolean / None / len-0, etc.
@@ -27,7 +27,7 @@ def read(fname): setup( name = 'nni', - version = '999.0.0-developing', + version = 'v0.8-347-g0538d30', author = 'Microsoft NNI Team', author_email = 'nni@microsoft.com', description = 'Neural Network Intelligence project',
[read->[open],find_packages,setup,read]
This function returns the contents of a given file in a Software object. Return a dictionary of dependencies for the NNNI module.
change version back
@@ -350,6 +350,15 @@ class GitHubDriver extends VcsDriver protected function authorizeOAuth() { + // If available use token from git config + exec('git config github.accesstoken', $output, $returnCode); + if ($returnCode === 0 && !empty($output[0])) + { + $this->io->write('Using Github OAuth token sto...
[GitHubDriver->[getRootIdentifier->[getRootIdentifier],authorizeOAuth->[getContents],fetchRootIdentifier->[getContents],getComposerInformation->[getComposerInformation],getUrl->[getUrl],getTags->[getTags],getSource->[getSource,getUrl],attemptCloneFallback->[generateSshUrl,initialize],getDist->[getDist],getBranches->[ge...
Authorize the user for OAuth.
Please use the process executor instead of using `exec` directly. Btw, `exec` does not capture the error output (at least on Windows) so it is a bad idea.
@@ -520,6 +520,7 @@ func convertMasterProfileToVLabs(api *MasterProfile, vlabsProfile *vlabs.MasterP vlabsProfile.SinglePlacementGroup = api.SinglePlacementGroup vlabsProfile.CosmosEtcd = api.CosmosEtcd vlabsProfile.AuditDEnabled = api.AuditDEnabled + vlabsProfile.UltraSSDEnabled = api.UltraSSDEnabled convertCu...
[SetSubnetIPv6,Distro,DependenciesLocation,Sprintf,SetSubnet,OSType,ProvisioningState,AgentPoolProfileRole,KubeProxyMode,Make]
convertKeyVaultSecretsToVlabs converts a list of key - value pairs into a convertAgentPoolProfileToVLabs converts an agent pool profile from the vSphere API.
We need the equivalent conversion boilerplate for agentPoolProfiles as well.