patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -413,7 +413,7 @@ namespace Dynamo.Controls
// Always set old ZIndex to the last value, even if mouse is not over the node.
oldZIndex = NodeViewModel.StaticZIndex;
- if (!previewEnabled) return; // Preview is hidden. There is no need run further.
+ if (!previewEnabled... | [NodeView->[ExpandPreviewControl->[IsMouseOver,IsTestMode,IsCondensed,Expanded,TransitionToState],NodeViewReady->[OnNodeViewReady],OnPreviewControlMouseLeave->[GetPosition,Condensed,Control,IsInTransition,StaysOpen,IsMouseInsideNodeOrPreview,Captured,TransitionToState,Modifiers],OnNodeViewMouseEnter->[Condensed,IsInTra... | OnNodeViewMouseEnter - MouseEnter handler. | @aosyatnik - we are seeing crashes with custom nodes and sliders in the latest builds. Could this be related? Let me know |
@@ -26,6 +26,7 @@ namespace System.Net.WebSockets.Client.Tests
}).ToArray();
public const int TimeOutMilliseconds = 20000;
+ public const int BrowserTimeOutMilliseconds = 30000;
public const int CloseDescriptionMaxLength = 123;
public readonly ITestOutputHelper _output;
| [ClientWebSocketTestBase->[Task->[Equal,Aborted,action,InvalidState,GetConnectedWebSocket,WebSocketErrorCode,State],ReceiveEntireMessageAsync->[MessageType,CloseStatusDescription,Offset,ReceiveAsync,Count,CloseStatus,EndOfMessage,Array],OK,Format,Uri,Faulted,NotAWebSocket,GetExceptionMessage,Host,Port,WebSocketsSupport... | A class that implements the standard WebSocket client test cases. Test cancellation action for client - side WebSockets. | as far as I can tell, this is just upper boundary. I think it would be ok to just bump up TimeOutMilliseconds instead of creating new variable. If you feel this should be different, I would put the logic here instead of dragging Browser branches through the tests. |
@@ -1,4 +1,4 @@
-# Copyright 2013-2021 Lawrence Livermore National Security, LLC and other
+# Copyright 2013-2020 Lawrence Livermore National Security, LLC and other
# Spack Project Developers. See the top-level COPYRIGHT file for details.
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
| [PyPytest->[depends_on,version]] | Creates an instance of a single sequence number. Find all packages that require setuptools and not in runtime. This is a workaround for the issue with the - setuptools command. | Undo this change |
@@ -23,7 +23,7 @@ class PythonSetup(Subsystem):
def register_options(cls, register):
super().register_options(register)
register('--interpreter-constraints', advanced=True, fingerprint=True, type=list,
- default=['CPython>=2.7,<3', 'CPython>=3.6,<4'],
+ default=['CPython>=3.6,<4'],
... | [PythonSetup->[interpreter_constraints->[tuple,get_options],use_manylinux->[get_options],platforms->[get_options],get_environment_paths->[split,getenv],chroot_cache_dir->[get_options,join],resolver_allow_prereleases->[get_options],get_pyenv_paths->[append,isdir,sorted,join,pyenv_root_func,listdir],register_options->[re... | Register options for the command line tool. Adds options for the missing - unused - value command. | This is a breaking change for any shop with only python2 available. For them, without ever setting `--interpreter-constraints` things just worked since all their machines had python2.7 only. On upgrade, they break, albeit with a workaround. I think this violates our deprecation policy. Although I'm happy to see this sw... |
@@ -56,4 +56,11 @@ public interface SensitivePropertyProvider {
* @return the raw value to be used by the application
*/
String unprotect(String protectedValue) throws SensitivePropertyProtectionException;
+
+ /**
+ * Closes any clients that may have been opened by the SPP and releases
+ * a... | [No CFG could be retrieved] | Unprotect the protected value. | What do you think about using slightly more generic language, like "Cleans up any resources allocated by the SPP", and naming this `cleanUp()`? |
@@ -125,7 +125,7 @@ module Idv
end
def new_idv_session
- { step_attempts: { phone: 0 } }
+ {}
end
def move_pii_to_user_session
| [Session->[session->[fetch],complete_session->[phone_confirmed?],cache_encrypted_pii->[save,new],create_profile_from_applicant_with_password->[profile_id,build_profile_maker,pii_attributes,id,pii,save_profile],proofing_started?->[present?],create_gpo_entry->[perform,new,is_a?,new_from_json,otp,pii],build_profile_maker-... | missing - idv - session - nak - session - nak - session - n. | ditto for keeping the old data until next deploy |
@@ -917,6 +917,14 @@ func (ui *UI) PromptYesNo(_ libkb.PromptDescriptor, p string, def libkb.PromptDe
return ui.Terminal.PromptYesNo(p, def)
}
+func (ui *UI) GetSize() (width int, height int, error error) {
+ w, h := ui.Terminal.GetSize()
+ return w, h, nil
+}
+
+var _ libkb.TerminalUI = (*UI)(nil)
+var _ libkb.Du... | [FinishWebProofCheck->[GetDomain,GetCheckText,GetCachedMsg,GetHostname,GetDiff,GetHumanURL,GetHint,ReportHook,GetTorWarning,ToDisplayString,GetError,GetProtocol],Warning->[Warning],Printf->[OutputWriter],DisplayRecheckWarning->[render],FinishSocialProofCheck->[GetService,GetCachedMsg,GetSnoozedError,GetHumanURL,GetDiff... | PromptYesNo prompts the user for a yes or no confirmation. | Do we want the `error` here? It doesn't seem to be used. in `Terminal.GetSize()` it just defaults to 80,24 if `open()` errors |
@@ -48,7 +48,7 @@ public abstract class AbstractAddVariablePropertyTransformer extends AbstractMes
else
{
Object value = valueEvaluator.resolveValue(message);
- if (value == null)
+ if (value == null || value instanceof NullPayload)
{
me... | [AbstractAddVariablePropertyTransformer->[initialise->[initialise],clone->[clone]]] | This method is called to transform a message by using the identifier evaluator and the value evaluator. | Does it make sense adding a static method NullPayload.isNull() which does null check too, or something similar? Or is this check only going to happen like this on specific occasions? |
@@ -599,8 +599,11 @@ class TestESAddonSerializerOutput(AddonSerializerOutputTestMixin, ESTestCase):
def search(self):
self.reindex(Addon)
- qs = AddonSearchView().get_queryset()
- return qs.filter('term', id=self.addon.pk).execute()[0]
+ view = AddonSearchView()
+ view.reques... | [TestReplacementAddonSerializer->[test_valid_addon_path->[serialize],test_invalid_addons->[serialize],test_valid_collection_path->[serialize],test_invalid_collections->[serialize]],TestESAddonAutoCompleteSerializer->[test_translations->[serialize],test_basic->[serialize],test_icon_url_persona_with_no_persona_id->[seria... | Search for a object. | nit : we use `qs` pretty much everywhere. Applies to a lot of other parts below. |
@@ -124,6 +124,9 @@ class RunTracker(Subsystem):
# Note that multiple threads may share a name (e.g., all the threads in a pool).
self._threadlocal = threading.local()
+ # A logger facade that logs into this RunTracker.
+ self._logger = RunTrackerLogger(self)
+
# For background work. Created laz... | [RunTracker->[background_worker_pool->[get_background_root_workunit],end_workunit->[end_workunit,end],store_stats->[write_stats_to_json,post_stats],post_stats->[do_post->[error,do_post],error,do_post],new_workunit_under_parent->[start],end->[store_stats,new_workunit,log],_create_dict_with_nested_keys_and_val->[_create_... | Initialize the object with a single object. Check if there is a nag object in the chain. | This has the RunTracker acting as middle-man so that folks who just need a logger now need to instead get a runtracker and pull on its logger. It seems a bit better to me to: 1. short term: prefer those folks construct a RunTrackerLogger for which they depend on a RunTracker subsystem 2. cleanup: have those folks depen... |
@@ -845,7 +845,7 @@ public class UpdateCenter extends AbstractModelObject implements Saveable, OnMas
* Loads the data from the disk into this object.
*/
public synchronized void load() throws IOException {
- UpdateSite defaultSite = new UpdateSite(ID_DEFAULT, config.getUpdateCenterUrl() + "updat... | [UpdateCenter->[getConnectionCheckJob->[getSite,getConnectionCheckJob],updateDefaultSite->[getSite],getAvailables->[getAvailables],getCategorizedAvailables->[getAvailables],UpdateCenterJob->[submit->[submit]],isRestartScheduled->[getJobs],HudsonDowngradeJob->[getURL->[getData],onSuccess->[Success],run->[onSuccess,_run,... | Loads the configuration from the file. | I would go for creating a `protected` method thats creates the `UpdateSite` with the default id (obtained from the system property) and configuration as arguments. This allows subclasses to override the creation. The `LEGACY_ID_DEFAULT` should be referenced in `UpdateSite#isLegacyDefault`, shouldn't it? |
@@ -106,8 +106,8 @@ func (cfg SchemaConfig) hourlyBuckets(from, through model.Time, userID string, m
)
for i := fromHour; i <= throughHour; i++ {
- relativeFrom := util.Max64(i*millisecondsInHour, int64(from))
- relativeThrough := util.Min64((i+1)*millisecondsInHour, int64(through))
+ relativeFrom := util.Max6... | [GetReadEntriesForMetricLabel->[GetReadEntriesForMetricLabel,forSchemas],GetReadEntriesForMetricLabelValue->[GetReadEntriesForMetricLabelValue,forSchemas],hourlyBuckets->[tableForBucket],dailyBuckets->[tableForBucket],GetWriteEntries->[GetWriteEntries,forSchemas],GetReadEntriesForMetric->[GetReadEntriesForMetric,forSch... | hourlyBuckets returns a slice of index entries for the given time range for the given user. | I'm having trouble understanding how this works. First, the `relative...` naming is confusing - if I understand correctly, the resulting `relativeFrom` and `relativeThrough` timestamps are used as absolute bucket timestamps in the schema's `GetWriteEntries()` etc. functions. So if that's true, how can it be right to st... |
@@ -464,7 +464,7 @@ class SDFProcessElementInvoker(object):
with self._checkpoint_lock:
if checkpoint_state.checkpointed:
return
- checkpoint_state.residual_restriction = tracker.checkpoint()
+ checkpoint_state.residual_restriction = tracker.try_claim(0)
checkpoint_state.chec... | [PairWithRestrictionFn->[process->[ElementAndRestriction]],SplitRestrictionFn->[process->[ElementAndRestriction]],SDFProcessElementInvoker->[invoke_process_element->[Result,CheckpointState,initiate_checkpoint]]] | Invokes the process method of a Splittable DoFn with a given base - number of elements Yields a single element. | Are you meaning `try_split(0)`? |
@@ -2758,7 +2758,7 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
return initLevel;
}
- public void setNumExecutors(int n) throws IOException {
+ public void setNumExecutors(@Nonnegative int n) throws IOException, IllegalArgumentException {
if (this.nu... | [Jenkins->[getAllItems->[getAllItems],getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],_cleanUpCloseDNSMulticast->[add],getViewActions->[getActions],getJDK->[getJDKs],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredV... | This method is called to set the number of executors. | Hmm, does it really throw `IllegalArgumentException`? |
@@ -5404,7 +5404,7 @@ inline void gcode_M42() {
* L = Number of legs of movement before probe
* S = Schizoid (Or Star if you prefer)
*
- * This function assumes the bed has been homed. Specifically, that a G28 command
+ * This function assumes the bed has been homed. Specifically, that a comm... | [No CFG could be retrieved] | Z probe repeatability measurement function. - - - - - - - - - - - - - - - - - -. | This edit is not needed. Please undo. |
@@ -898,7 +898,11 @@ func (orm *ORM) FindJobIDsWithBridge(bridgeName string) ([]models.JobID, error)
// IdempotentInsertEthTaskRunTx creates both eth_task_run_transaction and eth_tx in one hit
// It can be called multiple times without error as long as the outcome would have resulted in the same database state
-fun... | [preloadJobRuns->[Unscoped],createJob->[MustEnsureAdvisoryLock],ArchiveJob->[convenientTransaction],JobRunsSortedFor->[MustEnsureAdvisoryLock,JobRunsCountForGivenStatus,JobRunsCountFor,preloadJobRuns],CreateBridgeType->[MustEnsureAdvisoryLock],UpdateBridgeType->[MustEnsureAdvisoryLock],PendingBridgeType->[MustEnsureAdv... | IdempotentInsertEthTaskRunTx creates an immutable transaction that can be used get a node from the network. | Ahh I see why, the meta.taskrunid is required here |
@@ -16,15 +16,14 @@
*/
package org.apache.dubbo.config.spring.beans.factory.annotation;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.apache.dubbo.common.utils.Assert;
import org.apache.dubbo.config.AbstractConfig;
import org.apache.dubbo.config.spring.context... | [DubboConfigBindingBeanPostProcessor->[afterPropertiesSet->[setIgnoreInvalidFields,setIgnoreUnknownFields]]] | Imports a single object. Dubbo config binding bean post processor. | As above mentioned, the order should be changed |
@@ -188,6 +188,10 @@ def pick_types(info, meg=True, eeg=False, stim=False, eog=False, ecg=False,
"""
# NOTE: Changes to this function's signature should also be changed in
# PickChannelsMixin
+ from .meas_info import Info
+ if not isinstance(info, Info):
+ raise TypeError('info must be an in... | [pick_types_forward->[pick_types,pick_channels_forward],pick_channels_cov->[pick_channels],channel_indices_by_type->[channel_type],pick_channels_forward->[pick_channels],_picks_by_type->[pick_types],pick_channels_evoked->[pick_info,pick_channels],pick_types->[pick_channels]] | Pick channels by type. Picks a from the info dict. This function checks if a specific type of channel is available in the system. pick channels that have a in the channel list. | FYI I made this change because we had no check to ensure `info` was an instance of `Info` here before, and I got some weird error when I accidentally passed `raw` instead of `raw.info`. We could relax this check to `isinstance(info, (Info, dict))` but I'd prefer to keep it more strict to `Info` for now to help ensure p... |
@@ -326,9 +326,15 @@ func (consensus *Consensus) ParseNewViewMessage(msg *msg_pb.Message) (*FBFTMessa
utils.Logger().Warn().Err(err).Msg("ParseViewChangeMessage failed to parse senderpubkey")
return nil, err
}
- FBFTMsg.SenderPubkey = pubKey
- copy(FBFTMsg.SenderPubkeyBytes[:], vcMsg.SenderPubkey[:])
+ FBFTMs... | [DeleteBlocksLessThan->[Blocks],HasMatchingViewAnnounce->[GetMessagesByTypeSeqViewHash],GetBlocksByNumber->[Blocks],DeleteBlockByNumber->[Blocks],GetMessagesByTypeSeq->[Messages],HasMatchingAnnounce->[GetMessagesByTypeSeqHash],GetMessagesByTypeSeqHash->[Messages],GetMessagesByTypeSeqView->[Messages],DeleteMessagesLessT... | ParseNewViewMessage parses a new view message and returns a new FBFTMessage Parse the M3 message and create a FBFT message. | can we also cache participants to mask per epoch? can be done in the next PR. |
@@ -2247,6 +2247,13 @@ close_reopen_coh_oh(test_arg_t *arg, struct ioreq *req, daos_obj_id_t oid)
static void
tx_discard(void **state)
{
+ /*
+ * FIXME: This obsolete epoch model transaction API test have been
+ * broken by online aggregation, needs be removed or updated as per
+ * new transaction model.
+ */
+ ... | [insert_recxs->[insert_recxs_nowait,insert_wait],lookup_empty_single->[lookup],lookup_single->[lookup],void->[insert_test,ioreq_init,insert_wait,lookup_single,enumerate_dkey,lookup,punch_akey,lookup_single_with_rxnr,punch_dkey,insert,punch_obj,close_reopen_coh_oh,ioreq_fini,insert_single_with_rxnr,insert_nowait,insert_... | - - - - - - - - - - - - - - - - - - Write three timestamps to same set of d - key and a - keys. Transaction - related functions Transaction - related functions Frees all records in req. ioreq. | should use skip(); ? That way skipped tests are in report. |
@@ -17,6 +17,7 @@ module Reports
end
def transaction_with_timeout
+ Db::EstablishConnection::ReadReplica.call
ActiveRecord::Base.transaction do
ActiveRecord::Base.connection.execute("SET LOCAL statement_timeout = #{report_timeout}")
yield
| [BaseReport->[class_name->[name],save_report->[info,s3_reports_enabled!,upload_file_to_s3_timestamped_and_latest],generate_s3_paths->[strftime,env,year,now],gen_s3_bucket_name->[s3_report_bucket_prefix!,region,account_id],upload_file_to_s3_bucket->[info,debug,object,put],ec2_data->[load],upload_file_to_s3_timestamped_a... | Creates a new transaction with a timeout. | Do we need to do something to clean up the read replica connection? |
@@ -68,6 +68,7 @@ public class OidcIdTokenGeneratorServiceTests extends AbstractOidcTests {
when(accessToken.getAuthentication()).thenReturn(authentication);
when(accessToken.getTicketGrantingTicket()).thenReturn(tgt);
when(accessToken.getId()).thenReturn(getClass().getSimpleName());
+ ... | [OidcIdTokenGeneratorServiceTests->[verifyTokenGenerationWithoutCallbackService->[setAttribute,assertNotNull,of,CommonProfile,getSimpleName,thenReturn,getAuthentication,mock,generate,MockHttpServletResponse,setId,getRegisteredOAuthServiceByClientId,wrap,MockHttpServletRequest,setClientName],verifyTokenGenerationFailsWi... | Verify token generation. Returns a new instance of the class that will be used to create the class. | Scopes need not be hardcoded as strings. They are available as an enum |
@@ -22,7 +22,7 @@ import { ITEMS_PER_PAGE } from 'app/shared/constants/pagination.constants';
@Injectable({providedIn: 'root'})
export class PaginationConfig {
- constructor(private config: NgbPaginationConfig) {
+ constructor(config: NgbPaginationConfig) {
config.boundaryLinks = true;
confi... | [No CFG could be retrieved] | NgPaginationConfig provides a basic pagination configuration for the NgPagination component. | why did you made it public? (and why the other are too...) |
@@ -178,15 +178,15 @@ public class GlueHiveMetastore
{
if (config.getAwsAccessKey().isPresent() && config.getAwsSecretKey().isPresent()) {
return new AWSStaticCredentialsProvider(
- new BasicAWSCredentials(config.getAwsAccessKey().get(), config.getAwsSecretKey().get()));
+ ... | [GlueHiveMetastore->[dropColumn->[getTableOrElseThrow,replaceTable],getPartitionNames->[getTableOrElseThrow],dropTable->[getTableOrElseThrow],createTable->[createTable],renameColumn->[getTableOrElseThrow,replaceTable],getPartitionNamesByParts->[getTableOrElseThrow],updateTableStatistics->[getTableOrElseThrow,getTableSt... | Returns a AWSCredentialsProvider based on the AWS credentials. | Please also fix indentation in `presto-hive/src/main/java/io/prestosql/plugin/hive/ConnectorObjectNameGeneratorModule.java`, `presto-hive/src/main/java/io/prestosql/plugin/hive/HivePartitionManager.java` and `presto-hive/src/test/java/io/prestosql/plugin/hive/TestBackgroundHiveSplitLoader.java` |
@@ -16,7 +16,8 @@
text-align: center;
}
.elgg-pagination li {
- display: inline;
+ display: inline-block;
+ height: 24px;
margin: 0 6px 0 0;
text-align: center;
}
| [No CFG could be retrieved] | Provides a list of options for a specific item in the list of items that are related to Displays a list of all items that have a specific key value. | In the IE7 CSS you'll want to add `.elgg-pagination li` to the inline-block fixes selectors. |
@@ -57,6 +57,16 @@ namespace Dynamo.PackageManager
PackageLoader.RequestLoadCustomNodeDirectory -=
RequestLoadCustomNodeDirectoryHandler;
}
+ if (RequestLoadExtension != null)
+ {
+ PackageLoader.RequestLoadExtension -=
+ ... | [PackageManagerExtension->[LoadPackages->[DoCachedPackageUninstalls,LoadAll],Startup->[Preferences,Value,PathManager,Absolute,Info,Settings,RequestLoadNodeLibrary,RequestLoadCustomNodeDirectory,Location,OnMessageLogged,AddUninitializedCustomNodesInPath,LoadNodeLibrary,MessageLogged,DefaultPackagesDirectory,SetEngineVer... | Dispose of the object. | Really strange whitespace here. Possibly an editing defect? |
@@ -32,7 +32,7 @@ class WPSEO_Cornerstone_Filter extends WPSEO_Abstract_Post_Filter {
$where .= sprintf(
' AND ' . $wpdb->posts . '.ID IN( SELECT post_id FROM ' . $wpdb->postmeta . ' WHERE meta_key = "%s" AND meta_value = "1" ) ',
- WPSEO_Meta::$meta_prefix . WPSEO_Cornerstone::META_NAME
+ WPSEO_Meta::... | [WPSEO_Cornerstone_Filter->[filter_posts->[is_filter_active],get_explanation->[get_current_post_type],get_post_total->[get_var,get_current_post_type,prepare]]] | Filter posts by meta key and value. | Is there a specific reason why we don't have a class constant or method to provide this value? Having a string for this increases the risk of typos and inconsistent implementations. |
@@ -0,0 +1,14 @@
+from django.conf import settings
+from django.db import models
+
+
+class BaseNote(models.Model):
+ user = models.ForeignKey(
+ settings.AUTH_USER_MODEL, blank=True, null=True,
+ on_delete=models.SET_NULL)
+ date = models.DateTimeField(db_index=True, auto_now_add=True)
+ content... | [No CFG could be retrieved] | No Summary Found. | This model has to be abstract. We don't want to save instances of `BaseNote` in the database, but only the derived models such as `OrderNote` or `CustomerNote`. |
@@ -20,6 +20,16 @@ class ImageUploadResponsePresenter
@form.remaining_attempts
end
+ def status
+ if success
+ :ok
+ elsif @form_response.errors.key?(:limit)
+ :too_many_requests
+ else
+ :bad_request
+ end
+ end
+
def as_json(*)
if success
{ success: true }
| [ImageUploadResponsePresenter->[remaining_attempts->[remaining_attempts]]] | get remaining attempts nag array. | I know the method `success` is old but since it's a predicate, WDYT of renaming it `success?` to match other `success?` methods we have? |
@@ -18,15 +18,15 @@ from .meta_optimizer_base import MetaOptimizerBase
class RecomputeOptimizer(MetaOptimizerBase):
def __init__(self, optimizer):
super(RecomputeOptimizer, self).__init__(optimizer)
- #self.inner_opt = RO(optimizer)
self.inner_opt = optimizer
- self.wrapped_opt = R... | [RecomputeOptimizer->[minimize_impl->[minimize],backward->[backward],_can_apply->[len],_set_basic_info->[list,super,_set_checkpoints],__init__->[RO,super]]] | Initialize the optimizer with a single node. | help remove this from the `meta_optimizers_white_list` of RecomputeOptimizer. |
@@ -241,3 +241,18 @@ func GetPortFromDiff(port string, diff int) string {
GetLogInstance().Error("error on parsing port.")
return ""
}
+
+// ReadStringFromFile reads string from a file.
+func ReadStringFromFile(fileName string) (string, error) {
+ data, err := ioutil.ReadFile(fileName)
+ if err != nil {
+ return ... | [Unlock,MarshalIndent,Close,Compile,UnmarshalPrivateKey,Atoi,Copy,IsNotExist,ConfigDecodeKey,Error,ConfigEncodeKey,Init,New,Lock,Errorf,ParseCIDR,Bytes,Create,GenerateKeyPairWithReader,Contains,NewDecoder,MarshalPrivateKey,Write,ReplaceAllString,NewSource,NewReader,Panic,Sprintf,Decode,GetAddress,Print,SetBytes,Open,Ge... | error on parsing port. | This function shouldn't be necessary. |
@@ -1238,7 +1238,10 @@ class Flow:
self.validate()
schema = prefect.serialization.flow.FlowSchema
- serialized = schema(exclude=["storage"]).dump(self)
+ flow_copy = self.copy()
+ for task, slug in flow_copy.slugs.items():
+ task.slug = slug
+ serialized = sche... | [Flow->[copy->[copy],upstream_tasks->[edges_to],_run->[copy,update],load->[load],update->[add_edge,add_task,update],reference_tasks->[terminal_tasks],chain->[add_edge],edges_to->[all_upstream_edges],set_dependencies->[add_edge,add_task],run->[parameters,_run],edges_from->[all_downstream_edges],validate->[reference_task... | Serializes this flow into a serialized version of a . | Could you add a `#NOTE` here that this is undesirable and only due to the current serialization approach; I don't want anyone to hesitate to rip it out in the future when we can! |
@@ -4,6 +4,10 @@ RSpec.describe EdgeCache::Bust, type: :service do
let(:user) { create(:user) }
let(:path) { "/#{user.username}" }
+ it "defines TIMEFRAMES" do
+ expect(described_class.const_defined?(:TIMEFRAMES)).to be true
+ end
+
describe "#bust_fastly_cache" do
let(:fastly_provider_class) { Edg... | [configure_fastly->[to,and_return],configure_nginx->[to,and_return],stub_fastly->[to,and_return],stub_nginx->[to,and_return],call,create,context,to,let,have_received,new,describe,before,not_to,receive,username,it,require] | Provides a description of a Bust service. cache - level tests. | I would use `Timecop` to test that by moving forward or backwards in time those timeframes adjust to the current time inside the Timecop block, just to be on the safe side (I think testing one of them is enough) |
@@ -137,7 +137,7 @@ class SimpleCache {
*/
function enable() {
$this->datalist->set('simplecache_enabled', 1);
- $this->config->set('simplecache_enabled', 1);
+ $this->config->save('simplecache_enabled', 1);
$this->invalidate();
}
| [SimpleCache->[invalidate->[getPath],getUrl->[registerView]]] | Enable SimpleCache. | The simplecache status is stored in the datalists table, which is read into config on the next request. So this isn't necessary. |
@@ -390,7 +390,12 @@ ds_pool_find_bylabel(d_const_string_t label, uuid_t pool_uuid,
if (ranks == NULL)
D_GOTO(out_resp, rc = -DER_NOMEM);
*svc_ranks = ranks;
- uuid_parse(frsp->uuid, pool_uuid);
+ rc = uuid_parse(frsp->uuid, pool_uuid);
+ if (rc != 0) {
+ D_ERROR("Unable to parse pool UUID %s: "DF_RC"\n", frsp-... | [ds_get_pool_svc_ranks->[dss_drpc_call],ds_notify_bio_error->[dss_drpc_call],ds_pool_find_bylabel->[dss_drpc_call],drpc_notify_ready->[dss_drpc_call]] | dss_drpc_pool_find_bylabel - find pool by label find pool by label response. | Generally, if a function like ds_pool_find_bylabel returns an error, its caller is not expected to look at pool_uuid and *svc_ranks. So we should free ranks before returning the -DER_INVAL. E.g., something like rc = uuid_parse(...); if (rc != 0) { ... D_FREE(*svc_ranks); D_GOTO(...); } Additionally, is -DER_INVAL reall... |
@@ -505,6 +505,15 @@ func IsPoolUpdated(dc dynamic.NamespaceableResourceInterface, name string) (bool
framework.Logf("error getting pool %s: %v", name, err)
return false, nil
}
+ paused, found, err := unstructured.NestedBool(pool.Object, "spec", "paused")
+ if err != nil || !found {
+ return false, nil
+ }
+ i... | [ExpectNoError,DeepCopy,Resource,Now,RetryOnConflict,It,Events,Atoi,NewForConfigOrDie,LoadConfig,ClusterStatusConditionType,EventsV1,Reached,GetName,NewOpenShiftAvailableWithConnectionReuseTest,NewKubeAvailableWithNewConnectionsTest,Errorf,MustParseSemantic,Sub,Logf,ConfigV1,PollImmediate,WaitForOperatorsToSettle,Shoul... | IsPoolUpdated checks if a pool is updated or not Checks if the object has the correct type and status. | I'm restructuring this slightly into #25922 |
@@ -47,6 +47,7 @@ func resourceAwsLaunchTemplate() *schema.Resource {
"description": {
Type: schema.TypeString,
Optional: true,
+ Default: "Managed by Terraform",
ValidateFunc: validation.StringLenBetween(0, 255),
},
| [StringLenBetween,StringValueSlice,GetChangedKeysPrefix,DescribeLaunchTemplates,NewSet,UniqueId,SetPartial,BoolValue,IsNewResource,StringInSlice,Partial,HasPrefix,Set,Add,DeleteLaunchTemplate,CreateLaunchTemplate,Itoa,FormatBool,Int64Value,Format,Error,GetOk,ParseBool,Sequence,Errorf,Len,SetId,Bool,ComputedIf,Time,Pref... | ec2 - launch - template The Schema for the device and virtual names. | We should skip adding our own default here. Its an old practice and will cause unexpected differences for existing Terraform configurations when added like this. |
@@ -34,7 +34,7 @@ public class TestJsonUtils
public static class TestObject
{
@JsonProperty
- private TestEnum testEnum;
+ public TestEnum testEnum;
}
@Test
| [TestJsonUtils->[testLowercaseEnum->[getBytes,parseJson,isEqualTo]]] | Test case of a . | Please squash this change with the commit that broke this test. |
@@ -10,7 +10,7 @@ namespace DotNetNuke.Prompt
{
[Serializable]
[JsonObject]
- public class Command : ICommand
+ public class Command : IDnnCommand
{
/// <inheritdoc/>
public string Key { get; set; }
| [No CFG could be retrieved] | is a base class for all commands that are part of the system. | I believe to be non-breaking here that this object must inherit from BOTH ICommand and IDnnCommand @bdukes can you confirm this for me? |
@@ -107,7 +107,7 @@ namespace CoreNodeModels.Input
ShouldDisplayPreviewCore = false;
}
- public Filename() : base("Filename")
+ public Filename() : base(Resources.FilePathOutputDescription)
{
ShouldDisplayPreviewCore = false;
}
| [DirectoryObject->[DirectoryObjectDisposable->[Dispose->[Dispose],watcher_Changed->[Modified]]],FileObject->[IDisposable->[Directory],FileObjectDisposable->[Dispose->[Dispose],watcher_Changed->[Modified]]],FileSystemObject->[OnBuilt->[OnBuilt],StopWatching->[Dispose],Dispose->[Dispose],DataBridgeCallback->[StopWatching... | XmlElement - based deserialization methods Creates a base class for nodes that instantiate a File System Object that also watches the file system. | @martinstacey I think you also need to update the node description by updating the `FilenameNodeDescription` resource string. Currently it says `Allows you to select a file on the system to get its filename.`. It should be changed to read `...file path`. |
@@ -222,10 +222,16 @@ namespace System.Net.Quic.Implementations.Mock
public long _outboundErrorCode;
public long _inboundErrorCode;
+ private const int InitialBufferSize =
+#if DEBUG
+ 10;
+#else
+ 4096;
+#endif
public StreamState(long st... | [MockStream->[Write->[Write,CheckDisposed],Flush->[CheckDisposed],ReadAsync->[CheckDisposed,_outboundErrorCode,_inboundErrorCode,ConfigureAwait],AbortWrite->[_inboundErrorCode,_outboundErrorCode],CheckDisposed->[nameof],Shutdown->[CheckDisposed],Read->[CheckDisposed,Read],ValueTask->[EndWrite,CheckDisposed,CompletedTas... | StreamState - Stream state. | Can we similarly set the max buffer size to something very small in debug? |
@@ -25,6 +25,9 @@
/// <param name="destination">Destination endpoint.</param>
public void RouteToEndpoint(Type messageType, string destination)
{
+ if(destination.Contains("@"))
+ throw new ArgumentException($"Expected an endpoint name but received '{destination}'. U... | [RoutingSettings->[RouteToEndpoint->[RouteToEndpoint]]] | Route to endpoint. | Is > Use routing file to specify physical address of the endpoint. correct? If I understand correctly the file based routing was moved to MSMQ only |
@@ -49,6 +49,12 @@ public class InterceptorBuilderImpl extends AbstractBeanBuilder implements Inter
private BeanManagerImpl beanManager;
+ private BeanDeploymentFinder beanDeploymentFinder;
+
+ public InterceptorBuilderImpl() {
+ this(null);
+ }
+
public InterceptorBuilderImpl(BeanManagerI... | [InterceptorBuilderImpl->[addBinding->[addAll],addBindings->[addAll],bindings->[clear,addAll],build->[BuilderInterceptorBean,noInterceptionFunction,noInterceptionType]]] | Creates a new InterceptorBuilder. Adds bindings to the interceptor. | I personally don't like this much but didn't invent anything better in this case. |
@@ -92,8 +92,10 @@ public class PolicyNextActionMessageProcessor extends AbstractComponent implemen
return from(publisher)
.doOnNext(coreEvent -> logExecuteNextEvent("Before execute-next", coreEvent.getContext(),
coreEvent.getMessage(), muleContext.getCo... | [PolicyNextActionMessageProcessor->[saveState->[singletonMap,quickCopy],toPolicyLocation->[getPartPath],loadState->[getInternalParameter],initialise->[getId,PolicyNotificationHelper,getNotificationManager],popBeforeNextFlowFlowStackElement->[pop],process->[processToApply],isEventContextHandledByThisNext->[getInternalPa... | Apply the policy next - operation to the given publisher. | i think default should be `false`? |
@@ -80,6 +80,10 @@ module.exports = {
},
},
+ junitReporter: {
+ useBrowserName: false,
+ },
+
port: 9876,
colors: true,
| [No CFG could be retrieved] | Exports the configuration of the given Karma constant. Chrome CI client. | It seems weird to set one sub-option statically (here) and the others dynamically (in `runtime-test-base.js`). Given that this is only applicable during CI, I think it's safe to move this to the dynamic section as well. |
@@ -521,7 +521,7 @@ def JINJA_CONFIG():
# Details: http://jinja.pocoo.org/2/documentation/api#bytecode-cache
# and in the errors you get when you try it the other way.
bc = jinja2.MemcachedBytecodeCache(cache._cache,
- "%s:j2:" % settings.CACHE_PREFIX... | [get_user_url->[reverse],get_locales->[_Language,items,join,open,load],JINJA_CONFIG->[MemcachedBytecodeCache,isinstance],abspath,path,node,_,dict,dirname,namedtuple,setup_loader,sorted,tuple,dumps,join,items,get_locales,%,lower,reverse_lazy] | Jinja configuration for a object. | I realize this probably stands for "jinja2" but I'm cache bumpin' it because :tada: :boom: |
@@ -56,6 +56,10 @@ module UsersGenerator
end
end
+ # Assing user organization as user currentorganization
+ nu.current_organization_id = nu.organizations.first.id
+ nu.save!
+
nu.reload
return nu
end
| [create_user->[create,new,create_private_user_organization,save!,get_user_initials,each,now,present?,reload,confirmed_at,find_by_id],create_private_user_organization->[create],generate_user_password->[hex,require],get_user_initials->[join],validate_user->[validate,get_user_initials,errors,new],print_user->[email,initia... | Creates a user in the system if it doesn t exist. | "Assign" and "current organization". Sorry for being a syntax Nazi :/. |
@@ -70,4 +70,8 @@ module AuthenticationHelper
def came_from_sign_up?
request.referer&.include?(new_user_registration_path)
end
+
+ def display_social_login?
+ Authentication::Providers.enabled.include?(:apple) || request.user_agent.to_s.exclude?("ForemWebView")
+ end
end
| [authentication_enabled_providers->[get!,map],authentication_enabled_providers_for_user->[enabled_for_user],authentication_provider->[get!],forem_creator_flow_enabled?->[waiting_on_first_user?,enabled?],available_providers_array->[map],waiting_on_first_user?->[waiting_on_first_user],authentication_provider_enabled?->[i... | Checks if the user is logged in and if so returns the index page. | We'll have to make sure that Android's concept of a web view doesn't use this same user agent! /cc @rt4914 |
@@ -5576,13 +5576,12 @@ example usage
}
- [ResourceExposure(ResourceScope.Process)]
- [ResourceConsumption(ResourceScope.Process)]
+
+
internal System.Drawing.Graphics CreateGraphicsInternal() {
return Graphics.FromHwndInternal(this.Handle);
... | [Control->[OnSystemColorsChanged->[OnSystemColorsChanged,Invalidate],UpdateRoot->[GetTopLevel],OnFontChanged->[GetAnyDisposingInHierarchy,Font,DisposeFontHandle,GetStyle,Invalidate],AccessibilityNotifyClients->[AccessibilityNotifyClients],OnParentFontChanged->[OnFontChanged],AutoValidate->[AutoValidate],OnParentBackCol... | CreateGraphicsInternal - internal method for a System. Drawing. Graphics object. | Please remove the extra lines |
@@ -69,6 +69,8 @@ public class HoodieHiveClient extends AbstractSyncHoodieClient {
private static final Logger LOG = LogManager.getLogger(HoodieHiveClient.class);
private final PartitionValueExtractor partitionValueExtractor;
private IMetaStoreClient client;
+ private SessionState sessionState;
+ private org... | [HoodieHiveClient->[close->[close],getAllTables->[getAllTables],constructChangePartitions->[getPartitionClause]]] | Creates a new instance of the HoodieClient class. Create a new instance of the partitionValueExtractor class. | Not really an issue from this PR. but do we need to really specify the full package name? `org.apache.hadoop.hive.ql.Driver`? |
@@ -892,9 +892,10 @@ TypeVarList = List[Tuple[str, TypeVarExpr]]
# Mypyc doesn't support callback protocols yet.
FailCallback = Callable[[str, Context, DefaultNamedArg(Optional[ErrorCode], 'code')], None]
+NoteCallback = Callable[[str, Context, DefaultNamedArg(Optional[ErrorCode], 'code')], None]
-def get_omitt... | [InstanceFixer->[visit_instance->[fix_instance]],TypeAnalyser->[anal_var_defs->[anal_array],bind_function_type_variables->[infer_type_variables,fail],analyze_callable_type->[get_omitted_any],tuple_type->[named_type],visit_unbound_type_nonoptional->[no_subscript_builtin_alias],get_omitted_any->[get_omitted_any],analyze_... | Get Any type from a type object. | This alias is identical to the above one. You can rename it to `MsgCallback` and use it to annotate both `fail` and `note`. |
@@ -66,6 +66,7 @@ class Trainer(TrainerBase):
local_rank: int = 0,
world_size: int = 1,
num_gradient_accumulation_steps: int = 1,
+ opt_level: Optional[str] = None,
) -> None:
"""
A trainer for doing supervised learning. It just takes a labeled dataset
| [Trainer->[_validation_loss->[batch_loss],_train_epoch->[rescale_gradients,batch_loss],rescale_gradients->[rescale_gradients],train->[_validation_loss,_train_epoch]]] | Initialize a new object with a base configuration. A list of all the classes that are associated with a specific . This is the default method for all training and training models. It is the default method for Log histograms of the model parameters and activations of a specific node in the model. | Can you add this to the docstring? |
@@ -69,7 +69,7 @@ class ShippingMethodPostalCodeRule(CountableDjangoObjectType):
]
-class ShippingMethod(ChannelContextTypeWithMetadata, CountableDjangoObjectType):
+class ShippingMethodType(ChannelContextTypeWithMetadata, CountableDjangoObjectType):
type = ShippingMethodTypeEnum(description="Type of ... | [ShippingZone->[resolve_price_range->[resolve_price_range]]] | Represents a shipping method postal code rule. The fields for the shipping method. | Now I noticed we didn't change the description for this type. Because now we will have two very similar types `ShippingMethodType` and `ShippingMethod`, we should update the description to make it clear what's the purpose of this one. Maybe something like: internal representation of a shipping method used in private AP... |
@@ -116,6 +116,9 @@ func (e *DeviceAdd) Run(ctx *Context) (err error) {
// run provisioner
if err = RunEngine(provisioner, ctx); err != nil {
+ if err == kex2.ErrHelloTimeout {
+ return errors.New("Failed to provision device: are you sure you typed the secret properly?")
+ }
return err
}
| [Run->[Phrase,ChooseDeviceType,LoginState,DisplayAndPromptSecret,GetPassphraseStream,Warning,G,WithCancel,NewKex2Secret,Background,ErrToOk,AddSecret,TODO,NewKex2SecretFromPhrase,Secret,Debug],NewContextified] | Run starts the device add process. DisplayAndPromptSecret is called when a secret is received from the user. | Change to exportable error. |
@@ -85,6 +85,9 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
f.DurationVar(&cfg.ChunkAgeJitter, "ingester.chunk-age-jitter", 20*time.Minute, "Range of time to subtract from MaxChunkAge to spread out flushes")
f.BoolVar(&cfg.SpreadFlushes, "ingester.spread-flushes", false, "If true, spread series flushes ac... | [LabelNames->[LabelNames],ShutdownHandler->[Shutdown],LabelValues->[LabelValues],RegisterFlags->[RegisterFlags],Shutdown->[Shutdown]] | RegisterFlags registers flags for the config Period with which to update the per - user ingestion rates. | Which flags do we typically turn on? If these are all debug flags, can we name this debug? |
@@ -89,7 +89,7 @@ public class AsynchronousCommitTracker {
return false;
}
- if (isDataQueued(connectable)) {
+ if (isDataQueued(connectable) || (connectable.isTriggerWhenEmpty() && isDataHeld(connectable))) {
logger.debug("{} {} is ready because it has data queued", t... | [AsynchronousCommitTracker->[triggerFailureCallbacks->[pop,isEmpty,handleCallbackFailure],isDataQueued->[getIncomingConnections,isEmpty],isAnyReady->[debug,isEmpty],addConnectable->[remove,add,debug],handleCallbackFailure->[debug,error,getFailureCallback,getConnectable,accept],isReady->[debug,isDataQueued,contains,remo... | Checks if a component is ready. | The new condition could go to a separate `if` with its own log message: "ready because it has data held" (or "ready because it has unacknowledged data"). The "not ready" log message could also be improved below: "not ready because it has no data queued or held". |
@@ -170,6 +170,11 @@ public abstract class HypervisorGuruBase extends AdapterBase implements Hypervis
offering.getRamSize() * 1024l * 1024l, null, null, vm.isHaEnabled(), vm.limitCpuUse(), vm.getVncPassword());
to.setBootArgs(vmProfile.getBootArgs());
+ String bootType = (String)vmPro... | [HypervisorGuruBase->[addServiceOfferingExtraConfiguration->[addExtraConfig],addExtraConfig->[addExtraConfig],toVirtualMachineTO->[addServiceOfferingExtraConfiguration,toNicTO,addExtraConfig]]] | This method converts a virtual machine profile to a virtual machine TO object. Adds the details of the network offerings and the virtual machine to the list of NIC Folder - > Config Drive - > State - > State. | less improtant, but consider: please extract, see above |
@@ -39,7 +39,7 @@ import com.typesafe.config.ConfigFactory;
/**
* A {@link DatasetsFinder} to find {@link DatasetStoreDataset}s.
*/
-public class DatasetStoreDatasetFinder implements DatasetsFinder<DatasetStoreDataset> {
+public class DatasetStoreDatasetFinder implements DatasetsFinder<Dataset> {
public stati... | [DatasetStoreDatasetFinder->[buildPredicate->[IllegalArgumentException,StoreNamePredicate,getString,hasNonEmptyPath,StateStorePredicate,DatasetPredicate],findDatasets->[toList,groupingBy,collect,getMetadataForTables],buildPredicate,buildDatasetStateStore,parseProperties]] | Package private for testing purposes. region DatasetFilter Methods. | I feel it's better to limit the type to DatasetStoreDataset here. However this will cause some incompatibility if you want to reuse the existing **ModificationTimeDataset**. That's why I don't like this class to be derived from **ModificationTimeDataset**. Please check with Issac to see if this type restriction can be ... |
@@ -148,6 +148,7 @@ func BuildKubernetesNodeConfig(options configapi.NodeConfig) (*NodeConfig, error
server.PodInfraContainerImage = imageTemplate.ExpandOrDie("pod")
server.CPUCFSQuota = true // enable cpu cfs quota enforcement by default
server.MaxPods = 110
+ server.SerializeImagePulls = false // disable serial... | [Warningf,Duration,NewKubeletAuth,Atoi,SecureTLSConfig,SplitHostPort,FromUnversionedClient,Env,UseTLS,Errorf,GetNamedCertificateMap,CertPoolFromFile,GetKubeClient,AnonymousClientConfig,UnsecuredKubeletConfig,Join,Infof,NewKubeletServer,NewAggregate,V,SingleTenantPluginName,ParseIP,NewDefaultImageTemplate,ExpandOrDie,Mu... | Initialize the Server object if is a helper function that resolves the command line flags and calls the kube - config. | This only affects when you're running the kubelet that is a symlink to /usr/bin/origin. Also need to update the appropriate origin files too. @liggitt which ones make the most sense - node_options.go? node_args.go? |
@@ -133,7 +133,6 @@ public class TestTableSchemaEvolution extends TestHoodieClientBase {
@Test
public void testMORTable() throws Exception {
tableType = HoodieTableType.MERGE_ON_READ;
- initMetaClient();
// Create the table
HoodieTableMetaClient.initTableType(metaClient.getHadoopConf(), metaCl... | [TestTableSchemaEvolution->[checkLatestDeltaCommit->[assertTrue,filterCompletedInstants,equals],getWriteConfig->[build],generateInsertsWithSchema->[generateInserts,convertToSchema,equals],testSchemaCompatibilityBasic->[assertTrue,replace,isSchemaCompatible,assertFalse],testCopyOnWriteTable->[assertTrue,insertFirstBatch... | Test MOR table. This method is used to insert records with a devolved schema and insertBatch inserts records with Updates records in the database. Insert records in the dataset. | already called in `setUp()` |
@@ -54,7 +54,13 @@ public class ExpressionVectorSelectors
String constant = plan.getExpression().eval(ExprUtils.nilBindings()).asString();
return ConstantVectorSelectors.singleValueDimensionVectorSelector(factory.getReadableVectorInspector(), constant);
}
- throw new IllegalStateException("Only co... | [ExpressionVectorSelectors->[createVectorBindings->[ExpressionVectorInputBinding,getRequiredBindingsList,makeObjectSelector,getType,addNumeric,getReadableVectorInspector,addObjectSelector,makeValueSelector,getColumnCapabilities],makeSingleValueDimensionVectorSelector->[plan,isConstant,singleValueDimensionVectorSelector... | Makes a single value dimension vector selector. | Can we also use `SingleStringInputDeferredEvaluationExpressionDimensionVectorSelector` when the plan is `SINGLE_INPUT_MAPPABLE`? |
@@ -106,8 +106,8 @@ function cron_run(&$argv, &$argc){
// Check every conversation
ostatus::check_conversations(false);
- // Set the gcontact-id in the item table if missing
- item_set_gcontact();
+ // Do post update functions
+ post_update();
// update nodeinfo data
nodeinfo_cron();
| [cron_clear_cache->[get_basepath],cron_run->[set_baseurl]] | The main function for the cron This function runs the processes to discover global contacts and update locally stored global contacts in the background This function is called from the command line. It will poll the database for missing Dias This function is used to find all contacts that are blocked or not in the data... | little better description would be nice. `Do post update functions` explains nothing |
@@ -750,9 +750,14 @@ class WPSEO_Utils {
*/
public static function is_valid_datetime( $datetime ) {
if ( substr( $datetime, 0, 1 ) != '-' ) {
- // Use the DateTime class ( PHP 5.2 > ) to check if the string is a valid datetime
- if ( new DateTime( $datetime ) !== false ) {
- return true;
+ try {
+ /... | [WPSEO_Utils->[get_roles->[get_names],clear_sitemap_cache->[query]]] | Checks if a string is a valid date time. | Why not doing `return ( new DateTime( $datetime ) !== false );` |
@@ -144,4 +144,6 @@ def main
T.reveal_type(AdvancedODM.new.ifunset_nilable) # error: Revealed type: `T.nilable(String)`
AdvancedODM.new.ifunset = nil # error: does not match expected type
AdvancedODM.new.ifunset_nilable = nil
+
+ T.reveal_type(ComputingProps.new.num_explicit_ok) # error: Revealed type... | [AdvancedODM->[prop],main->[foo2],NotAODM->[prop],SomeODM->[prop]] | This method returns the type of the object in the AdvancedODM. Method to check if the type of the object is correct. missing type of new object. | This doesn't really test anything more what was already being tested. To check the `Revealed type` here we *only* look at the sig on top of the (DSL-generated) `num_explicit_ok` method. we don't look at `num_explicit_ok`'s body to check this call site. |
@@ -249,7 +249,17 @@ def fetch_langpack(url, xpi, **kw):
# Not `version.files.update`, because we need to trigger save
# hooks.
file_.update(status=amo.STATUS_PUBLIC)
- sign_file(file_)
+
+ # Create a dummy request to be able to tie the autograph enabling
+ # ... | [celery_error->[info,RuntimeError],fetch_langpack->[,FileUpload,from_upload,AddonUser,filter,from_static_category,compile,info,Exception,int,builtins,get_or_create,add_file,warning,error,update_status,append,sign_file,update,len,iter_content,format,parse_addon,match,override,splitext,search,get,r',exc_info,save,unicode... | Fetches a language pack from the given url and xpi. Add a new language pack if it doesn t already exist. This function is called when a new language pack is created. It will create a new language. | using test classes in live code makes me worry. If we're just using it below (and as far as I can see, we are) then why not just pass `use_autograph=True` or `use_autograph=False` as you think appropriate. Or `autograph_flag = waffle.models.Flag.get('activate-autograph-signing)` then do `autograph.everyone` to get th... |
@@ -210,6 +210,12 @@ public class AccountManagetImplTestBase {
CallContext.unregister();
}
+ @Test
+ public void test()
+ {
+ return;
+ }
+
public static Map<String, Field> getInheritedFields(Class<?> type) {
Map<String, Field> fields = new HashMap<>();
for (Cla... | [AccountManagetImplTestBase->[setup->[register,asList,setSecurityCheckers,setUserAuthenticators],cleanup->[unregister],getInheritedFields->[getName,put,getSuperclass,getDeclaredFields]]] | Get the inherited fields. | wouw, how can we have done without this before ;) kidding can you explain a bit about the changes to tests you needed to do. I see some excpected exception attributes removed. and an account changed in tests. seems like unrelated to the PR. |
@@ -490,15 +490,8 @@ func (a *apiServer) createWorkerRc(options *workerOptions) error {
},
Spec: v1.ServiceSpec{
Selector: options.labels,
- Type: v1.ServiceTypeNodePort,
- Ports: []v1.ServicePort{
- {
- Port: options.service.ExternalPort,
- TargetPort: intstr.FromInt(int(opti... | [workerPodSpec->[MergePatch,Marshal,GetBackendSecretVolumeAndMount,Background,Apply,FormatUint,Unmarshal,GetPachClient,PullPolicy,GetSecretEnvVars,DecodePatch,GetState,MustParse,AddRegistry],createWorkerRc->[Create,Itoa,workerPodSpec,CoreV1,ReplicationControllers,Services,FromInt,GetKubeClient],getWorkerOptions->[Pipel... | createWorkerRc creates a worker RC object This function creates a new service if it does not already exist. | Small tweak: I think you can just do `Type: options.service.Type` and save the conditional above, with the exception of the part where you set the `NodePort`. `v1.ServiceType` is actually just a string under the hood so you can assign to it directly. |
@@ -30,17 +30,14 @@ import org.apache.beam.sdk.transforms.Create;
import org.apache.beam.sdk.transforms.PTransform;
import org.apache.beam.sdk.values.PBegin;
import org.apache.beam.sdk.values.PCollection;
-import org.apache.beam.sdk.values.PInput;
import org.apache.beam.sdk.values.POutput;
import org.apache.beam.s... | [TestSchemaIOTableProviderWrapper->[TestPushdownProjector->[withProjectionPushdown->[TestPushdownProjector]]]] | Get the schema io provider. | This class is already in the `test` folder, so `@VisibleForTesting` is redundant. |
@@ -33,7 +33,7 @@ def create_stripe_customer_and_subscription_for_user(user, email, stripe_token):
customer=customer.id, items=[{"plan": settings.STRIPE_PLAN_ID}],
)
- return subscription
+ UserSubscription.set_active(user, subscription.id)
def get_stripe_customer(user):
| [create_stripe_customer_and_subscription_for_user->[retrieve_stripe_subscription],get_stripe_subscription_info->[retrieve_stripe_subscription]] | Create a stripe customer and subscription for a user. | Now a `utils` function has to deal with data side-effects :( But it's fine because it was already dirty in how it would edit the user modal if the `stripe_customer_id` had to be set. |
@@ -64,14 +64,14 @@ public class OnHeapNamespaceExtractionCacheManager extends NamespaceExtractionCa
try {
ConcurrentMap<String, String> cacheMap = mapMap.get(cacheKey);
if (cacheMap == null) {
- // Sometimes cache will not be populated (for example: if it doesn't contain new data)
- re... | [OnHeapNamespaceExtractionCacheManager->[delete->[delete]]] | Swap and clear cache. | lookup instead of namespace |
@@ -81,6 +81,12 @@ EOT
// create installed repo, this contains all local packages + platform packages (php & extensions)
$installedRepo = new PlatformRepository($localRepo);
+ if ($internallyInstalledPackages) {
+ foreach ($internallyInstalledPackages as $package) {
+ ... | [InstallCommand->[install->[getOption,getPackage,getJobType,getLockedPackages,solve,getTarget,getVersion,addRepository,getInstallationManager,getJobs,collectLinks,getLocalRepository,getNames,dispatchCommandEvent,setPreferSource,dump,lockPackages,getVendorPath,update,getComposer,writeln,isPackageInstalled,whatProvides,e... | Installs packages from a package lock file. Installs dependencies and checks if they are missing Checks if a package can be installed or updated. | pass an empty array as default value instead (and typehint as array) to get rid of this `if` check |
@@ -9,7 +9,8 @@ type DisplayOptions struct {
Color colors.Colorization // colorization to apply to events.
ShowConfig bool // true if we should show configuration information.
ShowReplacementSteps bool // true to show the replacement steps in the plan.
- Show... | [No CFG could be retrieved] | Colorization colorization for events. | Nit: `a summarized` |
@@ -67,6 +67,12 @@ public class DbUserController implements UserDao {
secondaryDao.updateUser(user, password);
}
+ @Override
+ public void updateUser(final DBUser user, final String password) {
+ Preconditions.checkArgument(user.isValid(), user.getValidationErrorMessage());
+ secondaryDao.updateUser(u... | [DbUserController->[login->[login,createUser],doesUserExist->[doesUserExist],getUserByName->[getUserByName],createUser->[createUser],updateUser->[updateUser],getPassword->[getPassword]]] | Updates a user in the primary and secondary DAO. | Please get rid of the Sring password methods, use an enum flag instead. The bcrypt should happen before these methods are called. The DAO layer is *not* responsible for doing encryption. |
@@ -321,7 +321,7 @@ def cosine_distance(
predictions.get_shape().assert_is_compatible_with(labels.get_shape())
radial_diffs = math_ops.multiply(predictions, labels)
- losses = 1 - math_ops.reduce_sum(radial_diffs, axis=(axis,), keepdims=True)
+ losses = 1 - math_ops.reduce_sum(radial_diffs, axis=axis,... | [_safe_mean->[_safe_div],mean_pairwise_squared_error->[_safe_div,_num_present],compute_weighted_loss->[validate,_num_elements,_safe_mean,_num_present],huber_loss->[compute_weighted_loss],absolute_difference->[compute_weighted_loss],cosine_distance->[compute_weighted_loss],Reduction->[validate->[all]],sigmoid_cross_entr... | Adds a cosine - distance loss to the training procedure. Computes the weighted loss of the node - missing node. | Thanks for the PR! Could you also update the docstring as well? |
@@ -540,6 +540,17 @@ export class UrlReplacements {
return navigationInfo[attribute];
}
+ getQueryParamData_(param, defaultValue, opt_sync) {
+ user().assert(param,
+ 'The first argument to QUERY_PARAM, the query string ' +
+ 'param is required');
+ const url = parseUrl(this.ampdoc.win.lo... | [UrlReplacements->[constructor->[shareTrackingForOrNull,variantForOrNull],getTimingDataAsync_->[whenDocumentComplete,resolve],buildExpr_->[length,join,sort],expand_->[then,split,resolve,user,encodeValue,apply,replace,async,rethrowAsync,catch,sync],getTimingDataSync_->[isFiniteNumber],collectVars->[create],setAsync_->[d... | getNavigationData_ - get the navigation data for an attribute. | This doesn't have the same problem as above, because it reads the `.href` every time. |
@@ -44,6 +44,8 @@ const (
tokensPrefix = "/tokens"
aclsPrefix = "/acls"
adminsPrefix = "/admins"
+ usersPrefix = "/users"
+ groupsPrefix = "/groups"
defaultTokenTTLSecs = 14 * 24 * 60 * 60 // two weeks
| [GetACL->[LogResp,getEnterpriseTokenState,isAdmin,isActivated,LogReq],getEnterpriseTokenState->[getPachClient],GetScope->[LogResp,getEnterpriseTokenState,isAdmin,isActivated,LogReq],ExtendAuthToken->[isActivated,LogReq,LogResp,isAdmin],Authenticate->[isActivated,LogResp,getEnterpriseTokenState],Activate->[getPachClient... | Package names of the packages that are required to be authenticated This function is used to determine whether a given is a GitHub access token. | Nit: how would you feel about calling this `/members`? |
@@ -46,6 +46,15 @@ public class RuntimeServiceEvent {
public static final int RUNTIME_STOPPED = 3;
+ public static final int RUNTIME_ABOUT_TO_RESUME = 4;
+
+ public static final int RUNTIME_RESUME = 5;
+
+ public static final int RUNTIME_ABOUT_TO_STANDBY = 6;
+
+ public static final int RUNTIME_STA... | [RuntimeServiceEvent->[toString->[getEventName],equals->[equals]]] | Creates a class which represents a Nuxeo event in a Nuxeo runtime. Checks if an object is an instance of the class of the object. | Remove extra empty line. |
@@ -39,7 +39,7 @@ feature 'IDP-initiated logout' do
it 'adds acs_url domain names for current Rails env to CSP form_action' do
expect(page.response_headers['Content-Security-Policy']).
- to include('form-action \'self\' localhost:3000 example.com')
+ to include('form-action \'self\' example.... | [visit,assertion_statement_node,create,new,let,to_not,feature,it,domain_name,to,have_content,before,click_button,t,require,include,sign_in_and_2fa_user,each,context,eq] | This method creates a signed up user in the SP. It also creates a signed out request deactivates each authenticated Identity and logs the user out. | this one isn't working, need to dig in more to debug it |
@@ -38,13 +38,13 @@ import lombok.Getter;
@Alpha
public class HivePartition extends HiveRegistrationUnit {
+ private final List<String> values;
+
private HivePartition(Builder builder) {
super(builder);
this.values = ImmutableList.<String> copyOf(builder.values);
}
- private List<String> values;... | [HivePartition->[Builder->[build->[HivePartition]]]] | Sets the partition values. | You should consider using lombok's `equalandhashcode` |
@@ -229,7 +229,11 @@ func (r *chatConversationResolver) Resolve(ctx context.Context, req chatConversa
info.Visibility, info.Triple.TopicType, info.TopicName, info.TLFNameExpandedSummary())
}
}
- return &conversation, false, nil
+ var err error
+ if conversation.Error != nil {
+ err = errors.New(conver... | [resolveWithService->[makeGetInboxAndUnboxLocalArg],Resolve->[resolveWithService,create,resolveWithCliUIInteractively]] | Resolve resolves a single conversation. resolves a single conversation. | do we want to log/warn this error here or in the cmd itself? |
@@ -2200,10 +2200,13 @@ def sequence_conv(input,
def sequence_softmax(input, use_cudnn=False, name=None):
"""
- This function computes the softmax activation among all time-steps for each
- sequence. The dimension of each time-step should be 1. Thus, the shape of
- input Tensor can be either :math:`[N,... | [ctc_greedy_decoder->[topk],py_func->[PyFuncRegistry],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],nce->[_init_by_numpy_array],reshape->[get_attr_shape,get_new_shape_tensor,contain_var],resize_trilinear->[image_resize],crop_tensor->[contain_var],slice->[get_new_list_tensor,contain_var],logic... | Computes the softmax activation among all time - steps for each sequence of length 1 and all time Create a sequence softmax variable for the given type inference. | If the input type to be processed is Tensor => For Tensor |
@@ -82,7 +82,7 @@ func (dc *BasicDeploymentController) handleNew(ctx kapi.Context, deployment *dep
controller := &kapi.ReplicationController{
DesiredState: deployment.ControllerTemplate,
- Labels: map[string]string{deployapi.DeploymentConfigLabel: configID, "deploymentID": deployment.ID},
+ Labels... | [handleNew->[ListReplicationControllers,Infof,GetReplicationController,UpdateReplicationController,ParseSelector,V,DeleteReplicationController,CreateReplicationController],Run->[Forever,HandleDeployment],HandleDeployment->[Infof,WithNamespace,UpdateDeployment,V,NextDeployment,handleNew,NewContext]] | handleNew creates a new deployment and returns the status of the deployment Check if there are any necessary pods for a given deploymentConfig. | Just changing these to match convention |
@@ -1605,7 +1605,8 @@ function PMA_getSumbitAndResetButtonForActionsPanel($tabindex, $tabindex_for_val
*/
function PMA_getHeadAndFootOfInsertRowTable($url_params)
{
- $html_output = '<table class="insertRowTable">'
+ $html_output = '<div id="clearfloat">'
+ . '<table class="insertRowTable">'
.... | [PMA_analyzeWhereClauses->[fetchAssoc,query],PMA_transformEditedValues->[applyTransformation],PMA_verifyWhetherValueCanBeTruncatedAndAppendExtraData->[tryQuery,fetchValue,getFieldsMeta],PMA_setSessionForEditNext->[query,getFieldsMeta,fetchRow],PMA_showEmptyResultMessageOrSetUniqueCondition->[addHtml,getFieldsMeta],PMA_... | This function returns the head and foot of the insert row table for a object. | Hi, Aditya Sastry I think clearfloat element shouldn't be a container. |
@@ -44,6 +44,7 @@ namespace System.Runtime.InteropServices.Tests
[Fact]
[SkipOnMono("Marshal.WriteByte will not be implemented in Mono, see https://github.com/mono/mono/issues/15085.")]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/37093", TestPlatforms.Android)]
public vo... | [ByteTests->[WriteByte_BlittableObject_Roundtrips->[value1,Equal,ToInt32,ReadByte,WriteByte,value2],ReadByte_ZeroPointer_ThrowsException->[ReadByte,AssertExtensions,Zero],ReadByte_BlittableObject_ReturnsExpected->[ReadByte,ToInt32,Equal],StructWithReferenceTypes->[ByValArray],WriteByte_Pointer_Roundtrips->[Equal,ReadBy... | Write a negative value to the BlittableStruct where the value is stored as a byte. | Does `SkipOnMono` just apply to 'legacy' mono? |
@@ -11,6 +11,7 @@ Rails.application.routes.draw do
via: %i[get post delete],
as: :destroy_user_session
match '/api/saml/auth' => 'saml_idp#auth', via: %i[get post]
+ post '/analytics' => 'analytics#create'
# SAML secret rotation paths
if FeatureManagement.enable_saml_cert_rotation?
| [redirect,devise_scope,join,put,draw,root,scope,post,webauthn_enabled?,enable_usps_verification?,enable_identity_verification?,rotation_path_suffix,enable_saml_cert_rotation?,patch,devise_for,match,delete,namespace,get,doc_auth_enabled?,enable_test_routes] | This method is used to generate routes that are used by the application. Routes that handle login. Alphabetically sorted. | This endpoint shouldn't be exposed unless a feature is enabled to use it. |
@@ -548,6 +548,13 @@ export class AmpVideo extends AMP.BaseElement {
}
this.video_.appendChild(currSource);
});
+
+ return;
+ }
+
+ // Cached by the remote video caching (amp-video[cache=*]).
+ if (source.hasAttribute('i-amphtml-video-cached-source')) {
+ this... | [No CFG could be retrieved] | Adds source elements to the video element and updates the source element with the new source elements. Find all sources of the video and set it on video. | Would this return do anything? Because it's inside the `(source) => {}` function, it doesn't stop the other code from executing |
@@ -180,7 +180,7 @@ public class StreamRouterEngine {
for (final StreamRule streamRule : stream.getStreamRules()) {
try {
- final Rule rule = new Rule(stream, streamRule);
+ final Rule rule = new Rule(stream, streamRule, null);
m... | [StreamRouterEngine->[matchRules->[match],Rule->[match->[match]],matchRulesWithTimeout->[call->[match]],StreamTestMatch->[matchMessage->[match,getStreamRule]]]] | Test match. | What meaning would `sufficient = null` have in this case? There's also not a single check for `Rule#isSufficient() == null`. |
@@ -343,7 +343,7 @@ def test_cov_scaling():
assert_true(cov.max() < 1)
-@requires_sklearn
+@requires_recent_sklearn
def test_auto_low_rank():
"""Test probabilistic low rank estimators"""
| [test_evoked_whiten->[all,read_evokeds,regularize,read_cov,mean,whiten_evoked,assert_true,pick_types,abs],test_regularize_cov->[Raw,regularize,read_cov,mean,assert_true,info],test_arithmetic_cov->[assert_array_almost_equal,read_cov,assert_true],test_auto_low_rank->[get_data->[randn,rand,copy,svd,RandomState,dot],_auto_... | Test probabilistic low rank estimators. Raises a ValueError if the model is not a model with the given rank. | wouldn't be nicer to pass the version as param to the decorator? |
@@ -42,7 +42,7 @@ def setup_args(parser=None):
train.add_argument('-et', '--evaltask',
help=('task to use for valid/test (defaults to the '
'one used for training if not set)'))
- train.add_argument('--eval-batchsize', type=int,
+ train.add_argument('-ebs... | [TrainLoop->[validate->[run_eval,save_best_valid],train->[run_eval,validate,log]],TrainLoop] | Setup the arguments for the training loop. Parse command line options for training and validation. | strip these changes. |
@@ -32,7 +32,7 @@ class AddonIndexer(BaseSearchIndexer):
'properties': {
'id': {'type': 'long'},
- 'app': {'type': 'long'},
+ 'app': {'type': 'byte'},
'appversion': {'properties': {app.id: appver
... | [AddonIndexer->[get_mapping->[attach_language_specific_analyzers,attach_translation_mappings,get_doctype_name],extract_document->[version_int,max,keys,getattr,extract_field_search_translations,update,extract_field_raw_translations,items,exists,unicode,extract_field_analyzed_translations,is_new]],getLogger] | Return mapping of a sequence of tokens to a sequence of tokens. A collection of all the configuration options that define a single node. Adds analyzers to the mapping of the object to the mapping field. | Why is this changing if I mind asking? afair es 2.x still supports `long`? Or did I miss something and this is a string repr now? |
@@ -242,7 +242,6 @@ void RemoteClient::GetNextBlocks (
FOV setting. The default of 72 degrees is fine.
*/
- float camera_fov = (72.0*M_PI/180) * 4./3.;
if(isBlockInSight(p, camera_pos, camera_dir, camera_fov, d_blocks_in_sight) == false)
{
continue;
| [event->[notifyEvent,UpdatePlayerList],UpdatePlayerList->[getClientIDs]] | This method is called by the remote client to get the next blocks. This function is used to rotate the XZ camera by the Yaw and Zaw of region ICacheManager interface v3s16 - > v3s16 This function is used to check if a block is in the map and if it is not Merge a block. | Just checking something, here the default FOV 72deg is multiplied by 4/3, i assume to get horizontal FOV in radians by assuming a 4/3 screen aspect ratio. Now that you're getting FOV directly is this * 4/3 still being done? I'm assuming that the player accessible FOV setting is vertical FOV. |
@@ -80,7 +80,7 @@ class PostCreator
end
def guardian
- @guardian ||= Guardian.new(@user)
+ @guardian ||= Guardian.new(@opts[:acting_user] || @user)
end
def valid?
| [PostCreator->[save_post->[skip_validations?],build_post_stats->[track_post_stats],store_unique_post_key->[store_unique_post_key],create!->[create!],create->[create,valid?],handle_spam->[skip_validations?,create],ensure_in_allowed_users->[create!],valid?->[skip_validations?],transaction->[transaction],enqueue_jobs->[en... | Checks if a node in the system has a node in the system and if so checks if Checks if a node with the given ID is valid. If it is add_errors_. | The acting user should not be bounded/unbounded by the original poster, so I think this makes sense? |
@@ -61,13 +61,14 @@ setup(
# This means any folder structure that only consists of a __init__.py.
# For example, for storage, this would mean adding 'azure.storage'
# in addition to the default 'azure' that is seen here.
- 'azure'
+ 'azure',
'azure.ai',
'azur... | [find_packages,setup,search,replace,read,format,RuntimeError,join,open] | Package structure of a given package. | Nit: trailing comma makes the diff cleaner next time, like you did on line 66 above. |
@@ -422,6 +422,7 @@ namespace Dynamo.Models
IAuthProvider AuthProvider { get; set; }
IEnumerable<IExtension> Extensions { get; set; }
TaskProcessMode ProcessMode { get; set; }
+ bool HeadlessMode { get; set; }
}
| [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Paste,Copy],RemoveWorkspace->[Dispose],UngroupModel->[DeleteModelInternal],ResetEngine->[ResetEngine],ShutDown->[OnShutdownStarted,OnShutdownCompleted],DumpLibraryToXml->[DumpLibraryToXml],ResetEngineInternal->[RegisterCusto... | Creates a new instance of the base type IStartConfiguration. Starts DynamoModel with custom configuration. | @ikeough @gregmarr , this is a change to a public interface, any change to this interface will break clients building their own Start Configuration derived configurations... like Revit etc, and should impact Dynamo version number to Dynamo 2.0 afaik. I think an alternative is to implement an additional interface contai... |
@@ -114,13 +114,13 @@ namespace System.Diagnostics
protected void OnExited() { }
public void Refresh() { }
public bool Start() { throw null; }
- public static System.Diagnostics.Process Start(System.Diagnostics.ProcessStartInfo startInfo) { throw null; }
- public static System.D... | [MonitoringDescriptionAttribute->[All],ProcessStartInfo->[Normal]] | This method is used to start a new process and wait for it to finish. | NIT: For `GetProcessesByName` method overloads its allowing null for parameter `processName` but might be not intentional |
@@ -172,15 +172,7 @@ namespace Microsoft.Extensions.Caching.Memory
public long? Size
{
get => _size;
- set
- {
- if (value < 0)
- {
- throw new ArgumentOutOfRangeException(nameof(value), value, $"{nameof(value)} must b... | [CacheEntry->[ExpirationTokensExpired->[SetExpired],DetachTokens->[Dispose],CheckForExpiredTokens->[SetExpired],CheckForExpiredTime->[SetExpired],Dispose->[Dispose]]] | region ICacheCacheItem Implementation This method is called by the cache manager to root unnecessary objects. | Why have 2 lines of code on the same line? I think this makes it harder to read. |
@@ -236,7 +236,8 @@ def run_app(
config=config,
chain=blockchain_service,
query_start_block=BlockNumber(start_block),
- default_one_to_n_address=one_to_n_contract_address,
+ default_one_to_n_address=one_to_n_contract_address
+ or contracts[CONTRACT... | [run_app->[get_account_and_private_key,_setup_matrix,rpc_normalized_endpoint]] | Run the app. Initialize the nagios configuration. Raiden related functions on network id raiden_app . | This looks very weird, maybe adding parens would make it more readable (or does black remove those?) |
@@ -201,6 +201,7 @@ func newGregorHandler(g *globals.Context) *gregorHandler {
broadcastCh: make(chan gregor1.Message, 10000),
forceSessionCheck: false,
connectHappened: make(chan struct{}),
+ replayCh: make(chan replayThreadArg, 10),
}
return gh
}
| [handleInBandMessage->[Name,Debug,IsAlive,Errorf],connectTLS->[pingLoop,Debug,GetClient,Errorf],OnConnectError->[setReachability,Debug],handleShowTrackerPopupCreate->[Debug],handleInBandMessageWithHandler->[Debug,getGregorCli],PushState->[PushState],Init->[Error],PushOutOfBandMessages->[PushOutOfBandMessages],handleSho... | newLocalDb creates a new local object that stores the unique ID in the DB. monitorAppState is a long lived function that monitors the current app state and reacts. | Any reason not to make this 100? |
@@ -82,6 +82,12 @@ public final class DatanodeIdYaml {
.setIpAddress(datanodeDetailsYaml.getIpAddress())
.setHostName(datanodeDetailsYaml.getHostName())
.setCertSerialId(datanodeDetailsYaml.getCertSerialId());
+ if (datanodeDetailsYaml.getPersistedOpState() != null) {
+ buil... | [DatanodeIdYaml->[getDatanodeDetailsYaml->[getHostName,DatanodeDetailsYaml,getCertSerialId,getIpAddress]]] | Reads a datanode id file. | Shouldn't this be also inside the if != null ? , I am going to presume that even if we have no data, datanodeDetailsYaml.getPersistedOpStateExpiryEpochSec is going to return zero, but since the expiry is a long, JVM would initialize it to zero by default, would it not?. So curious why this check is outside the if. |
@@ -57,8 +57,12 @@ public final class AuthorizeControllerServiceReference {
if (!Objects.equals(currentValue, proposedValue)) {
// ensure access to the old service
if (currentValue != null) {
- final Authorizable currentSe... | [AuthorizeControllerServiceReference->[authorizeControllerServiceReferences->[getValue,getAuthorizable,equals,authorize,getKey,getPropertyDescriptor,getControllerServiceDefinition,entrySet,getNiFiUser]]] | Authorizes access to the controller service references. | I wonder if instead of raising and then catching exception and do nothing we should instead introduce `canLocate(id)` or `isLocatable`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.