patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -112,7 +112,7 @@ int rsautl_main(int argc, char **argv)
case OPT_HEXDUMP:
hexdump = 1;
break;
- case OPT_RAW:
+ case OPT_RSA_RAW:
pad = RSA_NO_PADDING;
break;
case OPT_OAEP:
| [No CFG could be retrieved] | Parse the given command line arguments and return the number of keys read. DUMP - Dump the contents of a key. | This name change isn't at all related to this PR, and not necessary. This is `rsautl`, we already know that we're dealing with RSA keys. Please undo the changes in this file. |
@@ -602,14 +602,15 @@ static int rsa_ossl_public_decrypt(int flen, const unsigned char *from,
return r;
}
-static int rsa_ossl_mod_exp(BIGNUM *r0, const BIGNUM *I, RSA *rsa, BN_CTX *ctx)
+static int rsa_ossl_mod_exp(BIGNUM *r0, const BIGNUM *II, RSA *rsa, BN_CTX *ctx)
{
- BIGNUM *r1, *m1, *vrfy, *r2, *m[RSA... | [int->[RSA_padding_check_none,BN_mul,RSA_padding_add_PKCS1_type_2,RSA_padding_add_PKCS1_OAEP,BN_BLINDING_unlock,BN_BLINDING_invert_ex,BN_is_negative,BN_new,BN_BLINDING_convert_ex,BN_cmp,RSA_padding_check_PKCS1_OAEP,BN_add,rsa_blinding_convert,BN_CTX_start,BN_bn2bin,OPENSSL_clear_free,BN_free,RSA_padding_add_SSLv23,RSAe... | RSA OSSL public decryption read - only version of rsa_decrypt RSA_OSSL_MOD_EXP rsa_mod_p rsa_mod_q finds n - th node in BN tree which can be null if no node in if rsa == NULL return - 1 ; check for missing private key private helper functions n is not mod n. | I think you now just created a memory leak? |
@@ -53,6 +53,14 @@ class Elmo(torch.nn.Module):
Should we apply layer normalization (passed to ``ScalarMix``)?
dropout : ``float``, optional, (default = 0.5).
The dropout to be applied to the ELMo representations.
+ module : ``torch.nn.Module``, optional, (default = None).
+ If provided... | [_ElmoCharacterEncoder->[forward->[,conv,add_sentence_boundary_token_ids,max,activation,append,getattr,size,_projection,cat,len,embedding,transpose,format,_highways,range,view,ConfigurationError],__init__->[cached_path,from_numpy,super,Variable,open,_load_weights,load,array],_load_cnn_weights->[FloatTensor,append,cache... | Initialize the ElMo with a list of scalar mixes. | You could check that the module has this attribute in the init. |
@@ -496,9 +496,16 @@ class Optimizer(object):
startup_program=startup_program,
parameter_list=parameter_list,
no_grad_set=no_grad_set)
+
+ if grad_clip is not None and framework.in_dygraph_mode():
+ params_grads = grad_clip(params_grads)
+
optimize_ops =... | [AdamaxOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_finish_update->[_get_accumulator],_create_accumulators->[_add_accumulator]],MomentumOptimizer->[_append_optimize_op->[_get_accumulator,_create_param_lr],_create_accumulators->[_add_accumulator]],Optimizer->[apply_gradients->[_create_optimizati... | Add operations to minimize loss by updating parameters_list and optimizations. | Add Warning to avoid static graph user to have unexpected effect |
@@ -8,7 +8,13 @@
const uint Memory::StandAloneFreeListPolicy::MaxEntriesGrowth;
+#ifdef _MSC_VER
template __forceinline BVSparseNode * BVSparse<JitArenaAllocator>::NodeFromIndex(BVIndex i, BVSparseNode *** prevNextFieldOut, bool create);
+#else
+// Clang/GCC support
+// We need this function to be inlined for per... | [No CFG could be retrieved] | Creates a new non - zero number of non - zero memory block from a list of objects XmlElement for the list of free objects in a block. | This can be removed if you now define __forceinline as always_inline? |
@@ -480,7 +480,7 @@ export class MultisigHDWallet extends AbstractHDElectrumWallet {
}
// is it electrum json?
- if (json && json.wallet_type) {
+ if (json && json.wallet_type && json.wallet_type !== 'standard') {
const mofn = json.wallet_type.split('of');
this.setM(parseInt(mofn[0].trim... | [No CFG could be retrieved] | add cosigner info Add Cosigner to the list of known Cosigner objects. | what does this `standard` stands for? |
@@ -27,15 +27,10 @@ import java.util.Set;
*/
public class ProUtils {
- public static Map<Unit, Territory> createUnitTerritoryMap(final PlayerID player) {
- final GameData data = ProData.getData();
- final List<Territory> allTerritories = data.getMap().getTerritories();
- final List<Territory> myUnitTerri... | [ProUtils->[getClosestEnemyLandTerritoryDistance->[getPotentialEnemyPlayers],getLiveAlliedCapitals->[getAlliedPlayers],getAlliedPlayersInTurnOrder->[getOtherPlayersInTurnOrder],getEnemyPlayersInTurnOrder->[getOtherPlayersInTurnOrder],getClosestEnemyOrNeutralLandTerritoryDistance->[getEnemyPlayers],getLiveEnemyCapitals-... | Create a map of units to territory. | Looks like there are a few NPE potential spots here. Also, the onner loop could be replaced with a Lambda expression to make this a bit easier to read. |
@@ -486,8 +486,15 @@ func (pt *programTester) testLifeCycleInitAndDestroy() error {
} else {
contract.IgnoreError(os.RemoveAll(tmpdir))
}
- }()
- }
+ } else {
+ // When tmpdir is empty, we ran "in tree", which means we wrote output
+ // to the "command-output" folder in the projdir, and we should cle... | [yarnCmd->[getYarnBin],testLifeCycleDestroy->[GetDebugUpdates,runPulumiCommand],testEdit->[previewAndUpdate],pulumiCmd->[getBin,GetDebugLogLevel],performExtraRuntimeValidation->[GetStackName,runPulumiCommand],copyTestToTemporaryDirectory->[GetStackName,getBin],previewAndUpdate->[GetDebugUpdates,runPulumiCommand],prepar... | testLifeCycleInitAndDestroy initializes and destroys the test project. | This is a bit scary, but perhaps better than leaving a dirty worktree? |
@@ -89,6 +89,7 @@ namespace System.Xml.Xsl
// SxS: This method does not take any resource name and does not expose any resources to the caller.
// It's OK to suppress the SxS warning.
+ [RequiresUnreferencedCode("This method requires a call to LoadInternal which might use types that cannot be... | [XslCompiledTransform->[TestGenerate->[CompileQilToMsil],Load->[Load,Reset],QilExpression->[CompileXsltToQil,Reset],Transform->[Transform]]] | Load a sequence of resources from the specified stylesheet. | So this means there's no way to use XSLT and be "trim compatible" right? I haven't looked into the details - maybe that's really the case. In any case I would probably create an issue to track this - in theory running XSLT should not break trimming (precompiled XSLT is a separate problem) - in most cases. |
@@ -64,14 +64,15 @@ func ValidateBuildConfig(config *buildapi.BuildConfig) field.ErrorList {
fromRefs := map[string]struct{}{}
specPath := field.NewPath("spec")
triggersPath := specPath.Child("triggers")
+ buildFrom := buildutil.GetImageStreamForStrategy(config.Spec.Strategy)
for i, trg := range config.Spec.Tri... | [ValidatePodLogOptions,ParseDockerImageReference,Index,DeepEqual,GetImageStreamForStrategy,SplitImageStreamTag,HasPrefix,NewPath,Required,IsDNS1123Subdomain,BuildToPodLogOptions,Clean,Child,ValidateSecretName,IsAbs,IsBuildComplete,Contains,ValidateObjectMeta,Invalid,Sprintf,ValidateObjectMetaUpdate,IsCIdentifier,TrimPr... | refKey returns a unique identifier for the given object. Check if all triggers are set. | Will this break anything that already exists in etcd? |
@@ -81,7 +81,7 @@ export function onDocumentFormSubmit_(e) {
user().assert(action,
'form action attribute is required for method=GET: %s', form);
assertHttpsUrl(action, dev().assertElement(form), 'action');
- user().assert(!startsWith(action, urls.cdn),
+ user().assert(!isProxyOrigin(action),
... | [No CFG could be retrieved] | Check if the form has a valid and trigger validation if it is. check if form has a valid target attribute and if so check if cross origin request is allowed. | This should allow localhost. |
@@ -39,6 +39,13 @@ class Atomic_Admin_Menu extends Admin_Menu {
wp_dequeue_script( 'a8c_wpcom_masterbar_overrides' ); // Initially loaded in modules/masterbar/masterbar/class-masterbar.php.
}
+ /**
+ * Determines whether the current locale is right-to-left (RTL).
+ */
+ public function is_rtl() {
+ return 'rt... | [Atomic_Admin_Menu->[add_new_site_link->[add_admin_menu_separator],reregister_menu_items->[add_browse_sites_link,add_my_home_menu,add_site_card_menu,add_new_site_link]]] | Dequeues all scripts from the queue. | I wonder if it may make sense to expand on that description a bit, to outline the differences between the site's settings and the linked WordPress.com account settings? |
@@ -156,7 +156,8 @@ Rails.application.routes.draw do
patch "/unhide", to: "comments#unhide"
end
resources :comment_mutes, only: %i[update]
- resources :users, only: [:update] do
+ resources :users, only: %i[index], defaults: { format: :json } # internal API
+ resources :users, only: %i[update] do
res... | [new,authenticate,authenticated,redirect,devise_scope,mount,draw,has_role?,resources,member,root,use,scope,post,set,controllers,require,secrets,class_eval,use_doorkeeper,resource,patch,devise_for,each,production?,delete,resolve,namespace,collection,get,session_options,tech_admin?] | get all the events of a given category onboarding is a tag that can be used to link to onboarding. | Rails allows for multiple resource blocks for the same resource, so I'm using this here to apply different defaults for the one that's only part of the internal API. |
@@ -147,9 +147,11 @@ class Utils {
return false;
}
}
-
+
public static String buildJobGroupId(InterpreterContext context) {
- return "zeppelin-" + context.getNoteId() + "-" + context.getParagraphId();
+ return "zeppelin-" + context.getNoteId() + "-" + context.getParagraphId() + "\n" +
+ ... | [Utils->[findClass->[findClass],isScala2_11->[isScala2_10],invokeMethod->[invokeMethod],isCompilerAboveScala2_11_7->[isScala2_10],invokeStaticMethod->[invokeStaticMethod],evaluateScalaCompilerVersion->[findClass]]] | Returns true if the job is in a Spark session false otherwise. | it looks like the newline doesn't show up in the web interface, from your screen cap? should we remove it then? |
@@ -0,0 +1,11 @@
+class DECSSnippetService
+ attr_reader :url
+
+ def initialize(url)
+ @url = url
+ end
+
+ def call
+ HTTParty.get(url).parsed_response
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I'm all for code organization but I think this service is a bit redundant, since you only issues a GET :) I'd just put the `HTTParty.get` inside the liquid tag. |
@@ -30,7 +30,8 @@ public abstract class AbstractCacheFactory implements CacheFactory {
private final ConcurrentMap<String, Cache> caches = new ConcurrentHashMap<String, Cache>();
- public Cache getCache(URL url) {
+ public Cache getCache(URL url, Invocation invocation) {
+ url = url.addParameter(C... | [AbstractCacheFactory->[getCache->[put,toFullString,get,createCache]]] | Get a cache with the given URL. | can you attach a testcase for these modified codes, thx. |
@@ -47,7 +47,8 @@ public final class ZlibCodecFactory {
}
public static ZlibEncoder newZlibEncoder(ZlibWrapper wrapper, int compressionLevel, int windowBits, int memLevel) {
- if (PlatformDependent.javaVersion() < 7) {
+ if (PlatformDependent.javaVersion() < 7 ||
+ windowBits !=... | [ZlibCodecFactory->[newZlibDecoder->[JZlibDecoder],newZlibEncoder->[JdkZlibEncoder,javaVersion,JZlibEncoder]]] | Creates a new encoder for the given compression level window bits and mem level. | Maybe we also should check the dependency is on the classpath? |
@@ -49,7 +49,7 @@ import gobblin.source.workunit.Extract;
*/
public class SourceState extends State {
- private static final Set<Extract> extractSet = Sets.newConcurrentHashSet();
+ private static final Set<Extract> EXTRACT_SET = Sets.newConcurrentHashSet();
private static final DateTimeFormatter DTF =
... | [SourceState->[readFields->[readFields],equals->[equals],write->[write],hashCode->[hashCode],ImmutableSourceState->[SourceState],getPreviousSourceState->[SourceState]]] | Creates a new state which contains all the meta data related to a particular source. The previous work unit state of the job run. | Why don't make use ExtractFactory? |
@@ -1012,7 +1012,8 @@ export class Viewer {
eventType, data, awaitResponse));
}
- if (!this.messagingReadyPromise_) {
+ if (awaitResponse // Only throw when caller is waiting for response.
+ && !this.messagingReadyPromise_) {
return Promise.reject(getChannelError());
}
| [No CFG could be retrieved] | Sends a message to the viewer and waits for a response. Broadcasts a message to all other AMP documents under the same viewer that the messaging channel. | Maybe we could move this if inside `if (!cancelUnsent)`. Instead of `awaitResponse`, we should check `cancelUnsent` |
@@ -58,13 +58,13 @@ for pass_id in range(PASS_NUM):
y_data = np.array(map(lambda x: x[1], data)).astype("int64")
y_data = np.expand_dims(y_data, axis=1)
- tensor_x = core.LoDTensor()
+ tensor_x = fluid.LoDTensor()
tensor_x.set(x_data, place)
- tensor_y = core.LoDTenso... | [reset,default_main_program,MomentumOptimizer,eval,UniformInitializer,test,shuffle,Accuracy,LoDTensor,expand_dims,default_startup_program,cross_entropy,fc,test_reader,set,range,train,train_reader,print,mean,data,get_inference_program,CPUPlace,L2DecayRegularizer,batch,str,Executor,run,minimize,exit,array] | Train and test cross entropy on the training data. Reads the test data and computes the test accuracy. | So executor run interface will create LoDTensor and set numpy data? |
@@ -715,6 +715,7 @@ class Report(object):
Name of the section. If section already exists, the figures
will be appended to the end of the section
"""
+ import mayavi
if not isinstance(figs, (list, tuple)):
figs = [figs]
| [_iterate_bem_slices->[_fig_to_mrislice],_iterate_mri_slices->[_build_image],_iterate_trans_views->[_fig_to_img],Report->[_render_forward->[_get_id],add_section->[_get_id,_fig_to_img],_render_trans->[_get_id,_iterate_trans_views],_render_image->[_get_id,_render_array],_render_cov->[_get_id,_fig_to_img],_render_toc->[_i... | Append custom user - defined figures. | use try as mayavi shoudl only be a weak dependency |
@@ -22,7 +22,7 @@ use Symfony\Component\HttpKernel\Event\GetResponseForControllerResultEvent;
* @author Kévin Dunglas <dunglas@gmail.com>
* @author Baptiste Meyer <baptiste.meyer@gmail.com>
*/
-class WriteListener
+final class WriteListener
{
private $dataPersister;
| [WriteListener->[onKernelView->[getMethod,getControllerResult,persist,isMethodSafe,setControllerResult,has,supports,getRequest,remove]]] | This method is called when the constructor of the class is called. | Can we really do this? It's a BC break, no? |
@@ -190,10 +190,13 @@ func (s *Server) ResetOrgAdminKey(ctx context.Context, req *request.ResetOrgAdmi
return nil, err
}
+ org, err = s.service.Storage.TouchOrg(ctx, req.Id, req.ServerId)
+ if err != nil {
+ return nil, service.ParseStorageError(err, *req, "org")
+ }
+
return &response.ResetOrgAdminKey{
- Id... | [ResetOrgAdminKey->[GetOrg],GetOrg->[GetOrg],DeleteOrg->[DeleteOrg],GetOrgs->[GetOrgs]] | ResetOrgAdminKey resets the admin key of an organization. | Touch Org record to update the `updated_at` in reset admin key API |
@@ -64,8 +64,6 @@ def start_download_data(args: Dict[str, Any]) -> None:
try:
if config.get('download_trades'):
- if config.get('trading_mode') == 'futures':
- raise OperationalException("Trade download not supported for futures.")
pairs_not_available = refresh_bac... | [start_download_data->[,join,config,info,validate_timeframes,parse_timerange,refresh_backtest_trades_data,validate_pairs,TimeRange,bool,setup_utils_configuration,refresh_backtest_ohlcv_data,OperationalException,load_exchange,items,market_is_active,get,expand_pairlist,exit,convert_trades_to_ohlcv],start_list_data->[tabu... | Start download data. Refresh backtest trades data from the backtest trades directory. | Please keep this here (including the test for it). the ONLY reason to use freqtrade in this mode (download_trades / `--dl-trades`) is on kraken - which is a far way from supporting futures (ccxt does not support kraken futures at the moment). |
@@ -58,7 +58,7 @@ namespace System.Text.Json.Serialization.Converters
}
break;
default:
- Debug.Fail("This should never happen.");
+ Debug.Fail("We shouldn't be here if there are more than 4 parameters.");
... | [SmallObjectWithParameterizedConstructorConverter->[CreateObject->[Arg0,CreateObjectWithArgs,Arg3,Arg2,Arguments,Arg1],ReadAndCacheConstructorArgument->[Arg3,Position,Arg1,Assert,Fail,ReadJsonTyped,Arg2,Arguments,Arg0],InitializeConstructorArgumentCaches->[MemberAccessorStrategy,CreateObjectWithArgs,ShouldDeserialize,J... | read constructor argument. | What is "here" here? You mean in this method? |
@@ -99,13 +99,15 @@ bool ESP8266WiFiAPClass::softAP(const char* ssid, const char* passphrase, int ch
return false;
}
- if(!ssid || strlen(ssid) == 0 || strlen(ssid) > 31) {
+ size_t ssid_len = strlen(ssid);
+ if(!ssid || ssid_len == 0 || ssid_len > 32) {
// fail SSID too long or missin... | [No CFG could be retrieved] | This function checks if the given access point is a valid access point. get_config - get config for softap. | passphrase nullptr case is checked after strlen() |
@@ -490,6 +490,12 @@ export class AmpA4A extends AMP.BaseElement {
this.win.ampA4aValidationKeys = this.getKeyInfoSets_();
return this.verifyCreativeSignature_(
creativeParts.creative, creativeParts.signature);
+ })
+ // Emit adResponseVal... | [AmpA4A->[constructor->[AmpAdUIHandler,AmpAdXOriginIframeHandler,dev,platformFor,protectFunctionWrapper,SAFEFRAME],renderViaNameAttrOfXOriginIframe_->[NAMEFRAME,utf8Decode,dev,user,getDefaultBootstrapBaseUrl,stringify,assign,SAFEFRAME,reject,length,createElementWithAttributes],verifyCreativeSignature_->[cryptoKey,then,... | called when the layout is executed. Returns a non - null object if the request is successful or null if the request is cancelled Determines if a response contains a non - AMP response and if so extracts the ad creative Checks if a given AMP creative has expired and if so checks if it has been validated If ad url or cr... | Is there some cost to adding a promise (e.g. JS context switch)? Instead you can move this within verifyCreativeSignature |
@@ -0,0 +1,15 @@
+require "rails_helper"
+
+describe Loggers::LogWorkerQueueStats do
+ it "logs totals" do
+ allow(described_class).to receive(:record_totals)
+ described_class.run
+ expect(described_class).to have_received(:record_totals)
+ end
+
+ it "logs queue stats" do
+ allow(described_class).to re... | [No CFG could be retrieved] | No Summary Found. | it's a bit weird that we're testing the private methods of a class, this test would break if we change the name of the private methods, which probably shouldn't. maybe we can `allow/expect` the `DataDogStatsClient` since it's what it's ultimately doing, sending events to Datadog |
@@ -383,5 +383,8 @@ public final class PaneInfo {
}
return new PaneInfo(base.isFirst, base.isLast, base.timing, index, onTimeIndex);
}
+
+ @Override
+ public void verifyDeterministic() {}
}
}
| [PaneInfo->[toString->[toString],createPane->[PaneInfo,createPane,encodedByte],PaneInfoCoder->[decode->[PaneInfo,fromTag],encode->[chooseEncoding,encode],PaneInfoCoder],encodedByte,PaneInfo]] | Decodes a single node from the specified input stream. | nit: remove extra new line |
@@ -159,6 +159,7 @@ function checkForErrors(jdlObject, configuration) {
let applicationType = configuration.applicationType;
let databaseType = configuration.databaseType;
let skippedUserManagement = configuration.skipUserManagement;
+ let blueprints = configuration.blueprints;
... | [No CFG could be retrieved] | Reads the JHipster configuration object and returns an object with the parsed JDL content Checks if. yo - rc. json exists and if so returns it. | You've forgotten to add the "blueprints" param to the jsdoc starting from l.63. |
@@ -35,7 +35,7 @@ import org.sonar.api.rule.Severity;
import org.sonar.api.rules.RuleType;
import org.sonar.api.utils.Duration;
import org.sonar.api.utils.KeyValueFormat;
-import org.sonar.server.search.BaseDoc;
+import org.sonar.server.es.BaseDoc;
public class IssueDoc extends BaseDoc implements Issue {
| [IssueDoc->[status->[getField],projectUuid->[getField],reporter->[UnsupportedOperationException],language->[getField],attributes->[parse,emptyMap,getNullableField],setManualSeverity->[setField],authorLogin->[getNullableField],setAssignee->[setField],effortToFix->[UnsupportedOperationException],setLanguage->[setField],a... | Imports a single - field object from the base document. Gets the componentKey moduleUuid and modId from the fields. | Shouldn't the 'index' package be also renamed 'es' ? |
@@ -27,7 +27,7 @@ from pants.engine.parser import SymbolTable
from pants.engine.rules import SingletonRule
from pants.engine.scheduler import Scheduler
from pants.option.global_options import GlobMatchErrorBehavior
-from pants.scm.change_calculator import EngineChangeCalculator
+from pants.option.options_bootstrappe... | [LegacyGraphScheduler->[new_session->[new_session]],EngineInitializer->[setup_legacy_graph_extended->[LegacyGraphScheduler,LegacySymbolTable]]] | Creates a new object of type u2c. base. base. base. base. This method is called after all the tasks in the engine have completed. | This import looks unused. I believe that if `isort` weren't failing, this would show up as the next lint failure. |
@@ -7540,7 +7540,7 @@ void Sedp::save_matching_data_and_get_typeobjects(const XTypes::TypeInformation*
if (get_complete) {
if (DCPS_debug_level >= 4) {
ACE_DEBUG((LM_DEBUG,
- "(%P|%t) EndpointManager::save_matching_data_and_get_typeobjects: "
+ "(%P|%t) Sedp::save_matchi... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | I'm glad this rename (in logging statements) is happening but it should be handled in its own PR for master. |
@@ -3079,8 +3079,6 @@ func TestStopPipeline(t *testing.T) {
}
func TestStandby(t *testing.T) {
- // TODO(2.0 required): Investigate flakiness.
- t.Skip("Investigate flakiness")
if testing.Short() {
t.Skip("Skipping integration tests in short mode")
}
| [StartTransaction,DurationProto,PrintDetailedCommitInfo,Message,DeepEqual,JoinHostPort,SubscribeCommit,GetAuthenticatedPachClient,CreateRepo,WaitJob,Itoa,NewPipeline,VisitInput,NotNil,StartCommit,FormatLabelSelector,GetFile,DeletePipeline,ExecuteInTransaction,PrintDetailedJobInfo,WaitCommitSetAll,EqualOneOf,NoError,Fat... | Do first commit to dataRepo and then wait for it to finish. c. CreateRepo creates a new commit and pipeline for the given data repo. | It seems like `Standby` is now just `Autoscaling` - should probably rename the test as well. |
@@ -69,5 +69,6 @@ func (app *ChainlinkApplication) AddJob(job *models.Job) error {
}
app.Scheduler.AddJob(job)
+ app.NotificationListener.AddJob(job)
return nil
}
| [Start->[Start],AddJob->[SaveJob,AddJob],Stop->[Close,Info,Sync,Stop],Reconfigure,NewStore] | AddJob adds a job to the application. | Should return error, doing it in subsequent commit. |
@@ -158,9 +158,9 @@ export class Placement {
* @return {!Promise<number>}
*/
getEstimatedPosition() {
- return getElementLayoutBox(this.anchorElement_).then((layoutBox) => {
- return this.getEstimatedPositionFromAchorLayout_(layoutBox);
- });
+ return measurePageLayoutBox(this.anchorElement_).t... | [No CFG could be retrieved] | A private class which is used to provide a way to determine the y - position of the Determines if an ad has a reserved position and places it in the correct position. | nit: achor --> anchor |
@@ -405,12 +405,6 @@ func resourceComputeFirewallDelete(d *schema.ResourceData, meta interface{}) err
func resourceFirewall(d *schema.ResourceData, meta interface{}, computeApiVersion ComputeApiVersion) (*computeBeta.Firewall, error) {
config := meta.(*Config)
- project, _ := getProject(d, config)
-
- network, err... | [Delete,StringInSlice,Partial,Set,Strings,GetOk,Errorf,Len,SetId,Do,Id,Get,Split,Update,Sprintf,List,String,IntBetween,Insert,WriteString] | resourceFirewall - Gets the firewall object from the data and checks if it is valid. Get the list of allowed entries and the list of denied entries. | nice, you eliminated an API call with this change :) |
@@ -244,6 +244,7 @@ public final class KsqlRestApplication extends Application<KsqlRestConfig> imple
new JacksonMessageBodyProvider(JsonMapper.INSTANCE.mapper);
config.register(jsonProvider);
config.register(JsonParseExceptionMapper.class);
+ config.register(new KsqlRestServiceContextBinder(ksqlCo... | [KsqlRestApplication->[start->[start],buildApplication->[buildApplication,KsqlRestApplication],stop->[stop],displayWelcomeMessage->[getListeners,displayWelcomeMessage]]] | Override this to register unwanted exceptions in the application. | How will this work when we need to configure it differently for each request? |
@@ -18,7 +18,9 @@
public RecoverabilityComponent(SettingsHolder settings)
{
this.settings = settings;
-
+ var configuration = settings.Get<Configuration>();
+ MessageRetryNotification = configuration.MessageRetryNotification;
+ MessageFaultedNotification =... | [RecoverabilityComponent->[DelayedConfig->[settings,Zero,Warn],Initialize->[ErrorQueue,MaxNumberOfRetries,None,TransactionMode,AddStartupDiagnosticsSection,ErrorQueueAddress,UnrecoverableExceptions,GetDelayedRetryConfig,HostInformation,WireUpLegacyNotifications,ToString,settings,BindSending,ToArray,GetImmediateRetryCon... | Creates a new instance of the RecoverabilityComponent class. The name of the resource. | The other components takes this as an argument to not use the settings inside the component but since this component is not yet aligned we should do that in a separate PR |
@@ -18,6 +18,10 @@
*
* @package Elgg.Core
* @subpackage DataModel.File
+ *
+ * @property string $thumbnail Path to small thumbnail relative to file owner's filestore directory
+ * @property string $smallthumb Path to medium thumbnail relative to file owner\'s filestore directory
+ * @property string $largethu... | [ElggFile->[getFilenameOnFilestore->[getFilenameOnFilestore],size->[getSize],grabFile->[grabFile],tell->[tell],detectMimeType->[getFilenameOnFilestore],write->[write],seek->[seek],exists->[exists],save->[getFilestore],delete->[delete],close->[close],read->[read],open->[getFilename,open],eof->[eof]]] | Creates a new \ElggFile object which represents a single non - physical file. Set the metadata of a file in the filestore. | Do we care for these here? I personally never remember, so hinting is nice, but it is also irrelevant to most files (especially non entities). |
@@ -850,8 +850,10 @@ namespace Kratos {
it->CalculateRightHandSide(rhs_cond, r_process_info);
DEMWall* p_wall = dynamic_cast<DEMWall*> (&(*it));
p_wall->CalculateElasticForces(rhs_cond_elas, r_process_info);
- array_1d<double, 3> Normal_to_Element;
- ... | [No CFG could be retrieved] | This method is used to find the right hand side of a condition. computes the node pressure for the 3 - or 4 - node. | I would put this `if` for all the operations inside the loop. I am afraid that a null normal can bring problems in the following lines. |
@@ -1,6 +1,9 @@
require 'rails_helper'
RSpec.describe ServiceProviderSessionDecorator do
+ subject { ServiceProviderSessionDecorator.new(sp_name: sp_name, sp_logo: nil) }
+ let(:sp_name) { 'Best SP ever!' }
+
it 'has the same public API as SessionDecorator' do
SessionDecorator.public_instance_methods.each... | [to,context,new,be,describe,eq,each,it,require] | It describe the object that has the same public API as SessionDecorator. | I suggested the named subject, `subject(:decorator)` because then the tests can still read the same as they were before (`expect(decorator.foobar).to be_foobar`). I think un-named subjects are very easily confused, but again, small style nit, don't let that get in the way of this if you want to merge |
@@ -2026,6 +2026,7 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity {
protected void displayCardAnswer() {
Timber.d("displayCardAnswer()");
+ crashWebViewRenderer();
// prevent answering (by e.g. gestures) before card is loaded
if (mCurrentCard... | [AbstractFlashcardViewer->[MyWebView->[onScrollChanged->[onScrollChanged]],initLayout->[onClick->[lookUp,clipboardHasText]],onCollectionLoaded->[setTitle,onCollectionLoaded],onDestroy->[onDestroy],onCreate->[onCreate],onKeyDown->[onKeyDown],fillFlashcard->[updateForNewCard,switchTopBarVisibility],updateScreenCounts->[s... | Display the user answer. | I'm not sure you intend for this line to remain here? seems like it would crash any time we showed answer, and is likely just for local testing? |
@@ -681,7 +681,7 @@
"surrogateAuthRequired": false,
"enabled": true,
"clientAuthenticatorType": "client-secret",
- "secret": "jhipster-registry",
+ "secret": "**********",
"redirectUris": [
"http://127.0.0.1:8761/*",
"http://localhost:8761/*"
| [No CFG could be retrieved] | The default policy is a user - defined policy that grants access only for users within this realm This method returns a dictionary of all the configuration options that are set in the OpenID Connect configuration. | I think it's value should be `jhipster-registry` |
@@ -160,8 +160,7 @@ public class BattleTracker implements Serializable {
private boolean didThesePlayersJustGoToWarThisTurn(final PlayerId p1, final PlayerId p2) {
// check all relationship changes that are p1 and p2, to make sure that oldRelation is not war,
// and newRelation is war
- for (final Tuple... | [BattleTracker->[addBattle->[addBombingBattle,addBattle],fightDefenselessBattles->[getPendingBattle,getPendingBattleSites],removeBattle->[getBlocked,removeDependency],clearBattleRecords->[clear],addMustFightBattleChange->[addBattle],addAirBattle->[addBattle],clear->[clear],fightAirRaidsAndStrategicBombing->[fightAirRai... | Checks if there are any players that have just been moved to war this turn. | Ditto on long-line length violation. |
@@ -1821,7 +1821,7 @@ namespace Js
// 3. If func is either undefined or null, return undefined.
// 4. If IsCallable(func) is false, throw a TypeError exception.
// 5. Return func.
- BOOL result = JavascriptOperators::GetPropertyReference(handler, methodId, &varMethod, requestContext... | [No CFG could be retrieved] | This abstract operation is used to get the value of a specific property of a proxy. Checks if the current context has a non - zero value. | curious, why does GetPropertyReference not marshalling to the request context, when you pass the requestContex. Why do you have explicitly marshal after this call? |
@@ -142,10 +142,11 @@ export class BindExpression {
const params = this.eval_(args[1], scope);
const method = String(value);
- let validFunction = null;
- let unsupportedError = `${method} is not a supported function.`;
+ let validFunction;
+ let unsupportedError;
... | [No CFG could be retrieved] | Evaluates the given node and returns the value of the node and its children. Evaluate an expression. | Nit: Do the same for this case. |
@@ -105,6 +105,12 @@ class GradeEntryFormsController < ApplicationController
# For students
def student_interface
@grade_entry_form = GradeEntryForm.find(params[:id])
+ if @grade_entry_form.is_hidden
+ render 'shared/http_status', formats: [:html],
+ locals: { code: '404', message: HttpSt... | [GradeEntryFormsController->[new->[new],create->[new],update->[update]]] | This method is used to render a block of missing node responses for the student interface. It. | Align the elements of a hash literal if they span more than one line. |
@@ -761,7 +761,7 @@ namespace System
}
}
- private static unsafe string JoinCore(char* separator, int separatorLength, string?[] value, int startIndex, int count)
+ private static unsafe string JoinCore(char* separator, int separatorLength, IList<string?> value, int startIndex, int... | [String->[PadRight->[PadRight],SplitInternal->[SplitInternal],ToUpper->[ToUpper],ToLowerInvariant->[ToLower],PadLeft->[PadLeft],Join->[Join],Replace->[Replace],ToUpperInvariant->[ToUpper],CreateTrimmedString->[InternalSubString],JoinCore->[FillStringChecked,JoinCore],Split->[SplitInternal],Concat->[Concat,FillStringChe... | This method joins the values of the IEnumerable into a string using the separator specified. This method is called to allocate a new string from the array. if we copied exactly the right amount of elements return the new string. | Have you benchmarked this? In theory this could regress existing usage with arrays, as now every access is via an interface dispatch. |
@@ -0,0 +1,15 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+using System.Text.Json.Serialization;
+
+namespace System.Text.Json
+{
+ public static partial class JsonSerializer
+ {
+ internal static bool IsVa... | [No CFG could be retrieved] | No Summary Found. | This file under `S/T/J/Serialization` doesn't match the namespace (though on its own that isn't an issue). I think naming this file `JsonSerializer.cs` and putting this static helper on it is also a bit confusing. Consider calling it `JsonSerializer.Helpers.cs` and move it to the `S/T/J` directory. Alternatively, just ... |
@@ -42,7 +42,7 @@ func (m *MinTerm) Shutdown() error {
if m.termIn != nil {
go m.termIn.Close()
}
- if m.termOut != nil {
+ if m.termOut != nil && m.closeTermOut {
go m.termOut.Close()
}
return nil
| [Shutdown->[Close],Write->[Fprint],PromptPassword->[Write,GetPasswd,HasSuffix,Fd],Prompt->[ReadLine],open,New] | Shutdown shuts down the minterm. | Ah sorry I missed this the first time through. Why was this working before? Or was it silently risking a close-someone-else's-file condition? |
@@ -75,6 +75,10 @@ class Meson(object):
args = args or []
defs = defs or {}
+ # overwrite default values with user's inputs
+ for key in defs.keys():
+ self.options[key] = defs[key]
+
source_dir, self.build_dir = self._get_dirs(source_folder, build_folder,
... | [Meson->[configure->[_get_dirs],build->[_append_vs_if_needed]]] | Configures a single object. | Can be done in single line with ``self.options.update(defs)`` |
@@ -27,6 +27,8 @@ namespace System.Runtime.Intrinsics
public static Vector128<ulong> AsUInt64<T>(this Vector128<T> vector) where T : struct => throw new PlatformNotSupportedException();
public static T GetElement<T>(this Vector128<T> vector, int index) where T : struct => throw new PlatformNotSupporte... | [No CFG could be retrieved] | Get element from vector. | I don't see the usage of these APIs inside `ASCIIUtility.cs`. Any reason why this is added? |
@@ -355,7 +355,7 @@ class TestConv2dOp(OpTest):
place, atol=1e-5, check_dygraph=(self.use_mkldnn == False))
def test_check_grad(self):
- if self.dtype == np.float16:
+ if self.dtype == np.float16 or hasattr(self, "no_need_check_grad"):
return
place = core.CUDAPlac... | [TestConv2dOp->[test_check_grad_no_filter->[has_cuda],test_check_output->[has_cuda],setUp->[conv2d_forward_naive,init_kernel_type],test_check_grad->[has_cuda],test_check_grad_no_input->[has_cuda]],TestConv2dOp_v2->[test_check_grad_no_filter->[has_cuda],test_check_output->[has_cuda],setUp->[init_dilation,init_kernel_typ... | Check the gradient of a node in the network. | please also make sure the value of the `no_need_check_grad` attribute ist `True` here, and below |
@@ -120,7 +120,7 @@
typedef struct { uint16_t X, Y, Z, X2, Y2, Z2, Z3, E0, E1, E2, E3, E4, E5; } tmc_stepper_current_t;
typedef struct { uint32_t X, Y, Z, X2, Y2, Z2, Z3, E0, E1, E2, E3, E4, E5; } tmc_hybrid_threshold_t;
-typedef struct { int16_t X, Y, Z; } tmc_sgt_t;
+typed... | [No CFG could be retrieved] | The functions below are defined in the M217 file. The settings data structure for the specified type of block. | Don't forget to increase the EEPROM structure version number. |
@@ -32,6 +32,10 @@ class DebugPackagesCommand extends Command
$this
->setName('debug:packages')
->setDescription('Lists all existing packages and their version')
+ ->setDefinition(array(
+ new InputOption('local', null, InputOption::VALUE_NONE, 'list locally ... | [DebugPackagesCommand->[execute->[getName,getRepositories,getComposer,getPackages,getPrettyVersion,writeln,getPrettyName,getLocalRepository,getVersion],configure->[setHelp]]] | Configures the warning message for missing packages. | This command should probably just be called list |
@@ -157,7 +157,7 @@ public class LivyInterpreterIT {
}
}
- @Test
+// @Test
public void testSparkInterpreterDataFrame() {
if (!checkPreCondition()) {
return;
| [LivyInterpreterIT->[testPySparkInterpreter->[checkPreCondition],testSparkInterpreterDataFrame->[checkPreCondition],testSparkSQLInterpreter->[checkPreCondition],testSparkInterpreterWithDisplayAppInfo->[checkPreCondition],testSparkInterpreterRDD->[checkPreCondition],testSparkRInterpreter->[checkPreCondition],testLivyTut... | Interprets the spark interpreter with a group and a spark interpreter group and a spark interpreter This test method is used to test if a data frame contains a single missing value. Interprets a single record in the spark database. | Need to disable it as it could cause OOM in CI due to docker container memory limitation |
@@ -140,7 +140,7 @@ func (cs *ContainerService) setOrchestratorDefaults(isUpdate bool) {
o.KubernetesConfig.MobyVersion = DefaultMobyVersion
}
case Containerd, ClearContainers, KataContainers:
- if o.KubernetesConfig.ContainerdVersion == "" {
+ if o.KubernetesConfig.ContainerdVersion == "" || isUpdate {... | [SetPropertiesDefaults->[setVMSSDefaultsForMasters,setAgentProfileDefaults,setVMSSDefaultsForAgents,setStorageDefaults,SetDefaultCerts,GetCloudSpecConfig,setCustomCloudProfileDefaults,HasVMSSAgentPool,setExtensionDefaults,setHostedMasterProfileDefaults,setMasterProfileDefaults,IsVirtualMachineScaleSets,setWindowsProfil... | setOrchestratorDefaults sets the default values for the Orchestrator profile and the default This function is used to set the default values for all configuration options. This function is called to set all default values for all configuration options. | Can we get unit tests for this as well? |
@@ -235,7 +235,9 @@ func (kv *KV) loadFloatWithDefaultValue(path string, def float64) (float64, erro
// Flush flushes the dirty region to storage.
func (kv *KV) Flush() error {
if kv.regionKV != nil {
- kv.regionKV.FlushRegion()
+ if err := kv.regionKV.FlushRegion(); err != nil {
+ return err
+ }
}
return ... | [SaveRegion->[SaveRegion],LoadStores->[storePath,storeRegionWeightPath,storeLeaderWeightPath],SaveStoreWeight->[storeLeaderWeightPath,storeRegionWeightPath],SaveStore->[storePath],Close->[Close],LoadStore->[storePath]] | Flush flushes all the data in the kv. | How about just `return kv.regionKV.FlushRegion()`. |
@@ -1078,6 +1078,11 @@ namespace Microsoft.WebAssembly.Diagnostics
Log("verbose", $"Failed to clear breakpoints due to {clear_result}");
}
+ if (context.PauseOnCaught && context.PauseOnUncaught)
+ await SendMonoCommand(sessionId, MonoCommands.SetPauseOnException... | [MonoProxy->[AcceptEvent->[SendMonoCommand],RuntimeGetProperties->[SendMonoCommand],AcceptCommand->[SendMonoCommand,IsRuntimeAlreadyReadyAlready],IsRuntimeAlreadyReadyAlready->[SendMonoCommand],OnSetVariableValue->[SendMonoCommand],GetScopeProperties->[SendMonoCommand],RuntimeReady->[SendMonoCommand,Task,LoadStore],Set... | Returns a task that will be executed when the runtime is ready. | Won't this send both commands when `context.PauseOnCaught && context.PauseOnUncaught` is true? |
@@ -67,7 +67,7 @@ namespace MonoGame.Framework
static private ReaderWriterLockSlim _allWindowsReaderWriterLockSlim = new ReaderWriterLockSlim(LockRecursionPolicy.NoRecursion);
static private List<WinFormsGameWindow> _allWindows = new List<WinFormsGameWindow>();
- private readonly WinFormsGame... | [WinFormsGameWindow->[UpdateWindows->[UpdateMouseState],Dispose->[Dispose,UnregisterFromAllWindows],OnClientSizeChanged->[OnClientSizeChanged]]] | License for a WinFormsGameWindow region ResourceConfigGetter methods. | Cannot be readonly as we clear it in Dispose. |
@@ -127,7 +127,7 @@ func pullCmd(c *cliconfig.PullValues) error {
} else {
authfile := getAuthFile(c.String("authfile"))
spec := image
- systemContext := common.GetSystemContext("", authfile, false)
+ systemContext := image2.GetSystemContext("", authfile, false)
srcRef, err := alltransports.ParseImageName(... | [StartSpanFromContext,StringVar,HasPrefix,SetUsageTemplate,GetSystemContext,New,GetRuntime,Errorf,Bool,SplitN,Debugf,ID,DockerReference,Wrapf,NewOptionalBool,Name,Shutdown,LoadFromArchiveReference,Flag,Finish,ParseImageName,Println,SetHelpTemplate,ParseRegistryCreds,String,GetRepositoryTags,BoolVarP,Flags,BoolVar] | var returns a list of unique identifiers for the given image. finds all the tags that are not in the registry. | Not due to this review, but I think we can drop image2 now, I think the other include ending in image has gone away. (Or maybe I've been staring at the screen too long today and missed it). |
@@ -105,7 +105,7 @@ try:
Constant = Any
except ImportError:
try:
- from typed_ast import ast35 # type: ignore
+ from typed_ast import ast35 # type: ignore # noqa: F401
except ImportError:
print('The typed_ast package is not installed.\n'
'You can install it w... | [parse_type_string->[parse_type_comment],parse_type_comment->[ast3_parse],stringify_name->[stringify_name],TypeConverter->[visit_UnaryOp->[invalid_type,visit],visit_Num->[numeric_type],visit_Str->[parse_type_string],visit_Attribute->[invalid_type,visit],_extract_argument_name->[fail],visit_Subscript->[invalid_type,visi... | Parse a single node from a file. Creates a dummy object for the given type of the object. | I considered changing this to `__import__('typed_ast').ast35` to avoid the lint error but decided to one-off exclude |
@@ -339,6 +339,7 @@ namespace System
[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties | DynamicallyAccessedMemberTypes.NonPublicProperties)]
public abstract PropertyInfo[] GetProperties(BindingFlags bindingAttr);
+ [DynamicallyAccessedMembers(DynamicallyAccessedMemb... | [Type->[GetEvents->[GetEvents],GetNestedType->[GetNestedType],GetMethods->[GetMethods],GetNestedTypes->[GetNestedTypes],GetFields->[GetFields],Equals->[Equals],GetMember->[GetMember],GetTypeFromProgID->[GetTypeFromProgID],GetProperty->[GetProperty],InvokeMember->[InvokeMember],GetConstructors->[GetConstructors],GetInte... | Get the type handle of the object. | Why All (that includes NestedTypes as well) ? The doc says it can be only `constructor, method, property, or field` and I think they have to be public |
@@ -1058,7 +1058,8 @@ public abstract class SeekableStreamIndexTaskRunner<PartitionIdType, SequenceOff
ingestionState,
getTaskCompletionUnparseableEvents(),
getTaskCompletionRowStats(),
- errorMsg
+ errorMsg,
+ false
... | [SeekableStreamIndexTaskRunner->[pause->[isPaused],getEndOffsetsHTTP->[authorizationCheck],pauseHTTP->[authorizationCheck],maybePersistAndPublishSequences->[publishAndRegisterHandoff],getStartTime->[authorizationCheck],getRowStats->[authorizationCheck],getLiveReport->[authorizationCheck],setEndOffsets->[isPaused,getLas... | Get the task completion reports for a single task. | Why is this always `false`? Does it make more sense to be always `true` because realtime tasks will fail when handoff fails? |
@@ -144,8 +144,8 @@ public class ConsumeMQTT extends AbstractMQTTProcessor implements MqttCallback {
.build();
public static final PropertyDescriptor PROP_QOS = new PropertyDescriptor.Builder()
- .name("Quality of Service(QoS)")
- .description("The Quality of Service(QoS) to re... | [ConsumeMQTT->[transferQueueRecord->[transferFailure],customValidate->[customValidate],onScheduled->[onScheduled]]] | This class defines the properties of the MQTT consumer. The Record Reader is a field that is not part of the Java source code. | Unfortunately we can't change this as it would be a breaking change. You should add ``.displayName()`` in addition to ``.name``. |
@@ -192,6 +192,18 @@ func (p *provider) Diff(urn resource.URN, id resource.ID,
label := fmt.Sprintf("%s.Diff(%s,%s)", p.label(), urn, id)
logging.V(7).Infof("%s: executing (#olds=%d,#news=%d)", label, len(olds), len(news))
+ // Get the RPC client and ensure it's configured.
+ client, err := p.getClient()
+ if err... | [Check->[label,getClient,Check],Create->[label,Create,getClient],Delete->[label,Delete,getClient],Invoke->[label,Invoke,getClient],Update->[label,Update,getClient],GetPluginInfo->[label,GetPluginInfo],Read->[label,Read,getClient],Error->[Error],Configure->[label,Configure],Close->[Close],Diff->[label,Diff,getClient]] | Diff performs a diff of the given properties. DiffResult returns DiffResult for all items in the list that are not nil. | Lets default to assuming these are all Replaces instead to leave this conservative. Our hope is that this doesn't actually happen often, and so it's okay to be conservative here. If in practice we learn that this is painful, we could consider not being conservative here - but ideally we don't have to do that. |
@@ -535,9 +535,11 @@ class Article < ApplicationRecord
errors.add(:canonical_url, "must not have spaces") if canonical_url.to_s.match?(/[[:space:]]/)
end
+ # TODO: (Alex Smith) refactor liquid tag permissions
+ #
# Admin only beta tags etc.
def validate_liquid_tag_permissions
- errors.add(:body_mar... | [Article->[username->[username],update_notifications->[update_notifications],readable_edit_date->[edited?],evaluate_front_matter->[set_tag_list],set_cached_object->[username]]] | canonical_url must not have spaces and have only permitted tags. | Handling permissions, roles, and liquid tags are going to change entirely in a separate PR. But, because this PR introduces the liquid tag now by including `app/liquid_tags/email_subscription_tag.rb`, I need to somehow restrict it so users don't start messing with it, though technically it wouldn't render anything sinc... |
@@ -66,6 +66,7 @@ def test_pip_wheel_fail(script, data):
)
assert "FakeError" in result.stdout, result.stdout
assert "Failed to build wheelbroken" in result.stdout, result.stdout
+ assert result.returncode != 0
def test_pip_wheel_ignore_wheels_editables(script, data):
| [test_pip_wheel_downloads_wheels->[pip],test_pip_wheel_source_deps->[pip],test_no_clean_option_blocks_cleaning_after_wheel->[exists,pip,str],test_pip_wheel_fail_cause_of_previous_build_dir->[write_delete_marker_file,pip,makedirs,join],test_pip_wheel_success->[pip],test_pip_wheel_fails_without_wheel->[pip],test_pip_whee... | Test pip wheel failure. Check if a missing key is found in the local editable file. | We could probably have a few more of these around the place to make sure we're erroring out correctly, we've had a number of those problems in the past! |
@@ -65,6 +65,14 @@ public class DnsEntry {
return dnsClass;
}
+ /**
+ * Create a transformed DnsEntry with the passed time-to-live
+ * @param seconds The number of seconds
+ * @return A new DnsEntry identical to this one other than that it
+ * uses the passed time-to-live value
+ ... | [DnsEntry->[hashCode->[hashCode],toString->[toString],equals->[name,equals]]] | Returns the dnsClass of this node. | Missing '.' at end of line |
@@ -50,7 +50,7 @@ class SourceFilesRequest:
self.enable_codegen = enable_codegen
-@rule
+@rule(desc="Get all relevant source files")
async def determine_source_files(request: SourceFilesRequest) -> SourceFiles:
"""Merge all `Sources` fields into one Snapshot."""
unrooted_files: Set[str] = set()
| [determine_source_files->[MergeDigests,MultiGet,update,sorted,tuple,set,isinstance,SourceFiles,zip,Get,HydrateSourcesRequest],rules->[collect_rules],SourceFilesRequest->[__init__->[tuple]],dataclass] | Merge all Sources fields into one Snapshot. | This verb might be off. Note that this is a helper rule that can work on many targets at once, it's not the `HydrateSources` rule. |
@@ -169,7 +169,6 @@ final class ApiPlatformParser implements ParserInterface
foreach ($this->propertyNameCollectionFactory->create($resourceClass, $options) as $propertyName) {
$propertyMetadata = $this->propertyMetadataFactory->create($resourceClass, $propertyName);
-
if (
... | [ApiPlatformParser->[parseProperty->[parseProperty,parseResource]]] | Returns an array of property metadata for the given class. | I may think that this is bugging, and that we are not calling the good property with the good groups, @api-platform/core-team any opinion ? If you run this with the Dummy entity, you will see that this is not totally wrong |
@@ -1,6 +1,9 @@
-# ------------------------------------
-# Copyright (c) Microsoft Corporation.
-# Licensed under the MIT License.
-# ------------------------------------
+# coding=utf-8
+# --------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights rese... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - -. | this version should go up to `1.0.0b3` |
@@ -41,4 +41,8 @@ public interface DBTransactionBuffer extends Closeable {
void setLatestSnapshot(SnapshotInfo latestSnapshot);
void flush() throws IOException;
+
+ void init() throws IOException;
+
+ void close() throws IOException;
}
| [No CFG could be retrieved] | Flush the buffer to the underlying stream. | remove close here, since already `extends Closeable`. |
@@ -847,7 +847,7 @@ d_tm_record_timestamp(struct d_tm_node_t **metric, char *item, ...)
}
if (node == NULL) {
- rc = d_tm_add_metric(&node, path, D_TM_TIMESTAMP, "N/A", "N/A");
+ rc = d_tm_add_metric(&node, protect, path, D_TM_TIMESTAMP, "N/A", "N/A");
if (rc != D_TM_SUCCESS) {
D_ERROR("Failed to add and... | [No CFG could be retrieved] | record a timestamp in the D_TM_node_t Reads a high resolution timer snapshot value from the specified item. | (style) line over 80 characters |
@@ -202,11 +202,13 @@ def lamb_step_sparse(inputs, attributes, height, rows, row_numel, np_grad):
update_mom(row_id, update_value)
update_param()
+ beta1_pow_out = beta1_pow * beta1
+ beta2_pow_out = beta2_pow * beta2
- return param_out, moment1_out, moment2_out
+ return param_out, moment1... | [lamb_step_sparse->[update_param,update_mom],TestLambOp1->[setUp->[set_attrs]],TestSparseLambOp->[setup->[lamb_step_sparse],test_sparse_lamb->[check_with_place],check_with_place->[setup]]] | Simulate one step of the lamb optimizer. This function initializes the missing - block parameters moment1 moment2 and weight decay parameters. Gradient of the last missing row. | Please remove meaningless `g` in this class name |
@@ -163,7 +163,14 @@ class QuantizationTransformPass(object):
window_size=10000,
moving_rate=0.9,
skip_pattern=['skip_quant'],
- quantizable_op_type=['conv2d', 'depthwise_conv2d', 'mul']):
+ quantizable_op_type=['conv2d', 'depthwise_c... | [_is_input_all_not_persistable->[_get_op_input_var_names],AddQuantDequantPass->[apply->[_is_input_all_not_persistable,_get_op_input_var_names],_inser_quant_dequant_moving_average_abs_max_op->[_init_var_node]],ConvertToInt8Pass->[apply->[_remove_unused_var_nodes],_convert_to_int8->[_load_var]],OutScaleForTrainingPass->[... | A base class for all of the base class attributes. d - depthwise_conv2d - depthwise_conv2d - depthwise Sets the moving rate and quantizable ops to None. | replace exe with executor? |
@@ -57,7 +57,7 @@ var angularFiles = {
'src/ng/directive/ngController.js',
'src/ng/directive/ngCsp.js',
'src/ng/directive/ngEventDirs.js',
- 'src/ng/directive/ngIf.js',
+ 'src/ng/directive/ngIfUnless.js',
'src/ng/directive/ngInclude.js',
'src/ng/directive/ngInit.js',
'src/ng/directiv... | [No CFG could be retrieved] | This is a list of all JS files that are required by the ng - directive directive. Syntax - - - - - - - - - - - - - - - - -. | Shouldn't it be `ngUnless`? |
@@ -1139,5 +1139,15 @@ namespace System.Text.RegularExpressions.Tests
AssertExtensions.Throws<ArgumentNullException>("inner", () => System.Text.RegularExpressions.Match.Synchronized(null));
}
+
+ [Fact]
+ public void Explore()
+ {
+ //var regex2 = new Regex("abc(e... | [RegexMatchTests->[Match_Advanced->[Match,VerifyMatch],Match_Timeout_Throws->[Match],Result->[Result],Match->[Match],Match_Timeout_Repetition_Throws->[Match],Match_DeepNesting->[Match],Match_Invalid->[Match],Synchronized->[Synchronized,Match],Match_Timeout_Loop_Throws->[Match],Match_SpecialUnicodeCharacters_enUS->[Matc... | Checks if the node is synchronized. | This prototype has a bug while populating the word list for this pattern. When walking the tree in `RegexWriter`, there is an error in expanding the word list. I'll fix it later :) |
@@ -299,7 +299,9 @@ public class Lz4FrameEncoder extends MessageToByteEncoder<ByteBuf> {
if (buffer != null && buffer.isReadable()) {
final ByteBuf buf = allocateBuffer(ctx, Unpooled.EMPTY_BUFFER, isPreferDirect(), false);
flushBufferedData(buf);
- ctx.write(buf);
+ ... | [Lz4FrameEncoder->[finishEncode->[flushBufferedData],handlerRemoved->[handlerRemoved],close->[operationComplete->[close],run->[close,finishEncode],close,finishEncode],allocateBuffer->[allocateBuffer],flush->[allocateBuffer,flushBufferedData,flush]]] | Flush the buffer and write the footer. | Add an `assert` that `promise` is not `null` |
@@ -87,7 +87,7 @@ namespace Dynamo.Scheduler
throw new ArgumentNullException("initParams.DrawableIds");
var nodeModel = initParams.Node;
- if (!nodeModel.WasInvolvedInExecution && !initParams.ForceUpdate)
+ if (nodeModel.WasRenderPackageUpdatedAfterExecution && !ini... | [UpdateRenderPackageAsyncTask->[AddToLabelMap->[AddToLabelMap],GetRenderPackagesFromMirrorData->[GetRenderPackagesFromMirrorData]]] | Initialize the node model. | Should the above be `OR` rather than `AND`? |
@@ -0,0 +1,6 @@
+package io.quarkus.tck.config;
+
+// We need this class so that target/test-classes is added to the class path?
+public class Dummy {
+
+}
| [No CFG could be retrieved] | No Summary Found. | What breaks if `target/test-classes` isn't on the classpath? |
@@ -2394,3 +2394,7 @@ func DedupStringLists(lists ...[]string) (res []string) {
}
return res
}
+
+func CurrentUserIsBot(mctx libkb.MetaContext, botUID *gregor1.UID) bool {
+ return botUID != nil && botUID.Eq(gregor1.UID(mctx.G().Env.GetUID().ToBytes()))
+}
| [showLog->[showVerbose],Debug->[showLog],Less->[Less],Trace->[showLog],Len,Debug,GetLog] | Responsible for returning the responsible for id. | Why not ActiveDevice? |
@@ -112,9 +112,10 @@ class Article < ApplicationRecord
scope :admin_published_with, lambda { |tag_name|
published
- .where(user_id: SiteConfig.staff_user_id)
- .order(published_at: :desc)
- .tagged_with(tag_name)
+ .where(user_id: User.with_role(:super_admin)
+ .un... | [Article->[username->[username],evaluate_front_matter->[set_tag_list],update_notifications->[update_notifications],readable_edit_date->[edited?]]] | Initialize the model Select all tags in the nag - node. | Is this line included because the staff user is not necessarily someone with an admin role yet? If they are an admin out of the box, I imagine this line could be omitted? |
@@ -31,6 +31,12 @@ class Log4cplus(CMakePackage):
granular control over log management and configuration."""
homepage = "https://sourceforge.net/projects/log4cplus/"
- url = "https://nchc.dl.sourceforge.net/project/log4cplus/log4cplus-stable/1.2.0/log4cplus-1.2.0.tar.gz"
+ url = "https://dow... | [Log4cplus->[version]] | This function returns a list of log records that can be used to manage log management and configuration. | If you aren't going to add 1.0.4.3 anymore, you don't actually need this `url_for_version`. If you are going to add it, I like to put the `url_for_version` below the version()` directives. |
@@ -814,7 +814,7 @@ shard_open:
D_GOTO(out, rc);
shard_tgt->st_rank = obj_shard->do_target_rank;
- shard_tgt->st_shard = shard,
+ shard_tgt->st_shard = obj_shard->do_shard;
shard_tgt->st_tgt_idx = obj_shard->do_target_idx;
rc = obj_shard2tgtid(obj, shard, map_ver, &shard_tgt->st_tgt_id);
obj_shard_close(ob... | [No CFG could be retrieved] | region ethernet object read access dumps the object - request - related information from the object - request - message. | just curious any difference of using "shard" and "obj_shard->do_shard" at above L817 and L177? should be same? |
@@ -1848,7 +1848,12 @@ class SemanticAnalyzerPass2(NodeVisitor[None],
self.type.names[lval.name] = SymbolTableNode(MDEF, v)
elif explicit_type:
# Don't re-bind types
- self.name_already_defined(lval.name, lval)
+ global_def = self.globals.get(... | [merge->[MroError],infer_condition_value->[infer_condition_value],linearize_hierarchy->[linearize_hierarchy],make_any_non_explicit->[accept],SemanticAnalyzerPass2->[analyze_comp_for->[analyze_lvalue],name_not_defined->[add_fixture_note,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_ex... | Analyze an lvalue or a tuple or list of lvalues. Add a missing variable to the class. Check if a given lvalue is a known node or a nested list or tuple. | If you rewrite it using an if statement, then the cast will be unnecessary. |
@@ -83,7 +83,12 @@ class MemnnAgent(TorchRankerAgent):
def score_candidates(self, batch, cand_vecs, cand_encs=None):
mems = self._build_mems(batch.memory_vecs)
- scores = self.model(batch.text_vec, mems, cand_vecs)
+ # Check for rows that have no non-null tokens
+ pad_mask = None
+ ... | [MemnnAgent->[add_cmdline_args->[add_cmdline_args],_build_mems->[_time_feature]]] | Score candidates for the given batch. | you can use `self.NULL_IDX` |
@@ -364,4 +364,8 @@ public enum RecordFieldType {
public static RecordFieldType of(final String typeString) {
return SIMPLE_NAME_MAP.get(typeString);
}
+
+ public Set<RecordFieldType> getNarrowDataTypes() {
+ return Collections.unmodifiableSet(narrowDataTypes);
+ }
}
| [getArrayDataType->[ArrayDataType],of->[get],isWiderThan->[contains],getDataType->[DataType],getChoiceDataType->[add,ChoiceDataType],getRecordDataType->[RecordDataType],getMapDataType->[MapDataType],RecordDataType,MapDataType,ArrayDataType,ChoiceDataType,DataType,emptyList,put,asList,values,emptySet] | Returns the record field type for the given record type string. | Should make the member variable itself immutable instead of creating a new Set object to wrap the existing one for each invocation. |
@@ -437,6 +437,8 @@ type DeploymentCondition struct {
Type DeploymentConditionType
// Status of the condition, one of True, False, Unknown.
Status kapi.ConditionStatus
+ // The last time this condition was updated.
+ LastUpdateTime unversioned.Time
// The last time the condition transitioned from one status to ... | [No CFG could be retrieved] | Integrity of the type of a given condition. | I prefer the `LastProbeTime` from pretty much all types other than deployment since this probably didn't change (update) the condition at all. |
@@ -1067,13 +1067,15 @@ namespace Js
int i = 0;
for (collation = uenum_next(collations, &collationLen, &status); collation != nullptr; collation = uenum_next(collations, &collationLen, &status))
{
+ ICU_ASSERT(status, collation != nullptr && collationLen > 0);
... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - UTF - 16 - 16. | I can't find anything for this bug number (?). |
@@ -0,0 +1,4 @@
+<?php
+
+$version = snmp_get($device, "MERU-GLOBAL-STATISTICS-MIB::mwSystemGeneralVersion.0", "-OQv");
+$hardware = snmp_get($device, "MERU-GLOBAL-STATISTICS-MIB::mwSystemGeneralModel.0", "-OQv");
| [No CFG could be retrieved] | No Summary Found. | Can you convert these two `snmp_get()` calls into one `snmp_get_multi_oid()`. You also don't and shouldn't prepend the MIB name to the OID, pass it as an arg to the function. |
@@ -54,16 +54,14 @@ class RPNHead(nn.Module):
return logits, bbox_reg
-def permute_and_flatten(layer, N, A, C, H, W):
- # type: (Tensor, int, int, int, int, int) -> Tensor
+def permute_and_flatten(layer: Tensor, N: int, A: int, C: int, H: int, W: int) -> Tensor:
layer = layer.view(N, -1, C, H, W)
... | [concat_box_prediction_layers->[permute_and_flatten],RegionProposalNetwork->[_get_top_n_idx->[pre_nms_top_n,_onnx_get_num_anchors_and_pre_nms_top_n],forward->[concat_box_prediction_layers,assign_targets_to_anchors,filter_proposals,compute_loss],filter_proposals->[post_nms_top_n,_get_top_n_idx]]] | Permute and flatten the given layer and return the resulting tensor. | The variable A is unused one, but I think should be fixed by a follow-up PR. As it would need a few more edits. |
@@ -90,7 +90,10 @@ class ExcerptStructureExtension extends AbstractExtension
*/
public function save(NodeInterface $node, $data, $webspaceKey, $languageCode)
{
- foreach ($this->excerptStructure->getProperties() as $property) {
+ $excerptStructure = $this->getExcerptStructure();
+ $... | [ExcerptStructureExtension->[getExcerptStructure->[setLanguageCode],getContentData->[getContentData]]] | Save the data to the node. | I doubt that it make sense to cache this class, if the value has always to be adapted... Why is it done this way? |
@@ -70,7 +70,7 @@ public class SCMUpgradeFinalizer extends
}
@Override
- public Void call() throws IOException {
+ public Void call() throws IOException, InterruptedException {
try {
emitStartingMsg();
versionManager.setUpgradeState(FINALIZATION_IN_PROGRESS);
| [SCMUpgradeFinalizer->[runPrefinalizeStateActions->[runPrefinalizeStateActions]]] | This method is called when a new version of a feature is required. | I don't see any blocking calls. Removing `InterruptedException` does not indicate unhandled exception in this method. |
@@ -523,6 +523,9 @@ namespace ILCompiler
_commandLineOptions.CompileBubbleGenerics);
}
+ // Load any profiles generated by method call chain analyis
+ CallChainProfile jsonProfile = new CallChainProfile(_commandLineOptions.CallCha... | [Program->[Run->[ProcessCommandLine,ConfigureTarget,InitializeDefaultOptions],Main->[Run,DumpReproArguments]]] | Runs the type system context. Private function to find all the input files that are not managed by CppInputFiles. Checks if a file is a managed module and if so creates a compilation group and a list Creates a module group that can be run based on the specified parameters. | This crashes when CallChainProfileFile is not specified, could you please add a string.IsNullOrEmpty conditional check? I guess your current PR build will also fail because of that. |
@@ -183,7 +183,7 @@ class TestFeaturedCollectionSignals(TestCase):
collection=self.collection,
application=self.collection.application)
assert index_addons.delay.call_count == 1
- index_addons.delay.call_args[0] == ([self.addon.pk],)
+ assert index_addons.delay.call_args... | [TestCollections->[test_set_addons->[get_addons,activitylog_count],test_collection_meta->[activitylog_count]]] | Test if update featured status does index add - ons. | Yeah I wrote that and the ones below... |
@@ -738,7 +738,7 @@ class ItemFormatter(BaseFormatter):
'ctime': partial(self.format_time, 'ctime'),
'atime': partial(self.format_time, 'atime'),
}
- for hash_function in hashlib.algorithms_guaranteed:
+ for hash_function in self.__class__.hash_algorithms:
s... | [BaseFormatter->[format_item->[get_item_data]],ellipsis_truncate->[swidth_slice],format_line->[InvalidPlaceholder,PlaceholderError],Location->[parse->[replace_placeholders],_parse->[normpath_special]],DatetimeWrapper->[__format__->[__format__]],json_print->[json_dump],ItemFormatter->[get_item_data->[remove_surrogates],... | Initialize the object with the given parameters. | self.hash_algorithms didn't work? |
@@ -401,9 +401,10 @@ class NginxConfigurator(common.Plugin):
:type unused_options: Not Available
"""
redirect_block = [[
- ['if', '($scheme != "https")'],
- [['return', '301 https://$host$request_uri']]
- ]]
+ ['\n ', 'if', ' ', '($scheme != "https")... | [NginxConfigurator->[enhance->[choose_vhost],_make_server_ssl->[_get_snakeoil_paths],perform->[restart,perform],recovery_routine->[recovery_routine],cleanup->[revert_challenge_config,restart],rollback_checkpoints->[rollback_checkpoints],view_config_changes->[view_config_changes],get_all_certs_keys->[get_all_certs_keys]... | Redirect all equivalent HTTP traffic to ssl_vhost. . | Question: Is there a difference as far as our parser is concerned between `['\n']` and `\n` at the end of a block? |
@@ -30,7 +30,9 @@ import org.graylog2.plugin.Tools;
import org.graylog2.plugin.rest.ValidationResult;
import org.graylog2.plugin.streams.Stream;
-class NotificationTestData {
+public class NotificationTestData {
+ public static final String TEST_NOTIFICATION_ID = "1234";
+
static EventNotificationContext ge... | [NotificationTestData->[getDummyContext->[build]]] | Get a dummy context for the given notification. build a nany node. | maybe we could make that id a little more explicit. like `testing-testing-123` :) |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.