patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -19,6 +19,8 @@ class Query(graphene.ObjectType):
Category, filterset_class=DistinctFilterSet,
level=graphene.Argument(graphene.Int))
category = graphene.Field(Category, id=graphene.Argument(graphene.ID))
+ page = graphene.Field(Page, id=graphene.Argument(graphene.ID))
+ pages = graphene.... | [Query->[resolve_categories->[resolve_categories],resolve_attributes->[resolve_attributes],resolve_products->[resolve_products]]] | Create a Field object for the node with the given ID. | I expect that the common case will be to get the pages by their slug. ID is fine as it is standard API, but we also need to add `slug` argument here. |
@@ -82,7 +82,7 @@ import static <%= packageName %>.config.Constants.ID_DELIMITER;
<%_ } _%>
*/
<%_ if (databaseTypeSql || databaseTypeMongodb || databaseTypeNeo4j || databaseTypeCouchbase) { _%>
-public interface PersistentTokenRepository extends <% if (databaseTypeSql) { %>JpaRepository<% } %><% if (databaseTypeMo... | [No CFG could be retrieved] | Package private for testing purposes find by user. | Extract to PersistentTokenRepository_couchbase.java.ejs |
@@ -110,6 +110,9 @@ export class AmpSlideScroll extends BaseCarousel {
if (inViewport) {
this.hintControls();
}
+ if (inViewport == false) {
+ this.updateInViewport(this.slides_[this.slideIndex_], inViewport);
+ }
}
/** @override */
| [No CFG could be retrieved] | Creates a wrapper element that wraps the slides in the container and adds it to the slides wrapper Handler for the scroll event. | Why only when `false`? |
@@ -75,7 +75,7 @@ def _limit_gpu_memory():
if gpus:
tf.config.experimental.set_virtual_device_configuration(
gpus[0],
- [tf.config.experimental.VirtualDeviceConfiguration(memory_limit=1152)])
+ [tf.config.experimental.VirtualDeviceConfiguration(memory_limit=1024)])
return True
ret... | [GradientCheckpointTest->[test_raises_oom_exception->[_limit_gpu_memory,_train_no_recompute],test_does_not_raise_oom_exception->[_limit_gpu_memory,_train_with_recompute]],_train_with_recompute->[_compute_loss,_get_dummy_data,_get_split_cnn_model],_train_no_recompute->[_compute_loss,_get_dummy_data,_get_big_cnn_model]] | Helper function to limit GPU memory for testing. | Is this an accidental revert of a previous change? |
@@ -162,6 +162,8 @@ ds_mgmt_tgt_pool_create_ranks(uuid_t pool_uuid, char *tgt_dev,
D_DEBUG(DB_TRACE, "fill ranks %d idx %d "DF_UUID"\n",
tc_out_ranks[i], idx, DP_UUID(tc_out_uuids[i]));
}
+ D_FREE(tc_out->tc_tgt_uuids.ca_arrays);
+ D_FREE(tc_out->tc_ranks.ca_arrays);
rc = DER_SUCCESS;
| [No CFG could be retrieved] | decref - > DF_UUID - > DF_UUID - > DF decref - decref action for n - n - n - n - n - n. | I think this is incorrect, it is fields in rpc's output struct right? it should be allocated and freed by proc func internally. Here the test did not report error just because D_FREE set ca_arrays as NULL, so did not trigger issue as free(NULL) will not cause problem. But the code here looks not correct to me, should r... |
@@ -112,8 +112,18 @@ func (mlr *Multiline) Next() (Message, error) {
return mlr.state(mlr)
}
+func (r *Multiline) Close() error {
+ close(r.done)
+ return r.reader.Close()
+}
+
func (mlr *Multiline) readFirst() (Message, error) {
for {
+ select {
+ case <-mlr.done:
+ return Message{}, ErrReaderStopped
+ de... | [readNext->[reset,Next,addLine,pred,startNewLine,pushLine],Next->[state],readFirst->[startNewLine,readNext,Next],readFailed->[reset],startNewLine->[pushLine,addLine],Match,New,Errorf] | Next returns the next message in the multiline stream. | we need to test the done channel here, with us closing the underlying reader anyways? We need the done channel at all? |
@@ -498,6 +498,8 @@ class Addon(OnChangeMixin, ModelBase):
if generate_guid:
data['guid'] = guid = generate_addon_guid()
+ data = cls.resolve_webext_translations(data, upload)
+
addon = Addon(**dict((k, v) for k, v in data.items() if k in fields))
addon.status = amo.ST... | [watch_disabled->[Addon],AddonManager->[valid_q->[q],__init__->[__init__]],Addon->[increment_version->[save],__new__->[__new__],all_dependencies->[valid],update_status->[update_version,logit],create_addon_from_upload_data->[initialize_addon_from_upload],transformer->[attach_related_versions,transformer,attach_previews,... | Initialize a new Addon object from a JSON object. | You might want to do this after the default locale has been determined below ? |
@@ -154,7 +154,8 @@ public abstract class AbstractFlatTextFormatParser implements Parser<String, Obj
setFieldNames(ParserUtils.generateFieldNames(values.size()));
}
- return Utils.zipMapPartial(fieldNames, Iterables.transform(values, valueFunction));
+ Map<String, String> fieldValueMap = Uti... | [AbstractFlatTextFormatParser->[parseToMap->[setFieldNames],setFieldNames->[setFieldNames]]] | Parse the input string and return a map of the fields and values. | I suggest to populate a HashMap in a simple loop, without `multiValueTransformer` functional object, but rather having it's functionality in a method in `AbstractFlatTextFormatParser` class. |
@@ -107,6 +107,8 @@ func (s resultsCache) handleHit(ctx context.Context, r *QueryRangeRequest, exten
reqResps []requestResponse
err error
)
+ log, ctx := spanlogger.New(ctx, "handleHit")
+ defer log.Finish()
requests, responses := partition(r, extents)
if len(requests) == 0 {
| [handleHit->[Slice],handleMiss->[Do],Do->[handleHit,Sprintf,Do,handleMiss,ExtractOrgID,Now,get,put,filterRecentExtents,Add],get->[StartSpanFromContext,Int,Finish,Error,HashKey,Unmarshal,Log,LogFields,Fetch],RegisterFlags->[DurationVar,RegisterFlagsWithPrefix],put->[Store,Error,Marshal,HashKey,Log],filterRecentExtents->... | handleHit handles a hit request. | Do we want to add the same line to `handleMiss`? |
@@ -126,7 +126,12 @@ def _filter_ignored_elbs(elbs, key_field, arg_name, response_key_field, **kwargs
keys = [elb[key_field] for elb in elbs]
client = kwargs.pop("client")
# {'TagDescriptions': [{'ResourceArn': 'string','Tags': [{'Key': 'string','Value': 'string'},]}]}
- tags_list = cl... | [_get_elbs_v2->[send,pop,str,describe_load_balancers,capture_exception],describe_ssl_policies_v2->[str,send,capture_exception,kwargs],get_elbs->[_get_elbs],_filter_ignored_elbsv2->[_filter_ignored_elbs],get_all_elbs->[send,_filter_ignored_elbsv1,dict,get,update,_get_elbs,capture_exception],_filter_ignored_elbsv1->[_fil... | Filter out ELBs that should be ignored. | any chance we can catch the validation error more gracefully, and for example return an all elbs, without filtering? |
@@ -126,13 +126,11 @@ def arrays_to_variables(data_structure: Dict[str, Union[dict, numpy.ndarray]],
def _get_normalized_masked_log_probablities(vector, mask):
# We calculate normalized log probabilities in a numerically stable fashion, as done
# in https://github.com/rkadlec/asreader/blob/master/asreader/cu... | [arrays_to_variables->[arrays_to_variables],last_dim_softmax->[masked_softmax],masked_softmax->[_get_normalized_masked_log_probablities],masked_log_softmax->[_get_normalized_masked_log_probablities]] | Returns normalized log probabilities of the given vector masked by the given mask. | Hmm, with broadcasting, do we even need the `keepdim=True`, here and below? |
@@ -44,6 +44,12 @@ fname_event = op.join(s_path, 'sample_audvis_trunc_raw-eve.fif')
fname_label = op.join(s_path, 'labels', '%s.label')
fname_vol_inv = op.join(s_path,
'sample_audvis_trunc-meg-vol-7-meg-inv.fif')
+# trans and bem needed for channel reordering tests incl. forward computation
+... | [test_apply_inverse_operator->[_get_evoked],test_warn_inverse_operator->[_get_evoked],_compare_io->[_compare],test_make_inverse_operator->[_compare_inverses_approx,read_forward_solution_meg,_compare_io,_get_evoked],test_make_inverse_operator_free->[_compare_inverses_approx,read_forward_solution_meg,_get_evoked],test_ma... | Picks the types of the given sample from the Megabola data directory. Function to compare two audvis objects. | More DRY here to use `s_path` here instead of re-calling `testing.data_path` again |
@@ -181,7 +181,7 @@
</file>
</example>
*
- * @element INPUT
+ * @element INPUT, BUTTON, SELECT
* @param {expression} ngDisabled If the {@link guide/expression expression} is truthy,
* then the `disabled` attribute will be set on the element
*/
| [No CFG could be retrieved] | A directive that sets the disabled attribute on the element if the expression inside ngDisabled evaluates to Requires a check box. | Theoretically, it can go on any element, but I guess it makes sense to only recommend it for form controls. What about `textarea`? |
@@ -65,9 +65,12 @@ define([
this._eventHelper = new EventHelper();
this._eventHelper.add(dataSourceCollection.dataSourceAdded, this._onDataSourceAdded, this);
this._eventHelper.add(dataSourceCollection.dataSourceRemoved, this._onDataSourceRemoved, this);
+ this._eventHelper.add(dataSou... | [No CFG could be retrieved] | Displays the data in a single . Creates a new GeometryVisualizer for the given entities. | Can we avoid adding these primitives until at least one data source is added? Otherwise users will always have these two primitives in there app, which is something we try and avoid. |
@@ -222,9 +222,11 @@ export function getErrorReportUrl(message, filename, line, col, error,
'&c=' + encodeURIComponent(col || '');
}
url += '&r=' + encodeURIComponent(self.document.referrer);
+ url += '&ae=' + encodeURIComponent(accumulatedErrorMessages.join(','));
+ accumulatedErrorMessages.push(messa... | [No CFG could be retrieved] | Detects if a non - AMP JS script is on the current page. | Do we need the original fragment? |
@@ -1,8 +1,11 @@
# pylint: disable=invalid-name,line-too-long
+
+import pytest
+
from allennlp.data.dataset_readers.semantic_parsing.grammar_based_text2sql import GrammarBasedText2SqlDatasetReader
from allennlp.common.testing import AllenNlpTestCase
-
+@pytest.mark.skip(reason="Mark will fix in a nearby PR.")
cla... | [TestGrammarBasdText2SqlDatasetReader->[test_reader_can_read_data_with_entity_pre_linking->[print,list,read,len],setUp->[str,GrammarBasedText2SqlDatasetReader,super]]] | Set up the properties of the object. | Minor typo: `GrammarBasd` |
@@ -156,7 +156,7 @@ public class DataSourceAnalysis
// going-up order. So reverse them.
Collections.reverse(preJoinableClauses);
- return Pair.of(current, preJoinableClauses);
+ return Pair.of(Pair.of(current, currentDimFilter), preJoinableClauses);
}
/**
| [DataSourceAnalysis->[equals->[equals],isConcreteTableBased->[isConcreteBased],isConcreteBased->[isGlobal],isGlobal->[isGlobal],forDataSource->[DataSourceAnalysis]]] | Flattens a join into a single pair of the current and the list of pre -. | nit: Nested Pairs probably mean it's time for a named class. |
@@ -309,6 +309,11 @@ public class DataflowRunner extends PipelineRunner<DataflowPipelineJob> {
+ "' invalid. Please make sure the value is non-negative.");
}
+ if (dataflowOptions.isStreaming() && dataflowOptions.getGcsUploadBufferSizeBytes() == null) {
+ dataflowOptions.setGcsUploadBufferSize... | [DataflowRunner->[IterableWithWindowedValuesToIterable->[apply->[of]],Concatenate->[getAccumulatorCoder->[of],getDefaultOutputCoder->[of],mergeAccumulators->[createAccumulator]],BatchViewAsMultimap->[GroupByKeyHashAndSortByKeyAndWindow->[apply->[apply]],applyForMapLike->[addPCollectionRequiringIndexedFormat,apply],appl... | Creates a new DataflowRunner from the given options. Returns a runner object that runs if the given is valid. | You should use our own constant instead of referring to another constant which may change outside of our control |
@@ -8,6 +8,8 @@ from django.core.exceptions import ValidationError
from graphene import relay
from promise import Promise
+from saleor.graphql.checkout.types import DeliveryMethod
+
from ...account.models import Address
from ...account.utils import requestor_is_staff_member_or_app
from ...core.anonymize import o... | [OrderEvent->[resolve_discount->[get_order_discount_event],resolve_lines->[_resolve_lines->[OrderEventOrderLineObject,get_order_discount_event]]],OrderLine->[resolve_thumbnail->[_get_first_product_image->[_get_image_from_media],_resolve_thumbnail->[_get_first_variant_image,_get_image_from_media]]],Order->[resolve_user_... | Imports a single object from a model. _type - > _type. | It's should be relative import. |
@@ -62,11 +62,11 @@ def build_dict(pattern, cutoff):
word_freq[word] += 1
# Not sure if we should prune less-frequent words here.
- word_freq = filter(lambda x: x[1] > cutoff, word_freq.items())
+ word_freq = [x for x in list(word_freq.items()) if x[1] > cutoff]
dictionary = sorted(word... | [train->[reader_creator],test->[reader_creator],word_dict->[build_dict],reader_creator->[load->[tokenize],load],convert->[word_dict,train,test,convert],build_dict->[tokenize]] | Build a word dictionary from the corpus. | Follow up a PR to make them six xrange? |
@@ -974,8 +974,8 @@ class PackageBase(with_metaclass(PackageMeta, object)):
raise FetchError("Will not fetch %s" %
self.spec.format('$_$@'), ck_msg)
+ self.stage.create()
self.stage.fetch(mirror_only)
-
self._fetch_time = time.time() - start_... | [PackageBase->[do_install->[build_process->[do_stage,_stage_and_write_lock,do_fake_install,do_patch],remove_prefix,_update_explicit_entry_in_db,do_install,_process_external_package],sanity_check_prefix->[check_paths],do_uninstall->[uninstall_by_spec],build_log_path->[build_log_path],possible_dependencies->[possible_dep... | Creates a stage directory and downloads the tarball for this package. | Is `do_fetch` always granted to happen before any of the other operations listed above (`stage`, `patch`, `install`)? Just trying to figure out if we have corner cases where moving the create will cause something to fail... |
@@ -93,10 +93,11 @@ def get_index(channel_urls=(), prepend=True, platform=None,
channel_urls += context.channels
channel_priority_map = prioritize_channels(channel_urls, platform=platform)
- index = fetch_index(channel_priority_map, use_cache=use_cache, unknown=unknown)
- if prefix:
- sup... | [fetch_repodata->[read_mod_and_etag,fetch_repodata_remote_request,read_local_repodata],fetch_index->[make_index,_collect_repodatas],_collect_repodatas->[_collect_repodatas_concurrent,_collect_repodatas_serial],fetch_repodata_remote_request->[maybe_decompress,Response304ContentUnchanged],get_index->[supplement_index_wit... | Get the index of packages available on the channels. | Note the order here is now flipped. We build index from prefix information first, and then we add on top repodata information. |
@@ -435,6 +435,10 @@ class CheckoutCustomerDetach(BaseMutation):
error_type_class = CheckoutError
error_type_field = "checkout_errors"
+ @classmethod
+ def check_permissions(cls, context):
+ return context.user.is_authenticated
+
@classmethod
def perform_mutation(cls, _root, i... | [CheckoutBillingAddressUpdate->[perform_mutation->[CheckoutBillingAddressUpdate,save]],CheckoutCreate->[process_checkout_lines->[check_lines_quantity],clean_input->[retrieve_billing_address,retrieve_shipping_address,process_checkout_lines],Arguments->[CheckoutCreateInput],perform_mutation->[save,CheckoutCreate,clean_in... | Perform a mutation on a node. | We should check if the currently logged in user is the current owner of that checkout session. A malicious user could disassociate all checkouts from their current owners by enumerating all possible checkout IDs. |
@@ -0,0 +1,13 @@
+# Docker specific development configuration
+if Rails.env.development? && File.file?("/.dockerenv")
+ # Using shell tools so we don't need to require Socket and IPAddr
+ host_ip = `/sbin/ip route|awk '/default/ { print $3 }'`.strip
+ logger = Logger.new(STDOUT)
+ logger.info "Whitelisting #{host_i... | [No CFG could be retrieved] | No Summary Found. | moved this in an initializer because Rubocop was complaining that development.rb was becoming too big |
@@ -5,6 +5,7 @@
* Make sure not to add !default to values here
*/
+<%_ if (clientTheme === 'none') { _%>
// Colors:
// Grayscale and brand colors for use across Bootstrap.
| [No CFG could be retrieved] | All values of a single node - element in the page are optional and can be overwritten by. | Can you use `clientThemNone` derived variable starting from now? |
@@ -0,0 +1,9 @@
+using System.Collections.Generic;
+
+namespace Pulumi.X.Automation
+{
+ /// <summary>
+ /// A Pulumi program as an inline function (in process).
+ /// </summary>
+ public delegate IDictionary<string, object?> PulumiFn();
+}
| [No CFG could be retrieved] | No Summary Found. | I do wonder if we should have this return `Task<IDictionary<string, object?>` instead? It would allow consumers to make their `PulumiFn` asynchronous, but it would also make synchronous functions a bit uglier because they would need to return `Task.FromResult(output)`. We could have a `PulumiFnAsync` and a `PulumiFn` a... |
@@ -40,7 +40,7 @@ class JsonldContextDummy
* attributes={
* "jsonld_context"={
* "@id"="http://example.com/id",
- * "@type"="@id",
+ * "@var"="@id",
* "foo"="bar"
* }
* },
| [No CFG could be retrieved] | Missing class. | Please revert this. |
@@ -263,7 +263,7 @@ RSpec.describe MarkdownParser, type: :labor do
context "when a colon emoji is used" do
it "doesn't change text in codeblock" do
result = generate_and_parse_markdown("<span>:o:<code>:o:</code>:o:<code>:o:</code>:o:<span>:o:</span>:o:</span>")
- expect(result).to include("<span>⭕️<... | [generate_and_parse_markdown->[finalize],generate_and_parse_markdown,new,let,describe,build_stubbed,it,to,before,inner_html,username,require,word,include,start_with,each,context,search,not_to,eq,raise_error,and_return] | end of class methods renders the text in the codeblock properly. | is it just me or...are these two lines the same? |
@@ -403,9 +403,7 @@ public class SwingComponents {
promise.completeExceptionally(e.getCause());
} catch (final InterruptedException e) {
promise.completeExceptionally(e);
- // TODO: consider if re-interrupting the thread is the right thing to do when we can't throw
- // ... | [SwingComponents->[promptSaveFile->[approveSelection->[approveSelection]],newOpenUrlConfirmationDialog->[promptUser,newOpenUrlConfirmationDialog],newJPanelWithHorizontalBoxLayout->[newJPanelWithBoxLayout],newJMenu->[getSwingKeyEventCode],newJButton->[newJButton]]] | Asynchronously runs a task with a progress bar. | Remove the client logger. Not much value in logging an interrupted exception. In addition to that, the UI window is closing, so we are also logging into a black hole. |
@@ -242,13 +242,13 @@ public class DatabaseUpgradeChecker implements SystemIntegrityChecker {
_upgradeMap.put("4.5.2", new DbUpgrade[] {new Upgrade452to460(), new Upgrade460to461(), new Upgrade461to470()});
- _upgradeMap.put("4.5.3", new DbUpgrade[] {new Upgrade453to460()});
+ _upgradeMap.put... | [DatabaseUpgradeChecker->[check->[upgrade],runScript->[runScript],upgrade->[runScript]]] | API to register all the known upgrades. Upgrade - related tables are stored in the upgrade map. | there is no reason for this |
@@ -340,7 +340,7 @@ public class QuotaManagerImpl extends ManagerBase implements QuotaManager {
BigDecimal quotaUsgage;
BigDecimal onehourcostpergb;
BigDecimal noofgbinuse;
- onehourcostpergb = tariff.getCurrencyValue().multiply(aggregationRatio);
+ onehourco... | [QuotaManagerImpl->[calculateQuotaUsage->[processQuotaBalanceForAccount,aggregatePendingQuotaRecordsForAccount],configure->[mergeConfigs,configure],saveQuotaBalance->[saveQuotaBalance]]] | Update quota usage in database. | I think you need to remove the parameter aggregationRotio` on this change as it is no longer used is it? |
@@ -37,9 +37,11 @@ var (
config struct {
session.Config
- addr string
- dockerHost string
- vmPath string
+ addr string
+ dockerHost string
+ vmPath string
+ hostCertFile string
+ hostKeyFile string
}
defaultReaders []entryReader
| [serve->[handleFunc],Write->[Write],open->[Size,Name],Name,listen,stop,Size,serve,open] | The main function of the package. Secure is only applicable for vSAN and vSANs. | Ah I just noticed that I named these variables with a capital first letter -- do I need to rename these to `hostCertFile` and `hostKeyFile` to be idiomatic? |
@@ -34,9 +34,9 @@ import java.io.Serializable;
import java.time.Instant;
import java.util.Map;
-import org.nuxeo.ecm.core.bulk.BulkParameters;
-import org.nuxeo.ecm.core.bulk.BulkStatus;
-import org.nuxeo.ecm.core.bulk.BulkStatus.State;
+import org.nuxeo.ecm.core.bulk.io.BulkParameters;
+import org.nuxeo.ecm.core.b... | [BulkJsonReader->[readEntity->[setState,longValue,parse,asText,isNotEmpty,get,setCount,setResult,setSubmitTime,BulkStatus,setId,getStringField,setProcessed,emptyMap,has,getLongField,valueOf,paramsToMap]]] | Reads a single object from the System. This class is used to read bulk status from a JSON node. | Can we rename this class `BulkStatusJsonReader` ? |
@@ -211,7 +211,7 @@ func (u *userState) unlockedGet(metric model.Metric, cfg *UserStatesConfig) (mod
if !u.canAddSeriesFor(metricName, cfg) {
u.fpLocker.Unlock(fp)
- return fp, nil, httpgrpc.Errorf(http.StatusTooManyRequests, "per-metric series limit exceeded")
+ return fp, nil, httpgrpc.Errorf(http.StatusTooM... | [gc->[length,Lock,Unlock],canAddSeriesFor->[Lock,Unlock],unlockedGet->[mapFP,ExtractMetricNameFromMetric,canAddSeriesFor,Unlock,get,Lock,Errorf,add,FastFingerprint,length,put],numUsers->[RUnlock,RLock],removeSeries->[Unlock,Lock,ExtractMetricNameFromMetric,del,delete],get->[RUnlock,RLock],RegisterFlags->[DurationVar,In... | unlockedGet returns the fingerprint of the given metric and a series if it is available. | it would be helpful to include the limit. |
@@ -486,6 +486,15 @@ class ImperativeQuantizeOutputs(object):
self._gather_scales(infer_program, scope, fetch_targets)
+ # Remove `moving_average_abs_max_scale` node in sub graphs.
+ graph = IrGraph(core.Graph(infer_program.desc), for_test=False)
+ for sub_graph in graph.all_sub_graphs... | [ImperativeQuantizeOutputs->[_gather_scales->[_gather_input_scale,_gather_output_scale]],ImperativeQuantAware->[save_quantized_model->[save_quantized_model]]] | Save a quantized model. Gather scales and save the missing values in the model. | `threshold`?save infer modelop? |
@@ -526,9 +526,9 @@ class MediaManager implements MediaManagerInterface
if ($value ||
('tags' === $attribute && null !== $value) ||
('size' === $attribute && null !== $value) ||
- ('description' === $attribute && null !== $value) ||
- ('copyri... | [MediaManager->[modifyMedia->[save,getProperties,getEntityById],buildData->[save,getProperties],setDataToMedia->[get],getProperties->[get],addFormatsAndUrl->[getProperties],getCurrentUser->[getUser],getFormatUrls->[getByIds],delete->[getEntityById]]] | Sets data to a Media object. Private method to set the properties of a media object. | Why do we only remove it for these three attributes? What about all the others? |
@@ -581,8 +581,7 @@ namespace System.Windows.Forms
var p when
p == NativeMethods.UIA_ValuePatternId ||
p == NativeMethods.UIA_GridPatternId ||
- p == NativeMethods.UIA_TablePatternId ||
- p == NativeMeth... | [MonthCalendar->[MonthCalendarAccessibleObject->[GetPropertyValue->[GetPropertyValue],GetCalendarGridInfoText->[GetCalendarGridInfoText],FragmentNavigate->[FragmentNavigate],IsPatternSupported->[IsPatternSupported],GetCalendarGridInfo->[GetCalendarGridInfo],AccessibleObject->[GetCalendarGridInfo],ElementProviderFromPoi... | This method is called when the user clicks on a pattern. | Please remove extra space before `=>` |
@@ -370,7 +370,7 @@ def find_layout(info, ch_type=None, exclude='bads'):
FIFF.FIFFV_COIL_CTF_OFFDIAG_REF_GRAD)
has_CTF_grad = (FIFF.FIFFV_COIL_CTF_GRAD in coil_types or
(FIFF.FIFFV_MEG_CH in channel_types and
- any([k in ctf_other_types for k in coil... | [make_grid_layout->[Layout],_box_size->[ydiff,xdiff],read_montage->[Montage],find_layout->[read_layout,make_eeg_layout],read_layout->[_read_lout,Layout,_read_lay],make_eeg_layout->[Layout],_pair_grad_sensors->[_find_topomap_coords]] | Find a layout based on the channels in the info. Check if there is a VV - only or VV - only gradient in the current Returns layout of the vector view or None if there is no layout. | If we're really shooting to use generators, could this just be `sum(ch['coil_type'] = FIFF.FIFFV_COIL_KIT_GRAD for ch in chs)`? |
@@ -195,4 +195,16 @@ public abstract class AbstractAlertCondition implements EmbeddedPersistable, Ale
}
}
+ @VisibleForTesting
+ protected Optional<Number> getNumber(Object o) {
+ if (o instanceof Number) {
+ return Optional.of((Number)o);
+ }
+
+ try {
+ ... | [AbstractAlertCondition->[getTypeString->[toString],CheckResult->[newArrayList,addAll],getBacklog->[get],toString->[getDescription],getPersistedFields->[build],get,containsKey,toString]] | Ejecuta un nuevo Nuevo Nuevo Nuevo. | Minor semantic nitpick: Child classes are also using this (protected) method, so it's not just visible for testing. :wink: |
@@ -68,6 +68,11 @@ define([
* @param {Number} [options.rotation=0.0] The rotation of the extent in radians. A positive rotation is counter-clockwise.
* @param {Matrix4} [options.modelMatrix] The model matrix for this geometry.
* @param {Color} [options.color] The color of the geometry when a per-geome... | [No CFG could be retrieved] | Creates a geometry for a given extent on an ellipsoid centered at the origin. Rotation extent is invalid. | Instead of `minHeight` and `maxHeight`, use the `surfaceHeight` option and add a `height` property to the `extrudedOptions` that defaults to zero. In `constructExtrudedExtent`, get the minimum and maximum of those two. Also, if they're very close, you can call `constructExtent` instead. |
@@ -440,10 +440,10 @@ function _elgg_river_menu_setup($hook, $type, $return, $params) {
}
}
- if (elgg_is_admin_logged_in()) {
+ if ($item->canDelete()) {
$options = array(
'name' => 'delete',
- 'href' => elgg_add_action_tokens_to_url("action/river/delete?id=$item->id"),
+ 'href' => elgg_add... | [elgg_is_menu_item_registered->[getName],elgg_get_menu_item->[getName],_elgg_widget_menu_setup->[getTitle,canEdit],elgg_register_title_button->[canWriteToContainer],elgg_unregister_menu_item->[getName],_elgg_entity_menu_setup->[getGUID,canDelete,canEdit],_elgg_site_menu_setup->[setSelected,getHref,getSelected,getName],... | Setup menu for a river. | Not needed. `confirm` will add tokens. |
@@ -201,4 +201,16 @@ namespace Dynamo.Graph.Workspaces
return Name + ", Version=" + Version.ToString();
}
}
+
+ /// <summary>
+ /// Manages Package Dependencies for a workspace
+ /// </summary>
+ public class PackageDependencyManager
+ {
+ WorkspaceModel Workspace;
+
+ ... | [PackageDependencyInfo->[ToString->[ToString],GetHashCode->[GetHashCode]],PackageInfo->[ToString->[ToString],GetHashCode->[GetHashCode]]] | Returns a string representation of the . | This isn't being used yet. |
@@ -590,6 +590,8 @@ class Command(object):
set_subparser.add_argument("item", help="'item=value' to set")
init_subparser.add_argument('-f', '--force', default=False, action='store_true',
help='Overwrite existing Conan configuration files')
+ list_subparser.a... | [Command->[export->[export],info->[info],install->[install],editable->[info],source->[source],remove->[remove,info],new->[new],_print_similar->[_commands],imports->[imports],upload->[upload],copy->[copy],download->[download],run->[_warn_python_version,_print_similar,_commands,_show_help],export_pkg->[export_pkg],test->... | Manages Conan configuration. This method is called from the command line interface to set or get a specific key in the Install a config item. | Avoid the --raw for now, lets keep it simple. Users shouldn't parse this output for anything. |
@@ -153,7 +153,7 @@ namespace System.ComponentModel.Design.Tests
public static IEnumerable<object[]> Children_GetInvalidService_TestData()
{
- foreach (ICollection associatedComponents in new object[] { null, new object[0], new object[] { new Component() }})
+ foreach (ICollect... | [ComponentDesignerTests->[CustomInheritanceAttributeComponentDesigner->[PostFilterEvents->[PostFilterEvents],PostFilterProperties->[PostFilterProperties],PostFilterAttributes->[PostFilterAttributes]],SubComponentDesigner->[PreFilterProperties->[PreFilterProperties],GetService->[GetService],PostFilterEvents->[PostFilter... | Get invalid service test data. | nit: do you think it is worth having the code analysis run on tests? Could condition it with `Condition="'$(IsTestProject)' != 'true'"` or something |
@@ -28,6 +28,10 @@ func (t *BridgeTask) Type() TaskType {
return TaskTypeBridge
}
+func (t *BridgeTask) ApplyDefaults(inputValues map[string]string, g TaskDAG, self taskDAGNode) error {
+ return nil
+}
+
func (t *BridgeTask) Run(ctx context.Context, taskRun TaskRun, inputs []Result) (result Result) {
if len(inp... | [Run->[Wrapf,Debugw,String,getBridgeURLFromName,Run,WebURL,Warnw],getBridgeURLFromName->[TaskType,URL],Sprintf] | Type returns the type of the task. | If we define this return nil on the BaseTask we don't have to define it on every task, just override where needed |
@@ -2120,7 +2120,7 @@ class SemanticAnalyzer(NodeVisitor[None],
"""Check if s defines a namedtuple."""
if isinstance(s.rvalue, CallExpr) and isinstance(s.rvalue.analyzed, NamedTupleExpr):
return True # This is a valid and analyzed named tuple definition, nothing to do here.
- if l... | [SemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],attribute_already_defined->[already_defined],get_name_repr_of_expr->[get_name_repr_of_expr],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_expr->[an... | Check if s defines a namedtuple. | A CI error is raised `"error: Expression" has no attribute "name" `, its confusing because lvalue is either NameExpr or MemberExpr both of which have `name` attribute. |
@@ -31,6 +31,12 @@ class Mathematica(Package):
license_url = 'https://reference.wolfram.com/language/tutorial/RegistrationAndPasswords.html#857035062'
def install(self, spec, prefix):
+ # Backup .spack because Mathematica moves it but never restores it
+ rand_suffix = random.randint(1, 65... | [Mathematica->[install->[exists,ln,sh,format,join,which],version,format,getcwd]] | Installs a Wolfram script in the given prefix. | I would use Spack's `copy()` method for this. Same below. Also, if you copy it to the stage directory, you won't need a random suffix. Is there even anything in `<prefix>/.spack` before the installation starts? Maybe you can just create a directory at the end. Does the build log still get copied? |
@@ -437,12 +437,11 @@ namespace System
// time units to this DateTime.
private DateTime Add(double value, int scale)
{
- double millis_double = value * (double)scale + (value >= 0 ? 0.5 : -0.5);
-
- if (millis_double <= (double)-MaxMillis || millis_double >= (double)MaxM... | [DateTime->[TryFormat->[TryFormat],TimeToTicks->[TimeToTicks],TryParse->[TryParse],TypeCode->[DateTime],TryParseExact->[TryParseExact],TryCreate->[IsLeapYear,DateToTicks,TimeToTicks],GetDateTimeFormats->[GetDateTimeFormats],ToOADate->[TicksToOADate],IsDaylightSavingTime->[IsDaylightSavingTime],CompareTo->[Compare],GetD... | Adds a double value to the last missing value in the series. | >ThrowOutOfRange [](start = 24, length = 15) don't we have any other helper method doing the same instead of defining this one here? |
@@ -240,7 +240,9 @@ void SSDPClass::_send(ssdp_method_t method){
void SSDPClass::schema(WiFiClient client){
uint32_t ip = WiFi.localIP();
- client.printf(_ssdp_schema_template,
+ char buffer[strlen(_ssdp_schema_template)+1];
+ strcpy_P(buffer, _ssdp_schema_template);
+ client.printf(buffer,
IP2STR(&ip), ... | [schema->[IP2STR,localIP,printf],_update->[getRemoteAddress,strncmp,flush,millis,random,strcmp,read,getRemotePort,atoi,printf,_send,next,getSize],setSchemaURL->[strlcpy],_server->[sprintf],setURL->[strlcpy],setModelURL->[strlcpy],setManufacturerURL->[strlcpy],setSerialNumber->[snprintf,strlcpy],setModelNumber->[strlcpy... | This is a helper method to add schema information to an SSDP class. | shouldn't this be `strlen_P`? |
@@ -1265,6 +1265,10 @@ d_hhash_link_lookup(struct d_hhash *hhash, uint64_t key)
if (d_hhash_key_isptr(key)) {
struct d_hlink *hlink = (struct d_hlink *)key;
+ if (hlink == NULL) {
+ D_ERROR("NULL PTR type key.\n");
+ return NULL;
+ }
if (!d_hhash_is_ptrtype(hhash)) {
D_ERROR("invalid PTR type key be... | [No CFG could be retrieved] | d_hlink is the first link in the htable. d_hhash_link_delete - delete a link in a hhash. | Is this change intentional or left-over debugging? |
@@ -940,10 +940,8 @@ namespace System.Text.Unicode
uint inputCharsRemaining = (uint)(pFinalPosWhereCanReadDWordFromInputBuffer - pInputBuffer) + 2;
uint minElementsRemaining = (uint)Math.Min(inputCharsRemaining, outputBytesRemaining);
- if (Sse41.X64.IsSupp... | [Utf8Utility->[OperationStatus->[TestZ,IsFirstCharTwoUtf8Bytes,IsSecondCharTwoUtf8Bytes,ExtractTwoUtf8TwoByteSequencesFromTwoPackedUtf16Chars,UInt32EndsWithOverlongUtf8TwoByteSequence,IsSurrogateCodePoint,IsSecondCharAscii,UInt32FirstByteIsAscii,ExtractTwoCharsPackedFromTwoAdjacentTwoByteSequences,ExtractFourUtf8BytesF... | TranscodeToUtf8 - Transcodes a string of UTF - 8 characters from the input This function reads a non - zero non - zero non - zero non - zero non - Reads 8 bytes from the input buffer and writes 8 bytes to the output buffer if there are This function will check whether the vector contains non - ASCII data and if so narr... | Maybe rephrase as `Sse41.X64.IsSupported || (AdvSimd.Arm64.IsSupported && BitConverter.IsLittleEndian)` |
@@ -1,7 +1,10 @@
<?php
-if (!$os) {
- // Eaton UPS
- if (strstr($sysDescr, 'Eaton 5PX')) {
+ if (strstr($sysDescr, 'Eaton 5P') ||
+ strstr($sysDescr, 'Eaton 9130') ||
+ strstr($sysDescr, 'Eaton 93E') ||
+ strstr($sysDescr, 'Eaton 9PX') ||
+ strstr($sysDescr, 'Eaton Evolution') ||
+... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - -. | Why remove this part? |
@@ -84,6 +84,16 @@ namespace System.IO.Tests
SettingUpdatesPropertiesCore(item);
}
+ [Fact]
+ public void SettingUpdatesPropertiesWhenReadOnly()
+ {
+ if (!CanBeReadOnly)
+ return; // directories can't be read only, so automatic pass
+
+ ... | [BaseGetSetTimes->[TimesIncludeMillisecondPart_LowTempRes->[TimeFunctions],SettingUpdatesProperties->[SettingUpdatesPropertiesCore],DoesntExist_ReturnsDefaultValues->[TimeFunctions],SettingUpdatesPropertiesCore->[TimeFunctions],SettingUpdatesPropertiesOnSymlink->[TimeFunctions,SettingUpdatesPropertiesCore],TimesInclude... | Checks whether the system has a missing or existing object and sets the time on that object. | Nit: we generally try to use braces for one-line bodies on different lines, especially when that's the style in the rest of the file |
@@ -140,7 +140,7 @@ class AccountQueries(graphene.ObjectType):
@permission_required("account.manage_service_accounts")
def resolve_service_accounts(self, info, **_kwargs):
- return resolve_service_accounts(info)
+ return resolve_service_accounts(info, **_kwargs)
@permission_required("ac... | [AccountQueries->[resolve_user->[resolve_user],resolve_address_validation_rules->[resolve_address_validation_rules],resolve_staff_users->[resolve_staff_users],resolve_customers->[resolve_customers],resolve_service_accounts->[resolve_service_accounts],StaffUserInput,ServiceAccountFilterInput,CustomerFilterInput]] | Resolve service accounts. | you are using `kwargs` so you shouldn't use underscore in the name. (AFAIK) |
@@ -163,6 +163,7 @@ func resourceKmsCryptoKeyRead(d *schema.ResourceData, meta interface{}) error {
d.Set("key_ring", cryptoKeyId.KeyRingId.terraformId())
d.Set("name", cryptoKeyId.Name)
d.Set("rotation_period", cryptoKey.RotationPeriod)
+ d.Set("self_link", cryptoKeyId.cryptoKeyId())
d.SetId(cryptoKeyId.cryp... | [terraformId->[terraformId],terraformId,cryptoKeyId] | clearCryptoKeyVersions updates the CryptoKey and its versions. resourceKmsCryptoKeyDelete deletes a given resource from the state. | I think setting this to `cryptoKey.Name`would probably be safer, just in case for some reason we need to change the ID format again. |
@@ -343,11 +343,11 @@ namespace System.Net.Http.Functional.Tests
});
}
- [OuterLoop("Uses external servers")]
+ [OuterLoop("Uses external servers", PlatformDetection.LocalEchoServerIsNotAvailable)]
[Theory]
[InlineData(false)]
[InlineData(true)]
- ... | [HttpClientHandlerTest_Headers->[Task->[Value,UtcNow,ResponseHeaderEncodingSelector,Count,Host,False,SendAsync,ToList,ReadRequestDataAsync,Add,GetUnderlyingSocketsHttpHandler,First,VerifyResponseBody,All,Select,SecureRemoteEchoServer,ContentMD5,Null,IndexOf,Assert,CreateHttpClient,Same,Concat,RequestHeaderEncodingSelec... | Asynchronously gets a response with a valid header with a specific value. | Could you please explain the reasoning for this? |
@@ -82,7 +82,7 @@ class RealtimeUnmergedRecordReader extends AbstractRealtimeRecordReader
false, jobConf.getInt(MAX_DFS_STREAM_BUFFER_SIZE_PROP, DEFAULT_MAX_DFS_STREAM_BUFFER_SIZE), record -> {
// convert Hoodie log record to Hadoop AvroWritable and buffer
GenericRecord rec = (GenericReco... | [RealtimeUnmergedRecordReader->[createKey->[createKey],getProgress->[getProgress],createValue->[createValue],close->[close]]] | Creates a new instance of RealtimeUnmergedRecordReader for reading Hoodie log records produce a producer for the next parquet record. | what do we use in the merged record reader? cc @bvaradar |
@@ -277,6 +277,17 @@ public class CxfInboundMessageProcessor extends AbstractInterceptingMessageProce
soapActions.add(soapAction);
protocolHeaders.put(SoapBindingConstants.SOAP_ACTION, soapActions);
}
+
+ String eventRequestUri = event.getMessage... | [CxfInboundMessageProcessor->[stop->[stop],start->[start],sendToDestination->[getUri],processNext->[processNext],getRessponseOutputHandler->[write->[write]]]] | Send the event to the destination. find the next message in the chain This method is called when an exception occurs while dispatching the message to CXF. | this kind of construct unnecesarily executes getInboundProperty(String) twice. Isn't it better to first get the value in a variable and then apply the default value if null? |
@@ -287,9 +287,9 @@ void undrfire_state::draw_sprites_cbombers(screen_device &screen, bitmap_ind16 &
sprite_ptr->zoomx = zx << 12;
sprite_ptr->zoomy = zy << 12;
- if (primasks)
+ if (pritable)
{
- sprite_ptr->primask = primasks[priority];
+ sprite_ptr->primask = u32(~1) << u32(pritable[priority]... | [No CFG could be retrieved] | pick tiles back to front for x and y flips This function is called from the main loop of the MGR and MGR. It is. | Why do you need to cast the shift up to `u32` here? It shoudn't make any difference as the value has the be less than 32 anyway. |
@@ -669,3 +669,12 @@ func parseCreateOpts(c *cli.Context, runtime *libpod.Runtime, imageName string,
}
return config, nil
}
+
+//CreatePortBinding takes port (int) and IP (string) and creates an array of portbinding structs
+func CreatePortBinding(hostPort int, hostIP string) []nat.PortBinding {
+ pb := nat.PortBi... | [NewContainer,InitLabels,GetContainerCreateOptions,Pull,IsContainer,GetLocalImageName,IsImageID,StringSlice,GetImage,RAMInBytes,DisableSecOpt,SplitProtoPort,StringInSlice,GetImageInspectInfo,GetFQName,WithShmSize,IsSet,WriteFile,IsNotExist,ShmDir,ParsePortSpecs,Error,Stat,ParsePortRange,Args,Marshal,IsHost,NewImage,Pid... | returns config object and nil if not found. | Why not just do HostIP: hostIP Then eliminate the check below. By default HostIP will be "", and if hostIP="" nothing will change and code is nicer. |
@@ -35,11 +35,15 @@ class Onebox::Engine::YoutubeOnebox
<div class="onebox lazyYT lazyYT-container"
data-youtube-id="#{video_id}"
data-youtube-title="#{escaped_title}"
- data-width="#{video_width}"
- data-height="#{video_height}"
+ #{size_restricted ? size_ta... | [to_html->[html_escape,to_i,data],path,to_s,include,on,host,replace,alias_method,after_initialize,register_asset,remove,each,respond_to?] | Generates a single - box tag that represents a single - box window. | If size_restricted is true, I think this will leave us with duplicate width/height attributes? |
@@ -633,9 +633,7 @@ class Project extends CommonObject
$this->getLinesArray($user);
// Delete tasks
- foreach($this->lines as &$task) {
- $task->delete($user);
- }
+ $this->deleteTasks($this->lines);
// Delete project
if (! $error)
| [Project->[setCategories->[fetch],info->[fetch],load_state_board->[getProjectsAuthorizedForUser],createFromClone->[fetch,createFromClone,create,update],delete->[delete],load_board->[getProjectsAuthorizedForUser],shiftTaskDate->[fetch,update]]] | Delete a node in the system remove an object from the system. | Please provide the $user as parameter because it is received as parameter in delete() so we should not change behaviour by getting it as a global var later. |
@@ -97,7 +97,7 @@ public class AmqpInboundGatewayParserTests {
Address expected = new Address("fooExchange/barRoutingKey");
assertEquals(expected.getExchangeName(), defaultReplyTo.getExchangeName());
assertEquals(expected.getRoutingKey(), defaultReplyTo.getRoutingKey());
- //TODO Address.equals() when IO goes... | [AmqpInboundGatewayParserTests->[customMessageConverter->[assertTrue,getPropertyValue,getBean,assertSame,assertEquals,valueOf],verifyUsageWithHeaderMapper->[handleMessage->[build,send,getReplyChannel],any,Message,setAppId,getPropertyValue,setField,setContentType,setAccessible,setClusterId,getBean,MessageProperties,Mess... | This test is used to verify that the life cycle of the gateway is not turned off. Mocks the answer method. | Not important but this really replaces the above 2 assertions. |
@@ -23,7 +23,7 @@ class EthGasStationProvider extends SubProvider {
const jason = await res.json()
if (typeof jason[GAS_PRICE_KEY] !== 'undefined') {
// values come from EGS as tenths of gwei
- return String(jason[GAS_PRICE_KEY] * 1e8)
+ return '0x' + (jason[GAS_PRICE_KEY] * 1e8).toString(16)... | [No CFG could be retrieved] | Provides a subprovider that provides gas - related data for a given network. | That won't break the relayer, will it ? |
@@ -1643,10 +1643,10 @@ int speed_main(int argc, char **argv)
dsa_doit[i] = 1;
#endif
#ifndef OPENSSL_NO_EC
- for (loop = 0; loop < OSSL_NELEM(ecdsa_choices); loop++)
- ecdsa_doit[ecdsa_choices[loop].retval] = 1;
- for (loop = 0; loop < OSSL_NELEM(ecdh_choices); loop++)
- ... | [No CFG could be retrieved] | The main entry point for the network functions. finds the next header block and returns the number of headers the next private key and the. | Hopefully, there is no OOB because of the values that are used |
@@ -173,6 +173,7 @@ __all__ = [
'MSCOCORecall',
'MSCOCOKeypointsPrecision',
'MSCOCOKeypointsRecall',
+ 'MSCOCOSegmAveragePrecision',
'MSCOCOorigAveragePrecision',
'MSCOCOorigRecall',
'MSCOCOOrigSegmAveragePrecision',
| [No CFG could be retrieved] | This function returns the name of a specific feature. This function returns the name of a specific object. | is there plan to support `MSCOCOSegmRecall`? |
@@ -270,10 +270,14 @@ public class ComponentContainer implements ContainerPopulator.Container {
}
public ComponentContainer removeChild(ComponentContainer childToBeRemoved) {
- for (ComponentContainer child : children) {
+ requireNonNull(childToBeRemoved);
+ Iterator<ComponentContainer> childrenIterato... | [ComponentContainer->[size->[size],getComponentByKey->[getComponent],addExtension->[addComponent],getName->[getName],addIfMissing->[add],ExtendedDefaultPicoContainer->[makeChildContainer->[ExtendedDefaultPicoContainer],getComponent->[getComponent]],createPicoContainer->[start->[start],ExtendedDefaultPicoContainer],stop... | removeChild - remove a child container from this container. | you could use the same pattern for `removeChildren()` |
@@ -26,8 +26,9 @@ class PyPyzmq(PythonPackage):
version('16.0.2', sha256='0322543fff5ab6f87d11a8a099c4c07dd8a1719040084b6ce9162bcdf5c45c9d')
version('14.7.0', sha256='77994f80360488e7153e64e5959dc5471531d1648e3a4bff14a714d074a38cc2')
- depends_on('python@2.7:2.8,3.3:', type=('build', 'run'), when='@18:')... | [PyPyzmq->[setup_build_environment->[prepend_path],depends_on,version]] | This module shows the version of a protocol in the Zenomq library. Setup the build environment for zmq - py. | I'm not actually sure why this is the case. It builds fine with Python 3.9 on my laptop. |
@@ -246,8 +246,9 @@ public class Queue extends ResourceController implements Saveable {
}
/**
- * Verifies that the {@link Executor} represented by this object is capable of executing the given task.
+ * @deprecated discards information; prefer {@link #getCauseOfBlockage}
*... | [Queue->[contains->[getItem],getApproximateItemsQuickly->[getItems],BuildableItem->[leave->[all],enter->[all,add],isStuck->[getEstimatedDuration,getAssignedLabel],getCauseOfBlockage->[isEmpty,getAssignedLabel,isBlockedByShutdown]],isBuildBlocked->[isBuildBlocked],getItems->[add],withLock->[call],BuildableRunnable->[run... | Checks if the task can be taken from the queue. | Maybe the logic should be replaced by `return getCauseOfBlockage (item) == null` |
@@ -98,9 +98,14 @@ public class SparkInterpreterLauncher extends StandardInterpreterLauncher {
sparkProperties.setProperty("spark.pyspark.python", condaEnvName + "/bin/python");
}
- if (isYarnMode() && getDeployMode().equals("cluster")) {
+ if (isYarnCluster()) {
env.put("ZEPPELIN_SPARK_YARN_... | [SparkInterpreterLauncher->[setupPropertiesForSparkR->[mergeSparkProperty,getEnv],isYarnCluster->[getDeployMode,isYarnMode],buildEnvFromProperties->[buildEnvFromProperties],isYarnClient->[getDeployMode,isYarnMode]]] | Build environment variables from properties. Checks if there are any missing log4j files in the current environment and if so adds Add additional jars for spark interpreter and spark - interpreter - shaded. | I'm just curious but this setting helps to send proper status code to yarn? |
@@ -91,7 +91,7 @@ int LuaVoxelManip::l_set_data(lua_State *L)
MMVManip *vm = o->vm;
if (!lua_istable(L, 2))
- return 0;
+ throw LuaError("set_data called with missing parameter");
u32 volume = vm->m_area.getVolume();
for (u32 i = 0; i != volume; i++) {
| [gc_object->[lua_touserdata],create_object->[luaL_getmetatable,check_v3s16,lua_setmetatable,lua_istable,lua_newuserdata,getMap],l_get_node_at->[getNodeNoExNoEmerge,pushnode,checkobject,check_v3s16,getServer],l_set_lighting->[LuaError,checkobject,sortBoxVerticies,check_v3s16,getintfield_default,VoxelArea,v3s16,lua_istab... | This function set the data of an object. | "VoxelManip:set_data() called with ..." Same for the other throw LuaError lines? |
@@ -505,7 +505,7 @@ All jobs created by a pipeline will create commits in the pipeline's repo.
}
pipelineInfos, err := client.ListPipeline()
if err != nil {
- return grpcutil.ScrubGRPC(err)
+ return err
}
if raw {
for _, pipelineInfo := range pipelineInfos {
| [nextCreatePipelineRequest->[UnmarshalNext,Errorf],StringVar,Message,PrintDetailedDatumInfo,PrintDatumPfsStateHeader,ListDatum,RunFixedArgs,Flush,UnmarshalNext,PrintPipelineInfo,ReadFile,New,NewWriter,DeletePipeline,PrintDetailedJobInfo,Split,PrintJobHeader,Println,BoolVar,PrintJobInfo,Close,PrintDetailedPipelineInfo,R... | inspectPipeline returns info about a pipeline. var returns true if the command is able to delete a pipeline or all of the pipelines. | Why this change? It seems like the `ScrubGRPC` function should leave the error alone if it's not a grpc error w an error code. Do we want to display grpc error codes here specifically? |
@@ -477,9 +477,8 @@ namespace System.Net.Http.QPack
case 400:
case 404:
case 500:
- // TODO this isn't safe, some index can be larger than 64. Encoded here!
- buffer[0] = (byte)(0xC0 | H3StaticTable.StatusIndex[statusCode]);
- ... | [QPackEncoder->[EncodeLiteralHeaderFieldWithoutNameReferenceToArray->[EncodeLiteralHeaderFieldWithoutNameReference],EncodeValueString->[EncodeValueString],EncodeLiteralHeaderFieldWithStaticNameReference->[EncodeLiteralHeaderFieldWithStaticNameReference],Encode->[Encode,EncodeLiteralHeaderFieldWithoutNameReference],Enco... | Encode a status code into a header field. | Can we keep single byte write for those statuses that are still a single byte? Should be faster for those. |
@@ -171,7 +171,17 @@ public class QuarkusTestExtension
}
}
- runnerBuilder.setProjectRoot(Paths.get("").normalize().toAbsolutePath());
+ final Path projectRoot = Paths.get("").normalize().toAbsolutePath();
+ runnerBuilder.setProjectRoot(projectRoot);
+ ... | [QuarkusTestExtension->[interceptBeforeAllMethod->[throwBootFailureException,ensureStarted,isNativeTest],interceptTestMethod->[isNativeTest],interceptTestTemplateMethod->[isNativeTest],interceptAfterEachMethod->[isNativeTest],runExtensionMethod->[setCCL],beforeAll->[ensureStarted,isNativeTest],ExtensionState->[close->[... | Start the extension. Method to enable alternative. This method is called by the extension framework to initialize the application and then starts the extension. Closes the resource manager and sets the context class loader. | It would be nice to log.debug this exception, just in case |
@@ -91,11 +91,17 @@ function createHttpBackend($browser, createXhr, $browserDefer, callbacks, rawDoc
response = ('response' in xhr) ? xhr.response : xhr.responseText;
}
+ // Accessing statusText on an aborted xhr object will
+ // throw an 'c00c023f error' in IE9 and lower, do... | [No CFG could be retrieved] | This function is called by the browser when a response is received. POST a to the server. | this looks more readable to me: `if (!(status === ABORTED && msie < 10))` |
@@ -163,4 +163,13 @@ function get_number_system(country) {
return number_system_map[country];
}
-export { generate_route, generate_grid, build_summary_item, shorten_number };
+const map_defaults = {
+ center: [19.0800, 72.8961],
+ zoom: 13,
+ tiles: 'https://{s}.tile.openstreetmap.org/{z}/{x}/{y}.png',
+ options: ... | [No CFG could be retrieved] | nova - navec. | Can this be moved to the frappe/frappe/public/js/frappe/utils/utils.js file instead? |
@@ -67,14 +67,8 @@ class Jetpack_WPCOM_Block_Editor {
*/
public function show_error_if_logged_out() {
if ( ! get_current_user_id() ) {
- /* translators: %s: Login URL */
- $message = __( 'Please <a href="%s" target="_blank" rel="noopener noreferrer">log into</a> your Jetpack-connected site to use the block ... | [Jetpack_WPCOM_Block_Editor->[enqueue_scripts->[is_iframed_block_editor],add_tinymce_plugins->[is_iframed_block_editor]]] | Show error if logged out. | We probably want to rename this function and its docstring. |
@@ -353,6 +353,8 @@ public class NavigationDrawerActivity extends AnkiActivity {
// collection path has changed so kick the user back to the DeckPicker
AnkiDroidApp.closeCollection(true);
finishWithoutAnimation();
+ // Ensure the new collection directory... | [NavigationDrawerActivity->[setTitle->[setTitle],onActivityResult->[onActivityResult],onDestroy->[onDestroy],onConfigurationChanged->[onConfigurationChanged],onPostCreate->[onPostCreate]]] | Override onActivityResult to restart the activity if the collection path has changed. | The ability to change the AnkiDroid directory at runtime means there are actually two places where we have to worry about the accessibility of the AnkiDroid directory. |
@@ -88,6 +88,9 @@ func Load(
"host": common.MapStr{
"name": name,
},
+ "ecs": common.MapStr{
+ "version": "1.0.0-beta2",
+ },
},
},
}
| [NewConfig,Info,Set,IsSet,Put,New,GetRegistry,Errorf,NewString,L,Infof,Name,FindFactory,Config,Clear,NewStats,NewRegistry,Fail,Load,BoolVar] | Load creates a Pipeline from a single beat. Info object and a Monitors struct. loadOutput loads the output from the given beat. | Just a thought, if we vendor the generated ECS Go package we could rely on that package's constant (`ecs.Version`) for keep this value in sync. If you update the fields data you should also be updating the vendored ecs package. |
@@ -629,7 +629,7 @@ func (http *httpPlugin) collectHeaders(m *message) interface{} {
func (http *httpPlugin) setBody(result common.MapStr, m *message) {
if m.sendBody && len(m.body) > 0 {
- result["body"] = string(m.body)
+ result.Put("body.content", string(m.body))
}
}
| [ReceivedFin->[PrepareForNewMessage],extractParameters->[Parse,hideSecrets],doParse->[PrepareForNewMessage,messageComplete],GapInStream->[messageComplete,messageGap],Expired->[handleHTTP,PrepareForNewMessage,flushRequests,flushResponses,correlate],correlate->[flushResponses]] | setBody sets the body field of the message. | missing ',' before newline in argument list (and 10 more errors) |
@@ -209,6 +209,17 @@ public class ScanHBase extends AbstractProcessor implements VisibilityFetchSuppo
.addValidator(StandardValidators.CHARACTER_SET_VALIDATOR)
.build();
+ static final PropertyDescriptor BLOCK_CACHE = new PropertyDescriptor.Builder()
+ .displayName("Block Cache... | [ScanHBase->[ScanHBaseResultHandler->[handle->[getBatchSize,initNewFlowFile,finalizeFlowFile]]]] | This class defines the properties that are used to represent the given row in JSON format. The list of properties that can be used to determine if a resource is not authorized. | Since the HBase Scan object has `boolean cacheBlocks = true;` by default, do you think we should make this default to true? If we default to false then anyone using this processor will stop using block cache without realizing it. Also, since we are providing a default value then we can make this required. If its not re... |
@@ -8,6 +8,12 @@ from examples.eval_model import setup_args
import ast
import unittest
import parlai.core.testing_utils as testing_utils
+try:
+ import rouge as rouge
+except ImportError:
+ # User doesn't have rouge installed, so we can't use it for rouge
+ # We'll just turn off things, but we might want to... | [TestEvalModel->[test_output->[assertTrue,literal_eval,split,parse_args,len,set_defaults,assertGreater,eval_model,setup_args,range]],main] | Test output of the eval_model. py example. | Get rid of this try. See below for soln |
@@ -420,15 +420,9 @@ func (m *ppsMaster) makeCronCommits(ctx context.Context, in *pps.Input) error {
return err // Shouldn't happen, as the input is validated in CreatePipeline
}
pachClient := m.a.env.GetPachClient(ctx)
- // make sure there isn't an unfinished commit on the branch
- commitInfo, err := pachClient... | [cancelMonitor->[Lock,Unlock],makeCronCommits->[InspectCommit,FinishCommit,NewCommit,Done,Format,SquashCommitSet,IsNotFoundError,After,StartCommit,Until,Wrapf,Next,GetPachClient,Err,PutFile,NewReader,ParseStandard,getLatestCronTime,DeleteFile],monitorPipeline->[As,InspectJob,CoreV1,FinishAnySpan,AddSpanToAnyPipelineTra... | makeCronCommits creates a new commit in the given repository using the given input. Put in an empty file named by the timestamp. | some part of this block is wrong - the if condition isn't sufficient to avoid losing data, but it didn't seem clear to me that we should squash the entire commitset, potentially deleting unrelated data, just because a user (accidentally?) opened a commit on the cron repo. This could use broader discussion, as maybe `sq... |
@@ -1142,6 +1142,7 @@ class StorageCommonBlobTestAsync(StorageTestCase):
# Assert
self.assertIsNotNone(copy)
self.assertEqual(copy['copy_status'], 'success')
+ self.assertFalse(isinstance(copy['copy_status'], Enum))
self.assertIsNotNone(copy['copy_id'])
copy_content... | [StorageCommonBlobTestAsync->[_test_get_blob_metadata_fail->[_setup,_create_block_blob],_test_lease_blob_with_proposed_lease_id->[_setup,_create_block_blob],_test_get_blob_metadata->[_setup,_create_block_blob],test_shared_write_access_blob->[_test_shared_write_access_blob],_test_get_account_information_with_container_n... | Test copy blob with existing blob. | I would like to assert it is a string more than just not enum. :) |
@@ -1247,7 +1247,7 @@ if (is_dir(DIR_FS_CATALOG_IMAGES)) {
}
?>
</div>
- </div>
+ <!--</div>-->
<!-- footer //-->
<?php require(DIR_WS_INCLUDES . 'footer.php'); ?>
<!-- footer_eof //-->
| [Execute,display_count,get_allow_add_to_cart,get_handler,infoBox,add_session,notify,display_links,RecordCount,add] | Print a single . | I understand the `class` thing, but why remove the `div`? |
@@ -393,7 +393,7 @@ public class AvroSource<T> extends BlockBasedSource<T> {
ByteArrayInputStream byteStream = new ByteArrayInputStream(data);
switch (codec) {
case DataFileConstants.SNAPPY_CODEC:
- return new SnappyCompressorInputStream(byteStream);
+ return new SnappyCompresso... | [AvroSource->[validate->[validate],createDatumReader->[getFileSchema,getReadSchema],AvroBlock->[decodeAsInputStream,getCodec,createDatumReader],AvroReader->[getCurrentSource->[getCurrentSource],getSplitPointsRemaining->[getSplitPointsRemaining],createStream->[getSyncMarker],startReading->[getSyncMarker,createStream],re... | Decodes the given byte array into an input stream of the given codec. | Instead of re-implementing the codec factory with a fixed number of codecs, why don't we just use the CodecFactory to create an instance of the codec which we can use to decode the bytes using Avro's code? |
@@ -4006,8 +4006,8 @@ again:
static int
ds_obj_dtx_leader_prep_handle(struct daos_cpd_sub_head *dcsh,
struct daos_cpd_sub_req *dcsrs,
- struct daos_shard_tgt *tgts, uint32_t tgt_cnt,
- uint32_t req_cnt, uint32_t *flags)
+ struct daos_shard_tgt *tgts,
+ int tgt_cnt, int req_cn... | [No CFG could be retrieved] | Get the handle of the object from the DCA and dispatch it remotely. - - - - - - - - - - - - - - - - - -. | This solves this issue: CID 306807 (#2 of 2): Negative loop bound (NEGATIVE_RETURNS) negative_returns: req_cnt is passed to a parameter that cannot be negative. The negative return from ds_obj_cpd_get_dcsr_cnt() is : if (oci->oci_sub_reqs.ca_count <= dtx_idx) return -DER_INVAL; should this error return be handled expli... |
@@ -955,3 +955,13 @@ func (ctx *Context) RegisterResourceOutputs(resource Resource, outs Map) error {
func (ctx *Context) Export(name string, value Input) {
ctx.exports[name] = value
}
+
+// RegisterStackTransformation adds a transformation to all future resources constructed in this Pulumi stack.
+func (ctx *Conte... | [ReadResource->[ReadResource,DryRun],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],Invoke->[Invoke],resolve->[resolve],prepareResourceInputs->[DryRun],RegisterResourceOutputs->[DryRun,endRPC,RegisterResourceOutputs,beginRPC],Close->[Close],RegisterResource->[DryRun,RegisterResource]] | Export adds a new input to the context. | Is it possible for this to happen in the Go SDK? |
@@ -352,6 +352,11 @@ public abstract class MRCompactorJobRunner implements Runnable, Comparable<MRCom
}
}
+ private boolean isFailedPath(Path path, List<TaskCompletionEvent> failedEvents) {
+ return failedEvents.stream()
+ .filter(event -> path.toString().contains(event.getTaskAttemptId().toString(... | [MRCompactorJobRunner->[moveTmpPathToOutputPath->[call],submitAndWait->[getInputPaths],getApplicableFilePaths->[call->[accept->[getApplicableFileExtensions]]],shouldPublishData->[getInputPaths],getInputSize->[getInputPaths]]] | This method is called when the job is started. This method is called from MRCompactor to publish the data. It is called from. | This code is also in CompactionCompleteFileOperationAction.java. |
@@ -958,11 +958,14 @@ class InterfaceActionsAuto extends DolibarrTriggers
}
//var_dump($societeforaction);var_dump($contactforaction);var_dump($elementid);var_dump($elementtype);exit;
+ $type_code = '';
+ if (strpos($action, 'SENTBYMAIL')) $type_code = 'AC_EMAIL_OUT';
+
// Insertion action
require_once ... | [InterfaceActionsAuto->[runTrigger->[fetch,getFullName,transnoentitiesnoconv,create,transnoentities,loadLangs,trans,load]]] | This method is called by the trigger system when an action is triggered on an object Sets all properties of the object to default values Adds translations to the end of a sequence Adds translations to the end of a list of translations Load translation files required by the page Adds translations to the end of a seq... | The caller should be able to define the value by setting $object->actiontypecode So this value must used in priority and only after type_code can be used. Which value do you have for $object->actiontypecode when action is *SENTBYMAIL* ? |
@@ -13886,7 +13886,7 @@ def foo(y : int)
}
[Test]
- [Category("ExpressionInterpreterRunner"), Category("ProtoGeometry")]
+ [Category("ExpressionInterpreterRunner"), Category("ProtoGeometry")] [Ignore] [Category("PortToCodeBlocks")]
[Category("Failing")]
public void ID... | [BasicTests->[inlineconditional_stepin_656_7->[Step,AreNotEqual,Payload,Execute,GetWatchValue,AreEqual,Verify,PreStart],inlineconditional_stepin_656_5->[Step,AreNotEqual,Payload,Execute,GetWatchValue,AreEqual,Verify,PreStart],watchExpandClassinstance_Imperative_StepIn_758->[Step,AreNotEqual,Payload,Execute,GetWatchValu... | region > 7. 6. 1 Tests if there is a missing missing test frame. | please remove this failing category |
@@ -2083,6 +2083,11 @@ public class KeyManagerImpl implements KeyManager {
metadataManager.getLock().releaseReadLock(BUCKET_LOCK, volumeName,
bucketName);
}
+ if (args.getRefreshPipeline()) {
+ for(OzoneFileStatus fileStatus : fileStatusList){
+ refreshPipeline(fileStatus.getKeyInf... | [KeyManagerImpl->[completeMultipartUpload->[validateS3Bucket],createMultipartInfo->[validateS3Bucket],allocateBlockInKey->[allocateBlock],allocateBlock->[validateBucket,allocateBlock],abortMultipartUpload->[validateS3Bucket],getAcl->[validateBucket],getFileEncryptionInfo->[getKMSProvider,generateEDEK],getExpiredOpenKey... | List all of the objects in the cache that match the specified key arguments. This method is used to retrieve the entries from the database and add them to the cache. Get next greater - than - string. | I'm +1 on this JIRA. Can we file a follow up JIRA to allow batching refreshPipeline call instead of individual calls to save RPC traffic. |
@@ -57,7 +57,7 @@ public abstract class AbstractConfig implements Serializable {
private static final Pattern PATTERN_PATH = Pattern.compile("[/\\-$._0-9a-zA-Z]+");
- private static final Pattern PATTERN_NAME_HAS_SYMBOL = Pattern.compile("[:*,/\\-._0-9a-zA-Z]+");
+ private static final Pattern PATTERN_NA... | [AbstractConfig->[appendAttributes->[appendAttributes],checkParameterName->[checkNameHasSymbol],isPrimitive->[isPrimitive],appendProperties->[convertLegacyValue],toString->[getTagName,toString,isPrimitive],appendParameters->[appendParameters]]] | Abstract configuration class. This method is used to convert legacy properties to new ones. | I just learned that this is a limitation from the Dubbo framework. Previously, I got an exception when trying to use mock value with the following format: `fail: return null` |
@@ -39,9 +39,7 @@ add_action( 'init', __NAMESPACE__ . '\register_block' );
function render_block( $attributes, $content ) {
$save_in_post_content = get_attribute( $attributes, 'saveInPostContent' );
- if ( Blocks::is_amp_request() ) {
- Jetpack_Gutenberg::load_styles_as_required( FEATURE_NAME );
- }
+ Jetpack_Gut... | [No CFG could be retrieved] | Renders a block Generate the button. | Previously we were only loading the `view.scss` styles for amp requests. There are no other pre-existing stylesheets for the button on the frontend where I could put the alignment fixes; I'm still a little shaky on best practices here so I'm definitely looking for feedback if there's a better place to do this. |
@@ -24,6 +24,7 @@ import static org.apache.beam.sdk.util.WindowedValue.valueInEmptyWindows;
import static com.google.common.base.Preconditions.checkArgument;
import static com.google.common.base.Preconditions.checkState;
+import org.apache.beam.runners.core.UnboundedReadFromBoundedSource;
import org.apache.beam.ru... | [DataflowRunner->[IterableWithWindowedValuesToIterable->[apply->[of]],Concatenate->[getAccumulatorCoder->[of],getDefaultOutputCoder->[of],mergeAccumulators->[createAccumulator]],BatchViewAsMultimap->[GroupByKeyHashAndSortByKeyAndWindow->[apply->[apply]],applyForMapLike->[addPCollectionRequiringIndexedFormat,apply],appl... | Creates a new object using the parameters defined in the constructor. Imports all parameters related to worker pool. | @kennknowles @davorbonaci adding this here would make the Dataflow runner depend on runners-core. This violates our prior assumption that only the service half of the runner should depend on runner core. Opinions? |
@@ -775,6 +775,8 @@ module.exports = class binance extends Exchange {
}
async fetchDepositAddress (code, params = {}) {
+ await this.loadMarkets ();
+
let currency = this.currency (code);
let response = await this.wapiGetDepositAddress (this.extend ({
'asset': currency[... | [No CFG could be retrieved] | Cancel an order or cancel an order Withdraw a number of blocks from a given address. | This empty lines breaks the transpiler, but I'll edit it upon merging. Thx! |
@@ -431,6 +431,18 @@ public:
bool SetBossState(uint32 bossId, EncounterState state) override
{
+ // pull all the trash if not killed
+ if (bossId == BOSS_PATCHWERK)
+ if (state == IN_PROGRESS)
+ if (Creature* patch = instance->GetCreatu... | [No CFG could be retrieved] | This is a utility method that sets the n - tuple of the n - tuple of the check if a creature is not already in the system. | why not using a single IF with (condition1 && condition2 && ...) |
@@ -518,8 +518,9 @@ namespace Dynamo.Engine
/// <summary>
/// Import a library (if it hasn't been imported yet).
/// </summary>
- /// <param name="library"></param>
- internal bool ImportLibrary(string library)
+ /// <param name="library">The library to be loaded</par... | [LibraryServices->[AddAdditionalAttributesToNode->[FunctionSignatureNeedsAdditionalAttributes],AddAdditionalElementsToNode->[FunctionSignatureNeedsAdditionalElements],ImportLibrary->[UpdateLibraryCoreData],TryGetFunctionGroup->[CanbeResolvedTo],PopulatePreloadLibraries->[LoadLibraryMigrations],PopulateBuiltIns->[AddBui... | Imports a library. Checks if a library has a reserved version. | I'm confused by this- when is a library not locally imported? What do you mean by locally imported? |
@@ -381,11 +381,7 @@ public class CacheImpl<K, V> implements AdvancedCache<K, V> {
}
final boolean isEmpty(EnumSet<Flag> explicitFlags, ClassLoader explicitClassLoader) {
- // TODO: replace with stream findAny isPresent instead
- try (CloseableIterable<CacheEntry<K, Void>> iterable = filterEntries(A... | [CacheImpl->[endBatch->[endBatch],cacheEntrySet->[cacheEntrySet],removeGroup->[removeGroup],addListener->[addListener],associateImplicitTransactionWithCurrentThread->[isTxInjected],remove->[removeInternal,remove],get->[get,assertKeyNotNull],removeListener->[removeListener],getStatus->[getStatus],putInternal->[assertKey... | Checks if the cache is empty. | I would have expected to see `entrySet(explicitFlags, explicitClassLoader).isEmpty()` here, but I see it's the other way around - `AbstractCloseableIteratorCollection.isEmpty()` uses `cache.isEmpty()`. Wouldn't it be cleaner to put this implementation in the entry set? |
@@ -12152,6 +12152,9 @@ Case0:
BOOL JavascriptArray::GetNonIndexEnumerator(JavascriptStaticEnumerator * enumerator, ScriptContext* requestContext)
{
+#if ENABLE_COPYONACCESS_ARRAY
+ JavascriptLibrary::CheckAndConvertCopyOnAccessNativeIntArray<Var>(this);
+#endif
return enumerator->Initialize... | [No CFG could be retrieved] | Evolve typeHandlers so that the type of the array is not already set. Missing NegError if no NegError is found in the context. | Can we also add a check inside `JavsacriptArray::GetEnumerator()`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.