patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -30,6 +30,7 @@ const (
const (
Ubuntu Distro = "ubuntu"
Ubuntu1804 Distro = "ubuntu-18.04"
+ Ubuntu1804Gen2 Distro = "ubuntu-18.04-gen2"
RHEL Distro = "rhel"
CoreOS Distro = "coreos"
AKS1604Deprecated Distro = "aks" // deprecated AKS 16.04 distro.... | [No CFG could be retrieved] | returns a string constant for a given orchestrator type Port specifies the maximum TCP port to open and the maximum number of disks to add to the. | It bugs me that we have to define these consts twice... |
@@ -7,4 +7,12 @@ import java.io.Serializable;
*/
public interface Function extends Serializable {
+ default void loadCheckpoint(Object checkpointObject) {
+
+ }
+
+ default Object doCheckpoint() {
+ return null;
+ }
+
}
| [No CFG could be retrieved] | The function that is used to create a function from a sequence of numbers. | Add doc for all public methods |
@@ -423,8 +423,15 @@ public class PySparkInterpreter extends Interpreter implements ExecuteResultHand
}
synchronized (statementFinishedNotifier) {
- while (statementOutput == null) {
+ long startTime = System.currentTimeMillis();
+ while (statementOutput == null
+ && pythonScriptInitia... | [PySparkInterpreter->[getProgress->[getProgress],completion->[PythonInterpretRequest],getSQLContext->[getSQLContext,getSparkInterpreter],getJavaSparkContext->[getSparkInterpreter],createGatewayServerAndStartScript->[createPythonScript],getZeppelinContext->[getZeppelinContext,getSparkInterpreter],getSparkConf->[getJavaS... | completion method. | Shall we replace hard-coded constant value here with `MAX_TIMEOUT_SEC` ? Also, to get pretty stacktrace in case of this error - it's better to `logger.error("...", e);` |
@@ -1011,7 +1011,7 @@ def declares_pkg_resources_namespace_package(python_src: str) -> bool:
def merge_entry_points(
*all_entry_points_with_descriptions_of_source: Tuple[str, Dict[str, Dict[str, str]]]
-) -> Dict[str, List[str]]:
+) -> Dict[str, Dict[str, str]]:
"""Merge all entry points, throwing ValueErr... | [declares_pkg_resources_namespace_package->[is_call_to->[is_name],has_args,is_call_to],get_sources->[SetupPySources],get_owned_dependencies->[OwnedDependency,OwnedDependencies],generate_chroot->[SetupPySourcesRequest,InvalidSetupPyArgs,SetupPyChroot,InvalidEntryPoint,DependencyOwner,FinalizedSetupKwargs],get_requiremen... | Merge all entry points with descriptions of source. | Changed signature, to stay true to our "normalized" structure for entry points. The `List[str]` form for entry points is applied at the last moment when outputting for the setup kwargs. |
@@ -2060,6 +2060,7 @@ LowererMD::LoadFunctionObjectOpnd(IR::Instr *instr, IR::Opnd *&functionObjOpnd)
instr->InsertBefore(mov1);
functionObjOpnd = mov1->GetDst()->AsRegOpnd();
instrPrev = mov1;
+ instr->m_func->SetHasImplicitParamLoad();
}
else
{
| [No CFG could be retrieved] | Legalize a constant number of non - constant operands. MISSING - function object opnd. | You might want to add this setter in arm equivalent API for completeness, though you are not really optimizing for ARM #Closed |
@@ -84,6 +84,8 @@ public class LdapSettingsImpl extends PersistedImpl implements LdapSettings {
public static final String LDAP_GROUP_MAPPING_NAMEKEY = "group";
public static final String LDAP_GROUP_MAPPING_ROLEKEY = "role_id";
+ public static final String SYSTEM_PASSWORD_PLACEHOLDER = "*************";
+... | [LdapSettingsImpl->[getGroupSearchPattern->[nullToEmpty,get],getSystemPassword->[getSystemPasswordSalt,debug,decrypt,get,substring,toString,isEmpty],setSystemPasswordSalt->[put],setActiveDirectory->[put],isTrustAllCertificates->[toString,get,valueOf],setTrustAllCertificates->[put],setAdditionalDefaultGroups->[apply->[c... | Creates a LdapSettings object. Gets the embedded validations for a given node. | I am a bit opposed against the idea to return a magic string to mask the password. Maybe it is a better idea to use a boolean flag (`system_password_set`) to indicate that there is an ldap system password configured, which is returned in (and only in) the DTO used by `LdapResource#getLdapSettings`? The DTOs used for se... |
@@ -45,8 +45,15 @@ public class ActivityService {
.setAction(activity.getAction())
.setMessage(activity.getMessage())
.setData(KeyValueFormat.format(activity.getData()))
+ .setProfileKey((String) activity.getData().get("profileKey"))
.setType(activity.getType().name());
- dbClient.ac... | [ActivityService->[save->[setType,insert,name,index]]] | Save activity. | Why do you get the profileKey from the data of activity ? Why haven't you add a new property in Activity ? |
@@ -486,7 +486,16 @@ def sys_info(fid=None, show_paths=False):
PyQt5: 5.15.0
""" # noqa: E501
ljust = 15
- out = 'Platform:'.ljust(ljust) + platform.platform() + '\n'
+ platform_str = platform.platform()
+ if platform.system() == 'Darwin' and sys.version_info[:2] < (3, 8):
+ ... | [_get_stim_channel->[get_config],set_config->[get_config_path,_load_config],get_subjects_dir->[get_config],get_config->[get_config_path,_load_config],sys_info->[_get_numpy_libs]] | Print system information about a specific . Print a string describing a single unknown node error message. Print out a warning if a node has a specific version. | I am hesitant to add `re.match` without any check that the result is not None |
@@ -235,7 +235,7 @@ class ApacheConfigurator(augeas_configurator.AugeasConfigurator):
if not vhost.enabled:
self.enable_site(vhost)
- def choose_vhost(self, target_name):
+ def choose_vhost(self, target_name, temp=False):
"""Chooses a virtual host based on the given domain name.
... | [ApacheConfigurator->[enhance->[choose_vhost],perform->[restart,perform],make_addrs_sni_ready->[is_name_vhost,add_name_vhost],get_virtual_hosts->[_create_vhost],_add_name_vhost_if_necessary->[is_name_vhost,add_name_vhost],cleanup->[restart],_create_vhost->[_add_servernames],make_vhost_ssl->[_create_vhost],enable_site->... | Deploys a certificate to a virtual host. This method is called when a virtual host is not available. | You should update the docstring below to say what `temp` does with respect to ssl vhosts and caching. |
@@ -543,6 +543,8 @@ namespace System.ComponentModel.Composition.Hosting
private string GetDisplayName() =>
$"{GetType().Name} (Assembly=\"{Assembly.FullName}\")"; // NOLOC
+ [UnconditionalSuppressMessage("Single file", "IL3000: Avoid accessing Assembly file path when publishing as a sin... | [AssemblyCatalog->[Dispose->[Dispose],GetEnumerator->[GetEnumerator],GetExports->[GetExports]]] | Get the display name of the missing assembly. | In general I would avoid "dangerous"... we can use for example "single file compatible" or similar terminology. |
@@ -81,6 +81,15 @@ class ArticleApiIndexService
end
end
+ def collection_articles(collection_id)
+ Article.published.
+ where(collection_id: collection_id).
+ includes(:user, :organization).
+ order("collection_id").
+ page(page).
+ per(30)
+ end
+
def base_articles
Artic... | [ArticleApiIndexService->[state_articles->[where,to_i],top_articles->[per],get->[present?,decorate,state_articles],username_articles->[none,per,find_by],base_articles->[per],tag_articles->[per,requires_approval,present?,order,includes],attr_accessor]] | Find articles with state + state +. | I don't think one is needed, since they are filtered by collection id, they should probably be ordered by published time in ascending order, as in the first article should be the oldest of the series |
@@ -190,6 +190,12 @@ public class RefsOperation extends TransactionOperationAbstract {
}
}
+ private void clearLingerRef(MessageReference ref) {
+ if (!ref.hasConsumerId() && lingerSessionId != null) {
+ ref.getQueue().removeLingerSession(lingerSessionId);
+ }
+ }
+
private void d... | [RefsOperation->[afterRollback->[afterRollback],decrementRefCount->[decrementRefCount]]] | This method is called after commit of the transaction. It will check all the refs to ack. | No need for message ref. Just use the refop queue |
@@ -39,6 +39,10 @@ func main() {
halt()
}()
+ logFile, _ := os.OpenFile("/dev/ttyS1", os.O_WRONLY|os.O_SYNC, 0644)
+ syscall.Dup2(int(logFile.Fd()), 2)
+ os.Stderr.WriteString("all stderr redirected to debug log")
+
// where to look for the various devices and files related to tether
pathPrefix = "/.tether"
... | [FileMode,GuestInfoSink,Mknod,Warnf,Info,Stack,Error,New,Start,Mkdev,Errorf,HasSuffix,Infof,SetFormatter,InContainer,GuestInfoSource,StandardLogger,Register,NewToolbox,MkdirAll,Sprintf,Sync,Reboot,SetLevel] | requires that the n - device system is installed and available to be installed. Allocate a unique identifier for the guest. | do not ignore the error here |
@@ -283,4 +283,18 @@ public class VirtualColumns implements Cacheable
{
return virtualColumns.toString();
}
+
+ public DoubleColumnSelector makeDoubleColumnSelector(
+ String columnName,
+ ColumnSelectorFactory factory
+ )
+ {
+ final VirtualColumn virtualColumn = getVirtualColumn(columnName)... | [VirtualColumns->[makeDimensionSelector->[getVirtualColumn,makeDimensionSelector],makeFloatColumnSelector->[getVirtualColumn,makeFloatColumnSelector],detectCycles->[getVirtualColumn,detectCycles],getColumnCapabilities->[getVirtualColumn],equals->[equals],getVirtualColumn->[splitColumnName],create->[VirtualColumns],hash... | Returns the string representation of a . | Please arrange this method along with other similar methods |
@@ -35,6 +35,7 @@ module.exports = class currencycom extends Exchange {
'fetchTime': true,
'fetchTrades': true,
'fetchTradingFees': true,
+ 'loadTimeDifference': true,
},
'timeframes': {
'1m': '1m',
| [No CFG could be retrieved] | Provides a base class for all of the currencies that have a specific nonce. The currency API urls. | Let's remove this. |
@@ -26,14 +26,9 @@ module Users
else
result = personal_key_form.submit
- analytics_result = FormResponse.new(
- success: result.success?,
- errors: result.errors,
- extra: result.extra.except(:decrypted_pii),
- )
- analytics.track_event(Analytics::PERSON... | [VerifyPersonalKeyController->[personal_key_form->[new],new->[new],create->[new]]] | Creates a new user key object. | there are existing specs that ensure we don't put `decrypted_pii` in the form response here |
@@ -574,8 +574,9 @@ def test_load_bad_channels(tmp_path):
# Test forcing the bad case
with pytest.warns(RuntimeWarning, match='1 bad channel'):
- raw.load_bad_channels(bad_file_wrong, force=True)
- # write it out, read it in, and check
+ raw.load_bad_channels(bad_file_wrong, force=True,... | [test_multiple_files->[_compare_combo],test_compensation_raw_mne->[compensate_mne]] | Test reading and writing of bad channels. | verbose=None here is a noop, you shouldn't need to add this |
@@ -25,7 +25,7 @@ import {registerElement} from '../src/service/custom-element-registry';
* @type {!Array<string>}
*/
const ATTRIBUTES_TO_PROPAGATE = ['alt', 'title', 'referrerpolicy', 'aria-label',
- 'aria-describedby', 'aria-labelledby','srcset', 'src', 'sizes'];
+ 'aria-describedby', 'aria-labelledby','srcset... | [No CFG could be retrieved] | Creates an object that represents an image of a specific type. The callback for the that is called when a new is added to the. | Revert this change. |
@@ -452,6 +452,7 @@ class Collection(SeoModel):
Product, blank=True, related_name='collections')
background_image = VersatileImageField(
upload_to='collection-backgrounds', blank=True, null=True)
+ background_image_alt = models.CharField(max_length=128, blank=True)
is_published = models.B... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],get_first_image->[get_first_image]],CollectionQuerySet->[visible_to_user->[public]],Product->[is_in_stock->[is_in_stock]],ProductQuerySet->[visible_to_user->[available_products]]] | A class that represents a single product object. Model for the unique_code field. | How about changing that to just `image`? and `background_image_alt` to `image_alt`? Right now we are using this image in way more places than just the background, also we should not predefine the usage at the database level, what if someone wants to use it, as for example, a thumbnail? |
@@ -63,14 +63,14 @@ import java.util.Set;
* components. So far the capabilities are:
* <ul>
* <li>{@link MetadataKeyProvider}, to resolve {@link MetadataKey metadata keys} associated to a configuration</li>
- * <li>{@link ConfigurationParameterValueProvider}, to resolve {@link Value values} associated to a config... | [ConfigurationProviderToolingAdapter->[getMetadataKeys->[getMetadataKeys]]] | Creates a tooling adapter for the given configuration. | same as before. Incompatible change |
@@ -1096,7 +1096,16 @@ public abstract class AbstractFlashcardViewer extends NavigationDrawerActivity i
super.onBackPressed();
} else {
Timber.i("Back key pressed");
- closeReviewer(RESULT_DEFAULT, false);
+ if (!mDisablePressBack) {
+ closeReviewe... | [AbstractFlashcardViewer->[MyWebView->[onOverScrolled->[onOverScrolled],onScrollChanged->[onScrollChanged],onTouchEvent->[onTouchEvent],loadDataWithBaseURL->[loadDataWithBaseURL],findScrollParent->[findScrollParent]],LinkDetectingGestureDetector->[executeTouchCommand->[processCardAction],onWebViewCreated->[executeTouch... | Override onKeyDown to handle back key presses. | Same: combine the two equal branches with an or |
@@ -2600,7 +2600,17 @@ if (window.jasmine || window.mocha) {
currentSpec = null;
if (injector) {
- injector.get('$rootElement').off();
+ var cleanUpElems = [originalRootElement];
+ var $rootElement = injector.get('$rootElement');
+ if ($rootElement !== originalRootElement) cleanUpElems.p... | [No CFG could be retrieved] | A module that can be used to provide a specific configuration code. The * method is used to specify the number of modules which are represented as string. | I think this can be `jqLite.cleanData(cleanUpElements)`. Then you might not need the `off` or `removeData` calls above? |
@@ -1394,7 +1394,6 @@ pool_map_extend(struct pool_map *map, uint32_t version, struct pool_buf *buf)
D_DEBUG(DB_TRACE, "Merge buffer with already existent pool map\n");
rc = pool_map_merge(map, version, tree);
out:
- pool_tree_free(tree);
return rc;
}
| [No CFG could be retrieved] | Merges all components in the given buffer into a new pool map. get the n - ary pool from the given buffer and version. | Why this is removed? Looks like a memory leak. |
@@ -233,11 +233,13 @@ function applyResponse(win, response) {
return;
}
+ const viewer = Services.viewerForDoc(win.document);
const currentHref = win.location.href;
const url = parseUrl(adLocation);
const params = parseQueryString(url.search);
const newHref = addParamsToUrl(currentH... | [addParamsToUrl,all,status,href,dev,getMode,whenFirstVisible,applyResponse,isTrustedViewer,replaceUrl,isExperimentOn,location,getQueryParamUrl,hasCapability,history,document,getAttribute,indexOf,user,getParam,isTrustedReferrer,sendMessageAwaitResponse,json,invoke,parseQueryString,length,push,resolve,timerFor,search,isP... | Parses the response from the ad server and adds the extra url params that should be appended to This function parses the url query string and checks if the param already exists in the url. | Doesn't meant to overwrite fragment here. Maybe we should fix the issue for all, instead of just for Cct. Thanks. |
@@ -1,7 +1,7 @@
module RouteFormat
def self.username
- /[\w.\-]+?/
+ /[%\w.\-]+?/
end
def self.backup
| [No CFG could be retrieved] | Returns an array of strings representing the unique identifier for the user. | What is this % for? |
@@ -178,11 +178,13 @@
"pretest": "<%= clientPackageManager %> run lint",
"test": "ng test --coverage --log-heap-usage -w=2",
"test:watch": "<%= clientPackageManager %> run test -- --watch",
+ "watch": "concurrently 'npm run webapp:hmr' 'npm run backend:start'",
"webapp:build": "<%= clientPackageM... | [No CFG could be retrieved] | _% > _% > _% > _% > _% > _% >. | What happened if there is skip server? |
@@ -226,3 +226,17 @@ class TestGeneralOptions(object):
options1, args1 = main(['--cert', 'path', 'fake'])
options2, args2 = main(['fake', '--cert', 'path'])
assert options1.cert == options2.cert == 'path'
+
+
+class TestOptionsConfigFiles(object):
+
+ def test_general_option_after_subcomma... | [TestOptionsInterspersed->[test_general_option_after_subcommand->[main],test_subcommand_option_before_subcommand_fails->[main],test_additive_before_after_subcommand->[main],test_option_after_subcommand_arg->[main]],TestOptionPrecedence->[test_cli_override_environment->[main],test_env_alias_override_default->[main],test... | Test that the certificate specified in the command line is the same as the one specified in the. | how about relabel this test name. "test_venv_config_file_found" |
@@ -709,10 +709,8 @@ public abstract class FileBasedSink<T> extends Sink<T> {
*/
void copy(List<String> srcFilenames, List<String> destFilenames) throws IOException;
- /**
- * Remove a collection of files.
- */
- void remove(Collection<String> filenames) throws IOException;
+ /** Removes ... | [FileBasedSink->[LocalFileOperations->[copyOne->[copy]],populateDisplayData->[populateDisplayData],GcsOperations->[copy->[copy],remove->[remove],create],FileBasedWriteOperation->[removeTemporaryFiles->[buildTemporaryFilename],generateDestinationFilenames->[getFileExtension],getBaseOutputFilename],FileBasedWriter->[clos... | Copy files from one list to another. | This seems like it's going in the opposite direction of @peihe 's proposal for the new API. I'm fine with it, but surprised that @peihe signed off given that he'll just be rewriting this soon. |
@@ -908,11 +908,16 @@ if (zen_not_null($action) && $order_exists == true) {
<div class="row noprint"><?php echo zen_draw_separator('pixel_trans.gif', '1', '5'); ?></div>
<div class="row noprint">
<div class="formArea">
- <?php echo zen_draw_form('statusUpdate', FILENAME_ORDERS,... | [_doCapt,MoveNext,_doAuth,Execute,display_count,prepare_input,_doVoid,add_session,notify,_doStatusUpdate,infoBox,_doRefund,RecordCount,display_links,format,ExecuteNoCache,get_decimal_places,admin_notification] | Renders the object. ----- Shows the status of a node. | I haven't explored this, and I'm a bit reluctant to encourage rich-text in these fields, but if you add the `.editorHook` class to this textarea and have CKEditor enabled, it's possible we could also link it to the right language so that it offers spellcheck and UI in the corresponding language expected for the field (... |
@@ -292,11 +292,11 @@ main(int argc, char **argv)
DFUSE_TRA_UP(dfs, dfp, "dfs");
rc = duns_resolve_path(dfuse_info->di_mountpoint, &duns_attr);
- DFUSE_TRA_INFO(dfuse_info, "duns_resolve_path() returned %d", rc);
+ DFUSE_TRA_INFO(dfuse_info, "duns_resolve_path() returned %d %s", rc, strerror(rc));
if (rc == 0) ... | [No CFG could be retrieved] | -DER - DAS - 1 find the n - ary entry in the system. | (style) line over 80 characters |
@@ -0,0 +1,5 @@
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
+VERSION = "1.0.0b1"
| [No CFG could be retrieved] | No Summary Found. | @swathipil Is the version needed here and in the root `_version.py` file and the extension? I assume probably not but not sure which one to keep! |
@@ -174,6 +174,9 @@ def process_options(args: List[str],
parser.add_argument('--strict-optional', action='store_true',
dest='special-opts:strict_optional',
help="enable experimental strict Optional checks")
+ parser.add_argument('--strict-optional-whitelist', me... | [expand_dir->[expand_dir],process_options->[SplitNamespace]] | Parse command line arguments and return a tuple of build sources and options. Parse command line options and return a single node. This function is used to add additional arguments to a command line file to get more information specify the code to type check Check if missing missing key - value pairs. | Can you manually also turn on `--strict-optional` if this is not None, so I won't have to write `--strict-optional --strict-optional-whitelist`? |
@@ -42,7 +42,7 @@ define([
* @constructor
*
* @param {String} [expression] The expression defined using the 3D Tiles Styling language.
- * @param {Object} [defines] Defines in the style.
+ * @param {*} [defines] Defines in the style.
*
* @example
* var expression = new Cesium... | [No CFG could be retrieved] | PUBLIC CONSTRUCTORS This constructor creates a new expression object that evaluates a 3D county Construct a new expression object. | This is a map, leave as `Object`. |
@@ -994,11 +994,11 @@ function load_os(&$device)
// Set type to a predefined type for the OS if it's not already set
$loaded_os_type = Config::get("os.{$device['os']}.type");
- if ((! isset($device['attribs']['override_device_type']) && $device['attribs']['override_device_type'] != 1) && array_key_exists... | [generate_smokeping_file->[generateFileName],is_client_authorized->[inNetwork],set_dev_attrib->[setAttrib],snmpv3_capabilities->[getErrorOutput,run],get_dev_attribs->[getAttribs],device_by_id_cache->[getAttribs,toArray],get_dev_attrib->[getAttrib],c_echo->[convert],external_exec->[setTimeout,getErrorOutput,getOutput,ru... | Load the OS definition and set the device properties if it s not already set. | what about this `!= 1` check? |
@@ -170,7 +170,7 @@ public class NumberedShardedFileTest {
tmpFolder.newFile("tmp-result-000-of-001");
NumberedShardedFile shardedFile =
- new NumberedShardedFile(IOChannelUtils.resolve(tmpFolder.getRoot().getPath(), "*"));
+ new NumberedShardedFile(filePattern);
thrown.expect(IOExcepti... | [NumberedShardedFileTest->[testReadWithRetriesFailsWhenTemplateIncorrect->[newFile,readFilesWithRetries,resolve,expect,write,NumberedShardedFile,expectMessage,compile,containsString,getPath],testPreconditionFilePathIsNull->[expectMessage,containsString,expect,NumberedShardedFile],testReadEmpty->[newFile,readFilesWithRe... | This test attempts to read files that are missing. | where you can, merge these int previous line. |
@@ -153,7 +153,7 @@ public class SingleStringInputDimensionSelector implements DimensionSelector
@Override
public Object getObject()
{
- return defaultGetObject();
+ return lookupName(getRow().get(0));
}
@Override
| [SingleStringInputDimensionSelector->[getValueCardinality->[getValueCardinality],lookupName->[lookupName],getRow->[getRow]]] | Gets the object of a . | I'm not sure this will work for empty rows in multi-value dimensions. |
@@ -253,6 +253,7 @@ type OffchainReporting2OracleSpec struct {
JuelsPerFeeCoinPipeline string `toml:"juelsPerFeeCoinSource"`
CreatedAt time.Time `toml:"-"`
UpdatedAt time.Time `toml:"-"`
+ DatabaseTimeout ... | [SetID->[ParseInt,ToInt64],GetID->[Sprintf],RightPadBytes,BytesToHash,String,Replace,Bytes] | GetID returns the ID of the OOM spec. | for this db column you can just update the existing ocr2 migration directly (nothing live yet) |
@@ -80,7 +80,7 @@ def get_thumbnail_size(size, method):
@register.simple_tag()
-def get_thumbnail(instance, size, method='crop'):
+def get_thumbnail(instance, size, method='thumbnail'):
if instance:
used_size = get_thumbnail_size(size, method)
try:
| [get_thumbnail->[choose_placeholder,get_thumbnail_size],get_thumbnail_size->[get_available_sizes_by_method],get_available_sizes] | Get a thumbnail from an instance. | Could we either drop the method param entirely or make it explicitly required? |
@@ -556,6 +556,7 @@ class ProductCreateInput(ProductInput):
),
required=False,
)
+ base_price = Decimal(description="Default price for product variant.",)
T_INPUT_MAP = List[Tuple[models.Attribute, List[str]]]
| [CollectionCreate->[save->[save],Arguments->[CollectionCreateInput]],ProductImageDelete->[perform_mutation->[ProductImageDelete]],ProductImageReorder->[perform_mutation->[save,ProductImageReorder]],ProductImageCreate->[Arguments->[ProductImageCreateInput],perform_mutation->[ProductImageCreate]],VariantImageAssign->[per... | Creates a new object from the given base object. Retrieve attributes nodes from given global IDs and or slugs. | What about the `productUpdate` mutation? It uses `ProductInput` and for now we want to use it to update prices of simple products (with the one default variant). |
@@ -11,8 +11,9 @@ namespace MonoGame.Tools.Pipeline
{
Panel panel;
TextArea textArea;
- Scrollable scrollable1;
+ Scrollable scrollable;
Drawable drawable;
+ Eto.Drawing.Point scrollPosition;
private void InitializeComponent()
{
| [BuildOutput->[InitializeComponent->[SizeChanged,ExpandContentHeight,Scroll,MouseLeave,Content,CreateContent,ReadOnly,MouseDown,Paint,MouseMove,BackColor,Wrap,ExpandContentWidth,BackgroundColor]]] | Initialize the components. | Non GUI member declarations should be placed in `BuildOutput.cs`. |
@@ -27,8 +27,17 @@ func assignKubernetesParameters(properties *api.Properties, parametersMap params
k8sVersion := orchestratorProfile.OrchestratorVersion
k8sComponents := api.K8sComponentsByVersionMap[k8sVersion]
kubernetesConfig := orchestratorProfile.KubernetesConfig
+ hyperKubeImageBase := kubernetesConfig... | [IsAADPodIdentityEnabled,Now,GetAzureCNIURLLinux,GetAzureCNIURLWindows,GetAddonContainersIndexByName,IsClusterAutoscalerEnabled,GetAddonByName,Itoa,FormatBool,Int,IsACIConnectorEnabled,IsKubernetesVersionGe,New,FormatFloat,Bool,HasNSeriesSKU,UnixNano,PrivateJumpboxProvision,ToLower,HasWindows,K8sOrchestratorName,IsKube... | assignKubernetesParameters assigns parameters to the given parametersMap. missing - noindex - if - no - aad - pod - identity - addon. | As discussed, we can consider using the `kubernetesConfig.CustomHyperkubeImage` instead |
@@ -902,3 +902,17 @@ func (h *Handler) SetStoreLimitTTL(data string, value float64, ttl time.Duration
data: value,
}, ttl)
}
+
+func checkStoreState(rc *cluster.RaftCluster, storeID uint64) error {
+ store := rc.GetStore(storeID)
+ if store == nil {
+ return errs.ErrStoreNotFound.FastGenByArgs(storeID)
+ }
+ if ... | [AddLabelScheduler->[AddScheduler],AddRandomMergeScheduler->[AddScheduler],GetHistory->[GetOperatorController,GetHistory],GetOperatorsOfKind->[GetOperators],GetSchedulerConfigHandler->[GetRaftCluster],GetHotReadRegions->[GetRaftCluster,GetHotReadRegions],AddAddPeerOperator->[GetOperatorController,checkAdminAddPeerOpera... | SetStoreLimitTTL sets the limit TTL for the given data. | Maybe we can add one more argument in `ErrStoreUnhealthy` to distinguish these different situations. |
@@ -86,10 +86,11 @@ function getAdContainer(global) {
/**
* @param {!Window} global
* @param {!Object} data
+ * @return {?Node}
*/
function getInitAdScript(global, data) {
const scriptElement = global.document.createElement('script');
- const initData = getInitData(data);
+ const initData = /** @type {Json... | [No CFG could be retrieved] | Get the init script element for the ad. | instead of casting the output of `getInitData`, specify its return type |
@@ -63,6 +63,13 @@ class Jetpack_VideoPress_Shortcode {
if ( ( $attr['width'] % 2 ) === 1 )
$attr['width']--;
+ /**
+ * Filter the default VideoPress shortcode options.
+ *
+ * @since 2.5.0
+ *
+ * @param array $args Array of VideoPress shortcode options.
+ */
$options = apply_filters( 'videopr... | [Jetpack_VideoPress_Shortcode->[shortcode_callback->[is_valid_guid,asHTML,asXML]]] | Shortcode callback function This method is used to display a videoPress_Player object in a web page. | Same here, without being aware of new VP shortcodes operate any differently. |
@@ -1741,6 +1741,12 @@ ROM_START( sun4_20 )
ROM_LOAD( "520-2748-04.rom", 0x0000, 0x20000, CRC(e85b3fd8) SHA1(4cbc088f589375e2d5983f481f7d4261a408702e))
ROM_END
+// SPARCstation ELC (Sun 4/25)
+ROM_START(sun4_25)
+ROM_REGION32_BE(0x80000, "user1", ROMREGION_ERASEFF)
+ROM_LOAD("520-3085-03.rom", 0x0000, 0x40000, CRC... | [No CFG could be retrieved] | region 16 - bit Baudrate region 0x80000 - 0x80000 - 0x80000 - 0x. | Can you please indent these two lines? We treat ROM definitions as a scope block. |
@@ -74,6 +74,8 @@ type Message interface {
Nonce() uint64
CheckNonce() bool
Data() []byte
+
+ TxType() types.TransactionType
}
// IntrinsicGas computes the 'intrinsic gas' for a message with the given data.
| [TransitionDb->[to,preCheck,useGas],preCheck->[buyGas]] | Protected state transition NewStateTransition creates a new StateTransition object from a given EVM message and a given. | so we are actually not adding new field into transaction struct itself? |
@@ -100,13 +100,12 @@ function getHostOS($device)
// check yaml files
$pattern = $config['install_dir'] . '/includes/definitions/*.yaml';
foreach (glob($pattern) as $file) {
+ $tmp = Symfony\Component\Yaml\Yaml::parse(
+ file_get_contents($file)
+ );
$os = basename($file... | [send_mail->[send,isSMTP,addAddress,isHTML,setFrom],addHost->[addReason]] | Get the host OS. | Parsing the yaml is slow, so this is why the check was added in the first place. My thoughts was check `$config['os'][$os]['os']` which is unlikely to be set by the user in config.php and is required in the yaml, that does seem a little hacky though. |
@@ -1474,9 +1474,8 @@ cont_set_prop_hdlr(struct cmd_args_s *ap)
rc = daos_cont_set_prop(ap->cont, ap->props, NULL);
if (rc) {
- fprintf(ap->errstream, "failed to set properties for container "
- DF_UUIDF": %s (%d)\n", DP_UUID(ap->c_uuid),
- d_errdesc(rc), rc);
+ fprintf(ap->errstream, "failed to set propert... | [No CFG could be retrieved] | - GET - PROPER - GET - PROPER - GET - PROPER - GET - Get the first empty property entry in the list of cmd_args_s. | (style) line over 100 characters |
@@ -456,6 +456,8 @@ class Task(CeleryTask, ReservedTaskMixin):
else:
_logger.info(_('Task failed : [%s]') % task_id)
# celery will log the traceback
+ if 'scheduled_call_id' in kwargs:
+ utils.increment_failure_count(kwargs['scheduled_call_id'])
if not self.... | [cleanup_old_worker->[create_worker_working_directory,_delete_worker],_delete_worker->[error,_,delete_worker_working_directory,objects,cancel],_queue_reserved_task->[ReservedResource,sleep,apply_async,get_worker_for_reservation,tasks,_get_unreserved_worker],register_sigterm_handler->[wrap_f->[signal,f],sigterm_handler-... | Updates the state finish_time and traceback of the relevant task status . | This seems right, but to recap the expected behavior, any task (including the ones like `queue_publish`) that has `schedule_call_id` passed in as a kwarg and fails will increment the failure count. That seems right to me. |
@@ -700,6 +700,15 @@ func claimPaymentWithDetail(ctx context.Context, g *libkb.GlobalContext, remoter
})
}
+func randMemoID() (uint64, error) {
+ buf := make([]byte, 8)
+ _, err := rand.Read(buf)
+ if err != nil {
+ return 0, err
+ }
+ return binary.LittleEndian.Uint64(buf), nil
+}
+
func isAccountFunded(ctx con... | [StatusCode,Override,GetMeUV,IsNativeXLM,NewPaymentID,RunEngine2,LocalSigchainGuard,StartStandaloneChat,WithUID,Post,New,SendMsgByName,AccountID,PaymentXLMTransaction,Details,LossyAbbreviation,NewMetaContext,RuneCountInString,Advance,RelocateTransaction,RecipientInput,Relay,informAcceptedDisclaimer,Split,WithPublicKeyO... | Check if the user has claimed a secret key. If it s the user s account GetOwnPrimaryAccountID returns the account ID of the primary account in the active bundle. | you could use libkb.RandBytes(8)...this package already imports libkb. |
@@ -75,6 +75,18 @@ class DropConnect(torch.nn.Module):
if re.search(regex, parameter_name):
yield _Match(submodule_name, submodule, parameter_name, parameter)
+ def _prepare_matched_parameters(self, match: _Match):
+ """
+ Apply non-training dropout to all of mat... | [DropConnect->[_search_parameters->[_Match],reset->[_search_parameters,reset]]] | Searches for all parameters whose names match the provided regular expression. | Why apply dropout with training=False instead of just assigning the parameter? |
@@ -48,9 +48,8 @@
// If we're redirected to login, our
// previousState is already set in the authExpiredInterceptor. When login succesful go to stored state
- if ($rootScope.redirected && $rootScope.previousStateName) {
- $state.go($rootScope.previo... | [No CFG could be retrieved] | Login to the user and go to the previous state if login is successful. | I forgot why I added this but it was done for some reason. Are you sure everything works fine without this? |
@@ -788,7 +788,7 @@ public class MapPanel extends ImageScrollerLargeView {
final int xSpace = 5;
final BufferedImage img = Util.createImage(categories.size() * (xSpace + icon_width),
uiContext.getUnitImageFactory().getUnitImageHeight(), true);
- final Graphics2D g = (Graphics2D) img.getGraphics();... | [BackgroundDrawer->[run->[getData,getUndrawnTiles]],RouteDescription->[hashCode->[hashCode],equals->[equals]],MapPanel->[setTopLeft->[setTopLeft],getInfoImage->[getInfoImage],print->[print],getHelpImage->[getHelpImage],setScale->[recreateTiles,setScale,getData],setTerritoryOverlayForBorder->[setTerritoryOverlayForBorde... | Set the mouse shadow units. private int i = 0 ;. | getGraphics ist just kept for backwards compatibility... createGraphics ist recommendet wince it creates a Graphics2D object |
@@ -0,0 +1,7 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Xunit;
+
+[assembly: ActiveIssue("https://github.com/dotnet/runtime/issues/34748", TestPl... | [No CFG could be retrieved] | No Summary Found. | This issue is about COM tests failing on Mono. Copy & paste mistake? |
@@ -379,6 +379,17 @@ export class DraggableDrawer extends AMP.BaseElement {
? this.open()
: this.close_();
}
+
+ return;
+ }
+
+ if (
+ this.openThreshold_ !== null &&
+ this.state_ === DrawerState.DRAGGING_TO_OPEN &&
+ swipingUp &&
+ -deltaY > this.openThresh... | [No CFG could be retrieved] | Determines if the given element is a descendant of the drawer content. Drag a drawer on the screen upon user interaction. | Are these conditions specifically for the remote URL case? if so, should we move them to a separate method so it's easier to know? |
@@ -13,9 +13,10 @@ from pants.backend.jvm.targets.java_library import JavaLibrary
from pants.backend.project_info.tasks.filedeps import FileDeps
from pants.build_graph.register import build_file_aliases as register_core
from pants_test.task_test_base import ConsoleTaskTestBase
+from pants_test.test_base import TestG... | [FileDepsTest->[assert_console_output->[super,join],test_scala_java_cycle_java_end->[assert_console_output,target],test_jvm_app->[assert_console_output,target],test_globs_app->[dict,assert_console_output,target],test_scala_java_cycle_scala_end->[assert_console_output,target],test_concrete_only->[assert_console_output,t... | Register all the groups in the system. | Let's not rename this class any more, because it's now an actual test class rather than a base class. |
@@ -92,6 +92,7 @@ namespace Internal.TypeSystem
throw new NotSupportedException();
}
+ internal partial void InternalGetSupportsUniversalCanon(ref bool flag) => flag = SupportsUniversalCanon;
public abstract bool SupportsCanon { get; }
public abstract bool SupportsUniver... | [TypeSystemContext->[IsCanonicalDefinitionType->[Universal,Any,Specific,Assert],MetadataType->[FullName],Instantiation->[ConvertInstantiationToCanonForm],CompareExchange]] | This method is called to convert a type descriptor to a canon type. | Why do we need this ugly hack? |
@@ -336,6 +336,8 @@ int run_test(int argc, ACE_TCHAR *argv[])
try
{
+ DDS::DomainParticipantFactory_var dpf =
+ TheParticipantFactoryWithArgs(argc, argv);
TestParticipantImpl* tpi = new TestParticipantImpl();
DDS_TEST* test = new DDS_TEST();
::DDS::DataWriterQos dw_qos;
| [No CFG could be retrieved] | Parse command line arguments and run a test if the command is successful. LIMITED - MAX_SAMPLES. | Is this needed? Not necessarily wrong but this is more of a component-level test that doesn't need the core DDS running. |
@@ -198,7 +198,15 @@ func (m *ppsMaster) attemptStep(ctx context.Context, e *pipelineEvent) error {
})
// we've given up on the step, check if the error indicated that the pipeline should fail
if err != nil && errors.As(err, &stepErr) && stepErr.failPipeline {
- failError := m.a.setPipelineFailure(ctx, e.pipelin... | [deletePipelineResources->[AddSpanToAnyExisting,cancelMonitor,Wrapf,Infof,Sprintf,CoreV1,FinishAnySpan,Secrets,IsNotFoundError,List,Delete,ReplicationControllers,Services,GetKubeClient,TagAnySpan,cancelCrashingMonitor],setPipelineState->[AddSpanToAnyExisting,FinishAnySpan,GetDBClient,SetPipelineState,TagAnySpan],transi... | attemptStep attempts to update the resource in the pipeline. | It seems like it would be better to have a transactional and non-transactional version of this so each call site that doesn't need the transaction won't have to set one up. |
@@ -68,9 +68,7 @@ public abstract class AbstractRulesAttachment extends AbstractConditionsAttachme
}
protected List<PlayerId> getPlayers() {
- return players.isEmpty()
- ? new ArrayList<>(Collections.singletonList((PlayerId) getAttachedTo()))
- : players;
+ return players.isEmpty() ? new Arr... | [AbstractRulesAttachment->[getTerritoriesBasedOnStringName->[setTerritoryCount],setTurns->[setRounds],getTerritoryListBasedOnInputFromXml->[getTerritoriesBasedOnStringName,setTerritoryCount],getListedTerritories->[setTerritoryCount]]] | Get the list of players attached to this node. | Would be good to check if the outer ArrayList<>() is needed. |
@@ -332,4 +332,7 @@ public interface Log extends BasicLogger {
@Message(value = "OAUTHBEARER mechanism selected without providing a token", id = 4093)
CacheConfigurationException oauthBearerWithoutToken();
+
+ @Message(value = "Cannot specify both template name and configuration for '%s'", id = 4094)
+ Ca... | [getMessageLogger] | OAUTHBEARER mechanism selected without providing a token. | what is Xor configuration ? |
@@ -286,6 +286,11 @@ func (c *generalConfig) SetDB(db *gorm.DB) {
c.ORM = orm
}
+// SetKeyStore provides reference to the keystore for runtime configuration values
+func (c *generalConfig) SetKeyStore(ks keystore.Master) {
+ c.ks = ks
+}
+
func (c *generalConfig) SetDialect(d dialects.DialectName) {
c.dialect =... | [P2PV2AnnounceAddresses->[P2PV2ListenAddresses],SessionSecret->[RootDir],OCRContractSubscribeInterval->[getDuration],OCRContractPollInterval->[getDuration],TLSDir->[RootDir],Chain->[ChainID],KeyFile->[TLSKeyPath,TLSDir],CreateProductionLogger->[LogLevel,RootDir,CreateProductionLogger,LogToDisk,JSONConsole],SessionOptio... | SetDB sets the database to use for the configuration. | Seems like something that should be passed in the constructor of *generalConfig right (same goes for SetDB actually)? I don't think we want to be able to overwrite this dynamically ? |
@@ -115,7 +115,7 @@ describe('cid', () => {
crypto = results[1];
crypto.sha384Base64 = val => {
if (val instanceof Uint8Array) {
- val = '[' + val + ']';
+ val = '[' + Array.apply([], val).join(',') + ']';
}
return Promise.resolve(... | [No CFG could be retrieved] | The base context for the object. Checks that AMP - CID and time are unique. | wondering why `Array.apply` is necessary here. |
@@ -158,7 +158,7 @@ void AddProcessesToPython(pybind11::module& m)
;
py::class_<FindNodalNeighboursProcess, FindNodalNeighboursProcess::Pointer, Process>(m,"FindNodalNeighboursProcess")
- .def(py::init<ModelPart&, unsigned int, unsigned int>())
+ .def(py::init<ModelPart& >())
.de... | [No CFG could be retrieved] | Create a class - level constructor for FindNodalElementalNeighboursProcess. Initialize the missing neighbouring processes. | since this process is becoming deprecated, I suggest to leave the old constructor an issue a deprecation-warning saying that this process should be replaced by either of the specific ones |
@@ -304,14 +304,14 @@ public final class ReferenceMatcher {
}
// optimization to avoid ArrayList allocation in the common case when there are no mismatches
- private static List<Mismatch> lazyAdd(List<Mismatch> mismatches, Mismatch mismatch) {
+ static List<Mismatch> lazyAdd(List<Mismatch> mismatches, Mismatc... | [ReferenceMatcher->[findField->[findField],checkThirdPartyTypeMatch->[matches],collectFieldsFromTypeHierarchy->[collectFieldsFromTypeHierarchy],collectMethodsFromTypeHierarchy->[collectMethodsFromTypeHierarchy],findMethod->[findMethod]]] | lazyAddAll - Add all mismatches to the end of the list. | `add` for these methods that are not private any more is better name since lazy is an implementation detail. |
@@ -648,7 +648,7 @@ class AllauthPersonaTestCase(TestCase):
socialaccount = None
try:
socialaccount = (SocialAccount.objects
- .order_by('-date_joined')[0])
+ .filter(user__username=perso... | [ProfileViewsTest->[test_profile_edit_beta->[_get_current_form_field_values],test_profile_edit_websites->[_get_current_form_field_values],test_bug_709938_interests->[_get_current_form_field_values],test_profile_edit_interests->[_get_current_form_field_values]]] | Test persona signing up with Persona creates a new SocialAccount instance. | Make the test a little less fragile. |
@@ -143,7 +143,9 @@ export class AmpStoryPageAttachment extends DraggableDrawer {
closeButtonEl.setAttribute('aria-label', localizedCloseString);
}
- if (this.element.hasAttribute('data-title')) {
+ if (this.element.hasAttribute('title')) {
+ titleEl.textContent = this.element.getAttribute('tit... | [No CFG could be retrieved] | Builds inline page attachment drawer UI. Adds a class name to the CTA drawer UI. | Nit: can we factorize? e.g. `const title = this.element.getAttribute('title') || getAttribute('data-title')` |
@@ -62,10 +62,12 @@ public class KsqlAuthorizationValidatorImpl implements KsqlAuthorizationValidato
final MetaStore metaStore,
final Query query
) {
- final SourceTopicsExtractor extractor = new SourceTopicsExtractor(metaStore);
- extractor.process(query, null);
- for (String kafkaTopic : ext... | [KsqlAuthorizationValidatorImpl->[validateCreateAsSelect->[validateQuery],validateInsertInto->[validateQuery],getCreateAsSelectSinkTopic->[getSourceTopicName]]] | Checks if the query is valid for a given node. | Shouldn't we also check for read access on the schema in this case? |
@@ -25,7 +25,10 @@ namespace System.Text.Json.Serialization
/// <summary>
/// The "NaN", "Infinity", and "-Infinity" <see cref="JsonTokenType.String"/> tokens can be read as
/// floating-point constants, and the <see cref="float"/> and <see cref="double"/> values for these
- /// consta... | [No CFG could be retrieved] | - NaN - Infinity - Infinity - float. | So, with such a setting, "\u0031" will get parsed as the integer number 1. Neat. |
@@ -219,8 +219,10 @@ EVP_PKEY *X509_PUBKEY_get0(X509_PUBKEY *key)
EVP_PKEY *X509_PUBKEY_get(X509_PUBKEY *key)
{
EVP_PKEY *ret = X509_PUBKEY_get0(key);
- if (ret != NULL)
- EVP_PKEY_up_ref(ret);
+ if (ret != NULL && !EVP_PKEY_up_ref(ret)) {
+ X509err(X509_F_X509_PUBKEY_GET0, ERR_R_INTERNAL_ERR... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - 1 = pktmp - 1 = xpk - 1 = pkey - 1 =. | Please add a blank line after this declaration |
@@ -57,7 +57,7 @@ public class KsqlFunction {
final List<Schema> arguments,
final String functionName,
final Class<? extends Kudf> kudfClass,
- final Supplier<Kudf> udfSupplier,
+ final Function<KsqlConfig, Kudf> udfSupplier,
fi... | [KsqlFunction->[newInstance->[get],toString->[toList,collect],hashCode->[hash],equals->[getClass,equals],IllegalArgumentException,newInstance,anyMatch,requireNonNull,KsqlException]] | PUBLIC CONSTRUCTORS This constructor creates an instance of KsqlFunction from the given arguments and Get the list of schemas for a single . | Rename to `udfFunction`? |
@@ -787,7 +787,17 @@ function _elgg_admin_maintenance_action_check($hook, $type) {
}
if ($type == 'login') {
- $user = get_user_by_username(get_input('username'));
+ $username = get_input('username');
+
+ $user = get_user_by_username($username);
+
+ if (!$user) {
+ $users = get_user_by_email($username);... | [_elgg_admin_markdown_page_handler->[getAvailableTextFiles,getName],_elgg_add_admin_widgets->[getGUID,move],_elgg_robots_page_handler->[getPrivateSetting],elgg_delete_admin_notice->[delete],_elgg_admin_sort_page_menu->[setChildren,getName,getChildren],_elgg_admin_maintenance_handler->[getPrivateSetting],_elgg_admin_plu... | Checks if the user is allowed to perform maintenance actions. | This is already implemented somewhere. Is it possible to just reuse that other code? What if we want to log in with oauth or something? |
@@ -169,7 +169,8 @@ namespace System.Net.WebSockets.Client.Tests
{
var cts = new CancellationTokenSource(TimeOutMilliseconds);
- var closeStatus = WebSocketCloseStatus.InvalidPayloadData;
+ // See issue for Browser websocket differences https://github.com/do... | [CloseTest->[Task->[Message,Count,NormalClosure,Netcoreapp,SendAsync,False,Close,ConnectAsync,IsCompleted,CloseOutputAsync,CloseStatus,GetTextFromBuffer,CloseAsync,CloseStatusDescription,Closed,Token,GetBufferFromText,Delay,Empty,SetResult,Null,Mono,Assert,WebSocketHandshakeAsync,Windows,State,InvalidMessageType,Create... | Checks if the client is connected and able to receive a message echoed by the server. | could we just use 500 for all platforms? This is already OuterLoop test so it may not matter much. |
@@ -492,6 +492,12 @@ class Reshape(Layer):
target_shape: Target shape. Tuple of integers, does not include the
samples dimension (batch size).
**kwargs: Any additional layer keyword arguments.
+
+ Returns:
+ A layer to Reshape the input.
+
+ Raises:
+ ValueError: If input_... | [Reshape->[call->[dropped_inputs->[],compute_output_shape],compute_output_shape->[_fix_unknown_dimension]],Dropout->[call->[dropped_inputs->[_get_noise_shape]]],_delegate_property->[InstanceProperty],_delegate_method->[delegate->[InstanceMethod]],SlicingOpLambda->[__init__->[_call_wrapper->[_dict_to_slice]]],TFOpLambda... | Creates a Reshape layer instance. | This doesn't seem right. Same shape means there is no need to reshape. |
@@ -1100,12 +1100,9 @@ namespace Microsoft.Xna.Framework
/// <param name="result">Transformed normal as an output parameter.</param>
public static void TransformNormal(ref Vector3 normal, ref Matrix matrix, out Vector3 result)
{
- var x = (normal.X * matrix.M11) + (normal.Y * matri... | [Vector3->[Max->[Max],Length->[DistanceSquared],CatmullRom->[CatmullRom],SmoothStep->[SmoothStep],Transform->[Length],Hermite->[Hermite],Lerp->[Lerp],Barycentric->[Barycentric],Clamp->[Clamp],TransformNormal->[Length],Normalize->[Distance,Normalize],Min->[Min],ToString->[ToString],LengthSquared->[DistanceSquared]]] | TransformNormal - Transform normal by matrix. | Local variables have a purpose again. |
@@ -1587,10 +1587,18 @@ zfs_domount(struct super_block *sb, zfs_mnt_t *zm, int silent)
uint64_t recordsize;
int error = 0;
zfsvfs_t *zfsvfs;
+ cred_t *cred;
ASSERT(zm);
ASSERT(osname);
+ cred = CRED();
+ error = secpolicy_zfs(cred);
+ if (error == EACCES)
+ error = dsl_deleg_access(osname, "mount", cred)... | [No CFG could be retrieved] | Initialize a zfsvfs object. Set up the file system. | nit: can you assign `cred = CRED()` in the declaration. |
@@ -12,8 +12,8 @@ from pants.base.exceptions import TaskError
from pants_test.backend.python.tasks.python_task_test_base import PythonTaskTestBase
from pants.contrib.python.checks.tasks.checkstyle.checker import PythonCheckStyleTask
-from pants.contrib.python.checks.tasks.checkstyle.print_statements_subsystem impor... | [PythonCheckStyleTaskTest->[test_syntax_error->[context,dedent,assertEqual,create_file,make_target,set_options,create_task,execute],test_multiline_nit_printed_only_once->[list,context,get_nits,dedent,assertEqual,len,str,create_file,make_target,create_task],test_no_sources->[context,create_task,assertEqual,execute],test... | Return the task type. | The Print Statements tests don't work as expected on Py3. Because they raise a syntax error with Python 3, the tests weren't working as intended. So, I changed to using Variable Names. The specific error doesn't matter much - this file tests the `checker` mechanics, and there are other files to check each specific subs... |
@@ -140,6 +140,13 @@ public class CasCoreServicesConfiguration {
return new NoOpRegisteredServiceReplicationStrategy();
}
+ @ConditionalOnMissingBean(name = "registeredServiceresourceNamingStrategy")
+ @Bean
+ @RefreshScope
+ public RegisteredServiceResourceNamingStrategy resourceNamingStrat... | [CasCoreServicesConfiguration->[webApplicationServiceResponseBuilder->[WebApplicationServiceResponseBuilder],registeredServiceReplicationStrategy->[NoOpRegisteredServiceReplicationStrategy],registeredServiceAccessStrategyEnforcer->[RegisteredServiceAccessStrategyAuditableEnforcer],defaultMultifactorTriggerSelectionStra... | This method is used to create a service registry. | `registeredServiceResourceNamingStrategy`, and the actual method name should change too. |
@@ -8,6 +8,7 @@
*/
#include <openssl/rand.h>
+#include "e_os.h"
#include "../ssl_locl.h"
#include "statem_locl.h"
| [No CFG could be retrieved] | Integrity check for the given type. Sub state of the sub - system. | This one also seems to be dependency on (not-really-os-specific) OPENSSL_CONF... |
@@ -440,8 +440,9 @@ ds_mgmt_destroy_pool(uuid_t pool_uuid, const char *group, uint32_t force)
}
int
-ds_mgmt_pool_reintegrate(uuid_t pool_uuid, uint32_t reint_rank,
- struct pool_target_id_list *reint_list)
+ds_mgmt_pool_target_update(uuid_t pool_uuid, uint32_t rank,
+ struct pool_target_id_list *target_list,
+ ... | [mock_ds_mgmt_pool_overwrite_acl_teardown->[daos_acl_free,daos_prop_free],ds_mgmt_pool_delete_acl->[uuid_copy,daos_prop_dup],ds_mgmt_pool_update_acl->[uuid_copy,daos_acl_dup,daos_prop_dup],ds_mgmt_pool_list_cont->[D_ALLOC_ARRAY,memcpy],mock_ds_mgmt_list_pools_gen_pools->[D_ALLOC_ARRAY,uuid_generate,d_rank_list_alloc],m... | int ds_mgmt_pool_reintegrate - if the node in the list. | (style) trailing whitespace |
@@ -150,9 +150,10 @@ module View
size: @current_entity.cash.to_s.size,
})
+ bid_str = @step.respond_to?(:bid_str) ? @step.bid_str(company) : 'Place Bid'
buttons = []
if @step.min_bid(company) <= @step.max_place_bid(@current_entity, company)
- ... | [Auction->[create_minor_bid->[hide!],choose_minor->[hide!],buy->[hide!],create_bid->[hide!],move_bid->[hide!],choose->[hide!],create_turn_bid->[hide!]]] | Renders the company actions. | shouldn't this be inside the if statement? |
@@ -32,6 +32,8 @@ public abstract class AuthenticationDetails {
return Builder.create();
}
+ public abstract AuthenticationDetails.Builder toBuilder();
+
@AutoValue.Builder
public abstract static class Builder {
| [AuthenticationDetails->[Builder->[create->[sessionAttributes]]]] | Creates a builder for the authentication details. | It's nice to have this, but we don't have code calling this. If we decide to keep the PR for the UI changes, we should leave this change in. |
@@ -130,6 +130,12 @@ def map_type_from_supertype(typ: Type,
return expand_type_by_instance(typ, inst_type)
+def instance_or_var(typ: ProperType) -> bool:
+ # TODO: use more principled check for non-trivial self-types.
+ return (isinstance(typ, TypeVarType) or
+ isinstance(typ, Instance) and ty... | [true_only->[true_only,make_simplified_union],bind_self->[expand,bind_self],map_type_from_supertype->[tuple_fallback],false_only->[make_simplified_union,false_only],erase_to_union_or_bound->[make_simplified_union],erase_def_to_union_or_bound->[make_simplified_union],true_or_false->[make_simplified_union,true_or_false]] | Return a copy of method with the type of self bound to original_type. Returns a copy of the function with the catalyical type information expanded to the type. | Maybe we should handle `typ` being a TypeType in here as well. That would let us clean up the if statement down below a little more. |
@@ -95,4 +95,11 @@ public class GuavaUtils
}
};
}
+
+ public static Long tryParseLong(String string)
+ {
+ return Strings.isNullOrEmpty(string)
+ ? null
+ : Longs.tryParse(string.charAt(0) == '+' ? string.substring(1) : string);
+ }
}
| [GuavaUtils->[joinFiles->[getInput->[getInput],joinFiles]]] | Returns a Supplier that reads from the input stream until either EOF is reached or the input stream. | Is this intended `@Nullable` on the input argument? There are checks for things that call this for `nullToEmpty`, which are probably not needed. |
@@ -70,6 +70,11 @@ export function useSlotContext(ref) {
Slot,
/** @type {!./core/loading-instructions.Loading} */ (context.loading)
);
+
+ if (!context.playable) {
+ execute(slot, pauseAll);
+ }
+
return () => {
removeProp(slot, CanRender, Slot);
removeProp(slot, CanPla... | [No CFG could be retrieved] | Set slot properties. | Mount and unmount? |
@@ -490,7 +490,7 @@ pool_buf_parse(struct pool_buf *buf, struct pool_domain **tree_pp)
/* Initialize the root */
parent = &tree[0]; /* root */
parent->do_comp.co_type = PO_COMP_TP_ROOT;
- parent->do_comp.co_status = PO_COMP_ST_UP;
+ parent->do_comp.co_status = PO_COMP_ST_UPIN;
if (buf->pb_domain_nr == 0) {
... | [No CFG could be retrieved] | - GET ROOT - GET DEPTH - GET DEPTH - GET DEPTH - GET DE Setup the children of a node. | It's not from this patch, but I'm wondering why don't we just use the state returned from server directly instead of setting one arbitrarily? |
@@ -1,12 +1,12 @@
##############################################################################
-# Copyright (c) 2013-2018, Lawrence Livermore National Security, LLC.
+# Copyright (c) 2013-2017, Lawrence Livermore National Security, LLC.
# Produced at the Lawrence Livermore National Laboratory.
#
# This file is pa... | [Sz->[variant,version]] | ############################## ********************************************************** ********************************************************** This function is a wrapper around the Configure command line options for the sequence number generation. | Can you undo the changes to the license? `github.com/llnl/spack` is out of date. |
@@ -395,9 +395,13 @@ class RaidenService(Runnable):
#
# We need a timeout to prevent an endless loop from trying to
# contact the disconnected client
+ if self.api_server is not None:
+ self.api_server.stop()
self.transport.stop()
self.alarm.stop()
+ ... | [RaidenService->[handle_and_track_state_changes->[add_pending_greenlet],_poll_until_target->[_log_sync_progress,handle_and_track_state_changes],start_mediated_transfer_with_secret->[PaymentStatus,handle_and_track_state_changes,async_start_health_check_for,matches,initiator_init],stop->[stop],_start_alarm_task->[start],... | Stop the node gracefully. Raise if any error occurs on any subtask. | What about possible exceptions from the greenlet? Shouldn't we use `get` instead of `join`? |
@@ -173,8 +173,8 @@ class ExportedTargetRequirements(DeduplicatedCollection[str]):
@dataclass(frozen=True)
-class SetupPySources:
- """The sources required by a setup.py command.
+class DistBuildSources:
+ """The sources required to build a distribution.
Includes some information derived from analyzin... | [declares_pkg_resources_namespace_package->[is_call_to->[is_name],has_args,is_call_to],get_sources->[DependencyOwner,SetupPySources],get_owned_dependencies->[OwnedDependency,OwnedDependencies],generate_chroot->[GenerateSetupPyRequest,DistBuildChroot],get_requirements->[OwnedDependency,ExportedTargetRequirements,first_p... | Creates a new object that represents a target in a CVV. Initialize a new with the required fields. | I may move these renamed classes and the corresponding rules to `util_rules/dists.py` in a followup. |
@@ -23,7 +23,8 @@ def stochastic_depth(input: Tensor, p: float, mode: str, training: bool = True)
Returns:
Tensor[N, ...]: The randomly zeroed tensor.
"""
- _log_api_usage_once("ops", "stochastic_depth")
+ if not torch.jit.is_scripting() and not torch.jit.is_tracing():
+ _log_api_usage_o... | [StochasticDepth->[forward->[stochastic_depth],__repr__->[str],__init__->[super]],stochastic_depth->[div_,_log_api_usage_once,empty,ValueError,bernoulli_],wrap] | Stochastic Depth implementation. | Same, missing from the class. |
@@ -13,7 +13,7 @@ module TwoFactorAuthentication
@recovery_code_form = RecoveryCodeForm.new(current_user, personal_key)
result = @recovery_code_form.submit
- analytics.track_event(Analytics::MULTI_FACTOR_AUTH, result.merge(method: 'recovery code'))
+ analytics.track_event(Analytics::MULTI_FACT... | [RecoveryCodeVerificationController->[password_reset_profile->[password_reset_profile]]] | Creates a new user - specified recovery code. | this isn't necessary for now, but in the future it might be helpful to make these named args |
@@ -396,7 +396,7 @@ define([
* The Data property of the input interval is ignored.
*
* @param {TimeInterval} interval The interval to remove.
- * @returns true if the interval was removed, false if no part of the interval was in the collection.
+ * @returns <code>true</code> if the interval wa... | [No CFG could be retrieved] | Remove an interval from the collection. Check if the interval is in the interval list. | Should be lowercase `data`. |
@@ -147,10 +147,10 @@ export default class Dialog {
this.submitted = false;
this.onCloseCallback = function() {};
- this.setDefoulOptions();
+ this.setDefaulOptions();
}
- setDefoulOptions() {
+ setDefaulOptions() {
var self = this;
this.options = {
| [No CFG could be retrieved] | Create a dialog object for a single . | Shouldn't it be setDefaultOptions not setDefaulOptions? |
@@ -434,6 +434,18 @@ namespace Dynamo.UpdateManager
}
}
+ public bool IsUpdateAvailable
+ {
+ get
+ {
+ //Update is not available unitl it's downloaded
+ if(DownloadedUpdateInfo==null)
+ return false;
+
+ ... | [UpdateManagerConfiguration->[Save->[OnLog]],DynamoLookUp->[BinaryVersion->[GetDynamoInstalls]],UpdateRequest->[ReadResult->[OnLog],UpdateDataAvailable],UpdateManager->[IsDailyBuild->[GetVersionString],OnDownloadFileCompleted->[OnLog],client_DownloadProgressChanged->[OnLog],UpdateManager_PropertyChanged->[OnLog],IsStab... | Protected base class for all of the properties of the object. region UpdateManager Implementation. | Are these properties set by the `CheckForProductUpdate` method? |
@@ -1630,7 +1630,7 @@ void Server::SendAddParticleSpawner(session_t peer_id, u16 protocol_version,
u16 amount, float spawntime, v3f minpos, v3f maxpos,
v3f minvel, v3f maxvel, v3f minacc, v3f maxacc, float minexptime, float maxexptime,
float minsize, float maxsize, bool collisiondetection, bool collision_removal,... | [No CFG could be retrieved] | Sends a SpawnParticle packet to a client. Add a network packet to a peer. | Just pass a reference to `ParticleSpawner` which reduces the count of arguments a lot. |
@@ -1,4 +1,4 @@
-namespace NServiceBus.DataBus
+namespace NServiceBus
{
using System;
using System.Collections.Concurrent;
| [DataBusReceiveBehavior->[Registration->[InvokeHandlers,InsertBefore,MutateIncomingMessages,InsertAfter],GetDataBusProperties->[GetType,ToList,TryGetValue],Invoke->[SetValue,Format,TryGetValue,next,GetDataBusProperties,Name,FullName,Suppress,GetValue,Deserialize,Get,Instance,Key]]] | Creates an object that can be used to receive logical messages. The list of properties that can be used to register the logical message. | Just curious why you killed the .DataBus namespace. If we stick everything in NServiceBus isn't it better to just remove the NS completely? (honest question since I'm getting on the no NS bandwagon) |
@@ -34,6 +34,9 @@ import java.nio.ByteBuffer;
import java.util.List;
import java.util.Random;
+/**
+ * TODO rewrite to use JMH and move to the benchmarks project
+ */
public class HyperLogLogCollectorBenchmark extends SimpleBenchmark
{
private final HashFunction fn = Hashing.murmur3_128();
| [ByteBuffers->[allocateAlignedByteBuffer->[getAddress]],HyperLogLogCollectorBenchmark->[timeFold->[allocateEmptyHLLBuffer],main->[main]]] | Creates a benchmark that uses the hyperloglog collector to collect the given number of times. Sets up the object. | Would you open a new issue for this? |
@@ -137,6 +137,11 @@ class MsalCredential(ABC):
return app
+ @property
+ def token_refresh_offset(self):
+ # type: (None) -> int
+ return DEFAULT_REFRESH_OFFSET
+
class ConfidentialClientCredential(MsalCredential):
"""Wraps an MSAL ConfidentialClientApplication with the TokenCre... | [PublicClientCredential->[_get_app->[_create_app]],ConfidentialClientCredential->[get_token->[_get_app],_get_app->[_create_app]],_build_auth_record->[_decode_client_info],InteractiveCredential->[get_token->[_build_auth_record],authenticate->[get_token],_acquire_token_silent->[_get_app]]] | Creates an MSAL application patching msal. authority to use an azure - core pipeline. | By default this is up to MSAL, which may or may not share our default behavior. MSAL does allow forcing a refresh during silent authentication, so I think these credentials could allow configuring the offset. Do you intend to add that in this PR? |
@@ -16,6 +16,6 @@ class BufferedArticlesController < ApplicationController
end
paths = relation.pluck(:path)
- paths.map { |path| "https://#{ApplicationConfig['APP_DOMAIN']}#{path}" }
+ paths.map { |path| "https://#{SiteConfig.app_domain}#{path}" }
end
end
| [BufferedArticlesController->[index->[to_json,render],buffered_articles_urls->[all,pluck,or,ago,where,production?,map]]] | Returns an array of URLs of buffered articles. | Since we're already changing code here, maybe this should be `URL.url(path)`? |
@@ -612,7 +612,9 @@ dc_cont_open(tse_task_t *task)
* opening the contianer
*/
in->coi_prop_bits = DAOS_CO_QUERY_PROP_CSUM |
- DAOS_CO_QUERY_PROP_CSUM_CHUNK;
+ DAOS_CO_QUERY_PROP_CSUM_CHUNK |
+ DAOS_CO_QUERY_PROP_DEDUP |
+ DAOS_CO_QUERY_PROP_DEDUP_THRESHOLD;
arg.coa_pool = pool;
arg.coa_... | [No CFG could be retrieved] | find the n - ary object in the pool This function is called to open the container object. | (style) 'DEDUP' may be misspelled - perhaps 'DEDUPE'? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.