patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -15,10 +15,15 @@ class OpenidConnectRedirector
@redirect_uri = redirect_uri
@service_provider = service_provider
@state = state
- @errors = errors
+ @errors = errors || ActiveModel::Errors.new(self)
@error_attr = error_attr
end
+ def valid?
+ validate
+ errors.blank?
+ end
+
... | [OpenidConnectRedirector->[validated_input_redirect_uri->[redirect_uri_matches_sp_redirect_uri?]]] | Initialize a new instance of the object. | CodeClimate is complaining here but I don't think there's a straightforward solution (especially since we need the reference to `self`...which we can't get until after the object is initialized....) so I think we should just add this to the `.reek` to ignore. Sorry! |
@@ -503,3 +503,18 @@ class RunTracker(Subsystem):
raise ValueError(
f"Couldn't find option scope {scope}{option_str} for recording ({e!r})"
)
+
+ def retrieve_logs(self) -> List[str]:
+ """Get a list of every log entry recorded during this run."""
+
+ if not s... | [RunTracker->[get_critical_path_timings->[add_to_timings],end_workunit->[end_workunit,end],write_stats_to_json->[_json_dump_options],_stats->[run_information],post_stats->[do_post->[error,do_post],error,_get_headers,do_post],store_stats->[write_stats_to_json,_stats,post_stats],end->[store_stats],start->[start,register_... | Looks up an option scope and optionally option therein in the options parsed by Pants. | This should probably be `Tuple[str, ...]`. |
@@ -64,6 +64,12 @@ _VALID_MODEL_FN_ARGS = set(
['features', 'labels', 'mode', 'params', 'self', 'config'])
+def _check_string_or_not(name):
+ if isinstance(name, six.string_types):
+ return name
+ raise TypeError("Received {} and I was expecting string".format(type(name)))
+
+
@tf_export('estimat... | [_write_dict_to_summary->[_dict_to_str],_load_global_step_from_checkpoint_dir->[latest_checkpoint],_check_checkpoint_available->[latest_checkpoint],Estimator->[export_savedmodel->[latest_checkpoint],_create_and_assert_global_step->[_create_global_step],_evaluate_model->[latest_checkpoint,_call_model_fn,_get_features_an... | Creates a TensorFlow estimator object which can be used to train and evaluate a single model. | Because you only use this in one place, can you - make this function local to where you use it - make the error message more specific (specifically, the string is a variable name) |
@@ -13,7 +13,7 @@
* the source code distribution for details.
*/
-$init_modules = array();
+$init_modules = array('alerts');
require __DIR__ . '/includes/init.php';
$options = getopt('d::h:f:;');
| [No CFG could be retrieved] | This function initializes the nagios service with the given parameters. Check if the hostname matches the hostname and if so run the polling function. | Need to remove 'alerts' now that this is no longer running alerting. |
@@ -10,7 +10,7 @@ class Authenticate extends Middleware
* Get the path the user should be redirected to when they are not authenticated.
*
* @param \Illuminate\Http\Request $request
- * @return string
+ * @return void|string
*/
protected function redirectTo($request)
{
| [Authenticate->[redirectTo->[expectsJson]]] | Redirects to login page if request is not json. | Revert these two please. |
@@ -202,13 +202,12 @@ public class OffHeapDataContainer implements DataContainer<WrappedBytes, Wrapped
if (!foundKey) {
if (offHeapEntryFactory.equalsKey(address, key)) {
entryReplaced(newAddress, address);
- allocator.deallocate(address);
... | [OffHeapDataContainer->[compute->[compute,performGet,performPut,checkDeallocation,performRemove],performPut->[performPut,deallocate],KeySet->[contains->[containsKey]],get->[checkDeallocation],remove->[checkDeallocation],keySet->[KeySet],peek->[get],values->[ValueCollection],containsKey->[toWrapper,checkDeallocation],Va... | This method is called from the put method of the HeapEntry interface. | I don't think the deallocation should happen in `entryReplaced()`. Once the entry was replaced from the LRU list and from the hash table it can't be read by other threads, so we can free the memory without holding the lock. Ideally I'd want the allocation and deallocation to happen at the same level, i.e. in `performPu... |
@@ -225,13 +225,7 @@ class Url
*/
public static function deviceUrl($device, $vars = [])
{
- $routeParams = [is_int($device) ? $device : $device->device_id];
- if (isset($vars['tab'])) {
- $routeParams[] = $vars['tab'];
- unset($vars['tab']);
- }
-
- retu... | [Url->[overlibContent->[subDays],graphPopup->[subMonth,subDay,subYear,subWeek],portLink->[subDay,subYear,displayName,canAccess,subWeek,subMonth,getLabel],sensorLink->[subDay,subYear,displayName,subWeek,subMonth],deviceLink->[displayName,subDay,canAccess,subWeek],portThumbnail->[subDay]]] | This method returns device url. | This is going to cause issues, above code has a workaround for a bug with legacy code calling it. |
@@ -225,4 +225,14 @@ public class ConvertAvroToJSON extends AbstractProcessor {
flowFile = session.putAttribute(flowFile, CoreAttributes.MIME_TYPE.key(), "application/json");
session.transfer(flowFile, REL_SUCCESS);
}
+
+ private byte[] toAvroJSON(Schema shcemaToUse, GenericRecord datum) throw... | [ConvertAvroToJSON->[init->[init,unmodifiableList,add],getRelationships->[add],onTrigger->[process->[hasNext,write,parse,binaryDecoder,get,BufferedInputStream,read,getBytes,next,BufferedOutputStream],getValue,write,error,asBoolean,equals,StreamCallback,get,putAttribute,key,transfer],getBytes,build]] | On trigger. Reads next record from the input stream and writes it to the output stream. | typo "shcemaToUse" should be "schemaToUse" |
@@ -70,8 +70,12 @@ class PageIterator(Iterator[Iterator[ReturnType]]):
# type: () -> Iterator[ReturnType]
if self.continuation_token is None and self._did_a_call_already:
raise StopIteration("End of paging")
+ try:
+ self._response = self._get_next(self.continuation_toke... | [ItemPaged->[__next__->[by_page,from_iterable,next],__repr__->[hex,id,format],by_page->[_page_iterator_class],__init__->[pop]],PageIterator->[__next__->[_get_next,StopIteration,iter,_extract_data]],getLogger,TypeVar] | Returns an iterator over the next in the response. | Do we have to glue the `continuation_token` onto the exception here, or can we make sure we provide it when we raise the exception (e.g. by passing it into the context of the current operation)? It feels more fragile to catch/annotate/re-throw than to always pass in "what you know" about a request when making it... |
@@ -75,9 +75,15 @@ class CenterCrop(object):
return image, target
-class ToTensor(object):
+class PILToTensor:
def __call__(self, image, target):
image = F.pil_to_tensor(image)
+ target = torch.as_tensor(np.array(target), dtype=torch.int64)
+ return image, target
+
+
+class Conv... | [Normalize->[__call__->[normalize]],Compose->[__call__->[t]],CenterCrop->[__call__->[center_crop]],pad_if_smaller->[min,pad],RandomHorizontalFlip->[__call__->[hflip,random]],ToTensor->[__call__->[pil_to_tensor,convert_image_dtype,as_tensor,array]],RandomResize->[__call__->[randint,resize]],RandomCrop->[__call__->[get_p... | Returns image and target with sequence number of missing values. | What is the type of target passed to this method? Can we avoid using numpy here? |
@@ -194,6 +194,13 @@ public class ConsumeAMQP extends AbstractAMQPProcessor<AMQPConsumer> {
return amqpConsumer;
} catch (final IOException ioe) {
+ try {
+ connection.close();
+ getLogger().warn("Closed connection at port " + connection.getPort());
+ ... | [ConsumeAMQP->[createAMQPWorker->[getValue,AMQPConsumer,ProcessException,asBoolean],addAttribute->[put,toString],buildAttributes->[getDeliveryMode,getHeaders,getExpiration,getContentEncoding,addAttribute,getTimestamp,getTime,getClusterId,getPriority,getType,getContentType,getMessageId,getAppId,getReplyTo,getUserId,getC... | Create a new AMQP consumer. | Instead of "ioe_close" "ioeClose" would be better?? Also not sure if log message should be at warn or info level. |
@@ -81,3 +81,6 @@ if DEMO_SENTRY_DSN:
sentry_sdk.init(
DEMO_SENTRY_DSN, integrations=[DjangoIntegration()], before_send=before_send,
)
+
+
+ROOT_EMAIL = os.environ.get("ROOT_EMAIL")
| [_get_project_name_from_url->[match],before_send->[any,info,get,endswith,_get_project_name_from_url],init,get_list,getLogger,DjangoIntegration,get,compile,remove,warning] | Initialize the SDK with the given configuration. | We already have it on line 43 |
@@ -238,12 +238,9 @@ def linkify_escape(text):
return URL_RE.sub(linkify, unicode(jinja2.escape(text)))
-def linkify_with_outgoing(text, nofollow=True, only_full=False):
+def linkify_with_outgoing(text):
"""Wrapper around bleach.linkify: uses get_outgoing_url."""
- callbacks = [linkify_only_full_urls] ... | [linkify_bounce_url_callback->[get_outgoing_url],resolve->[get_url_prefix],reverse->[get_url_prefix],linkify_with_outgoing->[linkify],Prefixer->[fix->[get_language,get_app]]] | Wrapper around bleach. linkify. | This strictly isn't necessary for the Bleach update, but I simplified this function down to what was actually used in the code. |
@@ -178,6 +178,16 @@ func (instance *ChainWorkflowInstance) IsRunning() bool {
return instance.isRunning
}
+func (instance *ChainWorkflowInstance) IsCanceled() bool {
+ if instance.payload != nil {
+ return instance.payload.Canceled
+ } else if instance.result != nil {
+ return instance.result.Canceled
+ } else ... | [getParameters->[GetParameters],startNext->[startNext,OnStart],OnStart->[OnStart],OnTaskComplete->[getParameters,IsValid,GetParameters,OnTaskComplete,GetPayload],OnCancel->[OnCancel,getParameters,IsValid,GetPayload]] | IsRunning returns true if the workflow instance is running false otherwise. | Can we drop the last `} else {`? |
@@ -377,6 +377,8 @@ class BatchNormalizationTest(test.TestCase):
x_shape, dtype, [6], np.float32, use_gpu=True, data_format='NHWC')
self._test_inference(
x_shape, dtype, [6], np.float32, use_gpu=False, data_format='NHWC')
+ self._test_inference(
+ x_shape, dtype, [131], np.f... | [BatchNormalizationTest->[testInferenceShape1->[_test_inference],testInferenceShape2->[_test_inference],_test_training->[_training_ref],_training_ref->[_batch_norm],testBatchNormGradShape2->[_test_gradient],_inference_ref->[_batch_norm],testTrainingShape4->[_test_training],testBatchNormGradGradConfig1->[_testBatchNormG... | Test inference shape 4 and 5. | For consistency with the GPU case, you should put the NCHW case first. And same for some of the test cases below |
@@ -481,13 +481,15 @@ static JsonElement *ReadReleaseIdFileFromInputs()
Policy *LoadPolicy(EvalContext *ctx, GenericAgentConfig *config)
{
- StringSet *parsed_files_and_checksums = StringSetNew();
+ StringMap *policy_files_hashes = StringMapNew();
+ StringSet *parsed_files_checksums = StringSetNew();
... | [bool->[RlistAppendScalar,RlistFnCallValue,EvalContextVariableControlCommonGet,PolicyGetBundle,StringWriterData,WriterClose,RlistDestroy,Log,RlistScalarValue,StringWriter,WriterWrite,RvalWrite],Policy->[BodyGetConstraint,PolicyResolve,PolicyNew,HashFile,LoadPolicyInputFiles,RenameMainBundle,PolicyDestroy,EffectiveConst... | Load the policy file and check if there are any missing bundles or errors. finds missing bundle or promise types and checks if there is a missing bundle or if there. | This is confusing. Why are you sending `policy_files_hashes` as an argument to `LoadPolicyFile` above, but then setting it directly here? |
@@ -64,9 +64,9 @@ func testSetup(t *testing.T) (string, func()) {
switch requiredTool {
case "psql":
- pg.PSQLCmd = []string{path}
+ pg.DefaultPSQLCmd = []string{path}
case "pg_dump":
- pg.PGDumpCmd = []string{path}
+ pg.DefaultPGDumpCmd = []string{path}
}
t.Logf("Found %s at %s\n", requiredToo... | [RemoveAll,DatabaseExists,Exists,Exec,False,ResolveTCPAddr,Close,TempDir,WriteFile,Atoi,CombinedOutput,AsUser,Error,CleanupPgPassfile,ReadFile,Args,Itoa,BoolQuery,Ping,DropDatabase,New,Connect,Export,CreateDatabase,RenameDatabase,NewExecExecutor,ConnURI,LookPath,Logf,Join,Equal,Geteuid,Lookup,NoError,Fatalf,Chown,Sleep... | testSetup tests the table for the given . testConnInfo returns a connection info object that can be used to connect to a PostgreSQL. | This isn't thread-safe, but this also only happens on startup in our tests. |
@@ -28,6 +28,14 @@
#include <exception>
#include <iostream>
+#include <string>
+
+#if defined _WIN64 || defined _WIN32
+#include <winsock.h>
+#else
+#include <arpa/inet.h>
+#include <unistd.h>
+#endif
using namespace OpenDDS::DCPS;
using namespace OpenDDS::RTPS;
| [No CFG could be retrieved] | Test for the mini - transport in SPDP. Internal method for handling a participant. | This block should be removed. Determine which platform functions/macros you need and call the equivalent from ACE - is it just `ntohl`? |
@@ -102,7 +102,8 @@ class _SideInputsContainer(object):
list
) # type: DefaultDict[Optional[AppliedPTransform], List[pvalue.AsSideInput]]
# this appears unused:
- self._side_input_to_blocked_tasks = collections.defaultdict(list) # type: ignore
+ self._side_input_to_blocked_tasks = collections... | [DirectStepContext->[get_keyed_state->[DirectUnmergedState]],_SideInputsContainer->[__init__->[_SideInputView]],EvaluationContext->[get_value_or_block_until_ready->[get_value_or_block_until_ready],create_bundle->[create_bundle],get_execution_context->[_ExecutionContext],__init__->[_SideInputsContainer],create_empty_com... | Initializes the object with a sequence of side inputs. | Would be good to drop this unrelated change |
@@ -3774,8 +3774,12 @@ class NewSemanticAnalyzer(NodeVisitor[None],
base = self.cur_mod_id
return base + '.' + n
- def enter(self) -> None:
- self.locals.append(SymbolTable())
+ def enter(self, function: Optional[FuncItem] = None) -> None:
+ if function:
+ names = ... | [names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_expr->[analyze_function],visit_for_stmt->[fai... | Returns the qualified name of the node with the given node identifier. | Add docstring and describe the argument. Also discuss when it's okay to leave it out. |
@@ -79,7 +79,7 @@ export default Controller.extend({
@discourseComputed("invitesCount.total", "invitesCount.redeemed")
redeemedLabel(invitesCountTotal, invitesCountRedeemed) {
- if (invitesCountTotal > 50) {
+ if (invitesCountTotal > 0) {
return I18n.t("user.invited.redeemed_tab_with_count", {
... | [No CFG could be retrieved] | Displays a list of all user - related objects that can be invited. User invites action. | Should this be `showSearch` instead? |
@@ -4,7 +4,7 @@ from typing import TYPE_CHECKING, Callable, List, Optional
from django.db import transaction
-from ..payment.interface import TokenConfig
+from ..payment.interface import PaymentData, TokenConfig
from ..plugins.manager import get_plugins_manager
from . import GatewayError, PaymentError, Transacti... | [list_payment_sources->[list_payment_sources],payment_refund_or_void->[void,refund],get_client_token->[get_client_token]] | Decorator to wrap a function to provide a function that can be called to create a new token Process a Payment object. | Unused import :policeman: |
@@ -61,11 +61,11 @@ class PathGlobs(datatype([
glob_match_error_behavior=glob_match_error_behavior)
-class PathGlobsAndRoot(datatype([('path_globs', PathGlobs), ('root', str)])):
+class PathGlobsAndRoot(datatype([('path_globs', PathGlobs), ('root', text_type)])):
pass
-class DirectoryDigest(datatype([... | [PathGlobs->[with_match_error_behavior->[PathGlobs]],DirectoryDigest,Snapshot] | Creates a PathGlobs object with the given include and exclude. Returns a string representation of the object. | This has to be bytes, or we get a thread panic. |
@@ -60,8 +60,9 @@ gulp.task(
'master': ' Includes a blank snapshot (baseline for skipped builds)',
'verify': ' Verifies the status of the build ID in ./PERCY_BUILD_ID',
'skip': ' Creates a dummy Percy build with only a blank snapshot',
+ 'headless': ' Runs Chrome in headless mode',... | [No CFG could be retrieved] | Options for the command. | Should we default to headless? If it's not headless, the user risks interrupting the test accidentally (imaging you start running the test in your terminal, switch to another window and begin typing. Then a Chrome window opens, takes focus, and you just modified the results because you thought you're typing on the othe... |
@@ -93,4 +93,6 @@ type Client interface {
// @param (context, previousIndex)
// @return (taskID, error)
ReindexNodeStateToLatest(context.Context, string) (string, error)
+ GetActions(string, int, time.Time, string, bool) ([]InternalChefAction, int64, error)
+ DeleteAllIndexesWithPrefix(string, context.Context) er... | [No CFG could be retrieved] | Missing taskID for the given context. | These are needed for migrating the actions to the event-feed-service. |
@@ -68,5 +68,10 @@ class TensorboardLogger(object):
for k, v in report.items():
if isinstance(v, numbers.Number):
self.writer.add_scalar(f'{setting}/{k}', v, global_step=step)
+ elif isinstance(v, Metric):
+ self.writer.add_scalar(f'{setting}/{k}', v.valu... | [TensorboardLogger->[log_metrics->[print,add_scalar,isinstance,items],add_cmdline_args->[add_argument_group,add_argument],__init__->[exists,print,SummaryWriter,format,dumps,ImportError,makedirs]]] | Add all metrics from tensorboard_metrics opt key. . | It *feels* like we shouldn't need to have a separate condition for this because it's mostly a repeat of above, but I don't know how to combine the two conditions without obfuscating what Metric does |
@@ -912,5 +912,6 @@ public abstract class AbstractHoodieWriteClient<T extends HoodieRecordPayload, I
// Calling this here releases any resources used by your index, so make sure to finish any related operations
// before this point
this.index.close();
+ this.heartbeatClient.stop();
}
}
| [AbstractHoodieWriteClient->[rollbackInflightCompaction->[rollback],startCommitWithTime->[startCommitWithTime,startCommit],inlineCluster->[scheduleClustering,cluster],startCommit->[startCommit],rollbackPendingCommits->[createTable,rollBackInflightBootstrap,getInflightTimelineExcludeCompactionAndClustering,rollback],res... | Closes the index and all resources associated with this object. | do we need to move this to finally block ? |
@@ -602,7 +602,7 @@ class Layer(core.Layer):
destination(dict, optional) : If provide, all the parameters will set to this dict . Default: None
include_sublayers(bool, optional) : If true, also include the parameters from sublayers. Default: True
- Retruns:
+ Returns:
... | [Layer->[named_sublayers->[named_sublayers],register_forward_post_hook->[HookRemoveHelper],train->[train],create_parameter->[create_parameter],__delattr__->[__delattr__],__init__->[_convert_camel_to_snake],eval->[eval],state_dict->[state_dict],__setattr__->[__setattr__,_remove_if_exist],clear_gradients->[parameters],__... | Returns a dict containing all the parameters of current layer and its sub - layers and their sub. | oops, a conflict happened in this file, may i ask for a fix again? |
@@ -22,6 +22,7 @@ import static com.redhat.rhn.domain.contentmgmt.ContentFilter.Rule.DENY;
import static com.redhat.rhn.domain.role.RoleFactory.ORG_ADMIN;
import static java.util.Collections.emptyList;
import static java.util.Collections.singleton;
+import static java.util.Optional.empty;
import static java.util.Op... | [ContentManagerChannelAlignmentTest->[setUp->[setUp]]] | missing - requires warranties of MERCHANTABILITY or FITNESS Package EVR Domain test and error data cache DTOs. | There are some unused imports in this one, and maybe in some other test classes as well |
@@ -196,8 +196,8 @@ class Top(object):
def expand(self, pcoll):
compare = self._compare
- if (not self._args and not self._kwargs and
- not self._key and pcoll.windowing.is_default()):
+ if (not self._args and not self._kwargs and
+ pcoll.windowing.is_default()):
if s... | [_MergeTopPerBundle->[process->[_ComparableValue]],_TopPerBundle->[process->[_ComparableValue]],TupleCombineFn->[add_input->[add_input]],PhasedCombineFnExecutor->[__init__->[curry_combine_fn],merge_only->[merge_accumulators],full_combine->[apply],add_only->[create_accumulator,add_inputs],extract_only->[extract_output]]... | Expand the given pipeline into a pipeline that combines all items in the pipeline into a single sequence. | Nit: This fits in one line, or? |
@@ -61,6 +61,11 @@ var (
// For 100k series for 7 week, could be 1.2m - 10*(8^(7-1)) = 2.6m.
Buckets: prometheus.ExponentialBuckets(10, 8, 7),
})
+ dedupedChunksTotal = promauto.NewCounter(prometheus.CounterOpts{
+ Namespace: "cortex",
+ Name: "chunk_store_deduped_chunks_total",
+ Help: "Count of c... | [DeleteChunk->[PutOne,Get],Get->[Error],calculateIndexEntries->[Get],lookupLabelNamesByChunks->[Error],LabelNamesForMetricName->[Error],hasChunksForInterval->[lookupChunksBySeries],GetChunkRefs->[Error]] | var returns a new Store instance that tracks the number of unique indexes that have been Get returns a seriesStore that can be used to lookup a series by userID. | This correlate with `cortex_chunk_store_stored_chunks_total` which is per user. @gouthamve are we OK having this metric non per-user? |
@@ -137,5 +137,15 @@ namespace Microsoft.Xna.Framework.Windows
base.WndProc(ref m);
}
+
+ private static ushort HiWord(IntPtr word)
+ {
+ return (ushort)(((ulong)word >> 16) & 0xffff);
+ }
+
+ private static short GetWheelDeltaWParam(IntPtr wParam)
+ ... | [WinFormsGameForm->[WndProc->[GetPointerLocation,WndProc,GetPointerId]]] | Override WndProc to handle keyboard related messages. Private functions for F5100. | If it is only used once, and it is a simple cast of another return value, just put this inline in the call site. Adding it as a separate method is overkill. |
@@ -109,6 +109,9 @@ public class MetricHolder
serializerUtils.writeString(out, holder.typeName);
switch (holder.type) {
+ case LONG:
+ holder.longType.writeToChannel(out);
+ break;
case FLOAT:
holder.floatType.writeToChannel(out);
break;
| [MetricHolder->[floatMetric->[MetricHolder],convertByteOrder->[MetricHolder,convertByteOrder],fromByteBuffer->[MetricHolder,fromByteBuffer],writeToChannel->[writeToChannel],complexMetric->[MetricHolder],determineType]] | Serializes the given MetricHolder to the given channel. | Was this added because the enum was missing? |
@@ -305,6 +305,9 @@ export function createAmpElementProto(win, name, implementationClass) {
/** @private {boolean|undefined} */
this.loadingDisabled_;
+ /** @private {boolean|undefined} */
+ this.loadingState_;
+
/** @private {?Element} */
this.loadingContainer_ = null;
| [No CFG could be retrieved] | Creates a new child element. Checks if the element has been upgraded yet. | is it possible to to start with a boolean state? like `false` by default? |
@@ -271,7 +271,7 @@ namespace System.Net.Http
if (_contentReadStream == null) // don't yet have a Stream
{
Task<Stream> t = TryGetBuffer(out ArraySegment<byte> buffer) ?
- Task.FromResult<Stream>(new MemoryStream(buffer.Array, buffer.Offset, buffer.Count, wr... | [HttpContent->[CreateContentReadStreamAsync->[CreateContentReadStreamAsync],Stream->[TryGetBuffer],ReadBufferedContentAsString->[TryGetBuffer],LimitArrayPoolWriteStream->[WriteByte->[EnsureCapacity],Write->[EnsureCapacity],Dispose->[Dispose],Task->[Write],ValueTask->[Write]],ReadAsStringAsync->[ReadAsStringAsync],GetCo... | Reads a stream asynchronously. If the stream doesn t yet have a Stream it will create a. | Is it a bug in ArraySegment null annotations? /cc @stephentoub |
@@ -199,10 +199,13 @@ public class AzkabanJobLauncher extends AbstractJob implements ApplicationLaunch
Properties jobProps = this.props;
if (jobProps.containsKey(TEMPLATE_KEY)) {
+ Config config = ConfigUtils.propertiesToConfig(jobProps);
+ JobSpecResolver resolver = JobSpecResolver.builder(config... | [AzkabanJobLauncher->[stop->[stop],cancelJob->[cancelJob],close->[close],start->[start],launchJob->[launchJob]]] | Creates a new instance of AzkabanJobLauncher. Initialize the object. | Shouldn't we pass a catalog (i.e. the PackagedTemplatesJobCatalogDecorator) to the JobSpecResolver Builder? |
@@ -29,6 +29,7 @@ import java.util.concurrent.CountDownLatch;
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeUnit;
+import lombok.AllArgsConstructor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
| [GobblinMultiTaskAttempt->[runAndOptionallyCommitTaskAttempt->[commit,run,isSpeculativeExecutionSafe],runWorkUnits->[runAndOptionallyCommitTaskAttempt,GobblinMultiTaskAttempt],commit->[apply->[call->[commit]]],isSpeculativeExecutionSafe->[isSpeculativeExecutionSafe]]] | Imports a single - object object from a Java source. Imports and imports Gobblin - specific properties for a single task. | Is this used? |
@@ -165,7 +165,7 @@ class Core_Command extends WP_CLI_Command {
* define( 'WP_DEBUG_LOG', true );
* PHP
*
- * @synopsis --dbname=<name> --dbuser=<user> [--dbpass=<password>] [--dbhost=<host>] [--dbprefix=<prefix>] [--locale=<locale>] [--extra-php]
+ * @synopsis --dbname=<name> --dbuser=<user> [--dbpa... | [Core_Command->[install->[_install],create_initial_blog->[set_permalink_structure,insert],download->[getMessage,get_download_offer],update->[upgrade,get_error_code],multisite_install->[_install,_multisite_convert],_read->[getMessage],_multisite_convert->[get_error_message,tables,get_error_code],multisite_convert->[_mul... | Generates the wp - config. php file. | There's a typo: `satls` |
@@ -83,7 +83,7 @@ int OBJ_NAME_new_index(unsigned long (*hash_func) (const char *),
return (0);
}
name_funcs->hash_func = lh_strhash;
- name_funcs->cmp_func = OPENSSL_strcmp;
+ name_funcs->cmp_func = obj_strcmp;
CRYPTO_mem_ctrl(CRYPTO_MEM_CHECK_DISABLE);
sk... | [void->[OBJ_NAME_remove],OBJ_NAME_do_all_sorted->[OBJ_NAME_do_all],OBJ_NAME_add->[OBJ_NAME_init],char->[OBJ_NAME_init]] | This function creates a new name index. | I suppose this is okay, but I'd kind prefer to see the else/define at 28/29 removed and an ifdef here. |
@@ -309,7 +309,7 @@ public class StringDimensionMergerV9 implements DimensionMergerV9<int[]>
if (hasSpatial) {
spatialWriter = new ByteBufferWriter<>(
ioPeon,
- String.format("%s.spatial", dimensionName),
+ StringUtils.safeFormat("%s.spatial", dimensionName),
... | [StringDimensionMergerV9->[toIndexSeekers->[IndexSeekerWithConversion,size,get,IndexSeekerWithoutConversion],ConvertingIndexedInts->[size->[size],get->[get],iterator->[nextInt->[nextInt,get],skip->[skip],hasNext->[hasNext],iterator]],writeIndexes->[close]]] | Writes all the indexes to the output directory. no - op if no data in the dictionary. | Probably should crash if bad format string |
@@ -2259,7 +2259,7 @@ class Item
$condition[0] .= " AND `received` < UTC_TIMESTAMP() - INTERVAL ? DAY";
$condition[] = $days;
- $items = Post::select(['resource-id', 'starred', 'id', 'post-type', 'uid', 'uri-id'], $condition);
+ $items = Post::select(['resource-id', 'starred', 'id', 'post-type', 'uid', 'uri-i... | [Item->[getLanguage->[getAvailableLanguages,close],newURI->[get],expire->[get],getGravity->[match],getPlink->[remove,t],storeForUserByUriId->[get],insert->[get],addNonVisualAttachments->[t,stopRecording,startRecording],enumeratePermissions->[expand],prepareBody->[t,get,getThemeInfoValue],addVisualAttachments->[stopReco... | Expire posts for a given number of days Fetch all the items that are not filed and expire them. | `post-type` is already a part of the field list. |
@@ -53,6 +53,7 @@ class PluginEntryPoint(object):
def __init__(self, entry_point, with_prefix=False):
self.name = self.entry_point_to_plugin_name(entry_point, with_prefix)
+ self.version = entry_point.dist.version
self.plugin_cls = entry_point.load()
self.entry_point = entry_poi... | [PluginEntryPoint->[verify->[init],prepare->[prepare],__str__->[init,prepare]],PluginsRegistry->[ifaces->[ifaces,filter],prepare->[prepare],init->[init],verify->[verify,filter],available->[filter],_load_entry_point->[PluginEntryPoint],visible->[filter],find_init->[init]]] | Initialize a object. | Is this line OK here? Or should it be after `entry_point.load()`? |
@@ -341,6 +341,7 @@ class KeyClient(_KeyVaultClientBase):
pages = self._client.get_deleted_keys(self._vault_url, maxresults=max_page_size, **kwargs)
return (DeletedKey._from_deleted_key_item(item) for item in pages)
+ @distributed_trace
def list_keys(self, **kwargs):
# type: (Mappin... | [KeyClient->[get_key->[get_key],unwrap_key->[unwrap_key],recover_deleted_key->[recover_deleted_key],create_ec_key->[create_key],delete_key->[delete_key],update_key->[update_key],get_deleted_key->[get_deleted_key],purge_deleted_key->[purge_deleted_key],backup_key->[backup_key],restore_key->[restore_key],create_rsa_key->... | Lists the deleted keys in the Key Vault. List all keys in the vault. | Can you please check what the resulting spans are from the `list_<something>` methods. The methods themselves should be returning `Paged[<something>]` instances that, in turn, will make individual service calls on demand if/when the caller iterates through the list. |
@@ -119,7 +119,8 @@ App.stackServiceMapper = App.QuickDataMapper.create({
}
stackServiceComponents.push(parsedResult);
}, this);
- stackService.stack_id = stackService.stack_name + '-' + stackService.stack_version;
+ stackService.stack_id = `${stackService.stack_name}-${stackService.s... | [No CFG could be retrieved] | Add the details of the items that are not installed in the stack. Private methods - This function is called from the constructor of the base class. It is called. | This will likely break many parts of the UI since code at many places assumes the value of id as service_name. Either we make all the other required changes or rename this as stackServiceId or something |
@@ -292,9 +292,8 @@ export class AmpSelector extends AMP.BaseElement {
targetOption: el.getAttribute('option'),
selectedOptions: selectedValues,
});
- // TODO(choumx, #9699): HIGH.
this.action_.trigger(this.element, name, selectEvent,
- ActionTrust.M... | [No CFG could be retrieved] | Adds a fragment to the select box and updates the selection and input fields. Handler for keyboard key down events. | @choumx What does this mean for selector? |
@@ -627,7 +627,7 @@ public class Weld implements ContainerInstanceFactory {
* @param resourceLoader
* @param bootstrap
*/
- protected Deployment createDeployment(ResourceLoader resourceLoader, CDI11Bootstrap bootstrap) {
+ protected Deployment createDeployment(CDI11Bootstrap bootstrap) {
... | [Weld->[resetAll->[reset,containerId],handleDir->[handleDir],shutdown->[shutdown],initialize->[initialize],PackInfo->[hashCode->[hashCode],equals->[equals]]]] | Creates a deployment. This method creates a WeldDeployment object. | I've seen the Weld class being subclassed more than once. Changing the signature of this protected method is likely to break those subclasses. |
@@ -510,7 +510,7 @@ func (m *kubeGenericRuntimeManager) computePodActions(pod *v1.Pod, podStatus *ku
if containerStatus == nil || containerStatus.State != kubecontainer.ContainerStateRunning {
if kubecontainer.ShouldContainerBeRestarted(&container, pod, podStatus) {
message := fmt.Sprintf("Container %+v is ... | [computePodActions->[podSandboxChanged],Status->[Status],Version->[Version],SyncPod->[computePodActions],GarbageCollect->[GarbageCollect]] | computePodActions returns a list of actions that can be performed on the given pod. This function is used to check the status of all containers in the pod and if the status Changes the container state of a pod. | While I realize that you are not responsible for this behavior, line 512 is an example of time spent formatting messages only to be discarded when the message is not logged on line 513 because the level of the message is not high enough. This might be worth investigating in general. |
@@ -120,6 +120,8 @@ var (
doRevertBefore = flag.Int("do_revert_before", 0, "If the current block is less than do_revert_before, revert all blocks until (including) revert_to block")
revertTo = flag.Int("revert_to", 0, "The revert will rollback all blocks until and including block number revert_to")
revertBe... | [Warn,LastCommitBitmap,SerializeToHexStr,Info,RunServices,GetMetricsFlag,WriteLastCommits,Rollback,SetShardIDProvider,Serialize,SupportSyncing,GetMemProfiling,New,GetLogInstance,Bool,SetBeaconGroupID,FindAccount,GetHandler,Seed,UpdateConsensusInformation,Network,FatalErrMsg,Println,SetPushgatewayIP,AddLogFile,Reshardin... | Configures the environment variables for a single node. validator - v. log - validator - v. log - onlyLogTps - only. | as RJ said, put the blacklist into .hmy directory, and add a default filename for it. |
@@ -3,15 +3,15 @@ using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Reflection;
+using System.Text;
using System.Threading;
using Dynamo;
using Dynamo.Controls;
using Dynamo.Models;
using Dynamo.Tests;
-using Dynamo.Utilities;
using Dynamo.ViewModels;
-
+using DynamoShapeMana... | [SystemTestBase->[Setup->[Setup],GetSublistItems->[GetSublistItems]]] | Creates a base class for all system tests. This method is called when a view is created and the view is not yet initialized. | Unit tests now rely on `DynamoShapeManager.Preloader` for its geometry preloading activities. |
@@ -69,7 +69,7 @@ public class XmlFileSensor implements Sensor {
return fs.inputFiles(xmlFilePredicate);
}
- private static Iterable<File> toFile(Iterable<InputFile> inputFiles) {
+ private static Collection<File> toFile(Iterable<InputFile> inputFiles) {
return StreamSupport.stream(inputFiles.spliterat... | [XmlFileSensor->[hasXmlFiles->[hasFiles],describe->[name],toFile->[toList,collect],getXmlFiles->[inputFiles],execute->[hasXmlFiles,registerCheckClasses,setSensorContext,scan,getXmlChecks,forEach,toFile,getXmlFiles],matchesPathPattern]] | Get xml files. | This can be simplified with the move to Collection. |
@@ -135,7 +135,14 @@ export default DiscourseRoute.extend({
I18n.t("yes_value"),
(confirmed) => {
if (confirmed) {
- Backup.rollback();
+ Backup.rollback().then((result) => {
+ if (!result.success) {
+ bootbox.alert(result.message);
+ ... | [No CFG could be retrieved] | Cancel an operation. | Could we use a regular ember transition here? |
@@ -31,6 +31,12 @@ module Idv
errors.add(:back_image, :blank)
end
+ def selfie_image_or_image_data_url_presence
+ return unless FeatureManagement.liveness_checking_enabled?
+ return if selfie_image.present? || selfie_image_data_url.present?
+ errors.add(:selfie_image, :blank)
+ end
+
... | [DocumentCaptureForm->[back_image_or_image_data_url_presence->[add,present?],raise_invalid_image_parameter_error->[raise],front_image_or_image_data_url_presence->[add,present?],model_name->[new],consume_params->[send,to_sym,include?,each,raise_invalid_image_parameter_error],submit->[messages,new,consume_params,valid?],... | if back_image or back_image_data_url_presence iterated over all attributes. | @jmhooper so I added this, but I don't see a convenient way to check that either there is no SP or the SP requires liveness checking. This is just a model with no access to the session or any of our current helpers. Open to suggestions... |
@@ -0,0 +1,16 @@
+/*
+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com
+ * The software in this package is published under the terms of the CPAL v1.0
+ * license, a copy of which has been included with this distribution in the
+ * LICENSE.txt file.
+ */
+package org.mule.module.http.intern... | [No CFG could be retrieved] | No Summary Found. | Same concerns about not composing lifecycle interfaces. |
@@ -14,13 +14,15 @@ import (
func getHTTPCacheGenNumberHeaderSetterMiddleware(cacheGenNumbersLoader *purger.TombstonesLoader) middleware.Interface {
return middleware.Func(func(next http.Handler) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
- userID, err := tenant.Tenant... | [Context,Header,Error,TenantID,HandlerFunc,ServeHTTP,GetResultsCacheGenNumber,Func,Set] | getHTTPCacheGenNumberHeaderSetterMiddleware returns a middleware for setting the cache gen header to. | I am not too sure if I can `cacheGenNumber` like that |
@@ -460,6 +460,8 @@ func ImageWithMetadata(image *Image) error {
case 0:
// legacy config object
case 1:
+ image.DockerImageManifestMediaType = schema1.MediaTypeManifest
+
if len(manifest.History) == 0 {
// should never have an empty history, but just in case...
return nil
| [Exact->[NameString],String->[Exact],DaemonMinimal->[Minimal],Exact,String,MostSpecific,Equal] | ImageWithMetadata returns a copy of image with the necessary metadata filled in. Image updates image metadata with mismatched layer count and history count. | should we be setting the media type even if we don't have a history? |
@@ -57,7 +57,7 @@ TEMPLATE_LOADERS = [
]
# Make this unique, and don't share it with anybody.
-SECRET_KEY = '{{ secret_key }}'
+SECRET_KEY = os.environ.get('SECRET_KEY')
MIDDLEWARE_CLASSES = [
'django.contrib.sessions.middleware.SessionMiddleware',
| [dirname,join,normpath] | The object returned by the n - th entry in the system. This function is a utility function that gets called from the main thread. It is called by. | How about `os.environ.get('SECRET_KEY', '{{ secret_key }}')`? This way using this as a Django project template will continue to work. |
@@ -72,12 +72,14 @@ public class ObjectSerializer {
} else if (object instanceof byte[]) {
// If the object is a byte array, skip serializing it and use a special metadata to
// indicate it's raw binary. So that this object can also be read by Python.
- return new NativeRayObject((byte[]) object... | [ObjectSerializer->[serialize->[encode,NativeRayObject],deserialize->[IllegalArgumentException,equals,RayActorException,decode,UnreconstructableException,RayWorkerException,toString],getBytes]] | Serializes the object if it is a native object or returns it if it is a RayTask. | do we still need to handle `byte[]` separately? why not just use message pack? |
@@ -83,6 +83,17 @@ func jobRowToStrings(job models.JobSpec) []string {
}
}
+func (rt RendererTable) renderBridge(bridge models.BridgeType) error {
+ table := tablewriter.NewWriter(rt)
+ table.SetHeader([]string{"Name", "URL"})
+ table.Append([]string{
+ bridge.Name,
+ bridge.URL.String(),
+ })
+ render("Bridge",... | [renderJobs->[Append,NewWriter,SetHeader],renderJob->[renderJobTasks,renderJobInitiators,renderJobSingles,renderJobRuns],renderJobTasks->[Append,NewWriter,FriendlyParams,SetHeader],renderJobRuns->[NewWriter,Append,NullISO8601UTC,SetHeader,ISO8601UTC,String],renderJobInitiators->[NewWriter,Append,SetHeader,String,Friend... | renderJob renders a job in the table. | We now also have a column `confirmations` that forces a task with that bridge type to wait for x number of block confirmations before executing the task. Let's add that one too. If the controller doesn't return information regarding the confirmations, let's add it. |
@@ -300,7 +300,7 @@ namespace System.ComponentModel.Composition.ReflectionModel
}
// if the instance has been already set
- if (createdInstance == null)
+ if (createdInstance != null)
{
ReleaseInstanceIfNecessary(cre... | [ReflectionComposablePart->[GetExportedValue->[RequiresRunning,GetExportedValue],UseImportedValues->[ToString],GetInstanceActivatingIfNeeded->[ReleaseInstanceIfNecessary],Activate->[RequiresRunning],NotifyImportSatisfied->[GetInstanceActivatingIfNeeded],SetExportedValueForImport->[GetInstanceActivatingIfNeeded],SetImpo... | Returns the instance activating if necessary. | I think this is bug, if `createdInstance` is null, no need to release it, CC @safern @maryamariyan |
@@ -99,9 +99,10 @@ public class WebSocketAgentsTest {
).stdout(System.out).start());
r.waitOnline(s);
assertEquals("response", s.getChannel().call(new DummyTask()));
+ assertNotNull(s.getChannel().call(new FatTask()));
FreeStyleProject p = r.createFreeStyle... | [WebSocketAgentsTest->[smokes->[JNLPLauncher,start,getURL,isWindows,writeLogTo,addNode,info,setAssignedNode,getAbsolutePath,buildAndAssertSuccess,DummyTask,setWebSocket,set,Shell,DumbSlave,newFile,copyURLToFile,sleep,kill,isOnline,BatchFile,waitOnline,assertEquals,getJnlpMac,call,get,createFreeStyleProject,add],record,... | This test method launches a slave agent and then checks if the node is available. | Suggest also cherry-picking #4605; i.e., reverting this line. |
@@ -377,7 +377,7 @@ public class DefaultHttp2ConnectionEncoderTest {
ChannelPromise promise = newPromise();
encoder.writeHeaders(ctx, streamId, EmptyHttp2Headers.INSTANCE, 0, false, promise);
verify(writer).writeHeaders(eq(ctx), eq(streamId), eq(EmptyHttp2Headers.INSTANCE), eq(0),
- ... | [DefaultHttp2ConnectionEncoderTest->[stream->[stream],goAwaySent->[goAwaySent],createStream->[createStream],reservePushStream->[reservePushStream],goAwayReceived->[goAwayReceived],infoHeadersAndTrailersWithData->[informationalHeaders]]] | Checks if headers should be written for unknown stream. | I think the import of `DEFAULT_PRIORITY_WEIGHT` is now dead code. |
@@ -3661,7 +3661,6 @@ public class ZetaSQLDialectSpecTest {
/** Only sample scenarios are covered here. Excessive testing is done via Compliance tests. */
@Test
- @Ignore("ZetaSQL does not support EnumType to IdentifierLiteral")
public void testExtractTimestamp() {
String sql =
"WITH Timestamp... | [ZetaSQLDialectSpecTest->[testCaseNoValueNoElseNoMatch->[standardMinutes,toPCollection,build,waitUntilFinish,convertToBeamRel,ZetaSQLQueryPlanner,containsInAnyOrder],testIsNotNull2->[standardMinutes,of,toPCollection,build,createNullValue,createArrayType,waitUntilFinish,createSimpleType,convertToBeamRel,ZetaSQLQueryPlan... | ZetaSQL does not support EnumType to IdentifierLiteral. | How could this test pass without running `BeamZetaSqlCalcRel`? My understanding is that the changes in this PR is only used in `BeamZetaSqlCalcRel`. Is this not correct? |
@@ -285,6 +285,13 @@ func NewFuncMap() []template.FuncMap {
}
return false
},
+ "octicon": func(icon string, mega bool) template.HTML {
+ size := ""
+ if mega {
+ size = "mega-"
+ }
+ return template.HTML(fmt.Sprintf(`<svg class="%socticon"><use xlink:href="%s/img/svg/octicons.svg#%s" /></svg>`, ... | [Title,Nanoseconds,LastIndex,Indent,Warn,Sanitize,Count,Front,HasPrefix,GetDefinitionForFilename,EncodeSha1,HTML,Error,Format,Sprint,Marshal,TrimLeftFunc,New,NewPushCommits,GetContent,RenderCommitMessage,RenderCommitMessageSubject,MustCompile,Since,TrimSpace,Next,HTMLEscapeString,FindIndex,Ext,NewReplacer,Split,EscapeS... | NewTextFuncMap returns a function map that returns the functions used to render the template. returns a string representation of the application version version built - with domain date format long date. | Could the `mega` argument be made a `interface` enabling a even shorter `{{octicon "lock"}}` for non-mega ones? |
@@ -508,6 +508,7 @@ public abstract class SeekableStreamIndexTaskRunner<PartitionIdType, SequenceOff
if (isEndSequenceOffsetsExclusive() &&
createSequenceNumber(record.getSequenceNumber()).compareTo(
createSequenceNumber(endOffsets.get(record.getPartitionId()))) >= 0) ... | [SeekableStreamIndexTaskRunner->[SequenceMetadata->[canHandle->[isOpen],createPublisher->[toString,getStartOffsets]],pause->[isPaused],getEndOffsetsHTTP->[authorizationCheck],pauseHTTP->[authorizationCheck],maybePersistAndPublishSequences->[publishAndRegisterHandoff],getStartTime->[authorizationCheck],assignPartitions-... | This method is called when the task is starting up. Create a new sequence sequence and record. This method is called when the next partition of the stream has been restored. This method is used to create a Committer that will attempt to assign all the partitions to Returns a sequence number that can be used to read the... | `stillReading` should only be set to `false` when our assignment is empty (no partitions left to read). Hitting the end offset for one partition doesn't mean we should stop reading _all_ partitions. |
@@ -25,6 +25,12 @@ type module struct {
// in the right order of dependencies.
type Manager struct {
modules map[string]*module
+
+ // Modules that are already initialized
+ modulesLoaded map[string]bool
+
+ // Service map
+ servicesMap map[string]services.Service
}
// UserInvisibleModule is an option for `Regi... | [listDeps->[listDeps],DependenciesForModule->[listDeps],orderedDeps->[listDeps]] | RegisterModuleimports is a function that imports a module from the system. Initializes the target module by starting all its dependencies and stopping all its dependencies. | I would rename "loaded" into "initialised", which is the naming we use here. |
@@ -123,6 +123,11 @@ class PageUpdate(PageCreate):
error_type_class = PageError
error_type_field = "page_errors"
+ @classmethod
+ def save(cls, info, instance, cleaned_input):
+ super(PageCreate, cls).save(info, instance, cleaned_input)
+ info.context.plugins.page_updated(instanc... | [PageCreate->[Arguments->[PageCreateInput],clean_input->[clean_attributes]],PageTypeUpdate->[Arguments->[PageTypeUpdateInput],clean_input->[validate_attributes,check_for_duplicates]],PageUpdate->[Arguments->[PageInput]],PageTypeCreate->[Arguments->[PageTypeCreateInput],clean_input->[validate_attributes]]] | Creates a ModelAdmin instance for a page type. Validate all the attributes of a page type. | Should we run `info.context.plugins.page_created(instance)` when `Page` is updated? |
@@ -29,7 +29,17 @@ import io.quarkus.runtime.ResourceHelper;
public class SubstrateAutoFeatureStep {
- private static final String GRAAL_AUTOFEATURE = "io.quarkus/runner/AutoFeature";
+ private static final String GRAAL_AUTOFEATURE = "io/quarkus/runner/AutoFeature";
+ private static final MethodDescriptor... | [SubstrateAutoFeatureStep->[addReflectiveMethod->[getDeclaringClass,equals,ReflectionInfo,get,add,put],addReflectiveField->[getDeclaringClass,getName,ReflectionInfo,get,add,put],addReflectiveClass->[ReflectionInfo,put,get],generateFeature->[writeArrayValue,getValue,SubstrateOutputBuildItem,size,toArray,returnValue,getM... | Generate a Feature. load the class and load the class loader This method is called when a proxy is not available. This method is called to register all the classes in the bundle. This method is used to find all constructors and methods declared in the given class. | Oh WOW, we're replacing a partly binary class name. Can we introduce a convension for constant class names that lets us know if it's a class name, or a class binary name ('.' or '/')? |
@@ -0,0 +1,3 @@
+<?php
+
+$version = end(explode(' ', trim(snmp_get($device, "sysDescr.0", "-OQv", "SNMPv2-MIB"))));
| [No CFG could be retrieved] | No Summary Found. | We already have sysDescr value in `$device['sysDescr']` |
@@ -89,9 +89,9 @@ class BearerTokenCredentialPolicy(_BearerTokenCredentialPolicyBase, SansIOHTTPPo
"""
self._enforce_https(request)
- if self._need_new_token:
+ if self._token is None or self._need_new_token:
self._token = self._credential.get_token(*self._scopes)
- ... | [BearerTokenCredentialPolicy->[on_request->[_update_headers,_enforce_https]]] | Adds a bearer token Authorization header to request and sends request to next policy. | def _need_new_token(self): # type: () -> bool return not self._token or self._token.expires_on - time.time() < 300 Seems like self._token is None is not needed? |
@@ -71,8 +71,8 @@ void ms32_state::video_start()
m_bg_tilemap_alt = &machine().tilemap().create(*m_gfxdecode, tilemap_get_info_delegate(*this, FUNC(ms32_state::get_ms32_bg_tile_info)), TILEMAP_SCAN_ROWS, 16,16, 256, 16); // alt layout, controller by register?
m_roz_tilemap = &machine().tilemap().create(*m_gfxde... | [No CFG could be retrieved] | region Get info of a specific tile Register screen bitmaps. | You can use `.length()` to get this. |
@@ -52,7 +52,7 @@ func (s *testUtilSuite) TestParseTimestap(c *C) {
data := uint64ToBytes(uint64(t.UnixNano()))
nt, err := parseTimestamp(data)
c.Assert(err, IsNil)
- c.Assert(nt, Equals, t)
+ c.Assert(nt.Equal(t), IsTrue)
}
data := []byte("pd")
nt, err := parseTimestamp(data)
| [TestMinDuration->[Assert],TestParseTimestap->[Int31n,UnixNano,Equal,Now,Duration,Assert,Add],TestMinUint64->[Assert],TestMaxUint64->[Assert]] | TestParseTimestap test parse timestamp. | The function Equal is in go 1.8? |
@@ -156,6 +156,12 @@ const OPTIONS x509_options[] = {
"Clears all the prohibited or rejected uses of the certificate"},
{"badsig", OPT_BADSIG, '-', "Corrupt last byte of certificate signature (for test)"},
{"", OPT_MD, '-', "Any supported digest"},
+#ifndef OPENSSL_NO_SM2
+ {"sm2-id", OPT_SM2ID, 's',... | [No CFG could be retrieved] | Parse the X509v3 spec and return the index of the certificate. Private methods for reading the EVP - PKEY configuration file. | There is `-sigopt` already, no need to make the SM2 id special |
@@ -275,6 +275,12 @@ var ngOptionsDirective = ['$compile', '$parse', function($compile, $parse) {
var label = displayFn(scope, locals);
watchedArray.push(label);
}
+
+ // Only need to watch the disableWhenFn if there is a specific disable expression
+ if (match[4])... | [No CFG could be retrieved] | Creates an object that can be used to provide the value of a property in the options list function to create an option object for the . | @petebacondarwin - I rebased your perf and mimicked it with the disableWhenFn |
@@ -1347,7 +1347,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
*/
@Restricted(DoNotUse.class) // WebOnly
public HttpResponse doPlugins() {
- Jenkins.get().checkPermission(Jenkins.ADMINISTER);
+ Jenkins.get().checkPermission(Jenkins.SYSTEM_READ);
... | [PluginManager->[createDefault->[create],doPlugins->[getDisplayName],install->[start,install,getPlugin],dynamicLoad->[dynamicLoad],getPlugin->[getPlugin,getPlugins],PluginUpdateMonitor->[ifPluginOlderThenReport->[getPlugin]],addDependencies->[addDependencies],start->[run],loadDetachedPlugins->[loadPluginsFromWar],getPl... | List all available plugins. | Pretty sure this is only used during the setup wizard, so doesn't need the permission check changed. |
@@ -140,7 +140,7 @@ public class DependencyResolver {
public ArtifactResult resolveArtifact(Artifact artifact) throws ArtifactResolutionException {
checkNotNull(artifact, "artifact cannot be null");
- final ArtifactRequest request = new ArtifactRequest(artifact, resolutionContext.getRemoteRepositories(), n... | [DependencyResolver->[readArtifactDescriptor->[readArtifactDescriptor],resolveArtifact->[resolveArtifact],setAuthentication->[setAuthentication]]] | Resolve an artifact. | Should this be called with resolveRepositories(resolutionContext.getRemoteRepositories()) |
@@ -35,6 +35,7 @@ from .constants import *
import time
import random
import string
+import site
from pathlib import Path
| [set_remote_config->[get_log_path,set_trial_config],set_experiment->[get_log_path],print_log_content->[get_log_path],start_rest_server->[get_log_path],set_trial_config->[get_log_path],resume_experiment->[launch_experiment],create_experiment->[launch_experiment],set_pai_config->[get_log_path,set_trial_config],set_local_... | generate stdout and stderr log path. | line 37's 'import string' is duplicated with lin 25's 'import string' |
@@ -127,6 +127,10 @@ public class TestExecuteProcess {
fail();
}
+ final List<MockFlowFile> flowFiles = runner.getFlowFilesForRelationship(ExecuteProcess.REL_SUCCESS);
+ if(!flowFiles.isEmpty()) {
+ assertTrue(flowFiles.get(0).getAttribute("command").equals("ping"));
+ ... | [TestExecuteProcess->[testNotRedirectErrorStream->[getProcessor,onTrigger,newTestRunner,size,sleep,getProcessContext,getWarnMessages,setupExecutor,getFlowFilesForRelationship,isCommandFailed,setProperty,getProcessSessionFactory,updateScheduledTrue,assertEquals],testSplitArgs->[assertNotNull,assertTrue,size,toArray,get,... | This method checks if the ExecuteProcess is running and if it is then the caller should be Checks if there is a problem with reading the flow files. | Nit: there should be a space between the if and the ( |
@@ -801,12 +801,6 @@ dfuse_fs_init(struct dfuse_info *dfuse_info,
fs_handle->dpi_info = dfuse_info;
- /* Max read and max write are handled differently because of the way
- * the interception library handles reads vs writes
- */
- fs_handle->dpi_max_read = 1024 * 1024 * 4;
- fs_handle->dpi_max_write = 1024 * 10... | [No CFG could be retrieved] | This function will insert the given into the hash table. region FSHandle methods. | To avoid the fallback to 4K, shall we still set it on older kernels based on proto_major/minor value or any other means? |
@@ -1351,6 +1351,8 @@ class _BaseEpochs(ProjMixin, ContainsMixin, UpdateChannelsMixin,
epoch = self._data[idx]
else: # from disk
epoch_noproj = self._get_epoch_from_raw(idx)
+ if epoch_noproj is None: # Dropped due to bad segment
+ ... | [EpochsArray->[__init__->[_detrend_offset_decim,drop_bad_epochs]],combine_event_ids->[copy],equalize_epoch_counts->[drop_epochs,drop_bad_epochs],_BaseEpochs->[equalize_event_counts->[drop_epochs,copy,_key_match,drop_bad_epochs],plot_drop_log->[plot_drop_log],_get_data->[_get_epoch_from_raw,_detrend_offset_decim,_is_goo... | Load all data from the database and drop bad epochs along the way. Get the data of a single object given a base - order index. | Why do you need this? The following two functions should already have this short-circuit builtin IIRC so this is less DRY |
@@ -186,7 +186,7 @@ public class JwtService {
* @throws JwtException if there is a problem with the token input
* @throws Exception if there is an issue logging the user out
*/
- public void logOut(String token) {
+ public void logOut(String token) throws LogoutException {
Jws<Claims> c... | [JwtService->[logOutUsingAuthHeader->[logOut],logOut->[parseTokenFromBase64EncodedString]]] | Log out the user. | As a subclass of `RuntimeException`, `LogoutException` does not need to be declared. |
@@ -568,10 +568,6 @@ func (c *readonlyCollection) Watch() (watch.Watcher, error) {
return watch.NewWatcher(c.ctx, c.etcdClient, c.prefix, c.prefix, c.template)
}
-func (c *readonlyCollection) WatchWithPrev() (watch.Watcher, error) {
- return watch.NewWatcherWithPrev(c.ctx, c.etcdClient, c.prefix, c.prefix, c.templ... | [GetBlock->[Path],get->[Get],indexPath->[indexDir],getIndexPath->[indexPath],Create->[Put,Get,Path],GetByIndex->[indexDir,Get],Count->[get],indexDir->[indexRoot],Get->[get,Path,Get],Delete->[getIndexPath,Get,getMultiIndexPaths,Path],DeleteAll->[indexRoot],WatchByIndex->[indexDir,get,Path,Watch],DecrementBy->[Put,Get,Pa... | Watch returns a watcher that will watch the contents of the collection. watch. WatchCallback for any unhandled events. | As much as I love seeing code being deleted. This seems like a reasonable method to have, even if it's no longer being used. |
@@ -844,7 +844,7 @@ func (e *Env) GetDisplayRawUntrustedOutput() bool {
func (e *Env) GetAutoFork() bool {
// On !Darwin, we auto-fork by default
- def := (runtime.GOOS != "darwin")
+ def := (RuntimeGroup() != keybase1.RuntimeGroup_DARWINLIKE)
return e.GetNegBool(def,
[]NegBoolFunc{
{
| [GetGpgHome->[GetGpgHome,GetString,GetConfig,GetHome],GetInfoDir->[GetString],GetPvlKitFilename->[GetString,GetConfig,GetPvlKitFilename],GetGUILogFile->[GetLogDir,GetString,GetGUILogFile],GetLevelDBNumFiles->[getEnvInt,GetConfig,GetInt],GetGpg->[GetString,GetConfig,GetGpg],GetExtraNetLogging->[GetBool,GetConfig,getEnvB... | GetAutoFork returns true if the user is trying to auto - fork the process. | This is irrelevant for iOS |
@@ -40,8 +40,8 @@ class JavaCompileSettingsPartitioningTest(NailgunTaskTestBase):
return Revision.lenient(version)
def _task_setup(self, targets, platforms=None, default_platform=None, **options):
- options['source'] = options.get('source', '1.7')
- options['target'] = options.get('target', '1.7')
+ ... | [JavaCompileSettingsPartitioningTest->[test_independent_targets->[_java,_partition,_version,assert_partitions_equal,_platforms],test_single_target->[_platforms,_java,_version,_partition],_partition->[_task_setup],_get_zinc_arguments->[_format_zinc_arguments],test_valid_source_target_combination->[_java,_settings_and_ta... | Setup task for missing target. | NB: I intentionally changed these to use `13` instead of `1.13` because JVM dropped the leading `1.` in version strings starting with Java 9. |
@@ -149,7 +149,7 @@ Doorkeeper.configure do
# `grant_type` - the grant type of the request (see Doorkeeper::OAuth)
# `scopes` - the requested scopes (see Doorkeeper::OAuth::Scopes)
#
- # use_refresh_token
+ use_refresh_token
# Provide support for an owner to be assigned to each registered application (d... | [orm,admin?,belongs_to,authenticate!,resource_owner_authenticator,configure,head,base_controller,admin_authenticator] | This function is used to provide a hash of all the possible access tokens and their associated secrets missing scopes - scopes to be used in the authentication process. | I'm cool with this, just wanted to ask what prompted you to enable it |
@@ -338,7 +338,7 @@ namespace Dynamo.PackageManager
return Directory.EnumerateFiles(RootDirectory, "*", SearchOption.AllDirectories).Any(s => s == path);
}
- internal bool InUse(DynamoModel dynamoModel)
+ public bool InUse(DynamoModel dynamoModel)
{
return (Lo... | [Package->[Log->[Log],UninstallCore->[MarkForUninstall]]] | Checks if a file is in the DynamoModel. | Why are these internal methods required outside? Can we implement the utilities methods in this projects itself so that we don't have to make these internal methods public. |
@@ -2067,9 +2067,9 @@ public class QueryManagerImpl extends MutualExclusiveIdsManagerBase implements Q
sb.and("display", sb.entity().isDisplayVolume(), SearchCriteria.Op.EQ);
sb.and("state", sb.entity().getState(), SearchCriteria.Op.EQ);
sb.and("stateNEQ", sb.entity().getState(), SearchCriter... | [QueryManagerImpl->[searchForIsosInternal->[searchForTemplatesInternal],searchForServiceOfferingsInternal->[getMinimumCpuServiceOfferingJoinSearchCriteria,getMinimumCpuSpeedServiceOfferingJoinSearchCriteria,findRelatedDomainIds,getMinimumMemoryServiceOfferingJoinSearchCriteria],buildAffinityGroupSearchCriteria->[buildA... | Internal method to perform a search for volumes. This method is used to find all the volumes in the system that are part of the current Creates a search criteria for volumes. find volume join by ids. | Then we won't need this change |
@@ -193,7 +193,6 @@ class Paraview(CMakePackage):
'-DVTK_USE_SYSTEM_HDF5:BOOL=%s' % variant_bool('+hdf5'),
'-DVTK_USE_SYSTEM_JPEG:BOOL=ON',
'-DVTK_USE_SYSTEM_LIBXML2:BOOL=ON',
- '-DVTK_USE_SYSTEM_MPI4PY:BOOL=%s' % variant_bool('+python+mpi'),
'-DVTK_USE_SYS... | [Paraview->[cmake_args->[nvariant_bool->[variant_bool],nvariant_bool,variant_bool]]] | Populate cmake arguments for ParaView. Add flags to cmake args to set a missing if it is not present. Returns a new instance of the class that will be used to create the class. | This can be simplified if you move it down into the "enable python" block, then you only need to check `if '+mpi' in spec` |
@@ -78,6 +78,9 @@ the dependencies"""
subparser.add_argument(
'--overwrite', action='store_true',
help="reinstall an existing spec, even if it has dependents")
+ subparser.add_argument(
+ '--keep-failures', action='store_true',
+ help="don't remove previous install failure marks ... | [install->[default_log_file,update_kwargs_from_args,install_spec,add_cdash_args]] | Setup the arguments for the command line parser. Adds command line options for a single . Add cash arguments to the parser. | (minor) I think `--keep-*` might be confusing because we have a couple other `--keep` arguments that control what type of cleanup this process does at the end - `--keep-failures` determines cleanup in the beginning. I think `--use-prior-failures` would be clearer. |
@@ -86,11 +86,10 @@ public class NullDereferenceCheck extends SECheck {
ProgramState programState = context.getState();
Constraint constraint = programState.getConstraint(currentVal);
if (constraint != null && constraint.isNull()) {
- List<JavaFileScannerContext.Location> secondary = new ArrayList<>... | [NullDereferenceCheck->[checkPostStatement->[isNull,getState,reportIssue,getName,peekValue,addTransition,is,createSink,setNullConstraint],checkConstraint->[isNull,addConstraint,getState,reportIssue,getConstraint,getName,add,Location,syntaxNode],isAnnotatedCheckForNull->[isAnnotatedWith],checkMemberSelect->[name,getStat... | Checks if a constraint is not null. | #flow is static, should be called in static way (i.e. SECheck.flow ) |
@@ -2237,7 +2237,7 @@ static FnCallResult FnCallMergeData(EvalContext *ctx, FnCall *fp, Rlist *args)
return FnFailure();
}
- SeqAppend(containers, RvalContainerValue(rval));
+ SeqAppend(containers, (void *)value);
VarRefDestroy(ref);
}
| [No CFG could be retrieved] | This function extracts a variable reference from a container variable and merges it into a list of containers Get the element from the first and second containers. | Is there a good reason why SeqAppend can't change its signature ? |
@@ -1,5 +1,5 @@
/*
- * Copyright 2019 Confluent Inc.
+ * Copyright 2020 Confluent Inc.
*
* Licensed under the Confluent Community License (the "License"; you may not use
* this file except in compliance with the License. You may obtain a copy of the
| [LatestByOffset->[latest->[aggregate->[createStruct],initialize->[createStruct]]]] | Creates an object from a given base - integer integer long string boolean boolean boolean boolean boolean boolean This class returns the most recent value for the column computed by offset. | please don't update existing copyright dates |
@@ -5,15 +5,12 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.Collections;
-import java.util.Comparator;
import java.util.Iterator;
import java.util.List;
import java.util.ListIterator;
import java.util.NoSuchElementException;
import java.util.Spliterator;
... | [ImmutableList->[ImmutableArrayList->[toString->[toString],ImmutableListIterator->[previous->[getInternal,hasPrevious],next->[getInternal,hasNext]],spliterator->[spliterator]],Builder->[addAll->[addAll],add->[add],build->[copyOf]]]] | Produces an immutable list of the given elements. Create a builder that builds a list of elements from a collection. | Do we still need this class? What about using `List.of`? |
@@ -1117,8 +1117,8 @@ public final class FilePath implements SerializableOnlyOverRemoting {
* <strong>Warning:</strong> implementations must be serializable, so prefer a static nested class to an inner class.
*
* <p>
- * Subtypes would likely want to extend from either {@link MasterToSlaveCallable... | [FilePath->[UntarFrom->[invoke->[extract]],unzip->[FilePath,unzip],AbstractInterceptorCallableWrapper->[call->[call],getClassLoader->[getClassLoader]],ValidateAntFileMask->[invoke->[equals],hasMatch->[isCaseSensitive->[isCaseSensitive,Cancel]]],UnzipLocal->[invoke->[getRemote,unzip]],copyTo->[copyTo,write,act],LastModi... | Copy the data from a file item into this object. The SecureFileCallable class is a base class that can be used to execute a secure file. | I think this was wrong before, since this discusses `FileCallable`s. |
@@ -54,9 +54,6 @@ namespace System.Text.Json.Serialization
}
/// <inheritdoc />
- [DynamicDependency(
- "#ctor(System.Text.Json.Serialization.Converters.EnumConverterOptions,System.Text.Json.JsonNamingPolicy,System.Text.Json.JsonSerializerOptions)",
- typeof(EnumConverte... | [JsonStringEnumConverter->[JsonConverter->[Public,MakeGenericType,Instance,CreateInstance],CanConvert->[IsEnum],AllowStrings,AllowNumbers]] | Dynamic dependency. | Why was this removed? Is the linker recognizing these dependencies now? |
@@ -4,6 +4,8 @@
/* jshint unused:false */
( function() {
+ var $ = jQuery;
+
/**
* Displays console notifications.
*
| [No CFG could be retrieved] | Displays a tagline notice for a specific user and displays all notifications in console. Anchor to dismiss the notice. | I think this is not the way to alias `jQuery` as `$`. ``` ( function( $ ) { // Code.... }( jQuery ) ); |
@@ -279,6 +279,10 @@ public final class HllCount {
public <K> Combine.PerKey<K, InputT, byte[]> perKey() {
return Combine.perKey(initFn);
}
+
+ public HllCountInitFn<InputT, ?> asUdaf() {
+ return initFn;
+ }
}
}
| [HllCount->[MergePartial->[globally->[globally],perKey->[perKey]],Init->[forBytes->[forBytes],Builder->[globally->[globally],perKey->[perKey]]]]] | Returns a Combine. PerKey instance if this Combine is initialized with the initial key. | nit: You might have this return `Combine.CombineFn` and make it package private (drop the `public`)? |
@@ -41,6 +41,8 @@ class Article < ApplicationRecord
class_name: "Comment"
has_many :profile_pins, as: :pinnable, inverse_of: :pinnable
has_many :buffer_updates, dependent: :destroy
+ has_many :html_variant_successes, dependent: :nullify
+ has_many :html_variant_trials, dependent: :nullify
has_man... | [Article->[username->[username],evaluate_front_matter->[set_tag_list],update_notifications->[update_notifications],readable_edit_date->[edited?]]] | A model that associates a user with an organization and a collection of articles. Validate the video. | As the relation is optional between those two, I thought it best to nullify the key. Let me know if they should be destroyed instead |
@@ -101,7 +101,7 @@ module Repository
# Static method: Creates a new repository at given location; returns
# an AbstractRepository instance, with the repository opened.
- def self.create(connect_string)
+ def self.create(connect_string, course)
raise NotImplementedError, "Repository::create Not... | [AbstractRepository->[redis_exclusive_lock->[to_s],get_all_permissions->[visibility_hash],update_permissions_after->[update_permissions],get_users->[get_full_access_users]]] | Creates a new repository. | Lint/UnusedMethodArgument: Unused method argument - connect_string. If it's necessary, use _ or _connect_string as an argument name to indicate that it won't be used. You can also write as create(*) if you want the method to accept any arguments but don't care about them.<br>Lint/UnusedMethodArgument: Unused method arg... |
@@ -480,6 +480,10 @@ public class SideInputContainerTest {
invocation -> {
Object callback = invocation.getArguments()[3];
final Runnable callbackRunnable = (Runnable) callback;
+ // Removing unused variable throws new errorprone warnings: FutureReturnValueIgnored... | [SideInputContainerTest->[withViewsForViewNotInContainerFails->[toString],isReadyInEmptyReaderThrows->[toString],getOnReaderForViewNotInReaderFails->[toString]]] | Invoke a callback that will be invoked when the latch is available. | Let's suppress the other warnings rather than suppressing unused - those warnings better indicate the problem here. |
@@ -49,7 +49,10 @@ public class RunningDatanodeState implements DatanodeState {
private final SCMConnectionManager connectionManager;
private final Configuration conf;
private final StateContext context;
- private CompletionService<EndpointStateMachine.EndPointStates> ecs;
+ private CompletionService<EndPoin... | [RunningDatanodeState->[await->[computeNextContainerState]]] | This class is used to handle the case where a SCM is running. Executes one or more tasks that are needed by this state. | Shouldn't this be `state` instead of `endpoint.getState()`? Assuming the endpoint state is constant during initialization, wouldn't this create several instances of the same type (eg. `RegisterEndpointTask`) for each endpoint? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.