hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
2100cf6357825882f538e4457381204dd742bd8d
|
diff --git a/packages/views/src/lib/buildPugLocals.js b/packages/views/src/lib/buildPugLocals.js
index <HASH>..<HASH> 100644
--- a/packages/views/src/lib/buildPugLocals.js
+++ b/packages/views/src/lib/buildPugLocals.js
@@ -32,7 +32,7 @@ export const buildPugLocals = ({packageJson, helmetContent, ...passedLocals}) =>
const locals = {
environment: process.env.NODE_ENV || "local",
assetUrl,
- logger: config.has("logger") ? JSON.stringify(config.get("logger")) : null,
+ logger: config.has("logger") ? JSON.stringify(config.get("logger")) : JSON.stringify(null),
sentryDsn: config.has("sentry.dsn") ? config.get("sentry.dsn") : null,
gtmContainerId: config.has("gtm.container.id") ? config.get("gtm.container.id") : null,
gaPropertyId: config.has("ga.property.id") ? config.get("ga.property.id") : null,
|
fix(views): Need to `JSON.stringify` this `null` Pug local value.
Since Pug'll just burn in an empty string into the HTML, which is bad.
|
randytarampi_me
|
train
|
js
|
402d7ba226d918e714ffa31e2b4a7250beb30309
|
diff --git a/packages/hoc-input/src/formInput.test.js b/packages/hoc-input/src/formInput.test.js
index <HASH>..<HASH> 100644
--- a/packages/hoc-input/src/formInput.test.js
+++ b/packages/hoc-input/src/formInput.test.js
@@ -15,9 +15,12 @@ describe("formInput", function() {
const value = "some value";
const component = shallow(<EnhancedInput value={value} />);
+ const setStateMock = jest.fn();
+ component.instance().setState = setStateMock;
+
component.setProps({ value });
- expect(component.state().value).toEqual(value);
+ expect(setStateMock.mock.calls.length).toBe(0);
});
test("changing the value property should update value state", function() {
|
test(formInput): mock setState so test can be more reliable
affects: @crave/farmblocks-hoc-input
ISSUES CLOSED: #<I>
|
CraveFood_farmblocks
|
train
|
js
|
9b141771d9f095e20a4e391dd4f648adc7b54e12
|
diff --git a/src/components/source.js b/src/components/source.js
index <HASH>..<HASH> 100644
--- a/src/components/source.js
+++ b/src/components/source.js
@@ -136,11 +136,12 @@ module.exports = class ComponentSource extends Source {
}
let layoutContext = yield this.resolve(layout.context);
let layoutContent = yield layout.getContent();
- layoutContext = _.defaults(layoutContext, context || {});
+ layoutContext = _.defaults(layoutContext, context || {});
layoutContext[this.setting('yield')] = content;
- return this.engine().render(layout.viewPath, layoutContent, layoutContext);
+ const renderMethod = (typeof this.engine().renderLayout === 'function') ? 'renderLayout' : 'render';
+ return this.engine()[renderMethod](layout.viewPath, layoutContent, layoutContext);
}
-
+
statusInfo(handle) {
const statuses = this.setting('statuses');
const defaultStatus = this.setting('default.status')
|
feat(components): Defer layout rendering to adapters if available
|
frctl_fractal
|
train
|
js
|
56e82b71435bb82d6a5d7f3f3f080dcde8786281
|
diff --git a/test/helpers/cilium.go b/test/helpers/cilium.go
index <HASH>..<HASH> 100644
--- a/test/helpers/cilium.go
+++ b/test/helpers/cilium.go
@@ -721,12 +721,14 @@ func (s *SSHMeta) ServiceGetFrontendAddress(id int) (string, error) {
// ServiceGetIds returns an array with the IDs of all Cilium services. Returns
// an error if the IDs cannot be retrieved
func (s *SSHMeta) ServiceGetIds() ([]string, error) {
- filter := `{range [*]}{@.ID}{end}`
+ filter := `{range [*]}{@.ID}{"\n"}{end}`
res, err := s.ServiceList().Filter(filter)
if err != nil {
return nil, err
}
- return strings.Split(res.String(), "\n"), nil
+ // trim the trailing \n
+ trimmed := strings.Trim(res.String(), "\n")
+ return strings.Split(trimmed, "\n"), nil
}
// ServiceDel is a wrapper around `cilium service delete <id>`. It returns the
|
test: ServiceGetIds jsonpath is splittable
We accidentally concatenated all the IDs into one unsplittable number.We
introduce the \n needed to split the list.
|
cilium_cilium
|
train
|
go
|
716969c01377538116c8ebcd32c4ee8887f14063
|
diff --git a/src/config/prettier.config.js b/src/config/prettier.config.js
index <HASH>..<HASH> 100644
--- a/src/config/prettier.config.js
+++ b/src/config/prettier.config.js
@@ -2,4 +2,5 @@ module.exports = {
semi: false,
singleQuote: true,
trailingComma: 'es5',
+ proseWrap: 'always',
}
|
fix(prettier): include proseWrap: always in Prettier config
|
macklinu_mdu-scripts
|
train
|
js
|
a65e99b3a29df6b6253b6bd0adef6e8e59619e5c
|
diff --git a/src/Exscriptd/Config.py b/src/Exscriptd/Config.py
index <HASH>..<HASH> 100644
--- a/src/Exscriptd/Config.py
+++ b/src/Exscriptd/Config.py
@@ -29,7 +29,7 @@ from Exscriptd.util import find_module_recursive
from Exscriptd.xml import get_accounts_from_etree, add_accounts_to_etree
default_config_dir = os.path.join('/etc', 'exscriptd')
-default_logdir = os.path.join('/var', 'log', 'exscriptd')
+default_log_dir = os.path.join('/var', 'log', 'exscriptd')
cache = {}
def cache_result(func):
@@ -47,7 +47,7 @@ class Config(ConfigReader):
self.cfg_dir = cfg_dir
self.service_dir = os.path.join(cfg_dir, 'services')
filename = os.path.join(cfg_dir, 'main.xml')
- self.logdir = default_logdir
+ self.logdir = default_log_dir
ConfigReader.__init__(self, filename, resolve_variables)
logdir_elem = self.cfgtree.find('exscriptd/logdir')
|
fix: exscriptd-config would not find default log dir.
|
knipknap_exscript
|
train
|
py
|
ac612e6d7496211237cc24ec826b2a021d6f52b2
|
diff --git a/components/Button/components/GenericButton.js b/components/Button/components/GenericButton.js
index <HASH>..<HASH> 100644
--- a/components/Button/components/GenericButton.js
+++ b/components/Button/components/GenericButton.js
@@ -12,7 +12,7 @@ type GenericProps = {|
form: boolean,
reversed: boolean,
icon?: SvgAsset,
- onClick?: MouseEvent => void,
+ onClick?: MouseEvent => any,
href?: string,
type?: 'submit' | 'reset',
automationId?: string,
|
fix(Button): Allow async functions to be used in onClick without Flow errors
|
cultureamp_cultureamp-style-guide
|
train
|
js
|
4f89c6060e635122868e767dba12e11c54699aca
|
diff --git a/lib/topologies/shared.js b/lib/topologies/shared.js
index <HASH>..<HASH> 100644
--- a/lib/topologies/shared.js
+++ b/lib/topologies/shared.js
@@ -425,11 +425,22 @@ const isRetryableWritesSupported = function(topology) {
*
* @param {ClientSession} session
*/
-const incrementTransactionNumber = function(session) {
+function incrementTransactionNumber(session) {
session.serverSession.txnNumber++;
};
/**
+ * Increment the statement id on the ServerSession contained by the provided ClientSession
+ *
+ * @param {ClientSession} session the client sessions
+ * @param {Number} [operationCount] the number of operations performed
+ */
+function incrementStatementId(session, operationCount) {
+ operationCount = operationCount || 1;
+ session.serverSession.stmtId += operationCount;
+};
+
+/**
* Relays events for a given listener and emitter
*
* @param {EventEmitter} listener the EventEmitter to listen to the events for
@@ -454,4 +465,5 @@ module.exports.Interval = Interval;
module.exports.Timeout = Timeout;
module.exports.isRetryableWritesSupported = isRetryableWritesSupported;
module.exports.incrementTransactionNumber = incrementTransactionNumber;
+module.exports.incrementStatementId = incrementStatementId;
module.exports.relayEvents = relayEvents;
|
refactor(shared): provide common method for incrementing stmtId
|
mongodb-js_mongodb-core
|
train
|
js
|
15491529ae33cce84349cf19e06afc553182f484
|
diff --git a/docs/conf.py b/docs/conf.py
index <HASH>..<HASH> 100644
--- a/docs/conf.py
+++ b/docs/conf.py
@@ -20,6 +20,7 @@
import gettext
import os
import sys
+import traceback
from os import path
import sphinxcontrib.plantuml
@@ -321,7 +322,12 @@ def setup(self):
locale_dir = os.path.join(package_dir, 'locale')
print("locale_dir exists:", os.path.exists(locale_dir), locale_dir)
print(locale.init([locale_dir], self.config.language, MESSAGE_CATALOG_NAME))
- print(gettext.find(MESSAGE_CATALOG_NAME, locale_dir, [self.config.language], all=True))
+ try:
+ print(gettext.find(MESSAGE_CATALOG_NAME, locale_dir, [self.config.language], all=True))
+ except Exception as e:
+ print("gettext.find emits", e)
+ traceback.print_exc(limit=2, file=sys.stdout)
+
self.add_message_catalog(MESSAGE_CATALOG_NAME, locale_dir)
self.add_message_catalog("sphinx", locale_dir)
self.config.language = conversion.get(self.config.language, self.config.language)
|
docs: rtd translation debug 1
|
blueset_ehForwarderBot
|
train
|
py
|
9911f886eaa10c238154b02668ebdddca2bc31fe
|
diff --git a/engine/watcher.go b/engine/watcher.go
index <HASH>..<HASH> 100644
--- a/engine/watcher.go
+++ b/engine/watcher.go
@@ -113,10 +113,10 @@ func (self *JobWatcher) AddJobWatch(watch *job.JobWatch) bool {
if len(sched) > 0 {
self.scheduler.FinalizeSchedule(&sched, self.machines, self.registry)
- log.Printf("Submitting schedule to Registry", watch.Payload.Name)
+ log.Printf("Submitting schedule: %s", sched.String())
self.submitSchedule(sched)
} else {
- log.Printf("No schedule changes made", watch.Payload.Name)
+ log.Printf("No schedule changes made")
}
return true
@@ -167,7 +167,7 @@ func (self *JobWatcher) TrackMachine(m *machine.Machine) {
}
if len(partial) > 0 {
- log.Printf("Submitting schedule")
+ log.Printf("Submitting schedule: %s", partial.String())
self.submitSchedule(partial)
}
}
|
fix(engine): clean up logging
|
coreos_fleet
|
train
|
go
|
29cae7725b886327cd4b8a476e495045becf866c
|
diff --git a/lib/workers/repository/onboarding/pr/pr-list.js b/lib/workers/repository/onboarding/pr/pr-list.js
index <HASH>..<HASH> 100644
--- a/lib/workers/repository/onboarding/pr/pr-list.js
+++ b/lib/workers/repository/onboarding/pr/pr-list.js
@@ -42,7 +42,7 @@ function getPrList(config) {
if (!upgrade.isPin) {
prDesc += `from \`${upgrade.currentVersion}\` `;
}
- prDesc += `to \`${upgrade.newVersion}\``;
+ prDesc += `to \`${upgrade.newVersion || upgrade.newDigest}\``;
prDesc += '\n';
}
}
|
fix: show newDigest for docker digest pinning in onboarding PR
|
renovatebot_renovate
|
train
|
js
|
ec3100b94bda8cc8d953bf81aaac15eaef0990f0
|
diff --git a/packages/core/src/plugins/input/chain.js b/packages/core/src/plugins/input/chain.js
index <HASH>..<HASH> 100644
--- a/packages/core/src/plugins/input/chain.js
+++ b/packages/core/src/plugins/input/chain.js
@@ -49,11 +49,13 @@ class ChainParser {
} else {
return []
}
- } else {
+ } else if (this.options.target === '@csl/list+object') {
return this.data.map(this.options.generateGraph
? entry => applyGraph(entry, this.graph)
: removeGraph
)
+ } else {
+ return this.data
}
}
}
|
fix(core): fix post-processing with 'target' set
|
citation-js_citation-js
|
train
|
js
|
c81dd349bebef31ace1b9cc8b55b8709af582e9a
|
diff --git a/cpenv/api.py b/cpenv/api.py
index <HASH>..<HASH> 100644
--- a/cpenv/api.py
+++ b/cpenv/api.py
@@ -573,7 +573,14 @@ def _init():
configured_repos = read_config('repos', {})
for name, config in configured_repos.items():
repo_cls = repos.registry[config.pop('type')]
- add_repo(repo_cls(**config))
+ try:
+ add_repo(repo_cls(**config))
+ except Exception as e:
+ warnings.warn('Failed to create %s named %s\nError: %s' % (
+ type(repo_cls).__name__,
+ config['name'],
+ str(e),
+ ))
# Set _active_modules from CPENV_ACTIVE_MODULES
unresolved = []
|
fix: _init failed when Repo construction raised
|
cpenv_cpenv
|
train
|
py
|
0add9248ede2cada31df6154c6cc6496f29a771e
|
diff --git a/src/Computed.js b/src/Computed.js
index <HASH>..<HASH> 100644
--- a/src/Computed.js
+++ b/src/Computed.js
@@ -86,12 +86,10 @@ export class Computed {
class ComputedFactory {
constructor (paths, func) {
if (
- !paths ||
- (
- !isObject(paths) &&
- typeof paths !== 'function'
+ !(
+ isObject(paths) ||
+ typeof paths === 'function'
) ||
- !func ||
typeof func !== 'function'
) {
throwError('You are not passing the correct arguments to the computed factory')
|
style(computed): simplify if clause for maintainability
|
cerebral_cerebral
|
train
|
js
|
0338c322fed01c6a87aa07cfcb48d2913cfbafcf
|
diff --git a/packages/select/src/Select.js b/packages/select/src/Select.js
index <HASH>..<HASH> 100644
--- a/packages/select/src/Select.js
+++ b/packages/select/src/Select.js
@@ -84,6 +84,12 @@ const Select = ({
const [newOptions, setNewOptions] = useState([]);
+ let _cacheUniq = attributes.cacheUniq;
+
+ if (!Array.isArray(_cacheUniq)) {
+ _cacheUniq = [_cacheUniq];
+ }
+
const getOptionLabel = (option) => {
if (option.__isNew__) {
return option.label;
@@ -296,6 +302,7 @@ const Select = ({
components={components}
options={selectOptions}
defaultOptions={waitUntilFocused ? [] : true}
+ cacheUniqs={_cacheUniq}
styles={{
...styles,
placeholder: (provided, state) => {
|
fix(select): ensure cacheUniq is an array and rename to cacheUniqs
|
Availity_availity-react
|
train
|
js
|
7e5382ffda62323f2f2ae92ad18a3f55bfd1dd6d
|
diff --git a/packages/@vue/cli-service-global/lib/util.js b/packages/@vue/cli-service-global/lib/util.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-service-global/lib/util.js
+++ b/packages/@vue/cli-service-global/lib/util.js
@@ -3,9 +3,31 @@ const path = require('path')
exports.toPlugin = id => ({ id, apply: require(id) })
+// Based on https://stackoverflow.com/questions/27367261/check-if-file-exists-case-sensitive
+// Case checking is required, to avoid errors raised by case-sensitive-paths-webpack-plugin
+function fileExistsWithCaseSync (filepath) {
+ const dir = path.dirname(filepath)
+
+ if (dir === '/' || dir === '.') {
+ return true
+ }
+
+ try {
+ const filenames = fs.readdirSync(dir)
+ if (!filenames.includes(path.basename(filepath))) {
+ return false
+ }
+ } catch (e) {
+ // dir does not exist
+ return false
+ }
+
+ return fileExistsWithCaseSync(dir)
+}
+
exports.findExisting = (context, files) => {
for (const file of files) {
- if (fs.existsSync(path.join(context, file))) {
+ if (fileExistsWithCaseSync(path.join(context, file))) {
return file
}
}
|
fix: `findExisting` should be case sensitive
closes #<I>
We have added `case-sensitive-paths-webpack-plugin` to the base config.
So the filename of instant prototyping entry should also be case-sensitive.
|
vuejs_vue-cli
|
train
|
js
|
ca539fce03b668f1d7dc0cab63ffae7f98058e3a
|
diff --git a/qa/performance-tests-engine/src/main/java/org/camunda/bpm/qa/performance/engine/framework/report/HtmlReportBuilder.java b/qa/performance-tests-engine/src/main/java/org/camunda/bpm/qa/performance/engine/framework/report/HtmlReportBuilder.java
index <HASH>..<HASH> 100644
--- a/qa/performance-tests-engine/src/main/java/org/camunda/bpm/qa/performance/engine/framework/report/HtmlReportBuilder.java
+++ b/qa/performance-tests-engine/src/main/java/org/camunda/bpm/qa/performance/engine/framework/report/HtmlReportBuilder.java
@@ -107,7 +107,7 @@ public class HtmlReportBuilder {
.endElement();
}
- if(jsonSourceFileName != null && jsonSourceFileName != null) {
+ if(jsonSourceFileName != null) {
sourceRow.startElement(new HtmlElementWriter("span").textContent(" | ")).endElement();
}
|
chore(qa): Duplicate subexpressions in HtmlReportBuilder
`jsonSourceFileName != null` is repeated
|
camunda_camunda-bpm-platform
|
train
|
java
|
9c1328442ce4a07a8ac8aa7211c389da68c6c5d1
|
diff --git a/ipyvolume/pylab.py b/ipyvolume/pylab.py
index <HASH>..<HASH> 100644
--- a/ipyvolume/pylab.py
+++ b/ipyvolume/pylab.py
@@ -337,7 +337,7 @@ def plot(x, y, z, color=default_color, **kwargs):
"""
fig = gcf()
_grow_limits(x, y, z)
- scatter = ipv.Scatter(x=x, y=y, z=z, color=color, color_selected=color_selected,
+ scatter = ipv.Scatter(x=x, y=y, z=z, color=color, color_selected=None,
size_selected=1, size=1,
connected=True, visible_markers=False, visible_lines=True, **kwargs)
fig.scatters = fig.scatters + [scatter]
|
fix: plot: default color_selected set to None
|
maartenbreddels_ipyvolume
|
train
|
py
|
7fee9db7df7251876e09757246c2e82ea08b7840
|
diff --git a/angular-toggle-switch.js b/angular-toggle-switch.js
index <HASH>..<HASH> 100644
--- a/angular-toggle-switch.js
+++ b/angular-toggle-switch.js
@@ -24,7 +24,7 @@ angular.module('toggle-switch', ['ng']).directive('toggleSwitch', function () {
});
attrs.$observe('disabled', function(val) {
- $scope.disabled = angular.isDefined(val) ? true : false
+ $scope.disabled = angular.isDefined(val) ? true : false;
});
$scope.toggle = function toggle() {
|
chore: Add semicolon at end of line
|
cgarvis_angular-toggle-switch
|
train
|
js
|
fea79b5b783b0f1f4b83fb8a06180dc63eebfab2
|
diff --git a/src/Leevel/Di/Container.php b/src/Leevel/Di/Container.php
index <HASH>..<HASH> 100644
--- a/src/Leevel/Di/Container.php
+++ b/src/Leevel/Di/Container.php
@@ -869,21 +869,15 @@ class Container implements IContainer, ArrayAccess
*/
protected function parseClosureReflection(Closure $injection): array
{
- $reflection = new ReflectionFunction($injection);
-
- return $reflection->getParameters();
+ return (new ReflectionFunction($injection))->getParameters();
}
/**
* 解析数组回调反射参数.
- *
- * @param array|callback $injection
*/
protected function parseMethodReflection(callable $injection): array
{
- $reflection = new ReflectionMethod($injection[0], $injection[1]);
-
- return $reflection->getParameters();
+ return (new ReflectionMethod($injection[0], $injection[1]))->getParameters();
}
/**
|
fix(di): fix for phpstan level 2
|
hunzhiwange_framework
|
train
|
php
|
0105ad99dc266e72ccb9bdc276aaedf3723c5db5
|
diff --git a/lib/endpoint-with-defaults.js b/lib/endpoint-with-defaults.js
index <HASH>..<HASH> 100644
--- a/lib/endpoint-with-defaults.js
+++ b/lib/endpoint-with-defaults.js
@@ -1,6 +1,7 @@
module.exports = endpointWithDefaults
const merge = require('deepmerge')
+const isPlainObject = require('is-plain-object')
const urlTemplate = require('url-template')
const addQueryParameters = require('./add-query-parameters')
@@ -23,7 +24,7 @@ function endpointWithDefaults (defaults, route, options) {
}, {})
}
- options = merge.all([defaults, options].filter(Boolean))
+ options = merge.all([defaults, options].filter(Boolean), { isMergeableObject: isPlainObject })
// https://fetch.spec.whatwg.org/#methods
let method = options.method.toUpperCase()
@@ -75,9 +76,11 @@ function endpointWithDefaults (defaults, route, options) {
}
// Only return body/request keys if present
- return Object.assign(
+ const funk = Object.assign(
{ method, url, headers },
typeof body !== 'undefined' ? { body } : null,
options.request ? { request: options.request } : null
)
+
+ return funk
}
|
fix: only merge simple objects (e.g. keep options.request.agent instance intact)
|
octokit_endpoint.js
|
train
|
js
|
430ddddc97cf94d2b7e9d7ff1d6f5f707bbb22fc
|
diff --git a/src/primitives/IllustrationPrimitive/index.js b/src/primitives/IllustrationPrimitive/index.js
index <HASH>..<HASH> 100644
--- a/src/primitives/IllustrationPrimitive/index.js
+++ b/src/primitives/IllustrationPrimitive/index.js
@@ -35,6 +35,7 @@ export const StyledImage = styled.img.attrs(({ theme, size, illustrationName })
max-width: 100%;
background-color: ${({ theme }) => theme.orbit.backgroundIllustration};
margin-bottom: ${getSpacingToken};
+ flex-shrink: 0;
`;
StyledImage.defaultProps = {
|
fix(IllustrationPrimitive): defaulting flex shrink to false (#<I>)
There is a issue when Illustration has a parent with flex properties, causing it to shrink unnecessary. The issue was spotted on Firefox, but not on Chrome, so browsers seem to behave inconsistently when it comes to flex items with `max-width`.
|
kiwicom_orbit-components
|
train
|
js
|
ea53d6f516d6b2e12c6c4e25fb9515d1e6470854
|
diff --git a/server/src/test/java/org/cloudfoundry/identity/uaa/security/CsrfAwareEntryPointAndDeniedHandlerTest.java b/server/src/test/java/org/cloudfoundry/identity/uaa/security/CsrfAwareEntryPointAndDeniedHandlerTest.java
index <HASH>..<HASH> 100644
--- a/server/src/test/java/org/cloudfoundry/identity/uaa/security/CsrfAwareEntryPointAndDeniedHandlerTest.java
+++ b/server/src/test/java/org/cloudfoundry/identity/uaa/security/CsrfAwareEntryPointAndDeniedHandlerTest.java
@@ -62,7 +62,7 @@ public class CsrfAwareEntryPointAndDeniedHandlerTest {
AccessDeniedException ex = new MissingCsrfTokenException("something");
handler.handle(request, response, ex);
assertEquals(HttpServletResponse.SC_FORBIDDEN, response.getStatus());
- assertEquals("{\"error\":\"Could not verify the provided CSRF token because no token was found to compare.\"}", response.getContentAsString());
+ assertEquals("{\"error\":\"" + ex.getMessage() + "\"}", response.getContentAsString());
assertNull(response.getErrorMessage());
}
|
refactor: no need to test spring lib exeception message string
- the exception message string of MissingCsrfTokenException will
change soon & might change again in the future. There is no need
for us to assert on the exact string, which will require us to update
this assertion whenever the spring lib code change.
- instead just assert that we return whatever exception message
that is attached to spring's MissingCsrfTokenException
[this is in preparation for bumping spring boot to <I>]
|
cloudfoundry_uaa
|
train
|
java
|
95e55621e46bf55039c0a04772447ddaaaf71dc9
|
diff --git a/formbuilder/views/fields/body-captcha.php b/formbuilder/views/fields/body-captcha.php
index <HASH>..<HASH> 100644
--- a/formbuilder/views/fields/body-captcha.php
+++ b/formbuilder/views/fields/body-captcha.php
@@ -1 +1 @@
-<?=$captcha->html?>
\ No newline at end of file
+<?=$captcha->getHtml()?>
\ No newline at end of file
|
fix: Captcha is now an object
|
nails_module-form-builder
|
train
|
php
|
5d4f6ac8ea50b167091dc5e0a4f372f8c15ef1b4
|
diff --git a/packages/cozy-client/examples/albums-relationships.js b/packages/cozy-client/examples/albums-relationships.js
index <HASH>..<HASH> 100644
--- a/packages/cozy-client/examples/albums-relationships.js
+++ b/packages/cozy-client/examples/albums-relationships.js
@@ -13,9 +13,9 @@ class HasManyReferenced extends HasMany {
static query(doc, client, assoc) {
if (
- !doc['relationships'] ||
- !doc['relationships']['referenced_by'] ||
- !doc['relationships']['referenced_by']['data']
+ !doc.relationships ||
+ !doc.relationships.referenced_by ||
+ !doc.relationships.referenced_by.data
) {
return null
}
|
refactor: Use dot instead of brackets
|
cozy_cozy-client
|
train
|
js
|
a02f5b93559a0d0b6dd11f298fa09d0b613b30ec
|
diff --git a/cloudvolume/datasource/precomputed/metadata.py b/cloudvolume/datasource/precomputed/metadata.py
index <HASH>..<HASH> 100644
--- a/cloudvolume/datasource/precomputed/metadata.py
+++ b/cloudvolume/datasource/precomputed/metadata.py
@@ -626,10 +626,10 @@ Hops:
self.info['scales'] = self.info['scales'][0:1]
def add_resolution(self, res, encoding=None, chunk_size=None, info=None):
- if isinstance(res[0], float):
+ if lib.floating(res):
factor = Vec(*res, dtype=float) / self.resolution(0)
else:
- factor = Vec(*res, dtype=float) // self.resolution(0)
+ factor = Vec(*res) // self.resolution(0)
return self.add_scale(factor, encoding, chunk_size, info)
|
fix(resolution): integer resolution accidently converted to float
|
seung-lab_cloud-volume
|
train
|
py
|
9e85e80089a6b67f9533fbbc34cf44eea537f9f8
|
diff --git a/assets/js/log.js b/assets/js/log.js
index <HASH>..<HASH> 100644
--- a/assets/js/log.js
+++ b/assets/js/log.js
@@ -208,9 +208,6 @@
}
function stringify(obj) {
- if (obj === undefined) {
- return 'undefined';
- }
if (!obj) {
return obj + '';
}
|
refactor: Output null&undefined
|
avwo_whistle
|
train
|
js
|
ea60745dbd510046fce4365f7375dfe5c2c4cd48
|
diff --git a/ui/src/components/table/table-body.js b/ui/src/components/table/table-body.js
index <HASH>..<HASH> 100644
--- a/ui/src/components/table/table-body.js
+++ b/ui/src/components/table/table-body.js
@@ -57,6 +57,7 @@ export default {
}
if (this.$listeners['row-click'] !== void 0) {
+ data.class['cursor-pointer'] = true
data.on = {
click: evt => {
this.$emit('row-click', evt, row)
|
feat(QTable): Auto add 'cursor-pointer' class on tr when there is a 'row-click' listener (on grid this must be added by hand) #<I> (#<I>)
|
quasarframework_quasar
|
train
|
js
|
01c26fc6dfa65913fa1ea1e2be78f2de6f36b839
|
diff --git a/src/RedisClustr.js b/src/RedisClustr.js
index <HASH>..<HASH> 100644
--- a/src/RedisClustr.js
+++ b/src/RedisClustr.js
@@ -79,8 +79,8 @@ RedisClustr.prototype.getClient = function(port, host, master) {
err.code === 'NR_CLOSED' ||
/Redis connection to .* failed.*/.test(err.message)
) {
- // broken connection so force a new client to be created (node_redis will reconnect other errors)
- if (err.code === 'CONNECTION_BROKEN') self.connections[name] = null;
+ // broken/closed connection so force a new client to be created (node_redis should reconnect other errors)
+ if (err.code === 'CONNECTION_BROKEN' || err.code === 'NR_CLOSED') self.connections[name] = null;
self.emit('connectionError', err, cli);
self.getSlots();
return;
|
fix: discard client on NR_CLOSED errors, node-redis doesn't reconnect
|
gosquared_redis-clustr
|
train
|
js
|
67aa1391c12013aae70e08f5bbabb94e74b10a6d
|
diff --git a/src/utils.js b/src/utils.js
index <HASH>..<HASH> 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -81,9 +81,9 @@ function proxyCustomImporters(importers, loaderContext) {
return [].concat(importers).map(
(importer) =>
function proxyImporter(...args) {
- this.webpackLoaderContext = loaderContext;
+ const self = { ...this, webpackLoaderContext: loaderContext };
- return importer.apply(this, args);
+ return importer.apply(self, args);
}
);
}
|
fix: crash in custom importers with worker threads (#<I>)
|
webpack-contrib_sass-loader
|
train
|
js
|
3753317d82e901e440ae8850641415c734c282f2
|
diff --git a/packages/@vue/cli-test-utils/createTestProject.js b/packages/@vue/cli-test-utils/createTestProject.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-test-utils/createTestProject.js
+++ b/packages/@vue/cli-test-utils/createTestProject.js
@@ -3,6 +3,8 @@ const path = require('path')
const execa = require('execa')
module.exports = function createTestProject (name, preset, cwd, initGit) {
+ delete process.env.VUE_CLI_SKIP_WRITE
+
cwd = cwd || path.resolve(__dirname, '../../test')
const projectRoot = path.resolve(cwd, name)
|
test: allow generateWithPlugin & createTestProject to be invoked in the same file
|
vuejs_vue-cli
|
train
|
js
|
ca26b94fa03c487e313dba034165fb59eab8554c
|
diff --git a/src/dnd-service.js b/src/dnd-service.js
index <HASH>..<HASH> 100644
--- a/src/dnd-service.js
+++ b/src/dnd-service.js
@@ -50,6 +50,10 @@ html, body {
box-shadow: 0 0 16px gray;
}
+.bcx-dnd-preview .bcx-dnd-preview-hide {
+ visible: hidden !important;
+}
+
.bcx-dnd-hide {
display: none !important;
}
|
feat: support class .bcx-dnd-preview-hide to hide some node in .bcx-dnd-preview.
|
buttonwoodcx_bcx-aurelia-dnd
|
train
|
js
|
eb69534bb6ce6c70c21e8b33f6050546d49a2c87
|
diff --git a/websocket_server/websocket_server.py b/websocket_server/websocket_server.py
index <HASH>..<HASH> 100644
--- a/websocket_server/websocket_server.py
+++ b/websocket_server/websocket_server.py
@@ -233,11 +233,11 @@ class WebSocketHandler(StreamRequestHandler):
payload_length = struct.unpack(">Q", self.rfile.read(8))[0]
masks = self.read_bytes(4)
- decoded = ""
- for char in self.read_bytes(payload_length):
- char ^= masks[len(decoded) % 4]
- decoded += chr(char)
- opcode_handler(self, decoded)
+ message_bytes = bytearray()
+ for message_byte in self.read_bytes(payload_length):
+ message_byte ^= masks[len(message_bytes) % 4]
+ message_bytes.append(message_byte)
+ opcode_handler(self, message_bytes.decode('utf8'))
def send_message(self, message):
self.send_text(message)
|
fix:read_next_message() when recv chinese
we can't decode message form payload byte by byte. some payload like Chinese word encode by utf-8 need 3 bytes to
indicate one char. so, collect all bytes from payload and decode them at one time may be better.
|
Pithikos_python-websocket-server
|
train
|
py
|
69636dfe09eaf99633c797660e846aad18954357
|
diff --git a/boyle/nifti/read.py b/boyle/nifti/read.py
index <HASH>..<HASH> 100644
--- a/boyle/nifti/read.py
+++ b/boyle/nifti/read.py
@@ -157,12 +157,6 @@ def niftilist_to_array(img_filelist, outdtype=None):
List of absolute file paths to nifti files. All nifti files must have
the same shape.
- smoothmm: int
- Integer indicating the size of the FWHM Gaussian smoothing kernel you
- would like for smoothing the volume before flattening it.
- Need FSL and nipype.
- See smooth_volume() source code.
-
outdtype: dtype
Type of the elements of the array, if not set will obtain the dtype from
the first nifti file.
|
fix: nifti/read: fix doctoring
|
Neurita_boyle
|
train
|
py
|
9d3f10b9c97ca89b1a04b1027f84c0b886d79bb3
|
diff --git a/p2p/transport/tcp/tcp.go b/p2p/transport/tcp/tcp.go
index <HASH>..<HASH> 100644
--- a/p2p/transport/tcp/tcp.go
+++ b/p2p/transport/tcp/tcp.go
@@ -6,6 +6,7 @@ import (
"net"
"os"
"runtime"
+ "syscall"
"time"
"github.com/libp2p/go-libp2p-core/network"
@@ -45,7 +46,7 @@ func tryKeepAlive(conn net.Conn, keepAlive bool) {
//
// But there's nothing we can do about invalid arguments, so we'll drop this to a
// debug.
- if errors.Is(err, os.ErrInvalid) {
+ if errors.Is(err, os.ErrInvalid) || errors.Is(err, syscall.EINVAL) {
log.Debugw("failed to enable TCP keepalive", "error", err)
} else {
log.Errorw("failed to enable TCP keepalive", "error", err)
|
fix: drop raw EINVAL (from keepalives) errors as well (#<I>)
It _looks_ like the standard library doesn't always wrap this error.
fixes #<I>
|
libp2p_go-libp2p
|
train
|
go
|
d2e0ee70ad790999e61f4d4e31341062146cbcbf
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -11,9 +11,26 @@ export function AggregateError(message: string, innerError?: Error, skipIfAlread
return innerError;
}
- if (innerError.stack) {
- message += `\n------------------------------------------------\ninner error: ${innerError.stack}`;
+ const separator = '\n------------------------------------------------\n';
+
+ message += `${separator}Inner Error:\n`;
+
+ if (typeof(innerError) === 'string' ) {
+ message += `Message: ${innerError}`;
+ } else {
+ if (innerError.message) {
+ message += `Message: ${innerError.message}`;
+ } else {
+ message += `Unknown Inner Error Type. Displaying Inner Error as JSON:\n ${JSON.stringify(innerError, null, ' ')}`;
+ }
+
+ if (innerError.stack) {
+ message += `\nInner Error Stack:\n${innerError.stack}`;
+ message += '\nEnd Inner Error Stack';
+ }
}
+
+ message += separator;
}
let e = new Error(message);
|
fix(AggregateError): better surface inner error information
|
aurelia_pal
|
train
|
js
|
5b2d89c88f5feadbf50aad1575f987a5fdcc09db
|
diff --git a/spec/models/booking_spec.rb b/spec/models/booking_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/models/booking_spec.rb
+++ b/spec/models/booking_spec.rb
@@ -162,7 +162,7 @@ describe Booking do
it 'should include accounts only once' do
FactoryGirl.create(:booking, debit_account: debit_account, credit_account: cash_account)
- FactoryGirl.create(:booking, debit_account: cash_account, debit_account: debit_account)
+ FactoryGirl.create(:booking, debit_account: cash_account, credit_account: debit_account)
expect(Booking.accounts.count).to eq(2)
end
end
@@ -188,7 +188,7 @@ describe Booking do
it 'should include accounts only once' do
FactoryGirl.create(:booking, debit_account: debit_account, credit_account: cash_account)
- FactoryGirl.create(:booking, debit_account: cash_account, debit_account: debit_account)
+ FactoryGirl.create(:booking, debit_account: cash_account, credit_account: debit_account)
expect(Booking.accounts.count).to eq(2)
end
end
|
test(models): fix parameters to factory call in model spec
We passed twice the same parameter in a factory call. The spec itself
was proper though.
This patch fixes the factory calls.
|
huerlisi_has_accounts
|
train
|
rb
|
ec1e04cafc08e49993f7755593b979af99b79733
|
diff --git a/lib/core/sdam/monitoring.js b/lib/core/sdam/monitoring.js
index <HASH>..<HASH> 100644
--- a/lib/core/sdam/monitoring.js
+++ b/lib/core/sdam/monitoring.js
@@ -4,8 +4,8 @@ const ServerDescription = require('./server_description').ServerDescription;
const calculateDurationInMs = require('../utils').calculateDurationInMs;
// pulled from `Server` implementation
-const STATE_DISCONNECTED = 'disconnected';
-const STATE_DISCONNECTING = 'disconnecting';
+const STATE_CLOSED = 'closed';
+const STATE_CLOSING = 'closing';
/**
* Published when server description changes, but does NOT include changes to the RTT.
@@ -180,7 +180,7 @@ function monitorServer(server, options) {
// emit an event indicating that our description has changed
server.emit('descriptionReceived', new ServerDescription(server.description.address, isMaster));
- if (server.s.state === STATE_DISCONNECTED || server.s.state === STATE_DISCONNECTING) {
+ if (server.s.state === STATE_CLOSED || server.s.state === STATE_CLOSING) {
return;
}
|
fix(monitoring): incorrect states used to determine rescheduling
|
mongodb_node-mongodb-native
|
train
|
js
|
aad66c06673e4943277f4b73be872d570c5c29a8
|
diff --git a/python_modules/dagster/dagster/core/storage/file_cache.py b/python_modules/dagster/dagster/core/storage/file_cache.py
index <HASH>..<HASH> 100644
--- a/python_modules/dagster/dagster/core/storage/file_cache.py
+++ b/python_modules/dagster/dagster/core/storage/file_cache.py
@@ -7,6 +7,7 @@ import dagster._check as check
from dagster.config import Field
from dagster.core.definitions import resource
from dagster.utils import mkdir_p
+from dagster.utils.backcompat import deprecation_warning
from .file_manager import LocalFileHandle
@@ -15,6 +16,10 @@ class FileCache(ABC):
def __init__(self, overwrite):
# Overwrite is currently only a signal to callers to not overwrite.
# These classes currently do not enforce any semantics around that
+ deprecation_warning(
+ "Support for file cache",
+ "0.15.0",
+ )
self.overwrite = check.bool_param(overwrite, "overwrite")
@abstractmethod
|
chore: mark FileCache for deprecation in <I> (#<I>)
|
dagster-io_dagster
|
train
|
py
|
219072f166312a3c8304f109ec3e97908e1102af
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -12,7 +12,7 @@ var compile = function(watch, done) {
var options = {
watch: watch,
output: {
- filename: 'smooth_scrollbar.js'
+ filename: 'angular-smooth-scrollbar.js'
},
module: {
preLoaders: [{
@@ -64,7 +64,7 @@ gulp.task('scripts:build', function() {
});
gulp.task('scripts:release', ['scripts:build'], function() {
- return gulp.src('src/index.js')
+ return gulp.src('index.js')
.pipe(compile(false))
.pipe(uglify())
.pipe(gulp.dest('dist/'));
|
chore(gulp): update workflow
|
idiotWu_angular-smooth-scrollbar
|
train
|
js
|
315ba035bf50abe1106a36968ed0e20b29ced807
|
diff --git a/test/spec.js b/test/spec.js
index <HASH>..<HASH> 100644
--- a/test/spec.js
+++ b/test/spec.js
@@ -5,9 +5,13 @@ const glob = require("glob");
const WebAssembly = require("../lib");
+const TEST_WHITELIST = ["spec/test/core/exports.wast"];
+
describe("spec", () => {
describe("watf", () => {
- const testSuites = glob.sync("spec/test/core/**/*.wast");
+ const testSuites = glob
+ .sync("spec/test/core/**/*.wast")
+ .filter(suite => TEST_WHITELIST.indexOf(suite) !== -1);
testSuites.forEach(suite => {
describe(suite, () => {
|
feat: add whitelist in spec tests
|
xtuc_webassemblyjs
|
train
|
js
|
20ea047cf2b4c13951e57187b8d050dde23c99dc
|
diff --git a/master/buildbot/test/fake/latent.py b/master/buildbot/test/fake/latent.py
index <HASH>..<HASH> 100644
--- a/master/buildbot/test/fake/latent.py
+++ b/master/buildbot/test/fake/latent.py
@@ -159,7 +159,9 @@ class ControllableLatentWorker(AbstractLatentWorker):
def stop_instance(self, build):
assert not self._controller.stopping
- assert self._controller.started or self._controller.starting
+ # TODO: we get duplicate stop_instance sometimes, this might indicate
+ # a bug in shutdown code path of AbstractWorkerController
+ # assert self._controller.started or self._controller.starting:
self._controller.started = False
self._controller.starting = False
|
test: Disable state asserts in fake latent worker shutdown path
|
buildbot_buildbot
|
train
|
py
|
732b3fb3b4bae921a32d2ff98a5146d84eb26461
|
diff --git a/xod-client/src/user/enhancer.js b/xod-client/src/user/enhancer.js
index <HASH>..<HASH> 100644
--- a/xod-client/src/user/enhancer.js
+++ b/xod-client/src/user/enhancer.js
@@ -80,6 +80,7 @@ export const authEnhancer = next => (reducer, initialState, enhancer) => {
initialState = undefined; // eslint-disable-line
}
+ let gettingDataRequest = false;
let persistedState;
let finalInitialState;
@@ -96,6 +97,7 @@ export const authEnhancer = next => (reducer, initialState, enhancer) => {
// On init: check authorization
if (hasToGetUserData(finalInitialState)) {
getUserData(store.dispatch);
+ gettingDataRequest = true;
}
// On change: write / delete cookies
@@ -129,11 +131,13 @@ export const authEnhancer = next => (reducer, initialState, enhancer) => {
const processes = getProccesses(state);
const gettingUserData = R.pipe(
filterNotFinished,
- findProcessByType(type)
+ findProcessByType(type),
+ notNil
)(processes);
- if (hasToGetUserData(state) && !gettingUserData) {
+ if (hasToGetUserData(state) && !gettingUserData && gettingDataRequest === false) {
getUserData(store.dispatch);
+ gettingDataRequest = true;
}
});
|
fix(client-auth): fix repeating requests
|
xodio_xod
|
train
|
js
|
3cdab36cecdef52f2f101cfa41dd2f5b6956c40d
|
diff --git a/src/settings.js b/src/settings.js
index <HASH>..<HASH> 100644
--- a/src/settings.js
+++ b/src/settings.js
@@ -227,22 +227,19 @@ parseCrop = function(val) {
}
parseShrink = function(val) {
- var reShrink, shrink, size
- reShrink = /^([0-9]+)x([0-9]+)(?:\s+(\d{1,2}|100)%)?$/i
- shrink = reShrink.exec($.trim(val.toLowerCase())) || []
+ const reShrink = /^([0-9]+)x([0-9]+)(?:\s+(\d{1,2}|100)%)?$/i
+ const shrink = reShrink.exec($.trim(val.toLowerCase())) || []
if (!shrink.length) {
return false
}
- size = shrink[1] * shrink[2]
+ const size = shrink[1] * shrink[2]
if (size > 5000000) {
// ios max canvas square
warnOnce(
- 'Shrinked size can not be larger than 5MP. ' +
+ 'Shrinked size larger than 5MP can not fit in maximum browser canvas size. ' +
`You have set ${shrink[1]}x${shrink[2]} (` +
`${Math.ceil(size / 1000 / 100) / 10}MP).`
)
-
- return false
}
return {
quality: shrink[3] ? shrink[3] / 100 : undefined,
|
chore: add warning about different shrink size in different browsers
|
uploadcare_uploadcare-widget
|
train
|
js
|
be32a74dcfc92d353c734a2d184d22eff38f7df2
|
diff --git a/views/js/qtiCreator/widgets/helpers/formElement.js b/views/js/qtiCreator/widgets/helpers/formElement.js
index <HASH>..<HASH> 100644
--- a/views/js/qtiCreator/widgets/helpers/formElement.js
+++ b/views/js/qtiCreator/widgets/helpers/formElement.js
@@ -13,7 +13,7 @@
* along with this program; if not, write to the Free Software
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
- * Copyright (c) 2015 (original work) Open Assessment Technologies SA;
+ * Copyright (c) 2015-2021 (original work) Open Assessment Technologies SA;
*
*/
@@ -282,7 +282,10 @@ define([
updateResponseDeclaration(element, value, options.updateCardinality);
}
- if (!value && (element.is('orderInteraction') || element.is('graphicOrderInteraction'))) {
+ if (this.disabled) {
+ // if the field is disabled, the corresponding attribute should be removed.
+ element[options.attrMethodNames.remove](name);
+ } else if (!value && (element.is('orderInteraction') || element.is('graphicOrderInteraction'))) {
element[options.attrMethodNames.remove](name); //to be removed for order interactions
} else {
element[options.attrMethodNames.set](name, value); //required
|
fix: removed upperbound value if field is disabled
|
oat-sa_extension-tao-itemqti
|
train
|
js
|
0fad116c6c2a01a8632c35db1484955a6dcc42ef
|
diff --git a/structs.go b/structs.go
index <HASH>..<HASH> 100644
--- a/structs.go
+++ b/structs.go
@@ -1213,6 +1213,7 @@ const (
ActivityTypeListening ActivityType = 2
ActivityTypeWatching ActivityType = 3
ActivityTypeCustom ActivityType = 4
+ ActivityTypeCompeting ActivityType = 5
)
// Identify is sent during initial handshake with the discord gateway.
|
feat: add ActivityTypeCompeting (5) (#<I>)
|
bwmarrin_discordgo
|
train
|
go
|
9198a1cbc186e742d0762ea54a84009a223d776f
|
diff --git a/packages/interactive-wrapper/src/interactive-wrapper.js b/packages/interactive-wrapper/src/interactive-wrapper.js
index <HASH>..<HASH> 100644
--- a/packages/interactive-wrapper/src/interactive-wrapper.js
+++ b/packages/interactive-wrapper/src/interactive-wrapper.js
@@ -61,7 +61,9 @@ class InteractiveWrapper extends Component {
if (retries) {
this.setState({ retries: retries - 1 });
setTimeout(() => {
- this.webview.reload();
+ if (this.webview) {
+ this.webview.reload();
+ }
}, 1000);
}
}
@@ -74,7 +76,9 @@ class InteractiveWrapper extends Component {
) {
// Need to handle native routing when something is clicked.
InteractiveWrapper.openURLInBrowser(data.url);
- this.webview.reload();
+ if (this.webview) {
+ this.webview.reload();
+ }
}
}
|
fix: REPLAT-<I> fix missing prop crash (#<I>)
|
newsuk_times-components
|
train
|
js
|
5c1f8825761387ea71e684faaf43e88e5d7782a3
|
diff --git a/scripts/release/index.js b/scripts/release/index.js
index <HASH>..<HASH> 100644
--- a/scripts/release/index.js
+++ b/scripts/release/index.js
@@ -38,6 +38,7 @@ cooker.cook('publish', [
cook.pushTagToRemote,
cook.createReleaseNotes(releaseNotesTemplate),
cook.createGithubRelease,
+ cook.runNpmScript('deploy'),
],
otherwise: [],
},
|
chore(release): add website deploy to master script
|
cerebral_cerebral
|
train
|
js
|
a96bb80552b4f1e1eb77a44ca5db5969de36ab17
|
diff --git a/lib/ditty/controllers/users.rb b/lib/ditty/controllers/users.rb
index <HASH>..<HASH> 100644
--- a/lib/ditty/controllers/users.rb
+++ b/lib/ditty/controllers/users.rb
@@ -44,6 +44,8 @@ module Ditty
begin
identity.save
rescue Sequel::ValidationFailed
+ raise unless request.accept? 'text/html'
+ status 400
locals = { title: heading(:new), entity: user, identity: identity }
return haml(:"#{view_location}/new", locals: locals)
end
|
fix: Failing to create a user should return <I>
|
EagerELK_ditty
|
train
|
rb
|
3848e7b7778571b400be74a668e5123814753ff9
|
diff --git a/packages/vuelidate/src/core.js b/packages/vuelidate/src/core.js
index <HASH>..<HASH> 100644
--- a/packages/vuelidate/src/core.js
+++ b/packages/vuelidate/src/core.js
@@ -256,14 +256,14 @@ function createValidationResults (rules, state, key, parentKey) {
.filter(ruleKey => result[ruleKey].$invalid.value)
.map(ruleKey => {
const res = result[ruleKey]
- return {
+ return reactive({
$propertyPath: parentKey ? `${parentKey}.${key}` : key,
$property: key,
$validator: ruleKey,
$message: res.$message,
$params: res.$params,
$pending: res.$pending
- }
+ })
})
)
|
fix(core): make $errors a reactive object
|
vuelidate_vuelidate
|
train
|
js
|
6e824b5fa25e2874d570656173c8de40f4655ef4
|
diff --git a/samples/updateViewQuery.js b/samples/updateViewQuery.js
index <HASH>..<HASH> 100644
--- a/samples/updateViewQuery.js
+++ b/samples/updateViewQuery.js
@@ -44,7 +44,7 @@ function main(
// Retrieve existing view metadata
const [metadata] = await view.getMetadata();
- // Uodate view query
+ // Update view query
metadata.view = newViewQuery;
// Set metadata
|
docs: update minor typo as per b/<I> (#<I>)
|
googleapis_nodejs-bigquery
|
train
|
js
|
e7a3d5cf8dcbcc2be04a038be3b5a9eee270fa7f
|
diff --git a/src/angular-websocket.js b/src/angular-websocket.js
index <HASH>..<HASH> 100644
--- a/src/angular-websocket.js
+++ b/src/angular-websocket.js
@@ -96,12 +96,6 @@
}
- $WebSocket.prototype.safeDigest = function safeDigest(autoApply) {
- if (autoApply && !this.scope.$$phase) {
- this.scope.$digest();
- }
- };
-
$WebSocket.prototype._readyStateConstants = {
'CONNECTING': 0,
'OPEN': 1,
@@ -117,6 +111,20 @@
$WebSocket.prototype.close = function (force) {
if (force || !this.socket.bufferedAmount) {
this.socket.close();
+ $WebSocket.prototype.safeDigest = function safeDigest(autoApply) {
+ if (autoApply && !this.scope.$$phase) {
+ this.scope.$digest();
+ }
+ };
+
+ $WebSocket.prototype.bindToScope = function bindToScope(scope) {
+ if (scope) {
+ this.scope = scope;
+ if (this.rootScopeFailover) {
+ this.scope.$on('$destroy', function() {
+ this.scope = $rootScope;
+ });
+ }
}
return this;
};
|
feat: bindToScope and safeDigest
|
PatrickJS_angular-websocket
|
train
|
js
|
fdd5189d9e1d7a1c43bcedad325f2d2f9fa96b65
|
diff --git a/google_cloud_logger/__init__.py b/google_cloud_logger/__init__.py
index <HASH>..<HASH> 100644
--- a/google_cloud_logger/__init__.py
+++ b/google_cloud_logger/__init__.py
@@ -1,5 +1,7 @@
-from datetime import datetime
import inspect
+import traceback
+from datetime import datetime
+from io import StringIO
from pythonjsonlogger.jsonlogger import JsonFormatter
@@ -57,7 +59,22 @@ class GoogleCloudFormatter(JsonFormatter):
}
return levels[level_name.upper()]
+ def make_exception(self, record):
+ with StringIO() as buf:
+ exception_info = record.exc_info
+ traceback.print_tb(exception_info[2], file=buf)
+ return {
+ "class": record.exc_info[0],
+ "message": record.exc_info[1],
+ "traceback": buf.getvalue(),
+ }
+
def make_metadata(self, record):
+ if record.exc_info:
+ return {
+ "userLabels": self.make_user_labels(record),
+ "exception": self.make_exception(record),
+ }
return {"userLabels": self.make_user_labels(record)}
def make_source_location(self, record):
|
feat: Format exceptions and tracebacks (#4)
|
rai200890_python_google_cloud_logger
|
train
|
py
|
afb25cef94df6dfcf6455200cd5baa7862b90f3c
|
diff --git a/spec/lib/session_spec.rb b/spec/lib/session_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/lib/session_spec.rb
+++ b/spec/lib/session_spec.rb
@@ -165,7 +165,7 @@ RSpec.describe Authie::Session do
original_time = session_model.expires_at
Timecop.freeze(original_time + 10.hours) { session.touch }
session.session.reload
- expect(session.expires_at).to eq original_time
+ expect(session.expires_at.to_i).to eq original_time.to_i
end
it 'does not set the expiry time' do
@@ -195,7 +195,7 @@ RSpec.describe Authie::Session do
time = session_model.created_at
Timecop.freeze(time) { session.touch }
session.session.reload
- expect(session.expires_at).to eq time + Authie.config.persistent_session_length
+ expect(session.expires_at.to_i).to eq (time + Authie.config.persistent_session_length).to_i
end
it 'updates the cookie' do
|
test: avoid timing precision issues in tests
|
adamcooke_authie
|
train
|
rb
|
0d90a860d6ee9d21504b1c32845a0ac7e26ade98
|
diff --git a/test/test.js b/test/test.js
index <HASH>..<HASH> 100644
--- a/test/test.js
+++ b/test/test.js
@@ -3,7 +3,7 @@
var rollup = require("rollup").rollup;
rollup({
- entry : "./test/specimens/entry.js",
+ input : "./test/specimens/entry.js",
plugins : [
require("../index.js")({
@@ -13,4 +13,9 @@ rollup({
})
.then((bundle) => {
bundle.generate({ format : "es" });
+})
+.catch((error) => {
+ console.error(error.toString());
+
+ process.exitCode = 1;
});
|
test: gracefully fail, update rollup usage
|
tivac_rollup-plugin-sizes
|
train
|
js
|
0f9fd55fc9ea38a2424aee3c05a5a4ddd01732c8
|
diff --git a/doc/conf.py b/doc/conf.py
index <HASH>..<HASH> 100755
--- a/doc/conf.py
+++ b/doc/conf.py
@@ -21,7 +21,11 @@ intersphinx_mapping = {
"python": ("http://python.readthedocs.io/en/latest/", None),
}
-version = release = stan.__version__
+try:
+ version = release = stan.__version__
+except AttributeError:
+ # install the package to make `stan.__version__` available
+ version = release = "unknown-dev"
################################################################################
# theme configuration
|
docs: set version correctly in development
Give sphinx a package version during development.
Previously sphinx would try to retrieve `stan.__version__`.
This is not available when the package is not installed.
(We use `importlib.metadata.version`)
Fixes exception which occurs when running `script/check`
during development.
|
stan-dev_pystan
|
train
|
py
|
838c3ceb3ffcf7ab0cce34dcffea219adc2aeee8
|
diff --git a/build/webpack.prod.config.js b/build/webpack.prod.config.js
index <HASH>..<HASH> 100644
--- a/build/webpack.prod.config.js
+++ b/build/webpack.prod.config.js
@@ -39,7 +39,7 @@ module.exports = merge(baseWebpackConfig, {
rules: [
{
test: /\.[jt]s$/,
- loaders: ['babel-loader', 'ts-loader', 'eslint-loader'],
+ loaders: ['babel-loader', 'ts-loader'],
exclude: /node_modules/
},
{
|
chore(build): don't use eslint-loader in production
|
vuetifyjs_vuetify
|
train
|
js
|
cec8eb68611c7424fa8dd233646b6bc1675e8be3
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -398,7 +398,11 @@ function mkdir(dirname, options = {}) {
assert.equal(typeof dirname, 'string', 'expected dirname to be a string');
const opts = Object.assign({ cwd: process.cwd(), fs }, options);
const segs = path.relative(opts.cwd, dirname).split(path.sep);
- const make = dir => fs.mkdirSync(dir, mode(opts));
+ const make = dir => {
+ if (!fs.existsSync(dir)) {
+ fs.mkdirSync(dir, mode(opts));
+ }
+ }
for (let i = 0; i <= segs.length; i++) {
try {
make((dirname = path.join(opts.cwd, ...segs.slice(0, i))));
|
fix: use existsSync instead on relying on mkdirSync throwing error (windows throws EPERM on 'C:\')
|
jonschlinkert_data-store
|
train
|
js
|
31843278712089287403183030192e640e827293
|
diff --git a/src/js/constants.js b/src/js/constants.js
index <HASH>..<HASH> 100644
--- a/src/js/constants.js
+++ b/src/js/constants.js
@@ -63,5 +63,5 @@ export const REGEXP_TAG_NAME = /^img|canvas$/i;
// Misc
// Inspired by the default width and height of a canvas element.
-export const MIN_CONTAINER_WIDTH = 300;
-export const MIN_CONTAINER_HEIGHT = 150;
+export const MIN_CONTAINER_WIDTH = 200;
+export const MIN_CONTAINER_HEIGHT = 100;
|
fix: revert the min container width and height
|
fengyuanchen_cropperjs
|
train
|
js
|
abc1d01d04109c1c2952256cc2b434857d891e5a
|
diff --git a/packages/@vuepress/core/lib/prepare/Page.js b/packages/@vuepress/core/lib/prepare/Page.js
index <HASH>..<HASH> 100644
--- a/packages/@vuepress/core/lib/prepare/Page.js
+++ b/packages/@vuepress/core/lib/prepare/Page.js
@@ -24,8 +24,8 @@ module.exports = class Page {
async process (markdown) {
this.key = 'v-' + Math.random().toString(16).slice(2)
- this.content = await fs.readFile(this._filePath, 'utf-8')
- const frontmatter = parseFrontmatter(this.content)
+ this._content = await fs.readFile(this._filePath, 'utf-8')
+ const frontmatter = parseFrontmatter(this._content)
// infer title
const title = inferTitle(frontmatter)
|
fix: regression - avoid deliver 'content' to client side
|
vuejs_vuepress
|
train
|
js
|
5b2e17939b04008d9db9601453b4171df061b2c1
|
diff --git a/packages/mdc-slider/addon/components/mdc-slider.js b/packages/mdc-slider/addon/components/mdc-slider.js
index <HASH>..<HASH> 100644
--- a/packages/mdc-slider/addon/components/mdc-slider.js
+++ b/packages/mdc-slider/addon/components/mdc-slider.js
@@ -69,11 +69,24 @@ export default Component.extend({
let {min, max, value, step, disabled} = this.getProperties (['min', 'max', 'value', 'step', 'disabled']);
- if (min !== this._slider.min) {
+ if (min > this._slider.max) {
+ // The new min value is greater than the current max value. We need to adjust
+ // the max value before setting the new min value. This will prevent the underlying
+ // component from throwing an exception.
+
+ this._slider.max = max;
this._slider.min = min;
}
+ else if (max < this._slider.min) {
+ // The new max value is less than the current min value. We need to adjust
+ // the min value before setting the new max value. This will prevent the underlying
+ // component from throwing an exception.
- if (max !== this._slider.max) {
+ this._slider.min = min;
+ this._slider.max = max;
+ }
+ else {
+ this._slider.min = min;
this._slider.max = max;
}
|
fix: Updating the slider failed if the min value was greater than the current max, or the max was less than the current min
|
onehilltech_ember-cli-mdc
|
train
|
js
|
f9f45ec57bf9063532ca41c896caebe35b78ea5a
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -202,7 +202,8 @@ export const sessionStoreBuilder = () => ({
if (params.cookieDomain) throw new Error('baseUrl param is deprecated, replaced with directoryUrl')
if (params.sessionDomain) throw new Error('baseUrl param is deprecated, replaced with directoryUrl')
if (!params.directoryUrl && params.directoryUrl !== '') throw new Error('directoryUrl param is required')
- commit('setAny', params)
+ const directoryUrl = params.directoryUrl.endsWith('/') ? params.directoryUrl.slice(0, -1) : params.directoryUrl
+ commit('setAny', { ...params, directoryUrl })
dispatch('readCookie')
},
readCookie({ state, commit }) {
|
fix: manage trailing slash in directoryUrl
|
koumoul-dev_sd-vue
|
train
|
js
|
8e17a2e76b7f3fdd30b2717c8f103f8767ea261c
|
diff --git a/Runnable/DispatcherStore.php b/Runnable/DispatcherStore.php
index <HASH>..<HASH> 100644
--- a/Runnable/DispatcherStore.php
+++ b/Runnable/DispatcherStore.php
@@ -147,7 +147,7 @@ abstract class DispatcherStore extends BaseStore
*/
public function dumpAction($action)
{
- echo "Action '" . $action->getName() . "'' : " . var_export($action->getProperties(), true) . "\n";
+ echo "Action '" . $action->getName() . "' : " . var_export($action->getProperties(), true) . "\n";
}
/**
|
fix(typo): remove double single quote
|
wizbii_pipeline
|
train
|
php
|
1372c2084e3019fcb48618de4d3af77281fa6ef2
|
diff --git a/plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentOpenShiftConverter.java b/plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentOpenShiftConverter.java
index <HASH>..<HASH> 100644
--- a/plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentOpenShiftConverter.java
+++ b/plugin/src/main/java/io/fabric8/maven/plugin/converter/DeploymentOpenShiftConverter.java
@@ -91,7 +91,7 @@ public class DeploymentOpenShiftConverter implements KubernetesToOpenShiftConver
specBuilder.withNewStrategy().withType("Rolling").
withNewRollingParams().withTimeoutSeconds(openshiftDeployTimeoutSeconds).endRollingParams().endStrategy();
} else if (Strings.isNotBlank(strategyType)) {
- if (strategyType.equals("Recreate")) {
+ if ("Recreate".equals(strategyType)) {
specBuilder.withNewStrategy().withType(strategyType).
withNewRecreateParams().withTimeoutSeconds(openshiftDeployTimeoutSeconds).endRecreateParams().endStrategy();
} else {
|
chore(pepperpot): unnecessary reorder to remove pepperpot warnings
I hope this pleases pepperpot.
I guess it avoids a possible NPE if the above line were to be removed
|
fabric8io_fabric8-maven-plugin
|
train
|
java
|
3cfbb36577c9a71ff2d19255749a04ba0786d984
|
diff --git a/lib/config/defaults.js b/lib/config/defaults.js
index <HASH>..<HASH> 100644
--- a/lib/config/defaults.js
+++ b/lib/config/defaults.js
@@ -22,7 +22,9 @@ function getConfig() {
const options = configDefinitions.getOptions();
const config = {};
options.forEach(option => {
- config[option.name] = getDefault(option);
+ if (!option.parents) {
+ config[option.name] = getDefault(option);
+ }
});
return config;
}
|
fix: don’t add options with parents to defaults
|
renovatebot_renovate
|
train
|
js
|
4660acd324cfa6c786245ea581691a23758ce960
|
diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js
index <HASH>..<HASH> 100644
--- a/lib/classes/PluginManager.js
+++ b/lib/classes/PluginManager.js
@@ -48,7 +48,7 @@ class PluginManager {
this.cliOptions = {};
this.cliCommands = [];
- this.pluginIndependentCommands = new Set(['plugin']);
+ this.pluginIndependentCommands = new Set(['help', 'plugin']);
this.plugins = [];
this.commands = {};
|
fix(CLI): Mark 'help' as command that doesn't depend on external plugins
|
serverless_serverless
|
train
|
js
|
8d0ab28b54161c70ca42da65f08718dc22b11ba2
|
diff --git a/Gruntfile.js b/Gruntfile.js
index <HASH>..<HASH> 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -82,7 +82,7 @@ module.exports = function (grunt) {
},
libtest: {
files: '<%= jshint.libtest.src %>',
- tasks: ['jshint:libtest', 'jscs:libtest', 'lintspaces:libtest', 'nodeunit']
+ tasks: ['jshint:libtest', 'jscs:libtest', 'lintspaces:libtest', 'build', 'test']
}
},
'release-it': {
@@ -108,6 +108,11 @@ module.exports = function (grunt) {
require('load-grunt-tasks')(grunt);
// Default task.
- grunt.registerTask('default', ['jshint', 'jscs', 'lintspaces', /*'simplemocha', */'umd:lib', 'concat', 'uglify']);
+ grunt.registerTask('default', ['lint', 'test', 'build']);
+ grunt.registerTask('build', ['umd:lib', 'concat', 'uglify']);
+
+ grunt.registerTask('test', ['simplemocha']);
+
+ grunt.registerTask('lint', ['jshint', 'jscs', 'lintspaces']);
};
|
chore(grunt): reorganize tasks
+ fix ref to nodeunit
+ on lib, test change, launch build and test tasks
|
stephanebachelier_mixit
|
train
|
js
|
a572c9c4183a6b9c7efab5c8fda56747882536aa
|
diff --git a/gulpfile.babel.js b/gulpfile.babel.js
index <HASH>..<HASH> 100755
--- a/gulpfile.babel.js
+++ b/gulpfile.babel.js
@@ -153,7 +153,7 @@ gulp.task('core-test-separately', ['prepare', 'core', 'core-dts-test'], (done) =
} else {
listOfSpecFiles = glob.sync(path.join(__dirname, 'core/src/**/*.spec.js'));
}
-
+
// Separately launch Karma server for each spec file
try {
for (let i = 0 ; i < listOfSpecFiles.length ; i++) {
@@ -174,7 +174,7 @@ gulp.task('core-test-separately', ['prepare', 'core', 'core-dts-test'], (done) =
},
(exitCode) => {
const exitMessage = `Karma server has exited with ${exitCode}`;
-
+
switch (exitCode) {
case 0: // success
$.util.log($.util.colors.green(exitMessage));
|
style(gulpfile): Removed trailing spaces.
|
OnsenUI_OnsenUI
|
train
|
js
|
7b31e76ecd8dfda9c22b585b8bf0d54ccc10870d
|
diff --git a/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/task/TaskQueryDto.java b/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/task/TaskQueryDto.java
index <HASH>..<HASH> 100644
--- a/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/task/TaskQueryDto.java
+++ b/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/task/TaskQueryDto.java
@@ -191,7 +191,7 @@ public class TaskQueryDto extends AbstractQueryDto<TaskQuery> {
private List<VariableQueryParameterDto> processVariables;
private List<VariableQueryParameterDto> caseInstanceVariables;
- private List<TaskQueryDto> orQueries = new ArrayList<TaskQueryDto>();
+ private List<TaskQueryDto> orQueries;
public TaskQueryDto() {
@@ -1368,6 +1368,7 @@ public class TaskQueryDto extends AbstractQueryDto<TaskQuery> {
TaskQueryDto dto = new TaskQueryDto();
if (!isOrQueryActive) {
+ dto.orQueries = new ArrayList<TaskQueryDto>();
for (TaskQuery orQuery: taskQuery.getOrQueries()) {
dto.orQueries.add(fromQuery(orQuery, true));
}
|
feat(rest): adds OR queries for task resource
related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
java
|
bb9640f6637ddbffff8063a51880838411531b55
|
diff --git a/test/entry.js b/test/entry.js
index <HASH>..<HASH> 100644
--- a/test/entry.js
+++ b/test/entry.js
@@ -2,3 +2,15 @@ import { jsdom } from 'jsdom';
global.document = jsdom('<!doctype html><html><body></body></html>');
global.window = document.defaultView;
+global.navigator = global.window.navigator;
+window.localStorage = window.sessionStorage = {
+ getItem(key) {
+ return this[key];
+ },
+ setItem(key, value) {
+ this[key] = value;
+ },
+ removeItem(key) {
+ this[key] = undefined;
+ },
+};
|
test(Tests): Fixing test jsdom mock
Adding navigator to test mock
|
Raathigesh_dazzle
|
train
|
js
|
14bfd72b5e50fa714b414c3021026edcc4e2962e
|
diff --git a/examples/docgen/docs/.vuepress/config.js b/examples/docgen/docs/.vuepress/config.js
index <HASH>..<HASH> 100644
--- a/examples/docgen/docs/.vuepress/config.js
+++ b/examples/docgen/docs/.vuepress/config.js
@@ -4,7 +4,7 @@ const cwd = path.join(__dirname, '..')
const { parse } = require('vue-docgen-api')
module.exports = async () => {
- const docFiles = glob.sync('components/**/*.md', { cwd }).map((f) => '/' + f)
+ const sidebar = glob.sync('components/**/*.md', { cwd }).map((f) => '/' + f)
const components = await Promise.all(
glob.sync('../src/components/**/*.{vue,js,jsx,ts,tsx}', { cwd, absolute: true }).map(async (path) => {
return {
@@ -22,8 +22,7 @@ module.exports = async () => {
dest: path.join(__dirname, '../../dist'),
title: 'VuePress DocGen Live',
themeConfig: {
- search: false,
- sidebar: docFiles
+ sidebar
},
plugins: [
['live'],
|
docs: add search to the docgen example
|
vue-styleguidist_vue-styleguidist
|
train
|
js
|
c914f6d60c043aee4b317eb0da1c87ea309708ca
|
diff --git a/packages/vaex-core/vaex/scopes.py b/packages/vaex-core/vaex/scopes.py
index <HASH>..<HASH> 100644
--- a/packages/vaex-core/vaex/scopes.py
+++ b/packages/vaex-core/vaex/scopes.py
@@ -73,6 +73,14 @@ class _BlockScope(object):
self.i2 = int(i2)
self.values = dict(self.variables)
+ def get(self, attr, default=None): # otherwise pdb crashes during pytest
+ if attr == "__tracebackhide__":
+ return False
+ return default
+
+ def __contains__(self, name): # otherwise pdb crashes during pytest
+ return name in self.buffers # not sure this should also include varibles, columns and virtual columns
+
def _ensure_buffer(self, column):
if column not in self.buffers:
logger.debug("creating column for: %s", column)
|
fix(core): pytest + pdb crashed since it uses BlockScope as frame, mock it
|
vaexio_vaex
|
train
|
py
|
484caef4f30c8a3ef12e2d97f6b02ca1223c6273
|
diff --git a/tasks/webpack.js b/tasks/webpack.js
index <HASH>..<HASH> 100644
--- a/tasks/webpack.js
+++ b/tasks/webpack.js
@@ -21,7 +21,7 @@ const configWatchPatterns = config.webpack.tsWatchPatterns.map((cPath) => path.j
const webpackWatchPatterns = [
...webpackSourcePatterns,
- configWatchPatterns
+ ...configWatchPatterns
];
if (config.webpack.watchScss) {
|
fix: 🐛 Missing destructuring (#<I>)
|
biotope_biotope-build
|
train
|
js
|
16c0858e21a3e938bea18cf827445bb38b8bf650
|
diff --git a/lib/processCss.js b/lib/processCss.js
index <HASH>..<HASH> 100644
--- a/lib/processCss.js
+++ b/lib/processCss.js
@@ -179,7 +179,7 @@ module.exports = function processCss(inputSource, inputMap, options, callback) {
]);
if(minimize) {
- var minimizeOptions = assign({}, query);
+ var minimizeOptions = assign({}, query.minimize);
["zindex", "normalizeUrl", "discardUnused", "mergeIdents", "reduceIdents", "autoprefixer"].forEach(function(name) {
if(typeof minimizeOptions[name] === "undefined")
minimizeOptions[name] = false;
|
fix: `minimizeOptions` should be `query.minimize`!
It's a mistake according to the doc.
Init `minimizeOptions` should be `query.minimize` rather than just query.
<URL>
|
webpack-contrib_css-loader
|
train
|
js
|
d57dd3f59fc752a44aa462c767565977dc18f047
|
diff --git a/src/config/webpack/index.js b/src/config/webpack/index.js
index <HASH>..<HASH> 100644
--- a/src/config/webpack/index.js
+++ b/src/config/webpack/index.js
@@ -2,6 +2,7 @@
const merge = require('webpack-merge')
const webpack = require('webpack')
+const path = require('path')
const utils = require('../../utils')
const base = require('./base')
@@ -19,7 +20,7 @@ function webpackConfig () {
],
devtool: 'source-map',
output: {
- filename: entry.split('/').pop(),
+ filename: path.basename(entry),
library: libraryName,
path: utils.getPathToDist()
},
|
fix: use rel paths on windows (#<I>)
|
ipfs_aegir
|
train
|
js
|
272161e2cb79d747d6fc08213fb6dba11aa03f86
|
diff --git a/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/modules/internal/CallsModule.java b/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/modules/internal/CallsModule.java
index <HASH>..<HASH> 100644
--- a/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/modules/internal/CallsModule.java
+++ b/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/modules/internal/CallsModule.java
@@ -130,7 +130,7 @@ public class CallsModule extends AbsModule {
//on end call update
public void onEndCall(long callId) {
- Log.d(TAG, "end call update");
+ Log.d(TAG, "end call update: " + callId);
ActorRef call = calls.get(callId);
if (call != null) {
Log.d(TAG, "call exist - end it");
@@ -143,7 +143,7 @@ public class CallsModule extends AbsModule {
//after end call update processed by CallActor
public void onCallEnded(long callId) {
- Log.d(TAG, "on callActor ended call");
+ Log.d(TAG, "on callActor ended call: " + callId);
calls.remove(callId);
}
|
chore(core): calls logging
|
actorapp_actor-platform
|
train
|
java
|
cf2ba83d66755e52d22b3ea4a9ba68ab495572d2
|
diff --git a/packages/vuetify/src/components/VMenu/mixins/menu-keyable.js b/packages/vuetify/src/components/VMenu/mixins/menu-keyable.js
index <HASH>..<HASH> 100644
--- a/packages/vuetify/src/components/VMenu/mixins/menu-keyable.js
+++ b/packages/vuetify/src/components/VMenu/mixins/menu-keyable.js
@@ -53,13 +53,6 @@ export default {
}
},
changeListIndex (e) {
- if ([
- keyCodes.down,
- keyCodes.up,
- keyCodes.enter
- ].includes(e.keyCode)
- ) e.preventDefault()
-
// For infinite scroll and autocomplete, re-evaluate children
this.getTiles()
@@ -71,7 +64,9 @@ export default {
this.listIndex--
} else if (e.keyCode === keyCodes.enter && this.listIndex !== -1) {
this.tiles[this.listIndex].click()
- }
+ } else { return }
+ // One of the conditions was met, prevent default action (#2988)
+ e.preventDefault()
},
getTiles () {
this.tiles = this.$refs.content.querySelectorAll('.v-list__tile')
|
fix(VMenu): don't prevent default on keydown unless action taken (#<I>)
* fix(VMenu): don't prevent default on keydown unless action taken
fixes #<I>
* refactor: dry up code
|
vuetifyjs_vuetify
|
train
|
js
|
c0c14e9e4c5d5566ab1e9310edfffd859ea5734a
|
diff --git a/.cz-config.js b/.cz-config.js
index <HASH>..<HASH> 100644
--- a/.cz-config.js
+++ b/.cz-config.js
@@ -12,8 +12,7 @@ module.exports = {
{value: 'test', name: 'test: Adding missing tests'},
{value: 'chore', name: 'chore: Changes to the build process or auxiliary tools\n and libraries such as documentation generation'},
{value: 'revert', name: 'revert: Revert to a commit'},
- {value: 'ts', name: 'ts: Typescript/Typings related changes'},
- {value: 'WIP', name: 'WIP: Work in progress'}
+ {value: 'ts', name: 'ts: Typescript/Typings related changes'}
],
scopes: [
|
chore: remove WIP type from cz-config
Makes more sense to mark the PR as WIP.
|
cerebral_cerebral
|
train
|
js
|
7b8a6b44f08b8d36fa7813a1299ad7431d0e9a09
|
diff --git a/conversation/src/main/java/com/ibm/watson/developer_cloud/conversation/v1/model/MessageRequest.java b/conversation/src/main/java/com/ibm/watson/developer_cloud/conversation/v1/model/MessageRequest.java
index <HASH>..<HASH> 100644
--- a/conversation/src/main/java/com/ibm/watson/developer_cloud/conversation/v1/model/MessageRequest.java
+++ b/conversation/src/main/java/com/ibm/watson/developer_cloud/conversation/v1/model/MessageRequest.java
@@ -18,7 +18,7 @@ import com.google.gson.annotations.SerializedName;
import com.ibm.watson.developer_cloud.service.model.GenericModel;
/**
- * A request formatted for the Conversation service.
+ * A message request formatted for the Conversation service.
*/
public class MessageRequest extends GenericModel {
|
docs(Conversation): Tweak class description
|
watson-developer-cloud_java-sdk
|
train
|
java
|
088e15f34985a40b4e495c517d62231beb3721e3
|
diff --git a/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java b/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
index <HASH>..<HASH> 100644
--- a/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
+++ b/core/src/main/java/org/testcontainers/containers/DockerComposeContainer.java
@@ -270,7 +270,7 @@ public class DockerComposeContainer<SELF extends DockerComposeContainer<SELF>> e
class DockerCompose extends GenericContainer<DockerCompose> {
public DockerCompose(File composeFile, String identifier) {
- super("dduportal/docker-compose:1.7.1");
+ super("docker/compose:1.8.0");
addEnv("COMPOSE_PROJECT_NAME", identifier);
// Map the docker compose file into the container
addEnv("COMPOSE_FILE", "/compose/" + composeFile.getAbsoluteFile().getName());
|
refactor: replace compose container image dduportal/docker-compose:<I> with the official docker/compose:<I>
|
testcontainers_testcontainers-java
|
train
|
java
|
017614d98510bc2e6b5b7b78ac08b4de7e2ec4de
|
diff --git a/packages/react-ui-testing/react-selenium-testing.js b/packages/react-ui-testing/react-selenium-testing.js
index <HASH>..<HASH> 100644
--- a/packages/react-ui-testing/react-selenium-testing.js
+++ b/packages/react-ui-testing/react-selenium-testing.js
@@ -470,11 +470,15 @@ function fillPropsForDomElementRecursive(attrContainer, instance) {
}
function fillPropsForDomElement(attrContainer, instance) {
- const instanceProps = instance._currentElement && instance._currentElement.props;
const componentName = getComponentName(instance);
if (componentName) {
appendToSet(attrContainer, 'data-comp-name', componentName);
}
+ const key = instance._currentElement && instance._currentElement.key;
+ if (key) {
+ appendToSet(attrContainer, 'data-key', key);
+ }
+ const instanceProps = instance._currentElement && instance._currentElement.props;
if (instanceProps) {
if (instanceProps['data-tid']) {
appendToSet(attrContainer, 'data-tid', instanceProps['data-tid']);
|
feat(react-ui-testing): prop key renders to html attribute
|
skbkontur_retail-ui
|
train
|
js
|
af7e3b1bf904d55a2ab4f2caa1fcce574528a7fd
|
diff --git a/tests/Controllers/WebhookControllerTest.php b/tests/Controllers/WebhookControllerTest.php
index <HASH>..<HASH> 100644
--- a/tests/Controllers/WebhookControllerTest.php
+++ b/tests/Controllers/WebhookControllerTest.php
@@ -83,6 +83,32 @@ class WebhookControllerTest extends TestCase
$controller = new WebhookController($config);
$controller->receive($request);
}
+
+ public function test_receive_request_is_empty()
+ {
+ $config = m::mock(Repository::class);
+ $config
+ ->shouldReceive('get')
+ ->with('fb-messenger.handlers')
+ ->andReturn([DefaultHandler::class])
+ ->shouldReceive('get')
+ ->with('fb-messenger.app_token')
+ ->shouldReceive('get')
+ ->with('fb-messenger.postbacks')
+ ->andReturn([])
+ ->shouldReceive('get')
+ ->with('fb-messenger.auto_typing')
+ ->andReturn(false);
+
+ $request = m::mock(Request::class)
+ ->shouldReceive('input')
+ ->with('entry.0.messaging')
+ ->andReturnNull()
+ ->getMock();
+
+ $controller = new WebhookController($config);
+ $controller->receive($request);
+ }
}
class HandlerNotExtendsBaseHandlerStub
|
test: Added test request is empty
|
CasperLaiTW_laravel-fb-messenger
|
train
|
php
|
c6e0289d0d05847d25e2636e7ca6175e6b95cb4c
|
diff --git a/src/lib/CollectStore.js b/src/lib/CollectStore.js
index <HASH>..<HASH> 100644
--- a/src/lib/CollectStore.js
+++ b/src/lib/CollectStore.js
@@ -1,4 +1,5 @@
/* global cozy */
+import DateFns from 'date-fns'
import * as accounts from './accounts'
import * as konnectors from './konnectors'
import * as jobs from './jobs'
@@ -56,12 +57,12 @@ export default class CollectStore {
}
// Populate the store
- fetchInitialData (domain) {
+ fetchInitialData (domain, ignoreJobsAfterInSeconds) {
return Promise.all([
this.fetchAllAccounts(),
this.fetchInstalledKonnectors(),
this.fetchKonnectorResults(),
- this.fetchKonnectorUnfinishedJobs(domain)
+ this.fetchKonnectorUnfinishedJobs(domain, ignoreJobsAfterInSeconds)
])
}
@@ -267,8 +268,9 @@ export default class CollectStore {
})
}
- fetchKonnectorUnfinishedJobs (domain) {
- return jobs.findQueuedOrRunning(cozy.client)
+ fetchKonnectorUnfinishedJobs (domain, ignoreAfterInSeconds) {
+ const limitDate = DateFns.subSeconds(new Date(), ignoreAfterInSeconds)
+ return jobs.findQueuedOrRunning(cozy.client, limitDate)
.then(jobs => {
jobs.forEach(job => {
this.updateUnfinishedJob(job)
|
feat: use limit date for jobs in CollectStore ✨
|
cozy_cozy-home
|
train
|
js
|
0bff913ffe09e10271306c4af0bec40423df8d19
|
diff --git a/bin/whistle.js b/bin/whistle.js
index <HASH>..<HASH> 100755
--- a/bin/whistle.js
+++ b/bin/whistle.js
@@ -116,7 +116,7 @@ program
.option('-S, --storage [newStorageDir]', 'the new local storage directory', String, undefined)
.option('-C, --copy [storageDir]', 'copy storageDir to newStorageDir', String, undefined)
.option('-c, --dnsCache [time]', 'the cache time of DNS (30000ms by default)', String, undefined)
- .option('-H, --host [host]', config.name + ' listening host(INADDR_ANY by default)', String, undefined)
+ .option('-H, --host [host]', config.name + ' listening host(:: or 0.0.0.0 by default)', String, undefined)
.option('-p, --port [port]', config.name + ' listening port (' + config.port + ' by default)', parseInt, undefined)
.option('-P, --uiport [uiport]', config.name + ' ui port (' + (config.port + 1) + ' by default)', parseInt, undefined)
.option('-m, --middlewares [script path or module name]', 'express middlewares path (as: xx,yy/zz.js)', String, undefined)
|
feat: Add cli -H, -host to set the listening host
|
avwo_whistle
|
train
|
js
|
f616b25693289ed9c2dbfdb298c635dce79c03ce
|
diff --git a/src/core/services/interimElement/interimElement.js b/src/core/services/interimElement/interimElement.js
index <HASH>..<HASH> 100644
--- a/src/core/services/interimElement/interimElement.js
+++ b/src/core/services/interimElement/interimElement.js
@@ -358,10 +358,14 @@ function InterimElementProvider() {
}
// Hide the latest showing interim element.
- return closeElement(showingInterims[showingInterims.length - 1]);
+ return closeElement(showingInterims.pop());
function closeElement(interim) {
+ if (!interim) {
+ return $q.when(reason);
+ }
+
var hideAction = interim
.remove(reason, false, options || { })
.catch(function(reason) { return reason; })
@@ -369,7 +373,6 @@ function InterimElementProvider() {
hidePromises.splice(hidePromises.indexOf(hideAction), 1);
});
- showingInterims.splice(showingInterims.indexOf(interim), 1);
hidePromises.push(hideAction);
return interim.deferred.promise;
|
fix(toast): remove the interim element from the list before closing element (#<I>)
|
angular_material
|
train
|
js
|
b48f6bb438a193174df569beef24d193d5cd954c
|
diff --git a/src/service/translate.js b/src/service/translate.js
index <HASH>..<HASH> 100644
--- a/src/service/translate.js
+++ b/src/service/translate.js
@@ -1389,7 +1389,7 @@ angular.module('pascalprecht.translate').provider('$translate', ['$STORAGE_KEY',
// if there isn't a translation table for the language we've requested,
// we load it asynchronously
- if (!$translationTable[key] && $loaderFactory) {
+ if (!$translationTable[key] && $loaderFactory && !langPromises[key]) {
$nextLang = key;
langPromises[key] = loadAsync(key).then(function (translation) {
translations(translation.key, translation.table);
|
fix(translateService): prevent multiple XHR calls
|
angular-translate_angular-translate
|
train
|
js
|
acb9cffe9a7a75f0e9f6ae4186544ab78e385047
|
diff --git a/spec/graphql/schema/build_from_definition_spec.rb b/spec/graphql/schema/build_from_definition_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/graphql/schema/build_from_definition_spec.rb
+++ b/spec/graphql/schema/build_from_definition_spec.rb
@@ -233,6 +233,17 @@ union U = Hello
assert_equal 63, built_schema.types["U"].ast_node.definition_line
end
+ it 'supports descriptions and definition_line' do
+ schema = <<-SCHEMA
+"""
+"""
+type Query {
+ f1: Int
+}
+ SCHEMA
+ refute_nil GraphQL::Schema.from_definition(schema)
+ end
+
it 'maintains built-in directives' do
schema = <<-SCHEMA
schema {
|
test(BuildFromDefinition): added test to confirm changes to handle frozen strings in Lexer
|
rmosolgo_graphql-ruby
|
train
|
rb
|
d2eb3b9ff5f52810067ac59969a3c4272772bdb3
|
diff --git a/storage/memory.go b/storage/memory.go
index <HASH>..<HASH> 100644
--- a/storage/memory.go
+++ b/storage/memory.go
@@ -40,7 +40,6 @@ type MemoryStore struct {
AuthorizeCodes map[string]StoreAuthorizeCode
IDSessions map[string]fosite.Requester
AccessTokens map[string]fosite.Requester
- Implicit map[string]fosite.Requester
RefreshTokens map[string]fosite.Requester
PKCES map[string]fosite.Requester
Users map[string]MemoryUserRelation
@@ -56,7 +55,6 @@ func NewMemoryStore() *MemoryStore {
AuthorizeCodes: make(map[string]StoreAuthorizeCode),
IDSessions: make(map[string]fosite.Requester),
AccessTokens: make(map[string]fosite.Requester),
- Implicit: make(map[string]fosite.Requester),
RefreshTokens: make(map[string]fosite.Requester),
PKCES: make(map[string]fosite.Requester),
Users: make(map[string]MemoryUserRelation),
|
fix(storage): remove unused field (#<I>)
Related #<I>
|
ory_fosite
|
train
|
go
|
49f35592658dcb4aba6a7d3d68879231a7fb28a8
|
diff --git a/cloudvolume/frontends/graphene.py b/cloudvolume/frontends/graphene.py
index <HASH>..<HASH> 100644
--- a/cloudvolume/frontends/graphene.py
+++ b/cloudvolume/frontends/graphene.py
@@ -443,8 +443,10 @@ class CloudVolumeGraphene(CloudVolumePrecomputed):
def get_leaves_v1(self, root_id, bbox, mip):
root_id = int(root_id)
+ api = GrapheneApiVersion("v1")
+
url = posixpath.join(
- self.meta.base_path, self.meta.api_version.path(self.meta.server_path),
+ self.meta.base_path, api.path(self.meta.server_path),
"node", str(root_id), "leaves"
)
bbox = Bbox.create(bbox, context=self.meta.bounds(mip), bounded=self.bounded)
|
fix(graphene): make sure api v1 is used in v1 specific code
|
seung-lab_cloud-volume
|
train
|
py
|
759f8da8470691df3ad71fd75f774e2a64766809
|
diff --git a/src/createDOMForm.js b/src/createDOMForm.js
index <HASH>..<HASH> 100644
--- a/src/createDOMForm.js
+++ b/src/createDOMForm.js
@@ -37,7 +37,9 @@ function getScrollableContainer(n) {
/* eslint no-cond-assign:0 */
while ((nodeName = node.nodeName.toLowerCase()) !== 'body') {
const overflowY = computedStyle(node, 'overflowY');
- if (node !== n && (overflowY === 'auto' || overflowY === 'scroll')) {
+ // https://stackoverflow.com/a/36900407/3040605
+ if (node !== n && (overflowY === 'auto' || overflowY === 'scroll') &&
+ node.scrollHeight > node.clientHeight) {
return node;
}
node = node.parentNode;
|
fix: scrollable node is not scrollable in some situations (#<I>)
close ant-design/ant-design#<I>
|
react-component_form
|
train
|
js
|
95794c571ae9c0bff7a89f7ce2faf3b19431168f
|
diff --git a/lib/macaca-reporter.js b/lib/macaca-reporter.js
index <HASH>..<HASH> 100644
--- a/lib/macaca-reporter.js
+++ b/lib/macaca-reporter.js
@@ -23,16 +23,6 @@ const totalTests = {
function done(output, options, config, failures, exit) {
try {
- if (process.env.MACACA_RUN_IN_PARALLEL) {
- output.suites.suites = output.suites.suites
- .map(item => {
- if (item.tests.length) {
- return item;
- } else {
- return item.suites[0];
- }
- });
- }
render(output, options);
outputJson(output, options);
|
fix: remove parallel (#<I>)
|
macacajs_macaca-reporter
|
train
|
js
|
cf9f8bfc43d7ef2ddf14ea80f2215644ba836b9d
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -1,7 +1,7 @@
import uniqueRandomArray from 'unique-random-array';
import starWarsNames from './starwars-names.json';
-var getRandomItem = uniqueRandomArray(starWarsNames);
+const getRandomItem = uniqueRandomArray(starWarsNames);
module.exports = {
all: starWarsNames,
@@ -12,8 +12,8 @@ function random(number) {
if (number === undefined) {
return getRandomItem();
} else {
- var randomItems = [];
- for (var i = 0; i < number; i++) {
+ const randomItems = [];
+ for (let i = 0; i < number; i++) {
randomItems.push(getRandomItem());
}
return randomItems;
|
chore: var -> const/let (#<I>)
* var -> let
since babel is already in place :smile:
* let -> const
|
kentcdodds_starwars-names
|
train
|
js
|
d3b192e3076b9465fad119703656d16d9b0277a4
|
diff --git a/packages/authorize/useAuthorize.js b/packages/authorize/useAuthorize.js
index <HASH>..<HASH> 100644
--- a/packages/authorize/useAuthorize.js
+++ b/packages/authorize/useAuthorize.js
@@ -107,6 +107,7 @@ export default (permissions,{
checkPermissions();
// todo - optimize this so we only have a permissions effect for fetching
// and the others are just filters
+ // eslint-disable-next-line react-hooks/exhaustive-deps
}, [organizationId, region, customerId, permissions]);
return [authorized,loading];
|
chore(authorize): hide warning for authorize effect
|
Availity_availity-react
|
train
|
js
|
c155fedcd47f4908d371731d74dc36d03efc7713
|
diff --git a/src/store.js b/src/store.js
index <HASH>..<HASH> 100644
--- a/src/store.js
+++ b/src/store.js
@@ -1252,7 +1252,12 @@ function store(Model, options = {}) {
return lastValue;
},
- connect: options.draft ? () => () => clear(Model, false) : undefined,
+ connect: options.draft
+ ? (host, key) => () => {
+ cache.invalidate(host, key, true);
+ clear(Model, false);
+ }
+ : undefined,
};
return desc;
|
fix(store): clear lastValue for draft mode
|
hybridsjs_hybrids
|
train
|
js
|
8492924614f495aa78f33cf4300b05e418135b5c
|
diff --git a/crd-generator/api/src/test/java/io/fabric8/crd/generator/CRDGeneratorTest.java b/crd-generator/api/src/test/java/io/fabric8/crd/generator/CRDGeneratorTest.java
index <HASH>..<HASH> 100644
--- a/crd-generator/api/src/test/java/io/fabric8/crd/generator/CRDGeneratorTest.java
+++ b/crd-generator/api/src/test/java/io/fabric8/crd/generator/CRDGeneratorTest.java
@@ -51,6 +51,8 @@ public class CRDGeneratorTest {
assertNotNull(definition);
CustomResourceDefinitionSpec spec = definition.getSpec();
CustomResourceDefinitionNames names = spec.getNames();
+
+ assertEquals("apiextensions.k8s.io/v1", definition.getApiVersion());
assertEquals("Basic", names.getKind());
assertEquals("basics", names.getPlural());
assertEquals("Namespaced", spec.getScope());
|
test: assert the crd apiVersion used
(cherry picked from commit <I>f5ace<I>c<I>dd<I>f4bb<I>accbc7e)
|
fabric8io_kubernetes-client
|
train
|
java
|
9746273b81faad17006f2532273e15e7643c6e88
|
diff --git a/source/application/transforms/react/index.js b/source/application/transforms/react/index.js
index <HASH>..<HASH> 100644
--- a/source/application/transforms/react/index.js
+++ b/source/application/transforms/react/index.js
@@ -77,7 +77,7 @@ export default function createReactCodeFactory(application) {
function createWrappedRenderFunction(file, source, resolveDependencies, opts) {
const dependencies = writeDependencyImports(file).join('\n');
- return renderCodeTemplate(source, dependencies, template, pascalCase(file.pattern.id), opts);
+ return renderCodeTemplate(source, dependencies, template, pascalCase(file.pattern.manifest.name), opts);
}
function renderCodeTemplate(source, dependencies, templateCode, className, opts) {
|
fix: use manifest.name for plain jsx class names
|
patternplate-archive_patternplate-server
|
train
|
js
|
1fc2fa5c9fe8cfa4a7b820cac90eff4d9dcbd762
|
diff --git a/examples/router/router-mock.js b/examples/router/router-mock.js
index <HASH>..<HASH> 100644
--- a/examples/router/router-mock.js
+++ b/examples/router/router-mock.js
@@ -5,6 +5,20 @@ Vue.component('RouterLink', {
tag: { type: String, default: 'a' }
},
render(createElement) {
- return createElement(this.tag, {}, this.$slots.default)
+ const href = this.$attrs.to
+ return createElement(
+ this.tag,
+ {
+ attrs: { href },
+ on: {
+ click(e) {
+ // eslint-disable-next-line no-console
+ console.log('Navigated to: ', href)
+ e.preventDefault()
+ }
+ }
+ },
+ this.$slots.default
+ )
}
})
|
docs(router): add href to examples
|
vue-styleguidist_vue-styleguidist
|
train
|
js
|
479330a49a28e4f7443982ba235d2adee3e49d58
|
diff --git a/google_auth_oauthlib/interactive.py b/google_auth_oauthlib/interactive.py
index <HASH>..<HASH> 100644
--- a/google_auth_oauthlib/interactive.py
+++ b/google_auth_oauthlib/interactive.py
@@ -166,7 +166,7 @@ def get_user_credentials(
client_config, scopes=scopes
)
- port = find_open_port()
+ port = find_open_port(start=minimum_port, stop=maximum_port)
if not port:
raise ConnectionError("Could not find open port.")
diff --git a/tests/unit/test_interactive.py b/tests/unit/test_interactive.py
index <HASH>..<HASH> 100644
--- a/tests/unit/test_interactive.py
+++ b/tests/unit/test_interactive.py
@@ -80,7 +80,7 @@ def test_get_user_credentials_raises_connectionerror(monkeypatch):
from google_auth_oauthlib import flow
from google_auth_oauthlib import interactive as module_under_test
- def mock_find_open_port():
+ def mock_find_open_port(start=8080, stop=None):
return None
monkeypatch.setattr(module_under_test, "find_open_port", mock_find_open_port)
|
fix: Pass port range from `get_user_credentials` to `find_open_port` (#<I>)
* Port range now passed in
|
googleapis_google-auth-library-python-oauthlib
|
train
|
py,py
|
2866c82cef0b028519bdc89f526462846b38da22
|
diff --git a/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java b/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java
index <HASH>..<HASH> 100644
--- a/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java
+++ b/engine-rest/engine-rest/src/test/java/org/camunda/bpm/engine/rest/util/container/TomcatServerBootstrap.java
@@ -41,7 +41,7 @@ public abstract class TomcatServerBootstrap extends EmbeddedServerBootstrap {
String contextPath = "/" + getContextPath();
PomEquippedResolveStage resolver = Maven.configureResolver()
- .useLegacyLocalRepo(true).loadPomFromFile("pom.xml");
+ .useLegacyLocalRepo(true).workOffline().loadPomFromFile("pom.xml");
WebArchive wa = ShrinkWrap.create(WebArchive.class, "rest-test.war").setWebXML(webXmlPath)
.addAsLibraries(resolver.resolve("org.codehaus.jackson:jackson-jaxrs:1.6.5").withTransitivity().asFile())
|
test(engine-rest): try harder to let shrinkwrap work offline
related to #CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
java
|
2e86cec48bf2da0fd0d1fe8de605ba73725bef61
|
diff --git a/aurelia-slickgrid/assets/lib/multiple-select/multiple-select.js b/aurelia-slickgrid/assets/lib/multiple-select/multiple-select.js
index <HASH>..<HASH> 100644
--- a/aurelia-slickgrid/assets/lib/multiple-select/multiple-select.js
+++ b/aurelia-slickgrid/assets/lib/multiple-select/multiple-select.js
@@ -670,7 +670,7 @@
}
// finally re-adjust the drop to the new calculated width when necessary
- if (maxDropWidth > currentDefinedWidth || currentDefinedWidth === '100%') {
+ if (currentDefinedWidth > maxDropWidth || this.$drop.width() > maxDropWidth || currentDefinedWidth === '100%') {
this.$drop.css({ 'width': maxDropWidth, 'max-width': maxDropWidth });
}
},
|
fix(select): multiple-select autoAdjustDropWidth sometime incorrect
|
ghiscoding_aurelia-slickgrid
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.