hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
bcb35010b0ec688733f6955ef7ad80d4aa97d3ff
diff --git a/src/Interaction/Core/MouseHandler/index.js b/src/Interaction/Core/MouseHandler/index.js index <HASH>..<HASH> 100644 --- a/src/Interaction/Core/MouseHandler/index.js +++ b/src/Interaction/Core/MouseHandler/index.js @@ -40,6 +40,10 @@ function getRelative(el, event) { } function broadcast(ctx, topic, event) { + if (!ctx.mouseEnabled) { + return; + } + event.preventDefault(); event.button = 0; @@ -67,6 +71,7 @@ export default class MouseHandler { handlerCount += 1; this.id = `mouse_handler_${handlerCount}`; + this.mouseEnabled = true; this.el = domElement; this.modifier = 0; this.toggleModifiers = [0]; @@ -89,6 +94,10 @@ export default class MouseHandler { }; this.domEventHandler = (e) => { + if (!this.mouseEnabled) { + return true; + } + e.preventDefault(); const event = { srcEvent: e, @@ -241,6 +250,10 @@ export default class MouseHandler { this.toggleModifierEnable = enable; } + setEnable(enableMouse = true) { + this.mouseEnabled = !!enableMouse; + } + attach(listeners) { var subscriptions = {}; Object.keys(listeners).forEach((key) => {
fix(MouseHandler): Add method to toggle mouse listener
Kitware_paraviewweb
train
js
828a9324b1785b028ffe7256546b14133552cde0
diff --git a/src/lib/adapter.js b/src/lib/adapter.js index <HASH>..<HASH> 100644 --- a/src/lib/adapter.js +++ b/src/lib/adapter.js @@ -63,13 +63,16 @@ /** * Filter which specs will be run by matching the start of the full name against the `spec` query param. */ - var specFilter = new jasmine.HtmlSpecFilter({ - filterString: function () { return queryString.getParam("spec"); } - }); - - config.specFilter = function (spec) { - return specFilter.matches(spec.getFullName()); - }; + var specFilter; + if (!config.specFilter || queryString.getParam("spec")) { + specFilter = new jasmine.HtmlSpecFilter({ + filterString: function () { return queryString.getParam("spec"); } + }); + + config.specFilter = function (spec) { + return specFilter.matches(spec.getFullName()); + }; + } env.configure(config);
fix: set specFilter only when needed (#<I>) * fix: set specFilter only when needed * syntax error
dfederm_karma-jasmine-html-reporter
train
js
3903e331200d2ed1259cad79d7fe601cebde0856
diff --git a/lib/operations/mongo_client_ops.js b/lib/operations/mongo_client_ops.js index <HASH>..<HASH> 100644 --- a/lib/operations/mongo_client_ops.js +++ b/lib/operations/mongo_client_ops.js @@ -114,7 +114,8 @@ const validOptionNames = [ 'useNewUrlParser', 'useUnifiedTopology', 'serverSelectionTimeoutMS', - 'useRecoveryToken' + 'useRecoveryToken', + 'autoEncryption' ]; function addListeners(mongoClient, topology) { @@ -453,8 +454,6 @@ function createTopology(mongoClient, topologyType, options, callback) { topology.s.options.autoEncrypter = new AutoEncrypter(mongoClient, mongoCryptOptions); callback(null, newTopology); }); - - callback(null, newTopology); }); }
refactor: support `autoEncryption` option in `MongoClient` ctor
mongodb_node-mongodb-native
train
js
10e47d100c39f439eb39a1e208315af93f7cc8b4
diff --git a/tests/file_test.py b/tests/file_test.py index <HASH>..<HASH> 100644 --- a/tests/file_test.py +++ b/tests/file_test.py @@ -101,7 +101,7 @@ def test_fsspec(df_trimmed): df_trimmed = df_trimmed.drop('obj') fs = fsspec.implementations.memory.MemoryFileSystem() df_trimmed.export('test.arrow', fs=fs) - assert 'test.arrow' in fs.store + assert ('test.arrow' in fs.store) or ('/test.arrow' in fs.store) # with vaex.file.open('test.txt', fs=fs) as f: # f.write('vaex') df_trimmed['test'] = df_trimmed.x + 10
fix: fsspec might prefix with a slash
vaexio_vaex
train
py
eb75434513e024081f98f15fc9e81e76928391d0
diff --git a/packages/cli-plugin-deploy-pulumi/commands/index.js b/packages/cli-plugin-deploy-pulumi/commands/index.js index <HASH>..<HASH> 100644 --- a/packages/cli-plugin-deploy-pulumi/commands/index.js +++ b/packages/cli-plugin-deploy-pulumi/commands/index.js @@ -77,8 +77,9 @@ module.exports = [ describe: `While making code changes, re-deploy cloud infrastructure`, type: "boolean" }); - yargs.option("scope", { - describe: `Override watch scope (list of packages that need to be watched for code changes)`, + yargs.option("package", { + alias: "p", + describe: `Override watch packages (list of packages that need to be watched for code changes)`, type: "string" }); yargs.option("depth", {
fix: change "scope" to "package" (with "p" alias)
Webiny_webiny-js
train
js
898ec25d9bd5a59c99e1b1e586c72a20efe20d15
diff --git a/src/platforms/mp/runtime/vdom/patch.js b/src/platforms/mp/runtime/vdom/patch.js index <HASH>..<HASH> 100644 --- a/src/platforms/mp/runtime/vdom/patch.js +++ b/src/platforms/mp/runtime/vdom/patch.js @@ -1,3 +1,4 @@ +/* istanbul ignore file */ /** * Virtual DOM patching algorithm based on Snabbdom by * Simon Friis Vindum (@paldepind)
chore: istanbul ignore mp/runtime/vdom/patch
kaola-fed_megalo
train
js
82f45bd71d42d3a3431ae0565ac4c2759b46b29d
diff --git a/src/resources/views/character/mining-ledger.blade.php b/src/resources/views/character/mining-ledger.blade.php index <HASH>..<HASH> 100644 --- a/src/resources/views/character/mining-ledger.blade.php +++ b/src/resources/views/character/mining-ledger.blade.php @@ -2,7 +2,7 @@ @section('page_header', trans_choice('web::seat.character', 1) . ' ' . trans('web::seat.mining')) -@inject('request', Illuminate\Http\Request') +@inject('request', 'Illuminate\Http\Request') @section('character_content') <div class="card">
fix: address a typo in request injection
eveseat_web
train
php
a774e5a40f3a523162076c7f69d85320cdb30411
diff --git a/ladybug/windrose.py b/ladybug/windrose.py index <HASH>..<HASH> 100644 --- a/ladybug/windrose.py +++ b/ladybug/windrose.py @@ -118,7 +118,7 @@ class WindRose(object): self._show_zeros = True self._base_point = None self._compass = None - self._north = None + self._north = self.DEFAULT_NORTH # Fixed properties that only need to be computed once self._bin_vectors = None @@ -250,8 +250,6 @@ class WindRose(object): This must be a number between -360 and 360. 0 is North, 90 is West and 270 is East. """ - if self._north is None: - self._north = self.DEFAULT_NORTH return self._north @north.setter @@ -597,7 +595,8 @@ class WindRose(object): # This formula is to reduce mesh size based on fractional increases: #if ytick_dist_inc > curr_bar_radius: - # ytick_dist_inc = ((i - 1) * ytick_dist) + (ytick_dist_inc % curr_bar_radius) + # ytick_dist_inc = \ + # ((i - 1) * ytick_dist) + (ytick_dist_inc % curr_bar_radius) ytick_dist_inc += min_bar_radius
fix(windrose): Style changes to _north and comment block.
ladybug-tools_ladybug
train
py
18796173ab5cec2cf3111f71542e7173c41370b2
diff --git a/packages/babel-core/src/transformation/normalize-file.js b/packages/babel-core/src/transformation/normalize-file.js index <HASH>..<HASH> 100644 --- a/packages/babel-core/src/transformation/normalize-file.js +++ b/packages/babel-core/src/transformation/normalize-file.js @@ -24,10 +24,28 @@ export default function normalizeFile( let inputMap = null; if (options.inputSourceMap !== false) { + // Check if sourceMap is inline inputMap = convertSourceMap.fromSource(code); + + // Remove inline sourceMap from code if (inputMap) { code = convertSourceMap.removeComments(code); - } else if (typeof options.inputSourceMap === "object") { + } + + // if source map is not inline check if it's an external file + if (!inputMap) { + try { + inputMap = convertSourceMap.fromMapFileSource(code); + } catch (err) {} + + // remove external sourceMappingUrl from code + if (inputMap) { + code = convertSourceMap.removeMapFileComments(code); + } + } + + // If no sourceMap is found and a user provides it use that + if (!inputMap && typeof options.inputSourceMap === "object") { inputMap = convertSourceMap.fromObject(options.inputSourceMap); } }
feat(sourcemap): parse external source maps when normalizing (#<I>)
babel_babel
train
js
f7ceb4d54835eae9ebb14bbc1ed40420444b7b57
diff --git a/build/build.transforms.js b/build/build.transforms.js index <HASH>..<HASH> 100644 --- a/build/build.transforms.js +++ b/build/build.transforms.js @@ -23,6 +23,10 @@ function camelCase (name) { return out.charAt(0).toUpperCase() + out.substr(1) } +function lowerCamelCase (name) { + return name.replace(/-([a-z])/g, g => g[1].toUpperCase()) +} + function isExternalUtil (name) { return !['escape-key', 'modal-fn', 'popup', 'sort', 'router-link', 'is', 'noop', 'web-storage'].includes(name) } @@ -71,7 +75,7 @@ function addUtils (map) { .forEach(file => { const name = getWithoutExtension(path.basename(file)) if (isExternalUtil(name)) { - map[name === 'open-url' ? 'openURL' : name] = file + map[name === 'open-url' ? 'openURL' : lowerCamelCase(name)] = file } }) }
fix: [<I> beta] frameDebounce seems to be undefined #<I>
quasarframework_quasar
train
js
b2e49af7a876f82521a581ea35afeaa4091456dd
diff --git a/package.js b/package.js index <HASH>..<HASH> 100644 --- a/package.js +++ b/package.js @@ -15,13 +15,13 @@ Package.onUse(function (api) { 'angular@1.0.0', 'angular:angular-messages@1.4.7', 'angular:angular-material@0.11.4', - 'wieldo:angular-formly@7.3.2' + 'formly:angular-formly@7.3.9' ], imply: [ 'angular:angular@1.4.7', 'angular:angular-messages', 'angular:angular-material', - 'wieldo:angular-formly' + 'formly:angular-formly' ] };
chore: move to formly:angular-formly BREAKING CHANGE: wieldo:angular-formly@<I> is now replaced with formly:angular-formly@<I>
formly-js_angular-formly-templates-material
train
js
0cecf8a04ff7bc4f803b495ab8e351a700baf3ca
diff --git a/src/utils.js b/src/utils.js index <HASH>..<HASH> 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,3 +1,4 @@ +// like _.min export function min(arr) { return arr.map((item) => +item) .filter((item) => Number.isInteger(item))
refactor(utils): add commit for function.
TossShinHwa_node-odata
train
js
d4b67cc7703acaf076f7ecb6e714456b0ac2c661
diff --git a/rollup.config.js b/rollup.config.js index <HASH>..<HASH> 100644 --- a/rollup.config.js +++ b/rollup.config.js @@ -8,6 +8,12 @@ const pkg = require('./package.json'); export default { input: 'src/moltin.js', + external: [ + 'cuid', + 'es6-promise', + 'fetch-everywhere', + 'inflected', + ], plugins: [ resolve({ browser: true, @@ -22,12 +28,6 @@ export default { json(), ], output: [{ - external: [ - 'es6-promise', - 'fetch-everywhere', - 'inflected', - 'uuid', - ], file: pkg['cjs:main'], exports: 'named', format: 'cjs', @@ -37,6 +37,5 @@ export default { exports: 'named', format: 'umd', name: 'moltin', - context: 'self', }], };
fix: Declare CUID an external dependency (#<I>)
moltin_js-sdk
train
js
b35c446ebe8a254f62a6571ceab48a3663d8c8b0
diff --git a/src/mixins/maskable.js b/src/mixins/maskable.js index <HASH>..<HASH> 100644 --- a/src/mixins/maskable.js +++ b/src/mixins/maskable.js @@ -84,7 +84,7 @@ export default { setCaretPosition (selection) { this.selection = selection window.setTimeout(() => { - this.$refs.input.setSelectionRange(this.selection, this.selection) + this.$refs.input && this.$refs.input.setSelectionRange(this.selection, this.selection) }, 0) }, updateRange () {
fix: don't setSelectionRange if the input doesn't exist any more Fixes #<I>
vuetifyjs_vuetify
train
js
c3a1bc1500302766017736811251070c908ac580
diff --git a/models/classes/preview/ItemPreviewerService.php b/models/classes/preview/ItemPreviewerService.php index <HASH>..<HASH> 100644 --- a/models/classes/preview/ItemPreviewerService.php +++ b/models/classes/preview/ItemPreviewerService.php @@ -33,9 +33,9 @@ use oat\tao\model\modules\DynamicModule; class ItemPreviewerService extends ConfigurableService { const SERVICE_ID = 'taoItems/ItemPreviewer'; - const REGISTRY_ENTRY_KEY = 'taoItems/previewer/factory'; - const PREVIEWERS_KEY = 'previewers'; - const PLUGINS_KEY = 'plugins'; + private const REGISTRY_ENTRY_KEY = 'taoItems/previewer/factory'; + private const PREVIEWERS_KEY = 'previewers'; + private const PLUGINS_KEY = 'plugins'; private $registry;
refactor: use private constants for registry internals
oat-sa_extension-tao-item
train
php
68660adf926c41410a58482be860a418c8c60b43
diff --git a/lib/Editor.js b/lib/Editor.js index <HASH>..<HASH> 100644 --- a/lib/Editor.js +++ b/lib/Editor.js @@ -77,9 +77,14 @@ Editor.prototype.open = Promise.method(function (givenPath) { }); Editor.prototype.save = Promise.method(function (path) { var self = this; - return Promise.resolve() - .then(function () { return path ? self.textBuf.saveAs(util.resolvePath(path)) : self.textBuf.save(); }) - .then(function () { return self.textBuf.getPath(); }) + var args = arguments; + return Promise + .try(function () { + return path + ? self.textBuf.saveAs(util.resolvePath.apply(null, args)) + : self.textBuf.save(); + }) + .then(function () { return self.textBuf.getPath(); }); }); // looks for path like /home/dan/file.c:3:8 but matches every string
feat(save): Editor#save now accepts `from` paths like `path.resolve`
slap-editor_editor-widget
train
js
d132d2c4f6dca8fb688f2d4548dbd875184d8fc5
diff --git a/packages/components/bolt-blockquote/__tests__/blockquote.js b/packages/components/bolt-blockquote/__tests__/blockquote.js index <HASH>..<HASH> 100644 --- a/packages/components/bolt-blockquote/__tests__/blockquote.js +++ b/packages/components/bolt-blockquote/__tests__/blockquote.js @@ -58,7 +58,7 @@ describe('button', () => { const image = await page.screenshot(); expect(image).toMatchImageSnapshot({ - failureThreshold: '0.01', + failureThreshold: '0.03', failureThresholdType: 'percent', }); @@ -94,7 +94,7 @@ describe('button', () => { const image = await page.screenshot(); expect(image).toMatchImageSnapshot({ - failureThreshold: '0.01', + failureThreshold: '0.03', failureThresholdType: 'percent', }); @@ -125,7 +125,7 @@ describe('button', () => { const image = await page.screenshot(); expect(image).toMatchImageSnapshot({ - failureThreshold: '0.01', + failureThreshold: '0.03', failureThresholdType: 'percent', });
fix: increase failure threshold to 3% on blockquote tests
bolt-design-system_bolt
train
js
11679e842f73a1169428f78e6340ef47b3a4a5d1
diff --git a/.eslintrc.js b/.eslintrc.js index <HASH>..<HASH> 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -115,7 +115,7 @@ module.exports = { "newline-after-var": "off", "newline-before-return": "off", "newline-per-chained-call": ["error", { - "ignoreChainWithDepth": 5, + "ignoreChainWithDepth": 3, }], "no-alert": "error", "no-array-constructor": "error", diff --git a/tests/oddjob.test.js b/tests/oddjob.test.js index <HASH>..<HASH> 100644 --- a/tests/oddjob.test.js +++ b/tests/oddjob.test.js @@ -435,7 +435,12 @@ harness.test( '@grr/oddjob', t => { }); t.is(show().length().of([0]), '1'); - t.is(show().verbatim('the').length().of([0]), 'the 1'); + t.is( + show() + .verbatim('the') + .length() + .of([0]), + 'the 1'); t.is( show()
chore: Make ESLint configuration for method chains less permissive
apparebit_js-junction
train
js,js
60ab759a7672cd6ba7775c64b621353af9c25a19
diff --git a/test/k8sT/Services.go b/test/k8sT/Services.go index <HASH>..<HASH> 100644 --- a/test/k8sT/Services.go +++ b/test/k8sT/Services.go @@ -699,6 +699,7 @@ var _ = Describe("K8sServicesTest", func() { for _, url := range testURLsFromPods { wg.Add(1) go func(url string) { + defer GinkgoRecover() defer wg.Done() testCurlRequest(testDSClient, url) }(url) @@ -706,6 +707,7 @@ var _ = Describe("K8sServicesTest", func() { for _, url := range testURLsFromHosts { wg.Add(1) go func(url string) { + defer GinkgoRecover() defer wg.Done() doRequests(url, count, k8s1NodeName) }(url) @@ -713,6 +715,7 @@ var _ = Describe("K8sServicesTest", func() { for _, url := range testURLsFromOutside { wg.Add(1) go func(url string) { + defer GinkgoRecover() defer wg.Done() doRequestsFromThirdHost(url, count, false) }(url)
test: Call GinkgoRecover() from testNodePort() goroutines Otherwise, in a case of a failure, ginkgo will panic leaving a cryptic message, from which it's harder to determine which test case has failed.
cilium_cilium
train
go
72767a1059526bdf617e80d5a9e5da1fbd2936d3
diff --git a/packages/discord.js/src/util/EnumResolvers.js b/packages/discord.js/src/util/EnumResolvers.js index <HASH>..<HASH> 100644 --- a/packages/discord.js/src/util/EnumResolvers.js +++ b/packages/discord.js/src/util/EnumResolvers.js @@ -26,6 +26,9 @@ function unknownKeyStrategy(val) { throw new Error(`Could not resolve enum value for ${val}`); } +/** + * Holds a bunch of methods to resolve enum values to readable strings. + */ class EnumResolvers extends null { /** * A string that can be resolved to a {@link ChannelType} enum value. Here are the available types:
docs: add EnumResolvers (#<I>)
discordjs_discord.js
train
js
d310e4fc2824aa4c4dcaaa8b93b6b45e6a8fa699
diff --git a/src/structures/WelcomeChannel.js b/src/structures/WelcomeChannel.js index <HASH>..<HASH> 100644 --- a/src/structures/WelcomeChannel.js +++ b/src/structures/WelcomeChannel.js @@ -13,7 +13,7 @@ class WelcomeChannel extends Base { /** * The guild for this welcome channel - * @type {Guild|WelcomeGuild} + * @type {Guild|InviteGuild} */ this.guild = guild;
docs(WelcomeChannel): Correct guild return type (#<I>)
discordjs_discord.js
train
js
0b411011258b995605dd8a77b3ac0910600a5500
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -17,12 +17,13 @@ # add these directories to sys.path here. If the directory is relative to the # documentation root, use os.path.abspath to make it absolute, like shown here. # +import gettext import os import sys from os import path import sphinxcontrib.plantuml -from sphinx import addnodes +from sphinx import addnodes, locale from typing import Sequence from sphinx.locale import get_translation @@ -318,6 +319,9 @@ sphinxcontrib.plantuml.plantuml.extract_original_messages = extract_original_mes def setup(self): package_dir = path.abspath(path.dirname(__file__)) locale_dir = os.path.join(package_dir, 'locale') + print("locale_dir exists:", os.path.exists(locale_dir), locale_dir) + print(locale.init([locale_dir], self.config.language, MESSAGE_CATALOG_NAME)) + print(gettext.find(MESSAGE_CATALOG_NAME, locale_dir, [self.config.language], all=True)) self.add_message_catalog(MESSAGE_CATALOG_NAME, locale_dir) self.add_message_catalog("sphinx", locale_dir) self.config.language = conversion.get(self.config.language, self.config.language)
docs: rtd translation debug 0
blueset_ehForwarderBot
train
py
fdb5ae6a1dc09ecf2181ddcb9dd7ec29f0708c27
diff --git a/src/cartesian/ErrorBar.js b/src/cartesian/ErrorBar.js index <HASH>..<HASH> 100644 --- a/src/cartesian/ErrorBar.js +++ b/src/cartesian/ErrorBar.js @@ -18,7 +18,6 @@ class ErrorBar extends Component { strokeWidth: PropTypes.number, width: PropTypes.number, offset: PropTypes.number, - opacity: PropTypes.number, }; static defaultProps = { @@ -27,7 +26,6 @@ class ErrorBar extends Component { width: 5, offset: 0, layout: 'horizontal', - opacity: 1, }; renderErrorBars() {
fix: remove opacity in ErrorBar
recharts_recharts
train
js
ebfb55ac9d05e15efb5741baf292666be5585424
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -376,11 +376,11 @@ class CrawlKit { // take no chances - if there was an error on Phantom side, we should get rid of the instance workerLogger.info(`Notifying pool to destroy Phantom instance.`); pool.destroy(scope.browser); - scope.browser = null; } else { workerLogger.debug(`Phantom released to pool.`); pool.release(scope.browser); } + scope.browser = null; } stopWorkerTimer(); if (err instanceof HeadlessError || err instanceof TimeoutError) { diff --git a/src/worker/steps/acquireBrowser.js b/src/worker/steps/acquireBrowser.js index <HASH>..<HASH> 100644 --- a/src/worker/steps/acquireBrowser.js +++ b/src/worker/steps/acquireBrowser.js @@ -2,10 +2,10 @@ module.exports = (scope, logger, pool) => { return (done) => { logger.debug('acquiring phantom from pool'); pool.acquire((err, browser) => { - scope.browser = browser; if (err) { return done(err); } + scope.browser = browser; logger.debug(`Acquired phantom from pool.`); done(); });
fix: make sure we can only release proper objects
crawlkit_crawlkit
train
js,js
74bd48d062bd7dcdee2408ca1f975f31ff493e00
diff --git a/release.config.js b/release.config.js index <HASH>..<HASH> 100644 --- a/release.config.js +++ b/release.config.js @@ -1,6 +1,29 @@ 'use strict' +const config = require('@codedependant/release-config-npm') + module.exports = { 'extends': '@codedependant/release-config-npm' , 'branches': ['main'] +, 'plugins': remap(config.plugins) +} + +function remap(plugins) { + const remapped = [] + + for (const [name, config] of plugins) { + if (name === '@semantic-release/git') { + remapped.push([ + '@semantic-release/exec', { + prepareCmd: 'npm run docs:build' + } + ]) + config.assets = [...config.assets, 'docs'] + } + + remapped.push([name, config]) + } + + return remapped + }
fix(release): update release to regenerate docs. Addes back the exec stage to run the command that generates gh-pages with the rendered output from vuepress
esatterwhite_node-seeli
train
js
43e7cf34ce650535abf6efde60f192eeeb0f6f0a
diff --git a/samcli/commands/sync/command.py b/samcli/commands/sync/command.py index <HASH>..<HASH> 100644 --- a/samcli/commands/sync/command.py +++ b/samcli/commands/sync/command.py @@ -62,7 +62,10 @@ LOG = logging.getLogger(__name__) HELP_TEXT = """ [Beta Feature] Update/Sync local artifacts to AWS -By default, the sync command runs a full stack update. You can specify --code or --watch to switch modes +By default, the sync command runs a full stack update. You can specify --code or --watch to switch modes. +\b +Sync also supports nested stacks and nested stack resources. For example +$ sam sync --code --stack-name {stack} --resource-id {ChildStack}/{ResourceId} """ SYNC_CONFIRMATION_TEXT = """ @@ -113,7 +116,8 @@ DEFAULT_CAPABILITIES = ("CAPABILITY_NAMED_IAM", "CAPABILITY_AUTO_EXPAND") @click.option( "--resource-id", multiple=True, - help="Sync code for all the resources with the ID.", + help="Sync code for all the resources with the ID. To sync a resource within a nested stack, " + "use the following pattern {ChildStack}/{logicalId}.", ) @click.option( "--resource",
chore: Update command option text (#<I>) * Update command option text * Use curly braces
awslabs_aws-sam-cli
train
py
2aff59a9873e098564606df8eecdff58de62f3e7
diff --git a/src/Ufo/Routing/Route.php b/src/Ufo/Routing/Route.php index <HASH>..<HASH> 100644 --- a/src/Ufo/Routing/Route.php +++ b/src/Ufo/Routing/Route.php @@ -19,9 +19,21 @@ class Route public static function parse(string $path, RouteStorageInterface $routeStorage): ?Section { if (empty($path) || '/' == $path) { - return $routeStorage->get('/'); + $section = $routeStorage->get('/'); + } else { + $section = $routeStorage->find($path); } - return $routeStorage->find($path); + if (null === $section) { + return null; + } + + //strlen faster than simple comparison + $splen = strlen($section->path); + if (strlen($path) > $splen) { + $section->params = explode('/', trim(substr($path, $splen), '/')); + } + + return $section; } }
feat: parse additional data from path into section params
enikeishik_ufoframework
train
php
94008ff572d49b13489dc964194a8cda4b686396
diff --git a/lib/core/public/cleanup-plugins.js b/lib/core/public/cleanup-plugins.js index <HASH>..<HASH> 100644 --- a/lib/core/public/cleanup-plugins.js +++ b/lib/core/public/cleanup-plugins.js @@ -23,9 +23,11 @@ function cleanupPlugins(resolve, reject) { }); }); - axe.utils.toArray(document.querySelectorAll('frame, iframe')).forEach(function (frame) { + var flattenedTree = axe.utils.getFlattenedTree(document.body) + + axe.utils.querySelectorAll(flattenedTree, 'iframe, frame').forEach(function (node) { q.defer(function (res, rej) { - return axe.utils.sendCommandToFrame(frame, { + return axe.utils.sendCommandToFrame(node.actualNode, { command: 'cleanup-plugin' }, res, rej); }); diff --git a/lib/core/public/plugins.js b/lib/core/public/plugins.js index <HASH>..<HASH> 100644 --- a/lib/core/public/plugins.js +++ b/lib/core/public/plugins.js @@ -43,4 +43,4 @@ Plugin.prototype.add = function (impl) { axe.registerPlugin = function (plugin) { 'use strict'; axe.plugins[plugin.id] = new Plugin(plugin); -}; \ No newline at end of file +};
fix: Use frame query that supports shadow dom (#<I>)
dequelabs_axe-core
train
js,js
313ae3bb7f92ea73a3c6fbe146503912ae848795
diff --git a/src/constants.js b/src/constants.js index <HASH>..<HASH> 100644 --- a/src/constants.js +++ b/src/constants.js @@ -8,6 +8,5 @@ module.exports = { hasBlockTimeout: 15 * SECOND, provideTimeout: 15 * SECOND, kMaxPriority: Math.pow(2, 31) - 1, - rebroadcastDelay: 10 * SECOND, maxListeners: 1000 } diff --git a/src/want-manager/index.js b/src/want-manager/index.js index <HASH>..<HASH> 100644 --- a/src/want-manager/index.js +++ b/src/want-manager/index.js @@ -112,16 +112,6 @@ module.exports = class WantManager { } start () { - // resend entire wantlist every so often - this.timer = setInterval(() => { - this._log('resend full-wantlist') - const fullwantlist = new Message(true) - this.wantlist.forEach((entry) => { - fullwantlist.addEntry(entry.cid, entry.priority) - }) - - this.peers.forEach((p) => p.addMessage(fullwantlist)) - }, 60 * 1000) } stop () {
fix: do not rebroadcast want list (#<I>) We should not need to rebroadcast our want lists, because we send it to newly connected peers. Rebroadcasting is a throwback to when the network was less reliable, but if the connection is unreliable it is dropped and a new connection established, which triggers sending the whole wantlist as the remote is seen as a newly connected peer. fixes #<I>
ipfs_js-ipfs-bitswap
train
js,js
f859d4ce44ec4f836792fa31376a8b02b1531bab
diff --git a/spec-main/index.js b/spec-main/index.js index <HASH>..<HASH> 100644 --- a/spec-main/index.js +++ b/spec-main/index.js @@ -124,4 +124,8 @@ app.whenReady().then(async () => { chai.use(require('dirty-chai')); const runner = mocha.run(cb); +}).catch((err) => { + console.error('An error occurred while running the spec-main spec runner'); + console.error(err); + process.exit(1); });
test: fail tests if the spec runner promise rejects (#<I>)
electron_electron
train
js
760ee445fe3d78d7e9679b704609e637a9d32dc0
diff --git a/packages/cozy-pouch-link/src/CozyPouchLink.js b/packages/cozy-pouch-link/src/CozyPouchLink.js index <HASH>..<HASH> 100644 --- a/packages/cozy-pouch-link/src/CozyPouchLink.js +++ b/packages/cozy-pouch-link/src/CozyPouchLink.js @@ -87,7 +87,7 @@ export default class PouchLink extends CozyLink { onLogin() { if (this.client && this.options.initialSync) { - this.pouches.startReplicationLoop() + this.startReplication() } } @@ -113,11 +113,34 @@ export default class PouchLink extends CozyLink { } } + /** + * User of the link can call this to start ongoing replications. + * Typically, it can be used when the application regains focus. + * + * @public + * @return {void} + */ + startReplication() { + this.pouches.startReplicationLoop() + } + + /** + * User of the link can call this to stop ongoing replications. + * Typically, it can be used when the applications loses focus. + * + * @public + * @return {void} + */ + stopReplication() { + this.pouches.stopReplicationLoop() + } + async onSyncError(error) { if (isExpiredTokenError(error)) { try { await this.client.renewAuthorization() - this.pouches.startReplicationLoop() + this.startReplication() + return } catch (err) { console.warn('Could not refresh token, replication has stopped', err) }
feat: add public methods to start/stop replication
cozy_cozy-client
train
js
b5ff309bf985a43da4229421ac53b68f216edede
diff --git a/src/structures/CategoryChannel.js b/src/structures/CategoryChannel.js index <HASH>..<HASH> 100644 --- a/src/structures/CategoryChannel.js +++ b/src/structures/CategoryChannel.js @@ -5,6 +5,10 @@ const GuildChannel = require('./GuildChannel'); * @extends {GuildChannel} */ class CategoryChannel extends GuildChannel { + constructor(guild, data) { + super(guild, data); + this.type = 'category'; + } /** * The channels that are part of this category * @type {?Collection<Snowflake, GuildChannel>} diff --git a/src/structures/Channel.js b/src/structures/Channel.js index <HASH>..<HASH> 100644 --- a/src/structures/Channel.js +++ b/src/structures/Channel.js @@ -19,6 +19,7 @@ class Channel { * * `group` - a Group DM channel * * `text` - a guild text channel * * `voice` - a guild voice channel + * * `category` - a guild category channel * @type {string} */ this.type = null;
fix(CategoryChannel): set the type to 'category' and document its type
discordjs_discord.js
train
js,js
b0bf8a71ae2a3c83727f574dfef1f46e96d7b3b8
diff --git a/addon/models/radar.js b/addon/models/radar.js index <HASH>..<HASH> 100644 --- a/addon/models/radar.js +++ b/addon/models/radar.js @@ -273,17 +273,17 @@ export default class Radar { this._nextScroll = null; this._nextAdjustment = null; - this._scrollHandler = () => { + this._scrollHandler = run.bind(this, () => { if (this.isTracking) { this._nextScroll = run.scheduleOnce('sync', this, this.filterMovement); } - }; - this._resizeHandler = () => { + }); + this._resizeHandler = run.bind(this, () => { this._nextResize = run.debounce(this, this.resizeSatellites, this.resizeDebounce); - }; - this._scrollAdjuster = () => { + }); + this._scrollAdjuster = run.bind(this, () => { this._nextAdjustment = run.scheduleOnce('sync', this, this.updateScrollPosition); - }; + }); window.addEventListener('resize', this._resizeHandler, true); this.telescope.addEventListener('scroll', this._scrollHandler, true);
fix(radar): bind window events to run loops
html-next_vertical-collection
train
js
f096722955a46576857d42e026af6eace431bb4a
diff --git a/commons-config/src/main/java/module-info.java b/commons-config/src/main/java/module-info.java index <HASH>..<HASH> 100644 --- a/commons-config/src/main/java/module-info.java +++ b/commons-config/src/main/java/module-info.java @@ -1,4 +1,4 @@ -module se.l4.commons.guice { +module se.l4.commons.config { requires se.l4.commons.serialization; requires se.l4.commons.io; requires com.google.common;
fix(config): Module name of config was a duplicate
LevelFourAB_commons
train
java
c3405b82e1e68dc32ce6261affb81a6295eba4cc
diff --git a/packages/upload/UploadProgressBar.js b/packages/upload/UploadProgressBar.js index <HASH>..<HASH> 100644 --- a/packages/upload/UploadProgressBar.js +++ b/packages/upload/UploadProgressBar.js @@ -61,9 +61,7 @@ class UploadProgressBar extends Component { const { percentage, error, modalOpen } = this.state; return upload.errorMessage ? ( <React.Fragment> - <span data-testid="upload-error-message" className="text-danger"> - {upload.errorMessage} - </span> + <span className="text-danger">{upload.errorMessage}</span> {upload.status === 'encrypted' && ( <div className="pwRequired"> <Button size="sm" color="primary" onClick={this.toggleModal}>
feat(upload): remove unit testing attempt
Availity_availity-react
train
js
8bc463b5a54dda32cd9f114c8cf337fcb99d2645
diff --git a/scripts/rollup/config.js b/scripts/rollup/config.js index <HASH>..<HASH> 100644 --- a/scripts/rollup/config.js +++ b/scripts/rollup/config.js @@ -49,6 +49,12 @@ const createConfiguration = ({ mode, filename }) => ({ banner: license, sourcemap: true, }, + onwarn(warning, warn) { + if (warning.code === 'CIRCULAR_DEPENDENCY') + throw new Error(warning.message); + + warn(warning); + }, plugins: [ ...plugins, replace({
chore(ci): make build fail when circular dependency is detected (#<I>)
algolia_instantsearch.js
train
js
7d2d6eafc75823f436b3f62f626c1cc3d7ffcf2f
diff --git a/packages/icon-helpers/src/toSVG.js b/packages/icon-helpers/src/toSVG.js index <HASH>..<HASH> 100644 --- a/packages/icon-helpers/src/toSVG.js +++ b/packages/icon-helpers/src/toSVG.js @@ -6,8 +6,9 @@ import getAttributes from './getAttributes'; export default function toSVG(descriptor) { const { elem = 'svg', attrs = {}, content = [] } = descriptor; const node = document.createElementNS('http://www.w3.org/2000/svg', elem); + const attributes = elem !== 'svg' ? attrs : getAttributes(attrs); - Object.keys(elem !== 'svg' ? attrs : getAttributes(attrs)).forEach(key => { + Object.keys(attributes).forEach(key => { node.setAttribute(key, attrs[key]); });
fix(icon-helpers): use attributes correctly in toSVG (#<I>)
carbon-design-system_carbon-elements
train
js
c90d3464f2fcdde122d61479da97d5ad3e9018b1
diff --git a/tasks/options/aliases.js b/tasks/options/aliases.js index <HASH>..<HASH> 100644 --- a/tasks/options/aliases.js +++ b/tasks/options/aliases.js @@ -14,6 +14,10 @@ module.exports = { default: [ 'build' ], + dev: [ + 'karma:unit:start', + 'watch' + ], doc: [ 'groc' ]
chore(grunt): add dev task which start karma and watch repository
stephanebachelier_superapi
train
js
a12154b732f853cd5d0b4518b4010de82b6aacb6
diff --git a/packages/metascraper/test/unit/interface.js b/packages/metascraper/test/unit/interface.js index <HASH>..<HASH> 100644 --- a/packages/metascraper/test/unit/interface.js +++ b/packages/metascraper/test/unit/interface.js @@ -40,7 +40,7 @@ it('Disable URL validation using `validateUrl`', async () => { <meta charset="UTF-8"> <meta name="viewport" content="width=device-width, initial-scale=1.0"> <meta http-equiv="X-UA-Compatible" content="ie=edge"> - <title>Document</title> + <meta property="og:title" content="Document"/> </head> <body> <div class="logos">
refactor: rewrite test
microlinkhq_metascraper
train
js
2f15fb6ba7a90229f1a81ae67bf778eb35734233
diff --git a/base-server/index.js b/base-server/index.js index <HASH>..<HASH> 100644 --- a/base-server/index.js +++ b/base-server/index.js @@ -290,7 +290,8 @@ class BaseServer { let pkg = JSON.parse(await readFile(join(__dirname, '../package.json'))) - this.ws.on('connection', ws => { + this.ws.on('connection', (ws, req) => { + ws.upgradeReq = req this.addClient(new ServerConnection(ws)) }) this.reporter('listen', {
fix(base-server): cookie is empty object (#<I>)
logux_server
train
js
123d303b9a3beb46be23d98a816ddbf9e844be83
diff --git a/protocol-designer/src/steplist/generateSubsteps.js b/protocol-designer/src/steplist/generateSubsteps.js index <HASH>..<HASH> 100644 --- a/protocol-designer/src/steplist/generateSubsteps.js +++ b/protocol-designer/src/steplist/generateSubsteps.js @@ -96,14 +96,16 @@ function transferLikeSubsteps (args: { const commandCallArgs = { ...validatedForm, mixBeforeAspirate: null, - mixInDestination: null + mixInDestination: null, + preWetTip: false } result = transfer(commandCallArgs)(robotState) } else if (validatedForm.stepType === 'distribute') { const commandCallArgs = { ...validatedForm, - mixBeforeAspirate: null + mixBeforeAspirate: null, + preWetTip: false } result = distribute(commandCallArgs)(robotState) @@ -111,7 +113,8 @@ function transferLikeSubsteps (args: { const commandCallArgs = { ...validatedForm, mixFirstAspirate: null, - mixInDestination: null + mixInDestination: null, + preWetTip: false } result = consolidate(commandCallArgs)(robotState)
fix(protocol-designer): hide pre-wet tip asp/disp from substeps (#<I>) Fixes #<I>
Opentrons_opentrons
train
js
4618fa9e7c6bb6883e0201b0342d92f1e1a94faf
diff --git a/jest.config.jest.js b/jest.config.jest.js index <HASH>..<HASH> 100644 --- a/jest.config.jest.js +++ b/jest.config.jest.js @@ -1,5 +1,5 @@ module.exports = { - ...require('./jest.config'), // eslint-disable-next-line global-require + ...require('./jest.config'), setupFiles: ['<rootDir>/testSetupJest.js'], };
chore: thnx eslint, so helpful
stipsan_ioredis-mock
train
js
961999dbbed6bf46f47fee8db43aeeee5568cdf5
diff --git a/src/mixins/popup/index.js b/src/mixins/popup/index.js index <HASH>..<HASH> 100644 --- a/src/mixins/popup/index.js +++ b/src/mixins/popup/index.js @@ -75,8 +75,9 @@ export const PopupMixin = { /* istanbul ignore next */ activated() { - if (this.value) { - this.open(); + if (this.shouldReopen) { + this.$emit('input', true); + this.shouldReopen = false; } }, @@ -90,7 +91,10 @@ export const PopupMixin = { /* istanbul ignore next */ deactivated() { - this.close(); + if (this.value) { + this.close(); + this.shouldReopen = true; + } }, methods: {
fix(Popup): should reopen when activated (#<I>)
youzan_vant
train
js
71c2bba69dcbaf7477956f1c45356106552c9f7a
diff --git a/pkg/action/install.go b/pkg/action/install.go index <HASH>..<HASH> 100644 --- a/pkg/action/install.go +++ b/pkg/action/install.go @@ -131,6 +131,10 @@ func (i *Install) Run(chrt *chart.Chart) (*release.Release, error) { i.cfg.Releases = storage.Init(driver.NewMemory()) } + if err := chartutil.ProcessDependencies(chrt, i.rawValues); err != nil { + return nil, err + } + // Make sure if Atomic is set, that wait is set as well. This makes it so // the user doesn't have to specify both i.Wait = i.Wait || i.Atomic
fix: call chartutil.ProcessDependencies in action.Install
helm_helm
train
go
8317fc0ae40f31cd77c542625638758cc61e5564
diff --git a/src/core.js b/src/core.js index <HASH>..<HASH> 100644 --- a/src/core.js +++ b/src/core.js @@ -341,4 +341,5 @@ // Treasure.Plugins // ------------------------------- - var Plugins = Treasure.Plugins = {}; + // var Plugins = Treasure.Plugins = {}; +
refactor(plugins): temporarily disable
treasure-data_td-js-sdk
train
js
9cc337d0be4125c3c500c3bf95f446981dc41511
diff --git a/src/router.js b/src/router.js index <HASH>..<HASH> 100644 --- a/src/router.js +++ b/src/router.js @@ -165,6 +165,7 @@ export class Router { } navModel.title = navModel.title || config.title; + navModel.settings = config.settings || (config.settings = {}); this.routes.push(config); this.recognizer.add([{path:config.route, handler: config}]); @@ -179,6 +180,7 @@ export class Router { }]); withChild.navModel = navModel; + withChild.settings = config.settings; } config.navModel = navModel;
feat(router): enable dedicated user setting for route config All route configs can now have a settings property which will be referencable also from the navModel. Fixes #<I>
aurelia_router
train
js
4e3716d1007b68c3c9473f43bce3ac11698ccd70
diff --git a/examples/cms-wordpress/lib/api.js b/examples/cms-wordpress/lib/api.js index <HASH>..<HASH> 100644 --- a/examples/cms-wordpress/lib/api.js +++ b/examples/cms-wordpress/lib/api.js @@ -10,7 +10,7 @@ async function fetchAPI(query = '', { variables } = {}) { } // WPGraphQL Plugin must be enabled - const res = await fetch(`${API_URL}/graphql`, { + const res = await fetch(API_URL, { headers, method: 'POST', body: JSON.stringify({
chore(examples): require `WORDPRESS_API_URL` to include `/graphql` (#<I>) Fixes #<I> Since we are calling it `API_URL`, it sounds more correct to require including the `/graphql` rather than making `WORDPRESS_API_URL` be just the root domain in <URL>
zeit_next.js
train
js
5fcece8d7925d2f78b5a795746d83663d3373485
diff --git a/lib/datasource/index.js b/lib/datasource/index.js index <HASH>..<HASH> 100644 --- a/lib/datasource/index.js +++ b/lib/datasource/index.js @@ -93,18 +93,15 @@ async function getPkgReleases(purlStr, config) { } const dep = await datasources[purl.type].getPkgReleases(purl, config); if (dep) { + const depName = purl.fullname.toLowerCase(); if ( manualChangelogUrls[purl.type] && - manualChangelogUrls[purl.type][purl.fullname.toLowerCase()] + manualChangelogUrls[purl.type][depName] ) { - dep.changelogUrl = - manualChangelogUrls[purl.type][purl.fullname.toLowerCase()]; + dep.changelogUrl = manualChangelogUrls[purl.type][depName]; } - if ( - manualSourceUrls[purl.type] && - manualSourceUrls[purl.type][purl.fullname.toLowerCase()] - ) { - dep.sourceUrl = manualSourceUrls[purl.type][purl.fullname.toLowerCase()]; + if (manualSourceUrls[purl.type] && manualSourceUrls[purl.type][depName]) { + dep.sourceUrl = manualSourceUrls[purl.type][depName]; } if ( !dep.sourceUrl &&
refactor: purl.fullname.toLowerCase() -> depName
renovatebot_renovate
train
js
571ebe48cf669f442b9bfbbff3d0bbd683fef5c9
diff --git a/docs/themes/cypress/source/js/toc.js b/docs/themes/cypress/source/js/toc.js index <HASH>..<HASH> 100644 --- a/docs/themes/cypress/source/js/toc.js +++ b/docs/themes/cypress/source/js/toc.js @@ -9,10 +9,17 @@ if (!toc) return; - // https://github.com/lcdsantos/menuspy - // This highlights the proper toc link while scrolling var ms = new MenuSpy(tocInner) + // we need this to be called after all images have loaded + // otherwise the height for the menuspy is not properly calculated + window.addEventListener('load', function(){ + // https://github.com/lcdsantos/menuspy + // This highlights the proper toc link while scrolling + ms.cacheItems() + ms.tick() + }); + // This keeps the toc within the view function updateSidebarPosition(){ var scrollTop = document.scrollingElement.scrollTop;
docs: Have menuspy recalculate positions after all images have been loaded Fixes #<I>
cypress-io_cypress
train
js
5de3efc66e827550e36ab2ef5b8bcfeb0fe8c22a
diff --git a/canary/live_stream_api.py b/canary/live_stream_api.py index <HASH>..<HASH> 100644 --- a/canary/live_stream_api.py +++ b/canary/live_stream_api.py @@ -12,7 +12,7 @@ HEADER_AUTHORIZATION = "Authorization" HEADER_VALUE_AUTHORIZATION = "Bearer {}" -URL_LOGIN_PAGE = "https://my.canary.is/v2/login" +URL_LOGIN_PAGE = "https://my.canary.is/manifest.json" URL_LOGIN_API = "https://api-prod.canaryis.com/o/access_token/" URL_START_SESSION = "https://my.canary.is/api/watchlive/{device_uuid}/session" URL_RENEW_SESSION = "https://my.canary.is/api/watchlive/{device_uuid}/send"
fix: get session cookies looks like canary changed the file that sets the ssesyranac cookie from the login page to a manifest.json file linked off the login page. Looking at all the files, that was the only file that set the ssesyranac cookie.
snjoetw_py-canary
train
py
26dc169e2ab2f3c5c94439e9ff47594bdcbf620f
diff --git a/master/buildbot/test/__init__.py b/master/buildbot/test/__init__.py index <HASH>..<HASH> 100644 --- a/master/buildbot/test/__init__.py +++ b/master/buildbot/test/__init__.py @@ -99,6 +99,8 @@ warnings.filterwarnings('ignore', ".*Using or importing the ABCs from 'collectio # more 3.7 warning from moto warnings.filterwarnings('ignore', r".*Use 'list\(elem\)' or iteration over elem instead.*", DeprecationWarning) +warnings.filterwarnings('ignore', r".*distutils Version classes are deprecated.*", + DeprecationWarning) # ignore ResourceWarnings for unclosed sockets for the pg8000 driver on Python 3+ (tech debt: #4508) if sys.version_info[0] >= 3 and "pg8000" in os.getenv("BUILDBOT_TEST_DB_URL", ""):
test: Ignore distutils version class deprecation in tests (used by moto)
buildbot_buildbot
train
py
b112ad1b6a063278ee6b5bf30e3be482ecc0c24d
diff --git a/src/adapter.js b/src/adapter.js index <HASH>..<HASH> 100644 --- a/src/adapter.js +++ b/src/adapter.js @@ -60,6 +60,9 @@ var getAllSpecNames = function(topSuite) { childPointer = pointer[child.description] = {_: []}; processSuite(child, childPointer); } else { + if (!pointer._) { + pointer._ = []; + } pointer._.push(child.description); } }
fix: resolving spec names for suites without parents pointer._.push would throw undefined method for push - if parent topSuite would not contain any children suites
sumanjs_karma-suman
train
js
59bf7595b801b85df9ab9fb8c3be3c54d4431fc1
diff --git a/src/Keboola/StorageApi/Client.php b/src/Keboola/StorageApi/Client.php index <HASH>..<HASH> 100644 --- a/src/Keboola/StorageApi/Client.php +++ b/src/Keboola/StorageApi/Client.php @@ -1139,7 +1139,12 @@ class Client 'file' => $fh, ))); } catch (RequestException $e) { - throw new ClientException("Error on file upload to S3: " . $e->getMessage(), $e->getCode(), $e); + $response = $e->getResponse(); + $message = "Error on file upload to S3: " . $e->getMessage(); + if ($response) { + $message .= ' ' . (string) $response->getBody(); + } + throw new ClientException($message, $e->getCode(), $e); } if ($fs) {
feat: file upload error message contains reponse body
keboola_storage-api-php-client
train
php
c97ffcc0b976a4efe67b14858ac96580d7b9d4a9
diff --git a/test/mochaPatch.js b/test/mochaPatch.js index <HASH>..<HASH> 100644 --- a/test/mochaPatch.js +++ b/test/mochaPatch.js @@ -52,9 +52,6 @@ BbPromise.config({ longStackTraces: true, }); -// In order to ensure that telemetry is not mistakenly emitted during test runs -process.env.SLS_TELEMETRY_DISABLED = '1'; - const { runnerEmitter } = require('@serverless/test/setup/patch'); runnerEmitter.on('runner', (runner) => {
test: Remove env var setting, which is already set by dependency
serverless_serverless
train
js
8fff159389aa63941ccf0c59567c3eb7936a2c62
diff --git a/src/sagemaker/model.py b/src/sagemaker/model.py index <HASH>..<HASH> 100644 --- a/src/sagemaker/model.py +++ b/src/sagemaker/model.py @@ -274,9 +274,18 @@ class Model(object): framework (str): The framework name. framework_version (str): The framework version. """ - framework_prefix = "inferentia-" if target_instance_type.startswith("ml_inf") else "neo-" + framework_prefix = "" + framework_suffix = "" + + if framework == "xgboost": + framework_suffix = "-neo" + elif target_instance_type.startswith("ml_inf"): + framework_prefix = "inferentia-" + else: + framework_prefix = "neo-" + return image_uris.retrieve( - "{}{}".format(framework_prefix, framework), + "{}{}{}".format(framework_prefix, framework, framework_suffix), region, instance_type=target_instance_type, version=framework_version,
fix: add a condition to retrieve correct image URI for xgboost (#<I>)
aws_sagemaker-python-sdk
train
py
13b4bfbdacbea6665a5ee8309f5550d3db010a8a
diff --git a/packages/blueprint-sequelize/app/services/sequelize.js b/packages/blueprint-sequelize/app/services/sequelize.js index <HASH>..<HASH> 100644 --- a/packages/blueprint-sequelize/app/services/sequelize.js +++ b/packages/blueprint-sequelize/app/services/sequelize.js @@ -205,7 +205,7 @@ module.exports = Service.extend ({ this._seeds[name] = models; if (!!models) - this.emit ('seeded', name, conn, models); + this.emit ('blueprint.sequelize.seeded', name, conn, models); return models; });
fix: change the name of the event emitted after database seeded to avoid clashes
onehilltech_blueprint
train
js
4421e2c72826153c30da8f88470119f9135abb29
diff --git a/lib/conventional_changelog/writer.rb b/lib/conventional_changelog/writer.rb index <HASH>..<HASH> 100644 --- a/lib/conventional_changelog/writer.rb +++ b/lib/conventional_changelog/writer.rb @@ -1,13 +1,16 @@ module ConventionalChangelog class Writer < File def initialize(file_name) - @previous_body = File.open(file_name, "a+").read - super file_name, "w" + FileUtils.touch file_name + super file_name, 'r+' + + @previous_body = read end def write!(options) + seek 0 write_new_lines options - self.puts @previous_body + puts @previous_body end private diff --git a/spec/generator_spec.rb b/spec/generator_spec.rb index <HASH>..<HASH> 100644 --- a/spec/generator_spec.rb +++ b/spec/generator_spec.rb @@ -229,5 +229,14 @@ describe ConventionalChangelog::Generator do end end + + context "with unexpected errors" do + it "keeps the original changelog" do + File.write("CHANGELOG.md", "original") + expect { subject.generate! }.to raise_exception NoMethodError + + expect(changelog).to eql "original" + end + end end end
fix: Avoid truncating original changelog on errors
dcrec1_conventional-changelog-ruby
train
rb,rb
9ad0d100b43418826d849f6a92ae579ec0ee2650
diff --git a/lib/pact/consumer_contract/consumer_contract_writer.rb b/lib/pact/consumer_contract/consumer_contract_writer.rb index <HASH>..<HASH> 100644 --- a/lib/pact/consumer_contract/consumer_contract_writer.rb +++ b/lib/pact/consumer_contract/consumer_contract_writer.rb @@ -57,8 +57,9 @@ module Pact logger.info log_message FileUtils.mkdir_p File.dirname(pactfile_path) Filelock pactfile_path do | file | + new_contents = pact_json file.truncate 0 - file.write pact_json + file.write new_contents end end
fix: read existing pact file before truncating it
pact-foundation_pact-mock_service
train
rb
08bcf853caacfe8d91321aa0d5661688df663075
diff --git a/actor-apps/app-web/src/app/stores/ComposeStore.js b/actor-apps/app-web/src/app/stores/ComposeStore.js index <HASH>..<HASH> 100644 --- a/actor-apps/app-web/src/app/stores/ComposeStore.js +++ b/actor-apps/app-web/src/app/stores/ComposeStore.js @@ -85,8 +85,7 @@ let onTyping = (action) => { let onMentionInsert = (action) => { const query = getQuery(action.text, action.caretPosition); - const mentionEnding = action.caretPosition === 1 && query.atStart ? ': ' : ' '; - //const startChar = action.mention.isNick ? 1 : 0; + const mentionEnding = query.atStart ? ': ' : ' '; text = action.text.substring(0, action.caretPosition - query.text.length - 1) + action.mention.mentionText +
fix(web): fix ending mention text when it's at the start of the string
actorapp_actor-platform
train
js
680a6ed357843d8a1c5b527d90a6f76f45e67621
diff --git a/packages/line/stories/LineCanvas.stories.js b/packages/line/stories/LineCanvas.stories.js index <HASH>..<HASH> 100644 --- a/packages/line/stories/LineCanvas.stories.js +++ b/packages/line/stories/LineCanvas.stories.js @@ -63,7 +63,7 @@ stories.add( ) stories.add( - 'different serie lengths', + 'different series lengths', () => ( <LineCanvas {...commonProperties}
fix(storybook): fix typo in line's story (#<I>)
plouc_nivo
train
js
2639a7fc97639d3e18786470a4836d81ebdb8734
diff --git a/app/Config/Feature.php b/app/Config/Feature.php index <HASH>..<HASH> 100644 --- a/app/Config/Feature.php +++ b/app/Config/Feature.php @@ -26,7 +26,7 @@ class Feature extends BaseConfig public $multipleFilters = false; /** - * Use improved new auto routing, instead of the traditional auto routing. + * Use improved new auto routing instead of the default legacy version. */ public bool $autoRoutesImproved = false; }
docs: fix by proofreading
codeigniter4_CodeIgniter4
train
php
ea6637362248f4d9a66d4c1aa944c2a22719f271
diff --git a/packages/vaex-core/vaex/dataset_mmap.py b/packages/vaex-core/vaex/dataset_mmap.py index <HASH>..<HASH> 100644 --- a/packages/vaex-core/vaex/dataset_mmap.py +++ b/packages/vaex-core/vaex/dataset_mmap.py @@ -95,8 +95,8 @@ if no_mmap: #print(values[:2]) - # make sure we write at a multiple of the page size - if True: + # make sure we write at a multiple of the page size, if the content is smaller than + if N * itemsize >= page_size: offset_optimal = math.ceil(offset/page_size) * page_size padding = offset_optimal - offset #ar_ptr_pad = ar_bytes[:padding].ctypes.data_as(ctypes.POINTER(ctypes.c_byte))
fix: support for writing smaller than page size when VAEX_NO_MMAP is defined
vaexio_vaex
train
py
773ad632bbd963bdfbc63056410dc93397e0e35b
diff --git a/client/js/uploader.basic.api.js b/client/js/uploader.basic.api.js index <HASH>..<HASH> 100644 --- a/client/js/uploader.basic.api.js +++ b/client/js/uploader.basic.api.js @@ -1441,13 +1441,14 @@ this._onSubmit.apply(this, arguments); this._uploadData.setStatus(id, qq.status.SUBMITTED); this._onSubmitted.apply(this, arguments); - this._options.callbacks.onSubmitted.apply(this, arguments); if (this._options.autoUpload) { + this._options.callbacks.onSubmitted.apply(this, arguments); this._uploadFile(id); } else { this._storeForLater(id); + this._options.callbacks.onSubmitted.apply(this, arguments); } },
fix(manual-upload): submitted file not avail for upload in onSubmitted fixes #<I>
FineUploader_fine-uploader
train
js
136ca295d1ca8a711e44195b5418f8acef84f5fe
diff --git a/cmd/influx/completion.go b/cmd/influx/completion.go index <HASH>..<HASH> 100644 --- a/cmd/influx/completion.go +++ b/cmd/influx/completion.go @@ -33,7 +33,7 @@ func completionCmd(rootCmd *cobra.Command) *cobra.Command { $ source <(influx completion bash) # for bash users $ source <(influx completion zsh) # for zsh users - Additionally, you may want to output the completion to a file and source in your .bashrc/.zshrc + Additionally, you may want to add this to your .bashrc/.zshrc `, RunE: func(cmd *cobra.Command, args []string) error { writer := rootCmd.OutOrStdout()
fix(influx): update completion cmd with more accurate help message
influxdata_influxdb
train
go
f78e0ca8f75fea5e2d99e7447f2258ffe945dd33
diff --git a/Gruntfile.js b/Gruntfile.js index <HASH>..<HASH> 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -34,8 +34,7 @@ module.exports = function(grunt) { alias: [ 'bower_components/snapsvg/index.js:snapsvg', 'node_modules/lodash/lodash.js:lodash' - ], - transform: [ 'uglifyify' ] + ] } }, src: { @@ -46,8 +45,7 @@ module.exports = function(grunt) { external: [ 'snapsvg', 'lodash' ], alias: [ 'src/diagram.js:diagram' - ], - transform: [ 'uglifyify' ] + ] } } },
chore(build): do not uglify (yet)
bpmn-io_diagram-js
train
js
a8c5e72f12d4f279da693d6040860434d3505780
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -1,5 +1,5 @@ -const Core = require("../blitz-js-core") -const API = require("../blitz-js-api") +const Core = require("blitz-js-core") +const API = require("blitz-js-api") const local = require("./config/local.js") const WebpackServer = require('./controllers/webpack.js') const endpoints = require('./override/endpoints.js')
fix: remove debug code from overhaul
cubic-js_cubic
train
js
fd058859cdcd1bbdf1740dbc3d3ec34fa21058ed
diff --git a/controller/api/models.py b/controller/api/models.py index <HASH>..<HASH> 100644 --- a/controller/api/models.py +++ b/controller/api/models.py @@ -444,7 +444,7 @@ class Release(UuidAuditedModel): config = models.ForeignKey('Config') build = models.ForeignKey('Build') # NOTE: image contains combined build + config, ready to run - image = models.CharField(max_length=256) + image = models.CharField(max_length=256, default=settings.DEFAULT_BUILD) class Meta: get_latest_by = 'created' diff --git a/controller/api/tests/test_release.py b/controller/api/tests/test_release.py index <HASH>..<HASH> 100644 --- a/controller/api/tests/test_release.py +++ b/controller/api/tests/test_release.py @@ -60,6 +60,7 @@ class ReleaseTest(TransactionTestCase): self.assertIn('config', response.data) self.assertIn('build', response.data) self.assertEquals(release1['version'], 1) + self.assertEquals(release1['image'], 'deis/helloworld') # check to see that a new release was created url = '/api/apps/{app_id}/releases/v2'.format(**locals()) response = self.client.get(url)
fix(controller): set default release image If you scale an application with `deis scale cmd=1` before an application has been pushed, it should deploy deis/helloworld. However, the initial release (v1) does not have a image set for the release, only the build. Setting the default to deis/helloworld fixes the "scale before deploy" problem.
deis_deis
train
py,py
43aeb5d692d2288be753f7afbd4e2996ffcce498
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -42,7 +42,7 @@ AssetsWebpackPlugin.prototype = { ) self.writer = createQueuedWriter(createOutputWriter(self.options)) - const afterEmit = (compilation, callback) => { + const emitPlugin = (compilation, callback) => { const options = compiler.options const stats = compilation.getStats().toJson({ hash: true, @@ -206,9 +206,9 @@ AssetsWebpackPlugin.prototype = { if (compiler.hooks) { const plugin = { name: 'AssetsWebpackPlugin' } - compiler.hooks.afterEmit.tapAsync(plugin, afterEmit) + compiler.hooks.emit.tapAsync(plugin, emitPlugin) } else { - compiler.plugin('after-emit', afterEmit) + compiler.plugin('after-emit', emitPlugin) } } }
fix: the source is not available on afterEmit
ztoben_assets-webpack-plugin
train
js
2410980431c328ad6fdbe1dc3d272ada87efc337
diff --git a/library/src/main/java/com/liulishuo/filedownloader/PauseAllMarker.java b/library/src/main/java/com/liulishuo/filedownloader/PauseAllMarker.java index <HASH>..<HASH> 100644 --- a/library/src/main/java/com/liulishuo/filedownloader/PauseAllMarker.java +++ b/library/src/main/java/com/liulishuo/filedownloader/PauseAllMarker.java @@ -26,6 +26,7 @@ import java.io.IOException; public class PauseAllMarker { private static final String MAKER_FILE_NAME = ".filedownloader_pause_all_marker.b"; + private static File markerFile; @SuppressWarnings("ResultOfMethodCallIgnored") public static void createMarker(Context context) { @@ -44,7 +45,10 @@ public class PauseAllMarker { } private static File markerFile(Context context) { - return new File(context.getCacheDir() + File.separator + MAKER_FILE_NAME); + if (markerFile == null) { + markerFile = new File(context.getCacheDir() + File.separator + MAKER_FILE_NAME); + } + return markerFile; } public static boolean isMarked(Context context) {
refactor: use lazy marker file instead of creating marker file every time Closes #<I>
lingochamp_FileDownloader
train
java
8b1f19f56ddc31a49445334ddc8abe2162b4b760
diff --git a/lib/icon/module.js b/lib/icon/module.js index <HASH>..<HASH> 100755 --- a/lib/icon/module.js +++ b/lib/icon/module.js @@ -219,7 +219,7 @@ async function resizeIcons (options) { await fs.mkdirp(options.cacheDir) await new Promise((resolve, reject) => { - const child = fork(require.resolve('./resize'), [resizeOpts]) + const child = fork(require.resolve('./resize'), [resizeOpts], { execArgv: [] }) child.on('exit', (code) => { return code ? reject(code) : resolve() })
fix(icon): fork without original process args (#<I>)
nuxt-community_pwa-module
train
js
935a39082147914446ee4a3f6211a9d6af088481
diff --git a/Gruntfile.js b/Gruntfile.js index <HASH>..<HASH> 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -203,9 +203,6 @@ module.exports = function (grunt) { // Default }, sauce: { - sauceLabs: { - testName: 'Angular ApiMock with multiple browsers', - }, browsers: ['SL_Chrome', 'SL_Firefox', 'SL_Safari', 'SL_iOS', /*'SL_IE_8', */'SL_IE_9', 'SL_IE_10', 'SL_IE_11'], reporters: [ 'progress', 'saucelabs' ], files: [{
chore(travis): don't overwrite SauceLab config from Karma The Karma config detects Travis and sets `startConnect` to `false`, but this overwrite in Grunt was putting it back to the default of `true`. This is probably why Travis is failing with connection issues, as it tries to create a connection when it’s already open.
seriema_angular-apimock
train
js
d29adc2a747b148333a3d59a96df829af6f2f027
diff --git a/src/main/launch.js b/src/main/launch.js index <HASH>..<HASH> 100644 --- a/src/main/launch.js +++ b/src/main/launch.js @@ -1,6 +1,6 @@ import path from "path"; -import { shell, BrowserWindow } from "electron"; +import { shell, BrowserWindow, dialog } from "electron"; let launchIpynb; @@ -36,6 +36,29 @@ export function launch(filename) { const index = path.join(__dirname, "..", "..", "static", "index.html"); win.loadURL(`file://${index}`); + let actuallyExit = false; + + win.on("close", e => { + if (!actuallyExit) { + e.preventDefault(); + dialog.showMessageBox( + { + type: "question", + buttons: ["Yes", "No"], + title: "Confirm", + message: "Unsaved data will be lost. Are you sure you want to quit?" + }, + function(response) { + if (response === 0) { + e.returnValue = false; + actuallyExit = true; + win.close(); + } + } + ); + } + }); + win.webContents.on("did-finish-load", () => { if (filename) { win.webContents.send("main:load", filename);
feat(app): prompt before closing window
nteract_nteract
train
js
ee869f5e61faa1916b23194fccc857d34d5673f5
diff --git a/lib/platform/github/gh-got-wrapper.js b/lib/platform/github/gh-got-wrapper.js index <HASH>..<HASH> 100644 --- a/lib/platform/github/gh-got-wrapper.js +++ b/lib/platform/github/gh-got-wrapper.js @@ -21,7 +21,7 @@ async function get(path, options, retries = 5) { } logger.trace(`${method.toUpperCase()} ${path}`); stats.requests = (stats.requests || []).concat([ - method.toUpperCase() + ' ' + path.replace(opts.endpoint, ''), + method.toUpperCase() + ' ' + path, ]); try { if (global.appMode) {
refactor: log full path for requests array
renovatebot_renovate
train
js
badf68f5a0fad7ebd9615e44f90d3e0a84a09dc0
diff --git a/src/Keboola/Json/Struct.php b/src/Keboola/Json/Struct.php index <HASH>..<HASH> 100644 --- a/src/Keboola/Json/Struct.php +++ b/src/Keboola/Json/Struct.php @@ -234,9 +234,15 @@ class Struct /** * Return all structure definitions as an array * @return array + * @deprecated */ public function getStruct() { + return $this->getData(); + } + + public function getData() + { return $this->struct; }
feat: deprecated Struct::getStruct() replaced by Struct::getData()
keboola_php-jsonparser
train
php
37bf89a017ca162042e6b21425623d7354e0d80e
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -38,15 +38,13 @@ setup( url='https://github.com/thiagopbueno/tf-rddlsim', packages=find_packages(), scripts=['scripts/tfrddlsim', 'tfrddlsim/viz/plots/plot_navigation_policy'], + python_requires=">=3.6", install_requires=[ + 'tensorflow<2.0.0', 'matplotlib', - 'numpy', - 'pyrddl>=0.1.8', - 'rddlgym>=0.5.8', - 'rddl2tf>=0.5.1', - 'tensorflow<=1.15', - 'tensorflow-tensorboard', - 'typing' + 'typing', + 'pyrddl', + 'rddlgym', ], include_package_data=True, zip_safe=False,
refactor: update python and install_requires in setup.py
thiagopbueno_tf-rddlsim
train
py
f1e1223cdf8f3fdf0adb7a1538a733dee87b7812
diff --git a/packages/node_modules/@webex/plugin-meetings/src/meetings/util.js b/packages/node_modules/@webex/plugin-meetings/src/meetings/util.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/plugin-meetings/src/meetings/util.js +++ b/packages/node_modules/@webex/plugin-meetings/src/meetings/util.js @@ -84,7 +84,7 @@ MeetingsUtil.hasH264Codec = async () => { pc.close(); } catch (error) { - LoggerProxy.logger.error('Meetings:util#hasH264Codec --> Error creating peerConnection for H.264 test.'); + LoggerProxy.logger.warn('Meetings:util#hasH264Codec --> Error creating peerConnection for H.264 test.'); } return hasCodec;
fix(plugins-meetings): warn if H<I> codec is not detected
webex_spark-js-sdk
train
js
f908fb435ccbe0b11bbf68752c60544e3e4e314f
diff --git a/src/OrderByViewsScope.php b/src/OrderByViewsScope.php index <HASH>..<HASH> 100644 --- a/src/OrderByViewsScope.php +++ b/src/OrderByViewsScope.php @@ -31,8 +31,8 @@ class OrderByViewsScope $unique = ($options['unique'] ?? false) === true; $descending = ($options['descending'] ?? false) === true; $direction = $descending ? SortDirection::DESCENDING : SortDirection::ASCENDING; - $period = $options['period']; - $collection = $options['collection']; + $period = $options['period'] ?? null; + $collection = $options['collection'] ?? null; $viewable = $query->getModel(); $viewModel = app(ViewContract::class);
fix: add null as fallback value
cyrildewit_eloquent-viewable
train
php
15d4cb03bda0d0708a52dc2d1f2fdb56cd8f3e48
diff --git a/packages/xod-core/src/fs/extract.js b/packages/xod-core/src/fs/extract.js index <HASH>..<HASH> 100644 --- a/packages/xod-core/src/fs/extract.js +++ b/packages/xod-core/src/fs/extract.js @@ -1,5 +1,5 @@ import R from 'ramda'; -import { notNil, hasNot } from './ramda'; +import { notNil, hasNot } from '../utils/ramda'; const getParentFoldersPath = (folders, folder, path) => { const newPath = R.prepend(
fix(extract): fix path to ramda utils
xodio_xod
train
js
bd8d769457f441bc561f9ab59759befef6523d0b
diff --git a/scripts/travis.js b/scripts/travis.js index <HASH>..<HASH> 100644 --- a/scripts/travis.js +++ b/scripts/travis.js @@ -40,8 +40,10 @@ spawn(bin('istanbul'), [ proc.on('exit', function(code) { process.exit(0); }).on('error', function(err) { + err.message += ' in ' + bin('minijasminenode2'); throw err; }); }).on('error', function(err) { + err.message += ' in ' + bin('istanbul'); throw err; });
chore(scripts): and again...
stefanpenner_broccoli-persistent-filter
train
js
a5935a9984d6667664b72bbdcf4962632ad0627d
diff --git a/src/ai/backend/client/cli/run.py b/src/ai/backend/client/cli/run.py index <HASH>..<HASH> 100644 --- a/src/ai/backend/client/cli/run.py +++ b/src/ai/backend/client/cli/run.py @@ -584,7 +584,7 @@ def run(image, files, name, # base args domain_name=domain, group_name=group, scaling_group=scaling_group, - bootstrap_script=bootstrap_script.read(), + bootstrap_script=bootstrap_script.read() if bootstrap_script is not None else None, tag=tag, preopen_ports=preopen_ports) except Exception as e: @@ -864,7 +864,7 @@ def start(image, name, owner, # base args domain_name=domain, group_name=group, scaling_group=scaling_group, - bootstrap_script=bootstrap_script.read(), + bootstrap_script=bootstrap_script.read() if bootstrap_script is not None else None, tag=tag, preopen_ports=preopen_ports) except Exception as e:
fix: nullify unspecified bootstrap_script (#<I>)
lablup_backend.ai-client-py
train
py
a7ea4e58cef2503e1de269e3b4bf3b74ac8a42a1
diff --git a/examples/todomvc/backend/handler/handler.go b/examples/todomvc/backend/handler/handler.go index <HASH>..<HASH> 100644 --- a/examples/todomvc/backend/handler/handler.go +++ b/examples/todomvc/backend/handler/handler.go @@ -72,7 +72,7 @@ func NewHandler( // Simple HTTP request logging middleware as final handler. handler := http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { - log.Println(r.Method, r.URL) + log.Printf("%s %s\n", r.Method, r.URL.EscapedPath()) h.ServeHTTP(w, r) })
fix: escape logging in TodoMVC example
looplab_eventhorizon
train
go
628d9c82bf993a3635ec456aff985cc74d45eb94
diff --git a/grunt/config/browserify.js b/grunt/config/browserify.js index <HASH>..<HASH> 100644 --- a/grunt/config/browserify.js +++ b/grunt/config/browserify.js @@ -36,7 +36,7 @@ module.exports = function(config) { '@babel/preset-env', { targets: - 'ie 11, last 1 chrome version, last 1 firefox version, last 1 edge version', + 'last 1 chrome version, last 1 firefox version, last 1 edge version', forceAllTransforms: true, useBuiltIns: 'usage', corejs: 3 @@ -69,7 +69,7 @@ module.exports = function(config) { '@babel/preset-env', { targets: - 'ie 11, last 1 chrome version, last 1 firefox version, last 1 edge version', + 'last 1 chrome version, last 1 firefox version, last 1 edge version', forceAllTransforms: true, useBuiltIns: 'usage', corejs: 3 @@ -102,7 +102,7 @@ module.exports = function(config) { '@babel/preset-env', { targets: - 'ie 11, last 1 chrome version, last 1 firefox version, last 1 edge version', + 'last 1 chrome version, last 1 firefox version, last 1 edge version', forceAllTransforms: true, useBuiltIns: 'usage', corejs: 3
chore(build): remove IE<I> support related to CAM-<I>
camunda_camunda-bpm-sdk-js
train
js
24f24c09c3dd056a8cc314794fdf2ee888ceddeb
diff --git a/lib/inspectors/data.js b/lib/inspectors/data.js index <HASH>..<HASH> 100644 --- a/lib/inspectors/data.js +++ b/lib/inspectors/data.js @@ -109,7 +109,8 @@ function emitDataEvents(req, res, proxy) { requestTime = Date.now(); unzipBody(req, reqBody, function(err, body) { data.requestTime = requestTime; - reqData.body = err ? util.getErrorStack(err) : body; + reqBody = err ? util.getErrorStack(err) : body; + reqData.body = reqBody; checkBodySize(reqData); unzipResBody && unzipResBody(); }); @@ -149,7 +150,8 @@ function emitDataEvents(req, res, proxy) { unzipResBody = function() { unzipResBody = null; unzipBody(res, resBody, function(err, body) { - resData.body = err ? util.getErrorStack(err) : body; + resBody = err ? util.getErrorStack(err) : body; + resData.body = resBody; checkBodySize(resData); data.endTime = endTime; reqEmitter.emit('end', data);
refactor: the cache of request data
avwo_whistle
train
js
68369ee7377c0b19ddace746041a99fce674e715
diff --git a/model/exclusionList/ExclusionListService.php b/model/exclusionList/ExclusionListService.php index <HASH>..<HASH> 100644 --- a/model/exclusionList/ExclusionListService.php +++ b/model/exclusionList/ExclusionListService.php @@ -48,7 +48,7 @@ abstract class ExclusionListService extends OntologyClassService { if ($this->names === null) { $nameInstances = $this->getNameProperty()->getRange()->getInstances(); - + $this->names = []; foreach ($nameInstances as $nameInstance) { $this->names[strtolower($nameInstance->getLabel())] = $nameInstance->getUri(); } @@ -61,7 +61,7 @@ abstract class ExclusionListService extends OntologyClassService { if ($this->excluded === null) { $instances = $this->getRootClass()->getInstances(true); - + $this->excluded = []; foreach ($instances as $instance) { $properties = $instance->getPropertiesValues([ $this->getNameProperty(), @@ -75,7 +75,6 @@ abstract class ExclusionListService extends OntologyClassService $this->excluded[$excludedName][] = $excludedVersion; } - } }
fix: bad initialisation of the exclude list if it is empty
oat-sa_extension-tao-clientdiag
train
php
54f8c772c1f1ac64cd8415fe1c5546de996c5ac9
diff --git a/.toys/release/please.rb b/.toys/release/please.rb index <HASH>..<HASH> 100644 --- a/.toys/release/please.rb +++ b/.toys/release/please.rb @@ -142,7 +142,8 @@ def build_command dir, gem_name, cur_version, release_as cmd += ["--last-package-version", cur_version] if cur_version && cur_version >= "0.1" cmd += ["--release-as", release_as] if release_as cmd += ["--token", github_token] if github_token - cmd += ["--version-file", version_file] if version_file + version_path = version_file || default_version_path(dir, gem_name) + cmd += ["--version-file", version_path] if version_path cmd end @@ -155,3 +156,8 @@ def default_repo_url exit 1 end end + +def default_version_path dir, gem_name + gem_path = gem_name.gsub "-", "/" + File.join "lib", gem_path, "version.rb" +end
chore: Release-please automatically determines the path to the version file (#<I>)
googleapis_google-cloud-ruby
train
rb
c40f43823cd42241c31bfa30a640a31e7d38a6fd
diff --git a/pandas/tests/io/test_compression.py b/pandas/tests/io/test_compression.py index <HASH>..<HASH> 100644 --- a/pandas/tests/io/test_compression.py +++ b/pandas/tests/io/test_compression.py @@ -11,6 +11,8 @@ import zipfile import pytest +from pandas.compat import is_platform_windows + import pandas as pd import pandas._testing as tm @@ -325,5 +327,10 @@ def test_tar_gz_to_different_filename(): members = archive.getmembers() assert len(members) == 1 content = archive.extractfile(members[0]).read().decode("utf8") - content = content.replace("\r\n", "\n") # windows - assert content == "foo,bar\n1,2\n" + + if is_platform_windows(): + expected = "foo,bar\r\n1,2\r\n" + else: + expected = "foo,bar\n1,2\n" + + assert content == expected
refactor: use is_platform_windows() (#<I>)
pandas-dev_pandas
train
py
785f84819dc942f7af1521fabb165d8b9696c86f
diff --git a/src/Metadata/ApiResource.php b/src/Metadata/ApiResource.php index <HASH>..<HASH> 100644 --- a/src/Metadata/ApiResource.php +++ b/src/Metadata/ApiResource.php @@ -509,12 +509,12 @@ class ApiResource return $self; } - public function getStatus(): ?string + public function getStatus() { return $this->status; } - public function withStatus(?string $status = null): self + public function withStatus($status = null): self { $self = clone $this; $self->status = $status;
fix(resource): status can not be typed yet
api-platform_core
train
php
437cff5c539a38b61e122af13534681a550ff0fb
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -15,6 +15,12 @@ long_description = short_description if os.path.exists('README.rst'): long_description = open('README.rst').read() +tests_require = [ + 'minimock', + 'pytest', + 'pytest-cover' +] + setup( name="helperlibs", @@ -30,7 +36,7 @@ setup( 'helperlibs.tests', 'helperlibs.tests.bio', 'helperlibs.tests.wrappers'], install_requires=['BioPython>=1.62'], - tests_require=['minimock', 'pytest', 'pytest-cover'], + tests_require=tests_require, classifiers=[ "Development Status :: 3 - Alpha", "Topic :: Scientific/Engineering :: Bio-Informatics",
chore: Fix tests_require in setup.py
kblin_bioinf-helperlibs
train
py
fe09cecae7714bc7cca9fbf29413849f3db1ebaf
diff --git a/src/utils.js b/src/utils.js index <HASH>..<HASH> 100644 --- a/src/utils.js +++ b/src/utils.js @@ -8,8 +8,12 @@ const RE_NUM = (/[\-+]?(?:\d*\.|)\d+(?:[eE][\-+]?\d+|)/).source; let getComputedStyleX; -function force(x, y) { - return x + y; +// https://stackoverflow.com/a/3485654/3040605 +function forceRelayout(elem) { + const originalStyle = elem.style.display; + elem.style.display = 'none'; + elem.offsetHeight; // eslint-disable-line + elem.style.display = originalStyle; } function css(el, name, v) { @@ -244,6 +248,8 @@ function setLeftTop(elem, offset, option) { elem.style[oppositeVerticalProperty] = ''; elem.style[verticalProperty] = `${presetV}px`; } + // force relayout + forceRelayout(elem); const old = getOffset(elem); const originalStyle = {}; for (const key in offset) { @@ -260,7 +266,7 @@ function setLeftTop(elem, offset, option) { } css(elem, originalStyle); // force relayout - force(elem.offsetTop, elem.offsetLeft); + forceRelayout(elem); if ('left' in offset || 'top' in offset) { setTransitionProperty(elem, originalTransition); }
fix: position properties not match to style object (#<I>) close ant-design/ant-design#<I> close ant-design/ant-design-pro#<I>
yiminghe_dom-align
train
js
ff5a7586070b8a6684272de2bbd57dca25e24cfd
diff --git a/packages/js/test/unit/src/lib/util.js b/packages/js/test/unit/src/lib/util.js index <HASH>..<HASH> 100644 --- a/packages/js/test/unit/src/lib/util.js +++ b/packages/js/test/unit/src/lib/util.js @@ -34,7 +34,8 @@ describe("util", function () { it("sorts posts by descending `#date`", function () { const stubPhotos = [ Photo.fromJS({id: "grr", dateCreated: new Date(1991, 10, 14)}), - Photo.fromJS({id: "woof", datePublished: new Date()}), + Photo.fromJS({id: "woof", datePublished: new Date(Date.now() + 2000)}), + Photo.fromJS({id: "rawr", datePublished: new Date(Date.now() - 2000)}), Photo.fromJS({id: "meow", dateCreated: new Date(1991, 10, 14)}) ]; @@ -47,8 +48,9 @@ describe("util", function () { }); expect(sortedPhotos.map(sortedPhoto => sortedPhoto.id)).to.eql([ stubPhotos[1].id, + stubPhotos[2].id, stubPhotos[0].id, - stubPhotos[2].id + stubPhotos[3].id ]); }); });
chore(js): Add some more coverage around `sortPostsByDate`. Guess we were benefiting from some coverage from `@randy.tarampi/posts`?
randytarampi_me
train
js
9a34f0a419b1a704b29a7ebeb98b7ec2a0824497
diff --git a/packages/node_modules/@ciscospark/plugin-teams/test/integration/spec/teams.js b/packages/node_modules/@ciscospark/plugin-teams/test/integration/spec/teams.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@ciscospark/plugin-teams/test/integration/spec/teams.js +++ b/packages/node_modules/@ciscospark/plugin-teams/test/integration/spec/teams.js @@ -12,7 +12,6 @@ import {assert} from '@ciscospark/test-helper-chai'; import sinon from '@ciscospark/test-helper-sinon'; import testUsers from '@ciscospark/test-helper-test-users'; import {find} from 'lodash'; -import {nodeOnly} from '@ciscospark/test-helper-mocha'; const http = require('http'); const path = require('path'); @@ -81,11 +80,11 @@ describe('plugin-teams', function () { spark = new CiscoSpark({credentials: user.token}); })); - nodeOnly(before)(() => { + before(() => { proxy.listen(3000); }); - nodeOnly(after)(() => proxy.close()); + after(() => proxy.close()); describe('#teams', () => { describe('#create()', () => {
refactor(plugin-teams): remove nodeOnly, which does not work
webex_spark-js-sdk
train
js
5d979caa321e0df98145e1de2f4323d3e341d7cb
diff --git a/lib/carlo.js b/lib/carlo.js index <HASH>..<HASH> 100644 --- a/lib/carlo.js +++ b/lib/carlo.js @@ -85,6 +85,7 @@ class App extends EventEmitter { */ async exit() { await this.browser_.close(); + this.emit(App.Events.Exit); } /** @@ -233,7 +234,7 @@ class App extends EventEmitter { windowClosed_(window) { this.windows_.delete(window.page_); if (!this.windows_.size) - this.emit(App.Events.Exit); + this.exit(); } } @@ -586,7 +587,8 @@ class Window extends EventEmitter { } closeBrowser() { - this.app_.emit(App.Events.Exit); + // Allow rpc response to land. + setTimeout(() => this.app_.exit(), 0); } }
fix(exit): gracefully close the browser upon exiting
GoogleChromeLabs_carlo
train
js
bd3e08aee0425ff2cf5d4c04db83304892fde742
diff --git a/spec/mysql/cli/ridgepole_spec.rb b/spec/mysql/cli/ridgepole_spec.rb index <HASH>..<HASH> 100644 --- a/spec/mysql/cli/ridgepole_spec.rb +++ b/spec/mysql/cli/ridgepole_spec.rb @@ -46,6 +46,7 @@ describe 'ridgepole' do --index-removed-drop-column --skip-drop-table --mysql-change-table-options + --mysql-change-table-comment --check-relation-type DEF_PK --ignore-table-comment --skip-column-comment-change
test: fix failed specs for CLI
winebarrel_ridgepole
train
rb
68a376909bf3b1a9ec9401cff52513c63ee9c406
diff --git a/packages/node_modules/@webex/plugin-attachment-actions/src/attachmentActions.js b/packages/node_modules/@webex/plugin-attachment-actions/src/attachmentActions.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/plugin-attachment-actions/src/attachmentActions.js +++ b/packages/node_modules/@webex/plugin-attachment-actions/src/attachmentActions.js @@ -19,7 +19,9 @@ import { const AttachmentActions = WebexPlugin.extend({ /** - * Initializer + * Initializer used to generate an AttachmentActions + * as a plugin wrapped around the provided arguments. + * @see WebexPlugin.initialize * @param {...any} args * @returns {undefined} */
docs(plugin-attachment-actions): enhance initializer jsdoc Enhance the current initializer JS Doc for the attachment actions plugin.
webex_spark-js-sdk
train
js
b62759caf77545b69368b8a81018aca7046dda60
diff --git a/lib/plugin.js b/lib/plugin.js index <HASH>..<HASH> 100644 --- a/lib/plugin.js +++ b/lib/plugin.js @@ -17,6 +17,10 @@ var initCommonJS = function(/* config.files */ files) { var createPreprocesor = function(logger, config, basePath) { var log = logger.create('preprocessor.commonjs'); var modulesRootPath = path.resolve(config && config.modulesRoot ? config.modulesRoot : path.join(basePath, 'node_modules')); + //normalize root path on Windows + if (process.platform === 'win32') { + modulesRootPath = modulesRootPath.replace(/\\/g, '/'); + } log.debug('Configured root path for modules "%s".', modulesRootPath);
fix: properly prepare root path on windows
karma-runner_karma-commonjs
train
js
813b3ab68a7ab6e2493aaa25f6793618fb1a506f
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -840,6 +840,7 @@ export default class ReactJkMusicPlayer extends PureComponent { lyric: '', currentLyric: '', playId: this.initPlayId, + loadedProgress: 0, }) }
fix: reset audio loaded progress when clear audio
lijinke666_react-music-player
train
js
994555d7d6eb7bf960adceed4a59a4f667a9d92d
diff --git a/scripts/pkg/config.js b/scripts/pkg/config.js index <HASH>..<HASH> 100644 --- a/scripts/pkg/config.js +++ b/scripts/pkg/config.js @@ -11,6 +11,9 @@ module.exports = { '../../lib/plugins/aws/package/lib/*.json', // Service templates '../../lib/plugins/create/templates', + // Dashboard wrappers + '../../node_modules/@serverless/enterprise-plugin/sdk-js/dist/index.js', + '../../node_modules/@serverless/enterprise-plugin/sdk-py', // Ensure npm is bundled as a dependency '../../node_modules/npm/bin/npm-cli.js', // Below module is not automatically traced by pkg, we need to point it manually
fix(Standalone): Ensure dashboard wrapper is bundled
serverless_serverless
train
js
f8963b9a80eb4676a440cb4e1d9eca61e3f1153d
diff --git a/test/spec/logic/calendar.factory.spec.js b/test/spec/logic/calendar.factory.spec.js index <HASH>..<HASH> 100644 --- a/test/spec/logic/calendar.factory.spec.js +++ b/test/spec/logic/calendar.factory.spec.js @@ -276,7 +276,7 @@ cal.registerTimeFrames(inputTimeFrames); cal.registerDateFrames(inputDateFrames); - var timeFrames = cal.getTimeFrames(moment().month(10).date(11)); + var timeFrames = cal.getTimeFrames(moment().year(2016).month(10).date(11)); timeFrames = cal.solve(timeFrames); expect(timeFrames.length).toBe(1); @@ -285,7 +285,7 @@ expect(timeFrames[0].classes.length).toBe(1); expect(timeFrames[0].classes[0]).toBe('gantt-timeframe-holiday'); - timeFrames = cal.getTimeFrames(moment().day(6)); + timeFrames = cal.getTimeFrames(moment().month(0).day(6)); timeFrames = cal.solve(timeFrames); expect(timeFrames.length).toBe(1);
fix(test): Fix an issue when running tests in <I> <I> November is also a week-end.
angular-gantt_angular-gantt
train
js
a74352644ecc1f377c88f68d10685573ff8e064a
diff --git a/superset/utils/webdriver.py b/superset/utils/webdriver.py index <HASH>..<HASH> 100644 --- a/superset/utils/webdriver.py +++ b/superset/utils/webdriver.py @@ -137,7 +137,7 @@ class WebDriverProxy: ] logger.debug("Wait %i seconds for chart animation", selenium_animation_wait) sleep(selenium_animation_wait) - logger.info("Taking a PNG screenshot or url %s", url) + logger.info("Taking a PNG screenshot of url %s", url) img = element.screenshot_as_png except TimeoutException: logger.warning("Selenium timed out requesting url %s", url, exc_info=True)
fix: typo in log (#<I>)
apache_incubator-superset
train
py
824c909e2ac1c883252ef9229f4489a8fa515238
diff --git a/npm/install.js b/npm/install.js index <HASH>..<HASH> 100755 --- a/npm/install.js +++ b/npm/install.js @@ -22,7 +22,8 @@ if (isInstalled()) { const platform = process.env.npm_config_platform || process.platform; let arch = process.env.npm_config_arch || process.arch; -if (platform === 'darwin' && process.platform === 'darwin' && arch === 'x64') { +if (platform === 'darwin' && process.platform === 'darwin' && arch === 'x64' && + process.env.npm_config_arch === undefined) { // When downloading for macOS ON macOS and we think we need x64 we should // check if we're running under rosetta and download the arm64 version if appropriate try {
fix: Allow npm_config_arch override on mac (#<I>) If the npm_config_arch environment variable is set on Mac, then use the specified architecture rather than overriding it to x<I>.
electron_electron
train
js