hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
342c23514d9f6d4fbbc2bc8f0f6ba80854393c54
|
diff --git a/src/services/campaigns/enum/AttributionModelEnum.php b/src/services/campaigns/enum/AttributionModelEnum.php
index <HASH>..<HASH> 100644
--- a/src/services/campaigns/enum/AttributionModelEnum.php
+++ b/src/services/campaigns/enum/AttributionModelEnum.php
@@ -11,4 +11,5 @@ class AttributionModelEnum extends Enum
public const LC = "LC";
public const LSC = "LSC";
public const LYDC = "LYDC";
+ public const LYDCCD = "LYDCCD";
}
|
fix(campaigns): add new attribution model - LYDCCD
|
sitkoru_yandex-direct-api
|
train
|
php
|
49794693913ce6d7c15647f5272572771f279828
|
diff --git a/includes/edu-question-functions.php b/includes/edu-question-functions.php
index <HASH>..<HASH> 100644
--- a/includes/edu-question-functions.php
+++ b/includes/edu-question-functions.php
@@ -149,11 +149,8 @@ function edu_render_number_question( $question, $multiple, $suffix ) {
function edu_render_info_text( $question ) {
if ( ! empty( $question['QuestionText'] ) ) {
- echo '<div class="edu-question-info questionanswer_id_' . esc_attr( $question['AnswerId'] ) . '">';
+ echo '<div class="edu-question-info questionanswer_id_q' . esc_attr( $question['QuestionId'] ) . '">';
echo '<div class="inputLabel questionInfoQuestion">' . esc_html( wp_strip_all_tags( $question['QuestionText'] ) ) . '</div>';
- echo '<div class="questionInfoText" data-type="infotext">';
- echo wp_kses( $question->Answers->EventBookingAnswer->AnswerText, wp_kses_allowed_html( 'post' ) );
- echo '</div></div>';
}
}
|
fix: Fixed render info text-function (still not fully converted from old soap)
|
MultinetInteractive_EduAdmin-WordPress
|
train
|
php
|
42c7e42739c0f904dfbde3e011fdf07697807391
|
diff --git a/lib/imgix/client.rb b/lib/imgix/client.rb
index <HASH>..<HASH> 100644
--- a/lib/imgix/client.rb
+++ b/lib/imgix/client.rb
@@ -65,7 +65,7 @@ module Imgix
# method.
def create_request(endpoint, resource, data_fmt = :json_data_from)
req = Net::HTTP::Post.new(endpoint.path)
- req["Content-Type"] = "application/json"
+ req["Content-Type"] = "application/vnd.api+json"
req["Authorization"] = "Bearer #{@api_key}"
req["User-Agent"] = "imgix #{@library}-#{@version}"
diff --git a/test/units/purge_test.rb b/test/units/purge_test.rb
index <HASH>..<HASH> 100644
--- a/test/units/purge_test.rb
+++ b/test/units/purge_test.rb
@@ -46,7 +46,7 @@ class PurgeTest < Imgix::Test
"Accept" => "*/*",
"Accept-Encoding" => "gzip;q=1.0,deflate;q=0.6,identity;q=0.3",
"Authorization" => "Bearer #{mock_api_key}",
- "Content-Type" => "application/json",
+ "Content-Type" => "application/vnd.api+json",
"User-Agent" => "imgix rb-#{Imgix::VERSION}"
}
end
|
refactor: use /vnd.api+json over /json
|
imgix_imgix-rb
|
train
|
rb,rb
|
deaad6b423a9045b4cccfda30ebf0653b8ae87df
|
diff --git a/lib/plugins/filter/before_post_render/backtick_code_block.js b/lib/plugins/filter/before_post_render/backtick_code_block.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/filter/before_post_render/backtick_code_block.js
+++ b/lib/plugins/filter/before_post_render/backtick_code_block.js
@@ -50,6 +50,7 @@ function backtickCodeBlock(data) {
}
}
+ // PR #3765
const endOfStart = start.split('\n').pop();
if (endOfStart && endOfStart.includes('>')) {
const depth = endOfStart.split('>').length - 1;
|
docs(backtick_code): mention PR #<I>
|
hexojs_hexo
|
train
|
js
|
faf127371fa004b415d6bd850b5d118e2be3342a
|
diff --git a/src/db/src/QueryBuilder.php b/src/db/src/QueryBuilder.php
index <HASH>..<HASH> 100644
--- a/src/db/src/QueryBuilder.php
+++ b/src/db/src/QueryBuilder.php
@@ -506,7 +506,7 @@ class QueryBuilder implements QueryBuilderInterface
* - ['id', '<', 13]
* - ['id', '>=', 13]
* - ['id', '<=', 13]
- * - ['id', '<>', 13]
+ * - ['id', '!=', 13]
*
* - ['id', 'in', [1, 2, 3]]
* - ['id', 'not in', [1, 2, 3]]
|
fix: db condition() comments is error
|
swoft-cloud_swoft-http-message
|
train
|
php
|
56ecb573114867545a4ca68457927bd638d6ca54
|
diff --git a/lib/export.js b/lib/export.js
index <HASH>..<HASH> 100644
--- a/lib/export.js
+++ b/lib/export.js
@@ -126,7 +126,7 @@ export const exportTranslationKeysFromFiles = async ({rootPath, filePath = '.',
logTrace(logger, err)
}
fileCount++
- progressCallback(fileCount, totalCount, file)
+ if(fileCount < totalCount) progressCallback(fileCount, totalCount, file)
}
if(fileNames.length && progress) progress(totalCount, totalCount, fileNames[fileNames.length-1].file)
const total = templates.map((i) => (i.items && i.items.length) || 1).reduce((a, b) => a + b, 0)
diff --git a/lib/validation.js b/lib/validation.js
index <HASH>..<HASH> 100644
--- a/lib/validation.js
+++ b/lib/validation.js
@@ -166,7 +166,7 @@ export const validateTranslationFiles = async ({rootPath, schemaPath, logger, pr
success = false
}
fileCount++
- progressCallback(fileCount, totalCount, file)
+ if(fileCount < totalCount) progressCallback(fileCount, totalCount, file)
}
if(fileNames.length && progress) progress(totalCount, totalCount, fileNames[fileNames.length-1].file)
if(success) {
|
refactor(progress): optimized progress callback
|
skolmer_i18n-tag-schema
|
train
|
js,js
|
a096fa45af7aaa40a09c87254aef0de864fa8ab6
|
diff --git a/packages/hooks/src/useMount.js b/packages/hooks/src/useMount.js
index <HASH>..<HASH> 100644
--- a/packages/hooks/src/useMount.js
+++ b/packages/hooks/src/useMount.js
@@ -1,5 +1,6 @@
import { useEffect } from 'react';
export default (effect) => {
- useEffect(effect, [effect]);
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ useEffect(effect, []);
};
|
fix(hooks): remove effect from dependency array in useMount
Adds eslint ignore for exhaustive deps and fixes infinite loop issue in some tests since useMount should only run once
|
Availity_availity-react
|
train
|
js
|
44214e10db1759e383bcbd9aa0610a1a4b318608
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -16,10 +16,13 @@ function getPath(resolvedResource) {
output += `!!css!`;
break;
case ".scss":
- output += `!!sass!`;
+ output += `!!css!sass!`;
break;
case ".less":
- output += `!!less!`;
+ output += `!!css!less!`;
+ break;
+ case ".styl":
+ output += `!!css!stylus!`;
break;
}
|
fix(index): use the css loader together with other CSS-processing extensions
fixes #<I>
|
aurelia_webpack-plugin
|
train
|
js
|
89be18fd28e1ef50e1a83f0f4869974a6f0d5786
|
diff --git a/core/src/main/java/com/dtolabs/rundeck/core/logging/OverridableStreamingLogWriter.java b/core/src/main/java/com/dtolabs/rundeck/core/logging/OverridableStreamingLogWriter.java
index <HASH>..<HASH> 100644
--- a/core/src/main/java/com/dtolabs/rundeck/core/logging/OverridableStreamingLogWriter.java
+++ b/core/src/main/java/com/dtolabs/rundeck/core/logging/OverridableStreamingLogWriter.java
@@ -34,6 +34,7 @@ public class OverridableStreamingLogWriter extends FilterStreamingLogWriter {
public void openStream() throws IOException {
if (getOverride() != null) {
getOverride().openStream();
+ return;
}
super.openStream();
}
@@ -42,6 +43,7 @@ public class OverridableStreamingLogWriter extends FilterStreamingLogWriter {
public void addEvent(final LogEvent event) {
if (getOverride() != null) {
getOverride().addEvent(event);
+ return;
}
super.addEvent(event);
}
@@ -50,6 +52,7 @@ public class OverridableStreamingLogWriter extends FilterStreamingLogWriter {
public void close() {
if (getOverride() != null) {
getOverride().close();
+ return;
}
super.close();
}
|
fix: override log writer emits 2 events
|
rundeck_rundeck
|
train
|
java
|
1bb54bea7c46858f3b6b5111d9fe81563cca0a98
|
diff --git a/src/file.js b/src/file.js
index <HASH>..<HASH> 100644
--- a/src/file.js
+++ b/src/file.js
@@ -71,9 +71,11 @@ module.exports = function(AV) {
* @param data {Array} The data for the file, as either:
* 1. an Array of byte value Numbers, or
* 2. an Object like { base64: "..." } with a base64-encoded String.
- * 3. a Blob(File) { blob: {uri: "..."} } selected with a file upload control.
- * 4. a Buffer in Node.js runtime.
- * 5. a Stream in Node.js runtime.
+ * 3. a Blob(File) selected with a file upload control in a browser.
+ * 4. an Object like { blob: {uri: "..."} } that mimics Blob
+ * in some non-browser environments such as React Native.
+ * 5. a Buffer in Node.js runtime.
+ * 6. a Stream in Node.js runtime.
*
* For example:<pre>
* var fileUploadControl = $("#profilePhotoFileUpload")[0];
|
docs: fix uncommited suggestions in #<I>
|
leancloud_javascript-sdk
|
train
|
js
|
d5ca5c011e86e5249a795b9cb58ec89f1531b5a4
|
diff --git a/packages/processor/processor.js b/packages/processor/processor.js
index <HASH>..<HASH> 100644
--- a/packages/processor/processor.js
+++ b/packages/processor/processor.js
@@ -113,7 +113,7 @@ class Processor {
}
// Add a file by name + contents to the dependency graph
- async string(file, text) {
+ string(file, text) {
const id = this._normalize(file);
this._log("string()", id);
|
fix: remove random async from processor.string
|
tivac_modular-css
|
train
|
js
|
484d14724c53b37723f09ae97cd68a3c07aefd3e
|
diff --git a/test/rtcpeerconnection.js b/test/rtcpeerconnection.js
index <HASH>..<HASH> 100644
--- a/test/rtcpeerconnection.js
+++ b/test/rtcpeerconnection.js
@@ -634,9 +634,10 @@ describe('Edge shim', () => {
return pc.setRemoteDescription({type: 'offer', sdp: sdp});
})
.then(() => {
+ const senders = pc.getSenders();
// the second ice transport should have been disposed.
- expect(pc.transceivers[0].iceTransport)
- .to.equal(pc.transceivers[1].iceTransport);
+ expect(senders[0].transport.transport).to
+ .equal(senders[1].transport.transport);
done();
});
});
|
test: dont use internal private transceivers API
dont use pc.transceivers in tests which is a private API
|
otalk_rtcpeerconnection-shim
|
train
|
js
|
f072c9330cfe96ae91d4c6a69a12701256cf6032
|
diff --git a/Kwf/Controller/Action/Cli/Web/SetupController.php b/Kwf/Controller/Action/Cli/Web/SetupController.php
index <HASH>..<HASH> 100644
--- a/Kwf/Controller/Action/Cli/Web/SetupController.php
+++ b/Kwf/Controller/Action/Cli/Web/SetupController.php
@@ -77,6 +77,7 @@ class Kwf_Controller_Action_Cli_Web_SetupController extends Kwf_Controller_Actio
Zend_ProgressBar_Adapter_Console::ELEMENT_TEXT));
$c->setTextWidth(50);
+ file_put_contents("update", serialize([]));
$runner = new Kwf_Util_Update_Runner($updates);
$progress = new Zend_ProgressBar($c, 0, $runner->getProgressSteps());
$runner->setProgressBar($progress);
@@ -99,6 +100,7 @@ class Kwf_Controller_Action_Cli_Web_SetupController extends Kwf_Controller_Actio
} else {
echo "\n\nSetup finished.\nThank you for using Koala Framework.\n";
}
+ unlink("update");
exit;
}
}
|
fix: add empty update file for inital run of db setup
|
koala-framework_koala-framework
|
train
|
php
|
cf1ad335d071afbea372870302f4123b5868e93c
|
diff --git a/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js b/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
+++ b/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
@@ -222,8 +222,8 @@ skipInNode(describe)('plugin-meetings', () => {
])
]))
.then(() => {
- assert.equal(bob.meeting.sipUri, alice.emailAddress);
- assert.equal(alice.meeting.sipUri, bob.emailAddress);
+ assert.equal(bob.meeting.sipUri, alice.id);
+ assert.equal(alice.meeting.sipUri, bob.id);
assert.exists(alice.meeting.members.locusUrl);
assert.equal(alice.meeting.type, 'CALL');
assert.equal(bob.meeting.type, 'CALL');
|
test(meetings): update journey tests for email DTO removal
|
webex_spark-js-sdk
|
train
|
js
|
b6768bf20cd48f3efd5040fc2e6532ac33985609
|
diff --git a/packages/project-utils/bundling/app/index.js b/packages/project-utils/bundling/app/index.js
index <HASH>..<HASH> 100644
--- a/packages/project-utils/bundling/app/index.js
+++ b/packages/project-utils/bundling/app/index.js
@@ -1,6 +1,7 @@
module.exports.buildApp = options => {
process.env.NODE_ENV = "production";
process.env.REACT_APP_ENV = "browser";
+ process.env.REACT_APP_USER_ID = require("@webiny/cli/config").getId();
return require("./createProdConfig")(options);
};
|
fix(project-utils): set anonymous user id during production build
|
Webiny_webiny-js
|
train
|
js
|
5047a75bde21f72850e9a15088c41f472e4c63fb
|
diff --git a/model/MediaSource.php b/model/MediaSource.php
index <HASH>..<HASH> 100644
--- a/model/MediaSource.php
+++ b/model/MediaSource.php
@@ -54,6 +54,9 @@ class MediaSource extends Configurable implements MediaManagement, ProcessedFile
/** @var MediaBrowserPermissionsMapper */
private $permissionsMapper;
+ /** @var string[] */
+ private $tmpFiles = [];
+
public function enableAccessControl(): AccessControlEnablerInterface
{
$this->getPermissionsMapper()->enableAccessControl();
@@ -206,6 +209,9 @@ class MediaSource extends Configurable implements MediaManagement, ProcessedFile
fwrite($fh, $stream->read(1048576));
}
fclose($fh);
+
+ $this->tmpFiles[] = $filename;
+
return $filename;
}
@@ -428,4 +434,13 @@ class MediaSource extends Configurable implements MediaManagement, ProcessedFile
return $this->permissionsMapper;
}
+
+ public function __destruct()
+ {
+ foreach ($this->tmpFiles as $tmpFile) {
+ if (is_writable($tmpFile)) {
+ unlink($tmpFile);
+ }
+ }
+ }
}
|
feat: clear tmp files (#<I>)
* feat: clear tmp files
|
oat-sa_extension-tao-mediamanager
|
train
|
php
|
aec2f6f6de1a628602f13ca5ed22da217091082b
|
diff --git a/model/classes/Copier/AssetClassCopier.php b/model/classes/Copier/AssetClassCopier.php
index <HASH>..<HASH> 100644
--- a/model/classes/Copier/AssetClassCopier.php
+++ b/model/classes/Copier/AssetClassCopier.php
@@ -35,8 +35,6 @@ use Psr\Log\LoggerInterface;
class AssetClassCopier implements ClassCopierInterface
{
- private const ROOT_CLASS_URI = TaoMediaOntology::CLASS_URI_MEDIA_ROOT;
-
/** @var LoggerInterface */
private $logger;
@@ -111,7 +109,7 @@ class AssetClassCopier implements ClassCopierInterface
sprintf(
'Selected class (%s) is not supported because it is not part of the media assets root class (%s).',
$class->getUri(),
- self::ROOT_CLASS_URI
+ TaoMediaOntology::CLASS_URI_MEDIA_ROOT
)
);
}
|
chore: Use TaoMediaOntology constants directly
|
oat-sa_extension-tao-mediamanager
|
train
|
php
|
02bd7a63882bcd41f37d05cd40997dd6dce88059
|
diff --git a/packages/cli-plugin-deploy-pulumi/commands/destroy.js b/packages/cli-plugin-deploy-pulumi/commands/destroy.js
index <HASH>..<HASH> 100644
--- a/packages/cli-plugin-deploy-pulumi/commands/destroy.js
+++ b/packages/cli-plugin-deploy-pulumi/commands/destroy.js
@@ -3,8 +3,8 @@ const { createPulumiCommand, processHooks } = require("../utils");
module.exports = createPulumiCommand({
name: "destroy",
createProjectApplicationWorkspace: false,
- command: async ({ inputs, context, projectApplication, pulumi }) => {
- const { env, folder, getDuration } = inputs;
+ command: async ({ inputs, context, projectApplication, pulumi, getDuration }) => {
+ const { env, folder } = inputs;
let stackExists = true;
try {
|
fix: require getDuration from command params
|
Webiny_webiny-js
|
train
|
js
|
62d61dee63e71e8e2d0ce118ee8bdfbde0c36684
|
diff --git a/src/fetchClientConfig.js b/src/fetchClientConfig.js
index <HASH>..<HASH> 100644
--- a/src/fetchClientConfig.js
+++ b/src/fetchClientConfig.js
@@ -44,19 +44,24 @@ export class FetchConfig {
},
response: (response, request) => {
return new Promise((resolve, reject) => {
+ // resolve success
if (response.ok) {
return resolve(response);
}
+ // resolve all non-authorization errors
if (response.status !== 401) {
return resolve(response);
}
+ // resolve unexpected authorization errors (not a managed request or token not expired)
if (!this.config.httpInterceptor || !this.authService.isTokenExpired()) {
return resolve(response);
}
+ // resolve expected authorization error without refresh_token setup
if (!this.config.useRefreshToken || !this.authService.getRefreshToken()) {
return resolve(response);
}
+ // refresh token and try again
return this.authService.updateToken().then(() => {
let token = this.authService.getAccessToken();
@@ -66,7 +71,7 @@ export class FetchConfig {
request.headers.set(this.config.authHeader, token);
- return this.client.fetch(request).then(resolve);
+ return this.httpClient.fetch(request).then(resolve);
});
});
}
|
fix(interceptor): fix automatic refresh token usage
usually the token gets refreshed before, so most did requests never got there anyways
|
SpoonX_aurelia-authentication
|
train
|
js
|
759e4bf29dd84508ec59ae6f6b91a9a349388af1
|
diff --git a/lib/middleware.js b/lib/middleware.js
index <HASH>..<HASH> 100644
--- a/lib/middleware.js
+++ b/lib/middleware.js
@@ -3,12 +3,13 @@
// Creates new middleware using provided options
function create (rules) {
return function redirectRoute (req, res, next) {
- const foundRule = rules.find(o => o.from.test(req.url))
+ const decodedBaseUrl = decodeURI(req.url)
+ const foundRule = rules.find(o => o.from.test(decodedBaseUrl))
if (!foundRule) {
return next()
}
- const toUrl = req.url.replace(foundRule.from, foundRule.to)
+ const toUrl = decodedBaseUrl.replace(foundRule.from, foundRule.to)
res.statusCode = foundRule.statusCode || 302
res.setHeader('Location', toUrl)
|
feat: support non-ascii URL redirects as well
|
nuxt-community_redirect-module
|
train
|
js
|
691e1e2913f04af909780585cd0cd2534ca4255a
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -39,15 +39,16 @@ function options (object) {
}, []);
}
-exports.format = function formatArgv (object) {
- var args = options(object);
- var _ = object._;
- if (_) {
- _ = Array.isArray(_) ? _ : [_];
- _ = _.map(function (value) {
- return value.toString();
- });
- args.push.apply(args, _);
+function args (object) {
+ if (object._) {
+ return (Array.isArray(object._) ? object._ : [object._])
+ .map(function (value) {
+ return value.toString();
+ });
}
- return args;
+ return [];
+}
+
+exports.format = function formatArgv (object) {
+ return options(object).concat(args(object));
};
|
refactor(formatter): split optionaless args handling into separate fn
|
bendrucker_argv-formatter
|
train
|
js
|
70964ca642e4ab95cffdb690fe687e48d12d6fca
|
diff --git a/src/backend/vuex.js b/src/backend/vuex.js
index <HASH>..<HASH> 100644
--- a/src/backend/vuex.js
+++ b/src/backend/vuex.js
@@ -146,7 +146,10 @@ export function initVuexBackend (hook, bridge) {
// Replay mutations
for (let i = snapshot.index + 1; i <= index; i++) {
const mutation = mutations[i]
- mutation.handlers.forEach(handler => handler(mutation.payload))
+ if (mutation.handlers) {
+ mutation.handlers.forEach(handler => handler(mutation.payload))
+ }
+
if (i !== index && i % SharedData.cacheVuexSnapshotsEvery === 0) {
takeSnapshot(i, state)
}
|
fix: browser env mutation.handlers is undefined (#<I>)
* Fix browser env mutation.handlers is undefined
In the latest Firefox and Google browsers, state data tree will not load for error:[mutation.handlers is undefined], because mutation handler actually passes is null (store. _mutations is empty) while pushing the handlers value as an element to the base mutations array, just add robust check.
* Fix CI lint space problem
|
vuejs_vue-devtools
|
train
|
js
|
285c1b5d2275b168ef7c8564ff2e1397ee22ade2
|
diff --git a/superset/utils/cache.py b/superset/utils/cache.py
index <HASH>..<HASH> 100644
--- a/superset/utils/cache.py
+++ b/superset/utils/cache.py
@@ -21,6 +21,7 @@ from typing import Any, Callable, Dict, Optional, Union
from flask import current_app as app, request
from flask_caching import Cache
+from flask_caching.backends import NullCache
from werkzeug.wrappers.etag import ETagResponseMixin
from superset import db
@@ -47,6 +48,9 @@ def set_and_log_cache(
cache_timeout: Optional[int] = None,
datasource_uid: Optional[str] = None,
) -> None:
+ if isinstance(cache_instance.cache, NullCache):
+ return
+
timeout = cache_timeout if cache_timeout else config["CACHE_DEFAULT_TIMEOUT"]
try:
dttm = datetime.utcnow().isoformat().split(".")[0]
|
fix: skip set and log when NullCache (#<I>)
|
apache_incubator-superset
|
train
|
py
|
a8ea89f6493483bb32fcea0a380ed0b4b5c3edc6
|
diff --git a/vyper/parser/parser_utils.py b/vyper/parser/parser_utils.py
index <HASH>..<HASH> 100644
--- a/vyper/parser/parser_utils.py
+++ b/vyper/parser/parser_utils.py
@@ -601,7 +601,7 @@ def make_setter(left, right, location, pos, in_function_call=False):
LLLnode.from_list(i, typ='int128'),
pos=pos,
array_bounds_check=False,
- ), LLLnode.from_list(None, typ=left.typ.subtype), location, pos=pos))
+ ), LLLnode.from_list(None, typ=right.typ.subtype), location, pos=pos))
return LLLnode.from_list(['with', '_L', left, ['seq'] + subs], typ=None)
# If the right side is a variable
else:
|
fix: fix typechecker for list assign None
|
ethereum_vyper
|
train
|
py
|
4a05a1289ac767c53b3d3c7dbef00ebe14b42884
|
diff --git a/views/js/uiForm.js b/views/js/uiForm.js
index <HASH>..<HASH> 100644
--- a/views/js/uiForm.js
+++ b/views/js/uiForm.js
@@ -329,6 +329,13 @@ define([
//map the wysiwyg editor to the html-area fields
$('.html-area').each(function () {
var propertyUri = this.id;
+
+ // destroy previously created editors
+ if (self.htmlEditors[propertyUri]) {
+ ckeditor.instances[propertyUri].destroy(this);
+ delete self.htmlEditors[propertyUri];
+ }
+
var editor = ckeditor.replace(this);
editor.config = ckConfigurator.getConfig(editor, 'htmlField', {resize_enabled : false });
self.htmlEditors[propertyUri] = editor;
|
fix: destroy previous ckeditors
|
oat-sa_tao-core
|
train
|
js
|
20a9326124b9375b0b1cfb726e09fdf811031f57
|
diff --git a/core/vendor/viewport.js b/core/vendor/viewport.js
index <HASH>..<HASH> 100644
--- a/core/vendor/viewport.js
+++ b/core/vendor/viewport.js
@@ -31,14 +31,16 @@
return;
}
- if (this.platform.name == 'ios') {
- if (this.platform.version >= 7 && isWebView()) {
- this.viewportElement.setAttribute('content', this.IOS7_VIEWPORT);
+ if (!this.viewportElement.getAttribute('content')) {
+ if (this.platform.name == 'ios') {
+ if (this.platform.version >= 7 && isWebView()) {
+ this.viewportElement.setAttribute('content', this.IOS7_VIEWPORT);
+ } else {
+ this.viewportElement.setAttribute('content', this.PRE_IOS7_VIEWPORT);
+ }
} else {
- this.viewportElement.setAttribute('content', this.PRE_IOS7_VIEWPORT);
+ this.viewportElement.setAttribute('content', this.DEFAULT_VIEWPORT);
}
- } else {
- this.viewportElement.setAttribute('content', this.DEFAULT_VIEWPORT);
}
function isWebView() {
|
fix(viewport): Fixed viewport overwritten issue, closes #<I>.
|
OnsenUI_OnsenUI
|
train
|
js
|
9bd243787c38c9a03ff14327b5a35876b7f6bb22
|
diff --git a/src/components/sidenav/sidenav.js b/src/components/sidenav/sidenav.js
index <HASH>..<HASH> 100644
--- a/src/components/sidenav/sidenav.js
+++ b/src/components/sidenav/sidenav.js
@@ -136,7 +136,9 @@ function mdSidenavService($mdComponentRegistry) {
* </md-button>
* </md-content>
*
- * <md-sidenav component-id="right" class="md-sidenav-right">
+ * <md-sidenav component-id="right"
+ * lock-open="$media('min-width: 333px')"
+ * class="md-sidenav-right">
* Right Nav!
* </md-sidenav>
* </div>
@@ -155,7 +157,7 @@ function mdSidenavService($mdComponentRegistry) {
* service.
* @param {expression=} lock-open When this expression evalutes to true,
* the sidenav 'locks open': it falls into the content's flow instead
- * of appearing above it.
+ * of appearing over it.
*
* A $media() function is exposed to the expression, which
* can be given a media query or one of the `sm`, `md` or `lg` presets.
|
docs(sidenav): reword and add lock-open to usage
|
angular_material
|
train
|
js
|
72053c27d3fd783a6b7f53f1af81753eb36dd3ae
|
diff --git a/lib/utils/reporters/cluster.js b/lib/utils/reporters/cluster.js
index <HASH>..<HASH> 100644
--- a/lib/utils/reporters/cluster.js
+++ b/lib/utils/reporters/cluster.js
@@ -6,6 +6,9 @@ export default class Reporter {
if (logObj.type === 'success' && logObj.args[0].startsWith('Generated ')) {
// Ignore success messages from Nuxt.Generator::generateRoute
return
+ } else if (logObj.type === 'error' && logObj.args[0].startsWith('Error generating ')) {
+ // Ignore error messages from Nuxt.Generator::generateRoute
+ return
}
if (global._ngc_log_tag) {
|
fix: also ignore error messages from Nuxt generator
|
nuxt-community_nuxt-generate-cluster
|
train
|
js
|
be8c8559f47cedf1d6d004d29c435d0bff7ec0c0
|
diff --git a/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js b/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
+++ b/packages/node_modules/@webex/plugin-meetings/test/integration/spec/journey.js
@@ -482,10 +482,7 @@ skipInNode(describe)('plugin-meetings', () => {
.then((response) => {
assert.equal(response[0].result.memberId, alice.meeting.selfId);
}),
- testUtils.waitForEvents([{scope: bob.meeting.members, event: 'members:update'}])
- .then((response) => {
- console.log('SCREEN SHARE RESPONSE ', JSON.stringify(response));
- }),
+ testUtils.waitForEvents([{scope: bob.meeting.members, event: 'members:update'}]),
testUtils.waitForEvents([{scope: alice.meeting, event: 'media:ready'}])
.then((response) => {
console.log('MEDIA:READY event ', response[0].result);
|
test(meeting): remove unnecessary console.log/stringify which causes Firefox to fail a test case
|
webex_spark-js-sdk
|
train
|
js
|
22eca44c00508e2b3915a79fb7e3aa1eb831dd28
|
diff --git a/java-dns/src/test/java/com/google/cloud/dns/it/ITDnsTest.java b/java-dns/src/test/java/com/google/cloud/dns/it/ITDnsTest.java
index <HASH>..<HASH> 100644
--- a/java-dns/src/test/java/com/google/cloud/dns/it/ITDnsTest.java
+++ b/java-dns/src/test/java/com/google/cloud/dns/it/ITDnsTest.java
@@ -51,6 +51,7 @@ import java.util.UUID;
import java.util.concurrent.TimeUnit;
import org.junit.AfterClass;
import org.junit.BeforeClass;
+import org.junit.Ignore;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.Timeout;
@@ -253,6 +254,7 @@ public class ITDnsTest {
}
@Test
+ @Ignore
public void testCreateZoneWithErrors() {
try {
try {
@@ -1471,6 +1473,7 @@ public class ITDnsTest {
}
@Test
+ @Ignore
public void testCreateZoneWithErrorsBatch() {
try {
DnsBatch batch = DNS.batch();
|
chore: ignore createZoneWithError tests (#<I>)
testCreateZoneWithErrors() and testCreateZoneWithErrorsBatch() started failing last week. The issue seems to be coming from the back end.
Filed a bug with the DNS team b/<I>. Skipping these tests until the issues is resolved.
|
googleapis_google-cloud-java
|
train
|
java
|
c11a85e202bdd45f38354bb40bc585d70aee9548
|
diff --git a/packages/react/lib/assets.js b/packages/react/lib/assets.js
index <HASH>..<HASH> 100644
--- a/packages/react/lib/assets.js
+++ b/packages/react/lib/assets.js
@@ -8,11 +8,7 @@ module.exports = (stats, modules) => {
(result, module) => [...result, ...moduleFileMap[module]],
[]
);
- return [
- ...vendorFiles.sort((a, b) => b.localeCompare(a)),
- ...moduleFiles.sort((a, b) => b.localeCompare(a)),
- ...entryFiles.sort((a, b) => b.localeCompare(a)),
- ]
+ return [...vendorFiles, ...moduleFiles, ...entryFiles]
.filter(
(asset, index, self) =>
self.indexOf(asset) === index &&
|
fix(react): rely on webpack to sort chunks correctly
|
untool_untool
|
train
|
js
|
c34cdc9da39b8786c3ab96eb99efa2f026356e5c
|
diff --git a/tests/basic.test.js b/tests/basic.test.js
index <HASH>..<HASH> 100644
--- a/tests/basic.test.js
+++ b/tests/basic.test.js
@@ -191,7 +191,6 @@ describe('Resource(basic)', function() {
url: test.baseUrl + '/people_pkey',
json: userData
}, function(error, response, body) {
- console.log(body);
expect(response.statusCode).to.eql(201);
expect(error).is.null;
expect(response.headers.location).is.not.empty;
|
chore(basic): removed an errant console.log
|
mbroadst_thinky-rest
|
train
|
js
|
bcbde45b6a00bf20a8cd806890efe83d629cb701
|
diff --git a/src/litegraph.js b/src/litegraph.js
index <HASH>..<HASH> 100755
--- a/src/litegraph.js
+++ b/src/litegraph.js
@@ -5220,6 +5220,7 @@ LGraphNode.prototype.executeAction = function(action)
node.is_selected = false;
}
this.selected_nodes = {};
+ this.current_node = null;
this.highlighted_links = {};
this.setDirty(true);
};
@@ -5235,6 +5236,7 @@ LGraphNode.prototype.executeAction = function(action)
this.graph.remove(m);
}
this.selected_nodes = {};
+ this.current_node = null;
this.highlighted_links = {};
this.setDirty(true);
};
|
fix: reset current_node after deletion
|
jagenjo_litegraph.js
|
train
|
js
|
b90a5dc497e00cb201beb8da334e500995b7d55b
|
diff --git a/wallaby.config.js b/wallaby.config.js
index <HASH>..<HASH> 100644
--- a/wallaby.config.js
+++ b/wallaby.config.js
@@ -29,9 +29,7 @@ module.exports = wallaby => {
testFramework: 'mocha',
compilers: {
- '**/*.js': wallaby.compilers.babel(
- JSON.parse(require('fs').readFileSync('.babelrc'))
- )
+ '**/*.js': wallaby.compilers.babel()
},
postprocessor: wallabyWebpack(webpackTestConfig),
@@ -42,7 +40,8 @@ module.exports = wallaby => {
},
env: {
- kind: 'electron'
+ kind: 'chrome',
+ runner: require('puppeteer').executablePath()
},
reportConsoleErrorAsError: true
|
chore(wallaby): reanimate wallaby tests
|
JetBrains_ring-ui
|
train
|
js
|
979669223a71451714bf200d67ba3469c2152e9d
|
diff --git a/event/bus.go b/event/bus.go
index <HASH>..<HASH> 100644
--- a/event/bus.go
+++ b/event/bus.go
@@ -32,7 +32,7 @@ func (self *EventBus) Listen(stop chan bool) {
}
func (self *EventBus) Close() {
- self.chClose <- true
+ close(self.chClose)
}
func (self *EventBus) AddListener(name string, m *machine.Machine, l interface{}) {
|
refactor(EventBus): use close bulitin to stop
|
coreos_fleet
|
train
|
go
|
4554387bbc8710c99b411012f75459a824ae74a6
|
diff --git a/pyethereum/trie.py b/pyethereum/trie.py
index <HASH>..<HASH> 100644
--- a/pyethereum/trie.py
+++ b/pyethereum/trie.py
@@ -177,10 +177,11 @@ class Trie(object):
self.root_node = BLANK_NODE
def _delete_child_stroage(self, node):
- if len(node) == 17:
+ node_type = self._get_node_type(node)
+ if node_type == NODE_TYPE_BRANCH:
for item in node[:16]:
self._delete_child_stroage(self._decode_to_node(item))
- elif len(node) == 17:
+ elif is_key_value_type(node_type):
node_type = self._get_node_type(node)
if node_type == NODE_TYPE_LEAF:
self._delete_child_stroage(self._decode_to_node(node[1]))
|
fix: bug in deleting unused key
|
ethereum_pyethereum
|
train
|
py
|
9d2bddff800beeb54d4f26643abdcbbe3b8a4794
|
diff --git a/gulp/tasks/release.js b/gulp/tasks/release.js
index <HASH>..<HASH> 100644
--- a/gulp/tasks/release.js
+++ b/gulp/tasks/release.js
@@ -10,7 +10,7 @@ const runSequence = require('run-sequence');
const tagVersion = require('gulp-tag-version');
const packagepath = './package.json';
-const types = ['patch', 'prepatch', 'minor', 'preminor', 'major', 'premajor'];
+const types = ['patch', 'prepatch', 'minor', 'preminor', 'major', 'premajor', 'prerelease'];
_.forEach(types, type => {
gulp.task(`release:package:${type}`, updateVersion(type));
|
chore(release): add a prerelease task [ci skip]
|
suguru03_aigle
|
train
|
js
|
47c73390ed45fe27b7fd3252af5114da60e46db1
|
diff --git a/src/internals/init_options.js b/src/internals/init_options.js
index <HASH>..<HASH> 100644
--- a/src/internals/init_options.js
+++ b/src/internals/init_options.js
@@ -8,7 +8,7 @@ import { SmoothScrollbar } from '../smooth_scrollbar';
export { SmoothScrollbar };
-function __initOptions(opt = {}) {
+function __initOptions(userPreference) {
const options = {
speed: 1, // scroll speed scale
friction: 10, // friction factor, percent
@@ -56,6 +56,7 @@ function __initOptions(opt = {}) {
});
this.__readonly('options', optionAccessors);
+ this.setOptions(userPreference);
};
Object.defineProperty(SmoothScrollbar.prototype, '__initOptions', {
|
fix(initOption): assign user preference
|
idiotWu_smooth-scrollbar
|
train
|
js
|
e6eab2091f632622fadbe3b25bb4732125b2d5df
|
diff --git a/cmd/admin-handlers.go b/cmd/admin-handlers.go
index <HASH>..<HASH> 100644
--- a/cmd/admin-handlers.go
+++ b/cmd/admin-handlers.go
@@ -2713,7 +2713,7 @@ func appendClusterMetaInfoToZip(ctx context.Context, zipWriter *zip.Writer) {
go func() {
ci := clusterInfo{}
ci.Info.PoolsCount = len(globalEndpoints)
- ci.Info.ServersCount = globalEndpoints.NEndpoints()
+ ci.Info.ServersCount = len(globalEndpoints.Hostnames())
ci.Info.MinioVersion = Version
si, _ := objectAPI.StorageInfo(ctx)
diff --git a/cmd/endpoint.go b/cmd/endpoint.go
index <HASH>..<HASH> 100644
--- a/cmd/endpoint.go
+++ b/cmd/endpoint.go
@@ -315,7 +315,7 @@ func (l EndpointServerPools) HTTPS() bool {
return l[0].Endpoints.HTTPS()
}
-// NEndpoints - returns all nodes count
+// NEndpoints - returns number of endpoints
func (l EndpointServerPools) NEndpoints() (count int) {
for _, ep := range l {
count += len(ep.Endpoints)
|
fix: Incorrect ServersCount in cluster.info (#<I>)
The `ServersCount` field in cluster.info is expected to contain the
number of nodes, and not number of endpoints.
|
minio_minio
|
train
|
go,go
|
d9cab20afb3d9a637f177c7d209283fbb1f835de
|
diff --git a/tests/test_lexer.py b/tests/test_lexer.py
index <HASH>..<HASH> 100644
--- a/tests/test_lexer.py
+++ b/tests/test_lexer.py
@@ -332,6 +332,22 @@ class TestLexer(unittest.TestCase):
),
)
+ self.assertRaises(
+ ValueError,
+ Lexer.lex_char,
+ "a",
+ "b",
+ "c",
+ "",
+ dict(state="bogus preserve state", end="end"),
+ g,
+ dict(
+ chars={"k", "v", "/", "*"},
+ single_comments={"k": "v"},
+ multi_chars={"/", "*"},
+ ),
+ )
+
def test_lexer_recurse(self):
def foo(tokens):
two = list()
|
test(lexer): Added a test.
|
planetarypy_pvl
|
train
|
py
|
030f3ba946f9bdabccd7cdd114ba78d19afc8734
|
diff --git a/lib/run.js b/lib/run.js
index <HASH>..<HASH> 100644
--- a/lib/run.js
+++ b/lib/run.js
@@ -88,9 +88,9 @@ async function processResults(results, opts) {
}
async function remindAboutIssue() {
- remindedIssues++;
const passedDays = moment().diff(ghIssue.updated_at, 'days', true);
if (passedDays >= opts.remind) {
+ remindedIssues++;
console.log('not ok (reminding...):', rule, ghIssue.html_url);
if (opts.dry) return;
await github.issue.comment(repo, ghIssue, comment.update(issue, rule), opts);
|
fix: stats for reminded issues
|
MailOnline_tap-github-issues
|
train
|
js
|
2b2dda63ef32907246a62e7ad6ab882a85f1e24d
|
diff --git a/test/tests/functional/error_tests.js b/test/tests/functional/error_tests.js
index <HASH>..<HASH> 100644
--- a/test/tests/functional/error_tests.js
+++ b/test/tests/functional/error_tests.js
@@ -6,7 +6,10 @@ var expect = require('chai').expect,
describe('Error tests', function() {
it('should return helpful error when geoHaystack fails', {
metadata: {
- requires: { topology: ['single', 'replicaset'] }
+ requires: {
+ mongodb: '< 4.1.x',
+ topology: ['single', 'replicaset']
+ }
},
test: function(done) {
diff --git a/test/tests/functional/operations_tests.js b/test/tests/functional/operations_tests.js
index <HASH>..<HASH> 100644
--- a/test/tests/functional/operations_tests.js
+++ b/test/tests/functional/operations_tests.js
@@ -366,7 +366,7 @@ describe('Operation tests', function() {
it('should correctly execute query against cursorId', {
metadata: {
requires: {
- mongodb: '>=2.6.0',
+ mongodb: '>=2.6.0 < 4.1.x',
topology: ['single', 'replicaset']
}
},
|
test(latest): disable tests using commands which have been removed
|
mongodb-js_mongodb-core
|
train
|
js,js
|
4f80f6c09fdc3aa208a68aaa9cd425f0e261ad95
|
diff --git a/django_misaka/templatetags/markdown.py b/django_misaka/templatetags/markdown.py
index <HASH>..<HASH> 100644
--- a/django_misaka/templatetags/markdown.py
+++ b/django_misaka/templatetags/markdown.py
@@ -11,8 +11,8 @@ from pygments.formatters import HtmlFormatter
register = template.Library()
-class MisakaRenderer(m.HtmlRenderer, m.SmartyPants):
- def block_code(self, text, lang):
+class MisakaRenderer(m.HtmlRenderer):
+ def blockcode(self, text, lang):
if not lang:
return '\n<pre><code>%s</code></pre>\n' % \
h.escape_html(text.strip())
@@ -27,7 +27,7 @@ def markdown_filter(value):
renderer = MisakaRenderer(flags=m.HTML_ESCAPE)
md = m.Markdown(renderer,
extensions=m.EXT_FENCED_CODE | m.EXT_NO_INTRA_EMPHASIS)
- return md.render(value)
+ return md(value)
@register.tag(name='markdown')
@@ -49,5 +49,4 @@ class MisakaNode(template.Node):
renderer = MisakaRenderer(flags=m.HTML_ESCAPE)
md = m.Markdown(renderer,
extensions=m.EXT_FENCED_CODE | m.EXT_NO_INTRA_EMPHASIS)
- return md.render(value)
-
+ return md(value)
|
refactor: update code to work with Misaka <I>
|
chiehtu_django-misaka
|
train
|
py
|
d3a1ee40c938781ac60f0a15314479449fab94c6
|
diff --git a/lib/client.js b/lib/client.js
index <HASH>..<HASH> 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -517,10 +517,9 @@ class Parser extends HTTPParser {
util.destroy(socket, new InformationalError('request reset'))
} else {
+ socket.resume()
resume(client)
}
-
- socket.resume()
}
}
|
fix: don't resume destroyed socket
|
mcollina_undici
|
train
|
js
|
f05f16af296a5a8c4575860821c378a3f752eace
|
diff --git a/tests/Concerns/Deserialize.php b/tests/Concerns/Deserialize.php
index <HASH>..<HASH> 100644
--- a/tests/Concerns/Deserialize.php
+++ b/tests/Concerns/Deserialize.php
@@ -41,6 +41,14 @@ trait Deserialize
$expected = array_only($expected['data'], $keys);
$actual = array_only($this->object_to_array($actual), $keys);
+ ksort($expected);
+ ksort($actual);
+
+ if (isset($actual['asset']['multisignature'])) {
+ ksort($expected['asset']['multisignature']);
+ ksort($actual['asset']['multisignature']);
+ }
+
$this->assertSame($expected, $actual);
}
}
|
fix: key order for deserialized objects in tests
|
ArkEcosystem_php-crypto
|
train
|
php
|
1c6fcb8e0963ceefd76d5e015fcec54c89655a94
|
diff --git a/src/geshi.php b/src/geshi.php
index <HASH>..<HASH> 100644
--- a/src/geshi.php
+++ b/src/geshi.php
@@ -2052,13 +2052,13 @@ class GeSHi {
for ($key = 0, $n = count($lines); $key < $n; $key++) {
$line = $lines[$key];
- $lines[$key] = ''; // reduce memory
if (false === strpos($line, "\t")) {
continue;
}
$pos = 0;
$length = strlen($line);
+ $lines[$key] = ''; // reduce memory
$IN_TAG = false;
for ($i = 0; $i < $length; ++$i) {
|
fix: Error when processing lines without tabs, introduced in r<I>
|
GeSHi_geshi-1.0
|
train
|
php
|
c5f72632ce54b954f4c2f4b3b64fb0b92719ea95
|
diff --git a/src/apis/clear_movement.js b/src/apis/clear_movement.js
index <HASH>..<HASH> 100644
--- a/src/apis/clear_movement.js
+++ b/src/apis/clear_movement.js
@@ -14,4 +14,5 @@ export { SmoothScrollbar };
*/
SmoothScrollbar.prototype.clearMovement = SmoothScrollbar.prototype.stop = function() {
this.movement.x = this.movement.y = 0;
+ cancelAnimationFrame(this.__timerID.scrollTo);
};
\ No newline at end of file
|
fix(stop): stop scrollTo animation when called
|
idiotWu_smooth-scrollbar
|
train
|
js
|
e7dc1b642e74fa265570e0200261d03bdb9a55d0
|
diff --git a/src/main/java/org/casbin/jcasbin/main/CoreEnforcer.java b/src/main/java/org/casbin/jcasbin/main/CoreEnforcer.java
index <HASH>..<HASH> 100644
--- a/src/main/java/org/casbin/jcasbin/main/CoreEnforcer.java
+++ b/src/main/java/org/casbin/jcasbin/main/CoreEnforcer.java
@@ -29,7 +29,7 @@ import org.casbin.jcasbin.model.Model;
import org.casbin.jcasbin.persist.Adapter;
import org.casbin.jcasbin.persist.Dispatcher;
import org.casbin.jcasbin.persist.WatcherEx;
-import org.casbin.jcasbin.persist.file_adapter.FilteredAdapter;
+import org.casbin.jcasbin.persist.FilteredAdapter;
import org.casbin.jcasbin.persist.Watcher;
import org.casbin.jcasbin.rbac.DefaultRoleManager;
import org.casbin.jcasbin.rbac.RoleManager;
@@ -237,7 +237,7 @@ public class CoreEnforcer {
public void loadFilteredPolicy(Object filter) {
model.clearPolicy();
FilteredAdapter filteredAdapter;
- if (adapter instanceof org.casbin.jcasbin.persist.FilteredAdapter) {
+ if (adapter instanceof FilteredAdapter) {
filteredAdapter = (FilteredAdapter) adapter;
} else {
throw new CasbinAdapterException("Filtered policies are not supported by this adapter.");
|
fix: change type to use correct FilteredAdapter type cast when loading filtered policies
|
casbin_jcasbin
|
train
|
java
|
3a403800f6b2264977aaf0ceff088c4cbb614fe5
|
diff --git a/lib/dpl/provider/npm.rb b/lib/dpl/provider/npm.rb
index <HASH>..<HASH> 100644
--- a/lib/dpl/provider/npm.rb
+++ b/lib/dpl/provider/npm.rb
@@ -23,7 +23,7 @@ module DPL
end
def push_app
- context.shell "npm publish --force"
+ context.shell "npm publish"
end
end
end
diff --git a/spec/provider/npm.rb b/spec/provider/npm.rb
index <HASH>..<HASH> 100644
--- a/spec/provider/npm.rb
+++ b/spec/provider/npm.rb
@@ -16,7 +16,7 @@ describe DPL::Provider::NPM do
describe :push_app do
example do
- provider.context.should_receive(:shell).with("npm publish --force")
+ provider.context.should_receive(:shell).with("npm publish")
provider.push_app
end
end
|
fix(npm): don't publish with --force
force publishing is going away in the near(-ish) future, see
npm/npmjs.org#<I>.
|
travis-ci_dpl
|
train
|
rb,rb
|
60240e7e72e86c136679e4e36d82eb92d193ee99
|
diff --git a/task.js b/task.js
index <HASH>..<HASH> 100644
--- a/task.js
+++ b/task.js
@@ -108,8 +108,12 @@ module.exports = function task(gulp, projectConfig, tasks) {
* WATCH TASKS
* ---------------------*/
+ Object.keys(taskConfig.files).forEach(function setupTasksFromConfig(key) {
+ taskConfig.watch.push('!' + taskConfig.files[key].src);
+ });
+
gulp.task('watch:' + TASK_NAME, function watchTask() {
- gulp.watch(
+ gulp.watch (
taskConfig.watch,
[TASK_NAME]
);
|
fix: sass task was looping on windows, gen files ignored
|
cartridge_cartridge-sass
|
train
|
js
|
b422d0833a83418d091b660e3f2f87d73e27d9da
|
diff --git a/src/media/WebAudio.js b/src/media/WebAudio.js
index <HASH>..<HASH> 100644
--- a/src/media/WebAudio.js
+++ b/src/media/WebAudio.js
@@ -42,8 +42,15 @@
*/
var WebAudio = (function(){
-var AudioContext = window.AudioContext || window.webkitAudioContext;
-var context = AudioContext ? new AudioContext() : null;
+var context = null;
+try {
+ var AudioContext = window.AudioContext || window.webkitAudioContext;
+ if (AudioContext) {
+ context = new AudioContext();
+ }
+} catch(e) {
+ context = null;
+}
return Class.create(/** @lends WebAudio.prototype */{
Mixes: EventMixin,
@@ -316,7 +323,7 @@ return Class.create(/** @lends WebAudio.prototype */{
* @language=zh
* 浏览器是否支持WebAudio。
*/
- isSupported: AudioContext != null,
+ isSupported: context !== null,
/**
* @language=en
|
fix: WebAudio create context should try catch
|
hiloteam_Hilo
|
train
|
js
|
777aa910755263c14222ffaebd2b35e1750fa989
|
diff --git a/test/unit/cursor/Cursor.test.js b/test/unit/cursor/Cursor.test.js
index <HASH>..<HASH> 100644
--- a/test/unit/cursor/Cursor.test.js
+++ b/test/unit/cursor/Cursor.test.js
@@ -282,15 +282,15 @@ describe('Cursor', () => {
});
it('Should properly get TTY size based on process.stdout.getWindowSize', () => {
- let stdout = sinon.mock(process.stdout);
+ let mock = sinon.mock(process.stdout);
- stdout.expects('getWindowSize').twice().returns([10, 10]);
+ mock.expects('getWindowSize').twice().returns([10, 10]);
let {width, height} = Cursor.getTTYSize();
assert.equal(width, 10);
assert.equal(height, 10);
- stdout.verify();
+ mock.verify();
});
it('Should properly get TTY size based on process columns and rows', () => {
|
refactor(cursor): Renames mock name in one of tests
|
ghaiklor_kittik
|
train
|
js
|
83412537a27795f664d3b642424e1e50a4cd298a
|
diff --git a/framework/core/src/Foundation/InstalledSite.php b/framework/core/src/Foundation/InstalledSite.php
index <HASH>..<HASH> 100644
--- a/framework/core/src/Foundation/InstalledSite.php
+++ b/framework/core/src/Foundation/InstalledSite.php
@@ -174,7 +174,7 @@ class InstalledSite implements SiteInterface
protected function registerLogger(Container $container)
{
$logPath = $this->paths->storage.'/logs/flarum.log';
- $handler = new RotatingFileHandler($logPath, Logger::INFO);
+ $handler = new RotatingFileHandler($logPath, 0, Logger::INFO);
$handler->setFormatter(new LineFormatter(null, null, true, true));
$container->instance('log', new Logger('flarum', [$handler]));
|
fix(logs): assign INFO scope to correct argument
Argument for INFO (constant value <I>) was assigned to
maxfiles argument incorrectly.
|
flarum_core
|
train
|
php
|
561da4692eb06f5b1e6602b7b78e3dcd1c12b470
|
diff --git a/model/DeliveryFactory.php b/model/DeliveryFactory.php
index <HASH>..<HASH> 100755
--- a/model/DeliveryFactory.php
+++ b/model/DeliveryFactory.php
@@ -236,7 +236,7 @@ class DeliveryFactory extends ConfigurableService
): KernelResource {
$deliveryId = trim($additionalParameters[DeliveryAssemblyService::PROPERTY_ASSESSMENT_PROJECT_ID] ?? '');
- if (!$deliveryId) {
+ if ('' === $deliveryId) {
throw new RuntimeException(
sprintf('%s must not be empty.', DeliveryAssemblyService::PROPERTY_ASSESSMENT_PROJECT_ID)
);
|
fix: apply a strict emptiness check of the incoming Delivery ID when creating a Remote Delivery resource
--
TR-<I>
|
oat-sa_extension-tao-delivery-rdf
|
train
|
php
|
a4bed90d57e5f98b1817a0c2c9b96674d95e188c
|
diff --git a/src/components/Table/Table.js b/src/components/Table/Table.js
index <HASH>..<HASH> 100644
--- a/src/components/Table/Table.js
+++ b/src/components/Table/Table.js
@@ -10,7 +10,7 @@ const Table = styled(Base)`
background-color: white;
border: 1px solid #bbb;
line-height: 200%;
- ${prop("Table")};
+ ${prop("theme.Table")};
`;
Table.defaultProps = {
|
fix(Table): Use theme.Table
|
reakit_reakit
|
train
|
js
|
5538ed36b86e9ab50b2f09f00477ce00b0ad46bb
|
diff --git a/models/classes/Lists/Business/Domain/RemoteSourceContext.php b/models/classes/Lists/Business/Domain/RemoteSourceContext.php
index <HASH>..<HASH> 100644
--- a/models/classes/Lists/Business/Domain/RemoteSourceContext.php
+++ b/models/classes/Lists/Business/Domain/RemoteSourceContext.php
@@ -56,7 +56,7 @@ class RemoteSourceContext extends AbstractContext
return;
}
- if (!$parameter !== self::PARAM_JSON && is_string($parameterValue)) {
+ if ($parameter !== self::PARAM_JSON && is_string($parameterValue)) {
return;
}
diff --git a/models/classes/featureFlag/FeatureFlagChecker.php b/models/classes/featureFlag/FeatureFlagChecker.php
index <HASH>..<HASH> 100644
--- a/models/classes/featureFlag/FeatureFlagChecker.php
+++ b/models/classes/featureFlag/FeatureFlagChecker.php
@@ -28,7 +28,6 @@ class FeatureFlagChecker extends ConfigurableService implements FeatureFlagCheck
{
public function isEnabled(string $feature): bool
{
- return true;
if (!isset($_ENV[$feature])) {
return false;
}
|
refactor: fix refactoring
|
oat-sa_tao-core
|
train
|
php,php
|
3d80b68a7609fbaf9a8cc61a0269cae9b0988e75
|
diff --git a/test/test.js b/test/test.js
index <HASH>..<HASH> 100644
--- a/test/test.js
+++ b/test/test.js
@@ -51,7 +51,7 @@ describe('plug-login', function () {
, { json: true, jar: result.jar }
, (e, {}, body) => {
if (e) throw e
- eq(result.body.data[0].id, body.data[0].id)
+ ok(body.data[0].id)
done()
})
})
|
test: fix jar check for plug update
plug.dj doesn't include the user data in login responses anymore.
|
miniplug_plug-login
|
train
|
js
|
a489a71985a13a3610582272a6201be2104df0b0
|
diff --git a/src/cobra/manipulation/validate.py b/src/cobra/manipulation/validate.py
index <HASH>..<HASH> 100644
--- a/src/cobra/manipulation/validate.py
+++ b/src/cobra/manipulation/validate.py
@@ -41,7 +41,7 @@ def check_mass_balance(model: "Model") -> Dict["Reaction", Dict["Metabolite", fl
def check_metabolite_compartment_formula(model: "Model") -> List[str]:
- """Check metabolite compartments of `model`.
+ """Check metabolite formulae of `model`.
Parameters
----------
|
fix: rectify docstring to reflect usage accurately
|
opencobra_cobrapy
|
train
|
py
|
bce7745b1772363cc2dfbe181f425dc6276ae486
|
diff --git a/lib/Image.js b/lib/Image.js
index <HASH>..<HASH> 100644
--- a/lib/Image.js
+++ b/lib/Image.js
@@ -110,7 +110,7 @@ export default class Image extends React.Component {
const originURL = src.substring(0, src.indexOf('/upload/')+8);
const originURLEnd = src.substring(src.lastIndexOf('/'), src.length);
- const blurURL = `${originURL}e_blur:250,${blurParams}${originURLEnd}`;
+ const blurURL = `${originURL}e_blur:750,${blurParams}${originURLEnd}`;
return blurURL;
}
|
fix: increase image blurUp blur value for iOS
|
poetic_react-super-components
|
train
|
js
|
4b9288cb08611af89c8a2ff649eff48be28f7805
|
diff --git a/theme/shadows.js b/theme/shadows.js
index <HASH>..<HASH> 100644
--- a/theme/shadows.js
+++ b/theme/shadows.js
@@ -1,3 +1,6 @@
+// Used to generate all the shadows used in the material theme.
+// Is not used at runtime.
+
const parseLine = line => {
const values = line.split(/\s+/)
return {
|
docs: Add docstring for file generating shadows
|
cozy_cozy-ui
|
train
|
js
|
19cde595f64559abd645deca4214ea6590fc9c31
|
diff --git a/karma.coverage.js b/karma.coverage.js
index <HASH>..<HASH> 100644
--- a/karma.coverage.js
+++ b/karma.coverage.js
@@ -2,6 +2,7 @@ module.exports = function(config) {
require("./karma.conf")(config);
config.autoWatch = true;
+ config.browserNoActivityTimeout = 30000;
config.preprocessors = {
'lib/**/!(*spec).js': ['coverage']
|
fix(build): increase no activity timeout
|
Stabzs_Angular2-Toaster
|
train
|
js
|
af9c84a379d3b02de03d0fc2d0402ea56a0a0462
|
diff --git a/test/unit/middleware/proxy.spec.js b/test/unit/middleware/proxy.spec.js
index <HASH>..<HASH> 100644
--- a/test/unit/middleware/proxy.spec.js
+++ b/test/unit/middleware/proxy.spec.js
@@ -346,8 +346,8 @@ describe('middleware.proxy', () => {
}
var parsedProxyConfig = m.parseProxyConfig(proxy, config)
expect(parsedProxyConfig).to.have.length(1)
- expect(parsedProxyConfig[0].proxy.listeners('proxyReq', true)).to.equal(true)
- expect(parsedProxyConfig[0].proxy.listeners('proxyRes', true)).to.equal(true)
+ expect(parsedProxyConfig[0].proxy.listeners('proxyReq')[0]).to.equal(config.proxyReq)
+ expect(parsedProxyConfig[0].proxy.listeners('proxyRes')[0]).to.equal(config.proxyRes)
})
it('should handle empty proxy config', () => {
|
fix(UTs): Correct proxy listeners expectation
Expectations added in <URL>
|
karma-runner_karma
|
train
|
js
|
70a1728562c6777249b963b77206f3a95e9edb58
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -56,7 +56,7 @@ var supportedTargets = [
{runtime: 'node', target: '9.0.0', abi: '59', lts: false},
{runtime: 'node', target: '10.0.0', abi: '64', lts: new Date(2018, 10, 1) < new Date() && new Date() < new Date(2020, 4, 31)},
{runtime: 'node', target: '11.0.0', abi: '67', lts: false},
- {runtime: 'node', target: '12.0.0', abi: '72', lts: false},
+ {runtime: 'node', target: '12.0.0', abi: '72', lts: new Date(2019, 9, 21) < new Date() && new Date() < new Date(2020, 9, 31)},
{runtime: 'electron', target: '0.36.0', abi: '47', lts: false},
{runtime: 'electron', target: '1.1.0', abi: '48', lts: false},
{runtime: 'electron', target: '1.3.0', abi: '49', lts: false},
|
feat: indicate Node <I> is an LTS release
|
lgeiger_node-abi
|
train
|
js
|
e5fb2b4d4aeff0da1594addd2d948b9c4b8938a3
|
diff --git a/lib/pincers/nokogiri/property_helper.rb b/lib/pincers/nokogiri/property_helper.rb
index <HASH>..<HASH> 100644
--- a/lib/pincers/nokogiri/property_helper.rb
+++ b/lib/pincers/nokogiri/property_helper.rb
@@ -28,6 +28,10 @@ module Pincers::Nokogiri
end
end
+ def toggle(_name)
+ set(_name, !get(_name))
+ end
+
def get(_name)
_name = _name.to_sym
@@ -70,6 +74,9 @@ module Pincers::Nokogiri
end
end
+ alias :[] :get
+ alias :[]= :set
+
private
def is_boolean?(_name)
|
feat(property_helper): adds toogle, [] and []= conveniece methods
|
platanus_pincers
|
train
|
rb
|
dd5c041723d3214ed95e842074c95741f75d76b2
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -16,7 +16,7 @@ var parentRequire = require('parent-require'),
'2.0': path.join(vendorPath, 'jasmine-2.0.2', 'SpecRunner.html'),
'2.1': path.join(vendorPath, 'jasmine-2.1.3', 'SpecRunner.html'),
'2.2': path.join(vendorPath, 'jasmine-2.2.0', 'SpecRunner.html'),
- 'peer': path.join('node_modules', 'jasmine', 'SpecRunner.html')
+ 'peer': path.join(vendorPath, 'jasmine', 'SpecRunner.html')
},
jshint = {
'2.6': path.join(vendorPath, 'jshint-2.6.0', 'jshint.js'),
@@ -40,10 +40,12 @@ var parentRequire = require('parent-require'),
options;
module.exports = function (opts) {
- if (fs.existsSync(template.peer)) {
+ try {
+ require.resolve('jasmine-core');
defaults.jasmine = 'peer';
console.log('Installed Jasmine found');
- } else {
+ } catch (err) {
+ console.error(err)
console.log('No installed Jasmine found. Using embedded one');
}
|
fix(peer): support using peer jasmine
|
mucsi96_gulp-jasmine-livereload-task
|
train
|
js
|
5c5defd5269203e62b8c257558512d843124dd11
|
diff --git a/test.py b/test.py
index <HASH>..<HASH> 100644
--- a/test.py
+++ b/test.py
@@ -8,13 +8,27 @@ if (sys.version).startswith('2'):
sys.setdefaultencoding("utf-8")
bus_routes = cpsk.get_routes('TO', 'BA', vehicle='bus')
+print('Looking for bus lines')
for b in bus_routes:
print(b)
+print()
+
train_routes = cpsk.get_routes('NR', 'TO', vehicle='vlak')
+print('Looking for train lines')
for t in train_routes:
print(t)
+print()
+
routes = cpsk.get_routes('KE', 'TO')
+print('Looking for lines')
for r in routes:
print(r)
+
+print()
+
+inter_routes = cpsk.get_routes('Brno', 'BA', vehicle='vlak')
+print('Looking for international lines')
+for ir in inter_routes:
+ print(ir)
|
test: added international lines
* also the output is now more readable
|
Adman_python-cpsk-api
|
train
|
py
|
b6dcdc5aa4ef6bf6f918c7a576dadb888b5b4538
|
diff --git a/dpark/schedule.py b/dpark/schedule.py
index <HASH>..<HASH> 100644
--- a/dpark/schedule.py
+++ b/dpark/schedule.py
@@ -1010,12 +1010,12 @@ class MesosScheduler(DAGScheduler):
def jobFinished(self, job):
logger.debug('job %s finished', job.id)
if job.id in self.activeJobs:
+ self.last_finish_time = time.time()
del self.activeJobs[job.id]
self.activeJobsQueue.remove(job)
for tid in self.jobTasks[job.id]:
self.driver.killTask(Dict(value=tid))
del self.jobTasks[job.id]
- self.last_finish_time = time.time()
if not self.activeJobs:
self.agentTasks.clear()
|
fix: fix bug for collision (#<I>)
fix the bug for the collision between the check thread and the check function called in runJob
|
douban_dpark
|
train
|
py
|
d353aa09b5ecb16a9ea21c5cbe0dbc5192cabe07
|
diff --git a/api/models.py b/api/models.py
index <HASH>..<HASH> 100644
--- a/api/models.py
+++ b/api/models.py
@@ -298,7 +298,7 @@ class Container(UuidAuditedModel):
if c_type == 'cmd':
return ''
else:
- return 'start {c_type}'
+ return "start {}".format(c_type)
else:
return ''
@@ -311,10 +311,9 @@ class Container(UuidAuditedModel):
@transition(field=state, source=INITIALIZED, target=CREATED)
def create(self):
image = self.release.image
- c_type = self.type
self._scheduler.create(name=self._job_id,
image=image,
- command=self._command.format(**locals()),
+ command=self._command,
use_announcer=self._command_announceable())
@close_db_connections
|
fix(controller): format command before creating container
The self._command_announceable() check was called inline with code
that formatted the container's command, so no announcer would be
created since the command showed up as "start {c_type}" literally.
The _command property is only referenced in this code.
|
deis_controller-sdk-go
|
train
|
py
|
836549bbe63a04d74084eb5fcf5b9bae4c4fe621
|
diff --git a/src/ui/uploads/upload-progress-bar.js b/src/ui/uploads/upload-progress-bar.js
index <HASH>..<HASH> 100644
--- a/src/ui/uploads/upload-progress-bar.js
+++ b/src/ui/uploads/upload-progress-bar.js
@@ -5,7 +5,7 @@ ngModule.directive('avUploadProgressBar', () => ({
restrict: 'E',
scope: {
upload: '=',
- errorCallback: '='
+ errorcallback: '='
},
templateUrl,
link(scope) {
@@ -17,7 +17,7 @@ ngModule.directive('avUploadProgressBar', () => ({
const error = () => {
scope.error = true;
- return scope.errorCallback(scope.upload);
+ return scope.errorcallback(scope.upload);
};
const success = () => {
|
fix(availity-angular): uploads callback fix
|
Availity_availity-angular
|
train
|
js
|
91e9fd34617c1e255a1b1346581d987ff7afc435
|
diff --git a/lib/frames/transfer_frame.js b/lib/frames/transfer_frame.js
index <HASH>..<HASH> 100644
--- a/lib/frames/transfer_frame.js
+++ b/lib/frames/transfer_frame.js
@@ -220,7 +220,7 @@ TransferFrame.prototype._getPerformative = function() {
return new DescribedType(TransferFrame, {
handle: new ForcedType('uint', self.handle),
deliveryId: new ForcedType('uint', self.deliveryId),
- deliveryTag: new ForcedType('uint', self.deliveryTag),
+ deliveryTag: self.deliveryTag,
messageFormat: new ForcedType('uint', self.messageFormat),
settled: self.settled,
more: self.more,
|
fix(TransferFrame): accidentally forced type for delivery tag
|
noodlefrenzy_node-amqp10
|
train
|
js
|
91df35088ee7780c4b829221e523113ceda76b78
|
diff --git a/lib/sdam/topology_description.js b/lib/sdam/topology_description.js
index <HASH>..<HASH> 100644
--- a/lib/sdam/topology_description.js
+++ b/lib/sdam/topology_description.js
@@ -75,7 +75,10 @@ class TopologyDescription {
// value among ServerDescriptions of all data-bearing server types. If any have a null
// logicalSessionTimeoutMinutes, then TopologyDescription.logicalSessionTimeoutMinutes MUST be
// set to null.
- const readableServers = Object.values(this.servers).filter(s => s.isReadable);
+ const readableServers = Object.keys(this.servers)
+ .map(s => this.servers[s])
+ .filter(s => s.isReadable);
+
this.logicalSessionTimeoutMinutes = readableServers.reduce((result, server) => {
if (server.logicalSessionTimeoutMinutes == null) return null;
if (result == null) return server.logicalSessionTimeoutMinutes;
|
fix(topology-description): we can't use Object.values yet
|
mongodb-js_mongodb-core
|
train
|
js
|
1833894856991e98e0d32701217453c413164cf3
|
diff --git a/lib/plugins/aws/invokeLocal/index.js b/lib/plugins/aws/invokeLocal/index.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/aws/invokeLocal/index.js
+++ b/lib/plugins/aws/invokeLocal/index.js
@@ -26,12 +26,9 @@ const cachePath = path.join(cachedir('serverless'), 'invokeLocal');
const ensureRuntimeWrappers = isStandalone
? () =>
- ensureArtifact('runtimeWrappers/validationFile', async (artifactsPath) => {
- await fse.copy(
- path.resolve(__dirname, 'runtimeWrappers'),
- path.resolve(artifactsPath, 'runtimeWrappers')
- );
- return fse.ensureFile(path.resolve(artifactsPath, 'runtimeWrappers/validationFile'));
+ ensureArtifact('runtimeWrappers/validationFile', async (runtimeCachePath) => {
+ await fse.copy(path.resolve(__dirname, 'runtimeWrappers'), runtimeCachePath);
+ return fse.ensureFile(path.resolve(runtimeCachePath, 'validationFile'));
})
: () => Promise.resolve(__dirname);
|
fix(Standalone): Ensure proper resolution of runtime wrappers
|
serverless_serverless
|
train
|
js
|
e866517713b16538d7d9966101193fa5732815bd
|
diff --git a/packages/plugin-critical/index.js b/packages/plugin-critical/index.js
index <HASH>..<HASH> 100644
--- a/packages/plugin-critical/index.js
+++ b/packages/plugin-critical/index.js
@@ -9,7 +9,7 @@ const {
module.exports = function (api, options) {
api.afterBuild(async ({ queue, config }) => {
- const { outDir: base, pathPrefix } = config
+ const { outDir: base, pathPrefix, publicPath } = config
const pages = queue.filter(page => {
return micromatch(page.path, options.paths).length
@@ -27,10 +27,11 @@ module.exports = function (api, options) {
ignore: options.ignore,
width: options.width,
height: options.height,
+ // TODO: remove pathPrefix fallback
+ pathPrefix: publicPath || pathPrefix || '/',
html: sourceHTML,
inline: false,
minify: true,
- pathPrefix,
base
})
} catch (err) {
|
fix(critical): use publicPath as path prefix
|
gridsome_gridsome
|
train
|
js
|
ac22c7c8b807af234fbe3acd03367a7319e63051
|
diff --git a/library/src/main/java/com/liulishuo/filedownloader/DownloadSpeedMonitor.java b/library/src/main/java/com/liulishuo/filedownloader/DownloadSpeedMonitor.java
index <HASH>..<HASH> 100644
--- a/library/src/main/java/com/liulishuo/filedownloader/DownloadSpeedMonitor.java
+++ b/library/src/main/java/com/liulishuo/filedownloader/DownloadSpeedMonitor.java
@@ -51,7 +51,7 @@ public class DownloadSpeedMonitor implements IDownloadSpeed.Monitor, IDownloadSp
long downloadSize = sofarBytes - mStartSofarBytes;
this.mLastRefreshTime = 0;
long interval = SystemClock.uptimeMillis() - mStartTime;
- if (interval < 0) {
+ if (interval <= 0) {
mSpeed = (int) downloadSize;
} else {
mSpeed = (int) (downloadSize / interval);
|
fix: fix divide by zero on calculating average speed when download completed and connected at the same time
Closes #<I>
|
lingochamp_FileDownloader
|
train
|
java
|
c1de734d9ee988b0996db9792f53997a499e0b0d
|
diff --git a/lib/cmd/cov.js b/lib/cmd/cov.js
index <HASH>..<HASH> 100644
--- a/lib/cmd/cov.js
+++ b/lib/cmd/cov.js
@@ -129,6 +129,7 @@ class CovCommand extends Command {
'report',
'--root', coverageDir,
'text-summary',
+ 'json-summary',
'json',
'lcov',
];
diff --git a/test/lib/cmd/cov.test.js b/test/lib/cmd/cov.test.js
index <HASH>..<HASH> 100644
--- a/test/lib/cmd/cov.test.js
+++ b/test/lib/cmd/cov.test.js
@@ -27,6 +27,7 @@ describe('test/lib/cmd/cov.test.js', () => {
.end(err => {
assert.ifError(err);
assert.ok(fs.existsSync(path.join(cwd, 'coverage/coverage-final.json')));
+ assert.ok(fs.existsSync(path.join(cwd, 'coverage/coverage-summary.json')));
assert.ok(fs.existsSync(path.join(cwd, 'coverage/lcov-report/index.html')));
assert.ok(fs.existsSync(path.join(cwd, 'coverage/lcov.info')));
assert.ok(!fs.existsSync(path.join(cwd, '.tmp')));
|
feat: cov support output json-summary (#<I>)
|
eggjs_egg-bin
|
train
|
js,js
|
6a94465bea75dc7f302b42b7c7207e637ef506e6
|
diff --git a/brother_ql/reader.py b/brother_ql/reader.py
index <HASH>..<HASH> 100755
--- a/brother_ql/reader.py
+++ b/brother_ql/reader.py
@@ -297,8 +297,8 @@ class BrotherQLReader(object):
fmt = " media width: {} mm, media length: {} mm, raster no: {} rows"
logger.info(fmt.format(self.mwidth, self.mlength, self.raster_no))
if opcode_def[0] == 'print':
- logger.info("Len of black rows: ", len(self.black_rows))
- logger.info("Len of red rows: ", len(self.red_rows))
+ logger.info("Len of black rows: %d", len(self.black_rows))
+ logger.info("Len of red rows: %d", len(self.red_rows))
def get_im(rows):
if not len(rows): return None
size = (len(rows[0])*8, len(rows))
|
fix: logging output in BrotherQLReader() raises TypeError
The following error is resolved with this fix:
TypeError: not all arguments converted during string formatting
|
pklaus_brother_ql
|
train
|
py
|
a71005bd879d05d7dcb892d1e0dc5c6ca74e9d39
|
diff --git a/src/__tests__/utils.getNextWrappingIndex.js b/src/__tests__/utils.getNextWrappingIndex.js
index <HASH>..<HASH> 100644
--- a/src/__tests__/utils.getNextWrappingIndex.js
+++ b/src/__tests__/utils.getNextWrappingIndex.js
@@ -223,3 +223,21 @@ test('should skip disabled and not wrap to first if circular when reaching last'
),
).toEqual(1)
})
+
+test('should not select any if all disabled when arrow up', () => {
+ const moveAmount = -1
+ const baseIndex = -1
+ const itemCount = 3
+ const getItemNodeFromIndex = () => ({hasAttribute: () => true})
+ const circular = true
+
+ expect(
+ getNextWrappingIndex(
+ moveAmount,
+ baseIndex,
+ itemCount,
+ getItemNodeFromIndex,
+ circular,
+ ),
+ ).toEqual(-1)
+})
diff --git a/src/utils.js b/src/utils.js
index <HASH>..<HASH> 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -342,7 +342,11 @@ function getNextWrappingIndex(
circular,
)
- return nonDisabledNewIndex === -1 ? baseIndex : nonDisabledNewIndex
+ if (nonDisabledNewIndex === -1) {
+ return baseIndex >= itemCount ? -1 : baseIndex
+ }
+
+ return nonDisabledNewIndex
}
/**
|
fix(useCombobox): navigating up if all items are disabled (#<I>)
|
downshift-js_downshift
|
train
|
js,js
|
ddcaeb5ae7cf83cd332747217fb03a8764ae7d46
|
diff --git a/src/Output/Writer.php b/src/Output/Writer.php
index <HASH>..<HASH> 100644
--- a/src/Output/Writer.php
+++ b/src/Output/Writer.php
@@ -41,6 +41,16 @@ class Writer
}
/**
+ * Get Colorizer.
+ *
+ * @return Color
+ */
+ public function colorizer(): Color
+ {
+ return $this->colorizer;
+ }
+
+ /**
* Magically set methods.
*
* @param string $name Like `red`, `bgRed`, 'bold', `error` etc
@@ -78,6 +88,14 @@ class Writer
return $this->doWrite($text, $error);
}
+ /**
+ * Really write to the stream.
+ *
+ * @param string $text
+ * @param bool $error
+ *
+ * @return self
+ */
protected function doWrite(string $text, bool $error = false): self
{
$stream = $error ? $this->eStream : $this->stream;
@@ -87,11 +105,26 @@ class Writer
return $this;
}
+ /**
+ * Write EOL n times.
+ *
+ * @param int $n
+ *
+ * @return self
+ */
public function eol(int $n = 1): self
{
return $this->doWrite(\str_repeat(PHP_EOL, \max($n, 1)));
}
+ /**
+ * Write raw text (as it is).
+ *
+ * @param string $text
+ * @param bool $error
+ *
+ * @return self
+ */
public function raw($text, bool $error = false): self
{
return $this->doWrite((string) $text, $error);
|
refactor(writer): add typehints and docblocks, colorizer()
|
adhocore_php-cli
|
train
|
php
|
43d729b71427660357a80fec5bf3bf9b983a9fd8
|
diff --git a/bin/index.js b/bin/index.js
index <HASH>..<HASH> 100644
--- a/bin/index.js
+++ b/bin/index.js
@@ -18,16 +18,16 @@ if (semver.lt(process.version, '8.0.0')) {
}
function local () {
- spawnArgs.push(['./node_modules/.bin/japa'])
- const tests = spawn('node', ...spawnArgs)
+ spawnArgs.push('./node_modules/.bin/japa')
+ const tests = spawn('node', spawnArgs)
tests.stdout.on('data', (data) => process.stdout.write(data))
tests.stderr.on('data', (data) => process.stderr.write(data))
tests.on('close', (code) => process.exit(code))
}
function win () {
- spawnArgs.push(['./node_modules/japa-cli/index.js'])
- const tests = spawn('node', ...spawnArgs)
+ spawnArgs.push('./node_modules/japa-cli/index.js')
+ const tests = spawn('node', spawnArgs)
tests.stdout.on('data', (data) => process.stdout.write(data))
tests.stderr.on('data', (data) => process.stderr.write(data))
tests.on('close', (code) => process.exit(code))
|
fix(bin): fix test commands to work across node versions
|
adonisjs_adonis-framework
|
train
|
js
|
24e0cb486c98bf990e8ef684279b614dcbbee430
|
diff --git a/sm4/sm4_gcm.go b/sm4/sm4_gcm.go
index <HASH>..<HASH> 100644
--- a/sm4/sm4_gcm.go
+++ b/sm4/sm4_gcm.go
@@ -72,8 +72,9 @@ func Rightshift(V []byte){
func findYi( Y []byte,index int) int{
var temp byte
- temp=Y[index/8]
- temp=temp>>(7-index%8)
+ i := uint(index)
+ temp=Y[i/8]
+ temp=temp>>(7-i%8)
if temp & 0x01 == 1{
return 1
}else{
@@ -329,4 +330,4 @@ func GCMDecrypt(K,IV,C,A []byte)(P,_T []byte){
copy(P[(n-1)*BlockSize:],addition(C[(n-1)*BlockSize:],out))
return P,_T
-}
\ No newline at end of file
+}
|
fix: shift count type int, must be unsigned integer
|
tjfoc_gmsm
|
train
|
go
|
ae0bf30132334250112c60f827fd4dfab01a6b59
|
diff --git a/spec/associations_spec.rb b/spec/associations_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/associations_spec.rb
+++ b/spec/associations_spec.rb
@@ -3,7 +3,7 @@ require 'spec_helper'
describe Cistern::Associations do
subject { Class.new(Sample::Model) }
- describe '#assocations' do
+ describe '#associations' do
before {
Sample::Associate = Class.new(Sample::Model) do
identity :id
@@ -13,7 +13,7 @@ describe Cistern::Associations do
end
}
- it 'returns a mapping of assocations types to names' do
+ it 'returns a mapping of associations types to names' do
expect(Sample::Associate.associations).to eq(
{
:belongs_to => [:association],
@@ -24,7 +24,7 @@ describe Cistern::Associations do
end
describe '#belongs_to' do
- it 'returns an assoicated model' do
+ it 'returns an associated model' do
Sample::Associate = Class.new(Sample::Model) do
identity :id
end
@@ -69,7 +69,7 @@ describe Cistern::Associations do
end
}
- it 'returns assoicated models' do
+ it 'returns associated models' do
expected = Sample::Associates.new(associate_id: 2).load([{id: 3}])
expect(subject.new(associate_id: 2).associates.all).to eq(expected)
|
test(model): i can spell
correct misspellings of associate
|
lanej_cistern
|
train
|
rb
|
83502fa722fb53fd4d12daf18c58ec3a267e471e
|
diff --git a/test/integration/features/step_definitions/husky-steps.js b/test/integration/features/step_definitions/husky-steps.js
index <HASH>..<HASH> 100644
--- a/test/integration/features/step_definitions/husky-steps.js
+++ b/test/integration/features/step_definitions/husky-steps.js
@@ -15,7 +15,7 @@ async function assertHookContainsScript(hook, script) {
}
Then('husky is configured for a {string} project', async function (packageManager) {
- td.verify(this.execa(td.matchers.contains(new RegExp('(npm install|yarn add).*husky'))), {ignoreExtraArgs: true});
+ td.verify(this.execa(td.matchers.contains(/(npm install|yarn add).*husky/)), {ignoreExtraArgs: true});
await assertHookContainsScript('pre-commit', `${packageManager} test`);
await assertHookContainsScript('commit-msg', 'npx --no-install commitlint --edit $1');
|
chore(lint): switched regex to literal form to satisfy increased lint rule strictness
|
travi_javascript-scaffolder
|
train
|
js
|
24d0099bdf51d3b960c738d8c23054b2ab02db05
|
diff --git a/lib/util/file-writer-transform.js b/lib/util/file-writer-transform.js
index <HASH>..<HASH> 100644
--- a/lib/util/file-writer-transform.js
+++ b/lib/util/file-writer-transform.js
@@ -29,7 +29,7 @@ function getRawData(source, req, isReq) {
var rawHeaderNames = source.rawHeaderNames || {};
Object.keys(source.headers).forEach(function(key) {
var val = source.headers[key];
- if (!isReq || (key !== config.HTTPS_FIELD && key !== config.CLIENT_IP_HEAD && key !== 'content-encoding')) {
+ if (!isReq || (key !== config.HTTPS_FIELD && key !== 'content-encoding')) {
key = rawHeaderNames[key] || key;
headers.push(Array.isArray(val) ? val.map(function(item) {
return key + ': ' + item;
|
feat: Add x-forwarded-for header
|
avwo_whistle
|
train
|
js
|
b8ce488f6b7566668aa428b8a7c336ba64b78742
|
diff --git a/docs/src/examples/collections/Table/Variations/TableExampleSortable.js b/docs/src/examples/collections/Table/Variations/TableExampleSortable.js
index <HASH>..<HASH> 100644
--- a/docs/src/examples/collections/Table/Variations/TableExampleSortable.js
+++ b/docs/src/examples/collections/Table/Variations/TableExampleSortable.js
@@ -15,7 +15,7 @@ function exampleReducer(state, action) {
if (state.column === action.column) {
return {
...state,
- data: state.data.reverse(),
+ data: state.data.slice().reverse(),
direction:
state.direction === 'ascending' ? 'descending' : 'ascending',
}
|
docs(Table): fix sort issue in TableExampleSortable (#<I>)
|
Semantic-Org_Semantic-UI-React
|
train
|
js
|
74a72420816ee1cf93b872e0c77ff19d9effff14
|
diff --git a/lib/config/migration.js b/lib/config/migration.js
index <HASH>..<HASH> 100644
--- a/lib/config/migration.js
+++ b/lib/config/migration.js
@@ -225,13 +225,13 @@ function migrateConfig(config) {
migratedConfig[key] = `${val[0]}`;
} else if (key === 'node' && val.enabled === true) {
isMigrated = true;
- delete val.enabled;
+ delete migratedConfig.node.enabled;
migratedConfig.travis = migratedConfig.travis || {};
migratedConfig.travis.enabled = true;
- if (!Object.keys(val).length) {
+ if (!Object.keys(migratedConfig.node).length) {
delete migratedConfig.node;
} else {
- const subMigrate = migrateConfig(val);
+ const subMigrate = migrateConfig(migratedConfig.node);
migratedConfig.node = subMigrate.migratedConfig;
}
} else if (isObject(val)) {
|
fix: node-travis migration
|
renovatebot_renovate
|
train
|
js
|
3c1ba18b6a92b75ab7636b813ff94b5875c9f389
|
diff --git a/src/components/table/sortable-header/sortable-header.js b/src/components/table/sortable-header/sortable-header.js
index <HASH>..<HASH> 100644
--- a/src/components/table/sortable-header/sortable-header.js
+++ b/src/components/table/sortable-header/sortable-header.js
@@ -91,7 +91,7 @@ const SortableHeader = props => {
{isArrowDown ? (
<AngleDownIcon size="medium" color="surface" />
) : (
- <AngleUpIcon size="medium" theme="neutral60" />
+ <AngleUpIcon size="medium" color="neutral60" />
)}
</Span>
</Container>
|
fix(table): sortable header icon color (#<I>)
|
commercetools_ui-kit
|
train
|
js
|
1037b9c9be12ff6be65a1619398f24fa64930393
|
diff --git a/packages/@vue/cli-service/lib/config/css.js b/packages/@vue/cli-service/lib/config/css.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-service/lib/config/css.js
+++ b/packages/@vue/cli-service/lib/config/css.js
@@ -103,6 +103,7 @@ module.exports = (api, options) => {
}
createCSSRule('css', /\.css$/)
+ createCSSRule('postcss', /\.p(ost)?css$/)
createCSSRule('scss', /\.scss$/, 'sass-loader', loaderOptions.sass)
createCSSRule('sass', /\.sass$/, 'sass-loader', Object.assign({
indentedSyntax: true
|
feat: support `<style lang="postcss">` (#<I>)
|
vuejs_vue-cli
|
train
|
js
|
dd0dabe17b202863d149b2ce304a5b3781131b8a
|
diff --git a/src/wrappers/wrapper.js b/src/wrappers/wrapper.js
index <HASH>..<HASH> 100644
--- a/src/wrappers/wrapper.js
+++ b/src/wrappers/wrapper.js
@@ -185,6 +185,8 @@ export default class Wrapper implements BaseWrapper {
* Checks if wrapper has a style with value
*/
hasStyle (style: string, value: string) {
+ warn('hasStyle() has been deprecated and will be removed in version 1.0.0. Use wrapper.element.style instead')
+
if (typeof style !== 'string') {
throwError('wrapper.hasStyle() must be passed style as a string')
}
|
refactor: add deprecation notice to hasStyle
|
vuejs_vue-test-utils
|
train
|
js
|
58b70430a33aa927987c090e9b5fa8cfa912735f
|
diff --git a/__tests__/monorepo-deps.test.js b/__tests__/monorepo-deps.test.js
index <HASH>..<HASH> 100644
--- a/__tests__/monorepo-deps.test.js
+++ b/__tests__/monorepo-deps.test.js
@@ -65,7 +65,7 @@ describe('Bolt Components declare dependencies in package.json if used in Twig f
[join(boltPkg.location, '**/*.twig')],
{
gitignore: true,
- ignore: ['**/__tests__/**'],
+ ignore: ['**/__tests__/**', '**/node_modules/**', '**/vendor/**'],
},
);
|
fix: prevent globbing into gitignore folders
|
bolt-design-system_bolt
|
train
|
js
|
77747e337d565f835430cf9c07f5e29d64e9031c
|
diff --git a/version.go b/version.go
index <HASH>..<HASH> 100644
--- a/version.go
+++ b/version.go
@@ -11,7 +11,7 @@ import (
var CurrentCommit string
// CurrentVersionNumber is the current application's version literal
-const CurrentVersionNumber = "0.14.0-rc1"
+const CurrentVersionNumber = "0.14.0"
const ApiVersion = "/kubo/" + CurrentVersionNumber + "/"
|
chore: bump to <I>
|
ipfs_go-ipfs
|
train
|
go
|
fc8b579552c48c292d0eab4fe3a55d18789afe07
|
diff --git a/lib/api_client.js b/lib/api_client.js
index <HASH>..<HASH> 100644
--- a/lib/api_client.js
+++ b/lib/api_client.js
@@ -18,9 +18,12 @@ class APIClientBase extends Base {
}
this._client = wrapper.create(options);
utils.delegateEvents(this._client, this);
- this._client.ready(err => {
- this.ready(err ? err : true);
- });
+
+ if (!options.initMethod) {
+ this._client.ready(err => {
+ this.ready(err ? err : true);
+ });
+ }
}
get DataClient() {
|
fix: don't auto ready when initMethod exists (#<I>)
|
node-modules_cluster-client
|
train
|
js
|
f9cdb2df04f24c0b7b25d8e7c9c6059f1ed10687
|
diff --git a/pipeline/snapshot/snapshot_test.go b/pipeline/snapshot/snapshot_test.go
index <HASH>..<HASH> 100644
--- a/pipeline/snapshot/snapshot_test.go
+++ b/pipeline/snapshot/snapshot_test.go
@@ -3,13 +3,32 @@ package snapshot
import (
"testing"
+ "github.com/goreleaser/goreleaser/config"
+ "github.com/goreleaser/goreleaser/context"
"github.com/stretchr/testify/assert"
)
func TestStringer(t *testing.T) {
assert.NotEmpty(t, Pipe{}.String())
}
-
func TestDefault(t *testing.T) {
- // TODO: implement this
+ var ctx = &context.Context{
+ Config: config.Project{
+ Snapshot: config.Snapshot{},
+ },
+ }
+ assert.NoError(t, Pipe{}.Default(ctx))
+ assert.Equal(t, "SNAPSHOT-{{ .Commit }}", ctx.Config.Snapshot.NameTemplate)
+}
+
+func TestDefaultSet(t *testing.T) {
+ var ctx = &context.Context{
+ Config: config.Project{
+ Snapshot: config.Snapshot{
+ NameTemplate: "snap",
+ },
+ },
+ }
+ assert.NoError(t, Pipe{}.Default(ctx))
+ assert.Equal(t, "snap", ctx.Config.Snapshot.NameTemplate)
}
|
test: added test for snapshot
Added tests for snapshot defaulter
|
goreleaser_goreleaser
|
train
|
go
|
e4c2a3ecf4411fcc1f85f22d28e1f5655da7f165
|
diff --git a/src/FormFeedback/index.js b/src/FormFeedback/index.js
index <HASH>..<HASH> 100644
--- a/src/FormFeedback/index.js
+++ b/src/FormFeedback/index.js
@@ -46,7 +46,7 @@ StyledFormFeedback.defaultProps = {
const FormFeedback = (props: Props) => {
const { children, type = TYPE_OPTIONS.HELP, dataTest } = props;
return (
- <StyledFormFeedback type={type} data-test={dataTest}>
+ <StyledFormFeedback type={type} data-test={dataTest} aria-live="polite">
{children}
</StyledFormFeedback>
);
|
fix(FormElements): adding aria polite to errors (#<I>)
|
kiwicom_orbit-components
|
train
|
js
|
813a1de7c6e08420a049156e23332eed9787bfe0
|
diff --git a/lib/style.js b/lib/style.js
index <HASH>..<HASH> 100644
--- a/lib/style.js
+++ b/lib/style.js
@@ -20,8 +20,11 @@ module.exports = function (hexo, config) {
var files = config.css;
var content = '';
+ // 处理为字符时，在 yml 里没有使用 `-` 则为字符串
if ('string' === typeof files) {
- files = String(config.css || '').split(/\s+/);
+ files = String(config.css || '').split(/\s+/).filter(function (filename) {
+ return !!filename;
+ });
}
if (!files || !files.length) {
|
fix: there are spaces in `config.mip.css`
|
xuexb_hexo-generator-mip
|
train
|
js
|
1fa9a3e0a5d8bb4a9ef2b6a9697f8c4d4a571b3f
|
diff --git a/server/api.js b/server/api.js
index <HASH>..<HASH> 100644
--- a/server/api.js
+++ b/server/api.js
@@ -1,4 +1,5 @@
let plugins = require('./plugins')
+let watcher = require('./watcher')
let Router = require('yiss')
let wch = require('./client')
let log = require('./log')
@@ -55,7 +56,12 @@ api.GET('/events', async (req, res) => {
api.POST('/stop', (req) => {
log.red('Shutting down...')
- setTimeout(() => req.app.close(), 100)
+ setTimeout(() => {
+ req.app.close()
+ watcher.stream.each(stream => {
+ stream.destroy()
+ })
+ }, 100)
return true
})
|
fix: destroy streams on POST /stop
|
aleclarson_wch
|
train
|
js
|
76a171de13d1812733be8a58f50571d2a3501775
|
diff --git a/schema/validator.js b/schema/validator.js
index <HASH>..<HASH> 100644
--- a/schema/validator.js
+++ b/schema/validator.js
@@ -2,7 +2,9 @@ var Ajv = require('ajv');
var ajv = new Ajv({allErrors: true});
module.exports = function validate(schema, data) {
- var ajv = new Ajv();
+ var ajv = new Ajv({
+ errorDataPath: 'property'
+ });
var isValid = ajv.validate(schema, data);
if(!isValid) {
diff --git a/test/extract.test.js b/test/extract.test.js
index <HASH>..<HASH> 100644
--- a/test/extract.test.js
+++ b/test/extract.test.js
@@ -29,7 +29,7 @@ describe("ExtractTextPlugin.extract()", function() {
ExtractTextPlugin.extract({style: 'file.css'});
},
function(err) {
- return err.message === 'data should NOT have additional properties';
+ return err.message === 'data[\'style\'] should NOT have additional properties';
}
);
});
|
feat(errors): show nicer errors if there are extra fields
Now you can see which field caused the error.
|
webpack-contrib_extract-text-webpack-plugin
|
train
|
js,js
|
53ed3bdb9994c5360973765fb1f9d4b43ef7f972
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -342,7 +342,7 @@ class Node extends EventEmitter {
}
if (t.filter(multiaddrs).length > 0) {
- this._switch.transport.add(t.tag || t.constructor.name, t)
+ this._switch.transport.add(t.tag || t[Symbol.toStringTag], t)
} else if (WebSockets.isWebSockets(t)) {
// TODO find a cleaner way to signal that a transport is always used
// for dialing, even if no listener
|
fix: use symbol instead of constructor name (#<I>)
|
libp2p_js-libp2p
|
train
|
js
|
bfe5de40cf8b111bf9d863a176f11fac96709595
|
diff --git a/commands/Seed.js b/commands/Seed.js
index <HASH>..<HASH> 100644
--- a/commands/Seed.js
+++ b/commands/Seed.js
@@ -140,17 +140,17 @@ class SeedDatabase extends Command {
const endTime = process.hrtime(startTime)
this.success(`Seeded database in ${prettyHrTime(endTime)}`)
-
- /**
- * Close the connection when seeder are executed and keep alive is
- * not passed
- */
- if (!keepAlive) {
- this.Database.close()
- }
} catch (error) {
console.log(error)
}
+
+ /**
+ * Close the connection when seeder are executed and keep alive is
+ * not passed
+ */
+ if (!keepAlive) {
+ this.Database.close()
+ }
}
}
|
refactor(seed): auto close connection regardless of seed errors
|
adonisjs_adonis-lucid
|
train
|
js
|
d885a27ea1c8445137c653f5c563f8edfb56a82c
|
diff --git a/tests/tests.py b/tests/tests.py
index <HASH>..<HASH> 100755
--- a/tests/tests.py
+++ b/tests/tests.py
@@ -16,6 +16,7 @@ class DNSTest(unittest.TestCase):
def setUp(self):
self.channel = pycares.Channel(timeout=10.0, tries=1, servers=['8.8.8.8', '8.8.4.4'])
+ self.is_ci = os.environ.get('APPVEYOR') or os.environ.get('TRAVIS') or os.environ.get('GITHUB_ACTION')
def tearDown(self):
self.channel = None
@@ -36,7 +37,7 @@ class DNSTest(unittest.TestCase):
self.channel.process_fd(pycares.ARES_SOCKET_BAD, fd)
def assertNoError(self, errorno):
- if errorno == pycares.errno.ARES_ETIMEOUT and (os.environ.get('APPVEYOR') or os.environ.get('TRAVIS')):
+ if errorno == pycares.errno.ARES_ETIMEOUT and self.is_ci:
raise unittest.SkipTest('timeout')
self.assertEqual(errorno, None)
|
test: add generic way to check for a CI
|
saghul_pycares
|
train
|
py
|
af98f9993df068c487558114ae025635d7dc045c
|
diff --git a/lib/client/dialog_api.js b/lib/client/dialog_api.js
index <HASH>..<HASH> 100644
--- a/lib/client/dialog_api.js
+++ b/lib/client/dialog_api.js
@@ -26,7 +26,9 @@ class DialogApi extends BaseApi {
this.deferreds[message.data.dialogId].reject(message);
}
- this.close();
+ if (message.data.autoClose !== false) {
+ this.close();
+ }
}
}
|
feat(dialog): auto-closing a dialog can be skipped now
|
emartech_emarsys-integration-client-js
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.