hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
f22f099eace4a1e4fc287eff9530aecf3ff4ae15
|
diff --git a/tooling/circle-cli/lib/download-artifacts.js b/tooling/circle-cli/lib/download-artifacts.js
index <HASH>..<HASH> 100644
--- a/tooling/circle-cli/lib/download-artifacts.js
+++ b/tooling/circle-cli/lib/download-artifacts.js
@@ -17,6 +17,7 @@ module.exports = _.curry((argv, ci, build) => {
return ci.getBuildArtifacts(build)
.then((artifacts) => {
+ console.log(require('util').inspect(artifacts, { depth: null }));
return artifacts.reduce((promise, artifact) => {
return promise.then(() => downloadArtifact(artifact));
}, Promise.resolve());
|
chore(tooling): log available artifacts #no-push
|
webex_spark-js-sdk
|
train
|
js
|
aa8fc589ee14f6b1e369f430dcd22fdc70a7087c
|
diff --git a/src/Queue/AdapterTrait.php b/src/Queue/AdapterTrait.php
index <HASH>..<HASH> 100644
--- a/src/Queue/AdapterTrait.php
+++ b/src/Queue/AdapterTrait.php
@@ -42,6 +42,10 @@ trait AdapterTrait
return $this->connection;
}
+ /**
+ * @return string
+ * @codeCoverageIgnore
+ */
public function getConnectionName()
{
return $this->connectionName;
@@ -63,8 +67,12 @@ trait AdapterTrait
return $queue ?: $this->defaultQueue;
}
+ abstract public function pop($queue = null);
+
public function push($worker, $data = '', $queue = null, array $options = [])
{
return $this->pushRaw($this->createPayload($worker, $data), $queue, $options);
}
+
+ abstract public function pushRaw($payload, $queue = null, array $options = []);
}
|
refactor(queue): add abstract pushRaw() and pop() method to queue adapter trait
|
phwoolcon_phwoolcon
|
train
|
php
|
271bbacf4c39b84caea33ac1dcaeaab6e5a2db3f
|
diff --git a/src/modules/auth.js b/src/modules/auth.js
index <HASH>..<HASH> 100644
--- a/src/modules/auth.js
+++ b/src/modules/auth.js
@@ -19,11 +19,6 @@ export function authChange (params) {
// Checks if authentication is enabled
export const authEnabled = (dispatch, getState) => {
const state = getState()
- if (!state.auth.enabled) {
- console.error('modules/auth :: Auth not configured, check your .env file and ensure all AUTH variables are configured correctly.')
- dispatch(interfaceMessage('AUTH_NOT_ENABLED'))
- }
-
return state.auth.enabled
}
|
fix: Removes UI feedback when auth is disabled
|
techcoop_react-material-site
|
train
|
js
|
be2219dc1f1ffca24e524b45fbd2af21e435afb1
|
diff --git a/core/src/elements/ons-dialog/index.js b/core/src/elements/ons-dialog/index.js
index <HASH>..<HASH> 100644
--- a/core/src/elements/ons-dialog/index.js
+++ b/core/src/elements/ons-dialog/index.js
@@ -227,12 +227,10 @@ export default class DialogElement extends BaseElement {
const container = document.createElement('div');
container.classList.add('dialog-container');
-
- dialog.appendChild(container);
-
while (this.firstChild) {
container.appendChild(this.firstChild);
}
+ dialog.appendChild(container);
this.appendChild(dialog);
}
|
refactor(dialog): Reorder statements.
|
OnsenUI_OnsenUI
|
train
|
js
|
b8a51ec7ca7ec8195d588f2361a2c17d167b1ad7
|
diff --git a/components/form/form.js b/components/form/form.js
index <HASH>..<HASH> 100644
--- a/components/form/form.js
+++ b/components/form/form.js
@@ -59,10 +59,10 @@ export default class Form extends Intact {
_submit(e) {
e.preventDefault();
- this.submit();
+ this.submit(e);
}
- submit() {
+ submit(e) {
this.validate().then(isValid => {
if (isValid) {
this.trigger('submit', e, this);
|
fix(Form): event is undefined when call submit manually, #<I>
|
ksc-fe_kpc
|
train
|
js
|
976a03c9e55281ad9ef07dc484c32e6dbd400553
|
diff --git a/extensions/mentions/js/src/forum/components/PostMentionedNotification.js b/extensions/mentions/js/src/forum/components/PostMentionedNotification.js
index <HASH>..<HASH> 100644
--- a/extensions/mentions/js/src/forum/components/PostMentionedNotification.js
+++ b/extensions/mentions/js/src/forum/components/PostMentionedNotification.js
@@ -23,6 +23,6 @@ export default class PostMentionedNotification extends Notification {
}
excerpt() {
- return truncate(this.attrs.notification.subject().contentPlain(), 200);
+ return truncate(this.attrs.notification.subject().contentPlain() || '', 200);
}
}
|
fix: post mention notification errors with _no content_ subjects (#<I>)
|
flarum_core
|
train
|
js
|
622e88b134f77f0ec77e0398be0b41b5eae1ea65
|
diff --git a/src/TokenizerBuilder.js b/src/TokenizerBuilder.js
index <HASH>..<HASH> 100644
--- a/src/TokenizerBuilder.js
+++ b/src/TokenizerBuilder.js
@@ -27,10 +27,10 @@ var DictionaryLoader = require("./loader/NodeDictionaryLoader");
* @constructor
*/
function TokenizerBuilder(option) {
- if (option.dicPath != null) {
- this.dic_path = option.dicPath;
- } else {
+ if (option.dicPath == null) {
this.dic_path = "dict/";
+ } else {
+ this.dic_path = option.dicPath;
}
}
|
refactor: toggle if condition
|
takuyaa_kuromoji.js
|
train
|
js
|
75dc830af24a54fc97c5ed333e95b13adc0b2e74
|
diff --git a/test/helpers/kubectl.go b/test/helpers/kubectl.go
index <HASH>..<HASH> 100644
--- a/test/helpers/kubectl.go
+++ b/test/helpers/kubectl.go
@@ -4206,7 +4206,17 @@ func validateCiliumSvc(cSvc models.Service, k8sSvcs []v1.Service, k8sEps []v1.En
k8sService = &k8sSvc
break
}
+ for _, clusterIP := range k8sSvc.Spec.ClusterIPs {
+ if clusterIP == cSvc.Status.Realized.FrontendAddress.IP {
+ k8sService = &k8sSvc
+ break
+ }
+ }
+ if k8sService != nil {
+ break
+ }
}
+
if k8sService == nil {
return fmt.Errorf("Could not find Cilium service with ip %s in k8s", cSvc.Spec.FrontendAddress.IP)
}
|
test: Fix svc validation of ClusterIPs
Previously, the validateCiliumSvc() routine was assuming that ClusterIP
can be set only in a dedicated field, and it didn't consider the list of
ClusterIPs which are set when the DualStack is enabled.
The validateCiliumSvc() check gives very little value and it can be
removed. To avoid adding more variables to the net-next switch to k8s
<I>, let's do it in a separate PR.
|
cilium_cilium
|
train
|
go
|
1bf72477e362c7e84dfa43940d1e8a2c2177961d
|
diff --git a/ui/src/components/dialog/QDialog.js b/ui/src/components/dialog/QDialog.js
index <HASH>..<HASH> 100644
--- a/ui/src/components/dialog/QDialog.js
+++ b/ui/src/components/dialog/QDialog.js
@@ -259,7 +259,7 @@ export default Vue.extend({
__onFocusChange (e) {
// the focus is not in a vue child component
if (
- this.__getInnerNode() !== void 0 &&
+ this.__portal !== void 0 &&
childHasFocus(this.__portal.$el, e.target) !== true
) {
this.focus()
|
perf(QDialog): small tweak to __onFocusChange
|
quasarframework_quasar
|
train
|
js
|
d159e0f597506e22bdd4d72e1c2014e6b065072e
|
diff --git a/src/Listener/ViewListener.php b/src/Listener/ViewListener.php
index <HASH>..<HASH> 100644
--- a/src/Listener/ViewListener.php
+++ b/src/Listener/ViewListener.php
@@ -513,7 +513,7 @@ class ViewListener extends BaseListener
$associations = $table->associations();
$keys = $associations->keys();
- if ($whitelist) {
+ if (!empty($whitelist)) {
$keys = array_intersect($keys, array_map('strtolower', $whitelist));
}
foreach ($keys as $associationName) {
|
fix: clarify that we want to check for a non-empty array
|
FriendsOfCake_crud-view
|
train
|
php
|
f1e53163f78bb01245233006cf6d4e48bc60bfb8
|
diff --git a/src/cli.js b/src/cli.js
index <HASH>..<HASH> 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -57,5 +57,13 @@ const cli = {
}
;(async function main () {
- await cli[command]();
+ try {
+ await cli[command]();
+ }
+ catch (err) {
+ if (err instanceof Error) {
+ return console.error(err.stack);
+ }
+ console.error(err);
+ }
})();
|
fix(errors): Fix uncaught promise errors.
|
Aldlevine_comptroller
|
train
|
js
|
a3f61ea4404a7ae6f7141f9a2c553190ca6e2541
|
diff --git a/src/LumenGenerator/Console/ServeCommand.php b/src/LumenGenerator/Console/ServeCommand.php
index <HASH>..<HASH> 100644
--- a/src/LumenGenerator/Console/ServeCommand.php
+++ b/src/LumenGenerator/Console/ServeCommand.php
@@ -46,11 +46,18 @@ class ServeCommand extends Command
*/
protected function serverCommand()
{
- return sprintf('%s -S %s:%s %s/server.php',
+ $base = base_path();
+ if (file_exists("$base/server.php")) {
+ $command = '%s -S %s:%s %s/server.php';
+ } else {
+ $command = '%s -S %s:%s -t %s/public/';
+ }
+
+ return sprintf($command,
ProcessUtils::escapeArgument((new PhpExecutableFinder)->find(false)),
$this->host(),
$this->port(),
- ProcessUtils::escapeArgument(base_path())
+ ProcessUtils::escapeArgument($base)
);
}
|
fix: artisan serve error
Fix "Failed opening required 'server.php'" error.
|
flipboxstudio_lumen-generator
|
train
|
php
|
76684cb6fbd4f14d9f8796a2ca9a7961e83ffc12
|
diff --git a/src/resources/views/character/includes/summary.blade.php b/src/resources/views/character/includes/summary.blade.php
index <HASH>..<HASH> 100644
--- a/src/resources/views/character/includes/summary.blade.php
+++ b/src/resources/views/character/includes/summary.blade.php
@@ -151,6 +151,13 @@
<img src="{{ asset('web/img/eve-prism.png') }}" />
</a>
</span>
+ @can('global.superuser')
+ @if(! is_null($character->refresh_token))
+ <a href="{{ route('configuration.users.edit', $character->refresh_token->user_id) }}" class="btn btn-xs btn-secondary float-right">
+ <i class="fas fa-user"></i> {{ trans_choice('web::seat.user', 1) }}
+ </a>
+ @endif
+ @endcan
</div>
</div>
|
feat: add user card link on character summary
Closes: eveseat/seat#<I>
|
eveseat_web
|
train
|
php
|
72caea9c0a6b7a9af2aa03f18542fef7bd85e099
|
diff --git a/reuseport_test.go b/reuseport_test.go
index <HASH>..<HASH> 100644
--- a/reuseport_test.go
+++ b/reuseport_test.go
@@ -41,7 +41,7 @@ func TestReuseError(t *testing.T) {
for k, v := range cases {
if ReuseErrShouldRetry(k) != v {
- t.Fatalf("expected %b for %#v", v, k)
+ t.Fatalf("expected %t for %#v", v, k)
}
}
|
fix(govet): correct fmt for bool is %t
|
libp2p_go-tcp-transport
|
train
|
go
|
002f71369c4a133f62af42dabfbef0c0c5bc4b7d
|
diff --git a/source/rafcon/gui/start.py b/source/rafcon/gui/start.py
index <HASH>..<HASH> 100755
--- a/source/rafcon/gui/start.py
+++ b/source/rafcon/gui/start.py
@@ -83,9 +83,11 @@ def setup_installation():
If RAFCON is started directly from the repo or from RMPM (without a previous installation), it can be forced to
install all additionally required files (icons and gtksourceview styles) by setting the env variable
- `RAFCON_CHECK_INSTALLATION` to "True".
+ `RAFCON_CHECK_INSTALLATION` to "True". If `RAFCON_CHECK_INSTALLATION` is set to "False", it will prevent a restart
+ of RAFCON e.g. after updating the font cache.
"""
force_check_installation = os.environ.get("RAFCON_CHECK_INSTALLATION", False) == "True"
+ prevent_restart = os.environ.get("RAFCON_CHECK_INSTALLATION", True) == "False"
if not force_check_installation and data_files_version_up_to_date():
return
@@ -93,7 +95,7 @@ def setup_installation():
if force_check_installation or installation.started_without_installation() or installation.started_in_virtualenv():
installation.install_locally_required_files()
- installation.install_fonts(restart=True)
+ installation.install_fonts(restart=(not prevent_restart))
update_data_files_version()
|
fix(start): Prevent repeated RAFCON restarts
If the env var RAFCON_CHECK_INSTALLATION is set to "False", a RAFCON
restart is prevented. The env var is set after installing fonts.
|
DLR-RM_RAFCON
|
train
|
py
|
7a9c392ac4d3cf9926fb7988b63bcd1e96ff25ce
|
diff --git a/lib/watchy.js b/lib/watchy.js
index <HASH>..<HASH> 100644
--- a/lib/watchy.js
+++ b/lib/watchy.js
@@ -357,7 +357,7 @@ WatchyObserver.prototype.remove = function (callback) {
if (index !== -1) {
this.callbacks.splice(index, 1)
} else {
- console.error('Callback not found ?', callback)
+ // Callback allready removed (certainly closed manually)
}
}
|
fix: Ignore allready closed watcher
|
nodys_elastomer
|
train
|
js
|
cc71edeb4446efbdedf7174fa0a032ed108d7673
|
diff --git a/libs/request.js b/libs/request.js
index <HASH>..<HASH> 100644
--- a/libs/request.js
+++ b/libs/request.js
@@ -1,4 +1,5 @@
let request = require('request-promise')
+const requestdebug = require('request-debug')
const log = require('./logger')
let singleton = null
@@ -22,7 +23,7 @@ module.exports = function (options = {}) {
options = Object.assign(defaultOptions, options)
- if (options.debug) require('request-debug')(request)
+ if (options.debug) requestdebug(request)
const requestOptions = {}
|
fix: bad request-debug dependency
|
konnectors_libs
|
train
|
js
|
4cf57255dbd3f601272f5d8e06c5baa5f23f48e8
|
diff --git a/src/components/Lookup/index.js b/src/components/Lookup/index.js
index <HASH>..<HASH> 100644
--- a/src/components/Lookup/index.js
+++ b/src/components/Lookup/index.js
@@ -421,6 +421,7 @@ class Lookup extends Component {
hideLabel,
isLoading,
icon,
+ variant,
} = this.props;
const { searchValue, focusedItemIndex, options } = this.state;
const onDeleteValue = disabled || readOnly ? undefined : this.handleRemoveValue;
@@ -508,6 +509,7 @@ class Lookup extends Component {
icon={icon}
error={error}
isLoading={isLoading}
+ variant={variant}
/>
<RenderIf isTrue={isLookupOpen}>
<StyledOptionsMenu id={this.listboxId} role="listbox">
@@ -617,6 +619,9 @@ Lookup.propTypes = {
style: PropTypes.object,
/** The index of the option that is visual-focus initially */
preferredSelectedOption: PropTypes.number,
+ /** The variant changes the appearance of the Input. Accepted variants include default,
+ * shaded and bare. This value defaults to default. */
+ variant: PropTypes.oneOf(['default', 'shaded', 'bare']),
};
Lookup.defaultProps = {
@@ -645,6 +650,7 @@ Lookup.defaultProps = {
onSearch: () => {},
debounce: false,
preferredSelectedOption: 0,
+ variant: 'default',
};
export default withReduxForm(Lookup);
|
feat: implement shaded and bare variants on Lookup component (#<I>)
* feat: implement shaded and bare variants on Lookup component
* feat: add examples for shaded and bare variants
* fix: example
|
90milesbridge_react-rainbow
|
train
|
js
|
ee47fe6fcd8216e1ca7decad9afeac31458845dc
|
diff --git a/apps/actor-web/js/components/dialog/MessagesSection.react.js b/apps/actor-web/js/components/dialog/MessagesSection.react.js
index <HASH>..<HASH> 100644
--- a/apps/actor-web/js/components/dialog/MessagesSection.react.js
+++ b/apps/actor-web/js/components/dialog/MessagesSection.react.js
@@ -48,7 +48,7 @@ var MessagesSection = React.createClass({
_getMessagesListItem: function (message, index) {
return (
- <ReadableMessage key={index} peer={this.props.peer} message={message}/>
+ <ReadableMessage key={message.sortKey} peer={this.props.peer} message={message}/>
);
}
});
|
fix(web): use message.sortKey as react key
|
actorapp_actor-platform
|
train
|
js
|
3e1b641ee595a2acc7a807679578c0ab076d9ee2
|
diff --git a/src/components/source.js b/src/components/source.js
index <HASH>..<HASH> 100644
--- a/src/components/source.js
+++ b/src/components/source.js
@@ -124,7 +124,6 @@ module.exports = class ComponentSource extends Source {
// }
*_wrapInLayout(content, previewHandle, context) {
- console.log(previewHandle);
let layout = this.find(previewHandle);
if (!layout) {
logger.error(`Preview layout ${previewHandle} not found.`);
|
fix(components): remove stray console log call
|
frctl_fractal
|
train
|
js
|
e8d7f87fe816d4edcf948d5b25a540aa5ea67bd5
|
diff --git a/engine/src/test/java/org/camunda/bpm/engine/test/concurrency/DbDeadlockTest.java b/engine/src/test/java/org/camunda/bpm/engine/test/concurrency/DbDeadlockTest.java
index <HASH>..<HASH> 100644
--- a/engine/src/test/java/org/camunda/bpm/engine/test/concurrency/DbDeadlockTest.java
+++ b/engine/src/test/java/org/camunda/bpm/engine/test/concurrency/DbDeadlockTest.java
@@ -21,11 +21,13 @@ import org.camunda.bpm.engine.impl.db.entitymanager.DbEntityManagerFactory;
import org.camunda.bpm.engine.impl.history.event.HistoricProcessInstanceEventEntity;
import org.camunda.bpm.engine.impl.interceptor.Command;
import org.camunda.bpm.engine.impl.interceptor.CommandContext;
+import org.junit.Ignore;
/**
* @author Daniel Meyer
*
*/
+@Ignore // remove after CAM-4060 is solved
public class DbDeadlockTest extends ConcurrencyTestCase {
private ThreadControl thread1;
|
chore(engine): ignore DbDeadlockTest until fixed
related to #CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
java
|
9e0110693dad1f55300da668a266548d877ec209
|
diff --git a/test/k8sT/istio.go b/test/k8sT/istio.go
index <HASH>..<HASH> 100644
--- a/test/k8sT/istio.go
+++ b/test/k8sT/istio.go
@@ -29,7 +29,9 @@ import (
// This tests the Istio integration, following the configuration
// instructions specified in the Istio Getting Started Guide in
// Documentation/gettingstarted/istio.rst.
-var _ = Describe("K8sIstioTest", func() {
+var _ = SkipContextIf(func() bool {
+ return helpers.SkipQuarantined() && helpers.GetCurrentK8SEnv() == "1.19"
+}, "K8sIstioTest", func() {
var (
// istioSystemNamespace is the default namespace into which Istio is
|
test: Quarantine K8sIstioTest while flaky
This commit quarantines the Istio test on K8s <I> as it is currently
flaky and makes subsequent tests fail.
Related: #<I>
|
cilium_cilium
|
train
|
go
|
257524c016bc9d04745f4231ddd74ccabe3eac0d
|
diff --git a/src/lambda/handler-runner/docker-runner/DockerContainer.js b/src/lambda/handler-runner/docker-runner/DockerContainer.js
index <HASH>..<HASH> 100644
--- a/src/lambda/handler-runner/docker-runner/DockerContainer.js
+++ b/src/lambda/handler-runner/docker-runner/DockerContainer.js
@@ -12,7 +12,7 @@ import pRetry from 'p-retry'
import DockerImage from './DockerImage.js'
const { stringify } = JSON
-const { entries, hasOwn, keys } = Object
+const { entries, hasOwn } = Object
export default class DockerContainer {
#containerId = null
@@ -311,9 +311,10 @@ export default class DockerContainer {
const data = await readFile(layerZipFile)
const zip = await jszip.loadAsync(data)
+
await Promise.all(
- keys(zip.files).map(async (filename) => {
- const fileData = await zip.files[filename].async('nodebuffer')
+ entries(zip.files).map(async ([filename, jsZipObj]) => {
+ const fileData = await jsZipObj.async('nodebuffer')
if (filename.endsWith(sep)) {
return Promise.resolve()
}
|
refactor: use Object.entries
|
dherault_serverless-offline
|
train
|
js
|
d32c38bad2b3db3c52482ab4be0953e2bc36c17e
|
diff --git a/src/common.js b/src/common.js
index <HASH>..<HASH> 100644
--- a/src/common.js
+++ b/src/common.js
@@ -284,20 +284,6 @@ function unroll(callback) {
};
}
-function flattenPrototypeChain(obj) {
- var objs = [];
- do {
- objs.push(obj);
- } while ((obj = Object.getPrototypeOf(obj)));
- objs.reverse();
-
- var result = {};
- forEach(objs, function(obj) {
- extend(result, obj);
- });
- return result;
-}
-
// Return a completely flattened version of an array.
function flatten (array) {
function _flatten(input, output) {
|
chore(common): removed flattenPrototypeChain
|
ui-router_angular
|
train
|
js
|
666c42ca12206a8c7c9843d79a080684993c4e11
|
diff --git a/lib/index.js b/lib/index.js
index <HASH>..<HASH> 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -36,7 +36,7 @@ function proxy(callback) {
if (!socket.writable) {
return socket.destroy(err);
}
- var stack = util.getErrorStack(err);
+ var stack = util.getErrorStack('clientError: Bad request');
socket.end('HTTP/1.1 400 Bad Request\r\n\r\n' + stack);
});
initSocketMgr(proxyEvents);
@@ -98,7 +98,7 @@ function exportInterfaces(obj) {
}
process.on('uncaughtException', function(err){
- var stack = util.getErrorStack('clientError: Bad request');
+ var stack = util.getErrorStack(err);
fs.writeFileSync(path.join(process.cwd(), config.name + '.log'), '\r\n' + stack + '\r\n', {flag: 'a'});
/*eslint no-console: "off"*/
console.error(stack);
|
refactor: clientError
|
avwo_whistle
|
train
|
js
|
706cd05aebb231242324dba0cef6667eeda98df1
|
diff --git a/lib/gui/constants/server.js b/lib/gui/constants/server.js
index <HASH>..<HASH> 100644
--- a/lib/gui/constants/server.js
+++ b/lib/gui/constants/server.js
@@ -1,5 +1,5 @@
'use strict';
module.exports = {
- MAX_REQUEST_SIZE: '50mb'
+ MAX_REQUEST_SIZE: '100mb'
};
|
fix: x2 max request size
|
gemini-testing_html-reporter
|
train
|
js
|
f4f3891f64a834b85409281cac396cb5ee20a18a
|
diff --git a/test/test-pmctl-local.js b/test/test-pmctl-local.js
index <HASH>..<HASH> 100644
--- a/test/test-pmctl-local.js
+++ b/test/test-pmctl-local.js
@@ -151,11 +151,7 @@ function test(port) {
expect('set-size 1');
waiton('status', /worker count: *1/);
- if (require('semver').gt(process.version, '0.11.0')) {
- expect('cpu-start 0', /Profiler started/);
- } else {
- failon('cpu-start 0', /CPU profiler unavailable/);
- }
+ expect('cpu-start 0', /Profiler started/);
if (process.env.STRONGLOOP_LICENSE) {
expect('objects-start 1');
|
test: cpu profiling now supported on <I>
|
strongloop_strong-pm
|
train
|
js
|
413a60f8835bcae4597e7d9f418ad5907dbb6973
|
diff --git a/Gemfile.lock b/Gemfile.lock
index <HASH>..<HASH> 100644
--- a/Gemfile.lock
+++ b/Gemfile.lock
@@ -1,7 +1,7 @@
PATH
remote: .
specs:
- ecic (0.2.0)
+ ecic (0.2.1)
activesupport
colorize
rake
diff --git a/lib/ecic/project.rb b/lib/ecic/project.rb
index <HASH>..<HASH> 100644
--- a/lib/ecic/project.rb
+++ b/lib/ecic/project.rb
@@ -4,7 +4,7 @@ module Ecic
require 'pathname'
- SCRIPT_ECIC = File.join('config', 'ecic.rb')
+ SCRIPT_ECIC = File.join('src', 'config', 'ecic.rb')
#Function that returns the root directory of a ECIC project
def self.root(path = Pathname.new(Dir.pwd))
diff --git a/lib/ecic/version.rb b/lib/ecic/version.rb
index <HASH>..<HASH> 100644
--- a/lib/ecic/version.rb
+++ b/lib/ecic/version.rb
@@ -1,3 +1,3 @@
module Ecic
- VERSION = "0.2.0"
+ VERSION = "0.2.1"
end
|
fix: library generator created library in wrong folder
|
ic-factory_ecic
|
train
|
lock,rb,rb
|
b6f8489f70c97832c5281726cec9a9e24e818733
|
diff --git a/lib/ditty/helpers/response.rb b/lib/ditty/helpers/response.rb
index <HASH>..<HASH> 100644
--- a/lib/ditty/helpers/response.rb
+++ b/lib/ditty/helpers/response.rb
@@ -25,6 +25,7 @@ module Ditty
)
end
format.csv do
+ attachment "#{base_path}.csv"
CSV.generate do |csv|
csv << result.first.for_csv.keys
result.all.each do |r|
|
fix: Send file name when serving CSV
|
EagerELK_ditty
|
train
|
rb
|
ea9bfab5814c6811de7c99f58fdd4110cd9e4431
|
diff --git a/src/foremast/pipeline/create_pipeline.py b/src/foremast/pipeline/create_pipeline.py
index <HASH>..<HASH> 100644
--- a/src/foremast/pipeline/create_pipeline.py
+++ b/src/foremast/pipeline/create_pipeline.py
@@ -140,7 +140,6 @@ class SpinnakerPipeline:
for region, pipeline in pipelines.items():
renumerate_stages(pipeline)
- self.log.info('Updating Pipeline for %s.', region)
self.post_pipeline(pipeline)
return True
|
refactor: Remove extra INFO
See also: PSOBAT-<I>
|
foremast_foremast
|
train
|
py
|
6b670593ad359baeeaf4c7fcf2464c563f07063b
|
diff --git a/api/src/main/java/io/minio/messages/Item.java b/api/src/main/java/io/minio/messages/Item.java
index <HASH>..<HASH> 100644
--- a/api/src/main/java/io/minio/messages/Item.java
+++ b/api/src/main/java/io/minio/messages/Item.java
@@ -42,7 +42,7 @@ public class Item {
@Element(name = "StorageClass")
private String storageClass;
- @Element(name = "Owner")
+ @Element(name = "Owner", required = false)
private Owner owner;
@Element(name = "UserMetadata", required = false)
|
fix: make owner field optional in Item class. (#<I>)
Fixes #<I>
|
minio_minio-java
|
train
|
java
|
35edbfc9a3c1030ee688e3f5cfa6da21b701f940
|
diff --git a/spec/acceptance/organizer/reduce_if_spec.rb b/spec/acceptance/organizer/reduce_if_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/acceptance/organizer/reduce_if_spec.rb
+++ b/spec/acceptance/organizer/reduce_if_spec.rb
@@ -49,7 +49,7 @@ RSpec.describe LightService::Organizer do
expect(result).to be_success
end
- it "knows that it's being reduced from within an organizer" do
+ it "knows that it's being conditionally reduced from within an organizer" do
result = TestDoubles::TestIterate.call(:number => 1,
:counters => [1, 2, 3, 4])
diff --git a/spec/acceptance/organizer/reduce_until_spec.rb b/spec/acceptance/organizer/reduce_until_spec.rb
index <HASH>..<HASH> 100644
--- a/spec/acceptance/organizer/reduce_until_spec.rb
+++ b/spec/acceptance/organizer/reduce_until_spec.rb
@@ -41,7 +41,7 @@ RSpec.describe LightService::Organizer do
expect(result).to be_success
end
- it "knows that it's being reduced from within an organizer" do
+ it "is expected to know its organizer when reducing until a condition" do
result = TestReduceUntil.call(:number => 1)
expect(result.organized_by).to eq TestReduceUntil
|
test: amend expectation titles to be clearer
|
adomokos_light-service
|
train
|
rb,rb
|
e59d143bfe1012f81fc305d0b060577bf152374c
|
diff --git a/bin/rimuc.js b/bin/rimuc.js
index <HASH>..<HASH> 100755
--- a/bin/rimuc.js
+++ b/bin/rimuc.js
@@ -141,7 +141,7 @@ outer:
}
break;
case '--htmlReplacement':
- htmlReplacement = process.argv.shift()
+ htmlReplacement = process.argv.shift();
break;
case '--styled':
case '-s':
@@ -195,9 +195,9 @@ while (!!(arg = process.argv.shift())) {
var options = {
safeMode: arg === rimurc ? 0 : safeMode,
macroMode: macroMode
- }
+ };
if (htmlReplacement !== null) {
- options.htmlReplacement = htmlReplacement
+ options.htmlReplacement = htmlReplacement;
}
html += Rimu.render(source, options) + '\n';
}
|
style: Make rimuc.js pass jshint checks.
|
srackham_rimu
|
train
|
js
|
170f8658edc8b16492228ad7719212fd670905ac
|
diff --git a/controller/Middleware/MiddlewareConfig.php b/controller/Middleware/MiddlewareConfig.php
index <HASH>..<HASH> 100644
--- a/controller/Middleware/MiddlewareConfig.php
+++ b/controller/Middleware/MiddlewareConfig.php
@@ -16,6 +16,8 @@
* Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
*
* Copyright (c) 2022 (original work) Open Assessment Technologies SA;
+ *
+ * @author Gabriel Felipe Soares <gabriel.felipe.soares@taotesting.com>
*/
declare(strict_types=1);
|
chore: add author to track namespace change later
|
oat-sa_tao-core
|
train
|
php
|
a3ccbd32336f2876c2ecb4b8802de5c1fd5acec8
|
diff --git a/modules/router5.js b/modules/router5.js
index <HASH>..<HASH> 100644
--- a/modules/router5.js
+++ b/modules/router5.js
@@ -127,7 +127,7 @@ class Router5 {
this.navigate(opts.defaultRoute, opts.defaultParams, {reload: true, replace: true})
}
} else {
- this.updateBrowserState(toState, this.buildUrl(toState.name, toState.params), newState)
+ this.updateBrowserState(toState, this.buildUrl(toState.name, toState.params), !newState)
}
})
}
|
fix: fix state replacement on popstate
Fixes #<I>
|
router5_router5
|
train
|
js
|
a6ec7b321474b6de2f23a2cd63916ef7e10589be
|
diff --git a/packages/puppeteer-extra-plugin-stealth/evasions/user-agent-override/index.js b/packages/puppeteer-extra-plugin-stealth/evasions/user-agent-override/index.js
index <HASH>..<HASH> 100644
--- a/packages/puppeteer-extra-plugin-stealth/evasions/user-agent-override/index.js
+++ b/packages/puppeteer-extra-plugin-stealth/evasions/user-agent-override/index.js
@@ -50,7 +50,7 @@ class Plugin extends PuppeteerExtraPlugin {
get defaults() {
return {
userAgent: null,
- acceptLanguage: 'en-US,en',
+ locale: 'en-US,en',
platform: 'Win32'
}
}
|
fix(plugin-stealth): Minor mistake in option names in the UA evasion (#<I>)
|
berstend_puppeteer-extra
|
train
|
js
|
3a66a8d82810b0c128c49d7f1ff37a7df1c00e9b
|
diff --git a/packages/core/src/index.js b/packages/core/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/core/src/index.js
+++ b/packages/core/src/index.js
@@ -1,9 +1,10 @@
/** @license MIT License (c) copyright 2016 original author or authors */
import { curry2, curry3 } from '@most/prelude'
-export { now } from './source/now'
export { empty } from './source/empty'
export { never } from './source/never'
+export { now } from './source/now'
+export { at } from './source/at'
export { periodic } from './source/periodic'
|
fix(at): export at (#<I>)
|
mostjs_core
|
train
|
js
|
369d2fa40a641fdb0bc81fcb957dd8cf4872c6a1
|
diff --git a/data/country-currency.js b/data/country-currency.js
index <HASH>..<HASH> 100644
--- a/data/country-currency.js
+++ b/data/country-currency.js
@@ -204,6 +204,7 @@ module.exports = {
'SH': 'SHP',
'SI': 'EUR',
'SJ': 'NOK',
+ 'SK': 'EUR',
'SL': 'SLL',
'SM': 'EUR',
'SN': 'XOF',
|
feat: Add country and currency code for Slovakia
|
zalando-stups_banknote
|
train
|
js
|
7e4fe77c063b949d12134520e0856f95859c0a07
|
diff --git a/tests/src/Functional/InstallationTest.php b/tests/src/Functional/InstallationTest.php
index <HASH>..<HASH> 100644
--- a/tests/src/Functional/InstallationTest.php
+++ b/tests/src/Functional/InstallationTest.php
@@ -3,8 +3,6 @@
namespace Drupal\Tests\contenta_jsonapi\Functional;
use Drupal\Component\Serialization\Json;
-use Drupal\Core\Url;
-use Drupal\Tests\BrowserTestBase;
use PHPUnit\Framework\TestCase;
use GuzzleHttp\Client;
@@ -13,7 +11,7 @@ use GuzzleHttp\Client;
*
* @group ContentaInstaller
*/
-class InstallationTest extends BrowserTestBase {
+class InstallationTest extends TestCase {
/**
* @var Client
|
fix: use the old test case base class
|
contentacms_contenta_jsonapi
|
train
|
php
|
5c11880e56752456bb6e3b2bb571ef04187edeb8
|
diff --git a/lib/gulp/gulp-config.js b/lib/gulp/gulp-config.js
index <HASH>..<HASH> 100644
--- a/lib/gulp/gulp-config.js
+++ b/lib/gulp/gulp-config.js
@@ -122,7 +122,6 @@ module.exports = {
watch: src + '/**/*.styl',
src: [
src + '/css/*.styl',
- src + '/pages/*/css/*.styl',
src + '/pages/*/style.*.styl'
],
dest: dist
@@ -136,7 +135,6 @@ module.exports = {
src: [
src + '/js/*.js',
src + '/pages/*/script.*.js',
- src + '/pages/*/js/*.js',
src + '/layouts/*/layout.*.js'
],
dest: dist
|
chore: Updated Page Build to latest specs
|
quasarframework_quasar-cli
|
train
|
js
|
97d27d12e2dc7c946ed49c869fbb91d65679e77c
|
diff --git a/benchbuild/project.py b/benchbuild/project.py
index <HASH>..<HASH> 100644
--- a/benchbuild/project.py
+++ b/benchbuild/project.py
@@ -308,10 +308,6 @@ class Project(metaclass=ProjectDecorator):
def compile(self):
"""Compile the project."""
- @abstractmethod
- def versions(self):
- """Return a list of versions, in descending order."""
-
def download(self, version=None):
"""Auto-generated by with_* decorators."""
del version
|
fix: remove abstract method declaration, this broke gentoo projects.
|
PolyJIT_benchbuild
|
train
|
py
|
eb540153348e68f1824c94460be93960b463c592
|
diff --git a/tests/test_user.py b/tests/test_user.py
index <HASH>..<HASH> 100644
--- a/tests/test_user.py
+++ b/tests/test_user.py
@@ -276,11 +276,17 @@ def test_request_mobile_phone_verify(): # type: () -> None
@with_setup(get_setup_func())
def test_request_change_phone_number(): # type: () -> None
+ user1 = User()
+ user1.set("username", "user1_name")
+ user1.set("password", "password")
+ user1.login()
try:
User.request_change_phone_number("18611111112")
except LeanCloudError as e:
- if e.code not in (213, 601):
+ if e.code not in (119, 213, 601):
raise e
+ finally:
+ user1.logout()
@with_setup(get_setup_func())
|
fix(test): request_change_phone_number
This test requires X-LC-Session header.
|
leancloud_python-sdk
|
train
|
py
|
5a3a23f3e35b24871453a055c07351682c728841
|
diff --git a/lib/NormalModule.js b/lib/NormalModule.js
index <HASH>..<HASH> 100644
--- a/lib/NormalModule.js
+++ b/lib/NormalModule.js
@@ -270,10 +270,9 @@ NormalModule.prototype.source = function(dependencyTemplates, outputOptions, req
var emitFunction = function emitFunction() {
if(varNames.length === 0) return;
-
varStartCode += "/* WEBPACK VAR INJECTION */(function(" + varNames.join(", ") + ") {";
// exports === this in the topLevelBlock, but exports do compress better...
- varEndCode = (topLevelBlock === block ? "}.call(exports, " : "}.call(this, ") +
+ varEndCode = (topLevelBlock === block ? "}.call(module.exportsArgument || 'exports', " : "}.call(this, ") +
varExpressions.map(function(e) {
return e.source();
}).join(", ") + "))" + varEndCode;
|
fix(nmf): Fix exports for var injection to include free glob exports or arguments
|
webpack_webpack
|
train
|
js
|
2a18fce168afa3b434f70fbb0470a3e8f7cdca78
|
diff --git a/lib/endpoint/find-previews.js b/lib/endpoint/find-previews.js
index <HASH>..<HASH> 100644
--- a/lib/endpoint/find-previews.js
+++ b/lib/endpoint/find-previews.js
@@ -15,20 +15,21 @@ function findPreviews(state) {
note: normalizeMarkdown(state, block.text)
.replace(/^\*\*Note:?\*\*\s+/, "")
+ // convert single-backtick code snippets to fully fenced triple-backtick blocks
+ // example: This is the description.\n\n`application/vnd.github.machine-man-preview+json`
+ .replace(/\n`application/, "\n```\napplication")
+ .replace(/json`$/, "json\n```")
+
// remove extra leading and trailing newlines
.replace(/```\n\n\n/gm, "```\n")
.replace(/```\n\n/gm, "```\n")
.replace(/\n\n\n```/gm, "\n```")
.replace(/\n\n```/gm, "\n```")
+ .replace(/```\n\s+/gm, "```\n")
// use shell so it's not wrongly auto-detected as AppleScript
.replace(/```\n/, "```shell\n")
- // convert single-backtick code snippets to fully fenced triple-backtick blocks
- // example: This is the description.\n\n`application/vnd.github.machine-man-preview+json`
- .replace(/\n`application/, "\n```\napplication")
- .replace(/json`$/, "json\n```")
-
.trim(),
};
});
|
fix: normlize preview notes code blocks
|
octokit_routes
|
train
|
js
|
442ad339dd008bf23e99b9a95b66ca86e322fd39
|
diff --git a/src/plugin/release/index.js b/src/plugin/release/index.js
index <HASH>..<HASH> 100644
--- a/src/plugin/release/index.js
+++ b/src/plugin/release/index.js
@@ -95,10 +95,10 @@ function action (config, directory, options) {
if (!method || check || pkg.private) {
return generateChangelog(changelogOptions).then(() => {
- if (!check) {
+ if (!check && method || pkg.private) {
execute(
'git add CHANGELOG.md',
- 'git commit -m "docs(CHANGELOG): append to changelog"',
+ 'git commit -m "docs(CHANGELOG): append to changelog [ci skip]"',
`git tag -f ${newVersion}`,
`git push origin ${releaseBranch}`,
'git push origin --tags'
@@ -184,7 +184,7 @@ function handleVersionOutput (method, releaseBranch, newVersion, options) {
return generateChangelog(options).then((file) => {
return execute(
'git add .',
- `git commit -m "chore(release): ${newVersion}"`,
+ `git commit -m "chore(release): ${newVersion} [ci skip]"`,
`git push origin ${releaseBranch}`,
'git push origin --tags'
)
|
chore(northrbook): skip ci on release commits
|
northbrookjs_northbrook
|
train
|
js
|
24f0fac4c09c56d49084491bcc7ecaf387c23b98
|
diff --git a/server/server.go b/server/server.go
index <HASH>..<HASH> 100644
--- a/server/server.go
+++ b/server/server.go
@@ -130,14 +130,10 @@ func newEngineFromConfig(mach machine.Machine, cfg config.Config) (*engine.Engin
func (s *Server) Run() {
idx := s.agent.Initialize()
- asyncDispatch := func(ev *event.Event) {
- go s.eBus.Dispatch(ev)
- }
-
s.stop = make(chan bool)
go s.mach.PeriodicRefresh(machineStateRefreshInterval, s.stop)
- go s.rStream.Stream(idx, asyncDispatch, s.stop)
- go s.sStream.Stream(asyncDispatch, s.stop)
+ go s.rStream.Stream(idx, s.eBus.Dispatch, s.stop)
+ go s.sStream.Stream(s.eBus.Dispatch, s.stop)
go s.agent.Heartbeat(s.stop)
s.engine.CheckForWork()
|
refactor(event): Serialize event dispatch
|
coreos_fleet
|
train
|
go
|
8f086d3263026880f9141689bd0148220afab294
|
diff --git a/src/fs.js b/src/fs.js
index <HASH>..<HASH> 100644
--- a/src/fs.js
+++ b/src/fs.js
@@ -1,4 +1,5 @@
+const path = require('path')
const fs = require('fs')
// File contents split by line.
@@ -37,6 +38,7 @@ function watch(onChange) {
}
watched.forEach(dir => {
fs.watch(dir, (event, file) => {
+ file = path.join(dir, file)
if (event == 'rename') {
event = fs.existsSync(file) ? 'add' : 'delete'
}
|
fix: ensure watch events provide absolute file paths
|
aleclarson_testpass
|
train
|
js
|
7738b773bad3c146ded8f7932084a005adaa19d3
|
diff --git a/src/Repository.php b/src/Repository.php
index <HASH>..<HASH> 100644
--- a/src/Repository.php
+++ b/src/Repository.php
@@ -15,11 +15,11 @@ abstract class Repository
protected $defaultSort = null;
- abstract protected function setModel();
+ abstract protected function getModel();
final public function __construct()
{
- $this->setModel();
+ $this->model = $this->getModel();
}
/**
|
refactor: let model definition function return the model to be set instead of leaving it to the consumer
|
esbenp_genie
|
train
|
php
|
906c71481bdf9741069f8193bab35b331b0599c5
|
diff --git a/plugins/outputs/groundwork/groundwork.go b/plugins/outputs/groundwork/groundwork.go
index <HASH>..<HASH> 100644
--- a/plugins/outputs/groundwork/groundwork.go
+++ b/plugins/outputs/groundwork/groundwork.go
@@ -280,6 +280,7 @@ func (g *Groundwork) parseMetric(metric telegraf.Metric) (metricMeta, *transit.M
MonitoredInfo: transit.MonitoredInfo{
Status: transit.MonitorStatus(status),
LastCheckTime: lastCheckTime,
+ NextCheckTime: lastCheckTime, // if not added, GW will make this as LastCheckTime + 5 mins
LastPluginOutput: message,
},
Metrics: nil,
|
fix: Set NextCheckTime to LastCheckTime to avoid GroundWork to invent a value (#<I>)
|
influxdata_telegraf
|
train
|
go
|
7d37327c79da97cc12d3305199e0a3369d9a5e0e
|
diff --git a/samples/new-columns.js b/samples/new-columns.js
index <HASH>..<HASH> 100644
--- a/samples/new-columns.js
+++ b/samples/new-columns.js
@@ -6,12 +6,14 @@ csv()
columns: true
})
.to.stream(process.stdout, {
- newColumns: true,
- end: false
+ newColumns: true
})
.transform(function(data){
data.name = data.firstname + ' ' + data.lastname
return data;
+})
+.on('end', function(){
+ process.stdout.write('\n');
});
/*
diff --git a/samples/sample-stdin.js b/samples/sample-stdin.js
index <HASH>..<HASH> 100644
--- a/samples/sample-stdin.js
+++ b/samples/sample-stdin.js
@@ -13,7 +13,7 @@ csv()
.on('record',function(record, index){
console.log('#'+index+' '+JSON.stringify(record));
})
-.on('end',function(count){
+.on('close',function(count){
console.log('Number of lines: '+count);
})
.on('error',function(error){
|
chore(csv): Fix stdout samples
|
adaltas_node-csv
|
train
|
js,js
|
05bab17ef013a70599850272b4f598d6fbc8fd1d
|
diff --git a/packages/focusmanager/src/react/__specs__/index.spec.js b/packages/focusmanager/src/react/__specs__/index.spec.js
index <HASH>..<HASH> 100644
--- a/packages/focusmanager/src/react/__specs__/index.spec.js
+++ b/packages/focusmanager/src/react/__specs__/index.spec.js
@@ -17,6 +17,9 @@ const children = (
<li>
<a href="#">forth</a>
</li>
+ <li>
+ <a href="#">fifth</a>
+ </li>
</ul>
)
|
test(focusmanager): update test stub
i needed something to force a version change :/
|
pluralsight_design-system
|
train
|
js
|
cdd5e9eb4adab55200061f07da82c305e30264da
|
diff --git a/test/runtime/Policies.go b/test/runtime/Policies.go
index <HASH>..<HASH> 100644
--- a/test/runtime/Policies.go
+++ b/test/runtime/Policies.go
@@ -47,7 +47,7 @@ const (
policiesL3JSON = "Policies-l3-policy.json"
)
-var _ = Describe("RuntimePolicyEnforcement", func() {
+var _ = Describe("RuntimeValidatedPolicyEnforcement", func() {
var once sync.Once
var logger *logrus.Entry
|
test: validate runtime policy tests
Better now than never.
|
cilium_cilium
|
train
|
go
|
3cf8f204db649a3e0eaf6b614927ca20d765eea7
|
diff --git a/src/observer.js b/src/observer.js
index <HASH>..<HASH> 100644
--- a/src/observer.js
+++ b/src/observer.js
@@ -104,8 +104,7 @@ function set (target, key, value, receiver) {
if (typeof key === 'symbol' || target !== proxyToRaw.get(receiver)) {
return Reflect.set(target, key, value, receiver)
}
- const oldValue = Reflect.get(target, key, receiver)
- if (key === 'length' || value !== oldValue) {
+ if (key === 'length' || value !== target[key]) {
queueObservers(target, key)
queueObservers(target, ENUMERATE)
}
@@ -113,7 +112,7 @@ function set (target, key, value, receiver) {
}
function deleteProperty (target, key) {
- if (typeof key !== 'symbol' && Reflect.has(target, key)) {
+ if (typeof key !== 'symbol' && (key in target)) {
queueObservers(target, key)
queueObservers(target, ENUMERATE)
}
|
perf(osberver): use normal operations instead of reflect where it doesn't matter
|
nx-js_observer-util
|
train
|
js
|
f10d8b0290998b9a33b074eb872fb2557895b6e9
|
diff --git a/inputs/select-input/select-input.story.js b/inputs/select-input/select-input.story.js
index <HASH>..<HASH> 100644
--- a/inputs/select-input/select-input.story.js
+++ b/inputs/select-input/select-input.story.js
@@ -97,7 +97,7 @@ storiesOf('Inputs', module)
onBlur={action('onBlur')}
isMulti={isMulti}
placeholder={text('placeholder', 'Select..')}
- maxMenuHeight={number('maxMenuHeight', 100)}
+ maxMenuHeight={number('maxMenuHeight', 200)}
isSearchable={boolean('isSearchable', false)}
isDisabled={boolean('isDisabled', false)}
isClearable={boolean('isClearable', false)}
|
refactor(react-select-story):
set maxMenuHeight <I> in the story
|
commercetools_ui-kit
|
train
|
js
|
6eb9f7638ac8e751e2dadb77b43a0252d210d60d
|
diff --git a/publish/scripts/installer.js b/publish/scripts/installer.js
index <HASH>..<HASH> 100755
--- a/publish/scripts/installer.js
+++ b/publish/scripts/installer.js
@@ -455,7 +455,7 @@ const pattern3 = /\\n\\s*\\/\\/Crashlytics 3 BEGIN[\\s\\S]*\\/\\/Crashlytics 3 E
const string1 = \`
//Crashlytics 1 BEGIN
#else
-#import <FirebaseCrashlytics/FirebaseCrashlytics.h>
+#import <FirebaseCrashlytics/FirebaseCrashlytics.h>;
#endif
//Crashlytics 1 END
\`;
|
fix(ios): FirebaseCrashlytics release mode and delegate handling improvements #<I> - resolve merge conflict (will revert)
|
EddyVerbruggen_nativescript-plugin-firebase
|
train
|
js
|
ab45001945950ed7d8b58034a18d8cb67286c948
|
diff --git a/test/docs/util.py b/test/docs/util.py
index <HASH>..<HASH> 100644
--- a/test/docs/util.py
+++ b/test/docs/util.py
@@ -115,8 +115,11 @@ class TestApp(Sphinx):
)
def cleanup(self, doctrees=False):
- from sphinx.ext.autodoc import AutoDirective
- AutoDirective._registry.clear()
+ try:
+ from sphinx.ext.autodoc import AutoDirective
+ AutoDirective._registry.clear()
+ except ImportError: # sphinx >= 2.0
+ pass
sys.path[:] = self._saved_path
sys.modules.pop('autodoc_fodder', None)
|
fix(doc): Correct bug for sphinx AutoDirective.
|
vinci1it2000_schedula
|
train
|
py
|
bf68dc389078440bca35f2fde6cd1eed4b6a9963
|
diff --git a/tests/double_disp.py b/tests/double_disp.py
index <HASH>..<HASH> 100644
--- a/tests/double_disp.py
+++ b/tests/double_disp.py
@@ -7,10 +7,13 @@ from pyvirtualdisplay import Display
def check_double_disp(backend):
python = sys.executable
+ if not backend:
+ backend = ""
# the main process may crash,
# so it must be tested in subprocess
- cmd = [python, __file__, backend, "--debug"]
+ fname = __file__.rsplit(".", 1)[0] + ".py"
+ cmd = [python, fname, backend, "--debug"]
p = EasyProcess(cmd).call()
assert p.return_code == 0
@@ -20,6 +23,9 @@ def main(backend):
import os
import sys
+ if not backend:
+ backend = None
+
sys.path.append(os.getcwd())
from pyscreenshot import grab
|
test: fix check_double_disp
|
ponty_pyscreenshot
|
train
|
py
|
767da1368b1808b2850a7befd4530a2c6674d643
|
diff --git a/src/geshi/bash.php b/src/geshi/bash.php
index <HASH>..<HASH> 100644
--- a/src/geshi/bash.php
+++ b/src/geshi/bash.php
@@ -233,11 +233,11 @@ $language_data = array (
//Variables without braces
1 => "\\$[a-zA-Z_][a-zA-Z0-9_]*",
//Variable assignment
- 2 => "(?<![\.a-zA-Z_])([a-zA-Z_][a-zA-Z0-9_]*?)(?==)",
+ 2 => "(?<![\.a-zA-Z_\-])([a-zA-Z_][a-zA-Z0-9_]*?)(?==)",
//Shorthand shell variables
4 => "\\$[*#\$\\-\\?!]",
//Parameters of commands
- 5 => "(?<=\s)-[0-9a-zA-Z\-]+(?=[\s=]|$)"
+ 5 => "(?<=\s)--?[0-9a-zA-Z\-]+(?=[\s=]|$)"
),
'STRICT_MODE_APPLIES' => GESHI_NEVER,
'SCRIPT_DELIMITERS' => array(
|
fix: the argument was not properly highlighed in things like 'dbus-send --dest=org...'
|
GeSHi_geshi-1.0
|
train
|
php
|
157d1550f659430832c3d582ae8dba221f96fd94
|
diff --git a/fleetctl/cmd.go b/fleetctl/cmd.go
index <HASH>..<HASH> 100644
--- a/fleetctl/cmd.go
+++ b/fleetctl/cmd.go
@@ -4,6 +4,7 @@ import (
"crypto/tls"
"fmt"
"io/ioutil"
+ "log"
"net"
"net/http"
"os"
@@ -48,7 +49,7 @@ func getRegistry(context *cli.Context) *registry.Registry {
if tun != "" {
sshClient, err := ssh.NewSSHClient("core", tun)
if err != nil {
- panic(err)
+ log.Fatalf("Failed initializing SSH client: %v", err)
}
dial := func(network, addr string) (net.Conn, error) {
|
fix(tunnel): do not panic when unable to auth
|
coreos_fleet
|
train
|
go
|
40968f22ab3b159f2294fd6d6bcd6ca2f9668694
|
diff --git a/hdl_toolkit/simulator/hdlSimulator.py b/hdl_toolkit/simulator/hdlSimulator.py
index <HASH>..<HASH> 100644
--- a/hdl_toolkit/simulator/hdlSimulator.py
+++ b/hdl_toolkit/simulator/hdlSimulator.py
@@ -140,10 +140,13 @@ class HdlSimulator(object):
Run simulation
"""
self.config.beforeSim(self, synthesisedUnit)
+
for p in extraProcesses:
self.env.process(p(self))
+
for p in self._initUnitSignals(synthesisedUnit):
- self.addHwProcToRun(p)
+ pass
+ #self.addHwProcToRun(p)
self.env.run(until=time)
|
fix: onverwritting of static initializations at startup
|
Nic30_hwt
|
train
|
py
|
15353297455aa8e09862a8e1e1ac38b1638ac9ea
|
diff --git a/lib/workers.js b/lib/workers.js
index <HASH>..<HASH> 100644
--- a/lib/workers.js
+++ b/lib/workers.js
@@ -49,28 +49,26 @@ function Workers(baseUrl, opts) {
// inheritance
Emitter.call(this);
- opts = parseOptions(opts);
-
- // local variables
- this.engineApi = new EngineApi(
- baseUrl,
- opts.requestOptions,
- opts.apiVersion
- );
+ this.options = parseOptions(opts);
this.workers = {};
- this.options = opts;
-
this.state = STATE_NEW;
// apply extensions
- if (opts.use) {
- this.extend(opts.use);
+ if (this.options.use) {
+ this.extend(this.options.use);
}
+ // local variables
+ this.engineApi = new EngineApi(
+ baseUrl,
+ this.options.requestOptions,
+ this.options.apiVersion
+ );
+
// start
- if (opts.pollingDelay !== -1) {
+ if (this.options.pollingDelay !== -1) {
this.start();
}
}
@@ -287,6 +285,7 @@ Workers.prototype.fetchTasks = async function(topics) {
return tasks;
};
+
Workers.prototype.executeTasks = async function(tasks) {
var t = now();
|
chore(workers): trigger middlewares ASAP
* ensure middlewares are called with correct worker options;
* call middlewares before engineApi construction
|
nikku_camunda-worker-node
|
train
|
js
|
a3f26672cef09b08b16612dfbdab79387baa37ed
|
diff --git a/lib/read-json-file.js b/lib/read-json-file.js
index <HASH>..<HASH> 100644
--- a/lib/read-json-file.js
+++ b/lib/read-json-file.js
@@ -4,15 +4,18 @@ var errors = require('common-errors');
var path = require('path');
var fs = require('fs');
-module.exports = function (opts) {
+module.exports = function (value) {
return new Promise(function(resolve, reject) {
- if (!opts) {
- reject(new errors.ArgumentNullError('opts'));
+ if (!value) {
+ reject(new errors.ArgumentNullError('value'));
}
- if (!opts.hasOwnProperty('path') || !opts['path']){
- reject(new errors.ArgumentNullError('path'));
- }
- var filePath = path.normalize(opts['path']);
+ ['path'].forEach(function (key) {
+ if(!value.hasOwnProperty(key) || !value[key]) {
+ reject(new errors.ArgumentNullError(key))
+ }
+ });
+
+ var filePath = path.normalize(value['path']);
fs.readFile(filePath, 'utf8', function (error, data) {
if (error) {
reject(new errors.io.FileLoadError(filePath));
|
refactor(readjson): use value as dummy argument
|
pandawing_node-run-yo
|
train
|
js
|
9e22a66d4b02e005766f71827f3468e694163167
|
diff --git a/examples/kitchen-sink-cra/craco.config.js b/examples/kitchen-sink-cra/craco.config.js
index <HASH>..<HASH> 100644
--- a/examples/kitchen-sink-cra/craco.config.js
+++ b/examples/kitchen-sink-cra/craco.config.js
@@ -1,21 +1,21 @@
module.exports = {
webpack: {
configure: (webpackConfig, { env, paths }) => {
- const mjsRules = webpackConfig.module.rules[1].oneOf.filter((rule) => {
+ const jsRules = webpackConfig.module.rules[1].oneOf.filter(rule => {
if (Array.isArray(rule.test)) {
- return !!rule.test.find((test) => test.test('.mjs'))
+ return !!rule.test.find(test => test.test('.js'))
} else {
- return rule.test?.test('.mjs')
+ return rule.test?.test('.js')
}
})
- mjsRules.forEach((rule) => {
+ jsRules.forEach(rule => {
rule.resolve = {
- mainFields: ['module', 'main'],
+ mainFields: ['module', 'main']
}
})
return webpackConfig
- },
- },
+ }
+ }
}
|
refactor(examples): kitchen-sink craco to look for js
The rules totally overlap, but I think this is a more accurate naming
conceptually.
It is the modules being IMPORTED that need to have the module field
looked at instead of the main. This solves the problem of webpack not
seeing libs like dayzed and date-fns as dual-published esm/cjs packages.
|
pluralsight_design-system
|
train
|
js
|
9c5934e879ca16b5f5fea1c94589f439a9000356
|
diff --git a/webmentiontools/request.py b/webmentiontools/request.py
index <HASH>..<HASH> 100644
--- a/webmentiontools/request.py
+++ b/webmentiontools/request.py
@@ -74,7 +74,8 @@ def request_post_url(endpoint, source_url, target_url):
endpoint,
data=payload,
allow_redirects=True,
- # type/* should be fine according to https://tools.ietf.org/html/rfc7231#section-5.3.2
+ # type/* should be fine according to
+ # https://tools.ietf.org/html/rfc7231#section-5.3.2
# c.f. https://github.com/Ryuno-Ki/webmention-tools/issues/31
headers={
"Accept": "text/*, application/*",
|
chore(lint): Make flake8 happy.
|
Ryuno-Ki_webmention-tools
|
train
|
py
|
88702336a54c3021c6dfb3aa8954abd3b2bd84a9
|
diff --git a/packages/parrot-fetch/src/index.js b/packages/parrot-fetch/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/parrot-fetch/src/index.js
+++ b/packages/parrot-fetch/src/index.js
@@ -24,7 +24,7 @@ export default function init(scenarios, fetchWrapperParam) {
let parrotFetch;
// option to mock a fetchClient that is different from the global fetch by passing the fetchClient in through a fetchWrapper object.
if (fetchWrapper) {
- parrotFetch = new ParrotFetch(scenarios, fetchWrapper.fetchClient);
+ parrotFetch = new ParrotFetch(scenarios, contextFetch);
fetchWrapper.fetchClient = parrotFetch.resolve;
} else {
parrotFetch = new ParrotFetch(scenarios, contextFetch);
|
fix(parrot-fetch): make contextFetch the fallback in parrotFetch
|
americanexpress_parrot
|
train
|
js
|
e722354f4f34d58227fe134f2fa3e931f8aaaf3b
|
diff --git a/lib/get-last-release.js b/lib/get-last-release.js
index <HASH>..<HASH> 100644
--- a/lib/get-last-release.js
+++ b/lib/get-last-release.js
@@ -30,10 +30,10 @@ module.exports = ({branch, options: {tagFormat}}, {before} = {}) => {
const [{version, gitTag, channels} = {}] = branch.tags
.filter(
tag =>
- (branch.type === 'prerelease' && tag.channels.some(channel => isSameChannel(branch.channel, channel))) ||
- !semver.prerelease(tag.version)
+ ((branch.type === 'prerelease' && tag.channels.some(channel => isSameChannel(branch.channel, channel))) ||
+ !semver.prerelease(tag.version)) &&
+ (isUndefined(before) || semver.lt(tag.version, before))
)
- .filter(tag => isUndefined(before) || semver.lt(tag.version, before))
.sort((a, b) => semver.rcompare(a.version, b.version));
if (gitTag) {
|
style: merge both `filter` functions in `get-last-release`
|
semantic-release_semantic-release
|
train
|
js
|
8cf69126e2cb08252a229c965f0437fbc5f17f96
|
diff --git a/service.js b/service.js
index <HASH>..<HASH> 100755
--- a/service.js
+++ b/service.js
@@ -142,10 +142,10 @@ class ServiceConsul extends service.Service {
* @param {Number} delay time to wait before doing the unregister/register action
*/
update(delay) {
- function reregister() {
+ const reregister = () => {
return consul.agent.service.deregister(this.consulDefinition.id)
.then(() => consul.agent.service.register(this.consulDefinition));
- }
+ };
if (delay) {
if (this._updateTimer) {
diff --git a/tests/service_test.js b/tests/service_test.js
index <HASH>..<HASH> 100644
--- a/tests/service_test.js
+++ b/tests/service_test.js
@@ -29,7 +29,10 @@ describe('consul service', function () {
cs.registerService('maService', {
url: cs.listener.url + "/somepath"
- });
+ }).then(() => cs.unregisterService('myService').then(() => {
+ assert.ok("unregistered");
+ })).catch(console.log);
+
cs.consul.kv.set('hello', 'world').then(f => {
//console.log(`SET ${f}`);
|
fix: use arrow function to preserve this
|
Kronos-Integration_kronos-service-consul
|
train
|
js,js
|
b7a21b7cbb7a5ebc0f1457d1515d6202302af9f6
|
diff --git a/node-phantom-simple.js b/node-phantom-simple.js
index <HASH>..<HASH> 100644
--- a/node-phantom-simple.js
+++ b/node-phantom-simple.js
@@ -645,6 +645,12 @@ function setup_long_poll (phantom, port, pages, setup_new_page) {
req.on('error', function (err) {
if (dead || phantom.killed) { return; }
+ if (err.code === 'ECONNRESET') {
+ dead = true;
+ cb(new HeadlessError('Phantom Process died'));
+ return;
+ }
+
logger.warn('Poll Request error: ' + err);
});
};
|
fix: return error if Phantom died
|
baudehlo_node-phantom-simple
|
train
|
js
|
2dcc10578e1018b8e7a51e67f118b05b1b828371
|
diff --git a/tests/integration/angular-meteor-collection-spec.js b/tests/integration/angular-meteor-collection-spec.js
index <HASH>..<HASH> 100644
--- a/tests/integration/angular-meteor-collection-spec.js
+++ b/tests/integration/angular-meteor-collection-spec.js
@@ -32,7 +32,7 @@ describe('$meteorCollection service', function() {
spyOn($rootScope, '$apply').and.callThrough();
- MyCollection = new Mongo.Collection();
+ MyCollection = new Mongo.Collection(null);
MyCollection.insert(testObjects[0]);
MyCollection.insert(testObjects[1]);
MyCollection.insert(testObjects[2]);
|
fix(test): avoid annoying warning on unit tests
|
Urigo_angular-meteor
|
train
|
js
|
4479042b25f8d665bc9dcc67c6c25a84cecbcf64
|
diff --git a/lib/util.js b/lib/util.js
index <HASH>..<HASH> 100644
--- a/lib/util.js
+++ b/lib/util.js
@@ -126,6 +126,15 @@ function addVariables(script, scriptPath, options, callback) {
script.config.variables[varName] = variables[varName];
});
}
+
+ script.config = engineUtil.template(
+ script.config,
+ { vars:
+ {
+ $processEnvironment: process.env
+ }
+ });
+
return callback(null, script, scriptPath, options);
}
|
feat: Add support for templates to config section
|
artilleryio_artillery
|
train
|
js
|
29e1e395ee9726924379df40bec9f9e38246a3c8
|
diff --git a/packages/cli/context.js b/packages/cli/context.js
index <HASH>..<HASH> 100644
--- a/packages/cli/context.js
+++ b/packages/cli/context.js
@@ -30,7 +30,14 @@ class Context {
this.plugins.register(
...plugins.map(plugin => {
if (typeof plugin === "string") {
- return require(path.join(this.paths.projectRoot, plugin));
+ let loadedPlugin;
+ try {
+ loadedPlugin = require(path.join(this.paths.projectRoot, plugin)); // Try loading the package from the project's root
+ } catch {
+ // If it fails, perhaps the user still has the package installed somewhere locally...
+ loadedPlugin = require(plugin);
+ }
+ return loadedPlugin;
}
return plugin;
})
|
fix: allow loading installed packages too
for example, packages loaded like this will be usable now: require("@webiny/cli-scaffold-graphql-service")
|
Webiny_webiny-js
|
train
|
js
|
a429618e09b24b8db7b9d6a00d786d91012d643a
|
diff --git a/test/workers/pr/changelog/index.spec.js b/test/workers/pr/changelog/index.spec.js
index <HASH>..<HASH> 100644
--- a/test/workers/pr/changelog/index.spec.js
+++ b/test/workers/pr/changelog/index.spec.js
@@ -1,3 +1,5 @@
+const delay = require('delay');
+
jest.mock('../../../../lib/platform/github/gh-got-wrapper');
jest.mock('../../../../lib/datasource/npm');
jest.mock('got');
@@ -200,7 +202,7 @@ describe('workers/pr/changelog', () => {
repositoryUrl: 'https://github-enterprise.example.com/chalk/chalk',
})
).toMatchSnapshot();
-
+ await delay(200);
expect(
await getChangeLogJSON({
...upgrade,
|
chore: try delay for changelog cache test (#<I>)
|
renovatebot_renovate
|
train
|
js
|
e959915fe4cc94f62099a29a6b006a7913a134d6
|
diff --git a/cmd/helm/get.go b/cmd/helm/get.go
index <HASH>..<HASH> 100644
--- a/cmd/helm/get.go
+++ b/cmd/helm/get.go
@@ -4,8 +4,10 @@ import (
"errors"
"fmt"
"os"
+ "time"
"github.com/kubernetes/helm/pkg/helm"
+ "github.com/kubernetes/helm/pkg/timeconv"
"github.com/spf13/cobra"
)
@@ -82,10 +84,11 @@ func getCmd(cmd *cobra.Command, args []string) error {
return err
}
- fmt.Printf("Chart/Version: %s %s\n", res.Release.Chart.Metadata.Name, res.Release.Chart.Metadata.Version)
- fmt.Println("Config:")
- fmt.Println(res.Release.Config)
- fmt.Println("\nManifest:")
+ fmt.Printf("CHART: %s-%s\n", res.Release.Chart.Metadata.Name, res.Release.Chart.Metadata.Version)
+ fmt.Printf("RELEASED: %s\n", timeconv.Format(res.Release.Info.LastDeployed, time.ANSIC))
+ fmt.Println("CONFIG:")
+ fmt.Println(res.Release.Config.Raw)
+ fmt.Println("MANIFEST:")
fmt.Println(res.Release.Manifest)
return nil
}
|
fix(helm): improve 'helm get' output
This makes the output of 'helm get' more like the output of other
Helm commands.
|
helm_helm
|
train
|
go
|
9d0a778a1ae97bb5c522cbfc7b1b65250118f2ea
|
diff --git a/lib/instrumentor.js b/lib/instrumentor.js
index <HASH>..<HASH> 100644
--- a/lib/instrumentor.js
+++ b/lib/instrumentor.js
@@ -45,12 +45,11 @@ Instrumentor.prototype.instrument = function (ast) {
path = controller.path(),
currentPath = path ? path[path.length - 1] : null;
if (assertionVisitor) {
- if (assertionVisitor.isCapturingArgument()) {
- if (toBeSkipped(currentNode, parentNode, currentPath)) {
- skipping = true;
- return controller.skip();
- }
- } else {
+ if (toBeSkipped(currentNode, parentNode, currentPath)) {
+ skipping = true;
+ return controller.skip();
+ }
+ if (!assertionVisitor.isCapturingArgument()) {
return assertionVisitor.enterArgument(currentNode, parentNode, path);
}
} else {
|
fix(espower): decide to be skipped first, then enter node
This fixes the case when FunctionExpression begins right after the assertion (its params will be transformed accidentally)
|
power-assert-js_espower
|
train
|
js
|
51352c4ee2187c64fbbe10be1a6c4a1926d0b763
|
diff --git a/auto_changelog/presenter.py b/auto_changelog/presenter.py
index <HASH>..<HASH> 100644
--- a/auto_changelog/presenter.py
+++ b/auto_changelog/presenter.py
@@ -34,8 +34,14 @@ class MarkdownPresenter(PresenterInterface):
return text
def replace(match):
- matching_text = match.group(1)
- ticket_id = match.group(2) or match.group(1)
+ groups = match.groups()
+ if len(groups) == 2:
+ matching_text = groups[0]
+ ticket_id = groups[1]
+ elif len(groups) == 1:
+ matching_text = ticket_id = groups[0]
+ else:
+ raise ValueError("Invalid pattern")
ticket_url = url.format(id=ticket_id)
return "[{matching_text}]({ticket_url})".format(matching_text=matching_text, ticket_url=ticket_url)
|
fix: Handle issue pattern with one group #<I>
|
Michael-F-Bryan_auto-changelog
|
train
|
py
|
9f48c6bfb255657a00738c69f649ffe5b06f5eb2
|
diff --git a/cli.js b/cli.js
index <HASH>..<HASH> 100644
--- a/cli.js
+++ b/cli.js
@@ -1,3 +1,4 @@
+#!/usr/bin/env node
const fn = require('./')
if (process.argv.length < 3 || !process.argv.every(val => val.match(/(--help|-h)/) === null)) {
diff --git a/covenant.js b/covenant.js
index <HASH>..<HASH> 100755
--- a/covenant.js
+++ b/covenant.js
@@ -1,4 +1,3 @@
-#!/usr/bin/env node
const request = require('request-promise')
const fs = require('mz/fs')
|
fix: bash script on cli
|
simonv3_covenant-generator
|
train
|
js,js
|
853fdfa3d440babaf249a5742a9f0b894a045d0d
|
diff --git a/test/test-capture.js b/test/test-capture.js
index <HASH>..<HASH> 100644
--- a/test/test-capture.js
+++ b/test/test-capture.js
@@ -95,6 +95,8 @@ process.once('uncaughtException', function(err) {
// Determine "primary" IP address
http.get('http://google.com', function(res) {
localIP = res.socket.address().address;
+ console.log('localIP = %j', localIP);
+ console.log('device list = %s', require('util').inspect(Cap.deviceList()));
res.on('end', next);
res.resume();
});
|
test: add useful info to stdout
|
mscdex_cap
|
train
|
js
|
4e125984b0e75dc18309461ad91ce340988c492d
|
diff --git a/packages/v-tooltip/src/components/Popper.js b/packages/v-tooltip/src/components/Popper.js
index <HASH>..<HASH> 100644
--- a/packages/v-tooltip/src/components/Popper.js
+++ b/packages/v-tooltip/src/components/Popper.js
@@ -723,6 +723,7 @@ if (typeof document !== 'undefined' && typeof window !== 'undefined') {
window.addEventListener('mousedown', handleGlobalMousedown, true)
window.addEventListener('click', handleGlobalClick, true)
}
+ window.addEventListener('resize', handleGlobalResize)
}
function handleGlobalMousedown (event) {
@@ -755,8 +756,6 @@ function handleGlobalClose (event, touch = false) {
}
}
-window.addEventListener('resize', handleGlobalResize)
-
function handleGlobalResize (event) {
for (let i = 0; i < shownPoppers.length; i++) {
const popper = shownPoppers[i]
|
fix: window not defined in non-browser envs
|
Akryum_v-tooltip
|
train
|
js
|
1233a3c1e21e9208212a8534c29c90a85ab43c6f
|
diff --git a/hrp/boomer.go b/hrp/boomer.go
index <HASH>..<HASH> 100644
--- a/hrp/boomer.go
+++ b/hrp/boomer.go
@@ -393,7 +393,7 @@ func (b *HRPBoomer) convertBoomerTask(testcase *TestCase, rendezvousList []*Rend
// transaction
// FIXME: support nested transactions
if step.Struct().Transaction.Type == transactionEnd { // only record when transaction ends
- b.RecordTransaction(stepResult.Name, transactionSuccess, stepResult.Elapsed, 0)
+ b.RecordTransaction(step.Struct().Transaction.Name, transactionSuccess, stepResult.Elapsed, 0)
transactionSuccess = true // reset flag for next transaction
}
} else if stepResult.StepType == stepTypeRendezvous {
|
fix: the transaction name recorded is inaccurate, when transaction fails
|
HttpRunner_HttpRunner
|
train
|
go
|
a051d91493118ad6451c71ef03d37024e6b63e57
|
diff --git a/superset-frontend/.eslintrc.js b/superset-frontend/.eslintrc.js
index <HASH>..<HASH> 100644
--- a/superset-frontend/.eslintrc.js
+++ b/superset-frontend/.eslintrc.js
@@ -210,7 +210,7 @@ module.exports = {
},
],
rules: {
- 'theme-colors/no-literal-colors': 1,
+ 'theme-colors/no-literal-colors': 'error',
'translation-vars/no-template-vars': ['error', true],
camelcase: [
'error',
|
chore: Changes the no-literal-colors lint rule to throw errors instead of warnings (#<I>)
|
apache_incubator-superset
|
train
|
js
|
dfba06266cd6eddad48d2ede28e8bba6755223b1
|
diff --git a/src/components/select/select.js b/src/components/select/select.js
index <HASH>..<HASH> 100755
--- a/src/components/select/select.js
+++ b/src/components/select/select.js
@@ -1250,7 +1250,15 @@ function SelectProvider($$interimElementProvider) {
element
.removeClass('md-active')
.attr('aria-hidden', 'true')
- .css('display', 'none');
+ .css({
+ 'display': 'none',
+ 'top': '',
+ 'right': '',
+ 'bottom': '',
+ 'left': '',
+ 'font-size': '',
+ 'min-width': ''
+ });
element.parent().find('md-select-value').removeAttr('aria-hidden');
announceClosed(opts);
|
fix(select): perform full cleanup of the select drop-down after the close (#<I>)
it affects on the drop-down size if resize is happening after using the select
Fixes #<I>
|
angular_material
|
train
|
js
|
611a352bbec90595bf131b666abc2083b15d7e06
|
diff --git a/lib/topologies/server.js b/lib/topologies/server.js
index <HASH>..<HASH> 100644
--- a/lib/topologies/server.js
+++ b/lib/topologies/server.js
@@ -266,7 +266,12 @@ function configureWireProtocolHandler(self, ismaster) {
function disconnectHandler(self, type, ns, cmd, options, callback) {
// Topology is not connected, save the call in the provided store to be
// Executed at some point when the handler deems it's reconnected
- if (!self.s.pool.isConnected() && self.s.disconnectHandler != null && !options.monitoring) {
+ if (
+ !self.s.pool.isConnected() &&
+ self.s.options.reconnect &&
+ self.s.disconnectHandler != null &&
+ options.monitoring
+ ) {
self.s.disconnectHandler.add(type, ns, cmd, options, callback);
return true;
}
|
fix(server): avoid waiting for reconnect if reconnect disabled
|
mongodb-js_mongodb-core
|
train
|
js
|
a68d054e275c379b288b283d52b21f3f3bcdf5be
|
diff --git a/src/tracing/instrumentation/bluebird.js b/src/tracing/instrumentation/bluebird.js
index <HASH>..<HASH> 100644
--- a/src/tracing/instrumentation/bluebird.js
+++ b/src/tracing/instrumentation/bluebird.js
@@ -13,8 +13,20 @@ exports.deactivate = function() {
exports.init = function() {
try {
- require('cls-bluebird')(cls.ns);
- } catch (e) {
- logger.warn('Failed to instrument bluebird', e);
+ if (require.resolve('bluebird')) {
+ try {
+ require('cls-bluebird')(cls.ns);
+ } catch (e) {
+ logger.warn('Failed to instrument bluebird', e);
+ }
+ } else {
+ // This should actually not happen as require.resolve should either return a resolved filename or throw an
+ // exception.
+ logger.debug('Won\'t instrument bluebird as it is not installed (require.resolve returned falsy value).');
+ }
+ } catch (notResolved) {
+ // This happens if bluebird is not available, in which case we do not need
+ // to instrument anything, so we can safely ignore the error.
+ logger.debug('Won\'t instrument bluebird as it is not installed.');
}
};
|
fix(tracing): only instrument bluebird if the module is available
|
instana_nodejs-sensor
|
train
|
js
|
81e1a8540817fb6bcc9815daf9708bb4578cfe3d
|
diff --git a/mapillary_tools/geo.py b/mapillary_tools/geo.py
index <HASH>..<HASH> 100644
--- a/mapillary_tools/geo.py
+++ b/mapillary_tools/geo.py
@@ -235,6 +235,8 @@ def write_gpx(filename, gps_trace):
for point in gps_trace:
lat = point[1]
lon = point[2]
+ if lat == 0 or lon == 0:
+ continue
time = datetime.datetime.strftime(point[0], time_format)[:-3]
elevation = point[3] if len(point) > 3 else 0
gpx += "<trkpt lat=\"" + \
|
fix: dont write gpx if point lat or lon is 0
|
mapillary_mapillary_tools
|
train
|
py
|
3c816be77f08b9ad06a55bef9321853fee1424f0
|
diff --git a/scripts/generate-colors-for-story.js b/scripts/generate-colors-for-story.js
index <HASH>..<HASH> 100644
--- a/scripts/generate-colors-for-story.js
+++ b/scripts/generate-colors-for-story.js
@@ -5,7 +5,7 @@ const isVariation = require('./utility.js').isVariation;
const importPath = '../materials/colors/base-colors.mod.css';
const exportPath = '../materials/colors/colors-for-story.mod.css';
-const loadedFile = fs.readFileSync(path.join(__dirname, importPath));
+const loadedFile = fs.readFileSync(path.join(__dirname, importPath), 'utf8');
const fileToBeTransformed = css.parse(loadedFile);
// Path where decision file is located, for documentation purposes only
|
fix(colors): readds utf8, removes console and add template strings
|
commercetools_ui-kit
|
train
|
js
|
100d23e52609d5da66d761e71e6b9a028320df14
|
diff --git a/www/src/pages/components/navbar.js b/www/src/pages/components/navbar.js
index <HASH>..<HASH> 100644
--- a/www/src/pages/components/navbar.js
+++ b/www/src/pages/components/navbar.js
@@ -31,11 +31,11 @@ export default withLayout(function NaπvbarSection({ data }) {
Overview
</LinkedHeading>
<p>
- Here’s what you need to know before getting started with the navbar:
+ Here’s what you need to know before getting started with the Navbar:
</p>
<ul>
<li>
- use the <code>expand</code> prop to allow for nvabar collapsing at
+ Use the <code>expand</code> prop to allow for collapsing the Navbar at
lower breakpoints.
</li>
<li>
|
docs: Fix spelling and grammar in Navbar docs (#<I>)
|
react-bootstrap_react-bootstrap
|
train
|
js
|
ea60bc6c6da02229bf45f779926743d01e4b94d5
|
diff --git a/packages/d3fc-element/src/element.js b/packages/d3fc-element/src/element.js
index <HASH>..<HASH> 100644
--- a/packages/d3fc-element/src/element.js
+++ b/packages/d3fc-element/src/element.js
@@ -5,12 +5,11 @@ import requestRedraw from './requestRedraw';
const init = (instance, node) => {
instance.__node__ = node;
// Fill parent but allow parent to shrink
- instance.style.position = 'relative';
+ if (instance.__node__.offsetParent !== instance) {
+ instance.style.position = 'relative';
+ }
instance.__node__.style.position = 'absolute';
- instance.__node__.style.top = '0';
- instance.__node__.style.right = '0';
- instance.__node__.style.bottom = '0';
- instance.__node__.style.left = '0';
+ instance.__node__.style.top = instance.__node__.style.right = instance.__node__.style.bottom = instance.__node__.style.left = 0;
};
export default (createNode) => class extends HTMLElement {
|
fix: don't force position: relative
|
d3fc_d3fc
|
train
|
js
|
5c866ce7f1e2c41d6bd303debe4ef631c07c0957
|
diff --git a/website/src/data/config.js b/website/src/data/config.js
index <HASH>..<HASH> 100644
--- a/website/src/data/config.js
+++ b/website/src/data/config.js
@@ -9,9 +9,9 @@
export default {
// local
// nivoApiUrl: 'http://localhost:3030',
- storybookUrl: 'http://localhost:6006/',
+ // storybookUrl: 'http://localhost:6006/',
// production
nivoApiUrl: 'https://nivo-api.herokuapp.com',
- // storybookUrl: 'https://nivo.rocks/storybook/',
+ storybookUrl: 'https://nivo.rocks/storybook/',
}
|
fix(website): fix storybook url config
|
plouc_nivo
|
train
|
js
|
1b9245a675234f165cd273b8c9fc3dae4eb2b29b
|
diff --git a/src/core/util/util.js b/src/core/util/util.js
index <HASH>..<HASH> 100644
--- a/src/core/util/util.js
+++ b/src/core/util/util.js
@@ -59,7 +59,7 @@ function UtilFactory($document, $timeout, $compile, $rootScope, $$mdAnimate, $in
var $mdUtil = {
dom: {},
- now: window.performance ?
+ now: window.performance && window.performance.now ?
angular.bind(window.performance, window.performance.now) : Date.now || function() {
return new Date().getTime();
},
|
fix(util): check for definition of window.performance.now before using in mdUtil (#<I>)
The previous behavior assumes the existence of the now() function in browsers that provide the
window.performance API. This change verifies it is available and if not, uses existing fallbacks.
|
angular_material
|
train
|
js
|
b737639763ab97b29766e1c52dbadc0d392910f0
|
diff --git a/modules/core/middleware.js b/modules/core/middleware.js
index <HASH>..<HASH> 100644
--- a/modules/core/middleware.js
+++ b/modules/core/middleware.js
@@ -1,5 +1,3 @@
-import constants from '../constants';
-
export default function withMiddleware(router) {
let middlewareFactories = [];
let middlewareFunctions = [];
@@ -25,19 +23,10 @@ export default function withMiddleware(router) {
function addMiddleware(middleware) {
middlewareFactories.push(middleware);
-
- if (router.isStarted()) {
- startMiddleware(middleware);
- }
+ startMiddleware(middleware);
}
function startMiddleware(middleware) {
middlewareFunctions.push(router.executeFactory(middleware));
}
-
- function startMiddlewares() {
- middlewareFunctions = middlewareFactories.map(router.executeFactory);
- }
-
- router.addEventListener(constants.ROUTER_START, startMiddlewares);
}
|
refactor: don't create closures on middlewares on start but when added
|
router5_router5
|
train
|
js
|
97decf801a4614fa9bde1fe20cc563b3224f4788
|
diff --git a/frontend/src/data/helper.js b/frontend/src/data/helper.js
index <HASH>..<HASH> 100644
--- a/frontend/src/data/helper.js
+++ b/frontend/src/data/helper.js
@@ -43,7 +43,7 @@ export function throwIfNotSuccess(response) {
return new Promise((resolve, reject) => {
response.json().then(body => reject(new ForbiddenError(response.status, body)));
});
- } else if (response.status > 399 && response.status < 404) {
+ } else if (response.status > 399 && response.status < 499) {
return new Promise((resolve, reject) => {
response.json().then(body => {
const errorMsg = body && body.isJoi ? extractJoiMsg(body) : extractLegacyMsg(body);
|
fix: should support <I> responses as well
|
Unleash_unleash
|
train
|
js
|
6590f2cf772d493763d0deac81647282d02edc1a
|
diff --git a/lib/index.js b/lib/index.js
index <HASH>..<HASH> 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -4,11 +4,11 @@ import {ConsoleAppender} from 'aurelia-logging-console';
import {History} from 'aurelia-history';
import {BrowserHistory} from 'aurelia-history-browser';
import {RouteLoader, Router, AppRouter} from 'aurelia-router';
-import {TemplatingRouteLoader,RouterViewPort} from 'aurelia-templating-router';
+import {TemplatingRouteLoader,RouterView} from 'aurelia-templating-router';
import {TemplatingBindingLanguage} from 'aurelia-templating-binding';
import {Show, If, Repeat, Compose, SelectedItem} from 'aurelia-templating-resources';
-var defaultResources = [Show, If, Repeat, Compose, RouterViewPort, SelectedItem];
+var defaultResources = [Show, If, Repeat, Compose, RouterView, SelectedItem];
var logger = LogManager.getLogger('bootstrapper');
function ready(global) {
|
fix(bootstrapped): bad import name for RouterView
|
aurelia_bootstrapper
|
train
|
js
|
865f92f73583c7908a876fd1fa244ad08397a950
|
diff --git a/packages/mixins/popup/index.js b/packages/mixins/popup/index.js
index <HASH>..<HASH> 100644
--- a/packages/mixins/popup/index.js
+++ b/packages/mixins/popup/index.js
@@ -4,16 +4,12 @@ import PopupContext from './popup-context';
export default {
props: {
- /**
- * popup当前显示状态
- */
+ // popup当前显示状态
value: {
type: Boolean,
default: false
},
- /**
- * 是否显示遮罩层
- */
+ // 是否显示遮罩层
overlay: {
type: Boolean,
default: false
@@ -26,13 +22,16 @@ export default {
default: false
},
zIndex: [String, Number],
- /**
- * popup滚动时是否body内容也滚动
- * 默认为不滚动
- */
+ // popup滚动时是否body内容也滚动
+ // 默认为不滚动
lockOnScroll: {
type: Boolean,
default: true
+ },
+ // 防止滚动穿透
+ preventScroll: {
+ type: Boolean,
+ default: false
}
},
@@ -137,8 +136,11 @@ export default {
this.$el.style.zIndex = PopupManager.nextZIndex();
this.opened = true;
this.opening = false;
- document.addEventListener('touchstart', this.recordPosition, false);
- document.addEventListener('touchmove', this.watchTouchMove, false);
+
+ if (this.preventScroll) {
+ document.addEventListener('touchstart', this.recordPosition, false);
+ document.addEventListener('touchmove', this.watchTouchMove, false);
+ }
},
/**
|
fix: popup will not preventScroll by default
|
youzan_vant
|
train
|
js
|
8a76b13dacd1b7166dc534f874bbe921d1de6989
|
diff --git a/courriers/tests/settings.py b/courriers/tests/settings.py
index <HASH>..<HASH> 100644
--- a/courriers/tests/settings.py
+++ b/courriers/tests/settings.py
@@ -61,14 +61,14 @@ LOGGING = {
CELERY_ALWAYS_EAGER = True
CELERY_EAGER_PROPAGATES_EXCEPTIONS = True
-MIDDLEWARE_CLASSES = (
+MIDDLEWARE = [
"django.contrib.sessions.middleware.SessionMiddleware",
"django.middleware.common.CommonMiddleware",
"django.middleware.csrf.CsrfViewMiddleware",
"django.contrib.auth.middleware.AuthenticationMiddleware",
"django.contrib.messages.middleware.MessageMiddleware",
"django.middleware.clickjacking.XFrameOptionsMiddleware",
-)
+]
TEMPLATES = [
{
diff --git a/courriers/views.py b/courriers/views.py
index <HASH>..<HASH> 100644
--- a/courriers/views.py
+++ b/courriers/views.py
@@ -113,7 +113,7 @@ class BaseNewsletterListFormView(AJAXResponseMixin, FormView):
return context
def form_valid(self, form):
- if self.request.user.is_authenticated():
+ if self.request.user.is_authenticated:
form.save(self.request.user)
else:
form.save()
|
fix: Django <I> compatibility
|
ulule_django-courriers
|
train
|
py,py
|
6fa6f7f5c4f769b40892b93215e4a6429dab67ca
|
diff --git a/html2asketch/nodeToSketchLayers.js b/html2asketch/nodeToSketchLayers.js
index <HASH>..<HASH> 100644
--- a/html2asketch/nodeToSketchLayers.js
+++ b/html2asketch/nodeToSketchLayers.js
@@ -79,10 +79,6 @@ export default async function nodeToSketchLayers(node) {
const layers = [];
const {width, height, x, y} = node.getBoundingClientRect();
- if (width === 0 || height === 0) {
- return layers;
- }
-
const styles = getComputedStyle(node);
const {
backgroundColor,
@@ -114,9 +110,15 @@ export default async function nodeToSketchLayers(node) {
display,
boxShadow,
visibility,
- opacity
+ opacity,
+ overflowX,
+ overflowY
} = styles;
+ if ((width === 0 || height === 0) && overflowX === 'hidden' && overflowY === 'hidden') {
+ return layers;
+ }
+
if (display === 'none' || visibility === 'hidden' || parseFloat(opacity) === 0) {
return layers;
}
|
fix(overflow): only skip node if overflow is hidden (#<I>)
content of a node can still be visible if height and width are zero, and overflow is set to `'visible'`
|
brainly_html-sketchapp
|
train
|
js
|
6c501a10a8524add249db0e69879be20a42ba5c5
|
diff --git a/deps.js b/deps.js
index <HASH>..<HASH> 100755
--- a/deps.js
+++ b/deps.js
@@ -32,7 +32,7 @@ const depsToVersions = _.curry((rootPkg, deps) => deps.reduce((acc, dep) => {
return acc;
}
- acc[dep] = rootPkg.dependencies[dep] || rootPkg.devDependencies[dep] || rootPkg.optionalDependencies[dep];
+ acc[dep] = _.get(rootPkg, `dependencies[${dep}]`) || _.get(rootPkg, `devDependencies[${dep}]`) || _.get(rootPkg, `optionalDependencies[${dep}]`);
if (!acc[dep]) {
try {
|
chore(tooling): use _.get to check dependency sources
|
webex_spark-js-sdk
|
train
|
js
|
831dcb9098af14341ac8889f805286f8199a583b
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -217,7 +217,8 @@ gulp.task('test:launchsauceconnect', function (done) {
var config = {
username: saucelabsConfig.user,
accessKey: saucelabsConfig.key,
- logger: console.log
+ logger: console.log,
+ noSslBumpDomains: 'all'
}
var tryConnect = function (maxAttempts, currAttempts, done) {
|
chore: add noSslBumpDomains to saucelabs launcher
|
opbeat_opbeat-js-core
|
train
|
js
|
970b434ddbcb28084130d9b24c7302f7d7d94594
|
diff --git a/packages/@vuepress/core/lib/node/createTemp.js b/packages/@vuepress/core/lib/node/createTemp.js
index <HASH>..<HASH> 100644
--- a/packages/@vuepress/core/lib/node/createTemp.js
+++ b/packages/@vuepress/core/lib/node/createTemp.js
@@ -1,5 +1,15 @@
const { fs, path, chalk, logger } = require('@vuepress/shared-utils')
+// Only empty the `.temp` directory at most once per run to avoid
+// compilation errors caused by removed files.
+// See: https://github.com/vuejs/vuepress/issues/2254#issuecomment-689457157
+//
+// Known issue: This can cause the `.temp` directory to grow while the server
+// is running, but the impact is limited because the `.temp` directory will
+// be cleared when restarting the server.
+// See discussion in https://github.com/vuejs/vuepress/pull/2612
+let alreadyEmptied = false
+
/**
* Create a dynamic temp utility context that allow to lanuch
* multiple apps with isolated context at the same time.
@@ -19,8 +29,9 @@ module.exports = function createTemp (tempPath) {
if (!fs.existsSync(tempPath)) {
fs.ensureDirSync(tempPath)
- } else {
+ } else if (!alreadyEmptied) {
fs.emptyDirSync(tempPath)
+ alreadyEmptied = true
}
logger.debug(`Temp directory: ${chalk.gray(tempPath)}`)
|
fix: Only empty the `.temp` directory at most once per run (fix #<I>) (#<I>)
|
vuejs_vuepress
|
train
|
js
|
5b8785fa6427bd1b3fda2aaecd383397957cd413
|
diff --git a/src/qtism/runtime/expressions/operators/Utils.php b/src/qtism/runtime/expressions/operators/Utils.php
index <HASH>..<HASH> 100644
--- a/src/qtism/runtime/expressions/operators/Utils.php
+++ b/src/qtism/runtime/expressions/operators/Utils.php
@@ -334,7 +334,7 @@ class Utils
* @param string $pcreFlags
* @return string
*/
- public static function prepareXsdPatternForPcre(string $pattern, string $pcreFlags = ''): string
+ public static function prepareXsdPatternForPcre(string $pattern, string $pcreFlags = 'su'): string
{
// XML schema always implicitly anchors the entire regular expression
// Neither caret (^) nor dollar ($) sign have special meaning so they are
@@ -345,7 +345,6 @@ class Utils
$pattern = self::pregAddDelimiter('^' . $pattern . '$');
// XSD regexp always case-sensitive (nothing to do), dot matches white-spaces (use PCRE_DOTALL).
- $pattern .= 's';
$pattern .= $pcreFlags;
return $pattern;
|
refactor: always apply unicode regex modifier
|
oat-sa_qti-sdk
|
train
|
php
|
7a17922fdb9a17851d34b453ee68286647e27588
|
diff --git a/packages/regular-play-cli/lib/webpack/generate.js b/packages/regular-play-cli/lib/webpack/generate.js
index <HASH>..<HASH> 100644
--- a/packages/regular-play-cli/lib/webpack/generate.js
+++ b/packages/regular-play-cli/lib/webpack/generate.js
@@ -38,6 +38,7 @@ module.exports = function( options ) {
root: [
_.project( 'node_modules' ),
_.cwd( 'node_modules' ),
+ _.cwd( 'play/node_modules' ),
],
fallback: resolveFallback || [],
packageMains: [ 'play:main', 'jsnext:main', 'browser', 'main' ],
|
fix: support resolving modules from play/node_modules
|
fengzilong_regular-play
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.