hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
e93de76e6683cd7905e8b5250b7e51ef7636e4e1
diff --git a/anyconfig/api.py b/anyconfig/api.py index <HASH>..<HASH> 100644 --- a/anyconfig/api.py +++ b/anyconfig/api.py @@ -37,7 +37,6 @@ import anyconfig.backends import anyconfig.backend.json import anyconfig.compat import anyconfig.mdicts -import anyconfig.parser import anyconfig.template import anyconfig.utils @@ -325,12 +324,12 @@ def loads(content, ac_parser=None, ac_template=False, ac_context=None, msg = "Try parsing with a built-in parser because %s" if ac_parser is None: LOGGER.warning(msg, "ac_parser was not given.") - return anyconfig.parser.parse(content) + return None psr = find_loader(None, ac_parser) if psr is None: LOGGER.warning(msg, "parser '%s' was not found" % ac_parser) - return anyconfig.parser.parse(content) + return None schema = None ac_schema = options.get("ac_schema", None)
fix: make anyconfig.loads returning None if no parser or parser is not found
ssato_python-anyconfig
train
py
5cba07d9b7c386a88de79f7b704f408d107b87b0
diff --git a/jersey/src/main/java/com/netflix/conductor/server/resources/WebAppExceptionMapper.java b/jersey/src/main/java/com/netflix/conductor/server/resources/WebAppExceptionMapper.java index <HASH>..<HASH> 100644 --- a/jersey/src/main/java/com/netflix/conductor/server/resources/WebAppExceptionMapper.java +++ b/jersey/src/main/java/com/netflix/conductor/server/resources/WebAppExceptionMapper.java @@ -57,7 +57,7 @@ public class WebAppExceptionMapper implements ExceptionMapper<WebApplicationExce entityMap.put("instance", host); entityMap.put("code", code.toString()); entityMap.put("message", exception.getCause()); - entityMap.put("isRetryable", false); + entityMap.put("retryable", false); return Response.status(response.getStatus()).entity(entityMap).build(); }
fix(exception): rename key to retryable
Netflix_conductor
train
java
d0dabc4d35388adf7fefe38ad831f52da2caa7e5
diff --git a/packages/netlify-cms/src/index.js b/packages/netlify-cms/src/index.js index <HASH>..<HASH> 100644 --- a/packages/netlify-cms/src/index.js +++ b/packages/netlify-cms/src/index.js @@ -1,4 +1,4 @@ -import CMS, { init } from 'netlify-cms-core'; +import CMS, { init } from 'netlify-cms-core/src'; import './backends'; import './widgets'; import './editor-components';
fix: fix netlify-cms exports
netlify_netlify-cms
train
js
47a71c158191fed529e4261e7ccbfe45306dc5ae
diff --git a/packages/bonde-admin-canary/src/services/auth/AuthProvider.js b/packages/bonde-admin-canary/src/services/auth/AuthProvider.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/services/auth/AuthProvider.js +++ b/packages/bonde-admin-canary/src/services/auth/AuthProvider.js @@ -70,7 +70,7 @@ class AuthProvider extends React.Component { logout: this.handleLogout.bind(this) }} > - {children} + {fetching ? <Loading /> : children} </AuthContext.Provider> ) }
chore(admin-canary): loading children components only auth done
nossas_bonde-client
train
js
a0978099a7f7b4d0c1afb0a6542e04ffc844cab9
diff --git a/gulpfile.js b/gulpfile.js index <HASH>..<HASH> 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -41,6 +41,10 @@ gulp.task('buildSrc', shell.task([ "cd src/node_modules && ../../node_modules/.bin/tsc" ])); +gulp.task('publish', ['buildSrc'], shell.task([ + "cd src && npm publish" +])); + gulp.task('bundle', function() { return require('./tools/bundler').bundle(options.example); }) \ No newline at end of file
chore(publish): add gulp task for npm publish
angular_react-native-renderer
train
js
147dfa4557d6edada03ed73fe5a7d33b661ddc53
diff --git a/Eloquent/Relations/Relation.php b/Eloquent/Relations/Relation.php index <HASH>..<HASH> 100755 --- a/Eloquent/Relations/Relation.php +++ b/Eloquent/Relations/Relation.php @@ -307,7 +307,7 @@ abstract class Relation implements BuilderContract */ public function getBaseQuery() { - return $this->toBase(); + return $this->query->getQuery(); } /** @@ -317,7 +317,7 @@ abstract class Relation implements BuilderContract */ public function toBase() { - return $this->query->applyScopes()->getQuery(); + return $this->query->toBase(); } /**
fix: restore v8 behaviour of base query for relations (#<I>)
illuminate_database
train
php
cf22cd2b74abb1b0678a7c07789bd2527c53fec5
diff --git a/src/rez/pip.py b/src/rez/pip.py index <HASH>..<HASH> 100644 --- a/src/rez/pip.py +++ b/src/rez/pip.py @@ -255,8 +255,9 @@ def pip_install_package(source_name, pip_version=None, python_version=None, distribution_path = DistributionPath([destpath]) distributions = [d for d in distribution_path.get_distributions()] - folders = [folder for folder in os.listdir(destpath) if os.path.isdir(os.path.join(destpath, folder))] - if "bin" in folders: + # moving bin folder to expected relative location as per wheel RECORD files + staged_binpath = os.path.join(destpath, "bin") + if os.path.isdir(staged_binpath): shutil.move(os.path.join(destpath, "bin"), binpath) for distribution in distribution_path.get_distributions():
refactor(rez-pip): move bin folder to expected relative location
nerdvegas_rez
train
py
e6af91e16da1d47ea26206b5ea256a36cc404160
diff --git a/src/geshi/netrexx.php b/src/geshi/netrexx.php index <HASH>..<HASH> 100644 --- a/src/geshi/netrexx.php +++ b/src/geshi/netrexx.php @@ -65,14 +65,14 @@ $language_data = array ( ), 3 => array( 'catch','else','end','finally','otherwise','then','when' - ) + ), 4 => array( 'rc','result','self','sigl','super' - ) + ), 5 => array( '::attribute','::class','::constant','::method', '::optins','::requires','::routine' - ) + ), 6 => array( 'abbrev','abs','b2x','c2d','c2x','center','centre', 'changestr','compare','copies','copyindexed','countstr',
fix: Some missing comma ...
GeSHi_geshi-1.0
train
php
846576468de4b4770527a43747816f011bd6dbfd
diff --git a/algoliasearch/client.go b/algoliasearch/client.go index <HASH>..<HASH> 100644 --- a/algoliasearch/client.go +++ b/algoliasearch/client.go @@ -172,7 +172,7 @@ func (c *client) AddAPIKeyWithRequestOptions(ACL []string, params Map, opts *Req return } - err = c.request(&res, "POST", "/1/keys/", req, read, opts) + err = c.request(&res, "POST", "/1/keys/", req, write, opts) return } diff --git a/algoliasearch/index.go b/algoliasearch/index.go index <HASH>..<HASH> 100644 --- a/algoliasearch/index.go +++ b/algoliasearch/index.go @@ -196,7 +196,7 @@ func (i *index) AddAPIKeyWithRequestOptions(ACL []string, params Map, opts *Requ } path := i.route + "/keys" - err = i.client.request(&res, "POST", path, req, read, opts) + err = i.client.request(&res, "POST", path, req, write, opts) return }
fix: change AddAPIKey type from read to write This commit ensures that we avoid targeting DSNs when adding API keys.
algolia_algoliasearch-client-go
train
go,go
6fb1d8a3775371ba3d32142a7521eef538331f15
diff --git a/raft_stats.go b/raft_stats.go index <HASH>..<HASH> 100644 --- a/raft_stats.go +++ b/raft_stats.go @@ -81,7 +81,7 @@ func (ss *raftServerStats) SendAppendReq(pkgSize int) { type raftFollowersStats struct { Leader string `json:"leader"` - Followers map[string]*raftFollowerStats `json:"follwers"` + Followers map[string]*raftFollowerStats `json:"followers"` } type raftFollowerStats struct {
fix(raft_stats): spelling followers not follwers
etcd-io_etcd
train
go
368cc29d480d5dd0a4cf624ab5cf314042487441
diff --git a/tools/build/pubbuild.js b/tools/build/pubbuild.js index <HASH>..<HASH> 100644 --- a/tools/build/pubbuild.js +++ b/tools/build/pubbuild.js @@ -14,7 +14,7 @@ module.exports = function(gulp, plugins, config) { if (!webFolders.length) { return; } - var folder = getParentFolder(webFolders.shift()); + var folder = path.resolve(path.join(webFolders.shift(), '..')); var destFolder = path.resolve(path.join(config.dest, path.basename(folder))); return util.processToPromise(spawn(config.command, ['build', '-o', destFolder], { stdio: 'inherit', @@ -26,12 +26,6 @@ module.exports = function(gulp, plugins, config) { }; }; -function getParentFolder(folder) { - var parts = folder.split(path.sep); - parts.pop(); - return parts.join(path.sep); -} - function replaceDartWithJsScripts(gulp, folder) { return util.streamToPromise(gulp.src(path.join(folder, '**/*.html')) .pipe(through2.obj(function(file, enc, done) {
fix(gulpfile): fix the pubbuild task on Windows Closes #<I>
angular_angular
train
js
1f117ab723666f8452fb4acbdfd90ef9b6e00d7e
diff --git a/packages/vant-cli/site/desktop/utils.js b/packages/vant-cli/site/desktop/utils.js index <HASH>..<HASH> 100644 --- a/packages/vant-cli/site/desktop/utils.js +++ b/packages/vant-cli/site/desktop/utils.js @@ -4,9 +4,7 @@ export function scrollToAnchor(selector) { const timer = setInterval(() => { const el = document.querySelector(selector); if (el) { - el.scrollIntoView({ - behavior: 'smooth', - }); + el.scrollIntoView(); clearInterval(timer); } else { count++;
chore(cli): scroll to anchor immediately (#<I>)
youzan_vant
train
js
9405e1948303d31339e650ecf0c4b77a77f0c963
diff --git a/cerberus/client.py b/cerberus/client.py index <HASH>..<HASH> 100644 --- a/cerberus/client.py +++ b/cerberus/client.py @@ -195,7 +195,7 @@ class CerberusClient(object): """Return the path for a SDB""" sdb_id = self.get_sdb_id(sdb) sdb_resp = get_with_retry( - self.cerberus_url + '/v1/safe-deposit-box/' + sdb_id + '/', + self.cerberus_url + '/v2/safe-deposit-box/' + sdb_id + '/', headers=self.HEADERS )
fix: change endpoint for getting sdb path
Nike-Inc_cerberus-python-client
train
py
586ec1f5b8c9d0381faa039fcbc1fb13a93aaf65
diff --git a/lib/datasource/npm.js b/lib/datasource/npm.js index <HASH>..<HASH> 100644 --- a/lib/datasource/npm.js +++ b/lib/datasource/npm.js @@ -230,6 +230,9 @@ async function getDependency(name, retries = 5) { extraBaseUrls, }); } + if (res.homepage && res.homepage.includes('://github.com')) { + delete res.homepage; + } // Simplify response before caching and returning const dep = { name: res.name,
refactor(npm): delete package homepage if it’s a github repo
renovatebot_renovate
train
js
a1df08097d086a99d268212621d0f31ffea5c393
diff --git a/test.js b/test.js index <HASH>..<HASH> 100644 --- a/test.js +++ b/test.js @@ -95,6 +95,17 @@ describe('dragTabs', function() { } + function moveTab(event) { + var newIndex = event.newIndex; + var dragTab = event.dragTab; + + var parentNode = dragTab.parentNode; + + parentNode.removeChild(dragTab); + + parentNode.insertBefore(dragTab, parentNode.children[newIndex]); + } + // then expect(function() { dragger.on('start', logger('start')); @@ -102,14 +113,8 @@ describe('dragTabs', function() { dragger.on('end', logger('end')); dragger.on('cancel', logger('cancel')); - dragger.on('drag', function(event) { - var newIndex = event.newIndex; - var dragTab = event.dragTab; - - var parentNode = dragTab.parentNode; - - parentNode.insertBefore(dragTab, parentNode.children[newIndex]); - }); + dragger.on('drag', moveTab); + dragger.on('cancel', moveTab); }).not.to.throw(); });
test(drag-tabs): reset on cancel
bpmn-io_drag-tabs
train
js
5466ff13ba6460e380af7b1b2007a4099342d68f
diff --git a/src/main/java/com/contentful/java/cda/CDAAsset.java b/src/main/java/com/contentful/java/cda/CDAAsset.java index <HASH>..<HASH> 100644 --- a/src/main/java/com/contentful/java/cda/CDAAsset.java +++ b/src/main/java/com/contentful/java/cda/CDAAsset.java @@ -35,6 +35,9 @@ public class CDAAsset extends LocalizedResource { * * @param options to manipulate the image the returned url will be pointing to. * @return an url reflecting all the options given. + * @throws IllegalArgumentException if no options are given. + * @throws IllegalArgumentException if no mimetype was set on asset. + * @throws IllegalArgumentException if mimetype was not an image. * @see ImageOption * @see #url() */ @@ -44,7 +47,8 @@ public class CDAAsset extends LocalizedResource { "If you want to manipulate the url by hand, please use `CDAAsset.url()` instead."); } - if (!mimeType().startsWith("image")) { + final String mimeType = mimeType(); + if (mimeType == null || !mimeType.startsWith("image")) { throw new IllegalStateException("Asset has not image mime type. Please make sure it is " + "of jpg, png, or webp format."); }
fix: Add defensive assumptions: Do not thow NPE if no mimetype is set
contentful_contentful.java
train
java
4ea9b5a5aa1c5efa32f69887f4127e07d56b79e1
diff --git a/src/components/provider.js b/src/components/provider.js index <HASH>..<HASH> 100644 --- a/src/components/provider.js +++ b/src/components/provider.js @@ -329,7 +329,10 @@ export const ValidationProvider = { const rules = normalizeRules(this.rules); const forceRequired = this.forceRequired; - return !!rules.required || forceRequired; + const isRequired = rules.required || forceRequired; + this.flags.required = isRequired; + + return isRequired; }, classes () { const names = getConfig().classNames;
fix: set required flag properly in providers
baianat_vee-validate
train
js
6c19ba394ba8a7f1bd0f6a5b30edc1b5fa122193
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -89,7 +89,7 @@ var PROJECT_ID_PLACEHOLDER = '{{projectId}}'; * }); * * @example <caption>include:samples/quickstart.js</caption> - * region_tag:pubsub_quickstart + * region_tag:pubsub_quickstart_create_topic * Full quickstart example: */ function PubSub(options) { @@ -974,7 +974,7 @@ common.util.promisifyAll(PubSub, { * }); * * @example <caption>include:samples/quickstart.js</caption> - * region_tag:pubsub_quickstart + * region_tag:pubsub_quickstart_create_topic * Full quickstart example: */ module.exports = PubSub;
fix: Fix sample region tag in JSDoc (#<I>)
googleapis_nodejs-pubsub
train
js
edcce6a311057a8a26a0a8d2f6a7ae1321016031
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js index <HASH>..<HASH> 100644 --- a/packages/@vue/cli-service/lib/commands/serve.js +++ b/packages/@vue/cli-service/lib/commands/serve.js @@ -136,7 +136,7 @@ module.exports = (api, options) => { // create server const server = new WebpackDevServer(compiler, Object.assign({ - clientLogLevel: 'none', + clientLogLevel: 'silent', historyApiFallback: { disableDotRule: true, rewrites: genHistoryApiFallbackRewrites(options.publicPath, options.pages)
chore(dev-server): set `clientLogLevel` option to `silent` (#<I>) The `none` option is deprecated and will be removed in the next major <URL>
vuejs_vue-cli
train
js
8833e24422023b981f843d8cbd8f5d316c50557b
diff --git a/packages/core/renderers/renderer-preact.js b/packages/core/renderers/renderer-preact.js index <HASH>..<HASH> 100644 --- a/packages/core/renderers/renderer-preact.js +++ b/packages/core/renderers/renderer-preact.js @@ -115,7 +115,7 @@ export function withPreact(Base = HTMLElement) { this._preactDom = render( call(), root, - this._preactDom || root.childNodes[0], + this._preactDom || root.children[0], ); teardownPreact(); }
fix: revert updating Preact renderer to use "children" vs "childNodes" (used in Skate.js currently); fixes an issue with the block-ist Preact component rendering duplicate content
bolt-design-system_bolt
train
js
6cbc0b74c35d17c890963d73a30ae61f5f5423c4
diff --git a/src/Keboola/StorageApi/Components.php b/src/Keboola/StorageApi/Components.php index <HASH>..<HASH> 100644 --- a/src/Keboola/StorageApi/Components.php +++ b/src/Keboola/StorageApi/Components.php @@ -53,8 +53,12 @@ class Components $data['description'] = $options->getDescription(); } - if ($options->getConfiguration()) { - $data['configuration'] = json_encode($options->getConfiguration()); + if ($options->getConfiguration() !== null) { + if ($options->getConfiguration() === []) { + $data['configuration'] = '{}'; + } else { + $data['configuration'] = json_encode($options->getConfiguration()); + } } if (!is_null($options->getState())) { @@ -185,8 +189,12 @@ class Components $data['description'] = $options->getDescription(); } - if ($options->getConfiguration()) { - $data['configuration'] = json_encode($options->getConfiguration()); + if ($options->getConfiguration() !== null) { + if ($options->getConfiguration() === []) { + $data['configuration'] = '{}'; + } else { + $data['configuration'] = json_encode($options->getConfiguration()); + } } if ($options->getIsDisabled() !== null) {
fix(Components): allow empty configuration
keboola_storage-api-php-client
train
php
c082a82547fc309628c74c3f433c2b4dc873edc3
diff --git a/lib/Launcher.js b/lib/Launcher.js index <HASH>..<HASH> 100644 --- a/lib/Launcher.js +++ b/lib/Launcher.js @@ -107,7 +107,10 @@ class Launcher { chromeExecutable, chromeArguments, { - detached: true, + // On non-windows platforms, `detached: false` makes child process a leader of a new + // process group, making it possible to kill child process tree with `.kill(-pid)` command. + // @see https://nodejs.org/api/child_process.html#child_process_options_detached + detached: process.platform !== 'win32', env: options.env || process.env, stdio }
fix(Launcher): do not detach child process on windows (#<I>) Fixes #<I>.
GoogleChrome_puppeteer
train
js
d77109eeb182af09afbf84e266828dec9ec3547b
diff --git a/src/authentication.js b/src/authentication.js index <HASH>..<HASH> 100644 --- a/src/authentication.js +++ b/src/authentication.js @@ -43,12 +43,10 @@ export class Authentication { let base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/'); try { - let parsed = JSON.parse(decodeURIComponent(escape(window.atob(base64)))); + return JSON.parse(decodeURIComponent(escape(window.atob(base64)))); } catch (error) { - return; + return null; } - - return parsed; } } @@ -101,10 +99,12 @@ export class Authentication { return true; } + let base64Url = token.split('.')[1]; + let base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/'); + let exp; + try { - let base64Url = token.split('.')[1]; - let base64 = base64Url.replace(/-/g, '+').replace(/_/g, '/'); - let exp = JSON.parse(window.atob(base64)).exp; + exp = JSON.parse(window.atob(base64)).exp; } catch (error) { return false; }
chore(authentication): Fixed linting errors
SpoonX_aurelia-authentication
train
js
bf139b80b9fe0fd4f84491fd6bf171b2b44d416e
diff --git a/src/telegram-driver/entities.js b/src/telegram-driver/entities.js index <HASH>..<HASH> 100644 --- a/src/telegram-driver/entities.js +++ b/src/telegram-driver/entities.js @@ -19,8 +19,9 @@ export let entityIs = (type) => pipe( any(propEq('type', type)), pipe(not, isNil))) -export let getEntityFirst = curryN(2, (type, {message: {entities = []}}) => find( - propEq('type', type))(entities)) +export let getEntityFirst = curryN(2, (type, { + message: {entities = []} +}) => find(propEq('type', type))(entities)) export let getEntityFirstValue = curryN(2, (type, update) => { let match = getEntityFirst(type, update)
style(entities): max-len <I>
goodmind_cycle-telegram
train
js
dc05298683c45bb03e6432ddc8eca8ecc2cc5f43
diff --git a/website/docgen/dgeni-config.js b/website/docgen/dgeni-config.js index <HASH>..<HASH> 100644 --- a/website/docgen/dgeni-config.js +++ b/website/docgen/dgeni-config.js @@ -72,6 +72,7 @@ myPackage.config(function(readFilesProcessor, templateFinder, writeFilesProcesso {include: 'lib/**/element.js'}, {include: 'lib/**/protractor.js'}, {include: 'lib/**/locators.js'}, + {include: 'lib/**/expectedConditions.js'}, {include: 'node_modules/selenium-webdriver/lib/**/locators.js'}, {include: 'node_modules/selenium-webdriver/lib/webdriver/webdriver.js'} ];
chore(website): add expectedConditions to website's API page Closes #<I>
angular_protractor
train
js
9a53ddc721c90691b3286a297fe9d25aa5057885
diff --git a/stellar_sdk/base_transaction_envelope.py b/stellar_sdk/base_transaction_envelope.py index <HASH>..<HASH> 100644 --- a/stellar_sdk/base_transaction_envelope.py +++ b/stellar_sdk/base_transaction_envelope.py @@ -76,15 +76,14 @@ class BaseTransactionEnvelope(Generic[T]): """ raise NotImplementedError("The method has not been implemented.") - def sign_hashx(self, preimage: bytes) -> None: + def sign_hashx(self, preimage: Union[bytes, str]) -> None: """Sign this transaction envelope with a Hash(x) signature. See Stellar's documentation on `Multi-Sig <https://www.stellar.org/developers/guides/concepts/multi-sig.html>`_ for more details on Hash(x) signatures. - :param preimage: 32 byte hash or hex encoded string , the "x" value to be hashed and used as a - signature. + :param preimage: Preimage of hash used as signer, byte hash or hex encoded string """ hash_preimage = sha256(hex_to_bytes(preimage)) hint = stellar_xdr.SignatureHint(hash_preimage[-4:])
refactor: improve `sign_hashx`'s docs
StellarCN_py-stellar-base
train
py
d00c5d231ab98b33bc261cdfbc50b9b19c98c0dd
diff --git a/src/utils/gtm.js b/src/utils/gtm.js index <HASH>..<HASH> 100644 --- a/src/utils/gtm.js +++ b/src/utils/gtm.js @@ -158,11 +158,11 @@ export const boot = trackingEventWhitelist => { }; export const updateUser = user => { - if (window.dataLayer && window.app.tracking.gtm) + if (window.dataLayer && window.app.trackingGtm) window.dataLayer.push({ userId: user.id }); }; export const stopTrackingUser = () => { - if (window.dataLayer && window.app.tracking.gtm) + if (window.dataLayer && window.app.trackingGtm) window.dataLayer.push({ userId: undefined }); };
chore(k8s): declare env.json config for k8s Deployment
commercetools_merchant-center-application-kit
train
js
f97b7d07decb008c76f260470e2f138d64aff0cf
diff --git a/src/lib/CollectStore.js b/src/lib/CollectStore.js index <HASH>..<HASH> 100644 --- a/src/lib/CollectStore.js +++ b/src/lib/CollectStore.js @@ -124,4 +124,27 @@ export default class CollectStore { createIntentService(intent, window) { return cozy.client.intents.createService(intent, window) } + + // Get the drive and banks application url using the list of application + fetchUrls() { + return cozy.client + .fetchJSON('GET', '/apps/') + .then(body => { + body.forEach(item => { + if (!item.attributes || !item.attributes.slug || !item.links) return + switch (item.attributes.slug) { + case 'banks': + this.banksUrl = `${item.links.related}` + break + default: + break + } + }) + }) + .catch(err => { + // eslint-disable-next-line no-console + console.warn(err.message) + return false + }) + } }
fix: Revert this remove to keep intent working
cozy_cozy-home
train
js
a81731cc6b2779537294b85a5a248bbf26c02c7b
diff --git a/eventstore/mongodb_v2/eventstore.go b/eventstore/mongodb_v2/eventstore.go index <HASH>..<HASH> 100644 --- a/eventstore/mongodb_v2/eventstore.go +++ b/eventstore/mongodb_v2/eventstore.go @@ -164,7 +164,7 @@ func (s *EventStore) Save(ctx context.Context, events []eh.Event, originalVersio bson.M{"$inc": bson.M{"position": len(dbEvents)}}, ) if r.Err() != nil { - return nil, fmt.Errorf("could not increment global position: %w", err) + return nil, fmt.Errorf("could not increment global position: %w", r.Err()) } allStream := struct { Position int
fix: Use correct error in MongoDB v2 event store
looplab_eventhorizon
train
go
13ef332b8b500d44d9786619554d8203ac82dbc8
diff --git a/webapps/client/scripts/filter/directives/cam-tasklist-tasks.js b/webapps/client/scripts/filter/directives/cam-tasklist-tasks.js index <HASH>..<HASH> 100644 --- a/webapps/client/scripts/filter/directives/cam-tasklist-tasks.js +++ b/webapps/client/scripts/filter/directives/cam-tasklist-tasks.js @@ -254,7 +254,9 @@ define([ }); - scope.$on('filter.saved', loadTasks); + $rootScope.$on('filter.deleted', loadTasks); + + $rootScope.$on('filter.saved', loadTasks); } }; }];
fix(tasks): reload tasks when a filter is changed
camunda_camunda-bpm-platform
train
js
01b65d9ea10a31a3081c2b2e41234b2fc90fa68d
diff --git a/react/index.js b/react/index.js index <HASH>..<HASH> 100644 --- a/react/index.js +++ b/react/index.js @@ -71,6 +71,7 @@ export { default as MonthPicker } from './MonthPicker/MonthPicker'; export { default as SlideToggle } from './SlideToggle/SlideToggle'; export { default as Textarea } from './Textarea/Textarea'; export { default as TextField } from './TextField/TextField'; +export { default as Radio } from './Radio/Radio'; // Accessibility export { default as ScreenReaderOnly } from './ScreenReaderOnly/ScreenReaderOnly';
fix(Radio): Add Radio to export list (#<I>)
seek-oss_seek-style-guide
train
js
3aab2e453ee4279a97c05270e941719711d7a2ee
diff --git a/internal/service/dax/cluster_test.go b/internal/service/dax/cluster_test.go index <HASH>..<HASH> 100644 --- a/internal/service/dax/cluster_test.go +++ b/internal/service/dax/cluster_test.go @@ -32,6 +32,8 @@ func TestAccDAXCluster_basic(t *testing.T) { Check: resource.ComposeTestCheckFunc( testAccCheckClusterExists(resourceName, &dc), acctest.MatchResourceAttrRegionalARN(resourceName, "arn", "dax", regexp.MustCompile("cache/.+")), + resource.TestCheckResourceAttr( + resourceName, "cluster_endpoint_encryption_type", "NONE"), resource.TestMatchResourceAttr( resourceName, "cluster_name", regexp.MustCompile(`^tf-\w+$`)), resource.TestCheckResourceAttrPair(resourceName, "iam_role_arn", iamRoleResourceName, "arn"),
test(dax): basic set NONE endpoint encryption type
terraform-providers_terraform-provider-aws
train
go
a44f68cffd7f9cfa2c12a52db4e96041868a3538
diff --git a/packages/bonde-webpage/src/lib/ux/tell-a-friend-base/tell-a-friend.js b/packages/bonde-webpage/src/lib/ux/tell-a-friend-base/tell-a-friend.js index <HASH>..<HASH> 100644 --- a/packages/bonde-webpage/src/lib/ux/tell-a-friend-base/tell-a-friend.js +++ b/packages/bonde-webpage/src/lib/ux/tell-a-friend-base/tell-a-friend.js @@ -1,5 +1,5 @@ import React from 'react' -import PropTypes from 'prop-types' +import { any, bool, shape, string } from 'prop-types' import { FormattedMessage } from 'react-intl' import FacebookShareButton from './facebook-share-button' import TwitterShareButton from './twitter-share-button' @@ -39,8 +39,6 @@ const TellAFriend = ({ ) } -const { any, bool, shape, string, object } = PropTypes - TellAFriend.propTypes = { preview: bool, mobilization: shape({
feat(webpage): refactor tell-a-friend
nossas_bonde-client
train
js
e315bf50a4c5930c4e74d31335a94fa2c65fca80
diff --git a/httprunner/v3/runner.py b/httprunner/v3/runner.py index <HASH>..<HASH> 100644 --- a/httprunner/v3/runner.py +++ b/httprunner/v3/runner.py @@ -52,7 +52,7 @@ class TestCaseRunner(object): variables_mapping.update(extract_mapping) # validate - validators = step.validation + validators = step.validators resp_obj.validate(validators, variables_mapping) return extract_mapping diff --git a/httprunner/v3/schema/__init__.py b/httprunner/v3/schema/__init__.py index <HASH>..<HASH> 100644 --- a/httprunner/v3/schema/__init__.py +++ b/httprunner/v3/schema/__init__.py @@ -59,4 +59,4 @@ class TestStep(BaseModel): request: Request variables: VariablesMapping = {} extract: Dict[Text, Text] = {} - validation: Validators = Field([], alias="validate") + validators: Validators = Field([], alias="validate")
refactor: rename TestStep model field, validators
HttpRunner_HttpRunner
train
py,py
61cf31dd7f8b9abe5dae517b55e652b337b68eca
diff --git a/packages/bonde-admin-canary/src/scenes/Logged/scenes/Home/components/TableCardGadget.js b/packages/bonde-admin-canary/src/scenes/Logged/scenes/Home/components/TableCardGadget.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/scenes/Logged/scenes/Home/components/TableCardGadget.js +++ b/packages/bonde-admin-canary/src/scenes/Logged/scenes/Home/components/TableCardGadget.js @@ -18,7 +18,7 @@ const TableCardGadget = ({ pageTotal, onClickRow }) => { - const showPagination = ( + const showPagination = !!( page && pageTotal && pageTotal > 1 && renderPagination )
fix(home): force bool cast for showPagination on gadgets
nossas_bonde-client
train
js
c0068f2ea45fdd88b77c191ab40d9319ddbf3068
diff --git a/lib/performance/EmittedAssetSizeLimitPlugin.js b/lib/performance/EmittedAssetSizeLimitPlugin.js index <HASH>..<HASH> 100644 --- a/lib/performance/EmittedAssetSizeLimitPlugin.js +++ b/lib/performance/EmittedAssetSizeLimitPlugin.js @@ -72,7 +72,12 @@ EmittedAssetSizeLimitPlugin.prototype.apply = function(compiler) { sizeLimit ) ); + if(!hasAsyncChunks) { + warnings.push(new NoAsyncChunksWarning()); + } + } + if(entrypointsOverLimit.length > 0) { warnings.push( new EntrypointsOverSizeLimitWarning( entrypointsOverLimit, @@ -84,20 +89,7 @@ EmittedAssetSizeLimitPlugin.prototype.apply = function(compiler) { if(!hasAsyncChunks) { warnings.push(new NoAsyncChunksWarning()); } - } else { - if(entrypointsOverLimit.length > 0) { - warnings.push( - new EntrypointsOverSizeLimitWarning( - entrypointsOverLimit, - compilation, - entrypointSizeLimit - ) - ); - - if(!hasAsyncChunks) { - warnings.push(new NoAsyncChunksWarning()); - } - } + } if(warnings.length > 0) {
chore(performance): remove dup logic case
webpack_webpack
train
js
aabfc9cb68c50eee78440e9907214d0c9c6d82a4
diff --git a/src/classes/Config.js b/src/classes/Config.js index <HASH>..<HASH> 100644 --- a/src/classes/Config.js +++ b/src/classes/Config.js @@ -12,7 +12,7 @@ export default class Config { let config = this.parseConfigFolder(); Object.assign(this, config); - let env = getEnvironmentVariable() + let env = this.getEnvironmentVariable() if ( env !== '' ) this.environment = env else
fix(getEnvironmentVariable): Attach function to class
velop-io_server
train
js
38060733e8bd40d702306cbaf418983e7e880313
diff --git a/src/modules/Search/Search.js b/src/modules/Search/Search.js index <HASH>..<HASH> 100644 --- a/src/modules/Search/Search.js +++ b/src/modules/Search/Search.js @@ -478,6 +478,7 @@ export default class Search extends Component { if (!isBrowser) return const menu = document.querySelector('.ui.search.active.visible .results.visible') const item = menu.querySelector('.result.active') + if (!item) return debug(`menu (results): ${menu}`) debug(`item (result): ${item}`) const isOutOfUpperView = item.offsetTop < menu.scrollTop
fix(Search): pressing up/down arrow in the search input causes error (#<I>) * changes to ComponentDidUpdate event listener logic * adjust event listener changes * remove original changes and adjust scrollItemIntoView
Semantic-Org_Semantic-UI-React
train
js
bded2de51951902444bc62aa016a3ad34aab799e
diff --git a/gitlab/v4/objects.py b/gitlab/v4/objects.py index <HASH>..<HASH> 100644 --- a/gitlab/v4/objects.py +++ b/gitlab/v4/objects.py @@ -268,6 +268,13 @@ class UserProjectManager(ListMixin, CreateMixin, RESTManager): "statistics", "with_issues_enabled", "with_merge_requests_enabled", + "with_custom_attributes", + "with_programming_language", + "wiki_checksum_failed", + "repository_checksum_failed", + "min_access_level", + "id_after", + "id_before", ) def list(self, **kwargs): @@ -1192,12 +1199,16 @@ class GroupProjectManager(ListMixin, RESTManager): "order_by", "sort", "search", - "ci_enabled_first", "simple", "owned", "starred", "with_custom_attributes", "include_subgroups", + "with_issues_enabled", + "with_merge_requests_enabled", + "with_shared", + "min_access_level", + "with_security_reports", )
refactor: support new list filters This is most likely only useful for the CLI
python-gitlab_python-gitlab
train
py
8fa1e828c50be065bd3ce2d9f2a3f5ade18e04e7
diff --git a/lib/monitor.js b/lib/monitor.js index <HASH>..<HASH> 100644 --- a/lib/monitor.js +++ b/lib/monitor.js @@ -168,14 +168,18 @@ class Monitor extends EventEmitter { _getCheckResult() { + function getArray(arr) { + return Array.isArray(arr) ? arr : []; + } + return { consumer: { - online: this._consumersOnline.slice(), - offline: this._consumersOffline.slice(), + online: getArray(this._consumersOnline).slice(), + offline: getArray(this._consumersOffline).slice(), }, producer: { - online: this._producersOnline.slice(), - offline: this._producersOffline.slice(), + online: getArray(this._producersOnline).slice(), + offline: getArray(this._producersOffline).slice(), }, };
fix(monitor): check() 偶尔报错 cannot read property "slice" of undefined
SuperID_super-queue
train
js
29f1d8c2c17f8c04f9768d382b72aeeb0715ebb8
diff --git a/lib/Message.php b/lib/Message.php index <HASH>..<HASH> 100644 --- a/lib/Message.php +++ b/lib/Message.php @@ -43,6 +43,10 @@ abstract class Message public function __toString(): string { - return json_encode($this); + $encoded = json_encode($this); + if ($encoded === false) { + throw new Error(json_last_error_msg(), ErrorCode::INTERNAL_ERROR); + } + return $encoded; } }
fix: throw error if json encoding failed
felixfbecker_php-advanced-json-rpc
train
php
cacdc5a499a7c0ebcf234cb66a1a207d11dce1fe
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -179,10 +179,6 @@ function connect(options, cb) { exports.connect = connect; -function _preventThrowOutError(socket) { - preventThrowOutError(socket._tlssock || socket); -} - function preventThrowOutError(socket) { socket.removeListener('error', freeSocketErrorListener); socket.on('error', freeSocketErrorListener); @@ -302,7 +298,7 @@ exports.extend = function extend(newConf) { proxyOptions.localDNS = false; proxyOptions.auths = getAuths(options); agent = socksAgents[key] = options.isHttps ? new socks.HttpsAgent(proxyOptions) : new socks.HttpAgent(proxyOptions); - agent.on('free', _preventThrowOutError); + agent.on('free', preventThrowOutError); var createSocket = agent.createSocket; agent.createSocket = function(req, options) { var client = createSocket.apply(this, arguments);
refactor: Remove disableResCache
avwo_whistle
train
js
b362357c1fb158d70a97fceec8e3c6502436c58d
diff --git a/tracking_fields/tracking.py b/tracking_fields/tracking.py index <HASH>..<HASH> 100644 --- a/tracking_fields/tracking.py +++ b/tracking_fields/tracking.py @@ -23,7 +23,10 @@ def _set_original_fields(instance): original_fields = {} for field in instance._tracked_fields: if not isinstance(instance._meta.get_field(field), ManyToManyField): - original_fields[field] = getattr(instance, field) + if instance.pk is None: + original_fields[field] = None + else: + original_fields[field] = getattr(instance, field) instance._original_fields = original_fields # Include pk to detect the creation of an object instance._original_fields['pk'] = instance.pk
fix: set original to None when object is not created yet
makinacorpus_django-tracking-fields
train
py
ce35e0ae890d21319bfd7449e12666e1f2964031
diff --git a/packages/bonde-admin-canary/src/services/graphql/client.js b/packages/bonde-admin-canary/src/services/graphql/client.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/services/graphql/client.js +++ b/packages/bonde-admin-canary/src/services/graphql/client.js @@ -5,7 +5,7 @@ import { InMemoryCache } from 'apollo-cache-inmemory' import { AuthAPI } from '../auth' const httpLink = createHttpLink({ - uri: process.env.GRAPH_URL || 'http://localhost:3001/graphql' + uri: process.env.GRAPHQL_URL || 'http://localhost:3001/graphql' }) const authLink = setContext((_, { headers }) => {
chore(bonde-admin-canary): fix env to graphql url
nossas_bonde-client
train
js
71f7c68f7692bfc300d7011e24297a884696ebbc
diff --git a/src/connectors/autocomplete/connectAutocomplete.js b/src/connectors/autocomplete/connectAutocomplete.js index <HASH>..<HASH> 100644 --- a/src/connectors/autocomplete/connectAutocomplete.js +++ b/src/connectors/autocomplete/connectAutocomplete.js @@ -34,7 +34,7 @@ Full documentation available at https://community.algolia.com/instantsearch.js/c /** * @typedef {Object} CustomAutocompleteWidgetOptions - * @property {string[]} [indices = []] Name of the others indices to search into. + * @property {{value: string, label: string}[]} [indices = []] Name of the others indices to search into. * @property {boolean} [escapeHits = false] If true, escape HTML tags from `hits[i]._highlightResult`. */
docs(autocomplete): indices is an object array, not a string array (#<I>) * docs(autocomplete): indices is an object array, not a string array Not sure if jsdoc will take this in account, but can be changed if necessary later * Update connectAutocomplete.js
algolia_instantsearch.js
train
js
255c87d1a99e38e7ec973267ff993994562b85c9
diff --git a/karma.conf.js b/karma.conf.js index <HASH>..<HASH> 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -8,7 +8,8 @@ const ip = "bs-local.com"; const browserstack = require("./browserstack-karma.js"); // https://www.browserstack.com/open-source (text search "parallels") -const BROWSERSTACK_OPEN_SOURCE_CONCURRENCY = 5; +// Instead of the 5 available we only use 2, so two commits can run CI at the same time +const BROWSERSTACK_OPEN_SOURCE_CONCURRENCY = 2; const getBrowserstackBrowsers = () => Object.keys(browserstack).filter((k) => !!browserstack[k].es5 === es5);
chore(tools): lower browserstack concurrency
snabbdom_snabbdom
train
js
84d518e3bd38544963f74f037fb8b4de5353970f
diff --git a/src/util/calculateSUV.js b/src/util/calculateSUV.js index <HASH>..<HASH> 100644 --- a/src/util/calculateSUV.js +++ b/src/util/calculateSUV.js @@ -67,7 +67,7 @@ export default function(image, storedPixelValue, skipRescale = false) { seriesAcquisitionTime.minutes * 60 + seriesAcquisitionTime.hours * 60 * 60; const injectionStartTimeInSeconds = - fracToDec(startTime.fractionalSeconds) + + fracToDec(startTime.fractionalSeconds || 0) + startTime.seconds + startTime.minutes * 60 + startTime.hours * 60 * 60;
fix: 🐛 Fix SUV calculation if fractional seconds not present (#<I>)
cornerstonejs_cornerstoneTools
train
js
c114c38b9307b25867fced695a3fa562fd66b992
diff --git a/.storybook/Hug.js b/.storybook/Hug.js index <HASH>..<HASH> 100644 --- a/.storybook/Hug.js +++ b/.storybook/Hug.js @@ -25,8 +25,8 @@ storiesOf('Hug', module) </Hug> )) .add('With an uncropped border', () => ( - <Hug text={text}> - <Card p={3} bg="white" color="text" showChildBorder> + <Hug text={text} showChildBorder> + <Card p={3} bg="white" color="text"> I‘m a card within a hug! </Card> </Hug>
feat(hug): move prop to Hug
jrs-innovation-center_design-system
train
js
fdd6743dc129290a94570eff24eebd7c068e6af5
diff --git a/packages/tutorial/scripts/dist.js b/packages/tutorial/scripts/dist.js index <HASH>..<HASH> 100644 --- a/packages/tutorial/scripts/dist.js +++ b/packages/tutorial/scripts/dist.js @@ -14,7 +14,7 @@ function makeDist () { if (test('-d', dir)) { var part = dir.split('/').slice(-1)[0] prepare(part) - sed('-i', /\/tutorial\/.*"/g, '/tutorial/' + part + '"', paths.package) + sed('-i', /\/tutorial\/?.*"/g, '/tutorial/' + part + '"', paths.package) exec('npm run build') cp('-R', paths.build, path.join(paths.dist, part)) }
chore(tutorial): fix publish base path for parts
cerebral_cerebral
train
js
157bd2158da9fa9e6ae4def8d0be37a4b05e0f80
diff --git a/src/createPhantomPool.js b/src/createPhantomPool.js index <HASH>..<HASH> 100644 --- a/src/createPhantomPool.js +++ b/src/createPhantomPool.js @@ -10,7 +10,6 @@ module.exports = (logger, concurrency, phantomParameters, browserCookies) => { const poolDebug = {}; return poolModule.Pool({ // eslint-disable-line - name: 'phantomjs', create: (callback) => { async.waterfall([ function createPhantom(done) {
style: we only have one pool, no need for a name
crawlkit_crawlkit
train
js
ff16fffdeaebcb0f16587d596dba3f8046ff6c21
diff --git a/ui/src/composables/private/use-anchor.js b/ui/src/composables/private/use-anchor.js index <HASH>..<HASH> 100644 --- a/ui/src/composables/private/use-anchor.js +++ b/ui/src/composables/private/use-anchor.js @@ -137,7 +137,7 @@ export default function ({ } function pickAnchorEl () { - if (props.target === false || props.target === '') { + if (props.target === false || props.target === '' || proxy.$el.parentNode === null) { anchorEl.value = null } else if (props.target === true) {
fix(anchor): prevent error while setting anchor on detached component #<I>, #<I> (#<I>)
quasarframework_quasar
train
js
91b9dc3b6f5deea88028e97aab15b3b9f3289a2a
diff --git a/src/events.js b/src/events.js index <HASH>..<HASH> 100644 --- a/src/events.js +++ b/src/events.js @@ -111,10 +111,14 @@ function setNativeValue(element, value) { Object.getOwnPropertyDescriptor(prototype, 'value') || {} if (prototypeValueSetter && valueSetter !== prototypeValueSetter) { prototypeValueSetter.call(element, value) - } /* istanbul ignore next (I don't want to bother) */ else if (valueSetter) { - valueSetter.call(element, value) } else { - throw new Error('The given element does not have a value setter') + /* istanbul ignore if */ + // eslint-disable-next-line no-lonely-if -- Can't be ignored by istanbul otherwise + if (valueSetter) { + valueSetter.call(element, value) + } else { + throw new Error('The given element does not have a value setter') + } } }
test: Fix missing coverage for else-if (#<I>)
testing-library_dom-testing-library
train
js
00bc80bb37559f1c5202d2990315130519f4fcc7
diff --git a/packages/platform-server/rollup.config.js b/packages/platform-server/rollup.config.js index <HASH>..<HASH> 100644 --- a/packages/platform-server/rollup.config.js +++ b/packages/platform-server/rollup.config.js @@ -10,10 +10,13 @@ import resolve from 'rollup-plugin-node-resolve'; import sourcemaps from 'rollup-plugin-sourcemaps'; const globals = { + '@angular/animations': 'ng.animations', '@angular/core': 'ng.core', '@angular/common': 'ng.common', '@angular/compiler': 'ng.compiler', + '@angular/http': 'ng.http', '@angular/platform-browser': 'ng.platformBrowser', + '@angular/platform-browser-dynamic': 'ng.platformBrowserDynamic', 'rxjs/Observable': 'Rx', 'rxjs/Subject': 'Rx', 'rxjs/operator/toPromise': 'Rx.Observable.prototype',
fix(platform-server): add missing packages to the UMD global rollup config This adds the proper bindings for calling angular packages from platform-server in the UMD. This was not a problem for universal apps that dont use UMD. Fixes <I>
angular_angular
train
js
3ecd5e7375bfdce39b4d5206682f704ae6743015
diff --git a/registry/offer.go b/registry/offer.go index <HASH>..<HASH> 100644 --- a/registry/offer.go +++ b/registry/offer.go @@ -7,6 +7,7 @@ import ( "time" "github.com/coreos/go-etcd/etcd" + log "github.com/golang/glog" "github.com/coreos/coreinit/job" "github.com/coreos/coreinit/machine" @@ -34,7 +35,12 @@ func (r *Registry) ClaimJobOffer(jobName string, m *machine.Machine, ttl time.Du func (r *Registry) ResolveJobOffer(jobName string) { key := path.Join(keyPrefix, offerPrefix, jobName) - r.etcd.Delete(key, true) + _, err := r.etcd.Delete(key, true) + if err == nil { + log.V(2).Infof("Successfully resolved JobOffer(%s)", jobName) + } else { + log.V(2).Infof("Failed to resolve JobOffer(%s): %s", jobName, err.Error()) + } } func (r *Registry) SubmitJobBid(jb *job.JobBid) {
chore(logging): moar logging!
coreos_fleet
train
go
b2869d5741bccbea1e12a8d40e19d5f1fa1aedfa
diff --git a/build/tasks/build.js b/build/tasks/build.js index <HASH>..<HASH> 100644 --- a/build/tasks/build.js +++ b/build/tasks/build.js @@ -53,12 +53,13 @@ gulp.task('build-system', function () { }); gulp.task('build-dts', function(){ - return gulp.src(paths.output + paths.packageName + '.d.ts') - .pipe(rename(paths.packageName + '.d.ts')) - .pipe(gulp.dest(paths.output + 'es6')) - .pipe(gulp.dest(paths.output + 'commonjs')) - .pipe(gulp.dest(paths.output + 'amd')) - .pipe(gulp.dest(paths.output + 'system')); + return gulp.src([paths.output + paths.packageName + '.d.ts', paths.doc + '/whatwg-fetch.d.ts']) + .pipe(concat(paths.packageName + '.d.ts')) + .pipe(gulp.dest(paths.output)) + .pipe(gulp.dest(paths.output + 'es6')) + .pipe(gulp.dest(paths.output + 'commonjs')) + .pipe(gulp.dest(paths.output + 'amd')) + .pipe(gulp.dest(paths.output + 'system')); }); gulp.task('build', function(callback) {
fix(build): include fetch API typings with this library's typings fixes #<I>, #<I>
aurelia_fetch-client
train
js
2cf3b24d060d0ff4a2dc1ac4a71415ea4eff5871
diff --git a/lib/index.js b/lib/index.js index <HASH>..<HASH> 100644 --- a/lib/index.js +++ b/lib/index.js @@ -4,7 +4,7 @@ const path = require('path') const request = require('request') const validator = require('validator') -const dreamsFile = path.join('./', 'resources', 'dreams.json') +const dreamsFile = path.join(__dirname, '../', 'resources', 'dreams.json') const dreamsJSON = fs.readFileSync(dreamsFile, 'utf8') const parsedDreams = JSON.parse(dreamsJSON) const dreams = parsedDreams.dreams
fix(Library): Fix dreams.json path
durancristhian_quiniela-results
train
js
686b54839631851fa37a36c7b43a78a71cee7d78
diff --git a/ui/src/components/breadcrumbs/QBreadcrumbs.js b/ui/src/components/breadcrumbs/QBreadcrumbs.js index <HASH>..<HASH> 100644 --- a/ui/src/components/breadcrumbs/QBreadcrumbs.js +++ b/ui/src/components/breadcrumbs/QBreadcrumbs.js @@ -6,7 +6,7 @@ import { createComponent } from '../../utils/private/create.js' import { hSlot } from '../../utils/private/render.js' import { getNormalizedVNodes } from '../../utils/private/vm.js' -const disabledValues = [ void 0, true ] +const disabledValues = [ '', true ] export default createComponent({ name: 'QBreadcrumbs',
fix(QBreadcrumbs): fix child elements disable prop detection #<I> (#<I>) * fix(QBreadcrumbs): fix child elements disable prop detection #<I> * Update ui/src/components/breadcrumbs/QBreadcrumbs.js
quasarframework_quasar
train
js
3a09f412eb7679cc8f97d97c14d0cc14d81a26df
diff --git a/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js b/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js index <HASH>..<HASH> 100644 --- a/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js +++ b/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js @@ -21,13 +21,23 @@ export default Component.extend (Theme, { tagName: 'header', classNames: 'mdc-top-app-bar', - classNameBindings: ['styleClassName', 'fixedAdjustClassName', 'alwaysClosedClassName:mdc-top-app-bar--short-collapsed'], + + classNameBindings: [ + 'styleClassName', + 'fixedAdjustClassName', + 'alwaysClosedClassName:mdc-top-app-bar--short-collapsed', + 'contextual:mdc-top-app-bar--contextual', + ], /// Notification for navigation button clicked. navigation: undefined, + /// The top app bar is always closed in short mode. alwaysClosed: false, + /// Mark the top app bar as contextual + contextual: false, + _topAppBar: undefined, _navEventListener: undefined,
feat: Added contextual support to top app bar
onehilltech_ember-cli-mdc
train
js
145bd3f2c0a3f5e3cca2d354446329e49204efe4
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -108,7 +108,7 @@ function run() { return createLoader().then(loader => { return preparePlatform(loader).then(() => { for (let i = 0, ii = appHost.length; i < ii; ++i) { - handleApp(loader, appHost[i]).catch(logger.error.bind(logger)); + handleApp(loader, appHost[i]).catch(console.error.bind(console)); } sharedLoader = loader;
fix(index): switch to console when logger not loaded
aurelia_bootstrapper
train
js
1e754a8153ae9a9db0167618a070a3a78618f0ad
diff --git a/src/Application.php b/src/Application.php index <HASH>..<HASH> 100644 --- a/src/Application.php +++ b/src/Application.php @@ -39,7 +39,7 @@ class Application protected $name; /** @var string App version */ - protected $version = '0.0.1'; + protected $version = ''; /** @var string Ascii art logo */ protected $logo = ''; @@ -49,7 +49,10 @@ class Application /** @var Interactor */ protected $io; - public function __construct(string $name, string $version = '', callable $onExit = null) + /** @var callable The callable to perform exit */ + protected $onExit; + + public function __construct(string $name, string $version = '0.0.1', callable $onExit = null) { $this->name = $name; $this->version = $version; @@ -267,9 +270,9 @@ class Application $exitCode = 255; try { - $command = $this->parse($argv); - $this->doAction($command); - $exitCode = 0; + $command = $this->parse($argv); + $result = $this->doAction($command); + $exitCode = \is_int($result) ? $result : 0; } catch (\Throwable $e) { $this->outputHelper()->printTrace($e); }
refactor(app): add onExit prop, execute or action can return exit code
adhocore_php-cli
train
php
1adc534af771663de376460e484e8d83cefcc898
diff --git a/test/specs/polar/RadarSpec.js b/test/specs/polar/RadarSpec.js index <HASH>..<HASH> 100644 --- a/test/specs/polar/RadarSpec.js +++ b/test/specs/polar/RadarSpec.js @@ -3,7 +3,7 @@ import { expect } from 'chai'; import { Surface, Radar, Sector } from 'recharts'; import { mount, render } from 'enzyme'; -describe('<Pie />', () => { +describe('<Radar />', () => { const data = [ { x: 200, y: 230, cx: 250, cy: 250, angle: 30, radius: 60, value: 4 }, { x: 300, y: 405, cx: 250, cy: 250, angle: 90, radius: 60, value: 4 },
fix: tweak text in RadarSpec
recharts_recharts
train
js
321bed9c3a312e251217ec2346b7bd1e29b29b6a
diff --git a/commitlint.config.js b/commitlint.config.js index <HASH>..<HASH> 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -3,17 +3,21 @@ // so authorizing 4+5 = 9 characters more on master for the max header length should work // until we reach PR #99999. -let maxHeaderLength = 100; +let maxLineLength = 100; const prExtrasChars = 9; const isPushEvent = process.env.GITHUB_EVENT_NAME === 'push'; if (isPushEvent) { - maxHeaderLength += prExtrasChars; + maxLineLength += prExtrasChars; } module.exports = { extends: ['@commitlint/config-conventional'], - rules: { 'header-max-length': [2, 'always', maxHeaderLength] }, + rules: { + 'header-max-length': [2, 'always', maxLineLength], + 'body-max-line-length': [2, 'always', maxLineLength], + 'footer-max-line-length': [2, 'always', maxLineLength], + }, };
ci: consider all linting errors about line length as warnings (#<I>)
ForestAdmin_forest-express-sequelize
train
js
40da1fd5490d4433141742bb22bf70b7ac943836
diff --git a/src/components/ProgressIndicator/ProgressIndicator.js b/src/components/ProgressIndicator/ProgressIndicator.js index <HASH>..<HASH> 100644 --- a/src/components/ProgressIndicator/ProgressIndicator.js +++ b/src/components/ProgressIndicator/ProgressIndicator.js @@ -51,7 +51,7 @@ ProgressStep.propTypes = { /** * Provide the label for the <ProgressStep> */ - label: PropTypes.string.isRequired, + label: PropTypes.node.isRequired, /** * Provide an optional className to be applied to the containing <li> node
chore: Corrected label PropType from string to node, resolves #<I> (#<I>)
carbon-design-system_carbon-components-react
train
js
47377d8ea8519b6819ff181ab7dd3c440da3b35a
diff --git a/molgenis-core-ui/src/main/resources/js/jquery.molgenis.xrefmrefsearch.js b/molgenis-core-ui/src/main/resources/js/jquery.molgenis.xrefmrefsearch.js index <HASH>..<HASH> 100644 --- a/molgenis-core-ui/src/main/resources/js/jquery.molgenis.xrefmrefsearch.js +++ b/molgenis-core-ui/src/main/resources/js/jquery.molgenis.xrefmrefsearch.js @@ -19,7 +19,7 @@ var restApi = new molgenis.RestClient(); function getInexactQueryOperator(fieldType) { - var operator = 'SEARCH'; + var operator = 'LIKE'; switch (fieldType) { case 'INT': case 'LONG':
feat: the mref filter in the data explorer now uses like instead of search
molgenis_molgenis
train
js
8f16a5d762e3583f2ce0467d9d6bc97f7aa43281
diff --git a/spec/support/active_record/schema.rb b/spec/support/active_record/schema.rb index <HASH>..<HASH> 100644 --- a/spec/support/active_record/schema.rb +++ b/spec/support/active_record/schema.rb @@ -1,7 +1,7 @@ require 'active_record' require 'logger' -ActiveRecord::Base.establish_connection(:adapter => 'sqlite3', :database => ':memory:') +ActiveRecord::Base.establish_connection ActiveRecord::Base.logger = Logger.new(SPEC_ROOT.join('debug.log')) ActiveRecord::Migration.verbose = false
fix: don't force sqlite3 connection in specs, let the database.yml config be used
collectiveidea_audited
train
rb
7deccc38b1a9da27fd4102831e7289988cfd80b4
diff --git a/quasar/src/components/btn/QBtn.js b/quasar/src/components/btn/QBtn.js index <HASH>..<HASH> 100644 --- a/quasar/src/components/btn/QBtn.js +++ b/quasar/src/components/btn/QBtn.js @@ -58,6 +58,12 @@ export default Vue.extend({ __onKeyup (e) { if ([13, 32].includes(e.keyCode) === true) { + // from form submit -- keydown was called + // on other form item then keydown was attached to btn + if (this.pressed !== true) { + return + } + stopAndPrevent(e) this.__onKeyupAbort()
fix(QBtn): [v1] Submit on form with "enter" generates 2 requests #<I>
quasarframework_quasar
train
js
2852acd2046757a473e51cfd595afbb5edfeaf33
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -204,7 +204,7 @@ module.exports = function (options) { redirect(ctx, loginURL); })(); - return yield options.redirectHandler.call(this, nextHandler); + return yield options.redirectHandler.call(this, nextHandler, next); } debug('get user directly');
feat: add next parameter to redirectHandler (#<I>) sometimes it is not necessary to redirect to the login page when user is null, so add next parameter can make the process back to the flow
koajs_userauth
train
js
f58b9830d74bf6529f8c2e86aae8490a41cbd3cc
diff --git a/src/http-server/src/Command/ServerCommand.php b/src/http-server/src/Command/ServerCommand.php index <HASH>..<HASH> 100644 --- a/src/http-server/src/Command/ServerCommand.php +++ b/src/http-server/src/Command/ServerCommand.php @@ -30,12 +30,13 @@ class ServerCommand { $httpServer = $this->getHttpServer(); - // Sever 配置参数 - $serverStatus = $httpServer->getServerSetting(); - // 是否正在运行 if ($httpServer->isRunning()) { + $serverStatus = $httpServer->getServerSetting(); + \output()->writeln("<error>The server have been running!(PID: {$serverStatus['masterPid']})</error>", true, true); + } else { + $serverStatus = $httpServer->getServerSetting(); } // 启动参数
fix: undefined index on run server:start when server has been running.
swoft-cloud_swoft-http-message
train
php
bef34605fbee69c015211426026f2d031ae77733
diff --git a/src/BH.php b/src/BH.php index <HASH>..<HASH> 100644 --- a/src/BH.php +++ b/src/BH.php @@ -773,12 +773,15 @@ class BH // if (mods = json.elem && json.elemMods || json.mods) $mods = $json->elem && isset($json->elemMods) ? $json->elemMods : $json->mods; + $isList = isList($mods); foreach ($mods as $k => $mod) { if (!$mod && $mod !== 0) { continue; } $res .= ' ' . ($nobase ? '' : $base) . $naming['mod']; - $res .= $k . ($mod === true ? '' : $naming['val'] . $mod); + $res .= $isList + ? $mod + : $k . ($mod === true ? '' : $naming['val'] . $mod); } return $res;
feat: Boolean mods from simple arrays
bem_bh-php
train
php
2c0958a50cbfbdc0d4a8b7ed6b32635738488ddd
diff --git a/src/geshi.php b/src/geshi.php index <HASH>..<HASH> 100644 --- a/src/geshi.php +++ b/src/geshi.php @@ -1970,6 +1970,11 @@ class GeSHi { * @since 1.0.8 */ protected function build_parse_cache() { + // check whether language_data is available + if (empty($this->language_data)) { + return false; + } + // cache symbol regexp //As this is a costy operation, we avoid doing it for multiple groups ... //Instead we perform it for all symbols at once. @@ -2151,7 +2156,7 @@ class GeSHi { * * @since 1.0.0 */ - public function parse_code () { + public function parse_code() { // Start the timer $start_time = microtime(); @@ -2159,6 +2164,11 @@ class GeSHi { $code = str_replace("\r\n", "\n", $this->source); $code = str_replace("\r", "\n", $code); + // check whether language_data is available + if (empty($this->language_data)) { + $this->error = GESHI_ERROR_NO_SUCH_LANG; + } + // Firstly, if there is an error, we won't highlight if ($this->error) { //Escape the source for output
fix: prevent error with no language set
GeSHi_geshi-1.0
train
php
df26beb26de5dab97ff2fc3887659d894a52f242
diff --git a/test_settings.py b/test_settings.py index <HASH>..<HASH> 100644 --- a/test_settings.py +++ b/test_settings.py @@ -157,3 +157,23 @@ AUTHENTICATION_BACKENDS = ( STATIC_ROOT = '/tmp/' # Dummy STATIC_URL = '/static/' + +from django.contrib.auth.hashers import PBKDF2PasswordHasher + + +class MyPBKDF2PasswordHasher(PBKDF2PasswordHasher): + """ + A subclass of PBKDF2PasswordHasher that uses 1 iteration. + + This is for test purposes only. Never use anywhere else. + """ + iterations = 1 + + +PASSWORD_HASHERS = [ + 'test_settings.MyPBKDF2PasswordHasher', + 'django.contrib.auth.hashers.PBKDF2PasswordHasher', + 'django.contrib.auth.hashers.PBKDF2SHA1PasswordHasher', + 'django.contrib.auth.hashers.Argon2PasswordHasher', + 'django.contrib.auth.hashers.BCryptSHA256PasswordHasher', +]
test(test_settings): decrease password iterations to increase test speed * test(test_settings): decrease password iterations to increase test speed * update MyPBKDF2PasswordHasher to mention never using the low iterations anywhere.
pennersr_django-allauth
train
py
45b54d57576d2ca17e6ac05b1520aed88e56ccaa
diff --git a/src/Service/ElasticaService.php b/src/Service/ElasticaService.php index <HASH>..<HASH> 100644 --- a/src/Service/ElasticaService.php +++ b/src/Service/ElasticaService.php @@ -36,6 +36,7 @@ use Symfony\Component\OptionsResolver\OptionsResolver; class ElasticaService { + private const MAX_INDICES_BY_ALIAS = 100; private LoggerInterface $logger; private Client $client; @@ -287,7 +288,7 @@ class ElasticaService public function getIndicesFromAlias(string $alias): array { $terms = new TermsAggregation('indexes'); - $terms->setSize(2); + $terms->setSize(self::MAX_INDICES_BY_ALIAS); $terms->setField('_index'); $esSearch = new ElasticaSearch($this->client); $esSearch->setOption(ElasticaSearch::OPTION_SIZE, 0); @@ -589,7 +590,7 @@ class ElasticaService $aggIndexes = new TermsAggregation('indexes'); $aggIndexes->setField('_index'); - $aggIndexes->setSize(100); + $aggIndexes->setSize(self::MAX_INDICES_BY_ALIAS); $aggContentType = new TermsAggregation('contentTypes'); $aggContentType->setField('_contenttype');
fix: more than 2 index in an alias (#<I>) * fix: more than 2 index in an alias * chore: private
ems-project_EMSCommonBundle
train
php
694fd6c9e5561c33a9f32d1b7381462148710b0c
diff --git a/packages/tooltip/src/react/index.js b/packages/tooltip/src/react/index.js index <HASH>..<HASH> 100644 --- a/packages/tooltip/src/react/index.js +++ b/packages/tooltip/src/react/index.js @@ -81,11 +81,7 @@ const Tooltip = React.forwardRef((props, ref) => { Tooltip.propTypes = { appearance: PropTypes.oneOf(Object.keys(vars.appearances)), - children: PropTypes.oneOfType([ - PropTypes.arrayOf(PropTypes.node), - PropTypes.node, - PropTypes.string - ]).isRequired, + children: PropTypes.string.isRequired, className: PropTypes.string, style: PropTypes.object, tailPosition: PropTypes.oneOf(Object.keys(vars.tailPositions)),
fix: revert changes to Tooltip.children PropTypes
pluralsight_design-system
train
js
f969afa1cffe446a00351a6851390ca101bbccf7
diff --git a/go/vt/vtgate/planbuilder/abstract/join.go b/go/vt/vtgate/planbuilder/abstract/join.go index <HASH>..<HASH> 100644 --- a/go/vt/vtgate/planbuilder/abstract/join.go +++ b/go/vt/vtgate/planbuilder/abstract/join.go @@ -58,8 +58,8 @@ func (j *Join) PushPredicate(expr sqlparser.Expr, semTable *semantics.SemTable) j.LeftJoin = false return j.RHS.PushPredicate(expr, semTable) } - // TODO - we should do this on the vtgate level once we have a Filter primitive - return vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: cross-shard left join and where clause") + semTable.ProjectionErr = vterrors.Errorf(vtrpcpb.Code_UNIMPLEMENTED, "unsupported: cross-shard left join and where clause") + return nil case deps.IsSolvedBy(j.LHS.TableID().Merge(j.RHS.TableID())): j.Predicate = sqlparser.AndExpressions(j.Predicate, expr) return nil
feat: fail queries only when we know that we can't send everything to a single shard
vitessio_vitess
train
go
deff275604c6a400ec0f3f9b7cd36ee4415af99f
diff --git a/modules/components/FormItemDatePickerV2.js b/modules/components/FormItemDatePickerV2.js index <HASH>..<HASH> 100644 --- a/modules/components/FormItemDatePickerV2.js +++ b/modules/components/FormItemDatePickerV2.js @@ -60,6 +60,7 @@ class FormItemDatePickerV2 extends React.Component { orientation="vertical" noBorder={true} block={true} + readOnly={true} displayFormat="YYYY-MM-DD" showClearDate={true} isOutsideRange={() => false}
test: 补上缺少的lodash
miaoxing_app
train
js
af4d3d9e16dc0eca64e504d29807ab955bd66058
diff --git a/karma.conf.js b/karma.conf.js index <HASH>..<HASH> 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -61,7 +61,7 @@ function setConfig(defaultConfig, server) { // } }; defaultConfig.browsers = [ - 'IE8', + // 'IE8', 'IE9', 'IE10', 'IE11',
chore: exclude IE8 test (#<I>) When the test is run, the socket is not connected even if Karma is starting
nhn_tui.code-snippet
train
js
be6cdde6f3cb24f732013c1df70eac6ac11eecbb
diff --git a/packages/text/src/index.js b/packages/text/src/index.js index <HASH>..<HASH> 100644 --- a/packages/text/src/index.js +++ b/packages/text/src/index.js @@ -1,5 +1,4 @@ export { default as Title } from "./components/Title"; export { default as Caption } from "./components/Caption"; export { default as Paragraph } from "./components/Paragraph"; -export { default as fontSizes } from "./constants/fontSizes"; -export { default as fontTypes } from "./constants/fontTypes"; +export { fontSizes, fontTypes } from "@crave/farmblocks-theme"; diff --git a/packages/text/src/styledComponents/Title.js b/packages/text/src/styledComponents/Title.js index <HASH>..<HASH> 100644 --- a/packages/text/src/styledComponents/Title.js +++ b/packages/text/src/styledComponents/Title.js @@ -1,4 +1,3 @@ -// import styled, { css } from "styled-components"; import styled from "styled-components"; import { fontWeights } from "@crave/farmblocks-theme";
fix(text): export constants from theme package affects: @crave/farmblocks-text ISSUES CLOSED: #<I>
CraveFood_farmblocks
train
js,js
6ca82b892e3326accaaa279cbe43b9805cae8e17
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -120,8 +120,7 @@ function getName (candidate) { * Loads a custom logic module to populate additional distribution information */ function customLogic (os, name, file, cb) { - var logic = './logic/' + name + '.js' - try { require(logic)(os, file, cb) } catch (e) { cb(null, os) } + try { require(`./logic/${name}.js`)(os, file, cb) } catch (e) { cb(null, os) } } /**
fix(require): Use statically analyzable dynamic requires (#<I>)
retrohacker_getos
train
js
646c9c1c945c39d544439c3bfd23aee0adc9a68b
diff --git a/packages/orbit-components/src/ButtonLink/index.js b/packages/orbit-components/src/ButtonLink/index.js index <HASH>..<HASH> 100644 --- a/packages/orbit-components/src/ButtonLink/index.js +++ b/packages/orbit-components/src/ButtonLink/index.js @@ -16,8 +16,8 @@ const ButtonLink: React.AbstractComponent<Props, HTMLButtonElement> = React.forw HTMLButtonElement, >(({ type = TYPES.PRIMARY, size, compact = false, ...props }, ref) => { const theme = useTheme(); - const propsWithTheme = { theme, ...props }; - const commonProps = getButtonLinkCommonProps({ ...propsWithTheme, size, compact }); + const propsWithTheme = { theme, size, ...props }; + const commonProps = getButtonLinkCommonProps({ ...propsWithTheme, compact }); const buttonLinkStyles = getButtonLinkStyles({ type, theme, compact }); const icons = getIconContainer({ ...propsWithTheme,
fix(ButtonLink): pass size prop to icons (#<I>)
kiwicom_orbit-components
train
js
f6f2a9dd6ad43f1a86ea0d9fe42a12a8eee204a2
diff --git a/lib/oracle.js b/lib/oracle.js index <HASH>..<HASH> 100644 --- a/lib/oracle.js +++ b/lib/oracle.js @@ -4,6 +4,23 @@ const path = require('path'); const parseAuthor = require('parse-author'); /** + * Normalize author to {name, email, url} + */ +function getAuthor (pkg) { + return ( + typeof pkg.author === 'string' + ? parseAuthor(pkg.author) + : pkg.author && typeof pkg.author === 'object' + ? { + name: pkg.author.name, + email: pkg.author.email, + url: pkg.author.url, + } + : {} + ); +} + +/** * Reads file if it exists */ function readJSON (file) { @@ -49,13 +66,13 @@ guessVersion (compilerWorkingDirectory) { * Tries to guess the author name from the package.json */ guessDeveloperName (compilerWorkingDirectory) { - return parseAuthor(readPackageJson(compilerWorkingDirectory).author || "").name; + return getAuthor(readPackageJson(compilerWorkingDirectory)).name; }, /** * Tries to guess the author URL from the package.json */ guessDeveloperURL (compilerWorkingDirectory) { - return parseAuthor(readPackageJson(compilerWorkingDirectory).author || "").url; + return getAuthor(readPackageJson(compilerWorkingDirectory)).url; }, };
fix: handle author as object in package.json
jantimon_favicons-webpack-plugin
train
js
56a8abb3853d144dca1bdd5faa20d462fbed5d4b
diff --git a/anyconfig/backends.py b/anyconfig/backends.py index <HASH>..<HASH> 100644 --- a/anyconfig/backends.py +++ b/anyconfig/backends.py @@ -47,23 +47,11 @@ except ImportError: LOGGER.info(_NA_MSG, "ConfigObj module", "its") try: - import anyconfig.backend.msgpack - PARSERS.append(anyconfig.backend.msgpack.Parser) -except ImportError: - LOGGER.info(_NA_MSG, "msgpack module", "MessagePack") - -try: import anyconfig.backend.toml PARSERS.append(anyconfig.backend.toml.Parser) except ImportError: LOGGER.info(_NA_MSG, "toml module", "TOML") -try: - import anyconfig.backend.bson - PARSERS.append(anyconfig.backend.bson.Parser) -except ImportError: - LOGGER.info(_NA_MSG, "bson module in pymongo package", "BSON") - for e in pkg_resources.iter_entry_points("anyconfig_backends"): try: PARSERS.append(e.load())
fix: do not try to load msgpack and bson backend modules removed
ssato_python-anyconfig
train
py
21b65b6efffb4dd5c2c33eb2a71dcd2a3734960c
diff --git a/test/unit/license-test.js b/test/unit/license-test.js index <HASH>..<HASH> 100644 --- a/test/unit/license-test.js +++ b/test/unit/license-test.js @@ -38,7 +38,7 @@ suite('license', () => { `${projectRoot}/LICENSE`, `${spdxLicenseListWithContent[license].licenseText}\n` .replace(/\n/gm, '\n\n') - .replace(/<year>/gm, year) + .replace(/<\s*year\s*>/gm, year) .replace(/<copyright holders>/gm, copyrightHolders) .replace(/<(.+?)>/gm, '') )));
test(license): improved the stability of the token matching
travi_project-scaffolder
train
js
cb787d6c78f28d6fec2c024458bc88bcee078094
diff --git a/packages/ringcentral-widgets/components/CallListV2/index.js b/packages/ringcentral-widgets/components/CallListV2/index.js index <HASH>..<HASH> 100644 --- a/packages/ringcentral-widgets/components/CallListV2/index.js +++ b/packages/ringcentral-widgets/components/CallListV2/index.js @@ -181,6 +181,7 @@ export default class CallListV2 extends React.PureComponent { <div> <List style={{ outline: 'none' }} + containerStyle={{ overflow: 'visible' }} ref={this._list} width={width} height={height} @@ -190,7 +191,7 @@ export default class CallListV2 extends React.PureComponent { rowHeight={this._renderRowHeight} rowRenderer={this._rowRender} noRowsRenderer={this.noRowsRender} - /> + /> </div> ); }
fix(CallListV2): call history multiple match popup clipped (#<I>)
ringcentral_ringcentral-js-widgets
train
js
b3375861347399f296c7d53dd2bc6912b6ddfccc
diff --git a/howdoi/howdoi.py b/howdoi/howdoi.py index <HASH>..<HASH> 100755 --- a/howdoi/howdoi.py +++ b/howdoi/howdoi.py @@ -230,7 +230,7 @@ def _clean_google_link(link): def _extract_links_from_google(query_object): html = query_object.html() - link_pattern = re.compile('<a href="([^"]*)"[^>]*>') + link_pattern = re.compile('<a href="([^"]*stackoverflow\.com/questions[^"]*)"[^>]*>') links = link_pattern.findall(html) links = [_clean_google_link(link) for link in links] return links
fix: make google query extract only stackoverflow links from page
gleitz_howdoi
train
py
4da2fa268d075264c3ec226f71199fc5b204b1df
diff --git a/bin/cli.js b/bin/cli.js index <HASH>..<HASH> 100755 --- a/bin/cli.js +++ b/bin/cli.js @@ -12,7 +12,7 @@ const cli = meow(` $ qgen <template name> [dest] [arguments] [options] ${chalk.bold('Options')} - -d, --directory <dir> Templates directory (defaults to ./gqen-templates) + -d, --directory <dir> Templates directory (defaults to ./qgen-templates) -c, --config <path> Path to the JSON config file (defaults to ./qgen.json) ${chalk.bold('Examples')}
fix(cli): default template folder in help message was wrong
saneef_qgen
train
js
873233a419e694777914973d2bab5e74718638ce
diff --git a/src/bootstrap.js b/src/bootstrap.js index <HASH>..<HASH> 100644 --- a/src/bootstrap.js +++ b/src/bootstrap.js @@ -22,15 +22,14 @@ export default function bootstrap () { } onAnalyticsReady().then(() => { - // add Google Analytics trackers - // we need to add trackers first to be able to track + // we first need to add trackers to be able to track // every other aspect of the application createTrackers() // add exceptions auto tracking exceptionAutoTracking() // add page auto tracking pageAutoTracking() - // track every untracked events + // track every untracked events before analytics was ready untracked() // trigger the plugin `ready` callback ready()
docs(bootstrap): change comments
MatteoGabriele_vue-analytics
train
js
18d8dc363be0e26bcaca59fbeaf4313522cb2258
diff --git a/src/models/File.js b/src/models/File.js index <HASH>..<HASH> 100644 --- a/src/models/File.js +++ b/src/models/File.js @@ -42,6 +42,7 @@ module.exports = function getFileClass(config) { 'controlsData', 'alias', 'uploadType', + 'backgroundColor', ]; static int = [
fix: add backgroundColor to the whitelist
makeomatic_restify-utils
train
js
87982eac7dd66ecfea3e15063af7b251d38f98bf
diff --git a/packages/cozy-client/src/queries/dsl.js b/packages/cozy-client/src/queries/dsl.js index <HASH>..<HASH> 100644 --- a/packages/cozy-client/src/queries/dsl.js +++ b/packages/cozy-client/src/queries/dsl.js @@ -345,10 +345,12 @@ export const Q = doctype => new QueryDefinition({ doctype }) * @returns {boolean} */ export const isAGetByIdQuery = queryDefinition => { + const attributes = Object.values(queryDefinition) + if (attributes.length === 0) return false // 2 attrs because we check if id and doctype are not undefined return ( - Object.values(queryDefinition).filter(attr => attr !== undefined).length === - 2 && queryDefinition.id !== undefined + attributes.filter(attr => attr !== undefined).length === 2 && + queryDefinition.id !== undefined ) } // Mutations
fix: Defensive code. Check if there is attributes
cozy_cozy-client
train
js
6eea94e8d0aff69ecbe82de26b1f4ee0084efc25
diff --git a/core/commands/root.go b/core/commands/root.go index <HASH>..<HASH> 100644 --- a/core/commands/root.go +++ b/core/commands/root.go @@ -52,6 +52,7 @@ TEXT ENCODING COMMANDS ADVANCED COMMANDS daemon Start a long-running daemon process + shutdown Shut down the daemon process resolve Resolve any type of content path name Publish and resolve IPNS names key Create and list IPNS name keypairs
chore(cmd): add shutdown to CLI help
ipfs_go-ipfs
train
go
c553159ad9a83bc18d076d23604bd7ac44b3a7d8
diff --git a/apps/actor-web/js/components/activity/UserProfile.react.js b/apps/actor-web/js/components/activity/UserProfile.react.js index <HASH>..<HASH> 100644 --- a/apps/actor-web/js/components/activity/UserProfile.react.js +++ b/apps/actor-web/js/components/activity/UserProfile.react.js @@ -58,9 +58,9 @@ UserProfile.ContactInfo = React.createClass({ render: function () { var phones = this.props.phones; - var contactInfo = _.map(phones, function(phone) { + var contactInfo = _.map(phones, function(phone, i) { return ( - <li className="row"> + <li key={i} className="row"> <i className="material-icons">call</i> <div className="col-xs"> +{phone.number}
fix(web): fixed react warnings
actorapp_actor-platform
train
js
22bdd4f6ca0d51744fa46b756f680d74842ba64c
diff --git a/biz/webui/cgi-bin/rules/select.js b/biz/webui/cgi-bin/rules/select.js index <HASH>..<HASH> 100644 --- a/biz/webui/cgi-bin/rules/select.js +++ b/biz/webui/cgi-bin/rules/select.js @@ -4,13 +4,14 @@ var rules = require('../../../../lib/rules/util').rules; var TEMP_VALUES_DIR = config.TEMP_VALUES_DIR; var TEMP_NAME_RE = /^\d{1,30}$/; +var MAX_LENGTH = 1024 * 1024 * 5; function writeTempValue(data, callback) { - if (!TEMP_NAME_RE.test(data.key) || typeof data.value !== 'string') { + if (!TEMP_NAME_RE.test(data.key) || !data.value || typeof data.value !== 'string') { return callback(); } var filepath = TEMP_VALUES_DIR + '/' + data.key; - fs.writeFile(filepath, data.value, callback); + fs.writeFile(filepath, data.value.substring(0, MAX_LENGTH), callback); } module.exports = function(req, res) {
feat: write temp value to local file
avwo_whistle
train
js
87d7910ef0ab3fff0cc789741bb57a559db9bd9f
diff --git a/util/field.js b/util/field.js index <HASH>..<HASH> 100644 --- a/util/field.js +++ b/util/field.js @@ -23,9 +23,14 @@ for (var type in TEMPLATES) { } } -export { - TEMPLATES -}; +export {TEMPLATES}; + +export const RESERVED = [ + 'get', + 'set', + 'serialize' +]; + /** * @module util/field.Field FieldDefinition @@ -171,11 +176,18 @@ export function mapToFields (defineMap) { for (var prop in define) { if (define.hasOwnProperty(prop)) { const fType = typeof define[prop].type === 'function' ? define[prop].type.name : define[prop].type; + + // remove reserved properties + const clone = assign({}, define[prop]); + RESERVED.forEach((r) => { + delete clone[r]; + }); + fields.push(assign({}, { name: prop, type: 'string', fieldType: 'text' - }, define[prop], { + }, clone, { type: fType })); }
fix: reserved methods shouldn't be created in fields
roemhildtg_spectre-canjs
train
js
c526fd70f296ef0f3ed9037db2f78d9cb02aadc8
diff --git a/lib/cli.js b/lib/cli.js index <HASH>..<HASH> 100644 --- a/lib/cli.js +++ b/lib/cli.js @@ -12,7 +12,7 @@ function buildCommands() { buildCommandOptions(command, arg); }, (argv) => { - command.exec(argv._, argv); + command.exec(argv._.slice(1), argv); } ); }
fix(cli): don't pass the first argument to gitbook
aqrln_gitbook-commander
train
js
1f52a2a9f433452c15715131ed74433a43d5cfb7
diff --git a/src/server/bundle-renderer/create-bundle-runner.js b/src/server/bundle-renderer/create-bundle-runner.js index <HASH>..<HASH> 100644 --- a/src/server/bundle-renderer/create-bundle-runner.js +++ b/src/server/bundle-renderer/create-bundle-runner.js @@ -130,7 +130,23 @@ export function createBundleRunner (entry, files, basedir, runInNewContext) { if (initialContext._styles) { userContext._styles = deepClone(initialContext._styles) } - resolve(runner(userContext)) + // #6353 after the app is resolved, if the userContext doesn't have a + // styles property, it means the app doesn't have any lifecycle-injected + // styles, so vue-style-loader never defined the styles getter. + // just expose the same styles from the initialContext. + const exposeStylesAndResolve = app => { + if (!userContext.hasOwnProperty('styles')) { + userContext.styles = initialContext.styles + } + resolve(app) + } + + const res = runner(userContext) + if (typeof res.then === 'function') { + res.then(exposeStylesAndResolve) + } else { + exposeStylesAndResolve(res) + } }) } }
fix(ssr): expose context.styles when no lifecycle styles are injected fix #<I>
kaola-fed_megalo
train
js
6b17e5e2a48d00946bdf443d9bfaf8a295b344ec
diff --git a/staging/src/k8s.io/client-go/tools/events/event_broadcaster.go b/staging/src/k8s.io/client-go/tools/events/event_broadcaster.go index <HASH>..<HASH> 100644 --- a/staging/src/k8s.io/client-go/tools/events/event_broadcaster.go +++ b/staging/src/k8s.io/client-go/tools/events/event_broadcaster.go @@ -53,7 +53,6 @@ type eventKey struct { action string reason string reportingController string - reportingInstance string regarding corev1.ObjectReference related corev1.ObjectReference } @@ -264,7 +263,6 @@ func getKey(event *v1beta1.Event) eventKey { action: event.Action, reason: event.Reason, reportingController: event.ReportingController, - reportingInstance: event.ReportingInstance, regarding: event.Regarding, } if event.Related != nil {
fix: remove reportingInstance field in eventKey.
kubernetes_kubernetes
train
go
c3c238339206d680f336cfeed3cc16f522e12bfa
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -63,6 +63,15 @@ require('./lib/rollbar') }, 5000) } + const scheduleRemindersJobData = Buffer.from(JSON.stringify({name: 'schedule-stale-initial-pr-reminders'})) + setInterval(async () => { + try { + await scheduleJob(scheduleRemindersJobData, {priority: 1}) + } catch (e) { + console.log(e) + } + }, 60 * 60 * 1000) + async function consume (job) { const data = JSON.parse(job.content.toString())
feat: schedule initial-pr-reminders every hour
greenkeeperio_greenkeeper
train
js
d77a187e1d3b1e8f71673d68d01c35fcd95cd964
diff --git a/source/rafcon/gui/mygaphas/items/state.py b/source/rafcon/gui/mygaphas/items/state.py index <HASH>..<HASH> 100644 --- a/source/rafcon/gui/mygaphas/items/state.py +++ b/source/rafcon/gui/mygaphas/items/state.py @@ -987,7 +987,6 @@ class NameView(Element): c.move_to(*self.handles()[NW].pos) c.set_source_rgba(*get_col_rgba(gui_config.gtk_colors['STATE_NAME'], font_transparency)) - c.update_layout(layout) c.show_layout(layout) # Copy image surface to current cairo context
refactor(NameView): Remove obsolete call "update_layout" The context is not changed, thus no update is required.
DLR-RM_RAFCON
train
py
a590a34601a767c3636cdc878105499e875f2af9
diff --git a/node-tests/unit/utils/parse-platform-opts-test.js b/node-tests/unit/utils/parse-platform-opts-test.js index <HASH>..<HASH> 100644 --- a/node-tests/unit/utils/parse-platform-opts-test.js +++ b/node-tests/unit/utils/parse-platform-opts-test.js @@ -48,7 +48,7 @@ describe('Parse Platform Options Util', () => { ) expect('codeSignIdentity' in platformOpts) - .to.equal('codeSignIdentity' in platformOpts); + .to.equal(true); }); }); describe('for android', function() { @@ -58,7 +58,7 @@ describe('Parse Platform Options Util', () => { options ) expect('alias' in platformOpts) - .to.equal('alias' in platformOpts); + .to.equal(true); }); }); });
feat(plateformOpts): actually test the value
isleofcode_ember-cordova
train
js
44d2185a6152303a7624176bbe9c013440e59c8b
diff --git a/bin/c8.js b/bin/c8.js index <HASH>..<HASH> 100755 --- a/bin/c8.js +++ b/bin/c8.js @@ -23,8 +23,8 @@ let argv = buildYargs().parse(instrumenterArgs) } else { if (argv.clean) { await promisify(rimraf)(argv.tempDirectory) - await promisify(fs.mkdir)(argv.tempDirectory, { recursive: true }) } + await promisify(fs.mkdir)(argv.tempDirectory, { recursive: true }) process.env.NODE_V8_COVERAGE = argv.tempDirectory foreground(hideInstrumenterArgs(argv), async (done) => {
fix: make tmp directory regardless of clean
bcoe_c8
train
js
930822271ff59d84a7a5951ab8dc36d0544989cf
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100755 --- a/setup.py +++ b/setup.py @@ -22,7 +22,7 @@ from setuptools import find_packages, setup def tag_version(): """Generate version number from Git Tag, e.g. v2.0.0, v2.0.0-1.""" - recent_tag = subprocess.check_output(shlex.split('git describe --tags --long')) + recent_tag = subprocess.check_output(shlex.split('git describe --long')) tag, count, _ = recent_tag.decode().split('-') version = '-'.join([tag, count]) if int(count) else tag return version
fix: Only track annotated Tags See also: #<I>
foremast_foremast
train
py