hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
68e796f8578568300d98d206d94381883a61b03b
|
diff --git a/config/webpack.common.js b/config/webpack.common.js
index <HASH>..<HASH> 100644
--- a/config/webpack.common.js
+++ b/config/webpack.common.js
@@ -14,6 +14,7 @@ const HtmlWebpackPlugin = require('html-webpack-plugin');
const ForkCheckerPlugin = require('awesome-typescript-loader').ForkCheckerPlugin;
const HtmlElementsPlugin = require('./html-elements-plugin');
const AssetsPlugin = require('assets-webpack-plugin');
+const ContextReplacementPlugin = require('webpack/lib/ContextReplacementPlugin');
/*
* Webpack Constants
@@ -222,6 +223,19 @@ module.exports = function(options) {
name: ['polyfills', 'vendor'].reverse()
}),
+ /**
+ * Plugin: ContextReplacementPlugin
+ * Description: Provides context to Angular's use of System.import
+ *
+ * See: https://webpack.github.io/docs/list-of-plugins.html#contextreplacementplugin
+ * See: https://github.com/angular/angular/issues/11580
+ */
+ new ContextReplacementPlugin(
+ // The (\\|\/) piece accounts for path separators in *nix and Windows
+ /angular(\\|\/)core(\\|\/)(esm(\\|\/)src|src)(\\|\/)linker/,
+ helpers.root('src') // location of your src
+ ),
+
/*
* Plugin: CopyWebpackPlugin
* Description: Copy files and directories in webpack.
|
fix: Angular2 dependency warning (#<I>)
* fix: Angular2 RC7 dependency warning
* ~ minor syntactic change
LGTM
* Update webpack.common.js
|
inchingorg_xdata-web
|
train
|
js
|
6722ab8397b6170970ddd378709e54e1c7f56dde
|
diff --git a/packages/author-profile/author-profile-content.js b/packages/author-profile/author-profile-content.js
index <HASH>..<HASH> 100644
--- a/packages/author-profile/author-profile-content.js
+++ b/packages/author-profile/author-profile-content.js
@@ -149,7 +149,7 @@ class AuthorProfileContent extends React.Component {
testID="scroll-view"
accessibilityID="scroll-view"
data={data}
- keyExtractor={item => item.id}
+ keyExtractor={item => `${item.id}`}
renderItem={({ item, index }) => (
<ErrorView>
{({ hasError }) =>
|
fix: Fix the warning on Native devices when viewing Author Profile (#<I>)
|
newsuk_times-components
|
train
|
js
|
6e5bc6699b3df54afa2799c0567edb21250378c9
|
diff --git a/packages/docs/docs/.vuepress/config.js b/packages/docs/docs/.vuepress/config.js
index <HASH>..<HASH> 100644
--- a/packages/docs/docs/.vuepress/config.js
+++ b/packages/docs/docs/.vuepress/config.js
@@ -79,10 +79,10 @@ module.exports = ctx => ({
clientRootMixin: path.resolve(__dirname, 'mixin.js')
})
-function getGuideSidebar (gruopA, groupB) {
+function getGuideSidebar (groupA, groupB) {
return [
{
- title: gruopA,
+ title: groupA,
collapsable: false,
children: [
'',
@@ -107,10 +107,10 @@ function getGuideSidebar (gruopA, groupB) {
]
}
-function getPluginSidebar (gruopA, introductionA) {
+function getPluginSidebar (groupA, introductionA) {
return [
{
- title: gruopA,
+ title: groupA,
collapsable: false,
children: [
['', introductionA],
@@ -125,10 +125,10 @@ function getPluginSidebar (gruopA, introductionA) {
]
}
-function getThemeSidebar (gruopA, introductionA) {
+function getThemeSidebar (groupA, introductionA) {
return [
{
- title: gruopA,
+ title: groupA,
collapsable: false,
children: [
['', introductionA],
|
chore: fix typo (close: #<I>)(#<I>)
|
vuejs_vuepress
|
train
|
js
|
586684228b0314ff2c22c1298fbc225f571870fe
|
diff --git a/src/zoid/buttons/util.js b/src/zoid/buttons/util.js
index <HASH>..<HASH> 100644
--- a/src/zoid/buttons/util.js
+++ b/src/zoid/buttons/util.js
@@ -73,14 +73,14 @@ export function createVenmoExperiment() : ?Experiment {
}
if (isIos() && isSafari()) {
- return createExperiment('enable_venmo_ios', 90);
+ return createExperiment('enable_venmo_ios', 100);
}
if (isAndroid() && isChrome()) {
- return createExperiment('enable_venmo_android', 90);
+ return createExperiment('enable_venmo_android', 100);
}
} else {
- return createExperiment('enable_venmo_desktop', 90);
+ return createExperiment('enable_venmo_desktop', 100);
}
}
|
chore: ramp venmo experiment to <I> percent (#<I>)
|
paypal_paypal-checkout-components
|
train
|
js
|
998eac5c04f7c6844d53eba5255426b877f365bc
|
diff --git a/test/collections/Model-test.js b/test/collections/Model-test.js
index <HASH>..<HASH> 100644
--- a/test/collections/Model-test.js
+++ b/test/collections/Model-test.js
@@ -122,4 +122,13 @@ describe('collections/Model', () => {
});
});
+ describe('removeReducer with key type: Literal', () => {
+ it('normal', () => {
+ const root = j(`({reducers:{"a":1,b:2}})`);
+ root.find(j.ObjectExpression).at(0).removeReducer('a');
+ expect(root.toSource()).toEqual(`({reducers:{
+ b:2
+}})`);
+ });
+ });
});
|
test: removeReducer with key type: Literal
|
dvajs_dva-ast
|
train
|
js
|
61d38efe9316d529df5c4b4bea89d14925b90c62
|
diff --git a/Model/Api/CategoriesApi.php b/Model/Api/CategoriesApi.php
index <HASH>..<HASH> 100644
--- a/Model/Api/CategoriesApi.php
+++ b/Model/Api/CategoriesApi.php
@@ -195,7 +195,7 @@ class CategoriesApi implements CategoriesApiInterface
{
$this->categoryCollection = $this->categoryCollectionFactory->create();
- $this->linkField = 'entity_id';//$this->metadataPool->getMetadata(CategoryInterface::class)->getLinkField();
+ $this->linkField = 'entity_id';
return $this;
}
diff --git a/Model/Api/ProductsApi.php b/Model/Api/ProductsApi.php
index <HASH>..<HASH> 100644
--- a/Model/Api/ProductsApi.php
+++ b/Model/Api/ProductsApi.php
@@ -320,7 +320,7 @@ class ProductsApi implements ProductsApiInterface
{
$this->productCollection = $this->productCollectionFactory->create();
- $this->linkField = 'entity_id';//$this->metadataPool->getMetadata(ProductInterface::class)->getLinkField();
+ $this->linkField = 'entity_id';
return $this;
}
|
chore(code-style): remove comments MAGENTO-OPS
|
emartech_magento2-extension
|
train
|
php,php
|
bd685cae676a7d2e1fef3adcdc77e2aff91e693e
|
diff --git a/util/random_test.go b/util/random_test.go
index <HASH>..<HASH> 100644
--- a/util/random_test.go
+++ b/util/random_test.go
@@ -45,7 +45,7 @@ func (s *testMiscSuite) TestRand(c *C) {
}
}
fmt.Println(sum)
- c.Assert(sum < 6, IsTrue)
+ c.Assert(sum < 24, IsTrue)
}
func BenchmarkFastRand(b *testing.B) {
|
test: make rand test stable (#<I>)
|
pingcap_tidb
|
train
|
go
|
caddba93579d3ccd4c0f6990aa0c3a7e3eb70a26
|
diff --git a/generators/templates/apiroute/name.controller.js b/generators/templates/apiroute/name.controller.js
index <HASH>..<HASH> 100644
--- a/generators/templates/apiroute/name.controller.js
+++ b/generators/templates/apiroute/name.controller.js
@@ -10,7 +10,7 @@
* add <%= classedName %>Controller dependencies to inject
* @param {Service} <%= modelName %>Definition The model definition of <%= modelName %> resource
*/
- SensorController.$inject = ['<%= modelName %>Definition'];
+ <%= classedName %>Controller.$inject = ['<%= modelName %>Definition'];
/**
* <%= classedName %>Controller constructor. Main controller for the <%= scriptAppName %>.<%= moduleName %>
|
fix(apiroute): classedNameController not SensorController
|
michaelkrone_generator-material-app
|
train
|
js
|
494e689c5b02bfd7a0b07322d77c741ca88ca201
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -37,10 +37,7 @@ class ErrorOverlayPlugin {
function adjustEntry(entry, enableDevServer, sockOptions) {
if (typeof entry === 'string') {
- throw new Error(
- `We currently do not inject our entry code into single-file anonymous entries.
-Please use a multi-main (array) or object-form \`entry\` setting for now.`,
- )
+ entry = [entry]; // for anonymous single entry points
}
if (Array.isArray(entry)) {
|
feat: support single string entry (#<I>)
|
smooth-code_error-overlay-webpack-plugin
|
train
|
js
|
22a65966a7de20738d546c611694f5159f90180a
|
diff --git a/src/Leevel/Cache/Redis/PhpRedis.php b/src/Leevel/Cache/Redis/PhpRedis.php
index <HASH>..<HASH> 100644
--- a/src/Leevel/Cache/Redis/PhpRedis.php
+++ b/src/Leevel/Cache/Redis/PhpRedis.php
@@ -71,7 +71,6 @@ class PhpRedis implements IRedis
}
$this->option = array_merge($this->option, $option);
-
$this->handle = $this->createRedis();
$this->handle->{$this->option['persistent'] ? 'pconnect' : 'connect'}(
|
style(phpredis): code poem
|
hunzhiwange_framework
|
train
|
php
|
ec15a0377cb8cedf51541fa8e2f54ee777263a89
|
diff --git a/test/cucumber-runner.test.js b/test/cucumber-runner.test.js
index <HASH>..<HASH> 100644
--- a/test/cucumber-runner.test.js
+++ b/test/cucumber-runner.test.js
@@ -37,7 +37,7 @@ describe('Cucumber runner', () => {
it('should handle multi feature tests', () => {
return testCaseFactory
- .create('CucumberMultiFeatureTest')
+ .create('cucumberMultiFeatureTest')
.feature('addition')
.scenario('small numbers')
.given('User is on the simple calculator page', function () {
diff --git a/test/test-case-factory.js b/test/test-case-factory.js
index <HASH>..<HASH> 100644
--- a/test/test-case-factory.js
+++ b/test/test-case-factory.js
@@ -225,7 +225,8 @@ class TestCaseFactory {
_forkChild (runnerPath, args) {
return new Promise((resolve, reject) => {
console.log('Executing > ', runnerPath, args.join(' '))
- const command = this._cover(runnerPath, args)
+ // const command = this._cover(runnerPath, args)
+ const command = {path: runnerPath, args}
const child = fork(command.path, command.args, {
stdio: [0, 'pipe', 'pipe', 'ipc'],
cwd: this.testCasePath
|
chore(build): try to fix the travis build
|
mucsi96_nightwatch-cucumber
|
train
|
js,js
|
32209ee624cff0b069db395193f48e89d95c8a29
|
diff --git a/codegen/src/main/java/io/sundr/codegen/DefinitionRepository.java b/codegen/src/main/java/io/sundr/codegen/DefinitionRepository.java
index <HASH>..<HASH> 100644
--- a/codegen/src/main/java/io/sundr/codegen/DefinitionRepository.java
+++ b/codegen/src/main/java/io/sundr/codegen/DefinitionRepository.java
@@ -27,6 +27,7 @@ import java.util.Map;
import java.util.Set;
import java.util.concurrent.ConcurrentHashMap;
import java.util.concurrent.ConcurrentMap;
+import java.util.function.Supplier;
import io.sundr.codegen.model.AttributeKey;
import io.sundr.codegen.model.ClassRef;
@@ -55,6 +56,13 @@ public class DefinitionRepository {
return INSTANCE;
}
+ public TypeDef registerIfAbsent(String fqcn, Supplier<TypeDef> definition) {
+ if (definitions.containsKey(fqcn)) {
+ return definitions.get(fqcn);
+ }
+ return definitions.putIfAbsent(fqcn, definition.get());
+ }
+
public TypeDef registerIfAbsent(TypeDef definition) {
if (definition != null) {
definitions.putIfAbsent(definition.getFullyQualifiedName(), definition);
|
feat: allow registering defs using a Supplier
|
sundrio_sundrio
|
train
|
java
|
9352fe5c2b33a8152be48c40c179bb2483a43efe
|
diff --git a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js
+++ b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js
@@ -13,9 +13,9 @@ export default {
defaults: {
name: process.title || inBrowser && 'browser' || 'javascript',
deviceType: 'WEB',
- model: 'modelx',
- localizedModel: 'web',
- systemName: 'SDK_SYSTEM',
+ model: 'js_sdk',
+ localizedModel: 'js_sdk',
+ systemName: 'JS_SDK',
systemVersion: '1.0.0'
},
enableInactivityEnforcement: false,
|
fix: fix review comments for config
|
webex_spark-js-sdk
|
train
|
js
|
12b7f1e6c252a0f7cfc1b45b8f56b9945f7660f6
|
diff --git a/src/Jobs/Character/PublicCorporationHistory.php b/src/Jobs/Character/PublicCorporationHistory.php
index <HASH>..<HASH> 100644
--- a/src/Jobs/Character/PublicCorporationHistory.php
+++ b/src/Jobs/Character/PublicCorporationHistory.php
@@ -3,7 +3,7 @@
/*
* This file is part of SeAT
*
- * Copyright (C) 2015, 2016, 2017, 2018 Leon Jacobs
+ * Copyright (C) 2015, 2016, 2017, 2018, 2019 Leon Jacobs
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
diff --git a/src/Jobs/Character/PublicInfo.php b/src/Jobs/Character/PublicInfo.php
index <HASH>..<HASH> 100644
--- a/src/Jobs/Character/PublicInfo.php
+++ b/src/Jobs/Character/PublicInfo.php
@@ -3,7 +3,7 @@
/*
* This file is part of SeAT
*
- * Copyright (C) 2015, 2016, 2017, 2018 Leon Jacobs
+ * Copyright (C) 2015, 2016, 2017, 2018, 2019 Leon Jacobs
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
|
chore(licence): Update licence header to include <I>
|
eveseat_eveapi
|
train
|
php,php
|
f16e157727ae4405a4c8ec5da1cf4be98e744baa
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -23,7 +23,7 @@ function generateOutput(parsed, help) {
help = help || {};
const command = help['@command'] || process.argv[1].replace(process.cwd() + '/', '');
const descBuffer = 2;
- let lines = '';
+ let lines = '\n';
let options = [];
let descriptions = [];
let maxLength = 0;
@@ -101,7 +101,8 @@ function generateOutput(parsed, help) {
lines +
options
.map((o, i) => padLine(' ' + o, maxLength + 2 + descBuffer) + descriptions[i])
- .join('\n');
+ .join('\n') +
+ '\n';
return lines;
}
|
fix: newline around the help output
|
w33ble_mri-help
|
train
|
js
|
a0b390cfe5f85a9724deac35c0bb4fcad4dffed0
|
diff --git a/internal/service/backup/report_plan.go b/internal/service/backup/report_plan.go
index <HASH>..<HASH> 100644
--- a/internal/service/backup/report_plan.go
+++ b/internal/service/backup/report_plan.go
@@ -22,6 +22,7 @@ func ResourceReportPlan() *schema.Resource {
Create: resourceReportPlanCreate,
Read: resourceReportPlanRead,
Update: resourceReportPlanUpdate,
+ Delete: resourceReportPlanDelete,
Importer: &schema.ResourceImporter{
State: schema.ImportStatePassthrough,
},
@@ -234,6 +235,21 @@ func resourceReportPlanUpdate(d *schema.ResourceData, meta interface{}) error {
return resourceReportPlanRead(d, meta)
}
+func resourceReportPlanDelete(d *schema.ResourceData, meta interface{}) error {
+ conn := meta.(*conns.AWSClient).BackupConn
+
+ input := &backup.DeleteReportPlanInput{
+ ReportPlanName: aws.String(d.Id()),
+ }
+
+ _, err := conn.DeleteReportPlan(input)
+ if err != nil {
+ return fmt.Errorf("error deleting Backup Report Plan: %s", err)
+ }
+
+ return nil
+}
+
func expandReportDeliveryChannel(reportDeliveryChannel []interface{}) *backup.ReportDeliveryChannel {
if len(reportDeliveryChannel) == 0 || reportDeliveryChannel[0] == nil {
return nil
|
feat(backup): add ReportPlan delete
|
terraform-providers_terraform-provider-aws
|
train
|
go
|
50ed4087aafc932bb261209e0c174ac967d0e624
|
diff --git a/lib/extract-stream.js b/lib/extract-stream.js
index <HASH>..<HASH> 100644
--- a/lib/extract-stream.js
+++ b/lib/extract-stream.js
@@ -16,7 +16,7 @@ function pkgJsonTransform (spec, opts) {
if (entry.path === 'package.json') {
const transformed = new Minipass()
let str = ''
- entry.on('end', () => {
+ entry.once('end', () => {
const replaced = str.replace(
/}\s*$/,
`\n,"_resolved": ${
|
fix(extract-stream): address "write after end" issue (#<I>)
Fixes: #<I>
|
zkat_pacote
|
train
|
js
|
b29e155e0f8559cbea77c5c77eef0b152ad36a66
|
diff --git a/test/lib/webpack-utils/create-base-config.js b/test/lib/webpack-utils/create-base-config.js
index <HASH>..<HASH> 100644
--- a/test/lib/webpack-utils/create-base-config.js
+++ b/test/lib/webpack-utils/create-base-config.js
@@ -20,6 +20,7 @@ module.exports = (config = {}, options = {}) => {
},
devtool: false,
+ mode: 'development',
resolve: {
alias: {
|
test: use mode=development in base webpack config
|
JetBrains_svg-mixer
|
train
|
js
|
efdaf1b9249e53940baa1feda3bfd68ab1be02e4
|
diff --git a/tasks/usemin.js b/tasks/usemin.js
index <HASH>..<HASH> 100644
--- a/tasks/usemin.js
+++ b/tasks/usemin.js
@@ -205,5 +205,8 @@ module.exports = function (grunt) {
grunt.verbose.subhead(' ' + name + ':')
.writeln(' ' + util.inspect(grunt.config(name), false, 4, true, true));
});
+
+ // only displayed if not in verbose mode
+ grunt.verbose.or.writeln('Configuration changed for', grunt.log.wordlist(cfgNames));
});
};
|
fix(verbosity): add some ouput for useminPrepare in non verbose mode
Follow the request from @XhmikosR in #<I> in comment:
<URL>
|
yeoman_grunt-usemin
|
train
|
js
|
315533f935ee43099b95de59a7fc3a09b2a558d9
|
diff --git a/Query/Grammars/Grammar.php b/Query/Grammars/Grammar.php
index <HASH>..<HASH> 100755
--- a/Query/Grammars/Grammar.php
+++ b/Query/Grammars/Grammar.php
@@ -249,12 +249,9 @@ class Grammar extends BaseGrammar
protected function whereBasic(Builder $query, $where)
{
$value = $this->parameter($where['value']);
- $operator = $where['operator'];
// @see https://wiki.php.net/rfc/pdo_escape_placeholders
- if (Str::contains(strtolower($operator), '?')) {
- $operator = str_replace('?', '??', $operator);
- }
+ $operator = str_replace('?', '??', $where['operator']);
return $this->wrap($where['column']).' '.$operator.' '.$value;
}
|
fix: rebase on master and only use str_replace
|
illuminate_database
|
train
|
php
|
9f4ee44f1ea2c83a9af13580f31454ec885f38ef
|
diff --git a/packages/bonde-admin/src/mobilizations/widgets/__plugins__/form/components/__form__.js b/packages/bonde-admin/src/mobilizations/widgets/__plugins__/form/components/__form__.js
index <HASH>..<HASH> 100644
--- a/packages/bonde-admin/src/mobilizations/widgets/__plugins__/form/components/__form__.js
+++ b/packages/bonde-admin/src/mobilizations/widgets/__plugins__/form/components/__form__.js
@@ -38,7 +38,7 @@ class Form extends Component {
const fieldsWithValue = widget.settings.fields.map(field => ({
...field,
- value: document.getElementById(`#input-${field.uid}`).value
+ value: document.querySelector(`#input-${field.uid}`).value
}))
const errors = this.validate(fieldsWithValue)
this.setState({ errors })
|
fix(admin): refactor fieldsWithValue form selector
|
nossas_bonde-client
|
train
|
js
|
c2221e16e28457c11d2600478749f5f00da957d8
|
diff --git a/src/library/themes/mapComponentThemes.js b/src/library/themes/mapComponentThemes.js
index <HASH>..<HASH> 100644
--- a/src/library/themes/mapComponentThemes.js
+++ b/src/library/themes/mapComponentThemes.js
@@ -23,8 +23,8 @@ export default function mapComponentThemes(
);
return {
- ...baseTheme,
...sourceThemeWithRenamedKeys,
- ...override.theme
+ ...override.theme,
+ ...baseTheme
};
}
|
fix(themes): Ensure base theme overrides component theme
|
mineral-ui_mineral-ui
|
train
|
js
|
941faef437abb3fe7da1ac74923aa9552190a8ef
|
diff --git a/test/test-misc-client-server.js b/test/test-misc-client-server.js
index <HASH>..<HASH> 100644
--- a/test/test-misc-client-server.js
+++ b/test/test-misc-client-server.js
@@ -1233,7 +1233,7 @@ const setup = setupSimple.bind(undefined, debug);
badServer.listen(0, 'localhost', mustCall(() => {
badServer.unref();
- client.on('error', mustCall((err) => {
+ client.on('error', mustCallAtLeast((err) => {
client.end();
})).on('ready', mustNotCall()).on('close', mustCall(() => {}));
client.connect({
|
test: fix event count expection
|
mscdex_ssh2
|
train
|
js
|
e2ea7a4f90d0295ccea930f8e66835b2c0c858b8
|
diff --git a/app-vite/lib/quasar-config-file.js b/app-vite/lib/quasar-config-file.js
index <HASH>..<HASH> 100644
--- a/app-vite/lib/quasar-config-file.js
+++ b/app-vite/lib/quasar-config-file.js
@@ -304,7 +304,7 @@ class QuasarConfFile {
ssrPwaHtmlFilename: 'offline.html',
manualStoreHydration: false,
manualPostHydrationTrigger: false,
- prodPort: 3000 // gets superseeded in production by an eventual process.env.PORT
+ prodPort: 3000 // gets superseded in production by an eventual process.env.PORT
}, cfg.ssr)
}
|
chore(app-vite): fix typo in a comment (#<I>)
|
quasarframework_quasar
|
train
|
js
|
e8ec70db5b57b930327f9354ee03dd6b3864d6e0
|
diff --git a/src/internalHelpers/test/_isValidColor.test.js b/src/internalHelpers/test/_isValidColor.test.js
index <HASH>..<HASH> 100644
--- a/src/internalHelpers/test/_isValidColor.test.js
+++ b/src/internalHelpers/test/_isValidColor.test.js
@@ -32,5 +32,10 @@ describe('isValidColor', () => {
expect(validations.isRgba('rgba(0,0,0,0)')).toEqual(true)
})
+ it('isRgba should return true when color is rgb(255, 0, 0, .5)', () => {
+ expect(validations.isRgba('rgba(255, 0, 0, .5)')).toEqual(true)
+ })
+
+
})
|
chore(transparentize): Added _isValidColor.test.js isRgba_2
|
styled-components_polished
|
train
|
js
|
ddcb092a4bd51db485019dfb896835a317996939
|
diff --git a/submit.go b/submit.go
index <HASH>..<HASH> 100644
--- a/submit.go
+++ b/submit.go
@@ -141,7 +141,7 @@ func (m *CirconusMetrics) trapCall(payload []byte) (int, error) {
client.CheckRetry = retryPolicy
attempts := -1
- client.RequestLogHook = func(logger *log.Logger, req *http.Request, retryNumber int) {
+ client.RequestLogHook = func(logger retryablehttp.Logger, req *http.Request, retryNumber int) {
attempts = retryNumber
}
|
fix: submit for breaking change in dependency patch release
|
circonus-labs_circonus-gometrics
|
train
|
go
|
6551c8e4a8588d3c8c51551e6fc01d12ce9ad23e
|
diff --git a/lib/util/serial.js b/lib/util/serial.js
index <HASH>..<HASH> 100644
--- a/lib/util/serial.js
+++ b/lib/util/serial.js
@@ -74,11 +74,20 @@ const loaders = (exports.loaders = {
ruleSet = extra.compiler.__hardSource_ruleSet;
if (!ruleSet) {
const RuleSet = require('webpack/lib/RuleSet');
- ruleSet = extra.compiler.__hardSource_ruleSet = new RuleSet(
- extra.compiler.options.module.defaultRules.concat(
- extra.compiler.options.module.rules,
- ),
- );
+ if (extra.compiler.options.module.defaultRules) {
+ // webpack 4
+ ruleSet = extra.compiler.__hardSource_ruleSet = new RuleSet(
+ extra.compiler.options.module.defaultRules.concat(
+ extra.compiler.options.module.rules,
+ ),
+ );
+ } else {
+ // webpack <4
+ ruleSet = extra.compiler.__hardSource_ruleSet = new RuleSet(
+ extra.compiler.options.module.rules ||
+ extra.compiler.options.module.loaders,
+ );
+ }
}
}
return {
|
fix: webpack 3 RuleSet creation (#<I>)
|
mzgoddard_hard-source-webpack-plugin
|
train
|
js
|
5f5dd27228b8b031ad5bfff8aebe4170198c7de2
|
diff --git a/test/Model.spec.js b/test/Model.spec.js
index <HASH>..<HASH> 100644
--- a/test/Model.spec.js
+++ b/test/Model.spec.js
@@ -418,6 +418,18 @@ describe("Model", function() {
done();
});
+ it('cloned instance should retain custom type', function() {
+ function MyModel() {
+ Model.call(this);
+ }
+ MyModel.prototype = new Model();
+ MyModel.prototype.constructor = MyModel;
+ var model = new MyModel();
+ expect(model).to.be.instanceof(MyModel);
+ var clonedModel = model.batch(100);
+ expect(clonedModel).to.be.instanceof(MyModel);
+ });
+
describe('JSON-Graph Specification', function() {
require('./get-core');
|
test(clone): add tests for model._clone retaining type
|
Netflix_falcor
|
train
|
js
|
cac7815a249d8a79b89c2fc5c60b6dc65d230a8c
|
diff --git a/packages/components/bolt-video/plugins/cue-points.js b/packages/components/bolt-video/plugins/cue-points.js
index <HASH>..<HASH> 100644
--- a/packages/components/bolt-video/plugins/cue-points.js
+++ b/packages/components/bolt-video/plugins/cue-points.js
@@ -26,7 +26,10 @@ export function cuePointsPlugin(player, elem) {
player.tt.activeCues[0].startTime,
);
- _render(player.allCuePointData[0]);
+ // only render cue points CTA if the overlay element exists to be rendered into
+ if (elem.overlayElement){
+ _render(player.allCuePointData[0]);
+ }
}
};
|
chore: confirm the video player overlay exists before attempting to render a CTA inside of it
|
bolt-design-system_bolt
|
train
|
js
|
9cdf5966f4fc09d0a5f266492d83ba392252f817
|
diff --git a/packages/mdc-textfield/addon/components/mdc-textfield.js b/packages/mdc-textfield/addon/components/mdc-textfield.js
index <HASH>..<HASH> 100644
--- a/packages/mdc-textfield/addon/components/mdc-textfield.js
+++ b/packages/mdc-textfield/addon/components/mdc-textfield.js
@@ -20,8 +20,7 @@ export default Component.extend (TextSupport, {
'styleClassName',
'leadingIcon:mdc-text-field--with-leading-icon',
'trailingIcon:mdc-text-field--with-trailing-icon',
- 'noLabel:mdc-text-field--no-label',
- 'dense:mdc-text-field--dense'
+ 'noLabel:mdc-text-field--no-label'
],
// Set the style for the text field. The default style comes from the configurator.
|
fix: reverted last change because dense was supported
|
onehilltech_ember-cli-mdc
|
train
|
js
|
099aba3da8224a6beae2887b290b2b0e8952a797
|
diff --git a/cmd/kitgen/ast_helpers.go b/cmd/kitgen/ast_helpers.go
index <HASH>..<HASH> 100644
--- a/cmd/kitgen/ast_helpers.go
+++ b/cmd/kitgen/ast_helpers.go
@@ -5,6 +5,7 @@ import (
"go/ast"
"go/parser"
"go/token"
+ "path/filepath"
"strings"
"unicode"
)
@@ -204,5 +205,5 @@ func importFor(is *ast.ImportSpec) *ast.GenDecl {
}
func importSpec(path string) *ast.ImportSpec {
- return &ast.ImportSpec{Path: &ast.BasicLit{Kind: token.STRING, Value: `"` + path + `"`}}
+ return &ast.ImportSpec{Path: &ast.BasicLit{Kind: token.STRING, Value: `"` + filepath.ToSlash(path) + `"`}}
}
|
fix(kitgen): normalize backSlashes in path (#<I>)
add filepath.ToSlash() to convert backSlashes to forward slashes in path
fixes: #<I>
|
go-kit_kit
|
train
|
go
|
d07af90db53c5859774e609b73e924c0a6fbe0e5
|
diff --git a/lib/readstream.js b/lib/readstream.js
index <HASH>..<HASH> 100644
--- a/lib/readstream.js
+++ b/lib/readstream.js
@@ -21,7 +21,7 @@ function ReadStream( image, options ) {
return new ReadStream( image, options )
}
- Stream.Readable.call( this )
+ Stream.Readable.call( this, options )
this.bytesRead = 0
this.bytesWritten = 0
|
fix(readstream): Fix passing on readable stream options
|
jhermsmeier_node-udif
|
train
|
js
|
d35d4cec3eba112ffe3ea03e665e1fcd1bdf9a94
|
diff --git a/utilities.go b/utilities.go
index <HASH>..<HASH> 100644
--- a/utilities.go
+++ b/utilities.go
@@ -59,16 +59,13 @@ func nodeName(node *html.Node) string {
}
// Render renders the html of the first element from selector and writes it to the writer.
-// It behaves similar to OuterHtml but takes io.Writer as input.
+// // It behaves the same as OuterHtml but writes to w instead of returning the string.
func Render(w io.Writer, s *Selection) error {
if s.Length() == 0 {
return nil
}
n := s.Get(0)
- if err := html.Render(w, n); err != nil {
- return err
- }
- return nil
+ return html.Render(w, n)
}
// OuterHtml returns the outer HTML rendering of the first item in
|
fix(doc): update docs for accurate representation of function
|
PuerkitoBio_goquery
|
train
|
go
|
12b48b7cbb74b649d523fea40237b3cace66fff8
|
diff --git a/src/stores/GuildMemberRoleStore.js b/src/stores/GuildMemberRoleStore.js
index <HASH>..<HASH> 100644
--- a/src/stores/GuildMemberRoleStore.js
+++ b/src/stores/GuildMemberRoleStore.js
@@ -23,7 +23,7 @@ class GuildMemberRoleStore extends Collection {
* @readonly
*/
get _filtered() {
- const everyone = this.guild.defaultRole;
+ const everyone = this.guild.roles.everyone;
return this.guild.roles.filter(role => this.member._roles.includes(role.id)).set(everyone.id, everyone);
}
|
fix(GuildMemberRoleStore): correctly reference the everyone role (#<I>)
|
discordjs_discord.js
|
train
|
js
|
39bee7935a3a0307207619eb57857bc4cdaf600a
|
diff --git a/packages/react/src/components/Modal/next/Modal.stories.js b/packages/react/src/components/Modal/next/Modal.stories.js
index <HASH>..<HASH> 100644
--- a/packages/react/src/components/Modal/next/Modal.stories.js
+++ b/packages/react/src/components/Modal/next/Modal.stories.js
@@ -127,6 +127,7 @@ export const Default = () => {
<MultiSelect
id="test"
label="Multiselect"
+ titleText="Multiselect"
items={[
{
id: 'downshift-1-item-0',
|
fix(react): add titleText to multiselect in modal story (#<I>)
|
carbon-design-system_carbon-components
|
train
|
js
|
0bc90811644e37863a8b86c674b7ca807636540a
|
diff --git a/lib/bootstrap.js b/lib/bootstrap.js
index <HASH>..<HASH> 100644
--- a/lib/bootstrap.js
+++ b/lib/bootstrap.js
@@ -5,7 +5,7 @@ const cmdArgs = require('command-line-args');
require('./utils/process-log');
const isFlagPresent = (args, flag) => args.find(arg => [flag, `--${flag}`].includes(arg));
-const normalizeFlags = (args, command) => args.slice(2).filter(arg => arg.indexOf('--') < 0 && arg !== command.name && arg !== command.alias);
+const normalizeFlags = (args, cmd) => args.slice(2).filter(arg => arg.indexOf('--') < 0 && arg !== cmd.name && arg !== cmd.alias);
const isCommandUsed = commands =>
commands.find(cmd => {
@@ -20,11 +20,9 @@ async function runCLI(cli, commandIsUsed) {
if (helpFlagExists) {
cli.runHelp();
return;
- }
-
- else if(versionFlagExists) {
- cli.runVersion();
- return;
+ } else if (versionFlagExists) {
+ cli.runVersion();
+ return;
}
if (commandIsUsed) {
|
chore(bootstrap): refactor code (#<I>)
* feat: refactor
* feat: refactor
normalizeFlags method
* feat: tweak
* feat: format code
* fix: argument count
normalizeFlags method
* fix: format code
* fix: revert
* fix: revert
normalizeFlags
|
webpack_webpack-cli
|
train
|
js
|
d49884a994c42a9b8625f6f80fb0a595373cdb26
|
diff --git a/test/run-sequential/perf.test.js b/test/run-sequential/perf.test.js
index <HASH>..<HASH> 100644
--- a/test/run-sequential/perf.test.js
+++ b/test/run-sequential/perf.test.js
@@ -19,7 +19,7 @@ const FIXTURES = [
name: 'jso'
},
{
- threshold: 2700,
+ threshold: 2900,
name: 'dn'
},
{
|
test: increase time budget for perf test
|
pocketjoso_penthouse
|
train
|
js
|
bec6cad003c33fdce945b495cdd9bae7472ca495
|
diff --git a/mapillary_tools/uploader.py b/mapillary_tools/uploader.py
index <HASH>..<HASH> 100644
--- a/mapillary_tools/uploader.py
+++ b/mapillary_tools/uploader.py
@@ -344,7 +344,7 @@ def get_upload_token(mail, pwd):
'''
try:
params = urllib.urlencode({"email": mail, "password": pwd})
- response = urllib.urlopen(LOGIN_URL, params)
+ response = urllib2.urlopen(LOGIN_URL, params)
except:
return None
resp = json.loads(response.read())
|
fix: authentication by using urllib2 instead of urllib
|
mapillary_mapillary_tools
|
train
|
py
|
1ca9e5fb0ef215eb1185f3586d76039ac24a3d00
|
diff --git a/src/neural-network.js b/src/neural-network.js
index <HASH>..<HASH> 100644
--- a/src/neural-network.js
+++ b/src/neural-network.js
@@ -406,7 +406,10 @@ export default class NeuralNetwork {
}
if (this.trainOpts.callback && (status.iterations % this.trainOpts.callbackPeriod === 0)) {
- this.trainOpts.callback(Object.assign(status));
+ this.trainOpts.callback({
+ iterations: status.iterations,
+ error: status.error
+ });
}
return true;
}
@@ -667,7 +670,7 @@ export default class NeuralNetwork {
const gradient = delta * incoming[k];
const changeLow = this.changesLow[layer][node][k] * trainOpts.beta1 + (1 - trainOpts.beta1) * gradient;
const changeHigh = this.changesHigh[layer][node][k] * trainOpts.beta2 + (1 - trainOpts.beta2) * gradient * gradient;
-
+
const momentumCorrection = changeLow / (1 - Math.pow(trainOpts.beta1, this.iterations));
const gradientCorrection = changeHigh / (1 - Math.pow(trainOpts.beta2, this.iterations));
|
fix: Remove needless Object.assign
|
BrainJS_brain.js
|
train
|
js
|
971135dd12e73d70c26b8592c5ec15ac4eeb06af
|
diff --git a/Helper/Utilities.php b/Helper/Utilities.php
index <HASH>..<HASH> 100644
--- a/Helper/Utilities.php
+++ b/Helper/Utilities.php
@@ -73,7 +73,7 @@ class Utilities
// Add the transaction info for order save after
$paymentInfo->setAdditionalInformation(
'transaction_info',
- (array) $data
+ array_intersect_key((array)$data, array_flip(['id']))
);
if ($source['methodId'] == 'checkoutcom_apm') {
|
chore: filter unused data when saving additional payment data
|
checkout_checkout-magento2-plugin
|
train
|
php
|
4fb685373f26866047ad83db771d77263e4ffe10
|
diff --git a/src/geshi.php b/src/geshi.php
index <HASH>..<HASH> 100644
--- a/src/geshi.php
+++ b/src/geshi.php
@@ -1846,7 +1846,7 @@ class GeSHi {
$parts[$k][0] = $open;
$close_i = strpos($code, $close, $i + $open_strlen);
if ($close_i === false) {
- $close_i = $length - 1;
+ $close_i = $length;
} else {
$close_i += strlen($close);
}
|
fix: unterminated Strict Mode Openers caused last char of highlighted string to be outside the strict mode
|
GeSHi_geshi-1.0
|
train
|
php
|
258a5e88ad890f0e2f429d63f8011e8d01c3ebe3
|
diff --git a/packages/pob/lib/utils/package.js b/packages/pob/lib/utils/package.js
index <HASH>..<HASH> 100644
--- a/packages/pob/lib/utils/package.js
+++ b/packages/pob/lib/utils/package.js
@@ -145,7 +145,10 @@ const internalAddDependencies = (pkg, type, dependencies, cleaned, prefix) => {
? `${prefix || ''}${potentialNewVersionCleaned}`
: potentialNewVersion;
try {
- if (
+ if (currentVersion === 'workspace:*') {
+ // the package is in the monorepo
+ return;
+ } else if (
!currentVersion ||
semver.gt(potentialNewVersionCleaned, cleanVersion(currentVersion))
) {
|
feat: support workspace:* in dependencies
|
christophehurpeau_pob-lerna
|
train
|
js
|
be601ec9ad9773c7fe9659905728cf546d327c06
|
diff --git a/test/helpers/constants/images.go b/test/helpers/constants/images.go
index <HASH>..<HASH> 100644
--- a/test/helpers/constants/images.go
+++ b/test/helpers/constants/images.go
@@ -37,7 +37,7 @@ const (
BusyboxImage = "docker.io/library/busybox:1.28.0"
// AlpineCurlImage is the image used for invoking curl with a small base image.
- AlpineCurlImage = "docker.io/byrnedo/alpine-curl:0.1.7"
+ AlpineCurlImage = "docker.io/byrnedo/alpine-curl:0.1.8"
// MemcachedImage is the image used to test memcached in the runtime tests.
MemcacheDImage = "docker.io/library/memcached:1.5.11"
|
test: use alpine-curl <I> for policygen tests
This version is already pre-pulled in the dev VM and is also used for
the connectivity checks.
|
cilium_cilium
|
train
|
go
|
46d2ecd6a36528d0acc525784f44265755ec2d8b
|
diff --git a/actor-apps/app-web/src/app/stores/LoginStore.js b/actor-apps/app-web/src/app/stores/LoginStore.js
index <HASH>..<HASH> 100644
--- a/actor-apps/app-web/src/app/stores/LoginStore.js
+++ b/actor-apps/app-web/src/app/stores/LoginStore.js
@@ -132,9 +132,8 @@ LoginStore.dispatchToken = ActorAppDispatcher.register(function (action) {
break;
case ActionTypes.SET_LOGGED_IN:
myUid = ActorClient.getUid();
- Raven.setUserContext({
- id: myUid
- });
+ Raven.setUserContext({id: myUid});
+ mixpanel.identify(myUid);
mixpanel.track('Successful login');
LoginStore.emitChange();
break;
diff --git a/actor-apps/app-web/src/app/utils/Mixpanel.js b/actor-apps/app-web/src/app/utils/Mixpanel.js
index <HASH>..<HASH> 100644
--- a/actor-apps/app-web/src/app/utils/Mixpanel.js
+++ b/actor-apps/app-web/src/app/utils/Mixpanel.js
@@ -41,4 +41,3 @@ import { Mixpanel } from 'constants/ActorAppConstants';
mixpanel.init(Mixpanel);
export default mixpanel;
-
|
feat(web): integrate mixpanel analytics and add some simple events;
|
actorapp_actor-platform
|
train
|
js,js
|
71243210d5bbc74cd63f6b37020915e5bcbb679f
|
diff --git a/tests/unit/AppTest.php b/tests/unit/AppTest.php
index <HASH>..<HASH> 100644
--- a/tests/unit/AppTest.php
+++ b/tests/unit/AppTest.php
@@ -68,6 +68,37 @@ class AppTest extends BaseUnitTest
$this->assertInstanceOf(App::class, $app);
}
+ public function testExecute()
+ {
+ $config = new Config();
+ $config->routeStorageType = null;
+ $app = new App($config);
+ ob_start();
+ $app->execute();
+ $content = ob_get_clean();
+ $this->assertContains('Route storage not set', $content);
+
+ $config = new Config();
+ $config->routeStorageType = Config::STORAGE_TYPE_DB;
+ $config->dbServer = 'unreacheble.host.local';
+ $config->cache = false;
+ $app = new App($config);
+ ob_start();
+ $app->execute();
+ $content = ob_get_clean();
+ $this->assertContains('DataBase connection error', $content);
+
+ $config = new Config();
+ $config->routeStorageType = Config::STORAGE_TYPE_DB;
+ $config->dbServer = 'localhost';
+ $config->cache = false;
+ $app = new App($config);
+ ob_start();
+ $app->execute();
+ $content = ob_get_clean();
+ $this->assertContains('Unexpected exception', $content);
+ }
+
public function testExecuteWithArray()
{
$this->assertArrayContentContains('<title>Main page</title>');
|
feat: tests to cover some app exceptions
|
enikeishik_ufoframework
|
train
|
php
|
65cf6a7a4fd06a7998651cbad4e9f8da734baf8f
|
diff --git a/test/rules/no-angular-attributes.js b/test/rules/no-angular-attributes.js
index <HASH>..<HASH> 100644
--- a/test/rules/no-angular-attributes.js
+++ b/test/rules/no-angular-attributes.js
@@ -110,6 +110,14 @@ eslintTester.run('no-angular-attributes', rule, {
message: 'Unexpected Angular attribute "data-ng-src" inside a CSS selector'
}
]
+ },
+ {
+ code: 'element(by.css("[ng-reflect-name=email]"));',
+ errors: [
+ {
+ message: 'Unexpected Angular attribute "ng-reflect-name" inside a CSS selector'
+ }
+ ]
}
]
})
|
test(rules): add a test to catch 'ng-reflect-name' inside a CSS selector
|
alecxe_eslint-plugin-protractor
|
train
|
js
|
ff9432ad0a6654fc18103b80348a8fdd3f264e67
|
diff --git a/src/util/pair-checker.js b/src/util/pair-checker.js
index <HASH>..<HASH> 100644
--- a/src/util/pair-checker.js
+++ b/src/util/pair-checker.js
@@ -52,6 +52,8 @@ export function checkPair(context, { left, right }) {
matchParentheses.forEach(({node, index}) => {
report(node, new RuleError(`${left}の対となる${right}が見つかりません。${left}${right}`, index));
});
+ // clear state
+ matchParentheses = [];
}
};
|
fix(util): reset state after failure
close #6
|
textlint-ja_textlint-rule-preset-JTF-style
|
train
|
js
|
ae34492515a391736229918858eac757638c6d0b
|
diff --git a/jscodeshift-scripts/fix-imports.js b/jscodeshift-scripts/fix-imports.js
index <HASH>..<HASH> 100644
--- a/jscodeshift-scripts/fix-imports.js
+++ b/jscodeshift-scripts/fix-imports.js
@@ -18,10 +18,10 @@
* See https://github.com/decaffeinate/decaffeinate/issues/402 for some more
* details on why decaffeinate can't solve this itself.
*/
-import { existsSync, readFileSync } from 'fs';
-import path from 'path';
+const { existsSync, readFileSync } = require('fs');
+const path = require('path');
-export default function (fileInfo, api, options) {
+module.exports = function (fileInfo, api, options) {
let decodedOptions = JSON.parse(new Buffer(options['encoded-options'], 'base64'));
let {convertedFiles, absoluteImportPaths} = decodedOptions;
let j = api.jscodeshift;
@@ -520,7 +520,7 @@ export default function (fileInfo, api, options) {
}
return convertFile();
-}
+};
/**
* Little helper since we don't have Array.prototype.includes.
|
fix: avoid crash in fix-imports by switching to commonjs (#<I>)
It looks like the babel config was set up right when I was testing locally, but
not when running from a real package, so there would be an "unexpected token"
error. The easy (though ironic) fix is to just use commonjs style for the script
itself.
|
decaffeinate_bulk-decaffeinate
|
train
|
js
|
ca28ba96da12ba631e637621a50e015fb1064f22
|
diff --git a/src/services/search-builder.js b/src/services/search-builder.js
index <HASH>..<HASH> 100644
--- a/src/services/search-builder.js
+++ b/src/services/search-builder.js
@@ -110,7 +110,7 @@ function SearchBuilder(model, opts, params, fieldNamesRequested) {
' LIKE ',
lowerIfNecessary(`%${params.search}%`),
);
- pushCondition(condition, columnName);
+ pushCondition(condition, field.field);
} else if (isUUID(DataTypes, primaryKeyType)
&& params.search.match(REGEX_UUID)) {
condition[field.field] = params.search;
@@ -145,7 +145,7 @@ function SearchBuilder(model, opts, params, fieldNamesRequested) {
' LIKE ',
lowerIfNecessary(`%${params.search}%`),
);
- pushCondition(condition, columnName);
+ pushCondition(condition, field.field);
}
} else if (field.type === 'Number') {
let value = Number(params.search);
|
fix: search highlighting not working when the column name contains underscores
|
ForestAdmin_forest-express-sequelize
|
train
|
js
|
73d3b7be2235182de60304632a56230947986e87
|
diff --git a/webapps/grunt/config/copy.js b/webapps/grunt/config/copy.js
index <HASH>..<HASH> 100644
--- a/webapps/grunt/config/copy.js
+++ b/webapps/grunt/config/copy.js
@@ -35,6 +35,14 @@ module.exports = function(config) {
mock: false
},
+ 'process-instance': {
+ mock: false
+ },
+
+ 'authorization': {
+ mock: false
+ },
+
'task': {
mock: false
}
|
refactor(setup): use real services for process-instance and authorization
|
camunda_camunda-bpm-platform
|
train
|
js
|
8d4441a6b4e570f900275ad2a1c4e8ab64fe02e4
|
diff --git a/docgen/conf.py b/docgen/conf.py
index <HASH>..<HASH> 100644
--- a/docgen/conf.py
+++ b/docgen/conf.py
@@ -17,5 +17,5 @@ exclude_patterns = ['_build', 'README.rst']
intersphinx_mapping = {'python': ('http://docs.python.org/2.7', None)}
-html_theme_path = ['../']
+html_theme_path = ['.']
html_theme = 'minimalism'
diff --git a/docgen/docgen.py b/docgen/docgen.py
index <HASH>..<HASH> 100755
--- a/docgen/docgen.py
+++ b/docgen/docgen.py
@@ -292,6 +292,8 @@ Classes
dest_conf = os.path.join(self.prefix, "conf.py")
build_dir = os.path.join(self.prefix, "_build")
shutil.copy("conf.py", dest_conf)
+ theme_dest = os.path.join(self.prefix, "minimalism")
+ shutil.copytree("minimalism", theme_dest)
subprocess.call(["sphinx-build", self.prefix, build_dir])
|
docs: copy the theme in the sphinx env
|
pygobject_pgi
|
train
|
py,py
|
cef0d2bf0758b0c16e35cfd0376e4aa5ad2d137a
|
diff --git a/src/base/utils.js b/src/base/utils.js
index <HASH>..<HASH> 100644
--- a/src/base/utils.js
+++ b/src/base/utils.js
@@ -312,6 +312,32 @@ export class DomRecycler {
DomRecycler.options = { recycleVideo: false }
+export class DoubleTouchEventHandler {
+ constructor(delay = 500) {
+ this.delay = delay
+ this.lastTime = 0
+ this.timer = null
+ }
+
+ handle(touchendEvent, cb) {
+ // Based on http://jsfiddle.net/brettwp/J4djY/
+ let currentTime = new Date().getTime()
+ let tapLength = currentTime - this.lastTime
+ clearTimeout(this.timer)
+
+ if (tapLength < this.delay && tapLength > 0) {
+ cb()
+ touchendEvent.preventDefault()
+ } else {
+ this.timer = setTimeout(() => {
+ clearTimeout(this.timer)
+ }, this.delay)
+ }
+
+ this.lastTime = currentTime
+ }
+}
+
export default {
Config,
Fullscreen,
@@ -329,5 +355,6 @@ export default {
now,
removeArrayItem,
canAutoPlayMedia,
- Media
+ Media,
+ DoubleTouchEventHandler
}
|
feat(utils): add double touch event handler class
|
clappr_clappr
|
train
|
js
|
3467388d90313143fb0b1726aa0eb4ab10510b75
|
diff --git a/chai-jquery.js b/chai-jquery.js
index <HASH>..<HASH> 100644
--- a/chai-jquery.js
+++ b/chai-jquery.js
@@ -230,18 +230,10 @@
);
chai.Assertion.addMethod('focus', function () {
- // workaround for Webkit-based browsers
- // see https://github.com/ariya/phantomjs/issues/10427
- var _jQuery_is = $.fn.is;
- $.fn.is = function(s) {
- if (s === ':focus') {
- return this.get(0) === document.activeElement;
- }
- return _jQuery_is.apply(this, arguments);
- };
-
this.assert(
- flag(this, 'object').is(':focus')
+ // Can't use `$().is(':focus')` because of certain webkit browsers
+ // see https://github.com/ariya/phantomjs/issues/10427
+ flag(this, 'object').get(0) === document.activeElement
, 'expected #{this} to have focus'
, 'expected #{this} not to have focus');
});
|
fix: edit focus assertion to avoid monkey-patching jquery
|
chaijs_chai-jquery
|
train
|
js
|
997d26e2f6e7ff2e69274af14a0abb89d9c02377
|
diff --git a/node_debug_demon/preload.js b/node_debug_demon/preload.js
index <HASH>..<HASH> 100644
--- a/node_debug_demon/preload.js
+++ b/node_debug_demon/preload.js
@@ -40,7 +40,7 @@ try {
const commandLineAPIDebug = debug;
process.binding('inspector').callAndPauseOnStart = (fn, receiver, ...args) => {
commandLineAPIDebug(fn);
- fn.apply(receiver, args);
+ return fn.apply(receiver, args);
};
}
wait = false;
|
fix: callAndPauseOnStart wrapped function result (#<I>)
This patch ensures the wrapped CJS module result is forwarded.
|
GoogleChromeLabs_ndb
|
train
|
js
|
46ca52d56de842b25184db0334bff482e39977a1
|
diff --git a/ui/src/components/dialog/QDialog.js b/ui/src/components/dialog/QDialog.js
index <HASH>..<HASH> 100644
--- a/ui/src/components/dialog/QDialog.js
+++ b/ui/src/components/dialog/QDialog.js
@@ -354,7 +354,7 @@ export default defineComponent({
? h('div', {
class: 'q-dialog__backdrop fixed-full',
'aria-hidden': 'true',
- onClick: onBackdropClick
+ onMousedown: onBackdropClick
})
: null
)),
|
fix(QDialog): correctly coordinate QDialog + QMenu events so that clicking on backdrop with opened QMenu does not also close the QDialog
|
quasarframework_quasar
|
train
|
js
|
3d0efd742d1a036b54c95ebe3c7081fa351bd212
|
diff --git a/@pob/repo-config/createLintStagedConfig.js b/@pob/repo-config/createLintStagedConfig.js
index <HASH>..<HASH> 100644
--- a/@pob/repo-config/createLintStagedConfig.js
+++ b/@pob/repo-config/createLintStagedConfig.js
@@ -27,7 +27,7 @@ module.exports = function createLintStagedConfig() {
}}`]: (filenames) => [
'yarn --prefer-offline',
'yarn-deduplicate',
- 'git add',
+ 'git add yarn.lock',
],
[`{.eslintrc.json,package.json${
workspaces
|
fix(repo-config): add yarn.lock
|
christophehurpeau_pob-lerna
|
train
|
js
|
ea66a7e3ec6eabcc439b96acb21e2a25be2e35e5
|
diff --git a/packages/webpack-cli/lib/webpack-cli.js b/packages/webpack-cli/lib/webpack-cli.js
index <HASH>..<HASH> 100644
--- a/packages/webpack-cli/lib/webpack-cli.js
+++ b/packages/webpack-cli/lib/webpack-cli.js
@@ -31,6 +31,8 @@ class WebpackCLI {
* @returns {void}
*/
_handleCoreFlags(parsedArgs) {
+ const coreCliHelper = require('webpack').cli;
+ if (!coreCliHelper) return;
const coreConfig = Object.keys(parsedArgs)
.filter((arg) => {
return coreFlagMap.has(toKebabCase(arg));
@@ -39,7 +41,6 @@ class WebpackCLI {
acc[toKebabCase(cur)] = parsedArgs[cur];
return acc;
}, {});
- const coreCliHelper = require('webpack').cli;
const coreCliArgs = coreCliHelper.getArguments();
// Merge the core flag config with the compilerConfiguration
coreCliHelper.processArguments(coreCliArgs, this.compilerConfiguration, coreConfig);
|
fix: handle core flags for webpack 4 (#<I>)
|
webpack_webpack-cli
|
train
|
js
|
a340dae52cd1955ff6d6a6a3dd6799cb23bd8e32
|
diff --git a/lib/config.js b/lib/config.js
index <HASH>..<HASH> 100644
--- a/lib/config.js
+++ b/lib/config.js
@@ -357,7 +357,6 @@ var CONFIG_SYNTAX_HELP = ' module.exports = function(config) {\n' +
var parseConfig = function (configFilePath, cliOptions) {
var configModule
if (configFilePath) {
- log.debug('Loading config %s', configFilePath)
try {
configModule = require(configFilePath)
@@ -389,7 +388,6 @@ var parseConfig = function (configFilePath, cliOptions) {
return process.exit(1)
}
} else {
- log.debug('No config file specified.')
// if no config file path is passed, we define a dummy config module.
configModule = function () {}
}
@@ -433,6 +431,12 @@ var parseConfig = function (configFilePath, cliOptions) {
// configure the logger as soon as we can
logger.setup(config.logLevel, config.colors, config.loggers)
+ if (configFilePath) {
+ log.debug('Loading config %s', configFilePath)
+ } else {
+ log.debug('No config file specified.')
+ }
+
return normalizeConfig(config, configFilePath)
}
|
fix(config): Call debug log methods after setting the loglevel based upon config/cli-options.
|
karma-runner_karma
|
train
|
js
|
9cf5dfda83ff2234679f31dcc2c0314c78846cfe
|
diff --git a/test/test_cloudvolume.py b/test/test_cloudvolume.py
index <HASH>..<HASH> 100644
--- a/test/test_cloudvolume.py
+++ b/test/test_cloudvolume.py
@@ -11,7 +11,7 @@ import sys
from cloudvolume import exceptions
from cloudvolume.exceptions import AlignmentError
from cloudvolume import CloudVolume, chunks
-from cloudvolume.lib import Bbox, Vec, yellow
+from cloudvolume.lib import Bbox, Vec, yellow, mkdir
import cloudvolume.sharedmemory as shm
from layer_harness import (
TEST_NUMBER,
@@ -296,6 +296,22 @@ def test_autocropped_read():
assert img.shape == (0,0,0,1)
assert np.all(img == data[0:0, 0:0, 0:0])
+def test_download_upload_file():
+ for green in (False, True):
+ print("green:", green)
+ delete_layer()
+ cv, _ = create_layer(size=(50,50,50,1), offset=(0,0,0))
+ cv.green_threads = green
+
+ mkdir('/tmp/file/')
+
+ cv.download_to_file('/tmp/file/test', cv.bounds)
+ cv2 = CloudVolume('file:///tmp/file/test2/', info=cv.info)
+ cv2.upload_from_file('/tmp/file/test', cv.bounds)
+
+ assert np.all(cv2[:] == cv[:])
+ shutil.rmtree('/tmp/file/')
+
def test_write():
for green in (False, True):
print("green:", green)
|
test: basic test of upload/download to/from files
|
seung-lab_cloud-volume
|
train
|
py
|
cff196fdc6b3b09b9fa4c0a9b7e3a3abb824c3d4
|
diff --git a/src/components/Tab/Tab.js b/src/components/Tab/Tab.js
index <HASH>..<HASH> 100644
--- a/src/components/Tab/Tab.js
+++ b/src/components/Tab/Tab.js
@@ -74,6 +74,7 @@ export default class Tab extends React.Component {
href,
role: 'tab',
tabIndex,
+ ['aria-selected']: selected,
ref: e => {
this.tabAnchor = e;
},
diff --git a/src/components/Tabs/Tabs.js b/src/components/Tabs/Tabs.js
index <HASH>..<HASH> 100644
--- a/src/components/Tabs/Tabs.js
+++ b/src/components/Tabs/Tabs.js
@@ -148,6 +148,7 @@ export default class Tabs extends React.Component {
return (
<TabContent
className="tab-content"
+ aria-hidden={!selected}
hidden={!selected}
selected={selected}>
{children}
|
fix(tabs): add a<I>y fixes to tabs (#<I>)
|
carbon-design-system_carbon-components-react
|
train
|
js,js
|
60b8ba6b865ba02428d7926998af72cdaa17ea5d
|
diff --git a/src/structures/GuildEmoji.js b/src/structures/GuildEmoji.js
index <HASH>..<HASH> 100644
--- a/src/structures/GuildEmoji.js
+++ b/src/structures/GuildEmoji.js
@@ -31,6 +31,8 @@ class GuildEmoji extends BaseGuildEmoji {
* @private
*/
Object.defineProperty(this, '_roles', { value: [], writable: true });
+
+ this._patch(data);
}
/**
|
fix(GuildEmoji): Cache restricted roles and author data (#<I>)
|
discordjs_discord.js
|
train
|
js
|
12db23193d4e80f1df01e0c19ec75bfe52fc0175
|
diff --git a/benches/index.js b/benches/index.js
index <HASH>..<HASH> 100644
--- a/benches/index.js
+++ b/benches/index.js
@@ -111,6 +111,12 @@ const benchmarks = [
),
},
{
+ name: "signRecoverable",
+ bench: createBenchmarkFn(fecdsa, (secp256k1, f) =>
+ secp256k1.signRecoverable(f.m, f.d)
+ ),
+ },
+ {
name: "verify",
bench: createBenchmarkFn(fecdsa, (secp256k1, f) =>
secp256k1.verify(f.m, f.Q, f.signature)
|
chore: add signRecoverable() to benchmark tests
|
bitcoinjs_tiny-secp256k1
|
train
|
js
|
fb3e09b381c7357e47a0bf2e675c2780bb74319b
|
diff --git a/packages/core/renderers/bolt-base.js b/packages/core/renderers/bolt-base.js
index <HASH>..<HASH> 100644
--- a/packages/core/renderers/bolt-base.js
+++ b/packages/core/renderers/bolt-base.js
@@ -56,9 +56,10 @@ export function BoltBase(Base = HTMLElement) {
this.setupShadow();
// @todo: rework to disable this extra check here (used for demoing before/after behavior), unless a specific feature flag is used (debug mode?)
- if (!this.closest('.js-disable-extra-slot-check')) {
+ // @todo: Uncommment the following conditional when we have a debug flag or similar solution in place to re-enable test examples.
+ // if (!this.closest('.js-disable-extra-slot-check')) {
this.setupSlots(); // hotfix to ensure heavily nested elements containing text-nodes like <replace-with-children> re-render consistently in browsers that don't natively support custom elements Fixes wwwd8-2678
- }
+ // }
if (hasNativeShadowDomSupport && this.useShadow === true) {
return super.renderRoot || shadow(this);
|
docs: Comment out code needed for before version of button test
|
bolt-design-system_bolt
|
train
|
js
|
48c06460d2d65014a474765718d2a5f5bad8f8e3
|
diff --git a/lib/components/places/SearchBox.js b/lib/components/places/SearchBox.js
index <HASH>..<HASH> 100644
--- a/lib/components/places/SearchBox.js
+++ b/lib/components/places/SearchBox.js
@@ -230,7 +230,9 @@ var SearchBox = (exports.SearchBox = (function(_React$PureComponent) {
var child = this.context[_constants.MAP].controls[
this.props.controlPosition
].removeAt(this.mountControlIndex)
- this.containerElement.appendChild(child)
+ if (child !== undefined) {
+ this.containerElement.appendChild(child)
+ }
}
},
},
|
chore(lib): compile from src with `babel`
|
tomchentw_react-google-maps
|
train
|
js
|
297c80e6463fbb7e8f195e4d0256e98aa26c3a00
|
diff --git a/src/components/VSelect/VSelect.js b/src/components/VSelect/VSelect.js
index <HASH>..<HASH> 100644
--- a/src/components/VSelect/VSelect.js
+++ b/src/components/VSelect/VSelect.js
@@ -142,9 +142,24 @@ export default {
},
args: {
closeConditional: e => {
- return !this.$refs.menu.$refs.content.contains(e.target) &&
- !this.$el.contains(e.target) &&
- e.target !== this.$el
+ return (
+ // Check if the menu is
+ // currently active
+ this.isMenuActive &&
+ // Check if click originates
+ // from within the content
+ (
+ !!this.content &&
+ !this.content.contains(e.target)
+ ) &&
+ // Check if click originates
+ // from within the element
+ (
+ !!this.$el &&
+ !this.$el.contains(e.target) &&
+ e.target !== this.$el
+ )
+ )
}
}
}]
|
fix(v-select): change close conditional
fix close conditional comparison to ensure comparing elements exist
fixes #<I>
|
vuetifyjs_vuetify
|
train
|
js
|
8778cd7f98dab8ba96409c3caae9dc107025b821
|
diff --git a/packages/mip/src/components/mip-fixed.js b/packages/mip/src/components/mip-fixed.js
index <HASH>..<HASH> 100644
--- a/packages/mip/src/components/mip-fixed.js
+++ b/packages/mip/src/components/mip-fixed.js
@@ -14,11 +14,9 @@ class MipFixed extends CustomElement {
return
}
- // only in iOS + iframe
- if (platform.isIos() && viewer.isIframed) {
- // move element to fixedlayer
- viewer.fixedElement.setFixedElement([this.element], true)
- }
+ // only in iOS + iframe need moving element to fixedlayer
+ let shouldMoveToFixedLayer = platform.isIos() && viewer.isIframed
+ viewer.fixedElement.setFixedElement([this.element], shouldMoveToFixedLayer)
}
}
|
fix: move <mip-fixed> to <body> in iOS
|
mipengine_mip2
|
train
|
js
|
47b2cf398d5a55f7190b6c2fff52ddf38af0e106
|
diff --git a/helpers/form/elements/xhtml/class.Calendar.php b/helpers/form/elements/xhtml/class.Calendar.php
index <HASH>..<HASH> 100644
--- a/helpers/form/elements/xhtml/class.Calendar.php
+++ b/helpers/form/elements/xhtml/class.Calendar.php
@@ -65,7 +65,11 @@ class tao_helpers_form_elements_xhtml_Calendar extends tao_helpers_form_elements
{
$returnValue = $this->getRawValue();
- if (! empty($returnValue)) {
+ if (is_numeric($returnValue)) {
+ return (int)$returnValue;
+ }
+
+ if (!empty($returnValue)) {
$tz = new DateTimeZone(common_session_SessionManager::getSession()->getTimeZone());
$dt = new DateTime($returnValue, $tz);
$returnValue = $dt->getTimestamp() . '';
|
fix: support partially initialized form data retrieval
|
oat-sa_tao-core
|
train
|
php
|
1c090f2f823015cd746871b197adf94d576069b3
|
diff --git a/karma.conf.js b/karma.conf.js
index <HASH>..<HASH> 100644
--- a/karma.conf.js
+++ b/karma.conf.js
@@ -44,7 +44,8 @@ module.exports = function(config) {
plugins: []
},
webpackMiddleware: {
- noInfo: true
+ noInfo: true,
+ stats: 'errors-only'
},
coverageReporter: {
dir: 'coverage',
|
chore(karma): make webpack less noisy
|
willsoto_ng-chartist
|
train
|
js
|
9ae82c1192f850f05faa41dd3c31a0a46dceec4a
|
diff --git a/website/pages/en/index.js b/website/pages/en/index.js
index <HASH>..<HASH> 100644
--- a/website/pages/en/index.js
+++ b/website/pages/en/index.js
@@ -82,7 +82,7 @@ class HomeSplash extends React.Component {
<div className="inner">
<ProjectTitle />
<PromoSection>
- <Button href={docUrl('installation.html', language)}><translate>Get Started</translate></Button>
+ <Button href={docUrl('overview.html.html', language)}><translate>Get Started</translate></Button>
<Button href={docUrl('guides/basic/sendasset.html', language)}><translate>Tutorial</translate></Button>
<Button href={docUrl('api/index.html', language)}><translate>API</translate></Button>
<Button href={docUrl('examples/index.html', language)}><translate>Examples</translate></Button>
|
chore(docs): Change get started link to overview (#<I>)
|
CityOfZion_neon-js
|
train
|
js
|
7069bdd3ba997c1fa32744702520848fa67f3ffc
|
diff --git a/spec/support/star_wars/schema.rb b/spec/support/star_wars/schema.rb
index <HASH>..<HASH> 100644
--- a/spec/support/star_wars/schema.rb
+++ b/spec/support/star_wars/schema.rb
@@ -164,7 +164,7 @@ module StarWars
resolve ->(obj, args, ctx) {
all_bases = SequelBase.where(faction_id: obj.id)
if args[:nameIncludes]
- all_bases = all_bases.where("name LIKE ?", "%#{args[:nameIncludes]}%")
+ all_bases = all_bases.where(Sequel.like(:name, "%#{args[:nameIncludes]}%"))
end
all_bases
}
|
fix(spec): Update usage of Sequel in test schema
This change just follows what the error message says, upgrading to the newer syntax.
|
rmosolgo_graphql-ruby
|
train
|
rb
|
85b208bb519b18fb9ac9a593b4e683f1b188da1f
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -199,8 +199,8 @@ Engine.tokenGetAll = function (buffer, options) {
/**
* Extract tokens from the specified buffer.
* > Note that the output tokens are *STRICLY* similar to PHP function `token_get_all`
- * @param {String} buffer
- * @return {String[]} - Each item can be a string or an array with following informations [token_name, text, line_number]
+ * @param {string} buffer
+ * @return {string[]} - Each item can be a string or an array with following informations [token_name, text, line_number]
*/
Engine.prototype.tokenGetAll = function (buffer) {
this.lexer.mode_eval = false;
|
docs: Fixed problem with string being AST's String class.
|
glayzzle_php-parser
|
train
|
js
|
b04b18d07ef77bd2141472714afa24c799ea1dff
|
diff --git a/scripts/commit-lint.js b/scripts/commit-lint.js
index <HASH>..<HASH> 100755
--- a/scripts/commit-lint.js
+++ b/scripts/commit-lint.js
@@ -9,8 +9,9 @@ const gitMessage = require('child_process')
const matchCommit = /(chore|feat|fix|cleanup|docs)\((angular|bazel|core|docs|nextjs|node|react|storybook|testing|repo|misc)\):\s(([a-z0-9:\-\s])+)/g.test(
gitMessage
);
+const matchRevert = /Revert/gi.test(gitMessage);
const matchRelease = /Release/gi.test(gitMessage);
-const exitCode = +!(matchRelease || matchCommit);
+const exitCode = +!(matchRelease || matchRevert || matchCommit);
if (exitCode === 0) {
console.log('Commit ACCEPTED 👌');
|
feat(repo): correctly validate revert commits
|
nrwl_nx
|
train
|
js
|
84b3d5df7896f32cfbc63a51e0c6fdb9a2ddb48c
|
diff --git a/views/cypress/tests/asset-preview.spec.js b/views/cypress/tests/asset-preview.spec.js
index <HASH>..<HASH> 100644
--- a/views/cypress/tests/asset-preview.spec.js
+++ b/views/cypress/tests/asset-preview.spec.js
@@ -112,6 +112,7 @@ describe('Passage Authoring Preview', () => {
cy.wait('@savePassage').its('response.body').its('success').should('eq', true);
});
it('can click on preview, preview is rendered', () => {
+ cy.getSettled(selectors.assetAuthoringPreviewButton).should('not.be.disabled');
cy.get(selectors.assetAuthoringPreviewButton).click();
cy.intercept('GET', '**taoMediaManager/SharedStimulus/get*').as('previewPassage');
cy.wait('@previewPassage');
|
fix: add check preview button after save
|
oat-sa_extension-tao-mediamanager
|
train
|
js
|
f8a4cf1bff4a661a68d0e2330282e3ce125fb108
|
diff --git a/packages/upload-core/upload.js b/packages/upload-core/upload.js
index <HASH>..<HASH> 100644
--- a/packages/upload-core/upload.js
+++ b/packages/upload-core/upload.js
@@ -121,6 +121,10 @@ class Upload {
resume: true,
endpoint: `${this.options.endpoint}/${this.options.bucketId}/`,
chunkSize: this.options.chunkSize,
+ metadata: {
+ filename: file.name,
+ filetype: file.type,
+ },
headers: {
'X-XSRF-TOKEN': this.getToken(),
'X-Availity-Customer-ID': this.options.customerId,
|
feat(upload-core): add file metadata via tus
Add file name and file type to the tus meta data which gets handles special via the tus protocol.
Fixes #<I>
|
Availity_sdk-js
|
train
|
js
|
13511e4d4067ed82d3822cf7a7762b16433b1fed
|
diff --git a/src/Server.js b/src/Server.js
index <HASH>..<HASH> 100644
--- a/src/Server.js
+++ b/src/Server.js
@@ -36,7 +36,7 @@ type ConnectionHook = (client: Client, data?: any) => Promise<any>
* @property {Object} [Server] Alternative constructor for wss
* server.
*/
-type ServerOptions = { Server?: Class<any>, connectionHook?: ConnectionHook }
+type ServerOptions = { Server?: constructor, connectionHook?: ConnectionHook }
type SocketOptions = Object
@@ -47,7 +47,7 @@ type SocketOptions = Object
* @emits Server#error
*/
class Server extends EventEmitter {
- Server: Class<any>
+ Server: constructor
clients: Map<string, Object>
connectionHook: ConnectionHook
socketOptions: Object
|
refactor: fix flow constructors types
|
an-sh_ws-messaging
|
train
|
js
|
fcb0b4bfdd82c5ae59b0cd5624483cba2b7ff2f2
|
diff --git a/src/components/VTabs/VTab.js b/src/components/VTabs/VTab.js
index <HASH>..<HASH> 100644
--- a/src/components/VTabs/VTab.js
+++ b/src/components/VTabs/VTab.js
@@ -47,8 +47,9 @@ export default {
if (typeof to === 'string') return to.replace('#', '')
if (to === Object(to) &&
- to.hasOwnProperty('path')
- ) return to.path
+ (to.hasOwnProperty('name') ||
+ to.hasOwnProperty('path'))
+ ) return to.name || to.path
return this
}
|
fix(v-tabs): updated computed prop
added support for the `name` prop in a `router-link`
fixes #<I>
|
vuetifyjs_vuetify
|
train
|
js
|
b33c23ef2529c8f6c1537bbd70af47a184ea3f76
|
diff --git a/superset/migrations/versions/2022-06-19_16-17_f3afaf1f11f0_add_unique_name_desc_rls.py b/superset/migrations/versions/2022-06-19_16-17_f3afaf1f11f0_add_unique_name_desc_rls.py
index <HASH>..<HASH> 100644
--- a/superset/migrations/versions/2022-06-19_16-17_f3afaf1f11f0_add_unique_name_desc_rls.py
+++ b/superset/migrations/versions/2022-06-19_16-17_f3afaf1f11f0_add_unique_name_desc_rls.py
@@ -17,14 +17,14 @@
"""add_unique_name_desc_rls
Revision ID: f3afaf1f11f0
-Revises: e786798587de
+Revises: e09b4ae78457
Create Date: 2022-06-19 16:17:23.318618
"""
# revision identifiers, used by Alembic.
revision = "f3afaf1f11f0"
-down_revision = "e786798587de"
+down_revision = "e09b4ae78457"
import sqlalchemy as sa
from alembic import op
|
fix: migration revision order (#<I>)
|
apache_incubator-superset
|
train
|
py
|
29848b878429814cc9a2c7348172a9eb4f80d46a
|
diff --git a/packages/scatterplot/src/ScatterPlotCanvas.js b/packages/scatterplot/src/ScatterPlotCanvas.js
index <HASH>..<HASH> 100644
--- a/packages/scatterplot/src/ScatterPlotCanvas.js
+++ b/packages/scatterplot/src/ScatterPlotCanvas.js
@@ -243,7 +243,6 @@ class ScatterPlotCanvas extends Component {
style={{
width: outerWidth,
height: outerHeight,
- cursor: isInteractive ? 'crosshair' : 'normal',
}}
onMouseEnter={this.handleMouseHover(showTooltip, hideTooltip)}
onMouseMove={this.handleMouseHover(showTooltip, hideTooltip)}
|
feat(scatterplot): set pointer as 'normal' not crosshair (#<I>)
* Set pointer as 'normal' not crosshair in ScatterPlot canvas chart
* Remove cursor style prop
|
plouc_nivo
|
train
|
js
|
6879c6f498d54682c16415c351095b6a7e9923a8
|
diff --git a/src/core/services/layout/layout.js b/src/core/services/layout/layout.js
index <HASH>..<HASH> 100644
--- a/src/core/services/layout/layout.js
+++ b/src/core/services/layout/layout.js
@@ -264,7 +264,10 @@
updateFn(getNormalizedAttrValue(className, attrs, ""));
scope.$on("$destroy", function() { unwatch() });
- if (config.removeAttributes) element.removeAttr(className);
+
+ if (config.removeAttributes && (element[0].nodeName != "#comment")) {
+ element.removeAttr(className);
+ }
}
}
|
fix(layouts): removeAttr RTE on comment nodes
some directives (eg ng-messages-include) inject a comment node which will cause errors when trying to use `node.removeAttribute( )`.
Refs #<I>
|
angular_material
|
train
|
js
|
35454e408ac63c6675e96345728f6636037873a4
|
diff --git a/webapps/client/scripts/user/index.js b/webapps/client/scripts/user/index.js
index <HASH>..<HASH> 100644
--- a/webapps/client/scripts/user/index.js
+++ b/webapps/client/scripts/user/index.js
@@ -32,10 +32,8 @@ define([
* Controller used for the /login route
*/
userModule.controller('userLoginCtrl', [
- '$location',
'$modal',
function(
- $location,
$modal
) {
$modal.open({
@@ -48,12 +46,10 @@ define([
* controller to be used for the /logout route
*/
userModule.controller('userLogoutCtrl', [
- '$rootScope',
'$translate',
'AuthenticationService',
'Notifications',
function(
- $rootScope,
$translate,
AuthenticationService,
Notifications
@@ -72,15 +68,11 @@ define([
userModule.controller('userLoginModalFormCtrl', [
'$scope',
- '$rootScope',
- '$location',
'$translate',
'AuthenticationService',
'Notifications',
function(
$scope,
- $rootScope,
- $location,
$translate,
AuthenticationService,
Notifications
|
refactor(misc): remove some un-needed dependencies in user controllers
|
camunda_camunda-bpm-platform
|
train
|
js
|
0df54153a258da0802b3aca5c04f02dc3cdae060
|
diff --git a/lib/stripe/handlers/index.js b/lib/stripe/handlers/index.js
index <HASH>..<HASH> 100644
--- a/lib/stripe/handlers/index.js
+++ b/lib/stripe/handlers/index.js
@@ -55,7 +55,7 @@ module.exports = function (config) {
}
console.log('stripe webhook error');
console.log(event.type);
- console.log(err.stack);
+ console.log(err);
res.send(500, err);
});
|
fix: err is not a real error :-\
|
jsbin_jsbin
|
train
|
js
|
ba28f8ecfc551d4d916beb748d3384951bce3ed0
|
diff --git a/sign.go b/sign.go
index <HASH>..<HASH> 100644
--- a/sign.go
+++ b/sign.go
@@ -123,7 +123,7 @@ func signMessage(pid peer.ID, key crypto.PrivKey, m *pb.Message) error {
pk, _ := pid.ExtractPublicKey()
if pk == nil {
- pubk, err := key.GetPublic().Bytes()
+ pubk, err := crypto.MarshalPublicKey(key.GetPublic())
if err != nil {
return err
}
|
fix: remove deprecated Bytes call (#<I>)
|
libp2p_go-libp2p-pubsub
|
train
|
go
|
b5a86b389169d3e9a8d7c4ecfe80d82c5a72cfe7
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -17,7 +17,7 @@ const polished = {
hiDIPI,
stripUnit,
timingFunctions,
- wordWrap
+ wordWrap,
}
export default polished
@@ -29,5 +29,5 @@ export {
hiDIPI,
stripUnit,
timingFunctions,
- wordWrap
+ wordWrap,
}
diff --git a/src/mixins/clearFix.js b/src/mixins/clearFix.js
index <HASH>..<HASH> 100644
--- a/src/mixins/clearFix.js
+++ b/src/mixins/clearFix.js
@@ -24,14 +24,20 @@
* }
*/
+<<<<<<< HEAD
function clearFix(parent = `&`) {
+=======
+function clearFix(parent: string = '&') {
+>>>>>>> d5c2354... chore(Linting): Fix linting
const pseudoSelector = `${parent}::after`
return {
+ /* eslint-disable comma-dangle */
[pseudoSelector]: {
'clear': 'both',
'content': '',
- 'display': 'table'
+ 'display': 'table',
}
+ /* eslint-enable comma-dangle */
}
=======
// @flow
|
chore(Linting): Fix linting
Fix linting
n/a
|
styled-components_polished
|
train
|
js,js
|
9d12205cb237b5d6bbeb09504730b919342d0aaf
|
diff --git a/master/buildbot/test/unit/test_steps_shell.py b/master/buildbot/test/unit/test_steps_shell.py
index <HASH>..<HASH> 100644
--- a/master/buildbot/test/unit/test_steps_shell.py
+++ b/master/buildbot/test/unit/test_steps_shell.py
@@ -663,14 +663,30 @@ class SetPropertyDeprecation(unittest.TestCase):
)
-class Configure(unittest.TestCase):
+class Configure(steps.BuildStepMixin, TestReactorMixin, unittest.TestCase):
+
+ def setUp(self):
+ self.setUpTestReactor()
+ return self.setUpBuildStep()
+
+ def tearDown(self):
+ return self.tearDownBuildStep()
def test_class_attrs(self):
- # nothing too exciting here, but at least make sure the class is
- # present
step = shell.Configure()
self.assertEqual(step.command, ['./configure'])
+ def test_run(self):
+ self.setupStep(shell.Configure())
+
+ self.expectCommands(
+ ExpectShell(workdir='wkdir',
+ command=["./configure"])
+ + 0
+ )
+ self.expectOutcome(result=SUCCESS)
+ return self.runStep()
+
class WarningCountingShellCommand(steps.BuildStepMixin,
configmixin.ConfigErrorsMixin,
|
test: Add more tests for Configure step
|
buildbot_buildbot
|
train
|
py
|
17c95bef5e7bf246400f6483dfc5aa07aa3db98f
|
diff --git a/assets/js/log.js b/assets/js/log.js
index <HASH>..<HASH> 100644
--- a/assets/js/log.js
+++ b/assets/js/log.js
@@ -236,7 +236,7 @@
img.onload = null;
clearTimeout(timer);
};
- img.onload = preventGC;
+ img.onload = img.onerror = preventGC;
timer = setTimeout(preventGC, 3000);
}
|
refactor: Add img.onerror
|
avwo_whistle
|
train
|
js
|
f1c50fae0545fa76ff8ae198eed8f6d0c36437e4
|
diff --git a/lib/worker.js b/lib/worker.js
index <HASH>..<HASH> 100644
--- a/lib/worker.js
+++ b/lib/worker.js
@@ -2,6 +2,7 @@ const { resolve } = require('path')
const Log = require('gk-log')
const _ = require('lodash')
const Promise = require('bluebird')
+const { performance } = require('perf_hooks')
const env = require('./env')
const rollbar = require('./rollbar')
@@ -53,7 +54,12 @@ module.exports = async function worker (scheduleJob, channel, job) {
return channel.nack(job, false, false)
}
+ let jobStartedAt = 0
try {
+ // start timer for job runtime
+ jobStartedAt = performance.now()
+ performance.mark('start')
+
var newJobs = await jobWorker(data)
} catch (err) {
let level = 'error'
@@ -88,6 +94,11 @@ module.exports = async function worker (scheduleJob, channel, job) {
null,
rollbarPayload
)
+ } finally {
+ const jobFinishedAt = performance.now()
+ const runtimeDuration = jobFinishedAt - jobStartedAt
+
+ statsd.gauge('job_runtime', runtimeDuration, { tag: data.name })
}
statsd.increment(
|
feat(jobs): log job runtime to datadog
we want to have an overview how long each job runs
|
greenkeeperio_greenkeeper
|
train
|
js
|
fc589e4e83e6fb176aca5e42a5b338d0be23fc39
|
diff --git a/.toys/ci.rb b/.toys/ci.rb
index <HASH>..<HASH> 100644
--- a/.toys/ci.rb
+++ b/.toys/ci.rb
@@ -265,7 +265,14 @@ def find_changed_directories files
dirs = Set.new
files.each do |file|
if file =~ %r{^([^/]+)/.+$}
- dirs << Regexp.last_match[1]
+ dir = Regexp.last_match[1]
+ dirs << dir
+ if dir =~ %r{^(.+)-v\d[^-]*$}
+ wrapper_dir = Regexp.last_match[1]
+ if Dir.exists? wrapper_dir
+ dirs << wrapper_dir
+ end
+ end
end
end
filter_gem_dirs dirs.to_a
|
chore: run tests for wrappers when child directories have changed
|
googleapis_google-cloud-ruby
|
train
|
rb
|
5ef2974de6e08efbc38f905cccc7b346baa91974
|
diff --git a/instana/version.py b/instana/version.py
index <HASH>..<HASH> 100644
--- a/instana/version.py
+++ b/instana/version.py
@@ -3,4 +3,4 @@
# Module version file. Used by setup.py and snapshot reporting.
-VERSION = '1.36.2'
+VERSION = '1.37.0'
|
chore: Bump package version to <I> (#<I>)
The minor version is change because of support to suppression through X-INSTANA-L 0.
|
instana_python-sensor
|
train
|
py
|
db6108b443d25cb832460f764da715cc7860d1e5
|
diff --git a/src/client/processes/actions.js b/src/client/processes/actions.js
index <HASH>..<HASH> 100644
--- a/src/client/processes/actions.js
+++ b/src/client/processes/actions.js
@@ -1,8 +1,8 @@
import * as ActionType from './actionTypes';
-import ProcessSelectors from './selectors';
+import * as ProcessSelectors from './selectors';
+import * as ProjectSelectors from 'xod/client/project/selectors';
import { STATUS } from 'xod/client/utils/constants';
-import ProjectSelectors from 'xod/client/project/selectors';
import { uploadToEspruino } from 'xod/utils/espruino';
export const upload = () => (dispatch, getState) => {
|
fix(actions): fix import errors
|
xodio_xod
|
train
|
js
|
24de8e491ad6d200fbbcd0127c4db4ed5127d767
|
diff --git a/src/tools/annotation/ArrowAnnotateTool.js b/src/tools/annotation/ArrowAnnotateTool.js
index <HASH>..<HASH> 100644
--- a/src/tools/annotation/ArrowAnnotateTool.js
+++ b/src/tools/annotation/ArrowAnnotateTool.js
@@ -263,7 +263,7 @@ export default class ArrowAnnotateTool extends BaseAnnotationTool {
measurementData.active = false;
external.cornerstone.updateImage(element);
- });
+ }, evt.detail);
}
external.cornerstone.updateImage(element);
}
|
feat: Add event details to arrow tool getText callback (#<I>)
|
cornerstonejs_cornerstoneTools
|
train
|
js
|
920129892ed0fcae097188f928442d971ab59ee2
|
diff --git a/lib/core.js b/lib/core.js
index <HASH>..<HASH> 100644
--- a/lib/core.js
+++ b/lib/core.js
@@ -784,7 +784,7 @@ Archiver.prototype.setModule = function(module) {
/**
* Returns the current length (in bytes) that has been emitted.
*
- * @return {this}
+ * @return {integer}
*/
Archiver.prototype.pointer = function() {
return this._pointer;
|
docs: initial jsdoc for core.
|
archiverjs_node-archiver
|
train
|
js
|
a855ea0663ef763edf64a6211c9607b3c48123e8
|
diff --git a/scripts/get_ldif.py b/scripts/get_ldif.py
index <HASH>..<HASH> 100644
--- a/scripts/get_ldif.py
+++ b/scripts/get_ldif.py
@@ -13,6 +13,7 @@ def run(*args):
u.user_type = "staff"
else:
u.user_type = "students"
+ tj_email = u.tj_email
ldiftemplate = """dn: uid={username},ou={graduation_year},ou={user_type},ou=people,dc=csl,dc=tjhsst,dc=edu
cn: {first_name} {last_name}
@@ -30,8 +31,9 @@ uidNumber: {uidNum}
gecos: {first_name} {last_name}
gidNumber: {graduation_year}
homeDirectory: /afs/csl.tjhsst.edu/{user_type}/{graduation_year}/{username}
+mail: {tj_email}
loginShell: /bin/bash"""
- out = ldiftemplate.format(uidNum=uidNum, **model_to_dict(u))
+ out = ldiftemplate.format(uidNum=uidNum, tj_email=tj_email, **model_to_dict(u))
if u.user_type == "staff":
out = out.replace("staff/1984", "staff")
out = out.replace("ou=1984,", "")
|
feat(scripts): add TJ email to LDIF
|
tjcsl_ion
|
train
|
py
|
54a341fae9ec0ae0db0216e8bae1df584c3930c2
|
diff --git a/spaceship/lib/spaceship/connect_api/client.rb b/spaceship/lib/spaceship/connect_api/client.rb
index <HASH>..<HASH> 100644
--- a/spaceship/lib/spaceship/connect_api/client.rb
+++ b/spaceship/lib/spaceship/connect_api/client.rb
@@ -129,7 +129,6 @@ module Spaceship
tries = 1 if Object.const_defined?("SpecHelper")
response = yield
- tries -= 1
status = response.status if response
if [500, 504].include?(status)
@@ -139,6 +138,7 @@ module Spaceship
return response
rescue => error
+ tries -= 1
puts(error) if Spaceship::Globals.verbose?
if tries.zero?
return response
|
fix: infinite retry of with_asc_retry (#<I>)
The previous implementation decremented the number of attempts only after a successful response by the yield block. However, if the yield block raises an unhandled exception, the execution jumps straight to the rescue block without decrementing the number of retry attempts. This leads to an infinite loop of retries.
|
fastlane_fastlane
|
train
|
rb
|
743034fd59b5d66b1fb8ffb941da77143ae56f5d
|
diff --git a/lib/babel-config.js b/lib/babel-config.js
index <HASH>..<HASH> 100644
--- a/lib/babel-config.js
+++ b/lib/babel-config.js
@@ -13,7 +13,7 @@ module.exports = function (env) {
presets: [
[babelEnv, {
targets: {browsers},
- loose: true
+ loose: false // Loose mode breaks spread operator on `Set`s
}],
react,
stage2
|
fix(babel): Loose mode breaks spread operator on Sets. Disable for now.
|
conveyal_mastarm
|
train
|
js
|
9d422cc0003342bf86653ae27e27d08402eb6226
|
diff --git a/percy/percy.test.js b/percy/percy.test.js
index <HASH>..<HASH> 100644
--- a/percy/percy.test.js
+++ b/percy/percy.test.js
@@ -1,6 +1,3 @@
-/* eslint-disable jest/expect-expect */
-/* We use a method to generate our assertions */
-
import execa from 'execa'
import puppeteer from 'puppeteer'
@@ -130,6 +127,8 @@ test('OTP-RR Fixed Routes', async () => {
})
*/
+// Percy screenshot is not an assertion, but that's ok
+// eslint-disable-next-line jest/expect-expect
test('OTP-RR', async () => {
const page = await loadPath('/')
await page.setViewport({
|
chore(ci): attempt to force ci build
|
opentripplanner_otp-react-redux
|
train
|
js
|
3fb59aac3945eb6cc06c0350a78eddd0a65b768c
|
diff --git a/src/Hint/HintContent.js b/src/Hint/HintContent.js
index <HASH>..<HASH> 100644
--- a/src/Hint/HintContent.js
+++ b/src/Hint/HintContent.js
@@ -40,7 +40,7 @@ const styles = theme => ({
position: 'absolute',
borderStyle: 'solid',
borderColor: 'transparent',
- borderWidth: 5,
+ borderWidth: theme.hint.arrowWidth,
borderBottomColor: theme.hint.colors.background,
zIndex: 100
},
diff --git a/src/theme/create-theme.js b/src/theme/create-theme.js
index <HASH>..<HASH> 100644
--- a/src/theme/create-theme.js
+++ b/src/theme/create-theme.js
@@ -551,6 +551,7 @@ export default function createTheme(config) {
boxShadow: '-2px 2px 10px 0 rgba(102, 116, 166, 0.2)',
fontWeight: 400,
lineHeight: 1.54,
+ arrowWidth: 5,
colors: {
background: colors.light,
text: colors.dark
|
feat: added hint arrow borderWidth
|
rambler-digital-solutions_rambler-ui
|
train
|
js,js
|
8057cca83441272bc2f39e03b7fb9cf0a4a96520
|
diff --git a/engine/src/main/java/org/camunda/bpm/dmn/engine/impl/DefaultDmnEngineConfiguration.java b/engine/src/main/java/org/camunda/bpm/dmn/engine/impl/DefaultDmnEngineConfiguration.java
index <HASH>..<HASH> 100644
--- a/engine/src/main/java/org/camunda/bpm/dmn/engine/impl/DefaultDmnEngineConfiguration.java
+++ b/engine/src/main/java/org/camunda/bpm/dmn/engine/impl/DefaultDmnEngineConfiguration.java
@@ -108,6 +108,9 @@ public class DefaultDmnEngineConfiguration implements DmnEngineConfiguration {
protected void initFeelEngine() {
if (feelEngineFactory == null) {
feelEngineFactory = new FeelEngineFactoryImpl();
+ }
+
+ if (feelEngine == null) {
feelEngine = feelEngineFactory.createInstance();
}
}
@@ -188,7 +191,7 @@ public class DefaultDmnEngineConfiguration implements DmnEngineConfiguration {
public void setFeelEngineFactory(FeelEngineFactory feelEngineFactory) {
this.feelEngineFactory = feelEngineFactory;
- this.feelEngine = feelEngineFactory.createInstance();
+ this.feelEngine = null; // clear cached FEEL engine
}
public DmnEngineConfiguration feelEngineFactory(FeelEngineFactory feelEngineFactory) {
|
chore(engine): do not initialize FEEL engine in setter
|
camunda_camunda-engine-dmn
|
train
|
java
|
12d2a5e32b2e190b4be5780e3d9ccac13fb97ea1
|
diff --git a/lib/login/index.js b/lib/login/index.js
index <HASH>..<HASH> 100644
--- a/lib/login/index.js
+++ b/lib/login/index.js
@@ -49,7 +49,8 @@ if (config.login.twitch && config.login.twitch.enabled) {
clientID: config.login.twitch.clientID,
clientSecret: config.login.twitch.clientSecret,
callbackURL: `${protocol}://${config.baseURL}/login/auth/twitch`,
- scope
+ scope,
+ customHeaders: {'Client-ID': config.login.twitch.clientID}
}, (accessToken, refreshToken, profile, done) => {
profile.allowed = (config.login.twitch.allowedUsernames.indexOf(profile.username) > -1);
|
fix(auth): send Client-ID header on all Twitch API requests (#<I>)
As of now, Twitch requires this header on all Helix endpoints.
|
nodecg_nodecg
|
train
|
js
|
8102de7fa562a05acabae696e9d33ce42fd3c39d
|
diff --git a/packages/router5-transition-path/test/main.js b/packages/router5-transition-path/test/main.js
index <HASH>..<HASH> 100644
--- a/packages/router5-transition-path/test/main.js
+++ b/packages/router5-transition-path/test/main.js
@@ -69,6 +69,8 @@ describe('router5-transition-path', function() {
describe('TypeScript definitions', function() {
it('should compile examples against index.d.ts', function(done) {
+ this.timeout(10000)
+
tt.compileDirectory(
`${__dirname}/typescript`,
filename => filename.match(/\.ts$/),
diff --git a/packages/router5/test/index.js b/packages/router5/test/index.js
index <HASH>..<HASH> 100644
--- a/packages/router5/test/index.js
+++ b/packages/router5/test/index.js
@@ -33,6 +33,8 @@ describe('router5', function() {
describe('TypeScript definitions', function() {
it('should compile examples against index.d.ts', function(done) {
+ this.timeout(10000)
+
tt.compileDirectory(
`${__dirname}/typescript`,
filename => filename.match(/\.ts$/),
|
test: Increase timeouts for TypeScript examples
When compiling the TypeScript examples, Travis CI sometimes takes longer
than the default Mocha timeout of 2 s. This patch increases those
timeouts to <I> s to avoid failures.
See <<URL>
|
router5_router5
|
train
|
js,js
|
bb9328a62eeed4f0bde0767fd219d79ce2635133
|
diff --git a/app/lib/webpack/create-chain.js b/app/lib/webpack/create-chain.js
index <HASH>..<HASH> 100644
--- a/app/lib/webpack/create-chain.js
+++ b/app/lib/webpack/create-chain.js
@@ -13,8 +13,8 @@ module.exports = function (cfg, configName) {
const chain = new WebpackChain()
const needsHash = !cfg.ctx.dev && !['electron', 'cordova', 'capacitor'].includes(cfg.ctx.modeName)
- const fileHash = needsHash ? '.[hash:8]' : ''
- const chunkHash = needsHash ? '.[contenthash:8]' : ''
+ const fileHash = needsHash ? '.[contenthash:8]' : ''
+ const chunkHash = needsHash ? '.[chunkhash:8]' : ''
const resolveModules = [
'node_modules',
appPaths.resolve.app('node_modules'),
|
fix(app): hash name computation algorithm for generated build files #<I>
|
quasarframework_quasar
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.