hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
721671e04f1f5d107e576090517d4b0b54e504a8
diff --git a/lib/jestPreprocessor.js b/lib/jestPreprocessor.js index <HASH>..<HASH> 100644 --- a/lib/jestPreprocessor.js +++ b/lib/jestPreprocessor.js @@ -4,7 +4,8 @@ const jestPreset = require('babel-preset-jest') module.exports = { process: function (src) { const transformCfg = { - presets: ['es2015', 'react', 'stage-0', jestPreset] + presets: ['es2015', 'react', 'stage-0', jestPreset], + retainLines: true } return babel.transform(src, transformCfg).code }
fix(tests): Fix Jest error reporting Add configuration to babel transformation that allows Jest to report errors with the correct line number.
conveyal_mastarm
train
js
f64996acb2b78e18ea1462b35f2980d4bbc0686f
diff --git a/benchmarks/bench_test.go b/benchmarks/bench_test.go index <HASH>..<HASH> 100644 --- a/benchmarks/bench_test.go +++ b/benchmarks/bench_test.go @@ -88,7 +88,7 @@ func runQueriesSlow(b *testing.B, t *iavl.MutableTree, keyLen int) { itree, err := t.GetImmutable(version - 1) require.NoError(b, err) - isFastCacheEnabled, err := t.IsFastCacheEnabled() // to ensure fast storage is enabled + isFastCacheEnabled, err := itree.IsFastCacheEnabled() // to ensure fast storage is enabled require.NoError(b, err) require.False(b, isFastCacheEnabled) // to ensure fast storage is not enabled @@ -108,7 +108,7 @@ func runKnownQueriesSlow(b *testing.B, t *iavl.MutableTree, keys [][]byte) { itree, err := t.GetImmutable(version - 1) require.NoError(b, err) - isFastCacheEnabled, err := t.IsFastCacheEnabled() // to ensure fast storage is not enabled + isFastCacheEnabled, err := itree.IsFastCacheEnabled() // to ensure fast storage is not enabled require.NoError(b, err) require.False(b, isFastCacheEnabled) b.StartTimer()
fix: make slow query benchmarks use correct tree (#<I>)
tendermint_iavl
train
go
51d879d7d2619672b4e10890167b39c4ca8fb29f
diff --git a/services/github/github-contributors.tester.js b/services/github/github-contributors.tester.js index <HASH>..<HASH> 100644 --- a/services/github/github-contributors.tester.js +++ b/services/github/github-contributors.tester.js @@ -4,14 +4,14 @@ const t = (module.exports = require('../tester').createServiceTester()) const { isMetric } = require('../test-validators') t.create('Contributors') - .get('/contributors/cdnjs/cdnjs.json') + .get('/contributors/badges/shields.json') .expectBadge({ label: 'contributors', message: isMetric, }) t.create('1 contributor') - .get('/contributors/paulmelnikow/local-credential-storage.json') + .get('/contributors/badges/shields-tests.json') .expectBadge({ label: 'contributors', message: '1',
fix: use repos from badges organization for GithubContributors (#<I>) (#<I>) Fixes #<I>
badges_shields
train
js
4d1387e0fdb2bb177fd20233490cf83ddefbaac3
diff --git a/lib/Model/actions/Finder.js b/lib/Model/actions/Finder.js index <HASH>..<HASH> 100644 --- a/lib/Model/actions/Finder.js +++ b/lib/Model/actions/Finder.js @@ -89,7 +89,7 @@ class Finder { } // find createSqlSelect (options) { - const filter = Array.isArray(options.fields) + const filter = Array.isArray(options.fields) && options.fields.length ? ([col, prop]) => options.fields.includes(prop) : () => true
fix: check fields is not empty array
wmfs_pg-model
train
js
75f57e72441144c87cf8adc311b43e018f8f466c
diff --git a/goreleaserlib/goreleaser.go b/goreleaserlib/goreleaser.go index <HASH>..<HASH> 100644 --- a/goreleaserlib/goreleaser.go +++ b/goreleaserlib/goreleaser.go @@ -75,7 +75,8 @@ func Release(flags Flags) error { if err != nil { return err } - log.WithField("notes", notes).Info("loaded custom release notes") + log.WithField("file", notes).Info("loaded custom release notes") + log.WithField("file", notes).Debugf("custon release notes: \n%s", string(bts)) ctx.ReleaseNotes = string(bts) } ctx.Snapshot = flags.Bool("snapshot")
chore: Improved custom release notes logs Improved the previous log by changing the field notes to file and also adding a new a debug log with the actual contents of the file. Refs #<I>
goreleaser_goreleaser
train
go
9ac7a092f1f4857ee7396105507af04cea67c986
diff --git a/packages/vue-cli-plugin-styleguidist/index.js b/packages/vue-cli-plugin-styleguidist/index.js index <HASH>..<HASH> 100644 --- a/packages/vue-cli-plugin-styleguidist/index.js +++ b/packages/vue-cli-plugin-styleguidist/index.js @@ -95,6 +95,20 @@ function getStyleguidist(args, api, options) { function getConfig(api) { const conf = api.resolveChainableWebpackConfig() + // avoid annoying notification when everything works + if (conf.plugins.has('fork-ts-checker')) { + conf.plugin('fork-ts-checker').tap(args => { + args[0].logger = { + // eslint-disable-next-line no-console + warn: console.warn, + // eslint-disable-next-line no-console + error: console.error, + info: function() {} + } + return args + }) + } + // because we are dealing with hot replacement in vsg // remove duplicate hot module reload plugin conf.plugins.delete('hmr')
fix(plugin): avoid fork-ts success notification
vue-styleguidist_vue-styleguidist
train
js
b8169af58f928f4e29ea7eabc35d62e0dba19ec3
diff --git a/src/novo-elements.js b/src/novo-elements.js index <HASH>..<HASH> 100644 --- a/src/novo-elements.js +++ b/src/novo-elements.js @@ -55,5 +55,8 @@ export * from './utils/countries/Countries'; export * from './utils/Helpers'; export * from './utils/component-utils/ComponentUtils'; +// Pipes +export * from './pipes/plural/Plural'; + // Export main module export { NovoElementsModule } from './novo-elements.module';
chore(exports): Making sure to export the pipes
bullhorn_novo-elements
train
js
0b0fec285d7df8675c8f5ecc42519f3734d70f72
diff --git a/lib/rules/color-contrast-matches.js b/lib/rules/color-contrast-matches.js index <HASH>..<HASH> 100644 --- a/lib/rules/color-contrast-matches.js +++ b/lib/rules/color-contrast-matches.js @@ -69,14 +69,17 @@ function colorContrastMatches(node, virtualNode) { : virtualNode; // explicit label of disabled control - const doc = getRootNode(labelNode); - const explicitControl = doc.getElementById(labelNode.htmlFor || ''); - const explicitControlVirtual = - explicitControl && getNodeFromTree(explicitControl); + if (labelNode.htmlFor) { + const doc = getRootNode(labelNode); + const explicitControl = doc.getElementById(labelNode.htmlFor); + const explicitControlVirtual = + explicitControl && getNodeFromTree(explicitControl); - if (explicitControlVirtual && isDisabled(explicitControlVirtual)) { - return false; + if (explicitControlVirtual && isDisabled(explicitControlVirtual)) { + return false; + } } + // implicit label of disabled control const query = 'input:not([type="hidden"]):not([type="image"])' +
fix(color-contrast-matches): do not pass empty string to getElementById (#<I>)
dequelabs_axe-core
train
js
1c3b5755ae65e29bcd3b85cf5d536df0ea014367
diff --git a/example/App.js b/example/App.js index <HASH>..<HASH> 100644 --- a/example/App.js +++ b/example/App.js @@ -31,7 +31,7 @@ import { // Comment the following two lines to stop using react-native-screens import { useScreens } from 'react-native-screens'; -useScreens(); +useScreens(false); // Change `false` to `true` to force RTL. Requires closing and re-opening // your app after you first load it with this option enabled.
chore: disable react-native-screens in the example for now
react-navigation_stack
train
js
7820a3ba9e98b528dcc61f590ec78cabbdbd8455
diff --git a/modules/Router5.js b/modules/Router5.js index <HASH>..<HASH> 100644 --- a/modules/Router5.js +++ b/modules/Router5.js @@ -25,7 +25,7 @@ export default class Router5 { hashPrefix: '' } Object.keys(opts).forEach(opt => this.options[opt] = opts[opt]) - this.base = window.location.pathname.replace(/^\/$/, '') + this.base = window.location.pathname.replace(/\/$/, '') return this }
fix: double slash in paths (base path parsing) Issue #9
router5_router5
train
js
cd30a422fbc3d9d96b9aae791063a20d02a5f195
diff --git a/lib/server.js b/lib/server.js index <HASH>..<HASH> 100644 --- a/lib/server.js +++ b/lib/server.js @@ -245,6 +245,11 @@ var createSocketIoServer = function(webServer, executor, config) { var server = io.listen(webServer, { // avoid destroying http upgrades from socket.io to get proxied websockets working 'destroy upgrade': false, + // socket.io has a timeout (15s by default) before destroying a store (a data structure where + // data associated with a socket are stored). Unfortunately this timeout is not cleared + // properly on socket.io shutdown and this timeout prevents karma from exiting cleanly. + // We change this timeout to 0 to make Karma exit just after all tests were executed. + 'client store expiration': 0, logger: logger.create('socket.io', constant.LOG_ERROR), resource: config.urlRoot + 'socket.io', transports: config.transports
fix(server): don't wait for socket.io store expiration timeout
karma-runner_karma
train
js
45192bd0864198ffe2573f404974fc3d17a2ec93
diff --git a/android/src/main/java/com/horcrux/svg/PathView.java b/android/src/main/java/com/horcrux/svg/PathView.java index <HASH>..<HASH> 100644 --- a/android/src/main/java/com/horcrux/svg/PathView.java +++ b/android/src/main/java/com/horcrux/svg/PathView.java @@ -24,6 +24,7 @@ class PathView extends RenderableView { public PathView(ReactContext reactContext) { super(reactContext); PathParser.mScale = mScale; + mPath = new Path(); } @ReactProp(name = "d")
fix: initialize PathView with empty path
react-native-community_react-native-svg
train
java
ea1d52a53734d27f9bf009481e097fe8610ed47d
diff --git a/src/directives/center.js b/src/directives/center.js index <HASH>..<HASH> 100644 --- a/src/directives/center.js +++ b/src/directives/center.js @@ -41,12 +41,6 @@ angular.module("leaflet-directive").directive('center', map.fitBounds(leafletBoundsHelpers.createLeafletBounds(leafletScope.bounds), leafletScope.bounds.options); centerModel = map.getCenter(); safeApply(leafletScope, function (scope) { - scope.center = { - lat: map.getCenter().lat, - lng: map.getCenter().lng, - zoom: map.getZoom(), - autoDiscover: false - }; angular.extend(scope.center,{ lat: map.getCenter().lat, lng: map.getCenter().lng, @@ -96,11 +90,11 @@ angular.module("leaflet-directive").directive('center', var urlCenter = extractCenterFromUrl(); if (isDefined(urlCenter) && !isSameCenterOnMap(urlCenter, map)) { //$log.debug("updating center model...", urlCenter); - scope.center = { + angular.extend(scope.center, { lat: urlCenter.lat, lng: urlCenter.lng, zoom: urlCenter.zoom - }; + }); } }); }
fix(center): cleanup some center code, based on this issue by @pieterjandesmedt: <URL>
tombatossals_angular-leaflet-directive
train
js
e3d5c128115bf79ddf99b90a161369ae99aa97aa
diff --git a/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/migration/MigrationPlanDto.java b/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/migration/MigrationPlanDto.java index <HASH>..<HASH> 100644 --- a/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/migration/MigrationPlanDto.java +++ b/engine-rest/engine-rest/src/main/java/org/camunda/bpm/engine/rest/dto/migration/MigrationPlanDto.java @@ -58,9 +58,11 @@ public class MigrationPlanDto { dto.setTargetProcessDefinitionId(migrationPlan.getTargetProcessDefinitionId()); ArrayList<MigrationInstructionDto> instructionDtos = new ArrayList<MigrationInstructionDto>(); - for (MigrationInstruction migrationInstruction : migrationPlan.getInstructions()) { - MigrationInstructionDto migrationInstructionDto = MigrationInstructionDto.from(migrationInstruction); - instructionDtos.add(migrationInstructionDto); + if (migrationPlan.getInstructions() != null) { + for (MigrationInstruction migrationInstruction : migrationPlan.getInstructions()) { + MigrationInstructionDto migrationInstructionDto = MigrationInstructionDto.from(migrationInstruction); + instructionDtos.add(migrationInstructionDto); + } } dto.setInstructions(instructionDtos);
fix(engine-rest): provide a further null check related to CAM-<I>
camunda_camunda-bpm-platform
train
java
664c1dd29c2a170c7c2a2b36e63c94c5a5b3c57c
diff --git a/src/area/index.js b/src/area/index.js index <HASH>..<HASH> 100644 --- a/src/area/index.js +++ b/src/area/index.js @@ -110,6 +110,7 @@ export default createComponent({ } code = code.slice(0, compareNum); + for (let i = 0; i < list.length; i++) { if (list[i].code.slice(0, compareNum) === code) { return i; @@ -138,7 +139,7 @@ export default createComponent({ picker.setColumnValues(0, province); picker.setColumnValues(1, city); - if (city.length && code.slice(2, 4) === '00') { + if (city.length && code.slice(2, 4) === '00' && !this.isOverseaCode(code)) { [{ code }] = city; }
fix(Area): can't select some oversea country (#<I>)
youzan_vant
train
js
06217d72e66a3943d4789bed60446328b8a387f8
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -9,6 +9,7 @@ import { passportJwtSecret } from './integrations/passport'; module.exports = (options) => { return new JwksClient(options); }; +module.exports.JwksClient = JwksClient; module.exports.ArgumentError = errors.ArgumentError; module.exports.JwksError = errors.JwksError;
fix: missing export (#<I>)
auth0_node-jwks-rsa
train
js
ce11e3816b6996b882902aa172dd0bcc1c2023e6
diff --git a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js +++ b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/config.js @@ -12,7 +12,11 @@ export default { }, defaults: { name: process.title || inBrowser && 'browser' || 'javascript', - deviceType: 'UNKNOWN' + deviceType: 'WEB', + model: 'web-js-sdk', + localizedModel: 'webex-js-sdk', + systemName: 'WEBEX_JS_SDK', + systemVersion: '1.0.0' }, enableInactivityEnforcement: false, /**
fix: changed device config to web
webex_spark-js-sdk
train
js
476915b1e23623f7d808ca11f04cfd938d546e95
diff --git a/test/protractor.conf.js b/test/protractor.conf.js index <HASH>..<HASH> 100644 --- a/test/protractor.conf.js +++ b/test/protractor.conf.js @@ -43,7 +43,7 @@ if (process.env.TRAVIS_BUILD_NUMBER){ name: 'protractor-testability-plugin Chrome' }, { 'browserName': 'safari', - 'version': '7', + 'version': '8', build: process.env.TRAVIS_BUILD_NUMBER, 'tunnel-identifier': process.env.TRAVIS_JOB_NUMBER, name: 'protractor-testability-plugin Safari'
fix(e2e_tests): Upgrade to safari 8 due to saucelabs probs with 7
alfonso-presa_protractor-testability-plugin
train
js
9ee1b6baa52e1f6cc88fd695f34b80f26cfaa12f
diff --git a/src/lib/isMobilePhone.js b/src/lib/isMobilePhone.js index <HASH>..<HASH> 100644 --- a/src/lib/isMobilePhone.js +++ b/src/lib/isMobilePhone.js @@ -112,7 +112,7 @@ const phones = { 'uk-UA': /^(\+?38|8)?0\d{9}$/, 'uz-UZ': /^(\+?998)?(6[125-79]|7[1-69]|88|9\d)\d{7}$/, 'vi-VN': /^(\+?84|0)((3([2-9]))|(5([2689]))|(7([0|6-9]))|(8([1-9]))|(9([0-9])))([0-9]{7})$/, - 'zh-CN': /^((\+|00)86)?1([3568][0-9]|4[579]|6[67]|7[01235678]|9[012356789])[0-9]{8}$/, + 'zh-CN': /^((\+|00)86)?1([3456789][0-9]|4[579]|6[67]|7[01235678]|9[012356789])[0-9]{8}$/, 'zh-TW': /^(\+?886\-?|0)?9\d{8}$/, }; /* eslint-enable max-len */
fix(isMobilePhone): update china zh-CN locale (#<I>)
chriso_validator.js
train
js
ea8642e2a17bb1e6b535b31db30bf22d065866fd
diff --git a/pkg/pilot/pilot.go b/pkg/pilot/pilot.go index <HASH>..<HASH> 100644 --- a/pkg/pilot/pilot.go +++ b/pkg/pilot/pilot.go @@ -33,6 +33,8 @@ const ( pilotInstanceInfoTimer = 5 * time.Minute pilotDynConfTimer = 12 * time.Hour maxElapsedTime = 4 * time.Minute + initialInterval = 5 * time.Second + multiplier = 3 ) type instanceInfo struct { @@ -219,6 +221,8 @@ func (c *client) SendInstanceInfo(ctx context.Context, pilotMetrics []metrics.Pi func (c *client) sendDataRetryable(ctx context.Context, req *http.Request) error { exponentialBackOff := backoff.NewExponentialBackOff() exponentialBackOff.MaxElapsedTime = maxElapsedTime + exponentialBackOff.InitialInterval = initialInterval + exponentialBackOff.Multiplier = multiplier req.Header.Set("Content-Type", "application/json") req.Header.Set(tokenHashHeader, c.tokenHash)
fix: reduce pressure of pilot services when errors occurs
containous_traefik
train
go
3f21b5229aa02cad059798eed21cd0a91e6ee400
diff --git a/src/Strain.js b/src/Strain.js index <HASH>..<HASH> 100644 --- a/src/Strain.js +++ b/src/Strain.js @@ -24,6 +24,12 @@ const utils = require('./utils.js'); const log = require('./log.js'); /** + * Flags indicating whether deprecation warning were shown. + */ +let urlOverridesCondition; +let urlIsDeprecated; + +/** * Strain */ class Strain { @@ -51,10 +57,12 @@ class Strain { this._condition = new Condition(cfg.condition || ''); if (cfg.url) { - if (cfg.condition) { + if (cfg.condition && !urlOverridesCondition) { log.warn('Property url overrides property condition, use just a condition instead.'); - } else { + urlOverridesCondition = 1; + } else if (!urlIsDeprecated) { log.info('Property url is deprecated, use a condition instead.'); + urlIsDeprecated = 1; } }
fix: Deprecation warnings should be shown just once per run (#<I>)
adobe_helix-shared
train
js
982eee52b20141f564934270fe12085f4a047083
diff --git a/core/src/elements/ons-carousel.js b/core/src/elements/ons-carousel.js index <HASH>..<HASH> 100644 --- a/core/src/elements/ons-carousel.js +++ b/core/src/elements/ons-carousel.js @@ -636,9 +636,13 @@ export default class CarouselElement extends BaseElement { } _canConsumeGesture(gesture) { + const d = gesture.direction; + const isFirst = this._scroll === 0 && !this.overscrollable; + const isLast = this._scroll === this._calculateMaxScroll() && !this.overscrollable; + return this._isVertical() - ? (gesture.direction === 'up' || gesture.direction === 'down') - : (gesture.direction === 'right' || gesture.direction === 'left'); + ? ((d === 'down' && !isFirst) || (d === 'up' && !isLast)) + : ((d === 'right' && !isFirst) || (d === 'left' && !isLast)); } _onDragStart(event) {
feat(ons-carousel): Improve useful swipe detection.
OnsenUI_OnsenUI
train
js
db4a0957de400786bd39af8126c73e7bef583476
diff --git a/packages/plugin-board/test/unit/spec/realtime.js b/packages/plugin-board/test/unit/spec/realtime.js index <HASH>..<HASH> 100644 --- a/packages/plugin-board/test/unit/spec/realtime.js +++ b/packages/plugin-board/test/unit/spec/realtime.js @@ -169,14 +169,15 @@ describe(`plugin-board`, () => { }); }; - spark.board.realtime.on(`mercury.buffer_state`, bufferSpy); + spark.board.realtime.on(`event:mercury.buffer_state`, bufferSpy); spark.board.realtime.on(`online`, onlineSpy); - spark.board.realtime._attemptConnection((error) => { - assert(error, `_attemptConnection failed`); - assert.callCount(bufferSpy, 1); - assert.calledWith(bufferSpy, bufferStateMessage.data); - }); + return assert.isFulfilled(spark.board.realtime.connect()) + .then(() => { + assert.callCount(onlineSpy, 1); + assert.callCount(bufferSpy, 1); + assert.calledWith(bufferSpy, bufferStateMessage); + }); }); });
fix(plugin-board): add return statement to buffer state test ensure the test fulfill its promise before asserting buffer state and also event name should be event:mercury.buffer_state
webex_spark-js-sdk
train
js
b981441bae2d662ea1c1f65a1b62762c24d3a07b
diff --git a/test/databases.test.js b/test/databases.test.js index <HASH>..<HASH> 100644 --- a/test/databases.test.js +++ b/test/databases.test.js @@ -1028,6 +1028,13 @@ const HasManyDissociator = require('../src/services/has-many-dissociator'); it('should handle numbers over MAX_SAFE_INTEGER', async () => { expect.assertions(2); const { models, sequelizeOptions } = initializeSequelize(); + + // HACK: sequelize-fixtures does not support BigInt in json files, + // so we need to update the clicks value manually + const counter = await models.counter.findByPk(10); + counter.clicks = BigInt('9013084467599484828'); // eslint-disable-line no-undef + await counter.save(); + const params = { fields: { counter: 'id,clicks',
test: workaround a sequelize-fixtures bug
ForestAdmin_forest-express-sequelize
train
js
c3d85716420048dd0567ccc5cda894a9717598ae
diff --git a/workflow/util/util.go b/workflow/util/util.go index <HASH>..<HASH> 100644 --- a/workflow/util/util.go +++ b/workflow/util/util.go @@ -203,9 +203,9 @@ func ApplySubmitOpts(wf *wfv1.Workflow, opts *wfv1.SubmitOpts) error { if opts.ServiceAccount != "" { wf.Spec.ServiceAccountName = opts.ServiceAccount } - labels := wf.GetLabels() - if labels == nil { - labels = make(map[string]string) + wfLabels := wf.GetLabels() + if wfLabels == nil { + wfLabels = make(map[string]string) } if opts.Labels != "" { passedLabels, err := cmdutil.ParseLabels(opts.Labels) @@ -213,10 +213,10 @@ func ApplySubmitOpts(wf *wfv1.Workflow, opts *wfv1.SubmitOpts) error { return fmt.Errorf("Expected labels of the form: NAME1=VALUE2,NAME2=VALUE2. Received: %s", opts.Labels) } for k, v := range passedLabels { - labels[k] = v + wfLabels[k] = v } } - wf.SetLabels(labels) + wf.SetLabels(wfLabels) if len(opts.Parameters) > 0 || opts.ParameterFile != "" { newParams := make([]wfv1.Parameter, 0) passedParams := make(map[string]bool)
chore: Avoid variable name collision with imported package name (#<I>)
argoproj_argo
train
go
403a0ee7c32afeca844745bb2dae947a6c0ace2a
diff --git a/test/WebSocket.test.js b/test/WebSocket.test.js index <HASH>..<HASH> 100644 --- a/test/WebSocket.test.js +++ b/test/WebSocket.test.js @@ -1990,7 +1990,7 @@ describe('WebSocket', function() { var srv = http.createServer(); srv.listen(++port, function() { srv.on('upgrade', function(req, socket, upgradeHeade) { - req.headers.should.not.have.property('origin'); + should(req.headers).not.have.property('origin'); srv.close(); done(); });
test: update `should` usage These changes are in anticipation of upcoming changes in node <I>. See: <URL>
websockets_ws
train
js
0a16988be06ef6de191bcc227d153d7a0966417f
diff --git a/test/request-test.js b/test/request-test.js index <HASH>..<HASH> 100644 --- a/test/request-test.js +++ b/test/request-test.js @@ -433,4 +433,20 @@ describe('octokitRequest()', () => { expect(url).to.equal('https://www.githubstatus.com/api/v2/status.json') }) }) + + it.only('options.request.signal is passed as option to fetch', function () { + return octokitRequest('/', { + request: { + signal: 'funk' + } + }) + + .then(() => { + throw new Error('Should not resolve') + }) + + .catch((error) => { + expect(error.message).to.equal('Expected signal to be an instanceof AbortSignal') + }) + }) })
test: `options.request.signal` gets passed as `signal` option to fetch
octokit_request.js
train
js
4b7ae944af68b9c8b3f3cd79415403f4de5c1ed3
diff --git a/source/rafcon/gui/views/menu_bar.py b/source/rafcon/gui/views/menu_bar.py index <HASH>..<HASH> 100644 --- a/source/rafcon/gui/views/menu_bar.py +++ b/source/rafcon/gui/views/menu_bar.py @@ -111,7 +111,8 @@ class MenuBarView(View): if menu_item_name in global_gui_config.get_config_value('SHORTCUTS'): shortcuts = global_gui_config.get_config_value('SHORTCUTS')[menu_item_name] if shortcuts: - self.set_menu_item_accelerator(menu_item_name, shortcuts[0]) + main_shortcut = shortcuts[0] if isinstance(shortcuts, list) else shortcuts + self.set_menu_item_accelerator(menu_item_name, main_shortcut) def set_menu_item_icon(self, menu_item_name, uni_code=None): menu_item = self[menu_item_name]
fix(set_menu_item_accelerator): Properly derive main shortcut The function set_menu_item_accelerator was often passed the wrong accel_code, as the calling method expected the config values of ["SHORTCUTS"][menu_item_name] always to be lists. With this commit, all menu accelerators are correctly installed and no more GTK warning is printed.
DLR-RM_RAFCON
train
py
28cf48cea881c8e94eb4986d735b79927a5c1b23
diff --git a/cypress/integration/admin/pageBuilder/menus/createMenu.spec.js b/cypress/integration/admin/pageBuilder/menus/createMenu.spec.js index <HASH>..<HASH> 100644 --- a/cypress/integration/admin/pageBuilder/menus/createMenu.spec.js +++ b/cypress/integration/admin/pageBuilder/menus/createMenu.spec.js @@ -24,7 +24,7 @@ context("Menus Module", () => { .should("exist"); cy.findByLabelText("Slug") - .type("-edited") + .should('disabled') .findByLabelText("Description") .type(" Test test.") .findByText("Save menu") @@ -61,13 +61,12 @@ context("Menus Module", () => { cy.visit("/page-builder/menus") .findByLabelText("Name") .type(`Cool Menu ${id}`) - .findByText("Save menu") .findByLabelText("Slug") .type(`cool-menu-${id}`) .findByText("Save menu") .click(); - cy.wait(500); + cy.wait(1000); cy.findByTestId("new-record-button") .click()
test: assert that the "slug" field is disabled
Webiny_webiny-js
train
js
fb7044cb75bd681530fa0214949d0689cdbabe65
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -227,6 +227,11 @@ module.exports = function (options) { }); }); + router.get('/verify', function (req, res) { + // If we've gotten this far then token gives proper access and that's all that this route care about + return res.sendStatus(200); + }); + router.post('/', function (req, res, next) { var isUpdate = !!req.body['edit-of']; var isDeletion = !!req.body['delete-of'];
feat(main): add a /verify endpoint Helps micropub clients verify whether a token gives proper access or not – without having to attempt to publish anything or such.
voxpelli_node-micropub-express
train
js
ed54a8ec527a3c3176372936b6424f8ebc75a6ae
diff --git a/lib/core/src/server/common/babel.js b/lib/core/src/server/common/babel.js index <HASH>..<HASH> 100644 --- a/lib/core/src/server/common/babel.js +++ b/lib/core/src/server/common/babel.js @@ -5,6 +5,7 @@ function createProdPresets() { { builtIns: false, mangle: false, + simplify: false }, ], ];
fix: update babel.js to disable simplify A small fix to disable the simplify-feature of the babel's minify plugin as it stops the compilation of the storybook static build.
storybooks_storybook
train
js
86e030521eaa91acfaec141c1c22efedc7ed7d43
diff --git a/packages/spaces/src/SpacesLink.js b/packages/spaces/src/SpacesLink.js index <HASH>..<HASH> 100644 --- a/packages/spaces/src/SpacesLink.js +++ b/packages/spaces/src/SpacesLink.js @@ -69,6 +69,7 @@ const Link = ({ skeletonProps, linkAttributes, role, + analytics, ...rest }) => { const { loading } = useSpacesContext() || {}; @@ -185,6 +186,7 @@ const Link = ({ icons, images, colors, + ...analytics, ...restLink, ...props, }))() @@ -193,6 +195,7 @@ const Link = ({ tabIndex: 0, style: { cursor: link?.url ? 'pointer' : 'not-allowed' }, 'aria-label': name, + ...analytics, ...props, }); @@ -229,6 +232,7 @@ const Link = ({ style={{ cursor: link?.url ? 'pointer' : 'not-allowed', }} + {...analytics} {...props} aria-label={name} > @@ -288,6 +292,7 @@ Link.propTypes = { maxDescriptionLength: PropTypes.number, linkAttributes: PropTypes.object, role: PropTypes.string, + analytics: PropTypes.object, }; Link.defaultProps = {
refactor(spaces): move analytics into an object that can be assigned to the link
Availity_availity-react
train
js
947d0140a3b9929251a826ca2f3eec0a08e9cf43
diff --git a/spec/operators/inspectTime-spec.js b/spec/operators/inspectTime-spec.js index <HASH>..<HASH> 100644 --- a/spec/operators/inspectTime-spec.js +++ b/spec/operators/inspectTime-spec.js @@ -13,6 +13,16 @@ describe('Observable.prototype.inspectTime', function () { expectSubscriptions(e1.subscriptions).toBe(e1subs); }); + it('should get inspect the same value each time even if a new one did not arrive', function () { + var e1 = hot('----a-^--b----c--------------f----|'); + var e1subs = '^ !'; + var expected = '-----------c----------c-----|'; + // timer -----------!----------!--------- + + expectObservable(e1.inspectTime(110, rxTestScheduler)).toBe(expected); + expectSubscriptions(e1.subscriptions).toBe(e1subs); + }); + it('should inspect nothing if source has not nexted by time of inspect', function () { var e1 = hot('----a-^-------------b-------------|'); var e1subs = '^ !';
test(inspectTime): add test to cover multiple emission of same value closes #<I>
ReactiveX_rxjs
train
js
17295a1209721a9c3926f3210b1a18e07df6e1db
diff --git a/cypress/integration/column.js b/cypress/integration/column.js index <HASH>..<HASH> 100644 --- a/cypress/integration/column.js +++ b/cypress/integration/column.js @@ -54,10 +54,10 @@ describe('Column', function () { cy.getColumnCell(3) .should('have.css', 'width') - .and('match', /12\dpx/); + .and('match', /13\dpx/); cy.getCell(3, 1) .should('have.css', 'width') - .and('match', /12\dpx/); + .and('match', /13\dpx/); }); it('resize column using double click', function () {
test: Fix column resize test
frappe_datatable
train
js
6dfdb09e4f5aa82a3abb88c574290cbcdfe41ea2
diff --git a/src/utils.js b/src/utils.js index <HASH>..<HASH> 100644 --- a/src/utils.js +++ b/src/utils.js @@ -1,4 +1,5 @@ import isPlainObject from 'lodash.isplainobject' +import Vue from 'vue' const ObjProto = Object.prototype const toString = ObjProto.toString @@ -165,7 +166,16 @@ export const validateType = (type, value, silent = false) => { } if (hasOwn.call(typeToCheck, 'validator') && isFunction(typeToCheck.validator)) { + // swallow warn + let oldWarn + if (silent) { + oldWarn = warn + warn = noop + } + valid = typeToCheck.validator(value) + oldWarn && (warn = oldWarn) + if (!valid && silent === false) warn(`${namePrefix}custom validation failed`) return valid } @@ -176,11 +186,9 @@ let warn = noop if (process.env.NODE_ENV !== 'production') { const hasConsole = typeof console !== 'undefined' - warn = (msg) => { - if (hasConsole) { - console.warn(`[VueTypes warn]: ${msg}`) - } - } + warn = hasConsole ? (msg) => { + Vue.config.silent === false && console.warn(`[VueTypes warn]: ${msg}`) + } : noop } export { warn }
fix(loggin): silence warnings when Vue.config.silent is true and swallow warnings on sub validation tests
dwightjack_vue-types
train
js
f089accd684c35548085e43edee81f252b8097d8
diff --git a/lems/model/model.py b/lems/model/model.py index <HASH>..<HASH> 100644 --- a/lems/model/model.py +++ b/lems/model/model.py @@ -901,7 +901,7 @@ class Model(LEMSBase): return exposures - def get_recording_path(self, comp, exposures): + def get_recording_path_for_exposures(self, comp, exposures): # type: (Component, List[Exposure]) -> List[str] """Create recording path from a component and its list of exposures. @@ -917,7 +917,7 @@ class Model(LEMSBase): retlist.append(comp.id + "/" + exposure.name) return retlist - def list_recording_paths(self, substring=None): + def list_recording_paths_for_exposures(self, substring=None): # type: (str) -> List[str] """Get the recording path strings for exposures of matching component ids. @@ -931,5 +931,5 @@ class Model(LEMSBase): exposures = self.list_exposures(substring) for comp, exps in exposures.items(): - recording_paths.extend(self.get_recording_path(comp, exps)) + recording_paths.extend(self.get_recording_path_for_exposures(comp, exps)) return recording_paths
feat: change method name The method only gets paths for exposures, so we change the name to make it more specific.
LEMS_pylems
train
py
77cb7539b7605f3e35889ec43fb9673ed04e7d6a
diff --git a/packages/bonde-admin/src/mobrender/widgets/adjustments/component.spec.js b/packages/bonde-admin/src/mobrender/widgets/adjustments/component.spec.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin/src/mobrender/widgets/adjustments/component.spec.js +++ b/packages/bonde-admin/src/mobrender/widgets/adjustments/component.spec.js @@ -4,6 +4,10 @@ import { expect } from 'chai' import * as mock from 'utils/mock' import shallowWithIntl from 'intl/helpers/shallow-with-intl' import { AdjustmentsSettingsForm as Page } from './component' +import { IntlProvider } from 'react-intl'; + +const intlProvider = new IntlProvider({ locale: 'en' }, {}); +const { intl } = intlProvider.getChildContext(); describe('client/mobrender/widgets/adjustments/component', () => { let wrapper @@ -23,7 +27,7 @@ describe('client/mobrender/widgets/adjustments/component', () => { } beforeAll(() => { - wrapper = shallowWithIntl(<Page {...props} />) + wrapper = shallowWithIntl(<Page {...props} intl={intl} />) }) describe('#render', () => {
fix(admin): adjustments console.error
nossas_bonde-client
train
js
af0ccc8104bd8f4a6623811ab422b0de39e07219
diff --git a/src/Leevel/Database/Ddd/Relation/Relation.php b/src/Leevel/Database/Ddd/Relation/Relation.php index <HASH>..<HASH> 100644 --- a/src/Leevel/Database/Ddd/Relation/Relation.php +++ b/src/Leevel/Database/Ddd/Relation/Relation.php @@ -21,10 +21,10 @@ declare(strict_types=1); namespace Leevel\Database\Ddd\Relation; use Closure; +use Exception; use Leevel\Collection\Collection; use Leevel\Database\Ddd\Entity; use Leevel\Database\Ddd\Select; -use Throwable; /** * 关联实体基类. @@ -318,7 +318,7 @@ abstract class Relation try { $relation = $call(); static::$relationCondition = $old; - } catch (Throwable $th) { + } catch (Exception $th) { static::$relationCondition = $old; throw $th;
refactor(database): \Throwable changed to \Exception
hunzhiwange_framework
train
php
df3a87d3ad46b656484041f0d008bfbdf8f4a062
diff --git a/commitizen/commands/bump.py b/commitizen/commands/bump.py index <HASH>..<HASH> 100644 --- a/commitizen/commands/bump.py +++ b/commitizen/commands/bump.py @@ -148,8 +148,6 @@ class Bump: version_files, check_consistency=self.check_consistency, ) - if is_files_only: - raise ExpectedExit() if self.changelog: changelog_cmd = Changelog( @@ -164,6 +162,10 @@ class Bump: c = cmd.run(f"git add {changelog_cmd.file_name}") self.config.set_key("version", str(new_version)) + + if is_files_only: + raise ExpectedExit() + c = git.commit(message, args=self._get_commit_args()) if c.return_code != 0: raise BumpCommitFailedError(f'git.commit error: "{c.err.strip()}"')
feat: allow files-only to set config version and create changelog
Woile_commitizen
train
py
ad4d05cbc77e92ae4c54d36656ebe410f6123b4e
diff --git a/docs-v2/docusaurus.config.js b/docs-v2/docusaurus.config.js index <HASH>..<HASH> 100644 --- a/docs-v2/docusaurus.config.js +++ b/docs-v2/docusaurus.config.js @@ -35,6 +35,9 @@ const config = { favicon: 'img/favicon.ico', organizationName: 'apache', // Usually your GitHub org/user name. projectName: 'superset', // Usually your repo name. + themes: [ + '@saucelabs/theme-github-codeblock' + ], plugins: [ [ '@docusaurus/plugin-client-redirects',
chore: Reference Github code in Docusaurus (#<I>) * POC github code reference * Add example * Remove unnecessary change * Remove POC page
apache_incubator-superset
train
js
f6b2444c9f854cf78a5e3ea135ecf5373b064e0e
diff --git a/packages/button/src/presenters/ButtonPresenter.js b/packages/button/src/presenters/ButtonPresenter.js index <HASH>..<HASH> 100644 --- a/packages/button/src/presenters/ButtonPresenter.js +++ b/packages/button/src/presenters/ButtonPresenter.js @@ -23,7 +23,9 @@ const classNamesBySize = { const classNamesByType = { [types.PRIMARY]: "hig__button-v1--type-primary", + [types.SOLID]: "hig__button-v1--type-primary", [types.SECONDARY]: "hig__button-v1--type-secondary", + [types.OUTLINE]: "hig__button-v1--type-secondary", [types.FLAT]: "hig__button-v1--type-flat" };
fix: add styling support for new variants
Autodesk_hig
train
js
418762d15c46ea394d92ca41298fa13fc7fdb80c
diff --git a/core/resource/DependsOnPropertyCollection.php b/core/resource/DependsOnPropertyCollection.php index <HASH>..<HASH> 100644 --- a/core/resource/DependsOnPropertyCollection.php +++ b/core/resource/DependsOnPropertyCollection.php @@ -32,7 +32,7 @@ class DependsOnPropertyCollection extends ArrayIterator { public function isEqual(DependsOnPropertyCollection $dependsOnPropertyCollection): bool { - return $this->isArraysEqual($this->getPropertyUris(), $dependsOnPropertyCollection->getPropertyUris()); + return $this->areArraysEqual($this->getPropertyUris(), $dependsOnPropertyCollection->getPropertyUris()); } public function getPropertyUris(): array @@ -45,7 +45,7 @@ class DependsOnPropertyCollection extends ArrayIterator ); } - private function isArraysEqual(array $array1, array $array2): bool + private function areArraysEqual(array $array1, array $array2): bool { return empty(array_diff($array1, $array2)) && empty(array_diff($array2, $array1)); }
refactor: update private method nmae
oat-sa_generis
train
php
3ff4db2ddc5a61e19db5669d26de53ce41eee6c1
diff --git a/src/log-monitor/log-monitor-json-directive/log-monitor-json-controller.js b/src/log-monitor/log-monitor-json-directive/log-monitor-json-controller.js index <HASH>..<HASH> 100644 --- a/src/log-monitor/log-monitor-json-directive/log-monitor-json-controller.js +++ b/src/log-monitor/log-monitor-json-directive/log-monitor-json-controller.js @@ -9,7 +9,7 @@ export class LogMonitorJSONController { this.value = $scope.value; this.startExpanded = $scope.startExpanded; - $scope.$watch('value', value => this.value = value.toJS && value.toJS() || value); + $scope.$watch('value', value => this.value = value && value.toJS && value.toJS() || value); this.classModifier = LogMonitorJSONController.whatClass(this.value).toLowerCase();
fix(log-monitor): Bug when value is empty
D34THWINGS_ng-redux-dev-tools
train
js
3205accc5b105996049771f1502ed2ce20d87d50
diff --git a/GEOparse/GEOTypes.py b/GEOparse/GEOTypes.py index <HASH>..<HASH> 100755 --- a/GEOparse/GEOTypes.py +++ b/GEOparse/GEOTypes.py @@ -446,7 +446,7 @@ class GSM(SimpleGEO): email, directory=directory, **sra_kwargs) - downloaded_paths["SRA"] = downloaded_files + downloaded_paths.update(downloaded_files) except Exception as err: logger.error("Cannot download %s SRA file (%s)" % ( self.get_accession(), err)) @@ -468,9 +468,6 @@ class GSM(SimpleGEO): the download type to fasta or fastq. Following ``**kwargs`` can be passed: - * return_list - bool - if True returns list of arguments for multiprocess.Pool.map - else * filetype - str can be sra, fasta, or fastq - for fasta or fastq SRA-Toolkit need to be installed @@ -506,7 +503,7 @@ class GSM(SimpleGEO): :obj:`HTTPError`: Cannot access or connect to DB """ downloader = SRADownloader(self, email, directory, **kwargs) - return downloader.download() + return {"SRA": downloader.download()} class GPL(SimpleGEO):
fix: Consistent supplementary files dictionary
guma44_GEOparse
train
py
15ba391b6267aa1da0806117db8d8ae427d8577d
diff --git a/examples/with-experimental-refresh/razzle.config.js b/examples/with-experimental-refresh/razzle.config.js index <HASH>..<HASH> 100644 --- a/examples/with-experimental-refresh/razzle.config.js +++ b/examples/with-experimental-refresh/razzle.config.js @@ -1,5 +1,5 @@ module.exports = { - experimental: { - reactRefresh: true, + opt: { + useReactRefresh: true, }, }
fix(examples): use correct option for react refresh
jaredpalmer_razzle
train
js
ad6def9b2de90e81fe050751f23070d969b100bf
diff --git a/test/unit/core/storage.spec.js b/test/unit/core/storage.spec.js index <HASH>..<HASH> 100644 --- a/test/unit/core/storage.spec.js +++ b/test/unit/core/storage.spec.js @@ -1,4 +1,4 @@ -describe.only('Storage', function() { +describe('Storage', function() { var keyOne = 'quasar-bogus-key-one',
fix(test): removed .only from storage.spec.js
quasarframework_quasar
train
js
8cba814869d29e408822d06727ad3664b9864004
diff --git a/app/src/components/CalibrationPanels/Introduction.js b/app/src/components/CalibrationPanels/Introduction.js index <HASH>..<HASH> 100644 --- a/app/src/components/CalibrationPanels/Introduction.js +++ b/app/src/components/CalibrationPanels/Introduction.js @@ -60,7 +60,7 @@ const PIP_OFFSET_CAL_INTRO_FRAGMENT = 'Calibrating' const PIP_OFFSET_CAL_EXPLANATION_FRAGMENT = 'enables the robot to accurately establish the location of the mounted pipette’s nozzle, relative to the deck.' const PIP_OFFSET_REQUIRES_TIP_LENGTH = - 'You don’t have a tip length saved with this pipette yet. You will need to calibrate tip length before calibrating you pipette offset.' + 'You don’t have a tip length saved with this pipette yet. You will need to calibrate tip length before calibrating your pipette offset.' const TIP_LENGTH_CAL_HEADER = 'tip length calibration' const TIP_LENGTH_CAL_NAME_FRAGMENT = 'Tip length'
fix(app): Fix a typo in introduction (#<I>) you pipette->your pipette
Opentrons_opentrons
train
js
4bd9e6ddcd32e073d79a20893b50c3989d35eb67
diff --git a/html/query.go b/html/query.go index <HASH>..<HASH> 100644 --- a/html/query.go +++ b/html/query.go @@ -80,7 +80,7 @@ func InnerText(n *html.Node) string { for child := n.FirstChild; child != nil; child = child.NextSibling { buf.WriteString(InnerText(child)) } - return buf.String() + return strings.TrimSpace(buf.String()) } func isSelfClosingTag(t string) bool {
refactor: remove white space for InnerText()
antchfx_xmlquery
train
go
6b4431be8f3b0f4182aae0c419dff70bbd55c76b
diff --git a/statuspage/statuspage.py b/statuspage/statuspage.py index <HASH>..<HASH> 100644 --- a/statuspage/statuspage.py +++ b/statuspage/statuspage.py @@ -149,7 +149,7 @@ def run_upgrade(name, token, org): ) if not is_same_content( content, - base64.b64decode(repo_template.content) + base64.b64decode(repo_template.content).decode('utf-8') ): repo.update_file( path=template, @@ -200,7 +200,7 @@ def run_update(name, token, org): ref=sha, ) - if is_same_content(content, base64.b64decode(index.content)): + if is_same_content(content, base64.b64decode(index.content).decode('utf-8')): click.echo("Local status matches remote status, no need to commit.") return False
fix: update encoding for issue #<I>: (#<I>) base<I>.b<I>decode(...) is of type 'str', which is not accepted by encode() in function is_same_content(). Converting the string to type 'unicode' before passing it to is_same_content() fixes the bug.
jayfk_statuspage
train
py
05752f21b43afdac3743c71c83c7f300ab4d5e1c
diff --git a/lib/client-request.js b/lib/client-request.js index <HASH>..<HASH> 100644 --- a/lib/client-request.js +++ b/lib/client-request.js @@ -72,15 +72,10 @@ class RequestRequest extends Request { const { body } = request if (body) { request.body = null - util.destroy(body, err) + request.runInAsyncScope(util.destroy, null, body, err) } - request.runInAsyncScope( - callback, - null, - err, - null - ) + request.runInAsyncScope(callback, null, err, null) } })
fix: destroy in async scope
mcollina_undici
train
js
b2baccf2cf6f318aac150f1b6d600bb02caf4e66
diff --git a/lib/components/user/monitored-trip/trip-notifications-pane.js b/lib/components/user/monitored-trip/trip-notifications-pane.js index <HASH>..<HASH> 100644 --- a/lib/components/user/monitored-trip/trip-notifications-pane.js +++ b/lib/components/user/monitored-trip/trip-notifications-pane.js @@ -32,7 +32,9 @@ const SettingsListWithAlign = styled(SettingsList)` display: table-row; & > * { display: table-cell; - margin-left: 10px; + } + & > label { + padding-right: 10px; } } ` @@ -162,7 +164,7 @@ class TripNotificationsPane extends Component { <option value={45}>45 min</option> <option value={60}>1 hour</option> </Select> - before it begins until it ends. + before it begins, until it ends. </li> </SettingsList> )}
refactor(TripNotificationsPane): Flush selectors to right margin. Tweak text. Change left-margin of selector into padding-right of label.
opentripplanner_otp-react-redux
train
js
57cb4b615de83427ce0c81d0fe7db3eb2c2e77cd
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -11,6 +11,10 @@ const connect = require('./lib/mongo_client').connect; connect.MongoError = core.MongoError; connect.MongoNetworkError = core.MongoNetworkError; connect.MongoTimeoutError = core.MongoTimeoutError; +connect.MongoParseError = core.MongoParseError; +connect.MongoWriteConcernError = core.MongoWriteConcernError; +connect.MongoBulkWriteError = require('./lib/bulk/common').BulkWriteError; +connect.BulkWriteError = connect.MongoBulkWriteError; // Actual driver classes exported connect.Admin = require('./lib/admin');
refactor: export all error types we use in the driver NODE-<I>
mongodb_node-mongodb-native
train
js
b0f41c7f860a803b9ec0cd8b0aa308d7d2b5ec17
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -315,7 +315,7 @@ var Config = function () { this.autoWatch = true this.autoWatchBatchDelay = 250 this.restartOnFileChange = false - this.usePolling = process.platform === 'darwin' || process.platform === 'linux' + this.usePolling = process.platform === 'linux' this.reporters = ['progress'] this.singleRun = false this.browsers = []
feat(config): remove polling usage - Remove polling usage for file change watching with chokidar on Mac OS Closes #<I>
karma-runner_karma
train
js
b979cea7f182d39f6e5f27b575e2e0c207c4ec4e
diff --git a/packages/ssr/src/lib/run-client.js b/packages/ssr/src/lib/run-client.js index <HASH>..<HASH> 100644 --- a/packages/ssr/src/lib/run-client.js +++ b/packages/ssr/src/lib/run-client.js @@ -32,8 +32,9 @@ const makeClient = options => { if (typeof window !== "undefined" && window.nuk) { const acsTnlCookie = window.nuk.getCookieValue("acs_tnl"); const sacsTnlCookie = window.nuk.getCookieValue("sacs_tnl"); - - networkInterfaceOptions.headers.Authorization = `Cookie acs_tnl=${acsTnlCookie};sacs_tnl=${sacsTnlCookie}`; + if (acsTnlCookie && sacsTnlCookie) { + networkInterfaceOptions.headers.Authorization = `Cookie acs_tnl=${acsTnlCookie};sacs_tnl=${sacsTnlCookie}`; + } } return new ApolloClient({
fix: only add acs and sacs cookies if they exist (#<I>)
newsuk_times-components
train
js
b0e823dc21a310cf0b90dcb6d678b898f81617c6
diff --git a/test/test-utils.js b/test/test-utils.js index <HASH>..<HASH> 100644 --- a/test/test-utils.js +++ b/test/test-utils.js @@ -8,6 +8,12 @@ var socketIoHandler = require('../lib/frontend/socket.io-handler'); function createMockedSender() { var sender = { + on: function() { + }, + removeAllListeners: function() { + }, + removeListener: function() { + }, emit: function(eventName, message) { this.messages.push({ eventName: eventName, message: message }); },
test: Add fake methods for dummy sender
droonga_express-droonga
train
js
615e59cfae3eeb906d99be09cff064a491433377
diff --git a/lib/pact/support/metrics.rb b/lib/pact/support/metrics.rb index <HASH>..<HASH> 100644 --- a/lib/pact/support/metrics.rb +++ b/lib/pact/support/metrics.rb @@ -1,7 +1,6 @@ require 'securerandom' require 'digest' require 'socket' -require 'pact/support/metrics' require 'pact/mock_service/version' require 'net/http'
fix: fix ruby `circular require` warning (#<I>)
pact-foundation_pact-mock_service
train
rb
9837d456a8b7cd8ef5f170b7bc41858957cc5e96
diff --git a/pycoin/ecdsa/native/openssl.py b/pycoin/ecdsa/native/openssl.py index <HASH>..<HASH> 100644 --- a/pycoin/ecdsa/native/openssl.py +++ b/pycoin/ecdsa/native/openssl.py @@ -98,7 +98,7 @@ def create_OpenSSLOptimizations(curve_id): openssl_group = OpenSSL.EC_GROUP_new_by_curve_name(curve_id) def multiply(self, p, e): - "Use OpenSSL to perform point mulitiplication." + "Use OpenSSL to perform point multiplication." if e == 0 or p == self._infinity: return self._infinity
docs: fix simple typo, mulitiplication -> multiplication There is a small typo in pycoin/ecdsa/native/openssl.py. Should read `multiplication` rather than `mulitiplication`.
richardkiss_pycoin
train
py
1067a235f6bc9870bd3bda5688987de5a070653c
diff --git a/stellar_sdk/account.py b/stellar_sdk/account.py index <HASH>..<HASH> 100644 --- a/stellar_sdk/account.py +++ b/stellar_sdk/account.py @@ -7,14 +7,14 @@ __all__ = ["Account"] class Account: - """The :class:`Account` object, which represents represents a single - account in Stellar network and its sequence number. + """The :class:`Account` object represents a single + account on the Stellar network and its sequence number. Account tracks the sequence number as it is used by :class:`TransactionBuilder <stellar_sdk.transaction_builder.TransactionBuilder>` See `Accounts`_ For more information about the formats used for asset codes and how issuers - work on Stellar's network, + work on Stellar, :param account_id: Account ID of the account (ex. `GB3KJPLFUYN5VL6R3GU3EGCGVCKFDSD7BEDX42HWG5BWFKB3KQGJJRMA`)
docs: update account.py (#<I>) Made grammatical changes to add clarity around Account object. No code changes, only comments to enhance documentation.
StellarCN_py-stellar-base
train
py
b7542234dca707b0611fe2dfb2da6a9c50a3e820
diff --git a/src/plugins/platform.js b/src/plugins/platform.js index <HASH>..<HASH> 100644 --- a/src/plugins/platform.js +++ b/src/plugins/platform.js @@ -220,7 +220,6 @@ export default { queues.takeover.push(q => { onSSR = fromSSR = false Object.assign(q.platform, getClientProperties()) - q.platform.has.touch = true }) Vue.util.defineReactive($q, 'platform', this) }
refactor: Remove debugging statement
quasarframework_quasar
train
js
471edbe5707c5b3d481225e1e10b4581111becc9
diff --git a/lib/renderers/Theme.js b/lib/renderers/Theme.js index <HASH>..<HASH> 100644 --- a/lib/renderers/Theme.js +++ b/lib/renderers/Theme.js @@ -9,7 +9,7 @@ class Theme { } dim (string) { - return chalk.dim(string) + return chalk.gray(string) } error (string) { diff --git a/lib/renderers/helpers/renderProgress.js b/lib/renderers/helpers/renderProgress.js index <HASH>..<HASH> 100644 --- a/lib/renderers/helpers/renderProgress.js +++ b/lib/renderers/helpers/renderProgress.js @@ -1,11 +1,9 @@ -const chalk = require('chalk') - module.exports = (task, theme) => { const { done, total } = task.progress const safeDone = Math.min(done, total) const percent = Math.ceil((safeDone / total) * 100) const bar = progressBar(percent, theme) - const status = chalk.dim(`${percent.toString().padStart(3, ' ')}%`) + const status = theme.dim(`${percent.toString().padStart(3, ' ')}%`) return `${bar} ${status}` }
fix(log): use gray instead of dim
hjvedvik_tasks
train
js,js
8e0c1dcaefea5c5399b2cbb974b3aa0a2d5d4065
diff --git a/packages/ringcentral-widgets/components/ContactDetails/i18n/en-US.js b/packages/ringcentral-widgets/components/ContactDetails/i18n/en-US.js index <HASH>..<HASH> 100644 --- a/packages/ringcentral-widgets/components/ContactDetails/i18n/en-US.js +++ b/packages/ringcentral-widgets/components/ContactDetails/i18n/en-US.js @@ -9,6 +9,7 @@ export default { [phoneTypes.home]: 'Home', [phoneTypes.business]: 'Business', [phoneTypes.fax]: 'Fax', + [phoneTypes.other]: 'Other', emailLabel: 'Email', call: 'Call', text: 'Text',
docs(ContactDetails): add phoneType.other for ContactDetails (#<I>)
ringcentral_ringcentral-js-widgets
train
js
cb4b4184587ca5f31cda63b31c6f3eb03c1a746a
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -163,8 +163,9 @@ ee(Object.defineProperties(SiteTree.prototype, assign({ // We need to unload all view nodes until common ancestor if (current) { common = find.call(current.ancestors, function (ancestor) { - return includes.call(this, ancestor); - }, node.ancestors); + if (ancestor === node) return true; + return includes.call(node.ancestors, ancestor); + }); while (current !== common) { current._unload(); current = current.parent; @@ -175,12 +176,13 @@ ee(Object.defineProperties(SiteTree.prototype, assign({ resetDocument(this.document); } - // Load all ancestor view nodes - node.ancestors.slice(0, node.ancestors.indexOf(current)).reverse().forEach(function (ancestor) { - ancestor._load(); - }); - // Load view node in question - node._load(); + if (current !== node) { + // Load all ancestor view nodes + node.ancestors.slice(0, node.ancestors.indexOf(current)).reverse() + .forEach(function (ancestor) { ancestor._load(); }); + // Load view node in question + node._load(); + } this.current = node; // Assure repaint after content change
refactor: improve nodes load resolution logic When moving from parent to child, child was unloaded and loaded unnecessarily
medikoo_site-tree
train
js
3fbd834e048012e16e37b94f2463a593525398e3
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -11,8 +11,6 @@ # All configuration values have a default; values that are commented out # serve to show the default. -import sys, os - # If extensions (or modules to document with autodoc) are in another directory, # add these directories to sys.path here. If the directory is relative to the # documentation root, use os.path.abspath to make it absolute, like shown here.
docs: removed unused imports from conf
tsuru_tsuru
train
py
8858ef6061c1c4406989e1408575f5f21c32cbcd
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -6,7 +6,9 @@ var path = require('path'); var env = process.env; var phantomjsPath = path.join(__dirname, '../bin'); -env.PHANTOMJS_EXECUTABLE = phantomjsPath + '/phantomjs_2.0'; +var isWin = /^win/.test(process.platform); +env.PHANTOMJS_EXECUTABLE = phantomjsPath + '/phantomjs_2.0' + + (isWin ? '.exe' : ''); env.PATH += ';' + phantomjsPath; var mgrUuid = uuid();
feat: support windows and unix platforms
damonjs_damon
train
js
fa69fc9ae4a2ec8eaffca6d0d669aee65490a71e
diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -88,6 +88,7 @@ module.exports = [{ 'mdl-fab': path.resolve('./packages/mdl-fab/mdl-fab.scss'), 'mdl-icon-toggle': path.resolve('./packages/mdl-icon-toggle/mdl-icon-toggle.scss'), 'mdl-list': path.resolve('./packages/mdl-list/mdl-list.scss'), + 'mdl-radio': path.resolve('./packages/mdl-radio/mdl-radio.scss'), 'mdl-ripple': path.resolve('./packages/mdl-ripple/mdl-ripple.scss'), 'mdl-theme': path.resolve('./packages/mdl-theme/mdl-theme.scss'), 'mdl-typography': path.resolve('./packages/mdl-typography/mdl-typography.scss')
fix(infrastructure): Add radio webpack css entry [ci skip] (#<I>)
material-components_material-components-web
train
js
0842729c1fc3bcf53163d1886e20d83b4bbfc615
diff --git a/test/socket.io.js b/test/socket.io.js index <HASH>..<HASH> 100644 --- a/test/socket.io.js +++ b/test/socket.io.js @@ -26,12 +26,6 @@ describe('socket.io', function(){ expect(version).to.be(require('socket.io-client/package').version); }); - it('should have the same protocol version as client', function() { - var pversion = require('socket.io-parser').protocol; - var cparser = require('socket.io-client/node_modules/socket.io-parser'); - expect(pversion).to.be(cparser.protocol); - }); - describe('set', function() { it('should be able to set ping timeout to engine.io', function() { var srv = io(http());
test: temporarily removing parser test
socketio_socket.io
train
js
7a06fad99ab6b4157635d79809d90bac5ac7bb96
diff --git a/actor-sdk/sdk-core/runtime/runtime-clc/src/main/java/im/actor/runtime/WebRTCRuntimeProvider.java b/actor-sdk/sdk-core/runtime/runtime-clc/src/main/java/im/actor/runtime/WebRTCRuntimeProvider.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core/runtime/runtime-clc/src/main/java/im/actor/runtime/WebRTCRuntimeProvider.java +++ b/actor-sdk/sdk-core/runtime/runtime-clc/src/main/java/im/actor/runtime/WebRTCRuntimeProvider.java @@ -19,7 +19,7 @@ public class WebRTCRuntimeProvider implements WebRTCRuntime { @NotNull @Override - public Promise<WebRTCMediaStream> getUserAudio() { + public Promise<WebRTCMediaStream> getUserMedia(boolean inVideoEnabled) { return null; }
fix(runtime): update clc WebRTCRuntimeProvider
actorapp_actor-platform
train
java
d8b51d21587829145e7b029c1375be095ebb631d
diff --git a/salt/states/pkgrepo.py b/salt/states/pkgrepo.py index <HASH>..<HASH> 100644 --- a/salt/states/pkgrepo.py +++ b/salt/states/pkgrepo.py @@ -311,10 +311,10 @@ def managed(name, ppa=None, **kwargs): """ if "refresh_db" in kwargs: salt.utils.versions.warn_until( - "Neon", + "Sodium", "The 'refresh_db' argument to 'pkg.mod_repo' has been " "renamed to 'refresh'. Support for using 'refresh_db' will be " - "removed in the Neon release of Salt.", + "removed in the Sodium release of Salt.", ) kwargs["refresh"] = kwargs.pop("refresh_db")
fix(pkgrepo): fix regression with `refresh_db` warning for `Neon` * Regression detected during weekly test of Salt's `master` branch using the Formula's CI - Both instances now failing: <URL> * Confirmed this fixes the regression: - Both instances now passing: <URL>
saltstack_salt
train
py
1cdf9a5a78e7add897d23e51b45b1e2e264474be
diff --git a/packages/cwp-template-aws/cli/deploy/deploy.js b/packages/cwp-template-aws/cli/deploy/deploy.js index <HASH>..<HASH> 100644 --- a/packages/cwp-template-aws/cli/deploy/deploy.js +++ b/packages/cwp-template-aws/cli/deploy/deploy.js @@ -17,7 +17,9 @@ const deploy = (stack, inputs) => { "--debug", Boolean(inputs.debug), "--build", - Boolean(inputs.build) + Boolean(inputs.build), + "--preview", + Boolean(inputs.preview) ], { stdio: "inherit" diff --git a/packages/cwp-template-aws/cli/deploy/index.js b/packages/cwp-template-aws/cli/deploy/index.js index <HASH>..<HASH> 100644 --- a/packages/cwp-template-aws/cli/deploy/index.js +++ b/packages/cwp-template-aws/cli/deploy/index.js @@ -18,6 +18,12 @@ module.exports = () => ({ describe: `Build packages before deploying`, type: "boolean" }); + yargs.option("preview", { + required: false, + default: false, + describe: `Preview the deploy instead of actually performing it`, + type: "boolean" + }); yargs.option("debug", { required: false, default: false,
feat: enable "--preview" flag for "webiny deploy" Might be useful for CI/CD.
Webiny_webiny-js
train
js,js
6e5c39ee4c758b239884885ac0267d45f2de1201
diff --git a/lib/plugins/aws/info/index.js b/lib/plugins/aws/info/index.js index <HASH>..<HASH> 100644 --- a/lib/plugins/aws/info/index.js +++ b/lib/plugins/aws/info/index.js @@ -47,6 +47,8 @@ class AwsInfo { }), 'before:aws:info:validate': () => { + const isDeployCommand = this.serverless.processedInput.commands.join(' ') === 'deploy'; + if (!isDeployCommand) return; mainProgress.notice('Retrieving CloudFormation stack info', { isMainEvent: true }); }, 'aws:info:validate': async () => BbPromise.bind(this).then(this.validate),
refactor(CLI): Do not show progress bar in `info` command
serverless_serverless
train
js
5439e08b3530e4a2b7d6e6df6a02d9708ba80b08
diff --git a/webapps/webapp/src/main/resources-plugin/decisionList/app/views/decisionDefinition/decisionInstanceTable.js b/webapps/webapp/src/main/resources-plugin/decisionList/app/views/decisionDefinition/decisionInstanceTable.js index <HASH>..<HASH> 100644 --- a/webapps/webapp/src/main/resources-plugin/decisionList/app/views/decisionDefinition/decisionInstanceTable.js +++ b/webapps/webapp/src/main/resources-plugin/decisionList/app/views/decisionDefinition/decisionInstanceTable.js @@ -78,14 +78,12 @@ function(angular, template) { }, function(err, data) { $scope.decisionInstances = data; $scope.loadingState = data.length ? 'LOADED' : 'EMPTY'; - $scope.$apply(); }); historyService.decisionInstanceCount({ decisionDefinitionId: $scope.decisionDefinition.id }, function(err, data) { pages.total = data.count; - $scope.$apply(); }); }
chore(decision): remove unnecessary $apply() calls related to CAM-<I>
camunda_camunda-bpm-platform
train
js
806ecf73854bd804f9b67079e97fe4c7c7ef3427
diff --git a/lib/middleware/simple-authentication.js b/lib/middleware/simple-authentication.js index <HASH>..<HASH> 100644 --- a/lib/middleware/simple-authentication.js +++ b/lib/middleware/simple-authentication.js @@ -34,7 +34,7 @@ function unsecureAuthentication(basePath = '', app) { path: `${basePath}/api/admin/login`, type: 'unsecure', message: - 'You have to indentify yourself in order to use Unleash.', + 'You have to identify yourself in order to use Unleash.', }), ) .end();
fix: typo in message in simple-authentication.js (#<I>) `lib/middleware/simple-authentication.js`
Unleash_unleash
train
js
1117f1a7b2c66d65da3223583a63fcfdcfa250c5
diff --git a/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/CryptoRuntimeProvider.java b/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/CryptoRuntimeProvider.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/CryptoRuntimeProvider.java +++ b/actor-sdk/sdk-core/runtime/runtime-shared/src/template/java/im/actor/runtime/CryptoRuntimeProvider.java @@ -1,5 +1,6 @@ package im.actor.runtime; +import im.actor.runtime.crypto.BlockCipher; import im.actor.runtime.crypto.Digest; public class CryptoRuntimeProvider implements CryptoRuntime { @@ -10,6 +11,11 @@ public class CryptoRuntimeProvider implements CryptoRuntime { } @Override + public BlockCipher AES128(byte[] key) { + throw new RuntimeException("Dumb"); + } + + @Override public void waitForCryptoLoaded() { throw new RuntimeException("Dumb"); }
fix(runtime): Fixing template class
actorapp_actor-platform
train
java
243293a63b71672befaa393ad4ff6bd94d4c8e3d
diff --git a/src/lang/en/mail.php b/src/lang/en/mail.php index <HASH>..<HASH> 100644 --- a/src/lang/en/mail.php +++ b/src/lang/en/mail.php @@ -1,6 +1,6 @@ <?php -return[ - 'emails.auth.reminder'=>'User - Email Reminder', - 'mail.emails.password'=>'User - Email Reminder', +return [ + 'emails.auth.reminder' => 'User - Email Reminder', + 'emails.password' => 'User - Email Reminder', ]; \ No newline at end of file
fix(translation): Fix the translation of actions in email form
Distilleries_Expendable
train
php
09fec430734c6433235f8dfb2e3fc3ca2ba601d5
diff --git a/src/label/base.js b/src/label/base.js index <HASH>..<HASH> 100644 --- a/src/label/base.js +++ b/src/label/base.js @@ -72,9 +72,13 @@ class Label extends Component { */ destroy() { const group = this.get('group'); + const container = this.get('container'); if (!group.destroy) { group.destroy(); } + if (container) { + container.innerHTML = ''; + } } /**
feat: empty container if label is to destroyed
antvis_component
train
js
3256ff1c73672aaacf9df74367f81c28e94b4f5a
diff --git a/gulpfile.js b/gulpfile.js index <HASH>..<HASH> 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -384,6 +384,14 @@ gulp.task('test.unit.js', ['build.js.dev'], function (neverDone) { }); }); +gulp.task('watch.js.dev', ['build.js.dev'], function (neverDone) { + watch('modules/**', function() { + runSequence( + '!broccoli.js.dev' + ); + }); +}); + gulp.task('!test.unit.js/karma-server', function() { karma.server.start({configFile: __dirname + '/karma-js.conf.js'});
feat(gulpfuile): added watch.js.dev
angular_angular
train
js
b476b80ccb28073d8280a029bdf88c34c5b8cb11
diff --git a/packages/cozy-konnector-libs/src/libs/linker/billsToOperation/operationsFilters.js b/packages/cozy-konnector-libs/src/libs/linker/billsToOperation/operationsFilters.js index <HASH>..<HASH> 100644 --- a/packages/cozy-konnector-libs/src/libs/linker/billsToOperation/operationsFilters.js +++ b/packages/cozy-konnector-libs/src/libs/linker/billsToOperation/operationsFilters.js @@ -20,7 +20,8 @@ const HEALTH_VENDORS = [ 'ascoreSante', 'EoviMCD', 'Humanis', - 'Alan' + 'Alan', + 'lamutuellegenerale' ] // TODO: to import from each konnector const HEALTH_EXPENSE_CAT = '400610' const HEALTH_INSURANCE_CAT = '400620'
feat: add lamutuellegeneral as health vendor
konnectors_libs
train
js
43511ca1ca36dce16be60c20ccea68c035584c88
diff --git a/test/units/socks.test.js b/test/units/socks.test.js index <HASH>..<HASH> 100644 --- a/test/units/socks.test.js +++ b/test/units/socks.test.js @@ -1,10 +1,6 @@ var util = require('../util.test'); module.exports = function() { - // socks5模块的server在Node10上无法启动 - if (process.versions.modules >= 64) { - return; - } util.request('http://socks1.w2.org/index.html', function(res, data) { data.port.should.be.equal(1080); });
test: socksv5 -> sockx
avwo_whistle
train
js
9ca374d0babdca527e3cf37dfbd5d1d6df5e9c5d
diff --git a/src/render/index.js b/src/render/index.js index <HASH>..<HASH> 100644 --- a/src/render/index.js +++ b/src/render/index.js @@ -70,11 +70,13 @@ export function renderToProgram(node: MDASTRootNode, config: RenderConfig): JSAS let statements = stmt` export default function Document({className, style}) { return React.createElement(DocumentContext, - {context: {metadata, model}}, + {context: {meta}}, React.cloneElement(${expression}, {className, style})); } - export let metadata = ${buildJSON(metadata)}; - export let model = ${buildJSON(model)}; + export let meta = { + data: ${buildJSON(metadata)}, + model: ${buildJSON(model)}, + }; `; identifiersUsed.forEach(identifier => {
refactor: expose single key meta for metadata and model
andreypopp_reactdown
train
js
8dc35003c8ac1de720ac0894e96a09299dd18d40
diff --git a/lib/validate-ast/index.js b/lib/validate-ast/index.js index <HASH>..<HASH> 100644 --- a/lib/validate-ast/index.js +++ b/lib/validate-ast/index.js @@ -2,8 +2,8 @@ const result = require('./result'); -const noImportInTemplates = require('./no-imports-in-templates'); -const noTemplateNesting = require('./no-template-nesting'); +const noImportInTemplates = require('./rules/no-imports-in-templates'); +const noTemplateNesting = require('./rules/no-template-nesting'); const rootElements = require('./rules/root-elements'); const singleDefaultTemplate = require('./rules/single-default-template'); const importsNesting = require('./rules/imports-nesting');
fix(validation): fix rules import path
simonrelet_react-pure-html-component-loader
train
js
017c18aa3d6b2ccdc1ff5db7b61f52b9f2d974d4
diff --git a/lib/Client.js b/lib/Client.js index <HASH>..<HASH> 100644 --- a/lib/Client.js +++ b/lib/Client.js @@ -1093,7 +1093,7 @@ class Client extends EventEmitter { return Promise.resolve(); } if(messageIDs.length === 1) { - return this.deleteMessage(channelID, messageIDs[0]); + return this.deleteMessage(channelID, messageIDs[0], reason); } const oldestAllowedSnowflake = (Date.now() - 1421280000000) * 4194304; @@ -1106,7 +1106,7 @@ class Client extends EventEmitter { return this.requestHandler.request("POST", Endpoints.CHANNEL_BULK_DELETE(channelID), true, { messages: messageIDs.splice(0, 100), reason: reason - }).then(() => this.deleteMessages(channelID, messageIDs)); + }).then(() => this.deleteMessages(channelID, messageIDs, reason)); } return this.requestHandler.request("POST", Endpoints.CHANNEL_BULK_DELETE(channelID), true, { messages: messageIDs,
fix(deleteMessages): Pass reason param into subsequent calls (#<I>)
abalabahaha_eris
train
js
047e529fe4c888196c995ebc78c9354220a50a9b
diff --git a/teslajsonpy/connection.py b/teslajsonpy/connection.py index <HASH>..<HASH> 100644 --- a/teslajsonpy/connection.py +++ b/teslajsonpy/connection.py @@ -78,9 +78,13 @@ class Connection: elif refresh_token: self.oauth["grant_type"] = "refresh_token" self.oauth["refresh_token"] = refresh_token + elif not refresh_token: + raise IncompleteCredentials( + "Missing oauth authentication details: refresh token." + ) else: raise IncompleteCredentials( - "Connection requires email and password or refresh token to authenticate." + "Missing oauth authentication details: email and password." ) async def get(self, command): diff --git a/teslajsonpy/exceptions.py b/teslajsonpy/exceptions.py index <HASH>..<HASH> 100644 --- a/teslajsonpy/exceptions.py +++ b/teslajsonpy/exceptions.py @@ -15,6 +15,9 @@ class TeslaException(Exception): self.message = "" super().__init__(*args, **kwargs) self.code = code + if isinstance(code, str): + self.message = self.code + return if self.code == 401: self.message = "UNAUTHORIZED" elif self.code == 404:
refactor: improve incomplete credentials message
zabuldon_teslajsonpy
train
py,py
d80a442c48ed117536cf13001cb93ca75171bdf2
diff --git a/lib/openapi.js b/lib/openapi.js index <HASH>..<HASH> 100644 --- a/lib/openapi.js +++ b/lib/openapi.js @@ -4,6 +4,7 @@ module.exports = { findEndpointNameDeprecation } +const { resolve: pathResolve } = require('path') const { readdirSync } = require('fs') const { URL } = require('url') @@ -13,7 +14,7 @@ const urlTemplate = require('url-template') const { stringify } = require('javascript-stringify') const PUBLIC_API = 'api.github.com' -const APIS = readdirSync('openapi') +const APIS = readdirSync(pathResolve(__dirname, '..', 'openapi')) const mapValuesDeep = (v, callback) => { if (_.isArray(v)) {
fix: make `readdirSync` look for `openapi` folder relative to current path Otherwise it breaks when used as node module
octokit_routes
train
js
534bcb5b9442d81a9ebdb564f192b779d19bfa80
diff --git a/lib/https/server-agent.js b/lib/https/server-agent.js index <HASH>..<HASH> 100644 --- a/lib/https/server-agent.js +++ b/lib/https/server-agent.js @@ -1,7 +1,7 @@ var tls = require('tls'); var Q = require('q'); var ca = require('./ca'); -var MAX_SERVERS = 512; +var MAX_SERVERS = 360; var MAX_PORT = 60000; var curPort = 40000; var TIMEOUT = 6000;
refactor: Set MAX_SERVERS = <I>
avwo_whistle
train
js
29bae1453a6f382ca9839233c7e1709f2730af5a
diff --git a/config/karma.conf.js b/config/karma.conf.js index <HASH>..<HASH> 100644 --- a/config/karma.conf.js +++ b/config/karma.conf.js @@ -8,7 +8,7 @@ module.exports = function(config) { 'src/*.js' ], port: 9876, - reporters: ['progress', 'coverage', 'coveralls'], + reporters: ['progress', 'coverage'], preprocessors: { 'src/form-validation.js': ['coverage'] }, @@ -36,6 +36,8 @@ module.exports = function(config) { if(process.env.TRAVIS){ configuration.browsers = ['Chrome_travis_ci']; + + configuration.reporters.push('coveralls'); } config.set(configuration);
chore: only include coveralls reporter in travis build
assisrafael_angular-bootstrap-form-validation
train
js
7c88ca3415cbbd4380b60e0c0e24a6cb77756785
diff --git a/test/instrumentation/modules/http/disabling.js b/test/instrumentation/modules/http/disabling.js index <HASH>..<HASH> 100644 --- a/test/instrumentation/modules/http/disabling.js +++ b/test/instrumentation/modules/http/disabling.js @@ -35,7 +35,7 @@ if (cluster.isMaster) { function assertSpan (t, span) { t.ok(/GET localhost:\d+\//.test(span.name), 'span name') - t.equal(span.type, 'ext.http.http', 'span type') + t.equal(span.type, 'external.http.http', 'span type') } t.test('incoming enabled + outgoing enabled', makeTest({
test: fix http disabling test (#<I>) The PR #<I> introduced a bug in the tests as it expected the span.type for outgoing http requests to start with `ext.*`. This was changed to `external.*` in the PR #<I>, but #<I> was just never updated to be up to date with master before it was merged.
elastic_apm-agent-nodejs
train
js
dee9c1a27cb0e035eda685cf383bb7ca08b8289f
diff --git a/core/src/elements/ons-alert-dialog/index.js b/core/src/elements/ons-alert-dialog/index.js index <HASH>..<HASH> 100644 --- a/core/src/elements/ons-alert-dialog/index.js +++ b/core/src/elements/ons-alert-dialog/index.js @@ -216,6 +216,9 @@ class AlertDialogElement extends BaseElement { } createdCallback() { + contentReady(this, () => { + this._compile(); + }); this._visible = false; this._doorLock = new DoorLock();
fix(ons-alert-dialog): compile in `createdCallback`
OnsenUI_OnsenUI
train
js
1229f4467529b2257fea1f090de96d8917b9b4e3
diff --git a/server/plugins/client/index.js b/server/plugins/client/index.js index <HASH>..<HASH> 100644 --- a/server/plugins/client/index.js +++ b/server/plugins/client/index.js @@ -32,6 +32,27 @@ function register (server, options, next) { } resolve(bundleBuffer) + + if (!hasUpdate) { + log.info('client', 'bundle is up to date') + return + } + + if (options.config.inMemory) { + log.silly('client', 'running in memory, not writing bundle to ' + bundleTargetPath) + return + } + + log.info('client', 'bundle is out of date') + log.silly('client', 'writing bundle to ' + bundleTargetPath) + fs.writeFile(bundleTargetPath, bundleBuffer, function (error) { + if (error) { + log.warn('client', 'could not write to ' + bundleTargetPath + '. Bundle cannot be cached and will be re-generated on server restart') + return + } + + log.info('client', 'bundle written to ' + bundleTargetPath) + }) }) }) }
feat: write client bundle for caching (unless in memory)
hoodiehq_hoodie
train
js
4681505823ef8788cc0ac72c8c309194995b9cbb
diff --git a/src/reporters/ci-reporter.js b/src/reporters/ci-reporter.js index <HASH>..<HASH> 100644 --- a/src/reporters/ci-reporter.js +++ b/src/reporters/ci-reporter.js @@ -16,16 +16,7 @@ module.exports = { * false otherwise */ canRun() { - try { - const getNpmArgs = require('../utils/get-npm-args'); - const getNpxArgs = require('../utils/get-npx-args'); - return ( - typeof getNpmArgs === 'function' && - typeof getNpxArgs === 'function' - ); - } catch (_error) { - return false; - } + return true; }, /** * Check if this reporter should be used
refactor(ci-reporter): simplify code
inikulin_publish-please
train
js
62a2b9e88c0ef336262167fbc34ab0da24d2cfdf
diff --git a/lib/util/query-params.js b/lib/util/query-params.js index <HASH>..<HASH> 100644 --- a/lib/util/query-params.js +++ b/lib/util/query-params.js @@ -124,7 +124,7 @@ const queryParams = [ name: 'maxWalkDistance', routingTypes: [ 'ITINERARY' ], applicable: query => query.mode && query.mode.indexOf('WALK') !== -1, - default: 804.7, // 0.5 mi. + default: 1207, // 3/4 mi. selector: 'DROPDOWN', label: 'Maximum Walk', options: [ @@ -161,7 +161,7 @@ const queryParams = [ name: 'maxBikeDistance', routingTypes: [ 'ITINERARY' ], applicable: query => query.mode && query.mode.indexOf('BICYCLE') !== -1, - default: 3219, // 2 mi. + default: 4828, // 3 mi. selector: 'DROPDOWN', label: 'Maximum Bike', options: [ @@ -181,6 +181,9 @@ const queryParams = [ text: '2 miles', value: 3219 }, { + text: '3 miles', + value: 4828 + }, { text: '5 miles', value: 8047 }, {
feat(form): Update default query params for max walk/bike distance
opentripplanner_otp-react-redux
train
js
98ac3875ae9ed93b7c1dc5f7757ae3dffaf77fa4
diff --git a/test/ModalSpec.js b/test/ModalSpec.js index <HASH>..<HASH> 100644 --- a/test/ModalSpec.js +++ b/test/ModalSpec.js @@ -161,6 +161,24 @@ describe('<Modal>', () => { ).find('.modal-dialog.modal-sm'); }); + it('Should pass centered to the dialog', () => { + const noOp = () => {}; + mount( + <Modal show centered onHide={noOp}> + <strong>Message</strong> + </Modal>, + ).find('.modal-dialog.modal-dialog-centered'); + }); + + it('Should pass scrollable to the dialog', () => { + const noOp = () => {}; + mount( + <Modal show scrollable onHide={noOp}> + <strong>Message</strong> + </Modal>, + ).find('.modal-dialog.modal-dialog-scrollable'); + }); + it('Should pass dialog style to the dialog', () => { const noOp = () => {}; const dialog = mount(
test: Increase modal test coverage (#<I>) * tests/modal: added coverage for 'centered' modal prop Asserts that passing 'centered' prop to the modal component will render that as a css class on the modal element Issue <I> * tests/modal: added coverage for 'scrollable' modal prop Asserts that passing 'scrollable' prop to the modal component will render that as a css class on the modal element Issue <I>
react-bootstrap_react-bootstrap
train
js
0a17d8231de50c1fb2b6f99e4d110e651f4fd4b4
diff --git a/pgjdbc/src/test/java/org/postgresql/test/jdbc4/ArrayTest.java b/pgjdbc/src/test/java/org/postgresql/test/jdbc4/ArrayTest.java index <HASH>..<HASH> 100644 --- a/pgjdbc/src/test/java/org/postgresql/test/jdbc4/ArrayTest.java +++ b/pgjdbc/src/test/java/org/postgresql/test/jdbc4/ArrayTest.java @@ -115,6 +115,9 @@ public class ArrayTest extends BaseTest4 { @Test public void testCreateArrayOfMultiJson() throws SQLException { + if (!TestUtil.haveMinimumServerVersion(_conn, "9.2")) { + return; + } PreparedStatement pstmt = _conn.prepareStatement("SELECT ?::json[]"); PGobject p1 = new PGobject(); p1.setType("json");
test: skip json testing on pre-<I> databases (those do not implement json type)
pgjdbc_pgjdbc
train
java
d7dc9aaf526f41ef7849236c892c49f4cd3e7701
diff --git a/cmd/utils.go b/cmd/utils.go index <HASH>..<HASH> 100644 --- a/cmd/utils.go +++ b/cmd/utils.go @@ -427,12 +427,10 @@ func newCustomHTTPTransport(tlsConfig *tls.Config, dialTimeout, dialKeepAlive ti tr := &http.Transport{ Proxy: http.ProxyFromEnvironment, DialContext: newCustomDialContext(dialTimeout, dialKeepAlive), - MaxIdleConns: 256, MaxIdleConnsPerHost: 256, - IdleConnTimeout: 30 * time.Second, + IdleConnTimeout: 60 * time.Second, TLSHandshakeTimeout: 10 * time.Second, - ResponseHeaderTimeout: 10 * time.Second, - ExpectContinueTimeout: 3 * time.Second, + ExpectContinueTimeout: 10 * time.Second, TLSClientConfig: tlsConfig, // Go net/http automatically unzip if content-type is // gzip disable this feature, as we are always interested
fix: remove response header timeout (#<I>) Adding respone header timeout seems to have premature timeout like consequences which leads to potential disconnections.
minio_minio
train
go
1ddb71feb145e9456b6ddcf252d9484fdff7c76c
diff --git a/test/helpers/runner.js b/test/helpers/runner.js index <HASH>..<HASH> 100644 --- a/test/helpers/runner.js +++ b/test/helpers/runner.js @@ -28,7 +28,12 @@ function spawnCli(args, inPath) { var expect = nspawn(node, nodeArgs, opts); expect._run = expect.run; expect.run = function(callback) { - var child = this._run(callback); + var child = this._run(function() { + if (callback) { + callback.apply(this, arguments); + callback = null; + } + }); child.stdout.on('data', function(data) { debug('nspawn stdout:', data.toString()); });
test: ensure nexpect only calls callback once
strongloop_strongloop
train
js
20f7eee8ccf84a44c03c41986817af2f025f6b38
diff --git a/public/vendor/flot/jquery.flot.js b/public/vendor/flot/jquery.flot.js index <HASH>..<HASH> 100644 --- a/public/vendor/flot/jquery.flot.js +++ b/public/vendor/flot/jquery.flot.js @@ -1663,8 +1663,10 @@ Licensed under the MIT license. delta = max - min; if (delta == 0.0) { - // degenerate case - var widen = max == 0 ? 1 : 0.01; + // Grafana fix: wide Y min and max using increased wideFactor + // when all series values are the same + var wideFactor = 0.25; + var widen = max == 0 ? 1 : max * wideFactor; if (opts.min == null) min -= widen;
fix(graph): increase Y min and max range when series values are the same, (#<I>) fixes #<I>, #<I>.
grafana_grafana
train
js
5c7fcc0ed50691d4d732ed6382dc45e369dcda9f
diff --git a/anyconfig/backends.py b/anyconfig/backends.py index <HASH>..<HASH> 100644 --- a/anyconfig/backends.py +++ b/anyconfig/backends.py @@ -271,6 +271,6 @@ def list_types(cps=_PARSERS_BY_TYPE): if cps is None: cps = _list_parsers_by_type(PARSERS) - return sorted(set(zip(*cps)[0])) + return sorted(set(next(anyconfig.compat.izip(*cps)))) # vim:sw=4:ts=4:et:
fix: make .backends.list_types worked with python 3
ssato_python-anyconfig
train
py
2ddd90ecc4452eeb4c089a0a99b8664fde461b7c
diff --git a/lib/cistern/request.rb b/lib/cistern/request.rb index <HASH>..<HASH> 100644 --- a/lib/cistern/request.rb +++ b/lib/cistern/request.rb @@ -54,9 +54,8 @@ module Cistern::Request @cistern = cistern end - # @fixme remove _{mock,real} methods and call {mock,real} directly before 3.0 release. def call(*args) - cistern.mocking? ? dispatch(:mock, *args) : dispatch(:real, *args) + dispatch(*args) end def real(*) @@ -67,9 +66,12 @@ module Cistern::Request raise NotImplementedError end - private + protected + + # @fixme remove _{mock,real} methods and call {mock,real} directly before 3.0 release. + def dispatch(*args) + to = cistern.mocking? ? :mock : :real - def dispatch(to, *args) legacy_method = :"_#{to}" if respond_to?(legacy_method)
refactor(request): move mode conditional into #dispatch
lanej_cistern
train
rb
82a66d556a38d4ebe4cb532a39429c79ab17de93
diff --git a/packages/patternfly-4/react-core/src/components/Text/examples/BodyText.js b/packages/patternfly-4/react-core/src/components/Text/examples/BodyText.js index <HASH>..<HASH> 100644 --- a/packages/patternfly-4/react-core/src/components/Text/examples/BodyText.js +++ b/packages/patternfly-4/react-core/src/components/Text/examples/BodyText.js @@ -17,9 +17,6 @@ class BodyText extends React.Component { </Text> . Phasellus lacus ex, semper ac tortor nec, fringilla condimentum orci. Fusce eu rutrum tellus. </Text> - <Text component={TextVariants.pre}> - Aliquam sagittis rhoncus vulputate. Cras non luctus sem, sed tincidunt ligula. - </Text> <Text component={TextVariants.blockquote}> Ut venenatis, nisl scelerisque sollicitudin fermentum, quam libero hendrerit ipsum, ut blandit est tellus sit amet turpis.
docs(Text): remove pre Text example (#<I>) Leaving pre in TextVariants due to usage in livedemo
patternfly_patternfly-react
train
js
41686859bbf5033df87dedc22f5fd9532ddcdd57
diff --git a/src/helpers/config.js b/src/helpers/config.js index <HASH>..<HASH> 100644 --- a/src/helpers/config.js +++ b/src/helpers/config.js @@ -37,9 +37,11 @@ export const getKonnectorField = (slug, field) => { return fromEnv } - const config = JSON.parse(process.env.KONNECTOR_CONFIG) - if (config && config.fields && config.fields[field]) { - return config.fields[field] + if (process.env.KONNECTOR_CONFIG) { + const config = JSON.parse(process.env.KONNECTOR_CONFIG) + if (config && config.fields && config.fields[field]) { + return config.fields[field] + } } return conf.get(`konnector.${slug}.${field}`)
fix: when KONNECTOR_CONFIG is not enquire 🐛
konnectors_konitor
train
js
3d9d36a16abb5dc2f670990cf3c933cc37fb694d
diff --git a/wayback-core/src/main/java/org/archive/wayback/accesscontrol/robotstxt/AccessControlChecker.java b/wayback-core/src/main/java/org/archive/wayback/accesscontrol/robotstxt/AccessControlChecker.java index <HASH>..<HASH> 100644 --- a/wayback-core/src/main/java/org/archive/wayback/accesscontrol/robotstxt/AccessControlChecker.java +++ b/wayback-core/src/main/java/org/archive/wayback/accesscontrol/robotstxt/AccessControlChecker.java @@ -35,7 +35,7 @@ public class AccessControlChecker extends AbstractRequestHandler { } PrintWriter writer = httpResponse.getWriter(); - httpResponse.setContentType("text/plain"); + httpResponse.setContentType("application/json"); return checkAccess(url, writer); } @@ -60,7 +60,7 @@ public class AccessControlChecker extends AbstractRequestHandler { status = filter.filterObject(result); } catch (URIException e) { //Exclude invalid - } + } if (status == ExclusionFilter.FILTER_INCLUDE) { writer.println("[\"allow\"]");
fix: change AccessControlChecker Content-Type to application/json
iipc_openwayback
train
java