hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
70bce90b7f1df2bbcbf9bfd4a638a20952b3bc33
diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -28,8 +28,12 @@ var config = { ] }, output: { - library: 'ReactWebAnimation', - libraryTarget: 'umd' + library: { + root: 'ReactWebAnimation', + amd: 'react-web-animation', + }, + libraryTarget: 'umd', + umdNamedDefine: true, }, plugins: [ new LodashModuleReplacementPlugin(),
feat(repo): Include module name in AMD definition RequireJS needs to know which name to register an AMD module under. The name was previously mixing; this PR fixes that.
bringking_react-web-animation
train
js
5ab078bb7237d93a15de3d7f4c959146ee246a29
diff --git a/anytemplate/tests/globals.py b/anytemplate/tests/globals.py index <HASH>..<HASH> 100644 --- a/anytemplate/tests/globals.py +++ b/anytemplate/tests/globals.py @@ -12,6 +12,7 @@ class Test(unittest.TestCase): def test_10_null_handler(self): logger = TT.logging.getLogger(__name__) logger.addHandler(TT.NullHandler_()) + logger.debug("aaa") def test_20_logger(self): TT.LOGGER.info("test log")
refactor: add a (dummy) test case of logging handler's emitter
ssato_python-anytemplate
train
py
5f81dbcb01e923f821de830efe015df2d9c4ba69
diff --git a/tests/test_file.py b/tests/test_file.py index <HASH>..<HASH> 100644 --- a/tests/test_file.py +++ b/tests/test_file.py @@ -131,7 +131,7 @@ def test_save_with_specified_key_but_without_master_key(): # type: () -> None try: f.save() except LeanCloudError as e: - if e.code == 1 and e.message.startswith("Unsupported file key"): + if e.code == 1 and e.error.startswith("Unsupported file key"): pass
test: python 2 & 3 compatibility issue
leancloud_python-sdk
train
py
d4d9833224795b274a2f12f89d3af75faa1b33f4
diff --git a/dev/test/cypress/integration/web-extend.spec.js b/dev/test/cypress/integration/web-extend.spec.js index <HASH>..<HASH> 100644 --- a/dev/test/cypress/integration/web-extend.spec.js +++ b/dev/test/cypress/integration/web-extend.spec.js @@ -32,7 +32,10 @@ describe('Web extend scripts', function() { });`; win.document.head.appendChild(testScriptNode); }); + }); + afterEach(() => { + cy.logout(); }); it('should include web-extend scripts', function() {
feat(cypress): logout after each test in web-extend cases CDPIP-OPS
emartech_magento2-extension
train
js
cb50241e6fa7c95891925c8b18840c17df078620
diff --git a/src/util/Constants.js b/src/util/Constants.js index <HASH>..<HASH> 100644 --- a/src/util/Constants.js +++ b/src/util/Constants.js @@ -75,7 +75,7 @@ exports.DefaultOptions = { /** * HTTP options * @typedef {Object} HTTPOptions - * @property {number} [version=7] API version to use + * @property {number} [version=8] API version to use * @property {string} [api='https://discord.com/api'] Base url of the API * @property {string} [cdn='https://cdn.discordapp.com'] Base url of the CDN * @property {string} [invite='https://discord.gg'] Base url of invites
fix(HTTPOptions): change default value in jsdoc to 8 (#<I>)
discordjs_discord.js
train
js
cb40a72b5e5edcbe32532d75b1535df56ca1d456
diff --git a/packages/site/pages/utils/icon.js b/packages/site/pages/utils/icon.js index <HASH>..<HASH> 100644 --- a/packages/site/pages/utils/icon.js +++ b/packages/site/pages/utils/icon.js @@ -37,10 +37,10 @@ export default _ => ( <SectionHeading>Formating</SectionHeading> <P> - Icons must be monochromatic. Flattening SVGs before usage is - recommended. + Icons must be monochromatic and their filenames dash-cased. Flattening + SVGs before usage is recommended. </P> - <P>Formating svg files:</P> + <P>Formating svg files(dash-cased.svg):</P> <Doc> {`- **viewbox**: \`0 0 24 24\` - **role**: \`img\`
docs(site): document req to dash-case svg filename for cli
pluralsight_design-system
train
js
0317954af8fea3fb6ca3021564eaa026e241e595
diff --git a/tests/Keboola/Provisioning/Client/SnowflakeTest.php b/tests/Keboola/Provisioning/Client/SnowflakeTest.php index <HASH>..<HASH> 100644 --- a/tests/Keboola/Provisioning/Client/SnowflakeTest.php +++ b/tests/Keboola/Provisioning/Client/SnowflakeTest.php @@ -156,7 +156,7 @@ class Keboola_ProvisioningClient_SnowflakeTest extends \ProvisioningTestCase $this->dbQuery($conn); try { - odbc_exec($conn, "CALL SYSTEM\$WAIT(20);"); + odbc_exec($conn, "CALL SYSTEM\$WAIT(70);"); $this->fail("Query didn't time out."); } catch(\PHPUnit_Framework_Error_Warning $e) { $this->assertContains("timeout", $e->getMessage());
fix(tests): adjust for temporary longer statement timeout
keboola_provisioning-client
train
php
62b561bf32d0699271f417cd022982ea8fb63141
diff --git a/helpers/helpers.go b/helpers/helpers.go index <HASH>..<HASH> 100644 --- a/helpers/helpers.go +++ b/helpers/helpers.go @@ -123,8 +123,6 @@ func StartServer( } t.Helper() args := []string{ - "-address", - "localhost", "-type", svType, "-port",
refactor(helpers): remove address flag
topfreegames_pitaya
train
go
0fb90f3e5c77b5c9f988f89766a5b61077f72f43
diff --git a/src/incoming-message-stream.js b/src/incoming-message-stream.js index <HASH>..<HASH> 100644 --- a/src/incoming-message-stream.js +++ b/src/incoming-message-stream.js @@ -26,6 +26,22 @@ class IncomingMessageStream extends Transform { this.bl = new BufferList(); } + pause() { + super.pause(); + + if (this.currentMessage) { + this.currentMessage.pause(); + } + } + + resume() { + super.resume(); + + if (this.currentMessage) { + this.currentMessage.resume(); + } + } + processBufferedData(callback: () => void) { // The packet header is always 8 bytes of length. while (this.bl.length >= HEADER_LENGTH) {
fix: flow control in message-io.js
tediousjs_tedious
train
js
e654e137b36191259a661b9d8afb6b9f0b9f43e5
diff --git a/ext/microviewer/datacube.js b/ext/microviewer/datacube.js index <HASH>..<HASH> 100644 --- a/ext/microviewer/datacube.js +++ b/ext/microviewer/datacube.js @@ -1061,12 +1061,7 @@ class FloatingPointDataCube extends DataCube { const black = transparency ? 0x00000000 : alpha; if (this.minval === this.maxval) { - if (transparency) { - val = (this.minval === 0) ? black : 0xffffffff; - } - else { - val = (this.minval === 0) ? black : 0xffffffff; - } + val = (this.minval === 0) ? black : 0xffffffff; for (i = square.length - 1; i >= 0; i--) { if (isNaN(square[i]) || square[i] === -Infinity) {
refactor(uViewer): remove redundant branch logic
seung-lab_cloud-volume
train
js
4e6df54dc204a64fbcafc572a277feeea31c50f0
diff --git a/lib/plugins/index.js b/lib/plugins/index.js index <HASH>..<HASH> 100644 --- a/lib/plugins/index.js +++ b/lib/plugins/index.js @@ -425,11 +425,13 @@ function addRuleHeaders(req, rules, headers, isPipe) { if (req.fullUrl) { headers[FULL_URL_HEADER] = encodeURIComponent(req.fullUrl); } - if (req.clientIp) { - headers[config.CLIENT_IP_HEAD] = req.clientIp; + var clientIp = req.clientIp || util.getClientIp(req); + if (clientIp) { + headers[config.CLIENT_IP_HEAD] = clientIp; } - if (req.clientPort) { - headers[config.CLIENT_PORT_HEAD] = req.clientPort; + var clientPort = req.clientPort || util.getClientPort(req); + if (clientPort) { + headers[config.CLIENT_PORT_HEAD] = clientPort; } if (req._isUIRequest) { headers[UI_REQUEST_HEADER] = '1';
refactor: make sure to get client ip & port
avwo_whistle
train
js
93977c3dbf12513b419ab7300053447ecf14de26
diff --git a/src/Http/Controllers/VoyagerBreadController.php b/src/Http/Controllers/VoyagerBreadController.php index <HASH>..<HASH> 100644 --- a/src/Http/Controllers/VoyagerBreadController.php +++ b/src/Http/Controllers/VoyagerBreadController.php @@ -56,7 +56,7 @@ class VoyagerBreadController extends Controller } if ($model->timestamps) { - $dataTypeContent = call_user_func([$query->latest(), $getter]); + $dataTypeContent = call_user_func([$query->latest($model::CREATED_AT), $getter]); } else { $dataTypeContent = call_user_func([$query->with($relationships)->orderBy('id', 'DESC'), $getter]); }
fix: BREAD fails for custom created_at field.
the-control-group_voyager
train
php
fe7ae37142038fea64a3125d297b7c91d449234b
diff --git a/@uportal/dashboard-carousel/vue.config.js b/@uportal/dashboard-carousel/vue.config.js index <HASH>..<HASH> 100644 --- a/@uportal/dashboard-carousel/vue.config.js +++ b/@uportal/dashboard-carousel/vue.config.js @@ -1,6 +1,4 @@ module.exports = { - // options... - runtimeCompiler: true, devServer: { proxy: { '/uPortal': {
fix: removed unused config property
uPortal-contrib_uPortal-web-components
train
js
4d2de22e0a987262b80bd05b56256015eab9ac15
diff --git a/packages/transformers/react-refresh-wrap/src/ReactRefreshWrapTransformer.js b/packages/transformers/react-refresh-wrap/src/ReactRefreshWrapTransformer.js index <HASH>..<HASH> 100644 --- a/packages/transformers/react-refresh-wrap/src/ReactRefreshWrapTransformer.js +++ b/packages/transformers/react-refresh-wrap/src/ReactRefreshWrapTransformer.js @@ -18,7 +18,10 @@ function shouldExclude(asset, options) { v => v.specifier === 'react' || v.specifier === 'react/jsx-runtime' || - v.specifier === 'react/jsx-dev-runtime', + v.specifier === 'react/jsx-dev-runtime'|| + v.specifier === '@emotion/react' || + v.specifier === '@emotion/react/jsx-runtime' || + v.specifier === '@emotion/react/jsx-dev-runtime' ) ); }
feat: support react refresh for @emotion/react (#<I>) * feat: support react refresh for @emotion/react while set "jsxImportSource": "@emotion/react" in tsconfig * fix: missing new jsx runtime
parcel-bundler_parcel
train
js
f54be4205dfffb8cfc1eb2d824076971c1c047b5
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -48,13 +48,13 @@ def read_requirements(filename): # Declare minimal set for installation required_packages = [ "attrs==20.3.0", - "boto3>=1.20.21", + "boto3>=1.20.21,<2.0", "google-pasta", - "numpy>=1.9.0", - "protobuf>=3.1", - "protobuf3-to-dict>=0.1.5", + "numpy>=1.9.0,<2.0", + "protobuf>=3.1,<4.0", + "protobuf3-to-dict>=0.1.5,<1.0", "smdebug_rulesconfig==1.0.1", - "importlib-metadata>=1.4.0", + "importlib-metadata>=1.4.0,<2.0", "packaging>=20.0", "pandas", "pathos",
fix: pin protobuf to < <I> to fix breaking change (#<I>)
aws_sagemaker-python-sdk
train
py
da6252b6335c2d43b98fd98e7de83dff11a29d90
diff --git a/packages/__docs__/src/Properties/index.js b/packages/__docs__/src/Properties/index.js index <HASH>..<HASH> 100644 --- a/packages/__docs__/src/Properties/index.js +++ b/packages/__docs__/src/Properties/index.js @@ -117,6 +117,7 @@ class Properties extends Component { - custom - boolean - array + - ReactReactNode */ // TODO: currently custom imported types are just showing the name of the can somehow link to these custom types switch (name) { @@ -140,6 +141,8 @@ class Properties extends Component { return 'bool' case 'Array': return 'array' + case 'ReactReactNode': + return 'ReactNode' default: return name } @@ -254,7 +257,7 @@ class Properties extends Component { // react-docgen doesn't recognise functions if they are in parentheses, // so we have to parse the raw data - const elements = tsType.raw.split('|') + const elements = tsType.raw.split('|').filter((item) => item !== '') const values = elements.map((rawValue) => { let value = rawValue.trim()
chore: fix extra comma in prop value lists on docs page
instructure_instructure-ui
train
js
14113707df2ccdc70a2a1beb97cf3548fe54275b
diff --git a/src/lib/purgeUnusedStyles.js b/src/lib/purgeUnusedStyles.js index <HASH>..<HASH> 100644 --- a/src/lib/purgeUnusedStyles.js +++ b/src/lib/purgeUnusedStyles.js @@ -20,9 +20,7 @@ function removeTailwindComments(css) { } export default function purgeUnusedUtilities(config) { - const purgeEnabled = - _.get(config, 'purge.enabled', false) === true || - (config.purge !== undefined && process.env.NODE_ENV === 'production') + const purgeEnabled = _.get(config, 'purge.enabled', config.purge !== undefined && process.env.NODE_ENV === 'production') if (!purgeEnabled) { return removeTailwindComments
fix: purgeEnabled evaluating to true when config.purge.enabled is false
tailwindcss_tailwindcss
train
js
67da6225552e46266ed059c7f0d0128294cd08ed
diff --git a/src/store.js b/src/store.js index <HASH>..<HASH> 100644 --- a/src/store.js +++ b/src/store.js @@ -373,14 +373,14 @@ function makeLocalGetters (store, namespace) { function registerMutation (store, type, handler, local) { const entry = store._mutations[type] || (store._mutations[type] = []) entry.push(function wrappedMutationHandler (payload) { - handler(local.state, payload) + handler.call(store, local.state, payload) }) } function registerAction (store, type, handler, local) { const entry = store._actions[type] || (store._actions[type] = []) entry.push(function wrappedActionHandler (payload, cb) { - let res = handler({ + let res = handler.call(store, { dispatch: local.dispatch, commit: local.commit, getters: local.getters,
feat(store): bind mutation and action handlers to store (#<I>)
vuejs_vuex
train
js
d06b9e6e3c74674f133818f719b1774fb7b0372b
diff --git a/intranet/apps/announcements/models.py b/intranet/apps/announcements/models.py index <HASH>..<HASH> 100644 --- a/intranet/apps/announcements/models.py +++ b/intranet/apps/announcements/models.py @@ -157,7 +157,7 @@ class Announcement(models.Model): def is_visible_requester(self, user): try: - return self.announcementrequest and (user in self.announcementrequest.teachers_requested.all()) + return self.announcementrequest_set.filter(teachers_requested__id=user.id).exists() except get_user_model().DoesNotExist: return False
perf(announcements): simplify Announcement.is_visible_requester query WARNING: This does change behaviour slightly in the event that multiple AnnouncementRequests exist for a given Announcement. However, I do not see a problem for this as this is an edge case that should never occur (and I have confirmed that this is not the case for any Announcement in production).
tjcsl_ion
train
py
5e88c1e52d80f7b4c5976343b25469785bba14ed
diff --git a/src/diff-main.js b/src/diff-main.js index <HASH>..<HASH> 100644 --- a/src/diff-main.js +++ b/src/diff-main.js @@ -53,7 +53,7 @@ export default function diff (opts) { // Ensure the real node is carried over even if the destination isn't used. // This is used in the render() function to keep track of the real node // that corresponds to a virtual node if a virtual tree is being used. - if (typeof curDst.__id === 'undefined') { + if (typeof curDst.__id !== 'undefined') { realNodeMap.set(curDst.__id, realNode(curSrc)); } }
refactor: Fix bad equality check.
skatejs_dom-diff
train
js
befcdde6d6add5c00c8a63315f7ca6946eca7db9
diff --git a/src/Keboola/Syrup/Command/JobCommand.php b/src/Keboola/Syrup/Command/JobCommand.php index <HASH>..<HASH> 100644 --- a/src/Keboola/Syrup/Command/JobCommand.php +++ b/src/Keboola/Syrup/Command/JobCommand.php @@ -170,7 +170,8 @@ class JobCommand extends ContainerAwareCommand $status = self::STATUS_RETRY; } catch (MaintenanceException $e) { - return self::STATUS_LOCK; + $jobStatus = Job::STATUS_WAITING; + $status = self::STATUS_LOCK; } catch (UserException $e) { $exceptionId = $this->logException('error', $e); $jobResult = [
fix: return job status to waiting when maintenance occurs
keboola_syrup
train
php
431ff3dc5cdbeb74b601fce6e44baff7238ac393
diff --git a/lib/TaskProxy.js b/lib/TaskProxy.js index <HASH>..<HASH> 100644 --- a/lib/TaskProxy.js +++ b/lib/TaskProxy.js @@ -42,10 +42,9 @@ objectAssign(TaskProxy.prototype, { var self = this; return this._getFileKey().then(function(cachedKey) { - var removeCached = Bluebird.promisify( - self.opts.fileCache.removeCached, - self.opts.fileCache - ); + var removeCached = Bluebird.promisify(self.opts.fileCache.removeCached, { + context: self.opts.fileCache + }); return removeCached(self.opts.name, cachedKey); });
fix(TaskProxy): Bluebird usage `promisify` was using the wrong argument syntax. Fixing this also fixes the `cache.clear()` method - previously it returned `undefined` errors. :LINK: <URL>
jgable_gulp-cache
train
js
06be027614eef46564a124a30cfcff809181c73c
diff --git a/website/src/components/components/ComponentTemplate.js b/website/src/components/components/ComponentTemplate.js index <HASH>..<HASH> 100644 --- a/website/src/components/components/ComponentTemplate.js +++ b/website/src/components/components/ComponentTemplate.js @@ -61,7 +61,7 @@ const ComponentTemplate = ({ const hasStories = meta.stories !== undefined && meta.stories.length > 0 - const tags = useMemo(() => [meta.package, ...meta.tags], meta) + const tags = useMemo(() => [meta.package, ...meta.tags], [meta]) const flavorKeys = useMemo(() => flavors.map(flavor => flavor.flavor), [flavors])
fix(website): fix invalid dependency for useMemo
plouc_nivo
train
js
56eb976fa2eb0b2aef914efb80cec5ad214e6ca2
diff --git a/src/test/java/net/emaze/dysfunctional/order/CompareToBuilderTest.java b/src/test/java/net/emaze/dysfunctional/order/CompareToBuilderTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/net/emaze/dysfunctional/order/CompareToBuilderTest.java +++ b/src/test/java/net/emaze/dysfunctional/order/CompareToBuilderTest.java @@ -19,7 +19,8 @@ import org.junit.runners.Suite.SuiteClasses; TestSameOrderForPrimitives.class, TestIgnoreAppendWhenNotSameOrderForPrimitives.class, TestSameOrderForArrays.class, - TestNullsForArrays.class,}) + TestNullsForArrays.class +}) public class CompareToBuilderTest { public static class TestSameOrderForPrimitives {
fix: trailing comma
cybazeitalia_emaze-dysfunctional
train
java
ce6c4b4a18b1dcae358bdf6c7e7047c85741a39b
diff --git a/ui/src/components/dialog/QDialog.js b/ui/src/components/dialog/QDialog.js index <HASH>..<HASH> 100644 --- a/ui/src/components/dialog/QDialog.js +++ b/ui/src/components/dialog/QDialog.js @@ -159,6 +159,7 @@ export default Vue.extend({ shake () { this.focus() + this.$emit('shake') const node = this.__getInnerNode()
fix(QDialog): emit @shake (was in docs) #<I> (#<I>) * fix(QDialog): emit @shake (was in docs) #<I> * Update QDialog.js
quasarframework_quasar
train
js
2f90a85df1eea71321f1a2e0aee14ef7d22e910d
diff --git a/sanic/app.py b/sanic/app.py index <HASH>..<HASH> 100644 --- a/sanic/app.py +++ b/sanic/app.py @@ -97,7 +97,7 @@ if TYPE_CHECKING: # no cov from sanic_ext import Extend # type: ignore from sanic_ext.extensions.base import Extension # type: ignore except ImportError: - Extend = TypeVar("Extend") # type: ignore + Extend = TypeVar("Extend", Type) # type: ignore if OS_IS_WINDOWS: # no cov
feat(type): extend (#<I>)
huge-success_sanic
train
py
8d5df52eb7173f5803d961e0e9e53d271cb72561
diff --git a/bootstrap/app.php b/bootstrap/app.php index <HASH>..<HASH> 100644 --- a/bootstrap/app.php +++ b/bootstrap/app.php @@ -11,7 +11,7 @@ | */ -$app = new Roots\Acorn\Bootloader(); +\Roots\bootloader(); /* |-------------------------------------------------------------------------- @@ -47,16 +47,3 @@ collect(['helpers', 'setup', 'filters', 'admin']) */ add_theme_support('sage'); - -/* -|-------------------------------------------------------------------------- -| Return The Application -|-------------------------------------------------------------------------- -| -| This script returns the application instance. The instance is given to -| the calling script so we can separate the building of the instances -| from the actual running of the application and sending responses. -| -*/ - -return $app;
fix(bootstrap): use static bootloader to prevent rebooting
roots_sage
train
php
7b2e004d06ac23b2908caef956a322d97463f12f
diff --git a/lfu_test.go b/lfu_test.go index <HASH>..<HASH> 100644 --- a/lfu_test.go +++ b/lfu_test.go @@ -21,7 +21,12 @@ func TestLFUEviction(t *testing.T) { cache := NewLFU(2) testCacheGetSet(t, cache) - err := cache.Set("test_key3", "test_data3") + _, err := cache.Get("test_key2") + if err != nil { + t.Fatal("test_key2 should be in the cache") + } + // get-> test_key should not be in cache after insert test_key3 + err = cache.Set("test_key3", "test_data3") if err != nil { t.Fatal("should not give err while setting item") }
test: check eviction of lfu cache algorithm with TS(threaded-safe)
koding_cache
train
go
9051c354daf0b40cbddd8c2b457a000c6bb8287e
diff --git a/mapillary_tools/uploader.py b/mapillary_tools/uploader.py index <HASH>..<HASH> 100644 --- a/mapillary_tools/uploader.py +++ b/mapillary_tools/uploader.py @@ -908,6 +908,8 @@ def upload_video_for_processing(video, video_start_time, max_attempts, credentia try: files = {"file": encoded_string} response = requests.post(parameters["url"],data=parameters["fields"],files=files) + if response.status_code=='204': + create_upload_log(video, "upload_success") break except requests.exceptions.HTTPError as e: return "Upload error: {} on {}, will attempt to upload again for {} more times".format(e,filename,max_attempts - attempt - 1)
feat: add basic logging to send_videos command
mapillary_mapillary_tools
train
py
85171cf410a3e4db19701cb8ff68ba610a3131eb
diff --git a/gridsome/lib/app/PluginAPI.js b/gridsome/lib/app/PluginAPI.js index <HASH>..<HASH> 100644 --- a/gridsome/lib/app/PluginAPI.js +++ b/gridsome/lib/app/PluginAPI.js @@ -1,6 +1,7 @@ const autoBind = require('auto-bind') const { mapValues } = require('lodash') const PluginStore = require('./PluginStore') +const createRoutes = require('./createRoutes') const { cache, nodeCache } = require('../utils/cache') class PluginAPI { @@ -22,6 +23,7 @@ class PluginAPI { clearTimeout(regenerateTimeout) regenerateTimeout = setTimeout(() => { if (app.isBootstrapped) { + app.routerData = createRoutes(app.store) app.generator.generate('routes.js') } }, 20) @@ -34,6 +36,7 @@ class PluginAPI { if (!app.isBootstrapped) return if ( + (node && node.withPath && node === oldNode) || (node && node.withPath && node.path !== oldNode.path) || (!node && oldNode.withPath) ) {
fix: update routes when source path changes
gridsome_gridsome
train
js
d2da96ad360421205d7baa831192ac2fcfea498b
diff --git a/lib/https/ca.js b/lib/https/ca.js index <HASH>..<HASH> 100644 --- a/lib/https/ca.js +++ b/lib/https/ca.js @@ -400,7 +400,6 @@ exports.getSNIServer = function(listener, callback, disableH2) { setPort(false); // pending SNI_OPTIONS.allowHTTP1 = enableH2; // 是否启用http2 getHttpsServer(SNI_OPTIONS, listener, function(server, port) { - server.timeout = config.timeout; server.on('error', removeServer); var timeout = setTimeout(removeServer, TIMEOUT); var clearup = function() {
refactor: cancel custom timeout
avwo_whistle
train
js
1591d75d2ffccb338db96502297405d7f681835e
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -22,9 +22,6 @@ import sys from setuptools import find_packages, setup -if sys.version_info < (3, 6): - sys.exit("Sorry, Python < 3.6 is not supported") - BASE_DIR = os.path.abspath(os.path.dirname(__file__)) PACKAGE_JSON = os.path.join(BASE_DIR, "superset-frontend", "package.json") @@ -138,7 +135,7 @@ setup( "thumbnails": ["Pillow>=7.0.0, <8.0.0"], "vertica": ["sqlalchemy-vertica-python>=0.5.9, < 0.6"], }, - python_requires="~=3.6", + python_requires="~=3.7", author="Apache Software Foundation", author_email="dev@superset.incubator.apache.org", url="https://superset.apache.org/",
fix(setup): disallow python <I> for pip install (#<I>) * fix(setup): disallow python <I> for pip install * remove old py constraint
apache_incubator-superset
train
py
eea70f1c007b808148b2c2ee0bee7d1878b08c72
diff --git a/src/browser.js b/src/browser.js index <HASH>..<HASH> 100644 --- a/src/browser.js +++ b/src/browser.js @@ -28,15 +28,17 @@ const DEFAULT_PUPPETEER_LAUNCH_ARGS = [ ] export async function launchBrowserIfNeeded ({ getBrowser, width, height }) { - if (browser) { - return - } const usingCustomGetBrowser = getBrowser && typeof getBrowser === 'function' if (usingCustomGetBrowser && !_browserLaunchPromise) { debuglog('using browser provided via getBrowser option') _browserLaunchPromise = Promise.resolve(getBrowser()) } if (!_browserLaunchPromise) { + if (browser) { + // we have already a running browser + return + } + debuglog('no browser instance, launching new browser..') _browserLaunchPromise = puppeteer.launch({
fix(browser): call getBrowser each time if using a custom browser, getBrowser is not called when "browser" is != null. As the behaviour of the browser instance is controlled outside, this leads to situation where a browser is closed, but penthouse believes the browser is still running.
pocketjoso_penthouse
train
js
24f205d9f9b526c4db1204022d3ca2a41cbe4a24
diff --git a/packages/simplebar/src/simplebar.js b/packages/simplebar/src/simplebar.js index <HASH>..<HASH> 100755 --- a/packages/simplebar/src/simplebar.js +++ b/packages/simplebar/src/simplebar.js @@ -422,11 +422,6 @@ export default class SimpleBar { } ${this.elStyles.paddingBottom} ${this.elStyles.paddingLeft}`; this.contentEl.style.height = isHeightAuto ? 'auto' : '100%'; - this.placeholderEl.style.width = isWidthAuto - ? `${this.resizeWrapperEl.clientWidth}px` - : 'auto'; - this.placeholderEl.style.height = `${this.resizeWrapperEl.clientHeight}px`; - this.wrapperEl.style.margin = `-${this.elStyles.paddingTop} -${ this.elStyles.paddingRight } -${this.elStyles.paddingBottom} -${this.elStyles.paddingLeft}`; @@ -471,6 +466,13 @@ export default class SimpleBar { this.toggleTrackVisibility('y'); this.hideNativeScrollbar(); + + // Determine placeholder size + this.placeholderEl.style.width = isWidthAuto + ? `${this.resizeWrapperEl.clientWidth}px` + : 'auto'; + + this.placeholderEl.style.height = `${this.resizeWrapperEl.clientHeight}px`; } /**
fix: try to fix infinite width recalculation
Grsmto_simplebar
train
js
25426810f6f7b540b3e88c91e352f2252e645880
diff --git a/src/lib/index.js b/src/lib/index.js index <HASH>..<HASH> 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -92,7 +92,9 @@ async function generateFlowCoverageReport(opts: FlowCoverageReportOptions) { } if (reportTypes.indexOf('html') >= 0) { - reportResults.push(reportHTML.generate(coverageData, opts)); + reportResults.push(reportHTML.generate(coverageData, opts).then(() => { + console.log(`View generated HTML Report at file://${opts.outputDir}/index.html`); + })); } return Promise.all(reportResults).then(() => {
feat: included URL to the generated HTML report in the console output.
rpl_flow-coverage-report
train
js
e843b177ea2a781a69aa36792840e8828daf5804
diff --git a/src/Leevel/Http/RedirectResponse.php b/src/Leevel/Http/RedirectResponse.php index <HASH>..<HASH> 100644 --- a/src/Leevel/Http/RedirectResponse.php +++ b/src/Leevel/Http/RedirectResponse.php @@ -39,18 +39,18 @@ use Leevel\Session\ISession; class RedirectResponse extends Response { /** - * 目标 URL 地址 + * 目标 URL 地址. * * @var string */ protected string $targetUrl; /** - * HTTP 请求 + * HTTP 请求. * * @var \Leevel\Http\IRequest */ - protected IRequest $request; + protected ?IRequest $request = null; /** * SESSION 仓储. diff --git a/src/Leevel/Http/Response.php b/src/Leevel/Http/Response.php index <HASH>..<HASH> 100644 --- a/src/Leevel/Http/Response.php +++ b/src/Leevel/Http/Response.php @@ -138,7 +138,7 @@ class Response implements IResponse * * @var string */ - protected string $content; + protected ?string $content = null; /** * HTTP 协议版本.
fix(http): fix typed properties of http
hunzhiwange_framework
train
php,php
5de0ec2a1654c51c90e3afacb52597695c921795
diff --git a/actor-apps/app-web/src/app/components/DialogSection.react.js b/actor-apps/app-web/src/app/components/DialogSection.react.js index <HASH>..<HASH> 100644 --- a/actor-apps/app-web/src/app/components/DialogSection.react.js +++ b/actor-apps/app-web/src/app/components/DialogSection.react.js @@ -63,7 +63,13 @@ class DialogSection extends React.Component { } componentDidMount() { - this.componentDidUpdate(); + const peer = DialogStore.getSelectedDialogPeer(); + + if (peer) { + DialogActionCreators.onConversationOpen(peer); + this.fixScroll(); + this.loadMessagesByScroll(); + } } componentDidUpdate() {
fix(web): fixed DialogSection with null peer; call onConversationOpen on init
actorapp_actor-platform
train
js
407242a37b2dc03bdea400bcc85fe6a36a0adff2
diff --git a/ladybug/_datacollectionbase.py b/ladybug/_datacollectionbase.py index <HASH>..<HASH> 100644 --- a/ladybug/_datacollectionbase.py +++ b/ladybug/_datacollectionbase.py @@ -629,9 +629,10 @@ class BaseCollection(object): elif isinstance(dat_type, typ_clss._time_aggregated_type): time_class = typ_clss break - else: - raise ValueError('Data type "{}" does not have a time-rate-of-' - 'change metric.'.format(head.data_type)) + # if nothing was found, throw an error + if time_class is None: + raise ValueError('Data type "{}" does not have a time-rate-of-' + 'change metric.'.format(head.data_type)) # create the new data collection and assign normalized values new_data_c = self.to_unit(head.data_type.units[0])
style(datacollection): Improve error message in the event of no type
ladybug-tools_ladybug
train
py
3aa68b4c875756aa9dbc1ed75151b6949cf26322
diff --git a/webapps/ui/tasklist/client/scripts/tasklist/plugins/cam-tasklist-search-plugin.js b/webapps/ui/tasklist/client/scripts/tasklist/plugins/cam-tasklist-search-plugin.js index <HASH>..<HASH> 100644 --- a/webapps/ui/tasklist/client/scripts/tasklist/plugins/cam-tasklist-search-plugin.js +++ b/webapps/ui/tasklist/client/scripts/tasklist/plugins/cam-tasklist-search-plugin.js @@ -36,7 +36,11 @@ var parseValue = function(value, enforceString) { }; var sanitizeValue = function(value, operator, search) { - if(operator === 'Like' || operator === 'like') { + // Regex for '\_' and '\%' epxressions + var specialWildCardCharExp = /(\\%)|(\\_)/g; + // Regex for '_' and '%' special characters + var wildCardExp = /(\%)|(\_)/; + if(operator.toLowerCase() === 'like' && !wildCardExp.test(value.replace(specialWildCardCharExp, ''))) { return '%'+value+'%'; } else if(operator == 'in') { return value.split(',');
feat(cockpit): make like operator flexible to handle '_' and '%' wildcards in tasklist Related to CAM-<I>
camunda_camunda-bpm-platform
train
js
93a1e42ef31ad1b864f6b3268bdfae8198d7f6c9
diff --git a/src/switch/stats/stat.js b/src/switch/stats/stat.js index <HASH>..<HASH> 100644 --- a/src/switch/stats/stat.js +++ b/src/switch/stats/stat.js @@ -139,10 +139,10 @@ class Stats extends EventEmitter { this._timeout = null if (this._queue.length) { let last - while (this._queue.length) { - const op = last = this._queue.shift() - this._applyOp(op) + for (last of this._queue) { + this._applyOp(last) } + this._queue = [] this._updateFrequency(last[2]) // contains timestamp of last op
fix: performance bottleneck in stat.js (#<I>) Array.shift seems to be very slow, perhaps linear, on some engines, resulting in _update consuming a lot of CPU.
libp2p_js-libp2p
train
js
4b2811a5ad3918b6051c0625acb4fa119753d117
diff --git a/middlewares/events.js b/middlewares/events.js index <HASH>..<HASH> 100644 --- a/middlewares/events.js +++ b/middlewares/events.js @@ -6,13 +6,12 @@ const secret = { handlers: Symbol('event handlers') } -module.exports = function events (elem, state, next) { +module.exports = function events (elem, state) { if (!(elem instanceof Element)) return elem.$require('code') elem.$using('events') elem[secret.handlers] = new Map() - next() const attributes = elem.attributes for (let i = attributes.length; i--;) {
perf(events): do not compose the events middleware
nx-js_framework
train
js
f697efffc6b46c23ecfb7bef2eff8a3b906f85d0
diff --git a/lib/helpers.js b/lib/helpers.js index <HASH>..<HASH> 100644 --- a/lib/helpers.js +++ b/lib/helpers.js @@ -25,7 +25,7 @@ const getFileType = (fileName, { transformExtensions }) => { }; const reduceAssets = (files, asset, moduleAssets) => { - const name = moduleAssets[asset.name]; + const name = moduleAssets[asset.name] ? moduleAssets[asset.name] : asset.info.sourceFilename; if (name) { return files.concat({ path: asset.name,
feat: fallback to asset.info.sourceFilename (#<I>) * feat: fallback to as populated in asset.info * Compatibility tenary
danethurber_webpack-manifest-plugin
train
js
488535118dfc01473e5f236f3d1d017dc3a40b6d
diff --git a/builder/osc/chroot/step_create_omi.go b/builder/osc/chroot/step_create_omi.go index <HASH>..<HASH> 100644 --- a/builder/osc/chroot/step_create_omi.go +++ b/builder/osc/chroot/step_create_omi.go @@ -48,7 +48,7 @@ func (s *StepCreateOMI) Run(ctx context.Context, state multistep.StateBag) multi newDevice.Bsu.VolumeSize = gibSize if newDevice.DeviceName == rootDeviceName { - if &newDevice.Bsu != nil { + if newDevice.Bsu != (oapi.BsuToCreate{}) { newDevice.Bsu.SnapshotId = snapshotId } else { newDevice.Bsu = oapi.BsuToCreate{SnapshotId: snapshotId}
refactor: change validation when bsu is set
hashicorp_packer
train
go
ece328fa51f6ab16cfb2ce7d87bccf7a6846a87f
diff --git a/build/createTypeDeclarations.js b/build/createTypeDeclarations.js index <HASH>..<HASH> 100644 --- a/build/createTypeDeclarations.js +++ b/build/createTypeDeclarations.js @@ -2,7 +2,8 @@ const fs = require('fs') const path = require('path') function dataFiles () { - return fs.readdirSync(path.join(__dirname, '..', 'node_modules', 'video-testdata', 'data')) + const videoTestdata = path.dirname(require.resolve('video-testdata/package.json')) + return fs.readdirSync(path.join(videoTestdata, 'data')) .map(file => `"${file}"`) .join(' | ') }
fix: use require.resolve in post-install script ... to find video-testdata if it is in a sibling node_modules directory
nknapp_video-testdata-loader
train
js
65a0767e8024879e3a5c4557f376d8b6684530e8
diff --git a/lib/preprocessor.js b/lib/preprocessor.js index <HASH>..<HASH> 100644 --- a/lib/preprocessor.js +++ b/lib/preprocessor.js @@ -22,7 +22,7 @@ var isBinary = Object.create(null); 'sgi', 'tiff', 'psd', 'uvi', 'sub', 'djvu', 'dwg', 'dxf', 'fbs', 'fpx', 'fst', 'mmr', 'rlc', 'mdi', 'wdp', 'npx', 'wbmp', 'xif', 'webp', '3ds', 'ras', 'cmx', 'fh', 'ico', 'pcx', 'pic', 'pnm', 'pbm', 'pgm', 'ppm', 'rgb', 'tga', 'xbm', 'xpm', 'xwd', 'zip', 'rar', 'tar', 'bz2', 'eot', - 'ttf', 'woff', 'dat', 'nexe', 'pexe', 'epub' + 'ttf', 'woff', 'dat', 'nexe', 'pexe', 'epub', 'mp3', 'ogg' ].forEach(function(extension) { isBinary['.' + extension] = true; });
feat(preprocessor): add 'mp3' and 'ogg' as binary formats to avoid media corruption in the browser.
karma-runner_karma
train
js
1acc55399b694f4120c5f16657dbe01a5359869f
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -36,17 +36,9 @@ function Store (dbName, options) { var storeApi = db.hoodieApi({emitter: emitter}) var state = { - objectTypeById: {}, db: db } - // possible race condition... - storeApi.findAll().then(function (objects) { - objects.forEach(function (object) { - state.objectTypeById[object.id] = object.type - }) - }) - var api = merge( { db: storeApi.db,
chore: remove unnecessary code (#<I>
hoodiehq_hoodie-store-client
train
js
9004b007430f924cb876da4b932ce273d4688c22
diff --git a/src/Image.js b/src/Image.js index <HASH>..<HASH> 100644 --- a/src/Image.js +++ b/src/Image.js @@ -1,5 +1,5 @@ import classNames from 'classnames'; -import React, { useMemo } from 'react'; +import React from 'react'; import PropTypes from 'prop-types'; import { useBootstrapPrefix } from './ThemeProvider'; @@ -44,15 +44,11 @@ const Image = React.forwardRef( ) => { bsPrefix = useBootstrapPrefix(bsPrefix, 'img'); - const classes = useMemo( - () => - classNames( - fluid && `${bsPrefix}-fluid`, - rounded && `rounded`, - roundedCircle && `rounded-circle`, - thumbnail && `${bsPrefix}-thumbnail`, - ), - [fluid, rounded, roundedCircle, thumbnail, bsPrefix], + const classes = classNames( + fluid && `${bsPrefix}-fluid`, + rounded && `rounded`, + roundedCircle && `rounded-circle`, + thumbnail && `${bsPrefix}-thumbnail`, ); return (
chore(image): revert changes to classnames implementation There's really no point in memoizing this, since it's not an expensive computation.
react-bootstrap_react-bootstrap
train
js
14fe8ecb5820e11ebbcea15d0c2f92b7a1e6fc0b
diff --git a/cmd/data-usage.go b/cmd/data-usage.go index <HASH>..<HASH> 100644 --- a/cmd/data-usage.go +++ b/cmd/data-usage.go @@ -84,7 +84,8 @@ func loadPrefixUsageFromBackend(ctx context.Context, objAPI ObjectLayer, bucket } for id, usageInfo := range cache.flattenChildrens(*root) { - prefix := strings.TrimPrefix(id, bucket+slashSeparator) + prefix := decodeDirObject(strings.TrimPrefix(id, bucket+slashSeparator)) + // decodeDirObject to avoid any __XL_DIR__ objects m[prefix] += uint64(usageInfo.Size) } }
fix: decodeDirObject in prefix usage function (#<I>) prefixes at top level create such as ``` ~ mc mb alias/bucket/prefix ``` The prefix/ incorrect appears as prefix__XL_DIR__/ in the accountInfo output, make sure to trim '__XL_DIR__'
minio_minio
train
go
18d09be3c43d0fc0745799133fba5f13f627cb9f
diff --git a/src/EloGank/Replay/Output/OutputInterface.php b/src/EloGank/Replay/Output/OutputInterface.php index <HASH>..<HASH> 100644 --- a/src/EloGank/Replay/Output/OutputInterface.php +++ b/src/EloGank/Replay/Output/OutputInterface.php @@ -16,6 +16,12 @@ namespace EloGank\Replay\Output; */ interface OutputInterface { + const VERBOSITY_QUIET = 0; + const VERBOSITY_NORMAL = 1; + const VERBOSITY_VERBOSE = 2; + const VERBOSITY_VERY_VERBOSE = 3; + const VERBOSITY_DEBUG = 4; + const OUTPUT_TYPE_NORMAL = 0; const OUTPUT_TYPE_RAW = 1; const OUTPUT_TYPE_PLAIN = 2;
fix: forget adding verbosity constants.
EloGank_lol-replay
train
php
4dfafe953214ee60eedea7230c37922640486cb3
diff --git a/bigquery/setup.py b/bigquery/setup.py index <HASH>..<HASH> 100644 --- a/bigquery/setup.py +++ b/bigquery/setup.py @@ -33,6 +33,7 @@ dependencies = [ "google-cloud-core >= 1.0.3, < 2.0dev", "google-resumable-media >= 0.3.1, != 0.4.0, < 0.6.0dev", "protobuf >= 3.6.0", + "six >=1.13.0,< 2.0.0dev", ] extras = { "bqstorage": [
fix(bigquery): add six dependency in setup file (#<I>)
googleapis_google-cloud-python
train
py
2c5bfdd2844041226a911cd4f5174387ba3c1405
diff --git a/scripts/release.js b/scripts/release.js index <HASH>..<HASH> 100755 --- a/scripts/release.js +++ b/scripts/release.js @@ -79,7 +79,7 @@ const strategy = currentBranch !== 'develop' || forceBeta ? 'beta' : 'stable'; function rollback(newVersion) { if (strategy === 'stable') { // reset master - shell.exec('git reset --hard origin master'); + shell.exec('git reset --hard origin/master'); shell.exec('git checkout develop'); } else { // remove last commit
chore(release): fix rollback command (#<I>)
algolia_instantsearch.js
train
js
b8a4de9670654d9a19b4d6cacdc97a4348cd88e2
diff --git a/src/Security/Guard/JwtGuardAuthenticator.php b/src/Security/Guard/JwtGuardAuthenticator.php index <HASH>..<HASH> 100644 --- a/src/Security/Guard/JwtGuardAuthenticator.php +++ b/src/Security/Guard/JwtGuardAuthenticator.php @@ -49,7 +49,8 @@ class JwtGuardAuthenticator extends AbstractGuardAuthenticator // phpcs:ignore public function supports(Request $request) { - return true; + return $request->headers->has('Authorization') && + strpos($request->headers->get('Authorization'), 'Bearer') === 0; } /**
fix: Restore JwtGuardAuthenticator::supports behavior
auth0_jwt-auth-bundle
train
php
b3604e74eddcf8ef25b8d25c4993d75bbf3671b8
diff --git a/lib/env_pull_request/base.rb b/lib/env_pull_request/base.rb index <HASH>..<HASH> 100644 --- a/lib/env_pull_request/base.rb +++ b/lib/env_pull_request/base.rb @@ -45,14 +45,14 @@ module EnvPullRequest # Jenkins GitHub pull request builder plugin: # ENV['ghprbPullId'] # + # @return [Integer, nil] pull request id or nil + # # @see http://docs.travis-ci.com/user/environment-variables/#Default-Environment-Variables # Environment Variables - Travis CI # @see https://circleci.com/docs/environment-variables#building-pull-requests-that-come-from-forks # Environment variables - CircleCI # @see https://wiki.jenkins-ci.org/display/JENKINS/GitHub+pull+request+builder+plugin#GitHubpullrequestbuilderplugin-EnvironmentVariables # GitHub pull request builder plugin - Jenkins - Jenkins Wiki - # - # @return [Integer, nil] pull request id or nil def fetch_pull_request_id if positive_integer_string? ENV['TRAVIS_PULL_REQUEST'] ENV['TRAVIS_PULL_REQUEST'].to_i
docs(base): see also set buttom
packsaddle_ruby-env_pull_request
train
rb
b52a61b4d5c74c586f032c761cd0f902df20fd4b
diff --git a/allauth/socialaccount/providers/nextcloud/views.py b/allauth/socialaccount/providers/nextcloud/views.py index <HASH>..<HASH> 100644 --- a/allauth/socialaccount/providers/nextcloud/views.py +++ b/allauth/socialaccount/providers/nextcloud/views.py @@ -25,7 +25,7 @@ class NextCloudAdapter(OAuth2Adapter): request, extra_data) def get_user_info(self, token, user_id): - headers = {'Authorization': 'Bearer {0}'.format(self.server)} + headers = {'Authorization': 'Bearer {0}'.format(token)} resp = requests.get(self.profile_url + user_id, headers=headers) resp.raise_for_status() data = ET.fromstring(resp.content.decode())[1]
fix(nextcloud): Token/server accidentally swapped How did this ever work?
pennersr_django-allauth
train
py
9daa860bad14407f11f4b483a2639de24b847795
diff --git a/pook/interceptors/__init__.py b/pook/interceptors/__init__.py index <HASH>..<HASH> 100644 --- a/pook/interceptors/__init__.py +++ b/pook/interceptors/__init__.py @@ -20,8 +20,12 @@ interceptors = [ # Import aiohttp in modern Python runtimes if sys.version_info >= (3, 5, 0): - from .aiohttp import AIOHTTPInterceptor - interceptors.append(AIOHTTPInterceptor) + try: + import aiohttp # noqa + from .aiohttp import AIOHTTPInterceptor + interceptors.append(AIOHTTPInterceptor) + except ImportError: + pass def add(*custom_interceptors):
fix(aiohttp): compatible with non aiohttp projects (#<I>) * fix(aiohttp): compatible with non aiohttp projects * fix: ignore non-used line linting
h2non_pook
train
py
6426bc9084a99fc0187673aaf4d9ca7f80398bd8
diff --git a/tests/Protocol/Process/HotOverloadTest.php b/tests/Protocol/Process/HotOverloadTest.php index <HASH>..<HASH> 100644 --- a/tests/Protocol/Process/HotOverloadTest.php +++ b/tests/Protocol/Process/HotOverloadTest.php @@ -42,6 +42,13 @@ use Tests\TestCase; */ class HotOverloadTest extends TestCase { + protected function setUp(): void + { + if (extension_loaded('xdebug')) { + $this->markTestSkipped('32663 Segmentation fault (core dumped).'); + } + } + /** * @api( * title="测试代码热重启",
test(hotoverload): when xdebug installed and ignore the tests
hunzhiwange_framework
train
php
138f519018518f79664dbcc55eab43826fc0a424
diff --git a/src/cli/commands/files.js b/src/cli/commands/files.js index <HASH>..<HASH> 100644 --- a/src/cli/commands/files.js +++ b/src/cli/commands/files.js @@ -3,13 +3,12 @@ module.exports = { command: 'files', - description: '', + description: 'Unixfs commands', builder (yargs) { return yargs .commandDir('files') }, - handler (argv) { - } + handler (argv) {} } diff --git a/src/cli/commands/files/add.js b/src/cli/commands/files/add.js index <HASH>..<HASH> 100644 --- a/src/cli/commands/files/add.js +++ b/src/cli/commands/files/add.js @@ -34,9 +34,7 @@ function checkPath (inPath, recursive) { return inPath } -module.exports = command - -const command = { +module.exports = { command: 'add <file>', describe: 'Add a file to IPFS using the UnixFS data format',
fix(cli): fix the files API commands
ipfs_js-ipfs
train
js,js
8586719ee18598ff2aac47b05cba7fc15f7bc554
diff --git a/lib/rules/index.js b/lib/rules/index.js index <HASH>..<HASH> 100644 --- a/lib/rules/index.js +++ b/lib/rules/index.js @@ -251,7 +251,7 @@ function parseRule(rules, pattern, matcher, raw, root) { isDomain: !isRegExp && util.removeProtocol(rawPattern, true).indexOf('/') == -1, rawPattern: rawPattern }); -}; +} function parse(rules, text, root, append) { !append && protoMgr.resetRules(rules); @@ -279,7 +279,7 @@ function parse(rules, text, root, append) { }); } -function Rules(text, root) { +function Rules(text) { this._rules = protoMgr.getRules(); }
refactor: fix eslint errors
avwo_whistle
train
js
ba6bd26a4efe72c1d57e064669641d0ec94235ec
diff --git a/views/js/uiForm.js b/views/js/uiForm.js index <HASH>..<HASH> 100755 --- a/views/js/uiForm.js +++ b/views/js/uiForm.js @@ -110,12 +110,13 @@ const testedUrl = settings.url.indexOf('?') === -1 ? settings.url : settings.url.substr(0, settings.url.indexOf('?')); + const authoringRequestSuffix = 'authoring'; /** * Prevent manage-schema form initialization when the targeted url is related to authoring * associated action is "launchEditor" */ - if (!testedUrl.includes('authoring')) { + if (testedUrl.indexOf(authoringRequestSuffix, testedUrl.length - authoringRequestSuffix.length) === -1) { self.initRendering(); }
fix: skip TAO-resource form initialization only on `.*/authoring$` requests
oat-sa_tao-core
train
js
17e60d2379f4a1a57aff1ab8c37716debd45c801
diff --git a/mapillary_tools/exif_write.py b/mapillary_tools/exif_write.py index <HASH>..<HASH> 100644 --- a/mapillary_tools/exif_write.py +++ b/mapillary_tools/exif_write.py @@ -69,7 +69,7 @@ class ExifEdit(object): def add_altitude(self, altitude, precision=100): """Add altitude (pre is the precision).""" - ref = 1 if altitude > 0 else 0 + ref = 0 if altitude > 0 else 1 self._ef["GPS"][piexif.GPSIFD.GPSAltitude] = ( int(abs(altitude) * precision), precision) self._ef["GPS"][piexif.GPSIFD.GPSAltitudeRef] = ref
fix: fixed bug where gps reference was written wrong to EXIF
mapillary_mapillary_tools
train
py
233be156193e1457e0cda46f816df9dac39a67c3
diff --git a/dev/test/cypress/integration/web-extend.spec.js b/dev/test/cypress/integration/web-extend.spec.js index <HASH>..<HASH> 100644 --- a/dev/test/cypress/integration/web-extend.spec.js +++ b/dev/test/cypress/integration/web-extend.spec.js @@ -227,7 +227,7 @@ describe('Web extend scripts', function() { cy.loginWithCustomer({ customer: this.defaultCustomer }); - cy.get(':nth-child(3) > .greet > .logged-in').should('contain', 'Cypress Default').then(() => { + cy.get('.customer-name').should('contain', 'Cypress Default').then(() => { const customerData = JSON.parse(localStorage.getItem('mage-cache-storage')); expect(customerData.customer).to.be.not.undefined; expect(customerData.customer.id).to.be.not.undefined;
fix(test): try a different selector to determine if user is logged in CDPIP-OPS
emartech_magento2-extension
train
js
c60fadfff32dc32d310b195e77c48c3e0dfcbcb6
diff --git a/packages/core/polyfills/polyfill-loader.js b/packages/core/polyfills/polyfill-loader.js index <HASH>..<HASH> 100644 --- a/packages/core/polyfills/polyfill-loader.js +++ b/packages/core/polyfills/polyfill-loader.js @@ -6,7 +6,6 @@ require('core-js/modules/es6.string.starts-with'); require('core-js/modules/es7.array.includes'); require('core-js/modules/es6.array.for-each'); require('core-js/modules/es6.object.assign'); -require('core-js/library/es6/reflect'); let polyfills = [];
refactor: remove es6 reflect polyfill -- no longer required for IE<I>
bolt-design-system_bolt
train
js
aee6c603214a8b2e8a15462a92d831f1f2ed1e9c
diff --git a/base_konnector.js b/base_konnector.js index <HASH>..<HASH> 100644 --- a/base_konnector.js +++ b/base_konnector.js @@ -62,7 +62,7 @@ module.exports = { resolve(account) }) .catch(err => { - log('error', `error while getting the folder path from ID : "${cozyFields.folderPath}"`) + log('error', `error while getting the folder path from ID : "${folderId}"`) log('error', err.message) reject(new Error('NOT_EXISTING_DIRECTORY')) })
fix: better folder error log :loud_sound:
konnectors_libs
train
js
c47e62fa3758622229941f3636acbd33136ad89e
diff --git a/lib/components/form/error-message.js b/lib/components/form/error-message.js index <HASH>..<HASH> 100644 --- a/lib/components/form/error-message.js +++ b/lib/components/form/error-message.js @@ -22,7 +22,11 @@ const ErrorMessage = ({ error, message, warning }) => { <div className='error-message'> <div className='header'> <Icon type='exclamation-circle' /> - <FormattedMessage id={warning ? 'components.ErrorMessage.warning' : 'components.ErrorMessage.header'} /> + {warning ? ( + <FormattedMessage id='components.ErrorMessage.warning' /> + ) : ( + <FormattedMessage id='components.ErrorMessage.header' /> + )} </div> <div className='message'>{message}</div> {!warning && <TripTools buttonTypes={['START_OVER', 'REPORT_ISSUE']} />}
refactor(error-message): set each intl string as seperate component
opentripplanner_otp-react-redux
train
js
85b6c2292e04a9443e8cd4eaa014caf09f7838e7
diff --git a/lib/utils/isset.js b/lib/utils/isset.js index <HASH>..<HASH> 100644 --- a/lib/utils/isset.js +++ b/lib/utils/isset.js @@ -1,5 +1,5 @@ function isset(value) { - return typeof value !== 'undefined' && value !== null; + return value != null; } module.exports = isset;
refactor: simplifies "isset" util
apiaryio_gavel.js
train
js
dfb7f538b99942896d642ea6454546608271f275
diff --git a/test/test-capture.js b/test/test-capture.js index <HASH>..<HASH> 100644 --- a/test/test-capture.js +++ b/test/test-capture.js @@ -99,6 +99,9 @@ process.once('uncaughtException', function(err) { http.get('http://google.com', function(res) { localIP = res.socket.address().address; console.log('localIP = %j', localIP); + var interfaces = require('os').networkInterfaces(); + console.log('node interface list:\n%s', + require('util').inspect(interfaces, false, 6)); console.log('Cap device list:\n%s', require('util').inspect(Cap.deviceList(), false, 6)); res.on('end', next);
test: add node's interface list to output
mscdex_cap
train
js
655be46dc95420df1f63a986ac7f69105e7a0d82
diff --git a/core/poi/lib/plugins/config-html.js b/core/poi/lib/plugins/config-html.js index <HASH>..<HASH> 100644 --- a/core/poi/lib/plugins/config-html.js +++ b/core/poi/lib/plugins/config-html.js @@ -95,7 +95,11 @@ exports.apply = api => { filename: `${entryName}.html`, chunks: ['chunk-vendors', 'chunk-common', entryName] }, - typeof pages[entryName] === 'string' ? {} : pages[entryName] + typeof pages[entryName] === 'string' + ? { + entry: pages[entryName] + } + : pages[entryName] ) if (!page.template.startsWith('!')) { page.template = api.resolveCwd(page.template)
fix: missing shortcut for setting entry in multi-page mode
egoist_poi
train
js
c3db0c759697dac20dac3b15448e4b0f9f6d0c79
diff --git a/lib/featuresLoader.js b/lib/featuresLoader.js index <HASH>..<HASH> 100644 --- a/lib/featuresLoader.js +++ b/lib/featuresLoader.js @@ -33,7 +33,7 @@ const createCucumber = ( .find(fileSteps => fileSteps[filePath]) [filePath].join("\n")} - createTestsFromFeature('${filePath}', \`${spec}\`); + createTestsFromFeature('${path.basename(filePath)}', \`${spec}\`); }) ` ) diff --git a/lib/getStepDefinitionsPaths.js b/lib/getStepDefinitionsPaths.js index <HASH>..<HASH> 100644 --- a/lib/getStepDefinitionsPaths.js +++ b/lib/getStepDefinitionsPaths.js @@ -11,7 +11,6 @@ const getStepDefinitionsPaths = filePath => { const nonGlobalPattern = `${getStepDefinitionPathsFrom( filePath )}/**/*.+(js|ts)`; - console.log("GOZDECKI nonGlobalPattern", nonGlobalPattern); const commonPath = loaded.config.commonPath || `${stepDefinitionPath()}/common/`; const commonDefinitionsPattern = `${commonPath}**/*.+(js|ts)`;
fix(featuresloader): send only the basename of the feature file - match the original loader behavior
TheBrainFamily_cypress-cucumber-preprocessor
train
js,js
1099bf2101091759357f565ad712edefef071ccc
diff --git a/packages/date/src/DateRangeField.js b/packages/date/src/DateRangeField.js index <HASH>..<HASH> 100644 --- a/packages/date/src/DateRangeField.js +++ b/packages/date/src/DateRangeField.js @@ -4,11 +4,11 @@ import { Label } from 'reactstrap'; import { FormGroup, Feedback } from '@availity/form'; import DateRange from './DateRange'; -const DateRangeField = ({ name, label, labelClass, labelHidden, labelAttrs, ...props }) => ( +const DateRangeField = ({ name, label, labelClass, labelHidden, labelAttrs, id = name, ...props }) => ( <FormGroup for={name}> {label && ( <Label - for={name} + for={`${id.replace(/[^a-zA-Z0-9]/gi, '')}-start`} className={labelClass} hidden={labelHidden} {...labelAttrs} @@ -22,6 +22,7 @@ const DateRangeField = ({ name, label, labelClass, labelHidden, labelAttrs, ...p ); DateRangeField.propTypes = { + id: PropTypes.string, name: PropTypes.string, label: PropTypes.node, labelClass: PropTypes.string,
fix(DateRangeField): make label target start field Previously, the label was not targeting any visible input. With this change the label will target the start field, enabling the user to click the label to focus on the first field.
Availity_availity-react
train
js
57a83eae1dfb998cafbd5cc4bc50cc100556b44e
diff --git a/lib/https/index.js b/lib/https/index.js index <HASH>..<HASH> 100644 --- a/lib/https/index.js +++ b/lib/https/index.js @@ -888,7 +888,7 @@ module.exports = function(socket, hostname, next, isWebPort) { if(useSNI) { checkTimeout(); - getSNIServer(h2Handlers, handleConnect, util.isDisableH2(socket)); + getSNIServer(h2Handlers, handleConnect, util.isDisableH2(socket, true)); } else { useNoSNIServer(); } diff --git a/lib/util/index.js b/lib/util/index.js index <HASH>..<HASH> 100644 --- a/lib/util/index.js +++ b/lib/util/index.js @@ -2743,9 +2743,12 @@ exports.isEnableH2 = function(req) { return (enable.h2 || enable.http2) && !disable.h2 && !disable.http2; }; -exports.isDisableH2 = function(req) { +exports.isDisableH2 = function(req, strict) { var enable = req.enable || ''; var disable = req.disable || ''; + if (strict) { + return disable.http2 && !enable.http2; + } return (disable.h2 || disable.http2) && !enable.h2 && !enable.http2; };
refactor: refine disable http2
avwo_whistle
train
js,js
7a094af5b0fb3a278ff968e3a71ad130e6fb1282
diff --git a/src/plugins/closed_captions/closed_captions.js b/src/plugins/closed_captions/closed_captions.js index <HASH>..<HASH> 100644 --- a/src/plugins/closed_captions/closed_captions.js +++ b/src/plugins/closed_captions/closed_captions.js @@ -43,9 +43,14 @@ export default class ClosedCaptions extends UICorePlugin { if (this.container) { this.listenTo(this.container, Events.CONTAINER_SUBTITLE_AVAILABLE, this.onSubtitleAvailable) this.listenTo(this.container, Events.CONTAINER_SUBTITLE_CHANGED, this.onSubtitleChanged) + this.listenTo(this.container, Events.CONTAINER_STOP, this.onContainerStop) } } + onContainerStop() { + this.ccAvailable(false) + } + containerChanged() { this.ccAvailable(false) this.stopListening()
feat(closed_captions): hide CC button on container stop
clappr_clappr
train
js
c491292c23a7788395b36a0f653af3f3cf00881e
diff --git a/flask_graphql_auth/__init__.py b/flask_graphql_auth/__init__.py index <HASH>..<HASH> 100644 --- a/flask_graphql_auth/__init__.py +++ b/flask_graphql_auth/__init__.py @@ -3,4 +3,4 @@ from .main import * from .util import * from .fields import AuthInfoField -__version__ = "1.3.2" +__version__ = "1.3.3"
chore: Bump package version to <I>
callsign-viper_Flask-GraphQL-Auth
train
py
47e963ac5500671963c9b6e994d684d48e0fc92f
diff --git a/packages/line/src/Lines.js b/packages/line/src/Lines.js index <HASH>..<HASH> 100644 --- a/packages/line/src/Lines.js +++ b/packages/line/src/Lines.js @@ -12,6 +12,7 @@ import LinesItem from './LinesItem' const Lines = ({ lines, lineGenerator, lineWidth }) => { return lines + .slice(0) .reverse() .map(({ id, data, color }) => ( <LinesItem
fix(line): make copy of lines data before reversing (#<I>)
plouc_nivo
train
js
5b1106e74571b050fc58f6901a22bfe197a8568a
diff --git a/packages/components/bolt-tabs/src/tabs.js b/packages/components/bolt-tabs/src/tabs.js index <HASH>..<HASH> 100644 --- a/packages/components/bolt-tabs/src/tabs.js +++ b/packages/components/bolt-tabs/src/tabs.js @@ -290,7 +290,7 @@ class BoltTabs extends withContext(withLitHtml()) { aria-selected="${isSelected}" aria-controls="${panelId}" id="${labelId}" - tabindex="${isSelected ? -1 : 0}" + tabindex="${isSelected ? 0 : -1}" @click=${e => this.setSelectedTab(index)} @keydown=${e => this.handleOnKeydown(e)} @keyup=${e => this.handleOnKeyup(e)}
fix: flip tabindex so that active tab gets focus, other are skipped; use arrows to navigate
bolt-design-system_bolt
train
js
c28642642b982122fed57632564b02676ff6f883
diff --git a/provision/pool/pool.go b/provision/pool/pool.go index <HASH>..<HASH> 100644 --- a/provision/pool/pool.go +++ b/provision/pool/pool.go @@ -241,7 +241,7 @@ func volumePlanNames(ctx context.Context, poolName string) ([]string, error) { return nil, err } - var vplans map[string]struct{} + vplans := make(map[string]struct{}) for _, v := range volumes { if _, ok := vplans[v.Plan.Name]; !ok { vplans[v.Plan.Name] = struct{}{}
fix: intializing map before using it
tsuru_tsuru
train
go
5e26da9115cb7d0b1ae2efc8c09ebb478275b52c
diff --git a/source/rafcon/utils/gui_functions.py b/source/rafcon/utils/gui_functions.py index <HASH>..<HASH> 100644 --- a/source/rafcon/utils/gui_functions.py +++ b/source/rafcon/utils/gui_functions.py @@ -34,6 +34,7 @@ def call_gui_callback(callback, *args, **kwargs): from threading import Condition import sys from rafcon.utils import log + from rafcon.gui.utils import wait_for_gui global exception_info, result from gi.repository import GLib condition = Condition() @@ -66,6 +67,7 @@ def call_gui_callback(callback, *args, **kwargs): # Wait for the condition to be notified # TODO: implement timeout that raises an exception condition.wait() + GLib.idle_add(wait_for_gui) if exception_info: e_class, e_instance, e_traceback = exception_info raise_(e_instance, None, e_traceback)
fix(gui_functions): add wait_for_gui in call_gui_callback this makes sure that all GUI-changes initiated by the function called via call_gui_callback are finished before returning
DLR-RM_RAFCON
train
py
d41b9f53a46ff8c97b780d4c24f6f64e16017b89
diff --git a/src/ocLazyLoad.js b/src/ocLazyLoad.js index <HASH>..<HASH> 100644 --- a/src/ocLazyLoad.js +++ b/src/ocLazyLoad.js @@ -748,8 +748,8 @@ } var onInvoke = function(invokeName) { newInvoke = true; - broadcast('ocLazyLoad.componentLoaded', invokeName); regInvokes[moduleName][type].push(invokeName); + broadcast('ocLazyLoad.componentLoaded', [moduleName, type, invokeName]); } if(angular.isString(invokeList) && regInvokes[moduleName][type].indexOf(invokeList) === -1) { onInvoke(invokeList);
feat: broadcast for componentLoaded event provides more info (module name and type)
ocombe_ocLazyLoad
train
js
c2dda3c7e2393107b960294df92e9dae855e8d3d
diff --git a/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js b/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js +++ b/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js @@ -22,6 +22,7 @@ export default gql` id transfer_day: recipient(path: "transfer_day") transfer_interval: recipient(path: "transfer_interval") + transfer_enabled: recipient(path: "transfer_enabled") bank_account: recipient(path: "bank_account") } }
fix(canary): add recipient on community fetch
nossas_bonde-client
train
js
cb4f08ad7dd8eed3da69d61d51c6d5379a486bd0
diff --git a/lib/classes/PluginManager.js b/lib/classes/PluginManager.js index <HASH>..<HASH> 100644 --- a/lib/classes/PluginManager.js +++ b/lib/classes/PluginManager.js @@ -660,6 +660,13 @@ class PluginManager { } } + try { + for (const { hook } of this.getHooks(['finalize'])) await hook(); + } catch (finalizeHookException) { + await deferredBackendNotificationRequest; + throw finalizeHookException; + } + if (deferredBackendNotificationRequest) { await processBackendNotificationRequest(await deferredBackendNotificationRequest); }
feat: Support `finalize` hook, triggered on command finalization
serverless_serverless
train
js
61caf513073e157fb9022d1ac1694d13f2bf80ed
diff --git a/test/test_scheduler.go b/test/test_scheduler.go index <HASH>..<HASH> 100644 --- a/test/test_scheduler.go +++ b/test/test_scheduler.go @@ -350,10 +350,6 @@ func (s *SchedulerSuite) TestTCPApp(t *c.C) { } func (s *SchedulerSuite) TestDeployController(t *c.C) { - if testCluster == nil { - t.Skip("cannot determine test cluster size") - } - // get the current controller release client := s.controllerClient(t) app, err := client.GetApp("controller") @@ -397,6 +393,7 @@ loop: // check the correct controller jobs are running hosts, err := s.clusterClient(t).Hosts() t.Assert(err, c.IsNil) + t.Assert(hosts, c.Not(c.HasLen), 0) actual := make(map[string]map[string]int) for _, h := range hosts { jobs, err := h.ListJobs() @@ -420,7 +417,7 @@ loop: expected := map[string]map[string]int{release.ID: { "web": 2, "worker": 2, - "scheduler": testCluster.Size(), + "scheduler": len(hosts), }} t.Assert(actual, c.DeepEquals, expected) }
test: Don't require testCluster in TestDeployController
flynn_flynn
train
go
b4ce82ab3ee1f607240aa7c9b34433390102d0e9
diff --git a/intranet/utils/locking.py b/intranet/utils/locking.py index <HASH>..<HASH> 100644 --- a/intranet/utils/locking.py +++ b/intranet/utils/locking.py @@ -75,4 +75,4 @@ def lock_on(items: Iterable[Union[Model, Manager, QuerySet]]) -> None: combined_qs = combined_qs.union(*qs_list, all=False) # Now we actually do the locking. We order by PK first in an attempt to prevent deadlocks. - _ = combined_qs.order_by("pk").select_for_update().values_list("pk") + _ = list(combined_qs.order_by("pk").select_for_update().values_list("pk"))
fix(locking): force query evaluation It is now believed that the locking errors mentioned in 0dd<I>b0c<I>ca<I>cb<I>c<I>fabef<I>cd are caused by a failure to evaluate the query that is being locked on. This commit should finally fix those issues.
tjcsl_ion
train
py
f14f3e9b2d6b075d1c426d270e4ef45316cb04cd
diff --git a/test/spec/id-support.js b/test/spec/id-support.js index <HASH>..<HASH> 100644 --- a/test/spec/id-support.js +++ b/test/spec/id-support.js @@ -76,14 +76,15 @@ describe('bpmn-moddle - id-support', function() { var moddle = Helper.createModdle(); IdSupport.extend(moddle, new Ids()); - // when moddle.create('bpmn:ServiceTask', { id: 'ServiceTask_1' }); + // when IdSupport.extend(moddle, new Ids()); // then + // expect id to have been reset expect(function() { moddle.create('bpmn:ServiceTask', {
chore(tests): add additional comment
bpmn-io_bpmn-moddle
train
js
e79ed5222dce4bc4ead83f58333600a8dced7d23
diff --git a/test/test-bad-connection-string.js b/test/test-bad-connection-string.js index <HASH>..<HASH> 100644 --- a/test/test-bad-connection-string.js +++ b/test/test-bad-connection-string.js @@ -17,6 +17,10 @@ db.open("this is wrong", function(err) { error: '[node-odbc] SQL_ERROR', message: '[unixODBC][Driver Manager]Data source name not found, and no default driver specified', state: 'IM002' + , errors : [{ + message: '[unixODBC][Driver Manager]Data source name not found, and no default driver specified', + state: 'IM002' + }] }); assert.equal(db.connected, false);
test: fix test-bad-connection-string.js for use with newer error objects
ratanakvlun_node-odbc
train
js
99dc48bed988b275e607105ec20a893195cfaf8f
diff --git a/src/Adapter.php b/src/Adapter.php index <HASH>..<HASH> 100644 --- a/src/Adapter.php +++ b/src/Adapter.php @@ -314,8 +314,9 @@ class Adapter extends AbstractAdapter public function listContents($directory = '', $recursive = false) { return $this->client->listObjects([ - 'Bucket' => $this->getBucket(), - 'Prefix' => $directory, + 'Bucket' => $this->getBucket(), + 'Prefix' => rtrim($directory, '/') . '/', + 'Delimiter' => $recursive ? '' : '/', ]); }
fix: listContents recursive
freyo_flysystem-qcloud-cos-v5
train
php
e9a8796326e6f4620eb84ce0e60dbfc149dbef57
diff --git a/workflow/common/common.go b/workflow/common/common.go index <HASH>..<HASH> 100644 --- a/workflow/common/common.go +++ b/workflow/common/common.go @@ -96,7 +96,7 @@ const ( ExecutorStagingEmptyDir = "/argo/staging" // ExecutorScriptSourcePath is the path which init will write the script source file to for script templates ExecutorScriptSourcePath = "/argo/staging/script" - // ExecutorResourceManifestPath is the path which init will write the a manifest file to for resource templates + // ExecutorResourceManifestPath is the path which init will write the manifest file to for resource templates ExecutorResourceManifestPath = "/tmp/manifest.yaml" // Various environment variables containing pod information exposed to the executor container(s)
chore: typo (#<I>)
argoproj_argo
train
go
6582ecc3485099d6a98b9d9ca0ac5c66bc8be750
diff --git a/examples/with-mongodb-mongoose/models/Pet.js b/examples/with-mongodb-mongoose/models/Pet.js index <HASH>..<HASH> 100644 --- a/examples/with-mongodb-mongoose/models/Pet.js +++ b/examples/with-mongodb-mongoose/models/Pet.js @@ -7,21 +7,21 @@ const PetSchema = new mongoose.Schema({ type: String, required: [true, 'Please provide a name for this pet.'], - maxlength: [20, 'Name cannot be more than 60 characters'], + maxlength: [60, 'Name cannot be more than 60 characters'], }, owner_name: { /* The owner of this pet */ type: String, required: [true, "Please provide the pet owner's name"], - maxlength: [20, "Owner's Name cannot be more than 60 characters"], + maxlength: [60, "Owner's Name cannot be more than 60 characters"], }, species: { /* The species of your pet */ type: String, required: [true, 'Please specify the species of your pet.'], - maxlength: [30, 'Species specified cannot be more than 40 characters'], + maxlength: [40, 'Species specified cannot be more than 40 characters'], }, age: { /* Pet's age, if applicable */
fix(examples): maxlength was inconsistent (#<I>) the value and help-text were irritating the value of the help-text is now used as value ## Documentation / Examples - [x] Make sure the linting passes by running `yarn lint`
zeit_next.js
train
js
b260e4ebff7a0a2a97f0a021a4b2b653b749f2f1
diff --git a/build/cherry-pick.js b/build/cherry-pick.js index <HASH>..<HASH> 100644 --- a/build/cherry-pick.js +++ b/build/cherry-pick.js @@ -93,7 +93,7 @@ function getCommits(branch) { // filter merge commits and any types that don't match the release type if ( !merge && - !subject.startsWith('merge branch') && + subject && !subject.startsWith('merge branch') && scope !== 'release' && commitType[releaseType] && !ignoreCommits.includes(hash)
chore: fix cherry-pick script (#<I>)
dequelabs_axe-core
train
js
eb648f297eafd3f19d2f0a73f71206618ea4a34e
diff --git a/test/tests.js b/test/tests.js index <HASH>..<HASH> 100644 --- a/test/tests.js +++ b/test/tests.js @@ -718,6 +718,10 @@ exports['Blocks'] = function(test) { '<p id="id1">A _test_</p>', 'id attribute and block option'); test_document( + '.-spans -macros +specials\n_A {macro}_', + '<p>_A {macro}_</p>', + 'multiple block options'); + test_document( '.-container\n..\nfoo\n..', '<div>foo</div>', '-container expansion option');
test: Block Attributes: Multiple block options
srackham_rimu
train
js
0436ee0121d3a44c7a814a6219d975d08255d6e2
diff --git a/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js b/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js index <HASH>..<HASH> 100644 --- a/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js +++ b/packages/mdc-top-app-bar/addon/components/mdc-top-app-bar.js @@ -85,6 +85,18 @@ export default Component.extend (Theme, { this._createComponent (); }, + didRender () { + this._super (...arguments); + + // Set the scroll target for the top app bar. We process it after the component + // has rendered because we need to make sure all elements, including those for + // its children, are part of the dom model. + let scrollTarget = this.get ('scrollTarget'); + + if (isPresent (scrollTarget)) { + this.setScrollTarget (scrollTarget); + } + }, willDestroyElement () { this._super (...arguments); @@ -95,6 +107,14 @@ export default Component.extend (Theme, { this.getWithDefault ('navigation', noOp) (); }, + setScrollTarget (scrollTarget) { + let element = document.querySelector (scrollTarget); + + if (isPresent (element)) { + this._topAppBar.setScrollTarget (element); + } + }, + _createComponent () { this._topAppBar = new MDCTopAppBar (this.element);
feat: Can set the scroll target for the top app bar
onehilltech_ember-cli-mdc
train
js
bb9415e4491b4b27a3d29b67a952acd94a16a49c
diff --git a/packages/xod-client-electron/src/app/remoteActions.js b/packages/xod-client-electron/src/app/remoteActions.js index <HASH>..<HASH> 100644 --- a/packages/xod-client-electron/src/app/remoteActions.js +++ b/packages/xod-client-electron/src/app/remoteActions.js @@ -1,5 +1,5 @@ import R from 'ramda'; -import { save, getProjects, loadProjectWithLibs, loadLibs, arrangeByFiles, pack, isDirectoryExists } from 'xod-fs'; +import { save, getProjects, loadProjectWithLibs, loadAllLibs, arrangeByFiles, pack, isDirectoryExists } from 'xod-fs'; const extract = json => arrangeByFiles(JSON.parse(json)); @@ -31,7 +31,7 @@ export const loadProject = ({ path, workspace }, onFinish) => .then(onFinish); export const changeWorkspace = ({ path }, onFinish) => - loadLibs(['xod/core'], path) + loadAllLibs(path) .then(R.assoc('nodeTypes', R.__, { path })) .then(onFinish);
feat(xod-client-electron): replace load exactly xod/core lib with loadAllLibs function
xodio_xod
train
js
41aaf745ad8a4d4be7129fd4f8ea2cdc5521c4e4
diff --git a/fuse/readonly/readonly_unix.go b/fuse/readonly/readonly_unix.go index <HASH>..<HASH> 100644 --- a/fuse/readonly/readonly_unix.go +++ b/fuse/readonly/readonly_unix.go @@ -257,13 +257,15 @@ func (s *Node) Read(ctx context.Context, req *fuse.ReadRequest, resp *fuse.ReadR if err != nil { return err } - - buf := resp.Data[:min(req.Size, int(int64(r.Size())-req.Offset))] + // Data has a capacity of Size + buf := resp.Data[:int(req.Size)] n, err := io.ReadFull(r, buf) - if err != nil && err != io.EOF { + resp.Data = buf[:n] + switch err { + case nil, io.EOF, io.ErrUnexpectedEOF: + default: return err } - resp.Data = resp.Data[:n] lm["res_size"] = n return nil // may be non-nil / not succeeded } @@ -287,10 +289,3 @@ type roNode interface { } var _ roNode = (*Node)(nil) - -func min(a, b int) int { - if a < b { - return a - } - return b -}
fix: fix a potential out of bounds issue in fuse We likely encountered a file that misreported its size. That or there was no bug here and we hit an issue somewhere else. Regardless, there's no reason not to simplify this code and this should fix the issue.
ipfs_go-ipfs
train
go
39258cacafa5c770fb40d99075a97b8e6427adba
diff --git a/lib/googleauth/service_account.rb b/lib/googleauth/service_account.rb index <HASH>..<HASH> 100644 --- a/lib/googleauth/service_account.rb +++ b/lib/googleauth/service_account.rb @@ -123,8 +123,10 @@ module Google def apply_self_signed_jwt! a_hash # Use the ServiceAccountJwtHeaderCredentials using the same cred values cred_json = { - private_key: @signing_key.to_s, - client_email: @issuer + private_key: @signing_key.to_s, + client_email: @issuer, + project_id: @project_id, + quota_project_id: @quota_project_id } key_io = StringIO.new MultiJson.dump(cred_json) alt = ServiceAccountJwtHeaderCredentials.make_creds json_key_io: key_io
fix: Stop attempting to get the project from gcloud when applying self-signed JWTs (#<I>)
googleapis_google-auth-library-ruby
train
rb
86b84db9b7e751d22e7d5930f228c7817003e25e
diff --git a/scripts/orm/nosql/common/doc.js b/scripts/orm/nosql/common/doc.js index <HASH>..<HASH> 100644 --- a/scripts/orm/nosql/common/doc.js +++ b/scripts/orm/nosql/common/doc.js @@ -84,16 +84,16 @@ Doc.prototype.set = function (data) { return self.save(); }; -// TODO: remove -// Doc.prototype.unset = function (name) { -// delete this._data[name]; -// return this.save(); -// }; - -// TODO: remove -// Doc.prototype._include = function () { // Include in cursor? -// return true; -// }; +// TODO: test in adapters! +Doc.prototype.unset = function (name) { + delete this._data[name]; + return this.save(); +}; + +// TODO: test in adapters! +Doc.prototype._include = function () { // Include in cursor? + return true; +}; Doc.prototype._register = function () { var self = this;
test(node): restored some broken node tests
delta-db_deltadb-server
train
js
4ed8c3e5d93f0d686de3d1764270563e15c6e199
diff --git a/blocks/blockstore/arc_cache_test.go b/blocks/blockstore/arc_cache_test.go index <HASH>..<HASH> 100644 --- a/blocks/blockstore/arc_cache_test.go +++ b/blocks/blockstore/arc_cache_test.go @@ -1,9 +1,10 @@ package blockstore import ( + "testing" + "github.com/ipfs/go-ipfs/blocks" "github.com/ipfs/go-ipfs/blocks/key" - "testing" ds "gx/ipfs/QmTxLSvdhwg68WJimdS6icLPhZi28aTp6b7uihC2Yb47Xk/go-datastore" syncds "gx/ipfs/QmTxLSvdhwg68WJimdS6icLPhZi28aTp6b7uihC2Yb47Xk/go-datastore/sync" @@ -122,7 +123,7 @@ func TestGetFillsCache(t *testing.T) { } } -func TestGetAndDeleteFalseShortCirciot(t *testing.T) { +func TestGetAndDeleteFalseShortCircuit(t *testing.T) { arc, _, cd := createStores(t) arc.Has(exampleBlock.Key())
test: fix typo in blockstore test Also format imports License: MIT
ipfs_go-ipfs
train
go
aba5cc8369b9ac644b64ac48c2818a6afe352b30
diff --git a/lib/boot/refs/find-component.js b/lib/boot/refs/find-component.js index <HASH>..<HASH> 100644 --- a/lib/boot/refs/find-component.js +++ b/lib/boot/refs/find-component.js @@ -8,7 +8,7 @@ function findComponent (ref, components, jsonPath) { } // findObject function applyPath (obj, jsonPath) { - if (!jsonPath) return obj + if (!jsonPath || !obj) return obj const selection = jp.query(obj, jsonPath) return selection.length === 1 ? selection[0] : selection
fix(tymlyRef): Don't apply path to a null object.
wmfs_tymly-core
train
js
72e8fb82a604d08589aa65accbd2685e8027c24a
diff --git a/packages/halo/src/css/index.js b/packages/halo/src/css/index.js index <HASH>..<HASH> 100644 --- a/packages/halo/src/css/index.js +++ b/packages/halo/src/css/index.js @@ -1,4 +1,4 @@ -import { colorsStatus } from '@pluralsight/ps-design-system-core' +import { colorsBlue, colorsStatus } from '@pluralsight/ps-design-system-core' import { names as themeNames } from '@pluralsight/ps-design-system-theme' export const BASE_CLASSNAME = '.psds-halo' @@ -20,7 +20,7 @@ export default { position: 'absolute', borderWidth: '3px', borderStyle: 'solid', - borderColor: colorsStatus.info, + borderColor: colorsBlue.base, pointerEvents: 'none', visibility: 'hidden' } @@ -41,14 +41,14 @@ export default { [`${BASE_CLASSNAME}--visible`]: { '&:after': { visibility: 'visible', - borderColor: colorsStatus.info + borderColor: colorsBlue.base } }, [`${BASE_CLASSNAME}--visible-on-focus`]: { '&:focus-within:after, &[focus-within]:after': { visibility: 'visible', - borderColor: colorsStatus.info + borderColor: colorsBlue.base } },
refactor(halo): use base blue for focus indicator color
pluralsight_design-system
train
js
a3b6c0360cf36a6cc6159c52daf7334a322e5d29
diff --git a/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/Messenger.java b/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/Messenger.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/Messenger.java +++ b/actor-sdk/sdk-core/core/core-shared/src/main/java/im/actor/core/Messenger.java @@ -601,7 +601,7 @@ public class Messenger { */ @ObjectiveCName("sendMessageWithPeer:withText:") public void sendMessage(@NotNull Peer peer, @NotNull String text) { - sendMessage(peer, text, null, null, false); + sendMessage(peer, text, null, null, true); } /**
fix(android): mentions detect
actorapp_actor-platform
train
java
655d0ccc06e04cf532741c78245578ec448ed45f
diff --git a/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js b/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js +++ b/packages/bonde-admin-canary/src/scenes/Dashboard/graphql/allUserCommunities.graphql.js @@ -18,6 +18,12 @@ export default gql` facebook_app_id email_template_from modules + recipient { + id + transfer_day: recipient(path: "transfer_day") + transfer_interval: recipient(path: "transfer_interval") + bank_account: recipient(path: "bank_account") + } } communities_aggregate {
fix(canary): add recipient on user community data
nossas_bonde-client
train
js
f6c455bdbbe34e87ebdaebf357f074f0e9a352a9
diff --git a/lib/client.js b/lib/client.js index <HASH>..<HASH> 100644 --- a/lib/client.js +++ b/lib/client.js @@ -125,11 +125,6 @@ class Parser extends HTTPParser { socket.resume() client[kQueue][client[kComplete]++] = null - if (client[kComplete] > 256) { - client[kQueue].splice(0, client[kComplete]) - client[kInflight] -= client[kComplete] - client[kComplete] = 0 - } resume(client) } @@ -271,18 +266,23 @@ function resume (client) { } if (client.size === 0) { - client[kQueue].length = 0 - client[kInflight] = 0 - client[kComplete] = 0 - - if (!client[kClosed]) { - client.emit('drain') - } else { + if (client[kClosed]) { client.destroy(nop) + } else if (client[kComplete] > 0) { + client[kQueue].length = 0 + client[kInflight] = 0 + client[kComplete] = 0 + client.emit('drain') } return } + if (client[kComplete] > 256) { + client[kQueue].splice(0, client[kComplete]) + client[kInflight] -= client[kComplete] + client[kComplete] = 0 + } + if (client.running >= client.pipelining) { return }
refactor: closed, drain & overlfow
mcollina_undici
train
js
ae498628dab8789231828c167ef453b6dc26d49b
diff --git a/website/gulpfile.js b/website/gulpfile.js index <HASH>..<HASH> 100644 --- a/website/gulpfile.js +++ b/website/gulpfile.js @@ -35,6 +35,10 @@ gulp.task('dgeni', function() { dgeni.generate().then(function(docs) { console.log(docs.length, 'docs generated'); + }).then(function() { + // Copy files over + gulp.src(['docgen/build/*.json']) + .pipe(gulp.dest(paths.outputDir + '/apiDocs')); }); }); @@ -55,10 +59,6 @@ gulp.task('copyFiles', function() { gulp.src('partials/*.html') .pipe(gulp.dest(paths.outputDir + '/partials')); - // Degeni docs. - gulp.src(['docgen/build/*.json']) - .pipe(gulp.dest(paths.outputDir + '/apiDocs')); - // Images. gulp.src('img/**') .pipe(gulp.dest('build/img'));
fix(docs): you no longer have to run gulp twice Closes issue #<I>
angular_protractor
train
js