hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
2b810fd8193a15dff53393698478c0d2fcf33071
|
diff --git a/lib/util/injectscripts.js b/lib/util/injectscripts.js
index <HASH>..<HASH> 100644
--- a/lib/util/injectscripts.js
+++ b/lib/util/injectscripts.js
@@ -87,16 +87,19 @@ module.exports = function (pathOrHtml, resourceType, opts, cb) {
}
} else if (resourceType === 'graphic') {
if (config.rollbar && config.rollbar.enabled) {
- scripts.unshift('<script src="/components/rollbar/dist/rollbar.min.js"></script>');
- scripts.unshift(`<script>
- const _rollbarConfig = {
- accessToken: '${config.rollbar.token}',
- captureUncaught: true,
- payload: {
- environment: '${config.rollbar.environment}'
- }
- };
- </script>`);
+ scripts.unshift(
+ '<script src="/components/rollbar/dist/rollbar.min.js"></script>',
+ `<script>
+ Rollbar.init({
+ accessToken: '${config.rollbar.postClientItem}',
+ captureUncaught: true,
+ captureUnhandledRejections: true,
+ payload: {
+ environment: '${config.rollbar.environment}'
+ }
+ })
+ </script>`
+ );
}
// Graphics need to create their own socket
|
fix(rollbar): fix browser-side Rollbar not receiving the correct access token from the config
This prevented it from working at all. lol
|
nodecg_nodecg
|
train
|
js
|
fc38ed0f038f51e2718e160592848bca70d54e53
|
diff --git a/src/masonite/foundation/Kernel.py b/src/masonite/foundation/Kernel.py
index <HASH>..<HASH> 100644
--- a/src/masonite/foundation/Kernel.py
+++ b/src/masonite/foundation/Kernel.py
@@ -2,6 +2,7 @@ import os
from cleo import Application as CommandApplication
from .response_handler import response_handler
+from .. import __version__
from ..commands import (
TinkerCommand,
CommandCapsule,
@@ -63,7 +64,7 @@ class Kernel:
def register_commands(self):
self.application.bind(
"commands",
- CommandCapsule(CommandApplication("Masonite Version:", "4.0")).add(
+ CommandCapsule(CommandApplication("Masonite", __version__)).add(
TinkerCommand(),
KeyCommand(),
ServeCommand(self.application),
|
fix: display real version in Masonite commands help
|
MasoniteFramework_masonite
|
train
|
py
|
7e943590dac1c65c146ff3abd4f35816e33de40a
|
diff --git a/hooks/lib/ios/associatedDomains.js b/hooks/lib/ios/associatedDomains.js
index <HASH>..<HASH> 100644
--- a/hooks/lib/ios/associatedDomains.js
+++ b/hooks/lib/ios/associatedDomains.js
@@ -60,11 +60,8 @@
var second = preferences.linkDomain.split('.')[1]
var rest = preferences.linkDomain.split('.').slice(2).join('.')
var alternate = first + '-alternate'
- var test = 'test-' + second
domainList.push(prefix + alternate + '.' + second + '.' + rest)
- domainList.push(prefix + first + '.' + test + '.' + rest)
- domainList.push(prefix + alternate + '.' + test + '.' + rest)
}
return domainList
|
chore: removed test link domain from associated domains
|
BranchMetrics_cordova-ionic-phonegap-branch-deep-linking
|
train
|
js
|
ed93b339c45146cbcbd37b2bf32bd194bc6f4240
|
diff --git a/packages/vuetifyjs.com/lang/en/vuetify/AppToolbar.js b/packages/vuetifyjs.com/lang/en/vuetify/AppToolbar.js
index <HASH>..<HASH> 100644
--- a/packages/vuetifyjs.com/lang/en/vuetify/AppToolbar.js
+++ b/packages/vuetifyjs.com/lang/en/vuetify/AppToolbar.js
@@ -11,6 +11,11 @@ export default {
icon: 'mdi-account-multiple'
},
{
+ href: 'https://www.reddit.com/r/vuetifyjs/',
+ text: 'Reddit',
+ icon: 'mdi-reddit'
+ },
+ {
href: 'https://medium.com/vuetify',
text: 'Medium Publication',
icon: 'mdi-medium'
|
feat(ecosystem): added reddit
|
vuetifyjs_vuetify
|
train
|
js
|
0e4109a5df0931953460092d6b95bb1078b338e9
|
diff --git a/tests/Helper/TestCase.php b/tests/Helper/TestCase.php
index <HASH>..<HASH> 100644
--- a/tests/Helper/TestCase.php
+++ b/tests/Helper/TestCase.php
@@ -21,7 +21,6 @@ class TestCase extends PHPUnit_Framework_TestCase
* @var Di
*/
protected $di;
- protected static $logged = [];
public function setUp()
{
@@ -42,7 +41,12 @@ class TestCase extends PHPUnit_Framework_TestCase
parent::setUp();
$class = get_class($this);
- isset(static::$logged[$class]) or Log::debug("Starting {$class} tests");
- static::$logged[$class] = true;
+ Log::debug("Running {$class}::{$this->getName()}() ...");
+ }
+
+ public function tearDown()
+ {
+ parent::tearDown();
+ Log::debug("Finished.\n");
}
}
|
test: log start and finish for test cases
|
phwoolcon_phwoolcon
|
train
|
php
|
5a80d2225f54176f0c4d463efb181d40f802b300
|
diff --git a/lib/anycable/rails/config.rb b/lib/anycable/rails/config.rb
index <HASH>..<HASH> 100644
--- a/lib/anycable/rails/config.rb
+++ b/lib/anycable/rails/config.rb
@@ -1,6 +1,9 @@
# frozen_string_literal: true
require "anycable/config"
+# Make sure Rails extensions for Anyway Config are loaded
+# See https://github.com/anycable/anycable-rails/issues/63
+require "anyway/rails"
# Extend AnyCable configuration with:
# - `access_logs_disabled` (defaults to true) — whether to print Started/Finished logs
|
fix: ensure anyway/rails is loaded
|
anycable_anycable-rails
|
train
|
rb
|
fd724df176241cd40c813cd439bd34dcb8d4ceea
|
diff --git a/pook/mock.py b/pook/mock.py
index <HASH>..<HASH> 100644
--- a/pook/mock.py
+++ b/pook/mock.py
@@ -8,7 +8,7 @@ from .request import Request
from .matcher import MatcherEngine
from .helpers import trigger_methods
from .exceptions import PookExpiredMock
-from .matchers import init as matcher # noqa
+from .matchers import init as matcher
def _append_funcs(target, items):
|
refactor(mock): remove noqa statement
|
h2non_pook
|
train
|
py
|
b4d37b11a61492da50485d0e4822680258a8d581
|
diff --git a/packages/upload-core/upload.js b/packages/upload-core/upload.js
index <HASH>..<HASH> 100644
--- a/packages/upload-core/upload.js
+++ b/packages/upload-core/upload.js
@@ -75,15 +75,21 @@ class Upload {
}
onSuccessCallback() {
- const response = this.upload._xhr.getResponseHeader('references'); // eslint-disable-line
+ const xhr = this.upload._xhr; // eslint-disable-line
+
+ const references = xhr.getResponseHeader('references');
+ if (references) {
+ this.references = JSON.parse(references);
+ }
- this.responses = JSON.parse(response);
this.onSuccess();
}
onSuccess() {
console.log('download %s from %s', this.upload.file.name, this.upload.url); // eslint-disable-line
- console.log('references %s', this.responses.join(',')); // eslint-disable-line
+ if (this.references) {
+ console.log('references %s', this.responses.join(',')); // eslint-disable-line
+ }
}
}
|
refactor(upload-core): guard access to references
|
Availity_sdk-js
|
train
|
js
|
ffb1be88368f183b12fc5789c7d20604f35ba08a
|
diff --git a/packages/mysql/lib/mysql_p.js b/packages/mysql/lib/mysql_p.js
index <HASH>..<HASH> 100644
--- a/packages/mysql/lib/mysql_p.js
+++ b/packages/mysql/lib/mysql_p.js
@@ -74,14 +74,16 @@ function patchGetConnection(pool) {
var args = arguments;
var callback = args[0];
- if(callback instanceof Function){
+ if (callback instanceof Function) {
args[0] = (err, connection) => {
if(connection) patchObject(connection);
return callback(err, connection);
}
}
- return pool[baseFcn].apply(pool, args);
+ var result = pool[baseFcn].apply(pool, args);
+ if (result instanceof Promise) return result.then(patchObject);
+ else return result;
}
}
@@ -99,6 +101,7 @@ function patchObject(connection) {
if(connection.getConnection instanceof Function){
patchGetConnection(connection);
}
+ return connection;
}
function resolveArguments(argsObj) {
|
feat: add mysql2 support to patchGetConnection
|
aws_aws-xray-sdk-node
|
train
|
js
|
22a2f3f5b5eb38a5200fd653227ad846ae46d43e
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -43,7 +43,7 @@ required_packages = [
"inotify_simple==1.2.1",
"werkzeug==0.15.5",
"paramiko==2.4.2",
- "psutil==5.6.7",
+ "psutil>=5.6.7",
"protobuf>=3.1",
"scipy>=1.2.2",
]
|
fix: relax psutils version requirements to avoid version conflicts. (#<I>)
|
aws_sagemaker-containers
|
train
|
py
|
0bd1d5b4314d216d1a0b09df0129d6d260821641
|
diff --git a/tests/CommonDatatypeTest.php b/tests/CommonDatatypeTest.php
index <HASH>..<HASH> 100644
--- a/tests/CommonDatatypeTest.php
+++ b/tests/CommonDatatypeTest.php
@@ -48,11 +48,11 @@ class CommonDatatypeTest extends \PHPUnit_Framework_TestCase
} else if ($mdat['key'] === 'KBC.datatype.length') {
$this->fail("unspecified length should not create metadata.");
} else if ($mdat['key'] === 'KBC.datatype.nullable') {
- $this->assertEquals(false, $mdat['value']);
+ $this->assertEquals(true, $mdat['value']);
} else if ($mdat['key'] === 'KBC.datatype.format') {
$this->fail("unspecified format should not create metadata.");
} else if ($mdat['key'] === 'KBC.datatype.default') {
- $this->assertEquals("", $mdat['value']);
+ $this->assertEquals("NULL", $mdat['value']);
} else if ($mdat['key'] === 'KBC.datatype.basetype') {
$this->assertEquals('STRING', $mdat['value']);
}
|
fix: test for nullable true
|
keboola_php-datatypes
|
train
|
php
|
4c383d86f18d109f9176d3bdb5c25a42b08297c2
|
diff --git a/docs/src/examples/addons/Responsive/Types/ResponsiveExampleMaxWidth.js b/docs/src/examples/addons/Responsive/Types/ResponsiveExampleMaxWidth.js
index <HASH>..<HASH> 100644
--- a/docs/src/examples/addons/Responsive/Types/ResponsiveExampleMaxWidth.js
+++ b/docs/src/examples/addons/Responsive/Types/ResponsiveExampleMaxWidth.js
@@ -7,7 +7,7 @@ const ResponsiveExampleMaxWidth = () => (
Visible only if display has <code>767px</code> width and lower
</Responsive>
<Responsive as={Segment} maxWidth={2569}>
- Visible only if display has <code>2569px</code> width
+ Visible only if display has <code>2569px</code> width and lower
</Responsive>
</Segment.Group>
)
|
docs(Responsive): update ResponsiveExampleMaxWidth.js (added two words to clarify) (#<I>)
Added "and lower" to the <I>px width example, because that's what it does and the wording was confusing on first sight.
|
Semantic-Org_Semantic-UI-React
|
train
|
js
|
cedfb1d9ab7a7cc58c9032dd40509dc34666b3e9
|
diff --git a/workflow/controller/exec_control.go b/workflow/controller/exec_control.go
index <HASH>..<HASH> 100644
--- a/workflow/controller/exec_control.go
+++ b/workflow/controller/exec_control.go
@@ -14,7 +14,7 @@ import (
)
// applyExecutionControl will ensure a pod's execution control annotation is up-to-date
-// kills any pending pods when workflow has reached it's deadline
+// kills any pending and running pods when workflow has reached it's deadline
func (woc *wfOperationCtx) applyExecutionControl(ctx context.Context, pod *apiv1.Pod, wfNodesLock *sync.RWMutex) {
if pod == nil {
return
@@ -26,7 +26,7 @@ func (woc *wfOperationCtx) applyExecutionControl(ctx context.Context, pod *apiv1
case apiv1.PodSucceeded, apiv1.PodFailed:
// Skip any pod which are already completed
return
- case apiv1.PodPending:
+ case apiv1.PodPending, apiv1.PodRunning:
// Check if we are currently shutting down
if woc.GetShutdownStrategy().Enabled() {
// Only delete pods that are not part of an onExit handler if we are "Stopping" or all pods if we are "Terminating"
|
fix: Stop the workflow if activeDeadlineSeconds has beed patched (#<I>)
|
argoproj_argo
|
train
|
go
|
d9df1b341a99f0d606155e3de1a4982e3bcccdf5
|
diff --git a/lib/media/streaming_engine.js b/lib/media/streaming_engine.js
index <HASH>..<HASH> 100644
--- a/lib/media/streaming_engine.js
+++ b/lib/media/streaming_engine.js
@@ -1211,7 +1211,10 @@ shaka.media.StreamingEngine = class {
const info = this.playerInterface_.mediaSourceEngine.getBufferedInfo();
const buffered = info[mediaState.type];
- shaka.log.v1(logPrefix, 'finished fetch and append', buffered);
+ // Convert the buffered object to a string capture its properties on
+ // WebOS.
+ shaka.log.v1(logPrefix, 'finished fetch and append',
+ JSON.stringify(buffered));
if (!mediaState.waitingToClearBuffer) {
this.playerInterface_.onSegmentAppended();
|
fix: Log buffered info as a string
On WebOS, objects are logged as 'Object' rather than the properties.
Convert buffered info to a string, so that the properties get printed
in the logs.
Change-Id: Ia6daab<I>ed<I>e<I>ff7d<I>c<I>fdcb<I>bdb7e
|
google_shaka-player
|
train
|
js
|
5c5d9398d9b19c27620b1ff4550df419c8c93541
|
diff --git a/packages/components/bolt-image/src/image.js b/packages/components/bolt-image/src/image.js
index <HASH>..<HASH> 100644
--- a/packages/components/bolt-image/src/image.js
+++ b/packages/components/bolt-image/src/image.js
@@ -190,8 +190,8 @@ class BoltImage extends withLitHtml() {
// Include <noscript> for server-side rendered components
const fallbackImageElement = () => {
- // this.is_ssr is undefined at the moment, placeholder for future server-side rendering
- if (lazyload && src && this.is_ssr) {
+ // this.isSSR is undefined at the moment, placeholder for future server-side rendering
+ if (lazyload && src && this.isSSR) {
return html`
<noscript>
<img
|
refactor: rename is_ssr ro isSSR to follow JS convention
|
bolt-design-system_bolt
|
train
|
js
|
3803c24725b1bc68458f6903107e13690c343f55
|
diff --git a/demo/src/App.js b/demo/src/App.js
index <HASH>..<HASH> 100644
--- a/demo/src/App.js
+++ b/demo/src/App.js
@@ -586,11 +586,11 @@ class App extends Component {
<div ref={tc => (this.treeContainer = tc)} className="tree-container">
<Tree
data={this.state.data}
- // renderCustomNodeElement={
- // this.state.renderCustomNodeElement
- // ? rd3tProps => this.state.renderCustomNodeElement(rd3tProps, this.state)
- // : undefined
- // }
+ renderCustomNodeElement={
+ this.state.renderCustomNodeElement
+ ? rd3tProps => this.state.renderCustomNodeElement(rd3tProps, this.state)
+ : undefined
+ }
rootNodeClassName="demo-node"
branchNodeClassName="demo-node"
orientation={this.state.orientation}
|
fix(demo): restore toggling between node rendering types
|
bkrem_react-d3-tree
|
train
|
js
|
087f309858d94faaa6158becb56c0f7702a08ac4
|
diff --git a/src/main/java/com/twilio/Twilio.java b/src/main/java/com/twilio/Twilio.java
index <HASH>..<HASH> 100644
--- a/src/main/java/com/twilio/Twilio.java
+++ b/src/main/java/com/twilio/Twilio.java
@@ -116,14 +116,9 @@ public class Twilio {
* Set the account sid.
*
* @param accountSid account sid to use
- * @throws AuthenticationException if account sid is null
*/
public static synchronized void setAccountSid(final String accountSid) {
- if (accountSid == null) {
- throw new AuthenticationException("AccountSid can not be null");
- }
-
- if (!accountSid.equals(Twilio.accountSid)) {
+ if (!Objects.equals(accountSid, Twilio.accountSid)) {
Twilio.invalidate();
}
|
fix: support setting null account sid (#<I>)
|
twilio_twilio-java
|
train
|
java
|
bcf2add6fb9c855ca7d465f85c8547073c6d88e9
|
diff --git a/src/com/transloadit/sdk/Transloadit.java b/src/com/transloadit/sdk/Transloadit.java
index <HASH>..<HASH> 100644
--- a/src/com/transloadit/sdk/Transloadit.java
+++ b/src/com/transloadit/sdk/Transloadit.java
@@ -43,17 +43,17 @@ public class Transloadit {
/**
*
- * @return an assembly instance ({@link Assembly ) tied with the transloadit client.
+ * @return an assemblyApi instance ({@link AssemblyApi} ) tied with the transloadit client.
*/
- public Assembly assembly() {
- return new Assembly(this);
+ public AssemblyApi assemblyApi() {
+ return new AssemblyApi(this);
}
/**
*
* @return Map containing authentication key and the time it expires
*/
- public Map<String, String> getAuthData() {
+ Map<String, String> getAuthData() {
Map<String, String> authData = new HashMap<>();
authData.put("key", key);
authData.put("expires", expires);
@@ -66,7 +66,7 @@ public class Transloadit {
* @param message String data that needs to be encrypted.
* @return signature generate based on the message passed and the transloadit secret.
*/
- public String getSignature(String message) {
+ String getSignature(String message) {
byte[] kSecret = secret.getBytes(StandardCharsets.UTF_8);
byte[] rawHmac = HmacSHA1(kSecret, message);
byte[] hexBytes = new Hex().encode(rawHmac);
|
refactor: Improved access modifiers
|
transloadit_java-sdk
|
train
|
java
|
273e4f29824fa2dd15f6afaab8c2fe99610a8149
|
diff --git a/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/LPAResetAttribute.java b/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/LPAResetAttribute.java
index <HASH>..<HASH> 100755
--- a/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/LPAResetAttribute.java
+++ b/uPortal-layout/uPortal-layout-impl/src/main/java/org/apereo/portal/layout/dlm/LPAResetAttribute.java
@@ -39,6 +39,7 @@ public class LPAResetAttribute implements ILayoutProcessingAction {
* Reset a parameter to not override the value specified by a fragment. This is done by removing
* the parm edit in the PLF and setting the value in the ILF to the passed-in fragment value.
*/
+ @Override
public void perform() throws PortalException {
/*
* push the change into the PLF
|
docs: annotate LPAResetAttribute perform() as @Override
|
Jasig_uPortal
|
train
|
java
|
7527271feb4d420f098af031d5a344f2ac041fc5
|
diff --git a/packages/@vue/cli-service/lib/config/app.js b/packages/@vue/cli-service/lib/config/app.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-service/lib/config/app.js
+++ b/packages/@vue/cli-service/lib/config/app.js
@@ -251,6 +251,9 @@ module.exports = (api, options) => {
noErrorOnMissing: true,
globOptions: {
ignore: publicCopyIgnore
+ },
+ info: {
+ minimized: true
}
}]
}
|
fix(cli-service): skip minimization of public folder (#<I>)
|
vuejs_vue-cli
|
train
|
js
|
8f58835fa118d97b5328f72bb58146074624d0ba
|
diff --git a/npm/vue/.releaserc.js b/npm/vue/.releaserc.js
index <HASH>..<HASH> 100644
--- a/npm/vue/.releaserc.js
+++ b/npm/vue/.releaserc.js
@@ -1,7 +1,12 @@
module.exports = {
...require('../../.releaserc.base'),
branches: [
- { name: 'npm/vue/v2', channel: 'latest', range: '2.x' },
+ // we need to keep this branch in here even if no used because semantic-release demands
+ // that we have at least one branch that has no config
+ 'next/npm/vue',
+ // this line forces releasing 2.X releases on the latest channel
+ { name: 'npm/vue/v2', range: '2.X.X' },
+ // this one releases v3 on master as beta on the next channel
{ name: 'master', channel: 'next', prerelease: 'beta' },
],
}
|
ci: release vue3 on master (#<I>)
|
cypress-io_cypress
|
train
|
js
|
05ab9ad4cff2f2cc0be7ef60452ac9faaa24accf
|
diff --git a/Repository/FilterRepository.php b/Repository/FilterRepository.php
index <HASH>..<HASH> 100644
--- a/Repository/FilterRepository.php
+++ b/Repository/FilterRepository.php
@@ -27,15 +27,21 @@
namespace whatwedo\TableBundle\Repository;
-use Doctrine\ORM\EntityRepository;
+use Doctrine\Bundle\DoctrineBundle\Repository\ServiceEntityRepository;
+use Symfony\Bridge\Doctrine\RegistryInterface;
use whatwedo\TableBundle\Entity\Filter;
use whatwedo\TableBundle\Enum\FilterStateEnum;
/**
* @author Nicolo Singer <nicolo@whatwedo.ch>
*/
-class FilterRepository extends EntityRepository
+class FilterRepository extends ServiceEntityRepository
{
+ public function __construct(RegistryInterface $registry)
+ {
+ parent::__construct($registry, Filter::class);
+ }
+
/**
* @param string $path Route-Path
* @param string $username Username
@@ -66,4 +72,4 @@ class FilterRepository extends EntityRepository
->getQuery()
->getResult();
}
-}
\ No newline at end of file
+}
|
refactor: register repository as service
|
whatwedo_TableBundle
|
train
|
php
|
62c5c78a4649246d4d73d4ab8a3162158952d8b0
|
diff --git a/src/common.js b/src/common.js
index <HASH>..<HASH> 100644
--- a/src/common.js
+++ b/src/common.js
@@ -35,7 +35,7 @@ function toArray(object) {
* @returns {boolean}
*/
function isNull(value) {
- return toString.call(value) === '[object Null]'
+ return value === null;
}
/**
|
fix(common): isNull function, fixed
|
a8m_angular-filter
|
train
|
js
|
68170336d5cd889d5d05b62116f379c0cc0a7b9e
|
diff --git a/packages/netlify-cms-backend-github/src/API.js b/packages/netlify-cms-backend-github/src/API.js
index <HASH>..<HASH> 100644
--- a/packages/netlify-cms-backend-github/src/API.js
+++ b/packages/netlify-cms-backend-github/src/API.js
@@ -638,6 +638,11 @@ export default class API {
await this.patchBranch(branchName, commit.sha, { force: true });
}
+ // Update unpublished entries which don't have a PR. These are
+ // typically Open Authoring entries that have never been
+ // submitted for review.
+ await this.patchBranch(branchName, commit.sha);
+
return this.storeMetadata(contentKey, updatedMetadata);
}
}
|
fix(backend-github): update Open Authoring branches with no PR (#<I>)
|
netlify_netlify-cms
|
train
|
js
|
22a422643e5da6a4e54a47450fe116fe8ac405df
|
diff --git a/percy/percy.test.js b/percy/percy.test.js
index <HASH>..<HASH> 100644
--- a/percy/percy.test.js
+++ b/percy/percy.test.js
@@ -157,7 +157,7 @@ test('OTP-RR', async () => {
)
await routeViewerButton.click()
await page.waitForSelector('.route-viewer')
- await page.waitFortimeout(5000)
+ await page.waitForTimeout(5000)
await percySnapshotWithWait(page, 'Route Viewer')
|
ci(percy): correct typo
|
opentripplanner_otp-react-redux
|
train
|
js
|
63a9f2f2f291d653648fe2d4f7b535fe2f588a73
|
diff --git a/src/Twig/RequestRuntime.php b/src/Twig/RequestRuntime.php
index <HASH>..<HASH> 100644
--- a/src/Twig/RequestRuntime.php
+++ b/src/Twig/RequestRuntime.php
@@ -3,6 +3,7 @@
namespace EMS\CommonBundle\Twig;
use EMS\CommonBundle\Helper\EmsFields;
+use EMS\CommonBundle\Storage\NotSavedException;
use EMS\CommonBundle\Storage\Processor\Config;
use EMS\CommonBundle\Storage\Processor\Processor;
use EMS\CommonBundle\Storage\StorageManager;
@@ -118,7 +119,11 @@ class RequestRuntime implements RuntimeExtensionInterface
$config[EmsFields::ASSET_CONFIG_MIME_TYPE] = $mimeType;
}
- $hashConfig = $this->storageManager->saveConfig($config);
+ try {
+ $hashConfig = $this->storageManager->saveConfig($config);
+ } catch (NotSavedException $e) {
+ $hashConfig = $e->getHash();
+ }
if (isset($config[EmsFields::ASSET_CONFIG_GET_FILE_PATH]) && $config[EmsFields::ASSET_CONFIG_GET_FILE_PATH]) {
$configObj = new Config($this->storageManager, $hash, $hashConfig, $config);
|
fix: catch NotSavedException in ems_asset_path
|
ems-project_EMSCommonBundle
|
train
|
php
|
7ed2b58e875f67555dcda28cc8133b297a4b7e43
|
diff --git a/js/src/files/stat.js b/js/src/files/stat.js
index <HASH>..<HASH> 100644
--- a/js/src/files/stat.js
+++ b/js/src/files/stat.js
@@ -132,15 +132,14 @@ module.exports = (createCommon, options) => {
})
})
- // TODO: (achingbrain) - Not yet supported in js-ipfs or go-ipfs yet')
- it.skip('should stat outside of mfs', function (done) {
+ it('should stat outside of mfs', function (done) {
ipfs.files.stat('/ipfs/' + fixtures.smallFile.cid, (err, stat) => {
expect(err).to.not.exist()
expect(stat).to.eql({
type: 'file',
blocks: 0,
size: 12,
- hash: 'Qma4hjFTnCasJ8PVp3mZbZK5g2vGDT4LByLJ7m8ciyRFZP',
+ hash: fixtures.smallFile.cid,
cumulativeSize: 20,
withLocality: false,
local: undefined,
|
test: enable test stat with ipfs paths (#<I>)
Not sure why this is still skipped.
|
ipfs_interface-js-ipfs-core
|
train
|
js
|
5a3aff0cf50ad63f76fc1d7fc7df3375080ab498
|
diff --git a/build/paths.js b/build/paths.js
index <HASH>..<HASH> 100644
--- a/build/paths.js
+++ b/build/paths.js
@@ -12,7 +12,7 @@ module.exports = {
source: appRoot + '**/*.js',
tsSource: [
appRoot + '**/*.js', // list files to parse for d.ts
- '!' + appRoot + '*ValueConverter.js' // exclude entry file
+ '!' + appRoot + entryFileName // exclude entry file
],
resources: '*ValueConverter.js', // relative to root, resources can not that easily be bundled into a single file (due to naming conventions)
html: appRoot + '**/*.html',
diff --git a/build/tasks/build.js b/build/tasks/build.js
index <HASH>..<HASH> 100644
--- a/build/tasks/build.js
+++ b/build/tasks/build.js
@@ -20,7 +20,7 @@ gulp.task('build-dts', function() {
var importsToAdd = []; // stores extracted imports
return gulp.src(paths.tsSource)
- .pipe(tools.sortFiles())
+ //.pipe(tools.sortFiles()) can't sort with excluded files of the tsSource
.pipe(through2.obj(function(file, enc, callback) { // extract all imports to importsToAdd
file.contents = new Buffer(tools.extractImports(file.contents.toString('utf8'), importsToAdd));
this.push(file);
|
chore(build): fix build with value converters
|
SpoonX_aurelia-authentication
|
train
|
js,js
|
b6825756e97699db4d8c0230605919da877493d5
|
diff --git a/packages/@vue/cli/__tests__/Generator.spec.js b/packages/@vue/cli/__tests__/Generator.spec.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli/__tests__/Generator.spec.js
+++ b/packages/@vue/cli/__tests__/Generator.spec.js
@@ -456,13 +456,16 @@ test('api: onCreateComplete', async () => {
],
afterInvokeCbs: cbs
})
+
+ await generator.generate()
+
expect(cbs).toContain(fn)
})
-test('api: afterInvoke', () => {
+test('api: afterInvoke', async () => {
const fn = () => {}
const cbs = []
- new Generator('/', {
+ const generator = new Generator('/', {
plugins: [
{
id: 'test',
|
test: fix failing tests that due to async support in Generator
|
vuejs_vue-cli
|
train
|
js
|
3116bb9c2d568a17e2267c191f288e3570ea1cf2
|
diff --git a/test/mocha-utils.js b/test/mocha-utils.js
index <HASH>..<HASH> 100644
--- a/test/mocha-utils.js
+++ b/test/mocha-utils.js
@@ -117,6 +117,11 @@ global.describeChromeOnly = (...args) => {
if (process.env.COVERAGE)
assertCoverage();
+console.log(
+ `Running unit tests with:
+ -> product: ${product}
+ -> binary: ${path.relative(process.cwd(), puppeteer.executablePath())}`);
+
exports.setupTestBrowserHooks = () => {
before(async() => {
const browser = await puppeteer.launch(defaultBrowserOptions);
|
chore: log product + binary on unit test runs (#<I>)
This way it's super clear which product and binary you're testing against.
|
GoogleChrome_puppeteer
|
train
|
js
|
c72c2a18f819dfe6957f6e8904e8d569a78159c8
|
diff --git a/phwoolcon-package/assets/phwoolcon/utils.js b/phwoolcon-package/assets/phwoolcon/utils.js
index <HASH>..<HASH> 100644
--- a/phwoolcon-package/assets/phwoolcon/utils.js
+++ b/phwoolcon-package/assets/phwoolcon/utils.js
@@ -34,6 +34,8 @@ HTMLElement.prototype.toggleClass = function (toggleMe) {
};
document.on = function (eventName, selector, handler) {
+ var click = 'ontouchstart' in document.documentElement ? 'touchend' : 'click';
+ eventName === 'click' && (eventName = click);
document.addEventListener(eventName, function (event) {
for (var target = event.target || event.srcElement; target && target !== this; target = target.parentNode) {
// loop parent nodes from the target to the delegation node
|
fix(assets): support `document.on('click')` for touch devices [ci skip]
|
phwoolcon_phwoolcon
|
train
|
js
|
96647054351535843dc802401a834f64358e99e4
|
diff --git a/superset-frontend/webpack.config.js b/superset-frontend/webpack.config.js
index <HASH>..<HASH> 100644
--- a/superset-frontend/webpack.config.js
+++ b/superset-frontend/webpack.config.js
@@ -225,6 +225,10 @@ const config = {
noParse: /(mapbox-gl)\.js$/,
rules: [
{
+ test: /datatables\.net.*/,
+ loader: 'imports-loader?define=>false',
+ },
+ {
test: /\.tsx?$/,
use: [
'thread-loader',
|
fix: datatable dependencies for pivot-table in dev (#<I>)
|
apache_incubator-superset
|
train
|
js
|
f7f4aabe9e687480f928dbc240860ac61105e894
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -114,17 +114,17 @@ async function run(options, plugins) {
await plugins.prepare(
{options, logger, lastRelease, commits, nextRelease},
{
- getNextInput: async lastResult => {
+ getNextInput: async ({nextRelease, ...prepareParam}) => {
const newGitHead = await getGitHead();
// If previous prepare plugin has created a commit (gitHead changed)
- if (lastResult.nextRelease.gitHead !== newGitHead) {
+ if (nextRelease.gitHead !== newGitHead) {
nextRelease.gitHead = newGitHead;
// Regenerate the release notes
logger.log('Call plugin %s', 'generateNotes');
- [nextRelease.notes] = await plugins.generateNotes(generateNotesParam);
+ [nextRelease.notes] = await plugins.generateNotes({nextRelease, ...prepareParam});
}
// Call the next publish plugin with the updated `nextRelease`
- return {options, logger, lastRelease, commits, nextRelease};
+ return {...prepareParam, nextRelease};
},
}
);
|
refactor: use the `lastInput` arg to compute the `prepare` pipeline next input
Use the `getNextInput`'s provided argument rather than relying on the closure.
|
semantic-release_semantic-release
|
train
|
js
|
d7646eeaef1272734c55b94e04edccfe77460904
|
diff --git a/platform/nativescript/util/index.js b/platform/nativescript/util/index.js
index <HASH>..<HASH> 100644
--- a/platform/nativescript/util/index.js
+++ b/platform/nativescript/util/index.js
@@ -77,10 +77,14 @@ export function after(original, thisArg, wrap) {
export function deepProxy(object, depth = 0) {
return new Proxy(object, {
get(target, key) {
- if (key === 'toString') {
+ if (key === 'toString' || key === 'valueOf') {
return () => ''
}
+ if (key === Symbol.toPrimitive) {
+ return hint => hint
+ }
+
if (depth > 10) {
throw new Error('deepProxy over 10 deep.')
}
diff --git a/samples/app/app-with-list-view.js b/samples/app/app-with-list-view.js
index <HASH>..<HASH> 100644
--- a/samples/app/app-with-list-view.js
+++ b/samples/app/app-with-list-view.js
@@ -45,7 +45,7 @@ new Vue({
<v-template if="item.type === 'page'">
<WrapLayout orientation="horizontal" class="list-group-item active">
- <Label :text="item.title" style="color: red;" />
+ <Label :text="'<<< ' + item.title + ' >>>'" style="color: red;" />
</WrapLayout>
</v-template>
|
fix: allow deepProxy to be used in expressions
|
nativescript-vue_nativescript-vue
|
train
|
js,js
|
f64764bb31d29fdecb2762578764ee71c9496d90
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -14,6 +14,11 @@ import DropdownItem from './DropdownItem';
import DropdownTrigger from './DropdownTrigger';
import Facet from './Facet';
import FacetsSection from './FacetsSection';
+import Form from './Form';
+import FormField from './FormField';
+import FormFieldHelp from './FormFieldHelp';
+import FormFieldValidationBlock from './FormFieldValidationBlock';
+import FormPopover from './FormPopover';
import Popover from './Popover';
import PopoverBody from './PopoverBody';
import PopoverFooter from './PopoverFooter';
@@ -40,6 +45,11 @@ export {
DropdownTrigger,
Facet,
FacetsSection,
+ Form,
+ FormField,
+ FormFieldHelp,
+ FormFieldValidationBlock,
+ FormPopover,
Popover,
PopoverBody,
PopoverFooter,
|
fix(form): export form and related components
Form, FormPopover, and other form-related components were missing from index.js. Adds them.
|
rackerlabs_canon-react
|
train
|
js
|
7cab12cf74421f2e85d8ab1993cea9c42e886b1f
|
diff --git a/pkg/config/config.go b/pkg/config/config.go
index <HASH>..<HASH> 100644
--- a/pkg/config/config.go
+++ b/pkg/config/config.go
@@ -379,6 +379,7 @@ func Load(file string) (config Project, err error) {
if err != nil {
return
}
+ defer f.Close()
log.WithField("file", file).Info("loading config file")
return LoadReader(f)
}
|
fix: close config file (#<I>)
|
goreleaser_goreleaser
|
train
|
go
|
5429c0f9fa8f2657abd5f594891c8e554616d99b
|
diff --git a/app/templates/server/routers/index.js b/app/templates/server/routers/index.js
index <HASH>..<HASH> 100644
--- a/app/templates/server/routers/index.js
+++ b/app/templates/server/routers/index.js
@@ -10,6 +10,8 @@ module.exports = function(app, server){
{{#if genSwagger}}
require('./swagger')(app);
{{/if}}
+ {{log parsedSwagger}}
+ {{log spec}}
{{#genSwagger parsedSwagger spec}}
{{/genSwagger}}
require('./health')(app);
diff --git a/test/integration.js b/test/integration.js
index <HASH>..<HASH> 100644
--- a/test/integration.js
+++ b/test/integration.js
@@ -431,6 +431,7 @@ describe('core-node-express:app integration test with openApiServices', function
assert.file('test/dinosaurs.js');
assert.fileContent('test/dinosaurs.js', 'it(\'Testing GET for /dinosaurs route\',function(done)');
assert.fileContent('server/routers/index.js', 'require(\'./persons\')(app, basepath);');
+ assert.fileContent('server/routers/index.js', 'require(\'./public\')(app)');
assert.fileContent('server/routers/swagger.js', './public/swagger.json');
});
|
fix: adding new test to debug public route
|
ibm-developer_generator-ibm-core-node-express
|
train
|
js,js
|
a230b0350885194e5f07be667312316ad869b7fc
|
diff --git a/lib/resolveGitRepo.js b/lib/resolveGitRepo.js
index <HASH>..<HASH> 100644
--- a/lib/resolveGitRepo.js
+++ b/lib/resolveGitRepo.js
@@ -54,7 +54,7 @@ export const resolveGitRepo = async (cwd = process.cwd()) => {
// read the path of the current directory relative to the top-level directory
// don't read the toplevel directly, it will lead to an posix conform path on non posix systems (cygwin)
- const gitRel = normalize(await execGit(['rev-parse', '--show-prefix']))
+ const gitRel = normalize(await execGit(['rev-parse', '--show-prefix'], { cwd }))
const gitDir = determineGitDir(normalize(cwd), gitRel)
const gitConfigDir = normalize(await resolveGitConfigDir(gitDir))
|
fix: use cwd option when resolving git repo root (#<I>)
|
okonet_lint-staged
|
train
|
js
|
ccce47921757d6b25001a7d62648219cdf253c40
|
diff --git a/src/cli.js b/src/cli.js
index <HASH>..<HASH> 100644
--- a/src/cli.js
+++ b/src/cli.js
@@ -206,7 +206,7 @@ export default class CLI extends Context {
}
const parser = new Parser();
- let showHelpOnError = this.showHelpOnError;
+ let { showHelpOnError } = this;
try {
const { _, argv, contexts, unknown } = await parser.parse(unparsedArgs || process.argv.slice(2), this);
@@ -259,9 +259,7 @@ export default class CLI extends Context {
}
// allow command to override showHelpOnError if not set already
- if (showHelpOnError === undefined && results.cmd.get('showHelpOnError') === false) {
- showHelpOnError = false;
- }
+ showHelpOnError = results.cmd.prop('showHelpOnError');
// execute the command
if (results.cmd && typeof results.cmd.action === 'function') {
|
fix: Correctly reference command context properties.
|
cb1kenobi_cli-kit
|
train
|
js
|
6fe8d092a6796d36230a0e3480cd2a8472e1a6f0
|
diff --git a/test/k8sT/DatapathConfiguration.go b/test/k8sT/DatapathConfiguration.go
index <HASH>..<HASH> 100644
--- a/test/k8sT/DatapathConfiguration.go
+++ b/test/k8sT/DatapathConfiguration.go
@@ -551,7 +551,7 @@ var _ = Describe("K8sDatapathConfig", func() {
Context("Etcd", func() {
// Flaky on pipelines other than K8s 1.11/Linux net-next.
- SkipItIf(helpers.DoesNotRunOnNetNextKernel, "Check connectivity", func() {
+ It("Check connectivity", func() {
deploymentManager.Deploy(helpers.CiliumNamespace, StatelessEtcd)
deploymentManager.WaitUntilReady()
@@ -560,8 +560,9 @@ var _ = Describe("K8sDatapathConfig", func() {
etcdService := fmt.Sprintf("http://%s:%d", host, port)
opts := map[string]string{
- "global.etcd.enabled": "true",
- "global.etcd.endpoints[0]": etcdService,
+ "global.etcd.enabled": "true",
+ "global.etcd.endpoints[0]": etcdService,
+ "global.identityAllocationMode": "kvstore",
}
if helpers.ExistNodeWithoutCilium() {
opts["global.synchronizeK8sNodes"] = "false"
|
test: Fix and re-enable test reliant on managed etcd
- ensure `global.identityAllocationMode=kvstore` is set; the default
is `crd` which is not what etcd test was meant to be testing
- it looks like there is still a deadlock occuring when default `crd`
modes is used
Fixes: #<I>
|
cilium_cilium
|
train
|
go
|
e1aaec4c43e8c6a26dd9314c62ef2fbaa9679ca3
|
diff --git a/tests/Database/Ddd/Create/CreateTest.php b/tests/Database/Ddd/Create/CreateTest.php
index <HASH>..<HASH> 100644
--- a/tests/Database/Ddd/Create/CreateTest.php
+++ b/tests/Database/Ddd/Create/CreateTest.php
@@ -51,7 +51,7 @@ class CreateTest extends TestCase
* description="
* _**完整例子**_
*
- * ```
+ * ``` php
* $entity = new TestEntity();
* $entity->name = 'foo';
* $entity->save()->flush();
|
fix: fix comment for tests/Database/Ddd/Create/CreateTest.php
|
hunzhiwange_framework
|
train
|
php
|
281566536760cd9e9dd8ae8eeb0ca07656ffd5b1
|
diff --git a/library/pages/components/FeatureList/index.js b/library/pages/components/FeatureList/index.js
index <HASH>..<HASH> 100644
--- a/library/pages/components/FeatureList/index.js
+++ b/library/pages/components/FeatureList/index.js
@@ -22,7 +22,7 @@ export default function FeatureList(props) {
className="react-rainbow-feature-list_item"
image={<Components />}
title="60+ components"
- description="More than 60 components build on top of React."
+ description="More than 60 components built on top of React."
/>
<Item
|
fix: getting started ttypo (#<I>)
|
90milesbridge_react-rainbow
|
train
|
js
|
4b1104175dcd842ee42ca1f19b6dd53b6895f891
|
diff --git a/lib/plugins/load-plugin.js b/lib/plugins/load-plugin.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/load-plugin.js
+++ b/lib/plugins/load-plugin.js
@@ -40,7 +40,7 @@ var getText = function(item) {
var execCallback = function(id, cbs, item) {
var cb = cbs[id];
- if (cbs === reqCallbacks || (!item || item.endTime)) {
+ if (cbs === reqCallbacks || !item || item.endTime) {
cb(item);
delete cbs[id];
}
|
feat: supports to get network data in plugin
|
avwo_whistle
|
train
|
js
|
ebac2a5ec042592866aeded3b42d94e66bba4244
|
diff --git a/features/opsworks/step_definitions/opsworks.js b/features/opsworks/step_definitions/opsworks.js
index <HASH>..<HASH> 100644
--- a/features/opsworks/step_definitions/opsworks.js
+++ b/features/opsworks/step_definitions/opsworks.js
@@ -1,7 +1,7 @@
module.exports = function() {
this.Before("@opsworks", function (callback) {
- this.iam = new this.AWS.IAM();
- this.service = new this.AWS.OpsWorks();
+ this.iam = new this.AWS.IAM({region: 'us-west-2'});
+ this.service = new this.AWS.OpsWorks({region: 'us-west-2'});
callback();
});
|
fix: intermittent test failures with OpsWorks (#<I>)
|
aws_aws-sdk-js
|
train
|
js
|
46dbd88c1c8bbee9e0525a8cb11da7790024230f
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -62,7 +62,7 @@ var PATH = {
all: APP_SRC,
lib: [
// Order is quite important here for the HTML tag injection.
- require.resolve('traceur/bin/traceur-runtime.js'),
+ require.resolve('angular2/node_modules/traceur/bin/traceur-runtime.js'),
require.resolve('es6-module-loader/dist/es6-module-loader-sans-promises.js'),
require.resolve('es6-module-loader/dist/es6-module-loader-sans-promises.js.map'),
require.resolve('reflect-metadata/Reflect.js'),
|
fix(build): proper traceur path
|
NathanWalker_angular-seed-advanced
|
train
|
js
|
68f0da5ade827174aa9df3f06273ce0de9675e0b
|
diff --git a/lib/workers/branch/check-existing.js b/lib/workers/branch/check-existing.js
index <HASH>..<HASH> 100644
--- a/lib/workers/branch/check-existing.js
+++ b/lib/workers/branch/check-existing.js
@@ -22,19 +22,6 @@ async function prAlreadyExisted(config) {
);
if (pr) {
logger.debug('Found closed PR with current title');
- // this code exists to ignore mistakenly closed PRs which occurred due to a bug
- // TODO: Remove this by end of June 2018
- const closedAt = moment(pr.closed_at);
- const problemStart = moment('2017-10-15T20:00:00Z');
- const problemStopped = moment('2017-10-16T06:00:00Z');
- if (problemStart.isBefore(closedAt) && closedAt.isBefore(problemStopped)) {
- logger.info(
- { closedAt, problemStart, problemStopped },
- 'Renaming mistakenly closed PR'
- );
- await platform.updatePr(pr.number, `${pr.title} - autoclosed`);
- return null;
- }
return pr;
}
// Check for legacy PR title format
|
refactor: remove legacy code detecting mistakenly closed PRs
|
renovatebot_renovate
|
train
|
js
|
a921953d1ac28297e107f19f093d7f9765895658
|
diff --git a/src/color-thief.js b/src/color-thief.js
index <HASH>..<HASH> 100644
--- a/src/color-thief.js
+++ b/src/color-thief.js
@@ -28,8 +28,6 @@ var CanvasImage = function (image) {
this.canvas = document.createElement('canvas');
this.context = this.canvas.getContext('2d');
- document.body.appendChild(this.canvas);
-
this.width = this.canvas.width = image.width;
this.height = this.canvas.height = image.height;
@@ -44,11 +42,6 @@ CanvasImage.prototype.getImageData = function () {
return this.context.getImageData(0, 0, this.width, this.height);
};
-CanvasImage.prototype.removeCanvas = function () {
- this.canvas.parentNode.removeChild(this.canvas);
-};
-
-
var ColorThief = function () {};
/*
@@ -124,9 +117,6 @@ ColorThief.prototype.getPalette = function(sourceImage, colorCount, quality) {
var cmap = MMCQ.quantize(pixelArray, colorCount);
var palette = cmap? cmap.palette() : null;
- // Clean up
- image.removeCanvas();
-
return palette;
};
|
refactor: Don't append canvas to DOM
|
lokesh_color-thief
|
train
|
js
|
86967562dce909c999e8e5b69106f71b90213e63
|
diff --git a/bindings/vue/vue-onsenui/rollup.config.js b/bindings/vue/vue-onsenui/rollup.config.js
index <HASH>..<HASH> 100644
--- a/bindings/vue/vue-onsenui/rollup.config.js
+++ b/bindings/vue/vue-onsenui/rollup.config.js
@@ -24,7 +24,7 @@ babelrc.plugins = ['external-helpers'];
babelrc.exclude = [local('node_modules/**'), local('../../build/**')];
const globals = { 'onsenui': 'ons', 'onsenui/esm': 'ons' },
- external = id => /onsenui/.test(id),
+ external = id => /^onsenui/.test(id),
banner = `/* ${pkg.name} v${pkg.version} - ${dateformat(new Date(), 'yyyy-mm-dd')} */\n`;
const builds = [
|
chore(vue): Fix rollup external test regex
This broke because I renamed the directory to `vue-onsenui` so local
imports were getting treated as external.
|
OnsenUI_OnsenUI
|
train
|
js
|
f607dd3247ab547d8a16638f93c58601d0b4d619
|
diff --git a/src/label/base.js b/src/label/base.js
index <HASH>..<HASH> 100644
--- a/src/label/base.js
+++ b/src/label/base.js
@@ -157,7 +157,7 @@ class Label extends Component {
if (!oldLabel) {
return;
}
- if (this.get('useHtml')) {
+ if (oldLabel.tagName) {
const node = this._createDom(newLabel);
oldLabel.innerHTML = node.innerHTML;
this._setCustomPosition(newLabel, oldLabel);
@@ -308,9 +308,11 @@ class Label extends Component {
if (formatter) {
item.text = formatter(item.text, item, index);
}
-
- if (Util.isFunction(htmlTemplate)) {
- item.text = htmlTemplate(item.text, item, index);
+ if (htmlTemplate) {
+ item.useHtml = true;
+ if (Util.isFunction(htmlTemplate)) {
+ item.text = htmlTemplate(item.text, item, index);
+ }
}
if (Util.isNil(item.text)) {
|
fix(axis): when global htmlTemplate is set, use html to render label
|
antvis_component
|
train
|
js
|
ca1ce2f905ca718cf01c0ac0de022168fa0d340b
|
diff --git a/grappa/operators/equal.py b/grappa/operators/equal.py
index <HASH>..<HASH> 100644
--- a/grappa/operators/equal.py
+++ b/grappa/operators/equal.py
@@ -34,6 +34,9 @@ class EqualOperator(Operator):
# Is the operator a keyword
kind = Operator.Type.MATCHER
+ # Enable diff report
+ show_diff = True
+
# Operator keywords
operators = ('equal', 'same')
|
feat(equal): enable show_diff report in operator
|
grappa-py_grappa
|
train
|
py
|
3ed1788eb212318cb8742d437ebf3148e0432992
|
diff --git a/packages/functionals/botpress-qna/src/providers/qnaMaker.js b/packages/functionals/botpress-qna/src/providers/qnaMaker.js
index <HASH>..<HASH> 100644
--- a/packages/functionals/botpress-qna/src/providers/qnaMaker.js
+++ b/packages/functionals/botpress-qna/src/providers/qnaMaker.js
@@ -72,7 +72,7 @@ export default class Storage {
}
async update(data, id) {
- const prevData = await this.getQuestion(id)
+ const { data: prevData } = await this.getQuestion(id)
const questionsChanged = _.isEqual(data.questions, prevData.questions)
const questionsToAdd = _.difference(data.questions, prevData.questions)
|
fix(qna): fix deleting questions for QnA-maker (#<I>)
|
botpress_botpress
|
train
|
js
|
b33e8e23f00b5192e3d5866f22d4fc3e370cd9eb
|
diff --git a/src/migrations/20210421133845-add-sort-order-to-strategies.js b/src/migrations/20210421133845-add-sort-order-to-strategies.js
index <HASH>..<HASH> 100644
--- a/src/migrations/20210421133845-add-sort-order-to-strategies.js
+++ b/src/migrations/20210421133845-add-sort-order-to-strategies.js
@@ -15,5 +15,5 @@ exports.up = function(db, cb) {
};
exports.down = function(db, cb) {
- db.runSql(`ALTER TABLE strategies REMOVE COLUMN sort_order;`, cb);
+ db.runSql(`ALTER TABLE strategies DROP COLUMN sort_order;`, cb);
};
|
fix: migration rollback use DROP for column
|
Unleash_unleash
|
train
|
js
|
69b27e970225b1e678ea1a9bf5c25b84fc7d4396
|
diff --git a/src/Services/QueuedJobService.php b/src/Services/QueuedJobService.php
index <HASH>..<HASH> 100644
--- a/src/Services/QueuedJobService.php
+++ b/src/Services/QueuedJobService.php
@@ -680,7 +680,7 @@ class QueuedJobService
$jobDescriptor->write();
}
- if (!$broken) {
+ if ($job->jobFinished()) {
$job->afterComplete();
$jobDescriptor->cleanupJob();
}
|
fix(QueuedJobService): When a job hits the "Job releasing memory and waiting" case and completed successfully, it would not run the 'afterComplete' logic.
|
symbiote_silverstripe-queuedjobs
|
train
|
php
|
1544f5147125856e4de066e566820bd8548be007
|
diff --git a/source/rafcon/gui/mygaphas/view.py b/source/rafcon/gui/mygaphas/view.py
index <HASH>..<HASH> 100644
--- a/source/rafcon/gui/mygaphas/view.py
+++ b/source/rafcon/gui/mygaphas/view.py
@@ -31,6 +31,7 @@ class ExtendedGtkView(GtkView, Observer):
Observer.__init__(self)
self._selection = state_machine_m.selection
self.observe_model(self._selection)
+ self.observe_model(state_machine_m.root_state)
self._bounding_box_painter = BoundingBoxPainter(self)
self.graphical_editor = graphical_editor_v
@@ -154,6 +155,12 @@ class ExtendedGtkView(GtkView, Observer):
pass
super(ExtendedGtkView, self).queue_draw_item(*gaphas_items)
+ @Observer.observe("destruction_signal", signal=True)
+ def _on_root_state_destruction(self, root_state_m, signal_name, signal_msg):
+ """Ignore future selection changes when state machine is being destroyed"""
+ self.relieve_model(self._selection)
+ self.relieve_model(root_state_m)
+
@Observer.observe("selection_changed_signal", signal=True)
def _on_selection_changed_externally(self, selection_m, signal_name, signal_msg):
selected_items = self._get_selected_items()
|
fix(gaphas): Expose event on destruction
If a model had been selected when the GUI was closed, that element was
drawn, as it was deselected by the Selection. This had led (under some
circumstances) to exception during the close operation.
This is now fixed by relieving the Selection in the ExtendedGTKView when
then root state is being destroyed.
|
DLR-RM_RAFCON
|
train
|
py
|
5846d475ea590b5970a02048e373aad1f801f0fd
|
diff --git a/symlink.js b/symlink.js
index <HASH>..<HASH> 100644
--- a/symlink.js
+++ b/symlink.js
@@ -4,9 +4,11 @@ var isCallable = require("es5-ext/object/is-callable")
, isValue = require("es5-ext/object/is-value")
, isString = require("es5-ext/string/is-string")
, deferred = require("deferred")
- , resolve = require("path").resolve
+ , path = require("path")
, original = require("fs").symlink
- , symlink;
+ , mkdir = require("./mkdir");
+
+var dirname = path.dirname, resolve = path.resolve, symlink;
symlink = function (src, dest, options) {
var def = deferred();
@@ -35,6 +37,12 @@ module.exports = exports = function (src, dest /* [, options[, callback]]*/) {
options = isString(options) ? { type: options } : Object(options);
}
+ if (options.intermediate) {
+ return mkdir(dirname(dest), { intermediate: true })(function () {
+ return symlink(src, dest, options);
+ }).cb(cb);
+ }
+
return symlink(src, dest, options).cb(cb);
};
exports.returnsPromise = true;
|
feat: support `intermediate` option in symlink
|
medikoo_fs2
|
train
|
js
|
31d5deffc6f0b5e8cfc316ba0b4298c595fdacc3
|
diff --git a/src/material-context.js b/src/material-context.js
index <HASH>..<HASH> 100644
--- a/src/material-context.js
+++ b/src/material-context.js
@@ -8,6 +8,7 @@ export default
class Context extends EventEmitter {
constructor() {
this.dispatcher = new Dispatcher();
+ this._stores = [];
}
_registerStore(store) {
@@ -18,9 +19,15 @@ class Context extends EventEmitter {
+ `class UserStore extends Store{ ... }`
);
}
+ // guard for duplicated register
+ if(this._stores.indexOf(store) >= 0){
+ return;
+ }
+
let token = this.dispatcher.register(store.handler.bind(store));
store._waitFor = this.waitFor.bind(this);
store._token = token;
+ this._stores.push(store);
}
dispatch(eventKey, ...args) {
|
fix(Context): prevent duplicated register
fixed multiple call store's onhandler, when call action.
|
azu_material-flux
|
train
|
js
|
0a7536de8d44c9db02b0ba06ea76a1b2fe41ed2b
|
diff --git a/packages/build-tools/webpack/webpack-config/optimization.js b/packages/build-tools/webpack/webpack-config/optimization.js
index <HASH>..<HASH> 100644
--- a/packages/build-tools/webpack/webpack-config/optimization.js
+++ b/packages/build-tools/webpack/webpack-config/optimization.js
@@ -5,7 +5,7 @@ const {
optimization: {
splitChunks,
runtimeChunk = true,
- },
+ } = {},
} = require('./webpackPkgConfig');
module.exports = process.env.NODE_ENV === 'production'
|
fix(webpack-config): add default value to optimization config from package.json
affects: @goldwasserexchange/webpack-config
|
goldwasserexchange_public
|
train
|
js
|
18c8a4f2c558ac7c31633e2cf7cab0322d6c61a2
|
diff --git a/realtime/src/main/java/cn/leancloud/im/v2/AVIMConversation.java b/realtime/src/main/java/cn/leancloud/im/v2/AVIMConversation.java
index <HASH>..<HASH> 100644
--- a/realtime/src/main/java/cn/leancloud/im/v2/AVIMConversation.java
+++ b/realtime/src/main/java/cn/leancloud/im/v2/AVIMConversation.java
@@ -1446,7 +1446,7 @@ public class AVIMConversation {
* 清除未读消息
*/
public void read() {
- if (isTransient) {
+ if (!isTransient) {
AVIMMessage lastMessage = getLastMessage();
Map<String, Object> params = new HashMap<String, Object>();
if (null != lastMessage) {
|
fix(rtm): typo in AVIMConversation.read()
|
leancloud_java-sdk-all
|
train
|
java
|
1230e90c73cf207c4f9b5f9963fad48070223af1
|
diff --git a/src/DTS/eBaySDK/ReturnManagement/Types/IssueRefundOptionType.php b/src/DTS/eBaySDK/ReturnManagement/Types/IssueRefundOptionType.php
index <HASH>..<HASH> 100644
--- a/src/DTS/eBaySDK/ReturnManagement/Types/IssueRefundOptionType.php
+++ b/src/DTS/eBaySDK/ReturnManagement/Types/IssueRefundOptionType.php
@@ -23,7 +23,7 @@ namespace DTS\eBaySDK\ReturnManagement\Types;
/**
*
- * @property \DTS\eBaySDK\ReturnManagement\Types\Integer $daysToRefundBuyer
+ * @property integer $daysToRefundBuyer
*/
class IssueRefundOptionType extends \DTS\eBaySDK\ReturnManagement\Types\BaseActivityOptionType
{
@@ -32,7 +32,7 @@ class IssueRefundOptionType extends \DTS\eBaySDK\ReturnManagement\Types\BaseActi
*/
private static $propertyTypes = array(
'daysToRefundBuyer' => array(
- 'type' => 'DTS\eBaySDK\ReturnManagement\Types\Integer',
+ 'type' => 'integer',
'unbound' => false,
'attribute' => false,
'elementName' => 'daysToRefundBuyer'
|
fix: declare correct integer type of various properties
|
davidtsadler_ebay-sdk-php
|
train
|
php
|
fdb2b3d9d644fb178da4b8d70c298ee12d0ff027
|
diff --git a/test/specs/commonTests.js b/test/specs/commonTests.js
index <HASH>..<HASH> 100644
--- a/test/specs/commonTests.js
+++ b/test/specs/commonTests.js
@@ -26,6 +26,15 @@ const componentCtx = require.context(
const componentInfo = componentCtx.keys().map(key => {
const Component = componentCtx(key).default
+
+ const componentType = typeof Component
+ if (componentType !== 'function') {
+ throw new Error([
+ `${key} is not properly exported.`,
+ `Components should export a class or function, got: ${componentType}.`,
+ ].join(' '))
+ }
+
const { _meta, prototype } = Component
if (!_meta) {
|
feat(commonTests): catch bad component export
|
Semantic-Org_Semantic-UI-React
|
train
|
js
|
49423f9610fd6755d4d4b83dc8173f4d86b8c29f
|
diff --git a/tests/k8s_test.go b/tests/k8s_test.go
index <HASH>..<HASH> 100644
--- a/tests/k8s_test.go
+++ b/tests/k8s_test.go
@@ -54,7 +54,7 @@ func setupFromConfigFile(mngr, file string) []Cmd {
func tearDownFromConfigFile(mngr, file string) []Cmd {
return []Cmd{
{"kubectl delete --grace-period=0 --force -f " + k8sConfigFile(mngr, file), false},
- {"sleep 5", true},
+ {"sleep 10", true},
}
}
|
test: increase sleep after kubectl delete
|
skydive-project_skydive
|
train
|
go
|
8dc7df86e0c844d72749c0a492fdad6be2078f32
|
diff --git a/lib/ApiNetworkLog.php b/lib/ApiNetworkLog.php
index <HASH>..<HASH> 100644
--- a/lib/ApiNetworkLog.php
+++ b/lib/ApiNetworkLog.php
@@ -27,7 +27,7 @@ class ApiNetworkLog extends XjtuApi {
'username' => $username
]
]);
- return $response->getBody()->getContents();
+ return $this->parseResponse($response);
} catch(RequestException $e) {
if ($e->hasResponse()) {
$response = $e->getResponse();
@@ -51,7 +51,7 @@ class ApiNetworkLog extends XjtuApi {
'username' => $username
]
]);
- return $response->getBody()->getContents();
+ return $this->parseResponse($response);
} catch(RequestException $e) {
if ($e->hasResponse()) {
$response = $e->getResponse();
@@ -75,7 +75,7 @@ class ApiNetworkLog extends XjtuApi {
'account' => $username
]
]);
- return $this->parseResponse($response);
+ return $this->parseResponse($response, true);
} catch(RequestException $e) {
if ($e->hasResponse()) {
$response = $e->getResponse();
|
fix: use parseResponse to process response
|
xjtuana-dev_xjtu-api-php
|
train
|
php
|
c67299314798a13c2304c33c44fc220607dfedf9
|
diff --git a/dredd_hooks/dredd.py b/dredd_hooks/dredd.py
index <HASH>..<HASH> 100644
--- a/dredd_hooks/dredd.py
+++ b/dredd_hooks/dredd.py
@@ -110,7 +110,7 @@ class HookHandler(SocketServer.StreamRequestHandler):
self.wfile.write(msg)
except ValueError:
print("\nConnection closed\n", file=sys.stderr)
- except Exception as e:
+ except Exception:
traceback.print_exc(file=sys.stderr)
sys.stderr.flush()
raise
@@ -254,7 +254,7 @@ def main(args):
server.serve_forever()
except KeyboardInterrupt:
shutdown()
- except Exception as e:
+ except Exception:
traceback.print_exc(file=sys.stderr)
sys.stderr.flush()
raise
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -6,7 +6,7 @@ long_desc = open('README.rst').read()
setup(
name='dredd_hooks',
- version='0.1.2',
+ version='0.1.3',
url='https://github.com/apiaryio/dredd-hooks-python/',
download_url='http://pypi.python.org/pypi/dredd_hooks',
license='MIT License',
|
chore: Prepare release <I>
|
apiaryio_dredd-hooks-python
|
train
|
py,py
|
9cf4a7c8fda3ea8ae2b0e2f686a95680242bac57
|
diff --git a/src/components/GoogleAddressLookup/component.js b/src/components/GoogleAddressLookup/component.js
index <HASH>..<HASH> 100644
--- a/src/components/GoogleAddressLookup/component.js
+++ b/src/components/GoogleAddressLookup/component.js
@@ -201,6 +201,7 @@ class PlacesLookupComponent extends Component {
onBlur={onBlur}
error={error}
icon={<LocationIcon />}
+ preferredSelectedOption={1}
/>
<RenderIf isTrue={!error}>
<div className="rainbow-google-address-lookup_powered-by-google-container">
|
fix: make the first google option selected by default (#<I>)
|
90milesbridge_react-rainbow
|
train
|
js
|
2c8d81dc9d58b3ff23a2652d765063c188e9c69d
|
diff --git a/lib/components/viewers/trip-viewer.js b/lib/components/viewers/trip-viewer.js
index <HASH>..<HASH> 100644
--- a/lib/components/viewers/trip-viewer.js
+++ b/lib/components/viewers/trip-viewer.js
@@ -21,7 +21,10 @@ const { getUserTimezone } = coreUtils.time
class TripViewer extends Component {
static propTypes = {
+ findGraphQLTrip: findGraphQLTrip.type,
+ findTrip: findTrip.type,
hideBackButton: PropTypes.bool,
+ setViewedTrip: setViewedTrip.type,
tripData: PropTypes.object,
viewedTrip: PropTypes.object
}
@@ -174,7 +177,7 @@ class TripViewer extends Component {
}
}
-const mapStateToProps = (state, ownProps) => {
+const mapStateToProps = (state) => {
const viewedTrip = state.otp.ui.viewedTrip
return {
tripData: state.otp.transitIndex.trips[viewedTrip.tripId],
|
refactor(trip-viewer): adjust for linter
|
opentripplanner_otp-react-redux
|
train
|
js
|
33f0494683c037d2ec88a00e2babcc4e218792d8
|
diff --git a/packages/ternary/src/index.js b/packages/ternary/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/ternary/src/index.js
+++ b/packages/ternary/src/index.js
@@ -1,5 +1,7 @@
const CONDITIONAL_EXP = 'ConditionalExpression';
+// test change
+
export default {
name: 'ternary',
|
fix: test change to ternary
|
soney_jsep
|
train
|
js
|
4dccba29c368f50d28b6dd4c018e6511bcc9c24a
|
diff --git a/tsdb/engine/tsm1/engine.go b/tsdb/engine/tsm1/engine.go
index <HASH>..<HASH> 100644
--- a/tsdb/engine/tsm1/engine.go
+++ b/tsdb/engine/tsm1/engine.go
@@ -1616,7 +1616,7 @@ func (e *Engine) deleteSeriesRange(seriesKeys [][]byte, min, max int64) error {
// Have we deleted all values for the series? If so, we need to remove
// the series from the index.
- hasDeleted := false;
+ hasDeleted := false
for _, k := range seriesKeys {
if len(k) > 0 {
hasDeleted = true
|
chore(tsm1): go fmt file
|
influxdata_influxdb
|
train
|
go
|
a8fc131b895b2bea4d512e3dd9dec2b0c8982db6
|
diff --git a/packages/wasm-edit/src/index.js b/packages/wasm-edit/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/wasm-edit/src/index.js
+++ b/packages/wasm-edit/src/index.js
@@ -19,6 +19,10 @@ function preprocess(ab: ArrayBuffer): ArrayBuffer {
}
function sortBySectionOrder(nodes: Array<Node>) {
+ const originalOrder: Map<Node, number> = new Map();
+ for (const node of nodes) {
+ originalOrder.set(node, originalOrder.size);
+ }
nodes.sort((a, b) => {
const sectionA = getSectionForNode(a);
const sectionB = getSectionForNode(b);
@@ -30,6 +34,11 @@ function sortBySectionOrder(nodes: Array<Node>) {
throw new Error("Section id not found");
}
+ if (aId === bId) {
+ // $FlowIgnore originalOrder is filled for all nodes
+ return originalOrder.get(a) - originalOrder.get(b);
+ }
+
return aId - bId;
});
}
|
fix: keep insertion order for added nodes
|
xtuc_webassemblyjs
|
train
|
js
|
4e0a661b369b1bbe0f1838e6077fd0b9d8ba16d3
|
diff --git a/type/__tests__/is.test.js b/type/__tests__/is.test.js
index <HASH>..<HASH> 100644
--- a/type/__tests__/is.test.js
+++ b/type/__tests__/is.test.js
@@ -223,11 +223,48 @@ describe('types/is', () => {
})
describe('Maybe', () => {
+ test('Maybe', () => {
+ const expected = true
+ const maybe = Maybe
+ const actual = is(Maybe)(maybe)
+ expect(actual).toBe(expected)
+ })
+
test('Just is Maybe', () => {
const expected = true
const actual = is(Maybe)(Just(888))
expect(actual).toBe(expected)
})
+
+ test('Nothing is Maybe', () => {
+ const expected = true
+ const actual = is(Maybe)(Nothing)
+ expect(actual).toBe(expected)
+ })
+
+ test('null is false', () => {
+ const expected = false
+ const actual = is(Maybe)(null)
+ expect(actual).toBe(expected)
+ })
+
+ test('undefined is false', () => {
+ const expected = false
+ const actual = is(Maybe)(undefined)
+ expect(actual).toBe(expected)
+ })
+
+ test('{} is false', () => {
+ const expected = false
+ const actual = is(Maybe)({})
+ expect(actual).toBe(expected)
+ })
+
+ test('function is false', () => {
+ const expected = false
+ const actual = is(Maybe)(() => {})
+ expect(actual).toBe(expected)
+ })
})
describe('Set', () => {
|
refactor(types): add tests for is maybe
|
joelnet_MojiScript
|
train
|
js
|
bb3328982321fe7f1e12493adc25c53730133860
|
diff --git a/packages/cerebral/src/Controller.js b/packages/cerebral/src/Controller.js
index <HASH>..<HASH> 100644
--- a/packages/cerebral/src/Controller.js
+++ b/packages/cerebral/src/Controller.js
@@ -85,7 +85,7 @@ class Controller extends FunctionTree {
typeof navigator !== 'undefined' &&
/Chrome/.test(navigator.userAgent)
) {
- console.warn('You are not using the Cerebral devtools. It is highly recommended to use it in combination with the debugger: https://cerebral.github.io/cerebral-website/install/02_debugger.html')
+ console.warn('You are not using the Cerebral devtools. It is highly recommended to use it in combination with the debugger: http://cerebraljs.com/docs/get_started/debugger.html')
}
this.getSignal = getSignal
|
fix: corrected documentation url for debugger (#<I>)
|
cerebral_cerebral
|
train
|
js
|
00f06741b0cb2e2dc4fadf59d85ac995bf1dbff1
|
diff --git a/commands/MakeTest.js b/commands/MakeTest.js
index <HASH>..<HASH> 100644
--- a/commands/MakeTest.js
+++ b/commands/MakeTest.js
@@ -82,7 +82,7 @@ class MakeTest extends Command {
* defined
*/
if (!unit && !functional) {
- type = await this.chioce('Select the type of test to create', [
+ type = await this.choice('Select the type of test to create', [
{
name: 'Unit test',
value: 'unit'
|
fix(command): fix `chioce` to `choice` typo
|
adonisjs_adonis-vow
|
train
|
js
|
b56f318ea703e3a39ae5d80d8a5be6d682be3239
|
diff --git a/src/angular-pdf.js b/src/angular-pdf.js
index <HASH>..<HASH> 100644
--- a/src/angular-pdf.js
+++ b/src/angular-pdf.js
@@ -165,7 +165,8 @@
}
if (url && url.length) {
- pdfLoaderTask = PDFJS.getDocument(params, null, null, scope.onProgress);
+ pdfLoaderTask = PDFJS.getDocument(params);
+ pdfLoaderTask.onProgress = scope.onProgress;
pdfLoaderTask.then(
function(_pdfDoc) {
if (typeof scope.onLoad === 'function') {
|
fix: removing warning in getDocument call
Warning message was:
Deprecated API usage: getDocument is called with pdfDataRangeTransport, passwordCallback or progressCallback
|
sayanee_angularjs-pdf
|
train
|
js
|
811c6e68b241ea81159bb1a0abae9c8e34c734b4
|
diff --git a/lib/handlers/file-proxy.js b/lib/handlers/file-proxy.js
index <HASH>..<HASH> 100644
--- a/lib/handlers/file-proxy.js
+++ b/lib/handlers/file-proxy.js
@@ -139,9 +139,9 @@ module.exports = function(req, res, next) {
}
var defaultType = mime.lookup(req.fullUrl.replace(/[?#].*$/, ''), 'text/html');
var rule = req.rules.rule;
- var enableLength = util.isEnable(req, 'content-length') || util.isEnable(req, 'contentLength');
+ var disableLength = req.disable['content-length'] || req.disable.contentLength;
var addLength = function(reader, length) {
- if (enableLength) {
+ if (!disableLength) {
reader.headers['content-length'] = length;
}
};
|
refactor: set content-length by default
|
avwo_whistle
|
train
|
js
|
87582068579c74977dd9671f22daf5e689ebda3b
|
diff --git a/app/state.js b/app/state.js
index <HASH>..<HASH> 100644
--- a/app/state.js
+++ b/app/state.js
@@ -127,6 +127,7 @@ const initialState = {
dragging: null,
selection: [],
linkingPin: null,
+ selectedNodeType: 1,
},
nodeTypes: {
1: {
|
feat(editor): add selectedNodeType into initial state
|
xodio_xod
|
train
|
js
|
94b601361786c88cd56ca1241b41fcec1992aa97
|
diff --git a/templates/src/api/routes/___route.js b/templates/src/api/routes/___route.js
index <HASH>..<HASH> 100644
--- a/templates/src/api/routes/___route.js
+++ b/templates/src/api/routes/___route.js
@@ -36,7 +36,7 @@ router.{{@key}}('{{../../subresource}}', (req, res, next) => {
if (err) {
{{#each ../responses}}
{{#compare @key 400 operator=">="}}
- const err_response = { status: {{@key}}, message: '{{../description}}' };
+ const err_response_{{@key}} = { status: {{@key}}, message: '{{../description}}' };
return res.status({{@key}}).send(err_response);
{{/compare}}
{{#equal @key "default"}}
|
fix: resolve generation of multiple constants with same name
|
fmvilas_swagger-node-codegen
|
train
|
js
|
5544c44414d8889aeabadf021597fb490f15202e
|
diff --git a/packages/okam-build/lib/processor/css/plugins/postcss-plugin-import.js b/packages/okam-build/lib/processor/css/plugins/postcss-plugin-import.js
index <HASH>..<HASH> 100644
--- a/packages/okam-build/lib/processor/css/plugins/postcss-plugin-import.js
+++ b/packages/okam-build/lib/processor/css/plugins/postcss-plugin-import.js
@@ -1,5 +1,5 @@
/**
- * @file Postcss wxss plugin for weixin
+ * @file Postcss import plugin
* @author sparklewhy@gmail.com
*/
diff --git a/packages/okam-build/lib/processor/css/plugins/postcss-plugin-wx2swan.js b/packages/okam-build/lib/processor/css/plugins/postcss-plugin-wx2swan.js
index <HASH>..<HASH> 100644
--- a/packages/okam-build/lib/processor/css/plugins/postcss-plugin-wx2swan.js
+++ b/packages/okam-build/lib/processor/css/plugins/postcss-plugin-wx2swan.js
@@ -1,5 +1,5 @@
/**
- * @file postcss plugin px2rpx
+ * @file postcss wxss to swan css plugin
* @author xiaohong8023@outlook.com
*/
|
chore(okam-build): up file comment
|
ecomfe_okam
|
train
|
js,js
|
38bcad5f2797a18b581c6e7c99526180b5f8dde9
|
diff --git a/src/activation.js b/src/activation.js
index <HASH>..<HASH> 100644
--- a/src/activation.js
+++ b/src/activation.js
@@ -180,10 +180,40 @@ function shouldContinue(output, router: Router) {
return output;
}
+class SafeSubscription {
+ //if this were TypeScript, subscriptionFunc would be of type
+ //(sub: SafeSubscription) => Subscription
+ constructor(subscriptionFunc) {
+ this._subscribed = true;
+ this._subscription = subscriptionFunc(this);
+
+ if(!this._subscribed) this.unsubscribe()
+ }
+
+ unsubscribe() {
+ if(this._subscription) this._subscription.unsubscribe();
+
+ this._subscribed = false;
+ }
+}
+
function processPotential(obj, resolve, reject) {
if (obj && typeof obj.then === 'function') {
return Promise.resolve(obj).then(resolve).catch(reject);
}
+
+ if(obj && typeof obj.subscribe === 'function') {
+ //an object with a subscribe function should be assumed to be an observable
+ new SafeSubscription(sub => obj.subscribe({
+ next() {
+ sub.unsubscribe();
+ resolve(obj);
+ },
+ error(err) {
+ reject(err);
+ }
+ }));
+ }
try {
return resolve(obj);
|
feat(router): observables in lifecycle
Given that Observables are moving through committee to become a web
standard, it would be of use to support that standard similarly to how
Promises are supported.
Like with promises, if an observable (really, anything with a subscribe
function) is returned from the activate lifecycle event, the router will
wait until there's data present before finishing the routing process.
|
aurelia_router
|
train
|
js
|
9a1d047080f1a5ca629643d59d6687f928cde3b8
|
diff --git a/packages/blueprint-mongodb/lib/gridfs-controller.js b/packages/blueprint-mongodb/lib/gridfs-controller.js
index <HASH>..<HASH> 100644
--- a/packages/blueprint-mongodb/lib/gridfs-controller.js
+++ b/packages/blueprint-mongodb/lib/gridfs-controller.js
@@ -76,6 +76,10 @@ module.exports = ResourceController.extend ({
/// Name of the resource.
name: null,
+ /// The bucket name for the resources. If one is not provided, then the name
+ /// of the resource is used for the bucket name.
+ bucketName: null,
+
/// Name of the target connection. The $default connection is the
/// default target connection.
connection: '$default',
@@ -104,7 +108,7 @@ module.exports = ResourceController.extend ({
throw new Error ('The connection to the database is not open.');
let opts = {
- bucketName: this.name,
+ bucketName: this.bucketName || this.name,
chunkSizeBytes: this.chunkSizeBytes
};
|
feat: allow you to configure the bucket name for gridfs
|
onehilltech_blueprint
|
train
|
js
|
c0b164420dbf0255c175a4acd7b516b58ea33ac9
|
diff --git a/packages/xgplayer/src/skin/controls/textTrack.js b/packages/xgplayer/src/skin/controls/textTrack.js
index <HASH>..<HASH> 100644
--- a/packages/xgplayer/src/skin/controls/textTrack.js
+++ b/packages/xgplayer/src/skin/controls/textTrack.js
@@ -2,7 +2,6 @@ import Player from '../../player'
import SubTitles from 'xgplayer-subtitles'
import '../style/controls/textTrack.scss'
-
const defaultStyle = {
follow: true,
mode: 'st',
@@ -28,6 +27,8 @@ function createSubTitle (textTrack, style = {}, defaultOpen = true) {
})
return new SubTitles(config)
}
+
+// eslint-disable-next-line camelcase
let s_textTrack = function () {
let player = this
let root = player.root
@@ -139,13 +140,12 @@ let s_textTrack = function () {
subtitle && (subtitle.root.style.bottom = `${bottom}px`)
}
- function onBlur() {
+ function onBlur () {
isActive = false
const bottom = positionData.vBottom + positionData.marginBottom
subtitle && (subtitle.root.style.bottom = `${bottom}px`)
}
-
function onSubtitleResize (data) {
positionData.vBottom = data.vBottom
positionData.marginBottom = data.marginBottom
|
feat: (xgplayer) eslint
|
bytedance_xgplayer
|
train
|
js
|
5ed4548e9ece02012f50a3c50f4b7f7cc5297e44
|
diff --git a/components/cards/index.js b/components/cards/index.js
index <HASH>..<HASH> 100644
--- a/components/cards/index.js
+++ b/components/cards/index.js
@@ -1,3 +1,5 @@
+// @flow
+
export { default as Block } from './card_block';
export { default as Header } from './card_header';
export { default as Text } from './card_text';
|
chore(cards): update cards to use flow
|
guzart_fain
|
train
|
js
|
dd1291212431b64b6740d7bfd06a4e04867e5073
|
diff --git a/src/client/actions/InviteCreate.js b/src/client/actions/InviteCreate.js
index <HASH>..<HASH> 100644
--- a/src/client/actions/InviteCreate.js
+++ b/src/client/actions/InviteCreate.js
@@ -9,7 +9,7 @@ class InviteCreateAction extends Action {
const client = this.client;
const channel = client.channels.cache.get(data.channel_id);
const guild = client.guilds.cache.get(data.guild_id);
- if (!channel && !guild) return false;
+ if (!channel) return false;
const inviteData = Object.assign(data, { channel, guild });
const invite = new Invite(client, inviteData);
|
fix(Actions): Avoid crash in InviteCreate with unknown channel (#<I>)
|
discordjs_discord.js
|
train
|
js
|
3b19af385bf45bc22a32fdabe2bffe4020978fc3
|
diff --git a/src/funnies.js b/src/funnies.js
index <HASH>..<HASH> 100644
--- a/src/funnies.js
+++ b/src/funnies.js
@@ -152,4 +152,11 @@ export default [
"Kindly hold on as we convert this bug to a feature...",
"Kindly hold on as our intern quits vim...",
"Winter is coming...",
+ "Installing dependancies",
+ "Switching to the latest JS framework",
+ "Distracted by cat gifs",
+ "Finding someone to hold my beer",
+ "BRB, working on my side project",
+ "@todo Insert witty loading message",
+ "Let's hope it's worth the wait",
];
|
feat: Add more funnies (#<I>)
|
1egoman_funnies
|
train
|
js
|
ba94d203d78ef4fe336b561706a10a93c80c9800
|
diff --git a/packages/node_modules/@webex/http-core/src/lib/interceptor.js b/packages/node_modules/@webex/http-core/src/lib/interceptor.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/http-core/src/lib/interceptor.js
+++ b/packages/node_modules/@webex/http-core/src/lib/interceptor.js
@@ -24,8 +24,6 @@ export default class Interceptor {
});
});
}
-
- this.verboseLoggingEnabled = !!process.env.ENABLE_VERBOSE_NETWORK_LOGGING;
}
/**
@@ -38,7 +36,7 @@ export default class Interceptor {
logOptions(options = {}) {
const logger = get(this, 'webex.logger', console);
- if (!this.verboseLoggingEnabled || !logger) {
+ if (!process.env.ENABLE_VERBOSE_NETWORK_LOGGING || !logger) {
return;
}
|
fix(http-core): change env validation for logging to method scope
Change the env check for verbose network logging
to occur every time the logging interceptor's method
is called.
|
webex_spark-js-sdk
|
train
|
js
|
3eb3f9c68d795a816304948f57d80680333e2139
|
diff --git a/packages/release-rules-peakfijn/index.js b/packages/release-rules-peakfijn/index.js
index <HASH>..<HASH> 100644
--- a/packages/release-rules-peakfijn/index.js
+++ b/packages/release-rules-peakfijn/index.js
@@ -1,7 +1,13 @@
'use strict';
const commitTypes = require('commit-types-peakfijn');
+const defaultRules = [
+ { breaking: true, release: 'major' },
+ { revert: true, release: 'patch' },
+];
-module.exports = Object.keys(commitTypes)
- .map(type => ({ type, release: commitTypes[type].release }))
- .filter(rule => !!rule.release);
+module.exports = defaultRules.concat(
+ Object.keys(commitTypes)
+ .map(type => ({ type, release: commitTypes[type].release }))
+ .filter(rule => !!rule.release)
+);
|
fix(release-rules): include default breaking and revert rules (#<I>)
Without this breaking changes are not handled as breaking changes. This makes sure both breaking and revert commits are handled properly.
|
Peakfijn_Conventions
|
train
|
js
|
42e89bc903604a4226a867a89d55a06186f40db1
|
diff --git a/config/config.default.js b/config/config.default.js
index <HASH>..<HASH> 100644
--- a/config/config.default.js
+++ b/config/config.default.js
@@ -47,7 +47,7 @@ module.exports = appInfo => {
};
config.dataHubView = {
- assetsUrl: 'https://unpkg.com/datahub-view@2',
+ assetsUrl: 'https://cdn.jsdelivr.net/npm/datahub-view@2',
};
config.dataHubRpcType = process.env.DATAHUB_RPC_PROTOCOL || 'http';
|
feat: use cdn.jsdelivr.net by default (#<I>)
|
macacajs_macaca-datahub
|
train
|
js
|
7394150fe8dc657dfe6c92fe02c80d8fc753f83b
|
diff --git a/src/model.js b/src/model.js
index <HASH>..<HASH> 100644
--- a/src/model.js
+++ b/src/model.js
@@ -1,7 +1,7 @@
import * as types from './types'
import * as helpers from './helpers'
import * as enforcers from './enforcers'
-import { isArray, isString, isObject } from './util'
+import { isArray, isString, isObject, isNil } from './util'
export default class Model {
constructor (ctx, name, schema, options) {
@@ -76,6 +76,7 @@ export default class Model {
return helpers.runQuery(this.ctx, query, true).then(response => {
let result = isArray(response) ? response[0] : response
+ if (isNil(result)) return result
if (!column) {
return types.fromDefinition(this, result)
diff --git a/src/util.js b/src/util.js
index <HASH>..<HASH> 100644
--- a/src/util.js
+++ b/src/util.js
@@ -40,6 +40,7 @@ export let isFunction = value => isType(value, 'function')
export let isString = value => isType(value, 'string')
export let isNumber = value => isType(value, 'number')
export let isBoolean = value => isType(value, 'boolean')
+export let isNil = value => value == null
export function invariant (condition, message) {
if (!condition) {
|
fix(findOne): error when no result and column provided
Return early if result is null or undefined to prevent errors from trying to read properties of it if provided a column.
|
citycide_trilogy
|
train
|
js,js
|
d8e2829e5b551a3ecf92763617ce25cc699fff15
|
diff --git a/aio/tools/examples/add-example-boilerplate.js b/aio/tools/examples/add-example-boilerplate.js
index <HASH>..<HASH> 100644
--- a/aio/tools/examples/add-example-boilerplate.js
+++ b/aio/tools/examples/add-example-boilerplate.js
@@ -30,6 +30,7 @@ const files = {
// requires admin access because it adds symlinks
function add() {
+ remove();
const realPath = path.join(SHARED_PATH, '/node_modules');
const nodeModulesPaths = getNodeModulesPaths(EXAMPLES_PATH);
|
feat(aio): boilerplate:add cleans (removes) before adding
|
angular_angular
|
train
|
js
|
be0d1cd6637bca837f687bfd00e07e8bacf52838
|
diff --git a/src/client/Client.js b/src/client/Client.js
index <HASH>..<HASH> 100644
--- a/src/client/Client.js
+++ b/src/client/Client.js
@@ -53,6 +53,10 @@ class Client extends BaseClient {
this.options.totalShardCount = this.options.shardCount;
}
}
+ if (!this.options.shards && this.options.shardCount) {
+ this.options.shards = [];
+ for (let i = 0; i < this.options.shardCount; ++i) this.options.shards.push(i);
+ }
this._validateOptions();
@@ -227,6 +231,10 @@ class Client extends BaseClient {
this.emit(Events.DEBUG, `Using recommended shard count ${res.shards}`);
this.options.shardCount = res.shards;
this.options.totalShardCount = res.shards;
+ if (!this.options.shards || !this.options.shards.length) {
+ this.options.shards = [];
+ for (let i = 0; i < this.options.shardCount; ++i) this.options.shards.push(i);
+ }
}
this.emit(Events.DEBUG, `Using gateway ${gateway}`);
this.ws.connect(gateway);
|
fix: Client#shards not being set properly
|
discordjs_discord.js
|
train
|
js
|
0f01f3f0c2cdef759884257d8da8d40f8ae8fee1
|
diff --git a/src/Plugin/Alipay/PreparePlugin.php b/src/Plugin/Alipay/PreparePlugin.php
index <HASH>..<HASH> 100644
--- a/src/Plugin/Alipay/PreparePlugin.php
+++ b/src/Plugin/Alipay/PreparePlugin.php
@@ -122,7 +122,7 @@ class PreparePlugin implements PluginInterface
protected function formatCert(array $ssl): array
{
if (0 === strpos($ssl['serialNumber'], '0x')) {
- $ssl['serialNumber'] = $this->hex2dec($ssl['serialNumber']);
+ $ssl['serialNumber'] = $this->hex2dec($ssl['serialNumberHex']);
}
return $ssl;
|
fix: hexdec deprected
|
yansongda_pay
|
train
|
php
|
cd572b838495d78ab65c85d4c14e74801150552b
|
diff --git a/framework/views/slidingMenu.js b/framework/views/slidingMenu.js
index <HASH>..<HASH> 100644
--- a/framework/views/slidingMenu.js
+++ b/framework/views/slidingMenu.js
@@ -367,7 +367,6 @@ limitations under the License.
this._mainPage.append(pageContent);
if (this._currentPageElement) {
- this._currentPageElement.remove();
this._currentPageScope.$destroy();
}
@@ -376,6 +375,7 @@ limitations under the License.
this._currentPageElement = pageContent;
this._currentPageScope = pageScope;
this._currentPageUrl = pageUrl;
+ this._currentPageElement[0]._show();
},
/**
|
feat(ons-sliding-menu): adapted to page lifecycle events
|
OnsenUI_OnsenUI
|
train
|
js
|
a6b3836d85c9666a1ee223687210a854fe47c919
|
diff --git a/ui/tests/integration/components/job-page/parts/placement-failures-test.js b/ui/tests/integration/components/job-page/parts/placement-failures-test.js
index <HASH>..<HASH> 100644
--- a/ui/tests/integration/components/job-page/parts/placement-failures-test.js
+++ b/ui/tests/integration/components/job-page/parts/placement-failures-test.js
@@ -1,3 +1,5 @@
+/* eslint-disable qunit/require-expect */
+/* Mirage fixtures are random so we can't expect a set number of assertions */
import hbs from 'htmlbars-inline-precompile';
import { findAll, find, render } from '@ember/test-helpers';
import { module, test } from 'qunit';
@@ -25,8 +27,6 @@ module(
});
test('when the job has placement failures, they are called out', async function (assert) {
- assert.expect(6);
-
this.server.create('job', {
failedPlacements: true,
createAllocations: false,
|
fix: mirage fixtures are randomized so we cant assert.expect
|
hashicorp_nomad
|
train
|
js
|
b89bd0e2fe450d3431f5b1636e24356803e25f45
|
diff --git a/src/nipplejs.js b/src/nipplejs.js
index <HASH>..<HASH> 100644
--- a/src/nipplejs.js
+++ b/src/nipplejs.js
@@ -135,17 +135,14 @@ var Nipple = function (options) {
// Basic event system.
Nipple.prototype.on = function (type, cb) {
var self = this;
- var types = type.split(/[ ,]/g);
+ var types = type.split(/[ ,]+/g);
+ var type;
- if (types.length > 1) {
- for (var i = 0, max = types.length; i < max; i += 1) {
- self.on(types[i], cb);
- }
- return self;
+ for (var i = 0; i < types.length; i += 1) {
+ type = types[i];
+ self.handlers[type] = self.handlers[type] || [];
+ self.handlers[type].push(cb);
}
-
- self.handlers[type] = self.handlers[type] || [];
- self.handlers[type].push(cb);
return self;
};
|
fix(on): allows multiple spaces in event string
|
yoannmoinet_nipplejs
|
train
|
js
|
d058c1da2e057c044fb0750e16a82ddcbf85ec58
|
diff --git a/cpenv/__main__.py b/cpenv/__main__.py
index <HASH>..<HASH> 100644
--- a/cpenv/__main__.py
+++ b/cpenv/__main__.py
@@ -395,6 +395,7 @@ class Copy(cli.CLI):
copier.copy([module_spec], args.overwrite)
cli.echo('OK!')
+
class Publish(cli.CLI):
'''Publish a Module to a repo.'''
|
fix: spacing in __main__
|
cpenv_cpenv
|
train
|
py
|
efd558799a54db917498819798d1e66e98bfbd71
|
diff --git a/python/setup.py b/python/setup.py
index <HASH>..<HASH> 100755
--- a/python/setup.py
+++ b/python/setup.py
@@ -108,7 +108,7 @@ if platform.system() == 'Darwin':
setup(
name='neuroglancer',
- version='1.1.4',
+ version='1.1.5',
description='Python data backend for neuroglancer, a WebGL-based viewer for volumetric data',
author='Jeremy Maitin-Shepard, Jan Funke',
author_email='jbms@google.com, jfunke@iri.upc.edu',
|
chore(python): bump package version to <I>
|
google_neuroglancer
|
train
|
py
|
ab7e5c92aed1fc22a16751b3c77ed6ec3c2cbd55
|
diff --git a/master/docs/bbdocs/highlighterrors.py b/master/docs/bbdocs/highlighterrors.py
index <HASH>..<HASH> 100644
--- a/master/docs/bbdocs/highlighterrors.py
+++ b/master/docs/bbdocs/highlighterrors.py
@@ -93,3 +93,4 @@ def setup(app):
of Sphinx is %s. Check disabled.
""") % (sphinx.__version__, required_sphinx_version)
sys.stderr.write(msg)
+ return {'parallel_read_safe': True, 'parallel_write_safe': True}
|
docs: Enable multiprocess support for bbdocs.highlighterrors extension
|
buildbot_buildbot
|
train
|
py
|
d3ac5e0fa2d1f3ce7b3ac31c65b6ffa4bae6147d
|
diff --git a/javascript/atoms/inject.js b/javascript/atoms/inject.js
index <HASH>..<HASH> 100644
--- a/javascript/atoms/inject.js
+++ b/javascript/atoms/inject.js
@@ -372,7 +372,7 @@ bot.inject.executeAsyncScript = function(fn, args, timeout, onDone,
// a 0-based timeout.
timeoutId = win.setTimeout(function() {
sendResponse(bot.ErrorCode.SCRIPT_TIMEOUT,
- Error('Timed out waiting for asyncrhonous script result ' +
+ Error('Timed out waiting for asynchronous script result ' +
'after ' + (goog.now() - startTime) + ' ms'));
}, Math.max(0, timeout));
} catch (ex) {
@@ -530,4 +530,3 @@ bot.inject.cache.getElement = function(key, opt_doc) {
throw new bot.Error(bot.ErrorCode.STALE_ELEMENT_REFERENCE,
'Element is no longer attached to the DOM');
};
-
|
fix: typo in async execute error text (#<I>)
|
SeleniumHQ_selenium
|
train
|
js
|
7fcfc5f3270d3507a002247c53a29da211f1ecb6
|
diff --git a/src/image-preview/index.js b/src/image-preview/index.js
index <HASH>..<HASH> 100644
--- a/src/image-preview/index.js
+++ b/src/image-preview/index.js
@@ -62,6 +62,10 @@ const ImagePreview = (images, startPosition = 0) => {
instance.value = show;
});
+ instance.$once('closed', () => {
+ instance.images = [];
+ });
+
if (options.onClose) {
instance.$off('close');
instance.$once('close', options.onClose);
|
fix(ImagePreview): should not show previews image
|
youzan_vant
|
train
|
js
|
ccd3d26059b7b30e70adffea005faf787a703cd5
|
diff --git a/test/functional/adduser.js b/test/functional/adduser.js
index <HASH>..<HASH> 100644
--- a/test/functional/adduser.js
+++ b/test/functional/adduser.js
@@ -1,4 +1,6 @@
var Server = require('./lib/server')
+var fs = require('fs')
+var path = require('path')
module.exports = function() {
var server = new Server('http://localhost:55551/')
@@ -26,4 +28,20 @@ module.exports = function() {
.body_error(/maximum amount of users reached/)
})
})
+
+ describe('adduser created with htpasswd', function() {
+ var user = 'preexisting'
+ var pass = 'preexisting'
+ before(function () {
+ return fs.appendFileSync(
+ path.join(__dirname, 'test-storage', '.htpasswd'),
+ 'preexisting:$apr1$4YSboUa9$yVKjE7.PxIOuK3M4D7VjX.'
+ )
+ })
+ it('should log in', function () {
+ return server.auth(user, pass)
+ .status(201)
+ .body_ok(/you are authenticated as/)
+ })
+ })
}
|
test: adduser created with htpasswd
|
verdaccio_verdaccio
|
train
|
js
|
72dd6a85ad096c36bda8fe0b653ace9ce8d66509
|
diff --git a/src/components/btn/btn-mixin.js b/src/components/btn/btn-mixin.js
index <HASH>..<HASH> 100644
--- a/src/components/btn/btn-mixin.js
+++ b/src/components/btn/btn-mixin.js
@@ -81,7 +81,7 @@ export default {
},
attrs () {
const att = { tabindex: this.computedTabIndex }
- if (this.type === 'reset' || this.type === 'submit') {
+ if (this.type !== 'a') {
att.type = this.type
}
if (this.to !== void 0) {
|
chore: Addition to previous QBtn commit
|
quasarframework_quasar
|
train
|
js
|
911c686f006dc9a5996ace9235099fdee0f2eca9
|
diff --git a/config/ember-try.js b/config/ember-try.js
index <HASH>..<HASH> 100644
--- a/config/ember-try.js
+++ b/config/ember-try.js
@@ -4,6 +4,7 @@ const getChannelURL = require('ember-source-channel-url');
module.exports = async function() {
return {
+ useYarn: true,
scenarios: [
{
name: 'ember-lts-3.4',
|
fix: configure `ember-try` to use Yarn
|
tim-evans_ember-pop-over
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.