hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
e72200046982e390b0a5a7119eabcb230e81afd8
diff --git a/ibis/backends/tests/test_join.py b/ibis/backends/tests/test_join.py index <HASH>..<HASH> 100644 --- a/ibis/backends/tests/test_join.py +++ b/ibis/backends/tests/test_join.py @@ -133,17 +133,11 @@ def test_mutating_join(backend, con, batting, awards_players, how): [ param( "semi", - marks=pytest.mark.notimpl( - ["clickhouse", "dask", "datafusion", "impala"] - ), + marks=pytest.mark.notimpl(["dask", "datafusion"]), ), param( "anti", - marks=pytest.mark.notimpl( - # clickhouse and impala are broken, the rest are not - # implemented - ["clickhouse", "dask", "datafusion", "impala"] - ), + marks=pytest.mark.notimpl(["dask", "datafusion"]), ), ], )
test: remove notimpl for impala and clickhouse for test_filtering_join woohoo!
ibis-project_ibis
train
py
4e162074537d03110e5641cccf44a49ef6113bcc
diff --git a/framework/core/js/src/forum/components/Post.js b/framework/core/js/src/forum/components/Post.js index <HASH>..<HASH> 100644 --- a/framework/core/js/src/forum/components/Post.js +++ b/framework/core/js/src/forum/components/Post.js @@ -66,8 +66,8 @@ export default class Post extends Component { buttonClassName="Button Button--icon Button--flat" menuClassName="Dropdown-menu--right" icon="fas fa-ellipsis-h" - onshow={() => this.$('.Post-actions').addClass('open')} - onhide={() => this.$('.Post-actions').removeClass('open')} + onshow={() => this.$('.Post-controls').addClass('open')} + onhide={() => this.$('.Post-controls').removeClass('open')} accessibleToggleLabel={app.translator.trans('core.forum.post_controls.toggle_dropdown_accessible_label')} > {controls}
fix: clicking three dots on post opens all dropdowns in `.Post-actions` (#<I>)
flarum_core
train
js
5a37197a3ab44072067fe57f85d20a88ddd0daf5
diff --git a/api/src/opentrons/commands/module_commands.py b/api/src/opentrons/commands/module_commands.py index <HASH>..<HASH> 100644 --- a/api/src/opentrons/commands/module_commands.py +++ b/api/src/opentrons/commands/module_commands.py @@ -92,7 +92,7 @@ def thermocycler_execute_profile( ) -> command_types.ThermocyclerExecuteProfileCommand: text = ( f"Thermocycler starting {repetitions} repetitions" - " of cycle composed of the following steps: {steps}" + f" of cycle composed of the following steps: {steps}" ) return { "name": command_types.THERMOCYCLER_EXECUTE_PROFILE, diff --git a/api/src/opentrons/protocol_api/protocol_context.py b/api/src/opentrons/protocol_api/protocol_context.py index <HASH>..<HASH> 100644 --- a/api/src/opentrons/protocol_api/protocol_context.py +++ b/api/src/opentrons/protocol_api/protocol_context.py @@ -272,7 +272,7 @@ class ProtocolContext(CommandPublisher): return if message["$"] == "before": - self._commands.append(text.format(**payload)) + self._commands.append(text) self._unsubscribe_commands = self.broker.subscribe( cmd_types.COMMAND, on_command
fix(api): add missing f-string to thermocycler profile command text (#<I>) Closes #<I>
Opentrons_opentrons
train
py,py
38e52d533c8a5fd03dc6e43bd3b6245810d0ad7e
diff --git a/demo/index.js b/demo/index.js index <HASH>..<HASH> 100644 --- a/demo/index.js +++ b/demo/index.js @@ -188,7 +188,6 @@ function FullyControlledOnClick() { interactive={true} trigger="manual" visible={isOpen} - hideOnClick={false} onClickOutside={close} > <button onClick={isOpen ? close : open}>Open</button> diff --git a/src/Tippy.js b/src/Tippy.js index <HASH>..<HASH> 100644 --- a/src/Tippy.js +++ b/src/Tippy.js @@ -40,6 +40,7 @@ export default function TippyGenerator(tippy) { const props = { ignoreAttributes, + hideOnClick: !isControlledMode, ...restOfNativeProps, content: component.container, };
fix: set hideOnClick false by default in controlled mode
atomiks_tippy.js-react
train
js,js
bb2eb8a47fd0fd1721e5bbbe468b0266e29ff403
diff --git a/src/resources/views/character/intel/summary.blade.php b/src/resources/views/character/intel/summary.blade.php index <HASH>..<HASH> 100644 --- a/src/resources/views/character/intel/summary.blade.php +++ b/src/resources/views/character/intel/summary.blade.php @@ -153,7 +153,7 @@ </thead> </table> <div class="panel-footer clearfix"> - <div class="col-md-2 col-md-offset-2"> + <div class="col-md-2 offset-md-2"> <span class="badge badge-warning">0</span> Corporation </div> <div class="col-md-2">
fix(deps): use new offset helper
eveseat_web
train
php
313c56b7f6e58eac3468fd028bf573185a5a671d
diff --git a/docs/js/main.js b/docs/js/main.js index <HASH>..<HASH> 100644 --- a/docs/js/main.js +++ b/docs/js/main.js @@ -67,6 +67,7 @@ window.onload = function () { // Download if (typeof download.download === 'undefined') { download.className += ' disabled'; + download.title = 'Your browser does not support download'; } // Options
docs: add download note for outdated browsers
fengyuanchen_cropperjs
train
js
04e7f555e1401513b69218e8bab8b07c12419b13
diff --git a/lib/Bacon/App.php b/lib/Bacon/App.php index <HASH>..<HASH> 100644 --- a/lib/Bacon/App.php +++ b/lib/Bacon/App.php @@ -100,6 +100,11 @@ class App } catch (Exceptions\RouterException $e) { $this->log->debug($e->getMessage()); + + if (!empty($this->config->spa)) { + # Route all not found controllers to root, if single page application + return $this->use_root_controller(); + } $this->use_not_found_controller(); }
feat(router): added SPA flag, to route all to root controller
Brainsware_bacon
train
php
33ea42f3f7ad783088b19090d7aa576617cf68d5
diff --git a/views/js/controller/creator/views/test.js b/views/js/controller/creator/views/test.js index <HASH>..<HASH> 100644 --- a/views/js/controller/creator/views/test.js +++ b/views/js/controller/creator/views/test.js @@ -160,7 +160,7 @@ function($, _, __, hider, feedback, defaults, actions, testPartView, templates, assessmentSections : [{ 'qti-type' : 'assessmentSection', identifier : qtiTestHelper.getAvailableIdentifier(modelOverseer.getModel(), 'assessmentSection', defaults().sectionIdPrefix), - title : `${defaults().sectionTitlePrefix} 1`, + title : defaults().sectionTitlePrefix, index : 0, sectionParts : [], visible: true @@ -179,6 +179,8 @@ function($, _, __, hider, feedback, defaults, actions, testPartView, templates, //initialize the new test part testPartView.setUp(creatorContext, partModel, $testPart); + // set index for new section + actions.updateTitleIndex($('.section', $testPart)); /** * @event modelOverseer#part-add
fix: update index in new test part
oat-sa_extension-tao-testqti
train
js
5bc68d590d9b933172d12ca4811239f35116f37e
diff --git a/odoa.py b/odoa.py index <HASH>..<HASH> 100644 --- a/odoa.py +++ b/odoa.py @@ -24,8 +24,13 @@ SOFTWARE. import sys import json import random -import urllib2 import traceback +try: + # For Python 3.0 and later + from urllib.request import urlopen +except ImportError: + # Fall back to Python 2's urllib2 + from urllib2 import urlopen class ODOA(object): @@ -55,7 +60,7 @@ class ODOA(object): surah_url = '{base}/surah/surah_{pages}.json'.format(base=self.BASE_API, pages=rand_surah) try: - response = urllib2.urlopen(surah_url) # Fetch data from given url. + response = urlopen(surah_url) # Fetch data from given url. data = json.loads(response.read()) # Get response and convert to dict. except IOError: traceback.print_exc(file=sys.stdout) @@ -97,8 +102,8 @@ class ODOA(object): .format(base=self.BASE_API, lang=lang, surah=int(surah)) try: - response = urllib2.urlopen(translation_url) # Fetch data from give url. - data = json.loads(response.read()) # Get response and convert to dict. + response = urlopen(translation_url) # Fetch data from give url. + data = json.loads(response.read()) # Get response and convert to dict. translation = data['verse'][ayah] except Exception: return None
feat: Add python 3 support
Keda87_python-quran-odoa
train
py
39309ab6da907f605563f870afc146fec8505683
diff --git a/commitlint.config.js b/commitlint.config.js index <HASH>..<HASH> 100644 --- a/commitlint.config.js +++ b/commitlint.config.js @@ -3,9 +3,7 @@ module.exports = { rules: { 'body-leading-blank': [2, 'always'], - 'body-max-line-length': [2, 'always', 72], 'footer-leading-blank': [2, 'always'], - 'footer-max-line-length': [2, 'always', 72], 'header-max-length': [2, 'always', 72], 'scope-case': [2, 'always', 'start-case'], 'scope-enum': [
chore: Do not restrict lines length in body
serverless_serverless
train
js
3065af0930d6b044b3889c1b79ecd447834b48e3
diff --git a/app/examples/dynamic-linechart/index.js b/app/examples/dynamic-linechart/index.js index <HASH>..<HASH> 100644 --- a/app/examples/dynamic-linechart/index.js +++ b/app/examples/dynamic-linechart/index.js @@ -1,10 +1,9 @@ import LineChart from '../../../src/candela/components/LineChart'; -import Events from '../../../src/candela/VisComponent/mixin/Events'; import $ from 'jquery'; import html from './index.jade'; import './index.styl'; -class DynamicLineChart extends Events(LineChart) { +class DynamicLineChart extends LineChart { constructor (...args) { super(...args); } @@ -16,6 +15,14 @@ class DynamicLineChart extends Events(LineChart) { data (data) { this.options.data = data; + + this.chart.then(chart => { + let data = chart.data('data'); + data.remove(() => true); + data.insert(this.options.data); + + chart.update(); + }); } }
fix(DynamicLineChart): update DynamicLineChart example to work again (1) Remove Events mixin from DynamicLineChart. (2) Use Vega data update API to make dynamic updates.
Kitware_candela
train
js
5223064f4bcc02bb42986dd2ba95e72d67bbcdc4
diff --git a/src/View/Tags/InlineSvg.js b/src/View/Tags/InlineSvg.js index <HASH>..<HASH> 100644 --- a/src/View/Tags/InlineSvg.js +++ b/src/View/Tags/InlineSvg.js @@ -99,6 +99,7 @@ module.exports = function (BaseTag) { * @return {void} */ compile (compiler, lexer, buffer, { body, childs, lineno }) { + body = body.replace(/\\/g, '/') const { value } = this._compileStatement(lexer, body, lineno) const svgFile = this._normalizePath(this._getAbsPath(value))
fix(view): fix inlineSvg tag by escaping backslash
adonisjs_adonis-framework
train
js
99746ed5a7525a4c24109c05b2f2c243b752ed6a
diff --git a/schedula/dispatcher.py b/schedula/dispatcher.py index <HASH>..<HASH> 100644 --- a/schedula/dispatcher.py +++ b/schedula/dispatcher.py @@ -570,7 +570,7 @@ class Dispatcher(Base): try: # Set function name. function_name = func.__name__ except AttributeError as ex: - raise ValueError('Invalid function id due to:\n{}'.format(ex)) + function_name = 'unknown' else: function_name = function_id
feat(dispatcher): Avoid failure when functions does not have the name.
vinci1it2000_schedula
train
py
9b4e32ec9b04531a603aaa7a53916abd2b13b343
diff --git a/src/test/java/io/appium/java_client/ios/IOSNativeWebTapSettingTest.java b/src/test/java/io/appium/java_client/ios/IOSNativeWebTapSettingTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/io/appium/java_client/ios/IOSNativeWebTapSettingTest.java +++ b/src/test/java/io/appium/java_client/ios/IOSNativeWebTapSettingTest.java @@ -4,6 +4,7 @@ import static org.junit.Assert.assertTrue; import java.time.Duration; +import org.junit.Ignore; import org.junit.Test; import org.openqa.selenium.By; import org.openqa.selenium.WebElement; @@ -12,7 +13,9 @@ import org.openqa.selenium.support.ui.WebDriverWait; public class IOSNativeWebTapSettingTest extends BaseSafariTest { - @Test public void nativeWebTapSettingTest() { + @Test + @Ignore("https://github.com/appium/appium/issues/17014") + public void nativeWebTapSettingTest() { assertTrue(driver.isBrowser()); driver.get("https://saucelabs.com/test/guinea-pig");
chore: Ignore the test which has a connected server issue (#<I>)
appium_java-client
train
java
97b0508ce16775b1125bc35c72f800947ea2be05
diff --git a/lib/rethink.js b/lib/rethink.js index <HASH>..<HASH> 100644 --- a/lib/rethink.js +++ b/lib/rethink.js @@ -81,6 +81,9 @@ exports.initialize = function initializeDataSource(dataSource, callback) { }; RethinkDB.prototype.connect = function(cb) { + if(!this.db) { + this.db = r; + } cb(); // connection pooling handles it };
feat(app): Expose the driver on the db property of the connector
Yoobic_loopback-connector-rethinkdbdash
train
js
c81e9dcb66a727ae52a0baf892a18a0e1cd17530
diff --git a/packages/key-facts/src/key-facts-text.js b/packages/key-facts/src/key-facts-text.js index <HASH>..<HASH> 100644 --- a/packages/key-facts/src/key-facts-text.js +++ b/packages/key-facts/src/key-facts-text.js @@ -3,7 +3,7 @@ import { Text } from "react-native"; import { TextLink } from "@times-components/link"; import { renderTree } from "@times-components/markup-forest"; import coreRenderers from "@times-components/markup"; -import { defaultProps, propTypes } from "./key-facts-prop-types"; +import { defaultProps, propTypes } from "./key-facts-text-prop-types"; import styles from "./styles"; const KeyFactsText = ({ item, listIndex, onLinkPress, fontStyle }) => (
fix: fix key facts ast prop warning (#<I>)
newsuk_times-components
train
js
82dee82bfde4bfc83ba90d8a17c13a075ee13e8c
diff --git a/server/peer_server.go b/server/peer_server.go index <HASH>..<HASH> 100644 --- a/server/peer_server.go +++ b/server/peer_server.go @@ -40,7 +40,7 @@ const ( ) const ( - peerModeFlag = 0 + peerModeFlag = 0 standbyModeFlag = 1 ) diff --git a/server/registry.go b/server/registry.go index <HASH>..<HASH> 100644 --- a/server/registry.go +++ b/server/registry.go @@ -22,8 +22,8 @@ const RegistryStandbyKey = "/_etcd/standbys" // The Registry stores URL information for nodes. type Registry struct { sync.Mutex - store store.Store - peers map[string]*node + store store.Store + peers map[string]*node standbys map[string]*node } @@ -37,8 +37,8 @@ type node struct { // Creates a new Registry. func NewRegistry(s store.Store) *Registry { return &Registry{ - store: s, - peers: make(map[string]*node), + store: s, + peers: make(map[string]*node), standbys: make(map[string]*node), } }
chore: gofmt go files
etcd-io_etcd
train
go,go
a74eabb1a14b4f1af4ac142c2ee55406c08cd117
diff --git a/lib/config/definitions.js b/lib/config/definitions.js index <HASH>..<HASH> 100644 --- a/lib/config/definitions.js +++ b/lib/config/definitions.js @@ -60,7 +60,7 @@ const options = [ 'Whether CLI configuration options should be moved to the `force` config section', stage: 'global', type: 'boolean', - default: true, + default: false, }, { name: 'dryRun',
fix: Revert "feat: default forceCli to true" This reverts commit <I>d6f<I>e0cf<I>d7fb6ccaa<I>fffe<I>bc5.
renovatebot_renovate
train
js
f4668c46ad90dce6f20eee9fcad9d76616c92aae
diff --git a/karma.conf.js b/karma.conf.js index <HASH>..<HASH> 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -8,7 +8,7 @@ module.exports = function(config) { plugin: [['tsify', JSON.parse(fs.readFileSync('./tsconfig.json', 'utf8')).compilerOptions]], transform: ['brfs'], }, - browsers: ['ChromeHeadless', 'Firefox'], + browsers: ['ChromeHeadless'], concurrency: 1, files: [ {pattern: 'spec/**/*.spec.ts', type: "js"}
chore: run unit tests in chrome only
mapillary_mapillary-js
train
js
e8e2682e3ab5900afd5c8cb0b1bfea8766d9a059
diff --git a/core/src/main/java/com/dtolabs/rundeck/core/execution/workflow/BaseWorkflowExecutor.java b/core/src/main/java/com/dtolabs/rundeck/core/execution/workflow/BaseWorkflowExecutor.java index <HASH>..<HASH> 100644 --- a/core/src/main/java/com/dtolabs/rundeck/core/execution/workflow/BaseWorkflowExecutor.java +++ b/core/src/main/java/com/dtolabs/rundeck/core/execution/workflow/BaseWorkflowExecutor.java @@ -817,10 +817,16 @@ public abstract class BaseWorkflowExecutor implements WorkflowExecutor { final StepExecutionResult handlerResult ) { - combinedResultData.merge(outputContext.getSharedContext()); + WFSharedContext sharedContext = outputContext.getSharedContext(); + combinedResultData.merge(sharedContext); if (NodeDispatchStepExecutor.isWrappedDispatcherResult(handlerResult)) { combineNodeResultData(c, handlerResult, combinedResultData); } + //combine individual step context data to the global level + DataContext data = sharedContext.getData(ContextView.step(c)); + if (data != null) { + combinedResultData.merge(ContextView.global(), data); + } } public void reportNodesMatched(
fix: step context captured data should export to global context
rundeck_rundeck
train
java
72da4ade03ad8b5f92efaa2618856fec8c2ddb78
diff --git a/lib/crawler.js b/lib/crawler.js index <HASH>..<HASH> 100644 --- a/lib/crawler.js +++ b/lib/crawler.js @@ -75,6 +75,7 @@ class Crawler { this._preventNewTabs(), this._authenticate(), this._emulate(), + this._setViewport(), this._setCacheEnabled(), this._setUserAgent(), this._setExtraHeaders(), @@ -118,6 +119,15 @@ class Crawler { * @return {!Promise} * @private */ + async _setViewport() { + if (!this._options.viewport) return; + await this._page.setViewport(this._options.viewport); + } + + /** + * @return {!Promise} + * @private + */ async _setCacheEnabled() { if (this._options.browserCache) return; // @ts-ignore
feat(crawler): support page.setViewport method
yujiosaka_headless-chrome-crawler
train
js
2180e2f60e9835f79a8917478946e38c6475dc12
diff --git a/src/components/FileSelector/index.js b/src/components/FileSelector/index.js index <HASH>..<HASH> 100644 --- a/src/components/FileSelector/index.js +++ b/src/components/FileSelector/index.js @@ -225,7 +225,7 @@ FileSelector.propTypes = { /** Shows the help message below the input. */ bottomHelpText: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), /** Text that is displayed when the field is empty, to prompt the user for a valid entry. */ - placeholder: PropTypes.oneOfType([PropTypes.string, PropTypes.node]), + placeholder: PropTypes.string, /** Specifies the tab order of an element (when the tab button is used for navigating). */ tabIndex: PropTypes.oneOfType([PropTypes.number, PropTypes.string]), /** Specifies that an input field must be filled out before submitting the form.
fix: placeholder type on fileselector (#<I>)
90milesbridge_react-rainbow
train
js
7cdc14ddf5a069e9ef77ee9a32d0cac65b18a61e
diff --git a/docusaurus/docusaurus.config.js b/docusaurus/docusaurus.config.js index <HASH>..<HASH> 100644 --- a/docusaurus/docusaurus.config.js +++ b/docusaurus/docusaurus.config.js @@ -76,7 +76,8 @@ module.exports = { sidebarPath: require.resolve('./sidebars.js'), // Please change this to your repo. - editUrl: 'https://github.com/availity/availity-react/edit/master/', + editUrl: + 'https://github.com/availity/availity-react/edit/master/docusaurus/docs/', }, theme: {
fix(dinosaurdocs): fixes broken editUrl
Availity_availity-react
train
js
eb3514b6a19b48e3559e77d6b025040e5d2a810c
diff --git a/src/utils/log.js b/src/utils/log.js index <HASH>..<HASH> 100644 --- a/src/utils/log.js +++ b/src/utils/log.js @@ -6,6 +6,7 @@ export function log (...args) { process.env.DEBUG === '*' || process.env.DEBUG === 'isomorphic-git' || (typeof window !== 'undefined' && + typeof window.localStorage !== 'undefined' && (window.localStorage.debug === '*' || window.localStorage.debug === 'isomorphic-git')) }
fix: reference to window.localStorage broke WebWorker (#<I>)
isomorphic-git_isomorphic-git
train
js
27c5a8093ca83b226ff56293ff33cbab6e92606d
diff --git a/packages/mangojuice-core/src/core/run/mount.js b/packages/mangojuice-core/src/core/run/mount.js index <HASH>..<HASH> 100644 --- a/packages/mangojuice-core/src/core/run/mount.js +++ b/packages/mangojuice-core/src/core/run/mount.js @@ -79,9 +79,9 @@ * unmount a view using {@link Mounter#unmount} */ function mount(mounter, runRes, ...otherBlocks) { - const view = mounter.mount(mountBlock.model, mountBlock.block.View); + const view = mounter.mount(runRes.model, runRes.block.View); const stop = () => { - mountBlock.proc.destroy(); + runRes.proc.destroy(); otherBlocks.forEach(x => x.proc.destroy()); mounter.unmount(); };
fix(core): mount function (need to add eslint!)
mangojuicejs_mangojuice
train
js
a411eeb45f09df66af2478d775a70fca45d6b14d
diff --git a/src/dag-node/addNamedLink.js b/src/dag-node/addNamedLink.js index <HASH>..<HASH> 100644 --- a/src/dag-node/addNamedLink.js +++ b/src/dag-node/addNamedLink.js @@ -11,7 +11,7 @@ * @param {numner} position - The position within the array of links */ const addNamedLink = (object, name, position) => { - const skipNames = ['', ...Object.keys(this)] + const skipNames = ['', ...Object.keys(object)] if (skipNames.includes(name)) { return }
fix: actually use object keys The code was wrong, it didn't actually use the keys of the object. This also broke things in Browser environments. Fixes <URL>
ipld_js-ipld-dag-pb
train
js
ad03d261405684c9fd43cfbe38b113cca9417618
diff --git a/gulpfile.js/config/default.js b/gulpfile.js/config/default.js index <HASH>..<HASH> 100644 --- a/gulpfile.js/config/default.js +++ b/gulpfile.js/config/default.js @@ -20,7 +20,7 @@ var config = { }, license: { src: [ - 'node/**/*.js', 'browser/**/*.js', 'eslint/**/*.js', 'plugin/**/*.js', + 'lib/**/*.js', 'node/**/*.js', 'browser/**/*.js', 'eslint/**/*.js', 'plugin/**/*.js', 'package.json', 'README.md', 'LICENSE', 'NOTICE', ],
fix: missing lib/util during release
adoyle-h_eslint-config-adoyle-style
train
js
cdb6091a2216786faf63f10ccb39ce6f7ab8d990
diff --git a/lib/platform/aws-lambda/index.js b/lib/platform/aws-lambda/index.js index <HASH>..<HASH> 100644 --- a/lib/platform/aws-lambda/index.js +++ b/lib/platform/aws-lambda/index.js @@ -200,7 +200,7 @@ class PlatformLambda { } else if (body.event === 'workerError') { this.events.emit(body.event, workerId, { id: workerId, - error: new Error('A Lambda function has reached its timeout and will be stopped'), + error: new Error(`A Lambda function has exited with an error. Reason: ${body.reason}`), level: 'error', aggregatable: false, });
fix(lambda): include reason in error messages for worker errors
artilleryio_artillery
train
js
74fbc90329639523581617c693a04f4b6a4a797a
diff --git a/src/MySQL.js b/src/MySQL.js index <HASH>..<HASH> 100644 --- a/src/MySQL.js +++ b/src/MySQL.js @@ -72,6 +72,23 @@ function completeDoc($, rows, doc) { case 'default, range': doc.default = cleaner.cleanDefault(value.text().trim()); break; + case 'type: default, range': + let textValueDefaultRange = value.text().trim(); + let key = textValueDefaultRange.substring(0, textValueDefaultRange.indexOf(':') + 1); + let val = textValueDefaultRange.substring(textValueDefaultRange.indexOf(':') + 1); + if (typeof key === 'string') { + doc.type = cleaner.getCleanTypeFromMixedString(key); + if (typeof doc.type !== 'string') { + delete doc.type; + } + } + if (typeof val === 'string') { + doc.default = cleaner.cleanDefault(val); + if (typeof doc.default !== 'string') { + delete doc.default; + } + } + break; case 'valid values': doc.validValues = $(value) .find('code')
feat: support 'type: default, range' in MySQL pages
williamdes_mariadb-mysql-kbs
train
js
435c268a70bbea3225543eeda2ed0e037a8c79d6
diff --git a/packages/cozy-client/src/dsl.js b/packages/cozy-client/src/dsl.js index <HASH>..<HASH> 100644 --- a/packages/cozy-client/src/dsl.js +++ b/packages/cozy-client/src/dsl.js @@ -44,6 +44,9 @@ export class QueryDefinition { } include(includes) { + if (!Array.isArray(includes)) { + throw new Error('include() takes an array of relationship names') + } return new QueryDefinition({ ...this.toDefinition(), includes }) }
feat(dsl): include() throws helpful error if called with wrong args
cozy_cozy-client
train
js
9db25b15425af46f5f726bd86bd4c2ea687f94ff
diff --git a/test/12-integration-tests.js b/test/12-integration-tests.js index <HASH>..<HASH> 100644 --- a/test/12-integration-tests.js +++ b/test/12-integration-tests.js @@ -320,14 +320,14 @@ describe('Integration tests', () => { }) ) )); - it('Should pass branch validation via simple RegExp (release branch)', () => - exec('git checkout -b release').then(() => + it('Should pass branch validation via simple RegExp (hotfix branch)', () => + exec('git checkout -b hotfix').then(() => publish( getTestOptions({ set: { publishCommand: echoPublishCommand, validations: { - branch: '/(master|release)/', + branch: '/(master|release|hotfix)/', }, }, })
test(branch-validation): fix test
inikulin_publish-please
train
js
176b3e96a78c4590f42817e6dcf44addcc49a13f
diff --git a/src/directive/translate.js b/src/directive/translate.js index <HASH>..<HASH> 100644 --- a/src/directive/translate.js +++ b/src/directive/translate.js @@ -36,10 +36,10 @@ angular.module('pascalprecht.translate') .config(function ($translateProvider) { - $translateProvider.translations({ + $translateProvider.translations('en',{ 'TRANSLATION_ID': 'Hello there!', 'WITH_VALUES': 'The following value is dynamic: {{value}}' - }); + }).preferredLanguage('en'); });
fix(docs): fix example in directive ngdoc-documentation (fixes #<I>)
angular-translate_angular-translate
train
js
718ca02498bc4d34cfff2fbb16b4b45c31ca63bc
diff --git a/gulpfile.babel.js b/gulpfile.babel.js index <HASH>..<HASH> 100755 --- a/gulpfile.babel.js +++ b/gulpfile.babel.js @@ -338,8 +338,8 @@ gulp.task('core-dts-test', (argv['skip-build'] ? [] : ['core']), (done) => { //////////////////////////////////////// gulp.task('unit-test', [].concat( - argv['skip-build'] ? [] : (argv.watch ? ['watch-core'] : ['prepare', 'core']), - ['core-dts-test'] + argv['skip-build'] ? [] : (argv.watch ? ['watch-core'] : ['prepare', 'core'])//, + //['core-dts-test'] ), (done) => { // Usage:
chore(gulpfile): Suppress `core-dts-test` temporarily.
OnsenUI_OnsenUI
train
js
443b0562774e1ade2a396ced7e5c60b3e7da6234
diff --git a/packages/react/src/elements/components/Notification/__gemini__/Notifications.gemini.js b/packages/react/src/elements/components/Notification/__gemini__/Notifications.gemini.js index <HASH>..<HASH> 100644 --- a/packages/react/src/elements/components/Notification/__gemini__/Notifications.gemini.js +++ b/packages/react/src/elements/components/Notification/__gemini__/Notifications.gemini.js @@ -2,5 +2,6 @@ gemini.suite("Notifications", suite => { suite .setUrl("iframe.html?selectedKind=Notifications&selectedStory=V1") .setCaptureElements(".hig__flyout__panel") - .capture("Default"); + // Small differences in placeholder text can easily generate false negatives + .capture("Default", { tolerance: 5 }, () => {}); });
test: increase tolerance Small differences in placeholder text can easily generate false negatives
Autodesk_hig
train
js
2f62e4531cda02a3a48448212b82b287cf6426c3
diff --git a/app/actionTypes.js b/app/actionTypes.js index <HASH>..<HASH> 100644 --- a/app/actionTypes.js +++ b/app/actionTypes.js @@ -21,7 +21,6 @@ export const EDITOR_SWITCH_PATCH = 'EDITOR_SWITCH_PATCH'; export const TAB_OPEN = 'TAB_OPEN'; export const TAB_CLOSE = 'TAB_CLOSE'; -export const TAB_SWITCH = 'TAB_SWITCH'; export const TAB_SORT = 'TAB_SORT'; export const PROJECT_LOAD_DATA = 'PROJECT_LOAD_DATA'; diff --git a/app/state.js b/app/state.js index <HASH>..<HASH> 100644 --- a/app/state.js +++ b/app/state.js @@ -95,7 +95,6 @@ const initialState = { selection: [], linkingPin: null, selectedNodeType: 1, - activeTab: 1, tabs: { 1: { id: 1,
fix(tabs): remove unneeded props from state (activeTab === currentPatchId)
xodio_xod
train
js,js
990ef8de05a695b363d0d2027f02e1959634f8ac
diff --git a/webapps/ui/common/tests/test-helper.js b/webapps/ui/common/tests/test-helper.js index <HASH>..<HASH> 100644 --- a/webapps/ui/common/tests/test-helper.js +++ b/webapps/ui/common/tests/test-helper.js @@ -86,8 +86,25 @@ module.exports = function (operations, noReset, done) { return; } if( res == 0 ) { - deferred.fulfill(); - done(err, {}); + try { + + done(err, {}); + + var controlFlowObserver = setInterval(function(){ + // HAXX: For unknown reasons, the controlFlow sometimes does not emit an idle event + if(!browser.controlFlow().activeFrame_) { + browser.controlFlow().emit('idle'); + } + }, 1000); + + browser.controlFlow().once('idle', function() { + clearInterval(controlFlowObserver); + deferred.fulfill(); + }); + + } catch(err) { + deferred.reject(err); + } } else { setTimeout(pollFct, 200); }
chore(tests): make test helper more stable
camunda_camunda-bpm-platform
train
js
d584c3502744462f5e775d24e96be9ed51a82f46
diff --git a/packages/test/jest-config/index.js b/packages/test/jest-config/index.js index <HASH>..<HASH> 100644 --- a/packages/test/jest-config/index.js +++ b/packages/test/jest-config/index.js @@ -3,4 +3,5 @@ module.exports = { transform: { '^.+\\.jsx?$': require.resolve('./transformer'), }, + clearMocks: true, };
feat(jest-config): always clear mocks between tests BREAKING CHANGE: Mocks are now always cleared between tests
goldwasserexchange_public
train
js
b05db6f9ea44caab19b49f89dc979d793d499b71
diff --git a/lib/instrumentation/span.js b/lib/instrumentation/span.js index <HASH>..<HASH> 100644 --- a/lib/instrumentation/span.js +++ b/lib/instrumentation/span.js @@ -7,6 +7,8 @@ var parsers = require('../parsers') var stackman = require('../stackman') var Timer = require('./timer') +const TEST = process.env.ELASTIC_APM_TEST + module.exports = Span function Span (transaction) { @@ -122,7 +124,7 @@ Span.prototype._recordStackTrace = function (obj) { return } - if (!process.env.ELASTIC_APM_TEST) callsites = callsites.filter(filterCallsite) + if (!TEST) callsites = callsites.filter(filterCallsite) var next = afterAll((err, res) => { err ? stack.reject(err) : stack.resolve(res)
perf: use constant to store test boolean (#<I>) I'm not sure makes much if any difference in the real world, but it makes me feel better :D
elastic_apm-agent-nodejs
train
js
a67706abb5e0ae31b6af91534c1f2b8e16b47ca5
diff --git a/lib/array/reduce.js b/lib/array/reduce.js index <HASH>..<HASH> 100644 --- a/lib/array/reduce.js +++ b/lib/array/reduce.js @@ -27,14 +27,14 @@ module.exports = function reduceClosure(nativeReduce) { let i = 0; const iMax = array.length; let accumulator = initialValue; - + if (initialValue === undefined) { if (!array.length) { throw new TypeError('Reduce of empty array with no initial value'); } for (; i < iMax; i++) { - if (array[i]) { + if (array[i] !== undefined) { accumulator = array[i++]; break; }
fix(reduce): Fix undefined bug in Array.reduce
kb-dev_sanic.js
train
js
c3aebb14bf9b56d99039fb4fd69beaf33eeba8be
diff --git a/tests/schema.py b/tests/schema.py index <HASH>..<HASH> 100644 --- a/tests/schema.py +++ b/tests/schema.py @@ -4,7 +4,7 @@ # # pylint: disable=missing-docstring, invalid-name, protected-access # pylint: disable=bare-except -from __future__ import absolute_import +from __future__ import absolute_import, print_function import unittest import anyconfig.schema as TT
fix: add missing import, print_function from __future__
ssato_python-anyconfig
train
py
b4b088ded71a29561f86ab72a00c43eff7ff45a3
diff --git a/webpack.config.js b/webpack.config.js index <HASH>..<HASH> 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -60,10 +60,11 @@ module.exports = function makeWebpackConfig() { config.plugins = [ new webpack.optimize.DedupePlugin() - /*, new webpack.optimize.UglifyJsPlugin({ + , new webpack.optimize.UglifyJsPlugin({ compress: {warnings: false} , comments: false - })*/ + }) + /**/ ]; return config;
chore(webpack): added compression
BioPhoton_angular1-star-rating
train
js
24dd282f62983868b2f686d752f813db1275a57a
diff --git a/ruby/server/lib/roma/command/receiver.rb b/ruby/server/lib/roma/command/receiver.rb index <HASH>..<HASH> 100644 --- a/ruby/server/lib/roma/command/receiver.rb +++ b/ruby/server/lib/roma/command/receiver.rb @@ -59,7 +59,7 @@ module Roma # version def ev_version(s) - send_data("VERSION #{Roma::VERSION}\r\n") + send_data("VERSION ROMA-#{Roma::VERSION}\r\n") end # quit
refactor:improve a version command result.
roma_roma
train
rb
1f4dffae00028cb94cf9c8c38dc7f301bd6bb612
diff --git a/src/components/ebay-fake-menu-button/fake-menu-button.stories.js b/src/components/ebay-fake-menu-button/fake-menu-button.stories.js index <HASH>..<HASH> 100644 --- a/src/components/ebay-fake-menu-button/fake-menu-button.stories.js +++ b/src/components/ebay-fake-menu-button/fake-menu-button.stories.js @@ -188,12 +188,15 @@ Standard.args = { items: [ { renderBody: `item 1 that has very long text`, + href: 'https://www.ebay.com', }, { renderBody: `item 2`, + href: 'https://www.ebay.com', }, { renderBody: `item 3`, + href: 'https://www.ebay.com', }, ], text: `eBay Menu`,
fix(fake-menu-button): added href to stories
eBay_ebayui-core
train
js
ee1b670ec9d8c543f454a26b2cf3b0a64a14dbf8
diff --git a/providers/providers_test.go b/providers/providers_test.go index <HASH>..<HASH> 100644 --- a/providers/providers_test.go +++ b/providers/providers_test.go @@ -88,8 +88,8 @@ func TestProvidersSerialization(t *testing.T) { t.Fatal("failed to load set correctly") } - if pt1 != lt1 { - t.Fatal("time wasnt serialized correctly") + if !pt1.Equal(lt1) { + t.Fatalf("time wasnt serialized correctly, %v != %v", pt1, lt1) } lt2, ok := pset.set[p2]
fix: go<I> monotonic time is not symetric across serialization using ==
libp2p_go-libp2p-kad-dht
train
go
66f289836de20e4c47e9adaaa5f2be9170a409d9
diff --git a/lib/Serverless.js b/lib/Serverless.js index <HASH>..<HASH> 100644 --- a/lib/Serverless.js +++ b/lib/Serverless.js @@ -36,6 +36,11 @@ class Serverless { } else if (configObject.configurationPath === undefined) { this._shouldResolveConfigurationInternally = true; } + // Due to design flaw properties of configObject (which is to be merged onto `this.config`) + // also are subject to variables resolution. + // To avoid that we clear configObject after consuming it's properties. + // Once new variables engine is in, we can remove that patch + delete configObject.configurationPath; this.providers = {};
refactor: Ensure no side effects from config properties
serverless_serverless
train
js
f1f3e55ef76dd9a7280d49b4bd62357390222a55
diff --git a/src/loader.js b/src/loader.js index <HASH>..<HASH> 100644 --- a/src/loader.js +++ b/src/loader.js @@ -5,7 +5,7 @@ import * as BufferLayout from 'buffer-layout'; import {Account} from './account'; import {PublicKey} from './publickey'; import {NUM_TICKS_PER_SECOND} from './timing'; -import {Transaction} from './transaction'; +import {Transaction, PACKET_DATA_SIZE} from './transaction'; import {sendAndConfirmTransaction} from './util/send-and-confirm-transaction'; import {sleep} from './util/sleep'; import type {Connection} from './connection'; @@ -19,7 +19,12 @@ export class Loader { * Amount of program data placed in each load Transaction */ static get chunkSize(): number { - return 229; // Keep program chunks under PACKET_DATA_SIZE + // Keep program chunks under PACKET_DATA_SIZE, leaving enough room for the + // rest of the Transaction fields + // + // TODO: replace 300 with a proper constant for the size of the other + // Transaction fields + return PACKET_DATA_SIZE - 300; } /**
fix: load programs in larger chunks
solana-labs_solana-web3.js
train
js
a4a5cd30c67170cabca16a5c6bfea818858b692f
diff --git a/src/Exscript/external/otp/otp.py b/src/Exscript/external/otp/otp.py index <HASH>..<HASH> 100644 --- a/src/Exscript/external/otp/otp.py +++ b/src/Exscript/external/otp/otp.py @@ -91,7 +91,7 @@ def generate(passphrase, seed, hashmodule = _HASHMODULE[hashfunction] folder = _FOLDFUNCTION[hashfunction] - hash = folder(hashmodule.new(seed.lower() + passphrase).digest()) + hash = folder(hashmodule.new(seed + passphrase).digest()) # discard the first <startkey> keys for iterations in range(0, startkey):
fix: don't lower case the seed on OTP
knipknap_exscript
train
py
a4632092a5336a1c738f3a97d5e7bb01954d58cb
diff --git a/tests/unit/remote/ssh/test_ssh.py b/tests/unit/remote/ssh/test_ssh.py index <HASH>..<HASH> 100644 --- a/tests/unit/remote/ssh/test_ssh.py +++ b/tests/unit/remote/ssh/test_ssh.py @@ -3,7 +3,8 @@ import os from unittest import TestCase -from mock import patch, mock_open +import mock +from mock import patch import pytest from dvc.remote.ssh import RemoteSSH @@ -44,14 +45,27 @@ class TestRemoteSSH(TestCase): self.assertEqual(remote.prefix, "/") -mock_ssh_config = """ -Host example.com +mock_ssh_config = """Host example.com User ubuntu HostName 1.2.3.4 Port 1234 IdentityFile ~/.ssh/not_default.key """ +# compat version for mock library version 2 +# mock 2.0.0 can't iterate in mock_open +if mock.version_info[0] < 3: + + def mock_open_compat(*args, **kargs): + f_open = mock.mock_open(*args, **kargs) + f_open.return_value.__iter__ = lambda self: self + f_open.return_value.__next__ = lambda self: self.readline() + return f_open + + mock_open = mock_open_compat +else: + mock_open = mock.mock_open + @pytest.mark.parametrize( "config,expected_host",
test: ssh: add mock_open compat version
iterative_dvc
train
py
ab4b806308abec5d1824ee9b44f71bafcf8c6e3a
diff --git a/src/server/queue/index.js b/src/server/queue/index.js index <HASH>..<HASH> 100644 --- a/src/server/queue/index.js +++ b/src/server/queue/index.js @@ -98,7 +98,11 @@ class Queues { if (queueConfig.createClient) options.createClient = queueConfig.createClient; const { BullMQ } = this._config; - queue = new BullMQ(name, options); + const { redis, ...rest } = options; + queue = new BullMQ(name, { + connection: redis, + ...rest, + }); queue.IS_BULLMQ = true; } else { if (queueConfig.createClient) options.createClient = queueConfig.createClient;
fix: support redis configuration with bullmq (#<I>)
bee-queue_arena
train
js
2e396594465c4be936244d2eb1d4840aa8b15528
diff --git a/packages/node_modules/@webex/internal-plugin-ediscovery/src/ediscovery.js b/packages/node_modules/@webex/internal-plugin-ediscovery/src/ediscovery.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/internal-plugin-ediscovery/src/ediscovery.js +++ b/packages/node_modules/@webex/internal-plugin-ediscovery/src/ediscovery.js @@ -205,10 +205,10 @@ const EDiscovery = SparkPlugin.extend({ const activities = res.body; // Dequeue the activities until the list is empty - while (activities.length > 0) { + while (activities.length) { // Grab the 1st activity const activity = activities.shift(); - // If the activity contains a file download it, but either way add the file to the zip + // If the activity contains a file download it, but either way add the file to the report const promise = plugin._downloadFileContent(activity) .then((downloadedActivity) => reportGenerator.add(downloadedActivity)); promises.push(promise);
chore(ediscovery): tidyup of conditional
webex_spark-js-sdk
train
js
57d8a059ae1031975214615b2e2187a9140e224a
diff --git a/examples/advanced.js b/examples/advanced.js index <HASH>..<HASH> 100644 --- a/examples/advanced.js +++ b/examples/advanced.js @@ -1,6 +1,6 @@ 'use strict'; // eslint-disable-line const CrawlKit = require('crawlkit'); -const genericAnchors = require('../finders/genericAnchors'); +const genericAnchors = require('crawlkit/finders/genericAnchors'); const urijs = require('urijs'); const baseURL = 'http://www.feth.com';
chore: use package instead of relative link
crawlkit_crawlkit
train
js
0b87f23ac703928c295aaf5aed13a6bff0d834c1
diff --git a/core/peer/peer.go b/core/peer/peer.go index <HASH>..<HASH> 100644 --- a/core/peer/peer.go +++ b/core/peer/peer.go @@ -209,3 +209,11 @@ type IDSlice []ID func (es IDSlice) Len() int { return len(es) } func (es IDSlice) Swap(i, j int) { es[i], es[j] = es[j], es[i] } func (es IDSlice) Less(i, j int) bool { return string(es[i]) < string(es[j]) } + +func (es IDSlice) String() string { + peersStrings := make([]string, len(es)) + for i, id := range es { + peersStrings[i] = id.String() + } + return strings.Join(peersStrings, ", ") +}
chore: add `String()` method to `IDSlice` type (#<I>)
libp2p_go-libp2p
train
go
acba084abb01b967c239952d49e8e3d7775cbf2c
diff --git a/workflow/util/util.go b/workflow/util/util.go index <HASH>..<HASH> 100644 --- a/workflow/util/util.go +++ b/workflow/util/util.go @@ -505,10 +505,10 @@ func FormulateResubmitWorkflow(wf *wfv1.Workflow, memoized bool) (*wfv1.Workflow // Append an additional label so it's easy for user to see the // name of the original workflow that has been resubmitted. newWF.ObjectMeta.Labels[common.LabelKeyPreviousWorkflowName] = wf.ObjectMeta.Name + if newWF.ObjectMeta.Annotations == nil { + newWF.ObjectMeta.Annotations = make(map[string]string) + } for key, val := range wf.ObjectMeta.Annotations { - if newWF.ObjectMeta.Annotations == nil { - newWF.ObjectMeta.Annotations = make(map[string]string) - } newWF.ObjectMeta.Annotations[key] = val }
fix: Avoid unnecessary nil check for annotations of resubmitted workflow (#<I>)
argoproj_argo
train
go
530767d85d85b5932abdb87721e395c0a214b148
diff --git a/examples/browser-exchange-files/public/app.js b/examples/browser-exchange-files/public/app.js index <HASH>..<HASH> 100644 --- a/examples/browser-exchange-files/public/app.js +++ b/examples/browser-exchange-files/public/app.js @@ -294,7 +294,7 @@ async function refreshPeerList () { if (addr.indexOf('/p2p/') >= 0) { return addr } else { - return addr + peer.peer + return addr + '/p2p/' + peer.peer } } })
docs: add /p2p/ to add addresses on display (#<I>)
ipfs_js-ipfs
train
js
c84decaa48e1270d7042bfc2f4e806b616db28f0
diff --git a/bin/jack.js b/bin/jack.js index <HASH>..<HASH> 100644 --- a/bin/jack.js +++ b/bin/jack.js @@ -603,8 +603,9 @@ Much more documentation available at: https://www.node-tap.org/ ts: flag({ default: process.env.TAP_TS === '1', - description: `Automatically load .ts and .tsx tests with tap's bundled - ts-node module (Default: false)`, + description: `Automatically load .ts and .tsx tests ts-node module. + Note: you must provide ts-node as a dependency yourself, tap does + not automatically bundle it. (Default: false)`, }), jsx: flag({
docs: ts-node is not bundled
tapjs_node-tap
train
js
65cdf9de7bb7cbdaa7bda94d4464af06dae09ba8
diff --git a/lib/deps/graph.js b/lib/deps/graph.js index <HASH>..<HASH> 100644 --- a/lib/deps/graph.js +++ b/lib/deps/graph.js @@ -259,9 +259,9 @@ Graph.prototype.getEdgeAttribut = function(name) { Graph.prototype.to_dot = function() { var dotScript = ''; if (this.relativeGraph == null) { - dotScript = this.type + ' ' + this.id + ' {\n'; + dotScript = this.type + ' "' + this.id + '" {\n'; } else { - dotScript = 'subgraph ' + this.id + ' {\n'; + dotScript = 'subgraph "' + this.id + '" {\n'; } // Graph attributs
fix: escape graph id without this fix: `graphviz.digraph('my-id');` would produce `digraph my-id {` which is invalid, instead it should produce `digraph "my-id" {`
glejeune_node-graphviz
train
js
fa57348835ea7f130248c9952910b13308a65e99
diff --git a/test/cluster/net.go b/test/cluster/net.go index <HASH>..<HASH> 100644 --- a/test/cluster/net.go +++ b/test/cluster/net.go @@ -39,6 +39,15 @@ func createBridge(name, network, natIface string) (*Bridge, error) { if err != nil { return nil, err } + + // We need to explicitly assign the MAC address to avoid it changing to a lower value + // See: https://github.com/flynn/flynn/issues/223 + b := random.Bytes(5) + mac := fmt.Sprintf("fe:%02x:%02x:%02x:%02x:%02x", b[0], b[1], b[2], b[3], b[4]) + if err := netlink.NetworkSetMacAddress(iface, mac); err != nil { + return nil, err + } + if err := netlink.NetworkLinkAddIp(iface, ipAddr, ipNet); err != nil { return nil, err }
test: Ensure that the bridge MAC does not fluctuate This is the fix for #<I>, we forgot to apply it here.
flynn_flynn
train
go
64faa9fd61909d0a3a07b64b223c17f0f7f63c25
diff --git a/tests/test_coalaip.py b/tests/test_coalaip.py index <HASH>..<HASH> 100644 --- a/tests/test_coalaip.py +++ b/tests/test_coalaip.py @@ -29,7 +29,7 @@ def test_generate_user(mock_plugin, mock_coalaip, alice_user): **generate_user_kwargs) -@mark.parametrize('data_format', [(''), ('json'), ('jsonld')]) +@mark.parametrize('data_format', [None, 'json', 'jsonld']) def test_register_manifestation(mock_plugin, mock_coalaip, manifestation_data_factory, alice_user, data_format, mock_work_create_id, @@ -255,9 +255,9 @@ def test_register_manifestation_raises_on_creation_error( user=alice_user) -@mark.parametrize('data_format', [(''), ('json'), ('jsonld')]) -def test_derive_right(mock_plugin, mock_coalaip, right_data_factory, alice_user, - data_format, mock_copyright_create_id, +@mark.parametrize('data_format', [None, 'json', 'jsonld']) +def test_derive_right(mock_plugin, mock_coalaip, right_data_factory, + alice_user, data_format, mock_copyright_create_id, mock_right_create_id): mock_plugin.save.return_value = mock_right_create_id
style(tests): small stylistic changes for parametrized tests
COALAIP_pycoalaip
train
py
31d22320522c6413861275937620a5529769cbd1
diff --git a/index.test.js b/index.test.js index <HASH>..<HASH> 100644 --- a/index.test.js +++ b/index.test.js @@ -102,7 +102,7 @@ describe('Webpack rails manifest plugin', () => { module: { loaders: [{ test: /\.(txt|png)$/, - loader: 'file' + loader: 'file-loader' }] } }); @@ -130,7 +130,7 @@ describe('Webpack rails manifest plugin', () => { module: { loaders: [{ test: /\.(txt|png)$/, - loader: 'file' + loader: 'file-loader' }] } });
test(webpack2): ensure compatibility with webpack <I>-beta<I>
infinum_webpack-asset-pipeline
train
js
26683389ea2df30f7b3f9c2522f0ea7197c0bc9b
diff --git a/src/browser-polyfill.js b/src/browser-polyfill.js index <HASH>..<HASH> 100644 --- a/src/browser-polyfill.js +++ b/src/browser-polyfill.js @@ -8,12 +8,7 @@ if (typeof browser === "undefined") { const CHROME_SEND_MESSAGE_CALLBACK_NO_RESPONSE_MESSAGE = "The message port closed before a response was received."; - const SEND_RESPONSE_DEPRECATION_WARNING = ` - Returning a Promise is the preferred way to send a reply from an - onMessage/onMessageExternal listener, as the sendResponse will be - removed from the specs (See - https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/runtime/onMessage) - `.replace(/\s+/g, " ").trim(); + const SEND_RESPONSE_DEPRECATION_WARNING = "Returning a Promise is the preferred way to send a reply from an onMessage/onMessageExternal listener, as the sendResponse will be removed from the specs (See https://developer.mozilla.org/docs/Mozilla/Add-ons/WebExtensions/API/runtime/onMessage)"; // Wrapping the bulk of this polyfill in a one-time-use function is a minor // optimization for Firefox. Since Spidermonkey does not fully parse the
chore: Replace post-processed warning message with single-line string literal (#<I>)
mozilla_webextension-polyfill
train
js
dfd2d036756e48d4da4c55491ebc44985f28b643
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -512,6 +512,9 @@ exports.extend = function(newConf) { config.INADDR_ANY = true; } }); + if (config.networkMode) { + config.rulesMode = false; + } } if (newConf.guestName === '-' && !newConf.guestPassword) { config.guest = {};
feat: networkMode > rulesMode
avwo_whistle
train
js
2c435fc8bb923bf6311e53660bca741b90be2dfd
diff --git a/src/NPC.js b/src/NPC.js index <HASH>..<HASH> 100644 --- a/src/NPC.js +++ b/src/NPC.js @@ -34,9 +34,17 @@ export default class NPC { } } _convertFieldValue (value) { + if (typeof value === 'undefined') { + return ''; + } if (typeof value === 'string') { return value; } + if (Array.isArray('value')) { + return value.map((el) => { + return this._convertFieldValue(el); + }); + } if (value instanceof RandomTableResultSet || value instanceof RandomTableResult || value instanceof TableErrorResult ||
fix(npc): Fix for unserialization to account for undefined
derikb_rpg-table-randomizer
train
js
4d2951899331620cceb3f747f4fd402309ee2478
diff --git a/intranet/apps/emerg/views.py b/intranet/apps/emerg/views.py index <HASH>..<HASH> 100644 --- a/intranet/apps/emerg/views.py +++ b/intranet/apps/emerg/views.py @@ -28,7 +28,12 @@ def check_emerg(): timeout = settings.FCPS_EMERGENCY_TIMEOUT - r = requests.get("{}?{}".format(settings.FCPS_EMERGENCY_PAGE, int(time.time() // 60)), timeout=timeout) + try: + r = requests.get("{}?{}".format(settings.FCPS_EMERGENCY_PAGE, int(time.time() // 60)), timeout=timeout) + except requests.exceptions.Timeout: + return False, None + + res = r.text if not res: status = False
fix(emerg): add exception handling for request timeouts on emergency page
tjcsl_ion
train
py
8e014aa80b2cb546a96a59a5c675cf679f87d05e
diff --git a/lib/components/user/monitored-trip/trip-summary.js b/lib/components/user/monitored-trip/trip-summary.js index <HASH>..<HASH> 100644 --- a/lib/components/user/monitored-trip/trip-summary.js +++ b/lib/components/user/monitored-trip/trip-summary.js @@ -12,7 +12,7 @@ const TripSummary = ({ monitoredTrip }) => { // TODO: use the modern itinerary summary built for trip comparison. return ( <div - className={`otp option default-itin active`} + className={`otp option default-itin`} style={{borderTop: '0px', padding: '0px'}}> <div className='header'> <span className='title'>Itinerary</span>{' '}
fix(TripSummary): Remove green bar outside of batch itinerary results.
opentripplanner_otp-react-redux
train
js
e181fa50186e746d72ea1a622c34079f3c9e4751
diff --git a/src/platforms/mp/runtime/instance/index.js b/src/platforms/mp/runtime/instance/index.js index <HASH>..<HASH> 100644 --- a/src/platforms/mp/runtime/instance/index.js +++ b/src/platforms/mp/runtime/instance/index.js @@ -9,16 +9,22 @@ export * from './render-helpers/render-list' export function initRootVM (mpVM, opt = {}) { const { options, Component, platform } = opt + const { mpType } = options const mpVMOptions = mpVM && mpVM.options || {} const $mp = { platform, - page: mpVM, status: 'load', query: mpVMOptions, options: mpVMOptions, _update: createUpdateFn(mpVM) } + if (mpType === 'app') { + Object.assign($mp, { app: mpVM }) + } else { + Object.assign($mp, { page: mpVM }) + } + Object.assign(options, { $mp }) const rootVM = new Component(options)
fix: rename mpVM in App to "app"
kaola-fed_megalo
train
js
6ea3a8cb063c6370cc6e001a77d540cd5b603899
diff --git a/cli/lib/tasks/install.js b/cli/lib/tasks/install.js index <HASH>..<HASH> 100644 --- a/cli/lib/tasks/install.js +++ b/cli/lib/tasks/install.js @@ -1,4 +1,5 @@ const _ = require('lodash') +const arch = require('arch') const os = require('os') const url = require('url') const path = require('path') @@ -105,7 +106,7 @@ const getBinaryUrlFromPrereleaseNpmUrl = (npmUrl) => { const { version, artifactSlug } = matches.groups - parsed.pathname = `/beta/binary/${version}/${os.platform()}-${os.arch()}/${artifactSlug}/cypress.zip` + parsed.pathname = `/beta/binary/${version}/${os.platform()}-${arch()}/${artifactSlug}/cypress.zip` return parsed.format() }
chore: fixing m1 installation issues for m1 macs (#<I>)
cypress-io_cypress
train
js
0a3a1247563e3ae26e08164d2fba7f1f16ae8c5e
diff --git a/tests/test_config.py b/tests/test_config.py index <HASH>..<HASH> 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -74,3 +74,9 @@ class TestConfigCLI(TestDvc): ret = main(['config', 'global.non_existing_field', '-u']) self.assertEqual(ret, 1) + + ret = main(['config', 'core.remote', 'myremote']) + self.assertEqual(ret, 0) + + ret = main(['config', 'core.non_existing_field', '-u']) + self.assertEqual(ret, 1)
test: cover "Invalid option value" for config
iterative_dvc
train
py
2cf61a1e1777a3862bf3d3df1b7dcf696a4f1ba7
diff --git a/build/tasks/serve.js b/build/tasks/serve.js index <HASH>..<HASH> 100644 --- a/build/tasks/serve.js +++ b/build/tasks/serve.js @@ -10,6 +10,7 @@ gulp.task('serve', ['build'], function(done) { var bs = browserSync.create('Sample server'); var options = { + open: false, server: { baseDir: paths.sample, routes: {
chore(sample): keep browserSync from opening automatically
aurelia-ui-toolkits_aurelia-materialize-bridge
train
js
a62445183294a3019ae82b1aa0868d0083031612
diff --git a/integration/combination/test_function_with_s3_bucket.py b/integration/combination/test_function_with_s3_bucket.py index <HASH>..<HASH> 100644 --- a/integration/combination/test_function_with_s3_bucket.py +++ b/integration/combination/test_function_with_s3_bucket.py @@ -1,6 +1,11 @@ +from unittest.case import skipIf + from integration.helpers.base_test import BaseTest +from integration.helpers.resource import current_region_does_not_support +from integration.config.service_names import S3_EVENTS +@skipIf(current_region_does_not_support([S3_EVENTS]), "S3 Events feature is not supported in this testing region") class TestFunctionWithS3Bucket(BaseTest): def test_function_with_s3_bucket_trigger(self): self.create_and_verify_stack("combination/function_with_s3") diff --git a/integration/config/service_names.py b/integration/config/service_names.py index <HASH>..<HASH> 100644 --- a/integration/config/service_names.py +++ b/integration/config/service_names.py @@ -23,3 +23,4 @@ SQS = "SQS" CUSTOM_DOMAIN = "CustomDomain" ARM = "ARM" EFS = "EFS" +S3_EVENTS = "S3Events"
chore: Add capability to disable S3 Events integration test cases. (#<I>) * chore: Add capability to disable S3 Events integration test cases. * fix black issue
awslabs_serverless-application-model
train
py,py
b61d55bde280863741df51fd622ed3b690b6375e
diff --git a/src/commands/build.js b/src/commands/build.js index <HASH>..<HASH> 100644 --- a/src/commands/build.js +++ b/src/commands/build.js @@ -42,14 +42,17 @@ export default asyncCommand({ workers: { description: 'Add a Service Workers to the application.', alias: 'w', + type: 'boolean', default: true }, clean: { description: 'Clear output directory before building.', + type: 'boolean', default: true }, json: { description: 'Generate build statistics for analysis.', + type: 'boolean', default: false } // TODO diff --git a/src/commands/create.js b/src/commands/create.js index <HASH>..<HASH> 100644 --- a/src/commands/create.js +++ b/src/commands/create.js @@ -96,6 +96,7 @@ export default asyncCommand({ }, force: { description: 'Force option to create the directory for the new app', + type: 'boolean', default: false }, yarn: { diff --git a/src/commands/watch.js b/src/commands/watch.js index <HASH>..<HASH> 100644 --- a/src/commands/watch.js +++ b/src/commands/watch.js @@ -20,6 +20,7 @@ export default asyncCommand({ }, nomodule: { description: 'Build ES5 bundle for oldie browsers', + type: 'boolean', default: false }, port: {
fix(cast-boolean): added cast on boolean args
PolymerX_polymerx-cli
train
js,js,js
6f640517466f05dc6a184d0881e29e35d17cabe2
diff --git a/tests/integration/GraphQL/GraphQLQueryTest.php b/tests/integration/GraphQL/GraphQLQueryTest.php index <HASH>..<HASH> 100644 --- a/tests/integration/GraphQL/GraphQLQueryTest.php +++ b/tests/integration/GraphQL/GraphQLQueryTest.php @@ -94,6 +94,6 @@ GRAPHQL; $response = $this->execute($client, $request); $data = json_decode((string)$response->getBody(), true); - $this->assertNotEquals(0, $data['data']['products']['count']); + $this->assertSame(0, $data['data']['products']['count']); } }
test(GraphQL): fix assertion
commercetools_commercetools-php-sdk
train
php
e6f6d6e76f530052264770a3b343048c293673e1
diff --git a/lib/interceptor.js b/lib/interceptor.js index <HASH>..<HASH> 100644 --- a/lib/interceptor.js +++ b/lib/interceptor.js @@ -14,7 +14,7 @@ class RowProcessorInterceptor extends Interceptor { super(endpoint, config); // just validate the config once - parserFactory(config, true); + parserFactory(config.config, true); } static get name() { diff --git a/tests/interceptor_test.js b/tests/interceptor_test.js index <HASH>..<HASH> 100644 --- a/tests/interceptor_test.js +++ b/tests/interceptor_test.js @@ -21,13 +21,15 @@ const stepMock = { }; const checkProperties = { - "namus": { - "fieldType": { - "type": "boolean", - }, - "defaultValue": "false", - "mandatory": true, - "severity": "abort_file" + "config": { + "namus": { + "fieldType": { + "type": "boolean", + }, + "defaultValue": "false", + "mandatory": true, + "severity": "abort_file" + } } };
fix(interceptor): Fix how the config will be given to the underlying module. Adapted the test for this fix.
Kronos-Integration_kronos-interceptor-object-data-processor-row
train
js,js
1d92314f262548b6b24e309943274e0d9d196a41
diff --git a/staging/src/k8s.io/client-go/tools/watch/retrywatcher_test.go b/staging/src/k8s.io/client-go/tools/watch/retrywatcher_test.go index <HASH>..<HASH> 100644 --- a/staging/src/k8s.io/client-go/tools/watch/retrywatcher_test.go +++ b/staging/src/k8s.io/client-go/tools/watch/retrywatcher_test.go @@ -587,11 +587,12 @@ func TestRetryWatcherToFinishWithUnreadEvents(t *testing.T) { watcher.Stop() + maxTime := time.Second select { case <-watcher.Done(): break - case <-time.After(10 * time.Millisecond): - t.Error("Failed to close the watcher") + case <-time.After(maxTime): + t.Errorf("The watcher failed to be closed in %s", maxTime) } // RetryWatcher result channel should be closed
test(watch-tool): deflake TestRetryWatcherToFinishWithUnreadEvents
kubernetes_kubernetes
train
go
be32bcd5e62ea624f2750403b9df0d154a55301f
diff --git a/GEOparse/utils.py b/GEOparse/utils.py index <HASH>..<HASH> 100644 --- a/GEOparse/utils.py +++ b/GEOparse/utils.py @@ -64,7 +64,8 @@ def download_from_url(url, destination_path, try: fn = Downloader( url, - outdir=os.path.dirname(destination_path)) + outdir=os.path.dirname(destination_path), + filename=os.path.basename(destination_path)) if aspera: fn.download_aspera( user="anonftp",
fix: Pass filename to downloader
guma44_GEOparse
train
py
539398416c8a8927b3dc2b60600aacb3258b7ba9
diff --git a/test/plugin/test_out_forward.rb b/test/plugin/test_out_forward.rb index <HASH>..<HASH> 100644 --- a/test/plugin/test_out_forward.rb +++ b/test/plugin/test_out_forward.rb @@ -1294,7 +1294,13 @@ EOL begin chunk = Fluent::Plugin::Buffer::MemoryChunk.new(Fluent::Plugin::Buffer::Metadata.new(nil, nil, nil)) - mock.proxy(d.instance).socket_create_tcp(TARGET_HOST, TARGET_PORT, linger_timeout: anything, send_timeout: anything, recv_timeout: anything, connect_timeout: anything) { |sock| mock(sock).close.once; sock }.twice + mock.proxy(d.instance).socket_create_tcp(TARGET_HOST, TARGET_PORT, + linger_timeout: anything, + send_timeout: anything, + recv_timeout: anything, + connect_timeout: anything) { |sock| + mock(sock).close.once; sock + }.twice target_input_driver.run(timeout: 15) do d.run(shutdown: false) do
test: out_forward: Break a long line
fluent_fluentd
train
rb
1c27d080dce3e5f79e57344e6b0e07a4d1b04ea5
diff --git a/test/app/index.js b/test/app/index.js index <HASH>..<HASH> 100644 --- a/test/app/index.js +++ b/test/app/index.js @@ -27,7 +27,7 @@ var server = http.createServer().listen(process.env.PORT || 0, function() { function handler(signame) { var signo = process.binding('constants')[signame]; console.log('die on %s (%s)', signame, signo); - process.exit(signo); + process.kill(process.pid, signame); } function exitOn(signame) { diff --git a/test/test-start-stop.js b/test/test-start-stop.js index <HASH>..<HASH> 100644 --- a/test/test-start-stop.js +++ b/test/test-start-stop.js @@ -49,9 +49,9 @@ function pushWithConfig(config, failStatus, callback) { status, signame, signo); // expect runner to use SIGTERM on invalid configuration - // expect app to exit with signal number + // if signame is valid, it will have a signo > 0 - assert.equal(status, signo || constants.SIGTERM); + assert.equal(status, signo ? signame : 'SIGTERM'); return callback(); }); });
test: align app exit status with strong-supervisor test app was converting signals to exit codes, which was fine but when I run the same tests with sl-run, it was exiting by signal not with a status code. app now does as sl-run does, and signal comparison is now done in terms of signal strings, not exit codes.
strongloop_strong-pm
train
js,js
66d2bd75eac21529c89f3b7110d234fb82a97723
diff --git a/packages/driver/src/cypress.js b/packages/driver/src/cypress.js index <HASH>..<HASH> 100644 --- a/packages/driver/src/cypress.js +++ b/packages/driver/src/cypress.js @@ -159,6 +159,10 @@ class $Cypress { initialize ({ $autIframe, onSpecReady }) { this.$autIframe = $autIframe this.onSpecReady = onSpecReady + if (this._onInitialize) { + this._onInitialize() + this._onInitialize = undefined + } } run (fn) { @@ -217,6 +221,17 @@ class $Cypress { this.runner.onScriptError(err) }) .then(() => { + return (new Promise((resolve) => { + if (this.$autIframe) { + resolve() + } else { + // block initialization if the iframe has not been created yet + // Used in CT when async chunks for plugins take their time to download/parse + this._onInitialize = resolve + } + })) + }) + .then(() => { this.cy.initialize(this.$autIframe) this.onSpecReady()
fix(component-testing): wait for iframe to exist to start testing (#<I>) * fix: wait for iframe to exist to start testing * add comment
cypress-io_cypress
train
js
6f3159179f5cefa4aaa3be82550ebfbe986e9bf1
diff --git a/publish.js b/publish.js index <HASH>..<HASH> 100755 --- a/publish.js +++ b/publish.js @@ -415,6 +415,7 @@ function buildNav(members) { if (members.globals.length) { var globalNav = ''; + var useGlobalTitleLink = true; members.globals.forEach(function(g) { if ( !hasOwnProp.call(seen, g.longname) ) { @@ -425,13 +426,14 @@ function buildNav(members) { globalNav += '<li class="hidden">' + linkto(g.longname, g.name) + '</li>'; } else { globalNav += '<li>' + linkto(g.longname, g.name) + '</li>'; + useGlobalTitleLink = false; } } seen[g.longname] = true; }); - if (!globalNav) { + if (!useGlobalTitleLink) { // turn the heading into a link so you can actually get to the global page nav += '<div class="lnb-api hidden"><h3>' + linkto('global', 'Global') + '</h3></div>'; }
feat:set global title link if having only typedefs
nhn_tui.jsdoc-template
train
js
198c5cd59a5e16048eab78e1fcc6182fcdc44ec1
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -7,6 +7,7 @@ const defaults = { }; function syncEvent(node, eventName, newEventHandler) { + const eventNameLc = eventName.toLowerCase(); const eventStore = node.__events || (node.__events = {}); const oldEventHandler = eventStore[eventName]; @@ -17,7 +18,7 @@ function syncEvent(node, eventName, newEventHandler) { // Bind new listener. if (newEventHandler) { - node.addEventListener(eventName, eventStore[eventName] = function handler(e) { + node.addEventListener(eventNameLc, eventStore[eventName] = function handler(e) { newEventHandler.call(this, e); }); }
fix(events): Fix issues causing built-in events to not get fired due to case-sensitivity.
webcomponents_react-integration
train
js
16a282ecb65f8d9141e5ef7bb7333e284649fbd7
diff --git a/DrdPlus/Tables/History/InfluenceOfFortuneTable.php b/DrdPlus/Tables/History/InfluenceOfFortuneTable.php index <HASH>..<HASH> 100644 --- a/DrdPlus/Tables/History/InfluenceOfFortuneTable.php +++ b/DrdPlus/Tables/History/InfluenceOfFortuneTable.php @@ -64,7 +64,7 @@ class InfluenceOfFortuneTable extends AbstractFileTable /** * @param FateCode $fateCode - * @param int $diceRoll + * @param int|IntegerInterface $diceRoll * @return int * @throws \DrdPlus\Tables\History\Exceptions\UnexpectedDiceRoll */
fix: Both property types accept roll as integer interface by annotation
drdplusinfo_tables
train
php
96604fb9a55d3a98282a602ca1dee59b4b921a16
diff --git a/test/index.js b/test/index.js index <HASH>..<HASH> 100644 --- a/test/index.js +++ b/test/index.js @@ -257,7 +257,7 @@ describe('cz-release-me', () => { // question 1 - TYPE expect(getQuestion(1).name).to.equal('type'); expect(getQuestion(1).type).to.equal('list'); - expect(getQuestion(1).choices[0]).to.deep.equal({value: 'feat', name: 'feat: my feat'}); + expect(getQuestion(1).choices[0]).to.deep.equal({value: 'feat', name: '\u001b[33mfeat\u001b[39m (feat: my feat)'}); // chalk.yellow color // question 2 - SCOPE expect(getQuestion(2).name).to.equal('scope');
fix(test): fix for chalk colors
design4pro_cz-release-me
train
js
11d249f82fc782d84d62bb6dba40a8e3047d6df0
diff --git a/src/module.js b/src/module.js index <HASH>..<HASH> 100644 --- a/src/module.js +++ b/src/module.js @@ -26,7 +26,6 @@ export default function NetlifyCmsModule(moduleOptions) { const config = configManager.config; const ADMIN_PATH = config.adminPath; - const EXTENSIONS_DIR = config.extensionsDir; const BUILD_DIR = config.buildDir; // This will be called once when builder started @@ -119,10 +118,7 @@ export default function NetlifyCmsModule(moduleOptions) { }); // Start watching config file - const patterns = [ - Utils.r(configManager.cmsConfigFile.fileName), - Utils.r(EXTENSIONS_DIR) - ]; + const patterns = [Utils.r(configManager.cmsConfigFile.fileName)]; const options = { ...this.options.watchers.chokidar, @@ -131,7 +127,6 @@ export default function NetlifyCmsModule(moduleOptions) { const refreshFiles = _.debounce(() => { configManager.cmsConfigFile.readFile(); - debug(`Rebuilding...`); this.nuxt.renderer.netlifyWebpackDevMiddleware.invalidate(); }, 200);
fix(build): fix various rebuild errors Remove duplicate file watcher on `extensionsDir` Only read user cms config when it changes Greatly improve rebuild time fixes #7, closes #9, fixes #<I>
medfreeman_nuxt-netlify-cms-module
train
js
805f92b529bf4cd8bb77e2f4899c8d9348fbaf01
diff --git a/static/lib/composer/resize.js b/static/lib/composer/resize.js index <HASH>..<HASH> 100644 --- a/static/lib/composer/resize.js +++ b/static/lib/composer/resize.js @@ -27,7 +27,13 @@ define('composer/resize', ['taskbar'], function(taskbar) { } function getBounds() { - var headerRect = header.getBoundingClientRect(); + var headerRect; + if (header) { + headerRect = header.getBoundingClientRect(); + } else { + // Mock data + headerRect = { bottom: 0 }; + } var headerBottom = Math.max(headerRect.bottom, 0);
fix: handle cases where header is not present, by mocking data
NodeBB_nodebb-plugin-composer-default
train
js
6148fd090249e923ba4ea009e3ecba954a345450
diff --git a/v1/tracing/tracing.go b/v1/tracing/tracing.go index <HASH>..<HASH> 100644 --- a/v1/tracing/tracing.go +++ b/v1/tracing/tracing.go @@ -88,7 +88,7 @@ func AnnotateSpanWithSignatureInfo(span opentracing.Span, signature *tasks.Signa span.SetTag("signature.uuid", signature.UUID) if signature.GroupUUID != "" { - span.SetTag("signature.group.uuid", signature.UUID) + span.SetTag("signature.group.uuid", signature.GroupUUID) } if signature.ChordCallback != nil {
fix: wrong groupUUID in task span (#<I>)
RichardKnop_machinery
train
go
0fad106ce39fc27484d9f8f751c6a265f71f5a34
diff --git a/src/components/datepicker/js/datepickerDirective.js b/src/components/datepicker/js/datepickerDirective.js index <HASH>..<HASH> 100644 --- a/src/components/datepicker/js/datepickerDirective.js +++ b/src/components/datepicker/js/datepickerDirective.js @@ -285,6 +285,7 @@ this.calendarPane.id = 'md-date-pane' + $mdUtil.nextUid(); $mdTheming($element); + $mdTheming(angular.element(this.calendarPane)); /** Pre-bound click handler is saved so that the event listener can be removed. */ this.bodyClickHandler = angular.bind(this, this.handleBodyClick);
fix(datepicker): apply theming to the calendar pane The calendar pane wasn't registered with the theming service, causing it to be transparent in certain situations. Fixes #<I>. Closes #<I>
angular_material
train
js
c4d3b3dfb405ea0e1cefae92cc52b18eb8240ccd
diff --git a/lib/workers/branch/index.js b/lib/workers/branch/index.js index <HASH>..<HASH> 100644 --- a/lib/workers/branch/index.js +++ b/lib/workers/branch/index.js @@ -196,6 +196,10 @@ async function processBranch(branchConfig, packageFiles) { logger.debug('Passing repository-changed error up'); throw err; } + if (err.message === 'bad-credentials') { + logger.debug('Passing bad-credentials error up'); + throw err; + } if (err.message === 'lockfile-error') { logger.info('Lock file error'); } else if (err.message !== 'registry-failure') {
refactor: pass bad credentials error from branch to repo
renovatebot_renovate
train
js
86ddd1987cb7fc2d30c179287c96887df7bbba79
diff --git a/src/cache.js b/src/cache.js index <HASH>..<HASH> 100644 --- a/src/cache.js +++ b/src/cache.js @@ -55,7 +55,7 @@ export function get(target, key, getter, validate) { const context = contexts[0]; - if (context && !suspense.has(context)) { + if (context && !suspense.has(context.target)) { context.deps.add(entry); entry.contexts.add(context); } diff --git a/test/spec/cache.js b/test/spec/cache.js index <HASH>..<HASH> 100644 --- a/test/spec/cache.js +++ b/test/spec/cache.js @@ -372,6 +372,17 @@ describe("cache:", () => { expect(spy).toHaveBeenCalledTimes(2); }); + it("disables saving deps", () => { + const getDep = () => get(target, "other", () => "value"); + + suspend(target); + get(target, "key", getDep); + + const entry = getEntry(target, "key"); + + expect(entry.deps.size).toBe(0); + }); + it("disables observe callback", done => { get(target, "key", () => "value"); suspend(target);
fix(cache): use target of entry in suspend condition
hybridsjs_hybrids
train
js,js
00de344318e60f2872e53c35240db92ae6f82727
diff --git a/namesys/namesys.go b/namesys/namesys.go index <HASH>..<HASH> 100644 --- a/namesys/namesys.go +++ b/namesys/namesys.go @@ -86,16 +86,19 @@ func (ns *mpns) Resolve(ctx context.Context, name string, options ...opts.Resolv } func (ns *mpns) ResolveAsync(ctx context.Context, name string, options ...opts.ResolveOpt) <-chan Result { - res := make(chan Result, 1) if strings.HasPrefix(name, "/ipfs/") { p, err := path.ParsePath(name) + res := make(chan Result, 1) res <- Result{p, err} + close(res) return res } if !strings.HasPrefix(name, "/") { p, err := path.ParsePath("/ipfs/" + name) + res := make(chan Result, 1) res <- Result{p, err} + close(res) return res }
fix: close resolve channel before returning it
ipfs_go-ipfs
train
go
3e62ab7c6c042149b9153657cae92523a35f2002
diff --git a/nodes/events-state-changed/events-state-changed.js b/nodes/events-state-changed/events-state-changed.js index <HASH>..<HASH> 100644 --- a/nodes/events-state-changed/events-state-changed.js +++ b/nodes/events-state-changed/events-state-changed.js @@ -34,7 +34,7 @@ module.exports = function (RED) { if (this.nodeConfig.outputinitially) { // Here for when the node is deploy without the server config being deployed - if (this.isConnected) { + if (this.isIntegrationLoaded) { this.onDeploy(); } else { this.addEventClientListener(
fix(events-state): Waiit until HA is running before outputting Fixes #<I>
zachowj_node-red-contrib-home-assistant-websocket
train
js
46cb3a2fefb87fc79dc731e45316e17a56ca29ab
diff --git a/task/backend/bolt/bolt.go b/task/backend/bolt/bolt.go index <HASH>..<HASH> 100644 --- a/task/backend/bolt/bolt.go +++ b/task/backend/bolt/bolt.go @@ -173,7 +173,6 @@ func (s *Store) CreateTask(ctx context.Context, req backend.CreateTaskRequest) ( func (s *Store) UpdateTask(ctx context.Context, req backend.UpdateTaskRequest) (backend.UpdateTaskResult, error) { var res backend.UpdateTaskResult - fmt.Println("here1") op, err := backend.StoreValidator.UpdateArgs(req) if err != nil { return res, err diff --git a/task/backend/store.go b/task/backend/store.go index <HASH>..<HASH> 100644 --- a/task/backend/store.go +++ b/task/backend/store.go @@ -195,9 +195,6 @@ func (t *UpdateTaskRequest) UpdateFlux(oldFlux string) error { tu := platform.TaskUpdate{ Options: t.Options, } - // if t.Script != "" { - // tu.Flux = &t.Script - // } if err := tu.UpdateFlux(oldFlux); err != nil { return err }
chore(task): Clean up comments.
influxdata_influxdb
train
go,go
c8c5ee854de12517a9612127e12df19f55aedc04
diff --git a/src/files.js b/src/files.js index <HASH>..<HASH> 100644 --- a/src/files.js +++ b/src/files.js @@ -70,12 +70,7 @@ module.exports = (common) => { expect(err).to.not.exist expect(res).to.be.length(1) const file = res[0] - expect(file).to.be.eql({ - path: 'data.txt', - size: 17, - hash: expectedMultihash - }) - expect(file).to.eqlk + expect(file).to.exist expect(file.path).to.equal('data.txt') expect(file.size).to.equal(17) expect(file.hash).to.equal(expectedMultihash)
fix(files): remove duplicated expectations
ipfs_interface-js-ipfs-core
train
js
be7f67268d1e25462b7920b84ced317772e84b8c
diff --git a/cmd/disk-cache-backend.go b/cmd/disk-cache-backend.go index <HASH>..<HASH> 100644 --- a/cmd/disk-cache-backend.go +++ b/cmd/disk-cache-backend.go @@ -538,12 +538,15 @@ func (c *diskCache) saveMetadata(ctx context.Context, bucket, object string, met } m.Ranges[rs.String(actualSize)] = rsFileName } - } else { + } + if rs == nil && !incHitsOnly { // this is necessary cleanup of range files if entire object is cached. - for _, f := range m.Ranges { - removeAll(pathJoin(cachedPath, f)) + if _, err := os.Stat(pathJoin(cachedPath, cacheDataFile)); err == nil { + for _, f := range m.Ranges { + removeAll(pathJoin(cachedPath, f)) + } + m.Ranges = nil } - m.Ranges = nil } m.Stat.Size = actualSize m.Stat.ModTime = UTCNow()
fix: Do not cleanup range files in cache SaveMetadata when total hits are false (#<I>)
minio_minio
train
go
10f5e5fd0ae4a19235934ecf9d7966f331d49eca
diff --git a/test/unit/tone-analyzer.v3.test.js b/test/unit/tone-analyzer.v3.test.js index <HASH>..<HASH> 100644 --- a/test/unit/tone-analyzer.v3.test.js +++ b/test/unit/tone-analyzer.v3.test.js @@ -107,7 +107,7 @@ describe('tone', () => { test('should enforce required parameters', done => { // required parameters for this method - const requiredParams = ['tone_input', 'content_type']; + const requiredParams = ['tone_input']; tone_analyzer.tone({}, err => { checkRequiredParamsHandling(requiredParams, err, missingParamsMock, createRequestMock);
test: update unit test for tone analyzer
watson-developer-cloud_node-sdk
train
js
53ae6002bedc3d88cb2ca3d058599742a2c03380
diff --git a/__tests__/monorepo-deps.test.js b/__tests__/monorepo-deps.test.js index <HASH>..<HASH> 100644 --- a/__tests__/monorepo-deps.test.js +++ b/__tests__/monorepo-deps.test.js @@ -24,7 +24,7 @@ function pkgToHaveDependenciesOn(pkgName, deps) { deps.forEach(dep => { if (!listedDeps.some(d => d === dep)) { if (dep !== pkgName) { - if (dep !== '@bolt/global' && dep !== '@bolt/generator-bolt') { + if (dep !== '@bolt/global') { missingDeps.push(dep); } } @@ -53,7 +53,7 @@ expect.extend({ pkgToHaveDependenciesOn }); const boltPkgs = getPkgList(); describe('Bolt Components declare dependencies in package.json if used in Twig files', () => { - const excludedPkgs = ['generator-bolt']; + const excludedPkgs = ['@bolt/generator-bolt']; boltPkgs .filter(boltPkg => !excludedPkgs.includes(boltPkg.name))
fix: update the monorepo Twig dependency test to exclude the renamed Yeoman generator
bolt-design-system_bolt
train
js
8fdf1b5c1783e06eec0c8058e1008ea5b86d5bae
diff --git a/src/ViewableService.php b/src/ViewableService.php index <HASH>..<HASH> 100644 --- a/src/ViewableService.php +++ b/src/ViewableService.php @@ -241,12 +241,12 @@ class ViewableService implements ViewableServiceContract } /** - * Remove all views from a viewable model. + * Remove all views of a viewable model. * * @param \Illuminate\Database\Eloquent\Model $viewable * @return void */ - public function removeModelViews($viewable) + public function deleteViewsFor($viewable) { app(ViewContract::class)->where([ 'viewable_id' => $viewable->getKey(),
feat: rename removeModelViews method in ViewableService
cyrildewit_eloquent-viewable
train
php
40a0f36e4afe159dc4aa374188987dea2bedbb24
diff --git a/src/Common/Controller/Base.php b/src/Common/Controller/Base.php index <HASH>..<HASH> 100644 --- a/src/Common/Controller/Base.php +++ b/src/Common/Controller/Base.php @@ -733,10 +733,7 @@ abstract class Base extends \MX_Controller */ protected function setGlobalJs() { - $oAsset = Factory::service('Asset'); - - // -------------------------------------------------------------------------- - + $oAsset = Factory::service('Asset'); $sCustomJs = appSetting('site_custom_js', 'site'); if (!empty($sCustomJs)) { $oAsset->inline($sCustomJs, 'JS'); @@ -770,6 +767,7 @@ abstract class Base extends \MX_Controller */ protected function setGlobalCss() { + $oAsset = Factory::service('Asset'); $sCustomCss = appSetting('site_custom_css', 'site'); if (!empty($sCustomCss)) { $oAsset->inline($sCustomCss, 'CSS');
fix: Not loading Asset library before loading global CSS
nails_common
train
php
c7bd5f62fa967c36d4e17c2c1a9a20112ff5a239
diff --git a/Plugin/Backend/OrderAfterInvoice.php b/Plugin/Backend/OrderAfterInvoice.php index <HASH>..<HASH> 100644 --- a/Plugin/Backend/OrderAfterInvoice.php +++ b/Plugin/Backend/OrderAfterInvoice.php @@ -64,7 +64,11 @@ class OrderAfterInvoice // Check if payment method is checkout.com if (in_array($methodId, $this->config->getMethodsList())) { if ($this->statusNeedsCorrection($order)) { - $order->setStatus($this->config->getValue('order_status_captured')); + if ($order->getIsVirtual()) { + $order->setStatus('complete'); + } else { + $order->setStatus($this->config->getValue('order_status_captured')); + } } } @@ -84,9 +88,9 @@ class OrderAfterInvoice $desiredStatus = $this->config->getValue('order_status_captured'); $flaggedStatus = $this->config->getValue('order_status_flagged'); - return $currentState == Order::STATE_PROCESSING + return ($currentState == Order::STATE_PROCESSING && $currentStatus !== $flaggedStatus && $currentStatus !== $desiredStatus - && $currentStatus == 'processing'; + && $currentStatus == 'processing') || $order->getIsVirtual(); } }
fix: capture order status comment is set to closed for virtual orders
checkout_checkout-magento2-plugin
train
php
74db15b57c617d274055b6033b709a68dadf20a8
diff --git a/system/Database/OCI8/Forge.php b/system/Database/OCI8/Forge.php index <HASH>..<HASH> 100644 --- a/system/Database/OCI8/Forge.php +++ b/system/Database/OCI8/Forge.php @@ -193,7 +193,7 @@ class Forge extends \CodeIgniter\Database\Forge && version_compare($this->db->getVersion(), '12.1', '>=') ) { - $field['auto_increment'] = ' GENERATED ALWAYS AS IDENTITY'; + $field['auto_increment'] = ' GENERATED BY DEFAULT AS IDENTITY'; } }
fix: Fix to be able to update identity.
codeigniter4_CodeIgniter4
train
php
6597abc7d9b38f524fbf7fa87afd4f9a1e9f8e49
diff --git a/packages/bonde-admin-canary/src/scenes/Auth/scenes/ResetPassword/index.js b/packages/bonde-admin-canary/src/scenes/Auth/scenes/ResetPassword/index.js index <HASH>..<HASH> 100644 --- a/packages/bonde-admin-canary/src/scenes/Auth/scenes/ResetPassword/index.js +++ b/packages/bonde-admin-canary/src/scenes/Auth/scenes/ResetPassword/index.js @@ -35,6 +35,8 @@ export default ({ match }) => ( }) .then(() => { notify(t('resetPassword.success', { user })) + // should redirect with window to rehydrate session + window.location.href = '/' }) }} />
fix(reset-password): add redirect with window.location
nossas_bonde-client
train
js
ee5b29d5af18b6330838a74150063546dee0947e
diff --git a/doc/conf.py b/doc/conf.py index <HASH>..<HASH> 100644 --- a/doc/conf.py +++ b/doc/conf.py @@ -118,8 +118,10 @@ modindex_common_prefix = ['rafcon.'] # A list of warning types to suppress arbitrary warning messages. suppress_warnings = ['ref.python'] -extlinks = {'issue': ('https://rmc-github.robotic.dlr.de/common/rafcon/issues/%s', - 'Issue #')} +extlinks = { + 'issue_ghe': ('https://rmc-github.robotic.dlr.de/common/rafcon/issues/%s', 'Issue #'), + 'issue_gh': ('https://github.com/DLR-RM/RAFCON/issues/%s', 'Issue #') +} # -- Options for HTML output ----------------------------------------------
docs(conf): Distinguish between issues from GitHub and GitHub Enterprise
DLR-RM_RAFCON
train
py