hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
4caba62bb1360fc6ca66ba6a3dde77a81c9d9440
|
diff --git a/packages/building-rollup/modern-and-legacy-config.js b/packages/building-rollup/modern-and-legacy-config.js
index <HASH>..<HASH> 100644
--- a/packages/building-rollup/modern-and-legacy-config.js
+++ b/packages/building-rollup/modern-and-legacy-config.js
@@ -120,6 +120,7 @@ function createConfig(_options, legacy) {
production &&
options.plugins.workbox &&
+ !legacy &&
workbox({
mode: 'generateSW',
workboxConfig: {
|
fix(building-rollup): Generate the SW once with the createCompatibilityConfig (#<I>)
* Generate the SW once with the createCompatibilityConfig
* Update packages/building-rollup/modern-and-legacy-config.js
|
open-wc_open-wc
|
train
|
js
|
4eacdefe876bb482a2be7cbd7436017ac7b20e12
|
diff --git a/packages/ui-heading/src/Heading/index.js b/packages/ui-heading/src/Heading/index.js
index <HASH>..<HASH> 100644
--- a/packages/ui-heading/src/Heading/index.js
+++ b/packages/ui-heading/src/Heading/index.js
@@ -30,6 +30,7 @@ import { ThemeablePropTypes } from '@instructure/ui-themeable'
import { childrenOrValue } from '@instructure/ui-prop-types'
import { getElementType, passthroughProps } from '@instructure/ui-react-utils'
import { testable } from '@instructure/ui-testable'
+
import { withStyle, jsx } from '@instructure/emotion'
import generateStyle from './styles'
|
refactor(ui-heading): removed deprecated `ellipsis` prop
BREAKING CHANGE:
Removed deprecated `ellipsis` prop, use `TruncateText` component child instead.
|
instructure_instructure-ui
|
train
|
js
|
4b86d11c905567527e73d734f4a9f1290dc7b8c7
|
diff --git a/wikitextparser/_comment_bold_italic.py b/wikitextparser/_comment_bold_italic.py
index <HASH>..<HASH> 100644
--- a/wikitextparser/_comment_bold_italic.py
+++ b/wikitextparser/_comment_bold_italic.py
@@ -76,7 +76,7 @@ class Italic(BoldItalic):
False otherwise.
"""
super().__init__(string, _type_to_spans, _span, _type)
- self.end_token: bool = end_token
+ self.end_token = end_token
@property
def _match(self):
@@ -84,7 +84,7 @@ class Italic(BoldItalic):
return ITALIC_FULLMATCH(self.string)
return ITALIC_NOEND_FULLMATCH(self.string)
- def get_italics(self, recursive=True) -> List['Bold']:
+ def get_italics(self, recursive=True) -> List['Italic']:
if not recursive:
return []
return super().get_italics(True)[1:]
|
fix: syntax error in python <I>
variable annotations are not allowed in <I>.
|
5j9_wikitextparser
|
train
|
py
|
a127c688e0b9da7cd15e1bdc997ee273aaa9fcce
|
diff --git a/src/directives/scroll-fire.js b/src/directives/scroll-fire.js
index <HASH>..<HASH> 100644
--- a/src/directives/scroll-fire.js
+++ b/src/directives/scroll-fire.js
@@ -24,19 +24,18 @@ export default {
bind (el, binding) {
let ctx = {
scroll: debounce(() => {
- let containerBottom, elementBottom, fire
+ let containerBottom, elBottom
if (ctx.scrollTarget === window) {
- elementBottom = el.getBoundingClientRect().bottom
- fire = elementBottom < window.innerHeight
+ elBottom = el.getBoundingClientRect().bottom
+ containerBottom = window.innerHeight
}
else {
+ elBottom = offset(el).top + height(el)
containerBottom = offset(ctx.scrollTarget).top + height(ctx.scrollTarget)
- elementBottom = offset(el).top + height(el)
- fire = elementBottom < containerBottom
}
- if (fire) {
+ if (elBottom > 0 && elBottom < containerBottom) {
ctx.scrollTarget.removeEventListener('scroll', ctx.scroll, listenOpts.passive)
ctx.handler(el)
}
|
fix: v-scroll-fire get fired when reload the page #<I>
|
quasarframework_quasar
|
train
|
js
|
03ee38996f6e0edff10bd7d4a661c7f1570db972
|
diff --git a/tests/specs/init.js b/tests/specs/init.js
index <HASH>..<HASH> 100644
--- a/tests/specs/init.js
+++ b/tests/specs/init.js
@@ -172,7 +172,7 @@ test('hoodie.store gets initialized with options.ajax', function (t) {
getApi(state)
var storeAjaxParam = CustomStoreMock.lastCall.args[1]
- t.is(storeAjaxParam.ajax().headers.authorization, 'Bearer session123',
+ t.is(storeAjaxParam.ajax().headers.authorization, 'Session session123',
'sets ajax authorization header')
})
|
test: rename bearer token to session
|
hoodiehq_hoodie-client
|
train
|
js
|
c1dc7fc3179e1b67132fb46187c5f9cdbe631deb
|
diff --git a/src/lib/konnectors.js b/src/lib/konnectors.js
index <HASH>..<HASH> 100644
--- a/src/lib/konnectors.js
+++ b/src/lib/konnectors.js
@@ -127,7 +127,7 @@ export function deleteFolderPermission (cozy, konnector) {
return patchFolderPermission(cozy, konnector)
}
-export function run (cozy, konnector, account, successTimeout = 20 * 1000) {
+export function run (cozy, konnector, account, successTimeout = 60 * 60 * 1000) {
const slug = konnector.attributes ? konnector.attributes.slug : konnector.slug
if (!slug) {
throw new Error('Missing `slug` parameter for konnector')
|
fix: successTimeout must not fire if not explicitly requested
So we set a timeout of 1 hour, way longer than the server timeout
|
cozy_cozy-home
|
train
|
js
|
77f73f76dfdff7f60182455d2ac139b2fe39ac5c
|
diff --git a/src/util/dom.js b/src/util/dom.js
index <HASH>..<HASH> 100644
--- a/src/util/dom.js
+++ b/src/util/dom.js
@@ -4,7 +4,7 @@
*/
export const domArray = (target, document) => {
if (typeof target === 'string') return Array.from(document.querySelectorAll(target))
- if (target instanceof HTMLElement) return [target]
+ if (target.tagName) return [target]
if (target.jquery) return target.toArray()
if (Array.isArray(target)) return target
return []
@@ -17,7 +17,7 @@ export const domArray = (target, document) => {
*/
export const domSelector = (target, document) => {
if (typeof target === 'string') return document.querySelector(target)
- if (target instanceof HTMLElement) return target
+ if (target.tagName) return target
if (target.jquery) return target[0]
return target
}
|
fix: Make the domArray and domSelector compatible with different windows
|
livingdocsIO_editable.js
|
train
|
js
|
932dbfca28b5c879f1c3b9a5329849afe2601c45
|
diff --git a/webapps/camunda-webapp/webapp/src/main/webapp/assets/vendor/cabpmn/Renderer.js b/webapps/camunda-webapp/webapp/src/main/webapp/assets/vendor/cabpmn/Renderer.js
index <HASH>..<HASH> 100644
--- a/webapps/camunda-webapp/webapp/src/main/webapp/assets/vendor/cabpmn/Renderer.js
+++ b/webapps/camunda-webapp/webapp/src/main/webapp/assets/vendor/cabpmn/Renderer.js
@@ -321,7 +321,7 @@ define([ "dojox/gfx", "jquery" ], function (gfx, $) {
var currentLine = textLines[i];
if (/^[\n\r]+$/.test(currentLine)) {
- currentLine = currentLine.replace(/\n|\r/g, "");
+ currentLine = '';
}
var tempWordGroup = renderText(currentLine);
|
fix(lineBreak): Replace line break with space
related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
js
|
db8257578336c7a5cc63ebc99fbdff44b7aac80c
|
diff --git a/pgjdbc/src/main/java/org/postgresql/util/PGPropertyServiceParser.java b/pgjdbc/src/main/java/org/postgresql/util/PGPropertyServiceParser.java
index <HASH>..<HASH> 100644
--- a/pgjdbc/src/main/java/org/postgresql/util/PGPropertyServiceParser.java
+++ b/pgjdbc/src/main/java/org/postgresql/util/PGPropertyServiceParser.java
@@ -116,9 +116,8 @@ public class PGPropertyServiceParser {
String resourceName = OSUtil.getUserConfigRootDirectory();
if (OSUtil.isWindows()) {
resourceName += "postgresql" + File.separator;
- } else {
- resourceName += ".";
}
+ resourceName += ".";
resourceName += pgServceConfFileDefaultName;
if (new File(resourceName).canRead()) {
LOGGER.log(Level.FINE, "Value [{0}] selected because file exist in user home directory", new Object[]{resourceName});
|
fix: default file name is ".pg_service.conf" on Windows (not "pg_service.conf") (#<I>)
|
pgjdbc_pgjdbc
|
train
|
java
|
86d8cdf5391d9feb2ab0ea4125a6b3c2e4d03b8b
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -8,7 +8,10 @@ var gulp = require('gulp');
gulp.task('default', ['jshint', 'karma']);
gulp.task('serve', ['dist', 'continuousMode']);
-gulp.task('dist', ['clean:dist', 'uglify']);
+gulp.task('dist', ['clean:dist', 'uglify'], function(){
+ return gulp.src('*.css', { cwd: './src' })
+ .pipe(gulp.dest('./dist'));
+});
|
fix(gulp): copy *.css files to the dist
|
angular-ui_ui-layout
|
train
|
js
|
37cc09c4b2ae68813a53d6d704daf45771c2d3c2
|
diff --git a/shinken/daemon.py b/shinken/daemon.py
index <HASH>..<HASH> 100644
--- a/shinken/daemon.py
+++ b/shinken/daemon.py
@@ -349,7 +349,7 @@ class Daemon(object):
try:
pid = int(self.fpid.read())
except:
- logger.warning("Stale pidfile exists (no or invalid or unreadable content). Reusing it.")
+ logger.info("Stale pidfile exists (no or invalid or unreadable content). Reusing it.")
return
try:
|
fix: no need for a warning on a simple restart.
|
Alignak-monitoring_alignak
|
train
|
py
|
15ffd962bfedbaa4614d61b91f0d9fbcaa28594e
|
diff --git a/lib/sandbox.js b/lib/sandbox.js
index <HASH>..<HASH> 100644
--- a/lib/sandbox.js
+++ b/lib/sandbox.js
@@ -594,6 +594,7 @@ Sandbox.prototype.updateWebtask = function (options, cb) {
*
* @param {Object} options - Options
* @param {String} [options.container] - Set the webtask container. Defaults to the profile's container.
+ * @param {Boolean} [options.fetch_code] - Include the webtask's code in the listing response.
* @param {Function} [cb] - Optional callback function for node-style callbacks.
* @return {Promise} A Promise that will be fulfilled with an array of Webtasks
*/
@@ -614,12 +615,18 @@ Sandbox.prototype.listWebtasks = function (options, cb) {
request.query({ meta: m + ':' + options.meta[m] });
}
}
+ if (options.fetch_code) request.query({ fetch_code: true });
var self = this;
var promise = this.issueRequest(request)
.get('body')
.map(function (webtask) {
- return new Webtask(self, webtask.token, { name: webtask.name, meta: webtask.meta, webtask_url: webtask.webtask_url });
+ return new Webtask(self, webtask.token, {
+ code: webtask.code,
+ name: webtask.name,
+ meta: webtask.meta,
+ webtask_url: webtask.webtask_url,
+ });
});
return cb ? promise.nodeify(cb) : promise;
|
feat: Allow fetching code when listing webtasks
|
auth0_sandboxjs
|
train
|
js
|
3a9139e21274708ac56c9b1175892db54e25be73
|
diff --git a/lib/player.js b/lib/player.js
index <HASH>..<HASH> 100644
--- a/lib/player.js
+++ b/lib/player.js
@@ -6574,6 +6574,7 @@ shaka.Player.SRC_EQUAL_EXTENSIONS_TO_MIME_TYPES_ = {
'mpg': 'video/mpeg',
'mpeg': 'video/mpeg',
'm3u8': 'application/x-mpegurl',
+ 'mpd': 'application/dash+xml',
'mp3': 'audio/mpeg',
'aac': 'audio/aac',
'flac': 'audio/flac',
|
fix: Add DASH MIME type mapping for src= playback (#<I>)
|
google_shaka-player
|
train
|
js
|
ab3c543089b0fde4107fc0e579c19f85e0a4ee79
|
diff --git a/lib/plugins/package/lib/packageService.js b/lib/plugins/package/lib/packageService.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/package/lib/packageService.js
+++ b/lib/plugins/package/lib/packageService.js
@@ -6,6 +6,7 @@ const globby = require('globby');
const _ = require('lodash');
const micromatch = require('micromatch');
const ServerlessError = require('../../../serverless-error');
+const parseS3URI = require('../../aws/utils/parse-s3-uri');
module.exports = {
defaultExcludes: [
@@ -77,6 +78,7 @@ module.exports = {
return;
}
if (functionObject.package.artifact) {
+ if (parseS3URI(functionObject.package.artifact)) return;
try {
await fsp.access(
path.resolve(this.serverless.serviceDir, functionObject.package.artifact)
@@ -109,6 +111,7 @@ module.exports = {
await Promise.all(packagePromises);
if (shouldPackageService) {
if (this.serverless.service.package.artifact) {
+ if (parseS3URI(this.serverless.service.package.artifact)) return;
try {
await fsp.access(
path.resolve(this.serverless.serviceDir, this.serverless.service.package.artifact)
|
fix(Packaging): Fix `package.artifact` validation for S3 urls
|
serverless_serverless
|
train
|
js
|
42178e72c98b18e77a50c6818dbd23a9d9baac00
|
diff --git a/lib/platform/github/index.js b/lib/platform/github/index.js
index <HASH>..<HASH> 100644
--- a/lib/platform/github/index.js
+++ b/lib/platform/github/index.js
@@ -1005,8 +1005,18 @@ async function createBranch(branchName, sha) {
if (config.forkToken) {
options.token = config.forkToken;
}
- await get.post(`repos/${config.repository}/git/refs`, options);
- config.branchList.push(branchName);
+ try {
+ config.branchList.push(branchName);
+ await get.post(`repos/${config.repository}/git/refs`, options);
+ } catch (err) /* istanbul ignore next */ {
+ if (err.statusCode === 422) {
+ logger.warn('Branch already existed? Attempting update instead');
+ await updateBranch(branchName, sha);
+ } else {
+ logger.debug('Unknown error creating branch');
+ throw err;
+ }
+ }
}
// Internal: Updates an existing branch to new commit sha
|
fix: catch errors creating branches and try update instead (github)
|
renovatebot_renovate
|
train
|
js
|
f36e981b41a41981ff1c8dc97f014bb6098d7e0b
|
diff --git a/lib/selenium-webdriver/webdriver.js b/lib/selenium-webdriver/webdriver.js
index <HASH>..<HASH> 100644
--- a/lib/selenium-webdriver/webdriver.js
+++ b/lib/selenium-webdriver/webdriver.js
@@ -305,7 +305,7 @@ webdriver.WebDriver.prototype.takeScreenshot = function() {};
/**
* Used to switch WebDriver's focus to a frame or window (e.g. an alert, an
- * iframe, another window).
+ * iframe, another window).
*
* See [WebDriver's TargetLocator Docs](http://seleniumhq.github.io/selenium/docs/api/javascript/module/selenium-webdriver/lib/webdriver_exports_TargetLocator.html)
* for more information.
@@ -553,7 +553,7 @@ webdriver.WebElement.prototype.getCssValue = function(cssStyleProperty) {};
*
* @example
* var foo = element(by.id('foo'));
- * expect(foo.getAttribute(class)).toEqual('bar');
+ * expect(foo.getAttribute('class')).toEqual('bar');
*
* @param {string} attributeName The name of the attribute to query.
* @returns {!webdriver.promise.Promise.<?string>} A promise that will be
|
docs(webdriver): Add missing quotes in getAttribute doc. (#<I>)
In getAttibute function documentation :
`expect(foo.getAttribute(class))...` was written.
This got me confused when getting a class attribute.
I just added quotes around the class word showing class as a string
and not a variable.
Close #<I>
|
angular_protractor
|
train
|
js
|
8ae4af3d4ba16365faf6fb3b0b88c518ccfe0da9
|
diff --git a/src/index.spec.js b/src/index.spec.js
index <HASH>..<HASH> 100644
--- a/src/index.spec.js
+++ b/src/index.spec.js
@@ -1,7 +1,11 @@
import pluginTester from 'babel-plugin-tester';
import path from 'path';
+import fs from 'fs';
import captainsLog from './index';
+const loadFromFile = filePath =>
+ fs.readFileSync(path.resolve(__dirname, filePath), 'utf8');
+
pluginTester({
plugin: captainsLog,
snapshot: true,
@@ -76,7 +80,7 @@ pluginTester({
`,
{
title: 'Method options',
- fixture: path.resolve(__dirname, './__fixtures__/method-check/code.js'),
+ code: loadFromFile('./__fixtures__/method-check/code.js'),
pluginOptions: {
methods: ['debug', 'log', 'info'],
},
|
chore(tests): fixed issue wtih CI built tests
|
kwelch_babel-plugin-captains-log
|
train
|
js
|
aef0db1398f771fe94ddb5c1e4f6a72fb387ca3c
|
diff --git a/pywal/sequences.py b/pywal/sequences.py
index <HASH>..<HASH> 100644
--- a/pywal/sequences.py
+++ b/pywal/sequences.py
@@ -45,7 +45,7 @@ def create_sequences(colors, vte_fix=False):
# Special colors.
# Source: https://goo.gl/KcoQgP
- # 10 = foreground, 11 = background, 12 = cursor foregound
+ # 10 = foreground, 11 = background, 12 = cursor foreground
# 13 = mouse foreground, 708 = background border color.
sequences.extend([
set_special(10, colors["special"]["foreground"], "g"),
|
docs: Fix simple typo, foregound -> foreground
There is a small typo in pywal/sequences.py.
Should read `foreground` rather than `foregound`.
|
dylanaraps_pywal
|
train
|
py
|
e95294b2110311882f3a9680b6b886f7da2b5582
|
diff --git a/src/directives/formly-field.js b/src/directives/formly-field.js
index <HASH>..<HASH> 100644
--- a/src/directives/formly-field.js
+++ b/src/directives/formly-field.js
@@ -168,7 +168,8 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
}
formControl.$render();
- formControl.$setUntouched();
+ // REMOVE UNDEFINED CHECK WHEN DROPPING ANGULAR 1.2 SUPPORT
+ formControl.$setUntouched && formControl.$setUntouched();
formControl.$setPristine();
// To prevent breaking change requiring a digest to reset $viewModel
|
fix(formly-field): Skip if it doesn't exist (Angular <I>)
closes #<I>
|
formly-js_angular-formly
|
train
|
js
|
b097fc614696167fec537d5de49ba6718247cf1f
|
diff --git a/keys.js b/keys.js
index <HASH>..<HASH> 100644
--- a/keys.js
+++ b/keys.js
@@ -69,11 +69,10 @@ function generateKeyPair (pub, prv) {
pub
])
} catch (e) {
- console.log(
+ throw new Error(
'Failed to generate keys using OpenSSL. Please ensure you have OpenSSL ' +
'installed and configured on your system.'
)
- process.exit(1)
}
}
@@ -103,12 +102,11 @@ function loadKeypairs (recurse) {
this.generate()
keys = this.loadKeypairs(false)
- // if the keys still can't be loaded, kill the process
+ // if the keys still can't be loaded, throw an error
if (!keys) {
- console.log(
+ throw new Error(
'Unable to read the token-signing key pair from ' + this.directory
)
- process.exit(1)
}
}
|
refactor: Throw errors instead of killing process
The app using this library should make the determination whether or not and when to kill the process.
|
anvilresearch_connect-keys
|
train
|
js
|
6f0e0e68b5cb185bd840a00009d535d52bc2dbf4
|
diff --git a/views/js/controller/Delivery/monitoring.js b/views/js/controller/Delivery/monitoring.js
index <HASH>..<HASH> 100644
--- a/views/js/controller/Delivery/monitoring.js
+++ b/views/js/controller/Delivery/monitoring.js
@@ -480,7 +480,7 @@ define([
* @returns {Boolean}
*/
function canDo(what, delivery) {
- if (delivery && delivery.state.status) {
+ if (delivery && delivery.state && delivery.state.status) {
const status = _status.getStatusByCode(delivery.state.status);
const isAllowed = _.isFunction(status.can[what]) ?status.can[what](delivery) : status.can[what];
|
chore(monitoring): check that a state is always provided within a delivery
|
oat-sa_extension-tao-proctoring
|
train
|
js
|
0dcfbbe1abc3fa948d6bf38566671d4011e3e66e
|
diff --git a/lib/workers/branch/index.js b/lib/workers/branch/index.js
index <HASH>..<HASH> 100644
--- a/lib/workers/branch/index.js
+++ b/lib/workers/branch/index.js
@@ -306,6 +306,15 @@ async function processBranch(branchConfig, prHourlyLimitReached, packageFiles) {
logger.debug('Throwing bad credentials');
throw new Error('bad-credentials');
}
+ if (
+ err.message &&
+ err.message.startsWith(
+ 'ssh_exchange_identification: Connection closed by remote host'
+ )
+ ) {
+ logger.debug('Throwing bad credentials');
+ throw new Error('bad-credentials');
+ }
if (err.message === 'bad-credentials') {
logger.debug('Passing bad-credentials error up');
throw err;
|
fix(gitFs): catch and throw ssh error
|
renovatebot_renovate
|
train
|
js
|
aafc37a4390a5048e33df7f0e5a3f38b0abfdd9e
|
diff --git a/sqlalchemy_enum34.py b/sqlalchemy_enum34.py
index <HASH>..<HASH> 100644
--- a/sqlalchemy_enum34.py
+++ b/sqlalchemy_enum34.py
@@ -53,7 +53,10 @@ class Enum(TypeDecorator, SchemaType):
return self._enum_class[value] if value else None
return self._enum_class(value) if value else None
- if _sqlalchemy_version < (1, 4, 4):
+ if (
+ (1, 4, 0) <= _sqlalchemy_version < (1, 4, 4) or
+ _sqlalchemy_version < (1, 3, 24)
+ ):
def _set_parent(self, column):
self.impl._set_parent(column)
|
fix: the compatible version ranges for SQLAlchemy
|
spoqa_sqlalchemy-enum34
|
train
|
py
|
253d3758a52e1254be4a9cf4ddfca3d895581b38
|
diff --git a/src/static/vendorItems.js b/src/static/vendorItems.js
index <HASH>..<HASH> 100644
--- a/src/static/vendorItems.js
+++ b/src/static/vendorItems.js
@@ -121,7 +121,6 @@ module.exports = {
// Random single merchants
19676: {type: 'gold', quantity: 1, cost: 10000, npcs: [{name: 'Rojan the Penitent', position: 'Frostgorge Sound [C]'}]},
- 19678: {type: 'badge-of-honor', quantity: 1, cost: 500, npcs: [{name: 'Battle Master', position: 'Red/Green/Blue Borderlands, Eternal Battlegrounds'}]},
66902: {type: 'geode', quantity: 1, cost: 9, npcs: [{name: 'Geode merchant (Dusk, Gleam, Kiena, Moonglow)', position: 'Dry Top'}]},
67007: {type: 'pristine-fractal-relic', quantity: 1, cost: 5, npcs: [{name: 'BUY-4373', position: 'Mistlock Observatory'}]},
37050: {type: 'fractal-relic', quantity: 1, cost: 1350, npcs: [{name: 'BUY-4373', position: 'Mistlock Observatory'}]},
|
fix(vendor-items): Remove Gift of Battle, it can't be bought anymore
Closes gw2efficiency/issues#<I>
|
gw2efficiency_recipe-calculation
|
train
|
js
|
85cd2cbc3f0101fccea38c7849229f5739c5e7b0
|
diff --git a/sdam/topology.js b/sdam/topology.js
index <HASH>..<HASH> 100644
--- a/sdam/topology.js
+++ b/sdam/topology.js
@@ -86,7 +86,7 @@ class Topology extends EventEmitter {
description: new TopologyDescription(
topologyType,
serverDescriptions,
- options.replicaset,
+ options.replicaSet,
null,
null,
options
@@ -384,8 +384,8 @@ Topology.prototype.destroy = deprecate(
);
function topologyTypeFromSeedlist(seedlist, options) {
- if (seedlist.length === 1 && !options.replicaset) return TopologyType.Single;
- if (options.replicaset) return TopologyType.ReplicaSetNoPrimary;
+ if (seedlist.length === 1 && !options.replicaSet) return TopologyType.Single;
+ if (options.replicaSet) return TopologyType.ReplicaSetNoPrimary;
return TopologyType.Unknown;
}
|
refactor(topology): expect non-normalized option name
|
mongodb_node-mongodb-native
|
train
|
js
|
1d5695d2a6c5b2bed27328c9b2bb356d7bcc5688
|
diff --git a/src/Extension/ShopConfigExtension.php b/src/Extension/ShopConfigExtension.php
index <HASH>..<HASH> 100644
--- a/src/Extension/ShopConfigExtension.php
+++ b/src/Extension/ShopConfigExtension.php
@@ -112,7 +112,7 @@ class ShopConfigExtension extends DataExtension
$countries = self::config()->iso_3166_country_codes;
asort($countries);
if ($allowed = $this->owner->AllowedCountries) {
- $allowed = explode(',', $allowed);
+ $allowed = json_decode($allowed);
if (count($allowed) > 0) {
$countries = array_intersect_key($countries, array_flip($allowed));
}
|
fix(ShopConfigExtension): update method for parsing AllowedCountries into array (SS4 stores using json_encode)
|
silvershop_silvershop-core
|
train
|
php
|
699d29183385628cd1f9b3cbeeb501543511069d
|
diff --git a/packages/cozy-konnector-libs/src/helpers/cozy-client-js-stub.js b/packages/cozy-konnector-libs/src/helpers/cozy-client-js-stub.js
index <HASH>..<HASH> 100644
--- a/packages/cozy-konnector-libs/src/helpers/cozy-client-js-stub.js
+++ b/packages/cozy-konnector-libs/src/helpers/cozy-client-js-stub.js
@@ -14,6 +14,9 @@ if (fs.existsSync(FIXTURE_PATH)) {
}
module.exports = {
+ fetchJSON () {
+ Promise.resolve({})
+ },
data: {
create (doctype, item) {
log('info', item, `creating ${doctype}`)
@@ -115,9 +118,6 @@ module.exports = {
fs.mkdirSync(finalPath)
resolve()
})
- },
- fetchJSON () {
- Promise.resolve({})
}
}
}
|
fix: put fetchJSON in the right place
|
konnectors_libs
|
train
|
js
|
e21c185153b8e70d5d30cfd8e398cb5ac1581a6f
|
diff --git a/build/pre-publish.js b/build/pre-publish.js
index <HASH>..<HASH> 100644
--- a/build/pre-publish.js
+++ b/build/pre-publish.js
@@ -119,6 +119,7 @@ const compileWorkList = [
logLabel: 'extension ts -> js-esm',
compilerOptionsOverride: {
module: 'ES2015',
+ declaration: false,
rootDir: extensionSrcDir,
outDir: extensionESMDir
},
|
chore: not export declarations on the extension build
|
apache_incubator-echarts
|
train
|
js
|
743a31d206e92b3944402409880eeafdfdfd4135
|
diff --git a/pkg/cmd/cli/cmd/set/env.go b/pkg/cmd/cli/cmd/set/env.go
index <HASH>..<HASH> 100644
--- a/pkg/cmd/cli/cmd/set/env.go
+++ b/pkg/cmd/cli/cmd/set/env.go
@@ -329,7 +329,7 @@ func RunEnv(f *clientcmd.Factory, in io.Reader, out, errout io.Writer, cmd *cobr
}
mapper, typer := f.Object()
- b := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), kapi.Codecs.UniversalDecoder()).
+ b := resource.NewBuilder(mapper, typer, resource.ClientMapperFunc(f.ClientForMapping), f.Decoder(false)).
ContinueOnError().
NamespaceParam(cmdNamespace).DefaultNamespace().
FilenameParam(explicit, &resource.FilenameOptions{Recursive: false, Filenames: filenames}).
|
fix: versioned objects in 'oc set env' by default
|
openshift_origin
|
train
|
go
|
3f8b219554ef609c1a85aceb9d6e959cb4f01209
|
diff --git a/dht_net.go b/dht_net.go
index <HASH>..<HASH> 100644
--- a/dht_net.go
+++ b/dht_net.go
@@ -23,7 +23,7 @@ import (
)
var dhtReadMessageTimeout = time.Minute
-var dhtStreamIdleTimeout = 10 * time.Minute
+var dhtStreamIdleTimeout = 1 * time.Minute
var ErrReadTimeout = fmt.Errorf("timed out reading response")
// The Protobuf writer performs multiple small writes when writing a message.
|
feat: reduce stream idle timeout to 1m
It's currently <I> minutes. This change will kill all inbound DHT streams that
haven't been used in 1 minute.
We keep streams around to avoid the cost of setting up new streams (the
multistream overhead, mostly). However, each one of these takes at least one
goroutine and some other state.
Ideally, this will let us run multiple DHTs side-by-side without keeping one
stream per peer per DHT open.
|
libp2p_go-libp2p-kad-dht
|
train
|
go
|
49ec7c2fac074c0b8d980da2bc56c800e384cda8
|
diff --git a/src/bundler.js b/src/bundler.js
index <HASH>..<HASH> 100644
--- a/src/bundler.js
+++ b/src/bundler.js
@@ -6,7 +6,7 @@ import preset from 'babel-preset-es2015-rollup';
import uglify from 'rollup-plugin-uglify';
function getRollupConfig( metadata, isEs5 ) {
- const banner = `/*! ${metadata.name} v${metadata.version} | (c) ${new Date().getFullYear()} ${metadata.author.name} | ${metadata.license} license (see LICENSE) */`;
+ const banner = `/*! ${metadata.name} v${metadata.version} | (c) ${new Date().getFullYear()} ${metadata.author} | ${metadata.license} license (see LICENSE) */`;
const plugins = [
convertCJS(),
babili( {
|
fix(bundler): always treat author as a string
fixes #6
|
Comandeer_rollup-lib-bundler
|
train
|
js
|
ef223d1e813b19dc7e8cc8d6c9ad4d72d4a22cb1
|
diff --git a/packages/d3fc-data-join/src/dataJoin.js b/packages/d3fc-data-join/src/dataJoin.js
index <HASH>..<HASH> 100644
--- a/packages/d3fc-data-join/src/dataJoin.js
+++ b/packages/d3fc-data-join/src/dataJoin.js
@@ -39,7 +39,7 @@ export default (element, className) => {
.append(element)
.attr('class', className);
- const exit = update.exit();
+ let exit = update.exit();
// automatically merge in the enter selection
update = update.merge(enter);
@@ -51,7 +51,7 @@ export default (element, className) => {
enter.style('opacity', effectivelyZero)
.transition(transition)
.style('opacity', 1);
- exit.transition(transition)
+ exit = exit.transition(transition)
.style('opacity', effectivelyZero)
.remove();
} else {
|
fix: expose the exit transition (rather than the selection)
|
d3fc_d3fc
|
train
|
js
|
2eb140d3e3176a5ebb18ab7b43dea12cf5fb3e1a
|
diff --git a/test/callback.js b/test/callback.js
index <HASH>..<HASH> 100644
--- a/test/callback.js
+++ b/test/callback.js
@@ -26,6 +26,27 @@ describe('Callback', function () {
assert.strictEqual(null, func())
})
+ it('should throw an Error when invoked after the callback gets garbage collected', function () {
+ var cb = ffi.Callback('void', [ ], function () {})
+
+ // register the callback function
+ bindings.set_cb(cb)
+
+ // should be ok
+ bindings.call_cb()
+
+ cb = null // KILL!!
+ gc()
+
+ // should throw an Error synchronously
+ try {
+ bindings.call_cb()
+ assert(false) // shouldn't get here
+ } catch (e) {
+ assert(/ffi/.test(e.message))
+ }
+ })
+
describe('async', function () {
it('should be invokable asynchronously by an ffi\'d ForeignFunction', function (done) {
@@ -112,14 +133,6 @@ describe('Callback', function () {
cb = null // KILL!!
gc()
- // should throw an Error directly
- try {
- bindings.call_cb()
- assert(false) // shouldn't get here
- } catch (e) {
- assert(/ffi/.test(e.message))
- }
-
// should generate an "uncaughtException" asynchronously
bindings.call_cb_async()
})
|
test: put the sync callback GC test in its own test
Rather than the "async" one
|
node-ffi-napi_node-ffi-napi
|
train
|
js
|
af556080e3487d531f5fc3056cd50f60c151c308
|
diff --git a/src/core/components/pubsub.js b/src/core/components/pubsub.js
index <HASH>..<HASH> 100644
--- a/src/core/components/pubsub.js
+++ b/src/core/components/pubsub.js
@@ -1,6 +1,7 @@
'use strict'
const promisify = require('promisify-es6')
+const setImmediate = require('async/setImmediate')
module.exports = function pubsub (self) {
return {
@@ -31,7 +32,7 @@ module.exports = function pubsub (self) {
return Promise.resolve()
}
- process.nextTick(() => callback())
+ setImmediate(() => callback())
},
publish: promisify((topic, data, callback) => {
|
fix: use async/setImmediate vs process.nextTick
|
ipfs_js-ipfs
|
train
|
js
|
990d8105b368dbf600971e400065abcee7f39484
|
diff --git a/packages/optimizer/spec/valid-amp/ValidAmpSpec.js b/packages/optimizer/spec/valid-amp/ValidAmpSpec.js
index <HASH>..<HASH> 100644
--- a/packages/optimizer/spec/valid-amp/ValidAmpSpec.js
+++ b/packages/optimizer/spec/valid-amp/ValidAmpSpec.js
@@ -21,7 +21,7 @@ const {writeFileSync} = require('fs');
const {DomTransformer} = require('../../lib/DomTransformer.js');
-const ampOptimizer = new DomTransformer({validAmp: true});
+const ampOptimizer = new DomTransformer();
const files = getResources(join(__dirname, 'files')).filter((f) => f.endsWith('.html'));
|
fix: no need validAMP (#<I>)
|
ampproject_amp-toolbox
|
train
|
js
|
091e5f5f29636130a77df61a4339d191fd630299
|
diff --git a/watch.go b/watch.go
index <HASH>..<HASH> 100644
--- a/watch.go
+++ b/watch.go
@@ -160,8 +160,8 @@ func watch(c *cli.Context, service *update.Service, out *tabwriter.Writer) {
updateCheck, err := fetchUpdateCheck(server, appID, groupID, clientID, version, debug)
if err != nil {
- fmt.Fprintf(os.Stderr, err.Error())
- os.Exit(1)
+ log.Printf("warning: update check failed (%v)\n", err)
+ continue
}
if updateCheck.Status == "noupdate" {
|
fix(watch): only log warning on update check failure
|
coreos_updateservicectl
|
train
|
go
|
517f12fcfdfdd38c0ed8127ae4407e2bc6a7b457
|
diff --git a/internal/fasttime/fasttime.go b/internal/fasttime/fasttime.go
index <HASH>..<HASH> 100644
--- a/internal/fasttime/fasttime.go
+++ b/internal/fasttime/fasttime.go
@@ -1,4 +1,4 @@
-// +build !windows
+//go:build !windows
// Package fasttime gets wallclock time, but super fast.
package fasttime
@@ -10,12 +10,12 @@ import (
// Forked from https://github.com/sethvargo/go-limiter
//go:noescape
-//go:linkname walltime runtime.walltime
-func walltime() (int64, int32)
+//go:linkname now time.now
+func now() (sec int64, nsec int32, mono int64)
// Now returns a monotonic clock value. The actual value will differ across
// systems, but that's okay because we generally only care about the deltas.
func Now() uint64 {
- x, y := walltime()
- return uint64(x)*1e9 + uint64(y)
+ sec, nsec, _ := now()
+ return uint64(sec)*1e9 + uint64(nsec)
}
diff --git a/internal/fasttime/fasttime_windows.go b/internal/fasttime/fasttime_windows.go
index <HASH>..<HASH> 100644
--- a/internal/fasttime/fasttime_windows.go
+++ b/internal/fasttime/fasttime_windows.go
@@ -1,4 +1,4 @@
-// +build windows
+//go:build windows
package fasttime
|
fix(fasttime): Format files and merge changes made on upstream codebase.
Link: <URL>
|
ulule_limiter
|
train
|
go,go
|
208bc97e624ccf2aff6ffe2cf36725050ea9c1e2
|
diff --git a/test/spec.js b/test/spec.js
index <HASH>..<HASH> 100644
--- a/test/spec.js
+++ b/test/spec.js
@@ -6,18 +6,16 @@ var should = require('should');
var sinon = require('sinon');
var optionale = require('../src/optionale').optionale;
-describe('optional', function() {
- describe('require', function() {
- describe('called with the name of an unavailable package', function() {
- it('should return undefined', function() {
- should(optionale('invalid-package')).have.type('undefined');
- });
+describe('optionale', function() {
+ describe('called with the name of an unavailable package', function() {
+ it('should return undefined', function() {
+ should(optionale('invalid-package')).have.type('undefined');
});
+ });
- describe('called with the name of an available package', function () {
- it('should return it', function() {
- optionale('util').should.not.have.type('undefined');
- });
+ describe('called with the name of an available package', function () {
+ it('should return it', function() {
+ optionale('util').should.not.have.type('undefined');
});
});
});
|
refactor(tests): simplify spec
|
javiercejudo_optionale
|
train
|
js
|
43f56b1101ad50ef5af2edb889284af27c30b73a
|
diff --git a/lib/rules/index.js b/lib/rules/index.js
index <HASH>..<HASH> 100644
--- a/lib/rules/index.js
+++ b/lib/rules/index.js
@@ -1,6 +1,7 @@
var Pac = require('node-pac');
var Rules = require('./rules');
var util = require('../util');
+var logger = require('../util/logger');
var rules = new Rules();
var pacRules = new Rules();
var cachedPacs = {};
@@ -64,6 +65,7 @@ function getProxy(url, req, callback) {
}
}
callback();
+ logger.error(err);
});
}
|
chore: Log the error of finding proxy from pac
|
avwo_whistle
|
train
|
js
|
7e0dfbb046c7b25cc19730c17b3f994a9cad6237
|
diff --git a/src/Illuminate/Cache/MemcachedStore.php b/src/Illuminate/Cache/MemcachedStore.php
index <HASH>..<HASH> 100755
--- a/src/Illuminate/Cache/MemcachedStore.php
+++ b/src/Illuminate/Cache/MemcachedStore.php
@@ -49,7 +49,7 @@ class MemcachedStore extends TaggableStore implements Store
/**
* Retrieve an item from the cache by key.
*
- * @param string|array $key
+ * @param string $key
* @return mixed
*/
public function get($key)
|
fix: doc (#<I>)
|
laravel_framework
|
train
|
php
|
d2a003da89d8a7034cba76e7f3c97ead88ada71a
|
diff --git a/test/helper-async.js b/test/helper-async.js
index <HASH>..<HASH> 100644
--- a/test/helper-async.js
+++ b/test/helper-async.js
@@ -146,6 +146,7 @@ function queued(t) {
var newT = {
queue: queue,
waiton: partial(addStep, queue, waiton, t),
+ wait: partial(addStep, queue, wait, t),
expect: partial(addStep, queue, expect, t),
failon: partial(addStep, queue, failon, t),
shutdown: partial(runTests, queue, t),
@@ -235,6 +236,11 @@ function waiton(t, extra, cmd, pattern, next) {
}
}
+function wait(t, extra, time, reason, next) {
+ t.ok(true, fmt('%dms pause: %', time, reason));
+ setTimeout(next, time);
+}
+
function failon(t, extra, cmd, pattern, next) {
var name = fmt('pmctl %j !~ %s', cmd, new RegExp(pattern));
console.log('# START failon %s', name);
|
test: add wait to async test helper
|
strongloop_strong-pm
|
train
|
js
|
cb3850ad88d1d957eaa3b61327119228a277949d
|
diff --git a/tooling/lib/build.js b/tooling/lib/build.js
index <HASH>..<HASH> 100644
--- a/tooling/lib/build.js
+++ b/tooling/lib/build.js
@@ -44,6 +44,8 @@ exports.buildPackage = async function buildPackage(packageName) {
exports.buildSamples = async function buildSamples() {
await rimraf(`packages/node_modules/samples/bundle*`);
+ // reminder: samples:build calls this script, not webpack, hence we must call
+ // webpack here
await exec(`webpack`);
await rename(`bundle.js`, `packages/node_modules/samples/bundle.js`);
await rename(`bundle.js.map`, `packages/node_modules/samples/bundle.js.map`);
|
style(tooling): add note for why we can't shell out to npm scripts
|
webex_spark-js-sdk
|
train
|
js
|
6f4b8cea7114313da831b5586b733461c76e9d35
|
diff --git a/lib/git_diff_parser/version.rb b/lib/git_diff_parser/version.rb
index <HASH>..<HASH> 100644
--- a/lib/git_diff_parser/version.rb
+++ b/lib/git_diff_parser/version.rb
@@ -1,3 +1,3 @@
module GitDiffParser
- VERSION = '2.1.2'
+ VERSION = '2.1.3-beta'
end
|
chore(app): bump development version to <I>-beta
|
packsaddle_ruby-git_diff_parser
|
train
|
rb
|
2f4d3be303677f2496899297739277e771d70446
|
diff --git a/public/app/features/panellinks/linkSrv.js b/public/app/features/panellinks/linkSrv.js
index <HASH>..<HASH> 100644
--- a/public/app/features/panellinks/linkSrv.js
+++ b/public/app/features/panellinks/linkSrv.js
@@ -70,6 +70,7 @@ function (angular, kbn, _) {
else if (link.dashUri) {
info.href = 'dashboard/' + link.dashUri + '?';
info.title = templateSrv.replace(link.title || '');
+ info.target = link.targetBlank ? '_blank' : '';
}
else {
info.title = templateSrv.replace(link.title || '');
|
fix(panellinks): fixed open in new tab issue for dashboard links, Fixes #<I>
|
grafana_grafana
|
train
|
js
|
ea3916eaef3bcc0b2df6b36b849a46254767d828
|
diff --git a/alot/command.py b/alot/command.py
index <HASH>..<HASH> 100644
--- a/alot/command.py
+++ b/alot/command.py
@@ -28,11 +28,7 @@ import mimetypes
from email.parser import Parser
from email import Charset
from email.header import Header
-from email import encoders
from email.message import Message
-from email.mime.audio import MIMEAudio
-from email.mime.base import MIMEBase
-from email.mime.image import MIMEImage
from email.mime.text import MIMEText
from email.mime.multipart import MIMEMultipart
import urwid
@@ -845,7 +841,8 @@ class EnvelopeSendCommand(Command):
name = None
helper.attach(sig, mail, filename=name)
else:
- ui.notify('could not locate signature: %s' % sig, priority='error')
+ ui.notify('could not locate signature: %s' % sig,
+ priority='error')
if not ui.choice('send without signature') == 'yes':
return
diff --git a/alot/helper.py b/alot/helper.py
index <HASH>..<HASH> 100644
--- a/alot/helper.py
+++ b/alot/helper.py
@@ -87,7 +87,7 @@ def attach(path, mail, filename=None):
part.set_payload(fp.read())
fp.close()
# Encode the payload using Base64
- encoders.encode_base64(part)
+ email.encoders.encode_base64(part)
# Set the filename parameter
if not filename:
filename = os.path.basename(path)
|
fix: issue with encoders in helper.attach
|
pazz_alot
|
train
|
py,py
|
5affcbfade539bb77ff72825c9c633f8a820bfea
|
diff --git a/packages/build-tools/tasks/task-collections.js b/packages/build-tools/tasks/task-collections.js
index <HASH>..<HASH> 100644
--- a/packages/build-tools/tasks/task-collections.js
+++ b/packages/build-tools/tasks/task-collections.js
@@ -158,8 +158,12 @@ async function watch() {
config = config || await getConfig();
try {
- const watchTasks = [
- ];
+ const watchTasks = [];
+
+ // if webpackDevServer isn't defined or is disabled, use webpack watch mode instead
+ if (!config.webpackDevServer) {
+ watchTasks.push(webpackTasks.watch());
+ }
switch (config.env) {
case 'pl':
|
fix: update build tools so webpack's watch task is automatically run if webpackDevServer isn't enabled in the .boltrc config
|
bolt-design-system_bolt
|
train
|
js
|
96cf384c272bed81c4368ac50d2e02bd5a79399f
|
diff --git a/allauth/account/adapter.py b/allauth/account/adapter.py
index <HASH>..<HASH> 100644
--- a/allauth/account/adapter.py
+++ b/allauth/account/adapter.py
@@ -407,7 +407,7 @@ class DefaultAccountAdapter(object):
def is_safe_url(self, url):
from django.utils.http import is_safe_url
- return is_safe_url(url)
+ return is_safe_url(url, allowed_hosts=None)
def get_email_confirmation_url(self, request, emailconfirmation):
"""Constructs the email confirmation (activation) url.
|
fix(django): allowed_hosts is now a required argument of is_safe_url
|
pennersr_django-allauth
|
train
|
py
|
e721f25a84e9e3701a2d4d81eddd7ab46fdeb198
|
diff --git a/lib/plugins/load-plugin.js b/lib/plugins/load-plugin.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/load-plugin.js
+++ b/lib/plugins/load-plugin.js
@@ -327,7 +327,7 @@ var customParser = function() {
customParserPending = true;
customParserOpts.body = {
idList: idList,
- frames: framesList.splice(0, 16)
+ frames: framesList.splice(0, 10)
};
requestData(customParserOpts, function(err, result) {
customParserPending = false;
@@ -336,10 +336,10 @@ var customParser = function() {
return retryCustomParser();
}
idList.forEach(function(reqId) {
- var cb = parserCallbacks[reqId];
+ var cb = parserCalretryCustomParserlbacks[reqId];
cb && cb(result[reqId]);
});
- retryCustomParser(200);
+ retryCustomParser(framesList.length> 0 ? 20 : 200);
});
};
|
feat: custom socket data parer by plugin
|
avwo_whistle
|
train
|
js
|
3be73bf18130a1c096673d9024dc061402f6d02e
|
diff --git a/src/bin/repl.js b/src/bin/repl.js
index <HASH>..<HASH> 100644
--- a/src/bin/repl.js
+++ b/src/bin/repl.js
@@ -51,7 +51,7 @@ function assert_return(node) {
}
assert(
- actualRes === expectedRes,
+ actualRes == expectedRes,
`expected ${expectedRes}, ${actualRes} given`
);
} else {
@@ -65,7 +65,6 @@ function invoke(node) {
const [name, ...exprs] = node.args;
// find export in instantiated module
-
const module = instantiatedModules.find(
({ exports }) => exports[name.value] !== undefined
);
|
feat(repl): loose equal in assert_return
|
xtuc_webassemblyjs
|
train
|
js
|
d30a29d9e2f9f48203b286fa64446d8205444193
|
diff --git a/packages/g-base/tests/unit/element-spec.js b/packages/g-base/tests/unit/element-spec.js
index <HASH>..<HASH> 100644
--- a/packages/g-base/tests/unit/element-spec.js
+++ b/packages/g-base/tests/unit/element-spec.js
@@ -179,7 +179,8 @@ describe('test element', () => {
});
element.setClip(null);
- expect(clipShape.destroyed).eqls(true);
+ // setClip 应该只修改 element，不应该修改 clip 本身
+ expect(clipShape.destroyed).eqls(false);
expect(element.getClip()).eqls(null);
});
diff --git a/packages/g-canvas/tests/bugs/issue-218-spec.js b/packages/g-canvas/tests/bugs/issue-218-spec.js
index <HASH>..<HASH> 100644
--- a/packages/g-canvas/tests/bugs/issue-218-spec.js
+++ b/packages/g-canvas/tests/bugs/issue-218-spec.js
@@ -51,7 +51,7 @@ describe('#218', () => {
expect(getColor(context, 150, 160)).eqls('#ff0000');
expect(getColor(context, 150, 190)).eqls('#ff0000');
shape.setClip(null);
- expect(clipShape.get('destroyed')).eqls(true);
+ expect(clipShape.destroyed).eqls(false);
done();
}, 600);
}, 25);
|
fix(g-base): test failed
|
antvis_g
|
train
|
js,js
|
4a931d7c5fc324036dfc6bb3ec379da387f27622
|
diff --git a/test/ut/spec/model/Component.js b/test/ut/spec/model/Component.js
index <HASH>..<HASH> 100755
--- a/test/ut/spec/model/Component.js
+++ b/test/ut/spec/model/Component.js
@@ -35,7 +35,7 @@ describe('Component', function() {
ComponentModel.topologicalTravel(['m1', 'a1', 'a2'], allList, function (componentType, dependencies) {
result.push([componentType, dependencies]);
});
- expect(result).toEqual([['a2', []], ['a1', []], ['m1', ['a1', 'a2']]]);
+ expect(result).toEqual([['a2', ['dataset']], ['a1', ['dataset']], ['m1', ['dataset','a1', 'a2']]]);
});
testCase('topologicalTravel_a1IsAbsent', function (ComponentModel) {
|
refactor(UT): update Component topologicalTravel base test case
|
apache_incubator-echarts
|
train
|
js
|
5fb9092af9fd66d9ccf4763bc2ca80029ec0a3f3
|
diff --git a/src/EloquentBuilderTrait.php b/src/EloquentBuilderTrait.php
index <HASH>..<HASH> 100644
--- a/src/EloquentBuilderTrait.php
+++ b/src/EloquentBuilderTrait.php
@@ -57,6 +57,10 @@ trait EloquentBuilderTrait
$queryBuilder->offset($page*$limit);
}
+ if (isset($distinct)) {
+ $query->distinct();
+ }
+
return $queryBuilder;
}
|
feat: add ability to filter 'distinct' results
Closes esbenp/bruno#<I>
|
esbenp_bruno
|
train
|
php
|
16720a99409efef9983e3cf559c54ea670fafa00
|
diff --git a/packages/webpack/lib/configs/node.js b/packages/webpack/lib/configs/node.js
index <HASH>..<HASH> 100644
--- a/packages/webpack/lib/configs/node.js
+++ b/packages/webpack/lib/configs/node.js
@@ -30,7 +30,7 @@ module.exports = function getConfig(config, name) {
require.resolve('@babel/preset-env'),
{
modules: false,
- useBuiltIns: 'usage',
+ useBuiltIns: 'entry',
targets: { node: config.node },
include: [],
exclude: [],
diff --git a/packages/webpack/lib/shims/server.js b/packages/webpack/lib/shims/server.js
index <HASH>..<HASH> 100644
--- a/packages/webpack/lib/shims/server.js
+++ b/packages/webpack/lib/shims/server.js
@@ -1,4 +1,7 @@
+'use strict';
+
require('source-map-support/register');
+require('@babel/polyfill');
if (module.hot) {
module.hot.accept('@untool/entrypoint');
|
refactor(webpack): simplify node transpilation
switch to entry mode in babel-preset-env for node builds - no need to
limit bundle file size and thus complicate setup
|
untool_untool
|
train
|
js,js
|
13785c583416ed2b2b1eff12f4f78f1a7809f033
|
diff --git a/src/runner.js b/src/runner.js
index <HASH>..<HASH> 100644
--- a/src/runner.js
+++ b/src/runner.js
@@ -265,6 +265,7 @@ Runner.prototype.finish = function finish () {
this.started = false;
this.cancelled = false;
this.emit('finish', this.tasks);
+ this.unbindings();
};
// A task is pending.
|
fix(runner): remove watch leak
|
damonjs_damon
|
train
|
js
|
c6cf6d4655d1ab050787ce9fc8125d00dcab0724
|
diff --git a/pkg/api/common.go b/pkg/api/common.go
index <HASH>..<HASH> 100644
--- a/pkg/api/common.go
+++ b/pkg/api/common.go
@@ -79,7 +79,7 @@ func Json(status int, body interface{}) *NormalResponse {
func ApiSuccess(message string) *NormalResponse {
resp := make(map[string]interface{})
resp["message"] = message
- return Respond(200, resp)
+ return Json(200, resp)
}
func ApiError(status int, message string, err error) *NormalResponse {
|
fix(api): fixed issue with api content-type in api success messages, fixes #<I>
|
grafana_grafana
|
train
|
go
|
61f252f1d2083e5e9f262d0acd72058571e27708
|
diff --git a/workflow/controller/operator_test.go b/workflow/controller/operator_test.go
index <HASH>..<HASH> 100644
--- a/workflow/controller/operator_test.go
+++ b/workflow/controller/operator_test.go
@@ -1548,7 +1548,7 @@ spec:
args: ["cowsay {{inputs.parameters.message}}"]
`
-// TestWorkflowParallelismLimit verifies parallelism at a workflow level is honored.
+// TestWorkflowStepRetry verifies that steps retry will restart from the 0th step
func TestWorkflowStepRetry(t *testing.T) {
cancel, controller := newController()
defer cancel()
|
fix: TestWorkflowStepRetry's comment accurately reflects what it does. (#<I>)
|
argoproj_argo
|
train
|
go
|
1681af4897eeec20c1d1af292f9bfde5b1e9ffc3
|
diff --git a/lib/utils/isStandaloneExecutable.js b/lib/utils/isStandaloneExecutable.js
index <HASH>..<HASH> 100644
--- a/lib/utils/isStandaloneExecutable.js
+++ b/lib/utils/isStandaloneExecutable.js
@@ -1,3 +1,3 @@
'use strict';
-module.exports = Boolean(process.pkg);
+module.exports = Boolean(process.pkg && __dirname.startsWith('/snapshot/'));
|
fix(CLI): Fix standalone detection (case of a fallback from standalone)
|
serverless_serverless
|
train
|
js
|
a4f7e07b3bf2ce297fe8c0898710f88d141ece85
|
diff --git a/src/rest/APIRequest.js b/src/rest/APIRequest.js
index <HASH>..<HASH> 100644
--- a/src/rest/APIRequest.js
+++ b/src/rest/APIRequest.js
@@ -39,7 +39,7 @@ class APIRequest {
if (this.options.headers) headers = Object.assign(headers, this.options.headers);
let body;
- if (this.options.files) {
+ if (this.options.files && this.options.files.length) {
body = new FormData();
for (const file of this.options.files) if (file && file.file) body.append(file.name, file.file, file.name);
if (typeof this.options.data !== 'undefined') body.append('payload_json', JSON.stringify(this.options.data));
|
fix(APIRequest): only use form data when actually sending files (#<I>)
|
discordjs_discord.js
|
train
|
js
|
a35003b59de83b14dae526742187cc13c39196d6
|
diff --git a/packages/node_modules/@cerebral/http/src/DEFAULT_OPTIONS.js b/packages/node_modules/@cerebral/http/src/DEFAULT_OPTIONS.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@cerebral/http/src/DEFAULT_OPTIONS.js
+++ b/packages/node_modules/@cerebral/http/src/DEFAULT_OPTIONS.js
@@ -32,7 +32,8 @@ export default {
if (
result &&
- xhr.getResponseHeader('Content-Type').indexOf('application/json') >= 0
+ (xhr.getResponseHeader('Content-Type') || '')
+ .indexOf('application/json') >= 0
) {
result = JSON.parse(xhr.responseText)
}
|
fix(http): fix error indexOf of undefined, if there are no headers in the server response (#<I>)
|
cerebral_cerebral
|
train
|
js
|
f38ea7006249693199978e3d8afde6f2fe6da8d6
|
diff --git a/src/constants/api.js b/src/constants/api.js
index <HASH>..<HASH> 100644
--- a/src/constants/api.js
+++ b/src/constants/api.js
@@ -7,13 +7,12 @@ const TRANSACTION_APIS = {
};
const TRANSACTION_ID_PLACEHOLDER = '{transaction_id}';
-
const ETHERSCAN_API_KEY = 'FJ3CZWH8PQBV8W5U6JR8TMKAYDHBKQ3B1D';
const TRANSACTIONS_APIS_URLS = {
[TRANSACTION_APIS.Etherscan]: {
- main: `https://api.etherscan.io/api?module=proxy&apikey=${ETHERSCAN_API_KEY}&action=eth_getTransactionByHash&txhash=${TRANSACTION_ID_PLACEHOLDER}`,
- test: `https://api-ropsten.etherscan.io/api?module=proxy&apikey=${ETHERSCAN_API_KEY}&action=eth_getTransactionByHash&txhash=${TRANSACTION_ID_PLACEHOLDER}`
+ main: `https://api.etherscan.io/api?module=proxy&apikey=${ETHERSCAN_API_KEY}`,
+ test: `https://api-ropsten.etherscan.io/api?module=proxy&apikey=${ETHERSCAN_API_KEY}`
}
};
|
chore(ApiConstants): reverted to original etherscan url
|
blockchain-certificates_cert-verifier-js
|
train
|
js
|
cb114bc9869dda19c3ce65f3c5bb266b76409122
|
diff --git a/test/test_framework.go b/test/test_framework.go
index <HASH>..<HASH> 100644
--- a/test/test_framework.go
+++ b/test/test_framework.go
@@ -11,6 +11,8 @@ import (
"syscall"
"testing"
"time"
+
+ "github.com/micro/micro/v2/client/cli/token"
)
const (
@@ -201,6 +203,9 @@ func (s server) launch() {
}
func (s server) close() {
+ // remove the credentials so they aren't reused on next run
+ token.Remove(s.envName)
+
exec.Command("docker", "kill", s.containerName).CombinedOutput()
if s.cmd.Process != nil {
s.cmd.Process.Signal(syscall.SIGKILL)
|
test: remove creds when closing server
|
micro_micro
|
train
|
go
|
ad5d4f4f076b5467cb8e223dfe2c1efc46040131
|
diff --git a/views/cypress/tests/manage-schema.spec.js b/views/cypress/tests/manage-schema.spec.js
index <HASH>..<HASH> 100644
--- a/views/cypress/tests/manage-schema.spec.js
+++ b/views/cypress/tests/manage-schema.spec.js
@@ -125,5 +125,13 @@
it('Remove property from main item class', function() {
cy.removePropertyFromClass(selectors.root, className, newPropertyName, selectors.itemClassForm, selectors.editClass, selectors.classOptions, selectors.editClassUrl);
});
+
+ it('Check removed property is not present in child item anymore', function () {
+ cy.selectNode(selectors.root, selectors.itemClassForm, className);
+ cy.intercept('POST', selectors.editItemUrl).as('editItem');
+ cy.getSettled(`li [title ="${childItemName}"] a`).last().click();
+ cy.wait('@editItem');
+ cy.get(`[data-testid="${newPropertyName}"]`).should('not.exist');
+ });
});
});
|
feat: add check to ensure property is removed in item
|
oat-sa_extension-tao-item
|
train
|
js
|
6b91d58155dfd70cbca1506de6e67760b7405716
|
diff --git a/lib/components/app/responsive-webapp.js b/lib/components/app/responsive-webapp.js
index <HASH>..<HASH> 100644
--- a/lib/components/app/responsive-webapp.js
+++ b/lib/components/app/responsive-webapp.js
@@ -126,13 +126,19 @@ class ResponsiveWebapp extends Component {
// Add on back button press behavior.
window.addEventListener('popstate', handleBackButtonPress)
document.title = title
- if (window.location.search) {
- // If a URL is detected without hash routing (e.g., http://localhost:9966?sessionId=test),
- // window.location.search will have a value. In this case, we need to redirect to the URL root with the
- // search reconstructed for use with the hash router. This redirect should cause little disruption.
- window.location.href = `${URL_ROOT}/#/${window.location.search}`
+
+ // If a URL is detected without hash routing (e.g., http://localhost:9966?sessionId=test),
+ // window.location.search will have a value. In this case, we need to redirect to the URL root with the
+ // search reconstructed for use with the hash router.
+ //
+ // Exception: Do not redirect after auth0 login, which sets the URL in the form
+ // http://localhost:9966/?code=xxxxxxx&state=yyyyyyyyy that we want to preserve.
+ const search = window.location.search
+ if (search && !search.startsWith('?code=')) {
+ window.location.href = `${URL_ROOT}/#/${search}`
return
}
+
if (isMobile()) {
// If on mobile browser, check position on load
getCurrentPosition()
|
fix(ResponsiveWebapp): Do not reformat URL after auth0 login.
|
opentripplanner_otp-react-redux
|
train
|
js
|
a337ff70e200251884d7eee8b8e52c2d440ee2a1
|
diff --git a/src/cModel.js b/src/cModel.js
index <HASH>..<HASH> 100644
--- a/src/cModel.js
+++ b/src/cModel.js
@@ -368,12 +368,12 @@ cModel.prototype.startMotion = function(name, no, priority)
if (this.motions[name] == null)
{
- this.loadMotion(null, this.modelHomeDir + motionName, function(mtn) {
+ this.loadMotion(name, this.modelHomeDir + motionName, function(mtn) {
motion = mtn;
thisRef.setFadeInFadeOut(name, no, priority, motion);
-
+
});
}
else
|
fix: model motion (.mtn) cache
close #4
|
xiazeyu_live2d-widget.js
|
train
|
js
|
21c9f26ea64a7dfc06a96c173c8268d8ad835870
|
diff --git a/lib/Serverless.js b/lib/Serverless.js
index <HASH>..<HASH> 100644
--- a/lib/Serverless.js
+++ b/lib/Serverless.js
@@ -185,8 +185,11 @@ class Serverless {
_isInvokedByGlobalInstallation: true,
});
serverlessLocal.isLocallyInstalled = true;
- // TODO: Remove below assignment with next major
- serverlessLocal.isInvokedByGlobalInstallation = true;
+ if (!serverlessLocal._isInvokedByGlobalInstallation) {
+ // if we fallback to older version it may recognize "isInvokedByGlobalInstallation" instead
+ // of "_isInvokedByGlobalInstallation". Ensure to set it, in such case
+ serverlessLocal.isInvokedByGlobalInstallation = true;
+ }
this.invokedInstance = serverlessLocal;
await serverlessLocal.init();
}
@@ -271,6 +274,16 @@ class Serverless {
logDeprecation(code, message) {
return this._logDeprecation(`EXT_${ensureString(code)}`, ensureString(message));
}
+
+ // If this instance is initialized by older version of the Framework,
+ // it may set "isInvokedByGlobalInstallation" directly.
+ // This fallback ensures it ends at "_isInvokedByGlobalInstallation"
+ set isInvokedByGlobalInstallation(value) {
+ this._isInvokedByGlobalInstallation = value;
+ }
+ get isInvokedByGlobalInstallation() {
+ return this._isInvokedByGlobalInstallation;
+ }
}
module.exports = Serverless;
|
refactor: Patch handling of `isInvokedByGlobalInstallation` flag
|
serverless_serverless
|
train
|
js
|
7bcc49615e54f09c34bae07c994e3be3d870fe1f
|
diff --git a/src/http/api/routes/webui.js b/src/http/api/routes/webui.js
index <HASH>..<HASH> 100644
--- a/src/http/api/routes/webui.js
+++ b/src/http/api/routes/webui.js
@@ -20,7 +20,7 @@ module.exports = (server) => {
method: '*',
path: '/webui',
handler: (request, reply) => {
- return reply().redirect().location('/ipfs/QmPwKAKiPaTXYzqPSctCGnZoNyAjT3gn7AgXcT8TTDofw9')
+ return reply().redirect().location('/ipfs/QmUnXcWZC5Ve21gUseouJsH5mLAyz5JPp8aHsg8qVUUK8e')
}
}
])
|
feat: update Web UI to <I> (#<I>)
|
ipfs_js-ipfs
|
train
|
js
|
36d45d9b98d57493ad9a29efb6a349902383897a
|
diff --git a/superset/charts/commands/importers/v1/__init__.py b/superset/charts/commands/importers/v1/__init__.py
index <HASH>..<HASH> 100644
--- a/superset/charts/commands/importers/v1/__init__.py
+++ b/superset/charts/commands/importers/v1/__init__.py
@@ -89,9 +89,7 @@ class ImportChartsCommand(ImportModelsCommand):
config.update(
{
"datasource_id": dataset.id,
- "datasource_type": "view"
- if dataset.is_sqllab_view
- else "table",
+ "datasource_type": "table",
"datasource_name": dataset.table_name,
}
)
diff --git a/superset/commands/importers/v1/examples.py b/superset/commands/importers/v1/examples.py
index <HASH>..<HASH> 100644
--- a/superset/commands/importers/v1/examples.py
+++ b/superset/commands/importers/v1/examples.py
@@ -138,7 +138,7 @@ class ImportExamplesCommand(ImportModelsCommand):
dataset_info[str(dataset.uuid)] = {
"datasource_id": dataset.id,
- "datasource_type": "view" if dataset.is_sqllab_view else "table",
+ "datasource_type": "table",
"datasource_name": dataset.table_name,
}
|
fix: chart import error with virtual dataset (#<I>)
* fix: chart import error with virtual dataset
* remove unnecessary comment
* resolve comment
|
apache_incubator-superset
|
train
|
py,py
|
3c14816fc15944453e071af7c0de91446b4f0792
|
diff --git a/lmdbscan/scanner.go b/lmdbscan/scanner.go
index <HASH>..<HASH> 100644
--- a/lmdbscan/scanner.go
+++ b/lmdbscan/scanner.go
@@ -1,6 +1,5 @@
/*
Package lmdbscan provides a wrapper for lmdb.Cursor to simplify iteration.
-This package is experimental and it's API may change.
*/
package lmdbscan
|
docs: remove disclaimer about stability from godoc in lmdbscan
|
bmatsuo_lmdb-go
|
train
|
go
|
f78b2ebcc49b21074b4b7e23d82ebdec14477b58
|
diff --git a/lib/spec-helper/spec-helper.js b/lib/spec-helper/spec-helper.js
index <HASH>..<HASH> 100644
--- a/lib/spec-helper/spec-helper.js
+++ b/lib/spec-helper/spec-helper.js
@@ -28,7 +28,7 @@ export default async function (options, setupView) {
}
if (all || options.customMatchers) {
- await install("jasmine2-atom-matchers", "^1.1.2");
+ await install("jasmine2-atom-matchers", "^1.1.3");
}
if (all || options.jasmineJson) {
|
fix(deps): update spec-helper jasmine2-atom-matchers to ^<I> (#<I>)
|
UziTech_atom-jasmine3-test-runner
|
train
|
js
|
50d8bbeaeacbcc86db4ef304e7f7d4d3e979f0a0
|
diff --git a/src/commands/fetch.js b/src/commands/fetch.js
index <HASH>..<HASH> 100644
--- a/src/commands/fetch.js
+++ b/src/commands/fetch.js
@@ -83,15 +83,15 @@ export async function fetch ({
response.progress.pipe(split2(/(\r\n)|\r|\n/)).on('data', line => {
if (emitter) {
emitter.emit(`${emitterPrefix}message`, line.trim())
- }
- let matches = line.match(/([^:]*).*\((\d+?)\/(\d+?)\)/)
- if (matches && emitter) {
- emitter.emit(`${emitterPrefix}progress`, {
- phase: matches[1].trim(),
- loaded: parseInt(matches[2], 10),
- total: parseInt(matches[3], 10),
- lengthComputable: true
- })
+ let matches = line.match(/([^:]*).*\((\d+?)\/(\d+?)\)/)
+ if (matches) {
+ emitter.emit(`${emitterPrefix}progress`, {
+ phase: matches[1].trim(),
+ loaded: parseInt(matches[2], 10),
+ total: parseInt(matches[3], 10),
+ lengthComputable: true
+ })
+ }
}
})
let packfile = await pify(concat)(response.packfile)
|
perf: avoid unnecessary match if emitter is not defined (#<I>)
|
isomorphic-git_isomorphic-git
|
train
|
js
|
ae3b848f13f1ba1294d9d1d59db803dfc2e02d18
|
diff --git a/config/styleguide.config.js b/config/styleguide.config.js
index <HASH>..<HASH> 100644
--- a/config/styleguide.config.js
+++ b/config/styleguide.config.js
@@ -276,18 +276,6 @@ module.exports = {
},
{
name: 'Content',
- sections: [
- {
- name: 'Terms and Conditions',
- components() {
- return [
- path.resolve('packages/TermsAndConditions/TermsAndConditions.jsx'),
- path.resolve('packages/TermsAndConditions/Footnote/Footnote.jsx'),
- path.resolve('packages/TermsAndConditions/FootnoteLink/FootnoteLink.jsx'),
- ]
- },
- },
- ],
components() {
return [
path.resolve('packages/Card/Card.jsx'),
@@ -308,6 +296,16 @@ module.exports = {
]
},
},
+ {
+ name: 'Terms and Conditions',
+ components() {
+ return [
+ path.resolve('packages/TermsAndConditions/TermsAndConditions.jsx'),
+ path.resolve('packages/TermsAndConditions/Footnote/Footnote.jsx'),
+ path.resolve('packages/TermsAndConditions/FootnoteLink/FootnoteLink.jsx'),
+ ]
+ },
+ },
],
},
{
|
chore(config): move TermsAndConditions to its own category styleguidist
|
telus_tds-core
|
train
|
js
|
ef0752e92207945457b480ab8069cb6de6c08f46
|
diff --git a/packages/react/src/components/DatePicker/DatePicker.js b/packages/react/src/components/DatePicker/DatePicker.js
index <HASH>..<HASH> 100644
--- a/packages/react/src/components/DatePicker/DatePicker.js
+++ b/packages/react/src/components/DatePicker/DatePicker.js
@@ -383,10 +383,22 @@ export default class DatePicker extends Component {
}
}
- componentDidUpdate({ dateFormat: prevDateFormat }) {
- const { dateFormat } = this.props;
- if (this.cal && prevDateFormat !== dateFormat) {
- this.cal.set({ dateFormat });
+ componentDidUpdate({
+ dateFormat: prevDateFormat,
+ minDate: prevMinDate,
+ maxDate: prevMaxDate,
+ }) {
+ const { dateFormat, minDate, maxDate } = this.props;
+ if (this.cal) {
+ if (prevDateFormat !== dateFormat) {
+ this.cal.set({ dateFormat });
+ }
+ if (prevMinDate !== minDate) {
+ this.cal.set('minDate', minDate);
+ }
+ if (prevMaxDate !== maxDate) {
+ this.cal.set('maxDate', maxDate);
+ }
}
}
|
fix(DatePicker): explicitly update minDate and maxDate (#<I>)
Since flatpickr does not automatically update minDate and maxDate,
we need to explicitly do it when the user makes any change in the props
by using set(option, value) method from flatpickr
|
carbon-design-system_carbon-components
|
train
|
js
|
0fe2c897ea32b4ce9a2937913ac52cf378cc3647
|
diff --git a/test/tests/unit/mongos/reconnect_tests.js b/test/tests/unit/mongos/reconnect_tests.js
index <HASH>..<HASH> 100644
--- a/test/tests/unit/mongos/reconnect_tests.js
+++ b/test/tests/unit/mongos/reconnect_tests.js
@@ -37,7 +37,8 @@ describe('Reconnect (Mongos)', function() {
beforeEach(() => startServer());
afterEach(() => stopServer());
- it('should not connection swarm when reconnecting', function(done) {
+ // NOTE: skipped due to flakiness and extremely long test runs
+ it.skip('should not connection swarm when reconnecting', function(done) {
const reconnectInterval = 500;
const socketTimeout = reconnectInterval * 5;
const haInterval = reconnectInterval * 10;
|
test(mongos): disable unreliable and long running test case
|
mongodb-js_mongodb-core
|
train
|
js
|
5773ccbeecef92da7a93d89e23893b4af6c8f12f
|
diff --git a/packages/label/src/Label.js b/packages/label/src/Label.js
index <HASH>..<HASH> 100644
--- a/packages/label/src/Label.js
+++ b/packages/label/src/Label.js
@@ -6,9 +6,21 @@ import stylesheet from "./stylesheet";
class Label extends Component {
static propTypes = {
+ /**
+ * Content of the label, including the label text
+ */
children: PropTypes.node,
- disabled: PropTypes.bool, // eslint-disable-line react/no-unused-prop-types
+ /**
+ * Dims label text, signifying the related input or control is disabled
+ */
+ disabled: PropTypes.bool,
+ /**
+ * Reference to the HTML ID of the form element that this label represents
+ */
htmlFor: PropTypes.string,
+ /**
+ * Reference to the HTML ID of the form that contains this label
+ */
form: PropTypes.string
};
|
docs: Add comments to label prop types for docgeninfo
|
Autodesk_hig
|
train
|
js
|
a305bf63da8637c8bdf87112710ea4e5299f437b
|
diff --git a/Gruntfile.js b/Gruntfile.js
index <HASH>..<HASH> 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -30,9 +30,10 @@ module.exports = function(grunt) {
'test/**/*.js'
],
frameworks: ['mocha'],
- plugins: plugins
+ plugins: plugins,
+ //client: {captureConsole: true}
},
- continuous: {
+ single: {
singleRun: true
},
// watch using grunt-watch
@@ -70,6 +71,6 @@ module.exports = function(grunt) {
//Load karma plugin
grunt.loadTasks('tasks');
- grunt.registerTask('test', ['karma:continuous']);
+ grunt.registerTask('test', ['karma:single']);
grunt.registerTask('default', ['test']);
};
|
chore: Rename singleRun task.
|
karma-runner_grunt-karma
|
train
|
js
|
503ed204d822ec6f69732fa95f3b22b3b3e995b6
|
diff --git a/src/Cursor.js b/src/Cursor.js
index <HASH>..<HASH> 100644
--- a/src/Cursor.js
+++ b/src/Cursor.js
@@ -61,7 +61,7 @@ export default class Cursor {
/**
* Take current buffer and rendered buffer at last flush.
* Build difference between them.
- * Difference contains new control codes only, optimizing the rendering perfomance.
+ * Difference contains new control codes only, optimizing the rendering performance.
*
* @returns {Cursor}
*/
|
docs(cursor): Typo fix in comments
|
kittikjs_cursor
|
train
|
js
|
2df8e87d7e3952342c400f200a83cff071ce6eb0
|
diff --git a/src/directives/mwlDroppable.js b/src/directives/mwlDroppable.js
index <HASH>..<HASH> 100644
--- a/src/directives/mwlDroppable.js
+++ b/src/directives/mwlDroppable.js
@@ -11,6 +11,7 @@ angular
}
var DROP_ACTIVE_CLASS = $attrs.dropActiveClass || 'drop-active';
+ var INTERACT_OVERLAP_TYPE = $attrs.dropOverlap || 'pointer';
interact($element[0]).dropzone({
ondragenter: function(event) {
@@ -27,7 +28,8 @@ angular
$parse($attrs.onDrop)($scope, {dropData: event.relatedTarget.dropData});
$scope.$apply();
}
- }
+ },
+ overlap: INTERACT_OVERLAP_TYPE
});
$scope.$on('$destroy', function() {
|
feat(droppable): allow the drop overlap option to be configured
|
mattlewis92_angular-bootstrap-calendar
|
train
|
js
|
33daf5758fc0f1a92d1ab4e493f5b7bef45c58aa
|
diff --git a/src/parser.js b/src/parser.js
index <HASH>..<HASH> 100644
--- a/src/parser.js
+++ b/src/parser.js
@@ -45,15 +45,15 @@ export function getNodeIndex (node) {
* @param {HTMLElement}
*/
export function isVoid (node) {
- return Array.from(node.childNodes).every((child) => {
+ for (const child of node.childNodes) {
if (child.nodeType === nodeType.textNode && !isVoidTextNode(child)) {
return false
}
if (child.nodeType === nodeType.elementNode) {
return false
}
- return true
- })
+ }
+ return true
}
/**
|
chore(parser): Replace complex .every call with for of loop
|
livingdocsIO_editable.js
|
train
|
js
|
2799753bfda62f534a22f6db006f5cda97b50665
|
diff --git a/packages/building-rollup/modern-and-legacy-config.js b/packages/building-rollup/modern-and-legacy-config.js
index <HASH>..<HASH> 100644
--- a/packages/building-rollup/modern-and-legacy-config.js
+++ b/packages/building-rollup/modern-and-legacy-config.js
@@ -68,6 +68,7 @@ function createConfig(_options, legacy) {
// resolve bare import specifiers
resolve({
extensions: options.extensions,
+ moduleDirectory: ['node_modules', 'web_modules']
}),
// run code through babel
diff --git a/packages/building-rollup/modern-config.js b/packages/building-rollup/modern-config.js
index <HASH>..<HASH> 100644
--- a/packages/building-rollup/modern-config.js
+++ b/packages/building-rollup/modern-config.js
@@ -58,6 +58,7 @@ module.exports = function createBasicConfig(_options) {
// resolve bare import specifiers
resolve({
extensions: options.extensions,
+ moduleDirectory: ['node_modules', 'web_modules']
}),
// run code through babel
|
feat(building-rollup): support web-modules
|
open-wc_open-wc
|
train
|
js,js
|
5ce37e56059e4ad27b2d88d191f76483b4af5596
|
diff --git a/src/connection.js b/src/connection.js
index <HASH>..<HASH> 100644
--- a/src/connection.js
+++ b/src/connection.js
@@ -2111,7 +2111,10 @@ Connection.prototype.STATE = {
this.attentionReceived = false;
},
events: {
- socketError: function() {
+ socketError: function(err) {
+ const sqlRequest = this.request;
+ this.request = undefined;
+ sqlRequest.callback(err);
this.transitionTo(this.STATE.FINAL);
},
data: function(data) {
|
fix: forward socket errors to current request in `SENT_ATTENTION` state
|
tediousjs_tedious
|
train
|
js
|
ddcab40d1aaebec9290fec62433d4922c4d90f29
|
diff --git a/src/auth/idToken.js b/src/auth/idToken.js
index <HASH>..<HASH> 100644
--- a/src/auth/idToken.js
+++ b/src/auth/idToken.js
@@ -27,7 +27,7 @@ var DEFAULT_LEEWAY = 60; //default clock-skew, in seconds
* Validator for ID Tokens following OIDC spec.
* @param token the string token to verify
* @param options the options required to run this verification
- * @returns A promise containing the decoded token payload, or throws an exception if validation failed
+ * @returns The decoded token payload, or throws an exception if validation failed
*/
var validate = function(token, options) {
if (!token) {
|
docs: correct `idToken.validate` JSDoc detail (#<I>)
|
auth0_node-auth0
|
train
|
js
|
58f485967bdb6fed86f3e10761634a8d66ba0a27
|
diff --git a/packages/node_modules/@ciscospark/internal-plugin-flag/src/index.js b/packages/node_modules/@ciscospark/internal-plugin-flag/src/index.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@ciscospark/internal-plugin-flag/src/index.js
+++ b/packages/node_modules/@ciscospark/internal-plugin-flag/src/index.js
@@ -19,7 +19,7 @@ registerInternalPlugin('flag', Flag, {
return Promise.resolve(has(response, 'body.multistatus'));
},
extract(response) {
- return Promise.resolve(response.body.multistatus.map((item) => item.data.activity));
+ return Promise.resolve(response.body.multistatus.map((item) => item && item.data && item.data.activity));
}
}
],
|
fix(i-p-flag): handle flag not associated to activity
|
webex_spark-js-sdk
|
train
|
js
|
f5cd8f17c9a6f8106b0de43b2352c348c5772f47
|
diff --git a/lib/components/narrative/line-itin/itin-summary.js b/lib/components/narrative/line-itin/itin-summary.js
index <HASH>..<HASH> 100644
--- a/lib/components/narrative/line-itin/itin-summary.js
+++ b/lib/components/narrative/line-itin/itin-summary.js
@@ -92,7 +92,6 @@ export class ItinerarySummary extends Component {
const timeFormat = use24HourFormat ? 'H:mm' : 'h:mm a'
const {
- centsToString,
maxTNCFare,
minTNCFare,
transitFare
|
refactor(Linting):
|
opentripplanner_otp-react-redux
|
train
|
js
|
7bc56e74f9c71f8827b3a9425ff296a4b163cb11
|
diff --git a/cmd/helm/init.go b/cmd/helm/init.go
index <HASH>..<HASH> 100644
--- a/cmd/helm/init.go
+++ b/cmd/helm/init.go
@@ -75,7 +75,7 @@ func (i *initCmd) run() error {
if !strings.Contains(err.Error(), `"tiller-deploy" already exists`) {
return fmt.Errorf("error installing: %s", err)
}
- fmt.Fprintln(i.out, "Warning: Tiller is already installed in the cluster. (Use --client-only to supress this message.)")
+ fmt.Fprintln(i.out, "Warning: Tiller is already installed in the cluster. (Use --client-only to suppress this message.)")
} else {
fmt.Fprintln(i.out, "\nTiller (the helm server side component) has been installed into your Kubernetes Cluster.")
}
|
fix(cmd): s/supress/suppress/
Suppress is spelled wrong.
Matt did it.
|
helm_helm
|
train
|
go
|
43f690f34bfad84ba4eb7e07439dca422ff4f3db
|
diff --git a/Observers/CustomerAccountObserver.php b/Observers/CustomerAccountObserver.php
index <HASH>..<HASH> 100644
--- a/Observers/CustomerAccountObserver.php
+++ b/Observers/CustomerAccountObserver.php
@@ -35,7 +35,7 @@ class CustomerAccountObserver implements ObserverInterface
$customerId = $observer->getEvent()->getCustomer()->getId();
try {
- $this->customerEventHandler->store('customers/account', $customerId);
+ $this->customerEventHandler->store('customer_account', $customerId);
} catch (\Exception $e) {
$this->logger->warning('Emartech\\Emarsys\\Observers\\CustomerAccountObserver: ' . $e->getMessage());
}
|
fix(customer-account-observer): revert back to event type format SUITEDEV-<I>
|
emartech_magento2-extension
|
train
|
php
|
181d9f3f7e6169453a02289b581c65004f90796f
|
diff --git a/packages/spaces/src/SpacesLink.js b/packages/spaces/src/SpacesLink.js
index <HASH>..<HASH> 100644
--- a/packages/spaces/src/SpacesLink.js
+++ b/packages/spaces/src/SpacesLink.js
@@ -192,6 +192,7 @@ const Link = ({
className={classNames('spaces-hook-link', className, `spaces-${linkStyle}-link`, {
'p-2': linkStyle === 'default',
})}
+ {...rest}
style={{ ...style }}
>
<BodyTag
@@ -219,7 +220,6 @@ const Link = ({
cursor: link?.url ? 'pointer' : 'not-allowed',
}}
{...props}
- {...rest}
aria-label={name}
>
{name}
|
refactor(spaces): move rest back on to Tag
|
Availity_availity-react
|
train
|
js
|
40efb51b9483bc4e0f9fb363869ff9a8e9cdf358
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -39,10 +39,11 @@ setup(
"Development Status :: 5 - Production/Stable",
"Topic :: Scientific/Engineering :: Bio-Informatics",
"License :: OSI Approved :: MIT License",
- "Programming Language :: Python :: 3.5",
"Programming Language :: Python :: 3.6",
"Programming Language :: Python :: 3.7",
"Programming Language :: Python :: 3.8",
+ "Programming Language :: Python :: 3.9",
+ "Programming Language :: Python :: 3.10",
],
entry_points = {
"console_scripts": [
|
chore: update supported versions in setup.py classifiers
deprecate <I>
add support for <I> and <I>
|
neherlab_treetime
|
train
|
py
|
d6de169572c23f77566c122dc4b5e2ce2354990f
|
diff --git a/src/lib/modules/deployment/index.js b/src/lib/modules/deployment/index.js
index <HASH>..<HASH> 100644
--- a/src/lib/modules/deployment/index.js
+++ b/src/lib/modules/deployment/index.js
@@ -52,7 +52,14 @@ class DeployManager {
self.logger.info(__("deploying contracts"));
async.waterfall([
function (next) {
- self.plugins.emitAndRunActionsForEvent("deploy:beforeAll", next);
+ self.logger.info(__('Executing pre-deploy actions...'));
+ self.plugins.emitAndRunActionsForEvent("deploy:beforeAll", (err) => {
+ if (err) {
+ return next(err);
+ }
+ self.logger.info(__('Pre-deploy actions done. Deploying contracts'));
+ next();
+ });
},
function () {
const contractDeploys = {};
|
chore(deployment): add logs to tell about pre-deploy
Otherwise there was a long period of time without any input on what's going on
|
embark-framework_embark
|
train
|
js
|
8518108d67d67fc3945c4e7f180cccffe07c29f8
|
diff --git a/memote/suite/collect.py b/memote/suite/collect.py
index <HASH>..<HASH> 100644
--- a/memote/suite/collect.py
+++ b/memote/suite/collect.py
@@ -45,7 +45,7 @@ class ResultCollectionPlugin(object):
# Seems brittle, can we do better?
_param = re.compile(r"\[(?P<param>[a-zA-Z0-9_.\-]+)\]$")
- def __init__(self, model, experimental_config=None,
+ def __init__(self, model, model_ver, experimental_config=None,
exclusive=None, skip=None, **kwargs):
"""
Collect and store values during testing.
@@ -65,6 +65,7 @@ class ResultCollectionPlugin(object):
"""
super(ResultCollectionPlugin, self).__init__(**kwargs)
self._model = model
+ self._model_ver = model_ver
self._exp_config = experimental_config
self.results = MemoteResult()
self.results.add_environment_information(self.results.meta)
@@ -159,3 +160,11 @@ class ResultCollectionPlugin(object):
"""Provide each test case with a pristine model."""
with self._model as model:
yield model
+
+ @pytest.fixture(scope="session")
+ def model_ver(self):
+ """
+ Provide a tuple of the level, version, and FBC use of the SBML file.
+
+ """
+ return self._model_ver
|
feat: add fixture that stores the SBML level, version and FBC use.
|
opencobra_memote
|
train
|
py
|
8450eff5bd758c8afd6d4b6eac2df983f6e7cc7c
|
diff --git a/packages/posts/sources/tumblr/index.js b/packages/posts/sources/tumblr/index.js
index <HASH>..<HASH> 100644
--- a/packages/posts/sources/tumblr/index.js
+++ b/packages/posts/sources/tumblr/index.js
@@ -103,9 +103,11 @@ class TumblrSource extends CachedDataSource {
// # NOTE-RT: This is pretty gross modifying the HTML we're passing along, but I think this'll be more common than not for other post providers going forwards, especially the more sophisticated platforms.
export const processCaptionHtml = caption => {
- return caption
- .replace(/<p>/g, "<p><span class=\"photo-text\">")
- .replace(/<\/p>/g, "</span></p>");
+ const tags = ["p", "ol", "ul"];
+
+ return tags.reduce((processedCaption, tag) => processedCaption
+ .replace(new RegExp(`<${tag}>`, "g"), `<${tag}><span class="photo-text">`)
+ .replace(new RegExp(`</${tag}>`, "g"), `</span></${tag}>`), caption);
};
export default TumblrSource;
|
fix(posts): `processCaptionHtml` also works on `ol` and `ul` elements.
|
randytarampi_me
|
train
|
js
|
07c8ba102fd6f3a846a46ea86f46b386eeb10692
|
diff --git a/packages/bump/src/bump/hooks.js b/packages/bump/src/bump/hooks.js
index <HASH>..<HASH> 100644
--- a/packages/bump/src/bump/hooks.js
+++ b/packages/bump/src/bump/hooks.js
@@ -187,10 +187,10 @@ export const useBump = ({
const series = useMemo(
() =>
rawSeries.map(serie => {
- serie.color = getColor(serie)
- serie.style = getSerieStyle(serie)
-
- return serie
+ const nextSerie = { ...serie }
+ nextSerie.color = getColor(nextSerie)
+ nextSerie.style = getSerieStyle(nextSerie)
+ return nextSerie
}),
[rawSeries, getColor, getSerieStyle]
)
|
fix(bump): Return a new serie reference when color or styles change
This is the same fix as applied to area-bump in <I>f0de9
Contrary to area-bump, the previous implementation didn't lead to a visible bug, as whenever e.g. someone hovers over the graph, the memoization of the rendering component is broken by another object anyway, hence it doesn't matter that from a React's perspective the series objects are still the same.
Therefore this commit can be seen as a preemptive measure to avoid future problems.
|
plouc_nivo
|
train
|
js
|
152188e19b74c5ad12f8cfa636054e27e16396a3
|
diff --git a/src/utils.js b/src/utils.js
index <HASH>..<HASH> 100644
--- a/src/utils.js
+++ b/src/utils.js
@@ -53,7 +53,7 @@ export function throwInvalidMurmurSeed(seed) {
export function throwInvalidAleaSeed(seed) {
if (seed % 1 !== 0 || seed <= 0) {
throw new TypeError(
- `Expected seed to be an unsigned integer greater 1, but got "${seed}"`
+ `Expected seed to be an unsigned integer greater or equal 1, but got "${seed}"`
);
}
}
|
refactor: throw more explicit error message for alea seed mismatch
|
MartinHelmut_number-generator
|
train
|
js
|
19ef45130b8d3a226500a0ccd69f7d90aaa02430
|
diff --git a/src/structures/Guild.js b/src/structures/Guild.js
index <HASH>..<HASH> 100644
--- a/src/structures/Guild.js
+++ b/src/structures/Guild.js
@@ -144,6 +144,12 @@ class Guild extends Base {
/**
* An array of enabled guild features, here are the possible values:
+ * * ANIMATED_ICON
+ * * COMMERCE
+ * * LURKABLE
+ * * PARTNERED
+ * * NEWS
+ * * BANNER
* * INVITE_SPLASH
* * MORE_EMOJI
* * VERIFIED
|
docs(Guild): add missing features (#<I>)
The addition of missing guild features that were added in the Nitro boost update, such as ANIMATED_ICON
|
discordjs_discord.js
|
train
|
js
|
0cb291b5f3442b666fe08b76f169186ca0742ac6
|
diff --git a/packages/cwp-template-aws/cli/deploy/deploy.js b/packages/cwp-template-aws/cli/deploy/deploy.js
index <HASH>..<HASH> 100644
--- a/packages/cwp-template-aws/cli/deploy/deploy.js
+++ b/packages/cwp-template-aws/cli/deploy/deploy.js
@@ -7,7 +7,7 @@ const deploy = (stack, inputs) => {
return execa(
"webiny",
[
- "stack",
+ "app",
"deploy",
stack,
"--env",
|
fix: replace "stack" with "app"
|
Webiny_webiny-js
|
train
|
js
|
0cacb6cba480efaa8b4c5e9a54e369059e1840d6
|
diff --git a/store/store_test.go b/store/store_test.go
index <HASH>..<HASH> 100644
--- a/store/store_test.go
+++ b/store/store_test.go
@@ -528,6 +528,13 @@ func TestStoreWatchRecursiveCreateWithHiddenKey(t *testing.T) {
s.Create("/foo/_bar", false, "baz", false, Permanent)
e := nbselect(w.EventChan)
assert.Nil(t, e, "")
+ w, _ = s.Watch("/foo", true, false, 0)
+ s.Create("/foo/_baz", true, "", false, Permanent)
+ e = nbselect(w.EventChan)
+ assert.Nil(t, e, "")
+ s.Create("/foo/_baz/quux", false, "quux", false, Permanent)
+ e = nbselect(w.EventChan)
+ assert.Nil(t, e, "")
}
// Ensure that the store can watch for key updates.
|
test(store): exercise watchers receiving notifications of non-hidden keys within hidden directories
|
etcd-io_etcd
|
train
|
go
|
bef9610f6a182e9190fd2bbc36074b2bcb174a4a
|
diff --git a/script/lib/utils.js b/script/lib/utils.js
index <HASH>..<HASH> 100644
--- a/script/lib/utils.js
+++ b/script/lib/utils.js
@@ -40,12 +40,19 @@ async function getCurrentBranch (gitDir) {
let branch = await handleGitCall(['rev-parse', '--abbrev-ref', 'HEAD'], gitDir)
if (branch !== 'master' && !branch.match(/[0-9]+-[0-9]+-x/)) {
const lastCommit = await handleGitCall(['rev-parse', 'HEAD'], gitDir)
- const branches = (await handleGitCall(['branch', '--contains', lastCommit], gitDir)).split('\n')
+ const branches = (await handleGitCall([
+ 'branch',
+ '--contains',
+ lastCommit,
+ '--remote'
+ ], gitDir)).split('\n')
+
branch = branches.filter(b => b === 'master' || b.match(/[0-9]+-[0-9]+-x/))[0]
if (!branch) {
console.log(`${fail} no release branch exists for this ref`)
process.exit(1)
}
+ if (branch.startsWith('origin/')) branch = branch.substr('origin/'.length)
}
return branch.trim()
}
|
chore: account for remotes in branch parsing (#<I>)
|
electron_electron
|
train
|
js
|
e52d71060fa74da81c971f6a88183d3a96a5ee75
|
diff --git a/modules/examples/src/hello_world/index_static.js b/modules/examples/src/hello_world/index_static.js
index <HASH>..<HASH> 100644
--- a/modules/examples/src/hello_world/index_static.js
+++ b/modules/examples/src/hello_world/index_static.js
@@ -217,7 +217,7 @@ function setup() {
});
reflector.registerType(ViewFactory, {
- "factory": (capacity, renderer) =>
+ "factory": (capacity, renderer, appViewHydrator) =>
new ViewFactory(capacity, renderer, appViewHydrator),
"parameters": [[new Inject(VIEW_POOL_CAPACITY)],[Renderer],[AppViewHydrator]],
"annotations": []
|
chore(analysis): fix analyzer warning in index_static
|
angular_angular
|
train
|
js
|
187338f2ba1868570e7f06f8b076dc544a7ae95d
|
diff --git a/packages/text-field/src/__stories__/getKnobs.js b/packages/text-field/src/__stories__/getKnobs.js
index <HASH>..<HASH> 100644
--- a/packages/text-field/src/__stories__/getKnobs.js
+++ b/packages/text-field/src/__stories__/getKnobs.js
@@ -1,5 +1,6 @@
import { action } from "@storybook/addon-actions";
import { boolean, text } from "@storybook/addon-knobs/react";
+import { controlledText } from "@hig/storybook/utils";
const knobGroupIds = {
basic: "Basic",
@@ -86,6 +87,6 @@ export default function getKnobs(props) {
showClearButton,
knobGroupIds.basic
),
- value: text(knobLabels.value, value, knobGroupIds.form)
+ value: controlledText(knobLabels.value, value, knobGroupIds.form)
};
}
|
docs(storybook): correct `value` knob
|
Autodesk_hig
|
train
|
js
|
afaa73717aa78da43f5a1708b521c14dd23bd19e
|
diff --git a/src/proxy.js b/src/proxy.js
index <HASH>..<HASH> 100644
--- a/src/proxy.js
+++ b/src/proxy.js
@@ -150,15 +150,13 @@ function deleteProperty(state, prop) {
}
function getOwnPropertyDescriptor(state, prop) {
- const owner = state.modified
- ? state.copy
- : has(state.drafts, prop)
- ? state.drafts
- : state.base
- const descriptor = Reflect.getOwnPropertyDescriptor(owner, prop)
- if (descriptor && !(Array.isArray(owner) && prop === "length"))
- descriptor.configurable = true
- return descriptor
+ const owner = source(state)
+ const desc = Reflect.getOwnPropertyDescriptor(owner, prop)
+ if (desc) {
+ desc.writable = true
+ desc.configurable = !Array.isArray(owner) || prop !== "length"
+ }
+ return desc
}
function markChanged(state) {
|
fix: property descriptor edge cases
Using the `drafts` object as a source of property descriptors is bad,
because enumerability is not preserved by the `drafts` object.
Thus, we must use `state.base` when `state.copy` is undefined, which
means we need to ensure the property descriptor has a `writable` value
of true. Otherwise, the descriptor would be lying.
|
immerjs_immer
|
train
|
js
|
3818100608423c48b8d6b316e50da865741d2d1e
|
diff --git a/lib/plugin/components/services/statebox/index.js b/lib/plugin/components/services/statebox/index.js
index <HASH>..<HASH> 100644
--- a/lib/plugin/components/services/statebox/index.js
+++ b/lib/plugin/components/services/statebox/index.js
@@ -271,7 +271,8 @@ class StateboxService {
if (!this.services.userInfo) return userId
try {
- return await this.services.userInfo.emailFromUserId(userId)
+ const email = await this.services.userInfo.emailFromUserId(userId)
+ return email || userId
} catch (e) {
return userId
}
|
fix: Further fix on lookup email - return userId if email is empty
|
wmfs_tymly-core
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.