hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
e0e9ba7ce3a1ffee0aa16f99b38b6ac8409bc266
diff --git a/Gemfile.lock b/Gemfile.lock index <HASH>..<HASH> 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - molt (0.1.3) + molt (0.1.4) commander liquid (~> 4.0.0) terminal-table diff --git a/lib/molt/cli/main.rb b/lib/molt/cli/main.rb index <HASH>..<HASH> 100644 --- a/lib/molt/cli/main.rb +++ b/lib/molt/cli/main.rb @@ -20,7 +20,7 @@ module Molt::CLI program :help, "Version", Molt::VERSION default_command :help - global_option("-vv", "--verbose", "Add verbosity where applicable") { $verbose = false } + global_option("--verbose", "Add verbosity where applicable") { $verbose = false } command :setup do |c| c.syntax = 'molt setup' diff --git a/lib/molt/version.rb b/lib/molt/version.rb index <HASH>..<HASH> 100644 --- a/lib/molt/version.rb +++ b/lib/molt/version.rb @@ -1,3 +1,3 @@ module Molt - VERSION = "0.1.3" + VERSION = "0.1.4" end
fix(options): fixed issue in --verbose global option
MarcoCabazal_Molt
train
lock,rb,rb
4a99fbe742b569f4b9d922fd008a69f78c653045
diff --git a/packages/eslint-config-4catalyzer-typescript/rules.js b/packages/eslint-config-4catalyzer-typescript/rules.js index <HASH>..<HASH> 100644 --- a/packages/eslint-config-4catalyzer-typescript/rules.js +++ b/packages/eslint-config-4catalyzer-typescript/rules.js @@ -33,6 +33,8 @@ module.exports = { '@typescript-eslint/no-namespace': 'error', '@typescript-eslint/no-object-literal-type-assertion': 'error', '@typescript-eslint/no-triple-slash-reference': 'error', + 'no-useless-constructor': 'off', + '@typescript-eslint/no-useless-constructor': 'error', 'no-unused-vars': 'off', '@typescript-eslint/no-unused-vars': [ 'error',
feat: no-useless-constructor (#<I>)
4Catalyzer_javascript
train
js
0429f9da62eda044084d68d524f5d4c72e103ec1
diff --git a/src/clappr-dash-shaka-playback.js b/src/clappr-dash-shaka-playback.js index <HASH>..<HASH> 100644 --- a/src/clappr-dash-shaka-playback.js +++ b/src/clappr-dash-shaka-playback.js @@ -97,15 +97,20 @@ class DashShakaPlayback extends HTML5Video { stop () { clearInterval(this.sendStatsId) - this._sendStats() - this._player.unload().then(() => { + if (this._player) { + this._sendStats() + + this._player.unload().then(() => { + super.stop() + this._player = null + this._isShakaReadyState = false + }).catch(() => { + Log.error('shaka could not be unloaded') + }) + } else { super.stop() - this._player = null - this._isShakaReadyState = false - }).catch(() => { - Log.error('shaka could not be unloaded') - }) + } } get textTracks () {
fix: Do not call _sendStats/_player.unload if Shaka player instance does not exist Avoid "_player.getStats/unload is not a function" errors
clappr_dash-shaka-playback
train
js
ba20169a58551b7e775aefb7b3c25e8a445981d2
diff --git a/addon/services/new-version.js b/addon/services/new-version.js index <HASH>..<HASH> 100644 --- a/addon/services/new-version.js +++ b/addon/services/new-version.js @@ -9,7 +9,6 @@ import { task, timeout } from 'ember-concurrency'; import fetch from 'fetch'; let taskRunCounter = 0; -const MAX_COUNT_IN_TESTING = 10; const ONE_MINUTE = 60000; /** @@ -18,6 +17,7 @@ const ONE_MINUTE = 60000; * @property {number} firstCheckInterval * @property {number} updateInterval * @property {boolean} enableInTests + * @property {number} maxCountInTesting * @property {string} currentVersion */ @@ -40,6 +40,7 @@ export default class NewVersionService extends Service { firstCheckInterval: 0, updateInterval: 60000, enableInTests: false, + maxCountInTesting: 10, }; return Object.assign(defaultConfiguration, this._config.newVersion); @@ -155,7 +156,10 @@ export default class NewVersionService extends Service { yield timeout(updateInterval); - if (Ember.testing && ++taskRunCounter > MAX_COUNT_IN_TESTING) { + if ( + Ember.testing && + ++taskRunCounter > this._newVersionConfig.maxCountInTesting + ) { return; }
feat: Make MAX_COUNT_IN_TESTING a configuration variable (#<I>) This let tests override this option as needed.
sethwebster_ember-cli-new-version
train
js
037686264fa82a9ff3b91554c02edceacb4e7be1
diff --git a/lib/cli.js b/lib/cli.js index <HASH>..<HASH> 100644 --- a/lib/cli.js +++ b/lib/cli.js @@ -38,15 +38,11 @@ if (opts.h || opts.help) { } if (opts.v || opts.version) { - var SORT_ORDER = ['slap', 'node', 'v8']; - var versions = process.versions; + var SORT_ORDER = ['slap', 'node', 'v8'].reverse(); + var versions = _.clone(process.versions); versions[package.name] = package.version; info(Object.keys(versions) - .sort(function (a, b) { - var sa = SORT_ORDER.indexOf(a); if (sa < 0) return 1; - var sb = SORT_ORDER.indexOf(b); if (sb < 0) return -1; - return sa - sb; - }) + .sort(function (a, b) { return SORT_ORDER.indexOf(b) - SORT_ORDER.indexOf(a); }) .map(function (name) { return name+"@"+versions[name]; }) .join(", ")); return process.exit(0);
style(flags): improves -v logic
slap-editor_slap
train
js
381161184c6bfdf5b12e7911ff43d6c3be15a131
diff --git a/src/utils/constants.js b/src/utils/constants.js index <HASH>..<HASH> 100644 --- a/src/utils/constants.js +++ b/src/utils/constants.js @@ -122,6 +122,7 @@ export const validProps = [ 'customStopwords', 'enableIndexSuggestions', 'enableFeaturedSuggestions', + 'searchboxId', ]; export const CLEAR_ALL = { diff --git a/src/utils/transform.js b/src/utils/transform.js index <HASH>..<HASH> 100644 --- a/src/utils/transform.js +++ b/src/utils/transform.js @@ -139,6 +139,7 @@ export const getRSQuery = (componentId, props, execute = true) => { indexSuggestionsConfig: props.indexSuggestionsConfig, enableFeaturedSuggestions: props.enableFeaturedSuggestions, enableIndexSuggestions: props.enableIndexSuggestions, + ...(props.searchboxId ? { searchboxId: props.searchboxId } : {}), } : {}), calendarInterval: props.calendarInterval,
feat: add support for searchboxId prop include searchboxId prop in payload for suggestion type queries
appbaseio_reactivecore
train
js,js
818bb9b697bcc97ba16192a06272ee2151b10f26
diff --git a/modules/angular2/src/test_lib/test_bed.js b/modules/angular2/src/test_lib/test_bed.js index <HASH>..<HASH> 100644 --- a/modules/angular2/src/test_lib/test_bed.js +++ b/modules/angular2/src/test_lib/test_bed.js @@ -116,6 +116,7 @@ export class ViewProxy { detectChanges(): void { this._view.changeDetector.detectChanges(); + this._view.changeDetector.checkNoChanges(); } querySelector(selector) {
test: changed test bed to run change detection twice to make sure there are no changes second time Closes #<I>
angular_angular
train
js
3f5dff0520839327c9b98a2bb607ad7207c470ef
diff --git a/scripts/release.js b/scripts/release.js index <HASH>..<HASH> 100755 --- a/scripts/release.js +++ b/scripts/release.js @@ -76,7 +76,12 @@ function updatePackage(packageInfo, changes) { return } - const change = changes.includes('major') + const dependencyMajor = packageInfo.dependencies + .map(name => versions[name] && versions[name].major) + .reduce((any, isMajor) => any || isMajor, false) + + const major = changes.includes('major') || dependencyMajor + const change = major ? `${pre}major` : changes.includes('feat') ? `${pre}minor` @@ -92,7 +97,10 @@ function updatePackage(packageInfo, changes) { const prerelease = oldVersion.includes('-') const newVersion = runLocal(`npm version ${prerelease ? 'prerelease' : change}`).slice(1) - versions[packageInfo.name] = newVersion + versions[packageInfo.name] = { + version: newVersion, + major + } log(chalk.yellow(`v${oldVersion} => v${newVersion}`)) @@ -111,7 +119,7 @@ function updateDependencies(packageInfo) { if (!config[depType] || !versions[name]) return if (config[depType][name]) { - config[depType][name] = `^${versions[name]}` + config[depType][name] = `^${versions[name.version]}` } }) })
chore(build): Detect major from dependent packages
lingui_js-lingui
train
js
ff633df6f426be3769f9afee8c5dbbe1b7978aa1
diff --git a/.github/workflows/matrix.js b/.github/workflows/matrix.js index <HASH>..<HASH> 100644 --- a/.github/workflows/matrix.js +++ b/.github/workflows/matrix.js @@ -246,14 +246,17 @@ include.forEach(v => { v.query_mode = v.query_mode.value; let includeTestTags = []; - if (v.replication === 'no') { - includeTestTags.push('!org.postgresql.test.Replication'); + // See https://junit.org/junit5/docs/current/user-guide/#running-tests-tag-expressions + includeTestTags.push('none()'); // untagged tests + + if (v.replication === 'yes') { + includeTestTags.push('org.postgresql.test.Replication'); } - if (v.slow_tests === 'no') { - includeTestTags.push('!org.postgresql.test.SlowTests'); + if (v.slow_tests === 'yes') { + includeTestTags.push('org.postgresql.test.SlowTests'); } - v.includeTestTags = includeTestTags.join(' & '); + v.includeTestTags = includeTestTags.join(' | '); if (v.gss === 'yes' || v.check_anorm_sbt === 'yes') { v.deploy_to_maven_local = true
chore: use "untagged tests" filtering expression to allow skipping them For instance, if only certain tags need to be executed, then "none()" could be temporarily commented out.
pgjdbc_pgjdbc
train
js
d036063bd9758a58ececf9ce4fa25b2ad2948837
diff --git a/docgen/plugins/documentationjs-data.js b/docgen/plugins/documentationjs-data.js index <HASH>..<HASH> 100644 --- a/docgen/plugins/documentationjs-data.js +++ b/docgen/plugins/documentationjs-data.js @@ -1,4 +1,4 @@ -import {forEach, reduce, groupBy, findIndex, find, filter, isArray, isObject} from 'lodash'; +import {uniqBy, forEach, reduce, groupBy, findIndex, find, filter, isArray, isObject} from 'lodash'; import documentation from 'documentation'; import remark from 'remark'; import html from 'remark-html'; @@ -145,5 +145,5 @@ function findRelatedTypes(functionSymbol, symbols) { forEach(functionSymbol.returns, findParamsTypes); forEach(functionSymbol.properties, findParamsTypes); - return types; + return uniqBy(types, 'name'); }
chore(documentationjs): remove duplicated `relatedTypes` by name
algolia_instantsearch.js
train
js
4a3f68cc0526ab440e31d23fa5cbd8d6791d83e8
diff --git a/src/components/VBottomSheet/VBottomSheet.js b/src/components/VBottomSheet/VBottomSheet.js index <HASH>..<HASH> 100644 --- a/src/components/VBottomSheet/VBottomSheet.js +++ b/src/components/VBottomSheet/VBottomSheet.js @@ -8,6 +8,7 @@ export default { props: { disabled: Boolean, fullWidth: Boolean, + hideOverlay: Boolean, inset: Boolean, lazy: Boolean, maxWidth: {
feat(v-bottom-sheet): added **hide-overlay** prop resolves #<I>
vuetifyjs_vuetify
train
js
d06c663778752e168f05a35da9fc46bfa9ae5c21
diff --git a/packages/netlify-cms-core/src/actions/config.js b/packages/netlify-cms-core/src/actions/config.js index <HASH>..<HASH> 100644 --- a/packages/netlify-cms-core/src/actions/config.js +++ b/packages/netlify-cms-core/src/actions/config.js @@ -56,10 +56,10 @@ function parseConfig(data) { } async function getConfig(file, isPreloaded) { - const response = await fetch(file, { credentials: 'same-origin' }); - if (response.status !== 200) { + const response = await fetch(file, { credentials: 'same-origin' }).catch(err => err); + if (response instanceof Error || response.status !== 200) { if (isPreloaded) return parseConfig(''); - throw new Error(`Failed to load config.yml (${response.status})`); + throw new Error(`Failed to load config.yml (${response.status || response})`); } const contentType = response.headers.get('Content-Type') || 'Not-Found'; const isYaml = contentType.indexOf('yaml') !== -1;
fix(config): stop throwing on config.yml <I>, fix manual init (#<I>)
netlify_netlify-cms
train
js
1a36375fa7c19ba5da11b1a7f84ee79d910742bc
diff --git a/src/core/components/dag.js b/src/core/components/dag.js index <HASH>..<HASH> 100644 --- a/src/core/components/dag.js +++ b/src/core/components/dag.js @@ -19,7 +19,7 @@ module.exports = function dag (self) { const optionDefaults = { format: 'dag-cbor', - hashAlg: 'sha2-255' + hashAlg: 'sha2-256' } options = options.cid ? options : Object.assign({}, optionDefaults, options)
fix(dag): fix default hash algorithm for put() api (#<I>) Turns out we've introduced a little bug in <URL>` is actually not being used at time of this commit. For more info see: <URL>
ipfs_js-ipfs
train
js
894ccfd8fd6b1d77b5d8f94ed69dbca5bad59da3
diff --git a/test/spec/features/bendpoints/BendpointsMoveSpec.js b/test/spec/features/bendpoints/BendpointsMoveSpec.js index <HASH>..<HASH> 100755 --- a/test/spec/features/bendpoints/BendpointsMoveSpec.js +++ b/test/spec/features/bendpoints/BendpointsMoveSpec.js @@ -493,6 +493,8 @@ describe('features/bendpoints - move', function() { dragging.hover({ element: source, gfx: canvas.getGraphics(source) }); + dragging.move(canvasEvent({ x: 0, y: 0 })); + dragging.move(canvasEvent(getMid(source))); dragging.end();
chore(bendpoints): actually test
bpmn-io_diagram-js
train
js
9325d136d4ee619a3d8fc1cd22c91585f31b67fa
diff --git a/pkg/tiller/hooks_test.go b/pkg/tiller/hooks_test.go index <HASH>..<HASH> 100644 --- a/pkg/tiller/hooks_test.go +++ b/pkg/tiller/hooks_test.go @@ -197,17 +197,18 @@ metadata: sorted := []manifest{} for _, s := range data { manifests := util.SplitManifests(s.manifest) - mCount := 0 - for _, m := range manifests { - name := s.name[mCount] + for _, m := range manifests { var sh util.SimpleHead err := yaml.Unmarshal([]byte(m), &sh) if err != nil { // This is expected for manifests that are corrupt or empty. t.Log(err) + continue } + name := sh.Metadata.Name + //only keep track of non-hook manifests if err == nil && s.hooks[name] == nil { another := manifest{ @@ -217,8 +218,6 @@ metadata: } sorted = append(sorted, another) } - - mCount++ } }
fix(tests): fix sorting hooks test flake
helm_helm
train
go
c758497bd90137714f76ae2fc8c1e171dcde6f00
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -195,7 +195,7 @@ async function fastifyStatic (fastify, opts) { stream.on('error', function (err) { if (err.code === 'ENOENT') { - // when preCompress is enabled and the path is a directoy without a trailing shash + // when preCompress is enabled and the path is a directory without a trailing slash if (opts.preCompressed && encoding) { const indexPathname = findIndexFile(pathname, options.root, options.index) if (indexPathname) { @@ -494,7 +494,7 @@ function getEncodingExtension (encoding) { function getRedirectUrl (url) { let i = 0 - // we detech how many slash before a valid path + // we detect how many slash before a valid path for (i; i < url.length; i++) { if (url[i] !== '/' && url[i] !== '\\') break }
chore: fix typo (#<I>)
fastify_fastify-static
train
js
b8b435b0fa5a280de0cbf0aa59069aa4e28df2d7
diff --git a/lib/manager/npm/post-update/npm.js b/lib/manager/npm/post-update/npm.js index <HASH>..<HASH> 100644 --- a/lib/manager/npm/post-update/npm.js +++ b/lib/manager/npm/post-update/npm.js @@ -64,6 +64,20 @@ async function generateLockFile( if (binarySource === 'global') { cmd = 'npm'; } + // istanbul ignore if + if (config.binarySource === 'docker') { + logger.info('Running npm via docker'); + cmd = `docker run --rm `; + const volumes = [cwd]; + if (config.cacheDir) { + volumes.push(config.cacheDir); + } + cmd += volumes.map(v => `-v ${v}:${v} `).join(''); + const envVars = ['NPM_CONFIG_CACHE', 'npm_config_store']; + cmd += envVars.map(e => `-e ${e} `).join(''); + cmd += `-w ${cwd} `; + cmd += `renovate/npm npm`; + } args = `install`; if ( (postUpdateOptions && postUpdateOptions.includes('npmDedupe')) ||
feat(npm): support binarySource=docker (#<I>)
renovatebot_renovate
train
js
1875bea425e16d4f2ba4fe156f838a941aceba13
diff --git a/packages/build-tools/utils/bolt-versions.js b/packages/build-tools/utils/bolt-versions.js index <HASH>..<HASH> 100644 --- a/packages/build-tools/utils/bolt-versions.js +++ b/packages/build-tools/utils/bolt-versions.js @@ -18,10 +18,16 @@ const octokit = new Octokit({ }`, ); - if (options.request.retryCount === 0) { + // only retry if wait is 15 seconds or less + if (options.request.retryCount === 0 && retryAfter <= 15) { // only retries once console.log(`Retrying after ${retryAfter} seconds!`); return true; + } else { + console.log( + `Skipping auto-retry since we don't want to wait ${retryAfter} seconds!`, + ); + return false; } }, onAbuseLimit: (retryAfter, options) => {
fix: update to only wait to retry requests that are within <I> seconds before calling it quits and using the fallback
bolt-design-system_bolt
train
js
c95be44e5abe8952210b6dc9bdb22133ba5961eb
diff --git a/test.js b/test.js index <HASH>..<HASH> 100644 --- a/test.js +++ b/test.js @@ -58,7 +58,7 @@ function readSuite (suiteName) { } var suites = fs.readdirSync('test') -var total = { fail: 0, success: 0 } +var total = { fail: 0, optionalFail: 0, success: 0 } suites.forEach(function (suiteName) { var suite = readSuite(suiteName) @@ -73,9 +73,19 @@ suites.forEach(function (suiteName) { chalk.green(' ' + success + ' ' + result.success) ) total.fail += result.fail + total.optionalFail += result.optionalFail total.success += result.success }) +console.log('') +console.log('summary') +console.log('-------') +console.log( + chalk.red(' ' + error + ' ' + total.fail) + ' ' + + chalk.yellow(' ' + warning + ' ' + total.optionalFail) + ' ' + + chalk.green(' ' + success + ' ' + total.success) +) + if (total.fail > 0) { process.exit(1) }
test: show error/warning/success summary at end
goto-bus-stop_get-artist-title
train
js
6f8663d3ed845f943e2c065abffb1f4d1147ed54
diff --git a/tinydb/table.py b/tinydb/table.py index <HASH>..<HASH> 100644 --- a/tinydb/table.py +++ b/tinydb/table.py @@ -595,12 +595,21 @@ class Table: # The table does not exist yet, so it is empty table = {} + # Convert the document IDs to the document ID class. + # This is required as the rest of TinyDB expects the document IDs + # to be an instance of ``self.document_id_class`` but the storage + # might convert dict keys to strings. + table = { + self.document_id_class(doc_id): doc + for doc_id, doc in table.items() + } + # Perform the table update operation updater(table) - # Convert the document IDs to strings. - # This is required as some storages (most notably the JSON - # file format) don't require IDs other than strings. + # Convert the document IDs back to strings. + # This is required as some storages (most notably the JSON file format) + # don't require IDs other than strings. tables[self.name] = { str(doc_id): doc for doc_id, doc in table.items()
fix(table): convert document IDs during update operations
msiemens_tinydb
train
py
cf7ca45988e4f8069b405c8cff538e6fe55e79f2
diff --git a/src/createHashStateHistory.js b/src/createHashStateHistory.js index <HASH>..<HASH> 100644 --- a/src/createHashStateHistory.js +++ b/src/createHashStateHistory.js @@ -300,7 +300,7 @@ const createHashStateHistory = (props = {}) => { listenerCount += delta; const eventType = canUseHistory ? PopStateEvent : HashChangeEvent; - if (listenerCount === 1) { + if (listenerCount === 1 && delta === 1) { window.addEventListener(eventType, handleHashChange); } else if (listenerCount === 0) { window.removeEventListener(eventType, handleHashChange);
fix: duplicate listeners <I>d<I> commit on upstream ReactTraining/history
w33ble_history-extra
train
js
f1c7994082d97ddfea7da81be360a5317b45892b
diff --git a/internal/boomer/output.go b/internal/boomer/output.go index <HASH>..<HASH> 100644 --- a/internal/boomer/output.go +++ b/internal/boomer/output.go @@ -119,15 +119,15 @@ func (o *ConsoleOutput) OnEvent(data map[string]interface{}) { var state string switch output.State { - case 1: + case stateInit: state = "initializing" - case 2: + case stateSpawning: state = "spawning" - case 3: + case stateRunning: state = "running" - case 4: + case stateQuitting: state = "quitting" - case 5: + case stateStopped: state = "stopped" } @@ -463,7 +463,11 @@ func (o *PrometheusPusherOutput) OnStart() { // OnStop of PrometheusPusherOutput has nothing to do. func (o *PrometheusPusherOutput) OnStop() { - + // update runner state: stopped + gaugeState.Set(float64(stateStopped)) + if err := o.pusher.Push(); err != nil { + log.Error().Err(err).Msg("push to Pushgateway failed") + } } // OnEvent will push metric to Prometheus Pushgataway
fix: unable to sense the quit of hrp in Prometheus
HttpRunner_HttpRunner
train
go
cead49c8a55aad7c7626df2afa35ae137ecaf0c1
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -30,7 +30,7 @@ const nodeHasAttrs = (node, callback) => { if ( typeof node === 'object' && Object.prototype.hasOwnProperty.call(node, 'attrs') ) { - node.attrs = Object.keys(node.attrs).reduce(callback, {}); // eslint-disable-line unicorn/no-fn-reference-in-iterator + node.attrs = Object.keys(node.attrs).reduce(callback, {}); } }; diff --git a/test/test-plugin.js b/test/test-plugin.js index <HASH>..<HASH> 100644 --- a/test/test-plugin.js +++ b/test/test-plugin.js @@ -11,7 +11,7 @@ test('plugin beautify must be function', t => { test('plugin beautify should return Error with use option sync', t => { const error = t.throws(() => { beautify()(); - }, undefined); + }); t.is(error.message, 'tree is not Array'); });
style: after update dev dep and lint
Scrum_posthtml-beautify
train
js,js
b77ecca19df6d5426681d53bd974a2b7b44a9a5f
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -24,7 +24,7 @@ const optionsDefault = { const COMMENT_START = '<!--'; const COMMENT_END = '-->'; -const COMMENT_CONTENT_REG = new RegExp(`${COMMENT_START}([\S\s]*?)${COMMENT_END}`, 'g'); +const COMMENT_CONTENT_REG = new RegExp(`${COMMENT_START}([\\S\\s]*?)${COMMENT_END}`, 'g'); const nodeHasContent = (node, callback) => { if (
fix: escape character in regexp
Scrum_posthtml-beautify
train
js
07e3e7028bd1de019b6b67eac7d16212cd38d4a9
diff --git a/packages/java-parser/src/productions/blocks-and-statements.js b/packages/java-parser/src/productions/blocks-and-statements.js index <HASH>..<HASH> 100644 --- a/packages/java-parser/src/productions/blocks-and-statements.js +++ b/packages/java-parser/src/productions/blocks-and-statements.js @@ -294,6 +294,7 @@ function defineRules($, t) { $.OPTION(() => { $.CONSUME(t.Identifier); }); + $.CONSUME(t.Semicolon); }); // https://docs.oracle.com/javase/specs/jls/se11/html/jls-14.html#jls-ContinueStatement diff --git a/packages/java-parser/test/samples-spec.js b/packages/java-parser/test/samples-spec.js index <HASH>..<HASH> 100644 --- a/packages/java-parser/test/samples-spec.js +++ b/packages/java-parser/test/samples-spec.js @@ -10,7 +10,7 @@ const javaParser = require("../src/index"); describe("The Java Parser", () => { createSampleSpecs("java-design-patterns"); createSampleSpecs("spring-boot"); - createFailingSampleSpec("guava", 36, 0); + createFailingSampleSpec("guava", 32, 0); }); function createSampleSpecs(sampleName) {
fix(parser): fixmissing semicolon consuming in break statement (#<I>)
jhipster_prettier-java
train
js,js
d4d5923417734b73769493883c649f9adfcc7863
diff --git a/src/Engine/AlgoliaEngine.php b/src/Engine/AlgoliaEngine.php index <HASH>..<HASH> 100644 --- a/src/Engine/AlgoliaEngine.php +++ b/src/Engine/AlgoliaEngine.php @@ -13,7 +13,7 @@ class AlgoliaEngine implements EngineInterface public function __construct(Client $algolia) { - Version::addSuffixUserAgentSegment('Symfony Search Bundle', '2.0.0-BETA'); + Version::addSuffixUserAgentSegment('Symfony Search Bundle', '3.0.0-BETA'); $this->algolia = $algolia; }
chore(version): New version is actually <I>
algolia_search-bundle
train
php
02d571c9652c00327ac5b0afa7f11076d8f0ab1b
diff --git a/lib/server/hapi_plugins/api/internals.js b/lib/server/hapi_plugins/api/internals.js index <HASH>..<HASH> 100644 --- a/lib/server/hapi_plugins/api/internals.js +++ b/lib/server/hapi_plugins/api/internals.js @@ -38,7 +38,9 @@ module.exports = { return; } - if (Array.isArray(res.headers['set-cookie'])) { + var isSess = request.method === 'post' && request.path === '/_api/_session'; + + if (data && isSess && Array.isArray(res.headers['set-cookie'])) { data.bearerToken = extractToken(res.headers['set-cookie']); delete res.headers['set-cookie']; }
fix(api): send bearer token only on session request * * * This commit was sponsored by The Hoodie Firm. You can hire The Hoodie Firm: <URL>
hoodiehq_hoodie-server
train
js
7f33d73d06c2ed763a15e42483a2ea00fbb70033
diff --git a/pypot/creatures/services_launcher.py b/pypot/creatures/services_launcher.py index <HASH>..<HASH> 100644 --- a/pypot/creatures/services_launcher.py +++ b/pypot/creatures/services_launcher.py @@ -253,7 +253,7 @@ Examples: sys.stdout.flush() if snap_static_server_started or scratch_static_server_started: - for browser_name in ['chromium-browser', 'chromium', 'google-chrome', + for browser_name in ['firefox', 'chromium-browser', 'chromium', 'google-chrome', 'chrome', 'safari', 'midori', None]: try: browser = webbrowser.get(browser_name)
feat(poppyservices): Adds Firefox in web browsers list
poppy-project_pypot
train
py
6598cd3af4edcec586458d4fdfb7c4c6c7918dfe
diff --git a/vyper/parser/function_definitions/parse_external_function.py b/vyper/parser/function_definitions/parse_external_function.py index <HASH>..<HASH> 100644 --- a/vyper/parser/function_definitions/parse_external_function.py +++ b/vyper/parser/function_definitions/parse_external_function.py @@ -106,7 +106,7 @@ def parse_external_function( # Is default function. elif sig.is_default_func(): o = LLLnode.from_list( - ["seq"] + clampers + [parse_body(code.body, context)], # type: ignore + ["seq"] + clampers + [parse_body(code.body, context)] + [["stop"]], # type: ignore pos=getpos(code), ) # Is a normal function.
fix: include stop instruction at end of default func lll
ethereum_vyper
train
py
8ccb2e4b10d7ffa7e1e7fb81539975ecaa5ddcd8
diff --git a/src/Modules/CleanUpModule.php b/src/Modules/CleanUpModule.php index <HASH>..<HASH> 100644 --- a/src/Modules/CleanUpModule.php +++ b/src/Modules/CleanUpModule.php @@ -182,12 +182,7 @@ class CleanUpModule extends AbstractModule */ protected function disableExtraRss() { - remove_action('wp_head', 'feed_links_extra', 3); - add_action('wp_head', 'ob_start', 1, 0); - add_action('wp_head', function () { - $pattern = '/.*' . preg_quote(esc_url(get_feed_link('comments_' . get_default_feed())), '/') . '.*[\r\n]+/'; - echo preg_replace($pattern, '', ob_get_clean()); - }, 3, 0); + add_filter('feed_links_show_comments_feed', '__return_false'); } /**
feat(cleanup): use filter to remove comments feed
roots_soil
train
php
133bdb366a376d09fdf2c3e69d7fc5c2a740580c
diff --git a/lib/prepare.js b/lib/prepare.js index <HASH>..<HASH> 100644 --- a/lib/prepare.js +++ b/lib/prepare.js @@ -114,7 +114,7 @@ async function resolveOptions (sourceDir) { // resolve custom theme const themeDir = siteConfig.theme ? path.resolve(__dirname, `../../vuepress-theme-${siteConfig.theme}`) - : path.resolve(sourceDir, 'theme') + : path.resolve(vuepressDir, 'theme') const themePath = path.resolve(themeDir, 'Layout.vue') if (fs.existsSync(themePath)) {
fix: fix vuepress cant resolve custom theme under .vuepress/theme (#3)
vuejs_vuepress
train
js
0eaa46b5780f9eb0f71ae325782781cbc4155c5c
diff --git a/Debugger/src/BreakpointStorage/FileBreakpointStorage.php b/Debugger/src/BreakpointStorage/FileBreakpointStorage.php index <HASH>..<HASH> 100644 --- a/Debugger/src/BreakpointStorage/FileBreakpointStorage.php +++ b/Debugger/src/BreakpointStorage/FileBreakpointStorage.php @@ -37,14 +37,14 @@ class FileBreakpointStorage implements BreakpointStorageInterface /** * Create a new FileBreakpointStorage instance. * - * @param string $filename [optional] The full path to the storage file. - * **Defaults to** a temporary file in the system's temp directory. + * @param string $filename [optional] The name of the file to create in the + * system's temp directory. **Defaults to** `debugger-breakpoints`. */ public function __construct($filename = null) { $filename = $filename ?: self::DEFAULT_FILENAME; $this->filename = implode(DIRECTORY_SEPARATOR, [sys_get_temp_dir(), $filename]); - $this->lockFilename = $filename . '.lock'; + $this->lockFilename = $filename; } /**
fix: remove redundant extension from lock file name (#<I>) * fix: remove redundant extension from lock file name * update description * typo
googleapis_google-cloud-php
train
php
77b332a53cb7f7f6682e3bfcb263e2754787118d
diff --git a/angular-raven.js b/angular-raven.js index <HASH>..<HASH> 100644 --- a/angular-raven.js +++ b/angular-raven.js @@ -117,4 +117,8 @@ }; }]); + module.factory('$raven', ['Raven', function(Raven) { + return Raven; + }]); + }(angular.module('ngRaven', []), angular);
feat(Raven): Raven as $raven alias
PatrickJS_angular-raven
train
js
fa32d8caa0dbe5577afc4596eb9f9fe4c5cde6c1
diff --git a/cypress-tags.js b/cypress-tags.js index <HASH>..<HASH> 100755 --- a/cypress-tags.js +++ b/cypress-tags.js @@ -59,12 +59,20 @@ paths.forEach(featurePath => { } }); +function getOsSpecificExecutable(command) { + return process.platform === "win32" ? `${command}.cmd` : command; +} + +function getCypressExecutable() { + const command = getOsSpecificExecutable(`${__dirname}/../.bin/cypress`); + // fallback to the globally installed cypress instead + return fs.existsSync(command) ? command : getOsSpecificExecutable("cypress"); +} + try { if (featuresToRun.length || envTags === "") { execFileSync( - process.platform === "win32" - ? `cypress.cmd` - : `${__dirname}/../.bin/cypress`, + getCypressExecutable(), [...process.argv.slice(2), "--spec", featuresToRun.join(",")], { stdio: [process.stdin, process.stdout, process.stderr]
feat(tags): fallback to globally installed cypress executable if doesn't exist locally Fixes #<I>
TheBrainFamily_cypress-cucumber-preprocessor
train
js
6af8f2d4432bafea0a9bcf23d33f5783177c2a29
diff --git a/spec/operators/filter-spec.js b/spec/operators/filter-spec.js index <HASH>..<HASH> 100644 --- a/spec/operators/filter-spec.js +++ b/spec/operators/filter-spec.js @@ -88,6 +88,25 @@ describe('Observable.prototype.filter()', function () { expectObservable(source.filter(predicate)).toBe(expected); }); + it('should invoke predicate once for each checked value', function () { + var source = hot('-1--2--^-3-4-5-6--7-8--9--|'); + var expected = '--3---5----7-------|'; + + var invoked = 0; + var predicate = function (x) { + invoked++; + return isPrime(x); + }; + + var r = source + .filter(predicate) + .do(null, null, function () { + expect(invoked).toEqual(7); + }); + + expectObservable(r).toBe(expected); + }); + it('should filter in only prime numbers, predicate with index, ' + 'source unsubscribes early', function () {
test(filter): test the number of calls to the predicate function relates to #<I>.
ReactiveX_rxjs
train
js
e0ef6cc74b89cc8abc0700c2745667b83fec31d0
diff --git a/packages/cli-plugin-workspaces/commands/utils.js b/packages/cli-plugin-workspaces/commands/utils.js index <HASH>..<HASH> 100644 --- a/packages/cli-plugin-workspaces/commands/utils.js +++ b/packages/cli-plugin-workspaces/commands/utils.js @@ -3,7 +3,7 @@ const { join, resolve } = require("path"); const multimatch = require("multimatch"); const { allWorkspaces } = require("@webiny/project-utils/workspaces"); -const createGraph = packages => { +const createGraph = (packages, options = {}) => { const graph = new Graph(); const packageNames = packages.map(pkg => pkg.name); @@ -26,7 +26,7 @@ const createGraph = packages => { }); }); - validateGraph(graph); + options.validate !== false && validateGraph(graph); return graph; };
feat: add ability to skip graph validation
Webiny_webiny-js
train
js
d258c3849ec099d1aebf1f2f3e6a0699fb8edbb1
diff --git a/lib/platform/github/index.js b/lib/platform/github/index.js index <HASH>..<HASH> 100644 --- a/lib/platform/github/index.js +++ b/lib/platform/github/index.js @@ -1014,10 +1014,15 @@ async function commitFilesToBranch( gitPrivateKey ); const isBranchExisting = await branchExists(branchName); - if (isBranchExisting) { - await updateBranch(branchName, commit); - } else { - await createBranch(branchName, commit); + try { + if (isBranchExisting) { + await updateBranch(branchName, commit); + } else { + await createBranch(branchName, commit); + } + } catch (err) /* istanbul ignore next */ { + logger.debug({ files }); + throw err; } }
refactor: log files if commit files to branch fails
renovatebot_renovate
train
js
a0d41838699058143608ff781a1b44bc7aa45b5d
diff --git a/app/lib/quasar-config.js b/app/lib/quasar-config.js index <HASH>..<HASH> 100644 --- a/app/lib/quasar-config.js +++ b/app/lib/quasar-config.js @@ -550,6 +550,7 @@ class QuasarConfig { open: true }, cfg.devServer, { contentBase: false, + watchContentBase: false, before: app => { if (!this.ctx.mode.ssr) {
fix(app): Disable watchContentBase to avoid triggering unwanted errors #<I>
quasarframework_quasar
train
js
154d763f3410afda1100141434eb47546091d2a9
diff --git a/src/playbacks/html5_video/html5_video.js b/src/playbacks/html5_video/html5_video.js index <HASH>..<HASH> 100644 --- a/src/playbacks/html5_video/html5_video.js +++ b/src/playbacks/html5_video/html5_video.js @@ -222,6 +222,11 @@ export default class HTML5Video extends Playback { } volume(value) { + if (value === 0) { + this.$el.attr({muted: 'true'}) + } else if (this.el.volume === 0) { + this.$el.attr({muted: null}) + } this.el.volume = value / 100 }
feat: allow muted autoplay for html5 video playback on mobile devices
clappr_clappr
train
js
8e440faf6c8fa5468c52412eb556a5561cb505b3
diff --git a/docs/src/utils/formatCode.js b/docs/src/utils/formatCode.js index <HASH>..<HASH> 100644 --- a/docs/src/utils/formatCode.js +++ b/docs/src/utils/formatCode.js @@ -13,17 +13,19 @@ delete prettierConfig.overrides // Please use this function directly and don't reexport it in utils. // https://github.com/prettier/prettier/issues/4959 -const formatCode = (code, parser = 'babylon') => { - if (!code) return '' +const formatCode = isBrowser() + ? (code, parser = 'babylon') => { + if (!code) return '' - const formatted = prettier.format(code, { - ...prettierConfig, - printWidth, - parser, - plugins: isBrowser() ? window.prettierPlugins : undefined, - }) + const formatted = prettier.format(code, { + ...prettierConfig, + printWidth, + parser, + plugins: window.prettierPlugins, + }) - return formatted.replace(/^;</, '<') // remove beginning comma in JSX/HTML -} + return formatted.replace(/^;</, '<') // remove beginning semi in JSX/HTML + } + : x => x export default formatCode
docs(formatCode): make noop in SSR
Semantic-Org_Semantic-UI-React
train
js
904715333596eeb53e6ac6c97e30a9381bd49d84
diff --git a/scripts/pyannote-metrics.py b/scripts/pyannote-metrics.py index <HASH>..<HASH> 100644 --- a/scripts/pyannote-metrics.py +++ b/scripts/pyannote-metrics.py @@ -51,6 +51,7 @@ Options: # command line parsing from docopt import docopt +import warnings import functools import pandas as pd from tabulate import tabulate @@ -100,6 +101,8 @@ def get_hypothesis(hypotheses, item): raise ValueError(msg.format(uri=uri, uris=tmp_uri)) else: tmp_uri = tmp_uri[0] + msg = 'Could not find any hypothesis matching "{uri}" exactly: using "{tmp_uri}" instead.' + warnings.warn(msg.format(tmp_uri=tmp_uri, uri=uri)) hypothesis = hypotheses(uri=tmp_uri) hypothesis.uri = uri
feat: warn user about lack of exact match
pyannote_pyannote-metrics
train
py
43df864ed9d0a355d93f9de3f5e07be160212245
diff --git a/quasar/build/build.lang-index.js b/quasar/build/build.lang-index.js index <HASH>..<HASH> 100644 --- a/quasar/build/build.lang-index.js +++ b/quasar/build/build.lang-index.js @@ -39,14 +39,14 @@ module.exports.generate = function () { langFile = resolve('lang/index.json'), newLangJson = JSON.stringify(languages, null, 2) - let oldLangJson + let oldLangJson = '' try { oldLangJson = fs.readFileSync(langFile, 'utf-8') } catch (e) { } - if (newLangJson !== oldLangJson) { + if (newLangJson.split(/[\n\r]+/).join('\n') !== oldLangJson.split(/[\n\r]+/).join('\n')) { writeFile(langFile, newLangJson) } }
fix(quasar): Disregard line ending style when comparing generated lang index file (#<I>)
quasarframework_quasar
train
js
38f476e91c7d04ba0277a5afa71d151dbb9d210f
diff --git a/src/mode/shared/bar.js b/src/mode/shared/bar.js index <HASH>..<HASH> 100644 --- a/src/mode/shared/bar.js +++ b/src/mode/shared/bar.js @@ -489,6 +489,7 @@ function getBarData(vm, type) { } return { + hideBar, props: { type: type, ops: { @@ -518,8 +519,11 @@ export function createBar(h, vm) { const horizontalBarProps = getBarData(vm, 'horizontal'); // set class hooks - vm.setClassHook('hasVBar', !!verticalBarProps); - vm.setClassHook('hasHBar', !!horizontalBarProps); + vm.setClassHook('hasVBar', !!(verticalBarProps && !verticalBarProps.hideBar)); + vm.setClassHook( + 'hasHBar', + !!(horizontalBarProps && !horizontalBarProps.hideBar) + ); return [ verticalBarProps ? (
fix: incorrect class hook when rail is keepshow.(close #<I>)
YvesCoding_vuescroll
train
js
d348a203df438a3ea9abeb61cd1e4d34c73ed7ed
diff --git a/src/Repository.php b/src/Repository.php index <HASH>..<HASH> 100644 --- a/src/Repository.php +++ b/src/Repository.php @@ -13,7 +13,7 @@ abstract class Repository protected $model; - protected $defaultSort = null; + protected $sortProperty = null; abstract protected function getModel(); @@ -68,7 +68,7 @@ abstract class Repository * @param array $options * @return Collection */ - public function getWhereRecent($column, $value, array $options = []) + public function getRecentWhere($column, $value, array $options = []) { $query = $this->createBaseBuilder($options); @@ -174,8 +174,8 @@ abstract class Repository $this->applyResourceOptions($query, $options); - if (!isset($options['sort']) && isset($this->defaultSort)) { - $query->orderBy($this->defaultSort); + if (!isset($options['sort'])) { + $this->sortQuery($query, $options); } return $query; @@ -199,4 +199,17 @@ abstract class Repository { return $query->getModel()->getKeyName(); } + + /** + * Order query by the specified sorting property + * @param Builder $query + * @param array $options + * @return void + */ + protected function sortQuery(Builder $query, array $options = []) + { + if (isset($this->sortProperty)) { + $query->orderBy($this->sortProperty); + } + } }
refactor: refactor repository sorting mechanism to an extendable method
esbenp_genie
train
php
e8f1c449755a0a06c9b42057638c550d585fa404
diff --git a/samcli/__main__.py b/samcli/__main__.py index <HASH>..<HASH> 100644 --- a/samcli/__main__.py +++ b/samcli/__main__.py @@ -7,4 +7,6 @@ python -m samcli from samcli.cli.main import cli if __name__ == "__main__": - cli() + # NOTE(TheSriram): prog_name is always set to "sam". This way when the CLI is invoked as a module, + # the help text that is generated still says "sam" instead of "__main__". + cli(prog_name="sam")
fix: always ensure the base command is set to "sam" (#<I>) * fix: always ensure the base command is set to "sam" - irrespective of the module name that invokes the CLI, the command that is seen on the help/description text, should always say "sam" * fix: set prog_name to be "sam" without changing context
awslabs_aws-sam-cli
train
py
070ad14e54e348e53a843c2830112c614f2ab467
diff --git a/lib/browser/lighthouse.js b/lib/browser/lighthouse.js index <HASH>..<HASH> 100644 --- a/lib/browser/lighthouse.js +++ b/lib/browser/lighthouse.js @@ -90,7 +90,7 @@ const lhConfig = { const parseLhResult = function(results) { if (!results || !results.lhr || !results.lhr.audits) { - return null; + throw new Error(`Error fetching lighthouse audit results`); } const audits = results.lhr.audits;
chore: throw error when audits results can't be fetched
testiumjs_testium-driver-wd
train
js
a9b300036a3686f0d582b434e6cc39b6c560dc5b
diff --git a/plugins/chai-plugin-snapshot/src/index.js b/plugins/chai-plugin-snapshot/src/index.js index <HASH>..<HASH> 100644 --- a/plugins/chai-plugin-snapshot/src/index.js +++ b/plugins/chai-plugin-snapshot/src/index.js @@ -26,7 +26,7 @@ module.exports = function snapshot(runner) { let currentTestName = null; for (let i = lineno - 1; i >= 0; i -= 1) { const line = lines[i]; - if (line.trimLeft().startsWith('it')) { + if (line.trimLeft().startsWith('it(')) { [, currentTestName] = line.match(/it.*\((.*),/); break; }
fix: reduce risk of falsy test case match (#<I>)
qlik-oss_after-work.js
train
js
f81188ff9bb357a5a33c77636f933ec0ae76c0db
diff --git a/website/redirects.js b/website/redirects.js index <HASH>..<HASH> 100644 --- a/website/redirects.js +++ b/website/redirects.js @@ -2,6 +2,11 @@ module.exports = [ // Define your custom redirects within this file. // Vercel's redirect documentation: https://vercel.com/docs/configuration#project/redirects // Playground for testing url pattern matching: https://npm.runkit.com/path-to-regexp + { + source: '/home', + destination: '/', + permanent: true, + }, // Friendly URL for trial form redirection {
fix: redirects /home to /
hashicorp_nomad
train
js
9ba07e33548cd1736985e15717e431c042e893a9
diff --git a/test/helpers/kubectl.go b/test/helpers/kubectl.go index <HASH>..<HASH> 100644 --- a/test/helpers/kubectl.go +++ b/test/helpers/kubectl.go @@ -1828,7 +1828,7 @@ iteratePods: if err != nil || ep.Identity == nil || ep.Identity.ID == 0 { ginkgoext.By("Restarting unmanaged pod %s/%s", namespace, pod.Name) cmd = KubectlCmd + " -n " + namespace + " delete pod " + pod.Name - res = kub.ExecShort(cmd) + res = kub.Exec(cmd) if !res.WasSuccessful() { ginkgoext.Failf("Unable to restart unmanaged pod with '%s': %s", cmd, res.OutputPrettyPrint()) }
test: Fix issue with unmanaged pod deletions hitting the timeout Fixes: #<I>
cilium_cilium
train
go
351cdd1b981883443116cfbf6194ea018a83da91
diff --git a/anyconfig/utils.py b/anyconfig/utils.py index <HASH>..<HASH> 100644 --- a/anyconfig/utils.py +++ b/anyconfig/utils.py @@ -167,5 +167,4 @@ def are_same_file_types(paths): return all(_try_to_get_extension(p) == ext for p in paths[1:]) - # vim:sw=4:ts=4:et:
refactor: remove an extra empty line
ssato_python-anyconfig
train
py
2938796d648845771cfb62fde01cc236fadb424c
diff --git a/pyethereum/processblock.py b/pyethereum/processblock.py index <HASH>..<HASH> 100644 --- a/pyethereum/processblock.py +++ b/pyethereum/processblock.py @@ -148,7 +148,7 @@ def apply_transaction(block, tx): # check block gas limit if block.gas_used + tx.startgas > block.gas_limit: - BlockGasLimitReached( + raise BlockGasLimitReached( rp(block.gas_used + tx.startgas, block.gas_limit))
fix: actually raise BlockGasLimit exception
ethereum_pyethereum
train
py
9fe7a1e7e8118123fd95f07245796dc5f8700cff
diff --git a/components/serverless-apollo-service/serverless.js b/components/serverless-apollo-service/serverless.js index <HASH>..<HASH> 100644 --- a/components/serverless-apollo-service/serverless.js +++ b/components/serverless-apollo-service/serverless.js @@ -148,6 +148,7 @@ class ApolloService extends Component { this.context.debug(`[${componentName}] Deploying API Gateway`); const apiGwOut = await apiGw({ + region, name: componentName, description: `API for ${componentName}`, stage: "prod",
fix: pass region when creating API gateways
Webiny_webiny-js
train
js
65264690f04fb802ad8f148a165355e4e58c6b02
diff --git a/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py b/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py index <HASH>..<HASH> 100644 --- a/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py +++ b/packages/jsii-python-runtime/src/jsii/_kernel/providers/base.py @@ -74,7 +74,7 @@ class BaseProvider(metaclass=abc.ABCMeta): ... @abc.abstractmethod - def complete(self, request: CompleteRequest) -> Union[InvokeResponse, GetResponse]: + def complete(self, request: CompleteRequest) -> CompleteResponse: ... @abc.abstractmethod @@ -98,9 +98,5 @@ class BaseProvider(metaclass=abc.ABCMeta): ... @abc.abstractmethod - def complete(self, request: CompleteRequest) -> CompleteResponse: - ... - - @abc.abstractmethod def stats(self, request: Optional[StatsRequest] = None) -> StatsResponse: ...
fix(build): fix python runtime BaseProvider signatures (#<I>)
awslabs_jsii
train
py
9646ce42c285fbbda8e2f4c5357dbec776d6bb3a
diff --git a/src/targets.js b/src/targets.js index <HASH>..<HASH> 100644 --- a/src/targets.js +++ b/src/targets.js @@ -1,3 +1,5 @@ -const node = '12.0.0'; +import { engines } from '../package.json'; + +const node = engines.node.replace( /[<=>~^]/g, '' ); export { node };
feat(targets): always get Node target version from package.json engines.node field
Comandeer_rollup-lib-bundler
train
js
851e13f52aa6c656119a8c01f8964a087e9b47a0
diff --git a/gulpfile.js b/gulpfile.js index <HASH>..<HASH> 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -180,18 +180,39 @@ function testBrowser() { }, // Externals isn't necessary here since these are for tests. module: { - loaders: [ // This is what allows us to author in future JavaScript + rules: [ { test: /\.js$/, exclude: /node_modules/, - loader: 'babel-loader', + use: [ + { + loader: 'babel-loader', + query: { + babelrc: false, + presets: [ + [ + 'es2015', + { + modules: false, + }, + ], + ], + plugins: [ + 'lodash', + 'transform-object-rest-spread', + ], + }, + }, + ], }, - // This allows the test setup scripts to load `package.json` { test: /\.json$/, - exclude: /node_modules/, - loader: 'json-loader', + use: [ + { + loader: 'json-loader', + }, + ], }, ], }, @@ -204,7 +225,7 @@ function testBrowser() { ], devtool: 'inline-source-map', }, - null, + webpack, () => { if (firstBuild) { $.livereload.listen({
chore(tests): Sync the babel config for test to same as main build.
investtools_extensible-duck
train
js
33615c03c0f4556719b1e447efb484d57a61ed84
diff --git a/abstract.js b/abstract.js index <HASH>..<HASH> 100644 --- a/abstract.js +++ b/abstract.js @@ -60,6 +60,7 @@ function abstractPersistence (opts) { var packet = { cmd: 'publish', id: instance.broker.id, + brokerCounter: opts.counter, topic: opts.topic || 'hello/world', payload: opts.payload || Buffer.from('muahah'), qos: 0, @@ -117,6 +118,22 @@ function abstractPersistence (opts) { matchRetainedWithPattern(t, ['hello/+', 'other/hello']) }) + testInstance('store multiple retained messages in order', function (t, instance) { + t.plan(40) + + function checkIndex (index) { + opts.counter = index + storeRetained(instance, opts, function (err, packet) { + t.notOk(err, 'no error') + t.equal(packet.brokerCounter, index, 'packet stored in order') + }) + } + + for (let i = 0; i < 20; i++) { + checkIndex(i) + } + }) + testInstance('remove retained message', function (t, instance) { storeRetained(instance, {}, function (err, packet) { t.notOk(err, 'no error')
fix: Added test for #<I>
mcollina_aedes-persistence
train
js
5a11a4f5909ebb78babaa6ef136e8e1312451b54
diff --git a/examples/with-firebase-admin/index.js b/examples/with-firebase-admin/index.js index <HASH>..<HASH> 100644 --- a/examples/with-firebase-admin/index.js +++ b/examples/with-firebase-admin/index.js @@ -7,7 +7,7 @@ const compress = require('compression')(); const { PORT=3000 } = process.env; polka() - .use(cors, json(), serve, compress) + .use(cors, compress, json(), serve) .use('api', require('./api')) .listen(PORT) .then(_ => {
fix: correct order; compress before statics
lukeed_polka
train
js
7e18c7c1d0a1cd2cdd72d02e937c7cd4b5afa1d6
diff --git a/packages/cli/bin/run-prompts.js b/packages/cli/bin/run-prompts.js index <HASH>..<HASH> 100644 --- a/packages/cli/bin/run-prompts.js +++ b/packages/cli/bin/run-prompts.js @@ -90,7 +90,7 @@ function runInitPrompts(pathname, argv) { return ({ npm: 'npm', yarn: 'yarn', - '不自动安装依赖': 'none' + 'not install the packages automatically': 'none' }[value]) } })
feat: add manager to install packages automatically
yanhaijing_jslib-base
train
js
b157a2ba098edff2b637bac950a5b2ee906b5e42
diff --git a/src/geshi/email.php b/src/geshi/email.php index <HASH>..<HASH> 100644 --- a/src/geshi/email.php +++ b/src/geshi/email.php @@ -156,9 +156,15 @@ $language_data = array ( 3 => array( 'DISALLOWED_BEFORE' => '(?<![:=])', 'DISALLOWED_AFTER' => '(?=\s*:)', + ), + 4 => array( + 'DISALLOWED_BEFORE' => '(?<=\s)', + 'DISALLOWED_AFTER' => '(?=\s|\b)', ) ), 'ENABLE_FLAGS' => array( + 'BRACKETS' => GESHI_NEVER, + 'COMMENTS' => GESHI_NEVER, 'NUMBERS' => GESHI_NEVER ) )
fix: kw group 4 sometimes getting highlighted in the wrong places opt: Turned of unnecessary highlighting functions
GeSHi_geshi-1.0
train
php
f8f63e628674fcb6755e9ef50bea1d148ba49ac2
diff --git a/workflow/controller/controller.go b/workflow/controller/controller.go index <HASH>..<HASH> 100644 --- a/workflow/controller/controller.go +++ b/workflow/controller/controller.go @@ -192,6 +192,10 @@ var indexers = cache.Indexers{ // Run starts an Workflow resource controller func (wfc *WorkflowController) Run(ctx context.Context, wfWorkers, workflowTTLWorkers, podWorkers, podCleanupWorkers int) { defer runtimeutil.HandleCrash(runtimeutil.PanicHandlers...) + + ctx, cancel := context.WithCancel(ctx) + defer cancel() + defer wfc.wfQueue.ShutDown() defer wfc.podQueue.ShutDown() defer wfc.podCleanupQueue.ShutDown() @@ -240,7 +244,6 @@ func (wfc *WorkflowController) Run(ctx context.Context, wfWorkers, workflowTTLWo } logCtx := log.WithField("id", nodeID) - var cancel context.CancelFunc leaderName := "workflow-controller" if wfc.Config.InstanceID != "" { leaderName = fmt.Sprintf("%s-%s", leaderName, wfc.Config.InstanceID)
fix(controller): Handling panic in leaderelection (#<I>)
argoproj_argo
train
go
4451e81bfe36fb798c4f3bbf892bd17061dcb157
diff --git a/jobs/registry-change.js b/jobs/registry-change.js index <HASH>..<HASH> 100644 --- a/jobs/registry-change.js +++ b/jobs/registry-change.js @@ -49,15 +49,21 @@ module.exports = async function ( } const oldDistTags = npmDbDoc.distTags || {} - // which distTag has changed - const distTag = _.findKey(distTags, (version, tag) => { - const oldVersion = oldDistTags[tag] - if (!oldVersion) { - log.info(`exited: nothing to update, is first release of ${dependency}`) - return true - } - return semver.lt(oldVersion, version) - }) + let distTag + + if (force) { + distTag = 'latest' + } else { + // which distTag has changed + distTag = _.findKey(distTags, (version, tag) => { + const oldVersion = oldDistTags[tag] + if (!oldVersion) { + log.info(`exited: nothing to update, is first release of ${dependency}`) + return true + } + return semver.lt(oldVersion, version) + }) + } if (!distTag) { log.info(`exited: ${dependency} has no distTag`)
fix(reg-change): set distTag on force
greenkeeperio_greenkeeper
train
js
9889c0db2fa8d429367697bd51eba76742fd0cfc
diff --git a/build/travis-greenkeeper.js b/build/travis-greenkeeper.js index <HASH>..<HASH> 100644 --- a/build/travis-greenkeeper.js +++ b/build/travis-greenkeeper.js @@ -4,6 +4,7 @@ const { syncAll } = require('./update-nested-deps') const BRANCH = process.env.TRAVIS_PULL_REQUEST_BRANCH || '' const REPO = process.env.TRAVIS_REPO_SLUG +console.log('Current PR branch is:', BRANCH || '(empty)') if (!BRANCH.startsWith('greenkeeper/')) { console.log('Not a Greenkeeper PR, exiting.') process.exit(0)
chore(travis): log current PR branch for debugging
vk-x_vk-x
train
js
3f38bc1d94b7813db6f18fe7a1c53ba1f6b5631a
diff --git a/packages/site/pages/roadmap.js b/packages/site/pages/roadmap.js index <HASH>..<HASH> 100644 --- a/packages/site/pages/roadmap.js +++ b/packages/site/pages/roadmap.js @@ -19,7 +19,7 @@ import { const work = { now: [ { - title: 'Progress Loader', + title: 'Non-React CSS Support', tags: ['Component'] }, { @@ -38,10 +38,6 @@ const work = { tags: ['Component'] }, { - title: 'Switch', - tags: ['Component'] - }, - { title: 'Tooltip / Popover', tags: ['Component'] },
refactor(site): update roadmap
pluralsight_design-system
train
js
ab84dc0037355637451eda34eee55c866388dd36
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -395,7 +395,8 @@ function connect(options, cb) { var timer = setTimeout(function() { if (req) { req.emit('error', new Error('Timeout')); - req.abort(); + req.destroy(); + req.socket && req.socket.destroy(); } }, CONN_TIMEOUT); var req = httpModule.request(proxyOptions); diff --git a/lib/plugins/index.js b/lib/plugins/index.js index <HASH>..<HASH> 100644 --- a/lib/plugins/index.js +++ b/lib/plugins/index.js @@ -820,6 +820,7 @@ function getPipe(type, hookName) { var destroy = function() { if (client) { client.destroy(); + client.socket && client.socket.destroy(); client = null; } };
refactor: ensure to close the connection
avwo_whistle
train
js,js
ad1148a5b33018a8c049b18b944baf5e4800411c
diff --git a/lib/get-api.js b/lib/get-api.js index <HASH>..<HASH> 100644 --- a/lib/get-api.js +++ b/lib/get-api.js @@ -56,7 +56,6 @@ function getApi (state) { // helpers request: require('./request').bind(this, state), log: log, - plugin: require('./plugin'), // events on: require('./events').on.bind(this, state), @@ -65,6 +64,8 @@ function getApi (state) { trigger: require('./events').trigger.bind(this, state) } + api.plugin = require('./plugin').bind(null, api, state) + internals.init(api) return api diff --git a/lib/plugin.js b/lib/plugin.js index <HASH>..<HASH> 100644 --- a/lib/plugin.js +++ b/lib/plugin.js @@ -1,15 +1,13 @@ -module.exports = function pluginMethod (plugin) { - var self = this - +module.exports = function pluginMethod (hoodie, options, plugin) { if (typeof plugin === 'function') { - plugin(self) + plugin(hoodie, options) } if (typeof plugin === 'object') { Object.keys(plugin).forEach(function (key) { - self[key] = plugin[key] + hoodie[key] = plugin[key] }) } - return self + return hoodie }
feat(plugin): pass options We now pass the options of the `Hoodie` constructor as second argument to the `hoodie.plugin(plugin)` function ```js hoodie.plugin(function (hoodie, options) { hoodie.myMethod = function () { // do something with options here } }) ```
hoodiehq_hoodie-client
train
js,js
6c998aa4f2ee7d998a0fbd8613b9d62ccf6d3492
diff --git a/npm/index.js b/npm/index.js index <HASH>..<HASH> 100644 --- a/npm/index.js +++ b/npm/index.js @@ -15,20 +15,4 @@ function getElectronPath () { } } -// A list of the main modules the people will attempt to use from the Electron API, this is not a complete list but should cover most -// use cases. -var electronModuleNames = ['app', 'autoUpdater', 'BrowserWindow', 'ipcMain', 'Menu', 'net', 'Notification', 'systemPreferences', 'Tray'] -var electronPath = new String(getElectronPath()) - -electronModuleNames.forEach(function warnOnElectronAPIAccess (apiKey) { - Object.defineProperty(electronPath, apiKey, { - enumerable: false, - configurable: false, - get: function getElectronAPI () { - console.warn('WARNING: You are attempting to access an Electron API from a node environment.\n\n' + - 'You need to use the "electron" command to run your app. E.g. "npx electron ./myapp.js"') - } - }) -}) - -module.exports = electronPath +module.exports = getElectronPath()
fix: fix Electron not starting in development from the CLI (#<I>)
electron_electron
train
js
c7a69cd352af975d6cda587fb2d1282da37718e1
diff --git a/ibis/backends/tests/test_generic.py b/ibis/backends/tests/test_generic.py index <HASH>..<HASH> 100644 --- a/ibis/backends/tests/test_generic.py +++ b/ibis/backends/tests/test_generic.py @@ -397,3 +397,8 @@ def test_dropna_table(backend, alltypes, how, subset): # is type object in Pyspark, and type bool in Pandas. This diff does # not exist in Java 11. backend.assert_frame_equal(result, expected, check_dtype=False) + + +def test_select_sort_sort(alltypes): + query = alltypes[alltypes.year, alltypes.bool_col] + query = query.sort_by(query.year).sort_by(query.bool_col) diff --git a/ibis/expr/operations/relations.py b/ibis/expr/operations/relations.py index <HASH>..<HASH> 100644 --- a/ibis/expr/operations/relations.py +++ b/ibis/expr/operations/relations.py @@ -481,7 +481,7 @@ class Selection(TableNode, sch.HasSchema): self.table, self.selections, predicates=self.predicates, - sort_keys=self.sort_keys + resolved_keys, + sort_keys=self.sort_keys + tuple(resolved_keys), ) return Selection(expr, [], sort_keys=resolved_keys)
fix: regression in Selection.sort_by with resolved_keys
ibis-project_ibis
train
py,py
084b5fad2421c98bc7eba74c9891506a7a509e8a
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -108,7 +108,8 @@ quest.fetch = function(url, headers) { } quest.json = function(url, headers) { - const res = quest.stream(url, headers) + const res = typeof url == 'string' ? + quest.stream(url, headers) : url return new Promise((resolve, reject) => { res.on('error', reject) concat(res, (body) => {
feat: let `quest.json` take a readable stream
aleclarson_quest
train
js
2527117fa7e7a43e5748e83fcae04eeffd3a3af8
diff --git a/src/FieldGroup/FieldGroup.js b/src/FieldGroup/FieldGroup.js index <HASH>..<HASH> 100644 --- a/src/FieldGroup/FieldGroup.js +++ b/src/FieldGroup/FieldGroup.js @@ -16,9 +16,12 @@ const styles = theme => ({ flexBasis: 0 }, '& input': { - '&, &:disabled, &:enabled:hover, &:enabled:focus': { + '&, &:disabled, &:enabled:hover': { borderColor: 'transparent', backgroundColor: 'transparent' + }, + '&:enabled:focus': { + backgroundColor: 'transparent' } }, '& > :nth-child(n+2)': {
fix(FieldGroup): fix focus input borders
rambler-digital-solutions_rambler-ui
train
js
2ccf8d3457774fd85d190fbc82f39417dfa42ef1
diff --git a/lib/module.js b/lib/module.js index <HASH>..<HASH> 100644 --- a/lib/module.js +++ b/lib/module.js @@ -10,7 +10,7 @@ async function redirectModule(moduleOptions) { const initialRules = Object.assign([], this.options.redirect, moduleOptions) // Transform each "from" value to a RegExp for later test - const regExpRules = initialRules.map(o => Object.assign(o, { from: new RegExp(o.from) })) + const regExpRules = initialRules.map(o => ({ ...o, from: new RegExp(o.from) })) const middleware = require('./middleware.js')(regExpRules) this.addServerMiddleware(middleware)
refactor: use object spread (#<I>)
nuxt-community_redirect-module
train
js
4b6f137b1b826687a40f42d9414f2015a362bab1
diff --git a/views/cypress/support/resourceTree.js b/views/cypress/support/resourceTree.js index <HASH>..<HASH> 100644 --- a/views/cypress/support/resourceTree.js +++ b/views/cypress/support/resourceTree.js @@ -1,6 +1,3 @@ -import selectors from "../../../../taoItems/views/cypress/utils/selectors"; -import urls from "../../../../taoItems/views/cypress/utils/urls"; - /** * This program is free software; you can redistribute it and/or * modify it under the terms of the GNU General Public License @@ -43,7 +40,8 @@ Cypress.Commands.add('setup', ( .getSettled(`${ rootSelector } a`) .first() .click() - .wait('@editClassLabel'); + .wait('@editClassLabel') + .wait('@treeRender'); }); /**
chore: Remove not-used dependencies
oat-sa_tao-core
train
js
277c82dd7c5a2028c1b2ff541f66ab1fc823f079
diff --git a/test/renderer/reducers/document-spec.js b/test/renderer/reducers/document-spec.js index <HASH>..<HASH> 100644 --- a/test/renderer/reducers/document-spec.js +++ b/test/renderer/reducers/document-spec.js @@ -655,3 +655,29 @@ describe('changeCellType', () => { expect(state.document).to.equal(originalState.document); }); }); + +describe('toggleOutputExpansion', () => { + it('changes outputExpanded set', () => { + let cellStatuses = new Map(); + monocellDocument.getIn(['notebook', 'cellOrder']).map((cellID) => { + cellStatuses = cellStatuses.setIn([cellID, 'outputExpanded'], false) + return cellStatuses; + }); + + const docWithStatuses = monocellDocument.set('cellStatuses', cellStatuses); + + const originalState = { + document: docWithStatuses, + }; + + const id = originalState.document.getIn(['notebook', 'cellOrder']).first(); + + const action = { + type: constants.TOGGLE_OUTPUT_EXPANSION, + id: id, + }; + + const state = reducers(originalState, action); + expect(state.document.getIn(['notebook', 'cellMap', id, 'outputExpanded'])).to.be.true; + }); +});
test(reducers): Add toggleOutputExpansion test
nteract_nteract
train
js
d2dbe18f98003ed46ebcad782fcebefc560650b1
diff --git a/packages/bonde-public/next.config.js b/packages/bonde-public/next.config.js index <HASH>..<HASH> 100644 --- a/packages/bonde-public/next.config.js +++ b/packages/bonde-public/next.config.js @@ -1,8 +1,15 @@ +const { parsed: localEnv } = require('dotenv').config() +const webpack = require('webpack') const withSass = require('@zeit/next-sass') const withCSS = require('@zeit/next-css') module.exports = withCSS(withSass({ webpack: (config) => { + // config environment by .env + config.plugins.push( + new webpack.EnvironmentPlugin(localEnv) + ) + // url-loader config.module.rules.push({ test: /\.(png|svg|eot|otf|ttf|woff|woff2)$/, use: {
chore(public): config dotenv with next
nossas_bonde-client
train
js
19efe79edd4c04527448e476d83fc43bac2907db
diff --git a/registry/machine.go b/registry/machine.go index <HASH>..<HASH> 100644 --- a/registry/machine.go +++ b/registry/machine.go @@ -58,8 +58,10 @@ func (r *EtcdRegistry) GetMachineState(machID string) *machine.MachineState { // Push Machine object to etcd func (r *EtcdRegistry) SetMachineState(ms machine.MachineState, ttl time.Duration) (uint64, error) { - //TODO: Handle the error generated by marshal - json, _ := marshal(ms) + json, err := marshal(ms) + if err != nil { + return uint64(0), err + } key := path.Join(r.keyPrefix, machinePrefix, ms.ID, "object") // Assume state is already present, returning on success
fix(registry): tiny fix only thing left from the splitting the hearbeat/machineState idea
coreos_fleet
train
go
5e5fcc3f54192fe38909005b3b8720d7d4022e6c
diff --git a/src/inscriptis/metadata.py b/src/inscriptis/metadata.py index <HASH>..<HASH> 100644 --- a/src/inscriptis/metadata.py +++ b/src/inscriptis/metadata.py @@ -4,4 +4,4 @@ __author__ = 'Albert Weichselbraun, Fabian Odoni' __author_email__ = 'albert.weichselbraun@fhgr.ch, fabian.odoni@fhgr.ch' __copyright__ = '2016-2021 Albert Weichselbraun, Fabian Odoni' __license__ = 'Apache 2.0' -__version__ = '2.0rc2' +__version__ = '2.0.0'
fix: bumped version number. (#<I>)
weblyzard_inscriptis
train
py
d0a1489073084d1c674b5ba2a449afd921915525
diff --git a/packages/ui/webpack/webpack.js b/packages/ui/webpack/webpack.js index <HASH>..<HASH> 100644 --- a/packages/ui/webpack/webpack.js +++ b/packages/ui/webpack/webpack.js @@ -90,16 +90,11 @@ class WebpackServer { * Run webpack locally, assuming production environment. */ async initWebpackProd () { - await new Promise((resolve, reject) => { - const timer = new Date() - webpack([this.config.client, this.config.server], (err, stats) => { - if (err || stats.hasErrors()) { - return reject(err || stats.toJson().errors) - } - cubic.log.monitor('Webpack build successful', true, `${new Date() - timer}ms`) - resolve() - }) - }) + const timer = new Date() + const build = webpack([this.config.client, this.config.server]) + const compile = promisify(build.run).bind(build) + await compile() + cubic.log.monitor('Webpack build successful', true, `${new Date() - timer}ms`) } /**
style: Simplify production webpack build script.
cubic-js_cubic
train
js
7baf6a648dc86c3037f9547a8edc7c9a13b2ebf4
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -2,15 +2,28 @@ from __future__ import unicode_literals from setuptools import setup +import io +import os + +pkg_dir = os.path.dirname(__file__) # importing __<vars>__ into the namespace #https://packaging.python.org/guides/single-sourcing-package-version/#single-sourcing-the-version -with open('opentargets_validator/version.py') as fv: +with open(os.path.join(pkg_dir, 'opentargets_validator', 'version.py')) as fv: exec(fv.read()) + +long_description = "" +readme_path = os.path.join(pkg_dir, 'README.md') +with io.open(readme_path, encoding='utf-8') as readme_file: + long_description = readme_file.read() + + setup(name=__pkgname__, version=__version__, description=__description__, + long_description=long_description, + long_description_content_type='text/markdown; charset=UTF-8', author=__author__, author_email=__author_email__, url=__homepage__,
feat: improve long description for a more complete pypi
opentargets_validator
train
py
b29b0833e9e68b7d20d46bb51cd061e663955b83
diff --git a/redis/conn_test.go b/redis/conn_test.go index <HASH>..<HASH> 100644 --- a/redis/conn_test.go +++ b/redis/conn_test.go @@ -38,10 +38,14 @@ type testConn struct { writeDeadline time.Time } -func (*testConn) Close() error { return nil } -func (*testConn) LocalAddr() net.Addr { return nil } -func (*testConn) RemoteAddr() net.Addr { return nil } -func (c *testConn) SetDeadline(t time.Time) error { c.readDeadline = t; c.writeDeadline = t; return nil } +func (*testConn) Close() error { return nil } +func (*testConn) LocalAddr() net.Addr { return nil } +func (*testConn) RemoteAddr() net.Addr { return nil } +func (c *testConn) SetDeadline(t time.Time) error { + c.readDeadline = t + c.writeDeadline = t + return nil +} func (c *testConn) SetReadDeadline(t time.Time) error { c.readDeadline = t; return nil } func (c *testConn) SetWriteDeadline(t time.Time) error { c.writeDeadline = t; return nil }
fix: Formatting issues on tip (#<I>) Fix some formatting issue when testing on tip.
gomodule_redigo
train
go
4871e2dca3bc3d94ac2fbc0c0166449a5293d4be
diff --git a/packages/helpers/classes/mail.js b/packages/helpers/classes/mail.js index <HASH>..<HASH> 100644 --- a/packages/helpers/classes/mail.js +++ b/packages/helpers/classes/mail.js @@ -121,7 +121,7 @@ class Mail { if (typeof from === 'undefined') { return; } - if (typeof from !== 'object' || typeof from.email !== 'string') { + if (typeof from !== 'string' && typeof from.email !== 'string') { throw new Error('String or address object expected for `from`'); } this.from = EmailAddress.create(from); @@ -134,7 +134,7 @@ class Mail { if (typeof replyTo === 'undefined') { return; } - if (typeof replyTo !== 'object' || typeof replyTo.email !== 'string') { + if (typeof replyTo !== 'string' && typeof replyTo.email !== 'string') { throw new Error('String or address object expected for `replyTo`'); } this.replyTo = EmailAddress.create(replyTo);
fix: correct the email address type checks
sendgrid_sendgrid-nodejs
train
js
c2fd1597bdebbfe878aefba4bea5f37d7b14b9e9
diff --git a/languagetool-wikipedia/src/main/java/org/languagetool/dev/wikipedia/atom/MatchDatabase.java b/languagetool-wikipedia/src/main/java/org/languagetool/dev/wikipedia/atom/MatchDatabase.java index <HASH>..<HASH> 100644 --- a/languagetool-wikipedia/src/main/java/org/languagetool/dev/wikipedia/atom/MatchDatabase.java +++ b/languagetool-wikipedia/src/main/java/org/languagetool/dev/wikipedia/atom/MatchDatabase.java @@ -67,7 +67,7 @@ class MatchDatabase { } else { prepSt.setString(7, "<no category>"); } - prepSt.setString(8, ruleMatch.getErrorContext()); + prepSt.setString(8, StringUtils.abbreviate(ruleMatch.getErrorContext(), 500)); prepSt.setTimestamp(9, new Timestamp(ruleMatch.getEditDate().getTime())); prepSt.setLong(10, ruleMatch.getDiffId()); prepSt.execute();
fix: limit length of error context (to avoid MySQL error)
languagetool-org_languagetool
train
java
87bf33c603f8d7fe1b8d412a189b97760ca0a46e
diff --git a/src/lib/customPropTypes.js b/src/lib/customPropTypes.js index <HASH>..<HASH> 100644 --- a/src/lib/customPropTypes.js +++ b/src/lib/customPropTypes.js @@ -203,7 +203,7 @@ export const itemShorthand = (...args) => every([ /** * Collection shorthand ensures a prop is an array of item shorthand. */ -export const itemsShorthand = (...args) => every([ +export const collectionShorthand = (...args) => every([ disallow(['children']), PropTypes.arrayOf(itemShorthand), ])(...args)
fix(customPropTypes): itemsShorthand -> collectionShorthand (#<I>)
Semantic-Org_Semantic-UI-React
train
js
472f9ccaa16776c6661189e6a5bb0b11fd4768cd
diff --git a/lib/attach/attachment.rb b/lib/attach/attachment.rb index <HASH>..<HASH> 100644 --- a/lib/attach/attachment.rb +++ b/lib/attach/attachment.rb @@ -75,13 +75,21 @@ module Attach child(role) || self end + # rubocop:disable Metrics/AbcSize def add_child(role, &block) - attachment = children.build(attributes.slice(:owner, :file_name, :file_type, :disposition, :cache_type, - :cache_max_age, :type)) + attachment = children.build attachment.role = role + attachment.owner = owner + attachment.file_name = file_name + attachment.file_type = file_type + attachment.disposition = disposition + attachment.cache_type = cache_type + attachment.cache_max_age = cache_max_age + attachment.type = type block.call(attachment) attachment.save! end + # rubocop:enable Metrics/AbcSize # rubocop:disable Metrics/AbcSize def copy_attributes_from_file(file)
fix: fixes Attachment#add_child (This needs a test!)
adamcooke_attach
train
rb
24152e460af299c1095cdcf1bb33d5331782af6f
diff --git a/src/Parameter/OrderBy.php b/src/Parameter/OrderBy.php index <HASH>..<HASH> 100644 --- a/src/Parameter/OrderBy.php +++ b/src/Parameter/OrderBy.php @@ -24,7 +24,7 @@ class OrderBy implements ParameterInterface /** * @param PropertyInterface $property - * @param string $direction The direction of sort - either SORT_ASC or SORT_DESC + * @param int $direction The direction of sort - either SORT_ASC or SORT_DESC */ public function __construct(PropertyInterface $property, $direction = SORT_ASC) {
chore: Fix docblock on orderby constructor (#<I>)
usemarkup_contentful
train
php
50f92bb0cd276e0ce8b4588db451ddce58783bb9
diff --git a/test/loader/mixin/load_plugin.test.js b/test/loader/mixin/load_plugin.test.js index <HASH>..<HASH> 100644 --- a/test/loader/mixin/load_plugin.test.js +++ b/test/loader/mixin/load_plugin.test.js @@ -16,6 +16,15 @@ describe('test/load_plugin.test.js', function() { afterEach(mm.restore); afterEach(() => app.close()); + it('should exports allPlugins, appPlugins, customPlugins', () => { + app = utils.createApp('plugin'); + const loader = app.loader; + loader.loadPlugin(); + assert('allPlugins' in loader); + assert('appPlugins' in loader); + assert('customPlugins' in loader); + }); + it('should loadConfig all plugins', function() { const baseDir = utils.getFilepath('plugin'); app = utils.createApp('plugin');
test: add testcase for appPlugins and customPlugins (#<I>)
eggjs_egg-core
train
js
7c0fed3c4668d1707c50ae292a376907bfe5f80a
diff --git a/test/instrumentation/modules/hapi.js b/test/instrumentation/modules/hapi.js index <HASH>..<HASH> 100644 --- a/test/instrumentation/modules/hapi.js +++ b/test/instrumentation/modules/hapi.js @@ -7,6 +7,11 @@ var agent = require('../../..').start({ captureExceptions: false }) +var semver = require('semver') + +// hapi doesn't work in versions of Node.js prior to v4 +if (!semver.satisfies(process.version, '>=4')) process.exit() + var test = require('tape') var http = require('http') var Hapi = require('hapi')
test: only run hapi tests on Node.js v4 or newer
opbeat_opbeat-node
train
js
bb92a288a5b579dec7974fb7b87839aba001bf1c
diff --git a/src/WorkerPool.js b/src/WorkerPool.js index <HASH>..<HASH> 100644 --- a/src/WorkerPool.js +++ b/src/WorkerPool.js @@ -131,7 +131,7 @@ class PoolWorker { const { context, request, questionId } = message; const { data } = this.jobs[id]; data.resolve(context, request, (error, result) => { - this.worker.send({ + this.writeJson({ type: 'result', id: questionId, error,
fix(resolve): fix incorrect method for sending message
webpack-contrib_thread-loader
train
js
4172483c35c7d5a49135c5b1ed483aeebc73fab8
diff --git a/tornado/test/iostream_test.py b/tornado/test/iostream_test.py index <HASH>..<HASH> 100644 --- a/tornado/test/iostream_test.py +++ b/tornado/test/iostream_test.py @@ -973,9 +973,16 @@ class WaitForHandshakeTest(AsyncTestCase): server = server_cls(ssl_options=_server_ssl_options()) server.add_socket(sock) - client = SSLIOStream( - socket.socket(), ssl_options=dict(cert_reqs=ssl.CERT_NONE) - ) + ssl_ctx = ssl.create_default_context(ssl.Purpose.SERVER_AUTH) + ssl_ctx.check_hostname = False + ssl_ctx.verify_mode = ssl.CERT_NONE + # These tests fail with ConnectionAbortedErrors with TLS + # 1.3 on windows python 3.7.4 (which includes an upgrade + # to openssl 1.1.c. Other platforms might be affected with + # newer openssl too). Disable it until we figure out + # what's up. + ssl_ctx.options |= getattr(ssl, "OP_NO_TLSv1_3", 0) + client = SSLIOStream(socket.socket(), ssl_options=ssl_ctx) yield client.connect(("127.0.0.1", port)) self.assertIsNotNone(client.socket.cipher()) finally:
test: Disable TLS <I> in one test This test started failing on windows CI with an upgrade to python <I> (which bundles a newer version of openssl). Disable tls <I> for now. Possibly related to #<I>
tornadoweb_tornado
train
py
c357633df31e662ed7e22b3fd5731ccfe41dc9e6
diff --git a/src/utils/vnode.js b/src/utils/vnode.js index <HASH>..<HASH> 100644 --- a/src/utils/vnode.js +++ b/src/utils/vnode.js @@ -15,15 +15,28 @@ export function findModel (vnode) { return !!(vnode.data.directives) && find(vnode.data.directives, d => d.name === 'model'); } +function extractChildren (vnode) { + if (Array.isArray(vnode)) { + return vnode; + } + + if (Array.isArray(vnode.children)) { + return vnode.children; + } + + if (vnode.componentOptions && Array.isArray(vnode.componentOptions.children)) { + return vnode.componentOptions.children; + } + + return []; +} + export function extractVNodes (vnode) { if (findModel(vnode)) { return [vnode]; } - const children = Array.isArray(vnode) ? vnode : vnode.children; - if (!Array.isArray(children)) { - return []; - } + const children = extractChildren(vnode); return children.reduce((nodes, node) => { const candidates = extractVNodes(node);
fix: handle non-existing vnode children
baianat_vee-validate
train
js
571ef828e6c8515cd13ed1e9c0ea0330aae5c58c
diff --git a/builder/osc/bsusurrogate/step_snapshop_volumes.go b/builder/osc/bsusurrogate/step_snapshop_volumes.go index <HASH>..<HASH> 100644 --- a/builder/osc/bsusurrogate/step_snapshop_volumes.go +++ b/builder/osc/bsusurrogate/step_snapshop_volumes.go @@ -25,7 +25,7 @@ type StepSnapshotVolumes struct { func (s *StepSnapshotVolumes) snapshotVolume(ctx context.Context, deviceName string, state multistep.StateBag) error { oapiconn := state.Get("oapi").(*oapi.Client) ui := state.Get("ui").(packer.Ui) - vm := state.Get("vm").(*oapi.Vm) + vm := state.Get("vm").(oapi.Vm) var volumeId string for _, volume := range vm.BlockDeviceMappings {
fix: remove pointer when vm is getting
hashicorp_packer
train
go
b1a5ef8f8b139e89b3a966e6b583090cffd5531f
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -1,6 +1,8 @@ const p = require('path') // const printAST = require('ast-pretty-print') +const macrosRegex = /[./]macros(\.js)?$/ + module.exports = macrosPlugin function macrosPlugin() { @@ -11,7 +13,7 @@ function macrosPlugin() { const isMacros = looksLike(path, { node: { source: { - value: v => v.endsWith('.macros'), + value: v => macrosRegex.test(v), }, }, }) @@ -31,7 +33,7 @@ function macrosPlugin() { name: 'require', }, arguments: args => - args.length === 1 && args[0].value.endsWith('.macros'), + args.length === 1 && macrosRegex.test(args[0].value), }, parent: { type: 'VariableDeclarator',
feat: allow for files to simply be called macros
kentcdodds_babel-plugin-macros
train
js
557d1a93d6fd7bdd446c1fcddb64e2584e3a4d3a
diff --git a/packages/components/bolt-dropdown/src/dropdown.js b/packages/components/bolt-dropdown/src/dropdown.js index <HASH>..<HASH> 100644 --- a/packages/components/bolt-dropdown/src/dropdown.js +++ b/packages/components/bolt-dropdown/src/dropdown.js @@ -62,6 +62,16 @@ export class BoltDropdown extends BoltComponent() { window.addEventListener('resize', function () { elem.autoHeight(); }); + + this.addEventListener('activateLink', this.close); // Close dropdown automatically when an inner <bolt-navlink> component is clicked on + + document.addEventListener('click', function (e) { + if (elem.contains(e.target)) { + console.log('click inside of this'); + } else { + console.log(this.state); + } + }); } autoHeight() { @@ -75,8 +85,9 @@ export class BoltDropdown extends BoltComponent() { } close() { - // console.log('close dropdown'); - // this.dropdown.folds[0].close(); + if (this.dropdown && this.dropdown.folds[0]) { + this.dropdown.folds[0].close(); + } } get open() {
feat: add click event handlers to close when item selected
bolt-design-system_bolt
train
js
d8c85c4f8e23fbb5bc998d60a3e64afb93650164
diff --git a/karma.conf.js b/karma.conf.js index <HASH>..<HASH> 100644 --- a/karma.conf.js +++ b/karma.conf.js @@ -7,7 +7,7 @@ const launchers = process.env.KARMA_LAUNCHERS; module.exports = function karmaConfig(config) { const customLaunchers = { - SL_InternetExplorer: { + SL_Explorer: { base: 'SauceLabs', browserName: 'internet explorer', version: '11', @@ -47,7 +47,8 @@ module.exports = function karmaConfig(config) { frameworks: ['tap'], files: ['test/index.js'], preprocessors: { - 'test/**/*.{js,mjs}': ['rollup'], + 'test/**.{js,mjs}': ['rollup'], + 'src/**.{js,mjs}': ['rollup'], }, autoWatch: isDev, singleRun: !isDev,
chore: rollup src for tests and rename SL_InternetExplorer to SL_Explorer, faster to type
w33ble_history-extra
train
js
5df89959a068ade9f6c019467a5c3823122ed396
diff --git a/cid_test.go b/cid_test.go index <HASH>..<HASH> 100644 --- a/cid_test.go +++ b/cid_test.go @@ -584,3 +584,14 @@ func TestReadCidsFromBuffer(t *testing.T) { t.Fatal("had trailing bytes") } } + +func TestBadParse(t *testing.T) { + hash, err := mh.Sum([]byte("foobar"), mh.SHA3_256, -1) + if err != nil { + t.Fatal(err) + } + _, err = Parse(hash) + if err == nil { + t.Fatal("expected to fail to parse an invalid CIDv1 CID") + } +}
test: test parsing non-sha<I> hashes
ipfs_go-cid
train
go
aa5944b64f89e96980f63c0639bcae104dd87f17
diff --git a/src/router.js b/src/router.js index <HASH>..<HASH> 100644 --- a/src/router.js +++ b/src/router.js @@ -24,6 +24,7 @@ export class Router { routes: any[] = []; isNavigating: boolean = false; navigation: any[] = []; + currentInstruction: NavigationInstruction; constructor(container, history) { this.container = container;
chore(Router): added currentInstruction property
aurelia_router
train
js
3dd343ab2f904d651b2fb2c620580053edf4d4c1
diff --git a/actor-sdk/sdk-core-android/android-google-push/src/main/java/im/actor/push/PushManager.java b/actor-sdk/sdk-core-android/android-google-push/src/main/java/im/actor/push/PushManager.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core-android/android-google-push/src/main/java/im/actor/push/PushManager.java +++ b/actor-sdk/sdk-core-android/android-google-push/src/main/java/im/actor/push/PushManager.java @@ -12,11 +12,11 @@ import im.actor.sdk.core.ActorPushManager; public class PushManager implements ActorPushManager { private static final String TAG = "im.actor.push.PushManager"; - private boolean isRegistered; + private boolean isRegistered = false; @Override public void registerPush(final Context context) { - isRegistered = ActorSDK.sharedActor().getMessenger().getPreferences().getBool("push_registered", false); +// isRegistered = ActorSDK.sharedActor().getMessenger().getPreferences().getBool("push_registered", false); if (!isRegistered) { Log.d(TAG, "Requesting push token...");
fix(android): register push on every app launch
actorapp_actor-platform
train
java
b7edc2f94e2a9ca7cc9c3968137c0fa9855d76f5
diff --git a/tests/ref.py b/tests/ref.py index <HASH>..<HASH> 100644 --- a/tests/ref.py +++ b/tests/ref.py @@ -44,12 +44,15 @@ def backend_check(backend, ref=None, childprocess=True): ref='scrot' else: ref='pil' - if sys.platform != 'darwin': - - backend_ref(backend, - ref=ref, - childprocess=childprocess, - ) - backend_size(backend, - childprocess=childprocess, - ) + enable_ref=True + if sys.platform == 'darwin': + enable_ref=False # TODO + if enable_ref: + backend_ref(backend, + ref=ref, + childprocess=childprocess, + ) + else: + backend_size(backend, + childprocess=childprocess, + )
test: ref or size test, not both
ponty_pyscreenshot
train
py
8f98a08ee2da9a0238dcaf92ab786be77ae47b73
diff --git a/protocol-designer/src/components/FilePage.js b/protocol-designer/src/components/FilePage.js index <HASH>..<HASH> 100644 --- a/protocol-designer/src/components/FilePage.js +++ b/protocol-designer/src/components/FilePage.js @@ -19,10 +19,11 @@ export type FilePageProps = { } const FilePage = ({formConnector, isFormAltered, instruments, saveFileMetadata}: FilePageProps) => { - const handleSubmit = () => { + const handleSubmit = (e: SyntheticEvent<*>) => { // blur focused field on submit if (document && document.activeElement) document.activeElement.blur() saveFileMetadata() + e.preventDefault() } return ( <div className={styles.file_page}>
fix(protocol-designer): do not navigate on FilePage form submit - do not navigate on FilePage form submit (it made the page reload!)
Opentrons_opentrons
train
js
ece561a3155d94b1de2a212141c12826569418d1
diff --git a/bpmn-model/src/main/java/org/camunda/bpm/model/bpmn/builder/AbstractFlowNodeBuilder.java b/bpmn-model/src/main/java/org/camunda/bpm/model/bpmn/builder/AbstractFlowNodeBuilder.java index <HASH>..<HASH> 100644 --- a/bpmn-model/src/main/java/org/camunda/bpm/model/bpmn/builder/AbstractFlowNodeBuilder.java +++ b/bpmn-model/src/main/java/org/camunda/bpm/model/bpmn/builder/AbstractFlowNodeBuilder.java @@ -56,6 +56,11 @@ public abstract class AbstractFlowNodeBuilder<B extends AbstractFlowNodeBuilder< currentSequenceFlowBuilder = null; } + public B sequenceFlowId(String sequenceFlowId) { + getCurrentSequenceFlowBuilder().id(sequenceFlowId); + return myself; + } + private <T extends FlowNode> T createTarget(Class<T> typeClass, String identifier) { T target = createSibling(typeClass, identifier); connectTarget(target);
chore(fluent-api): add method to set the current sequence flow id
camunda_camunda-bpmn-model
train
java
e9260fe2cfc1dcd90b476744822192a7bc88ff12
diff --git a/system/Database/OCI8/Connection.php b/system/Database/OCI8/Connection.php index <HASH>..<HASH> 100644 --- a/system/Database/OCI8/Connection.php +++ b/system/Database/OCI8/Connection.php @@ -593,6 +593,7 @@ class Connection extends BaseConnection implements ConnectionInterface $primaryColumnType = $columnTypeList[$primaryColumnName]; if ($primaryColumnType !== 'NUMBER') { + $primaryColumnName = ''; continue; } }
feat: Fixed the problem that 1 is always returned when the type is not number.
codeigniter4_CodeIgniter4
train
php
cb1e3269c1a66a169c4b7d8e50e7ca1705179f36
diff --git a/censys/cli/commands/account.py b/censys/cli/commands/account.py index <HASH>..<HASH> 100644 --- a/censys/cli/commands/account.py +++ b/censys/cli/commands/account.py @@ -32,7 +32,7 @@ def cli_account(args: argparse.Namespace): # pragma: no cover quota = account["quota"] table.add_row( "Query Quota", - f"{quota['used']} / {quota['allowance']} ({quota['used']/quota['allowance']:.2f}%)", + f"{quota['used']} / {quota['allowance']} ({quota['used']/quota['allowance'] * 100 :.2f}%)", ) table.add_row("Quota Resets At", quota["resets_at"]) console.print(table)
fix(cli): Print correct percent
censys_censys-python
train
py