code stringlengths 41 34.3k | lang stringclasses 8
values | review stringlengths 1 4.74k |
|---|---|---|
@@ -1,9 +1,22 @@
+// eslint-disable-next-line
import React from 'react';
+import Nav from './Nav';
+import Feeds from './Feeds';
+import MainR from './MainR';
+import './Main.scss';
-class Main extends React.Component {
+class MainYoonHee extends React.Component {
render() {
- return null;
+ return (
+ ... | JavaScript | ๊ทธ ๋ ๋ง์ํด์ฃผ์
จ๋ ๋ถ๋ถ์ด๋ค์ฉ ใ
ใ
.. <div>๋ก ๋ณ๊ฒฝํ์ต๋๋น.. ์ฝ์์ฐฝ์ ๋จ๋ ์์์๋ ๋นจ๊ฐ์ ๊ธ์จ ์ค๋ฅ๊ฐ ์ด๊ฒ๋๋ฌธ์ด์๊ตฐ์ฉ ใ
ใ
index.html์์๋ body๋ถ๋ถ๊ณผ ์ถฉ๋ํด์์; ๊ธฐ๋ณธ์ ์ธ ๊ตฌ์กฐ๋ฅผ ์๊ฐํ๋ฉด ๋น์ฐํ๊ฑด๋ฐ ์ ๊ฐ ๋๋ฌด ์์ผํ๋ค์.. |
@@ -0,0 +1,25 @@
+import React from 'react';
+
+class Recommend extends React.Component {
+ render() {
+ const { nickname, img } = this.props;
+ return (
+ <li className="user main-right__user2">
+ <div className="user-and-botton">
+ <img
+ className="user__img user__img--brder-re... | JavaScript | ์์ ํ์จ๋ฏธ๋น~!๐ |
@@ -0,0 +1,22 @@
+import React from 'react';
+
+class Story extends React.Component {
+ render() {
+ const { nickname, img } = this.props;
+ return (
+ <li className="user main-right__user">
+ <img
+ className="user__img user__img--brder-red"
+ alt={nickname}
+ src={img}
+ ... | JavaScript | ์ฌ๊ธฐ๋์ฉ~ |
@@ -0,0 +1,281 @@
+/*------๊ณตํต-----*/
+/*------๊ณตํต-----*/
+
+.main-body {
+ background-color: var(--color-boxgray);
+}
+
+main {
+ display: flex;
+ margin-left: 100px;
+}
+
+ul > li {
+ margin: 10px 0;
+}
+
+a {
+ text-decoration: none;
+ color: inherit;
+}
+
+.box {
+ background-color: white;
+ border: 1px solid... | Unknown | common.scss ํ์ผ์ ์ด๋ฏธ ์์ด์ ํด๋น ๋ถ๋ถ ์ญ์ ํ์ด์ฉ ใ
...๐ฑ |
@@ -0,0 +1,51 @@
+import React from 'react';
+import { withRouter } from 'react-router-dom';
+
+class LoginForm extends React.Component {
+ constructor() {
+ super();
+ this.state = { id: '', ps: '' };
+ }
+
+ goToMain = e => {
+ this.props.history.push('/main-yoonhee');
+ };
+
+ handleInput = e => {
+ ... | JavaScript | ๋์๋ ๊ฐ์ ๋๋ถ์
๋๋น ใ
.ใ
|
@@ -0,0 +1,59 @@
+import React from 'react';
+import Comment from './Comment';
+
+class CommentBox extends React.Component {
+ constructor(props) {
+ super(props);
+ this.state = { feedComment: '', commentList: [] };
+ }
+
+ handleInput = e => {
+ this.setState({ [e.target.name]: e.target.value });
+ };
+
... | JavaScript | ๋ฐ์ดํฐ ๋ด์ฉ์ ๋ป์ ์ ์ ์๊ฒ comment๋ก ๋ณ๊ฒฝํ์ต๋๋ค! |
@@ -1,4 +1,4 @@
-import { EstimationInputDTO, Estimation } from '#estimations/estimation.types.js';
+import { EstimationInputDTO, Estimation, IsActivate } from '#estimations/estimation.types.js';
import { IEstimationRepository } from '#estimations/interfaces/estimation.repository.interface.js';
import { PrismaService... | TypeScript | ์๋ง๋ javascript ๋ ๋ฒจ์ด ์๋๋ผ prisma์์ findMany ํด์ค๋ ๋จ๊ณ์์ ์ด ์์
์ ํด์ ๊ฐ์ ธ์ฌ ์ ์์ ๊ฒ ๊ฐ์ต๋๋ค. ๋์ค์ ํ ๋ฒ ์ฐพ์๋ณด๋ฉด ์ข์ ๊ฒ ๊ฐ๋ค์. |
@@ -1,4 +1,4 @@
-import { EstimationInputDTO, Estimation } from '#estimations/estimation.types.js';
+import { EstimationInputDTO, Estimation, IsActivate } from '#estimations/estimation.types.js';
import { IEstimationRepository } from '#estimations/interfaces/estimation.repository.interface.js';
import { PrismaService... | TypeScript | ๋ค!! ์ฐพ์๋ณด๊ฒ ์ต๋๋ค !! ํ์๋ ์๋ ค์ฃผ์
์ ๊ฐ์ฌํฉ๋๋ค!!!! |
@@ -3,8 +3,10 @@ import { ParsedUrlQuery } from "querystring";
import { GetServerSideProps } from "next";
import { useState } from "react";
import { useQuery } from "@tanstack/react-query";
+import { getReviewStat, getReviews } from "@/lib/api/ReviewService";
import { getTrainerInfo } from "@/lib/api/trainerService... | Unknown | ```js
useQuery(["review-stat", trainerId],
() => getReviewStat(trainerId as string),
{ enabled: !!trainerId,
cacheTime: 5 * 60 * 1000,
staleTime: 5 * 60 * 1000 });
```
๋ก ํด์ฃผ์๋๊ฒ ์ข์๋ณด์ฌ์. |
@@ -3,8 +3,10 @@ import { ParsedUrlQuery } from "querystring";
import { GetServerSideProps } from "next";
import { useState } from "react";
import { useQuery } from "@tanstack/react-query";
+import { getReviewStat, getReviews } from "@/lib/api/ReviewService";
import { getTrainerInfo } from "@/lib/api/trainerService... | Unknown | ๋ต ์์ ํ๊ฒ ์ต๋๋ค! |
@@ -15,7 +15,7 @@ const CenterWrapper = styled.div`
overflow: scroll;
height: calc(100dvh - 126px);
align-items: center;
- justigy-content: space-between;
+ justify-content: space-between;
padding-top: 80px;
&::-webkit-scrollbar {
display: none;
@@ -155,47 +155,52 @@ const ReviewPage = () => {
... | Unknown | `handleSubmit`์ ์๋ ๋ฆฌ๋ทฐ ๋ฑ๋ก api ๋ก์ง๋ `review.ts`ํ์ผ์ ๋ถ๋ฆฌํ๋ฉด ๊ฐ๋
์ฑ์ด ๋ ์ข์ ๊ฒ ๊ฐ์์! |
@@ -15,7 +15,7 @@ const CenterWrapper = styled.div`
overflow: scroll;
height: calc(100dvh - 126px);
align-items: center;
- justigy-content: space-between;
+ justify-content: space-between;
padding-top: 80px;
&::-webkit-scrollbar {
display: none;
@@ -155,47 +155,52 @@ const ReviewPage = () => {
... | Unknown | ๊ทธ๋ฆฌ๊ณ ์ฑ๊ณต ์ ํ์ด์ง ์ด๋ ์ฝ๋๊ฐ ๋๋ฝ๋ ๊ฒ ๊ฐ์ต๋๋ค! |
@@ -37,14 +37,14 @@ export const showReviewRating = async (
// ์ฐ์ฑ
๋ก ๋ฆฌ๋ทฐ ๋ด์ฉ๋ณด๊ธฐ api
export const showReviewContent = async (
walkwayId: string,
- type: string
+ sort: string
): Promise<{
reviews: ReviewContentType[];
}> => {
try {
const response = await instance.get<
ApiResponseFormat<{ reviews: R... | TypeScript | `showReviewContent` ํธ์ถ ์ ์๋ต์ผ๋ก ๋ฐ์์ค๋ `period` ํ๋๊ฐ ui ์ปดํฌ๋ํธ์ ๋๋ฝ๋ ๊ฒ ๊ฐ์์! |
@@ -0,0 +1,83 @@
+@import '../../../../../Styles/common.scss';
+
+.navYeseul {
+ position: fixed;
+ top: 0;
+ left: 50%;
+ right: 0;
+ transform: translateX(-50%);
+ padding: 8px 0;
+ border-bottom: 1px solid $main-border;
+ background-color: #fff;
+ z-index: 9999;
+
+ .inner-nav {
+ display: flex;
+ ju... | Unknown | css ์์ฑ ์์์ ๋ฐ๋ฅด๋ฉด z-index๊ฐ ๊ฐ์ฅ ์๋์ ์์ผ ํ ๊ฒ ๊ฐ์์ ๐ |
@@ -0,0 +1,83 @@
+@import '../../../../../Styles/common.scss';
+
+.navYeseul {
+ position: fixed;
+ top: 0;
+ left: 50%;
+ right: 0;
+ transform: translateX(-50%);
+ padding: 8px 0;
+ border-bottom: 1px solid $main-border;
+ background-color: #fff;
+ z-index: 9999;
+
+ .inner-nav {
+ display: flex;
+ ju... | Unknown | common css์ ์์ด์ ๋นผ์
๋ ๋ ๊ฒ ๊ฐ์์! |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | ๋ํ
์ผ....๐๐ |
@@ -0,0 +1,140 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import User from '../User/User';
+import Comment from '../Comment/Comment';
+import IconButton from '../Button/IconButton';
+import { API } from '../../../../../config';
+import './Feed.scss';
+
+class Feed extends C... | JavaScript | ์คํ ์์ฌ๋์ filter๋ก ๊ตฌํํ์
จ๋ค์ฌ! :) |
@@ -0,0 +1,140 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import User from '../User/User';
+import Comment from '../Comment/Comment';
+import IconButton from '../Button/IconButton';
+import { API } from '../../../../../config';
+import './Feed.scss';
+
+class Feed extends C... | JavaScript | id๊ฐ์ผ๋ก key props ํ ๋น ๐ ๐ฏ ๐ฅ |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | checkId์ ๋ค์ด๊ฐ๋๋ฐ์ดํฐ๋ ์ด๋ค๊ฑธ ์๋ฏธํ๋๊ฑด๊ฐ์ฌ???? |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | > checkId์ ๋ค์ด๊ฐ๋๋ฐ์ดํฐ๋ ์ด๋ค๊ฑธ ์๋ฏธํ๋๊ฑด๊ฐ์ฌ????
์
๋ ฅํ ์์ด๋๊ฐ ์ด๋ฉ์ผ ํ์์ ๋ง๋์ง ์ฒดํฌํ๋ ์ ๊ทํํ์์ด์์! ๋ค์ด๋ฐ์ด ์ง๊ด์ ์ด์ง ์์๊ฐ์?? |
@@ -0,0 +1,83 @@
+@import '../../../../../Styles/common.scss';
+
+.navYeseul {
+ position: fixed;
+ top: 0;
+ left: 50%;
+ right: 0;
+ transform: translateX(-50%);
+ padding: 8px 0;
+ border-bottom: 1px solid $main-border;
+ background-color: #fff;
+ z-index: 9999;
+
+ .inner-nav {
+ display: flex;
+ ju... | Unknown | ์ค ๊ผผ๊ผผํ ๋ด์ฃผ์
จ๋ค์ ๊ฐ์ฌํฉ๋๋น :) ๊ณ ์น๋ฌ๊ฐ์ |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | (์๋ฃ์ผ๋ฉด ์ค๋ฅ๊ฐ ๋จ๋๋ผ๊ตฌ์..) |
@@ -0,0 +1,83 @@
+@import '../../../../../Styles/common.scss';
+
+.navYeseul {
+ position: fixed;
+ top: 0;
+ left: 50%;
+ right: 0;
+ transform: translateX(-50%);
+ padding: 8px 0;
+ border-bottom: 1px solid $main-border;
+ background-color: #fff;
+ z-index: 9999;
+
+ .inner-nav {
+ display: flex;
+ ju... | Unknown | ์ ์ common์ ์์ฃ ?!?! |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | ์๋์์ฌ ์ ๊ฐ ์๋ชฐ๋์ด์ ใ
ใ
ใ
ใ
์ํ์
จ์ด์!! |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | ์ ๋ ์ด๋ฒคํธ๋ฅผ ์ค input์ name attribute๋ฅผ ๋ถ์ฌํด์ handleInputId์ด๋ handleInputPw ํจ์๋ฅผ ํ๋๋ก ํฉ์ณค๋๋ฐ ์ฐธ๊ณ ํ์
์ ๋ฐ์ํด๋ ์ข์ ๊ฒ ๊ฐ์์ค!
handleInput = e => {
this.setState({
[e.target.name]: e.target.value,
});
}; |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | - API ๋ถ๋ ์ดํ์ src/config.js ํ์ผ์ ๋ง๋ค์ด ํด๋น ํ์ผ์์ ์ผ๊ด์ ์ผ๋ก ๊ด๋ฆฌํฉ๋๋ค.
```js
// config.js
const IP = '10.58.6.252:8000';
export const SIGN_IN_API = `http://${IP}/user/signin`;
// Login.js
import { SIGN_IN_API } from '../../config.js';
...
fetch(SIGN_IN_API).then().then()
...
```
- ์์ ๊ฐ์ด config.js ์์ ์ผ๊ด์ ์ผ๋ก ๊ด๋ฆฌํ ๊ฒฝ์ฐ... |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | - ์ ๊ท์ ๐ ๐ |
@@ -0,0 +1,125 @@
+import React, { Component } from 'react';
+import { withRouter } from 'react-router-dom';
+import { API } from '../../../config';
+import './Login.scss';
+
+class LoginYeseul extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ inputId: '',
+ inputPw: '',
+ ... | JavaScript | - ํด๋์ค ๋ค์ ๋ค์ด๋ฐ ๐ |
@@ -0,0 +1,60 @@
+@import '../../../Styles/common.scss';
+
+.loginYeseul {
+ position: fixed;
+ top: 50%;
+ left: 50%;
+ transform: translate(-50%, -60%);
+ padding: 32px 0 25px;
+ width: 350px;
+ text-align: center;
+
+ h1 {
+ font-size: 40px;
+ }
+
+ .login-form {
+ margin: 35px 40px 120px;
+
+ &__... | Unknown | - & ์ฐ์ฐ์ ํ์ฉ ๊ตฟ์
๋๋ค! |
@@ -0,0 +1,55 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import './Comment.scss';
+
+class Comment extends Component {
+ constructor(props) {
+ super(props);
+ this.state = {
+ isLiked: false,
+ };
+ }
+
+ likeComment = () => {
+ this.setState({ isLiked:... | JavaScript | - id ๊ฐ์ ํ๋ก์ ํธ ์ ์ฒด ๋ด์์ ์ ์ผํด์ผํ๊ธฐ ๋๋ฌธ์, ๊ผญ ํ์ํ ๊ฒฝ์ฐ์๋ง ์ฌ์ฉํด์ฃผ์ธ์!
- id ๋์ ์ onClick ์ด๋ฒคํธ์ ๋ฐ๋ก ์ธ์๋ฅผ ๋๊ฒจ์ฃผ์ค ์๋ ์์ต๋๋ค. ์ฐธ๊ณ ํด์ฃผ์ธ์!
```js
onClick = {() => this.props.handleClick(info.id)}
``` |
@@ -0,0 +1,140 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import User from '../User/User';
+import Comment from '../Comment/Comment';
+import IconButton from '../Button/IconButton';
+import { API } from '../../../../../config';
+import './Feed.scss';
+
+class Feed extends C... | JavaScript | - get ๋ฉ์๋๋ ๊ธฐ๋ณธ ๋ฉ์๋์ด๊ธฐ ๋๋ฌธ์ ์๋ตํด์ฃผ์ค ์ ์์ต๋๋ค.
```suggestion
fetch('/data/Yeseul/commentData.json')
``` |
@@ -0,0 +1,140 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import User from '../User/User';
+import Comment from '../Comment/Comment';
+import IconButton from '../Button/IconButton';
+import { API } from '../../../../../config';
+import './Feed.scss';
+
+class Feed extends C... | JavaScript | - ๋ถ๋ณ์ฑ ์ ์ง์ผ์ฃผ์
จ๋ค์! ๐ ๐ |
@@ -0,0 +1,140 @@
+import React, { Component } from 'react';
+import { Link } from 'react-router-dom';
+import User from '../User/User';
+import Comment from '../Comment/Comment';
+import IconButton from '../Button/IconButton';
+import { API } from '../../../../../config';
+import './Feed.scss';
+
+class Feed extends C... | JavaScript | - setState ๊ฐ ๊ธฐ์กด์ state ๊ฐ์ **๋ณํฉ** ํ๋ ์คํผ๋ ์ด์
์ด๊ธฐ ๋๋ฌธ์, ...this.state ๋ฅผ ํด์ฃผ์ค ํ์๊ฐ ์์ต๋๋ค.
```suggestion
this.setState({
comments: comments.filter(comment => comment.id !== clickedId),
});
``` |
@@ -0,0 +1,14 @@
+const flowTypeDao = require('../models/flowTypeDao');
+const error = require('../utils/error');
+
+const getFlowTypes = async () => {
+ const flowTypes = await flowTypeDao.getFlowTypes();
+ if (flowTypes.length === 0) {
+ error.throwErr(404, 'NOT_FOUND_TYPE');
+ }
+ return flowTypes;
+}
+
+modu... | JavaScript | ```suggestion
return flowTypes;
}
```
else ์์ด๋ ๋ ๊ฒ ๊ฐ์ต๋๋ค :) |
@@ -2,12 +2,11 @@ import styled from '@emotion/styled';
import { useRouter } from 'next/router';
import React, { useCallback, useMemo } from 'react';
import { FieldValues } from 'react-hook-form';
-import { useMutation } from 'react-query';
import { useRecoilValue } from 'recoil';
import { useGetFlavors } from '... | Unknown | @hy57in
mutation๋ ํ ๋ฒ ๋ํํด์ ์ฌ์ฉํ๋๊ฑด ์ด๋ ์ ๊ฐ์?
```typescript
export const useCreateReviewMutation = () => {
const cache = useQueryClient();
const { mutateAsync: createReviewMutation, ...rest } = useMutation(createReview, {
onSuccess: async () => {
await cache.invalidateQueries(queryKeyFactory.GET_R... |
@@ -2,12 +2,11 @@ import styled from '@emotion/styled';
import { useRouter } from 'next/router';
import React, { useCallback, useMemo } from 'react';
import { FieldValues } from 'react-hook-form';
-import { useMutation } from 'react-query';
import { useRecoilValue } from 'recoil';
import { useGetFlavors } from '... | Unknown | @hy57in
`useGetReviewsByBeer` ๋ queryKey๋ฅผ queryKeyFactory์์ ๊ฐ์ ธ์ค๋ ๋ฐฉ์์ผ๋ก ๋ณ๊ฒฝํ๋๊ฑฐ ์ด๋จ๊น์!?
ref
- https://github.com/beerair/beerair-web/blob/8a3fb178139646a813eac410820e31846c3460c3/src/commons/queryKeyFactory.ts |
@@ -2,12 +2,11 @@ import styled from '@emotion/styled';
import { useRouter } from 'next/router';
import React, { useCallback, useMemo } from 'react';
import { FieldValues } from 'react-hook-form';
-import { useMutation } from 'react-query';
import { useRecoilValue } from 'recoil';
import { useGetFlavors } from '... | Unknown | [bf34ee2](https://github.com/beerair/beerair-web/pull/162/commits/bf34ee2ba98545a4e64603f0bdad6d5195f50a47)
๋ง๋ค์ด๋์ queryKeyFactory ๋ฅผ ์๊ณ ์์๋ค์. ํด๋น๋ถ๋ถ ์์ ํ์ต๋๋ค!
mutaion๋ ๋ํํด์ ์์ ํ์ต๋๋ค! |
@@ -0,0 +1,45 @@
+import { useMutation, useQueryClient } from 'react-query';
+
+import request from '@/commons/axios';
+import { queryKeyFactory } from '@/commons/queryKeyFactory';
+import { IBaseResponse, IReview } from '@/types';
+
+/**
+ * ๋ฆฌ๋ทฐ ๋ฑ๋ก
+ */
+
+export interface ICreateReviewResponseData extends IBaseRespons... | TypeScript | @hy57in
๋ฆฌ๋ทฐ ์์ฑ๋๊ณ ํธ์ถ๋๋ success ํจ์ ๋ด๋ถ์์๋ ๋ฆฌ๋ทฐ ๋ฆฌ์คํธ๋ฅผ invalidate ์์ผ์ผํ์ง ์๋์..? |
@@ -0,0 +1,45 @@
+import { useMutation, useQueryClient } from 'react-query';
+
+import request from '@/commons/axios';
+import { queryKeyFactory } from '@/commons/queryKeyFactory';
+import { IBaseResponse, IReview } from '@/types';
+
+/**
+ * ๋ฆฌ๋ทฐ ๋ฑ๋ก
+ */
+
+export interface ICreateReviewResponseData extends IBaseRespons... | TypeScript | ์ํซ..! ๋ฆฌ๋ทฐ ๋ฆฌ์คํธ๋ฅผ invalidate ํ๋ ๊ฒ์ผ๋ก ์์ ํ์ต๋๋ค. ๋ฆฌ๋ทฐ ๊ฐ์ฌํฉ๋๋ค ๐ซข |
@@ -97,12 +97,12 @@ const BeerTicketTitle: React.FC<BeerTicketTitleProps> = ({
{sliceAndUpperCase(beer?.country?.engName || 'non', 3)}
</span>
<div className="ticket-detail">
- {`${beer?.alcohol?.toFixed(1)}%`}
+ {beer?.alcohol ? `${beer.alcohol?.toFixed(1)}%` : '-'}
... | Unknown | '?' ์์ด๋ ๊ด์ฐฎ์ ๊ฒ ๊ฐ์์!
```suggestion
{beer?.alcohol ? `${beer.alcohol.toFixed(1)}%` : '-'}
``` |
@@ -5,8 +5,17 @@
import nextstep.security.authentication.AuthenticationException;
import nextstep.security.authentication.BasicAuthenticationFilter;
import nextstep.security.authentication.UsernamePasswordAuthenticationFilter;
+import nextstep.security.authorization.AnyRequestMatcher;
+import nextstep.security.autho... | Java | > ๊ทธ ์ธ ๋ชจ๋ ์์ฒญ์ ๊ถํ์ ์ ํํ๊ธฐ ์ํด DenyAllAuthorizationManager๋ก ์ฒ๋ฆฌ
์ด์ธ ์์ฒญ์ ์คํจ์ฒ๋ฆฌ ํ๋ ๊ฒ์ด ์๊ตฌ์ฌํญ์ผ๋ก ๋ณด์ฌ์ง๋๋ค~ |
@@ -5,8 +5,17 @@
import nextstep.security.authentication.AuthenticationException;
import nextstep.security.authentication.BasicAuthenticationFilter;
import nextstep.security.authentication.UsernamePasswordAuthenticationFilter;
+import nextstep.security.authorization.AnyRequestMatcher;
+import nextstep.security.autho... | Java | /members/me ์์ฒญ๋ ํด๋น Filter๋ฅผ ํ๋๋ก ์์ ํ์ ์ด์ ๊ฐ ์์๊น์? |
@@ -0,0 +1,20 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class AuthenticatedAuthorizationManager implements AuthorizationManager<HttpServletRequest> {
+
+ @Override
+ public AuthorizationDecisio... | Java | ํด๋น Manager์์ ์์ธ๋ฅผ ๋ฐ์์ํค๋ ๊ฒ์ ๊ธฐ๋ณธ ์ธ๊ฐ ํ๋ฆ๊ณผ ์กฐ๊ธ ๋ง์ง ์๋ ๋ฐฉํฅ์ผ๋ก ๋ณด์ฌ์ง๋ค์!
AuthorizationDecision(false)๋ฅผ ์๋ตํ๋ ๋ฐฉํฅ์ผ๋ก ๊ฐ์ ํด๋ณด๋ฉด ์ด๋จ๊น์? |
@@ -9,30 +9,25 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
-import java.util.Set;
public class CheckAuthenticationFilter extends OncePerRequestFilter {
- private static final String DEFAULT_REQUEST_URI = "/members";
+ privat... | Java | decision.result์ ์ ๊ทผ์ ์ด์๋ฅผ private๋ก ์ค์ ํ์ง ์์ ์ด์ ๊ฐ ์์ผ์ค๊น์? |
@@ -0,0 +1,23 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class RequestMatcherEntry<T extends AuthorizationManager> {
+
+ private final RequestMatcher requestMatcher;
+ private final T entry;
+
+... | Java | ํด๋น ์ฝ๋์ AuthorizationManager๋ก ๊ฐ์ ์บ์คํ
ํ๋ ์ฝ๋๊ฐ ์กด์ฌํ๊ณ ์๋ค์! ์ด๋ ๊ฒ ๊ตฌํํ ๊ฒฝ์ฐ ์ ๋ค๋ฆญ์ ์ฌ์ฉํ ์ฅ์ ์ด ์์ด์ง ๊ฒ ๊ฐ์๋ฐ์.
์ ๋ค๋ฆญ์ ํ์ฉํ์ฌ ๊ฐ์ ์บ์คํ
์์ด ๊ตฌํํด๋ณด๋ฉด ์ด๋จ๊น์? |
@@ -0,0 +1,23 @@
+package nextstep.security.authorization;
+
+import nextstep.security.authentication.Authentication;
+import org.aopalliance.intercept.MethodInvocation;
+
+import java.lang.reflect.Method;
+
+public class SecuredAuthorizationManager implements AuthorizationManager<MethodInvocation> {
+
+ @Override
+... | Java | ํด๋น ์์น์์๋ ์์ธ๋ฅผ ๋ฐ์์ํค๋ ๊ฒ์ด ์์ฐ์ค๋ฌ์ด ํ๋ฆ์ผ์ง ๊ณ ๋ฏผํด๋ณด๋ฉด ์ข๊ฒ ์ต๋๋ค :) |
@@ -0,0 +1,23 @@
+package nextstep.security.authorization;
+
+import nextstep.security.authentication.Authentication;
+import org.aopalliance.intercept.MethodInvocation;
+
+import java.lang.reflect.Method;
+
+public class SecuredAuthorizationManager implements AuthorizationManager<MethodInvocation> {
+
+ @Override
+... | Java | ์ ์ ํฉํฐ๋ฆฌ ๋ฉ์๋๋ฅผ ํตํด ์๋ฏธ๋ฅผ ๋ํ๋ด๋ ๊ฒ์ด ๋๋ฌด ์ข๋ค์ ๐
๋ค๋ง ์ธ์ฆ์ด ์ฑ๊ณตํ์ ๊ฒฝ์ฐ๋ ์์ฑ์๋ฅผ ํตํด ์์ฑํ๊ณ , ์คํจ์ ๊ฒฝ์ฐ ์ ์ ํฉํฐ๋ฆฌ ๋ฉ์๋๋ฅผ ์ฌ์ฉํ๋ ๊ฒ ๋ณด๋ค ๋ฐฉ์์ ํต์ผํ๋ฉด ์ฝ๋์ ์ผ๊ด์ฑ์ด ์๊ธธ ๊ฒ ๊ฐ์๋ฐ ์ด๋ป๊ฒ ์๊ฐํ์๋์? |
@@ -1,7 +1,6 @@
package nextstep.security.authorization;
import nextstep.security.authentication.Authentication;
-import nextstep.security.authentication.AuthenticationException;
import nextstep.security.context.SecurityContextHolder;
import org.aopalliance.aop.Advice;
import org.aopalliance.intercept.MethodInte... | Java | ์ธ์ฆ ๊ณผ์ ์ผ๋ก ๋ดค์ ๋ ํด๋น ์ฝ๋๋ ๋จ์์์ด์ผ ํ์ง ์์๊น์? |
@@ -0,0 +1,59 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+import nextstep.security.authentication.UsernamePasswordAuthenticationToken;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Te... | Java | ์ถ๊ฐ ํ
์คํธ๋ค ๋๋ฌด ์ข๋ค์ ๐ฏ |
@@ -0,0 +1,26 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+import java.util.List;
+
+public class RequestAuthorizationManager implements AuthorizationManager<HttpServletRequest> {
+
+ private List<RequestMa... | Java | > ์ด๋ฏธ Reuqest URI์ ํด๋นํ๋ Matcher๋ฅผ ํ ๋ฒ ๋ง๋๊ฒ ๋๋ฉด ๋ฐ๋ก ๋ฐํ์ ํ๋๊ฒ ๋ง์๊น์?
๋ต ํ ๋ฒ ๋งค์นญ์ด ๋๋ฉด ์ถ๊ฐ์ ์ผ๋ก ํ์ธํ ํ์๋ ์์ด๋ณด์
๋๋ค! ์ผ๋ฐ์ ์ผ๋ก ์์ฒญ URI ํ๋์ ํ๋์ ์ ์ฑ
๋ง ์ ์ฉ๋๋ ๊ฒ์ด ์์ฐ์ค๋ฌ์ธ ๊ฒ ๊ฐ์์ ใ
ใ
|
@@ -0,0 +1,20 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class AuthenticatedAuthorizationManager implements AuthorizationManager<HttpServletRequest> {
+
+ @Override
+ public AuthorizationDecisio... | Java | ํน์๋ Authentication๊ฐ ์๋ ์์ฒญ์ด ๋ค์ด์ฌ ๊ฒ์ ์๊ฐํด์ ํด๋น ๋ก์ง์ ์์ฑํ์๋๋ฐ..
์ฌ์ค ์ธ๊ฐ ํ์ธํ๋ ๋ถ๋ถ์๋ ๋ชจ๋ ์ธ์ฆ์ด ๋์๋ค๊ณ ํ๋จํ๋๊ฒ ๋ง๊ฒ ์ฃ ...? ๐
|
@@ -9,30 +9,25 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
-import java.util.Set;
public class CheckAuthenticationFilter extends OncePerRequestFilter {
- private static final String DEFAULT_REQUEST_URI = "/members";
+ privat... | Java | ์~ ์ ํ ๋ชฐ๋๋ค์;;;! ๐
|
@@ -1,7 +1,6 @@
package nextstep.security.authorization;
import nextstep.security.authentication.Authentication;
-import nextstep.security.authentication.AuthenticationException;
import nextstep.security.context.SecurityContextHolder;
import org.aopalliance.aop.Advice;
import org.aopalliance.intercept.MethodInte... | Java | AuthorizationManager ๋ด๋ถ์์ Authentication๋ฅผ null ์ฒดํฌ ํ๋ค๊ณ ํด๋น ๋ก์ง์ ์ ๊ฑฐ ํ์๋๋ฐ,
SecuredAuthorizationManager๊ฐ ์ธ๊ฐ๋ง์ ์ฒดํฌํ๋ ๊ฒ์ด๊ธฐ ๋๋ฌธ์.. ํด๋น ๋ก์ง์ด ๋จ์ ์๋๊ฒ ๋ง์๋ณด์ด๋ค์ฅ ใ
0ใ
|
@@ -5,8 +5,17 @@
import nextstep.security.authentication.AuthenticationException;
import nextstep.security.authentication.BasicAuthenticationFilter;
import nextstep.security.authentication.UsernamePasswordAuthenticationFilter;
+import nextstep.security.authorization.AnyRequestMatcher;
+import nextstep.security.autho... | Java | 6e7360ff3c84e4862361e19f324a96ae1baeb16a ์ ๋ฐ์ํ์์ต๋๋ค! |
@@ -5,8 +5,17 @@
import nextstep.security.authentication.AuthenticationException;
import nextstep.security.authentication.BasicAuthenticationFilter;
import nextstep.security.authentication.UsernamePasswordAuthenticationFilter;
+import nextstep.security.authorization.AnyRequestMatcher;
+import nextstep.security.autho... | Java | ์ธ๊ฐ ๊ตฌํ ์ ์, ํน์ URI๋ง ์ฒ๋ฆฌํด์ค๋ค๊ณ , ์์ฑํ๋ ๋ก์ง์
๋๋น
์ง๊ธ์ ์ธ๊ฐ ๋ถ๋ถ์์ ์ฒ๋ฆฌ๋ฅผ ํ ์ ์๊ธฐ์ 7f9b37e03636d45d53340e4c1c40f9c938d56263 ํด๋น ์ปค๋ฐ์์ ์ ๊ฑฐํด ๋์์ต๋๋ค ๐
|
@@ -0,0 +1,20 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class AuthenticatedAuthorizationManager implements AuthorizationManager<HttpServletRequest> {
+
+ @Override
+ public AuthorizationDecisio... | Java | 605be945e21c24abe9040c8cbdad211f05132edc ํด๋น ๋ถ๋ถ์ ํตํด ๋ฐ์ํ์์ต๋๋ค! |
@@ -9,30 +9,25 @@
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletResponse;
import java.io.IOException;
-import java.util.Set;
public class CheckAuthenticationFilter extends OncePerRequestFilter {
- private static final String DEFAULT_REQUEST_URI = "/members";
+ privat... | Java | bd27412e9a027651567f25f0e51b725454af6e8c ๋ฅผ ํตํด ํธ๋ค๋ฅ ์์ ํ์์ต๋๋ค! |
@@ -0,0 +1,23 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class RequestMatcherEntry<T extends AuthorizationManager> {
+
+ private final RequestMatcher requestMatcher;
+ private final T entry;
+
+... | Java | 682a3ed6d8e7087121230ad169934e5193a5c73b ๋ฅผ ํตํด ์ฒ๋ฆฌ๋ฅผ ํด ๋ณด์์ต๋๋ค. |
@@ -0,0 +1,23 @@
+package nextstep.security.authorization;
+
+import nextstep.security.authentication.Authentication;
+import org.aopalliance.intercept.MethodInvocation;
+
+import java.lang.reflect.Method;
+
+public class SecuredAuthorizationManager implements AuthorizationManager<MethodInvocation> {
+
+ @Override
+... | Java | 589bd7f23cba24fe7845d0c83f8227d0d3c10b83 ์์ ์ฒ๋ฆฌํ์์ต๋๋ค.
ํ์ด๋ก ๊ฐ๋ฐ ํ ๋, ํ์ด์ง์ด ์ง์ฃผ์ ๊ฑฐ์๋๋ฐ ๐
์ฑ๊ณต์ ๊ฒฝ์ฐ์๋, ํฉํ ๋ฆฌ ๋ฉ์๋๋ฅผ ํตํด ์์ฑ๋ ์ ์๋๋ก ์์ ํ์์ต๋๋ค |
@@ -0,0 +1,29 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.springframework.mock.web.MockHttpServletRequest;
+
+import sta... | Java | ํ
์คํธ ๐๐๐ |
@@ -0,0 +1,20 @@
+package nextstep.security.authorization;
+
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
+
+public class AuthenticatedAuthorizationManager implements AuthorizationManager<HttpServletRequest> {
+
+ @Override
+ public AuthorizationDecisio... | Java | > ํน์๋ Authentication๊ฐ ์๋ ์์ฒญ์ด ๋ค์ด์ฌ ๊ฒ์ ์๊ฐํด์ ํด๋น ๋ก์ง์ ์์ฑํ์๋๋ฐ..
์ฌ์ค ์ธ๊ฐ ํ์ธํ๋ ๋ถ๋ถ์๋ ๋ชจ๋ ์ธ์ฆ์ด ๋์๋ค๊ณ ํ๋จํ๋๊ฒ ๋ง๊ฒ ์ฃ ...? ๐
๋ต!! ๋ณดํต ์ธ๊ฐ ๋ก์ง์์๋ ์ธ์ฆ์ด ์๋ฃ๋ฃ๋ ์ํ๋ผ๊ณ ๊ฐ์ ํ๋๊ฒ ์ข๊ณ , ๋ง์ฝ null์ด ์ฌ ์ ์๋๋ฉด ์ถ์ํ ๋ ๋ฒจ์ ์๊ฐํด์ ๋ค๋ฅธ ์์ธ๊ฐ ๋ฐ์ํ๋ ๊ฒ์ด ๋ ์์ฐ์ค๋ฌ์ธ ๊ฒ ๊ฐ์ต๋๋ค ใ
ใ
|
@@ -0,0 +1,58 @@
+package nextstep.app.config;
+
+import nextstep.security.authentication.*;
+import nextstep.security.context.HttpSessionSecurityContextRepository;
+import nextstep.security.context.SecurityContextRepository;
+import nextstep.security.domain.MemberDetailService;
+import nextstep.security.filter.*;
+imp... | Java | ํํฐ์ ์์๋ ์ค์ํฉ๋๋ค!
SecurityContextHolderFilter๋ BasicAuthenticationFilter, LoginAuthenticationFilter๋ณด๋ค ๋จผ์ ์ค์ ๋์ด์ผ ํ ๊ฒ ๊ฐ์์~ |
@@ -0,0 +1,77 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | ๊ฐ ํํฐ์์ SecurityContext๋ฅผ ์ฌ์ฉํ ๋๋ SecurityContextHolder๋ฅผ ํตํด ์ฌ์ฉํ๋ฉด ์ด๋จ๊น์? |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.*;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.exception.FilterChainNotFoundException;
+import org.springframework.web.filter.GenericFilterBean;
+
+import java.io.IOException;
+import java.util.List;
+
+public c... | Java | ์ง๊ธ์ ๋ชจ๋ ์ฒด์ธ์ ํํฐ๋ฅผ ์คํํ๊ณ ์๋๋ฐ์. ์ง๊ธ ํ๋ก์ ํธ์์ ํ๋์ ํํฐ ์ฒด์ธ๋ง ์ฌ์ฉํ๊ณ ์์ง๋ง, ์ฌ๋ฌ ํํฐ ์ฒด์ธ์ ์ฌ์ฉํ ์ ๊ฒฝ์ฐ ๋ฌธ์ ๊ฐ ์๊ธธ ์ ์์ ๊ฒ ๊ฐ์๋ฐ ์ด๋ป๊ฒ ์๊ฐํ์๋์? |
@@ -0,0 +1,67 @@
+package nextstep.security.filter;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import nextstep.... | Java | > ์์ธ ๋ฐ์ ์ clearContext๋ ExceptionHandlerFilter์์ ์ํํ๋๋ก ๊ตฌํํ๊ณ , ์์ฒญ ์๋ฃ ํ clearContext๋ SecurityContextHolderFilter์์ ์ํํ๋๋ก ๊ตฌํํ์ต๋๋ค. ์ด๊ฒ ๋ง๋ ๋ฐฉ์์ธ์ง ๊ถ๊ธํฉ๋๋ค.
Filter์ ์ญํ ์ ์ ๋๋ ์ฃผ์
จ์ด์ ๐
์กฐ๊ธ ๋ ์ฝ๋๋ฅผ ๋ฐ์ ์์ผ ๋ณธ๋ค๋ฉด ์์ธ ์ํฉ์ ๋ฐ๋ฅธ ์์ธ ์ฒ๋ฆฌ๊ฐ ์ถ๊ฐ๋๊ณ , SecurityContextHolder์ ๊ด๋ จ๋ ๋ชจ๋ ์ญํ ์ SecurityContextHolderFilter์์ ๋ด๋นํ๋๋ก ํด๋ณด๋ฉด ์ข์ ๊ฒ ๊ฐ์ต๋๋ค! |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | SPRING_SECURITY_CONTEXT_KEY๋ฅผ ๊ธฐ๋ฐ์ผ๋ก ์ฒ๋ฆฌํ๋ ์ญํ ์ SecurityContextRepository์๊ฒ ๋๊ฒจ์ฃผ๋ฉด ์ข๊ฒ ๋ค์! |
@@ -0,0 +1,39 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import... | Java | > 4๋จ๊ณ SecurityContextHolderFilter ๊ตฌํ ์ค clearContext๋ฅผ SecurityContextHolderFilter์์ ์ํํ๋ ๊ฒ ๋ง๋ค๊ณ ์๊ฐํ๋๋ฐ, clearContext๋ฅผ ์ํํ๋ฉด ํ
์คํธ๊ฐ ์คํจํฉ๋๋ค. ์ผ๋จ ์ ์ถ์ ์ํด ์ฃผ์์ฒ๋ฆฌํ๋๋ฐ, ํ
์คํธ๊ฐ ์คํจํ๋ ์ด์ ๊ฐ ๊ถ๊ธํฉ๋๋ค.
```suggestion
securityContextRepository.saveContext(securityContext, httpRequest, httpResponse);
SecurityContextHolder.... |
@@ -0,0 +1,58 @@
+package nextstep.app.config;
+
+import nextstep.security.authentication.*;
+import nextstep.security.context.HttpSessionSecurityContextRepository;
+import nextstep.security.context.SecurityContextRepository;
+import nextstep.security.domain.MemberDetailService;
+import nextstep.security.filter.*;
+imp... | Java | SecurityContextHolderFilter ๊ฐ ๋จผ์ ์คํ์ด ๋์ด์ผ ์์ฒญ์ด ์์ํ๊ณ ๋๋ ๋ SecurityContext๋ฅผ ์ ์ ํ๊ฒ ์ฒ๋ฆฌํ ์ ์๊ฒ ๋ค์. ์ ๊ฐ ์ดํดํ ๋ถ๋ถ์ด ๋ง์๊น์? |
@@ -0,0 +1,39 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import... | Java | ์ด์ ๋ฅผ ์ ๋ชจ๋ฅด๊ฒ ๋ค์.. ใ
ใ
๊ทผ๋ฐ ์์ ํ๋ค๊ฐ ๋ ์๊ฐ์ธ๋ฐ, ๊ฐ ํํฐ์์ `securityContextRepository.saveContext` ๋ฅผ ์ํํ๊ณ ์์ผ๋๊น SecurityContextHolderFilter์์๋ saveContext ์ํ์ ์ ํด๋ ๋์ง ์๋์? |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.*;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.exception.FilterChainNotFoundException;
+import org.springframework.web.filter.GenericFilterBean;
+
+import java.io.IOException;
+import java.util.List;
+
+public c... | Java | ํ๋์ ํํฐ ์ฒด์ธ๋ง ์ฌ์ฉํ๋ ๊ฒ ๋ณด์ฅ๋๋ ๊ฒ์ด ์ข์ ๊ฒ ๊ฐ์์.
์ด ์์ฒญ์ด filterChain์ ๋ง๋ ์์ฒญ์ธ์ง ํ์ธํ๋ ๋ฉ์๋๊ฐ ํ์ํ ๊ฒ ๊ฐ์ต๋๋ค. |
@@ -0,0 +1,67 @@
+package nextstep.security.filter;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import nextstep.... | Java | ํํฐ ์์๋ฅผ ๋ณ๊ฒฝํ๊ณ (SecurityContextHolderFilter -> Basic -> Login)
SecurityContextHolderFilter ์ finally ์ ์์ clearContext๋ฅผ ์ํํ๋๊น ๊ตณ์ด ExceptionHandlerFilter์์ ์ํ์ ์ ํด๋ ๋ ๊ฒ ๊ฐ์๋ฐ ์ ๊ฐ ์ดํดํ ๋ด์ฉ์ด ๋ง์๊น์? |
@@ -0,0 +1,58 @@
+package nextstep.app.config;
+
+import nextstep.security.authentication.*;
+import nextstep.security.context.HttpSessionSecurityContextRepository;
+import nextstep.security.context.SecurityContextRepository;
+import nextstep.security.domain.MemberDetailService;
+import nextstep.security.filter.*;
+imp... | Java | > SecurityContextHolderFilter ๊ฐ ๋จผ์ ์คํ์ด ๋์ด์ผ ์์ฒญ์ด ์์ํ๊ณ ๋๋ ๋ SecurityContext๋ฅผ ์ ์ ํ๊ฒ ์ฒ๋ฆฌํ ์ ์๊ฒ ๋ค์. ์ ๊ฐ ์ดํดํ ๋ถ๋ถ์ด ๋ง์๊น์?
์ ํํ ์ดํดํด์ฃผ์
จ๋ค์ ๐ |
@@ -0,0 +1,58 @@
+package nextstep.app.config;
+
+import nextstep.security.authentication.*;
+import nextstep.security.context.HttpSessionSecurityContextRepository;
+import nextstep.security.context.SecurityContextRepository;
+import nextstep.security.domain.MemberDetailService;
+import nextstep.security.filter.*;
+imp... | Java | HttpSessionSecurityContextRepository๋ฅผ ๋งค๋ฒ ์์ฑํ์ง ์๊ณ , Spring Bean์ผ๋ก ๋ฑ๋กํ์ฌ ์ฌ์ฌ์ฉํด๋ณด๋ฉด ์ด๋จ๊น์? |
@@ -0,0 +1,67 @@
+package nextstep.security.filter;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import nextstep.... | Java | > ํํฐ ์์๋ฅผ ๋ณ๊ฒฝํ๊ณ (SecurityContextHolderFilter -> Basic -> Login)
SecurityContextHolderFilter ์ finally ์ ์์ clearContext๋ฅผ ์ํํ๋๊น ๊ตณ์ด ExceptionHandlerFilter์์ ์ํ์ ์ ํด๋ ๋ ๊ฒ ๊ฐ์๋ฐ ์ ๊ฐ ์ดํดํ ๋ด์ฉ์ด ๋ง์๊น์?
๋ง์ต๋๋ค ๐
์ถ๊ฐ๋ก AuthenticationException ์ด์ธ์ ๋ค๋ฅธ ์์ธ๋ ์ด๋ค๊ฒ ๋ฐ์ํ ์ ์๊ณ , ์ด๋ป๊ฒ ์ฒ๋ฆฌํ๋ฉด ์ข์์ง ๊ณ ๋ฏผํด๋ณด๋ ๊ฒ๋ ํ์ต์ ๋์์ด ๋ ๊ฒ ๊ฐ์์! |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | SPRING_SECURITY_CONTEXT_KEY์ ์ญํ ์ด HttpSessionSecurityContextRepository๋ก ๋์ด๊ฐ์ผ๋, ํด๋น ์์๋ HttpSessionSecurityContextRepository๋ก ๋์ด๊ฐ๋ฉด ์ญํ ์ด ๋ช
ํํด ์ง ๊ฒ ๊ฐ์์! |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | > ์ด์ ๋ฅผ ์ ๋ชจ๋ฅด๊ฒ ๋ค์.. ใ
ใ
๊ทผ๋ฐ ์์ ํ๋ค๊ฐ ๋ ์๊ฐ์ธ๋ฐ, ๊ฐ ํํฐ์์ securityContextRepository.saveContext ๋ฅผ ์ํํ๊ณ ์์ผ๋๊น SecurityContextHolderFilter์์๋ saveContext ์ํ์ ์ ํด๋ ๋์ง ์๋์?
๋ฐ๋๋ก ์ ๊ทผํ ์๋ ์์ ๊ฒ ๊ฐ์์! ์ง๊ธ์ ๊ตฌ์กฐ์์ ๊ฐ ํํฐ์์ `saveContext`๋ฅผ ํธ์ถํด์ค์ผ ํ๋๋ฐ, SecurityContextHolderFilter์์ ๋ด๋นํ๊ฒ ๋๋ค๋ฉด ๊ฐ ํํฐ์์ SecurityContext์ ๋ํ ์ ๊ฒฝ์ ์์ฐ๋๋ก ๋ง๋ค ์ ์์ต๋๋ค~ |
@@ -0,0 +1,77 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | ๊ฐ Filter๊ฐ SecurityContextRepository์ ๋ํ ์์กด์ฑ์ ๊ฐ์ง๊ณ ์๋๋ก ๊ตฌํํด์ฃผ์
จ๋ค์.
์คํ๋ง์ ๋ค๋ฅธ Filter์์ SecurityContextRepository์ ๋ด๋ถ ๊ตฌํ์ ๋ชฐ๋ผ๋ SecurityContextHolder.getContext()๋ฅผ ํตํด ์ธ์ฆ ์ ๋ณด๋ฅผ ํ์ฉํ ์ ์๋๋ก ์ค๊ณ๋์ด ์๋๋ฐ์.
์ด๋ ๊ฒ ๊ตฌ์กฐ๋ฅผ ์ค๊ณํ ์ด์ ์ ๋ํด ๊ณ ๋ฏผํด๋ณด์๋ฉด ์ข๊ฒ ์ต๋๋ค! |
@@ -0,0 +1,67 @@
+package nextstep.security.filter;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import nextstep.... | Java | ๋ก๊ทธ์ธ ์์ ์
๋ ฅ๊ฐ์ด ๋๋ฝ๋์ ๊ฒฝ์ฐ์ ์์ธ์ฒ๋ฆฌ๋ฅผ ์ถ๊ฐํ๊ณ ,
ExceptionHandlerFilter ์์์ ์๋ฌ ์๋ต๊ฐ ์์ฑ ๋ก์ง์ ์ถ๊ฐํ์ต๋๋ค. ๊ทธ๋ฆฌ๊ณ ์์ ๋ชปํ ์์ธ๋ 500 ์๋ฌ ์ฒ๋ฆฌํ๋๋ก ๊ตฌํํ์ต๋๋ค..! |
@@ -0,0 +1,56 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | SecurityContextHolderFilter์ ์ญํ ์ ๋ํด ๋ค์ ์๊ฐํด๋ณด๊ฒ ๋์์ต๋๋ค. ๊ฐ์ฌํฉ๋๋ค! |
@@ -0,0 +1,77 @@
+package nextstep.security.filter;
+
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.ServletException;
+import jakarta.servlet.ServletRequest;
+import jakarta.servlet.ServletResponse;
+import jakarta.servlet.http.HttpServletRequest;
+import nextstep.security.authentication.Authentication;
... | Java | SecurityContextHolderFilter๋ง SecurityContextRepository์ ๋ํ ์์กด์ฑ์ ๊ฐ์ง๋๋ก ์์ ํ์ต๋๋ค! |
@@ -0,0 +1,67 @@
+package nextstep.security.filter;
+
+import com.fasterxml.jackson.core.JsonProcessingException;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import jakarta.servlet.FilterChain;
+import jakarta.servlet.http.HttpServletRequest;
+import jakarta.servlet.http.HttpServletResponse;
+import nextstep.... | Java | ```suggestion
try {
chain.doFilter(request, response);
} catch (AuthenticationException e) {
} catch (IllegalArgumentException e) {
} catch (Exception e) {
}
```
instanceof ๋์ ์์ ๊ฐ์ด ์์ฑํ๋๊ฒ ๋ ๋ช
ํํ ๊ฒ ๊ฐ๋ค์! |
@@ -0,0 +1,18 @@
+const categoryDao = require('../models/categoryDao');
+const error = require('../utils/error');
+
+const getCategory = async (type) => {
+ const categoryTypes = {
+ '์ง์ถ' : [1, 2, 3],
+ '์์
' : [4]
+ }
+
+ const categories = await categoryDao.getCategoriesByIds(categoryTypes[type]);
+ categori... | JavaScript | ```suggestion
const getCategory = async (type) => {
const categoryTypes = {
'์ง์ถ' : [1, 2, 4],
'์์
' : [3]
}
const categories = await categoryDao.getCategoriesByIds(categoryTypes[type]);
categories.map((category) => { category.type = type })
return categories
}
module.exports = { get... |
@@ -0,0 +1,20 @@
+const categoryService = require('../services/categoryService');
+const error = require('../utils/error');
+
+const getCategory = async (req, res) => {
+ try {
+ const { type } = req.query;
+ if (!type) {
+ error.throwErr(400, 'KEY_ERROR');
+ }
+ const categories = await categoryServi... | JavaScript | ์๋ฌ ๋ฐ์์์ผ ๋ณด์
จ๋์? ๋ชจ๋ ์๋ฌ๊ฐ 'internal_server_error'๋ก ๋ ํ
๋ฐ, ์๋ํ์ ๋ฐ๊ฐ ๋ง์๊น์? |
@@ -0,0 +1,18 @@
+const categoryDao = require('../models/categoryDao');
+const error = require('../utils/error');
+
+const getCategory = async (type) => {
+ const categoryTypes = {
+ '์ง์ถ' : [1, 2, 3],
+ '์์
' : [4]
+ }
+
+ const categories = await categoryDao.getCategoriesByIds(categoryTypes[type]);
+ categori... | JavaScript | 3. ๊ทผ๋ณธ์ ์ธ ์ง๋ฌธ์ด ํ๋ ์๋๋ฐ, category๊ฐ flow_type_id๋ฅผ FK๋ก ๊ฐ์ง๊ณ ์์ผ๋ฉด, ํ๋์ฝ๋ฉ์ ์ํด๋ ๋ ๊ฒ ๊ฐ์๋ฐ FK ์์ฑํ์๋๊ฒ ์ข์ง ์์๊น์? ์ด๋ถ๋ถ์ ๋ฐฑ์๋ ํ ๊ฐ์ด ๋ผ์ด์ง์์ ์ ํ ๋ฒ ์ฐพ์์ ์ฃผ์ธ์! |
@@ -0,0 +1,20 @@
+const categoryService = require('../services/categoryService');
+const error = require('../utils/error');
+
+const getCategory = async (req, res) => {
+ try {
+ const { type } = req.query;
+ if (!type) {
+ error.throwErr(400, 'KEY_ERROR');
+ }
+ const categories = await categoryServi... | JavaScript | ์ ํด๋น **error message** ๋ถ๋ถ ์์ ํ๊ฒ ์ต๋๋ค.
`=> 'INTERNAL_SERVER_ERROR' || err.message}` |
@@ -0,0 +1,14 @@
+const {DataSource} = require('typeorm');
+const dotenv = require('dotenv');
+dotenv.config();
+
+const appDataSource = new DataSource({
+ type : process.env.TYPEORM_CONNECTION,
+ host: process.env.TYPEORM_HOST,
+ port: process.env.TYPEORM_PORT,
+ username: process.env.TYPEORM_USERNAME,
+ password... | JavaScript | ๋ฐ์ํ๊ฒ ์ต๋๋ค! |
@@ -1,8 +1,6 @@
package reviewme.review.repository;
-import java.time.LocalDate;
import java.util.List;
-import java.util.Optional;
import org.springframework.data.jpa.repository.JpaRepository;
import org.springframework.data.jpa.repository.Query;
import reviewme.review.domain.Review;
@@ -23,17 +21,16 @@ public ... | Java | ๋ฉ์๋ ์ด๋ฆ์ด findAll ๋ก ์์ํ๋ฉด ๋ฆฌ์คํธ๋ก ๋ฐํํ๋ค๋๊ฒ ๋ ์ ์ ๋ฌ๋ ๊ฒ ๊ฐ์์!
์ปจ๋ฒค์
์๋ ๋ง๊ณ ์.
๊ทธ๋ฆฌ๊ณ ์ง๊ธ ๋ณด๋ `findByReviewGroupIdWithLimit` ํจ์๋ findAll ์ด ์๋๊ฒ ๋์ด์๋๋ฐ,
์ด ํจ์ ์ด๋ฆ๋ ์ด PR์์ ์์ ํด๋ ๊ด์ฐฎ๋ค ์๊ฐํฉ๋๋ค! |
@@ -5,11 +5,14 @@
import org.springframework.lang.Nullable;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
+import reviewme.review.domain.Review;
import reviewme.review.repository.ReviewRepository;
+import reviewme.review.service.dto.response.list.Aut... | Java | ๋ ๊ฐ๋
์ฑ ์ข๊ฒ ๋ฐ๋์๋ค์๐
isLastPage ๊ณ์ฐํ๋ ๋ถ๋ถ๊ณผ newLastReviewId ๊ตฌํ๋ ๋ถ๋ถ์ด ๊ฒน์ณ์ ์ถ์ํ๋ฅผ ํ ์ ์์๊ฒ๋ ๊ฐ์๋ฐ,.
๊ทธ๋ ๊ฒ ๋๋ฉด "๋ฆฌ๋ทฐ๊ฐ ์์ผ๋ฉด last_xxx_id ๊ฐ 0์ด๋ค"์ ๊ฐ์ ๊ฒ๋ค๋ ํต์ผํ ์ ์๊ณ ์
์ผ๋จ ๋น ๋ฅธ ๊ธฐ๋ฅ ๊ตฌํ์ ์ํด ๋์ด๊ฐ๊ณ ๋์ค์ ์๊ฐํด๋ด์~ |
@@ -1,14 +1,15 @@
package reviewme.review.service.dto.response.list;
-import java.time.LocalDate;
+import java.time.LocalDateTime;
import java.util.List;
public record AuthoredReviewElementResponse(
+
long reviewId,
String revieweeName,
String projectName,
- LocalDate createdAt,... | Java | LocalDateTime ์ผ๋ก ๋ฐ๊ฟ์ค ์ด์ ๋ฅผ ๋ฃ๊ณ ์ถ์ด์~
๊ทธ๋ฆฌ๊ณ ์๋ต๊ฐ์ ํ์
์ ์ฐ๋ฆฌ ๋ง์๋๋ก ๋ฐ๊ฟ๋ ๋ ๊น์?
์๋ฅผ ๋ค์ด์ ํ๋ก ํธ์์ ๋ฌธ์์ด์ ๊ธฐ์ค์ผ๋ก ํ์ฑ์ ํ๊ณ ์์๋๋ฐ,
๊ทธ ํ์์ด ๋ฌ๋ผ์ง๋ฉด ๋ฌธ์ ๊ฐ ์๊ธธ์๋ ์์ด์.
(๋ฌธ์ ๊ฐ ์๋ ์๋ ์์ง๋ง, ์ง๊ธ์ฒ๋ผ ๊ธํ๊ณ ๋์๊ฐ๋ ์ํฉ์์๋ ์ด๋ฐ ๋ฌธ์ ์์๋ฅผ ์๋ง๋๋๊ฒ ์ข๋ค ์๊ฐํด์์) |
@@ -0,0 +1,76 @@
+package reviewme.review.service.mapper;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.Set;
+import java.util.stream.Collectors;
+import lombok.RequiredArgsConstructor;
+import org.springframework.stereotype.Component;
+import reviewme.review.domain.Chec... | Java | ์บฌ ReviewPreviewGenerator ๋ถ๋ฆฌํด๋์๊ฑฐ ์ข์๋ค์๐ |
@@ -1,12 +1,13 @@
package reviewme.review.service.dto.response.list;
-import java.time.LocalDate;
+import java.time.LocalDateTime;
import java.util.List;
public record ReceivedReviewPageElementResponse(
+
long reviewId,
- LocalDate createdAt,
+ LocalDateTime createdAt,
String cont... | Java | ์ ๋ ์ด ๋ค์ด๋ฐ ๊ด์ฐฎ์๋ฐ,
(์ ๋ ์ด ํ๋ ๋ค์ด๋ฐ์ ๋ํ ๊ฐํ ์๊ฒฌ์ด ์์ด์, ํ์์ ์ ํธ๋ฅผ ๋ฐ๋ผ๊ฐ๋ ๋จ)
**์๋ต ํ๋ ์ด๋ฆ์ ์ง์ญ ๋ณ์ ์ด๋ฆ ๋ฐ๊พธ๋ฏ์ด ๋ฐ๊ฟ๋ ๋ ๊น์..! ๐ค**
ํ๋ก ํธ์ ๋ณ๊ฒฝ ์ฌํญ ์๋ ค์ผ ํ ํ
๋ฐ..
๋ฐฑ์๋์ ์ ํธ์ ๋ง๊ฒ "์ด๋ ๊ฒ ๋ณ๊ฒฝํ์ต๋๋ค" ํต๋ณดํ๋ ๊ฒ๋ ์ข ์๋ ๊ฒ ๊ฐ๊ณ ์๐
๋ค์ด๋ฐ ๋ณ๊ฒฝ์ ์ด PR์ ํ์์ ์ธ ๋ถ๋ถ์ ์๋๋ ๋๊ฒจ๋๊ณ ,
api ๋ณ๊ฒฝ์ ๋ํด์ ํ์ํ ๋ ๋ฐ๊พธ์๊ณ ํด๋ณด๋๊ฑด ์ด๋จ๊น์? |
@@ -3,10 +3,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static reviewme.fixture.QuestionFixture.์์ ํ_ํ์_์ง๋ฌธ;
import static reviewme.fixture.ReviewFixture.๋นํ์_์์ฑ_๋ฆฌ๋ทฐ;
+import static reviewme.fixture.ReviewFixture.ํ์_์์ฑ_๋ฆฌ๋ทฐ;
import static reviewme.fixture.ReviewGroupFixture.๋นํ์_๋ฆฌ๋ทฐ_๊ทธ๋ฃน;
+import s... | Java | ```suggestion
void lastReviewId๊ฐ_์ฃผ์ด์ง_๊ฒฝ์ฐ_ํด๋นID_์ด์ ์_๊ฐ์ฅ_์ต๊ทผ์_๋ฆฌ๋ทฐ๋ถํฐ_๋ฐํํ๋ค() {
```
"์ดํ"๊ฐ ์๋๋ผ "์ด์ "์ผ๋ก ๋ณ๊ฒฝ๋๋๊ฒ ์ข๊ฒ ๋ค์! |
@@ -3,10 +3,11 @@
import static org.assertj.core.api.Assertions.assertThat;
import static reviewme.fixture.QuestionFixture.์์ ํ_ํ์_์ง๋ฌธ;
import static reviewme.fixture.ReviewFixture.๋นํ์_์์ฑ_๋ฆฌ๋ทฐ;
+import static reviewme.fixture.ReviewFixture.ํ์_์์ฑ_๋ฆฌ๋ทฐ;
import static reviewme.fixture.ReviewGroupFixture.๋นํ์_๋ฆฌ๋ทฐ_๊ทธ๋ฃน;
+import s... | Java | ์ด๊ฒ๋ "์ด์ "์ด ์๋ฏธ๊ฐ ๋ง์ง ์์๊น์? |
@@ -1,14 +1,15 @@
package reviewme.review.service.dto.response.list;
-import java.time.LocalDate;
+import java.time.LocalDateTime;
import java.util.List;
public record AuthoredReviewElementResponse(
+
long reviewId,
String revieweeName,
String projectName,
- LocalDate createdAt,... | Java | LocalDate๋ก ๋ณํํด์ ์๋ตํ๋ฉด์, ๋ก์ง ๋ง์ ๋ถ๋ถ์ ๋ณํ ์์
์ด ๋ค์ด๊ฐ๊ณ ์์์ด์.
๋ ํฌ์งํ ๋ฆฌ์์ ๋ฐ์ดํฐ๋ฅผ ์กฐํํ ๋ SQL์์๋ ํ์
์ ๋ณ๊ฒฝํ๊ณ , ์ฌ์ง์ด ์ํฐํฐ ๊ฐ์ฒด์์๋ LocalDate๋ก ๋ณํํด์ ์๋ตํด์ฃผ๋ ๋ฉ์๋๊ฐ ์กด์ฌํ๊ธฐ๋ ํ๊ณ ์. LocalDate๋ก์ ๋ณํ์ ์ฐ๋ฆฌ๊ฐ ํํ์ด์ง ํ๋ฉด์์ ์ด ๋จ์๊น์ง๋ ์๋์ค๋ ๊ทธ๋ ๊ฒ ์๋ตํด์ฃผ๋ ๊ฑฐ์์. ์ฆ, View์ ๋ํ ๋ถ๋ถ์ด ๋๋ฉ์ธ๊น์ง ์ ์ฉ๋๊ณ ์๋๊ฑฐ์์. ๊ทธ๋ฆฌ๊ณ ์ง๊ธ์ ํ๋ก ํธ์์ ์ฐ๋ฆฌ๊ฐ ๋ด๋ ค์ฃผ๋ ๊ทธ๋๋ก ๋
ธ์ถํด์ฃผ๊ณ ์์ง๋ง, ์ ๋ ฌ ๊ธฐ์ค์ด ์ต์ ์๋ง ์๋ ๊ฒ์ด ์๋๋ผ, ๋ ์ง์๋ ์กด์ฌํ๊ฒ ๋๋ฉด ์ฐ๋ฆฌ๋ ๋ LocalDat... |
@@ -1,12 +1,13 @@
package reviewme.review.service.dto.response.list;
-import java.time.LocalDate;
+import java.time.LocalDateTime;
import java.util.List;
public record ReceivedReviewPageElementResponse(
+
long reviewId,
- LocalDate createdAt,
+ LocalDateTime createdAt,
String cont... | Java | ๊ณ์ํด์ ๋ฆฌํฉํฐ๋ง ์์๋ฅผ ๋จ๊ฒจ๋๋ ๊ฒ์ด ๋ง์๊น์? ์์
๋จ์๊ฐ ํฌ์ง ์์ ๊ฒ์ ๊ฐ์ด ํด๋ ๋์ง ์์๊น์?
ReviewCategoryResponse categories ์ด ๋จ์ด๊ฐ ๋ฌด์์ ๋ปํ๋์? "๋ฆฌ๋ทฐ ์นดํ
์ฝ๋ฆฌ ์๋ต / ์นดํ
๊ณ ๋ฆฌ"์ธ๋ฐ, ๋ฆฌ๋ทฐ์ ์นดํ
๊ณ ๋ฆฌ๊ฐ ์กด์ฌํ๋์?
๊ทธ๋ฅ ๋ค์ด๋ฐ๋ง ๋ณด๋ฉด ๋ฆฌ๋ทฐ์ ์นดํ
๊ณ ๋ฆฌ ์ข
๋ฅ๊ฐ ์๊ณ ๊ทธ ๋ถ๋ถ์ ๋ํ๋ด๋ ๊ฒ์ฒ๋ผ ๋ณด์ฌ์.
์ด ์์ ์ ์ ํธ์ ๋ง๊ฒ ๋ณ๊ฒฝํ ๋ถ๋ถ์ด ์๋๋ผ, ์ฌ๋ฐ๋ฅด๊ฒ ๋ณ๊ฒฝํ ๋ถ๋ถ์ด๊ณ ๋ณ๊ฒฝ ์ฌํ๊ฐ ํฌ์ง ์๋ค๊ณ ์๊ฐํด์.
๊ทธ๋ฆฌ๊ณ ๋์ค์ ๋ค์ ๋ณด๊ฒ ๋์ด๋ ๋ฐ๋ก ์ดํดํ ์ ์๊ฒ ์ ํํ ๋ค์ด๋ฐ์ ๋ํ๋ด๋ ๊ฒ์ด ์ข๋ค๊ณ ์๊ฐํด์. |
@@ -1,14 +1,15 @@
package reviewme.review.service.dto.response.list;
-import java.time.LocalDate;
+import java.time.LocalDateTime;
import java.util.List;
public record AuthoredReviewElementResponse(
+
long reviewId,
String revieweeName,
String projectName,
- LocalDate createdAt,... | Java | > ๋ ์ง์๋ ์กด์ฌํ๊ฒ ๋๋ฉด ์ฐ๋ฆฌ๋ ๋ LocalDateTime์ผ๋ก ๋ก์ง์ ๋ณ๊ฒฝํด์ผ ํด์. ๊ทธ๋ผ ํ๋ก ํธ์ ์์ฒญ์ ๋ฐ๋ผ์ ๊ณ์ํด์ ๋ก์ง์ ๋ณ๊ฒฝํ ๊ฑด๊ฐ์?
์ ๋ ๋ณธ์ง์ ์ผ๋ก๋ LocalDateTime์ด ๋ง๋ค๊ณ ์๊ฐํด์.
์ด ์ฝ๋ฉํธ๋ LocalDate โ LocalDateTime ๋ณ๊ฒฝ์ด ์๋ชป๋์๋ค๋ ๋ง์ด ์๋๋ผ,
๋ฐฑ์๋๊ฐ api๋ฅผ ์์ ๋ถ๋ถ์ด๋ผ๋ ๋
ผ์ ์์ด ๋ฐ๊พธ๋๊ฒ ์ํํ๋ค๋ ๋ง์ด์์ด์.
์ฐ๋ฆฌ๊ฐ ๋ณ๊ฒฝ์ ํ๋๋ฐ ํ๋ก ํธ์ ์ ๋ฌ์ ์ํ ์ฌํญ์ด ์๋ค๋ฉด ๊ทธ๊ฑด ๊ทธ๊ฒ๋๋ก ๋ฆฌ์์ค๊ฐ ๋ค์ด๊ฐ ๊ฒ์ด๊ณ ์.
๊ทธ๋ฆฌ๊ณ ์ ๊ฐ ๊ณ์ PR์ ๋จ์, ์์
์ ๋ฒ์์ ๋ํด์ ์ด์ผ๊ธฐ๋ฅผ ํ๊ฒ๋๋๋ฐ,
... |
@@ -1,9 +1,14 @@
+import java.util.List;
import java.util.Scanner;
public class InputView {
private static final String INPUT_MONEY_MESSAGE = "๊ตฌ์
๊ธ์ก์ ์
๋ ฅํด ์ฃผ์ธ์.";
private static final String INPUT_WINNING_LOTTO_MESSAGE = "์ง๋ ์ฃผ ๋น์ฒจ ๋ฒํธ๋ฅผ ์
๋ ฅํด ์ฃผ์ธ์.";
+ private static final String MANUAL_LOTTO_COUNT_MESSAGE = ... | Java | ์ ํ๋ฆฌ์ผ์ด์
์คํ์ ์์ผ๋ณด๋ ์
๋ ฅ์ ์ฐ๋ฌ์ ๋ฐ๊ธฐ ๋๋ฌธ์ ํ ์ค ์
๋ ฅ์ ๋ฐ์ ํ ์
๋ ฅ์ ํ ๋ฒ ๋ ๊ธฐ๋ค๋ฆฌ๊ณ ์์ต๋๋ค! ์ด๋ค ์๋๋ก ์ฌ์ฉํ์ ๊ฑธ๊น์? |
@@ -9,19 +9,24 @@ public LottoGame() {
statistics = new TreeMap<>();
}
- public int inputMoney(int money) {
+ public int calculateLottoCount(int money) {
return lottoCount = money / Lotto.LOTTO_PRICE;
}
- public LottoTicket generateAutoLottoTicket() {
+ public LottoTicket gen... | Java | ์๋ ๋ก๋์ ์๋ ๋ก๋๋ฅผ ํจ๊ป ์์ฑํ๊ณ ์๋๋ฐ ์ด๋ฅผ ๋ถ๋ฆฌ์์ผ๋ณด๋ฉด ์ด๋จ๊น์?
```
List<Lotto> lottos = InputView.manualLotto(lottoCount);
OutputView.printLottoTicket(game.generateLottoTicket(lottos));
```
์ฝ๋ ์์ฒด๋ก generateLottoTicket์์ ์๋๋ก๋๊น์ง ์์ฑํด์ฃผ๋ ๊ฒ์ธ์ง ํน์ ์๋ํ๋๋ก ์๋ ๋ก๋์ ์๋ ๋ก๋๋ฅผ ํจ๊ป ์์ฑํ๋ ๊ฒ์ธ์ง ๋ฉ์๋๋ช
๋ง ๋ณด๊ณ ๋ ์๋ฏธ๊ฐ ์กฐ๊ธ ๋ชจํธํ๋ค๊ณ ์๊ฐ๋ฉ๋๋ค. (๊ฐ์ธ์ ์๊ฐ์ผ๋ก)
๊ทธ๋ฆฌ๊ณ ๋์ค์ ์๊ตฌ์ฌํญ์ด ๋ณ๊ฒฝ๋์ด `์... |
@@ -0,0 +1,12 @@
+public class BonusNumber {
+ private LottoNumber bonusNumber;
+
+ public BonusNumber(LottoNumber bonusNumber) {
+ this.bonusNumber = bonusNumber;
+ }
+
+ public LottoNumber getBonusNumber() {
+ return bonusNumber;
+ }
+}
+ | Java | LottoNumber ์์ฒด๋ ์์๊ฐ์ ํฌ์ฅํ ํํ๋ก LottoNumber ํ์
์ผ๋ก bonusNumber๋ฅผ ์ฌ์ฉํ ์ ์๋๋ฐ ์ด๋ฅผ ํ ๋ฒ ๋ ํฌ์ฅํ์ฌ ์ฌ์ฉํ์ ์ด์ ๊ฐ ์์ผ์ค๊น์? BonusNumber์์๋ ์ด๋ ํ ํ์๋ฅผ ํ์ง ์๊ณ ํฌ์ฅ๋ ๊ฐ์ ํ ๋ฒ ๋ Wrapping ํ๋ ํํ๋ก๋ง ์ฌ์ฉ๋๊ณ ์๋๋ฐ ๋ถํ์ํด ๋ณด์ฌ์์~ |
@@ -43,6 +43,10 @@ public int match(WinningLotto winningLotto) {
return matchCount;
}
+ public boolean isBonusMatch(WinningLotto winningLotto) {
+ return lotto.contains(winningLotto.getBonusNumber());
+ }
+
public boolean contains(LottoNumber lottoNumber) {
return lotto.contai... | Java | lotto์ ๋ณด๋์ค ์ซ์๊ฐ ํฌํจ๋์ด์๋์ง ํ๋ณํ๋ ์ญํ ์ ํ๋ ๋ฉ์๋๋ก ๋ณด์ด๋ค์. ๋จ์ํ ํ๋ณ ์ฌ๋ถ๋ผ๋ฉด boolean ํ์
์ผ๋ก ๋ณ๊ฒฝํด์ฃผ๋ฉด ์ด๋จ๊น์? ๋ง์ฝ ๋ณด๋์ค ์ซ์๊ฐ 1๊ฐ ์ด์์ด๋ผ๋ ์๊ตฌ์ฌํญ ๋ณ๊ฒฝ์ ์ผ๋ํ ๊ตฌํ์ด๋ผ๋ฉด 1, 0์ ๋ฆฌํดํ๋ ๊ฒ๋ณด๋ค ๊ตฌ์ฒด์ ์ผ๋ก ๋งค์นญ๋ ๊ฐฏ์๋ฅผ ๋ฆฌํดํด์ฃผ๋ ์์ผ๋ก ๋ณ๊ฒฝํด๋ณด๋ฉด ํ์ฅ์ ์ ๋ฆฌํ ๊ตฌํ์ด ๋ ๊ฒ ๊ฐ์์. ๋ฉ์๋๋ช
๋ ์๋ฏธ์ ๋ฌ์ ์กฐ๊ธ ๋ ๋ช
ํํ๊ฒ ํ๋ฉด ์๋ฒฝํ ๊ฒ ๊ฐ์ต๋๋คb |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.