code
stringlengths
41
34.3k
lang
stringclasses
8 values
review
stringlengths
1
4.74k
@@ -0,0 +1,20 @@ +import { DISPLAY_SIZE } from '../../../constants/displaySize'; +import LargeHeader from './LargeHeader'; +import MobileHeader from './MobileHeader'; + +interface HeaderProps { + searchKeyword: string; + onSearch: (keyword: string) => void; +} + +function Header({ searchKeyword, onSearch }: HeaderPro...
Unknown
์˜ค Header์—์„œ๋Š” ์‚ฌ์šฉ๋˜์ง€ ์•Š๋Š”๋ฐ ๋“ค์–ด๊ฐ€์žˆ๊ตฐ์š”! Header๋Š” ๋‹จ์ˆœํžˆ ๋ ˆ์ด์•„์›ƒ ๊ธฐ๋Šฅ๋งŒ ํ•˜๊ณ  ์žˆ์–ด์„œ ํƒ€์ž…์„ ํ™•์žฅํ•˜์ง€ ์•Š์•„๋„ ๋  ๊ฒƒ ๊ฐ™์•„์š” ์งš์–ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ด์š”~! > common ํด๋”์—๋งŒ _๊ฐ€ ๋ถ™์–ด์žˆ๋Š”๋ฐ ์ฒ˜์Œ ๋ณด๋Š” ์ปจ๋ฒค์…˜์ด๋ผ ์–ด๋–ค ์˜๋ฏธ์ธ์ง€๋„ ๊ถ๊ธˆํ•ด์š” ใ…Žใ…Ž _๋Š” ํด๋” ์ตœ์ƒ๋‹จ์— ๋„์›Œ์ง€๋„๋ก ํ•˜๊ธฐ ์œ„ํ•ด ๋„ฃ์€ ์ปจ๋ฒค์…˜์ด๋ž๋‹ˆ๋‹ค!๐Ÿค—
@@ -0,0 +1,58 @@ +import React, { useReducer } from 'react'; +import * as S from './Header.styled'; + +interface HeaderProps extends React.InputHTMLAttributes<HTMLInputElement> { + searchKeyword: string; + onSearch: (keyword: string) => void; +} + +type State = boolean; +type Action = { type: 'TOGGLE' } | { type: 'OP...
Unknown
๋งž์•„์š”! ๊ทธ๋ฆฌ๊ณ  input์ด ๋‹ซํ˜€ ์žˆ๋Š” ๊ฒฝ์šฐ input์„ ํด๋ฆญํ–ˆ์„ ๋•Œ ๊ฐ’์ด ์ž…๋ ฅ๋˜๋ฉด์„œ ๋‹๋ณด๊ธฐ ๋ฒ„ํŠผ ์œ„๋กœ ๋ณด์—ฌ์ง€๋Š” ๋ฌธ์ œ๊ฐ€ ๋ฐœ์ƒํ•ด์„œ disabled ์†์„ฑ์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹น
@@ -0,0 +1,58 @@ +import React, { useReducer } from 'react'; +import * as S from './Header.styled'; + +interface HeaderProps extends React.InputHTMLAttributes<HTMLInputElement> { + searchKeyword: string; + onSearch: (keyword: string) => void; +} + +type State = boolean; +type Action = { type: 'TOGGLE' } | { type: 'OP...
Unknown
์ฒ˜์Œ์—๋Š” ํ™•์žฅ์„ฑ์„ ์—ผ๋‘ํ•˜๊ณ  ๊ฐ์ฒด๋กœ ๋งŒ๋“ค์—ˆ๋Š”๋ฐ ์ด ๊ฒฝ์šฐ์—๋Š” `isExpanded`์˜ boolean ์ƒํƒœ ๋ณ€๊ฒฝ๋งŒ์„ ๋ชฉ์ ์œผ๋กœ ํ•˜๋‹ˆ ๊ฐ์ฒด๋กœ ๋งŒ๋“ค์ง€ ์•Š๊ณ  ์˜ฌ๋ฆฌ๊ฐ€ ์ œ์•ˆํ•œ ๋ฐฉ์‹๋„ ๊ดœ์ฐฎ์„ ๊ฒƒ ๊ฐ™๋‹ค๋Š” ์ƒ๊ฐ์ด ๋“œ๋„ค์š”~!
@@ -0,0 +1,58 @@ +import React, { useReducer } from 'react'; +import * as S from './Header.styled'; + +interface HeaderProps extends React.InputHTMLAttributes<HTMLInputElement> { + searchKeyword: string; + onSearch: (keyword: string) => void; +} + +type State = boolean; +type Action = { type: 'TOGGLE' } | { type: 'OP...
Unknown
์˜ค ์ •๋ง ํ† ๊ธ€๋งŒ ์‚ฌ์šฉ ์ค‘์ด๊ตฐ์š”,,, open๊ณผ close๋Š” ์Šต๊ด€์ ์œผ๋กœ ์ž‘์„ฑํ–ˆ๋˜ ๊ฒƒ ๊ฐ™๋„ค์š” ใ…‹ใ…‹ใ…‹์ฃผ์˜ํ•ด์•ผ๊ฒ ์–ด์š”๐Ÿ˜‚ `useReducer`๋ฅผ ์‚ฌ์šฉํ•œ ์ด์œ ๋Š” `isExpanded` state๋ฅผ ์—…๋ฐ์ดํŠธ ํ•˜๋Š” ๋ฐฉ์‹์„ ๋ช…์‹œ์ ์œผ๋กœ ๋‚˜ํƒ€๋‚ด๊ธฐ ์œ„ํ•จ์ด์—ˆ์–ด์š”! `useState`๋Š” ์ƒํƒœ๋ฅผ ์–ด๋–ค ๊ฐ’์œผ๋กœ ๋ณ€๊ฒฝํ•˜๋Š”์ง€ ๋‚˜ํƒ€๋‚ธ๋‹ค๋ฉด, `useReducer`๋Š” ์–ด๋–ค ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝํ• ์ง€๋ฅผ ๋ณด์—ฌ์ค„ ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ•ด์„œ `useReducer`๋ฅผ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ท
@@ -0,0 +1,43 @@ +package com.ll.backend.domain.admin.controller; + +import com.ll.backend.domain.admin.dto.AdminRequestDto; +import com.ll.backend.domain.admin.entity.Admin; +import com.ll.backend.domain.admin.service.AdminService; +import lombok.RequiredArgsConstructor; +import org.springframework.http.ResponseEntity...
Java
์™ธ๋ถ€์—๋Š” ์—๋Ÿฌ๊ฐ€ ์ตœ๋Œ€ํ•˜๊ฒŒ ๋…ธ์ถœ๋˜์ง€ ์•Š๋„๋ก ํ•ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. (ํŠนํžˆ๋‚˜, ์—๋Ÿฌ๊ฐ€ ๊ตฌ์ฒดํ™”๊ฐ€ ๋˜๋ฉด ์•ˆ ๋ฉ๋‹ˆ๋‹ค.) -> ์™ธ๋ถ€ ๊ณต๊ฒฉ์ž ์ž…์žฅ์—์„œ, ์ด ์„œ๋ฒ„์˜ ์ทจ์•ฝ์ ์ด ๋ฌด์—‡์ธ์ง€ ํŒ๋‹จํ•˜๊ธฐ ์‰ฌ์›Œ์ ธ์š”.
@@ -0,0 +1,43 @@ +package com.ll.backend.domain.admin.controller; + +import com.ll.backend.domain.admin.dto.AdminRequestDto; +import com.ll.backend.domain.admin.entity.Admin; +import com.ll.backend.domain.admin.service.AdminService; +import lombok.RequiredArgsConstructor; +import org.springframework.http.ResponseEntity...
Java
๋งŒ์•ฝ์— ์ด๊ฒŒ ์„œ๋ฒ„ ์—๋Ÿฌ๊ฐ€ ์•„๋‹ˆ๋ผ, ์˜ฌ๋ฐ”๋ฅด์ง€ ์•Š์€ ๊ฐ’์„ ํ•„ํ„ฐ๋งํ•˜๊ธฐ ์œ„ํ•œ ์˜ˆ์™ธ๋ผ๋ฉด, `catch (Exception e)` ๊ฐ€ ์•„๋‹ˆ๋ผ `catch (ServiceException e)` ์™€ ๊ฐ™์ด, ์—ฌ๋Ÿฌ๋ถ„๋“ค์ด ๋งŒ๋“  ์˜ˆ์™ธ๋งŒ catch ํ•˜๋„๋ก ๋งŒ๋“ค์–ด์ค˜์•ผ ํ•ฉ๋‹ˆ๋‹ค.
@@ -0,0 +1,11 @@ +package com.ll.backend.domain.admin.dto; + +import lombok.Getter; +import lombok.Setter; + +@Getter +@Setter +public class AdminRequestDto { + private String username; + private String password; +}
Java
record๋กœ ์ˆ˜์ •ํ•ด ์ฃผ์„ธ์š”.
@@ -0,0 +1,27 @@ +package com.ll.backend.domain.admin.service; + +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.order.repository.OrderRepository; +import com.ll.backend.domain.orderdetail.repository.OrderDetailRepository; +import com.ll.backend.domain.product.repository.ProductRepositor...
Java
๊ฐ€๋Šฅํ•˜๋ฉด, ์ด๋Ÿฐ ์‹์˜ "์„œ๋น„์Šค ์ ์ธ ์˜ˆ์™ธ"๋Š” ์ž๋ฐ”์—์„œ ์ •์˜ํ•œ ๊ธฐ๋ณธ ์˜ˆ์™ธ๋ฅผ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ๊ฒƒ์„ ๊ถŒ์žฅ๋“œ๋ ค์š”.
@@ -0,0 +1,27 @@ +package com.ll.backend.domain.admin.service; + +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.order.repository.OrderRepository; +import com.ll.backend.domain.orderdetail.repository.OrderDetailRepository; +import com.ll.backend.domain.product.repository.ProductRepositor...
Java
log๋กœ ๋Œ€์ฒดํ•ด ์ฃผ์„ธ์š”.
@@ -0,0 +1,56 @@ +package com.ll.backend.domain.admin.service; + +import com.ll.backend.domain.admin.entity.Admin; +import com.ll.backend.domain.admin.repository.AdminRepository; +import lombok.RequiredArgsConstructor; +import org.springframework.security.crypto.password.PasswordEncoder; +import org.springframework.ste...
Java
๊ฐ€๋Šฅํ•˜๋ฉด, ์ตœ๋Œ€ํ•œ ๋งŽ์€ ๊ฐ์ฒด๋“ค์—์„œ setter ์ง์ ‘ ํ˜ธ์ถœ์„ ๋ฐฐ์ œํ•ด ์ฃผ์„ธ์š”.
@@ -0,0 +1,56 @@ +package com.ll.backend.domain.admin.service; + +import com.ll.backend.domain.admin.entity.Admin; +import com.ll.backend.domain.admin.repository.AdminRepository; +import lombok.RequiredArgsConstructor; +import org.springframework.security.crypto.password.PasswordEncoder; +import org.springframework.ste...
Java
```java Admin admin = adminRepository.findByUsername(username) .orElseThrow(() -> new IllegalArgumentException("์‚ฌ์šฉ์ž๋ฅผ ์ฐพ์„ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค.")); ```
@@ -0,0 +1,42 @@ +package com.ll.backend.domain.order.controller; + +import com.ll.backend.domain.order.dto.OrderRequestDto; +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.order.service.OrderService; +import com.ll.backend.domain.orderdetail.service.OrderDetailService; +import com.ll.ba...
Java
์š”๊ฑฐ๋Š” ๊ฐ’์ด ์—†๋‹ค๊ณ  ํ•ด์„œ status๋ฅผ ๋‹ค๋ฅด๊ฒŒ ์ฃผ๋Š” ๊ฑด ์•„๋‹Œ ๊ฒƒ ๊ฐ™์•„์š”. (204 -> no content ๊ฐ€ ๋งž๊ธด ํ•œ๋ฐ, ์ €๊ฑด ์‘๋‹ต์ด ํ•„์š” ์—†๋Š” ์š”์ฒญ์— ๋Œ€ํ•œ ์‘๋‹ต ์ฝ”๋“œ์—์š”.)
@@ -0,0 +1,15 @@ +package com.ll.backend.domain.order.dto; + +import com.ll.backend.domain.orderdetail.dto.OrderDetailRequestDto; +import lombok.Getter; + +import java.util.List; + +@Getter +public class OrderRequestDto { + private String email; + private String address; + private String postalCode; + priva...
Java
Jakarta Validation ์ ์šฉ
@@ -0,0 +1,81 @@ +package com.ll.backend.domain.order.service; + +import com.ll.backend.domain.order.OrderStatus; +import com.ll.backend.domain.order.dto.OrderRequestDto; +import com.ll.backend.domain.order.dto.OrderResponseDto; +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.order.repos...
Java
๊ฐ์ฒด ์„ธํŒ…์€ ๊ฐ€๋Šฅํ•˜๋ฉด Service ์ด์™ธ์˜ ๊ณณ์œผ๋กœ ์œ ๋ฐฐ ๋ณด๋‚ด์‹œ์ฃ . ```java return orderRepository.findAll().stream() .map(OrderConverter::toOrderResponse) .toList(); ```
@@ -0,0 +1,81 @@ +package com.ll.backend.domain.order.service; + +import com.ll.backend.domain.order.OrderStatus; +import com.ll.backend.domain.order.dto.OrderRequestDto; +import com.ll.backend.domain.order.dto.OrderResponseDto; +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.order.repos...
Java
```java //๋ฐฐ์†ก ์ƒํƒœ ๋ณ€๊ฒฝ @Transactional public void updateDeliveryStatus(OrderDeliveryRequestDto orderDeliveryRequestDto) { List<Integer> orderIds = orderDeliveryRequestDto.getId(); if (CollectionUtils.isEmpty(orderIds)) { throw new IllegalArgumentException("ID list cannot be null or empty."); } for (Intege...
@@ -0,0 +1,29 @@ +package com.ll.backend.domain.orderdetail.controller; + +import com.ll.backend.domain.orderdetail.dto.OrderDetailResponseDto; +import com.ll.backend.domain.orderdetail.service.OrderDetailService; +import lombok.RequiredArgsConstructor; +import org.springframework.http.HttpStatus; +import org.springfra...
Java
Integer๋กœ ๋ฐ›์์‹œ๋‹ค.
@@ -0,0 +1,29 @@ +package com.ll.backend.domain.orderdetail.controller; + +import com.ll.backend.domain.orderdetail.dto.OrderDetailResponseDto; +import com.ll.backend.domain.orderdetail.service.OrderDetailService; +import lombok.RequiredArgsConstructor; +import org.springframework.http.HttpStatus; +import org.springfra...
Java
(๋‚˜์ค‘์— ์‹œ๊ฐ„ ๋‚˜๋ฉด ํ™•์ธํ•ด ๋ณด์„ธ์š”~~~~~) - `@ControllerAdvice`, `@ExceptionHandler` ๋ฅผ ๊ฐ™์ด ์‚ฌ์šฉํ•˜๋ฉด, ์ €ํฌ๊ฐ€ ๊ตณ์ด ์ €๋ ‡๊ฒŒ ์‘๋‹ต ์ฝ”๋“œ๋ฅผ ๋ถ„๊ธฐํ•˜์ง€ ์•Š์•„๋„ ์˜ˆ์™ธ์˜ ์ข…๋ฅ˜๋งŒ ๋ณด๊ณ  HttpStatusCode๋ฅผ ์ง€์ •ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,15 @@ +package com.ll.backend.domain.orderdetail.repository; + +import com.ll.backend.domain.order.entity.Order; +import com.ll.backend.domain.orderdetail.entity.OrderDetail; +import org.springframework.data.jpa.repository.JpaRepository; + +import java.util.List; + +public interface OrderDetailRepository ext...
Java
Google Java Convention/Naver Java Convention ๋ชจ๋‘์—์„œ, ๋ฉ”์„œ๋“œ ์ด๋ฆ„์— ์–ธ๋”์Šค์ฝ”์–ด๋ฅผ ์“ฐ์ง€ ๋ง๋ผ๊ณ  ์ ํ˜€์žˆ์„๊ฑฐ์—์š”. (์ผ๋ฐ˜์ ์œผ๋กœ ํ…Œ์ŠคํŠธ๊ฐ€ ์•„๋‹ˆ๋ผ๋ฉด ๋ฉ”์„œ๋“œ ์ด๋ฆ„์— ์–ธ๋”์Šค์ฝ”์–ด๋ฅผ ์“ฐ์ง€ ์•Š์Šต๋‹ˆ๋‹ค.)
@@ -25,6 +25,7 @@ public class Board { @Column(updatable = false) private LocalDateTime createdAt = LocalDateTime.now(); + @ManyToOne(fetch = FetchType.LAZY) @JoinColumn(name = "userId") private User user;
Java
N+1 ๋ฌธ์ œ๋ฅผ ๊ณ ๋ คํ•ด์•ผํ•ด์„œ ์ˆ˜์ •ํ•ด์•ผํ•จ
@@ -22,18 +22,19 @@ public class BoardService { private final BoardRepository boardRepository; private final UserRepository userRepository; - LocalDateTime now = LocalDateTime.now(); - @Transactional + + @Transactional(readOnly = true) public Page<Board> getBoards(int page, int size) { ...
Java
์•„๋ž˜์ฒ˜๋Ÿผ ๋กœ์ง์ด ๋ฐ”๋€Œ์–ด์•ผํ•จ ```java @Transactional public void delete(BoardDeleteDto dto) { // ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง์˜ ๋ฌธ์ œ -> ์ด๋Ÿฐ๊ฑฐ๋ฅผ ๊ณ ๋ฏผํ•˜๋Š”๊ฒŒ ๋ฐฑ์—”๋“œ ๊ฐœ๋ฐœ์ž์˜ ์—ญํ•  // ๊ฒŒ์‹œํŒ์„ ์ฐพ๋Š”๋‹ค. final Board board = boardRepository.findById(dto.getId()) .orElseThrow(() -> new RuntimeException("์ผ์น˜ํ•˜๋Š” ๊ฒŒ์‹œ๋ฌผ์ด ์—†์Šต๋‹ˆ๋‹ค.")); ...
@@ -1,5 +1,22 @@ +import MovieListContainer from './components/MovieListContainer'; +import Header from './components/Header'; +import QueryErrorBoundary from './components/common/QueryResetErrorboundary'; + function App() { - return <div>hi</div>; + return ( + <div style={AppStyle}> + <QueryErrorBoundary> +...
Unknown
์™€์šฐ ์—๋Ÿฌ๋ฐ”์šด๋”๋ฆฌ๊นŒ์ง€...!๐Ÿ‘๐Ÿป
@@ -0,0 +1,56 @@ +import * as S from './styles'; +import Portal from '../common/Portal'; +import ModalBackground from '../common/ModalBackground'; +import useGetMovieDetail from '../../hooks/useGetMovieDetail'; +import {IMAGE_BASE_URL} from '../../constants/movie'; +import {toOneDecimalPlace} from '../../utils/number';...
Unknown
๋ชจ๋‹ฌ ๋ฐ์ดํ„ฐ๋ฅผ ๋ถˆ๋Ÿฌ์˜ค๊ณ  ์žˆ๋Š” ์ค‘์—๋Š” ๋ชจ๋‹ฌ์ด ์•ˆ๋„์›Œ์ง€๋”๋ผ๊ตฌ์š”. ๊ทธ๋ž˜์„œ Movie๋ฅผ ํด๋ฆญํ–ˆ์„ ๋•Œ ์•ฝ๊ฐ„์˜ ์ง€์—ฐ์‹œ๊ฐ„ ํ›„์— ๋ชจ๋‹ฌ์ด ๋„์›Œ์ง€๊ณ  ์žˆ๊ตฌ์š”! ์ด ๋ถ€๋ถ„์—์„œ ์‚ฌ์šฉ์„ฑ์„ ์œ„ํ•ด ์Šค์ผˆ๋ ˆํ†ค์ด๋‚˜ Suspense๊ฐ™์€ UI๋ฅผ ๋„ฃ๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?
@@ -0,0 +1,81 @@ +import {BASE_URL, POPULAR_MOVIE_URL, SEARCH_URL} from '../constants/movie'; +import {MovieDetail, MovieList} from '../types/movie'; +import {createApiErrorMessage} from '../utils/error'; + +export const getMovieList = async ({pageParam = 1}: {pageParam?: number}) => { + const params = { + api_key:...
TypeScript
์—ฌ๊ธฐ์„œ๋Š” as๋กœ ๋ฆฌํ„ดํ•˜๊ณ  ์žˆ๊ตฐ์š”! ํ˜น์‹œ ํƒ€์ž… ๋‹จ์–ธ์„ ํ•˜๋Š” ๊ฒฝ์šฐ๋„ `getMovieDetail` ํ•จ์ˆ˜์˜ ๋ฆฌํ„ด๊ฐ’ ํƒ€์ž… ์ถ”๋ก ์ด ๋˜๋‚˜์š”??(์ž˜ ๋ชฐ๋ผ์„œ...) ์‚ฌ์‹ค ์„œ๋ฒ„๋กœ๋ถ€ํ„ฐ ์˜ค๋Š” ๋ฐ์ดํ„ฐ ํƒ€์ž…์„ Typescript๊ฐ€ ์ถ”๋ก ํ•  ์ˆ˜๋Š” ์—†์–ด์„œ `as`๋„ ์ƒ๊ด€์—†์„ ๊ฒƒ ๊ฐ™์ง€๋งŒ ๊ถŒ์žฅ๋˜๋Š” ํ˜•์‹์€ ๋ช…์‹œ์ ์ธ ๋ฐ˜ํ™˜ ํƒ€์ž… ์„ ์–ธ์„ ํ•˜๋Š” ๋ฐฉ๋ฒ• ๊ฐ™์•„์„œ์š”! ์˜ฌ๋ฆฌ๋Š” as์™€ ๋ฐ˜ํ™˜ ํƒ€์ž… ์„ ์–ธ ์ค‘ ์–ด๋–ค ๋ฐฉ๋ฒ•์ด ๋” ๋‚ซ๋‹ค๊ณ  ์ƒ๊ฐํ•˜๋Š”์ง€ ๊ถ๊ธˆํ•ด์š”!
@@ -0,0 +1,56 @@ +import * as S from './styles'; +import Portal from '../common/Portal'; +import ModalBackground from '../common/ModalBackground'; +import useGetMovieDetail from '../../hooks/useGetMovieDetail'; +import {IMAGE_BASE_URL} from '../../constants/movie'; +import {toOneDecimalPlace} from '../../utils/number';...
Unknown
selectedMovieId๋„ props๊ฐ€ ๊ฝค ๊นŠ์ด ์žˆ์–ด์„œ ์ „์—ญ์œผ๋กœ ๊ด€๋ฆฌํ•ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์€๋ฐ ์–ด๋–จ๊นŒ์š”??
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
๋ฐ์ดํ„ฐ ํ˜•์‹ ์ฒ˜๋ฆฌ๋ฅผ MovieList์—์„œ ํ•˜๊ณ  ์žˆ๊ตฐ์š”! ์ œ ์ƒ๊ฐ์—๋Š” ์—ญํ• ์— ๋”ฐ๋ผ useGetList์—์„œ ๋‹ด๋‹นํ•  ์ˆ˜๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”!
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
์˜ค ์ด๋ ‡๊ฒŒ ๋ฌดํ•œ ์Šคํฌ๋กค ๋กœ์ง์„ ๋ถ„๋ฆฌํ•˜๋‹ˆ ์ •๋ง ๊น”๋”ํ•˜๋„ค์š”๐Ÿ‘๐Ÿป
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
closest๋ฅผ ์‚ฌ์šฉํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?!
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
์˜คํ˜ธ ์ด๋ ‡๊ฒŒ ๋งˆ์ง€๋ง‰ ์š”์†Œ์— ref๋ฅผ ๋„ฃ๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ๊ตฐ์š”..! ์ด๋ ‡๊ฒŒ ํ•˜๋ฉด ํ™•์‹คํžˆ ๋งˆ์ง€๋ง‰ ์š”์†Œ๊นŒ์ง€ ๋„๋‹ฌํ–ˆ์„ ๋•Œ ์ƒˆ๋กœ์šด API๋ฅผ ํ˜ธ์ถœํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
์ด ๋ถ€๋ถ„์„ ์ƒˆ๋กœ์šด ์ปดํฌ๋„ŒํŠธ๋กœ ๋ถ„๋ฆฌํ•ด๋ณด๋Š” ๊ฑด ์–ด๋–จ๊นŒ์š”? ref๋ฅผ MovieItem์— ์ง์ ‘ ๋„˜๊ฒจ์ฃผ๋Š” ๋ฐฉ๋ฒ•์œผ๋กœ๋„ ํ•ด๋ณผ ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”
@@ -0,0 +1,24 @@ +import {IMAGE_BASE_URL} from '../../constants/movie'; +import filledStar from '../../assets/star_filled.png'; +import {Movie} from '../../types/movie'; +import * as S from './styles'; +import {toOneDecimalPlace} from '../../utils/number'; + +export type MovieItemProps = Pick<Movie, 'id' | 'title' | 'p...
Unknown
์˜ค Pick์„ ์‚ฌ์šฉํ–ˆ๊ตฐ์š”! ์˜ฌ๋ฆฌ๋Š” Pick๊ณผ Omit์˜ ์‚ฌ์šฉ ๊ธฐ์ค€์ด ์žˆ์„๊นŒ์š”? ์ €๋Š” Omit์„ ์ฃผ๋กœ ์‚ฌ์šฉํ•˜๋Š” ํŽธ์ด๋ผ์„œ์š”! ๊ทธ๋ฆฌ๊ณ  MovieItemProps๋Š” ๋‹ค๋ฅธ ๊ณณ์—์„œ ์‚ฌ์šฉ๋˜์ง€ ์•Š๊ธฐ ๋•Œ๋ฌธ์— export๊ฐ€ ์—†์–ด๋„ ๋  ๊ฒƒ ๊ฐ™์Šด๋‹ค!
@@ -0,0 +1,24 @@ +import {IMAGE_BASE_URL} from '../../constants/movie'; +import filledStar from '../../assets/star_filled.png'; +import {Movie} from '../../types/movie'; +import * as S from './styles'; +import {toOneDecimalPlace} from '../../utils/number'; + +export type MovieItemProps = Pick<Movie, 'id' | 'title' | 'p...
Unknown
id๋Š” liํƒœ๊ทธ์˜ id์ธ ๊ฑธ๊นŒ์š”? idํƒœ๊ทธ๋ฅผ ๋„ฃ์–ด์ค€ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ด์š”!
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
infiniteQuery์—์„œ ์ƒˆ๋กœ์šด ๋ฐฐ์—ด์„ ๊ธฐ์กด ๋ฐฐ์—ด์— ๋„ฃ์–ด์ฃผ๊ณ  ์žˆ๊ธฐ ๋•Œ๋ฌธ์— ์ด ๋ถ€๋ถ„์€ ์—†์–ด๋„ ๋  ๊ฒƒ ๊ฐ™์•„์š”~!
@@ -0,0 +1,30 @@ +import styled from '@emotion/styled'; +import searchImg from '../../assets/search_button.png'; + +export const Search = styled.section` + display: flex; + height: 3rem; + + background: #fff; + padding: 8px; + border-radius: 4px; + + button { + width: 14px; + border: 0; + text-indent: -1...
TypeScript
form์œผ๋กœ๋„ ์ฒ˜๋ฆฌํ•ด๋ณผ ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์€๋ฐ ์˜ฌ๋ฆฌ๋Š” ์–ด๋–ค ๋ฐฉ๋ฒ•์ด ๋” ํŽธํ• ๊นŒ์š”?
@@ -0,0 +1,17 @@ +import React, {useRef} from 'react'; + +import * as S from './styles.ts'; +import useModalClose from '../../../hooks/useModalClose.ts'; + +interface ModalBackgroundProps { + closeModal: (() => void) | null; + children?: React.ReactNode; +} + +const ModalBackground = ({children, closeModal}: ModalBac...
Unknown
React.FC๋ฅผ ์‚ฌ์šฉํ•œ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”?!
@@ -0,0 +1,81 @@ +import {BASE_URL, POPULAR_MOVIE_URL, SEARCH_URL} from '../constants/movie'; +import {MovieDetail, MovieList} from '../types/movie'; +import {createApiErrorMessage} from '../utils/error'; + +export const getMovieList = async ({pageParam = 1}: {pageParam?: number}) => { + const params = { + api_key:...
TypeScript
์„œ๋ฒ„์—์„œ ๋ฐ์ดํ„ฐ๋ฅผ ํ˜ธ์ถœํ•˜๋Š” ์ง€์—ฐ ์‹œ๊ฐ„์ด ์žˆ๊ธฐ ๋•Œ๋ฌธ์— delay๋ฅผ ๊ฑธ์ง€ ์•Š์•„๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”! ์ €๋Š” ๊ตฌํ˜„ํ•  ๋•Œ ๋„คํŠธ์›Œํฌ ์†๋„๋‚˜ performance์—์„œ CPU๋ฅผ ์ œ์–ดํ•˜๋ฉด์„œ ํ…Œ์ŠคํŠธํ–ˆ๋‹ต๋‹ˆ๋‹ค๐Ÿ˜Š
@@ -0,0 +1,59 @@ +import React, {Component, ReactNode} from 'react'; + +import {TOAST_ERROR} from '../../../constants/error'; + +export interface FallbackProps { + error: Error; + resetErrorBoundary: () => void; +} + +interface ErrorBoundaryProps { + fallback: React.ComponentType<FallbackProps>; + children: ReactNo...
Unknown
์˜คํ™ ํ† ์ŠคํŠธ ๊ตฌํ˜„๋„ ๊ถ๊ธˆํ•ด์ง€๋„ค์š”๐Ÿคฉ ๊ธฐ๋Œ€ํ•ด๋ด๋„....์ข‹์„๊นŒ์š”....?ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹
@@ -0,0 +1,66 @@ +import {useAtomValue} from 'jotai'; +import useGetList from '../../hooks/useGetList'; +import useInfiniteScroll from '../../hooks/useInfiniteScroll'; +import * as S from './styles'; +import MovieItem from '../MovieItem'; +import SkeletonMovieList from '../skeleton/MovieList'; +import {searchTextAtom} ...
Unknown
์•— ์ด ๋ถ€๋ถ„๋•Œ๋ฌธ์— ์˜ํ™”๊ฐ€ 2๋ฒˆ ๋ณด์˜€๋˜ ๊ฑฐ๋„ค์š”๐Ÿ˜‚ ๋•๋ถ„์— ์•Œ์•„์ฐจ๋ ธ์–ด์š”!
@@ -1,5 +1,22 @@ +import MovieListContainer from './components/MovieListContainer'; +import Header from './components/Header'; +import QueryErrorBoundary from './components/common/QueryResetErrorboundary'; + function App() { - return <div>hi</div>; + return ( + <div style={AppStyle}> + <QueryErrorBoundary> +...
Unknown
์‚ฌ์‹ค ์žˆ๋Š” ์ฝ”๋“œ๋ฅผ ๊ฐ€์ ธ์™”์Šต๋‹ˆ๋‹คใ…‹ใ…‹ใ…‹ใ…‹
@@ -0,0 +1,56 @@ +import * as S from './styles'; +import Portal from '../common/Portal'; +import ModalBackground from '../common/ModalBackground'; +import useGetMovieDetail from '../../hooks/useGetMovieDetail'; +import {IMAGE_BASE_URL} from '../../constants/movie'; +import {toOneDecimalPlace} from '../../utils/number';...
Unknown
์‚ฌ์‹ค ์ €๋Š” 1์ดˆ ์–ธ์ €๋ฆฌ์˜ ์งง์€ ๋กœ๋”ฉ ์‹œ๊ฐ„์ด๋ผ๋ฉด ์Šค์ผˆ๋ ˆํ†ค์„ ๊ฑฐ๋Š” ๊ฒŒ ์˜คํžˆ๋ ค ์ •์‹ ์—†๋‹ค๊ณ  ์ƒ๊ฐํ•ด์„œ ์„ ํ˜ธํ•˜์ง€ ์•Š๋Š” ํŽธ์ธ๋ฐ, ๋ชจ๋‹ฌ์€ 1์ดˆ๋Œ€์˜ ๋กœ๋”ฉ์ด์ง€๋งŒ ํ™”๋ฉด ์ „ํ™˜์ด ๋ฐ”๋กœ ์ผ์–ด๋‚  ๊ฒƒ์„ ๊ธฐ๋Œ€ํ•˜๊ณ  ํด๋ฆญํ•˜๋Š” ๊ฑฐ๋‹ˆ๊นŒ ๋ชจ๋‹ฌ์€ ๋ฐ”๋กœ ๋„์šฐ๋˜ ๋กœ๋”ฉ UI๋ฅผ ๋ณด์—ฌ์ฃผ๋Š” ๊ฒŒ ํ›จ์”ฌ ์ž์—ฐ์Šค๋Ÿฌ์šธ ๊ฒƒ ๊ฐ™๋„ค์š”! ๊ฐœ๋ฐœํ•˜๋ฉด์„œ ๋ˆŒ๋ €๋˜ ๊ฒƒ๋งŒ ๊ณ„์† ๋ˆŒ๋Ÿฌ์„œ ๋А๋ฆฐ ์ค„๋„ ๋ชจ๋ฅด๊ณ  ์žˆ์—ˆ๋„ค์š”...ใ…‹ใ…‹ใ…‹ใ…‹ใ…‹
@@ -0,0 +1,81 @@ +import {BASE_URL, POPULAR_MOVIE_URL, SEARCH_URL} from '../constants/movie'; +import {MovieDetail, MovieList} from '../types/movie'; +import {createApiErrorMessage} from '../utils/error'; + +export const getMovieList = async ({pageParam = 1}: {pageParam?: number}) => { + const params = { + api_key:...
TypeScript
์ด ๋ถ€๋ถ„์€ ํ”„๋กœ์ ํŠธ ํ•  ๋•Œ ๊ณ„์† ์จ์™€์„œ ๊ทธ๋Ÿฐ๊ฐ€ ๋ณ„ ์ƒ๊ฐ ์—†์ด ์ผ์–ด์š”...ใ…Ž (ํฐ ๋ฌธ์ œ๊ฐ€ ์žˆ์—ˆ๋‹ค๋ฉด ๋ˆ„๊ตฐ๊ฐ€ ์ง€์ ํ•ด์คฌ๊ฒ ์ง€ ํ•˜๋Š” ์•ˆ์ผํ•จ) ๋‹น์žฅ ๋“œ๋Š” ์ƒ๊ฐ์€ ์ผ๋ฐ˜์ ์ธ ๊ฒฝ์šฐ์—๋Š” ๋‹จ์–ธ์„ ํ•ด๋„ ๋ฌธ์ œ๋Š” ์—†์„ ๊ฒƒ ๊ฐ™๋‹ค๋Š” ์ƒ๊ฐ์ž…๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ์„œ๋ฒ„๊ฐ€ ๊นจ์ ธ์„œ ์ด์ƒํ•œ ๊ฐ’์„ ๋ณด๋‚ด์ฃผ๋Š” ๊ฒฝ์šฐ์—๋Š” ๋””๋ฒ„๊น…ํ•˜๊ธฐ ์–ด๋ ค์šธ ์ˆ˜๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”. ํƒ€์ž… ์ถ”๋ก ์€ as๊ฐ€ ์• ์ดˆ์— ์ด๊ฑธ๋กœ ์ถ”๋ก ํ•ด๋ผ! ๋ผ๊ณ  ๋ช…๋ นํ•˜๋Š” ๊ฑฐ๋‹ˆ๊นŒ ๋ฌธ์ œ์—†์ด ๋˜๋Š” ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ์‹ค์ œ๋กœ ๋ฆฌ์•กํŠธ ์ฟผ๋ฆฌ ์ฝ”๋“œ๋ฅผ ์“ธ ๋•Œ ์ œ๋„ค๋ฆญ์œผ๋กœ ๋ฆฌํ„ด ํƒ€์ž…์„ ๋ช…์‹œํ•ด์ฃผ์ง€ ์•Š์•„๋„ ์•Œ์•„์„œ data ํƒ€์ž…์„ ์ถ”๋ก ํ•ด์ฃผ๋”๋ผ๊ณ ์š”. ๋งŒ์•ฝ ๊ณ ์ณ๋ณธ๋‹ค๋ฉด Promise์— ์ œ๋„ค๋ฆญ...
@@ -1,13 +1,16 @@ package nextstep.app; +import jakarta.servlet.http.HttpServletRequest; import nextstep.app.domain.Member; import nextstep.app.domain.MemberRepository; import nextstep.security.authentication.AuthenticationException; import nextstep.security.authentication.BasicAuthenticationFilter; import next...
Java
์ž˜ ์ถ”๊ฐ€ํ•ด์ฃผ์…จ๋„ค์š” ๐Ÿ‘
@@ -0,0 +1,5 @@ +package nextstep.security.authorization.manager; + +public interface AuthorizationResult { + boolean isGranted(); +}
Java
๋ฏธ์…˜๋‚ด์˜ ์š”๊ตฌ์‚ฌํ•ญ์€ `AuthorizationDecision`์ด์—ˆ์œผ๋‚˜ ์ตœ๊ทผ ๋ฒ„์ „์—์„œ์˜ ์ถ”์ƒํ™”๋ฅผ ์ž˜ ๊ตฌํ˜„ํ•ด์ฃผ์…จ๋„ค์š”
@@ -0,0 +1,20 @@ +package nextstep.security.authorization.manager; + +public enum AuthorizationDecision implements AuthorizationResult { + GRANTED(true), + NOT_GRANTED(false); + + private final boolean granted; + + AuthorizationDecision(final boolean granted) { + this.granted = granted; + } + + ...
Java
true์™€ false๋กœ ๊ตฌ์„ฑ๋˜์–ด์žˆ์–ด enum์œผ๋กœ ์ƒ๊ฐํ•ด๋ณผ ์ˆ˜๋„ ์žˆ์œผ๋‚˜ ์‹ค์ œ ๊ตฌํ˜„์ฒด์—์„œ๋Š” `AuthorizationDecision`์„ ์ƒ์†๋ฐ›์•„ ๊ตฌํ˜„ํ•˜๋Š” ์ƒˆ๋กœ์šด ๊ตฌํ˜„์ฒด๋“ค๋„ ์žˆ์–ด enum์œผ๋กœ ์‚ฌ์šฉ๋˜์ง€๋Š” ์•Š์Šต๋‹ˆ๋‹ค. ์ผ๋ฐ˜์ ์œผ๋กœ enum์„ ๊ตฌ์„ฑํ•˜๋Š” ๊ฒƒ์€ ๋ช‡๊ฐ€์ง€ ๊ณ ์ •๊ฐ’์ด ์žˆ๊ธฐ ๋•Œ๋ฌธ์— enum์œผ๋กœ ํ‘œํ˜„ํ•˜์ง€๋Š” ์•Š๊ณ  ์ •๋ง staticํ•œ ์ •๋ณด๋“ค๋กœ ํ‘œ๊ธฐ๋ ๋•Œ์—๋งŒ ์‚ฌ์šฉ๋˜์–ด์š”. ์˜ˆ๋ฅผ๋“ค๋ฉด `HttpStatus`๋Š” 400, 401๊ณผ ๊ฐ™์€ ์ฝ”๋“œ๊ฐ€ ์žˆ๊ธฐ ๋•Œ๋ฌธ์— ๊ฐ๊ฐ์„ ํ‘œ๊ธฐํ•˜๋Š” ๊ฒƒ์ฒ˜๋Ÿผ์š”. ๊ทธ๋ž˜์„œ ์‚ฌ์‹ค์€ `AuthorizationDecision`์€ granted๊ฐ€ ์žˆ๋‹ค ์—†๋‹ค๋กœ ์ƒ์„ฑ๋˜๋Š” ๊ฐ์ฒด์ผ๋ฟ...
@@ -1 +1,17 @@ # spring-security-authorization + +# ๐Ÿš€ 1๋‹จ๊ณ„ - AuthorizationManager๋ฅผ ํ™œ์šฉ + +- [x] AuthorizationManager๋ฅผ ํ™œ์šฉํ•˜์—ฌ ์ธ๊ฐ€ ๊ณผ์ • ์ถ”์ƒํ™” + - [x] SecuredAuthorizationManager ๊ตฌํ˜„ + - [x] RequestAuthorizationManager ๊ตฌํ˜„ + - [x] SecuredAuthorizationManager ๊ตฌํ˜„ + +# ๐Ÿš€ 2๋‹จ๊ณ„ - ์š”์ฒญ๋ณ„ ๊ถŒํ•œ ๊ฒ€์ฆ ์ •๋ณด ๋ถ„๋ฆฌ + +- [x] ์š”์ฒญ๋ณ„ ๊ถŒํ•œ ๊ฒ€์ฆ ์ •๋ณด๋ฅผ ๋ณ„๋„์˜ ๊ฐ์ฒด๋กœ ๋ถ„๋ฆฌํ•˜์—ฌ ๊ด€...
Unknown
```suggestion - [x] SecuredAuthorizationManager ๊ตฌํ˜„ - [x] RequestAuthorizationManager ๊ตฌํ˜„ ``` ์ค‘๋ณต๋˜์–ด์žˆ๋„ค์š” :)
@@ -0,0 +1,25 @@ +package nextstep.security.authorization.manager; + +import nextstep.security.authentication.Authentication; +import nextstep.security.authorization.Secured; +import org.aopalliance.intercept.MethodInvocation; + +import java.lang.reflect.Method; + +public class SecuredAuthorizationManager implements Au...
Java
`SecuredAuthorizationManager`์˜ ๊ตฌํ˜„ ๋‚ด์šฉ๊ณผ `AuthorityAuthorizationManager`์˜ ๊ตฌํ˜„ ๋‚ด์šฉ์„ ์ƒ๊ฐํ•ด๋ณด๋ฉด ์„œ๋กœ ๋น„์Šทํ•œ ๋™์ž‘์ด ๋ฐ˜๋ณต๋˜๋Š” ๊ฒƒ์„ ๋ณผ ์ˆ˜ ์žˆ๋Š”๋ฐ์š”. `AuthorizationManager`๋“ค์˜ ๊ตฌํ˜„์ฒด๋“ค์€ ๊ฐ๊ฐ ๋”ฐ๋กœ ๊ตฌ์„ฑ๋˜๋Š” ๊ฒƒ์ด ์•„๋‹Œ ์„œ๋กœ๋ฅผ ์‚ฌ์šฉํ•  ์ˆ˜ ์žˆ๋„๋ก ์—ฐ๊ฒฐํ•  ์ˆ˜ ์žˆ์–ด์š”. ๊ทธ๋ž˜์„œ `AuthorityAuthorizationManager`์—์„œ authority๊ฐ€ ์žˆ๋Š”์ง€๋ฅผ ์ฒดํฌํ•˜๋Š” ๋กœ์ง์„ ํ˜„์žฌ์™€ ๊ฐ™์ด ์ „๋ถ€ ๋ชฐ์•„๋„ฃ๊ณ , `SecuredAuthorizationManager`๋Š” `@Secured`์— ์žˆ๋Š” ๊ฐ’์„ ๊บผ๋‚ด ...
@@ -3,11 +3,14 @@ import nextstep.app.domain.Member; import nextstep.app.domain.MemberRepository; import nextstep.security.authorization.Secured; +import nextstep.security.context.SecurityContext; +import nextstep.security.context.SecurityContextHolder; import org.springframework.http.ResponseEntity; import org.sp...
Java
orElseThrow()๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด ๋” ๊ฐ„๊ฒฐํ•˜๊ณ  ์ฒ˜๋ฆฌํ•  ์ˆ˜ ์žˆ๊ฒ ๋„ค์š” ๐Ÿ˜„ ```suggestion Member member = memberRepository.findByEmail(email) .orElseThrow(() -> new IllegalStateException("ํšŒ์›์„ ์ฐพ์„ ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค. (email=%s)".formatted(email))); return ResponseEntity.ok(member); } ```
@@ -0,0 +1,26 @@ +package nextstep.security.authorization; + +import nextstep.security.authentication.Authentication; +import org.aopalliance.intercept.MethodInvocation; + +import java.lang.reflect.Method; +import java.util.Set; + +public class SecuredAuthorizationManager implements AuthorizationManager<MethodInvocatio...
Java
Spring AOP ํ™˜๊ฒฝ์—์„œ๋Š” ๋ฉ”์„œ๋“œ๊ฐ€ ํ”„๋ก์‹œ ๊ฐ์ฒด๋กœ ๊ฐ์‹ธ์งˆ ์ˆ˜ ์žˆ๊ธฐ ๋•Œ๋ฌธ์—, ํ”„๋ก์‹œ๋œ ๋ฉ”์„œ๋“œ๋ฅผ ์กฐํšŒํ•  ๊ฒฝ์šฐ ์‹ค์ œ ๊ตฌํ˜„์ฒด์˜ ๋ฉ”์„œ๋“œ์—์„œ ์„ ์–ธ๋œ `@Secured` ์–ด๋…ธํ…Œ์ด์…˜์„ ์ฐพ์ง€ ๋ชปํ•  ๊ฐ€๋Šฅ์„ฑ์ด ์žˆ์Šต๋‹ˆ๋‹ค. method.getAnnotation ์™€ AopUtils.getMostSpecificMethod() ์–ด๋–ค ์ฐจ์ด๊ฐ€ ์žˆ์„๊นŒ์š”? ๐Ÿ˜„
@@ -0,0 +1,11 @@ +package nextstep.security.util.matcher; + +import jakarta.servlet.http.HttpServletRequest; + +public class AnyRequestMatcher implements RequestMatcher { + + @Override + public boolean matches(HttpServletRequest request) { + return true; + } +}
Java
AnyRequestMatcher๋Š” ๋™์ผํ•œ ๋™์ž‘์„ ์ˆ˜ํ–‰ํ•˜๋Š” ๋ถˆ๋ณ€ ๊ฐ์ฒด์ด๋ฏ€๋กœ ์‹ฑ๊ธ€ํ†ค ํŒจํ„ด ์ ์šฉ์„ ํ•ด๋ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ๐Ÿ˜„ ๋˜ํ•œ, ์™ธ๋ถ€์—์„œ ์ธ์Šคํ„ด์Šค ์ƒ์„ฑ์„ ๋ฐฉ์ง€ํ•˜๋„๋ก private ์ƒ์„ฑ์ž๋ฅผ ์ถ”๊ฐ€ํ•˜๋Š” ๊ฒƒ๋„ ์ข‹๊ฒ ๋„ค์š”๐Ÿ˜„ ``` java public static final AnyRequestMatcher INSTANCE = new AnyRequestMatcher(); private AnyRequestMatcher() { } ```
@@ -5,6 +5,9 @@ import org.junit.jupiter.api.BeforeEach; import org.junit.jupiter.api.DisplayName; import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; import org.springfram...
Java
ํฌ์œผ ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๐Ÿ‘
@@ -0,0 +1,40 @@ +package nextstep.security.authorization; + +import jakarta.servlet.http.HttpServletRequest; +import nextstep.security.authentication.Authentication; +import nextstep.security.util.matcher.RequestMatcherEntry; + +import java.util.List; + +/** + * - ์š”์ฒญ์— ๋Œ€ํ•ด์„œ ์ ํ•ฉํ•œ ๊ถŒํ•œ์ด ์žˆ๋Š”์ง€๋งŒ ํŒ๋‹จ. + * - ์ธ๊ฐ€๊ฐ€ ๋˜์ง€ ์•Š์•˜์„ ๊ฒฝ์šฐ ์˜ˆ์™ธ๋ฅผ ๋ฐœ์ƒ์‹œํ‚ค์ง€...
Java
> Q. ๋ฏธ์…˜์„ ๊ตฌํ˜„ํ•˜๋‹ค๋ณด๋‹ˆ RequestAuthorizationManager์—์„œ Genric Raw Use ๊ด€๋ จํ•ด์„œ ๊ฒฝ๊ณ ๊ฐ€ ๋œจ๋˜๋ฐ ์ด ๋ถ€๋ถ„์„ ์–ด๋–ป๊ฒŒ ํ•ธ๋“ค๋งํ•˜๊ธฐ๊ฐ€ ์–ด๋ ต๋”๋ผ๊ณ ์š”. ์‹œํ๋ฆฌํ‹ฐ ์ฝ”๋“œ๋ฅผ ๋ณด๋‹ˆ๊นŒ List<RequestMatcherEntry<AuthorizationManager<RequestAuthorizationContext>>> ๊ฐ™์€ ํ˜•ํƒœ๋ฅผ ์“ฐ๊ธด ํ•˜๋˜๋ฐ ํ˜„์žฌ ์ˆ˜์ค€์—์„œ๋Š” Genric Raw Use๋ฅผ ์–ด๋–ป๊ฒŒ ํ”ผํ• ์ง€ ๊ฐ์ด ์ž˜ ์•ˆ ์žกํžˆ๋„ค์š”. ๐Ÿ˜… ํžŒํŠธ ์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค! A. ์ œ๋„ค๋ฆญ ํƒ€์ž…์„ ๋ช…ํ™•ํžˆ ์ง€์ •ํ•˜๋ฉด ๋” ์•ˆ์ „ํ•œ ์ฝ”๋“œ๊ฐ€ ๋  ๊ฒƒ ๊ฐ™์•„์š”! ์•„๋ž˜์™€ ๊ฐ™์ด `...
@@ -0,0 +1,24 @@ +package nextstep.security.authorization; + +import nextstep.security.authentication.Authentication; + +import java.util.Set; + +public class AuthorityAuthorizationManager<T> implements AuthorizationManager<T> { + + private final Set<String> authorities; + + public AuthorityAuthorizationManager(S...
Java
๊ฐ€๋ณ€์ธ์ž(String... authorities)๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด ์—ฌ๋Ÿฌ ๊ถŒํ•œ์„ ๋” ์‰ฝ๊ฒŒ ์ „๋‹ฌํ•  ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™๋„ค์š” ๐Ÿ˜„ `new AuthorityAuthorizationManager("ROLE_ADMIN", "ROLE_USER")`
@@ -5,19 +5,28 @@ import nextstep.security.authentication.AuthenticationException; import nextstep.security.authentication.BasicAuthenticationFilter; import nextstep.security.authentication.UsernamePasswordAuthenticationFilter; -import nextstep.security.authorization.CheckAuthenticationFilter; -import nextstep.secur...
Java
ํ˜„์žฌ๋Š” `@Secured` ๋ฅผ ์‚ฌ์šฉํ•  ๊ฒฝ์šฐ ADMIN ๊ถŒํ•œ ๋ฐ–์— ์ฒดํฌ๊ฐ€ ๋ถˆ๊ฐ€๋Šฅ ํ•˜๊ฒ ๋„ค์š” ๐Ÿค” Spring Security ์—์„œ๋Š” `AuthoritiesAuthorizationManager` ๋ฅผ ์‚ฌ์šฉํ•˜์—ฌ `@Secured("ROLE_ADMIN")`์™€ ๊ฐ™์€ ๊ถŒํ•œ์„ ์ฒดํฌํ•˜๊ณ  ์žˆ๋Š”๋ฐ ์ด๋ถ€๋ถ„์— ๋Œ€ํ•ด ํ•œ๋ฒˆ ํ•™์Šตํ•ด๋ณด๊ณ  ๊ฐœ์„ ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ๐Ÿ˜„
@@ -89,4 +89,28 @@ void request_fail_invalid_password() throws Exception { response.andExpect(status().isUnauthorized()); } + + @DisplayName("์ธ์ฆ๋œ ์‚ฌ์šฉ์ž๋Š” ์ž์‹ ์˜ ์ •๋ณด๋ฅผ ์กฐํšŒํ•  ์ˆ˜ ์žˆ๋‹ค.") + @Test + void request_success_members_me() throws Exception { + String token = Base64.getEncoder().encodeToString((T...
Java
ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ๐Ÿ‘
@@ -0,0 +1,42 @@ +package nextstep.security.authorization; + +import nextstep.security.authentication.Authentication; +import nextstep.security.context.SecurityContextHolder; +import org.aopalliance.aop.Advice; +import org.aopalliance.intercept.MethodInterceptor; +import org.aopalliance.intercept.MethodInvocation; +imp...
Java
> Q.์• ๋…ธํ…Œ์ด์…˜์„ ํ™œ์šฉํ•œ ์ธ๊ฐ€ ์ฒ˜๋ฆฌ๊ฐ€ ์ž˜ ์ดํ•ด๊ฐ€ ๋˜์ง€ ์•Š์•„, SecuredAuthorizationManager๋ฅผ ๋งŒ๋“  ๋’ค AuthorizationManagerBeforeMethodInterceptor์—์„œ ์ด๋ฅผ ๊ฐ€์ ธ๋‹ค ์‚ฌ์šฉํ•˜๋Š” ๋ฐฉํ–ฅ์œผ๋กœ ๊ตฌํ˜„ํ–ˆ๋Š”๋ฐ, ์ด๊ฒŒ ๊ดœ์ฐฎ์€ ๋ฐฉํ–ฅ์ธ์ง€๋Š” ์ž˜ ๋ชจ๋ฅด๊ฒ ๋„ค์š”. ์ด๋ถ€๋ถ„์— ๋Œ€ํ•œ ํ”ผ๋“œ๋ฐฑ์„ ํ•œ๋ฒˆ ๋ฐ›์•„๋ณด๊ณ  ์‹ถ์Šต๋‹ˆ๋‹ค! A. ์ž˜ ๊ตฌํ˜„ํ•ด ์ฃผ์…จ๋„ค์š”! ๐Ÿ‘ AuthorizationManagerBeforeMethodInterceptor ์—์„œ `@Secured`๊ฐ€ ์ ์šฉ๋œ ๋ฉ”์„œ๋“œ๋ฅผ ๊ฐ์ง€ํ•˜๊ณ , AuthorizationManager๋ฅผ ์‹คํ–‰ํ•˜์—ฌ ์‚ฌ์šฉ์ž์˜ ๊ถŒํ•œ์„...
@@ -5,19 +5,28 @@ import nextstep.security.authentication.AuthenticationException; import nextstep.security.authentication.BasicAuthenticationFilter; import nextstep.security.authentication.UsernamePasswordAuthenticationFilter; -import nextstep.security.authorization.CheckAuthenticationFilter; -import nextstep.secur...
Java
์งˆ๋ฌธ ์ฃผ์‹  ๋ถ€๋ถ„์— ๋Œ€ํ•œ ์ €์˜ ์˜๊ฒฌ ์—ฌ๊ธฐ์— ๋‚จ๊ธฐ๊ฒ ์Šต๋‹ˆ๋‹ค. > Q. RequestMatcherRegistry์˜ ์—ญํ• ์ด ํ•„์š”ํ•œ RequestMatcher์„ ๋ชจ๋‘ ๋“ฑ๋กํ•œ ๋’ค HTTP ์š”์ฒญ์ด ๋“ค์–ด์™”์„ ๋•Œ ์ ์ ˆํ•œ RequestMatcher๋ฅผ ์ฐพ์•„์„œ ๋ฐ˜ํ™˜ํ•˜๋Š” ๊ฒƒ์œผ๋กœ ์ดํ•ดํ–ˆ๋Š”๋ฐ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ์ดํ•ดํ•œ๊ฑธ๊นŒ์š”? A.RequestMatcherRegistry๋Š” ๋ณด์•ˆ ๊ทœ์น™์„ ๋“ฑ๋กํ•˜๋Š” ์—ญํ• ์„ ํ•ฉ๋‹ˆ๋‹ค. ์š”์ฒญ์ด ๋“ค์–ด์˜ค๋ฉด Spring Security์˜ AuthorizationFilter๊ฐ€ RequestMatcherDelegatingAuthorizationManager๋ฅผ ํ†ตํ•ด ์ ์ ˆํ•œ Re...
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
์ €๋Š” ๋ฐ˜๋ณต๋ฌธ์—์„œ break ๋ฌธ์„ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ์ง€์–‘ํ•ฉ๋‹ˆ๋‹ค! ํ˜„์žฌ๋Š” ๋งˆ์ง€๋ง‰์— ์žˆ์–ด์„œ ์ฝ๊ธฐ ์‰ฝ์ง€๋งŒ ์ค‘๊ฐ„์— ์žˆ์œผ๋ฉด ์ฝ”๋“œ ๋กœ์ง์„ ์ดํ•ดํ•˜๊ธฐ ํž˜๋“ค๊ธฐ ๋•Œ๋ฌธ์ž…๋‹ˆ๋‹ค! ์—ฌ๊ธฐ์„œ break ๋ณด๋‹ค๋Š” do-while์„ ์‚ฌ์šฉํ•˜๋Š”๊ฒŒ ์–ด๋–จ์ง€ ์กฐ์‹ฌ์Šค๋Ÿฝ๊ฒŒ ์˜๊ฒฌ ๋‚จ๊น๋‹ˆ๋‹ค ๐Ÿ˜Š
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
์ €๋Š” ์ปจํŠธ๋กค๋Ÿฌ์™€ ๋ทฐ์˜ ๊ฐ ์—ญํ• ์ด ์ปจํŠธ๋กค๋Ÿฌ์€ ๋ทฐ์—๊ฒŒ ์ถœ๋ ฅํ•  ์ •๋ณด๋ฅผ ์ œ๊ณตํ•˜๊ณ  ๋ทฐ๋Š” ์ปจํŠธ๋กค๋Ÿฌ์—์„œ ์ œ๊ณต๋ฐ›์€ ์ •๋ณด๋ฅผ ํ†ตํ•ด ์ถœ๋ ฅํ•ด์•ผํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ์ง€๊ธˆ์ฒ˜๋Ÿผ ๋‹จ์ˆœ ํ•˜๋“œ ์ฝ”๋”ฉ์„ ๋ฌธ์ž๋Š” ์ฃผ๋Š” ๊ฒฝ์šฐ์—๋Š” ์ฐจ๋ผ๋ฆฌ view ๋‚ด์—์„œ ์ƒ์ˆ˜ํ™”๋ฅผ ํ•˜์—ฌ ๊ด€๋ฆฌํ•˜๋Š”๊ฒŒ ๋” ์ข‹์•„๋ณด์ด๋Š”๋ฐ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”? ์ด๋ ‡๊ฒŒ ์„ค๊ณ„๋ฅผ ํ•œ ์˜๋„๊ฐ€ ์žˆ์„๊นŒ์š”?
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
break ๋Œ€์‹  returnํ•˜๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ์Šต๋‹ˆ๋‹ค!๐Ÿ˜Š
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
์ด ๋ถ€๋ถ„์€ ๋ฏผ์„ ๋‹˜์˜ ๋ง์”€์ฒ˜๋Ÿผ ์„œ๋น„์Šค๋กœ ๋‚˜๋ˆ„๋Š”๊ฒŒ ์ข‹์•„๋ณด์ž…๋‹ˆ๋‹ค! ์ปจํŠธ๋กค๋Ÿฌ๋Š” ๋ทฐ์™€ ์„œ๋น„์Šค ๋กœ์ง์„ ์ด์–ด์ฃผ๊ณ  ํ๋ฆ„๋งŒ ๋‹ด๋‹นํ•˜๋Š” ์—ญํ• ์„ ๋‹ด๋‹นํ•˜๋Š”๊ฒŒ ์ข‹์•„๋ณด์ž…๋‹ˆ๋‹ค ใ…Žใ…Ž
@@ -0,0 +1,31 @@ +package store.domain.vo; + +public record Name(String value) { + public static final int MAX_LEN = 10; + + public Name(String value) { + validateName(value.trim()); + this.value = value.trim(); + } + + private void validateName(String name) { + if (name == null || name...
Java
vo ๊ฐ์ฒด๋กœ ๊ฐ€๋Šฅํ•œ ๊ฐ’์— ๋Œ€ํ•œ ๊ฒ€์ฆ์„ ๋‚ด๋ถ€์—์„œ ๋‹ด๋‹นํ•˜๋Š” ๋ชจ์Šต์ด ์ •๋ง ์ธ์ƒ ๊นŠ๋„ค์š”! ํ•˜์ง€๋งŒ Quantity์ฒ˜๋Ÿผ ๊ณ„์‚ฐ ๊ณผ์ •์ด ๋ณต์žกํ•ด์งˆ ์ˆ˜ ์žˆ๊ณ  ๊ณ„์‚ฐํ•  ๋•Œ๋งˆ๋‹ค ์ƒˆ๋กœ์šด ๊ฐ์ฒด๊ฐ€ ์ƒ์„ฑ์ด ๋˜์–ด์•ผํ•œ๋‹ค๋Š” ๋‹จ์ ์ด ์กด์žฌํ•˜๋Š”๊ฑฐ๋กœ ๋ณด์ด๋Š”๋ฐ ๋ณธ์ธ๋งŒ์˜ ์ ์šฉ ๊ธฐ์ค€์ด ์žˆ์„๊นŒ์š”?? ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!
@@ -0,0 +1,128 @@ +package store.infrastructure.config; + +import store.controller.StoreController; +import store.repository.inventory.InventoryRepository; +import store.repository.inventory.InventoryRepositoryImpl; +import store.repository.order.OrderRepository; +import store.repository.order.OrderRepositoryImpl; +imp...
Java
์šฐ์™€ ๋‹จ ๊ฐ์ฒด ํ•˜๋‚˜๋งŒ ์ƒ์„ฑ์ด ๋˜๋„๋กํ•˜๊ธฐ ์œ„ํ•ด์„œ ์ด๋ ‡๊ฒŒ ์„ค๊ณ„๋ฅผ ํ•˜์…จ๊ตฐ์š”! ์ „ ํ•ด๊ฒฐํ•˜์ง€ ๋ชปํ–ˆ์—ˆ๋Š”๋ฐ ํ•˜๋‚˜ ๋ฐฐ์›Œ๊ฐ‘๋‹ˆ๋‹ค ๐Ÿ‘
@@ -0,0 +1,128 @@ +package store.infrastructure.config; + +import store.controller.StoreController; +import store.repository.inventory.InventoryRepository; +import store.repository.inventory.InventoryRepositoryImpl; +import store.repository.order.OrderRepository; +import store.repository.order.OrderRepositoryImpl; +imp...
Java
public ๋ฉ”์„œ๋“œ์™€ private ๋ฉ”์„œ๋“œ ์ˆœ์„œ ๋ฐฐ์น˜์˜ ๊ธฐ์ค€์ด ์žˆ์œผ์‹ ๊ฐ€์š”? ์ €ํฌํ•จ ๋‹ค๋ฅธ ๋ถ„๋“ค์€ public์„ ์œ„์—๋‘๊ณ  private์„ ์•„๋ž˜ ๋‘๋Š”๋ฐ ๋ฐ˜๋Œ€์—ฌ์„œ ์ด๋ ‡๊ฒŒ ์„ ํƒํ•˜์‹  ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!
@@ -0,0 +1,6 @@ +package store.infrastructure.constant; + +public class Membership { + public static final int DISCOUNT_RATE = 30; + public static final int MAX = 8_000; +}
Java
๋ฏผ์„ ๋‹˜์˜ ์ƒ์ˆ˜ํ™” ๊ธฐ์ค€์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค! ์–ด๋–ค ๊ฑธ ENUM์œผ๋กœ ๊ณตํ†ต์œผ๋กœ ๋ฌถ๊ณ  ์–ด๋–ค ๊ฑธ ๋‚ด๋ถ€๋กœ ๊ด€๋ฆฌํ•˜์‹œ๋‚˜์š”? ๋˜ํ•œ ์–ด๋–ค๊ฑด ํ•˜๋“œ์ฝ”๋”ฉ๋œ ์ƒํƒœ๋กœ ๊ทธ๋Œ€๋กœ ๋‘์‹œ๋‚˜์š”??
@@ -0,0 +1,54 @@ +package store.domain.vo; + +import store.infrastructure.constant.ExceptionMessage; +import store.infrastructure.exception.CustomException; + +public record Price(int value) implements Comparable<Price> { + public static final int MIN = 10; + public static final int MAX = 1_000_000; + + public...
Java
์ •์  ํŒฉํ† ๋ฆฌ ๋ฉ”์„œ๋“œ ํŒจํ„ด์€ ๋ณดํ†ต ์ƒ์„ฑ์ž๋ฅผ private๋กœ ๋ง‰๊ณ  ๋ฉ”์†Œ๋“œ ๋ช…๊ณผ ํŒŒ๋ผ๋ฏธํ„ฐ๋ฅผ ํ†ตํ•ด ๊ทธ ์˜๋ฏธ๋ฅผ ์ „๋‹ฌํ•˜๋Š” ๊ฒƒ์œผ๋กœ ์•Œ๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค! ์ด๋ ‡๊ฒŒ ์ƒ์„ฑ์ž์™€ ์ •์  ํŒฉํ† ๋ฆฌ ๋ฉ”์„œ๋“œ ํŒจํ„ด์„ ๋‘˜ ๋‹ค ์‚ฌ์šฉํ•˜์‹  ์ด์œ ๊ฐ€ ์žˆ์œผ์‹ค๊นŒ์š”?? ์„ ํƒํ•œ ๊ธฐ์ค€์ด ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
`do-while`์€ ์ƒ๊ฐํ•˜์ง€ ๋ชปํ–ˆ๋Š”๋ฐ, ์ข‹์€ ๋ฐฉ๋ฒ•์ธ ๊ฒƒ ๊ฐ™์•„์š”! ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค
@@ -0,0 +1,31 @@ +package store.domain.vo; + +public record Name(String value) { + public static final int MAX_LEN = 10; + + public Name(String value) { + validateName(value.trim()); + this.value = value.trim(); + } + + private void validateName(String name) { + if (name == null || name...
Java
์šฐ์„  ์ข‹์€ ์งˆ๋ฌธ ๋‚จ๊ฒจ์ฃผ์…”์„œ ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค! ์ €๋„ ์žฌํ˜„๋‹˜์ด ๋ง์”€ํ•ด์ฃผ์‹  ๊ฒƒ์ฒ˜๋Ÿผ `vo ๊ฐ์ฒด`๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด์„œ **๊ฐ์ฒด๋ฅผ ๋งค๋ฒˆ ์ƒˆ๋กœ ์ƒ์„ฑํ•ด์•ผ ํ•œ๋‹ค๋Š” ์ **, **์—ฐ์‚ฐ ๊ณผ์ •์ด ๋ณต์žกํ•ด์งˆ ์ˆ˜ ์žˆ๋‹ค๋Š” ์ **์—์„œ ๊ณ ๋ฏผ์„ ๋งŽ์ด ํ–ˆ์—ˆ๋Š”๋ฐ์š”, ์•„๋ž˜ ๋‘ ํ•ญ๋ชฉ์ด ๊ฐ€์ ธ๋‹ค์ฃผ๋Š” ์ด์ ์ด ๋” ํฌ๋‹ค๊ณ  ์ƒ๊ฐ๋˜๋Š” ๋ถ€๋ถ„์—๋Š” `vo ๊ฐ์ฒด`๋ฅผ ๋„์ž…ํ–ˆ์Šต๋‹ˆ๋‹ค. ``` 1. ๊ฒ€์ฆ ์œ„์น˜๋ฅผ ํ•œ ๊ณณ์œผ๋กœ(๊ฐ์ฒด ๋‚ด๋ถ€๋กœ) ํ†ต์ผ์‹œํ‚ฌ ์ˆ˜ ์žˆ๋‹ค. 2. ๋ถˆ๋ณ€์„ฑ์„ ๋ณด์žฅํ•˜์—ฌ ์•ˆ์ •์ ์œผ๋กœ ๊ฐ’์„ ๊ด€๋ฆฌํ•  ์ˆ˜ ์žˆ๋‹ค. ``` ์˜ˆ๋ฅผ๋“ค์–ด `์ƒํ’ˆ๋ช…`์˜ ๊ฒฝ์šฐ์—๋Š” ์ถœ๋ ฅ ํฌ๋งท์— ์˜ํ–ฅ์„ ์ค„ ์ˆ˜ ์žˆ๊ธฐ ๋•Œ๋ฌธ์—, `์ƒํ’ˆ๋ช… ๊ธธ์ด ์ œํ•œ`์ด ํ•„์š”ํ•˜๋‹ค๊ณ ...
@@ -0,0 +1,54 @@ +package store.domain.vo; + +import store.infrastructure.constant.ExceptionMessage; +import store.infrastructure.exception.CustomException; + +public record Price(int value) implements Comparable<Price> { + public static final int MIN = 10; + public static final int MAX = 1_000_000; + + public...
Java
์ผ๋‹จ `record`์˜ ๊ฒฝ์šฐ `private` ์ƒ์„ฑ์ž๋ฅผ ์„ ์–ธํ•˜๋”๋ผ๋„, ์•„๋ž˜์™€ ๊ฐ™์ด ์ง์ ‘ ์ƒ์„ฑํ•˜๋Š” ๊ฒƒ์„ ๋ง‰์„ ์ˆ˜ ์—†๋‹ค๊ณ  ์•Œ๊ณ ์žˆ์Šต๋‹ˆ๋‹ค! ```java Price price = new Price(1000); ``` ๋ฌด์—‡๋ณด๋‹ค ์ œ๊ฐ€ ์˜๋„ํ–ˆ๋˜ ๊ฒƒ์€ **์ •์ˆ˜ ๊ฐ’ ๋ฟ๋งŒ ์•„๋‹ˆ๋ผ, ์ •์ˆ˜๋ฅผ ๋‹ด๋Š” String ๊ฐ์ฒด๋กœ๋„ `Price ๊ฐ์ฒด`๋ฅผ ์ƒ์„ฑํ•  ์ˆ˜ ์žˆ๋„๋ก ํ•˜๋Š” ๊ฒƒ**์ด์—ˆ์Šต๋‹ˆ๋‹ค. - ์ฆ‰, **int ์ž๋ฃŒํ˜•**์œผ๋กœ๋งŒ `Price ๊ฐ์ฒด`๋ฅผ ์ƒ์„ฑํ•˜๋Š” ๊ฒƒ์ด ์•„๋‹Œ, **String ์ž๋ฃŒํ˜•**์œผ๋กœ๋„ `Price ๊ฐ์ฒด`๋ฅผ ์ƒ์„ฑํ•  ์ˆ˜ ์žˆ๋„๋ก ์˜๋„ํ–ˆ์Šต๋‹ˆ๋‹ค!
@@ -0,0 +1,128 @@ +package store.infrastructure.config; + +import store.controller.StoreController; +import store.repository.inventory.InventoryRepository; +import store.repository.inventory.InventoryRepositoryImpl; +import store.repository.order.OrderRepository; +import store.repository.order.OrderRepositoryImpl; +imp...
Java
์•„ ๋„ค ๋งž์Šต๋‹ˆ๋‹ค! ์ €๋„ ๋ณดํ†ต **์ƒ๋‹จ์— public ๋ฉ”์†Œ๋“œ**๋ฅผ ๋ฐฐ์น˜ํ•˜๊ณ , **ํ˜ธ์ถœ ์ˆœ์„œ์— ๋”ฐ๋ผ์„œ private ๋ฉ”์†Œ๋“œ๋ฅผ ํ•˜๋‹จ**์— ๋ฐฐ์น˜ํ•˜๋Š”๋ฐ์š”, `AppConfig` ํด๋ž˜์Šค์˜ ๊ฒฝ์šฐ์—๋Š” ๋ชฉ์ ์— ๋งž๊ฒŒ ์กฐ๊ธˆ ๋‹ค๋ฅด๊ฒŒ ๋ฐฐ์น˜๋ฅผ ํ–ˆ์Šต๋‹ˆ๋‹ค. `AppConfig` ํด๋ž˜์Šค๋Š” **ํ˜„์žฌ ์š”๊ตฌ์‚ฌํ•ญ์— ๋งž๋Š” ๊ตฌํ˜„์ฒด**์— ๋”ฐ๋ผ์„œ **์˜์กด์„ฑ์„ ๊ด€๋ฆฌ**ํ•˜๋Š” ์—ญํ• ์„ ํ•ฉ๋‹ˆ๋‹ค. - ๊ฐœ์ธ์ ์œผ๋กœ `์˜์กด ๊ด€๊ณ„`๋ณด๋‹ค๋Š” `๊ตฌํ˜„์ฒด`๊ฐ€ ๋ณ€๊ฒฝ๋˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ๋” ๋นˆ๋ฒˆํ•  ๊ฒƒ์ด๋ผ๊ณ  ์ƒ๊ฐํ–ˆ๊ณ , **๊ตฌํ˜„์ฒด๋ฅผ ๋ฐ˜ํ™˜ํ•˜๋Š” ๋ฉ”์†Œ๋“œ๋ฅผ ์ƒ๋‹จ์œผ๋กœ** ์˜ฌ๋ฆฌ๋Š” ๊ฒƒ์ด ๋” ๋ˆˆ์— ๋Œ ๊ฒƒ์ด๋ผ๊ณ  ์ƒ๊ฐํ–ˆ์Šต๋‹ˆ๋‹ค. - ๊ทธ๋ฆฌ๊ณ  ํ˜„์žฌ ์„œ๋น„์Šค์—์„œ๋Š” `์–ด...
@@ -0,0 +1,6 @@ +package store.infrastructure.constant; + +public class Membership { + public static final int DISCOUNT_RATE = 30; + public static final int MAX = 8_000; +}
Java
์ข‹์€ ์งˆ๋ฌธ์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค! ### 1. ์ƒ์ˆ˜ํ™” ์—ฌ๋ถ€ ๊ฒฐ์ • > ์ €๋Š” ์šฐ์„  ๋ช‡ ๊ฐ€์ง€ ๋ถ„๋ฅ˜ ๊ธฐ์ค€์œผ๋กœ **์ƒ์ˆ˜ํ™”๋ฅผ ๊ฒฐ์ •**ํ•ฉ๋‹ˆ๋‹ค. - ์ฒซ ๋ฒˆ์งธ ๋ถ„๋ฅ˜ ๊ธฐ์ค€์€ `์„œ๋น„์Šค ์š”๊ตฌ์‚ฌํ•ญ๊ณผ์˜ ๋ฐ€์ ‘๋„`์ธ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. **์„œ๋น„์Šค ์š”๊ตฌ์‚ฌํ•ญ**์€ ๋ณ€๋™ ๊ฐ€๋Šฅ์„ฑ์ด ํฐ ๋ถ€๋ถ„์ด๋ผ๊ณ  ์ƒ๊ฐํ•ด์„œ, **_์ด์™€ ๋ฐ€์ ‘ํ•˜๊ฒŒ ์—ฐ๊ด€๋œ ๊ฐ’๋“ค์€ ๋”ฐ๋กœ ์ƒ์ˆ˜๋กœ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ_** ์ด ์ข‹๋‹ค๊ณ  ์ƒ๊ฐํ•ด์š”. ๐Ÿ‘‰๐Ÿป ์˜ˆ๋ฅผ๋“ค์–ด `๋ฉค๋ฒ„์‹ญ ํ• ์ธ์œจ`์ด๋‚˜ `์ตœ๋Œ€ ํ• ์ธ ๊ฐ€๋Šฅ ๊ธˆ์•ก`์€ ์„œ๋น„์Šค ์š”๊ตฌ์‚ฌํ•ญ๊ณผ ๋ฐ€์ ‘ํ•œ ์—ฐ๊ด€์ด ์žˆ์œผ๋ฏ€๋กœ ์ƒ์ˆ˜๋กœ ๊ด€๋ฆฌํ•ฉ๋‹ˆ๋‹ค. - ๋‘ ๋ฒˆ์งธ๋Š” `์˜๋ฏธ๊ฐ€ ํ‘œํ˜„๋˜์ง€ ์•Š๋Š” ๊ฐ’`์ž…๋‹ˆ๋‹ค. **์˜๋ฏธ๋ฅผ ํฌํ•จํ•˜์ง€ ์•Š๋Š” ๊ฐ’**...
@@ -0,0 +1,176 @@ +package store.controller; + +import store.infrastructure.constant.Message; +import store.service.OrderParser; +import store.domain.vo.Name; +import store.domain.vo.Order; +import store.domain.vo.Quantity; +import store.service.*; +import store.service.dto.request.ApplyPromotionRequest; +import store....
Java
ํ•ด๋‹น ์ฝ”๋“œ๋ฅผ ์ž‘์„ฑํ•  ๋‹น์‹œ `์˜์ˆ˜์ฆ ์ถœ๋ ฅ์„ ์–ด๋–ป๊ฒŒ ํ‘œํ˜„ํ•  ๊ฒƒ์ธ์ง€`๋ฅผ ์ปจํŠธ๋กค๋Ÿฌ๊ฐ€ ๊ฒฐ์ •ํ•  ์ฑ…์ž„์ด ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ์—ˆ์Šต๋‹ˆ๋‹ค. ๊ทธ๋Ÿฐ๋ฐ ์žฌํ˜„๋‹˜ ์˜๊ฒฌ์„ ํ™•์ธํ•ด๋ณด๋‹ˆ, ์ด ๋ถ€๋ถ„์€ view์—๊ฒŒ ์ฑ…์ž„์„ ์ฃผ๋Š”๊ฒŒ ๋” ์ ํ•ฉํ•˜๊ฒ ๋‹ค๋Š” ์ƒ๊ฐ์ด ๋“œ๋„ค์š”..!
@@ -15,6 +15,7 @@ import Util import RxDataSources import RxCocoa import RxSwift +import StoreKit final class MainViewController: BBNavigationViewController<MainViewReactor>, UICollectionViewDelegateFlowLayout { private let familyViewController: MainFamilyViewController = MainFamilyViewControllerWrapper().ma...
Swift
์ด๊ฑฐ ์žˆ์ž–์•„์š”.. ์ด๊ฑฐ ๋ญ ๊ผญ ํ™ˆ์ด์—ฌ์•ผ ํ• ๊นŒ์š”? ์ด๋Ÿฐ ํŒ์—… ๋„์šฐ๊ณ  ํ•˜๋Š”๊ฒŒ ๊ผญ ํ™ˆ๋งŒ์˜ ์ฑ…์ž„์€ ์•„๋‹ˆ๋ผ ์ƒ๊ฐํ•˜๋Š”๋ฐ ์ด๊ฑฐ ์ตœ์ƒ๋‹จ ๋„ค๋น„๊ฒŒ์ด์…˜ ๋ฐ”์—์„œ ๋„์šฐ๋Š”๊ฑด ์–ด๋•Œ์š”? ์‚ฌ์‹ค ์ด๊ฑฐ๋ง๊ณ ๋„ ๊ทธ๋ƒฅ ํ† ์ŠคํŠธ ๋ฉ”์„ธ์ง€ ์ƒ๊ฐํ•ด๋ด๋„ ๋‹ค์Œ ๋ทฐ๋กœ ๋„˜์–ด๊ฐ€๋”๋ผ๋„ ํ† ์ŠคํŠธ๋ฉ”์„ธ์ง€๋Š” ๋‚จ์•„์žˆ์–ด์•ผํ•˜์ž–์•„์—ฌ...? ๊ทธ๋Ÿฐ๊ฑฐ๋ฅผ ๊ด€๋ฆฌํ•˜๊ธฐ ์œ„ํ•ด ์ตœ์ƒ๋‹จ์„ ํ•˜๋‚˜ ๋” ๋‘๋Š”๊ฒŒ ์–ด๋–จ์ง€
@@ -15,6 +15,7 @@ import Util import RxDataSources import RxCocoa import RxSwift +import StoreKit final class MainViewController: BBNavigationViewController<MainViewReactor>, UICollectionViewDelegateFlowLayout { private let familyViewController: MainFamilyViewController = MainFamilyViewControllerWrapper().ma...
Swift
์ด๊ฒŒ ๋งž๋Š” ๊ฒƒ ๊ฐ™์€๊ฒŒ ์‚ฌ์ง„์ฐ๊ณ  ์„ฑ๊ณตํ•˜๊ณ , ๋„ค๋น„๊ฒŒ์ดํ„ฐ์— ์ „๋‹ฌํ•ด์„œ ๊ฐ€์กฑ ์ƒ์„ฑ์ผ ์ฒดํฌํ•˜๊ณ  ํŒ์—… ๋„์šฐ๋Š”๊ฒŒ ๋งž๋Š”๊ฒƒ ๊ฐ™๋„ค์šฅ..? ์™œ๋ƒ๋ฉด ์ง€๊ธˆ ๋ฏธ์…˜์ฒดํฌํ•˜๋Š”๊ฑฐ์— ๊ทธ๊ฑธ ๋‘์‹ ๊ฒƒ ๊ฐ™์€๋ฐ ๊ทธ๊ฑฐ๋ž‘ ์ƒ์กด์‹ ๊ณ  ํ•œ๋ฒˆํ•˜๊ณ  ๋„์šฐ๋Š”๊ฑฐ๋ž‘์€ ์ฐจ์ด๊ฐ€ ์žˆ์ง€์•Š๋‚˜์š” ๋ฏธ์…˜์€ 4๋ช…๊ฐ€์กฑ์ด๋ฉด ๋‘๋ช…๊นŒ์ง€ ์˜ฌ๋ ค์•ผ ํ™•์ธ์ด๋˜์–ด๊ฐ€์ง€๊ณ  ๊ทธ๋•Œ ๋ฆฌ๋ทฐํŒ์—…์ด ๋œจ๊ฒŒ๋˜๋Š”๊ฑฐ์•„๋‹Œ๊ฐ€์—ฝ?
@@ -15,6 +15,7 @@ import Util import RxDataSources import RxCocoa import RxSwift +import StoreKit final class MainViewController: BBNavigationViewController<MainViewReactor>, UICollectionViewDelegateFlowLayout { private let familyViewController: MainFamilyViewController = MainFamilyViewControllerWrapper().ma...
Swift
> ์ด๊ฑฐ ์žˆ์ž–์•„์š”.. ์ด๊ฑฐ ๋ญ ๊ผญ ํ™ˆ์ด์—ฌ์•ผ ํ• ๊นŒ์š”? ์ด๋Ÿฐ ํŒ์—… ๋„์šฐ๊ณ  ํ•˜๋Š”๊ฒŒ ๊ผญ ํ™ˆ๋งŒ์˜ ์ฑ…์ž„์€ ์•„๋‹ˆ๋ผ ์ƒ๊ฐํ•˜๋Š”๋ฐ ์ด๊ฑฐ ์ตœ์ƒ๋‹จ ๋„ค๋น„๊ฒŒ์ด์…˜ ๋ฐ”์—์„œ ๋„์šฐ๋Š”๊ฑด ์–ด๋•Œ์š”? ์‚ฌ์‹ค ์ด๊ฑฐ๋ง๊ณ ๋„ ๊ทธ๋ƒฅ ํ† ์ŠคํŠธ ๋ฉ”์„ธ์ง€ ์ƒ๊ฐํ•ด๋ด๋„ ๋‹ค์Œ ๋ทฐ๋กœ ๋„˜์–ด๊ฐ€๋”๋ผ๋„ ํ† ์ŠคํŠธ๋ฉ”์„ธ์ง€๋Š” ๋‚จ์•„์žˆ์–ด์•ผํ•˜์ž–์•„์—ฌ...? ๊ทธ๋Ÿฐ๊ฑฐ๋ฅผ ๊ด€๋ฆฌํ•˜๊ธฐ ์œ„ํ•ด ์ตœ์ƒ๋‹จ์„ ํ•˜๋‚˜ ๋” ๋‘๋Š”๊ฒŒ ์–ด๋–จ์ง€ - ์ตœ์ƒ๋‹จ ๋‚ด๋น„๊ฒŒ์ด์…˜ ๋ฐ”์— ๋„์šฐ์ž๋Š” ๊ฒŒ ์–ด๋–ค ๋ง์”€์ด์‹ค ๊นŒ์š”?? ์ตœ์ƒ์œ„ ๋ทฐ์—์„œ ๋„์šฐ์ž๋Š” ๊ฒƒ์ผ๊นŒ์š”??
@@ -15,6 +15,7 @@ import Util import RxDataSources import RxCocoa import RxSwift +import StoreKit final class MainViewController: BBNavigationViewController<MainViewReactor>, UICollectionViewDelegateFlowLayout { private let familyViewController: MainFamilyViewController = MainFamilyViewControllerWrapper().ma...
Swift
> ์ด๊ฒŒ ๋งž๋Š” ๊ฒƒ ๊ฐ™์€๊ฒŒ ์‚ฌ์ง„์ฐ๊ณ  ์„ฑ๊ณตํ•˜๊ณ , ๋„ค๋น„๊ฒŒ์ดํ„ฐ์— ์ „๋‹ฌํ•ด์„œ ๊ฐ€์กฑ ์ƒ์„ฑ์ผ ์ฒดํฌํ•˜๊ณ  ํŒ์—… ๋„์šฐ๋Š”๊ฒŒ ๋งž๋Š”๊ฒƒ ๊ฐ™๋„ค์šฅ..? > > ์™œ๋ƒ๋ฉด ์ง€๊ธˆ ๋ฏธ์…˜์ฒดํฌํ•˜๋Š”๊ฑฐ์— ๊ทธ๊ฑธ ๋‘์‹ ๊ฒƒ ๊ฐ™์€๋ฐ ๊ทธ๊ฑฐ๋ž‘ ์ƒ์กด์‹ ๊ณ  ํ•œ๋ฒˆํ•˜๊ณ  ๋„์šฐ๋Š”๊ฑฐ๋ž‘์€ ์ฐจ์ด๊ฐ€ ์žˆ์ง€์•Š๋‚˜์š” > > ๋ฏธ์…˜์€ 4๋ช…๊ฐ€์กฑ์ด๋ฉด ๋‘๋ช…๊นŒ์ง€ ์˜ฌ๋ ค์•ผ ํ™•์ธ์ด๋˜์–ด๊ฐ€์ง€๊ณ  ๊ทธ๋•Œ ๋ฆฌ๋ทฐํŒ์—…์ด ๋œจ๊ฒŒ๋˜๋Š”๊ฑฐ์•„๋‹Œ๊ฐ€์—ฝ? ์˜ค์˜น ๋งž๋„ค์šฉ (best practice!!) ๊ทธ๋Ÿผ ์นด๋ฉ”๋ผ ์‚ฌ์ง„ ์ฐ๊ณ  ๋‚˜์„œ UseCase๋กœ ๊ฐ€์กฑ ์ƒ์„ฑ์ผ ์ฒดํฌํ•˜๊ณ  ํŒ์—… ๋„์šฐ๋Š” ํ˜•์‹์œผ๋กœ ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.
@@ -50,11 +50,11 @@ public List<ChatRoomDetailResponseDTO> getChatRoomList(Member member) { .filter(chatRoom -> { Chat chat = getLatestChatByChatRoom(chatRoom); chatRoomLastChatMap.put(chatRoom, chat); - if (chat == null) { + if (Objects.isNul...
Java
Objects.isNull() ์‚ฌ์šฉํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค
@@ -55,27 +55,27 @@ private void checkMemberMisMatch(Member member, ChatRoom chatRoom) { // ChatRoom์˜ MemberA๊ฐ€ null(ํƒˆํ‡ด ํšŒ์›)์ด๊ณ , ํ˜„์žฌ ์š”์ฒญ Member๊ฐ€ ChatRoom์˜ MemberB์™€ ๋‹ค๋ฅธ ๊ฒฝ์šฐ if (Objects.isNull(chatRoom.getMemberA()) && !member.getId().equals(chatRoom.getMemberB().getId())) { - throw new...
Java
์• ๋Ÿฌ ๋ฉ”์‹œ์ง€๋ฅผ ๋‚˜๋ˆ„์—ˆ์Šต๋‹ˆ๋‹ค
@@ -50,11 +50,11 @@ public List<ChatRoomDetailResponseDTO> getChatRoomList(Member member) { .filter(chatRoom -> { Chat chat = getLatestChatByChatRoom(chatRoom); chatRoomLastChatMap.put(chatRoom, chat); - if (chat == null) { + if (Objects.isNul...
Java
์ƒ๋Œ€ ์‚ฌ์šฉ์ž๊ฐ€ ํƒˆํ‡ดํ•œ ๊ฒฝ์šฐ ์ปจ๋ฒ„ํ„ฐ๋กœ ๋„˜๊ธฐ๋Š” ํŒŒ๋ผ๋ฏธํ„ฐ๋ฅผ ์ค„์˜€๊ณ , ์ƒ๋Œ€ ์‚ฌ์šฉ์ž๊ฐ€ ์กด์žฌํ•˜๋Š” ๊ฒฝ์šฐ ์•„๋ž˜ ์‚ผํ•ญ ์—ฐ์‚ฐ์ž ๋กœ์ง์„ ์ปจ๋ฒ„ํ„ฐ๋กœ ์˜ฎ๊ธฐ๋ฉด์„œ ์ปจ๋ฒ„ํ„ฐ์—์„œ ์‚ผํ•ญ์—ฐ์‚ฐ์ž๋ฅผ ํ•œ ๋ฒˆ๋งŒ ์‚ฌ์šฉํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,56 @@ +package store.config; + +import java.util.Map; +import store.controller.ConvenienceController; +import store.convenience.Convenience; +import store.domain.Product; +import store.domain.Promotion; +import store.reader.StoreFileReader; +import store.repository.ProductRepository; +import store.repository...
Java
์ €๋„ 2์ฃผ์ฐจ์— Factory๋ฅผ ์‚ฌ์šฉํ–ˆ์—ˆ๋Š”๋ฐ ํ™•์‹คํžˆ ์˜์กด์„ฑ ์ฃผ์ž…ํ•˜๊ธฐ์—๋Š” ์ด๊ฒƒ๋งŒํผ ์ข‹์€๊ฒŒ ์—†๋Š” ๊ฒƒ ๊ฐ™์•„์š”
@@ -0,0 +1,56 @@ +package store.config; + +import java.util.Map; +import store.controller.ConvenienceController; +import store.convenience.Convenience; +import store.domain.Product; +import store.domain.Promotion; +import store.reader.StoreFileReader; +import store.repository.ProductRepository; +import store.repository...
Java
IO์ž‘์—…์˜ ๊ฒฝ์šฐ ์—ฌ๋Ÿฌ ๊ฐœ์˜ ์ธ์Šคํ„ด์Šค๊ฐ€ ํ•œ๋ฒˆ์— ์ ‘๊ทผํ•œ๋‹ค๋ฉด ๋ฌธ์ œ๊ฐ€ ์ƒ๊ธธ์ˆ˜ ์žˆ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค. getInstance๋ฉ”์„œ๋“œ๋ฅผ ํ†ตํ•ด ์‹ฑ๊ธ€ํ†ค ์œ ์ง€ํ•ด๋ณด๋Š”๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?
@@ -0,0 +1,56 @@ +package store.config; + +import java.util.Map; +import store.controller.ConvenienceController; +import store.convenience.Convenience; +import store.domain.Product; +import store.domain.Promotion; +import store.reader.StoreFileReader; +import store.repository.ProductRepository; +import store.repository...
Java
Factory์˜ ์žฅ์ ์€ ์˜์กด์„ฑ ์ฃผ์ž…์ด๋ผ๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค. ์ธํ„ฐํŽ˜์ด์Šค๋ฅผ ํ†ตํ•ด ํด๋ž˜์Šค๊ฐ„ ๊ฒฐํ•ฉ๋„๋ฅผ ์ค„์—ฌ๋ณด๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?
@@ -0,0 +1,56 @@ +package store.config; + +import java.util.Map; +import store.controller.ConvenienceController; +import store.convenience.Convenience; +import store.domain.Product; +import store.domain.Promotion; +import store.reader.StoreFileReader; +import store.repository.ProductRepository; +import store.repository...
Java
staitc ๋ฉ”์„œ๋“œ๋ฅผ ํ†ตํ•ด ์ธ์Šคํ„ด์Šค๋ฅผ ์ƒ์„ฑํ•˜์ง€ ์•Š๋Š” ํ˜•ํƒœ๋กœ ๋งŒ๋“œ์…จ๋Š”๋ฐ private์ƒ์„ฑ์ž๋ฅผ ํ†ตํ•ด ๊ธฐ๋ณธ ์ƒ์„ฑ์ž๋ฅผ ์ƒ์„ฑํ•˜๋Š” ๊ฒƒ์„ ๋ง‰๋Š”๋‹ค๋ฉด ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,19 @@ +package store.config; + +public enum ErrorMessage { + + PRODUCT_NOT_EXIST("์กด์žฌํ•˜์ง€ ์•Š๋Š” ์ƒํ’ˆ์ž…๋‹ˆ๋‹ค. ๋‹ค์‹œ ์ž…๋ ฅํ•ด ์ฃผ์„ธ์š”."), + PRODUCT_QUANTITY_NOT_ENOUGH("์žฌ๊ณ  ์ˆ˜๋Ÿ‰์„ ์ดˆ๊ณผํ•˜์—ฌ ๊ตฌ๋งคํ•  ์ˆ˜ ์—†์Šต๋‹ˆ๋‹ค. ๋‹ค์‹œ ์ž…๋ ฅํ•ด ์ฃผ์„ธ์š”."), + PRODUCT_WRONG_INPUT("์˜ฌ๋ฐ”๋ฅด์ง€ ์•Š์€ ํ˜•์‹์œผ๋กœ ์ž…๋ ฅํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค์‹œ ์ž…๋ ฅํ•ด ์ฃผ์„ธ์š”."), + WRONG_INPUT("์ž˜๋ชป๋œ ์ž…๋ ฅ์ž…๋‹ˆ๋‹ค. ๋‹ค์‹œ ์ž…๋ ฅํ•ด ์ฃผ์„ธ์š”."); + + private ...
Java
"[ERROR] "๋ผ๋Š” ๊ฒƒ์„ ํ•„๋“œ์— ๋„ฃ์–ด ์ƒ์ˆ˜๋กœ ๋งŒ๋“ ๋‹ค๋ฉด ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ``` private static final String ERROR_PREFIX = "[ERROR] "; ```
@@ -0,0 +1,35 @@ +package store.controller; + +import java.util.List; +import java.util.Map; +import store.domain.Product; +import store.domain.Promotion; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +import store.domain.request.PurchaseRequest; +import store.service.ConvenienceService; + +publi...
Java
์Šคํ”„๋ง์—์„œ ์‚ฌ์šฉํ•˜๋Š” Controller, Service, Repository๋ฅผ ์‚ฌ์šฉํ•˜๋ฉด์„œ ๊ฐ๊ฐ์˜ ์ž…๋ ฅ์ด ๋”ฐ๋กœ ๋“ค์–ด์˜ค๋Š” ๊ฒƒ์ฒ˜๋Ÿผ ์ž‘์„ฑํ•˜์‹ ๊ฒŒ ๋˜๊ฒŒ ์‹ ์„ ํ•˜๊ฒŒ ๋А๊ปด์ง€๋„ค์š” ํ•˜์ง€๋งŒ ์ปจํŠธ๋กค๋Ÿฌ๋Š” ์ž…๋ ฅ์„ ๋ฐ›์•„ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๋ฅผ ํ•˜๋Š” ์—ญํ• ๋„ ์žˆ๋Š”๋ฐ ๊ทธ ์—ญํ• ์ด Convenience๋กœ ๋„˜์–ด๊ฐ„๊ฒŒ ์•„์‰ฌ์›€์ด ์žˆ์Šต๋‹ˆ๋‹ค. Supplier๋ฅผ ํ™œ์šฉํ•˜์—ฌ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ ์‹คํŒจ์‹œ ์žฌ์ž…๋ ฅ์„ ๋ฐ›๋„๋ก ์œ ๋„ํ•˜๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?
@@ -0,0 +1,35 @@ +package store.controller; + +import java.util.List; +import java.util.Map; +import store.domain.Product; +import store.domain.Promotion; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +import store.domain.request.PurchaseRequest; +import store.service.ConvenienceService; + +publi...
Java
์ปจํŠธ๋กค๋Ÿฌ์˜ ์—ญํ• ์ด ๋„ˆ๋ฌด ์—†์–ด์„œ ์•„์‰ฌ์›€์— ๋‚จ๊ฒจ๋ด์š”. ์ปจํŠธ๋กค๋Ÿฌ์—์„œ ์–ด๋–ค ์ฒ˜๋ฆฌ๋„ ํ•˜์ง€ ์•Š์€์ฑ„ ์„œ๋น„์Šค์˜ ๋ฉ”์„œ๋“œ๋ฅผ ํ˜ธ์ถœํ•ด์„œ ๊ทธ๋ ‡์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,72 @@ +package store.convenience; + +import static store.domain.Agree.YES; + +import java.util.List; +import java.util.Map; +import java.util.function.Supplier; +import store.controller.ConvenienceController; +import store.domain.Product; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +...
Java
์‹ค์ œ ์„œ๋ฒ„์—์„œ ์šด์˜๋˜๋“ฏ์ด Controller, Service, Repository๋ฅผ ์ž‘์„ฑํ•˜๊ณ  ์‹ค์งˆ์ ์ธ ํ๋ฆ„์„ Convenience๋กœ ๊ด€๋ฆฌํ•˜๋Š” ๊ฒƒ์ด ์–ด์ฉŒ๋ฉด ์ด ๋ถ€๋ถ„์ด ํ”„๋ก ํŠธ๊ณ  ๋‚˜๋จธ์ง€๊ฐ€ ๋ฐฑ์—”๋“œ๊ฐ™์•„ ๊ต‰์žฅํžˆ ํฅ๋ฏธ๋กœ์› ์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,72 @@ +package store.convenience; + +import static store.domain.Agree.YES; + +import java.util.List; +import java.util.Map; +import java.util.function.Supplier; +import store.controller.ConvenienceController; +import store.domain.Product; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +...
Java
Supplier๋ฅผ ์ž‘์„ฑํ•˜์‹  ๋ถ„๋“ค์ค‘์— ๊ฐ€์žฅ ์ž์—ฐ์Šค๋Ÿฝ๊ฒŒ ์‚ฌ์šฉํ•˜์‹  ์˜ˆ์‹œ์ธ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๊ต‰์žฅํžˆ ์žฌ๋ฏธ์žˆ๋„ค์š”
@@ -0,0 +1,72 @@ +package store.convenience; + +import static store.domain.Agree.YES; + +import java.util.List; +import java.util.Map; +import java.util.function.Supplier; +import store.controller.ConvenienceController; +import store.domain.Product; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +...
Java
N์ด๋‚˜ Y์ธ ๋ฌธ์ž์—ด๋ณด๋‹ค boolean์„ ์‚ฌ์šฉํ–ˆ์œผ๋ฉด ์–ด๋–จ๊นŒ๋ผ๋Š” ์ƒ๊ฐ์ด ๋“ค์–ด์š”
@@ -0,0 +1,72 @@ +package store.convenience; + +import static store.domain.Agree.YES; + +import java.util.List; +import java.util.Map; +import java.util.function.Supplier; +import store.controller.ConvenienceController; +import store.domain.Product; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +...
Java
enum์œผ๋กœ Agree๋ฅผ ๋งŒ๋“œ์…จ๋Š”๋ฐ ํ•ด๋‹น ํด๋ž˜์Šค๋ฅผ ํ†ตํ•ด ๊ตฌ๋ณ„ํ•˜๊ฑฐ๋‚˜ "Y"๊ฐ™์€ ๊ฐ’์„ enum์—์„œ ๊ฐ€์ ธ์™€ ์ƒ์ˆ˜์ฒ˜๋Ÿผ ์ฒ˜๋ฆฌํ•˜๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”? Agree์—์„œ ๋”ฐ๋กœ ๋ฉ”์„œ๋“œ๋ฅผ ๋งŒ๋“œ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,74 @@ +package store.domain; + +public class Product { + private final String name; + private final int price; + private int quantity; + private int promotionQuantity; + private Promotion promotion; + + public Product(String name, int price, int promotionQuantity, Promotion promotion) { + ...
Java
์ €์™€ ๊ฐ€์žฅ ๋น„์Šทํ•˜๊ฒŒ Product์˜ ํ•„๋“œ๊ฐ€ ๊ตฌ์„ฑ๋œ ์‚ฌ๋žŒ์„ ๋ด์„œ ์‹ ๊ธฐํ•˜๋„ค์š”. name๊ณผ price๋Š” ๋ณ€๊ฒฝ๋˜์ง€ ์•Š์•„ final๋กœ ์ ์œผ์‹ ๊ฒŒ ๊ผผ๊ผผํ•จ์ด ๋ณด์ž…๋‹ˆ๋‹ค.
@@ -0,0 +1,46 @@ +package store.domain; + +import java.time.LocalDate; + +public class Promotion { + private final String name; + private final int buy; + private final int get; + private final LocalDate startDate; + private final LocalDate endDate; + + public Promotion(String name, int buy, int get, ...
Java
์ด๊ฑด ๋””๋ฒ„๊น…์„ ์œ„ํ•ด ๋„ฃ์€ ๊ฒƒ์ผ๊นŒ์š”?
@@ -0,0 +1,46 @@ +package store.domain; + +import java.time.LocalDate; + +public class Promotion { + private final String name; + private final int buy; + private final int get; + private final LocalDate startDate; + private final LocalDate endDate; + + public Promotion(String name, int buy, int get, ...
Java
์ €๋„ Buy์™€ Get์„ ๋”ฐ๋กœ ๋งŒ๋“ค์—ˆ์—ˆ์ง€๋งŒ ์š”๊ตฌ์‚ฌํ•ญ์— N+1์ด๋ผ๋Š” ๊ธ€์„ ๋ด์„œ get์€ ํ•ญ์ƒ 1์ด๊ฒ ๊ตฌ๋‚˜ ์ƒ๊ฐํ•˜๊ณ  ๋‚˜์ค‘์— ์—ฐ์‚ฐ์— ํฐ ๋„์›€์ด ๋˜์ง€์•Š์•˜๋˜๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค
@@ -0,0 +1,46 @@ +package store.domain; + +import java.time.LocalDate; + +public class Promotion { + private final String name; + private final int buy; + private final int get; + private final LocalDate startDate; + private final LocalDate endDate; + + public Promotion(String name, int buy, int get, ...
Java
์‹œ์ž‘๋‚ ์งœ ์ด์ƒ ๋๋‚œ ๋‚ ์งœ์ดํ•˜ ์ฆ‰ ์‹œ์ž‘๊ณผ ๋์„ ํฌํ•จํ•˜๋Š” ๊ฒƒ์œผ๋กœ ์š”๊ตฌ์‚ฌํ•ญ์„ ์•Œ๊ณ  ์žˆ๋Š”๋ฐ isAfter๊ณผ isBefore์€ ๋™์ผํ•œ ๋‚ ์งœ๋ฅผ ๋งŒ๋‚˜๋ฉด false๋กœ ๋‚˜์˜จ๋‹ค๊ณ  ์•Œ๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,32 @@ +package store.domain.request; + +public class PurchaseRequest { + private final String name; + private int quantity; + + + public PurchaseRequest(String name, int quantity) { + this.name = name; + this.quantity = quantity; + } + + public String getName() { + return ...
Java
request์˜ ๊ฒฝ์šฐ view์˜ ํŒจํ‚ค์ง€์•ˆ์— ์กด์žฌํ•ด์•ผํ•œ๋‹ค๊ณ  ์ƒ๊ฐํ•ฉ๋‹ˆ๋‹ค. Domain์€ ๋ฐ์ดํ„ฐ๋ฅผ ์ €์žฅํ•˜๋Š” ์ €์žฅ์†Œ์ธ๋ฐ domain๊ณผ dto์ค‘์— dto์— ๋” ๊ฐ€๊นŒ์šด ํด๋ž˜์Šค์ธ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -15,29 +15,35 @@ public class StoreFileReader { public static final String PRODUCTS_DATA = "src/main/resources/products.md"; public static final String PROMOTIONS_DATA = "src/main/resources/promotions.md"; - public Map<String, Product> product(Map<String, Promotion> promotions) { - Map<String, ...
Java
์—๋Ÿฌ ๋ฉ”์„ธ์ง€๋ฅผ ์ƒ์ˆ˜ํ™” ์‹œํ‚ค๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”? ์•„๋‹ˆ๋ฉด ์ปค์Šคํ…€ ์˜ˆ์™ธ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -15,29 +15,35 @@ public class StoreFileReader { public static final String PRODUCTS_DATA = "src/main/resources/products.md"; public static final String PROMOTIONS_DATA = "src/main/resources/promotions.md"; - public Map<String, Product> product(Map<String, Promotion> promotions) { - Map<String, ...
Java
,์˜ ๊ฒฝ์šฐ ๊ตฌ๋ถ„์ž๋ฅผ ์ƒ์ˆ˜๋กœ ๊ทธ๋ฆฌ๊ณ  product[0]์˜ ๊ฒฝ์šฐ์—๋Š” ๋‹ค๋ฅธ ์ฝ”๋“œ๋ฅผ ๋ณด๋ฉด product[NAME_IDX]๋ผ๊ณ  ๋ช…๋ช…ํ•˜์—ฌ ๊ฐ€๋…์„ฑ์„ ๋†’์ด๊ธฐ๋„ ํ•˜๋Š”๋ฐ ์ด๋Ÿฐ ๊ฒƒ๋„ ์žˆ์œผ๋‹ˆ ์ฐธ๊ณ ํ•˜์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -15,29 +15,35 @@ public class StoreFileReader { public static final String PRODUCTS_DATA = "src/main/resources/products.md"; public static final String PROMOTIONS_DATA = "src/main/resources/promotions.md"; - public Map<String, Product> product(Map<String, Promotion> promotions) { - Map<String, ...
Java
null๋„ ์ƒ์ˆ˜ํ™” ์‹œํ‚ค๋ฉด ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -15,29 +15,35 @@ public class StoreFileReader { public static final String PRODUCTS_DATA = "src/main/resources/products.md"; public static final String PROMOTIONS_DATA = "src/main/resources/promotions.md"; - public Map<String, Product> product(Map<String, Promotion> promotions) { - Map<String, ...
Java
- ์ธ๋ฑ์Šค ๋ฒˆํ˜ธ์˜ ์ƒ์ˆ˜ํ™”๊ฐ€ ์ด๋ฃจ์–ด์ง€๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. - null๊ณผ ๊ฐ™์€ ๊ฒƒ๋“ค์„ EMPTY์™€ ๊ฐ™์ด ์˜๋ฏธ๊ฐ€ ์žˆ๋„๋ก ์ƒ์ˆ˜ํ™”๋ฅผ ์ง„ํ–‰ํ•˜๋ฉด ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. - Map์œผ๋กœ ๋„ฃ๋Š” ๊ณผ์ •์€ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง์ด๋‚˜ ๋ฐ์ดํ„ฐ ์ €์žฅ ๋กœ์ง์„ ๊ฑด๋“œ๋Š” ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. List๋ฅผ ํ†ตํ•ด request ๋ฐ์ดํ„ฐ ํ˜•์‹์œผ๋กœ ๋งŒ๋“  ํ›„ ๋น„์ฆˆ๋‹ˆ์Šค ๋กœ์ง์„ ๋‹ด๋‹นํ•˜๋Š” service๋‚˜ ๋ฐ์ดํ„ฐ๋ฅผ ์ง์ ‘ ๊ฑด๋“œ๋Š” repository์—์„œ ์ฒ˜๋ฆฌํ•˜๋Š” ๊ฒƒ์ด ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,11 @@ +package store.repository; + +import java.util.Map; +import store.domain.Product; + +public record ProductRepository(Map<String, Product> products) { + + public Product findProduct(String name) { + return products.get(name); + } +}
Java
StoreFileReader์—์„œ ๋จผ์ € ๋งŒ๋“  Map์„ ์—ฌ๊ธฐ์„œ ๋งŒ๋“ค์—ˆ์œผ๋ฉด ์ข‹๊ฒ ์Šต๋‹ˆ๋‹ค. ์ €ํฌ๊ฐ€ Controller๋‚˜ Service์—์„œ ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค์˜ ์ €์žฅ ๋ฐฉ์‹์„ ๊ฑด๋“ค์ง€ ์•Š๋Š” ์ด์œ ์™€ ๊ฐ™์€ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,52 @@ +package store.service; + +import java.util.List; +import java.util.Map; +import store.domain.Product; +import store.domain.Promotion; +import store.domain.Purchase; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +import store.domain.request.PurchaseRequest; + +public class Conven...
Java
๋ฉ”์„œ๋“œ๋ฅผ ๋”ฐ๋กœ ๋ฝ‘์•„๋‚ด๋ฉด ๋” ์ข‹์„๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,52 @@ +package store.service; + +import java.util.List; +import java.util.Map; +import store.domain.Product; +import store.domain.Promotion; +import store.domain.Purchase; +import store.domain.Receipt; +import store.domain.ShortageQuantity; +import store.domain.request.PurchaseRequest; + +public class Conven...
Java
ํ•ด๋‹น ์ œํ’ˆ์ด ์—†๋Š” ๊ฒฝ์šฐ filter๋กœ ์ฒ˜๋ฆฌํ•˜์˜€๋Š”๋ฐ ๊ธฐ์กด์— ์กด์žฌํ•˜์ง€ ์•Š์€ ์ œํ’ˆ์˜ ๊ฒฝ์šฐ ์—๋Ÿฌ๋Š” ๋ฌด์‹œํ•˜๊ณ  ๋„˜์–ด๊ฐ€๋Š” ๊ฒƒ์ผ๊นŒ์š”?