patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -98,7 +98,7 @@ public class CodeFirstSpringmvc extends CodeFirstSpringmvcBase {
@RequestMapping(path = "/uploadWithoutAnnotation", method = RequestMethod.POST, produces = MediaType.TEXT_PLAIN_VALUE, consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
public String fileUploadWithoutAnnotation(MultipartFile file1,... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 10,381 | Do we have test cases that name is null? | apache-servicecomb-java-chassis | java |
@@ -109,8 +109,16 @@ type SumIntAgg struct {
func (a *SumIntAgg) DoInt(vs *array.Int64) {
// https://issues.apache.org/jira/browse/ARROW-4081
- if vs.Len() > 0 {
- a.sum += math.Int64.Sum(vs)
+ if l := vs.Len() - vs.NullN(); l > 0 {
+ if vs.NullN() == 0 {
+ a.sum += math.Int64.Sum(vs)
+ } else {
+ for i := ... | 1 | package transformations
import (
"fmt"
"github.com/apache/arrow/go/arrow/array"
"github.com/apache/arrow/go/arrow/math"
"github.com/influxdata/flux"
"github.com/influxdata/flux/execute"
"github.com/influxdata/flux/plan"
)
const SumKind = "sum"
type SumOpSpec struct {
execute.AggregateConfig
}
func init() {
... | 1 | 9,469 | in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely. | influxdata-flux | go |
@@ -47,7 +47,7 @@ public class WebUtils {
try {
azkabanEventReporter = ServiceProvider.SERVICE_PROVIDER
.getInstance(AzkabanEventReporter.class);
- } catch (NullPointerException | ConfigurationException e) {
+ } catch (Exception e) {
Logger.getLogger(WebUtils.class.getName()).warn("A... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 19,982 | We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null. | azkaban-azkaban | java |
@@ -112,7 +112,12 @@ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context,
// The values only have the same type when `null`.
outer: if (oldDom==null || oldDom.parentNode!==parentDom) {
- parentDom.appendChild(newDom);
+ // Skip appendind if the last element is the sam... | 1 | import { diff, unmount, applyRef } from './index';
import { coerceToVNode } from '../create-element';
import { EMPTY_OBJ, EMPTY_ARR } from '../constants';
import { removeNode } from '../util';
import { getDomSibling } from '../component';
/**
* Diff the children of a virtual node
* @param {import('../internal').Prea... | 1 | 14,024 | Can't we add the check here? | preactjs-preact | js |
@@ -380,8 +380,15 @@ class RemoteConnection(object):
# Authorization header
headers["Authorization"] = "Basic %s" % auth
- self._conn.request(method, parsed_url.path, data, headers)
- resp = self._conn.getresponse()
+ if body and method != 'POST' and method != 'PUT':
+ ... | 1 | # Copyright 2008-2009 WebDriver committers
# Copyright 2008-2009 Google Inc.
# Copyright 2013 BrowserStack
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licens... | 1 | 10,707 | body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests | SeleniumHQ-selenium | js |
@@ -40,6 +40,8 @@ type GenericDeploymentSpec struct {
// The maximum length of time to execute deployment before giving up.
// Default is 6h.
Timeout Duration `json:"timeout,omitempty" default:"6h"`
+ // List of encrypted secrets and targets that should be decoded before using.
+ Encryption *SecretEncryption `jso... | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 17,285 | Tell me if you have a better field name for this. | pipe-cd-pipe | go |
@@ -1084,8 +1084,8 @@ partial class Build
"Samples.AspNetCoreMvc30" => Framework == TargetFramework.NETCOREAPP3_0,
"Samples.AspNetCoreMvc31" => Framework == TargetFramework.NETCOREAPP3_1,
"Samples.AspNetCore2" => Framework == TargetFramework.NET... | 1 | using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Net;
using System.Runtime.InteropServices;
using System.Text.Json;
using System.Text.RegularExpressions;
using Nuke.Common;
using Nuke.Common.IO;
using Nuke.Common.ProjectModel;
using Nuke.Common.T... | 1 | 22,663 | FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority | DataDog-dd-trace-dotnet | .cs |
@@ -364,16 +364,11 @@ void getNbrAtomAndBondIds(unsigned int aid, const RDKit::ROMol *mol,
unsigned int na = mol->getNumAtoms();
URANGE_CHECK(aid, na);
- RDKit::ROMol::ADJ_ITER nbrIdx, endNbrs;
- boost::tie(nbrIdx, endNbrs) = mol->getAtomNeighbors(mol->getAtomWithIdx(aid));
-
- unsigned int ai, bi;
- while ... | 1 | // $Id$
//
// Copyright (C) 2003-2010 greg Landrum and Rational Discovery LLC
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#include <RD... | 1 | 23,618 | This is just `mol->atomNeightors()`, is it? | rdkit-rdkit | cpp |
@@ -40,10 +40,11 @@ using daal_kmeans_lloyd_dense_ucapi_kernel_t =
daal_kmeans::internal::KMeansDenseLloydBatchKernelUCAPI<Float>;
template <typename Float>
-struct infer_kernel_gpu<Float, method::by_default> {
- infer_result operator()(const dal::backend::context_gpu& ctx,
- const... | 1 | /*******************************************************************************
* Copyright 2020 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.o... | 1 | 24,491 | This alias is just for a single occurrence. Maybe it ins't necessary? | oneapi-src-oneDAL | cpp |
@@ -1198,7 +1198,7 @@ class CppGenerator : public BaseGenerator {
code_ += " }";
}
}
- code_ += " default: return false;";
+ code_ += " default: return true;";
code_ += " }";
code_ += "}";
code_ += ""; | 1 | /*
* Copyright 2014 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applica... | 1 | 14,546 | You can delete this `NONE` case. | google-flatbuffers | java |
@@ -5420,8 +5420,8 @@ TEST_F(VkLayerTest, RenderPassCreateAttachmentReadOnlyButCleared) {
}
}
-TEST_F(VkLayerTest, RenderPassCreateAttachmentUsedTwiceColor) {
- TEST_DESCRIPTION("Attachment is used simultaneously as two color attachments. This is usually unintended.");
+TEST_F(VkLayerTest, RenderPassCreateAt... | 1 | /*
* Copyright (c) 2015-2019 The Khronos Group Inc.
* Copyright (c) 2015-2019 Valve Corporation
* Copyright (c) 2015-2019 LunarG, Inc.
* Copyright (c) 2015-2019 Google, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* Y... | 1 | 9,775 | @cnorthrop -- here is a test with a name change. Is this going to affect your internal CI? | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
private ChromeDriverCommand() {}
static final String LAUNCH_APP = "launchApp";
+ static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
+ = "sendCommandForDownloadChromeHeadLess";
+
} | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 15,148 | Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way. | SeleniumHQ-selenium | rb |
@@ -122,6 +122,10 @@ class core(task.Config):
parallel_scheduling = parameter.BoolParameter(
default=False,
description='Use multiprocessing to do scheduling in parallel.')
+ parallel_scheduling_processes = parameter.IntParameter(
+ default=None,
+ description='The number of proc... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 17,320 | I think this will cause a warning, can you set the default to zero (`0`)? | spotify-luigi | py |
@@ -2,7 +2,7 @@ package client_connection
import (
"errors"
- "github.com/mysterium/node/service_discovery/dto"
+ id "github.com/mysterium/node/identity"
)
type State string | 1 | package client_connection
import (
"errors"
"github.com/mysterium/node/service_discovery/dto"
)
type State string
const (
NOT_CONNECTED = State("NOT_CONNECTED")
NEGOTIATING = State("NEGOTIATING")
CONNECTED = State("CONNECTED")
)
var (
ALREADY_CONNECTED = errors.New("already connected")
)
type Connectio... | 1 | 9,730 | confusing naming. Identity from "id" package :/ why we need alias here? (and in other imports) | mysteriumnetwork-node | go |
@@ -355,9 +355,11 @@ def data(readonly=False):
"Hide the window decoration when using wayland "
"(requires restart)"),
- ('show-keyhints',
- SettingValue(typ.Bool(), 'true'),
- "Show possible keychains based on the current keystring"),
+ ('keyh... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 14,806 | It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work. | qutebrowser-qutebrowser | py |
@@ -150,7 +150,7 @@ module.exports = {
TestCase.assertEqual(obj.arrayCol1[-1], undefined);
TestCase.assertEqual(obj.arrayCol1['foo'], undefined);
- for (let field of Object.keys(prim)) {
+ for (let field of Object.keys(Object.getPrototypeOf(prim))) {
TestCase.assertEqual(p... | 1 | ////////////////////////////////////////////////////////////////////////////
//
// Copyright 2016 Realm Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/li... | 1 | 18,212 | Perhaps use the new `.keys()` method here instead? | realm-realm-js | js |
@@ -79,9 +79,10 @@ func (b *builder) kubernetesDiff(
}
}
- result, err := provider.DiffList(oldManifests, newManifests,
+ result, err := provider.DiffList(
+ oldManifests,
+ newManifests,
diff.WithEquateEmpty(),
- diff.WithIgnoreAddingMapKeys(),
diff.WithCompareNumberAndNumericString(),
)
if err != ... | 1 | // Copyright 2021 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 17,895 | We don't need this option because plan-preview is comparing between 2 commits, not using the live state. | pipe-cd-pipe | go |
@@ -37,6 +37,11 @@ module Beaker
# @param [Proc] block The actions to be performed in this step.
def step step_name, &block
logger.notify "\n * #{step_name}\n"
+ if @options
+ @options[:current_test_info] ||= {}
+ @options[:current_test_info][:step] ||= {}
+ @op... | 1 | require 'beaker/dsl/assertions'
module Beaker
module DSL
# These are simple structural elements necessary for writing
# understandable tests and ensuring cleanup actions happen. If using a
# third party test runner they are unnecessary.
#
# To include this in your own test runner a method #logger ... | 1 | 9,714 | I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution. | voxpupuli-beaker | rb |
@@ -237,7 +237,8 @@ func (card *DRICard) readPowerConsumption() (float64, error) {
return 0, fmt.Errorf("cannot find average power consumption param in the amdgpu_pm_info")
}
-func (card *DRICard) Metrics() (*DRICardMetrics, error) {
+// Status returns hardware stats for the card
+func (card *DRICard) Status() (*D... | 1 | package gpu
import (
"bufio"
"errors"
"fmt"
"io/ioutil"
"os"
"path"
"regexp"
"strconv"
"strings"
)
const (
pciSlotName = "PCI_SLOT_NAME"
)
var (
devDRICardNameRe = regexp.MustCompile(`^(card)([\d]+)`)
fullDevicePathRe = regexp.MustCompile(`(\/dev\/[a-z]+)(\d+)`)
errBadNameFormat = errors.New("bad name ... | 1 | 7,905 | So `Status` returns metrics? | sonm-io-core | go |
@@ -3,6 +3,8 @@ class OrganizationsController < ApplicationController
helper RatingsHelper
before_action :find_organization
+ before_action :set_outside_committers, only: :outside_committers
+ before_action :organization_context, only: :outside_committers
def outside_projects
@outside_projects = @or... | 1 | class OrganizationsController < ApplicationController
helper ProjectsHelper
helper RatingsHelper
before_action :find_organization
def outside_projects
@outside_projects = @organization.outside_projects((params[:page] || 1), 20)
end
private
def find_organization
@organization = Organization.fro... | 1 | 7,003 | Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument... | blackducksoftware-ohloh-ui | rb |
@@ -56,7 +56,15 @@ public final class IcebergDateObjectInspectorHive3 extends AbstractPrimitiveJava
@Override
public Object copyObject(Object o) {
- return o == null ? null : new Date((Date) o);
+ if (o == null) {
+ return null;
+ }
+
+ if (o instanceof Date) {
+ return new Date((Date) o);... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 27,557 | Why would this be called to copy a non-Date object? | apache-iceberg | java |
@@ -77,13 +77,13 @@ func (msg *Boolmsg) Serialize() []byte {
native.PutUint16(buf[0:2], uint16(msg.Len()))
native.PutUint16(buf[2:4], msg.Type)
if msg.Value {
- buf[4] = 1
+ native.PutUint32(buf[4:8], uint32(1))
} else {
- buf[4] = 0
+ native.PutUint32(buf[4:8], uint32(0))
}
return buf
}
func (msg *... | 1 | // +build linux
package libcontainer
import (
"github.com/vishvananda/netlink/nl"
"golang.org/x/sys/unix"
)
// list of known message types we want to send to bootstrap program
// The number is randomly chosen to not conflict with known netlink types
const (
InitMsg uint16 = 62000
CloneFlagsAttr uint16 =... | 1 | 15,905 | This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once. | opencontainers-runc | go |
@@ -71,7 +71,7 @@ func DefaultConfig() Config {
PauseContainerTag: DefaultPauseContainerTag,
AWSVPCBlockInstanceMetdata: false,
ContainerMetadataEnabled: false,
- TaskCPUMemLimit: DefaultEnabled,
+ TaskCPUMemLimit: BooleanDefaultTr... | 1 | // +build !windows
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the ... | 1 | 24,526 | Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are "default false" config vars not affected by this bug? | aws-amazon-ecs-agent | go |
@@ -9,7 +9,7 @@ class RolesController < ApplicationController
authorize @role
access_level = params[:role][:access_level].to_i
- @role.set_access_level(access_level)
+ @role.access_level = access_level
message = ''
if params[:user].present?
if @role.plan.owner.present? && @role.plan.o... | 1 | class RolesController < ApplicationController
include ConditionalUserMailer
respond_to :html
after_action :verify_authorized
def create
registered = true
@role = Role.new(role_params)
authorize @role
access_level = params[:role][:access_level].to_i
@role.set_access_level(access_level)
... | 1 | 17,919 | Replaced this method with a ruby idiomatic setter. | DMPRoadmap-roadmap | rb |
@@ -2,7 +2,7 @@
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
*
- * This program is free software; you can redistribute it and/or modify
+ * This program is free tisoftware; you can redistribute it and/or modify
* it under the ter... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either... | 1 | 13,772 | wrong place hehe | otland-forgottenserver | cpp |
@@ -0,0 +1,14 @@
+require 'travis/build/appliances/base'
+
+module Travis
+ module Build
+ module Appliances
+ class RestartMysql < Base
+ def apply
+ sh.cmd '(ls /var/run/mysqld/mysqld.sock >& /dev/null) || sudo service mysql restart'
+ end
+ end
+ end
+ end
+end
+ | 1 | 1 | 13,102 | Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon | travis-ci-travis-build | rb | |
@@ -30,12 +30,12 @@ class Proposal < ActiveRecord::Base
has_many :individual_approvals, ->{ individual }, class_name: 'Approvals::Individual'
has_many :approvers, through: :individual_approvals, source: :user
has_many :api_tokens, through: :individual_approvals
- has_many :attachments
+ has_many :attachments... | 1 | class Proposal < ActiveRecord::Base
include WorkflowModel
include ValueHelper
has_paper_trail class_name: 'C2Version'
CLIENT_MODELS = [] # this gets populated later
FLOWS = %w(parallel linear).freeze
workflow do
state :pending do
event :approve, :transitions_to => :approved
event :restart... | 1 | 15,064 | Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice? | 18F-C2 | rb |
@@ -1452,6 +1452,7 @@ static void establish_tunnel(h2o_req_t *req, h2o_tunnel_t *tunnel, uint64_t idle
h2o_iovec_t datagram_flow_id = {};
if (stream->tunnel == NULL) {
+ tunnel->destroy(tunnel);
/* the tunnel has been closed in the meantime */
return;
} | 1 | /*
* Copyright (c) 2018 Fastly, Kazuho Oku
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to use, copy, modify, merge, ... | 1 | 14,987 | This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach. | h2o-h2o | c |
@@ -5,8 +5,8 @@
nano::error nano::node_pow_server_config::serialize_toml (nano::tomlconfig & toml) const
{
- toml.put ("enable", enable, "Enable or disable starting Nano PoW Server as a child process.\ntype:bool");
- toml.put ("nano_pow_server_path", pow_server_path, "Path to the nano_pow_server executable.\ntype:s... | 1 | #include <nano/lib/config.hpp>
#include <nano/lib/rpcconfig.hpp>
#include <nano/lib/tomlconfig.hpp>
#include <nano/node/node_pow_server_config.hpp>
nano::error nano::node_pow_server_config::serialize_toml (nano::tomlconfig & toml) const
{
toml.put ("enable", enable, "Enable or disable starting Nano PoW Server as a ch... | 1 | 15,978 | Did you mean to remove the periods here while newly adding to other locations? | nanocurrency-nano-node | cpp |
@@ -2014,7 +2014,7 @@ func (bps *blockPutState) removeOtherBps(other *blockPutState) {
// slice length.
newLen := len(bps.blockStates) - len(other.blockStates)
if newLen <= 0 {
- newLen = 1
+ newLen = 0
}
// Remove any blocks that appear in `other`. | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"os"
"reflect"
"strings"
"sync"
"time"
"github.com/keybase/backoff"
"github.com/keybase/client/go/libkb"
"github.com/keybase/cl... | 1 | 18,172 | the check can now be `if newLen < 0` | keybase-kbfs | go |
@@ -8,18 +8,13 @@ import (
"os"
"time"
- "github.com/google/uuid"
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
-... | 1 | package main
import (
"context"
"flag"
golog "log"
"net/http"
"os"
"time"
"github.com/google/uuid"
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/pflag"
apiextv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/... | 1 | 20,955 | If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...) | openshift-hive | go |
@@ -28,14 +28,13 @@ typedef boost::tokenizer<boost::char_separator<char> > tokenizer;
namespace ForceFields {
namespace MMFF {
-class std::unique_ptr<MMFFAromCollection> MMFFAromCollection::ds_instance = nullptr;
-
extern const std::uint8_t defaultMMFFArom[];
MMFFAromCollection *MMFFAromCollection::getMMFFArom(... | 1 | // $Id$
//
// Copyright (C) 2013 Paolo Tosco
//
// Copyright (C) 2004-2006 Rational Discovery LLC
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source ... | 1 | 19,387 | Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not. | rdkit-rdkit | cpp |
@@ -360,6 +360,15 @@ class LocalStorage implements IStorage {
name,
(data, cb) => {
if (data._attachments[filename]) {
+ // get version form _attachments;
+ // there aways had 'version' in verdaccio publish package.
+ // but there was no 'version' in package witch unlin... | 1 | /**
* @prettier
* @flow
*/
import assert from 'assert';
import UrlNode from 'url';
import _ from 'lodash';
import { ErrorCode, isObject, getLatestVersion, tagVersion, validateName } from './utils';
import { generatePackageTemplate, normalizePackage, generateRevision, getLatestReadme, cleanUpReadme, normalizeContrib... | 1 | 20,293 | form => from | verdaccio-verdaccio | js |
@@ -28,6 +28,7 @@ public interface Rule extends PropertySource {
* The property descriptor to universally suppress violations with messages
* matching a regular expression.
*/
+ // TODO 7.0.0 use PropertyDescriptor<Pattern>
StringProperty VIOLATION_SUPPRESS_REGEX_DESCRIPTOR = new StringPropert... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd;
import java.util.List;
import net.sourceforge.pmd.lang.Language;
import net.sourceforge.pmd.lang.LanguageVersion;
import net.sourceforge.pmd.lang.ParserOptions;
import net.sourceforge.pmd.lang.ast.Nod... | 1 | 15,025 | Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is th... | pmd-pmd | java |
@@ -66,7 +66,9 @@ public class GoGapicSurfaceTransformerTest {
locator,
new String[] {"myproto_gapic.yaml"});
- productConfig = GapicProductConfig.create(model, configProto, TargetLanguage.GO);
+ productConfig =
+ GapicProductConfig.create(
+ model, configProto, "goog... | 1 | /* Copyright 2016 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in... | 1 | 26,866 | Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer. | googleapis-gapic-generator | java |
@@ -94,7 +94,7 @@ class CheckCompoundPattern {
CharsRef expandReplacement(CharsRef word, int breakPos) {
if (replacement != null && charsMatch(word, breakPos, replacement)) {
return new CharsRef(
- word.subSequence(0, breakPos)
+ new String(word.chars, 0, word.offset + breakPos)
... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 40,354 | Include all compounds parts from the very beginning for the case check to work later | apache-lucene-solr | java |
@@ -461,7 +461,7 @@ func get(envInfo *cmds.Agent, proxy proxy.Proxy) (*config.Node, error) {
}
if !nodeConfig.Docker && nodeConfig.ContainerRuntimeEndpoint == "" {
- nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.Containerd.Address
+ nodeConfig.AgentConfig.RuntimeSocket = "unix://" + nodeConfig.Containerd.Ad... | 1 | package config
import (
"bufio"
"context"
cryptorand "crypto/rand"
"crypto/tls"
"encoding/hex"
"encoding/pem"
"fmt"
"io/ioutil"
sysnet "net"
"net/http"
"net/url"
"os"
"os/exec"
"path/filepath"
"regexp"
"strings"
"time"
"github.com/pkg/errors"
"github.com/rancher/k3s/pkg/agent/proxy"
"github.com/ra... | 1 | 8,729 | if the user specifies a url scheme on the cli this is going to cause problems, no? | k3s-io-k3s | go |
@@ -726,7 +726,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
disableIndicators: true,
disableHoverMenu: true,
overlayPlayButton: true,
- width: dom.getWindowSize().innerWidth * 0.25
+ width: dom.getWindowSize().innerWid... | 1 | define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSettings', 'cardBuilder', 'datetime', 'mediaInfo', 'backdrop', 'listView', 'itemContextMenu', 'itemHelper', 'dom', 'indicators', 'imageLoader', 'libraryMenu', 'globalize', 'browser', 'events', 'playbackManager', 'scrollStyles', 'emby-itemscontai... | 1 | 16,589 | How about that `scaleFactor`? | jellyfin-jellyfin-web | js |
@@ -273,6 +273,19 @@ class NonDivArithmeticOpAnalyzer
}
}
+ /**
+ * @param int|float $result
+ */
+ private static function getNumericalType($result): Type\Union
+ {
+ if ($result <= PHP_INT_MAX && $result >= PHP_INT_MIN) {
+ /** @var int $result */
+ return... | 1 | <?php
namespace Psalm\Internal\Analyzer\Statements\Expression\BinaryOp;
use PhpParser;
use Psalm\CodeLocation;
use Psalm\Config;
use Psalm\Context;
use Psalm\Internal\Analyzer\Statements\Expression\Assignment\ArrayAssignmentAnalyzer;
use Psalm\Internal\Analyzer\StatementsAnalyzer;
use Psalm\Internal\Type\TypeCombiner;... | 1 | 10,540 | `assert(is_int($result));` would be preferable I think, even if we know it can't ever be false | vimeo-psalm | php |
@@ -162,14 +162,14 @@ class Cart
/**
* @return \Shopsys\FrameworkBundle\Model\Order\Item\QuantifiedProduct[]
*/
- public function getQuantifiedProductsIndexedByItemId()
+ public function getQuantifiedProducts()
{
- $quantifiedProductsByItemId = [];
+ $quantifiedProducts = [];
... | 1 | <?php
namespace Shopsys\FrameworkBundle\Model\Cart;
use DateTime;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\ORM\Mapping as ORM;
use Shopsys\FrameworkBundle\Model\Cart\Item\CartItem;
use Shopsys\FrameworkBundle\Model\Cart\Item\CartItemFactoryInterface;
use Shopsys\FrameworkBundle\Model\Customer\Use... | 1 | 14,983 | I'm unfortunately unable to review whether you've changed everything that used to use cartIds | shopsys-shopsys | php |
@@ -3,14 +3,15 @@ package de.danoeh.antennapod.dialog;
import android.app.Dialog;
import android.content.Context;
import android.content.SharedPreferences;
+import android.util.Log;
+
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;
-import android.util.Log;
+import androidx.appco... | 1 | package de.danoeh.antennapod.dialog;
import android.app.Dialog;
import android.content.Context;
import android.content.SharedPreferences;
import androidx.annotation.Nullable;
import androidx.annotation.VisibleForTesting;
import android.util.Log;
import java.lang.ref.WeakReference;
import java.util.concurrent.TimeUnit... | 1 | 18,208 | Please don't touch unrelated files to keep the git history clean | AntennaPod-AntennaPod | java |
@@ -0,0 +1,19 @@
+module AbTests
+ class LandingHeadlineTest < Base
+ def setup
+ variation(ab_test(test_name, "orig", "v1"))
+ end
+
+ def finish
+ finished(test_name)
+ end
+
+ private
+
+ def variation(key)
+ # The :name value isn't needed in all variations. Passing it when it is
+ ... | 1 | 1 | 8,662 | Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that? | thoughtbot-upcase | rb | |
@@ -54,7 +54,7 @@ def gen_gaussian_target(heatmap, center, radius, k=1):
masked_heatmap = heatmap[y - top:y + bottom, x - left:x + right]
masked_gaussian = gaussian_kernel[radius - top:radius + bottom,
radius - left:radius + right]
- out_heatmap = torch.zeros_like(hea... | 1 | from math import sqrt
import torch
def gaussian2D(radius, sigma=1, dtype=torch.float32, device='cpu'):
"""Generate 2D gaussian kernel.
Args:
radius (int): Radius of gaussian kernel.
sigma (int): Sigma of gaussian function. Default: 1.
dtype (torch.dtype): Dtype of gaussian tensor. De... | 1 | 20,990 | Will this change the input `heatmap`? Is this behavior expected or not? | open-mmlab-mmdetection | py |
@@ -411,7 +411,7 @@ func init() {
runtime.RegisterPackageValue("strings", "lastIndex",
generateDualArgStringFunctionReturnInt("lastIndex", []string{stringArgV, substr}, strings.LastIndex))
runtime.RegisterPackageValue("strings", "lastIndexAny",
- generateDualArgStringFunctionReturnInt("lastIndexAny", []string{s... | 1 | package strings
import (
"context"
"fmt"
"strings"
"unicode"
"unicode/utf8"
"github.com/influxdata/flux/interpreter"
"github.com/influxdata/flux/runtime"
"github.com/influxdata/flux/semantic"
"github.com/influxdata/flux/values"
)
var SpecialFns map[string]values.Function
const (
stringArgV = "v"
stringAr... | 1 | 17,667 | If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now? | influxdata-flux | go |
@@ -1,8 +1,3 @@
-/*
- Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
- SPDX-License-Identifier: Apache-2.0
-*/
-
package com.spring.sns;
import org.springframework.beans.factory.annotation.Autowired; | 1 | /*
Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
SPDX-License-Identifier: Apache-2.0
*/
package com.spring.sns;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Controller;
import org.springframework.web.bind.annotation.*;
import... | 1 | 20,176 | Need copyright/license info. | awsdocs-aws-doc-sdk-examples | rb |
@@ -3,10 +3,8 @@ package admissioncontroller
import (
"fmt"
"net/http"
- "strings"
admissionv1beta1 "k8s.io/api/admission/v1beta1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/klog/v2"
rulesv1 "github.com/kubeedge/kubeedge/cloud/pkg/apis/rules/v1" | 1 | package admissioncontroller
import (
"fmt"
"net/http"
"strings"
admissionv1beta1 "k8s.io/api/admission/v1beta1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/klog/v2"
rulesv1 "github.com/kubeedge/kubeedge/cloud/pkg/apis/rules/v1"
)
func admitRuleEndpoint(review admissionv1beta1.AdmissionReview) *admi... | 1 | 22,872 | Is this `info log` necessary? If it is not useful, can you consider deleting it? | kubeedge-kubeedge | go |
@@ -103,7 +103,7 @@ func TestConfigLoadEncryptedFailures(t *testing.T) {
err = config.Data().Load()
require.Error(t, err)
- // This file contains invalid base64 characters.
+ // This file's header starts with RCLONE_ENCRYPT_V1 instead of V0.
assert.NoError(t, config.SetConfigPath("./testdata/enc-too-new.conf"))... | 1 | // These are in an external package because we need to import configfile
//
// Internal tests are in crypt_internal_test.go
package config_test
import (
"context"
"testing"
"github.com/rclone/rclone/fs"
"github.com/rclone/rclone/fs/config"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/requi... | 1 | 14,666 | Unrelated change, but seems to be the correct purpose of the test. | rclone-rclone | go |
@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
const restrictions = this.uppy.opts.restrictions
return (
<input
+ id={'input-' + this.id}
class="uppy-DragDrop-input"
type="file"
tabindex={-1} | 1 | const { Plugin } = require('@uppy/core')
const Translator = require('@uppy/utils/lib/Translator')
const toArray = require('@uppy/utils/lib/toArray')
const isDragDropSupported = require('@uppy/utils/lib/isDragDropSupported')
const getDroppedFiles = require('@uppy/utils/lib/getDroppedFiles')
const { h } = require('preact... | 1 | 13,081 | Should it be `'uppy-input-`? | transloadit-uppy | js |
@@ -191,7 +191,7 @@ static inline double mtrace(int n,double A[8][8],double B[8][8]) {
void PairMGPT::make_triplet(bond_data *ij_bond,bond_data *ik_bond,
triplet_data *triptr) {
- if (1) {
+ if (true) {
const trmul_fun tr_mul = linalg.tr_mul;
tr_mul(&(ij_bond->H.m[1][0]), &(... | 1 | // clang-format off
/* ----------------------------------------------------------------------
LAMMPS - Large-scale Atomic/Molecular Massively Parallel Simulator
https://www.lammps.org/, Sandia National Laboratories
Steve Plimpton, sjplimp@sandia.gov
Copyright (2003) Sandia Corporation. Under the terms of ... | 1 | 31,444 | what's the reasoning to keep these always true or dead-code blocks? | lammps-lammps | cpp |
@@ -351,4 +351,13 @@ $(document).ready(function() {
}
});
}
+
+ $('body').on('click', '.tab-buttons > div', function() {
+ if ($(this).next().length === 1) {
+ $('.widget-content').addClass('hide-zoom');
+ }
+ else {
+ $('.widget-content').removeC... | 1 | 'use strict';
/* jshint undef: true, unused: true */
/* globals app, $, countlyGlobal, components, countlyCommon, countlySegmentation, countlyUserdata, CountlyHelpers, jQuery, countlyManagementView, Backbone */
app.addAppManagementView('push', jQuery.i18n.map['push.plugin-title'], countlyManagementView.extend({
i... | 1 | 13,541 | It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {` | Countly-countly-server | js |
@@ -307,9 +307,12 @@ func buildControllerContext(ctx context.Context, opts *options.ControllerOptions
KubeSharedInformerFactory: kubeSharedInformerFactory,
SharedInformerFactory: sharedInformerFactory,
GWShared: gwSharedInformerFactory,
- Namespace: opts.Namespace,
- Cloc... | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 28,712 | I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 sh... | jetstack-cert-manager | go |
@@ -1180,6 +1180,7 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
try {
configureLogging(true);
+ instantiateSignatureAlgorithmFactory();
configureNativeLibs();
logger.info("Starting Besu version: {}", BesuInfo.nodeName(identityString));
// Need to create... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 24,999 | I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu. | hyperledger-besu | java |
@@ -1,11 +1,16 @@
+from typing import TYPE_CHECKING
+
from astroid import nodes
from pylint.checkers import BaseChecker
from pylint.interfaces import IAstroidChecker
+if TYPE_CHECKING:
+ from pylint.lint import PyLinter
-# This is our checker class.
# Checkers should always inherit from `BaseChecker`.
+
+
... | 1 | from astroid import nodes
from pylint.checkers import BaseChecker
from pylint.interfaces import IAstroidChecker
# This is our checker class.
# Checkers should always inherit from `BaseChecker`.
class MyAstroidChecker(BaseChecker):
"""Add class member attributes to the class local's dictionary."""
# This cla... | 1 | 19,277 | Why remove this? | PyCQA-pylint | py |
@@ -490,6 +490,18 @@ class Builder {
return this;
}
+ /**
+ * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
+ * child process when creating IE sessions locally.
+ *
+ * @param {ie.ServiceBuilder} service the service to use.
+ * @return {!Builder} a self reference.
+ */
+ se... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 15,736 | `this.ieService_` should be initialized to null in the constructor. | SeleniumHQ-selenium | py |
@@ -394,7 +394,7 @@ int main(int argc, char **argv)
cflags.push_back(generate_header_filter_cflag(response_header_filters));
}
- ebpf::BPF *bpf = new ebpf::BPF();
+ std::unique_ptr<ebpf::BPF> bpf(new ebpf::BPF());
std::vector<ebpf::USDT> probes;
bool selective_tracing = false; | 1 | /*
* Copyright (c) 2019-2021 Fastly, Inc., Toru Maesaka, Goro Fuji, Kazuho Oku
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* ... | 1 | 15,398 | Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value. | h2o-h2o | c |
@@ -19,8 +19,11 @@ package controller
import (
"errors"
"fmt"
+ "strings"
"time"
+ apiutil "github.com/jetstack/cert-manager/pkg/api/util"
+
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
cmapi "github.com/jetstack/cert-manager/pkg/apis/certmanager/v1" | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 24,667 | nit: move to last block | jetstack-cert-manager | go |
@@ -15,8 +15,8 @@ import (
"syscall"
"github.com/hashicorp/hcl"
- "github.com/spiffe/spire/helpers"
"github.com/spiffe/spire/pkg/agent"
+ "github.com/spiffe/spire/pkg/common/logger"
)
const ( | 1 | package command
import (
"crypto/x509"
"crypto/x509/pkix"
"errors"
"flag"
"fmt"
"io/ioutil"
"net"
"net/url"
"os"
"os/signal"
"strconv"
"syscall"
"github.com/hashicorp/hcl"
"github.com/spiffe/spire/helpers"
"github.com/spiffe/spire/pkg/agent"
)
const (
defaultConfigPath = ".conf/default_agent_config.h... | 1 | 8,530 | nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces | spiffe-spire | go |
@@ -272,6 +272,12 @@ namespace NLog.Targets
[ArrayParameter(typeof(DatabaseParameterInfo), "parameter")]
public IList<DatabaseParameterInfo> Parameters { get; } = new List<DatabaseParameterInfo>();
+ /// <summary>
+ /// Configures isolated transaction batch writing. If supported by the... | 1 | //
// Copyright (c) 2004-2019 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 20,713 | Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss? | NLog-NLog | .cs |
@@ -24,15 +24,8 @@ var (
// Action is the action can be Executed in protocols. The method is added to avoid mistakenly used empty interface as action.
type Action interface {
- SetEnvelopeContext(SealedEnvelope)
- SanityCheck() error
-}
-
-type actionPayload interface {
- Serialize() []byte
Cost() (*big.Int, erro... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 21,667 | do we still need SanityCheck()? seems they all return nil now | iotexproject-iotex-core | go |
@@ -94,7 +94,6 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
* @type {HTMLElement}
*/
this.rootElement = rootElement;
- /* eslint-enable jsdoc/require-description-complete-sentence */
/**
* The nearest document over container.
* | 1 | import { addClass, empty, removeClass } from './helpers/dom/element';
import { isFunction } from './helpers/function';
import { isDefined, isUndefined, isRegExp, _injectProductInfo, isEmpty } from './helpers/mixed';
import { isMobileBrowser, isIpadOS } from './helpers/browser';
import EditorManager from './editorManage... | 1 | 20,905 | What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is ... | handsontable-handsontable | js |
@@ -48,4 +48,4 @@ doc.css("h1, h2, h3, h4, h5, h6").each do |header|
end
puts "\n==================================================\n"
-puts "!!! Don't forget to set a summary: https://#{ENV.fetch("APP_DOMAIN")}/admin/video/#{video.id}/edit"
+puts "!!! Don't forget to set a summary: https://thoughtbot.com/upcase/ad... | 1 | #!./bin/rails runner
# This script is designed to be run on Heroku, to set the notes and create
# Markers for the Video with a given slug.
#
# It assumes that it's receiving a Markdown document on STDIN with the marker
# times in the headers, like:
#
# ## Creating a database view 324
#
# Run it like this:
#
# cat... | 1 | 17,395 | Line is too long. [100/80] | thoughtbot-upcase | rb |
@@ -532,8 +532,12 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
return err
}
- if !gopts.JSON && parentSnapshotID != nil {
- p.V("using parent snapshot %v\n", parentSnapshotID.Str())
+ if !gopts.JSON {
+ if parentSnapshotID != nil {
+ p.P("using parent snapshot %v\n", pa... | 1 | package main
import (
"bufio"
"bytes"
"context"
"fmt"
"io"
"io/ioutil"
"os"
"path"
"path/filepath"
"runtime"
"strconv"
"strings"
"time"
"github.com/spf13/cobra"
tomb "gopkg.in/tomb.v2"
"github.com/restic/restic/internal/archiver"
"github.com/restic/restic/internal/debug"
"github.com/restic/restic/i... | 1 | 14,454 | I suggest "no parent snapshot found, will read all data\n". | restic-restic | go |
@@ -48,9 +48,7 @@ namespace NLog.UnitTests
{
using (new NoThrowNLogExceptions())
{
- LogManager.ThrowExceptions = true;
-
- LogManager.Configuration = XmlLoggingConfiguration.CreateFromXmlString(@"
+ var config = XmlLoggingConfiguration.Cre... | 1 | //
// Copyright (c) 2004-2018 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 18,046 | `LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load? | NLog-NLog | .cs |
@@ -27,14 +27,12 @@ var formatter = this;
string = function(value) {
if (value != null) {
value = value.replace(/\\/g, '\\\\');
- value = value.replace(/\"/g, '\\"');
+ value = value.replace(/\'/g, '\\\'');
value = value.replace(/\r/g, '\\r');
value = value.replace(/\n/g, '\\n');
- value = value.replace(... | 1 | /*
* Format for Selenium Remote Control Perl client.
*/
var subScriptLoader = Components.classes["@mozilla.org/moz/jssubscript-loader;1"].getService(Components.interfaces.mozIJSSubScriptLoader);
subScriptLoader.loadSubScript('chrome://selenium-ide/content/formats/remoteControl.js', this);
this.name = "perl-rc";
//... | 1 | 10,826 | It should be return "''"; I will fix it | SeleniumHQ-selenium | java |
@@ -100,11 +100,10 @@ public class AcceptanceTest extends STBBaseTst {
ASTMethodDeclaration node = acu.findDescendantsOfType(ASTMethodDeclaration.class).get(0);
Scope s = node.getScope();
Map<NameDeclaration, List<NameOccurrence>> m = s.getDeclarations();
- for (Iterator<NameDeclaratio... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.symboltable;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
import ja... | 1 | 13,826 | This is wrong, should be `entry.getValue()` | pmd-pmd | java |
@@ -363,7 +363,7 @@ func (r *ReconcileControlPlaneCerts) getServingCertificatesJSONPatch(cd *hivev1.
additional.Domain, remoteSecretName(bundle.CertificateSecretRef.Name, cd)))
}
- var kubeAPIServerNamedCertsTemplate = `[ { "op": "replace", "path": "/spec/servingCerts/namedCertificates", "value": [ %s ] } ]`
+ ... | 1 | package controlplanecerts
import (
"context"
"crypto/md5"
"fmt"
"io"
"net/url"
"sort"
"strings"
"time"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/p... | 1 | 15,636 | nit: why can't we combine the two add operations into one so that we add `{"nameCertificates": []}` to `/spec/servingCerts` ? | openshift-hive | go |
@@ -3,13 +3,14 @@
// See the LICENSE file in the project root for more information.
// ==++==
-//
-
-//
+//
+
+//
// ==--==
#include <assert.h>
#include "sos.h"
#include "safemath.h"
+#include "holder.h"
// This is the increment for the segment lookup data | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
// ==++==
//
//
// ==--==
#include <assert.h>
#include "sos.h"
#include "safemath.h"
// This is the increment ... | 1 | 11,741 | These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs. | dotnet-diagnostics | cpp |
@@ -19,11 +19,13 @@ public abstract class RoomHandler
protected final Client client;
protected final TheatrePlugin plugin;
+ protected final TheatreConfig config;
- protected RoomHandler(final Client client, final TheatrePlugin plugin)
+ protected RoomHandler(final Client client, final TheatrePlugin plugin, The... | 1 | package net.runelite.client.plugins.theatre;
import java.awt.Color;
import java.awt.Font;
import java.awt.Graphics2D;
import java.awt.Polygon;
import java.util.Map;
import net.runelite.api.Client;
import net.runelite.api.NPC;
import net.runelite.api.Perspective;
import net.runelite.api.Point;
import net.runelite.api.P... | 1 | 16,059 | why does this suddenly need a config ref | open-osrs-runelite | java |
@@ -99,6 +99,10 @@ module.exports = function(config) {
customLaunchers: sauceLabs ? sauceLabsLaunchers : travisLaunchers,
files: [
+ // We can't load this up front because it's ES2015 and we need it only
+ // for certain tests that run under those conditions. We also can't load
+ // it via CDN because { i... | 1 | /*eslint no-var:0, object-shorthand:0 */
var coverage = String(process.env.COVERAGE)!=='false',
ci = String(process.env.CI).match(/^(1|true)$/gi),
pullRequest = !String(process.env.TRAVIS_PULL_REQUEST).match(/^(0|false|undefined)$/gi),
masterBranch = String(process.env.TRAVIS_BRANCH).match(/^master$/gi),
realBrows... | 1 | 11,031 | Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it. | preactjs-preact | js |
@@ -67,6 +67,10 @@ exclude = ["AuthalicMatrixCoefficients",
"vnl_file_matrix",
"vnl_file_vector",
"vnl_fortran_copy",
+ "CosineWindowFunction",
+ "HammingWindowFunction",
+ "LanczosWindowFunction",
+ "WelchWindowFunction",
]
tota... | 1 | #==========================================================================
#
# Copyright Insight Software Consortium
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http... | 1 | 10,418 | Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now). | InsightSoftwareConsortium-ITK | py |
@@ -27,7 +27,7 @@ import (
// This little bit of wrapping needs to be done because go doesn't do
// covariance, but it does coerce *time.Timer into stoppable implicitly if we
// write it out like so.
-var afterFunc = func(c clock.Clock, d time.Duration, f func()) stoppable {
+func afterFunc(c clock.Clock, d time.Dur... | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 28,369 | Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability? | jetstack-cert-manager | go |
@@ -27,8 +27,7 @@ MolDraw2DQt::MolDraw2DQt(int width, int height, QPainter &qp, int panelWidth,
// ****************************************************************************
void MolDraw2DQt::setColour(const DrawColour &col) {
MolDraw2D::setColour(col);
- QColor this_col(int(255.0 * col.get<0>()), int(255.0 * c... | 1 | //
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
// Original author: David Cosgrove (AstraZeneca)
// 19th June 2014
//
#include "MolDraw2DQ... | 1 | 19,528 | I'm assuming that MolDraw2Qt drops the alpha channel? | rdkit-rdkit | cpp |
@@ -24,6 +24,9 @@ namespace System.Text.Json.Serialization.Tests
[GenericTypeArguments(typeof(HashSet<string>))]
[GenericTypeArguments(typeof(ArrayList))]
[GenericTypeArguments(typeof(Hashtable))]
+ [GenericTypeArguments(typeof(SimpleStructWithProperties))]
+ [GenericTypeArguments(typeof(LargeStruc... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using BenchmarkDotNet.Attributes;
using MicroBenchmarks;
using MicroBenchmarks.Serializers;
using System.Collection... | 1 | 10,932 | the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer. | dotnet-performance | .cs |
@@ -472,7 +472,18 @@ class Composition(collections.Hashable, collections.Mapping, MSONable):
Returns:
Composition with that formula.
+
+ Notes:
+ In the case of Metallofullerene formula (e.g. Y3N@C80),
+ the @ mark will be dropped and passed to parser.
"""
+... | 1 | # coding: utf-8
# Copyright (c) Pymatgen Development Team.
# Distributed under the terms of the MIT License.
from __future__ import division, unicode_literals
import collections
import numbers
import string
from itertools import combinations_with_replacement, product
import os
import six
import re
from collections ... | 1 | 17,544 | Pls remove the print statements. Also, you do not need the if statement. | materialsproject-pymatgen | py |
@@ -112,7 +112,7 @@ def patch_moto():
# escape message responses to allow for special characters like "<"
sqs_responses.RECEIVE_MESSAGE_RESPONSE = sqs_responses.RECEIVE_MESSAGE_RESPONSE.replace(
- "<StringValue>{{ value.string_value }}</StringValue>",
+ "<StringValue><![CDATA[{{ value.string_v... | 1 | import logging
import os
import types
from html import escape
from moto.core.utils import camelcase_to_underscores
from moto.sqs import responses as sqs_responses
from moto.sqs.exceptions import QueueDoesNotExist
from moto.sqs.models import Queue
from localstack import config
from localstack.config import LOCALSTACK_... | 1 | 13,578 | Thanks for this fix @eltone ! Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks | localstack-localstack | py |
@@ -91,6 +91,7 @@ func newSimpleClientV7(url string) (*clientV7, error) {
var err error
if client, err = elastic.NewClient(
elastic.SetURL(url),
+ elastic.SetSniff(false),
elastic.SetRetrier(retrier),
); err != nil {
return nil, err | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 12,240 | Should this be instead a configurable option? | temporalio-temporal | go |
@@ -64,6 +64,13 @@ func (c *CreateDisks) run(ctx context.Context, s *Step) DError {
}
}
+ // Get the source snapshot link if using a source snapshot.
+ if cd.SourceSnapshot != "" {
+ if snapshot, ok := w.snapshots.get(cd.SourceSnapshot); ok {
+ cd.SourceSnapshot = snapshot.link
+ }
+ }
+
... | 1 | // Copyright 2017 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 10,371 | unit test needs an update? | GoogleCloudPlatform-compute-image-tools | go |
@@ -12,7 +12,6 @@ module.exports = class Provider extends RequestClient {
super(uppy, opts)
this.provider = opts.provider
this.id = this.provider
- this.authProvider = opts.authProvider || this.provider
this.name = this.opts.name || _getName(this.id)
this.pluginId = this.opts.pluginId
t... | 1 | 'use strict'
const RequestClient = require('./RequestClient')
const tokenStorage = require('./tokenStorage')
const _getName = (id) => {
return id.split('-').map((s) => s.charAt(0).toUpperCase() + s.slice(1)).join(' ')
}
module.exports = class Provider extends RequestClient {
constructor (uppy, opts) {
super(... | 1 | 13,256 | I realised that this is not used anywhere | transloadit-uppy | js |
@@ -187,6 +187,7 @@ func watchConfig(cfg *config.Config, stopCh <-chan struct{}) {
case <-stopCh:
close(sigChan)
return
+ default:
}
}
}() | 1 | // Copyright 2019 PingCAP, Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to i... | 1 | 12,636 | why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time? | chaos-mesh-chaos-mesh | go |
@@ -1477,6 +1477,8 @@ func handleUSB(intr interrupt.Interrupt) {
// clear stall request
setEPINTENCLR(0, sam.USB_DEVICE_EPINTENCLR_STALL1)
}
+ } else {
+ sendZlp()
}
// Now the actual transfer handlers, ignore endpoint number 0 (setup) | 1 | // +build sam,atsamd21
// Peripheral abstraction layer for the atsamd21.
//
// Datasheet:
// http://ww1.microchip.com/downloads/en/DeviceDoc/SAMD21-Family-DataSheet-DS40001882D.pdf
//
package machine
import (
"device/arm"
"device/sam"
"errors"
"runtime/interrupt"
"unsafe"
)
type PinMode uint8
const (
PinAnalo... | 1 | 9,245 | This line appears to have caused the regression. What is it supposed to be doing? | tinygo-org-tinygo | go |
@@ -54,10 +54,8 @@ class ProxyType:
value = str(value).upper()
for attr in dir(cls):
attr_value = getattr(cls, attr)
- if isinstance(attr_value, dict) and \
- 'string' in attr_value and \
- attr_value['string'] is not None and \
- ... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 18,411 | # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done | SeleniumHQ-selenium | rb |
@@ -39,13 +39,11 @@ namespace OpenTelemetry.Metrics
configure?.Invoke(options);
var exporter = new PrometheusExporter(options);
-
- var metricReader = new BaseExportingMetricReader(exporter);
- exporter.CollectMetric = metricReader.Collect;
+ var reader = new... | 1 | // <copyright file="MeterProviderBuilderExtensions.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// ht... | 1 | 21,550 | @alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be... | open-telemetry-opentelemetry-dotnet | .cs |
@@ -224,7 +224,13 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore
if (!process.HasExited)
{
- process.Kill();
+ // Try shutting down gracefully
+ await SubmitRequest(aspNetCorePort, "/shutdown");
+
+ ... | 1 | // <copyright file="AspNetCoreMvcTestBase.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>
using System;
us... | 1 | 20,695 | As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too? | DataDog-dd-trace-dotnet | .cs |
@@ -0,0 +1,16 @@
+using System;
+using System.Net.Http;
+
+namespace OpenTelemetry.Exporter
+{
+ public interface IHttpClientFactoryExporterOptions
+ {
+ /// <summary>
+ /// Gets or sets the factory function called to create the <see
+ /// cref="HttpClient"/> instance that will be used at run... | 1 | 1 | 23,030 | Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself. | open-telemetry-opentelemetry-dotnet | .cs | |
@@ -12,6 +12,6 @@ return [
|
*/
- 'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
- 'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
+ 'failed' => 'یہ تفصیلات درست نہیں ہیں۔',
+ 'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ بر... | 1 | <?php
return [
/*
|--------------------------------------------------------------------------
| Authentication Language Lines
|--------------------------------------------------------------------------
|
| The following language lines are used during authentication for various
| messages th... | 1 | 6,989 | here is `:seconds` missing | Laravel-Lang-lang | php |
@@ -149,7 +149,7 @@ class KeywordArgument(object):
func = lambda arg=arg: arg * arg # [undefined-variable]
arg2 = 0
- func2 = lambda arg2=arg2: arg2 * arg2
+ func3 = lambda arg2=arg2: arg2 * arg2
# Don't emit if the code is protected by NameError
try: | 1 | # pylint: disable=missing-docstring, multiple-statements
# pylint: disable=too-few-public-methods, no-init, no-self-use, old-style-class,bare-except,broad-except
from __future__ import print_function
DEFINED = 1
if DEFINED != 1:
if DEFINED in (unknown, DEFINED): # [undefined-variable]
DEFINED += 1
def i... | 1 | 9,065 | change of name is not needed | PyCQA-pylint | py |
@@ -120,10 +120,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
self.assertEqual(kser.name, "renamed")
self.assert_eq(kser, pser)
- pser.name = None
- kser.name = None
- self.assertEqual(kser.name, None)
- self.assert_eq(kser, pser)
+ # pser.name = None
+ ... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 15,540 | Hm .. so this case doesn't work anymore? | databricks-koalas | py |
@@ -22,7 +22,8 @@
import os
import tempfile
-from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QProcess
+from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QProcess,
+ QFileSystemWatcher)
from qutebrowser.config import config
from qutebrowser.utils import message, log | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 20,180 | Please indent this so it lines up with the `(` | qutebrowser-qutebrowser | py |
@@ -23,10 +23,11 @@ function roots_scripts() {
if (is_single() && comments_open() && get_option('thread_comments')) {
wp_enqueue_script('comment-reply');
}
-
- wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
+
+ // Not included by default since th... | 1 | <?php
function roots_scripts() {
// Not included by default since Bootstrap's reset supersedes h5bp's. Include if you aren't using Bootstrap.
//wp_enqueue_style('roots_style', get_template_directory_uri() . '/css/style.css', false, null);
wp_enqueue_style('roots_bootstrap_style', get_template_directory_uri() . ... | 1 | 7,652 | We should still register the script. Just not enqueue it. | roots-sage | php |
@@ -20,7 +20,7 @@ module Mongoid #:nodoc:
def changes
{}.tap do |hash|
changed.each do |name|
- change = attribute_change(name)
+ change = [changed_attributes[name], attributes[name]] if attribute_changed?(name)
hash[name] = change if change[0] != change[1]
end... | 1 | # encoding: utf-8
module Mongoid #:nodoc:
module Dirty #:nodoc:
extend ActiveSupport::Concern
include ActiveModel::Dirty
# Get the changed values for the document. This is a hash with the name of
# the field as the keys, and the values being an array of previous and
# current pairs.
#
# @... | 1 | 9,053 | I think this can stay as a method. And we can write our own attribute_change(name) as required. | mongodb-mongoid | rb |
@@ -142,7 +142,8 @@ namespace MvvmCross.DroidX.RecyclerView
protected virtual View InflateViewForHolder(ViewGroup parent, int viewType, IMvxAndroidBindingContext bindingContext)
{
- return bindingContext.BindingInflate(viewType, parent, false);
+ var layoutId = ItemTemplateSele... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MS-PL license.
// See the LICENSE file in the project root for more information.
using System;
using System.Collections;
using System.Collections.Specialized;
using System.Windows.Input;
using A... | 1 | 15,231 | @alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which make... | MvvmCross-MvvmCross | .cs |
@@ -96,6 +96,9 @@ class BQTable(collections.namedtuple('BQTable', 'project_id dataset_id table_id'
return "bq://" + self.project_id + "/" + \
self.dataset.dataset_id + "/" + self.table_id
+ def __str__(self):
+ return "%s:%s.%s" % (self.project_id, self.dataset_id, self.table_id)
+
... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2015 Twitter Inc
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or ... | 1 | 15,887 | Can you change this to use `.format()`? | spotify-luigi | py |
@@ -308,13 +308,15 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
},
})
- if dropEncap {
+ if dropEncap && r.Config.DropVXLANPacketsFromWorkloads {
rules = append(rules, Rule{
Match: Match().ProtocolNum(ProtoUDP).
DestPorts(uint16(r.Config.VXLANPort)),
Action: DropAction{},
Comment:... | 1 | // Copyright (c) 2016-2020 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 18,306 | Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set? | projectcalico-felix | go |
@@ -47,11 +47,11 @@ type SectorBuilder interface {
// which will fit into a newly-provisioned staged sector.
GetMaxUserBytesPerStagedSector() (uint64, error)
- // GeneratePoST creates a proof-of-spacetime for the replicas managed by
+ // GeneratePoSt creates a proof-of-spacetime for the replicas managed by
// t... | 1 | package sectorbuilder
import (
"context"
"io"
"gx/ipfs/QmR8BauakNcBa3RbE4nbQu76PDiJgoQgz8AJdhJuiU4TAw/go-cid"
cbor "gx/ipfs/QmcZLyosDwMKdB6NLRsiss9HXzDPhVhhRtPy67JFKTDQDX/go-ipld-cbor"
"github.com/filecoin-project/go-filecoin/proofs"
)
func init() {
cbor.RegisterCborType(PieceInfo{})
}
// SectorBuilder provi... | 1 | 17,493 | new casing is less ELiTE | filecoin-project-venus | go |
@@ -179,6 +179,14 @@ bool wlr_renderer_blit_dmabuf(struct wlr_renderer *r,
return r->impl->blit_dmabuf(r, dst, src);
}
+GLuint wlr_renderer_renderbuffer_from_image(struct wlr_renderer *r,
+ EGLImageKHR image) {
+ if (!r->impl->renderbuffer_from_image) {
+ return false;
+ }
+ return r->impl->renderbuffer_from_ima... | 1 | #include <assert.h>
#include <stdbool.h>
#include <stdlib.h>
#include <wlr/render/gles2.h>
#include <wlr/render/interface.h>
#include <wlr/render/wlr_renderer.h>
#include <wlr/types/wlr_matrix.h>
#include <wlr/util/log.h>
#include "util/signal.h"
void wlr_renderer_init(struct wlr_renderer *renderer,
const struct wlr... | 1 | 15,572 | This leaks EGL/GL implementation details into the generic renderer interface. | swaywm-wlroots | c |
@@ -32,6 +32,16 @@ module Travis
end
end
+ class DeployConditionError < DeployConfigError
+ def initialize(msg = "The \\`deploy.on\\` should be a hash (dictionary).")
+ super
+ end
+
+ def doc_path
+ '/user/deployment#Conditional-Releases-with-on%3A'
+ end
+ end
+
... | 1 | module Travis
module Build
class CompilationError < StandardError
attr_accessor :doc_path
def initialize(msg = '')
@msg = msg
end
def to_s
@msg
end
end
class EnvVarDefinitionError < CompilationError
def initialize(msg = "Environment variables definiti... | 1 | 15,701 | Maybe add *key* i.e. `"The \\`deploy.on\\` key should be a hash (dictionary).` | travis-ci-travis-build | rb |
@@ -75,7 +75,7 @@ class StatusGridBuilder implements GridBuilderInterface
{
$result = [];
foreach ($this->statusQuery->getAllStatuses($language) as $code => $status) {
- $result[] = new StatusOption($code, $code, new Color($status['color']), $status['name']);
+ $result[] = n... | 1 | <?php
/**
* Copyright © Ergonode Sp. z o.o. All rights reserved.
* See LICENSE.txt for license details.
*/
declare(strict_types=1);
namespace Ergonode\Workflow\Infrastructure\Grid;
use Ergonode\Core\Domain\ValueObject\Color;
use Ergonode\Core\Domain\ValueObject\Language;
use Ergonode\Grid\Column\BoolColumn;
use ... | 1 | 9,490 | its be good also change $code na $id, actual name is misleading and that was probably actual error generator | ergonode-backend | php |
@@ -10,9 +10,8 @@ from listenbrainz.listenstore import ListenStore
class RedisListenStore(ListenStore):
- RECENT_LISTENS_KEY = "lb_recent_listens"
- RECENT_LISTENS_MAX = 100
- RECENT_LISTENS_MAX_TIME_DIFFERENCE = 300
+ RECENT_LISTENS_KEY = "lb_recent_sorted"
+ RECENT_LISTENS_MAX = 100
def __... | 1 | # coding=utf-8
import ujson
import redis
from time import time
from redis import Redis
from listenbrainz.listen import Listen
from listenbrainz.listenstore import ListenStore
class RedisListenStore(ListenStore):
RECENT_LISTENS_KEY = "lb_recent_listens"
RECENT_LISTENS_MAX = 100
RECENT_LISTENS_MAX_TIME_DI... | 1 | 15,245 | I changed the name of the key, to make deployment easier. | metabrainz-listenbrainz-server | py |
@@ -545,6 +545,7 @@ func environmentConfig() (Config, error) {
NvidiaRuntime: os.Getenv("ECS_NVIDIA_RUNTIME"),
TaskMetadataAZDisabled: utils.ParseBool(os.Getenv("ECS_DISABLE_TASK_METADATA_AZ"), false),
CgroupCPUPeriod: parseCgroupCPUPeriod(),
+ SpotInstan... | 1 | // Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license... | 1 | 23,241 | isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false. | aws-amazon-ecs-agent | go |
@@ -3,6 +3,8 @@ Provides Dimension objects for tracking the properties of a value,
axis or map dimension. Also supplies the Dimensioned abstract
baseclass for classes that accept Dimension values.
"""
+from __future__ import unicode_literals
+
import re
from operator import itemgetter
| 1 | """
Provides Dimension objects for tracking the properties of a value,
axis or map dimension. Also supplies the Dimensioned abstract
baseclass for classes that accept Dimension values.
"""
import re
from operator import itemgetter
try:
from cyordereddict import OrderedDict
except:
from collections import Order... | 1 | 13,968 | Do you think we might need this anywhere else in HoloViews? | holoviz-holoviews | py |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.