patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -3,7 +3,9 @@ export function getDisplayPlayMethod(session) {
return null;
}
- if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
+ if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect && session.TranscodingInfo.IsAudioDirect) {
+ return 'Remux';
+ ... | 1 | export function getDisplayPlayMethod(session) {
if (!session.NowPlayingItem) {
return null;
}
if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
return 'DirectStream';
} else if (session.PlayState.PlayMethod === 'Transcode') {
return 'Transcode';
} else ... | 1 | 18,070 | @MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case. | jellyfin-jellyfin-web | js |
@@ -36,7 +36,7 @@ module Asciidoctor
opts_parser = OptionParser.new do |opts|
opts.banner = <<-EOS
Usage: asciidoctor [OPTION]... [FILE]
-Translate the AsciiDoc source FILE into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
+Translate the AsciiDoc source FILE, or multiple FILE(s) into... | 1 | require 'optparse'
module Asciidoctor
module Cli
# Public: List of options that can be specified on the command line
class Options < Hash
def initialize(options = {})
self[:attributes] = options[:attributes] || {}
self[:input_file] = options[:input_file] || nil
self[:output_fi... | 1 | 4,491 | I have followed the convention of `cp` | asciidoctor-asciidoctor | rb |
@@ -8390,11 +8390,11 @@ return [
'mysql_xdevapi\tableupdate::where' => ['mysql_xdevapi\TableUpdate', 'where_expr'=>'string'],
'mysqli::__construct' => ['void', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null']... | 1 | <?php // phpcs:ignoreFile
namespace Phan\Language\Internal;
/**
* CURRENT PHP TARGET VERSION: 8.1
* The version above has to match Psalm\Internal\Codebase\InternalCallMapHandler::PHP_(MAJOR|MINOR)_VERSION
*
* Format
*
* '<function_name>' => ['<return_type>, '<arg_name>'=>'<arg_type>']
* alternative signature fo... | 1 | 11,768 | The docs say it's `false|null` | vimeo-psalm | php |
@@ -130,9 +130,14 @@ func (c *localCircuitBreaker) checkAndSet() {
// Config represents the configuration of a circuit breaker.
type Config struct {
+ // The threshold over sliding window that would trip the circuit breaker
Threshold float64 `json:"threshold"`
- Type string `json:"type"`
- TripTime string ... | 1 | // Copyright 2015 Matthew Holt and The Caddy Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicab... | 1 | 14,061 | Thinking on it more, I actually really like your idea to rename `type` to `factor`. | caddyserver-caddy | go |
@@ -45,7 +45,11 @@ public class MessageWebView extends WebView {
* will network images that are already in the WebView cache.
*
*/
- getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
+ try {
+ getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
+ ... | 1 | package com.fsck.k9.view;
import android.content.Context;
import android.content.pm.PackageManager;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import android.util.AttributeSet;
import timber.log.Timber;
import android.view.KeyEvent;
import android.webkit.WebSettings;
import android.webki... | 1 | 18,833 | This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I... | k9mail-k-9 | java |
@@ -1,11 +1,9 @@
-# -*- coding: UTF-8 -*-
-#shlobj.py
-#A part of NonVisual Desktop Access (NVDA)
-#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
-#This file is covered by the GNU General Public License.
-#See the file COPYING for more details.
+# A part of NonVisual Desktop Access (NVDA)
+# Copyright (C) 200... | 1 | # -*- coding: UTF-8 -*-
#shlobj.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
"""
This module wraps the SHGetFolderPath function in shell32.dll and defines t... | 1 | 34,139 | Feel free to add your own name while at it. | nvaccess-nvda | py |
@@ -30,11 +30,11 @@ import (
)
var (
- alias string
bytecode []byte
gasLimit uint64
gasPrice int64
nonce uint64
+ signer string
)
// ActionCmd represents the account command | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 16,141 | `signer` is a global variable (from `gochecknoglobals`) | iotexproject-iotex-core | go |
@@ -74,8 +74,12 @@ module Mongoid
# @return [ String ] The normalized key.
#
# @since 1.0.0
- def normalized_key(name, serializer)
- serializer && serializer.localized? ? "#{name}.#{::I18n.locale}" : name
+ def normalized_key(name, serializer, opts = {})
+ if s... | 1 | # encoding: utf-8
module Mongoid
class Criteria
module Queryable
# This is a smart hash for use with options and selectors.
class Smash < Hash
# @attribute [r] aliases The aliases.
# @attribute [r] serializers The serializers.
attr_reader :aliases, :serializers
# Per... | 1 | 11,417 | shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?) | mongodb-mongoid | rb |
@@ -17,6 +17,7 @@ from .number_types import (UOffsetTFlags, SOffsetTFlags, VOffsetTFlags)
from . import encode
from . import packer
+import pickle
from . import compat
from .compat import range_func | 1 | # Copyright 2014 Google Inc. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or a... | 1 | 13,371 | This can also be removed. | google-flatbuffers | java |
@@ -32,7 +32,8 @@ SYNOPSIS
const char *key);
int flux_kvs_txn_symlink (flux_kvs_txn_t *txn, int flags,
- const char *key, const char *target);
+ const char *key, const char *ns,
+ const char *target);
int fl... | 1 | flux_kvs_txn_create(3)
======================
:doctype: manpage
NAME
----
flux_kvs_txn_create, flux_kvs_txn_destroy, flux_kvs_txn_put, flux_kvs_txn_pack, flux_kvs_txn_vpack, flux_kvs_txn_mkdir, flux_kvs_txn_unlink, flux_kvs_txn_symlink, flux_kvs_txn_put_raw, flux_kvs_txn_put_treeobj - operate on a KVS transaction obj... | 1 | 22,496 | Not critical but "common" is not that helpful in the commit title. Maybe go with "libkvs/txn:" for this one? | flux-framework-flux-core | c |
@@ -277,6 +277,7 @@ class YamlConfig(QObject):
self._mark_changed()
self._migrate_bool(settings, 'tabs.favicons.show', 'always', 'never')
+ self._migrate_bool(settings, 'scrolling.bar', 'when_searching', 'never')
self._migrate_bool(settings, 'qt.force_software_rendering',
... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2018 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 22,144 | It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new ... | qutebrowser-qutebrowser | py |
@@ -27,7 +27,7 @@ class RRDReader(BaseReader):
def _convert_fs_path(fs_path):
if isinstance(fs_path, six.text_type):
fs_path = fs_path.encode(sys.getfilesystemencoding())
- return os.path.realpath(fs_path)
+ return os.path.realpath(fs_path).decode("utf-8")
def __init__(se... | 1 | import sys
import os
import time
import six
# Use the built-in version of scandir/stat if possible, otherwise
# use the scandir module version
try:
from os import scandir, stat # noqa # pylint: disable=unused-import
except ImportError:
from scandir import scandir, stat # noqa # pylint: disable=unused-import
... | 1 | 12,541 | .decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes.. | graphite-project-graphite-web | py |
@@ -0,0 +1,9 @@
+using System;
+
+namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+{
+ public interface IHttpHeadersHandler
+ {
+ void OnHeader(Span<byte> name, Span<byte> value);
+ }
+} | 1 | 1 | 11,713 | An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill. | aspnet-KestrelHttpServer | .cs | |
@@ -51,15 +51,10 @@ namespace NLog
private const int StackTraceSkipMethods = 0;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Naming", "CA2204:Literals should be spelled correctly", Justification = "Using 'NLog' in message.")]
- internal static void Write([NotNull] Type loggerTy... | 1 | //
// Copyright (c) 2004-2019 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 18,979 | Resharper annotations, always +1 | NLog-NLog | .cs |
@@ -46,6 +46,8 @@ var accountCreateAddCmd = &cobra.Command{
func init() {
accountCreateAddCmd.Flags().BoolVar(&CryptoSm2, "sm2", false,
config.TranslateInLang(flagSm2Usage, config.UILanguage))
+ accountCreateAddCmd.Flags().MarkHidden("sm2")
+
}
func accountCreateAdd(args []string) error { | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 21,370 | same here, CryptoSm2 won't be changed once command is compiled | iotexproject-iotex-core | go |
@@ -655,6 +655,13 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
try {
certChain = KeyChain.getCertificateChain(activity, alias);
key = KeyChain.getPrivateKey(activity, alias);
+ activity.runOnUiThread(new Runnable() {
+
+ @Override
+ public void run() {... | 1 | /*
* Copyright (c) 2011-2015, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright notice,... | 1 | 14,581 | Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -52,7 +52,7 @@ func (v *ConfigValidator) Validate(config *configs.Config) error {
}
for _, c := range warns {
if err := c(config); err != nil {
- logrus.WithError(err).Warnf("invalid configuration")
+ logrus.WithError(err).Warn("invalid configuration")
}
}
return nil | 1 | package validate
import (
"errors"
"fmt"
"os"
"path/filepath"
"strings"
"sync"
"github.com/opencontainers/runc/libcontainer/cgroups"
"github.com/opencontainers/runc/libcontainer/configs"
"github.com/opencontainers/runc/libcontainer/intelrdt"
selinux "github.com/opencontainers/selinux/go-selinux"
"github.co... | 1 | 24,661 | Technically it doesn't belong here; let me remove it. | opencontainers-runc | go |
@@ -78,7 +78,7 @@ MARKER_FILE_LIGHT_VERSION = "%s/.light-version" % dirs.static_libs
IMAGE_NAME_SFN_LOCAL = "amazon/aws-stepfunctions-local"
ARTIFACTS_REPO = "https://github.com/localstack/localstack-artifacts"
SFN_PATCH_URL_PREFIX = (
- f"{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunction... | 1 | #!/usr/bin/env python
import functools
import glob
import logging
import os
import platform
import re
import shutil
import stat
import sys
import tempfile
import time
from pathlib import Path
from typing import Callable, Dict, List, Tuple
import requests
from plugin import Plugin, PluginManager
from localstack import... | 1 | 14,412 | remember to update the hash once the upstream PR is merged | localstack-localstack | py |
@@ -45,10 +45,8 @@ public class SFDCFcmListenerService extends FirebaseMessagingService {
@Override
public void onMessageReceived(RemoteMessage message) {
if (message != null && SalesforceSDKManager.hasInstance()) {
- final PushNotificationInterface pnInterface = SalesforceSDKManager.getIn... | 1 | /*
* Copyright (c) 2018-present, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright noti... | 1 | 17,620 | Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -317,10 +317,15 @@ func (ctx *invocationContext) Send(toAddr address.Address, methodNum abi.MethodN
}
}()
+ // DRAGONS: remove these once specs actors project enforces Send params
// replace nil params with empty value
if params == nil {
params = &adt_spec.EmptyValue{}
}
+ // replace non pointer with... | 1 | package vmcontext
import (
"bytes"
"encoding/binary"
"fmt"
"runtime/debug"
"github.com/filecoin-project/go-address"
"github.com/filecoin-project/specs-actors/actors/abi"
"github.com/filecoin-project/specs-actors/actors/abi/big"
"github.com/filecoin-project/specs-actors/actors/builtin"
init_ "github.com/filec... | 1 | 23,207 | FYI This will go the other way, with nil being the correct value for "no params" | filecoin-project-venus | go |
@@ -162,8 +162,10 @@ namespace pwiz.Skyline.Model.Lib
var thatPeptideKey = thatItem.LibraryKey as PeptideLibraryKey;
if (thatPeptideKey == null)
{
- result.Add(thatItem.LibraryKey);
- nonPeptideKeySet.Add(thatItem.LibraryKey);
+ ... | 1 | /*
* Original author: Nicholas Shulman <nicksh .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2017 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in comp... | 1 | 12,582 | Is this necessary? Are there duplicates in your LibKeyIndex? | ProteoWizard-pwiz | .cs |
@@ -35,6 +35,7 @@ func (m *MockActionIterator) EXPECT() *MockActionIteratorMockRecorder {
// Next mocks base method
func (m *MockActionIterator) Next() (action.SealedEnvelope, bool) {
+ m.ctrl.T.Helper()
ret := m.ctrl.Call(m, "Next")
ret0, _ := ret[0].(action.SealedEnvelope)
ret1, _ := ret[1].(bool) | 1 | // Code generated by MockGen. DO NOT EDIT.
// Source: ./actpool/actioniterator/actioniterator.go
// Package mock_actioniterator is a generated GoMock package.
package mock_actioniterator
import (
gomock "github.com/golang/mock/gomock"
action "github.com/iotexproject/iotex-core/action"
reflect "reflect"
)
// MockA... | 1 | 15,373 | Why will the gomock files be regenerated? It seems to be irrelevant | iotexproject-iotex-core | go |
@@ -97,6 +97,7 @@ func newPlanner(
pipedConfig: pipedConfig,
plannerRegistry: registry.DefaultRegistry(),
appManifestsCache: appManifestsCache,
+ cancelledCh: make(chan *model.ReportableCommand, 1),
nowFunc: time.Now,
logger: l... | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 11,032 | I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity? | pipe-cd-pipe | go |
@@ -14,7 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
#
-from helpers import LuigiTestCase
+from helpers import LuigiTestCase, RunOnceTask
import luigi
import luigi.task | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2016 VNG Corporation
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 16,453 | It seems like you accidentally pulled some unrelated changes to util_test into this. | spotify-luigi | py |
@@ -15,6 +15,7 @@
// along with the Nethermind. If not, see <http://www.gnu.org/licenses/>.
using Nethermind.Blockchain;
+using Nethermind.Blockchain.Bloom;
using Nethermind.Blockchain.Filters;
using Nethermind.Blockchain.Receipts;
using Nethermind.Blockchain.TxPools; | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,301 | do not toucm NDM please - there will be lots of conflicts | NethermindEth-nethermind | .cs |
@@ -357,7 +357,7 @@ class XLSXWriter extends TextResponseWriter {
if (v instanceof IndexableField) {
IndexableField f = (IndexableField)v;
if (v instanceof Date) {
- output.append(((Date) val).toInstant().toString() + "; ");
+ output.append(((Date) v).toInstant().toString() + ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 26,290 | This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild? | apache-lucene-solr | java |
@@ -48,6 +48,8 @@ class Testinfra(base.Base):
name: testinfra
options:
n: 1
+ v: True
+ setup-show: True
The testing can be disabled by setting `enabled` to False.
| 1 | # Copyright (c) 2015-2017 Cisco Systems, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to
# deal in the Software without restriction, including without limitation the
# rights to use, copy, modify, merge... | 1 | 7,241 | This looks out of scope for this particular PR. | ansible-community-molecule | py |
@@ -39,6 +39,14 @@ import (
// Warning when user configures leafnode TLS insecure
const leafnodeTLSInsecureWarning = "TLS certificate chain and hostname of solicited leafnodes will not be verified. DO NOT USE IN PRODUCTION!"
+const (
+ leafDefaultFirstPingInterval = int64(time.Second)
+)
+
+var (
+ leafFirstPingInt... | 1 | // Copyright 2019 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in wr... | 1 | 9,319 | Don't need () if only one. | nats-io-nats-server | go |
@@ -26,6 +26,7 @@ public class AbstractMailer {
private boolean usesAuth;
private String mailHost;
+ private String mailPort;
private String mailUser;
private String mailPassword;
private String mailSender; | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 10,116 | Why not have mailPort as int since your are already parsing while calling t.connect ? | azkaban-azkaban | java |
@@ -38,7 +38,7 @@ with open('README.rst') as fobj:
install_requires = [
'tornado>=4.0,<5',
- 'python-daemon<3.0',
+ 'python-daemon<3.0'
]
if os.environ.get('READTHEDOCS', None) == 'True': | 1 | # Copyright (c) 2012 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may not
# use this file except in compliance with the License. You may obtain a copy of
# the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, s... | 1 | 14,357 | In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :) | spotify-luigi | py |
@@ -739,6 +739,11 @@ class SolrDefault extends AbstractBase
// Get LCCN from Index
$raw = isset($this->fields['lccn']) ? $this->fields['lccn'] : '';
+ // First call number only.
+ if (is_array($raw)) {
+ $raw = reset($raw);
+ }
+
// Remove all blanks.
... | 1 | <?php
/**
* Default model for Solr records -- used when a more specific model based on
* the recordtype field cannot be found.
*
* PHP version 5
*
* Copyright (C) Villanova University 2010.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public L... | 1 | 22,663 | Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations). | vufind-org-vufind | php |
@@ -44,6 +44,8 @@ type Config struct {
Manager Manager
Attestor Attestor
AllowUnauthenticatedVerifiers bool
+ AllowedForeignJWTClaims map[string]bool
+ TrustDomain spiffeid.TrustDomain
}
type Handler struct { | 1 | package workload
import (
"context"
"crypto"
"crypto/x509"
"encoding/json"
"errors"
"fmt"
"os"
"time"
"github.com/sirupsen/logrus"
"github.com/spiffe/go-spiffe/v2/proto/spiffe/workload"
"github.com/spiffe/go-spiffe/v2/spiffeid"
"github.com/spiffe/spire/pkg/agent/api/rpccontext"
"github.com/spiffe/spire/p... | 1 | 17,002 | i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false | spiffe-spire | go |
@@ -69,6 +69,7 @@ const (
History
Matching
Worker
+ Server
NumServices
)
| 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 13,291 | This is very unclear what Server means. We need a better name, maybe ServerExtension? | temporalio-temporal | go |
@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
out, err := system.RunCommand(DdevBin, args)
assert.NoError(err)
assert.Contains(string(out), "Server started")
- assert.Contains(string(out), "GET")
cleanup()
} | 1 | package cmd
import (
"testing"
"os"
"github.com/drud/ddev/pkg/testcommon"
"github.com/drud/drud-go/utils/system"
"github.com/stretchr/testify/assert"
)
func TestDevLogsBadArgs(t *testing.T) {
assert := assert.New(t)
testDir := testcommon.CreateTmpDir("no-valid-ddev-config")
err := os.Chdir(testDir)
if er... | 1 | 11,068 | I wonder if we should trigger a PHP error and ensure it ends up in the log? | drud-ddev | go |
@@ -232,7 +232,9 @@
* @returns {string} decoded string
*/
countlyCommon.decodeHtml = function(html) {
- return (html + "").replace(/&/g, '&');
+ var textArea = document.createElement('textarea');
+ textArea.innerHTML = html;
+ return textArea.va... | 1 | /*global store, Handlebars, CountlyHelpers, countlyGlobal, _, Gauge, d3, moment, countlyTotalUsers, jQuery, filterXSS*/
(function(window, $) {
/**
* Object with common functions to be used for multiple purposes
* @name countlyCommon
* @global
* @namespace countlyCommon
*/
var CommonCons... | 1 | 14,504 | Hmmm not sure about this. Is it fine @ar2rsawseen? | Countly-countly-server | js |
@@ -7,5 +7,5 @@ public interface Installer {
/**
* runs the installer
*/
- void run();
+ void go();
} | 1 | package org.phoenicis.scripts;
/**
* interface which must be implemented by all installers in Javascript
*/
public interface Installer {
/**
* runs the installer
*/
void run();
}
| 1 | 13,776 | Why do you prefer `go` over `run`? | PhoenicisOrg-phoenicis | java |
@@ -822,7 +822,7 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
TestRunCompleteArgs = dummyCompleteArgs
};
var runComplete = CreateMessage(MessageType.ExecutionComplete, completepayload);
-
+ ... | 1 | // Copyright (c) Microsoft. All rights reserved.
namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
{
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Linq.Expressions;
using System.Threading;
using System.Threading.Task... | 1 | 11,255 | Unintentional, please remove | microsoft-vstest | .cs |
@@ -18,6 +18,10 @@ class Subscription < ActiveRecord::Base
after_create :add_user_to_mailing_list
after_create :add_user_to_github_team
+ def self.active
+ where(deactivated_on: nil)
+ end
+
def self.deliver_welcome_emails
recent.each do |subscription|
subscription.deliver_welcome_email | 1 | # This class represents a user's subscription to Learn content
class Subscription < ActiveRecord::Base
MAILING_LIST = 'Active Subscribers'
GITHUB_TEAM = 516450
belongs_to :user
belongs_to :plan, polymorphic: true
belongs_to :team
delegate :includes_mentor?, to: :plan
delegate :includes_workshops?, to: :... | 1 | 8,701 | What was the reason behind moving this? | thoughtbot-upcase | rb |
@@ -1,12 +1,8 @@
-<%= t "user_mailer.gpx_notification.your_gpx_file" %>
-<strong><%= @trace_name %></strong>
-<%= t "user_mailer.gpx_notification.with_description" %>
-<em><%= @trace_description %></em>
-<% if @trace_tags.length>0 %>
- <%= t "user_mailer.gpx_notification.and_the_tags" %>
- <em><% @trace_tags.each do ... | 1 | <%= t "user_mailer.gpx_notification.your_gpx_file" %>
<strong><%= @trace_name %></strong>
<%= t "user_mailer.gpx_notification.with_description" %>
<em><%= @trace_description %></em>
<% if @trace_tags.length>0 %>
<%= t "user_mailer.gpx_notification.and_the_tags" %>
<em><% @trace_tags.each do |tag| %>
<%= tag.tag... | 1 | 13,098 | Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect> | openstreetmap-openstreetmap-website | rb |
@@ -72,6 +72,14 @@ class Realm {
*/
get isInTransaction() {}
+ /**
+ * Indicated is this Realm is closed.
+ * @type {boolean}
+ * @readonly
+ * @since 2.1.0
+ */
+ get isClosed() {}
+
/**
* Gets the sync session if this is a synced Realm
* @type {Session} | 1 | ////////////////////////////////////////////////////////////////////////////
//
// Copyright 2016 Realm Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/li... | 1 | 16,814 | `Indicates if this Realm has been closed.`? | realm-realm-js | js |
@@ -55,7 +55,6 @@ class _MissingPandasLikeSeries(object):
compress = unsupported_function('compress')
convert_objects = unsupported_function('convert_objects')
copy = unsupported_function('copy')
- corr = unsupported_function('corr')
cov = unsupported_function('cov')
cummax = unsupported_fun... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 8,500 | how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series? | databricks-koalas | py |
@@ -168,11 +168,11 @@ func (syncer *DefaultSyncer) tipSetState(ctx context.Context, tsKey types.Sorted
if !syncer.chainStore.HasTipSetAndState(ctx, tsKey.String()) {
return nil, errors.Wrap(ErrUnexpectedStoreState, "parent tipset must be in the store")
}
- tsas, err := syncer.chainStore.GetTipSetAndState(tsKey)
... | 1 | package chain
import (
"context"
"sync"
"time"
"github.com/ipfs/go-cid"
"github.com/ipfs/go-hamt-ipld"
logging "github.com/ipfs/go-log"
"github.com/pkg/errors"
"go.opencensus.io/trace"
"github.com/filecoin-project/go-filecoin/actor/builtin"
"github.com/filecoin-project/go-filecoin/consensus"
"github.com/f... | 1 | 19,124 | Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552. | filecoin-project-venus | go |
@@ -11,11 +11,15 @@ using MicroBenchmarks;
namespace System.Collections
{
[BenchmarkCategory(Categories.CoreCLR, Categories.Collections, Categories.GenericCollections)]
- [GenericTypeArguments(typeof(int))] // value type
- [GenericTypeArguments(typeof(string))] // reference type
+ [GenericTypeArguments(... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System.Collections.Generic;
using System.Linq;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Extens... | 1 | 9,044 | @billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types. | dotnet-performance | .cs |
@@ -31,7 +31,6 @@ from qutebrowser.config import config
class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
-
"""The commandline part of the statusbar.
Attributes: | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 20,413 | Unrelated whitespace change. | qutebrowser-qutebrowser | py |
@@ -133,8 +133,18 @@ bool rai::wallet_store::valid_password (MDB_txn * transaction_a)
return ok;
}
-bool rai::wallet_store::attempt_password (MDB_txn * transaction_a, std::string const & password_a)
+bool rai::wallet_store::attempt_password (rai::transaction * transaction_p, std::string const & password_a)
{
+ st... | 1 | #include <rai/node/wallet.hpp>
#include <rai/lib/interface.h>
#include <rai/node/node.hpp>
#include <rai/node/xorshift.hpp>
#include <argon2.h>
#include <boost/filesystem.hpp>
#include <boost/property_tree/json_parser.hpp>
#include <boost/property_tree/ptree.hpp>
#include <future>
#include <ed25519-donna/ed25519.h... | 1 | 14,062 | Slight formatting issue here. There should be a space after the asterisk. | nanocurrency-nano-node | cpp |
@@ -8,7 +8,8 @@
*/
axe.utils.isHidden = function isHidden(el, recursed) {
'use strict';
- var parent;
+ const node = axe.utils.getNodeFromTree(el);
+ let parent, isHidden;
// 9 === Node.DOCUMENT
if (el.nodeType === 9) { | 1 | /**
* Determine whether an element is visible
* @method isHidden
* @memberof axe.utils
* @param {HTMLElement} el The HTMLElement
* @param {Boolean} recursed
* @return {Boolean} The element's visibilty status
*/
axe.utils.isHidden = function isHidden(el, recursed) {
'use strict';
var parent;
// 9 === Node.DOC... | 1 | 14,392 | Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these. | dequelabs-axe-core | js |
@@ -32,9 +32,9 @@ import org.slf4j.LoggerFactory;
* @since [产品/模块版本]
*/
public class TestMgr {
- private static Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
+ private static final Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
- private static List<Throwable> errorList = new ArrayLi... | 1 | /*
* Copyright 2017 Huawei Technologies Co., Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable l... | 1 | 6,322 | this is a duplicate file of the one in demo-schema. please remove this file. | apache-servicecomb-java-chassis | java |
@@ -153,6 +153,7 @@ var (
utils.Eth1SyncServiceEnable,
utils.Eth1CanonicalTransactionChainDeployHeightFlag,
utils.Eth1L1CrossDomainMessengerAddressFlag,
+ utils.Eth1L1FeeWalletAddressFlag,
utils.Eth1ETHGatewayAddressFlag,
utils.Eth1ChainIdFlag,
utils.RollupClientHttpFlag, | 1 | // Copyright 2014 The go-ethereum Authors
// This file is part of go-ethereum.
//
// go-ethereum is free software: you can redistribute it and/or modify
// it under the terms of the GNU General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any la... | 1 | 17,657 | Nit: unified names between geth and contracts | ethereum-optimism-optimism | go |
@@ -42,7 +42,9 @@ func TestClientToServerCommunication(t *testing.T) {
// Note that the ordering of things here is pretty important; we need to get the
// client connected & ready to receive events before we push them all into the
// server and shut it down again.
- serverState := core.NewBuildState(5, nil, 4, co... | 1 | // Integration tests between the gRPC event server & client.
//
// It's a little limited in how much it can test due to extensive synchronisation
// issues (discussed ina little more detail below); essentially the scheme is designed
// for clients following a series of events in "human" time (i.e. a stream that runs
/... | 1 | 8,869 | Necessary? Could you just use DefaultBuildState here? | thought-machine-please | go |
@@ -22,7 +22,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collections;
import java.util.Date;
-import java.util.HashMap;
+import java.util.LinkedHashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Map; | 1 |
package org.twitter.zipkin.storage.cassandra;
import com.datastax.driver.core.BoundStatement;
import com.datastax.driver.core.Cluster;
import com.datastax.driver.core.KeyspaceMetadata;
import com.datastax.driver.core.PreparedStatement;
import com.datastax.driver.core.Row;
import com.datastax.driver.core.Session;
impo... | 1 | 10,324 | linked hashmap retains order | openzipkin-zipkin | java |
@@ -20,12 +20,12 @@
#include <wlr/render/matrix.h>
#include <wlr/render/gles2.h>
#include <wlr/render.h>
-#include "backend/drm.h"
-#include "backend/drm-util.h"
+#include "backend/drm/drm.h"
+#include "backend/drm/util.h"
bool wlr_drm_check_features(struct wlr_drm_backend *backend) {
- extern const struct wlr_dr... | 1 | #include <assert.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <inttypes.h>
#include <errno.h>
#include <time.h>
#include <xf86drm.h>
#include <xf86drmMode.h>
#include <drm_mode.h>
#include <EGL/egl.h>
#include <EGL/eglext.h>
#include <gbm.h>
#include <GLES2/gl2.h>
#include <GLES2/gl2ext.h>
#in... | 1 | 8,149 | And the old names for these variables made more sense imo. | swaywm-wlroots | c |
@@ -473,7 +473,7 @@ func GetAdditionalGroups(additionalGroups []string, group io.Reader) ([]int, err
return nil, fmt.Errorf("Unable to find group %s", ag)
}
// Ensure gid is inside gid range.
- if gid < minId || gid > maxId {
+ if gid < minId || gid >= maxId {
return nil, ErrRange
}
gidMap... | 1 | package user
import (
"bufio"
"fmt"
"io"
"os"
"os/user"
"strconv"
"strings"
)
const (
minId = 0
maxId = 1<<31 - 1 //for 32-bit systems compatibility
)
var (
ErrRange = fmt.Errorf("uids and gids must be in range %d-%d", minId, maxId)
)
type User struct {
Name string
Pass string
Uid int
Gid int
G... | 1 | 16,526 | Are you sure this change is correct? | opencontainers-runc | go |
@@ -9,8 +9,7 @@ def test_view_image():
"mitmproxy/data/image.png",
"mitmproxy/data/image.gif",
"mitmproxy/data/all.jpeg",
- # https://bugs.python.org/issue21574
- # "mitmproxy/data/image.ico",
+ "mitmproxy/data/image.ico",
]:
with open(tutils.test_data.path(... | 1 | from mitmproxy.contentviews import image
from mitmproxy.test import tutils
from .. import full_eval
def test_view_image():
v = full_eval(image.ViewImage())
for img in [
"mitmproxy/data/image.png",
"mitmproxy/data/image.gif",
"mitmproxy/data/all.jpeg",
# https://bugs.python.org/... | 1 | 13,343 | The previously linked bug does not apply anymore? If so, this is LGTM! | mitmproxy-mitmproxy | py |
@@ -84,7 +84,7 @@ func assertNotEqual(t *testing.T, a interface{}, b interface{}) {
}
}
-func TestFailOver(t *testing.T) {
+func Test_FailOver(t *testing.T) {
tmpDir, err := ioutil.TempDir("", "lb-test")
if err != nil {
assertEqual(t, err, nil) | 1 | package loadbalancer
import (
"bufio"
"context"
"errors"
"fmt"
"io/ioutil"
"net"
"net/url"
"os"
"strings"
"testing"
"time"
"github.com/rancher/k3s/pkg/cli/cmds"
)
type server struct {
listener net.Listener
conns []net.Conn
prefix string
}
func createServer(prefix string) (*server, error) {
list... | 1 | 9,896 | Why are we renaming all of the tests? | k3s-io-k3s | go |
@@ -24,8 +24,9 @@ import (
var defaultRFC2136Port = "53"
-// This function make a valid nameserver as per RFC2136
+// This function returns a valid nameserver (in the form <host>:<port>) for the RFC2136 provider
func ValidNameserver(nameserver string) (string, error) {
+ nameserver = strings.TrimSpace(nameserver)... | 1 | /*
Copyright 2019 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 20,768 | Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here? | jetstack-cert-manager | go |
@@ -142,9 +142,15 @@ PyObject *GetMolConformers(ROMol &mol) {
template <class T>
T MolGetProp(const ROMol &mol, const char *key) {
T res;
- if (!mol.getPropIfPresent(key, res)) {
- PyErr_SetString(PyExc_KeyError, key);
- throw python::error_already_set();
+ try {
+ if (!mol.getPropIfPresent(key, res)) {... | 1 | // $Id$
//
// Copyright (C) 2003-2009 Greg Landrum and Rational Discovery LLC
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#define NO_I... | 1 | 14,447 | Why not also replace this one with calls to `GetProp<ROMol,T>`? | rdkit-rdkit | cpp |
@@ -259,6 +259,7 @@ class KNNClassifier(object):
if doWinners:
if (self.numWinners>0) and (self.numWinners < (inputPattern > 0).sum()):
sparseInput = numpy.zeros(inputPattern.shape)
+
# Don't consider strongly negative numbers as winners.
sorted = inputPattern.argsort()[0:... | 1 | #!/usr/bin/env python
# ----------------------------------------------------------------------
# Numenta Platform for Intelligent Computing (NuPIC)
# Copyright (C) 2013-15, Numenta, Inc. Unless you have an agreement
# with Numenta, Inc., for a separate license for this software code, the
# following terms and conditio... | 1 | 20,430 | Still need to remove trailing spaces on this line | numenta-nupic | py |
@@ -0,0 +1,19 @@
+/*
+ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
+ */
+
+package net.sourceforge.pmd.lang.apex.ast;
+
+import apex.jorje.semantic.ast.AstNode;
+
+/**
+ * Interface for nodes that can contain comments. Because comments are for the most part lost, the tree builder only... | 1 | 1 | 19,099 | Please use the `@Experimental` annotation on this | pmd-pmd | java | |
@@ -77,7 +77,7 @@ func (s *LimitedReaderSlurper) Read(reader io.Reader) error {
// if we received err == nil and n == 0, we should retry calling the Read function.
continue
default:
- // if we recieved a non-io.EOF error, return it.
+ // if we received a non-io.EOF error, return it.
retur... | 1 | // Copyright (C) 2019-2021 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 42,226 | I found ~10 more instances of this typo. we can fix those in subsequent PRs. | algorand-go-algorand | go |
@@ -49,7 +49,7 @@ type InitRes struct {
// it returns a result object that contains useful artifacts for later use.
// Unlike sharedmain.Main, Init is meant to be run as a helper function in any main
// functions, while sharedmain.Main runs controllers with predefined method signatures.
-func Init(component string, ... | 1 | /*
Copyright 2020 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 14,702 | How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace("trigger")) | google-knative-gcp | go |
@@ -163,6 +163,8 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel("handlePage"))));
builder.pageVarName(
symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name(), "page"))));
+ bu... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 20,432 | Just checking: no need for case manipulation? | googleapis-gapic-generator | java |
@@ -94,7 +94,7 @@ public class GrpcMetadataGeneratorTool {
private static void generate(
String descriptorSet,
- String[] apiConfigs,
+ String[] configs,
String inputDir,
String outputDir,
String languageString, | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 22,017 | Same as above, not that descriptive | googleapis-gapic-generator | java |
@@ -5494,10 +5494,12 @@ emit_special_ibl_xfer(dcontext_t *dcontext, byte *pc, generated_code_t *code, ui
reg_id_t stub_reg = IF_AARCH64_ELSE(SCRATCH_REG0, SCRATCH_REG1);
ushort stub_slot = IF_AARCH64_ELSE(TLS_REG0_SLOT, TLS_REG1_SLOT);
IF_X86(size_t len;)
- byte *ibl_tgt = special_ibl_xfer_tgt(dcontex... | 1 | /* **********************************************************
* Copyright (c) 2010-2021 Google, Inc. All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 22,933 | > i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error. | DynamoRIO-dynamorio | c |
@@ -668,6 +668,8 @@ int flb_start(flb_ctx_t *ctx)
fd = event->fd;
bytes = flb_pipe_r(fd, &val, sizeof(uint64_t));
if (bytes <= 0) {
+ pthread_cancel(tid);
+ pthread_join(tid, NULL);
ctx->status = FLB_LIB_ERROR;
return -1;
} | 1 | /* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/* Fluent Bit Demo
* ===============
* Copyright (C) 2019-2021 The Fluent Bit Authors
* Copyright (C) 2015-2018 Treasure Data Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file ex... | 1 | 15,106 | Should we need to invoke pthread_cancel ? | fluent-fluent-bit | c |
@@ -122,7 +122,8 @@ public class ZMSResources {
public Domain postUserDomain(@PathParam("name") String name, @HeaderParam("Y-Audit-Ref") String auditRef, UserDomain detail) {
try {
ResourceContext context = this.delegate.newResourceContext(this.request, this.response);
- context.au... | 1 | //
// This file generated by rdl 1.4.12. Do not modify!
//
package com.yahoo.athenz.zms;
import com.yahoo.rdl.*;
import java.util.*;
import javax.ws.rs.*;
import javax.ws.rs.core.*;
import javax.servlet.http.HttpServletRequest;
import javax.servlet.http.HttpServletResponse;
import javax.inject.Inject;
@Path("/v1")
pu... | 1 | 4,290 | this is auto generated file so no changes are allowed here | AthenZ-athenz | java |
@@ -0,0 +1,13 @@
+if (
+ node.querySelector(
+ 'input[type="submit"]:not([disabled]), img[type="submit"]:not([disabled]), button[type="submit"]:not([disabled])'
+ )
+) {
+ return true;
+}
+
+if (!node.querySelectorAll(':not(textarea)').length) {
+ return false;
+}
+
+return undefined; | 1 | 1 | 13,247 | All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`. | dequelabs-axe-core | js | |
@@ -38,7 +38,7 @@ module Travis
def perl_version
# this check is needed because safe_yaml parses the string 5.10 to 5.1
- config[:perl] == 5.1 ? "5.10" : config[:perl]
+ config[:perl] == 5.1 ? "5.10" : config[:perl] == 5.2 ? "5.20" : config[:perl]
end
end
end | 1 | module Travis
module Build
class Script
class Perl < Script
DEFAULTS = {
perl: '5.14'
}
def cache_slug
super << "--perl-" << config[:perl].to_s
end
def export
super
set 'TRAVIS_PERL_VERSION', perl_version, echo: false
... | 1 | 11,780 | can you please make this multi line, this version is hard to read. | travis-ci-travis-build | rb |
@@ -128,7 +128,7 @@ Blockly.HorizontalFlyout.prototype.setMetrics_ = function(xyRatio) {
return;
}
- if (goog.isNumber(xyRatio.x)) {
+ if (typeof xyRatio.x === 'number') {
this.workspace_.scrollX = -metrics.contentWidth * xyRatio.x;
}
| 1 | /**
* @license
* Visual Blocks Editor
*
* Copyright 2011 Google Inc.
* https://developers.google.com/blockly/
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apach... | 1 | 9,997 | For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them. | LLK-scratch-blocks | js |
@@ -11,6 +11,10 @@ FactoryGirl.define do
project_title "NCR Name"
association :proposal, flow: 'linear'
+ trait :with_approver do
+ association :proposal, :with_approver, flow: 'linear'
+ end
+
trait :with_approvers do
association :proposal, :with_approvers, flow: 'linear'
end | 1 | FactoryGirl.define do
factory :ncr_work_order, class: Ncr::WorkOrder do
amount 1000
expense_type "BA61"
vendor "Some Vend"
not_to_exceed false
building_number Ncr::BUILDING_NUMBERS[0]
emergency false
rwa_number "R1234567" # TODO remove, since it's not applicable for BA61
org_code Ncr::... | 1 | 13,565 | Work Orders would never have only one approver, right? | 18F-C2 | rb |
@@ -0,0 +1,17 @@
+package com.codahale.metrics.collectd;
+
+enum DataType {
+
+ COUNTER(0), GAUGE(1);
+
+ private final int code;
+
+ private DataType(int code) {
+ this.code = code;
+ }
+
+ public int getCode() {
+ return code;
+ }
+
+} | 1 | 1 | 7,031 | `code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime. | dropwizard-metrics | java | |
@@ -163,9 +163,11 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
{
title: __( 'Earnings', 'google-site-kit' ),
tooltip: __( 'Earnings', 'google-site-kit' ),
- Component: ( { row } ) => numFmt(
- row.metrics[ 0 ].values[ 0 ],
- currencyFormat,
+ field: 'metrics.0... | 1 | /**
* DashboardTopEarningPagesWidget component.
*
* Site Kit by Google, Copyright 2021 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licen... | 1 | 39,604 | This is the only "extra" change here. | google-site-kit-wp | js |
@@ -36,14 +36,15 @@ type SignedMessageValidator interface {
}
type defaultMessageValidator struct {
- allowHighNonce bool
+ allowHighNonce bool
+ bypassBLSSignatureCheck bool
}
// NewDefaultMessageValidator creates a new default validator.
// A default validator checks for both permanent semantic prob... | 1 | package consensus
import (
"context"
"math/big"
"github.com/filecoin-project/go-filecoin/actor"
"github.com/filecoin-project/go-filecoin/actor/builtin/account"
"github.com/filecoin-project/go-filecoin/address"
"github.com/filecoin-project/go-filecoin/config"
"github.com/filecoin-project/go-filecoin/metrics"
"... | 1 | 21,813 | Please TODO and link to an issue for changing this. | filecoin-project-venus | go |
@@ -1,9 +1,10 @@
+/* eslint-disable comma-dangle */
const en_US = {}
en_US.strings = {
addBulkFilesFailed: {
'0': 'Failed to add %{smart_count} file due to an internal error',
- '1': 'Failed to add %{smart_count} files due to internal errors',
+ '1': 'Failed to add %{smart_count} files due to internal... | 1 | const en_US = {}
en_US.strings = {
addBulkFilesFailed: {
'0': 'Failed to add %{smart_count} file due to an internal error',
'1': 'Failed to add %{smart_count} files due to internal errors',
},
addingMoreFiles: 'Adding more files',
addMore: 'Add more',
addMoreFiles: 'Add more files',
allFilesFromFol... | 1 | 14,813 | Can we make the script output trailing commas? | transloadit-uppy | js |
@@ -0,0 +1,10 @@
+exports.featureFlags = {
+ widgets: {
+ dashboard: {
+ enabled: 'development',
+ },
+ pageDashboard: {
+ enabled: 'development',
+ },
+ },
+}; | 1 | 1 | 30,313 | This file should get a file header | google-site-kit-wp | js | |
@@ -7,7 +7,6 @@
#include "base/Base.h"
#include "kvstore/wal/FileBasedWal.h"
#include "kvstore/wal/FileBasedWalIterator.h"
-#include "kvstore/wal/BufferFlusher.h"
#include "fs/FileUtils.h"
#include "time/WallClock.h"
| 1 | /* Copyright (c) 2018 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "base/Base.h"
#include "kvstore/wal/FileBasedWal.h"
#include "kvstore/wal/FileBasedWalIterator.h"
#include "kvs... | 1 | 20,884 | maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger. | vesoft-inc-nebula | cpp |
@@ -135,6 +135,9 @@ func registerWriteCommand(cmd *cobra.Command) {
// gasPriceInRau returns the suggest gas price
func gasPriceInRau() (*big.Int, error) {
+ if account.CryptoSm2 {
+ return big.NewInt(0), nil
+ }
gasPrice := gasPriceFlag.Value().(string)
if len(gasPrice) != 0 {
return util.StringToRau(gasPr... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 21,072 | we need to pay attention not to use this flag everywhere. | iotexproject-iotex-core | go |
@@ -22,7 +22,6 @@ import (
)
type Protocol string
-type TableIDType uint8
type GroupIDType uint32
type MeterIDType uint32
| 1 | // Copyright 2019 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 42,670 | curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place | antrea-io-antrea | go |
@@ -74,7 +74,7 @@ func (db *DB) SubscribePush(ctx context.Context) (c <-chan swarm.Chunk, stop fun
}
select {
- case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag).WithStamp(dataItem.Stamp):
+ case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.... | 1 | // Copyright 2019 The go-ethereum Authors
// This file is part of the go-ethereum library.
//
// The go-ethereum library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License... | 1 | 14,080 | wait, are we not mising `WithStamp` here? | ethersphere-bee | go |
@@ -66,7 +66,7 @@ func (api *APIImpl) Syncing(ctx context.Context) (interface{}, error) {
return false, err
}
- currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.TxPool)
+ currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.Finish)
if err != nil {
return false, err
} | 1 | package commands
import (
"context"
"fmt"
"github.com/ledgerwatch/turbo-geth/common"
"github.com/ledgerwatch/turbo-geth/common/hexutil"
"github.com/ledgerwatch/turbo-geth/core"
"github.com/ledgerwatch/turbo-geth/core/rawdb"
"github.com/ledgerwatch/turbo-geth/core/types"
"github.com/ledgerwatch/turbo-geth/eth/... | 1 | 21,697 | oh. didn't know we store this stage progress. | ledgerwatch-erigon | go |
@@ -91,6 +91,7 @@ function getUnicodeNonBmpRegExp() {
'\u25A0-\u25FF' + // Geometric Shapes
'\u2600-\u26FF' + // Misc Symbols
'\u2700-\u27BF' + // Dingbats
+ '\uE000-\uF8FF' + // Private Use
']'
);
} | 1 | /* global text */
/**
* Determine if a given string contains unicode characters, specified in options
*
* @method hasUnicode
* @memberof axe.commons.text
* @instance
* @param {String} str string to verify
* @param {Object} options config containing which unicode character sets to verify
* @property {Boolean} o... | 1 | 14,966 | Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also... | dequelabs-axe-core | js |
@@ -300,7 +300,7 @@ class FunctionCallReturnTypeFetcher
return new Type\Union([
$atomic_types['array']->count !== null
? new Type\Atomic\TLiteralInt($atomic_types['array']->count)
- ... | 1 | <?php
namespace Psalm\Internal\Analyzer\Statements\Expression\Call;
use PhpParser;
use PhpParser\BuilderFactory;
use Psalm\Internal\Analyzer\Statements\ExpressionAnalyzer;
use Psalm\Internal\Analyzer\StatementsAnalyzer;
use Psalm\CodeLocation;
use Psalm\Context;
use Psalm\Internal\FileManipulation\FileManipulationBuff... | 1 | 9,805 | This change is un-tested and requires testing | vimeo-psalm | php |
@@ -83,6 +83,11 @@ class notebook_extension(extension):
logo = param.Boolean(default=True, doc="Toggles display of HoloViews logo")
+ comms = param.ObjectSelector(
+ default='default', objects=['default', 'ipywidgets', 'vscode'], doc="""
+ Whether to render output in Jupyter with the default J... | 1 | import os
from unittest import SkipTest
import param
import holoviews
from IPython import version_info
from IPython.core.completer import IPCompleter
from IPython.display import HTML, publish_display_data
from param import ipython as param_ext
from ..core.dimension import LabelledData
from ..core.tree import AttrTre... | 1 | 23,625 | Should the docstring mention the vscode option? | holoviz-holoviews | py |
@@ -83,6 +83,8 @@ public class PackageMetadataTransformer {
.packageVersionBound(packageConfig.generatedPackageVersionBound(language))
.protoPath(packageConfig.protoPath())
.shortName(packageConfig.shortName())
+ .gapicConfigName(packageConfig.shortName() + "_gapic.yaml")
+ .pac... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 21,885 | ISTM that since `artman` know the "real" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen... | googleapis-gapic-generator | java |
@@ -17,7 +17,7 @@ package main
import (
"time"
- "github.com/docopt/docopt-go"
+ docopt "github.com/docopt/docopt-go"
log "github.com/sirupsen/logrus"
"github.com/projectcalico/felix/iptables" | 1 | // Copyright (c) 2017 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 16,673 | Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated | projectcalico-felix | go |
@@ -17,6 +17,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken));
void Flush();
Task FlushAsync(CancellationToken cancellationToken = default(Canc... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines;
namespace M... | 1 | 12,638 | Should this be `ISocketOutput<T> where T : struct`? | aspnet-KestrelHttpServer | .cs |
@@ -104,4 +104,11 @@ public interface Snapshot {
* @return the location of the manifest list for this Snapshot
*/
String manifestListLocation();
+
+ /**
+ * Return this snapshot's sequence number, or 0 if the table has no snapshot yet.
+ *
+ * @return the sequence number of this Snapshot
+ */
+ Lon... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 16,335 | In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right? | apache-iceberg | java |
@@ -133,6 +133,11 @@ class NumClassCheckHook(Hook):
for name, module in model.named_modules():
if hasattr(module, 'num_classes') and not isinstance(
module, (RPNHead, VGG, FusedSemanticHead, GARPNHead)):
+ assert type(dataset.CLASSES) is not str,... | 1 | import copy
import warnings
from mmcv.cnn import VGG
from mmcv.runner.hooks import HOOKS, Hook
from mmdet.datasets.builder import PIPELINES
from mmdet.datasets.pipelines import LoadAnnotations, LoadImageFromFile
from mmdet.models.dense_heads import GARPNHead, RPNHead
from mmdet.models.roi_heads.mask_heads import Fuse... | 1 | 23,303 | This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module. | open-mmlab-mmdetection | py |
@@ -36,7 +36,7 @@ if __name__ == "__main__":
"boto3",
f"dagster{pin}",
"packaging",
- "psycopg2-binary<2.9",
+ "psycopg2-binary",
"requests",
],
extras_require={ | 1 | from typing import Dict
from setuptools import find_packages, setup # type: ignore
def get_version() -> str:
version: Dict[str, str] = {}
with open("dagster_aws/version.py") as fp:
exec(fp.read(), version) # pylint: disable=W0122
return version["__version__"]
if __name__ == "__main__":
v... | 1 | 14,583 | Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine? | dagster-io-dagster | py |
@@ -12,8 +12,9 @@ import (
)
var (
- _ = collection.Entry(&Entry{})
- serializedDataSize = swarm.SectionSize * 2
+ _ = collection.Entry(&Entry{})
+ serializedDataSize = swarm.SectionSize * 2
+ encryptedSerializedDataSize = swarm.EncryptedHashSize * 2
)
// Entr... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package entry
import (
"errors"
"github.com/ethersphere/bee/pkg/collection"
"github.com/ethersphere/bee/pkg/swarm"
)
var (
_ = collec... | 1 | 11,523 | could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`? | ethersphere-bee | go |
@@ -39,9 +39,14 @@ func (r *Reader) Close() error {
return r.r.Close()
}
+// ContentType returns the MIME type of the object content.
+func (r *Reader) ContentType() string {
+ return r.r.Attrs().ContentType
+}
+
// Size returns the content size of the blob object.
func (r *Reader) Size() int64 {
- return r.r.Si... | 1 | // Copyright 2018 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in ... | 1 | 9,952 | s/object content/blob object/ (for consistency with the `Size` docs) | google-go-cloud | go |
@@ -109,16 +109,7 @@ public class CheckJUnitDependencies extends DefaultTask {
+ "'org.junit.jupiter:junit-jupiter' dependency "
+ "because tests use JUnit4 and useJUnitPlatform() is not enabled.");
}
- } else {
- String co... | 1 | /*
* (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless ... | 1 | 7,525 | Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line? | palantir-gradle-baseline | java |
@@ -215,7 +215,7 @@ func (cfg *Config) newACMEClient(interactive bool) (*acmeClient, error) {
// lockKey returns a key for a lock that is specific to the operation
// named op being performed related to domainName and this config's CA.
func (cfg *Config) lockKey(op, domainName string) string {
- return fmt.Sprintf("... | 1 | // Copyright 2015 Matthew Holt
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in... | 1 | 13,023 | Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one? | caddyserver-caddy | go |
@@ -758,6 +758,7 @@ class CaiDataAccess(object):
except SQLAlchemyError as e:
LOGGER.exception('Attempt to delete data from CAI temporary store '
'failed, disabling the use of CAI: %s', e)
+ session.rollback()
return num_rows
| 1 | # Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by ap... | 1 | 33,367 | Thanks for this... is this the only place where the rollback is needed? Are there others? | forseti-security-forseti-security | py |
@@ -56,7 +56,7 @@ func TestTriangleEncoding(t *testing.T) {
}
t.Run("encoding block with zero fields works", func(t *testing.T) {
testRoundTrip(t, &blk.Block{
- BlockSig: crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
+ BlockSig: &crypto.Signature{Type: crypto.SigTypeSecp256k1... | 1 | package block_test
import (
"bytes"
"encoding/json"
"reflect"
"testing"
"github.com/filecoin-project/specs-actors/actors/abi"
fbig "github.com/filecoin-project/specs-actors/actors/abi/big"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
blk "github.com/filecoin-project/go-filecoin... | 1 | 23,366 | Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here. | filecoin-project-venus | go |
@@ -427,9 +427,9 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
case driver.Replace:
// If the given document has a revision, use it as the precondition (it implies existence).
- pc, err := revisionPrecondition(a.Doc)
- if err != nil {
- return nil, "", err
+ pc, perr :=... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,770 | This was definitely a subtle bug right here. | google-go-cloud | go |
@@ -35,6 +35,12 @@ class GithubApi
@access_token = data['access_token'].first
end
+ def secondary_emails
+ return @secondary_emails if @secondary_emails
+ @secondary_emails = fetch_email_responses.select { |hsh| !hsh['primary'] && hsh['verified'] }
+ .map { |... | 1 | class GithubApi
GITHUB_USER_URI = 'https://api.github.com/user'.freeze
GITHUB_ACCESS_TOKEN_URI = 'https://github.com/login/oauth/access_token'.freeze
REPO_LIMIT = 10
def initialize(code)
@code = code
end
def login
user_response['login']
end
def email
return user_response['email'] if user_... | 1 | 9,290 | If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**. | blackducksoftware-ohloh-ui | rb |
@@ -48,7 +48,7 @@ func TestBroadcast(t *testing.T) {
}
}
u := func(_ context.Context, _ uint32, _ peerstore.PeerInfo, _ proto.Message) {}
- bootnodePort := testutil.RandomPort()
+ bootnodePort := 14689
cfg := config.Config{
Network: config.Network{Host: "127.0.0.1", Port: bootnodePort},
} | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 18,717 | Can we still random, but if we randomly get a port is used before, we randomly pick again? | iotexproject-iotex-core | go |
@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
"""
def __init__(self, executable_path, port=0, service_args=None,
- log_path=None, env=None):
+ log_path=None, env=None, create_no_window=False):
"""
Creates a new instance of the Service
| 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 17,876 | I would rather no have this as a `kwarg` as it encourages "growth" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low. | SeleniumHQ-selenium | py |
@@ -11,5 +11,17 @@ module Gsa18f
super && self.gsa_if_restricted!
end
alias_method :can_new!, :can_create!
+
+ def can_cancel!
+ not_cancelled! && check((approver? || delegate? || requester?) && !purchaser?,
+ "Sorry, you are neither the requester, approver or delegate")
+ end
+ a... | 1 | module Gsa18f
class ProcurementPolicy < ProposalPolicy
include GsaPolicy
def initialize(user, record)
super(user, record.proposal)
@procurement = record
end
def can_create!
super && self.gsa_if_restricted!
end
alias_method :can_new!, :can_create!
end
end
| 1 | 15,602 | what if a purchaser is also an approver? or would that not happen? | 18F-C2 | rb |
@@ -125,9 +125,12 @@ def sweep(privkeys, network, config, recipient, fee=None, imax=100):
raise BaseException(_('No inputs found. (Note that inputs need to be confirmed)'))
total = sum(i.get('value') for i in inputs)
if fee is None:
+ if not network.config.has_fee_estimates():
+ rai... | 1 | # Electrum - lightweight Bitcoin client
# Copyright (C) 2015 Thomas Voegtlin
#
# Permission is hereby granted, free of charge, to any person
# obtaining a copy of this software and associated documentation files
# (the "Software"), to deal in the Software without restriction,
# including without limitation the rights t... | 1 | 11,976 | Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that. | spesmilo-electrum | py |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.