patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -21,6 +21,7 @@ public enum NetworkName { SEPOLIA, GOERLI, DEV, + PREMERGE, CLASSIC, KOTTI, MORDOR,
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
26,900
I don't think this is the type of network we should be putting in our named networks.
hyperledger-besu
java
@@ -60,7 +60,15 @@ void generic_data_reader::setup() { shuffle_indices(); } +std::ofstream debug; + int lbann::generic_data_reader::fetch_data(CPUMat& X) { +if (! debug.is_open()) { + char b[1024]; + sprintf(b, "debug.%d", m_comm->get_rank_in_world()); + debug.open(b); +} +if (get_role() == "train") debug << ...
1
//////////////////////////////////////////////////////////////////////////////// // Copyright (c) 2014-2016, Lawrence Livermore National Security, LLC. // Produced at the Lawrence Livermore National Laboratory. // Written by the LBANN Research Team (B. Van Essen, et al.) listed in // the CONTRIBUTORS file. <lbann-dev@l...
1
13,027
debug? I suspect this will be removed before merge?
LLNL-lbann
cpp
@@ -42,7 +42,12 @@ describe('Operation (Generators)', function() { // LINE test = require('assert'); // LINE // LINE co(function*() { - // LINE var client = yield MongoClient.connect('mongodb://localhost:27017/test'); + // LINE const client = new MongoClient('mongodb://loc...
1
'use strict'; var test = require('./shared').assert; var setupDatabase = require('./shared').setupDatabase; var Buffer = require('safe-buffer').Buffer; /************************************************************************** * * COLLECTION TESTS * ****************************************************************...
1
14,771
should this be here twice?
mongodb-node-mongodb-native
js
@@ -46,8 +46,13 @@ public: width_ = GENERATE(16, 128, 1024); stride_ = GENERATE(16, 128, 1024); height_ = GENERATE(16, 128, 1024, 16384, 32768); - SKIP_IF(width_ > stride_); - REQUIRE(width_ <= stride_); + CAPTURE(width_, stride_, height_); + } + + void generate_spe...
1
/******************************************************************************* * Copyright 2021 Intel Corporation * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.o...
1
29,476
`generate_special` - a meaningless name for me. Can we provide more detailed naming?
oneapi-src-oneDAL
cpp
@@ -61,8 +61,8 @@ feature 'Subscriber views subscription invoices' do @current_user.stripe_customer_id = "cus_NOMATCH" @current_user.save! - visit subscriber_invoice_path("in_1s4JSgbcUaElzU") - - expect(page).to have_content 'ActiveRecord::RecordNotFound' + expect { + visit subscriber_invoice_...
1
require 'spec_helper' feature 'Subscriber views subscription invoices' do scenario 'Subscriber views a listing of all invoices' do sign_in_as_user_with_subscription @current_user.stripe_customer_id = FakeStripe::CUSTOMER_ID @current_user.save! visit my_account_path click_link 'View all invoices'...
1
8,913
This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration.
thoughtbot-upcase
rb
@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> { Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass(); if (supplierClass.isPresent()) { Class<? extends Supplier<WebDriver>> clazz = supplierClass.get(); - logger.info("Using delegate supp...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
16,449
We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.
SeleniumHQ-selenium
py
@@ -139,7 +139,7 @@ public class BaseRemoteProxy implements RemoteProxy { this.id = id; } else { // otherwise assign the remote host as id. - this.id = remoteHost.toExternalForm(); + this.id = id = "http://" + remoteHost.getHost() + ":" + remoteHost.getPort(); } maxConcurrentSes...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
12,733
any reason you're assigning to the local variable 'id' too?
SeleniumHQ-selenium
py
@@ -28,6 +28,7 @@ import sys import termios from subprocess import CalledProcessError +import molecule.validators as validators import prettytable import sh import vagrant
1
# Copyright (c) 2015 Cisco Systems # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal # in the Software without restriction, including without limitation the rights # to use, copy, modify, merge, publish, ...
1
5,664
Need to fix this import :)
ansible-community-molecule
py
@@ -46,12 +46,14 @@ func TestBlockGenerator_GenerateBehavior(t *testing.T) { Height: uint64(100), StateRoot: newCid(), } + accountActor := &types.Actor{Code: types.AccountActorCodeCid} // With no messages. nextStateRoot := newCid() mpb, mst := &MockProcessBlock{}, &types.MockStateTree{} mpb.On("Pro...
1
package mining import ( "context" "errors" "testing" "github.com/filecoin-project/go-filecoin/core" "github.com/filecoin-project/go-filecoin/types" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/mock" "github.com/stretchr/testify/require" cid "gx/ipfs/QmcZfnkapfECQGcLZaf9B79NRg7cRa9EnZh4L...
1
11,730
sorry these tests suck so much we are working to kill them
filecoin-project-venus
go
@@ -701,7 +701,7 @@ import 'emby-ratingbutton'; const player = this; currentRuntimeTicks = playbackManager.duration(player); - updateTimeDisplay(playbackManager.currentTime(player), currentRuntimeTicks, playbackManager.getBufferedRanges(player)); + updateTimeDisplay(playbackManager.cur...
1
import datetime from 'datetime'; import events from 'events'; import browser from 'browser'; import imageLoader from 'imageLoader'; import layoutManager from 'layoutManager'; import playbackManager from 'playbackManager'; import nowPlayingHelper from 'nowPlayingHelper'; import appHost from 'apphost'; import dom from 'd...
1
17,367
Why not adjust `currentTime` to be in ms directly?
jellyfin-jellyfin-web
js
@@ -3697,7 +3697,8 @@ instr_is_reg_spill_or_restore_ex(void *drcontext, instr_t *instr, bool DR_only, if (reg == NULL) reg = &myreg; if (instr_check_tls_spill_restore(instr, spill, reg, &check_disp)) { - if (!DR_only || + /* We do not want to count an mcontext base load as a reg spill/r...
1
/* ********************************************************** * Copyright (c) 2011-2021 Google, Inc. All rights reserved. * Copyright (c) 2000-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
24,119
> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`.
DynamoRIO-dynamorio
c
@@ -89,12 +89,10 @@ var ( Chain: Chain{ ChainDBPath: "/tmp/chain.db", TrieDBPath: "/tmp/trie.db", - UseBadgerDB: false, ID: 1, Address: "", ProducerPubKey: keypair.EncodePublicKey(ke...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
13,709
this flag not used
iotexproject-iotex-core
go
@@ -625,7 +625,9 @@ class Folio extends AbstractAPI implements 'zip' => $profile->personal->addresses[0]->postalCode ?? null, 'phone' => $profile->personal->phone ?? null, 'mobile_phone' => $profile->personal->mobilePhone ?? null, - 'expiration_date' => $profile->expira...
1
<?php /** * FOLIO REST API driver * * PHP version 7 * * Copyright (C) Villanova University 2018. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * as published by the Free Software Foundation. * * This program is distr...
1
29,663
I don't think `?? null` works here... that's to ensure PHP doesn't throw an "undefined" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do: <pre> $expiration = isset($profile->expirationDate) ? $this->dateConverter->convertToDisplayDa...
vufind-org-vufind
php
@@ -0,0 +1,8 @@ +import Vue from 'vue' +import App from './App.vue' + +Vue.config.productionTip = false + +new Vue({ + render: h => h(App), +}).$mount('#app')
1
1
17,921
An ENV should be used? Are you sure that the Vue examples are built in the production mode?
handsontable-handsontable
js
@@ -52,7 +52,7 @@ class NodeResult( warn (Optional[Any]): The ``warn`` field from the results of the executed dbt node. skip (Optional[Any]): The ``skip`` field from the results of the executed dbt node. status (Optional[Union[str,int]]): The status of the executed dbt node (model). - ...
1
from collections import namedtuple from datetime import datetime, timedelta from typing import Any, Dict, List, Optional, Union from dagster import check from dateutil import parser class StepTiming(namedtuple("_StepTiming", "name started_at completed_at")): """The timing information of an executed step for a db...
1
14,464
Nit: this should actually always be float since we convert it before we construct the namedtuple.
dagster-io-dagster
py
@@ -99,7 +99,13 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId, , dataPath_(folly::stringPrintf("%s/nebula/%d", dataPath.c_str(), spaceId)) { auto path = folly::stringPrintf("%s/data", dataPath_.c_str()); if (FileUtils::fileType(path.c_str()) == FileType::NOTEXIST) { - FileUtils::makeDir(pat...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "kvstore/RocksEngine.h" #include <folly/String.h> #include "fs/FileUtils.h" #include "kv...
1
28,203
The result of `FileUtils::fileType` could be saved, instead of calling twice.
vesoft-inc-nebula
cpp
@@ -71,7 +71,10 @@ abstract class BaseProvider implements MediaProviderInterface return; } - $this->doTransform($media); + try { + $this->doTransform($media); + } catch (\Exception $e) { + } } /**
1
<?php /* * This file is part of the Sonata project. * * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ namespace Sonata\MediaBundle\Provider; use Gaufrette\Filesystem; use So...
1
6,377
Can you log the exception ?
sonata-project-SonataMediaBundle
php
@@ -113,6 +113,9 @@ static int http_post(struct flb_out_http *ctx, ctx->host, ctx->port, ctx->proxy, 0); + + flb_debug("[http_client] proxy host: %s port: %i", c->proxy.host, c->proxy.port); + /* Allow duplicated headers ? */ flb_http_allow_duplicated_hea...
1
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* Fluent Bit * ========== * Copyright (C) 2019-2020 The Fluent Bit Authors * Copyright (C) 2015-2018 Treasure Data Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in co...
1
13,035
since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, "..."), on this case don't need the component prefix since the API will put it there automatically
fluent-fluent-bit
c
@@ -25,10 +25,10 @@ import com.yahoo.athenz.common.server.util.ResourceUtils; import com.yahoo.athenz.zts.ZTSConsts; import com.yahoo.athenz.zts.cert.InstanceCertManager; import com.yahoo.athenz.zts.store.DataStore; +import com.yahoo.rdl.Timestamp; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import...
1
/* * Copyright 2020 Verizon Media * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed t...
1
5,431
I also took advantage of the changes to change the Timestamps used in this notification from "java.sql.Timestamp" to "com.yahoo.rdl.Timestamp".
AthenZ-athenz
java
@@ -23,6 +23,6 @@ import "time" const ( BrokerPort = 4222 BrokerMaxReconnect = -1 - BrokerReconnectWait = 4 * time.Second + BrokerReconnectWait = 1 * time.Second BrokerTimeout = 5 * time.Second )
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
13,919
It would be nice all these tweaks to be configurable from cmd line, with sensible defaults
mysteriumnetwork-node
go
@@ -147,9 +147,10 @@ class SQLServer(object): if make_url(connection_string).drivername == 'sqlite+pysqlite': # FIXME: workaround for locking errors - return sqlalchemy.create_engine(connection_string, - encoding='utf8', - ...
1
# ------------------------------------------------------------------------- # The CodeChecker Infrastructure # This file is distributed under the University of Illinois Open Source # License. See LICENSE.TXT for details. # -------------------------------------------------------------------------...
1
6,923
Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this.
Ericsson-codechecker
c
@@ -318,6 +318,13 @@ module.exports = BaseTest.extend({ // Should have been multiplied by 100 in the constructor. TestCase.assertEqual(object.intCol, 100); + + // Should be able to create object by passing in constructor. + object = realm.create(CustomObject, {intCol: 2...
1
//////////////////////////////////////////////////////////////////////////// // // Copyright 2016 Realm Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
15,094
We should probably test with constructors which aren't in the schema, and functions which aren't constructors.
realm-realm-js
js
@@ -201,6 +201,19 @@ CudaHostPinnedSpace::CudaHostPinnedSpace() {} // <editor-fold desc="allocate()"> {{{1 void *CudaSpace::allocate(const size_t arg_alloc_size) const { + return allocate("[unlabeled]", arg_alloc_size); +} +void *CudaSpace::allocate(const char * +#if defined(KOKKOS_ENABLE_PROFILING) + ...
1
/* //@HEADER // ************************************************************************ // // Kokkos v. 3.0 // Copyright (2020) National Technology & Engineering // Solutions of Sandia, LLC (NTESS). // // Under the terms of Contract DE-NA0003525 with NTESS, // the U.S. Govern...
1
23,457
this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical.
kokkos-kokkos
cpp
@@ -32,7 +32,7 @@ module Beaker 'puppetbin' => '/opt/puppet/bin/puppet', 'puppetbindir' => '/opt/puppet/bin', 'puppetsbindir' => '/opt/puppet/sbin', - 'privatebindir' => '/opt/puppetlabs/puppet/bin', + 'privatebindir' => '/opt/puppet/bin',...
1
module Beaker module DSL module InstallUtils # # This module contains default values for pe paths and directorys per-platform # module PEDefaults #Here be the pathing and default values for PE installs # PE_DEFAULTS = { 'mac' => { 'puppetserve...
1
10,552
This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl
voxpupuli-beaker
rb
@@ -106,13 +106,9 @@ func main() { } func initLogger(cfg config.Config) { - addr, err := cfg.BlockchainAddress() - if err != nil { - glog.Fatalln("Failed to get producer address from pub/kri key: ", err) - return - } + addr := cfg.ProducerAddress() if err := log.InitGlobal(cfg.Log, zap.Fields( - zap.String("ad...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
15,809
nit: let's call our address ioAddr from now on
iotexproject-iotex-core
go
@@ -12845,7 +12845,9 @@ bool CoreChecks::PreCallValidateGetBufferDeviceAddressEXT(VkDevice device, const void CoreChecks::PreCallRecordGetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice, VkPhysicalDeviceProperties *pPhysicalDeviceProperties) { - ...
1
/* Copyright (c) 2015-2019 The Khronos Group Inc. * Copyright (c) 2015-2019 Valve Corporation * Copyright (c) 2015-2019 LunarG, Inc. * Copyright (C) 2015-2019 Google Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You m...
1
10,839
You're killing this "else" case here which currently flags an error when maxBoundDescriptorSets == 0.
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -509,6 +509,16 @@ fill_refs_and_checksums_from_summary (GVariant *summary, return TRUE; } +static gboolean +remove_null_checksum_refs (gpointer key, + gpointer value, + gpointer user_data) +{ + const char *checksum = value; + + return (checksum == NULL);...
1
/* * Copyright © 2016 Kinvolk GmbH * Copyright © 2017 Endless Mobile, Inc. * * SPDX-License-Identifier: LGPL-2.0+ * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public * License as published by the Free Software Foundation; either * versi...
1
15,850
Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table.
ostreedev-ostree
c
@@ -86,8 +86,7 @@ public class Catalog implements AutoCloseable { tableMap = loadTables(db); } Collection<TiTableInfo> tables = tableMap.values(); - tables.removeIf(TiTableInfo::isView); - return ImmutableList.copyOf(tables); + return tables.stream().filter(TiTableInfo::isNotView)....
1
/* * Copyright 2017 PingCAP, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed ...
1
11,043
or you can use `filter(x => !x.isView)`
pingcap-tispark
java
@@ -133,7 +133,6 @@ func (c *Cluster) storageBootstrap(ctx context.Context) error { } return c.ReconcileBootstrapData(ctx, bytes.NewBuffer(data), &c.config.Runtime.ControlRuntimeBootstrap) - //return bootstrap.WriteToDiskFromStorage(bytes.NewBuffer(data), &c.runtime.ControlRuntimeBootstrap) } // getBootstrapK...
1
package cluster import ( "bytes" "context" "errors" "io/ioutil" "os" "path/filepath" "strings" "github.com/k3s-io/kine/pkg/client" "github.com/rancher/k3s/pkg/bootstrap" "github.com/rancher/k3s/pkg/clientaccess" "github.com/sirupsen/logrus" ) // save writes the current ControlRuntimeBootstrap data to the ...
1
10,294
Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later.
k3s-io-k3s
go
@@ -182,6 +182,7 @@ class AsciiDoc: asciidoc_args = ['--theme=qute', '-a toc', '-a toc-placement=manual'] self.call(modified_src, dst, *asciidoc_args) + # pylint: enable=too-many-locals,too-many-statements def _build_website(self): """Prepare and build the website."""
1
#!/usr/bin/env python3 # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as pub...
1
19,418
No need for this, as pylint already only turns things off for this function and it's needed for the entire function.
qutebrowser-qutebrowser
py
@@ -733,7 +733,7 @@ func (eval *BlockEvaluator) transactionGroup(txgroup []transactions.SignedTxnWit txibs = append(txibs, txib) if eval.validate { - groupTxBytes += len(protocol.Encode(&txib)) + groupTxBytes += txib.GetEncodedLength() if eval.blockTxBytes+groupTxBytes > eval.proto.MaxTxnBytesPerBlock {...
1
// Copyright (C) 2019-2021 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
41,662
extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always t...
algorand-go-algorand
go
@@ -849,8 +849,11 @@ describe Mongoid::Association::Depending do it 'adds an error to the parent object' do expect(person.delete).to be(false) - expect(person.errors[:restrictable_posts].first).to be( - Mongoid::Association::Depending::RESTRICT_ERROR_MSG) + + key_message = "#{Mo...
1
# frozen_string_literal: true # encoding: utf-8 require "spec_helper" describe Mongoid::Association::Depending do describe '#self.included' do context 'when a destroy dependent is defined' do context 'when the model is a subclass' do context 'when transitive dependents are defined' do ...
1
12,424
This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is.
mongodb-mongoid
rb
@@ -18,6 +18,7 @@ package ec2 import ( "fmt" + "sigs.k8s.io/cluster-api/util/conditions" errlist "k8s.io/apimachinery/pkg/util/errors"
1
/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
15,502
similar here for imports, these should be consolidated (and also consolidated with the grouping below)
kubernetes-sigs-cluster-api-provider-aws
go
@@ -231,7 +231,7 @@ class LoadAnnotations: self.with_seg = with_seg self.poly2mask = poly2mask self.file_client_args = file_client_args.copy() - self.file_client = None + self.file_client = mmcv.FileClient(**self.file_client_args) def _load_bboxes(self, results): ...
1
# Copyright (c) OpenMMLab. All rights reserved. import os.path as osp import mmcv import numpy as np import pycocotools.mask as maskUtils from mmdet.core import BitmapMasks, PolygonMasks from ..builder import PIPELINES try: from panopticapi.utils import rgb2id except ImportError: rgb2id = None @PIPELINES.r...
1
26,483
Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized.
open-mmlab-mmdetection
py
@@ -104,8 +104,7 @@ final class SelectTraceIdsFromSpan extends ResultSetFutureCall { Input input = new AutoValue_SelectTraceIdsFromSpan_Input( serviceName, - // % for like, bracing with ░ to ensure no accidental substring match - "%░" + annotationKey + "░%", + ...
1
/* * Copyright 2015-2018 The OpenZipkin Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or a...
1
13,277
Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?
openzipkin-zipkin
java
@@ -29,6 +29,13 @@ #include <opae/fpga.h> #include <time.h> #include "fpga_dma.h" +#include <getopt.h> +#include <stdio.h> +#include <stdint.h> +#include <errno.h> +#include <stdbool.h> +#include <sys/stat.h> +#include "safe_string/safe_string.h" /** * \fpga_dma_test.c * \brief User-mode DMA test
1
// Copyright(c) 2017, Intel Corporation // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are met: // // * Redistributions of source code must retain the above copyright notice, // this list of conditions and the ...
1
15,864
Please update the DMA test app in AFU repo once this gets approved.
OPAE-opae-sdk
c
@@ -57,8 +57,8 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend $manager->persist(new SettingValue(PricingSetting::DEFAULT_DOMAIN_CURRENCY, $defaultCurrency->getId(), Domain::FIRST_DOMAIN_ID)); $manager->persist(new SettingValue(Setting::DEFAULT_AVAILABILITY_IN_STOCK...
1
<?php namespace Shopsys\FrameworkBundle\DataFixtures\Base; use Doctrine\Common\DataFixtures\DependentFixtureInterface; use Doctrine\Common\Persistence\ObjectManager; use Shopsys\FrameworkBundle\Component\DataFixture\AbstractReferenceFixture; use Shopsys\FrameworkBundle\Component\Domain\Domain; use Shopsys\FrameworkBu...
1
9,433
There should be a migration for that as well to reflect the change on in-production instances
shopsys-shopsys
php
@@ -41,6 +41,7 @@ var _ = BeforeSuite(func() { appName = fmt.Sprintf("e2e-customizedenv-%d", time.Now().Unix()) vpcConfig = client.EnvInitRequestVPCConfig{ CIDR: "10.1.0.0/16", + AZs: `""`, // Use default AZ options. PrivateSubnetCIDRs: "10.1.2.0/24,10.1.3.0/24", PublicSubnetC...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package customized_env_test import ( "fmt" "testing" "time" "github.com/aws/copilot-cli/e2e/internal/client" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" ) var cli *client.CLI var aws *client....
1
20,255
Why does it have to be `""` instead of an empty string
aws-copilot-cli
go
@@ -107,7 +107,7 @@ module RSpec start(reporter) begin - unless pending + unless pending or RSpec.configuration.dry_run with_around_each_hooks do begin run_before_each
1
module RSpec module Core # Wrapper for an instance of a subclass of {ExampleGroup}. An instance of # `Example` is returned by the {ExampleGroup#example example} method # exposed to examples, {Hooks#before before} and {Hooks#after after} hooks, # and yielded to {Hooks#around around} hooks. # # ...
1
9,847
This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?
rspec-rspec-core
rb
@@ -894,7 +894,7 @@ module RSpec # @private RANDOM_ORDERING = lambda do |list| Kernel.srand RSpec.configuration.seed - ordering = list.sort_by { Kernel.rand(list.size) } + ordering = list.shuffle Kernel.srand # reset random generation ordering end
1
require 'fileutils' require 'rspec/core/backtrace_cleaner' require 'rspec/core/ruby_project' require 'rspec/core/formatters/deprecation_formatter.rb' module RSpec module Core # Stores runtime configuration information. # # Configuration options are loaded from `~/.rspec`, `.rspec`, # `.rspec-local`, ...
1
10,345
Will this obey the seed set on Kernel?
rspec-rspec-core
rb
@@ -23,16 +23,9 @@ Puppet::Functions.create_function(:add_facts) do .from_issue_and_stack(Bolt::PAL::Issues::PLAN_OPERATION_NOT_SUPPORTED_WHEN_COMPILING, action: 'add_facts') end - inventory = Puppet.lookup(:bolt_inventory) { nil } - - unless inventory - raise Puppet::ParseErrorWithIssue.from...
1
# frozen_string_literal: true require 'bolt/error' # Deep merges a hash of facts with the existing facts on a target. # # **NOTE:** Not available in apply block Puppet::Functions.create_function(:add_facts) do # @param target A target. # @param facts A hash of fact names to values that may include structured fact...
1
11,267
We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate.
puppetlabs-bolt
rb
@@ -68,11 +68,12 @@ public class SurfaceNamer extends NameFormatterDelegator { public String getNotImplementedString(String feature) { return "$ NOT IMPLEMENTED: " + feature + " $"; + //throw new RuntimeException(feature); } /** The full path to the source file */ public String getSourceFilePat...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
17,742
Why the switch from period to colon?
googleapis-gapic-generator
java
@@ -314,8 +314,9 @@ func environmentConfig() Config { imageCleanupDisabled := utils.ParseBool(os.Getenv("ECS_DISABLE_IMAGE_CLEANUP"), false) minimumImageDeletionAge := parseEnvVariableDuration("ECS_IMAGE_MINIMUM_CLEANUP_AGE") imageCleanupInterval := parseEnvVariableDuration("ECS_IMAGE_CLEANUP_INTERVAL") - numImag...
1
// Copyright 2014-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
14,408
Can you just fix the warning instead? It's actually important for this to have a default of `""` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `""`, you break the assumptions of `Merge()`.
aws-amazon-ecs-agent
go
@@ -23,5 +23,15 @@ namespace Nethermind.Baseline.Config { [ConfigItem(Description = "If 'true' then the Baseline Module is enabled via JSON RPC", DefaultValue = "false")] bool Enabled { get; } + + bool BaselineTreeDbCacheIndexAndFilterBlocks { get; set; } + ulong BaselineTreeDbBlock...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
24,739
let us not add this
NethermindEth-nethermind
.cs
@@ -41,6 +41,13 @@ type Cgroup struct { // Rootless tells if rootless cgroups should be used. Rootless bool + + // The host UID that should own the cgroup, or nil to accept + // the default ownership. This should only be set when the + // cgroupfs is to be mounted read/write. + // Not all cgroup manager implemen...
1
package configs import ( systemdDbus "github.com/coreos/go-systemd/v22/dbus" "github.com/opencontainers/runc/libcontainer/devices" ) type FreezerState string const ( Undefined FreezerState = "" Frozen FreezerState = "FROZEN" Thawed FreezerState = "THAWED" ) // Cgroup holds properties of a cgroup on Linux...
1
24,048
Is there a need for group as well? crun sets both.
opencontainers-runc
go
@@ -62,9 +62,12 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests [Fact] public async Task HttpDependenciesInstrumentationInjectsHeadersAsync() { - var spanProcessor = new Mock<SpanProcessor>(); - var tracer = TracerFactory.Create(b => b.AddProcessorPipeline(...
1
// <copyright file="HttpWebRequestTests.Basic.net461.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // ...
1
14,065
@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a "Next" or make sure that the chain is called. Probably need to do some more work in this area?
open-telemetry-opentelemetry-dotnet
.cs
@@ -1206,6 +1206,11 @@ Schema.prototype.queue = function(name, args) { * console.log(this.getFilter()); * }); * + * // Equivalent to calling `pre()` on `save`, `findOneAndUpdate`. + * toySchema.pre(['save', 'findOneAndUpdate'], function(next) { + * console.log(this.getFilter()); + * })...
1
'use strict'; /*! * Module dependencies. */ const EventEmitter = require('events').EventEmitter; const Kareem = require('kareem'); const SchemaType = require('./schematype'); const VirtualType = require('./virtualtype'); const applyTimestampsToChildren = require('./helpers/update/applyTimestampsToChildren'); const ...
1
14,049
`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?
Automattic-mongoose
js
@@ -58,9 +58,12 @@ public class TracerTest { public void shouldBeAbleToCreateATracer() { List<SpanData> allSpans = new ArrayList<>(); Tracer tracer = createTracer(allSpans); + long timeStamp = 1593493828L; try (Span span = tracer.getCurrentContext().createSpan("parent")) { span.setAttribut...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,762
Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.
SeleniumHQ-selenium
java
@@ -67,18 +67,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal if (result.IsCancelled) { - // Send a FIN - _log.ConnectionWriteFin(_connectionId); - - using (var shutdownReq = new ...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Threading.Tasks; using Microsoft.AspNetCore.Server.Kestrel.Internal.System.IO.Pipelines; using Microsoft.AspNetCore.Server.K...
1
13,141
I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?
aspnet-KestrelHttpServer
.cs
@@ -248,7 +248,7 @@ func (a *Agent) Attest() error { // Configure TLS // TODO: Pick better options here tlsConfig := &tls.Config{ - RootCAs: a.Config.TrustBundle, + InsecureSkipVerify:true, } dialCreds := grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig)) conn, err := grpc.Dial(a.Config.ServerAd...
1
package agent import ( "context" "crypto/ecdsa" "crypto/rand" "crypto/tls" "crypto/x509" "crypto/x509/pkix" "encoding/pem" "fmt" "io/ioutil" "net" "net/url" "os" "path" "github.com/go-kit/kit/log" "github.com/hashicorp/go-hclog" "github.com/hashicorp/go-plugin" "github.com/spiffe/go-spiffe/spiffe" "...
1
8,388
I think we can get this to work by passing in the root ca cert fixture that upstream ca is using
spiffe-spire
go
@@ -219,6 +219,18 @@ static batch_job_id_t batch_job_condor_wait (struct batch_queue * q, struct batc } } + time_t current; + struct tm tm; + + /* Obtain current year, in case HTCondor log lines do not provide a year. + Note that this fallback may give the incorrect year for jobs that run + when the year t...
1
/* Copyright (C) 2017- The University of Notre Dame This software is distributed under the GNU General Public License. See the file COPYING for details. */ #include "batch_job.h" #include "batch_job_internal.h" #include "debug.h" #include "itable.h" #include "path.h" #include "process.h" #include "stringtools.h" #incl...
1
14,834
Just occurred to me to ask: is the condor log date in localtime or UTC?
cooperative-computing-lab-cctools
c
@@ -686,7 +686,18 @@ public enum Varbits /** * 1 is true, 0 is false. */ - GAUNTLET_ENTERED(9178); + GAUNTLET_ENTERED(9178), + + /** + * 1 if full of Mushrooms, 0 is empty. + */ + MUSHY_PIT(5809), + + /** + * Current location of Sulliuscep tree. + */ + SULLIUSCEP_LOCATION(5808); + /** * The raw varbi...
1
/* * Copyright (c) 2017, Adam <Adam@sigterm.info> * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright notice, this * li...
1
15,766
Can you remove the sculliscep varbits from here too?
open-osrs-runelite
java
@@ -1162,6 +1162,12 @@ function update_5_9_2018() { "); } +function update_8_23_2018() { + $retval = do_query("alter table host add index host_cpid (host_cpid)"); + return $retval && do_query("alter table host add index host_domain_name (domain_name)"); +} + + // Updates are done automatically if you use...
1
<?php // This file is part of BOINC. // http://boinc.berkeley.edu // Copyright (C) 2008 University of California // // BOINC is free software; you can redistribute it and/or modify it // under the terms of the GNU Lesser General Public License // as published by the Free Software Foundation, // either version 3 of the ...
1
11,437
I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here.
BOINC-boinc
php
@@ -39,5 +39,5 @@ class InputDevice(object): def clear_actions(self): self.actions = [] - def create_pause(self, duraton=0): + def create_pause(self, duration=0): pass
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
14,870
we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
SeleniumHQ-selenium
js
@@ -47,8 +47,7 @@ void h2o_mruby__abort_exc(mrb_state *mrb, const char *mess, const char *file, int line) { - h2o_error_printf("%s at file: \"%s\", line %d: %s\n", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc)))); - abort(); + h2o_fatal("%s at file: \"%s\", line %d: %s\n", mess, fi...
1
/* * Copyright (c) 2014-2016 DeNA Co., Ltd., Kazuho Oku, Ryosuke Matsumoto, * Masayoshi Takahashi * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restr...
1
13,613
Should we do something like `h2o__fatal(file, line, "fatal error: %s, %s\n", mess, RSTRING_PTR(...))` here?
h2o-h2o
c
@@ -24,7 +24,8 @@ describe('monitoring', function () { return mock.createServer().then(server => (mockServer = server)); }); - it('should record roundTripTime', function (done) { + // TODO: NODE-3819: Unskip flaky tests. + it.skip('should record roundTripTime', function (done) { mockServer.setMessageH...
1
'use strict'; const mock = require('../../tools/mongodb-mock/index'); const { ServerType } = require('../../../src/sdam/common'); const { Topology } = require('../../../src/sdam/topology'); const { Monitor } = require('../../../src/sdam/monitor'); const { expect } = require('chai'); const { ServerDescription } = requir...
1
21,670
is this one all platforms?
mongodb-node-mongodb-native
js
@@ -72,7 +72,7 @@ func TestBytes(t *testing.T) { t.Run("not found", func(t *testing.T) { jsonhttptest.Request(t, client, http.MethodGet, resource+"/abcd", http.StatusNotFound, jsonhttptest.WithExpectedJSONResponse(jsonhttp.StatusResponse{ - Message: "not found", + Message: "Not Found", Code: http...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package api_test import ( "bytes" "io/ioutil" "net/http" "testing" "github.com/ethersphere/bee/pkg/api" "github.com/ethersphere/bee/pkg/jsonhttp" "g...
1
11,951
why capitals grr?
ethersphere-bee
go
@@ -0,0 +1,17 @@ +package nameserver + +import ( + . "github.com/zettio/weave/common" +) + +func checkFatal(e error) { + if e != nil { + Error.Fatal(e) + } +} + +func checkWarn(e error) { + if e != nil { + Warning.Println(e) + } +}
1
1
7,769
Surely all the above should go into `common`.
weaveworks-weave
go
@@ -249,7 +249,6 @@ def test_failing_unwatch(qtbot, caplog, monkeypatch): assert caplog.records[-1].msg == message - @pytest.mark.parametrize('text, caret_position, result', [ ('', 0, (1, 1)), ('a', 0, (1, 1)),
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2018 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
20,689
This is an unrelated change, but was failing CI... probably introduced in master.
qutebrowser-qutebrowser
py
@@ -30,7 +30,10 @@ double getAlignmentTransform(const ROMol &prbMol, const ROMol &refMol, if (atomMap == 0) { // we have to figure out the mapping between the two molecule MatchVectType match; - if (SubstructMatch(refMol, prbMol, match)) { + const bool recursionPossible = true; + const bool useChi...
1
// $Id$ // // Copyright (C) 2001-2008 Greg Landrum and Rational Discovery LLC // // @@ All Rights Reserved @@ // This file is part of the RDKit. // The contents are covered by the terms of the BSD license // which is included in the file license.txt, found at the root // of the RDKit source tree. // #include "Al...
1
14,757
This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem.
rdkit-rdkit
cpp
@@ -81,8 +81,9 @@ import ( var endPoint = "pubsub.googleapis.com:443" var sendBatcherOpts = &batcher.Options{ - MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC - MaxHandlers: 2, + MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single...
1
// Copyright 2018 The Go Cloud Development Kit Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
20,571
MB is presumably 1024 * 1024.
google-go-cloud
go
@@ -22,6 +22,12 @@ import DashboardSplashMain from 'GoogleComponents/dashboard-splash/dashboard-splash-main'; import { Suspense as ReactSuspense, lazy as ReactLazy } from 'react'; +/** + * WordPress dependencies + */ +import { Component, Fragment, Suspense as WPSuspense, lazy as WPlazy } from '@wordpress/element'; ...
1
/** * DashboardSplashApp component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-...
1
24,743
Didn't we extract this logic to a `react-features` helper?
google-site-kit-wp
js
@@ -24,8 +24,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Filter.Internal private bool _canWrite = true; - private object _writeLock = new object(); - public StreamSocketOutput(string connectionId, Stream outputStream, MemoryPool memory, IKestrelTrace logger) { _...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.IO; using System.Text; using System.Threading; using System.Threading.Tasks; using Microsoft.AspNetCore.Server.Kestrel.Intern...
1
9,815
But But, overlapping async writes will get corrupted
aspnet-KestrelHttpServer
.cs
@@ -9,6 +9,7 @@ import ( "github.com/filecoin-project/go-filecoin/address" "github.com/filecoin-project/go-filecoin/chain" + "github.com/filecoin-project/go-filecoin/config" "github.com/filecoin-project/go-filecoin/metrics" "github.com/filecoin-project/go-filecoin/types" )
1
package core import ( "context" "sync" "github.com/ipfs/go-cid" "github.com/pkg/errors" "github.com/filecoin-project/go-filecoin/address" "github.com/filecoin-project/go-filecoin/chain" "github.com/filecoin-project/go-filecoin/metrics" "github.com/filecoin-project/go-filecoin/types" ) var mpSize = metrics.N...
1
18,431
Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?
filecoin-project-venus
go
@@ -443,9 +443,6 @@ public class PasscodeActivityTest extends v.onEditorAction(actionCode); } }); - waitSome(); - //the enter key will send ACTION_DOWN and ACTION_UP both events out - this.sendKeys(KeyEvent.KEYCODE_ENTER); } ca...
1
/* * Copyright (c) 2011, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice, this...
1
15,459
recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -46,6 +46,7 @@ Status FindPathValidator::validateWhere(WhereClause* where) { } where->setFilter(ExpressionUtils::rewriteLabelAttr2EdgeProp(expr)); auto filter = where->filter(); + NG_RETURN_IF_ERROR(checkExprDepth(filter)); auto typeStatus = deduceExprType(filter); NG_RETURN_IF_ERROR(typeStatus);
1
/* Copyright (c) 2020 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License. */ #include "graph/validator/FindPathValidator.h" #include "graph/planner/plan/Algo.h" #include "graph/planner/plan/Logic.h" #include "graph/util/ExpressionUtils.h" #include "graph/util/ValidateUtil.h"...
1
32,626
It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere.
vesoft-inc-nebula
cpp
@@ -95,7 +95,8 @@ public class DefaultMailCreatorTest { executableFlow.setStatus(Status.FAILED); assertTrue(mailCreator.createErrorEmail( executableFlow, message, azkabanName, scheme, clientHostname, clientPortNumber)); - assertEquals("Flow 'mail-creator-test' has failed on unit-tests", message.ge...
1
package azkaban.executor.mail; import azkaban.executor.ExecutableFlow; import azkaban.executor.ExecutionOptions; import azkaban.executor.Status; import azkaban.flow.Flow; import azkaban.flow.Node; import azkaban.project.Project; import azkaban.utils.EmailMessage; import com.google.common.base.Charsets; import com.goog...
1
13,098
why split into two lines?
azkaban-azkaban
java
@@ -48,8 +48,7 @@ import org.apache.iceberg.types.Types; * represented by a named {@link PartitionField}. */ public class PartitionSpec implements Serializable { - // start assigning IDs for partition fields at 1000 - private static final int PARTITION_DATA_ID_START = 1000; + public static final int PARTITION_D...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
15,738
Does this need to be public or can it be package-private?
apache-iceberg
java
@@ -86,6 +86,11 @@ class FileCard extends Component { render () { const file = this.props.files[this.props.fileCardFor] + let showEditButton + this.props.editors.forEach((target) => { + showEditButton = this.props.getPlugin(target.id).сanEditFile(file) + }) + return ( <div c...
1
const { h, Component } = require('preact') const getFileTypeIcon = require('../../utils/getFileTypeIcon') const ignoreEvent = require('../../utils/ignoreEvent.js') const FilePreview = require('../FilePreview') class FileCard extends Component { constructor (props) { super(props) const file = this.props.file...
1
13,285
Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?
transloadit-uppy
js
@@ -313,8 +313,14 @@ public class IntMultimap<T> implements Traversable<T>, Serializable { @Override public <U> Seq<Tuple2<T, U>> zip(Iterable<? extends U> that) { + return zipWith(that, Tuple::of); + } + + @Override + public <U, R> Seq<R> zipWith(Iterable<? extends U> that, BiFunction<? sup...
1
/* / \____ _ _ ____ ______ / \ ____ __ _______ * / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG * _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io * /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ...
1
8,872
`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?
vavr-io-vavr
java
@@ -436,6 +436,7 @@ class Status(AbstractCommand): print(x) print self.molecule._print_valid_platforms() + print self.molecule._print_valid_providers()
1
# Copyright (c) 2015 Cisco Systems # # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal # in the Software without restriction, including without limitation the rights # to use, copy, modify, merge, publish, ...
1
5,949
Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437.
ansible-community-molecule
py
@@ -27,11 +27,17 @@ func SetupGenesisNode(ctx context.Context, node *fat.Filecoin, gcURI string, min return err } - if _, err := node.WalletImport(ctx, minerOwner); err != nil { + wallet, err := node.WalletImport(ctx, minerOwner) + if err != nil { return err } - if _, err := node.MinerUpdatePeerid(ctx, mi...
1
package series import ( "context" "math/big" "gx/ipfs/QmXWZCd8jfaHmt4UDSnjKmGcrQMw95bDGWqEeVLVJjoANX/go-ipfs-files" "github.com/filecoin-project/go-filecoin/address" "github.com/filecoin-project/go-filecoin/tools/fat" ) // SetupGenesisNode will initialize, start, configure, and issue the "start mining" command...
1
16,531
Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?
filecoin-project-venus
go
@@ -30,9 +30,17 @@ export class ComicsPlayer { return this.setCurrentSrc(elem, options); } + destroy() { + // Nothing to do here + } + stop() { this.unbindEvents(); + const stopInfo = { + src: this.item + }; + Events.trigger(this, 'stopped', [...
1
// eslint-disable-next-line import/named, import/namespace import { Archive } from 'libarchive.js'; import loading from '../../components/loading/loading'; import dialogHelper from '../../components/dialogHelper/dialogHelper'; import keyboardnavigation from '../../scripts/keyboardNavigation'; import { appRouter } from ...
1
19,743
Could you move it after `stop`?
jellyfin-jellyfin-web
js
@@ -49,10 +49,10 @@ public final class ClassUtils { // 将一系列body parameter包装成一个class public static Class<?> getOrCreateBodyClass(OperationGenerator operationGenerator, - List<BodyParameter> bodyParameters) { + List<BodyParameter> bodyParameters, String bodyParamName) { SwaggerGenerator swaggerGene...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
11,344
The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?
apache-servicecomb-java-chassis
java
@@ -57,7 +57,6 @@ import static org.apache.solr.cloud.OverseerCollectionMessageHandler.NUM_SLICES; import static org.apache.solr.common.cloud.ZkStateReader.MAX_SHARDS_PER_NODE; import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR; -@Slow public class ShardSplitTest extends BasicDistributedZk...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
25,987
I don't think this should be here?
apache-lucene-solr
java
@@ -26,8 +26,9 @@ type SyscallsImpl interface { HashBlake2b(data []byte) [32]byte ComputeUnsealedSectorCID(ctx context.Context, proof abi.RegisteredProof, pieces []abi.PieceInfo) (cid.Cid, error) VerifySeal(ctx context.Context, info abi.SealVerifyInfo) error - VerifyPoSt(ctx context.Context, info abi.PoStVerifyIn...
1
package vmcontext import ( "context" "github.com/filecoin-project/go-address" "github.com/filecoin-project/specs-actors/actors/abi" specsruntime "github.com/filecoin-project/specs-actors/actors/runtime" "github.com/ipfs/go-cid" "github.com/filecoin-project/go-filecoin/internal/pkg/block" "github.com/filecoin-...
1
23,605
Either I'm missing something or specs actors should remove this call cc @anorth
filecoin-project-venus
go
@@ -119,12 +119,12 @@ namespace Reporting var counterWidth = Math.Max(test.Counters.Max(c => c.Name.Length) + 1, 15); var resultWidth = Math.Max(test.Counters.Max(c => c.Results.Max().ToString("F3").Length + c.MetricName.Length) + 2, 15); ret.AppendLine(test.Name); - ...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using Newtonsoft.Json; using Newtonsoft.Json.Serialization; using System; using System.Collections.Generic; using S...
1
12,552
Please undo all these changes as they are white-space only.
dotnet-performance
.cs
@@ -114,9 +114,11 @@ final class CountryConfigurator implements FieldConfiguratorInterface private function generateFormTypeChoices(string $countryCodeFormat): array { $choices = []; + $countriesAlpha2 = Countries::getNames(); $countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $cou...
1
<?php namespace EasyCorp\Bundle\EasyAdminBundle\Field\Configurator; use EasyCorp\Bundle\EasyAdminBundle\Config\Crud; use EasyCorp\Bundle\EasyAdminBundle\Config\Option\TextAlign; use EasyCorp\Bundle\EasyAdminBundle\Context\AdminContext; use EasyCorp\Bundle\EasyAdminBundle\Contracts\Field\FieldConfiguratorInterface; us...
1
13,132
You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : $countriesAlpha2;`
EasyCorp-EasyAdminBundle
php
@@ -311,7 +311,7 @@ def _comment(string): def _format_option_value(optdict, value): """return the user input's value from a 'compiled' value""" if optdict.get("type", None) == "py_version": - value = ".".join(str(item) for item in value) + value = "current Python interpreter version (e.g., '3.8...
1
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE try: import isort.api HAS_ISORT_5 = True except ImportError: # isort < 5 import isort HAS_ISORT_5 = False import codecs import os import re import sys i...
1
16,205
Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did.
PyCQA-pylint
py
@@ -95,6 +95,9 @@ def get_listens(user_name): :param max_ts: If you specify a ``max_ts`` timestamp, listens with listened_at less than (but not including) this value will be returned. :param min_ts: If you specify a ``min_ts`` timestamp, listens with listened_at greater than (but not including) this value wil...
1
import ujson from flask import Blueprint, request, jsonify, current_app from listenbrainz.webserver.errors import APIBadRequest, APIInternalServerError, APIUnauthorized, APINotFound, APIServiceUnavailable from listenbrainz.db.exceptions import DatabaseException from listenbrainz.webserver.decorators import crossdomain ...
1
16,964
> the time range the listen search the time range of the listen search?
metabrainz-listenbrainz-server
py
@@ -777,6 +777,8 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte, NULL_TERMINATE_BUFFER(pc_addr); DO_ONCE(SYSLOG(SYSLOG_ERROR, AVX_512_SUPPORT_INCOMPLETE, 2, get_application_name(), get_application_pid(), pc_addr)); + if (ZMM_ENABLED()) + dynamo_pres...
1
/* ********************************************************** * Copyright (c) 2011-2019 Google, Inc. All rights reserved. * Copyright (c) 2000-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
17,567
This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit.
DynamoRIO-dynamorio
c
@@ -50,6 +50,7 @@ Cluster Options: --routes <rurl-1, rurl-2> Routes to solicit and connect --cluster <cluster-url> Cluster URL for solicited routes --no_advertise <bool> Advertise known cluster IPs to clients + --conn_retries <number> For implicit routes, number of ...
1
// Copyright 2012-2016 Apcera Inc. All rights reserved. package main import ( "flag" "fmt" "net" "net/url" "os" "github.com/nats-io/gnatsd/auth" "github.com/nats-io/gnatsd/logger" "github.com/nats-io/gnatsd/server" ) var usageStr = ` Usage: gnatsd [options] Server Options: -a, --addr <host> ...
1
6,757
would call it connect_retries
nats-io-nats-server
go
@@ -3717,3 +3717,15 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils): for p_items, k_items in zip(pdf.iteritems(), kdf.iteritems()): self.assert_eq(repr(p_items), repr(k_items)) + + def test_tail(self): + if LooseVersion(pyspark.__version__) >= LooseVersion("3.0"): + ...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
15,682
Why are we using `repr`?
databricks-koalas
py
@@ -21,6 +21,6 @@ class ZMSBinder extends AbstractBinder { @Override protected void configure() { - bind(new ZMSImpl()).to(ZMSHandler.class); + bind(ZMSImplFactory.getZmsInstance()).to(ZMSHandler.class); } }
1
/* * Copyright 2017 Yahoo Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
5,495
I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS.
AthenZ-athenz
java
@@ -114,7 +114,11 @@ public class JavaProcessJobTest { props.put(CommonJobProperties.JOB_ID, "test_job"); props.put(CommonJobProperties.EXEC_ID, "123"); props.put(CommonJobProperties.SUBMIT_USER, "test_user"); - props.put("execute.as.user", "false"); + + //The execute-as-user binary requires specia...
1
/* * Copyright 2014 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
11,827
Consider consolidating the common code in a common setup method in tests?
azkaban-azkaban
java
@@ -18,7 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat; import static org.mockito.Mockito.verifyNoInteractions; import org.hyperledger.besu.ethereum.eth.EthProtocolConfiguration; -import org.hyperledger.besu.util.number.PositiveNumber; +import org.hyperledger.besu.ethereum.eth.ImmutableEthProtoc...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,993
q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?
hyperledger-besu
java
@@ -69,12 +69,12 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter { } @Override - public String getNicknameFor(Schema type) { + public String getNicknameFor(DiscoveryField type) { return typeNameConverter.getTypeName(type).getNickname(); } @Override - public String...
1
/* Copyright 2017 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in...
1
25,368
What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?
googleapis-gapic-generator
java
@@ -353,6 +353,8 @@ func environmentConfig() (Config, error) { errs = append(errs, err) } } + containerMetadataEnabled := utils.ParseBool(os.Getenv("ECS_ENABLE_CONTAINER_METADATA"), false) + dataDirOnHost := os.Getenv("ECS_HOST_DATA_DIR") if len(errs) > 0 { err = utils.NewMultiError(errs...)
1
// Copyright 2014-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
17,291
What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `"/var/lib/ecs"` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as wh...
aws-amazon-ecs-agent
go
@@ -54,6 +54,11 @@ eprint_version(void) #else const char *has_dbus = "✘"; #endif +#ifdef WITH_XCB_ERRORS + const char *has_xcb_errors = "✔"; +#else + const char *has_xcb_errors = "✘"; +#endif #ifdef HAS_EXECINFO const char *has_execinfo = "✔"; #else
1
/* * version.c - version message utility functions * * Copyright © 2008 Julien Danjou <julien@danjou.info> * Copyright © 2008 Hans Ulrich Niedermann <hun@n-dimensional.de> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published ...
1
17,240
btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font w...
awesomeWM-awesome
c
@@ -21,6 +21,7 @@ import ( "github.com/iotexproject/iotex-core/config" "github.com/iotexproject/iotex-core/pkg/log" "github.com/iotexproject/iotex-core/server/itx" + recoverutil "github.com/iotexproject/iotex-core/tools/util" ) // recoveryHeight is the blockchain height being recovered to
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
19,872
alias is not needed
iotexproject-iotex-core
go
@@ -19,7 +19,7 @@ DEFINE_int32(num_accept_threads, 1, "Number of threads to accept incoming connec DEFINE_bool(reuse_port, true, "Whether to turn on the SO_REUSEPORT option"); DEFINE_int32(listen_backlog, 1024, "Backlog of the listen socket"); DEFINE_string(listen_netdev, "any", "The network device to listen on"); -...
1
/* Copyright (c) 2018 - present, VE Software Inc. All rights reserved * * This source code is licensed under Apache 2.0 License * (found in the LICENSE.Apache file in the root directory) */ #include "base/Base.h" #include "graph/GraphFlags.h" DEFINE_int32(port, 34500, "Nebula Graph daemon's listen port"); DEFINE...
1
16,425
Do we need to include the path?
vesoft-inc-nebula
cpp
@@ -1254,8 +1254,8 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment) { const ( compactInterval = 2 * time.Minute - compactSizeMin = 32 * 1024 * 1024 - compactNumMin = 4 + compactSizeMin = 64 * 1024 * 1024 + compactNumMin = 8192 ) t := time.NewTicker(compactInterval)
1
// Copyright 2020-2021 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
12,784
During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB.
nats-io-nats-server
go
@@ -1,5 +1,7 @@ package platform +import "log" + // App is an interface apps for Drud Local must implement to use shared functionality type App interface { Init(string) error
1
package platform // App is an interface apps for Drud Local must implement to use shared functionality type App interface { Init(string) error Describe() (string, error) GetType() string ContainerPrefix() string ContainerName() string AppRoot() string GetName() string Start() error Stop() error DockerEnv() ...
1
10,993
Here I thought you always insisted on ` log "github.com/Sirupsen/logrus" ` :) I might do a PR that just globally switches that out wherever we have log.
drud-ddev
php
@@ -495,10 +495,9 @@ type KeyMetadata interface { GetTlfHandle() *TlfHandle // HasKeyForUser returns whether or not the given user has - // keys for at least one device at the given key - // generation. Returns false if the TLF is public, or if the - // given key generation is invalid. - HasKeyForUser(keyGen KeyG...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "time" "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/logger" "github.com/keybase/client/go/protocol/keybase1" "githu...
1
14,849
We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`.
keybase-kbfs
go
@@ -96,6 +96,7 @@ setup( 'dev': [ "Flask>=0.10.1, <0.13", "flake8>=3.2.1, <3.4", + "mock>=2.0.0, <3.0", "mypy>=0.501, <0.502", "rstcheck>=2.2, <4.0", "tox>=2.3, <3",
1
import os import runpy from codecs import open from setuptools import setup, find_packages # Based on https://github.com/pypa/sampleproject/blob/master/setup.py # and https://python-packaging-user-guide.readthedocs.org/ here = os.path.abspath(os.path.dirname(__file__)) with open(os.path.join(here, 'README.rst'), en...
1
13,222
Please use `from unittest import mock` instead of this package.
mitmproxy-mitmproxy
py
@@ -405,6 +405,11 @@ Aggregate.prototype.exec = function (callback) { prepareDiscriminatorPipeline(this); + if (this.options.cursor) + return this._model + .collection + .aggregate(this._pipeline, this.options || {}); + this._model .collection .aggregate(this._pipeline, this.options ||...
1
/*! * Module dependencies */ var Promise = require('./promise') , util = require('util') , utils = require('./utils') , Query = require('./query') , read = Query.prototype.read /** * Aggregate constructor used for building aggregation pipelines. * * ####Example: * * new Aggregate(); * new Aggr...
1
12,625
Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks.
Automattic-mongoose
js
@@ -68,7 +68,7 @@ Rails.application.configure do config.action_mailer.raise_delivery_errors = false # config.action_mailer.perform_deliveries = true config.action_mailer.delivery_method = :letter_opener_web - config.action_mailer.smtp_settings = { address: 'mailrelay.blackducksoftware.com', + config.action_m...
1
# frozen_string_literal: true Rails.application.configure do # Settings specified here will take precedence over those in # config/application.rb. # Code is not reloaded between requests. config.cache_classes = true # Eager load code on boot. This eager loads most of Rails and # your application in memor...
1
9,503
This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server.
blackducksoftware-ohloh-ui
rb
@@ -74,6 +74,9 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure /// </summary> public MemoryPoolBlock2 Next { get; set; } +#if DEBUG + // See http://www.philosophicalgeek.com/2014/09/29/digging-into-net-object-allocation-fundamentals/ + // for the cost of including a finali...
1
using System; using System.Diagnostics; using System.Runtime.InteropServices; using System.Text; namespace Microsoft.AspNet.Server.Kestrel.Infrastructure { /// <summary> /// Block tracking object used by the byte buffer memory pool. A slab is a large allocation which is divided into smaller blocks. The //...
1
6,907
Maybe we should have a Debug.Assert for when `Slab != null` to ensure that we are always returning the block (in our tests at least).
aspnet-KestrelHttpServer
.cs
@@ -106,10 +106,9 @@ options.vnode = vnode => { if (typeof type != 'function') { // Apply defaultValue to value if (props.defaultValue) { - if (!props.value && props.value !== 0) { + if (props.value == null && props.value !== 0) { props.value = props.defaultValue; } - delete props.defaultValue; ...
1
import { render as preactRender, hydrate as preactHydrate, options, toChildArray, Component } from 'preact'; import { applyEventNormalization } from './events'; const CAMEL_PROPS = /^(?:accent|alignment|arabic|baseline|cap|clip(?!PathU)|color|fill|flood|font|glyph(?!R)|horiz|marker(?!H|W|U)|overline|paint|stop|st...
1
15,433
Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defau...
preactjs-preact
js
@@ -25,9 +25,12 @@ import { getTimeInSeconds, numberFormat } from 'GoogleUtil'; import { getDataTableFromData, TableOverflowContainer } from 'GoogleComponents/data-table'; import PreviewTable from 'GoogleComponents/preview-table'; -const { __, sprintf } = wp.i18n; -const { map } = lodash; -const { Component } = wp....
1
/** * SearchConsoleDashboardWidgetKeywordTable component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache...
1
24,753
`lodash` shouldn't be grouped under WordPress dependencies
google-site-kit-wp
js