patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -453,7 +453,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
blocksFetched := uint64(1) // we already got the first block in the previous step.
var blk *bookkeeping.Block
var client FetcherClient
- for attemptsCount := uint64(1); blocksFetched <= lookback; attemptsCount++ {
+... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 41,290 | Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount? | algorand-go-algorand | go |
@@ -21,7 +21,7 @@
"""Installation script for Python nupic package."""
-import os
+import OOOOOOOOOOOos
import pkg_resources
import sys
| 1 | # ----------------------------------------------------------------------
# Numenta Platform for Intelligent Computing (NuPIC)
# Copyright (C) 2015, Numenta, Inc. Unless you have an agreement
# with Numenta, Inc., for a separate license for this software code, the
# following terms and conditions apply:
#
# This progra... | 1 | 21,617 | I don't think this will work. | numenta-nupic | py |
@@ -0,0 +1,11 @@
+using System.IO.Pipelines;
+
+namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+{
+ public interface IHttpParser
+ {
+ bool ParseRequestLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpRequestLineHandler;
+
+ bool... | 1 | 1 | 11,709 | Since http2 is coming do we want to call this something more specific? | aspnet-KestrelHttpServer | .cs | |
@@ -11,8 +11,8 @@
</div>
</nav>
-<%= content_tag :div, class: 'navbar-search navbar navbar-light bg-light', role: 'navigation', aria: { label: t('blacklight.search.header') } do %>
+<div class="navbar-search navbar navbar-light bg-light" role="navigation">
<div class="<%= container_classes %>">
<%= render... | 1 | <nav class="navbar navbar-expand-md navbar-dark bg-dark topbar" role="navigation">
<div class="<%= container_classes %>">
<%= link_to application_name, root_path, class: 'mb-0 navbar-brand navbar-logo' %>
<button class="navbar-toggler navbar-toggler-right" type="button" data-toggle="collapse" data-bs-toggle="... | 1 | 8,873 | I don't think we want to revert the accessibility issues the tool caught, do we? | projectblacklight-blacklight | rb |
@@ -285,8 +285,11 @@ func (rt *RequestTracker) Accept() (conn net.Conn, err error) {
rt.hostRequests.pruneRequests(rateLimitingWindowStartTime)
originConnections := rt.hostRequests.countOriginConnections(trackerRequest.remoteHost, rateLimitingWindowStartTime)
+ remoteHostIsNonLocal := (!rt.config.DisableLocalh... | 1 | // Copyright (C) 2019-2021 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 42,060 | I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local. | algorand-go-algorand | go |
@@ -105,7 +105,7 @@ export function initDebug() {
`\n\n${getOwnerStack(vnode)}`
);
} else if (type != null && typeof type === 'object') {
- if (type._lastDomChild !== undefined && type._dom !== undefined) {
+ if (type._lastDomChildSibling !== undefined && type._dom !== undefined) {
throw new Error... | 1 | import { checkPropTypes } from './check-props';
import { options, Component } from 'preact';
import {
ELEMENT_NODE,
DOCUMENT_NODE,
DOCUMENT_FRAGMENT_NODE
} from './constants';
import {
getOwnerStack,
setupComponentStack,
getCurrentVNode,
getDisplayName
} from './component-stack';
const isWeakMapSupported = type... | 1 | 15,135 | Hmm I think I might've messed up this condition here... Need to look more at it | preactjs-preact | js |
@@ -118,11 +118,9 @@ class DocumentQueue:
if doc_type == DocTypes.PACKAGE:
if not handle or not package_hash or not pointer_file:
raise ValueError("missing required argument for package document")
- if (
- package_stats
- and not isinstance... | 1 | """ core logic for fetching documents from S3 and queueing them locally before
sending to elastic search in memory-limited batches"""
from datetime import datetime
from enum import Enum
from math import floor
from typing import Dict, List
import os
from aws_requests_auth.aws_auth import AWSRequestsAuth
import boto3
fr... | 1 | 19,251 | This also makes the exception to be raised on non-dict falsy values which I think was expected. | quiltdata-quilt | py |
@@ -173,7 +173,7 @@ class Dataset(Element):
# In the 1D case the interfaces should not automatically add x-values
# to supplied data
- _auto_indexable_1d = False
+ _auto_indexable_1d = True
# Define a class used to transform Datasets into other Element types
_conversion_interface = DataCon... | 1 | from __future__ import absolute_import
try:
import itertools.izip as zip
except ImportError:
pass
import numpy as np
import param
from ..dimension import redim
from ..util import dimension_range, unique_iterator
from .interface import Interface, iloc, ndloc
from .array import ArrayInterface
from .dictionary ... | 1 | 20,077 | Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR... | holoviz-holoviews | py |
@@ -6,9 +6,9 @@ setup(
py_modules=["rtool"],
install_requires=[
"click>=6.2, <7.0",
- "twine>=1.6.5, <1.9",
+ "twine>=1.6.5, <1.10",
"pysftp==0.2.8",
- "cryptography>=1.6, <1.7",
+ "cryptography>=1.6, <1.9",
],
entry_points={
"console_scripts": ... | 1 | from setuptools import setup
setup(
name='mitmproxy-rtool',
version="1.0",
py_modules=["rtool"],
install_requires=[
"click>=6.2, <7.0",
"twine>=1.6.5, <1.9",
"pysftp==0.2.8",
"cryptography>=1.6, <1.7",
],
entry_points={
"console_scripts": [
"r... | 1 | 13,258 | Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well. | mitmproxy-mitmproxy | py |
@@ -0,0 +1,13 @@
+#include <iostream>
+#include <rai/lib/utility.hpp>
+
+void release_assert_internal (bool check, const char * check_expr, const char * file, unsigned int line)
+{
+ if (check)
+ {
+ return;
+ }
+
+ std::cerr << "Assertion (" << check_expr << ") failed " << file << ":" << line << std::endl;
+ abort();... | 1 | 1 | 14,071 | Will calling `abort()` cause problems for our test suite? | nanocurrency-nano-node | cpp | |
@@ -292,6 +292,11 @@ ast_result_t pass_expr(ast_t** astp, pass_opt_t* options)
case TK_ADDRESS: r = expr_addressof(options, ast); break;
case TK_DIGESTOF: r = expr_digestof(options, ast); break;
+ case TK_OBJECT:
+ if(!expr_object(options, astp))
+ return AST_FATAL;
+ break;
+
... | 1 | #include "expr.h"
#include "../expr/literal.h"
#include "../expr/reference.h"
#include "../expr/operator.h"
#include "../expr/postfix.h"
#include "../expr/call.h"
#include "../expr/control.h"
#include "../expr/match.h"
#include "../expr/array.h"
#include "../expr/ffi.h"
#include "../expr/lambda.h"
#include "ponyassert.... | 1 | 10,042 | for my own edificaton, what's this? | ponylang-ponyc | c |
@@ -248,13 +248,14 @@ func (sf *factory) NewWorkingSet() (WorkingSet, error) {
// Commit persists all changes in RunActions() into the DB
func (sf *factory) Commit(ws WorkingSet) error {
+ if ws == nil {
+ return nil
+ }
sf.mutex.Lock()
defer sf.mutex.Unlock()
- if ws != nil {
- if sf.currentChainHeight != ws... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 13,303 | make it harmless to commit ws == nil | iotexproject-iotex-core | go |
@@ -59,6 +59,8 @@ var locationsReplacement = regexp.MustCompile(`\$\(locations ([^\)]+)\)`)
var exeReplacement = regexp.MustCompile(`\$\(exe ([^\)]+)\)`)
var outExeReplacement = regexp.MustCompile(`\$\(out_exe ([^\)]+)\)`)
var outReplacement = regexp.MustCompile(`\$\(out_location ([^\)]+)\)`)
+var absOutExeReplaceme... | 1 | // Replacement of sequences in genrule commands.
//
// Genrules can contain certain replacement variables which Please substitutes
// with locations of the actual thing before running.
// The following replacements are currently made:
//
// $(location //path/to:target)
// Expands to the output of the given build rule... | 1 | 9,232 | Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go? | thought-machine-please | go |
@@ -24,8 +24,11 @@ import (
var _reqBody = []byte("hello")
-func yarpcEcho(ctx context.Context, reqMeta yarpc.ReqMeta, body []byte) ([]byte, yarpc.ResMeta, error) {
- return body, yarpc.NewResMeta().Headers(reqMeta.Headers()), nil
+func yarpcEcho(ctx context.Context, body []byte) ([]byte, error) {
+ for _, k := ra... | 1 | package yarpc_test
import (
"bytes"
"context"
"io"
"io/ioutil"
"net"
"net/http"
"testing"
"time"
"go.uber.org/yarpc"
"go.uber.org/yarpc/encoding/raw"
yhttp "go.uber.org/yarpc/transport/http"
ytchannel "go.uber.org/yarpc/transport/tchannel"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testi... | 1 | 12,020 | That's actually not as bad as I thought it was going to be. | yarpc-yarpc-go | go |
@@ -198,6 +198,11 @@ public class DatasetServiceBean implements java.io.Serializable {
return em.createQuery("SELECT o.id FROM Dataset o WHERE o.indexTime IS null ORDER BY o.id DESC", Long.class).getResultList();
}
+ //Used in datasets listcurationstatus API
+ public List<Dataset> findAllUnpublish... | 1 | package edu.harvard.iq.dataverse;
import edu.harvard.iq.dataverse.authorization.AuthenticationServiceBean;
import edu.harvard.iq.dataverse.authorization.Permission;
import edu.harvard.iq.dataverse.authorization.users.AuthenticatedUser;
import edu.harvard.iq.dataverse.authorization.users.User;
import edu.harvard.iq.dat... | 1 | 44,861 | Hmm, I'm surprised if we don't already have a "find all unpublished datasets" method but I don't really know. Maybe @scolapasta knows. | IQSS-dataverse | java |
@@ -598,6 +598,12 @@ class Python3Checker(checkers.BaseChecker):
"variables will be deleted outside of the "
"comprehension.",
),
+ "C1601": (
+ "Consider using Python 3 style super() without arguments",
+ "old-style-super",
+ "Emitted when call... | 1 | # -*- coding: utf-8 -*-
# Copyright (c) 2014-2019 Claudiu Popa <pcmanticore@gmail.com>
# Copyright (c) 2014-2015 Brett Cannon <brett@python.org>
# Copyright (c) 2015 Simu Toni <simutoni@gmail.com>
# Copyright (c) 2015 Pavel Roskin <proski@gnu.org>
# Copyright (c) 2015 Ionel Cristian Maries <contact@ionelmc.ro>
# Copyri... | 1 | 11,964 | The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all. | PyCQA-pylint | py |
@@ -0,0 +1,18 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
+{
+ /// <summary>
+ /// Feature to set the minimum data rate at... | 1 | 1 | 13,638 | I would change "should be sent" to "must be received". | aspnet-KestrelHttpServer | .cs | |
@@ -24,6 +24,8 @@ import (
"github.com/openebs/maya/pkg/storagepool"
)
+
+// DeleteStoragePool receives StoragePoolClaim object and deletes it.
func DeleteStoragePool(spcGot *v1alpha1.StoragePoolClaim) error {
// Business logic for deletion of storagepool
glog.Infof("Storagepool delete event received for sto... | 1 | /*
Copyright 2017 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 10,130 | Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.` | openebs-maya | go |
@@ -58,4 +58,16 @@ public final class RestConst {
public static final String CONSUMER_HEADER = "servicecomb-rest-consumer-header";
public static final String READ_STREAM_PART = "servicecomb-readStreamPart";
+
+ public static final String UPLOAD_DIR = "cse.uploads.directory";
+
+ // limit of one upload file, o... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 9,813 | It's better to use servicecomb now. | apache-servicecomb-java-chassis | java |
@@ -58,12 +58,13 @@ var PolicyChain = policies.Chain{
type controller struct {
// the policies to use to define readiness - named here to make testing simpler
- policyChain policies.Chain
- certificateLister cmlisters.CertificateLister
- certificateRequestLister cmlisters.CertificateRequestList... | 1 | /*
Copyright 2020 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 24,222 | Make the flag derived default available in the readiness controller | jetstack-cert-manager | go |
@@ -278,6 +278,10 @@ func TestReconcileClusterSync_NoWorkToDo(t *testing.T) {
}),
),
},
+ {
+ name: "syncset pause",
+ cd: cdBuilder(scheme).GenericOptions(testgeneric.WithAnnotation(constants.SyncsetPauseAnnotation, "true")).Build(),
+ },
}
for _, tc := range cases {
t.Run(tc.name, func(t *t... | 1 | package clustersync
import (
"context"
"fmt"
"reflect"
"testing"
"time"
"github.com/golang/mock/gomock"
"github.com/pkg/errors"
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"k8s.io/utils/pointer"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io... | 1 | 14,535 | Confirmed this test fails when the fix is reverted | openshift-hive | go |
@@ -38,6 +38,9 @@ func NewCollector(options *LogOptions) *Collector {
// Archive creates ZIP archive containing all node log files.
func (c *Collector) Archive() (outputFilepath string, err error) {
+ if c.options.Filepath == "" {
+ return "", errors.New("file logging is disabled, can't retrieve logs")
+ }
filep... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 15,293 | This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`. | mysteriumnetwork-node | go |
@@ -14,6 +14,15 @@ class BaseDenseHead(BaseModule, metaclass=ABCMeta):
def __init__(self, init_cfg=None):
super(BaseDenseHead, self).__init__(init_cfg)
+ def init_weights(self):
+ super(BaseDenseHead, self).init_weights()
+ # avoid init_cfg overwrite the initialization of `conv_offset`
... | 1 | # Copyright (c) OpenMMLab. All rights reserved.
from abc import ABCMeta, abstractmethod
import torch
from mmcv.ops import batched_nms
from mmcv.runner import BaseModule, force_fp32
from mmdet.core.utils import filter_scores_and_topk, select_single_mlvl
class BaseDenseHead(BaseModule, metaclass=ABCMeta):
"""Base... | 1 | 26,694 | DCN should not be able to use `init_cfg`. | open-mmlab-mmdetection | py |
@@ -28,7 +28,7 @@ namespace OpenTelemetry.Shims.OpenTracing
{
if (!spanContext.IsValid)
{
- throw new ArgumentException(nameof(spanContext));
+ throw new ArgumentException($"{nameof(spanContext)} must be valid.");
}
this.SpanCo... | 1 | // <copyright file="SpanContextShim.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apach... | 1 | 16,575 | It is a bit weird to see a message like "something must be valid". | open-telemetry-opentelemetry-dotnet | .cs |
@@ -119,10 +119,10 @@ public class Standalone implements CliCommand {
LoggingOptions loggingOptions = new LoggingOptions(config);
loggingOptions.configureLogging();
- LOG.info("Logging configured.");
+ LOG.finest("Logging configured.");
DistributedTracer tracer = loggingOptions.getTra... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 16,466 | Again. This is part of the start up of the server, and the diagnostics are helpful. | SeleniumHQ-selenium | py |
@@ -139,6 +139,12 @@ describe Travis::Build::Script::R, :sexp do
echo: true, timing: true]
end
+ it 'skips PDF manual when LaTeX is disabled' do
+ data[:config][:latex] = false
+ should include_sexp [:cmd, /.*R CMD check.* --no-manual.*/,
+ echo: true, timin... | 1 | require 'spec_helper'
describe Travis::Build::Script::R, :sexp do
let (:data) { payload_for(:push, :r) }
let (:script) { described_class.new(data) }
subject { script.sexp }
it_behaves_like 'a build script sexp'
it 'normalizes bioc-devel correctly' do
data[:config][:r] = 'bioc-devel'
should ... | 1 | 14,201 | I think you need a `,` at the end of the line? | travis-ci-travis-build | rb |
@@ -54,10 +54,7 @@ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbEntityOperation;
import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation;
import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation.State;
import org.camunda.bpm.engine.impl.db.entitymanager.operation... | 1 | /*
* Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH
* under one or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information regarding copyright
* ownership. Camunda licenses this file to you under the Apache License,
* Version 2.0; y... | 1 | 11,001 | Please avoid wildcard imports. | camunda-camunda-bpm-platform | java |
@@ -84,6 +84,9 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
using (HttpClient client = new HttpClient())
{
client.DefaultRequestHeaders.Clear();
+
+ // In random occassions the request fails if the network is slow and it tak... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using Microsoft.Build.Framework;
using Microsoft.Build.Utilities;
using System;
using System.Collections.Generic;
us... | 1 | 14,122 | Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL. | dotnet-buildtools | .cs |
@@ -238,9 +238,17 @@ func run(o *Options) error {
}
var egressController *egress.EgressController
+ var nodeIP net.IP
+ if nodeConfig.NodeIPv4Addr != nil {
+ nodeIP = nodeConfig.NodeIPv4Addr.IP
+ } else if nodeConfig.NodeIPv6Addr != nil {
+ nodeIP = nodeConfig.NodeIPv6Addr.IP
+ } else {
+ return fmt.Errorf("in... | 1 | // Copyright 2019 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 44,082 | dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family? | antrea-io-antrea | go |
@@ -230,7 +230,7 @@ class ServerTLSLayer(_TLSLayer):
server.sni = self.context.client.sni.encode("idna")
else:
server.sni = server.address[0].encode("idna")
- self.tls[server].set_tlsext_host_name(server.sni)
+ self.tls[server]... | 1 | import os
import struct
from typing import MutableMapping, Optional, Iterator, Generator, Any
from OpenSSL import SSL
from mitmproxy.certs import CertStore
from mitmproxy.net.tls import ClientHello
from mitmproxy.proxy.protocol import tls
from mitmproxy.proxy2 import context
from mitmproxy.proxy2 import layer, comman... | 1 | 14,241 | Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me! | mitmproxy-mitmproxy | py |
@@ -57,12 +57,12 @@ public class TestPerformance extends LuceneTestCase {
@Test
public void en() throws Exception {
- checkAnalysisPerformance("en", 1_000_000);
+ checkAnalysisPerformance("en", 1_200_000);
}
@Test
public void en_suggest() throws Exception {
- checkSuggestionPerformance("en",... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 40,790 | Hmm what are these magical constant numbers? And why does this change mean they should increase? | apache-lucene-solr | java |
@@ -36,7 +36,7 @@ import logging.config
import urlparse
from boto.exception import InvalidUriError
-__version__ = '2.8.0-dev'
+__version__ = '2.8.0'
Version = __version__ # for backware compatibility
UserAgent = 'Boto/%s (%s)' % (__version__, sys.platform) | 1 | # Copyright (c) 2006-2012 Mitch Garnaat http://garnaat.org/
# Copyright (c) 2010-2011, Eucalyptus Systems, Inc.
# Copyright (c) 2011, Nexenta Systems Inc.
# Copyright (c) 2012 Amazon.com, Inc. or its affiliates.
# Copyright (c) 2010, Google, Inc.
# All rights reserved.
#
# Permission is hereby granted, free of charge, ... | 1 | 8,881 | This change shouldn't be included with this push. Shouldn't push version changes with a pull-request. | boto-boto | py |
@@ -97,6 +97,9 @@ func (h handler) handle(ctx context.Context, call inboundCall) {
err := h.callHandler(ctx, call, responseWriter)
+ // echo accepted rpc-service in response header in any status
+ responseWriter.addHeader(RespondServiceHeaderKey, call.ServiceName())
+
// black-hole requests on resource exhauste... | 1 | // Copyright (c) 2018 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 16,753 | nit: let's move this right under where we create the `responseWriter`, before `h.callHandler` | yarpc-yarpc-go | go |
@@ -361,7 +361,7 @@ void nano::mdb_store::upgrade_v14_to_v15 (nano::write_transaction & transaction_
nano::mdb_val value{ data.size (), (void *)data.data () };
auto s = mdb_put (env.tx (transaction_a), state_blocks_new, nano::mdb_val (hash), value, MDB_APPEND);
- release_assert_success (s);
+ release_assert_s... | 1 | #include <nano/crypto_lib/random_pool.hpp>
#include <nano/lib/utility.hpp>
#include <nano/node/common.hpp>
#include <nano/node/lmdb/lmdb.hpp>
#include <nano/node/lmdb/lmdb_iterator.hpp>
#include <nano/node/lmdb/wallet_value.hpp>
#include <nano/secure/buffer.hpp>
#include <nano/secure/versioning.hpp>
#include <boost/fi... | 1 | 16,715 | The way it was implemented, needed to pass the template values. Please check whether we want this. | nanocurrency-nano-node | cpp |
@@ -36,7 +36,8 @@ var daemonCmd = &cmds.Command{
cmdkit.BoolOption(OfflineMode, "start the node without networking"),
cmdkit.BoolOption(ELStdout),
cmdkit.BoolOption(IsRelay, "advertise and allow filecoin network traffic to be relayed through this node"),
- cmdkit.StringOption(BlockTime, "time a node waits bef... | 1 | package commands
import (
"context"
"fmt"
"net/http"
_ "net/http/pprof" // nolint: golint
"os"
"os/signal"
"syscall"
"time"
cmdkit "github.com/ipfs/go-ipfs-cmdkit"
cmds "github.com/ipfs/go-ipfs-cmds"
cmdhttp "github.com/ipfs/go-ipfs-cmds/http"
writer "github.com/ipfs/go-log/writer"
ma "github.com/multifo... | 1 | 23,810 | Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't... | filecoin-project-venus | go |
@@ -18,6 +18,7 @@
# WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
# IN THE SOFTWARE.
+from __future__ import print_function
import errno
import httplib | 1 | # Copyright 2010 Google Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a
# copy of this software and associated documentation files (the
# "Software"), to deal in the Software without restriction, including
# without limitation the rights to use, copy, modify, merge, publish, dis-
# trib... | 1 | 10,155 | Is this import needed? | boto-boto | py |
@@ -68,6 +68,8 @@ storiesOf( 'Dashboard', module )
<PostSearcher />
</WithTestRegistry>
);
+ }, {
+ padding: 0,
} )
.add( 'URL Search Widget', () => {
const setupRegistry = ( registry ) => provideSiteInfo( registry ); | 1 | /**
* Dashboard Page Stories.
*
* Site Kit by Google, Copyright 2021 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*... | 1 | 38,254 | Dashboard stories also need to have the default padding. | google-site-kit-wp | js |
@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
*/
String TARGET_FILE_SIZE_BYTES = "target-file-size-bytes";
+ /**
+ * If the compaction should commit rewritten data files using the sequence number at compaction start time instead
+ * of optimistically i... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 45,768 | Is there a reason why we wouldn't use this as the default? | apache-iceberg | java |
@@ -15,7 +15,7 @@ void CreateEdgeProcessor::process(const cpp2::CreateEdgeReq& req) {
{
// if there is an edge of the same name
// TODO: there exists race condition, we should address it in the future
- folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
+ folly::SharedMu... | 1 | /* Copyright (c) 2018 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "meta/processors/schemaMan/CreateEdgeProcessor.h"
namespace nebula {
namespace meta {
void CreateEdgeProcesso... | 1 | 27,753 | if there is an tag of the same name? | vesoft-inc-nebula | cpp |
@@ -1,10 +1,8 @@
package net
import (
- "bytes"
"errors"
"fmt"
- "os/exec"
"path/filepath"
"runtime"
| 1 | package net
import (
"bytes"
"errors"
"fmt"
"os/exec"
"path/filepath"
"runtime"
"github.com/vishvananda/netlink"
"github.com/vishvananda/netns"
)
var ErrLinkNotFound = errors.New("Link not found")
// NB: The following function is unsafe, because:
// - It changes a network namespace (netns) of an OS thre... | 1 | 15,494 | I'd add `// +build go1.10` to prevent from accidentally compiling with older Go. | weaveworks-weave | go |
@@ -1,10 +1,12 @@
+from __future__ import unicode_literals
+
import numpy as np
import param
from ..core import (HoloMap, DynamicMap, CompositeOverlay, Layout,
GridSpace, NdLayout, Store)
from ..core.util import (match_spec, is_number, wrap_tuple,
- get_overlay_spec, u... | 1 | import numpy as np
import param
from ..core import (HoloMap, DynamicMap, CompositeOverlay, Layout,
GridSpace, NdLayout, Store)
from ..core.util import (match_spec, is_number, wrap_tuple,
get_overlay_spec, unique_iterator)
def displayable(obj):
"""
Predicate that r... | 1 | 14,548 | Not sure how this import relates to the PR but seems like a good idea anyway... | holoviz-holoviews | py |
@@ -5,6 +5,7 @@
#include "../CustomBuild/ESPEasyLimits.h"
#include "../DataStructs/DeviceStruct.h"
#include "../../ESPEasy_common.h"
+#include "../WebServer/HardwarePage.h"
template<unsigned int N_TASKS>
SettingsStruct_tmpl<N_TASKS>::SettingsStruct_tmpl() : ResetFactoryDefaultPreference(0) { | 1 | #include "../DataStructs/SettingsStruct.h"
#include "../Globals/Plugins.h"
#include "../Globals/CPlugins.h"
#include "../CustomBuild/ESPEasyLimits.h"
#include "../DataStructs/DeviceStruct.h"
#include "../../ESPEasy_common.h"
template<unsigned int N_TASKS>
SettingsStruct_tmpl<N_TASKS>::SettingsStruct_tmpl() : ResetFac... | 1 | 22,639 | Hmm this is strange, why should the SettingsStruct import something from `WebServer` ? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around. | letscontrolit-ESPEasy | cpp |
@@ -4,13 +4,16 @@
using System;
using Microsoft.AspNet.Builder;
using Microsoft.AspNet.Http;
+using Microsoft.Framework.Logging;
namespace SampleApp
{
public class Startup
{
- public void Configure(IApplicationBuilder app)
+ public void Configure(IApplicationBuilder app, ILoggerFactory lo... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using Microsoft.AspNet.Builder;
using Microsoft.AspNet.Http;
namespace SampleApp
{
public class Startup
{
public void Co... | 1 | 5,748 | nit: Space between these lines. | aspnet-KestrelHttpServer | .cs |
@@ -353,7 +353,7 @@ class ResultsProvider(object):
:type listeners: list[AggregatorListener]
"""
- def __init__(self):
+ def __init__(self, translator=None):
super(ResultsProvider, self).__init__()
self.cumulative = BetterDict()
self.track_percentiles = [] | 1 | """
Aggregating results into DataPoints
Copyright 2015 BlazeMeter Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable ... | 1 | 13,874 | Why aggregator should have this translator? It's Selenium specifics for now... | Blazemeter-taurus | py |
@@ -136,6 +136,13 @@ public abstract class FieldComparator<T> {
}
}
+ /**
+ * Informs the comparator that sorting is done in reverse.
+ * This is necessary only for skipping functionality.
+ */
+ public void setReverse() {
+ }
+
/**
* Base FieldComparator class for numeric types | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 36,122 | I don't understand why this function is needed ? Can't you just pass the information when the `DocComparator` is created in the SortField ? | apache-lucene-solr | java |
@@ -11,5 +11,7 @@ class MailchimpFulfillmentJob < MailchimpJob
def subscribe(list_id, email)
client.list_subscribe(id: list_id, email_address: email, double_optin: false)
+ rescue Gibbon::MailChimpError => e
+ raise e unless MAILCHIMP_EMAIL_ERROR_CODES.include?(e.code)
end
end | 1 | class MailchimpFulfillmentJob < MailchimpJob
MASTER_LIST_ID = '66f4d45e54'
def perform
lists = client.lists(filters: { list_name: list_name })
subscribe(lists['data'].first['id'], email)
subscribe(MASTER_LIST_ID, email)
end
private
def subscribe(list_id, email)
client.list_subscribe(id: lis... | 1 | 7,646 | This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse? | thoughtbot-upcase | rb |
@@ -90,6 +90,9 @@ function fetchWithTimeout(input, init) {
url: xhr.responseURL,
headers: xhr.responseHeaders
};
+ if (!options.headers) {
+ options.headers = {'content-type': xhr.getResponseHeader('content-type')};
+ }
con... | 1 | ////////////////////////////////////////////////////////////////////////////
//
// Copyright 2016 Realm Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/li... | 1 | 17,610 | It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd. | realm-realm-js | js |
@@ -107,8 +107,16 @@ noreturn static void exec_xwayland(struct wlr_xwayland_server *server) {
dup2(devnull, STDERR_FILENO);
}
+ const char *xwayland_path = getenv("WLR_XWAYLAND");
+ if (xwayland_path) {
+ wlr_log(WLR_INFO, "Using Xwayland binary to '%s' due to WLR_XWAYLAND",
+ xwayland_path);
+ } else {
+ xw... | 1 | #define _POSIX_C_SOURCE 200809L
#include <errno.h>
#include <fcntl.h>
#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <stdlib.h>
#include <stdnoreturn.h>
#include <sys/socket.h>
#include <sys/types.h>
#include <sys/wait.h>
#include <time.h>
#include <unistd.h>
#include <wayland-server-core.h>
#inclu... | 1 | 16,078 | Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env. | swaywm-wlroots | c |
@@ -0,0 +1,13 @@
+// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the "URL folder". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The fo... | 1 | 1 | 11,074 | Should we have an avatar, truncate, etc examples, too? | salesforce-design-system-react | js | |
@@ -31,7 +31,6 @@ class _MissingPandasLikeIndex(object):
# Properties
nbytes = unsupported_property('nbytes')
- shape = unsupported_property('shape')
# Deprecated properties
strides = unsupported_property('strides', deprecated=True) | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 13,254 | could you add this to `docs/source/reference/indexing.rst` ? | databricks-koalas | py |
@@ -3,10 +3,10 @@
# Copyright (C) 2003 Rational Discovery LLC
# All Rights Reserved
#
-import sys
+
+import six
from rdkit.VLib.Node import VLibNode
-from rdkit import six
class FilterNode(VLibNode): | 1 | # $Id$
#
# Copyright (C) 2003 Rational Discovery LLC
# All Rights Reserved
#
import sys
from rdkit.VLib.Node import VLibNode
from rdkit import six
class FilterNode(VLibNode):
""" base class for nodes which filter their input
Assumptions:
- filter function takes a number of arguments equal to the
... | 1 | 15,846 | Why the change from rdkit.six to six? | rdkit-rdkit | cpp |
@@ -78,6 +78,12 @@ def renderView(request):
# Now we prepare the requested data
if requestOptions['graphType'] == 'pie':
+ targets = [target for target in requestOptions['targets'] if target.find(':') < 0]
+ if settings.REMOTE_PREFETCH_DATA and not requestOptions.get('localOnly'):
+ log.rendering("Pr... | 1 | """Copyright 2008 Orbitz WorldWide
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software... | 1 | 11,687 | Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it. | graphite-project-graphite-web | py |
@@ -1892,7 +1892,7 @@ describe('Bulk', function () {
expect(result).to.exist;
bulk.execute(err => {
- expect(err).to.match(/Batch cannot be re-executed/);
+ expect(err).to.match(/This batch has already been executed, create new batch to execute/);
done();
});
... | 1 | 'use strict';
const {
withClient,
withClientV2,
withMonitoredClient,
setupDatabase,
ignoreNsNotFound
} = require('./shared');
const test = require('./shared').assert;
const { MongoDriverError } = require('../../src/error');
const { Long } = require('../../src');
const crypto = require('crypto');
const chai = ... | 1 | 20,693 | I think we should change this to an instanceOf check for MongoBatchReExecutionError | mongodb-node-mongodb-native | js |
@@ -34,7 +34,7 @@ type ProfileDecoder struct {
}
func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
- return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
+ return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
}
func (p *ProfileDecoder)... | 1 | // Copyright (c) 2018 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,619 | Required by the libcalico-go changes | projectcalico-felix | go |
@@ -1193,3 +1193,12 @@ type MutableBareRootMetadataNoImplError struct {
func (e MutableBareRootMetadataNoImplError) Error() string {
return "Does not implement MutableBareRootMetadata"
}
+
+// blockNonExistentError is returned when a block doesn't exist.
+type blockNonExistentError struct {
+ id BlockID
+}
+
+func ... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/protocol/keybase1"
)
// ErrorFile is the name of the virtual file... | 1 | 13,008 | Explain why we don't reuse the corresponding server error locally? | keybase-kbfs | go |
@@ -417,7 +417,7 @@ public class SolrSearchResult {
.add("is_unpublished_state", this.isUnpublishedState())
.add("is_published", this.isPublishedState())
.add("is_deaccesioned", this.isDeaccessionedState())
- .add("date_to_display_on_card", this.dateToDi... | 1 | package edu.harvard.iq.dataverse.search;
import edu.harvard.iq.dataverse.DataFile;
import edu.harvard.iq.dataverse.Dataset;
import edu.harvard.iq.dataverse.DvObject;
import edu.harvard.iq.dataverse.api.Util;
import edu.harvard.iq.dataverse.dataset.DatasetThumbnail;
import edu.harvard.iq.dataverse.util.DateUtil;
import... | 1 | 39,514 | @JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method). | IQSS-dataverse | java |
@@ -20,8 +20,6 @@ var (
ErrNoConnection = errors.New("no connection exists")
// ErrAlreadyExists error indicates that aciton applieto to manager expects no active connection (i.e. connect)
ErrAlreadyExists = errors.New("connection already exists")
- // ErrConnectionCancelled indicates that connection in progress ... | 1 | package connection
import (
"errors"
log "github.com/cihub/seelog"
"github.com/mysterium/node/communication"
"github.com/mysterium/node/identity"
"github.com/mysterium/node/openvpn"
"github.com/mysterium/node/openvpn/middlewares/client/bytescount"
"github.com/mysterium/node/server"
"github.com/mysterium/node/s... | 1 | 10,898 | What was wrong with more concrete error? | mysteriumnetwork-node | go |
@@ -14,3 +14,17 @@ function roots_get_search_form($form) {
return $form;
}
add_filter('get_search_form', 'roots_get_search_form');
+
+/**
+ * Add page slug to body_class() classes if it doesn't exist
+ */
+function roots_body_class($classes) {
+ // Add post/page slug
+ if (is_single() || is_page() && !is_front_p... | 1 | <?php
/**
* Utility functions
*/
function is_element_empty($element) {
$element = trim($element);
return !empty($element);
}
// Tell WordPress to use searchform.php from the templates/ directory
function roots_get_search_form($form) {
$form = '';
locate_template('/templates/searchform.php', true, false);
r... | 1 | 8,536 | can you replace the tabs with 2 spaces please to match the rest of the project? | roots-sage | php |
@@ -14,6 +14,8 @@ const IntegralKind = "integral"
type IntegralOpSpec struct {
Unit flux.Duration `json:"unit"`
+ TimeSrc string `json:"timeSrc"`
+ TimeDst string `json:"timeDst"`
execute.AggregateConfig
}
| 1 | package functions
import (
"fmt"
"time"
"github.com/influxdata/flux"
"github.com/influxdata/flux/execute"
"github.com/influxdata/flux/plan"
"github.com/influxdata/flux/semantic"
)
const IntegralKind = "integral"
type IntegralOpSpec struct {
Unit flux.Duration `json:"unit"`
execute.AggregateConfig
}
var int... | 1 | 8,433 | Why are we adding it to the integral function? | influxdata-flux | go |
@@ -45,11 +45,11 @@ func XfrmStateAdd(state *XfrmState) error {
msg := &nl.XfrmUsersaInfo{}
msg.Family = uint16(nl.GetIPFamily(state.Dst))
- msg.Id.Daddr.FromIP(state.Dst)
+ msg.ID.Daddr.FromIP(state.Dst)
msg.Saddr.FromIP(state.Src)
- msg.Id.Proto = uint8(state.Proto)
+ msg.ID.Proto = uint8(state.Proto)
msg.M... | 1 | package netlink
import (
"fmt"
"syscall"
"github.com/vishvananda/netlink/nl"
)
func writeStateAlgo(a *XfrmStateAlgo) []byte {
algo := nl.XfrmAlgo{
AlgKeyLen: uint32(len(a.Key) * 8),
AlgKey: a.Key,
}
end := len(a.Name)
if end > 64 {
end = 64
}
copy(algo.AlgName[:end], a.Name)
return algo.Serialize(... | 1 | 17,795 | Same for this file | opencontainers-runc | go |
@@ -234,15 +234,14 @@ namespace NLog.Internal.FileAppenders
appender.Flush();
}
}
-
+
/// <summary>
/// Gets the file info for a particular appender.
/// </summary>
/// <param name="fileName">The file name associated with a particular ap... | 1 | //
// Copyright (c) 2004-2011 Jaroslaw Kowalski <jaak@jkowalski.net>
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of source code must retain the above c... | 1 | 12,275 | Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal? | NLog-NLog | .cs |
@@ -825,6 +825,11 @@ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
view_activate(view, true);
seat->has_focus = true;
+ // We want to unconditionally send keyboard input to the view we are
+ // focusing here, so cancel any existing grabs.
+ struct wlr_seat_keyboard_grab *curr_grab ... | 1 | #define _POSIX_C_SOURCE 199309L
#include <assert.h>
#include <stdlib.h>
#include <string.h>
#include <time.h>
#include <wayland-server.h>
#include <wlr/config.h>
#include <wlr/types/wlr_idle.h>
#include <wlr/types/wlr_layer_shell.h>
#include <wlr/types/wlr_xcursor_manager.h>
#include <wlr/util/log.h>
#include "rootston... | 1 | 11,778 | probably better to use `wlr_seat_keyboard_end_grab()`. | swaywm-wlroots | c |
@@ -142,6 +142,9 @@ public class TransactionPool implements BlockAddedObserver {
public ValidationResult<TransactionInvalidReason> addLocalTransaction(
final Transaction transaction) {
+ if (transaction.getChainId().isEmpty() && !configuration.isUnprotectedTransactionsAllowed()) {
+ return Validatio... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 24,735 | Such a large test impact for such a little 3 line change ;) | hyperledger-besu | java |
@@ -51,9 +51,9 @@ class Payment extends AbstractTranslatableEntity implements OrderableEntityInter
protected $vat;
/**
- * @var Collection
+ * @var \Shopsys\FrameworkBundle\Model\Transport\Transport[]|Collection
*
- * @ORM\ManyToMany(targetEntity="Shopsys\FrameworkBundle\Model\Transport\Tr... | 1 | <?php
namespace Shopsys\FrameworkBundle\Model\Payment;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Collection;
use Doctrine\ORM\Mapping as ORM;
use Gedmo\Mapping\Annotation as Gedmo;
use Prezent\Doctrine\Translatable\Annotation as Prezent;
use Shopsys\FrameworkBundle\Component\Ged... | 1 | 10,111 | Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport. | shopsys-shopsys | php |
@@ -0,0 +1,11 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Psalm\Issue;
+
+final class NonInvariantPropertyType extends CodeIssue
+{
+ public const ERROR_LEVEL = -1;
+ public const SHORTCODE = 235159;
+} | 1 | 1 | 9,941 | This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues. | vimeo-psalm | php | |
@@ -20,6 +20,9 @@ const (
// the default configuration provided to ingress-annotation should be
// created.
tlsACMEAnnotation = "kubernetes.io/tls-acme"
+ // editInPlaceAnnotation is used to toggle the use of ingressClass instead
+ // of ingress on the created Certificate resource
+ editInPlaceAnnotation = "certm... | 1 | package controller
import (
"context"
"fmt"
"strconv"
"github.com/golang/glog"
corev1 "k8s.io/api/core/v1"
extv1beta1 "k8s.io/api/extensions/v1beta1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha1"
... | 1 | 12,156 | We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?) | jetstack-cert-manager | go |
@@ -665,7 +665,7 @@ public class JobTypeManager {
/**
+ * Get the keystore load props
+ */
- public Props getCommonPluginLoadProps() {
+ public Props getCommonPluginLoadProps() {
return this.cachedCommonPluginLoadProps;
}
| 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 22,684 | No need to add this file change for this PR. Please remove it. | azkaban-azkaban | java |
@@ -8,6 +8,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
public class DontImportJavaLangRule extends AbstractJavaRule {
+ private static final String IMPORT_JAVA_LANG = "java.lang.";
@Override
public Object visit(ASTImp... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.rule.imports;
import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
public class DontImportJavaLangRule extends AbstractJa... | 1 | 12,055 | this extra dot at the end is causing a couple tests to fail on Travis | pmd-pmd | java |
@@ -853,7 +853,11 @@ Arguments:
@conf.commands.register
def tshark(*args,**kargs):
- """Sniff packets and print them calling pkt.show(), a bit like text wireshark"""
- sniff(prn=lambda x: x.display(),*args,**kargs)
-
-
+ """Sniff packets and print them calling pkt.summary(), a bit like text wireshark"""
+ ... | 1 | ## This file is part of Scapy
## See http://www.secdev.org/projects/scapy for more informations
## Copyright (C) Philippe Biondi <phil@secdev.org>
## This program is published under a GPLv2 license
"""
Functions to send and receive packets.
"""
from __future__ import absolute_import, print_function
import errno
impor... | 1 | 11,694 | Did you try using `global` with a regular integer ? | secdev-scapy | py |
@@ -76,7 +76,7 @@ int Contractor::Run()
#ifdef WIN32
#pragma message("Memory consumption on Windows can be higher due to different bit packing")
#else
- static_assert(sizeof(extractor::NodeBasedEdge) == 20,
+ static_assert(sizeof(extractor::NodeBasedEdge) == 24,
"changing extractor::NodeBase... | 1 | #include "contractor/contractor.hpp"
#include "contractor/crc32_processor.hpp"
#include "contractor/graph_contractor.hpp"
#include "extractor/compressed_edge_container.hpp"
#include "extractor/node_based_edge.hpp"
#include "util/exception.hpp"
#include "util/graph_loader.hpp"
#include "util/integer_range.hpp"
#includ... | 1 | 16,420 | windows size might be off | Project-OSRM-osrm-backend | cpp |
@@ -25,10 +25,8 @@
#include "engine/bp/BPFileReader.h"
#include "engine/bp/BPFileWriter.h"
-#ifdef ADIOS_HAVE_DATAMAN // external dependencies
#include "engine/dataman/DataManReader.h"
#include "engine/dataman/DataManWriter.h"
-#endif
#ifdef ADIOS_HAVE_ADIOS1 // external dependencies
#include "engine/adios1/A... | 1 | /*
* Distributed under the OSI-approved Apache License, Version 2.0. See
* accompanying file Copyright.txt for details.
*
* ADIOS.cpp
*
* Created on: Sep 29, 2016
* Author: William F Godoy
*/
/// \cond EXCLUDE_FROM_DOXYGEN
#include <fstream>
#include <ios> //std::ios_base::failure
#include <iostream>
#i... | 1 | 11,363 | This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds. | ornladios-ADIOS2 | cpp |
@@ -1,7 +1,7 @@
<%= "#{@plan.title}" %>
<%= "----------------------------------------------------------\n" %>
<% if @show_coversheet %>
-<%= @hash[:attribution].length > 1 ? _("Creators: ") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
+<%= @hash[:attribution].many? ? _("Creators: ") : _('Creator:') %> <%... | 1 | <%= "#{@plan.title}" %>
<%= "----------------------------------------------------------\n" %>
<% if @show_coversheet %>
<%= @hash[:attribution].length > 1 ? _("Creators: ") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
<%= _("Affiliation: ") + @hash[:affiliation] %>
<% if @hash[:funder].present? %>
<%= _("... | 1 | 18,050 | thanks for cleaning up these old length checks | DMPRoadmap-roadmap | rb |
@@ -189,7 +189,7 @@ func (e *Executor) addBuiltinAnnontations(manifests []provider.Manifest, variant
}
func (e *Executor) applyManifests(ctx context.Context, manifests []provider.Manifest) error {
- e.LogPersister.Infof("Start applying %d manifests", len(manifests))
+ e.LogPersister.Infof("Start applying %d manifes... | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 10,720 | What will be logged when the `Input.Namespace` was not specified? | pipe-cd-pipe | go |
@@ -102,6 +102,9 @@ public class PMDParameters {
@Parameter(names = "-cache", description = "Specify the location of the cache file for incremental analysis.")
private String cacheLocation = null;
+ @Parameter(names = "-fix", description = "Attempt to automatically fix rule violations found on source fil... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.cli;
import java.io.IOException;
import java.util.ArrayList;
import java.util.List;
import java.util.Properties;
import net.sourceforge.pmd.PMDConfiguration;
import net.sourceforge.pmd.RulePriority;
im... | 1 | 13,427 | I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development | pmd-pmd | java |
@@ -47,5 +47,6 @@ axe.imports = {
CssSelectorParser: require('css-selector-parser').CssSelectorParser,
doT: require('@deque/dot'),
emojiRegexText: require('emoji-regex'),
- memoize: require('memoizee')
+ memoize: require('memoizee'),
+ ariaQuery: require('aria-query')
}; | 1 | /* global axe */
/**
* Note:
* This file is run via browserify to pull in the required dependencies.
* See - './build/imports-generator'
*/
/**
* Polyfill `Promise`
* Reference: https://www.npmjs.com/package/es6-promise
*/
if (!('Promise' in window)) {
require('es6-promise').polyfill();
}
/**
* Polyfill req... | 1 | 15,304 | I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it. | dequelabs-axe-core | js |
@@ -86,18 +86,8 @@ namespace OpenTelemetry
return value;
}
- /// <inheritdoc/>
- public void Dispose()
- {
- if (!this.disposed)
- {
- Slot.Set(this.previousValue);
- this.disposed = true;
- }
- }
-
... | 1 | // <copyright file="SuppressInstrumentationScope.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http... | 1 | 19,377 | @ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other v... | open-telemetry-opentelemetry-dotnet | .cs |
@@ -283,9 +283,12 @@ public class ExecuteFlowAction implements TriggerAction {
actions.add(killAct);
}
}
- Trigger slaTrigger =
- new Trigger("azkaban_sla", "azkaban", triggerCond, expireCond,
- actions);
+ Trigger slaTrigger = new Trigger.Trigger... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 13,122 | would be good to turn these into constants. | azkaban-azkaban | java |
@@ -158,8 +158,8 @@ func (g *gen) frame() []byte {
return nil
}
var buf bytes.Buffer
- buf.WriteString("// Code generated by gowire. DO NOT EDIT.\n\n")
- buf.WriteString("//go:generate gowire\n")
+ buf.WriteString("// Code generated by wire. DO NOT EDIT.\n\n")
+ buf.WriteString("//go:generate wire\n")
buf.Writ... | 1 | // Copyright 2018 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in ... | 1 | 10,503 | Seems like it should be `generated by Wire` here and in the SUT? | google-go-cloud | go |
@@ -173,7 +173,7 @@ func TestStorageProtocolBasic(t *testing.T) {
}
}
- ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150)
+ ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150, false)
assert.NoError(err)
requireQueryDeal := func() (DealState, string) {
resp, err := c.QueryDe... | 1 | package storage_test
import (
"context"
"sync"
"testing"
"time"
unixfs "gx/ipfs/QmQXze9tG878pa4Euya4rrDpyTNX3kQe4dhCaBzBozGgpe/go-unixfs"
"gx/ipfs/QmR8BauakNcBa3RbE4nbQu76PDiJgoQgz8AJdhJuiU4TAw/go-cid"
cbor "gx/ipfs/QmRoARq3nkUb13HSKZGepCZSWe5GrVPwx7xURJGZ7KWv9V/go-ipld-cbor"
dag "gx/ipfs/QmTQdH4848iTVCJmKXYy... | 1 | 15,953 | I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string "no duplicates" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the dup... | filecoin-project-venus | go |
@@ -74,7 +74,7 @@ namespace OpenTelemetry
{
if (timeoutMilliseconds < 0 && timeoutMilliseconds != Timeout.Infinite)
{
- throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds));
+ throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds)... | 1 | // <copyright file="BaseExporter.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.or... | 1 | 17,498 | `Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -38,6 +38,7 @@ using System.Linq;
using Xunit;
using NLog.Common;
using System.Text;
+using Xunit.Extensions;
namespace NLog.UnitTests.Common
{ | 1 | //
// Copyright (c) 2004-2011 Jaroslaw Kowalski <jaak@jkowalski.net>
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of source code must retain the above c... | 1 | 12,929 | I think we need `#if !SILVERLIGHT` here and at the test. | NLog-NLog | .cs |
@@ -26,6 +26,7 @@ import javafx.collections.transformation.SortedList;
import javafx.event.EventHandler;
import javafx.scene.input.MouseEvent;
import me.xdrop.fuzzywuzzy.FuzzySearch;
+import org.eclipse.jgit.util.StringUtils;
import org.phoenicis.javafx.settings.JavaFxSettingsManager;
import org.phoenicis.javafx.v... | 1 | /*
* Copyright (C) 2015-2017 PÂRIS Quentin
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is... | 1 | 11,230 | Can you change this import to the apache dependency? I didn't even know that jgit contains such a method... | PhoenicisOrg-phoenicis | java |
@@ -34,11 +34,11 @@ func GenerateServiceAccountName(gServiceAccount, clusterName string) string {
}
// MakeServiceAccount creates a K8s ServiceAccount object for the Namespace.
-func MakeServiceAccount(namespace string, gServiceAccount, clusterName string) *corev1.ServiceAccount {
+func MakeServiceAccount(namespace... | 1 | /*
Copyright 2020 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 14,788 | Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler. | google-knative-gcp | go |
@@ -50,13 +50,15 @@ interpreted as encoded JSON and formatted accordingly. If '-r', value
is displayed without a newline. If '-t', the RFC 11 object is displayed.
'-a treeobj' causes the lookup to be relative to an RFC 11 snapshot reference.
-*put* [-j|-r|-t] [-n] 'key=value' ['key=value...']::
+*put* [-j|-r|-t] ... | 1 | // flux-help-include: true
FLUX-KVS(1)
===========
:doctype: manpage
NAME
----
flux-kvs - Flux key-value store utility
SYNOPSIS
--------
*flux* *kvs* 'COMMAND' ['OPTIONS']
DESCRIPTION
-----------
The Flux key-value store (KVS) is a simple, distributed data storage
service used a building block by other Flux compo... | 1 | 19,467 | should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON. | flux-framework-flux-core | c |
@@ -49,7 +49,7 @@ func init() {
flags.BoolVarP(cmdFlags, &checkControl, "check-control", "", true, "Check control characters.")
flags.DurationVarP(cmdFlags, &uploadWait, "upload-wait", "", 0, "Wait after writing a file.")
flags.BoolVarP(cmdFlags, &checkLength, "check-length", "", true, "Check max filename length.... | 1 | package info
// FIXME once translations are implemented will need a no-escape
// option for Put so we can make these tests work agaig
import (
"bytes"
"context"
"encoding/json"
"fmt"
"io"
"os"
"path"
"regexp"
"sort"
"strconv"
"strings"
"sync"
"time"
"github.com/pkg/errors"
"github.com/rclone/rclone/cm... | 1 | 12,082 | I presume this isn't some special term... | rclone-rclone | go |
@@ -79,6 +79,18 @@ function pAsHeadingEvaluate(node, options, virtualNode) {
const nextStyle = nextSibling ? getStyleValues(nextSibling) : null;
const prevStyle = prevSibling ? getStyleValues(prevSibling) : null;
+ if (node && nextSibling) {
+ const headingLength = node.textContent.trim().length;
+ const... | 1 | import { findUpVirtual } from '../../commons/dom';
function normalizeFontWeight(weight) {
switch (weight) {
case 'lighter':
return 100;
case 'normal':
return 400;
case 'bold':
return 700;
case 'bolder':
return 900;
}
weight = parseInt(weight);
return !isNaN(weight) ? wei... | 1 | 17,021 | Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata. | dequelabs-axe-core | js |
@@ -540,6 +540,14 @@ const (
// This is replaced at runtime
JivaClusterIPHolder JivaAnnotations = "__CLUSTER_IP__"
+ // JivaCloneIPHolder is used as a placeholder for sync controller IP address
+ // which will be used as cloneIP
+ //
+ // NOTE:
+ // This is replaced at runtime
+ JivaCloneIPHolder JivaAnnota... | 1 | package v1
// NomadEnvironmentVariable is a typed label that defines environment variables
// that are understood by Nomad
type NomadEnvironmentVariable string
const (
// NomadAddressEnvKey is the environment variable that determines the
// Nomad server address where the Job request can be directed to.
NomadAddres... | 1 | 7,536 | Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good. | openebs-maya | go |
@@ -38,6 +38,8 @@ public class RestClientSenderFilter implements ConsumerFilter {
@Override
public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
+ invocation.onStartSendRequest();
+
CompletableFuture<Response> future = new RestClientSender(invocation)
.send(... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 12,278 | `invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send` | apache-servicecomb-java-chassis | java |
@@ -218,8 +218,8 @@ func (ap *actPool) Add(ctx context.Context, act action.SealedEnvelope) error {
if act.GasPrice().Cmp(ap.cfg.MinGasPrice()) < 0 {
actpoolMtc.WithLabelValues("gasPriceLower").Inc()
log.L().Info("action rejected due to low gas price",
- zap.String("act hash", hex.EncodeToString(hash[:])),
- ... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 24,113 | use "actionHash" to be consistent with other places | iotexproject-iotex-core | go |
@@ -4,11 +4,14 @@
package net.sourceforge.pmd.lang.rule.properties;
+import java.util.Collections;
import java.util.Enumeration;
import java.util.Map;
+import net.sourceforge.pmd.EnumeratedPropertyDescriptor;
import net.sourceforge.pmd.PropertyDescriptorFactory;
-import net.sourceforge.pmd.lang.rule.propertie... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.rule.properties;
import java.util.Enumeration;
import java.util.Map;
import net.sourceforge.pmd.PropertyDescriptorFactory;
import net.sourceforge.pmd.lang.rule.properties.factories.BasicPropertyDe... | 1 | 12,320 | Can we derive `Class<E>` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me. | pmd-pmd | java |
@@ -5364,6 +5364,17 @@ TEST_F(VkLayerTest, AndroidHardwareBufferCreateYCbCrSampler) {
m_errorMonitor->SetUnexpectedError("VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651");
vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
m_errorMonitor->VerifyFound();
+
+ m_errorMonitor->... | 1 | /*
* Copyright (c) 2015-2020 The Khronos Group Inc.
* Copyright (c) 2015-2020 Valve Corporation
* Copyright (c) 2015-2020 LunarG, Inc.
* Copyright (c) 2015-2020 Google, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* Y... | 1 | 14,169 | I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set ... | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
return "", err
}
- if app.SiteStatus() != "running" {
- return "", errors.New("app not running locally. Try `ddev start`")
+ if app.SiteStatus() != platform.SiteRunning {
+ return "", errors.New("App not running locally. Try `d... | 1 | package cmd
import (
"fmt"
"log"
"os"
"os/exec"
"path/filepath"
"strconv"
"runtime"
"github.com/drud/ddev/pkg/appports"
"github.com/drud/ddev/pkg/dockerutil"
"github.com/drud/ddev/pkg/plugins/platform"
"github.com/drud/ddev/pkg/util"
"github.com/pkg/errors"
"github.com/spf13/cobra"
)
// SequelproLoc is... | 1 | 11,413 | I'd say the error should be an error, not instructions to the user. So error would be something like "site should be running and is not" | drud-ddev | php |
@@ -894,8 +894,11 @@ class SNSTest(unittest.TestCase):
return queue_name, queue_arn, queue_url
def test_publish_sms_endpoint(self):
+ # Clean posible previous sms messages
+ sns_backend = SNSBackend.get()
+ sns_backend.sms_messages = []
+
def check_messages():
- ... | 1 | # -*- coding: utf-8 -*-
import json
import os
import time
import unittest
import pytest
import requests
from botocore.exceptions import ClientError
from localstack import config
from localstack.config import external_service_url
from localstack.constants import TEST_AWS_ACCOUNT_ID
from localstack.services.generic_pr... | 1 | 13,730 | Thanks for this PR @pinzon ! Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have du... | localstack-localstack | py |
@@ -21,10 +21,12 @@ import (
"context"
"errors"
"sync"
- "time"
+
+ "github.com/asaskevich/EventBus"
log "github.com/cihub/seelog"
- "github.com/mysteriumnetwork/node/client/stats"
+ stats_dto "github.com/mysteriumnetwork/node/client/stats/dto"
+
"github.com/mysteriumnetwork/node/communication"
"github.co... | 1 | /*
* Copyright (C) 2017 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 12,766 | Some weird blocks formation again. | mysteriumnetwork-node | go |
@@ -39,7 +39,7 @@ func TestOvirtActuator(t *testing.T) {
clusterDeployment: testOvirtClusterDeployment(),
pool: testOvirtPool(),
expectedMachineSetReplicas: map[string]int64{
- fmt.Sprintf("%s-worker-0", testInfraID): 3,
+ fmt.Sprintf("%s-worker", testInfraID): 3,
},
},
} | 1 | package remotemachineset
import (
"fmt"
"testing"
"github.com/golang/mock/gomock"
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
corev1 "k8s.io/api/core/v1"
ovirtprovider "github.com/openshift/cluster-api-provider-ovirt/pkg/apis/ovirtprovider/v1be... | 1 | 19,500 | This is worrisome. | openshift-hive | go |
@@ -219,6 +219,9 @@ type FilesystemTrimDriver interface {
// AutoFilesystemTrimStatus returns the status of auto fs trim
// operations on volumes
AutoFilesystemTrimStatus(request *api.SdkAutoFSTrimStatusRequest) (*api.SdkAutoFSTrimStatusResponse, error)
+ // AutoFilesystemTrimUsage returns the usage of auto fs tr... | 1 | package volume
import (
"context"
"errors"
"github.com/libopenstorage/openstorage/api"
)
var (
// ErrAlreadyShutdown returned when driver is shutdown
ErrAlreadyShutdown = errors.New("VolumeDriverProvider already shutdown")
// ErrExit returned when driver already registered
ErrExist = errors.New("Already exist... | 1 | 8,987 | nit try rephrasing to something like " AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes" | libopenstorage-openstorage | go |
@@ -64,7 +64,7 @@ module Unix
h = self.foss_defaults
h['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d'
h['puppetservice'] = 'puppetserver'
- h['puppetbindir'] = '/opt/puppetlabs/agent/bin'
+ h['puppetbindir'] = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin'
h[... | 1 | [ 'host', 'command_factory', 'command', 'options' ].each do |lib|
require "beaker/#{lib}"
end
module Unix
class Host < Beaker::Host
[ 'user', 'group', 'exec', 'pkg', 'file' ].each do |lib|
require "beaker/host/unix/#{lib}"
end
include Unix::User
include Unix::Group
include Unix::... | 1 | 8,947 | currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppe... | voxpupuli-beaker | rb |
@@ -4,10 +4,10 @@ import Ember from 'ember';
import PouchAdapterUtils from 'hospitalrun/mixins/pouch-adapter-utils';
export default Adapter.extend(PouchAdapterUtils, {
- databaseName: 'config',
- db: Ember.computed.alias('pouchDBService.configDB'),
- pouchDBService: Ember.inject.service('pouchdb'),
- ... | 1 | import { Adapter } from 'ember-pouch';
import Ember from 'ember';
import PouchAdapterUtils from 'hospitalrun/mixins/pouch-adapter-utils';
export default Adapter.extend(PouchAdapterUtils, {
databaseName: 'config',
db: Ember.computed.alias('pouchDBService.configDB'),
pouchDBService: Ember.inject.servic... | 1 | 12,421 | any point in keeping this here ? | HospitalRun-hospitalrun-frontend | js |
@@ -233,8 +233,8 @@ type GossipData struct {
}
func (g *GossipData) Merge(o router.GossipData) {
- checkAndPanic(CaseSensitive(g.Entries))
- defer func() { checkAndPanic(CaseSensitive(g.Entries)) }()
+ checkAndPanic(CaseInsensitive(g.Entries))
+ defer func() { checkAndPanic(CaseInsensitive(g.Entries)) }()
other :... | 1 | package nameserver
import (
"bytes"
"encoding/gob"
"fmt"
"sort"
"strings"
"time"
"github.com/weaveworks/weave/net/address"
"github.com/weaveworks/weave/router"
)
var now = func() int64 { return time.Now().Unix() }
type Entry struct {
ContainerID string
Origin router.PeerName
Addr address.Addr... | 1 | 11,526 | I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver). | weaveworks-weave | go |
@@ -1,6 +1,11 @@
#include "engine/routing_algorithms/shortest_path.hpp"
+
+#ifdef OSRM_EXTERNAL_MEMORY
+#include "routing/routing_base_offline.hpp"
+#else
#include "engine/routing_algorithms/routing_base_ch.hpp"
#include "engine/routing_algorithms/routing_base_mld.hpp"
+#endif
#include <boost/assert.hpp>
#includ... | 1 | #include "engine/routing_algorithms/shortest_path.hpp"
#include "engine/routing_algorithms/routing_base_ch.hpp"
#include "engine/routing_algorithms/routing_base_mld.hpp"
#include <boost/assert.hpp>
#include <boost/optional.hpp>
#include <memory>
namespace osrm
{
namespace engine
{
namespace routing_algorithms
{
name... | 1 | 22,435 | This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantia... | Project-OSRM-osrm-backend | cpp |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.