patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -36,8 +36,7 @@ public class GleanMetricsService {
} else {
GleanMetricsService.stop();
}
- Configuration config = new Configuration(Configuration.DEFAULT_TELEMETRY_ENDPOINT,
- BuildConfig.BUILD_TYPE);
+ Configuration config ... | 1 | package org.mozilla.vrbrowser.telemetry;
import android.content.Context;
import android.util.Log;
import androidx.annotation.UiThread;
import org.mozilla.vrbrowser.browser.SettingsStore;
import org.mozilla.vrbrowser.utils.DeviceType;
import org.mozilla.vrbrowser.utils.SystemUtils;
import org.mozilla.vrbrowser.BuildC... | 1 | 8,359 | This was just fixed in mozilla-mobile/android-components#4892. @pocmo is cutting a new Android Components 19 dot release today, so you'll be able to jump to the new version and restore the build type. | MozillaReality-FirefoxReality | java |
@@ -131,6 +131,7 @@ func (r *genericInjectReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
if err := r.Client.Get(ctx, req.NamespacedName, target.AsObject()); err != nil {
if dropNotFound(err) == nil {
// don't requeue on deletions, which yield a non-found object
+ log.V(logf.TraceLevel).Info("not ... | 1 | /*
Copyright 2019 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 23,403 | Leaving this log line because it helped me to diagnose that the reconciler client was using a different cache than the event sources, so not always seeing the injectable that triggered the reconcile. | jetstack-cert-manager | go |
@@ -4867,7 +4867,10 @@ func (mset *stream) processCatchupMsg(msg []byte) (uint64, error) {
return 0, errors.New("bad catchup msg")
}
+ mset.mu.RLock()
st := mset.cfg.Storage
+ mset.mu.RUnlock()
+
if mset.js.limitsExceeded(st) || mset.jsa.limitsExceeded(st) {
return 0, NewJSInsufficientResourcesError()
} | 1 | // Copyright 2020-2021 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 14,178 | Do we need also to protect access to `mset.js` and `mset.jsa` or even `mset.store` down below? (not sure if those are immutable or not). | nats-io-nats-server | go |
@@ -579,6 +579,7 @@ func (k *KeybaseServiceBase) ResolveImplicitTeamByID(
func (k *KeybaseServiceBase) checkForRevokedVerifyingKey(
ctx context.Context, currUserInfo UserInfo, kid keybase1.KID) (
newUserInfo UserInfo, exists bool, err error) {
+ newUserInfo = currUserInfo
for key, info := range currUserInfo.Revo... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"sync"
"time"
kbname "github.com/keybase/client/go/kbun"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/logger... | 1 | 20,182 | I'd rather you do this under `if info.filledInMerkle {` since that's the only place it's relevant. | keybase-kbfs | go |
@@ -344,13 +344,8 @@ public class RecoveryStrategy implements Runnable, Closeable {
// though
try {
CloudDescriptor cloudDesc = this.coreDescriptor.getCloudDescriptor();
- ZkNodeProps leaderprops = zkStat... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 37,919 | *NULL_DEREFERENCE:* object `leaderUrl` last assigned on line 348 could be null and is dereferenced at line 351. | apache-lucene-solr | java |
@@ -38,9 +38,13 @@ class PlansController < ApplicationController
def create
@plan = Plan.new
authorize @plan
-
+
@plan.principal_investigator = current_user.surname.blank? ? nil : "#{current_user.firstname} #{current_user.surname}"
- @plan.data_contact = current_user.email
+ @plan.principal_... | 1 | class PlansController < ApplicationController
require 'pp'
helper SettingsTemplateHelper
after_action :verify_authorized, except: ['public_index', 'public_export']
def index
authorize Plan
@plans = current_user.plans
end
# GET /plans/public_index
# ----------------------------------------------... | 1 | 16,781 | Since the IdentifierScheme's don't change without us making additional code changes, perhaps this should be added as a constant as we previously did with Perms? | DMPRoadmap-roadmap | rb |
@@ -14,6 +14,7 @@
# limitations under the License.
#
+import os
import functools
import shutil
import sys | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 9,042 | nit: We can revert this now. | databricks-koalas | py |
@@ -5,9 +5,19 @@ import android.view.ContextMenu;
import android.view.MenuInflater;
import android.view.View;
import android.view.ViewGroup;
+
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.recyclerview.widget.RecyclerView;
+
+import org.apache.commons.lang3.ArrayUtils;
+... | 1 | package de.danoeh.antennapod.adapter;
import android.app.Activity;
import android.view.ContextMenu;
import android.view.MenuInflater;
import android.view.View;
import android.view.ViewGroup;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.recyclerview.widget.RecyclerView;
impor... | 1 | 19,231 | Oh, that's the reason why you have two different data structures here. Does the order of the `selectedItems` list matter? If not, I think it would be more clear if both would be a Set. | AntennaPod-AntennaPod | java |
@@ -2034,6 +2034,7 @@ void LuaScriptInterface::registerFunctions()
registerClass("Container", "Item", LuaScriptInterface::luaContainerCreate);
registerMetaMethod("Container", "__eq", LuaScriptInterface::luaUserdataCompare);
+ registerMethod("Container", "getContentDescription", LuaScriptInterface::luaContainerGet... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2015 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 11,577 | Should be named getDescription, since the other description functions are named that. | otland-forgottenserver | cpp |
@@ -62,7 +62,9 @@ public class PlatformActivity extends VRActivity implements RenderInterface, CVC
if (ControllerClient.isControllerServiceExisted(this)) {
mControllerManager = new CVControllerManager(this);
mControllerManager.setListener(this);
- mType = 1;
+ mT... | 1 | /* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*-
* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
package org.mozilla.vrbrowser;
imp... | 1 | 9,035 | Don't we want to do this for g2 4k also? | MozillaReality-FirefoxReality | java |
@@ -4,6 +4,8 @@ const time = require('./time').default;
const Logger = require('./Logger').default;
const { _ } = require('./locale');
const urlUtils = require('./urlUtils.js');
+const str2ab = require('string-to-arraybuffer');
+const Buffer = require('buffer').Buffer;
class OneDriveApi {
// `isPublic` is to te... | 1 | const shim = require('./shim').default;
const { stringify } = require('query-string');
const time = require('./time').default;
const Logger = require('./Logger').default;
const { _ } = require('./locale');
const urlUtils = require('./urlUtils.js');
class OneDriveApi {
// `isPublic` is to tell OneDrive whether the app... | 1 | 15,615 | I would prefer if we don't add this package as it's unsupported, and I expect not necessary. Node buffer supports many formats - is it not possible to use one of its helper functions to load the content? | laurent22-joplin | js |
@@ -205,6 +205,12 @@ type Table struct {
// to what we calculate from chainToContents.
chainToDataplaneHashes map[string][]string
+ // chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
+ chainsToFullRules map[string][]string
+
+ // hashToFullRules contains a mappi... | 1 | // Copyright (c) 2016-2019 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 17,083 | I don't think this is used any more, please remove. | projectcalico-felix | go |
@@ -219,7 +219,11 @@ def List(inner_type):
super(_List, self).__init__(
key='List.{inner_type}'.format(inner_type=inner_type.key),
name=None,
- description='List of {inner_type}'.format(inner_type=inner_type.name),
+ description=(
+ ... | 1 | from collections import namedtuple
import six
from dagster import check
from .builtin_enum import BuiltinEnum
class ConfigTypeAttributes(namedtuple('_ConfigTypeAttributes', 'is_builtin is_system_config')):
def __new__(cls, is_builtin=False, is_system_config=False):
return super(ConfigTypeAttributes, cl... | 1 | 12,433 | actually use type_name=print_config_type_to_string(self, with_lines=False) to populate this | dagster-io-dagster | py |
@@ -71,6 +71,13 @@ class Import extends QueueWorkerBase implements ContainerFactoryPluginInterface
foreach ($results as $result) {
$queued = $this->processResult($result, $data, $queued);
}
+
+ // Delete local resource file.
+ if ($this->container->get('config.factory')->get('datastore.... | 1 | <?php
namespace Drupal\datastore\Plugin\QueueWorker;
use Drupal\Core\Logger\RfcLogLevel;
use Drupal\Core\Plugin\ContainerFactoryPluginInterface;
use Drupal\Core\Queue\QueueWorkerBase;
use Drupal\common\LoggerTrait;
use Procrastinator\Result;
use Symfony\Component\DependencyInjection\ContainerInterface;
/**
* Proces... | 1 | 21,026 | We should be using dependency injection here, instead of fetching the config factory at the last minute from the container. That would allow us to more easily overwrite the "delete_local_resource" setting in tests. | GetDKAN-dkan | php |
@@ -21,8 +21,12 @@ import com.codahale.metrics.health.HealthCheckRegistry;
import com.codahale.metrics.json.HealthCheckModule;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.ObjectWriter;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
public class HealthCheck... | 1 | package com.codahale.metrics.servlets;
import java.io.IOException;
import java.io.OutputStream;
import java.util.Map;
import java.util.SortedMap;
import java.util.concurrent.ExecutorService;
import javax.servlet.ServletConfig;
import javax.servlet.ServletContext;
import javax.servlet.ServletContextEvent;
import javax... | 1 | 7,373 | everywhere else in the project, `LOGGER` is used | dropwizard-metrics | java |
@@ -10,7 +10,7 @@ OSM = {
MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>,
SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>,
SERVER_URL: <%= Settings.server_url.to_json %>,
- API_VERSION: <%= Settings.api_version.to_json %>,
+ API_VERSION: ... | 1 | //= depend_on settings.yml
//= depend_on settings.local.yml
//= require querystring
OSM = {
<% if defined?(PIWIK) %>
PIWIK: <%= PIWIK.to_json %>,
<% end %>
MAX_REQUEST_AREA: <%= Settings.max_request_area.to_json %>,
SERVER_PROTOCOL: <%= Settings.server_protocol.to_json %>,
SER... | 1 | 12,092 | Why is this value set to "min_by", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)? | openstreetmap-openstreetmap-website | rb |
@@ -0,0 +1,9 @@
+/**
+ * Setup configuration for Jest
+ * This file includes gloabl settings for the JEST environment.
+ */
+import 'raf/polyfill';
+import { configure } from 'enzyme';
+import Adapter from 'enzyme-adapter-react-16';
+
+configure({ adapter: new Adapter() }); | 1 | 1 | 17,517 | typo --> gloabl | verdaccio-verdaccio | js | |
@@ -356,6 +356,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
c := context.WithValue(r.Context(), OriginalURLCtxKey, urlCopy)
r = r.WithContext(c)
+ // Setup a replacer for the request that keeps track of placeholder
+ // values across plugins.
+ replacer := NewReplacer(r, nil, "")
+ c... | 1 | // Copyright 2015 Light Code Labs, LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 11,647 | Wanted to double-check: does the `log` middleware still set its own "empty" value (should default to `-` at least for the default log format)? | caddyserver-caddy | go |
@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
}
if (!GET_ALL_SESSIONS.equals(command.getName())
&& !NEW_SESSION.equals(command.getName())) {
- throw new SessionNotFoundException("Session ID is null");
+ throw new SessionNotFoundE... | 1 | /*
Copyright 2007-2011 Selenium committers
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 10,691 | It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()) | SeleniumHQ-selenium | java |
@@ -14,12 +14,13 @@ module Bolt
def print_head; end
- def initialize(color, verbose, trace, stream = $stdout)
+ def initialize(color, verbose, trace, spin, stream = $stdout)
super
# Plans and without_default_logging() calls can both be nested, so we
# track each of them w... | 1 | # frozen_string_literal: true
require 'bolt/pal'
module Bolt
class Outputter
class Human < Bolt::Outputter
COLORS = {
red: "31",
green: "32",
yellow: "33",
cyan: "36"
}.freeze
def print_head; end
def initialize(color, verbose, trace, stream = $stdo... | 1 | 17,208 | Is this going to be configurable? If not, it should just be removed for now. | puppetlabs-bolt | rb |
@@ -23,6 +23,13 @@ See :ref:`Parameter` for more info on how to define parameters.
import abc
import datetime
import warnings
+import json
+from json import JSONEncoder
+from collections import OrderedDict
+import collections
+import operator
+import functools
+
try:
from ConfigParser import NoOptionError, NoS... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 14,360 | Maybe just one import line - `from collections import OrderedDict, Mapping` ? | spotify-luigi | py |
@@ -37,8 +37,8 @@ public class NonRuleWithAllPropertyTypes extends AbstractRule {
public static final StringMultiProperty MULTI_STR = new StringMultiProperty("multiStr", "Multiple string values",
new String[] {"hello", "world"}, 5.0f,... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.properties;
import static net.sourceforge.pmd.properties.constraints.NumericConstraints.inRange;
import java.lang.reflect.Method;
import java.util.Arrays;
import java.util.Collections;
import java.util... | 1 | 14,998 | Btw this class probably doesn't belong in PMD. It says it's there to test UIs, but arguably UIs can use their own test fixtures, and this in in src/test so probably not even shipped anywhere. | pmd-pmd | java |
@@ -50,6 +50,8 @@ describe( 'AMPContainerSelect', () => {
registry.dispatch( STORE_NAME ).setAccountID( accountID );
registry.dispatch( STORE_NAME ).receiveGetAccounts( [ account ] );
registry.dispatch( STORE_NAME ).receiveGetContainers( [ ...webContainers, ...ampContainers ], { accountID } );
+ registry.disp... | 1 | /**
* AMP Container Select component tests.
*
* Site Kit by Google, Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/... | 1 | 32,635 | Maybe we can group each `finishResolution` call with the corresponding `receiveGet...` call? That would make the connection more clear when reading the code. | google-site-kit-wp | js |
@@ -109,9 +109,9 @@ class ServerConnectionMixin(object):
self.disconnect()
"""
- def __init__(self, server_address=None):
+ def __init__(self, server_address=None, source_address=None):
super(ServerConnectionMixin, self).__init__()
- self.server_conn = ServerConnect... | 1 | from __future__ import (absolute_import, print_function, division)
import sys
import six
from netlib import tcp
from ..models import ServerConnection
from ..exceptions import ProtocolException
from netlib.exceptions import TcpException
class _LayerCodeCompletion(object):
"""
Dummy class that provides type h... | 1 | 10,958 | Can we take this out of the constructor here and just use the config value? (This would also make the other proxy mode cases obsolete) | mitmproxy-mitmproxy | py |
@@ -1350,9 +1350,14 @@ class RustGenerator : public BaseGenerator {
code_ +=
" if self.{{FIELD_TYPE_FIELD_NAME}}_type() == "
"{{U_ELEMENT_ENUM_TYPE}} {";
- code_ +=
- " self.{{FIELD_NAME}}().map(|u| "
- "{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u)... | 1 | /*
* Copyright 2018 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applica... | 1 | 18,024 | Please flip the conditional to be `if (field.required) { ... }`. | google-flatbuffers | java |
@@ -11,7 +11,10 @@ describe 'User creation when logging in with Oauth to view a protected page' do
get '/auth/myusa/callback'
}.to change { User.count }.by(1)
- expect(User.last.email_address).to eq('george-test@example.com')
+ new_user = User.last
+ expect(new_user.email_address).to eq('george-t... | 1 | describe 'User creation when logging in with Oauth to view a protected page' do
StructUser = Struct.new(:email_address, :first_name, :last_name)
before do
user = StructUser.new('george-test@example.com', 'Georgie', 'Jetsonian')
setup_mock_auth(:myusa, user)
end
it 'creates a new user if the current us... | 1 | 15,373 | should we create a fixture without first name and last name and have a spec like this one that uses it to make sure nothing errors out when they are not present? | 18F-C2 | rb |
@@ -35,4 +35,9 @@ interface PythonSnippetSet<Element> {
* Generates the result module with a set of accumulated imports.
*/
Doc generateModule(Element element, Doc body, Iterable<String> imports);
+
+ /**
+ * Generate the example snippet for the code documentation.
+ */
+ Doc generateMethodSampleCode... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 15,181 | It seems odd to require all Python snippets to have this method when it's not relevant for messages.snip or the discovery snippets. (I see that we're already doing something similar with generateModule/generateBody where some of the implementations are empty. This also seems strange to me.) | googleapis-gapic-generator | java |
@@ -122,6 +122,7 @@ public class PrivateTransactionSimulator {
publicWorldState.updater(),
disposablePrivateState.updater(),
header,
+ Hash.ZERO, // PMT hash is not needed as this private transaction doesn't exist
transaction,
protocolSpec.getM... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 22,048 | What about this: "// Corresponding PMT does not exist." | hyperledger-besu | java |
@@ -626,6 +626,8 @@ class OptionsManagerMixIn(object):
config_file = self.config_file
if config_file is not None:
config_file = os.path.expanduser(config_file)
+ if not os.path.exists(config_file):
+ raise IOError("The config file {:s} doesn't exist!".format(... | 1 | # Copyright (c) 2006-2010, 2012-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
# Copyright (c) 2014-2016 Claudiu Popa <pcmanticore@gmail.com>
# Copyright (c) 2015 Aru Sahni <arusahni@gmail.com>
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/Py... | 1 | 9,756 | You don't need af ormat specified here. | PyCQA-pylint | py |
@@ -12,6 +12,8 @@ import (
"time"
"github.com/nats-io/go-nats"
+ "strings"
+ "sync"
)
func TestRouteConfig(t *testing.T) { | 1 | // Copyright 2013-2016 Apcera Inc. All rights reserved.
package server
import (
"fmt"
"net"
"net/url"
"reflect"
"strconv"
"testing"
"time"
"github.com/nats-io/go-nats"
)
func TestRouteConfig(t *testing.T) {
opts, err := ProcessConfigFile("./configs/cluster.conf")
if err != nil {
t.Fatalf("Received an er... | 1 | 7,203 | Nitpick: import ordering | nats-io-nats-server | go |
@@ -38,7 +38,7 @@ namespace Nethermind.Blockchain
public ReadOnlyChain(ReadOnlyBlockTree readOnlyTree,
IBlockValidator blockValidator,
- IRewardCalculator rewardCalculator,
+ Func<ITransactionProcessor, IRewardCalculator> rewardCalculatorFactory,
ISpecProvider ... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,148 | code smell here, a function that create a reward calculator from transaction processor? | NethermindEth-nethermind | .cs |
@@ -48,7 +48,7 @@ var authScopes = []string{
"https://www.googleapis.com/auth/cloud-platform",
}
-// Client is a runtimevarManager client.
+// A Client constructs runtime variables using the Runtime Configurator API.
type Client struct {
conn *grpc.ClientConn
// The gRPC API client. | 1 | // Copyright 2018 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in ... | 1 | 9,775 | I don't think the `A` is idomatic is it? | google-go-cloud | go |
@@ -67,4 +67,12 @@ public interface ActionsProvider {
default ExpireSnapshots expireSnapshots(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does not implement expireSnapshots");
}
+
+ /**
+ * Instantiates an action to remove all the files reachable from given metadat... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 35,840 | nit: the others use the method name in the api and not the class name of the api | apache-iceberg | java |
@@ -1939,6 +1939,9 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
// - Some passes may create new functions, but only the functions defined in
// the lldb repl line should be serialized.
if (swift_ast_ctx->UseSerialization()) {
+ // Run all the passes before differentiat... | 1 | //===-- SwiftExpressionParser.cpp -------------------------------*- C++ -*-===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2016 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/L... | 1 | 18,162 | Does it work to run all the sil diagnostic passes before we serialize? That would be more consistent with what the normal compiler does in `FrontendTool.cpp : performCompileStepsPostSILGen()` | apple-swift-lldb | cpp |
@@ -4,6 +4,7 @@ Given '"$teacher_name" is teaching the section from "$section_start" to "$sectio
section = Section.find_by_starts_on_and_ends_on!(start_date, end_date)
teacher = Teacher.find_by_name!(teacher_name)
create(:section_teacher, section: section, teacher: teacher)
+ p section.teachers
end
Given ... | 1 | Given '"$teacher_name" is teaching the section from "$section_start" to "$section_end"' do |teacher_name, section_start, section_end|
start_date = Date.parse(section_start)
end_date = Date.parse(section_end)
section = Section.find_by_starts_on_and_ends_on!(start_date, end_date)
teacher = Teacher.find_by_name!(t... | 1 | 6,405 | You left in a puts. | thoughtbot-upcase | rb |
@@ -59,6 +59,11 @@ public abstract class CachingCollector extends FilterCollector {
@Override
public final float score() { return score; }
+ @Override
+ public float smoothingScore(int docId) throws IOException {
+ return 0;
+ }
+
@Override
public int docID() {
return doc; | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 38,613 | Hmm, should we also cache the `smoothingScore` for this hit? Or, if we will keep it at returning `0`, couldn't we remove this impl and inherit the default from `Scorable`? | apache-lucene-solr | java |
@@ -51,7 +51,7 @@ module.exports = function (grunt, options) {
baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
}
else {
- baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy... | 1 |
module.exports = function (grunt, options) {
var baseTasks = {
'install': ['shell:bower-install', 'shell:protractor-install', 'shell:hooks-install'],
// register before and after test tasks so we don't have to change cli
// options on the CI server
'before-test': ['clean', 'newer:jshint', 'newer:jsc... | 1 | 11,764 | I removed that from here because I am hoping that will stop the random unwanted updates to the website with unstable versions. | angular-ui-ui-grid | js |
@@ -11,7 +11,9 @@ import (
// State is the status of a process.
type State rune
-const ( // Only values for Linux 3.14 and later are listed here
+// Process state values.
+// Only values for Linux 3.14 and later are listed here.
+const (
Dead State = 'X'
DiskSleep State = 'D'
Running State = 'R' | 1 | package system
import (
"fmt"
"os"
"path/filepath"
"strconv"
"strings"
)
// State is the status of a process.
type State rune
const ( // Only values for Linux 3.14 and later are listed here
Dead State = 'X'
DiskSleep State = 'D'
Running State = 'R'
Sleeping State = 'S'
Stopped State = '... | 1 | 23,686 | Nit: missing period. | opencontainers-runc | go |
@@ -1,10 +1,13 @@
# Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX - License - Identifier: Apache - 2.0
+# Purpose
+# This code example demonstrates how deny uploads of unencrypted objects to an Amazon Simple Storage Solution (Amazon S3) bucket.
+
+# snippet-start:[s3.ruby.s3_add_bucket_s... | 1 | # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
# SPDX - License - Identifier: Apache - 2.0
require 'aws-sdk-s3'
# Denies uploads of unencrypted objects to an Amazon S3 bucket.
#
# Prerequisites:
#
# - The Amazon S3 bucket to deny uploading unencrypted objects.
#
# @param s3_client [Aw... | 1 | 20,531 | how **to** deny Simple Storage **Service** | awsdocs-aws-doc-sdk-examples | rb |
@@ -5,7 +5,7 @@ setResolver(resolver);
/* jshint ignore:start */
mocha.setup({
- timeout: 15000,
+ timeout: 25000,
slow: 500
});
/* jshint ignore:end */ | 1 | import resolver from './helpers/resolver';
import {setResolver} from 'ember-mocha';
setResolver(resolver);
/* jshint ignore:start */
mocha.setup({
timeout: 15000,
slow: 500
});
/* jshint ignore:end */
| 1 | 7,914 | Were you having trouble with timeouts in general acceptance tests or only the editor test? It's possible to set timeouts on a per-test basis by using `this.timeout(25000)` within the `it()` function. I'd like to drop the global timeout in the future if possible rather than increase it - in some circumstances a failing ... | TryGhost-Admin | js |
@@ -246,6 +246,11 @@ def _setSystemConfig(fromPath):
if curSourceDir==fromPath:
curDestDir=toPath
else:
+ if os.path.relpath(curSourceDir,fromPath) == "addons":
+ import addonHandler
+ subDirs[:] = [addon.name for addon in addonHandler.getRunningAddons()]
+ else:
+ subDirs[:] = subDirs
curDes... | 1 | # -*- coding: UTF-8 -*-
#config/__init__.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2018 NV Access Limited, Aleksey Sadovoy, Peter Vágner, Rui Batista, Zahari Yurukov, Joseph Lee, Babbage B.V.
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
... | 1 | 22,491 | I don't think this is necessary. | nvaccess-nvda | py |
@@ -1025,15 +1025,13 @@ func (vd *volAPI) snapEnumerate(w http.ResponseWriter, r *http.Request) {
return
}
- snaps := make([]*api.Volume, len(resp.GetVolumeSnapshotIds()))
- for i, s := range resp.GetVolumeSnapshotIds() {
+ snaps := make([]*api.Volume, 0)
+ for _, s := range resp.GetVolumeSnapshotIds() {
vol,... | 1 | package server
import (
"context"
"encoding/json"
"fmt"
"math"
"net/http"
"strconv"
"strings"
"sync"
"github.com/gorilla/mux"
"github.com/grpc-ecosystem/grpc-gateway/runtime"
"github.com/libopenstorage/openstorage/api"
"github.com/libopenstorage/openstorage/api/errors"
sdk "github.com/libopenstorage/open... | 1 | 8,124 | Instead of blindly ignoring all errors, this should just ignore the volume not found error. | libopenstorage-openstorage | go |
@@ -135,11 +135,9 @@ public class ParquetReader<T> extends CloseableGroup implements CloseableIterabl
throw new RuntimeIOException(e);
}
- long rowPosition = rowGroupsStartRowPos[nextRowGroup];
+ model.setPageSource(pages, rowGroupsStartRowPos == null ? 0 : rowGroupsStartRowPos[nextRowGroup]... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 27,347 | The `rowPosition` will be ignored if the position column is not projected. | apache-iceberg | java |
@@ -215,6 +215,16 @@ spec:
protocol: TCP
- containerPort: 3232
protocol: TCP
+ livenessProbe:
+ exec:
+ command:
+ - /bin/sh
+ - -c
+ - zfs set io.openebs:livenesstimestap='$(date)' cstor-$OPEN... | 1 | /*
Copyright 2018 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 11,110 | Is there a possibility of a clash between periodSeconds and timeoutSeconds? For instance, the current probe is not yet timed-out and the next one has started. | openebs-maya | go |
@@ -38,12 +38,11 @@ public class BesuCommandCustomFactory implements CommandLine.IFactory {
return (T) new VersionProvider(pluginVersionsProvider);
}
- final Constructor<T> constructor = cls.getDeclaredConstructor();
try {
+ final Constructor<T> constructor = cls.getDeclaredConstructor();
... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 21,368 | This logic is already been performed in `CommandLine.defaultFactory().create(cls)` ... whats the point of repeating it here? | hyperledger-besu | java |
@@ -410,7 +410,7 @@ class ManualColumnMove extends BasePlugin {
* @private
*/
updateColumnsMapper() {
- let countCols = this.hot.countSourceCols();
+ let countCols = Math.max(this.hot.countCols(), this.hot.countSourceCols());
let columnsMapperLen = this.columnsMapper._arrayMap.length;
if (c... | 1 | import BasePlugin from './../_base.js';
import Hooks from './../../pluginHooks';
import {arrayEach} from './../../helpers/array';
import {addClass, removeClass, offset} from './../../helpers/dom/element';
import {rangeEach} from './../../helpers/number';
import EventManager from './../../eventManager';
import {register... | 1 | 14,517 | Please change from `let` to `const` here and above. Setting value to `this.hot.countSourceCols()` should be enought probably. | handsontable-handsontable | js |
@@ -796,7 +796,10 @@ int flb_upstream_conn_timeouts(struct mk_list *list)
* waiting for I/O will receive the notification and trigger
* the error to it caller.
*/
- shutdown(u_conn->fd, SHUT_RDWR);
+ if (u_conn->fd != -1) {
+ ... | 1 | /* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/* Fluent Bit
* ==========
* Copyright (C) 2019-2021 The Fluent Bit Authors
* Copyright (C) 2015-2018 Treasure Data Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 15,465 | Somewhat nitpick: I see the `!=` pattern mentioned in the fluent-bit style guide, but imo, it would be safer to check that a fd is non-negative with ` > -1` or `>= 0` | fluent-fluent-bit | c |
@@ -0,0 +1,17 @@
+class CreatePgSearchDocuments < ActiveRecord::Migration
+ def self.up
+ say_with_time("Creating table for pg_search multisearch") do
+ create_table :pg_search_documents do |t|
+ t.text :content
+ t.belongs_to :searchable, :polymorphic => true, :index => true
+ t.timestamp... | 1 | 1 | 15,165 | Use the new Ruby 1.9 hash syntax. | thoughtbot-upcase | rb | |
@@ -25,6 +25,8 @@ import (
"github.com/gogits/gogs/modules/bindata"
"github.com/gogits/gogs/modules/log"
"github.com/gogits/gogs/modules/user"
+
+ "strk.kbt.io/projects/go/libravatar"
)
type Scheme string | 1 | // Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package setting
import (
"fmt"
"net/url"
"os"
"os/exec"
"path"
"path/filepath"
"runtime"
"strings"
"time"
"github.com/Unknwon/com"
_ "github.com/... | 1 | 11,141 | Please host to a GitHub repo. | gogs-gogs | go |
@@ -197,6 +197,12 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) {
return
}
- tag.DoneSplit(tagr.Address)
+ _, err = tag.DoneSplit(tagr.Address)
+ if err != nil {
+ s.Logger.Debugf("done split: %v", err)
+ s.Logger.Error("done split: %v", err)
+ jsonhttp.InternalServerError(w, nil)
+ r... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package api
import (
"encoding/json"
"errors"
"fmt"
"io/ioutil"
"net/http"
"strconv"
"time"
"github.com/ethersphere/bee/pkg/jsonhttp"
"github.com/... | 1 | 11,916 | The Error log message should not expose internals. The message should be something like this `"done split failed for address %v", tagr.Address`. Also, the Debugf would be more informative with the address in the message. | ethersphere-bee | go |
@@ -13,11 +13,15 @@
package args
-import "flag"
+import (
+ "flag"
+)
const (
versionUsage = "Print the agent version information and exit"
- logLevelUsage = "Loglevel: [<crit>|<error>|<warn>|<info>|<debug>]"
+ logLevelUsage = "Loglevel overrides loglevel-driver and loglevel-... | 1 | // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license" file acco... | 1 | 24,806 | can we rename `fileLogLevelUsage` to be more generic like `instanceLogLevelUsage`? Same goes for other var below like fileLogLevelFlagName, FileLogLevel. | aws-amazon-ecs-agent | go |
@@ -169,11 +169,8 @@ define(["loading", "layoutManager", "userSettings", "events", "libraryBrowser",
valueChangeEvent: "click"
});
- if (layoutManager.desktop || layoutManager.mobile) {
- alphaPickerElement.classList.add("alphabetPicker-right");
... | 1 | define(["loading", "layoutManager", "userSettings", "events", "libraryBrowser", "alphaPicker", "listView", "cardBuilder", "emby-itemscontainer"], function (loading, layoutManager, userSettings, events, libraryBrowser, alphaPicker, listView, cardBuilder) {
"use strict";
return function (view, params, tabContent... | 1 | 12,841 | Does this one not need the `tabContent` object used in the other files? | jellyfin-jellyfin-web | js |
@@ -102,6 +102,16 @@ type ClassicELB struct {
Tags map[string]string `json:"tags,omitempty"`
}
+// IsUnmanaged returns true if the Classic ELB is unmanaged.
+func (b *ClassicELB) IsUnmanaged(clusterName string) bool {
+ return b.Name != "" && !Tags(b.Tags).HasOwned(clusterName)
+}
+
+// IsManaged returns true if C... | 1 | /*
Copyright 2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 20,857 | Our use of the terms `managed` and `unmanaged` in CAPA is interesting. I think we should probably update the docs (as part of a separate PR) to explain that we are referring to whether its CAPA managed infra. As opposed to meaning AWS managed service. | kubernetes-sigs-cluster-api-provider-aws | go |
@@ -246,7 +246,7 @@ def record_listens(request, data):
lookup = defaultdict(dict)
for key, value in data.items():
- if key == "sk" or key == "token" or key == "api_key" or key == "method":
+ if key == "sk" or key == "token" or key == "api_key" or key == "method" or key == "api_sig":
... | 1 | import time
import json
import re
from collections import defaultdict
from yattag import Doc
import yattag
from flask import Blueprint, request, render_template
from flask_login import login_required, current_user
from webserver.external import messybrainz
from webserver.rate_limiter import ratelimit
from webserver.err... | 1 | 13,995 | Looks like all of these can be put into a list. | metabrainz-listenbrainz-server | py |
@@ -38,6 +38,8 @@ func CanonicalizeHeaderKey(k string) string {
type Headers struct {
// This representation allows us to make zero-value valid
items map[string]string
+ // map from canonicalized key to original key
+ keyMapping map[string]string
}
// NewHeaders builds a new Headers object. | 1 | // Copyright (c) 2018 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 16,153 | nit: "*mapping" for a map is unnecessary. Consider calling this `originalNames` or similar. | yarpc-yarpc-go | go |
@@ -171,11 +171,11 @@ class ProfilesDialog(wx.Dialog):
index = self.profileList.Selection
if gui.messageBox(
# Translators: The confirmation prompt displayed when the user requests to delete a configuration profile.
- _("Are you sure you want to delete this profile? This cannot be undone."),
+ _("This pro... | 1 | #gui/configProfiles.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2013 NV Access Limited
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
import wx
import config
import api
import gui
from logHandler import log
import appModuleHandler
import gl... | 1 | 19,256 | Please split this into two sentences; i.e. "This profile will be permanently deleted. This action cannot be undone." | nvaccess-nvda | py |
@@ -173,9 +173,10 @@ public class OpenAPSAMAPlugin extends PluginBase implements APSInterface {
startPart = new Date();
if (MainApp.getConstraintChecker().isAutosensModeEnabled().value()) {
- lastAutosensResult = IobCobCalculatorPlugin.getPlugin().detectSensitivityWithLock(IobCobCalculato... | 1 | package info.nightscout.androidaps.plugins.OpenAPSAMA;
import org.json.JSONException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import java.io.IOException;
import java.util.Date;
import info.nightscout.androidaps.Config;
import info.nightscout.androidaps.MainApp;
import info.nightscout.androidaps.R;
i... | 1 | 30,857 | NPE here and in other APS plugins | MilosKozak-AndroidAPS | java |
@@ -142,6 +142,9 @@ func getMsgKey(obj interface{}) (string, error) {
resourceType, _ := edgemessagelayer.GetResourceType(*msg)
resourceNamespace, _ := edgemessagelayer.GetNamespace(*msg)
resourceName, _ := edgemessagelayer.GetResourceName(*msg)
+ if msg.Router.Source == modules.DynamicControllerModuleName {
... | 1 | package channelq
import (
"fmt"
"strings"
"sync"
"k8s.io/apimachinery/pkg/api/meta"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/client-go/tools/cache"
"k8s.io/client-go/util/workqueue"
"k8s.io/klog/v2"
beehiveContext "github.com/kubeedge/beehive/pkg/core/context"
beehiveModel "github.com/kubeedge... | 1 | 22,901 | Thanks for the fixing, and could you please provide more details for this bug? Because we have the deduplication mechanism in cloudhub, so it will has no problem. | kubeedge-kubeedge | go |
@@ -52,6 +52,10 @@ public class ViewSettings extends MainWindowView {
private static final String CAPTION_TITLE_CSS_CLASS = "captionTitle";
private static final String CONFIGURATION_PANE_CSS_CLASS = "containerConfigurationPane";
private static final String TITLE_CSS_CLASS = "title";
+ private String a... | 1 | /*
* Copyright (C) 2015-2017 PÂRIS Quentin
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is... | 1 | 9,070 | These could be final | PhoenicisOrg-phoenicis | java |
@@ -103,7 +103,7 @@ public abstract class AbstractRestInvocation {
@SuppressWarnings("unchecked")
Map<String, String> cseContext =
JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8), Map.class);
- invocation.setContext(cseContext);
+ invocation.addContext(cseContext);
}
... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 10,762 | highway have the same problem we can add a new method in invocation: mergeContext 1.if new context have more items, then addAll to new context, and replace old context 2.if new context have less items, then allAll to old context directly. | apache-servicecomb-java-chassis | java |
@@ -637,12 +637,15 @@ namespace GenFacades
private static void TraceDuplicateSeedTypeError(string docId, IReadOnlyList<INamedTypeDefinition> seedTypes)
{
- Trace.TraceError("The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the follo... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.IO;
using System.Linq;
using ... | 1 | 14,852 | Created a single error so it's not interleaved in log | dotnet-buildtools | .cs |
@@ -94,11 +94,9 @@ describe('exportFile', () => {
const result = plugin._createBlob(formatter);
- if (!Handsontable.helper.isIE9()) {
- expect(formatter.export).toHaveBeenCalled();
- expect(result.size).toBe(7);
- expect(result.type).toBe('foo;charset=iso-8859-1');
- }
+ e... | 1 | describe('exportFile', () => {
const id = 'testContainer';
beforeEach(function() {
this.$container = $(`<div id="${id}"></div>`).appendTo('body');
});
afterEach(function() {
if (this.$container) {
destroy();
this.$container.remove();
}
});
describe('export options', () => {
it... | 1 | 16,394 | `isIE9` was reverted. Shouldn't this condition be reverted as well? | handsontable-handsontable | js |
@@ -504,14 +504,14 @@ int LuaScriptInterface::luaErrorHandler(lua_State* L)
return 1;
}
-bool LuaScriptInterface::callFunction(int params)
+bool LuaScriptInterface::callFunction(int params, bool defaultReturn /* = false */)
{
bool result = false;
int size = lua_gettop(luaState);
if (protectedCall(luaState, ... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 13,693 | Sorry if I'm being too pedantic here, but wouldn't it be nice to have standard parameter name? Like using `defaultValue` everywhere. | otland-forgottenserver | cpp |
@@ -119,9 +119,14 @@ func defaultBServer(ctx Context) string {
case libkb.DevelRunMode:
return memoryAddr
case libkb.StagingRunMode:
- return "bserver-0.dev.keybase.io:443"
+ return `
+ bserver-0.dev.keybase.io:443,bserver-1.dev.keybase.io:443;
+ bserver.dev.keybase.io:443`
case libkb.ProductionRunMode:
... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"context"
"errors"
"flag"
"fmt"
"os"
"os/signal"
"path/filepath"
"strings"
"time"
"github.com/keybase/client/go/libkb"
"github.com/... | 1 | 18,353 | Remind me again: what's the point of having new clients connect to both -0 and -1? If we ever have to blackhole -0, we'd have to blackhole -1 at the same time, right? What is supposed to be the difference between the two? Is it just that someday we might want to have two ELBs, and this will help load balance between th... | keybase-kbfs | go |
@@ -1792,8 +1792,8 @@ func (s *Server) createClient(conn net.Conn) *client {
// Do final client initialization
- // Set the First Ping timer.
- s.setFirstPingTimer(c)
+ // Set the Ping timer. Will be reset once connect was received.
+ c.setPingTimer()
// Spin up the read loop.
s.startGoRoutine(func() { c.re... | 1 | // Copyright 2012-2019 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 10,006 | Why not go back to `c.setPingTimer()` here instead so you don't need the new boolean in setFirstPingTimer(). | nats-io-nats-server | go |
@@ -1,4 +1,4 @@
-/*
+/*
* Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
* | 1 | /*
* Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2009 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 12,314 | We should figure out why so many of these files have an invisible change on the first line: Are we writing out some sort of byte order mark? | ProteoWizard-pwiz | .cs |
@@ -1,19 +1,3 @@
-/*
-Copyright 2018 The Kubernetes Authors.
-
-Licensed under the Apache License, Version 2.0 (the "License");
-you may not use this file except in compliance with the License.
-You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable la... | 1 | /*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 6,592 | Was this our code @csrwng | openshift-hive | go |
@@ -24,6 +24,7 @@ module Travis
end
sh.echo "Build id: #{Shellwords.escape(data.build[:id])}"
sh.echo "Job id: #{Shellwords.escape(data.job[:id])}"
+ sh.echo "Runtime kernel version: #{`uname -r`.strip}"
end
def show_travis_build_version | 1 | require 'travis/build/appliances/base'
require 'shellwords'
module Travis
module Build
module Appliances
class ShowSystemInfo < Base
def apply
sh.fold 'system_info' do
header
show_travis_build_version
show_system_info_file
end
sh.new... | 1 | 15,570 | I think you need `.untaint` here. | travis-ci-travis-build | rb |
@@ -227,7 +227,10 @@ module Bolt
raise Bolt::ValidationError, "The project '#{name}' will not be loaded. The project name conflicts "\
"with a built-in Bolt module of the same name."
end
- else
+ elsif name.nil? &&
+ (File.directory?(plans_path) ||
+ File... | 1 | # frozen_string_literal: true
require 'pathname'
require 'bolt/config'
require 'bolt/validator'
require 'bolt/pal'
require 'bolt/module'
module Bolt
class Project
BOLTDIR_NAME = 'Boltdir'
CONFIG_NAME = 'bolt-project.yaml'
attr_reader :path, :data, :config_file, :inventory_file, :hiera_config,
... | 1 | 17,318 | Why are we including the `files/` directory in this check? I know `tasks/` and `plans/` make sense, since you can reference content in those directories from the CLI, but I don't think you can for `files/` (unless I'm missing a command). | puppetlabs-bolt | rb |
@@ -19,6 +19,8 @@ package org.openqa.grid.web;
import com.google.common.collect.Maps;
+import com.sun.org.glassfish.gmbal.ManagedObject;
+
import org.openqa.grid.internal.Registry;
import org.openqa.grid.internal.utils.GridHubConfiguration;
import org.openqa.grid.web.servlet.DisplayHelpServlet; | 1 | /*
Copyright 2011 Selenium committers
Copyright 2011 Software Freedom Conservancy
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by... | 1 | 11,533 | And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class. | SeleniumHQ-selenium | java |
@@ -72,6 +72,11 @@ const (
// A valid Certificate requires at least one of a CommonName, DNSName, or
// URISAN to be valid.
type CertificateSpec struct {
+ // Full X509 name specification (https://golang.org/pkg/crypto/x509/pkix/#Name).
+ // If specified, overrides any other name elements below.
+ // +optional
+ X50... | 1 | /*
Copyright 2019 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 20,163 | Can we rename this field to `Subject`? Looking around, it seems like 'subject' is the standard terminology for this stanza | jetstack-cert-manager | go |
@@ -15,7 +15,7 @@ was persisted in the address book and the node has been restarted).
So the information has been changed, and potentially upon disconnection,
the depth can travel to a shallower depth in result.
-If a peer gets added through AddPeer, this does not necessarily infer
+If a peer gets added through Add... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
/*
Package kademlia provides an implementation of the topology.Driver interface
in a way that a kademlia connectivity is actively maintained by the node.
A ... | 1 | 11,864 | Remove additional whitespace. | ethersphere-bee | go |
@@ -171,6 +171,16 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
http.SetCookie(w, cookie)
}
+ if cookies := md.HeaderMD.Get("Set-Cookie-Refresh-Token"); len(cookies) > 0 {
+ cookie := &http.Cookie{
+ Name: "refreshToken",
+ Value: cookies[0],
+ Path: "/v1/a... | 1 | package mux
import (
"context"
"fmt"
"io"
"net/http"
"net/http/httptest"
"net/http/pprof"
"net/textproto"
"net/url"
"path"
"regexp"
"strconv"
"strings"
"github.com/grpc-ecosystem/grpc-gateway/v2/runtime"
"golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"
"google.golang.org/grpc"
"google.golang.org... | 1 | 11,202 | We should add `Secure` as well | lyft-clutch | go |
@@ -12,7 +12,7 @@ import (
// TestIntegration runs integration tests against the remote
func TestIntegration(t *testing.T) {
fstests.Run(t, &fstests.Opt{
- RemoteName: "TestWebdavNexcloud:",
+ RemoteName: "TestWebdavNextcloud:",
NilObject: (*webdav.Object)(nil),
})
} | 1 | // Test Webdav filesystem interface
package webdav_test
import (
"testing"
"github.com/rclone/rclone/backend/webdav"
"github.com/rclone/rclone/fstest"
"github.com/rclone/rclone/fstest/fstests"
)
// TestIntegration runs integration tests against the remote
func TestIntegration(t *testing.T) {
fstests.Run(t, &fst... | 1 | 12,081 | I presume this isn't a big deal | rclone-rclone | go |
@@ -2974,7 +2974,8 @@ raw_mem_alloc(size_t size, uint prot, void *addr, dr_alloc_flags_t flags)
: (TEST(DR_ALLOC_COMMIT_ONLY, flags) ? RAW_ALLOC_COMMIT_ONLY : 0);
# endif
if (IF_WINDOWS(TEST(DR_ALLOC_COMMIT_ONLY, flags) &&) addr != NULL &&
- !app_memory_pre_alloc(get_thread_private_... | 1 | /* ******************************************************************************
* Copyright (c) 2010-2019 Google, Inc. All rights reserved.
* Copyright (c) 2010-2011 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2002-2010 VMware, Inc. All rights reserved.
* ************************... | 1 | 18,087 | Maybe {}, even though no multi-line body? | DynamoRIO-dynamorio | c |
@@ -39,6 +39,16 @@ describe CommunicartMailer do
mail.from.should == ['reply@communicart-stub.com']
end
+ it 'renders the navigator template' do
+ cart.setProp('origin','navigator')
+ cart.stub(:approval_group).and_return(approval_group)
+ approval_group.stub(:approvers).and_return([appro... | 1 | require 'spec_helper'
require 'ostruct'
describe CommunicartMailer do
let(:approval_group) { FactoryGirl.create(:approval_group_with_approvers_and_requester, name: "anotherApprovalGroupName") }
let(:approver) { FactoryGirl.create(:user) }
let(:cart) { FactoryGirl.create(:cart_with_approvals, name: "TestCart") }
... | 1 | 11,918 | We can try something like this: response.should render_template(:partial => 'partial_name') | 18F-C2 | rb |
@@ -514,6 +514,10 @@ IDRETRY=4
IDCANCEL=3
def MessageBox(hwnd, text, caption, type):
+ if hasattr(text, 'decode'):
+ text = text.decode('mbcs')
+ if caption and hasattr(caption, 'decode'):
+ caption = caption.decode('mbcs')
res = user32.MessageBoxW(hwnd, text, caption, type)
if res == 0:
raise WinError() | 1 | #winUser.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
"""Functions that wrap Windows API functions from user32.dll"""
from ctypes import *
from ctypes.win... | 1 | 23,351 | Please use `isinstance(text, bytes)` instead. Otherwise, this will lead to unnecessary decoding on python 2 unicode strings. | nvaccess-nvda | py |
@@ -3068,7 +3068,7 @@ void SwiftLanguageRuntime::FindFunctionPointersInCall(
ExecutionContext exe_ctx;
frame.CalculateExecutionContext(exe_ctx);
error = argument_values.GetValueAtIndex(0)->GetValueAsData(
- &exe_ctx, data, 0, NULL);
+ ... | 1 | //===-- SwiftLanguageRuntime.cpp --------------------------------*- C++ -*-===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/L... | 1 | 19,876 | This one is unrelated to the GetSymbolVendor removal ... the API to GetValueAsData was changed. | apple-swift-lldb | cpp |
@@ -45,6 +45,7 @@ func TestMarshalUnmarshalJSON(t *testing.T) {
desiredStatusUnsafe: resourcestatus.ResourceCreated,
knownStatusUnsafe: resourcestatus.ResourceCreated,
appliedStatusUnsafe: resourcestatus.ResourceCreated,
+ networkMode: bridgeNetworkMode,
}
bytes, err := json.Marshal(fi... | 1 | // +build linux,unit
// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or... | 1 | 23,280 | can you assert the value of this field below similar to other fields? | aws-amazon-ecs-agent | go |
@@ -11,6 +11,7 @@ package net.sourceforge.pmd.lang.java.ast;
* <pre class="grammar">
*
* PrimaryExpression ::= {@linkplain ASTLiteral Literal}
+ * | {@link ASTClassLiteral ClassLiteral}
* | {@linkplain ASTMethodCall MethodCall}
* | {@linkplain ASTFie... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.ast;
/**
* Tags those {@link ASTExpression expressions} that are categorised as primary
* by the JLS.
*
* <pre class="grammar">
*
* PrimaryExpression ::= {@linkplain ASTLiteral Literal}
... | 1 | 16,014 | I'll change that to "linkplain" for consistency :) | pmd-pmd | java |
@@ -196,7 +196,12 @@ class RouteFactory(object):
self.resource_name,
**matchdict)
if object_id == '*':
- object_uri = object_uri.replace('%2A', '*')
+ # Express the ob... | 1 | import functools
import six
from pyramid.settings import aslist
from pyramid.security import IAuthorizationPolicy, Authenticated
from zope.interface import implementer
from kinto.core import utils
from kinto.core.storage import exceptions as storage_exceptions
# A permission is called "dynamic" when it's computed a... | 1 | 10,267 | This is fix. But since the history resource was relying on the bug to work, I had to do some changes regarding the history entries (eg. explicit declare that the permissions inherit from bucket) | Kinto-kinto | py |
@@ -142,6 +142,11 @@ public class DocsStreamer implements Iterator<SolrDocument> {
return docIterator.hasNext();
}
+ // called at the end of the stream
+ public void finish(){
+ if (transformer != null) transformer.finish();
+ }
+
public SolrDocument next() {
int id = docIterator.nextDoc();
... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 26,373 | can't we leverage Closeable here and get some sugar&warns? Also, line 89 still calls setContext() .. is it right? or I'm missing something? | apache-lucene-solr | java |
@@ -52,7 +52,7 @@ func TestPing(t *testing.T) {
// ping
peerID := "124"
greetings := []string{"hey", "there", "fella"}
- rtt, err := client.Ping(context.Background(), peerID, greetings...)
+ rtt, err := client.Ping(context.Background(), []byte(peerID), greetings...)
if err != nil {
t.Fatal(err)
} | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package pingpong_test
import (
"bytes"
"context"
"fmt"
"io/ioutil"
"runtime"
"testing"
"time"
"github.com/ethersphere/bee/pkg/logging"
"github.com... | 1 | 8,718 | Use explicit swarm.Address when defining peerID, by using NewAddress, and remove conversion here. | ethersphere-bee | go |
@@ -30,9 +30,13 @@ const (
rootMountPoint = "/"
rootUser = "root"
+ // RpmDependenciesDirectory is the directory which contains RPM database. It is not required for images that do not contain RPM.
+ RpmDependenciesDirectory = "/var/lib/rpm"
+
// /boot directory should be only accesible by root. The direct... | 1 | // Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
package installutils
import (
"crypto/rand"
"fmt"
"os"
"path"
"path/filepath"
"sort"
"strconv"
"strings"
"syscall"
"time"
"microsoft.com/pkggen/imagegen/configuration"
"microsoft.com/pkggen/imagegen/diskutils"
"microsoft.com/pkgg... | 1 | 12,840 | `RpmDependenciesDirectory` should start with a lowercase character so it's not exported outside of this package, it looks like its only referenced in this file. | microsoft-CBL-Mariner | go |
@@ -25,9 +25,13 @@ class BasicBlock(nn.Module):
conv_cfg=None,
norm_cfg=dict(type='BN'),
dcn=None,
+ rfp_inplanes=None,
+ sac=None,
plugins=None):
super(BasicBlock, self).__init__()
assert dcn is No... | 1 | import torch.nn as nn
import torch.utils.checkpoint as cp
from mmcv.cnn import (build_conv_layer, build_norm_layer, constant_init,
kaiming_init)
from mmcv.runner import load_checkpoint
from torch.nn.modules.batchnorm import _BatchNorm
from mmdet.ops import build_plugin_layer
from mmdet.utils impo... | 1 | 20,149 | If we make a new backbone class, we don't need to support `BasicBlock` | open-mmlab-mmdetection | py |
@@ -359,11 +359,6 @@ configRetry:
// Start up the dataplane driver. This may be the internal go-based driver or an external
// one.
- if configParams.BPFEnabled && !bpf.SyscallSupport() {
- log.Error("BPFEnabled is set but BPF mode is not supported on this platform. Continuing with BPF disabled.")
- configPar... | 1 | // Copyright (c) 2020 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,869 | This was an out-of-date dupe of the check on line 335 | projectcalico-felix | go |
@@ -44,7 +44,6 @@ window.PluginsView = countlyView.extend({
this.dtable = $('#plugins-table').dataTable($.extend({}, $.fn.dataTable.defaults, {
"aaData": pluginsData,
- "bPaginate": false,
"aoColumns": [
{ "mData": function (row, type)... | 1 | window.PluginsView = countlyView.extend({
initialize: function () {
this.filter = (store.get("countly_pluginsfilter")) ? store.get("countly_pluginsfilter") : "plugins-all";
},
beforeRender: function () {
if (this.template)
return $.when(countlyPlugins.initialize()).then(function ... | 1 | 12,900 | Let's put this back | Countly-countly-server | js |
@@ -122,9 +122,9 @@ bool Mailbox::sendItem(Item* item) const
}
} else {
Player tmpPlayer(nullptr);
- if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
+ //if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
return false;
- }
+ //}
if (g_game.internalMoveItem(item->getParent(), tmp... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2014 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 10,130 | Things like these should have been addressed before submitting a pull request. | otland-forgottenserver | cpp |
@@ -77,7 +77,7 @@ public class ITZipkinMetrics {
// ensure we don't track prometheus, UI requests in prometheus
assertThat(scrape())
- .doesNotContain("prometheus")
+ .doesNotContain("prometheus_notifications")
.doesNotContain("uri=\"/zipkin")
.doesNotContain("uri=\"/\"");
} | 1 | /*
* Copyright 2015-2019 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or a... | 1 | 16,960 | This one as well. Any better suggestion please? | openzipkin-zipkin | java |
@@ -267,6 +267,11 @@ func (s *Server) internalSendLoop(wg *sync.WaitGroup) {
c.pa.reply = []byte(pm.rply)
c.mu.Unlock()
+ if c.trace {
+ c.traceInOp(fmt.Sprintf(
+ "PUB %s %s %d", c.pa.subject, c.pa.reply, c.pa.size), nil)
+ }
+
// Add in NL
b = append(b, _CRLF_...)
c.processInboundClie... | 1 | // Copyright 2018-2019 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 10,036 | wonder if we should collect c.trace, c.pa.subject, etc.. while under the lock to prevent data races.. or simply move the tracing under the lock. | nats-io-nats-server | go |
@@ -182,7 +182,7 @@ PJ_XY pj_fwd(PJ_LP lp, PJ *P) {
last_errno = proj_errno_reset(P);
- if (!P->skip_fwd_prepare)
+ if (!P->skip_fwd_prepare && 0 != strcmp(P->short_name, "s2"))
coo = fwd_prepare (P, coo);
if (HUGE_VAL==coo.v[0] || HUGE_VAL==coo.v[1])
return proj_coord_error ().xy; | 1 | /******************************************************************************
* Project: PROJ.4
* Purpose: Forward operation invocation
* Author: Thomas Knudsen, thokn@sdfe.dk, 2018-01-02
* Based on material from Gerald Evenden (original pj_fwd)
* and Piyush Agram (original pj_fwd3d)
*... | 1 | 12,608 | Why is this hack needed ? Ideally, we shouldn't need that. | OSGeo-PROJ | cpp |
@@ -0,0 +1,19 @@
+package plugin
+
+type Status struct {
+ DriverName string
+ MeshDriverName string `json:"MeshDriverName,omitempty"`
+ Version int
+}
+
+func NewStatus(address, meshAddress string, isPluginV2 bool) *Status {
+ status := &Status{
+ DriverName: pluginNameFromAddress(address),
+ MeshDriv... | 1 | 1 | 14,845 | Minor/Nitpick: replace `1` with a constant, esp. as used in `prog/weaver/http.go` in `{{if eq .Plugin.Version 1}}` | weaveworks-weave | go | |
@@ -13,5 +13,5 @@ namespace Datadog.Trace.Configuration
{
return Environment.GetEnvironmentVariable(key);
}
- }
+ }
} | 1 | using System;
namespace Datadog.Trace.Configuration
{
/// <summary>
/// Represents a configuration source that
/// retrieves values from environment variables.
/// </summary>
public class EnvironmentConfigurationSource : StringConfigurationSource
{
/// <inheritdoc />
public over... | 1 | 15,882 | nit: Looks like the whitespace got thrown off, can you fix this? | DataDog-dd-trace-dotnet | .cs |
@@ -5593,7 +5593,13 @@ namespace pwiz.Skyline.Properties {
return ResourceManager.GetString("CommandLine_ImportAnnotations_Error__Failed_while_reading_annotations_", resourceCulture);
}
}
-
+
+ public static string CommandLine_ImportPeakBoundaries_Error__Failed_whil... | 1 | //------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generate... | 1 | 14,468 | Redo this by adding a string literal and then pressing F6 to have Resharper move it to Properties\Resources.resx which will also create this property. | ProteoWizard-pwiz | .cs |
@@ -0,0 +1,11 @@
+// +build !windows
+// Copyright 2012-2017 Apcera Inc. All rights reserved.
+
+package server
+
+// Run starts the NATS server. This wrapper function allows Windows to add a
+// hook for running NATS as a service.
+func Run(server *Server) error {
+ server.Start()
+ return nil
+} | 1 | 1 | 7,146 | Unless a log file has been specified, IMO you should set the server option to enable syslog (windows event log) here, or someplace along the service start code path. We shouldn't really rely on users to specify that when creating the service. | nats-io-nats-server | go | |
@@ -86,8 +86,8 @@ public class TestFlinkCatalogTable extends FlinkCatalogTestBase {
Types.NestedField.optional(1, "strV", Types.StringType.get())));
Assert.assertEquals(
Arrays.asList(
- TableColumn.of("id", DataTypes.BIGINT()),
- TableColumn.of("strV", DataTypes.STRING(... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 30,627 | It's strange here, because I saw the `TableColumn` is marked as `PublicEvolving`, but after released flink 1.12.0 it did not have any Interface compatibility guarantee. At least, it should marked as `deprecated`, and keep it a major release. | apache-iceberg | java |
@@ -104,7 +104,7 @@ public abstract class ConnectionPageAbstract extends DialogPage implements IData
if (!site.isNew() && !site.getDriver().isEmbedded()) {
Link netConfigLink = new Link(panel, SWT.NONE);
- netConfigLink.setText("<a>Network settings (SSH, SSL, Proxy, ...)</a>");
+ ... | 1 | /*
* DBeaver - Universal Database Manager
* Copyright (C) 2010-2017 Serge Rider (serge@jkiss.org)
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org... | 1 | 10,278 | I'm not sure regarding this approach, for me the whole text including anchors should go to resources like ` netConfigLink.setText(CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link); ` You shouldn't concatenate translated values inside the code. If you need some params, please use NLS.bind() | dbeaver-dbeaver | java |
@@ -78,6 +78,7 @@ func (c *connectionFlowController) GetWindowUpdate() protocol.ByteCount {
func (c *connectionFlowController) EnsureMinimumWindowSize(inc protocol.ByteCount) {
c.mutex.Lock()
if inc > c.receiveWindowSize {
+ c.logger.Debugf("Increasing receive flow control window for the connection to %d kB, in r... | 1 | package flowcontrol
import (
"fmt"
"github.com/lucas-clemente/quic-go/internal/congestion"
"github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/internal/utils"
"github.com/lucas-clemente/quic-go/qerr"
)
type connectionFlowController struct {
lastBlockedAt protocol.ByteCount
... | 1 | 7,571 | How often do we expect this to trigger? Should we maybe put it behind an if logger.Debug()? | lucas-clemente-quic-go | go |
@@ -126,12 +126,12 @@ func Snapshot(volname string, snapname string, labels map[string]string) (string
return "", err
}
- volume, err := GetVolume(controller.address)
+ volume, err := GetVolume(controller.Address)
if err != nil {
return "", err
}
- url := controller.address + "/volumes/" + volume.Id + "... | 1 | package command
import (
"bytes"
"encoding/json"
"errors"
"flag"
"fmt"
"io/ioutil"
"log"
"net/http"
"regexp"
"strings"
)
var (
MaximumVolumeNameSize = 64
parsePattern = regexp.MustCompile(`(.*):(\d+)`)
)
type SnapshotCreateCommand struct {
Meta
Name string
Sname string
Labels map[string]s... | 1 | 6,731 | How was the name `controller` arrived? Can you get a consensus for the name controller ? This may be OK for jiva. However, c-stor does not have a concept called `controller`. | openebs-maya | go |
@@ -151,6 +151,16 @@ func (v *ConfigValidator) sysctl(config *configs.Config) error {
return fmt.Errorf("sysctl %q is not allowed in the hosts network namespace", s)
}
}
+ if config.Namespaces.Contains(configs.NEWUTS) {
+ switch s {
+ case "kernel.domainname":
+ // This is namespaced and there's no ... | 1 | package validate
import (
"fmt"
"os"
"path/filepath"
"strings"
"github.com/opencontainers/runc/libcontainer/configs"
"github.com/opencontainers/runc/libcontainer/intelrdt"
selinux "github.com/opencontainers/selinux/go-selinux"
)
type Validator interface {
Validate(*configs.Config) error
}
func New() Validat... | 1 | 16,552 | i dont think we need to explicitly single out `kernel.domainname` here since its not a TODO for OCI either right ? | opencontainers-runc | go |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.