patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -222,13 +222,15 @@ class Order extends BaseAction implements EventSubscriberInterface
$pse = $cartItem->getProductSaleElements();
/* check still in stock */
- if ($cartItem->getQuantity() > $pse->getQuantity()) {
+ if ($cartItem->getQuantity() > $pse->getQuantity() &... | 1 | <?php
/*************************************************************************************/
/* This file is part of the Thelia package. */
/* */
/* Copyright (c) OpenStudio ... | 1 | 10,360 | variable must be in camelCase => $newStock | thelia-thelia | php |
@@ -73,7 +73,7 @@ func setActionFlags(cmds ...*cobra.Command) {
func sendAction(elp action.Envelope) string {
fmt.Printf("Enter password #%s:\n", signer)
- bytePassword, err := terminal.ReadPassword(syscall.Stdin)
+ bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
if err != nil {
log.L().Error("... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 16,472 | unnecessary conversion (from `unconvert`) | iotexproject-iotex-core | go |
@@ -345,6 +345,18 @@ final class BitMappedTrie<T> implements Serializable {
return index;
}
+ Object[] toArray() {
+ final Object[] results = new Object[length];
+ visit((index, leaf, start, end) -> {
+ final int copied = end - start;
+ for (int i = start; i < end;... | 1 | /* / \____ _ _ ____ ______ / \ ____ __ _______
* / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG
* _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2017 Javaslang, http://javaslang.io
* /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ... | 1 | 11,789 | ... is probably automatically vectorized, since it has the same speed as `System.arraycopy` | vavr-io-vavr | java |
@@ -15,9 +15,19 @@
package engine
+import (
+ "github.com/aws/amazon-ecs-agent/agent/resources/cgroup"
+ "github.com/cihub/seelog"
+ "github.com/pkg/errors"
+)
+
+// control is used to manipulate cgroups and ease testing
+var control cgroup.Control
+
// SetupPlatformResources sets up platform level resources
fun... | 1 | // +build linux
// Copyright 2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in ... | 1 | 17,057 | Is there anyway to get rid of the global variable, if it is specific for each task, can you add it to the `mtask` struct? | aws-amazon-ecs-agent | go |
@@ -77,12 +77,12 @@ func TestDeserializeFromFlatBuffer(t *testing.T) {
{
name: "simple unary expr",
fbFn: getUnaryOpFlatBuffer,
- polyType: `forall [] float`,
+ polyType: `float`,
},
{
name: "function expression",
fbFn: getFnExprFlatBuffer,
- polyType: `forall [t0, t1] (a:... | 1 | package semantic_test
import (
"errors"
"fmt"
"regexp"
"strconv"
"strings"
"testing"
flatbuffers "github.com/google/flatbuffers/go"
"github.com/google/go-cmp/cmp"
"github.com/influxdata/flux/ast"
"github.com/influxdata/flux/internal/fbsemantic"
"github.com/influxdata/flux/parser"
"github.com/influxdata/fl... | 1 | 16,018 | Surprised to see this old syntax here, but not _that_ surprised. | influxdata-flux | go |
@@ -164,9 +164,16 @@ abstract class AbstractQueue<T, Q extends AbstractQueue<T, Q>> implements Traver
return Collections.removeAll((Q) this, elements);
}
- @SuppressWarnings("unchecked")
+ @Deprecated
public Q removeAll(Predicate<? super T> predicate) {
- return Collections.removeAll((... | 1 | /* __ __ __ __ __ ___
* \ \ / / \ \ / / __/
* \ \/ / /\ \ \/ / /
* \____/__/ \__\____/__/
*
* Copyright 2014-2017 Vavr, http://vavr.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may ... | 1 | 12,715 | It is good to mark it! Maybe we can remove the method for Vavr 1.0.0 - but for now it can stay as-is. Thx! | vavr-io-vavr | java |
@@ -15,11 +15,12 @@
package pool
import (
+ "errors"
"sync"
- "time"
"github.com/golang/glog"
- "github.com/openebs/maya/pkg/util"
+ col "github.com/openebs/maya/cmd/maya-exporter/app/collector"
+ types "github.com/openebs/maya/pkg/exec"
zpool "github.com/openebs/maya/pkg/zpool/v1alpha1"
"github.com/prome... | 1 | // Copyright © 2017-2019 The OpenEBS Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law o... | 1 | 12,234 | exported func New returns unexported type *pool.pool, which can be annoying to use | openebs-maya | go |
@@ -17,7 +17,7 @@ module BoltSpec
# Nothing on the executor is 'public'
class MockExecutor
- attr_reader :noop, :error_message, :in_parallel
+ attr_reader :noop, :error_message, :in_parallel, :transports
attr_accessor :run_as, :transport_features, :execute_any_plan
def initialize(m... | 1 | # frozen_string_literal: true
require 'bolt_spec/plans/action_stubs'
require 'bolt_spec/plans/publish_stub'
require 'bolt/error'
require 'bolt/executor'
require 'bolt/result_set'
require 'bolt/result'
require 'pathname'
require 'set'
module BoltSpec
module Plans
MOCKED_ACTIONS = %i[command download plan script ... | 1 | 18,066 | Sorry, I feel like I'm missing something - where does this get called? | puppetlabs-bolt | rb |
@@ -423,12 +423,9 @@ func (e *edged) syncNodeStatus() {
klog.Errorf("Register node failed: %v", err)
return
}
- if err := e.updateNodeStatus(); err != nil {
- klog.Errorf("Unable to update node status: %v", err)
- }
- } else {
- if err := e.updateNodeStatus(); err != nil {
- klog.Errorf("Unable to upd... | 1 | /*
Copyright 2016 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 19,076 | @guihecheng Thanks for the fixing! Actually this is not the dup codes, when we first registerNode, then update the nodestatus immediately, or the node will keep not ready for 10s. And do you have other ways to refactor it? | kubeedge-kubeedge | go |
@@ -14,6 +14,7 @@
#include "SystemInfo.hpp"
+#include <sys/stat.h>
#ifdef _WIN32
#include <windows.h>
#else | 1 | // Copyright 2021 Proyectos y Sistemas de Mantenimiento SL (eProsima).
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless re... | 1 | 22,915 | How portable is this? (e.g., Windows). I'm relaunching tests of windows because they failed for other reasons. | eProsima-Fast-DDS | cpp |
@@ -7498,10 +7498,13 @@ static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_stat
cb_state->hasDrawCmd = true;
// Add descriptor image/CIS layouts to CB layout map
- auto &desc_sets = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets;
- for (auto &desc : d... | 1 | /* Copyright (c) 2015-2018 The Khronos Group Inc.
* Copyright (c) 2015-2018 Valve Corporation
* Copyright (c) 2015-2018 LunarG, Inc.
* Copyright (C) 2015-2018 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You m... | 1 | 9,219 | What this does is narrow down what we are saying the descriptor set is requiring. This is a good thing, but doesn't go far enough, we are still potentially setting unused bindings to either a required state or an invalid one. set_binding_pair.second is a map of the binding/requirements from the bound shaders... and ins... | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -1038,11 +1038,10 @@ func (core *coreService) BlockMetas(start uint64, count uint64) ([]*iotextypes.B
var (
tipHeight = core.bc.TipHeight()
- res []*iotextypes.BlockMeta
+ res = make([]*iotextypes.BlockMeta, 0)
)
if start > tipHeight {
- log.L().Debug("err in BlockMetas()", zap.Error(status... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 24,373 | should use `codes.InvalidArgument`, same as above line 1033 and 1036 | iotexproject-iotex-core | go |
@@ -51,7 +51,7 @@ func getAgentVersions() []DockerVersion {
return append(getWindowsReplaceableVersions(), MinDockerAPIWindows)
}
-// getDefaultVersion returns agent's default version of the Docker API
+// GetDefaultVersion returns agent's default version of the Docker API
func getDefaultVersion() DockerVersion {... | 1 | // +build windows
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// ... | 1 | 16,003 | Please revert this file. | aws-amazon-ecs-agent | go |
@@ -18,10 +18,13 @@
//
// URLs
//
-// For pubsub.OpenTopic/Subscription URLs, azurepubsub registers for the scheme
-// "azuresb". The Service Bus Connection String defaults to the environment
-// variable "SERVICEBUS_CONNECTION_STRING". For details on the format of the
-// URL, see URLOpener.
+// For pubsub.OpenTopi... | 1 | // Copyright 2018 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 15,572 | Probably in another PR, I think the package should be renamed to `servicebus` to be consistent. | google-go-cloud | go |
@@ -557,7 +557,7 @@ namespace AutoRest.Core.Properties {
}
/// <summary>
- /// Looks up a localized string similar to A swagger must have security definitions and must adhere to the specific structure..
+ /// Looks up a localized string similar to Every swagger/configuratio... | 1 | //------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generated>
//--... | 1 | 24,771 | curious: are we planning to add link to each of the rules in the message? | Azure-autorest | java |
@@ -248,6 +248,11 @@ func (exp *MockExplorer) GetDeposits(subChainID int64, offset int64, limit int64
return nil, nil
}
+// SettleDeposit settles deposit on sub-chain
+func (exp *MockExplorer) SettleDeposit(req explorer.SettleDepositRequest) (res explorer.SettleDepositResponse, err error) {
+ return explorer.Settl... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 13,234 | line is 123 characters | iotexproject-iotex-core | go |
@@ -69,7 +69,7 @@ class AuthorizationService extends AbstractAuthenticationService
* whether a user is authenticated.
*
* @see \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::checkAuthentication()
- * @param array Array of user data
+ * @param array $user of user data
* @retur... | 1 | <?php
namespace ApacheSolrForTypo3\Solr\IndexQueue\FrontendHelper;
/***************************************************************
* Copyright notice
*
* (c) 2011-2015 Ingo Renner <ingo@typo3.org>
* All rights reserved
*
* This script is part of the TYPO3 project. The TYPO3 project is
* free software; you... | 1 | 5,913 | same here; `@param array $user Array of user data` | TYPO3-Solr-ext-solr | php |
@@ -21,7 +21,7 @@ func TestString(t *testing.T) {
b.Append("a")
}
},
- sz: 256,
+ sz: 0,
want: []interface{}{
"a", "a", "a", "a", "a",
"a", "a", "a", "a", "a", | 1 | package array_test
import (
"testing"
"github.com/apache/arrow/go/arrow/memory"
"github.com/influxdata/flux/array"
)
func TestString(t *testing.T) {
for _, tc := range []struct {
name string
build func(b *array.StringBuilder)
sz int
want []interface{}
}{
{
name: "Constant",
build: func(b *a... | 1 | 16,476 | A quick read of this test indicates that we're changing the behavior of this api, and so the test needs updating. Is that right? | influxdata-flux | go |
@@ -5,13 +5,13 @@
using System;
using Android.Content;
using Android.Runtime;
-using Android.Support.V7.Widget;
+using AndroidX.RecyclerView.Widget;
using Java.Lang;
using MvvmCross.Logging;
-namespace MvvmCross.Droid.Support.V7.RecyclerView
+namespace MvvmCross.DroidX.RecyclerView
{
- [Register("mvvmcross.d... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MS-PL license.
// See the LICENSE file in the project root for more information.
using System;
using Android.Content;
using Android.Runtime;
using Android.Support.V7.Widget;
using Java.Lang;
usi... | 1 | 15,185 | Register needs lowercasing | MvvmCross-MvvmCross | .cs |
@@ -134,6 +134,9 @@ public class Constants {
public static final String EXECUTION_SOURCE_SCHEDULED = "schedule";
public static final String EXECUTION_SOURCE_EVENT = "event";
+ // Should validate proxy user
+ public static final boolean DEFAULT_VALIDATE_PROXY_USER = false;
+
public static class Configuratio... | 1 | /*
* Copyright 2018 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 21,006 | This should belong to FlowContainer class. | azkaban-azkaban | java |
@@ -412,7 +412,10 @@ class NVDAHighlighter(providerBase.VisionEnhancementProvider):
window = self.window = self.customWindowClass(self)
self.timer = winUser.WinTimer(window.handle, 0, self._refreshInterval, None)
msg = MSG()
- while winUser.getMessage(byref(msg), None, 0, 0):
+ # Python 3.8 note, Change this... | 1 | # visionEnhancementProviders/NVDAHighlighter.py
# A part of NonVisual Desktop Access (NVDA)
# This file is covered by the GNU General Public License.
# See the file COPYING for more details.
# Copyright (C) 2018-2019 NV Access Limited, Babbage B.V., Takuya Nishimoto
"""Default highlighter based on GDI Plus."""
... | 1 | 28,049 | I think there is a chance that on disable/enable cycling, referring to `self.window` is problematic. In the `__init__` method `self.window` is set to None. If `__init__` gets called before `_run` exits the `while` loop then we wont call `self.window.destroy()`. Can you use non-instance variables after this point? I don... | nvaccess-nvda | py |
@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
// Set up tests and give ourselves a working directory.
assert := asrt.New(t)
+ noninteractive := "DRUD_NONINTERACTIVE"
+ // nolint: errcheck
+ defer os.Setenv(noninteractive, os.Getenv(noninteractive))
+ err := os.Unsetenv(... | 1 | package ddevapp_test
import (
"bufio"
"fmt"
"github.com/drud/ddev/pkg/exec"
"github.com/stretchr/testify/require"
"io/ioutil"
"os"
"path/filepath"
"strings"
"testing"
. "github.com/drud/ddev/pkg/ddevapp"
"github.com/drud/ddev/pkg/fileutil"
"github.com/drud/ddev/pkg/testcommon"
"github.com/drud/ddev/pkg/u... | 1 | 13,217 | I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv? | drud-ddev | php |
@@ -56,9 +56,15 @@ public class TableProperties {
public static final String PARQUET_COMPRESSION = "write.parquet.compression-codec";
public static final String PARQUET_COMPRESSION_DEFAULT = "gzip";
+ public static final String PARQUET_WRITE_MODE = "write.parquet.write-mode";
+ public static final String PARQ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 14,524 | nice, having the "overwrite" default makes this change backwards compatible, right? | apache-iceberg | java |
@@ -108,7 +108,7 @@ public class DefaultReactiveOAuth2UserService implements ReactiveOAuth2UserServi
authenticationMethod);
// @formatter:off
Mono<Map<String, Object>> userAttributes = requestHeadersSpec.retrieve()
- .onStatus((s) -> s != HttpStatus.OK, (response) ->
+ .onStatus((s) -> !s.is2xxSuc... | 1 | /*
* Copyright 2002-2020 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by a... | 1 | 16,794 | It doesn't make sense to accept all 2xx status code. For example, `203 Non-Authoritative Information` or `205 Reset Content`, etc. | spring-projects-spring-security | java |
@@ -385,16 +385,8 @@ class SplitOp implements CoreAdminHandler.CoreAdminOp {
// compare to current prefix bucket and see if this new term shares the same prefix
if (term != null && term.length >= currPrefix.length && currPrefix.length > 0) {
- int i = 0;
- for (; i < currPrefix.length; i++... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 30,161 | Found a better choice here that doesn't involve object creation: StringHelper.startsWith() | apache-lucene-solr | java |
@@ -250,8 +250,15 @@ func (s *nodeServer) attest(
attestedData *common.AttestedData, attestedBefore bool) (
response *nodeattestor.AttestResponse, err error) {
- // TODO: Pick the right node attestor [#222]
- nodeAttestor := s.catalog.NodeAttestors()[0]
+ // Pick the right node attestor
+ var nodeAttestor nodeatt... | 1 | package server
import (
"crypto/x509"
"errors"
"fmt"
"io"
"net/url"
"path"
"reflect"
"sort"
"strings"
"time"
"github.com/sirupsen/logrus"
"github.com/spiffe/go-spiffe/uri"
"github.com/spiffe/spire/pkg/common/selector"
"github.com/spiffe/spire/pkg/common/util"
"github.com/spiffe/spire/pkg/server/catalog... | 1 | 8,917 | Shouldn't we consider the situation where it doesn't find a plugin? | spiffe-spire | go |
@@ -24,7 +24,12 @@ namespace oneapi::dal::csv {
template <>
class detail::v1::read_args_impl<table> : public base {
public:
- read_args_impl() {}
+ read_args_impl(preview::read_mode mode = preview::read_mode::table) : mode(mode) {
+ if (mode != preview::read_mode::table)
+ throw invalid_argum... | 1 | /*******************************************************************************
* Copyright 2020-2021 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apa... | 1 | 31,781 | Do not understand why this needed for table. All new classes defined in the `preview` namespace. | oneapi-src-oneDAL | cpp |
@@ -17,6 +17,8 @@
package com.yahoo.athenz.common.server.notification;
public final class NotificationServiceConstants {
+ public static final String NOTIFICATION_PROP_SERVICE_FACTORY_CLASS = "athenz.zms.notification_service_factory_class";
+
public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL ... | 1 | /*
* Copyright 2020 Verizon Media
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed t... | 1 | 4,936 | Kept the same property value even though it is now in Common to avoid breaking existing clients. | AthenZ-athenz | java |
@@ -52,7 +52,7 @@ public class InclusiveMetricsEvaluator {
return visitors.get();
}
- InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+ public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
this(schema, unbound, true);
}
| 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 14,912 | TODO: this is temporary until we figure out case sensitivity for metrics evaluators. | apache-iceberg | java |
@@ -503,9 +503,10 @@ func (node *Node) Start(ctx context.Context) error {
// TODO it is possible the syncer interface should be modified to
// make use of the additional context not used here (from addr + height).
// To keep things simple for now this info is not used.
- err := node.Syncer.HandleNewBlocks(con... | 1 | package node
import (
"context"
"encoding/json"
"fmt"
"os"
"sync"
"time"
"github.com/ipfs/go-bitswap"
bsnet "github.com/ipfs/go-bitswap/network"
bserv "github.com/ipfs/go-blockservice"
"github.com/ipfs/go-cid"
"github.com/ipfs/go-datastore"
"github.com/ipfs/go-hamt-ipld"
bstore "github.com/ipfs/go-ipfs-b... | 1 | 18,293 | can we just kill this TODO? | filecoin-project-venus | go |
@@ -33,7 +33,7 @@ func TestDAGGet(t *testing.T) {
dag := NewDAG(dserv)
_, err := dag.GetNode(ctx, "awful")
- assert.EqualError(t, err, "invalid 'ipfs ref' path")
+ assert.EqualError(t, err, "invalid path \"awful\": selected encoding not supported")
})
t.Run("ILPD node not found results in error", func(t... | 1 | package dag
import (
"context"
"testing"
"time"
"github.com/filecoin-project/go-address"
"github.com/ipfs/go-blockservice"
"github.com/ipfs/go-datastore"
blockstore "github.com/ipfs/go-ipfs-blockstore"
offline "github.com/ipfs/go-ipfs-exchange-offline"
format "github.com/ipfs/go-ipld-format"
"github.com/ipf... | 1 | 23,573 | This appears to be a change in error handling due to a dag upgrade. | filecoin-project-venus | go |
@@ -246,7 +246,9 @@ module Beaker
end
it 'calls beaker-hostgenerator to get hosts information' do
- parser.instance_variable_set( :@options, {} )
+ parser.instance_variable_set( :@options, {
+ :hosts_file => 'notafile.yml'
+ } )
allow( B... | 1 | require "spec_helper"
module Beaker
module Options
describe Parser do
let(:parser) { Parser.new }
let(:opts_path) { File.join(File.expand_path(File.dirname(__FILE__)), "data", "opts.txt") }
let(:hosts_path) { File.join(File.expand_path(File.dirname(__FILE__)), "data", "hosts.cfg") }
it ... | 1 | 13,927 | These changes look like a hosts file _must_ be provided? | voxpupuli-beaker | rb |
@@ -92,8 +92,9 @@ int FixPythonInvoke::setmask()
void FixPythonInvoke::end_of_step()
{
PyUtils::GIL lock;
+ char fmt[] = "O";
- PyObject * result = PyObject_CallFunction((PyObject*)pFunc, "O", (PyObject*)lmpPtr);
+ PyObject * result = PyObject_CallFunction((PyObject*)pFunc, fmt, (PyObject*)lmpPtr);
if (!... | 1 | /* ----------------------------------------------------------------------
LAMMPS - Large-scale Atomic/Molecular Massively Parallel Simulator
https://lammps.sandia.gov/, Sandia National Laboratories
Steve Plimpton, sjplimp@sandia.gov
Copyright (2003) Sandia Corporation. Under the terms of Contract
DE-AC... | 1 | 30,574 | @akohlmey Just make it a cast like the others. I dislike it either way, but that's the price we pay for Python 2 support. | lammps-lammps | cpp |
@@ -68,6 +68,7 @@ program
.option('--disable_brave_extension', 'disable loading the Brave extension')
.option('--disable_pdfjs_extension', 'disable loading the PDFJS extension')
.option('--enable_brave_update', 'enable brave update')
+ .option('--channel <target_chanel>', 'target channel to start', /^(beta|de... | 1 | /* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
const program = require('commander');
const path = require('path')
const fs = require('fs-extra')
const config = r... | 1 | 5,387 | I wonder if the default here should be nightly? I won't block on that though just a question for a follow up. | brave-brave-browser | js |
@@ -181,7 +181,7 @@ namespace TestRunner
Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
Application.ThreadException += ThreadExceptionEventHandler;
- Console.OutputEncoding = Encoding.UTF8; // So we can send Japanese to SkylineTester, which monitors... | 1 | /*
* Original author: Don Marsh <donmarsh .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2012 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in complian... | 1 | 12,384 | Also not for merge to master. | ProteoWizard-pwiz | .cs |
@@ -201,6 +201,10 @@ class ScheduleDefinition:
raise DagsterInvalidDefinitionError(
f"Found invalid cron schedule '{self._cron_schedule}' for schedule '{name}''."
)
+ if len(self._cron_schedule.split(" ")) != 5:
+ raise DagsterInvalidDefinitionError(
+ ... | 1 | import copy
from contextlib import ExitStack
from datetime import datetime
from typing import TYPE_CHECKING, Any, Callable, Dict, List, NamedTuple, Optional, Union, cast
import pendulum
from croniter import croniter
from dagster import check
from dagster.seven import funcsigs
from ...serdes import whitelist_for_serde... | 1 | 17,849 | nit `non-standard` might be a bit subjective - maybe "Cron schedule {blah} is in an unrecognized format. Dagster cron strings must consist of five characters separated by a single space chacater". | dagster-io-dagster | py |
@@ -163,7 +163,6 @@ public class ServerPickerActivityTest {
openCustomEditDialog();
}
setText(com.salesforce.androidsdk.R.id.sf__picker_custom_label, label);
- clickView(com.salesforce.androidsdk.R.id.sf__picker_custom_url);
setText(com.salesforce.androidsdk.R.id.sf__picke... | 1 | /*
* Copyright (c) 2011-present, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright noti... | 1 | 16,718 | ARM emulator gets tripped up on the copy/paste menu when tapping the text. Tapping on the text field isn't necessary for setting text. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -68,11 +68,12 @@ public class SpellChecker {
}
char[] wordChars = word.toCharArray();
- if (dictionary.isForbiddenWord(wordChars, wordChars.length)) {
- return false;
+ Boolean simpleResult = checkSimpleWord(wordChars, wordChars.length, null);
+ if (simpleResult != null) {
+ return sim... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 40,284 | extra word lookup removed | apache-lucene-solr | java |
@@ -520,6 +520,12 @@ webdriver.WebDriver.prototype.call = function(fn, opt_scope, var_args) {
* Schedules a command to wait for a condition to hold, as defined by some
* user supplied function. If any errors occur while evaluating the wait, they
* will be allowed to propagate.
+ *
+ * <p>In the event a condition ... | 1 | // Copyright 2011 Software Freedom Conservancy. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless req... | 1 | 10,951 | Will you link to {!webdriver.promise.Promise} here? | SeleniumHQ-selenium | py |
@@ -45,6 +45,7 @@ Workshops::Application.routes.draw do
resources :licenses, only: [:create]
end
get '/products/:id/purchases/:lookup' => redirect("/purchases/%{lookup}")
+ get '/purchases/:lookup' => 'pages#show', id: 'purchase-show'
resources :books, only: :show, controller: 'products' do
resour... | 1 | Workshops::Application.routes.draw do
use_doorkeeper
mount RailsAdmin::Engine => '/admin', :as => 'admin'
root to: 'homes#show'
get '/api/v1/me.json' => 'api/v1/users#show', as: :resource_owner
namespace :api do
namespace :v1 do
resources :completions, only: [:index, :show, :create, :destroy]
... | 1 | 10,435 | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. | thoughtbot-upcase | rb |
@@ -96,11 +96,10 @@ public class DataService extends IntentService {
ObjectivesPlugin.bgIsAvailableInNS = true;
ObjectivesPlugin.saveProgress();
} else if (isNSProfile && Intents.ACTION_NEW_PROFILE.equals(action)){
- // always handle Profili if NSProfile is ... | 1 | package info.nightscout.androidaps.Services;
import android.app.IntentService;
import android.content.Intent;
import android.content.SharedPreferences;
import android.os.Bundle;
import android.preference.PreferenceManager;
import android.provider.Telephony;
import android.support.annotation.Nullable;
import com.j256.... | 1 | 29,309 | @AdrianLxM finally found some your bug too :) | MilosKozak-AndroidAPS | java |
@@ -1543,7 +1543,9 @@ void cvdescriptorset::ImageSamplerDescriptor::UpdateDrawState(layer_data *dev_da
if (iv_state) {
core_validation::AddCommandBufferBindingImageView(dev_data, cb_node, iv_state);
}
- SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
+ if (image_view_) {
+ ... | 1 | /* Copyright (c) 2015-2018 The Khronos Group Inc.
* Copyright (c) 2015-2018 Valve Corporation
* Copyright (c) 2015-2018 LunarG, Inc.
* Copyright (C) 2015-2018 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You m... | 1 | 9,477 | This crashed in an app using descriptor_indexing with some unbound descriptors. | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -39,14 +39,15 @@ MODULES_TO_CHECK = [
MODULES_NAMES = [m[1] for m in MODULES_TO_CHECK]
-@pytest.mark.primer_stdlib
+@pytest.mark.primer
@pytest.mark.parametrize(
("test_module_location", "test_module_name"), MODULES_TO_CHECK, ids=MODULES_NAMES
)
-def test_lib_module_no_crash(
+def test_primer_stdlib_no_c... | 1 | # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
import contextlib
import io
import os
import sys
import pytest
from pytest import CaptureFixture
import pylint.lint
def is_module(filename: str) -> bool:
return file... | 1 | 16,852 | I think we might want to keep these marks separate? Then we can create a new `workflow` file with 3 jobs: 1) Prime stdlib 2) Prime batch 1 of external 2) Prime batch 2 of external | PyCQA-pylint | py |
@@ -263,6 +263,13 @@ namespace MvvmCross.Droid.Support.V4
{
((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.Clear();
((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.PutAll(bundle);
+
+ var childViewModelCache = Mvx.GetSingleton<IMvxChildViewModelCac... | 1 | // MvxCachingFragmentActivity.cs
// (c) Copyright Cirrious Ltd. http://www.cirrious.com
// MvvmCross is licensed using Microsoft Public License (Ms-PL)
// Contributions and inspirations noted in readme.md and license.txt
//
// Project Lead - Stuart Lodge, @slodge, me@slodge.com
using System;
using System.Collections.... | 1 | 12,709 | Throw `fragInfo.CachedFragment.ViewModel.GetType()` into a variable so it's not evaluated each time. | MvvmCross-MvvmCross | .cs |
@@ -189,7 +189,7 @@ class User < ActiveRecord::Base
end
def preferred_languages
- @preferred_languages ||= Locale.list(languages)
+ Locale.list(languages)
end
def nearby(radius = NEARBY_RADIUS, num = NEARBY_USERS) | 1 | # == Schema Information
#
# Table name: users
#
# email :string not null
# id :integer not null, primary key
# pass_crypt :string not null
# creation_time :datetime not null
# display_name :string default(""), not n... | 1 | 11,303 | Rather than just getting rid of the memoization maybe we should use an `after_save` filter to set it to `nil` so that it will be recomputed on next read? | openstreetmap-openstreetmap-website | rb |
@@ -0,0 +1,3 @@
+export default function remove(el) {
+ el.parentNode && el.parentNode.removeChild(el);
+} | 1 | 1 | 10,731 | JS abstraction leaks so this should be `if (el.parentNode !== null) { el.parentNode.removeChild(el) }` @developit | preactjs-preact | js | |
@@ -30,6 +30,15 @@ type LedgerUSB struct {
hiddev *hid.Device
}
+// LedgerUSBError is a wrapper around the two-byte error code that the Ledger
+// protocol returns.
+type LedgerUSBError uint16
+
+// Error satisfies builtin interface `error`
+func (err LedgerUSBError) Error() string {
+ return fmt.Sprintf("unexpect... | 1 | // Copyright (C) 2019 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any l... | 1 | 36,590 | nit: change it to `Exchange: unexpected status 0x%x` so that we'll know where this issue came from as well as making it easier to decode. | algorand-go-algorand | go |
@@ -23,13 +23,7 @@ func CstorVolumeArtifactsFor070() (list ArtifactList) {
return
}
-// cstorVolumeYamlsFor070 returns all the yamls related to cstor volume in a
-// string format
-//
-// NOTE:
-// This is an implementation of MultiYamlFetcher
-func cstorVolumeYamlsFor070() string {
- return `
+const cstorRunTask... | 1 | /*
Copyright 2018 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 9,654 | Name of constant is not appropriate. Name of constant should make use of version no. as suffix. The constant can be a typed string versus a string. | openebs-maya | go |
@@ -51,6 +51,7 @@ module Bolt
command_options = []
# Need to be interactive if redirecting STDIN
command_options << '--interactive' unless options[:stdin].nil?
+ command_options << '--tty' if options[:tty]
command_options.concat(envs) unless envs.empty?
co... | 1 | # frozen_string_literal: true
require 'logging'
require 'bolt/node/errors'
module Bolt
module Transport
class Docker < Base
class Connection
def initialize(target)
raise Bolt::ValidationError, "Target #{target.name} does not have a host" unless target.host
@target = target
... | 1 | 12,363 | @glennsarti you want to validate this on Windows? IIRC this won't work | puppetlabs-bolt | rb |
@@ -45,8 +45,11 @@ public class ZipkinElasticsearchHttpStorageAutoConfiguration {
ElasticsearchHttpStorage.Builder esHttpBuilder(
ZipkinElasticsearchHttpStorageProperties elasticsearch,
@Qualifier("zipkinElasticsearchHttp") OkHttpClient client,
- @Value("${zipkin.storage.strict-trace-id:true}") bo... | 1 | /**
* Copyright 2015-2017 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or ... | 1 | 12,215 | ps I'm ok to add this as a elasticsearch property instead. ex zipkin.storage.elasticsearch.names-lookback (we have similar things in cassandra) | openzipkin-zipkin | java |
@@ -69,12 +69,12 @@ class Search implements IWebSearch {
}
/**
- * Force a reindex.
+ * Force a re-index.
*/
reindex() {
let self = this;
- this.storage.getLocalDatabase(function(err, packages) {
- if (err) throw err; // that function shouldn't produce any
+ this.storage.getLocalDatab... | 1 | /**
* @prettier
* @flow
*/
import lunrMutable from 'lunr-mutable-indexes';
import type { Version } from '@verdaccio/types';
import type { IStorageHandler, IWebSearch } from '../../types';
/**
* Handle the search Indexer.
*/
class Search implements IWebSearch {
index: lunrMutable.index;
storage: IStorageHandle... | 1 | 19,420 | Curly brackets here `{ (breakLine) xx (breakLine)}` | verdaccio-verdaccio | js |
@@ -450,6 +450,11 @@ window.ConfigurationsView = countlyView.extend({
return false;
}
+ if($(this).val() === countlyGlobal["member"].username){
+ $(".username-check").remove();
+ return false;
+ }
+
... | 1 | window.PluginsView = countlyView.extend({
initialize: function () {
this.filter = (store.get("countly_pluginsfilter")) ? store.get("countly_pluginsfilter") : "plugins-all";
},
beforeRender: function () {
if (this.template)
return $.when(countlyPlugins.initialize()).then(function ... | 1 | 13,128 | Can you check this case Assuming you have a dashboard with 2 users, test1 and test2 Currently logged in user is test1. You should not be able to change it to test2. You open dev console and paste in `countlyGlobal["member"].username = "test2";` then you enter value test2 in the input and it is allowed and form would be... | Countly-countly-server | js |
@@ -46,13 +46,14 @@ public class DataSourceFactory {
static final long MAX_TTL_CONN_MS = TimeUnit.MILLISECONDS.convert(10L, TimeUnit.MINUTES);
static final String MYSQL_VALIDATION_QUERY = "/* ping */ SELECT 1";
+ static final String DRIVER_CLASS_NAME = "athenz.db.driver.class";
public static Poolabl... | 1 | /*
* Copyright 2016 Yahoo Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 4,820 | since we're changing this class, let's fix the default class name as well. it should be com.mysql.cj.jdbc.Driver | AthenZ-athenz | java |
@@ -3,4 +3,13 @@ class Role < ActiveRecord::Base
has_many :proposals, through: :proposal_roles
has_many :user_roles
has_many :users, through: :user_roles
+
+ # Safely ensure that the system roles in `config/initializers/01_c2.rb`
+ # exist in the database. Rails will run this code when it loads the
+ # `Rol... | 1 | class Role < ActiveRecord::Base
has_many :proposal_roles
has_many :proposals, through: :proposal_roles
has_many :user_roles
has_many :users, through: :user_roles
end
| 1 | 17,638 | At load time, we ensure the config'd objects exist. | 18F-C2 | rb |
@@ -153,6 +153,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
{
throw new InvalidOperationException($"HTTPS endpoints can only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}().");
}
+ ... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Net;
using System.Threading;
using System.Threading.Tas... | 1 | 12,766 | Is there a test for this case? | aspnet-KestrelHttpServer | .cs |
@@ -0,0 +1,14 @@
+<section class="topic">
+ <header>
+ <p class="topic-headline"><%= show.name %></p>
+ </header>
+
+ <%= render partial: "products/videos/video", collection: show.latest_videos %>
+
+ <figure class="card see-more">
+ <%= link_to show do %>
+ <h4><%= pluralize show.videos.count, "more #{s... | 1 | 1 | 11,269 | This copy doesn't match what I had in my mockup. I think it's better to call them episodes. | thoughtbot-upcase | rb | |
@@ -135,7 +135,11 @@ func (s *server) startService() common.Daemon {
servicePortMap := make(map[string]int)
for roleName, svcCfg := range s.cfg.Services {
serviceName := getServiceName(roleName)
- servicePortMap[serviceName] = svcCfg.RPC.Port
+ if serviceName == common.FrontendServiceName || serviceName == com... | 1 | // Copyright (c) 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 9,251 | For some reason it worked for frontend even before this change. | temporalio-temporal | go |
@@ -666,7 +666,10 @@ TEST (block_store, large_iteration)
{
auto transaction (store.tx_begin (true));
nano::account account;
- nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
+ {
+ std::lock_guard<std::mutex> lk (nano::random_pool_mutex);
+ nano::random_pool.GenerateBlock (a... | 1 | #include <gtest/gtest.h>
#include <nano/lib/utility.hpp>
#include <nano/node/common.hpp>
#include <nano/node/node.hpp>
#include <nano/secure/versioning.hpp>
#include <fstream>
TEST (block_store, construction)
{
nano::logging logging;
bool init (false);
nano::mdb_store store (init, logging, nano::unique_path ());
... | 1 | 14,998 | Can we encapsulate this in a function so if we want to change it against we don't have to change all call sites? | nanocurrency-nano-node | cpp |
@@ -470,8 +470,8 @@ void nano::bulk_pull_client::received_block (boost::system::error_code const & e
connection->start_time = std::chrono::steady_clock::now ();
}
connection->attempt->total_blocks++;
- total_blocks++;
bool stop_pull (connection->attempt->process_block (block, known_account, total_blo... | 1 | #include <nano/crypto_lib/random_pool.hpp>
#include <nano/node/bootstrap.hpp>
#include <nano/node/common.hpp>
#include <nano/node/node.hpp>
#include <nano/node/transport/tcp.hpp>
#include <nano/node/transport/udp.hpp>
#include <boost/log/trivial.hpp>
#include <algorithm>
constexpr double bootstrap_connection_scale_t... | 1 | 15,771 | Maybe a good opportunity to do a related improvement: The parameter `total_blocks` in `bootstrap_attempt::process_block` shadows a field with the same name, so maybe rename the parameter to `total_blocks_a` The parameter and field are incremented at the same time, but the field is used by `populate_connections` as well... | nanocurrency-nano-node | cpp |
@@ -9,6 +9,8 @@
DEFINE_int32(default_parts_num, 100, "The default number of parts when a space is created");
DEFINE_int32(default_replica_factor, 1, "The default replica factor when a space is created");
+DEFINE_int32(default_space_sum, 100, "The default number of space can be created");
+DEFINE_int32(default_max_r... | 1 | /* Copyright (c) 2018 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "meta/processors/partsMan/CreateSpaceProcessor.h"
#include "meta/ActiveHostsMan.h"
DEFINE_int32(default_parts_... | 1 | 28,336 | Please revise the naming of these two flags. _**default**_ is the value we take when user doesn't provide. You could infer from the fact how `default_parts_num` are used. | vesoft-inc-nebula | cpp |
@@ -24,12 +24,13 @@ import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
-public class ImportTypeTransformer {
+public class ImportTypeTransformer implements ImportGenerator {
private enum ImportFileType {
SERVICE_FILE,
PROTO_FILE
}
+ @Override
public List<ImportTypeView> gene... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 19,184 | I don't think we should have separate "transformer" and "generator" terms. I would suggest renaming this existing class `ImportTypeTransformer` to `StandardImportTypeTransformer` and renaming the interface `ImportGenerator` to `ImportTypeTransformer`. | googleapis-gapic-generator | java |
@@ -1,4 +1,4 @@
export { default as getContainers } from './get-containers';
export { default as isValidAccountID } from './is-valid-account-id';
export { default as isValidContainerID } from './is-valid-container-id';
-export { default as tagMatchers } from './tag-matchers';
+export { default as tagMatchers } from ... | 1 | export { default as getContainers } from './get-containers';
export { default as isValidAccountID } from './is-valid-account-id';
export { default as isValidContainerID } from './is-valid-container-id';
export { default as tagMatchers } from './tag-matchers';
| 1 | 30,044 | I believe `tag-matchers` is the proper form for this filename. Only components should use pascal case, I believe everything else should continue to use kabob-case. | google-site-kit-wp | js |
@@ -19,6 +19,7 @@ package pubsub
import (
"context"
"fmt"
+ "github.com/google/knative-gcp/pkg/apis/duck/v1alpha1"
pubsubsourcev1alpha1 "github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1"
pubsubsourceclientset "github.com/google/knative-gcp/pkg/client/clientset/versioned" | 1 | /*
Copyright 2019 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 10,340 | same here, move this one down | google-knative-gcp | go |
@@ -112,6 +112,7 @@ class OrderDataFixture extends AbstractReferenceFixture implements DependentFixt
$orderData->domainId = Domain::FIRST_DOMAIN_ID;
$orderData->currency = $this->getReference(CurrencyDataFixture::CURRENCY_CZK);
$orderData->createdAt = $this->faker->dateTimeBetween('-1 week', ... | 1 | <?php
namespace Shopsys\FrameworkBundle\DataFixtures\Demo;
use Doctrine\Common\DataFixtures\DependentFixtureInterface;
use Doctrine\Common\Persistence\ObjectManager;
use Faker\Generator;
use Shopsys\FrameworkBundle\Component\DataFixture\AbstractReferenceFixture;
use Shopsys\FrameworkBundle\Component\Domain\Domain;
us... | 1 | 12,576 | Some could be created as superadmin instead, to add more special cases. Also, the reason behind this change should be described in the commit msg and the PR description. | shopsys-shopsys | php |
@@ -28,6 +28,7 @@ from pyspark.sql import functions as F
from pyspark.sql.types import FloatType, DoubleType, LongType, StructType, TimestampType, \
to_arrow_type
+from databricks import koalas as ks
from databricks.koalas.dask.utils import derived_from
from databricks.koalas.frame import DataFrame
from data... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 8,545 | Is this required? | databricks-koalas | py |
@@ -483,9 +483,10 @@ func start(c *cli.Context) error {
Cluster: cm,
StoragePolicy: sp,
Security: &sdk.SecurityConfig{
- Role: rm,
- Tls: tlsConfig,
- Authenticators: authenticators,
+ Role: rm,
+ Tls: tlsConfig,
+ ... | 1 | //go:generate swagger generate spec -m -o ../../api/swagger/swagger.json
// Package classification OSD API.
//
// OpenStorage is a clustered implementation of the Open Storage specification and relies on the OCI runtime.
// It allows you to run stateful services in containers in a multi-host clustered environment.
// ... | 1 | 8,380 | `--public-volume-create-allowed=true` and set the default to `true`, then use `!c.Bool('...')` | libopenstorage-openstorage | go |
@@ -867,7 +867,9 @@ static int handle_goaway_frame(h2o_http2_conn_t *conn, h2o_http2_frame_t *frame,
if ((ret = h2o_http2_decode_goaway_payload(&payload, frame, err_desc)) != 0)
return ret;
- /* nothing to do, since we do not open new streams by ourselves */
+ /* stop opening new push streams here... | 1 | /*
* Copyright (c) 2014-2016 DeNA Co., Ltd., Kazuho Oku, Fastly, Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to... | 1 | 12,782 | Could we use `0x7ffffffe` instead, since `INT32_MAX` is an ID of a _pull_ stream? Other than that the PR seems ready for merge. Thank you for working on the fix. | h2o-h2o | c |
@@ -86,11 +86,11 @@ module Beaker
execute_rake_task("beaker_quickstart:gen_hosts[vmpooler]")
end
- # Print a message to the console and exit with 0
+ # Print a message to the console and exit with 1
# @param [String] msg the message to print
- def self.exit_with(msg)
+ def s... | 1 | require 'rake'
require 'stringio'
module Beaker
module Subcommands
# Methods used in execution of Subcommands
# - should we execute a subcommand?
# - reset ARGV
# - execute Beaker
# - update a rakefile to require beaker quickstart tasks
# - initialise a rake application
# - execute a rake... | 1 | 14,533 | Might as well add a docstring for the new `exit_code` parameter too. | voxpupuli-beaker | rb |
@@ -77,8 +77,8 @@ public class LocalNewSessionQueuer extends NewSessionQueuer {
}
@Override
- public Optional<HttpRequest> remove() {
- return sessionRequests.poll();
+ public Optional<HttpRequest> remove(RequestId id) {
+ return sessionRequests.poll(id);
}
@Override | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 18,216 | `poll` and `remove` have different meanings. | SeleniumHQ-selenium | rb |
@@ -111,6 +111,15 @@ public class TableProperties {
public static final String DELETE_AVRO_COMPRESSION = "write.delete.avro.compression-codec";
public static final String AVRO_COMPRESSION_DEFAULT = "gzip";
+ public static final String PARQUET_BLOOM_FILTER_ENABLED = "write.parquet.bloom-filter-enabled";
+ publ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 37,876 | What's the perf impact of writing bloom filer? Does it make sense to enable it by default if the perf impact is minor? Would be nice to include benchmarks? | apache-iceberg | java |
@@ -1,4 +1,4 @@
-//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (IAM) role.]
+//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (AWS IAM) role.]
//snippet-k... | 1 | //snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (IAM) role.]
//snippet-keyword:[AWS SDK for Java v2]
//snippet-keyword:[Code Sample]
//snippet-service:[AWS IAM]
//snippet-sourcetype:[full-example]
//snippet-sourcedate:[11/02/2020]
/... | 1 | 18,241 | AWS Identity and Access Management (IAM) | awsdocs-aws-doc-sdk-examples | rb |
@@ -162,13 +162,13 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
{"cuMemAlloc", {"hipMalloc", "", CONV_MEMORY, API_DRIVER}},
{"cuMemAlloc_v2", {"hipMalloc", ... | 1 | /*
Copyright (c) 2015 - present Advanced Micro Devices, Inc. All rights reserved.
Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to us... | 1 | 8,085 | Remove `HIP_UNSUPPORTED` - it is an alias | ROCm-Developer-Tools-HIP | cpp |
@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
public void unassignExecutor(int executionId) throws ExecutorManagerException {
executionExecutorMapping.remove(executionId);
}
+
+ @Override
+ public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
+ thr... | 1 | /*
* Copyright 2014 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 13,201 | i think we should return an empty list instead of null here. | azkaban-azkaban | java |
@@ -104,10 +104,14 @@ public class UserPreferences {
public static final String PREF_ENABLE_AUTODL_WIFI_FILTER = "prefEnableAutoDownloadWifiFilter";
private static final String PREF_AUTODL_SELECTED_NETWORKS = "prefAutodownloadSelectedNetworks";
private static final String PREF_PROXY_TYPE = "prefProxyType... | 1 | package de.danoeh.antennapod.core.preferences;
import android.content.Context;
import android.content.SharedPreferences;
import android.content.res.Configuration;
import android.os.Build;
import android.text.TextUtils;
import android.util.Log;
import android.view.KeyEvent;
import androidx.annotation.NonNull;
import a... | 1 | 20,951 | Is it really necessary to store them in a new setting? I think it should be enough to store the credentials in `ProxyConfig.direct()`. Then AntennaPod does not need to store multiple different proxy settings. Also, it will not change existing users' settings (currently the proxy settings would be lost on upgrade). | AntennaPod-AntennaPod | java |
@@ -2115,10 +2115,15 @@ namespace pwiz.Skyline.Model
public static double GetCollisionEnergy(SrmSettings settings, PeptideDocNode nodePep,
TransitionGroupDocNode nodeGroup, TransitionDocNode nodeTran, CollisionEnergyRegression regression, int step)
{
- var ce = nodeTran==null /... | 1 | /*
* Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2009 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 13,313 | This is a mess. Can it be broken out as a separate function using ifs and return statements, which would also make it more debuggable. | ProteoWizard-pwiz | .cs |
@@ -1457,8 +1457,16 @@ class GenericCompositePlot(DimensionedPlot):
key_map = dict(zip([d.name for d in self.dimensions], key))
for path, item in self.layout.items():
- frame = item.map(lambda x: get_plot_frame(x, key_map, cached=cached),
- ['DynamicMap', 'Holo... | 1 | """
Public API for all plots supported by HoloViews, regardless of
plotting package or backend. Every plotting classes must be a subclass
of this Plot baseclass.
"""
import warnings
from itertools import groupby, product
from collections import Counter, defaultdict
import numpy as np
import param
from ..core import ... | 1 | 22,167 | This stuff is a bit ugly and should probably become a utility. The main problem is that ``.map`` is being abused a bit. | holoviz-holoviews | py |
@@ -1128,6 +1128,9 @@ class ShareableResource(UserResource):
filters = super(ShareableResource, self)._extract_filters(queryparams)
ids = self.context.shared_ids
+ if getattr(self.context, "forced_empty_list", False):
+ ids = ['UNKNOWN']
+
if ids:
filter_by_id... | 1 | import re
import functools
import warnings
import colander
import venusian
import six
from pyramid import exceptions as pyramid_exceptions
from pyramid.decorator import reify
from pyramid.httpexceptions import (HTTPNotModified, HTTPPreconditionFailed,
HTTPNotFound, HTTPConflict,
... | 1 | 9,165 | Maybe there is a better way here so that we don't even bother triggering a storage query since we want an empty list here. | Kinto-kinto | py |
@@ -0,0 +1,16 @@
+package aws
+
+import (
+ "context"
+
+ "github.com/aws/aws-sdk-go-v2/service/iam"
+)
+
+func (c *client) SimulateCustomPolicy(ctx context.Context, region string, customPolicySimulatorParams *iam.SimulateCustomPolicyInput) (*iam.SimulateCustomPolicyOutput, error) {
+ rc, err := c.getRegionalClient(reg... | 1 | 1 | 12,116 | just curious, `region` is not used in the AWS IAM client, afaik. But I see this is a general field for clutch clients, is it just ignored internally? | lyft-clutch | go | |
@@ -7,7 +7,7 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software... | 1 | /**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you m... | 1 | 14,271 | Why are we doing that change? | apache-thrift | c |
@@ -220,7 +220,7 @@ public class ErrorHandler {
private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
- if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
+ if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 15,006 | Why && changed to || ? | SeleniumHQ-selenium | py |
@@ -196,6 +196,15 @@ def _unpickle(filepath, serializer):
raise ValueError(f'Unrecognized serializer type: {serializer}')
+def collection_to_single_partition(collection):
+ """Merge the parts of a Dask collection into a single partition."""
+ if collection is None:
+ return
+ if isinstance(... | 1 | # coding: utf-8
"""Tests for lightgbm.dask module"""
import inspect
import pickle
import socket
from itertools import groupby
from os import getenv
from sys import platform
import lightgbm as lgb
import pytest
if not platform.startswith('linux'):
pytest.skip('lightgbm.dask is currently supported in Linux environm... | 1 | 28,572 | can you please change this to `_collection_to_single_partition()`, like we've done for alll other helper methods defined in this module? | microsoft-LightGBM | cpp |
@@ -24,6 +24,7 @@ namespace Thelia\Core;
use Propel\Runtime\Connection\ConnectionManagerSingle;
use Propel\Runtime\Connection\ConnectionWrapper;
use Propel\Runtime\Propel;
+use Propel\Runtime\ServiceContainer\StandardServiceContainer;
use Symfony\Component\Config\FileLocator;
use Symfony\Component\Config\Loader\Lo... | 1 | <?php
/*************************************************************************************/
/* This file is part of the Thelia package. */
/* */
/* Copyright (c) OpenStudio ... | 1 | 10,747 | This class is never used, don't import it. | thelia-thelia | php |
@@ -41,6 +41,10 @@ namespace Datadog.Trace.DiagnosticListeners
void IObserver<KeyValuePair<string, object>>.OnNext(KeyValuePair<string, object> value)
{
+#if DEBUG
+ // In debug mode we allow exceptions to be catch in the test suite
+ OnNext(value.Key, value.Value);
+#else
... | 1 | #if !NETFRAMEWORK
using System;
using System.Collections.Generic;
using System.Diagnostics;
using Datadog.Trace.Logging;
namespace Datadog.Trace.DiagnosticListeners
{
internal abstract class DiagnosticObserver : IObserver<KeyValuePair<string, object>>
{
private static readonly Vendors.Serilog.ILogger L... | 1 | 18,459 | Missing a `return`. Either way, I think it's better to add a `#if DEBUG throw;` in the catch block instead (so we keep the log in debug mode) | DataDog-dd-trace-dotnet | .cs |
@@ -43,7 +43,12 @@ module Selenium
def text
@bridge.getAlertText
end
+
+ def authenticate(username, password)
+ @bridge.setAuthentication username: username, password: password
+ accept
+ end
end # Alert
end # WebDriver
-end # Selenium
+end # Selenium | 1 | # encoding: utf-8
#
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "Li... | 1 | 13,040 | Files should have an extra line at the end of them. | SeleniumHQ-selenium | rb |
@@ -104,6 +104,9 @@ namespace NLog.Config
/// </summary>
public IList<LoggingRule> LoggingRules { get; private set; }
+ internal List<LoggingRule> GetLoggingRulesThreadSafe() { lock (LoggingRules) return LoggingRules.ToList(); }
+ private void AddLoggingRulesThreadSafe(LoggingRule rul... | 1 | //
// Copyright (c) 2004-2017 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 16,267 | I think we could replace this (well the backing field) with `BlockingCollection` when we drop NET35? | NLog-NLog | .cs |
@@ -928,6 +928,15 @@ class GroupBy(object):
pser_or_pdf = pdf.groupby(input_groupnames)[name].apply(func)
else:
pser_or_pdf = pdf.groupby(input_groupnames).apply(func)
+ keys = set(input_groupnames)
+ should_drop_columns = (
+ ... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 14,773 | Can you show before/after output in the PR description? From a cursory look, seems like it will just drop the duplicated column which isn't consistent with pandas' results. | databricks-koalas | py |
@@ -33,6 +33,14 @@ module Bolt
@rest = data.reject { |k, _| %w[name nodes config groups].include? k }
end
+ def check_deprecated_config(context, name, config)
+ if config && config['transports']
+ msg = "#{context} #{name} contains invalid config option 'transports', see " \
+ ... | 1 | module Bolt
class Inventory
# Group is a specific implementation of Inventory based on nested
# structured data.
class Group
attr_accessor :name, :nodes, :groups, :config, :rest
def initialize(data)
@logger = Logging.logger[self]
@name = data['name']
@nodes = {}
... | 1 | 8,045 | Added validation that `config: transports` isn't used @adreyer @katelopresti Curious what you think about having Bolt link directly to the docs site. | puppetlabs-bolt | rb |
@@ -99,6 +99,7 @@ class AbstractSettings:
_FONT_SIZES = {} # type: typing.Dict[str, typing.Any]
_FONT_FAMILIES = {} # type: typing.Dict[str, typing.Any]
_FONT_TO_QFONT = {} # type: typing.Dict[typing.Any, QFont.StyleHint]
+ _UnknownUrlSchemePolicy = {} # type: typing.Dict[str, typing.Any]
d... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2020 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 24,331 | This probably isn't needed anymore now? | qutebrowser-qutebrowser | py |
@@ -3,9 +3,9 @@ import { h } from './h';
/**
* Clones the given VNode, optionally adding attributes/props and replacing its children.
- * @param {VNode} vnode The virtual DOM element to clone
- * @param {Object} props Attributes/props to add when cloning
- * @param {VNode} rest Any additional arguments will be u... | 1 | import { extend } from './util';
import { h } from './h';
/**
* Clones the given VNode, optionally adding attributes/props and replacing its children.
* @param {VNode} vnode The virtual DOM element to clone
* @param {Object} props Attributes/props to add when cloning
* @param {VNode} rest Any additional argument... | 1 | 11,992 | Would it be easier to kick this import to the top of the file? It'll get stripped out anyway. | preactjs-preact | js |
@@ -236,7 +236,8 @@ public class MultiTenancyPrivacyController implements PrivacyController {
}
}
- private void verifyPrivacyGroupContainsEnclavePublicKey(
+ @Override
+ public void verifyPrivacyGroupContainsEnclavePublicKey(
final String privacyGroupId, final String enclavePublicKey) {
final ... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 22,141 | are you sure that the privacyGroup cannot be null? | hyperledger-besu | java |
@@ -120,7 +120,7 @@ def GenerateDepictionMatching2DStructure(mol, reference, confId=-1, referencePat
if not referenceMatch:
raise ValueError("Reference does not map to itself")
else:
- referenceMatch = range(reference.GetNumAtoms(onlyExplicit=True))
+ referenceMatch = list(range(reference.GetNumAto... | 1 | # $Id$
#
# Copyright (C) 2006-2011 greg Landrum and Rational Discovery LLC
#
# @@ All Rights Reserved @@
# This file is part of the RDKit.
# The contents are covered by the terms of the BSD license
# which is included in the file license.txt, found at the root
# of the RDKit source tree.
#
""" Import all RDKit ... | 1 | 16,000 | Wrapped with list | rdkit-rdkit | cpp |
@@ -0,0 +1,10 @@
+package stats
+
+// DivideFloat64 returns the value of value divided by base.
+// divide by zero case handled before calling.
+func DivideFloat64(value float64, base float64) (float64, bool) {
+ if base == 0 {
+ return 0, false
+ }
+ return (value / base), true
+} | 1 | 1 | 10,982 | Please move this to `pkg/stats/v1alpha1` | openebs-maya | go | |
@@ -1,12 +1,13 @@
class GithubUser
+ URL_FORMAT = /\A[^\/]+\Z/
include ActiveModel::Model
attr_accessor :url, :bypass_url_validation
attr_reader :repositories, :module_name, :password
alias_method :username, :url
- validates :url, format: { with: /\A[^\/]+\Z/, message: I18n.t('invalid_github_username... | 1 | class GithubUser
include ActiveModel::Model
attr_accessor :url, :bypass_url_validation
attr_reader :repositories, :module_name, :password
alias_method :username, :url
validates :url, format: { with: /\A[^\/]+\Z/, message: I18n.t('invalid_github_username') }
validate :username_must_exist
def attributes
... | 1 | 8,549 | a small nit pick ...this can go into `lib/patterns.rb` ? | blackducksoftware-ohloh-ui | rb |
@@ -27,7 +27,7 @@ import * as fixtures from '../datastore/__fixtures__';
import fetchMock from 'fetch-mock';
// TODO: update the active class.
-const activeClass = 'googlesitekit-cta-link--danger';
+const activeClass = 'mdc-tab--active';
const url = fixtures.pagespeedMobile.loadingExperience.id;
const setupRegist... | 1 | /**
* DashboardPageSpeed component tests.
*
* Site Kit by Google, Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LI... | 1 | 29,658 | The above TODO is no longer necessary I believe | google-site-kit-wp | js |
@@ -345,7 +345,7 @@ func getPoolLivenessProbe() *corev1.Probe {
probe := &corev1.Probe{
Handler: corev1.Handler{
Exec: &corev1.ExecAction{
- Command: []string{"/bin/sh", "-c", "zfs set io.openebs:livenesstimestamp=\"$(date)\" cstor-$OPENEBS_IO_POOL_NAME"},
+ Command: []string{"/bin/sh", "-c", "zfs set io... | 1 | /*
Copyright 2019 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 17,572 | Why is this change required ? | openebs-maya | go |
@@ -0,0 +1,16 @@
+package summary
+
+import (
+ "bytes"
+
+ "github.com/russross/blackfriday"
+)
+
+func Markdown(input []byte, wordcount int) []byte {
+ words := bytes.Fields(blackfriday.Markdown(input, Renderer{}, 0))
+ if wordcount > len(words) {
+ wordcount = len(words)
+ }
+
+ return bytes.Join(words[0:wordcount]... | 1 | 1 | 8,083 | This really is an excerpt. ;-) | caddyserver-caddy | go | |
@@ -164,7 +164,7 @@ func (m *mock) IsWithinDepth(addr swarm.Address) bool {
if m.isWithinFunc != nil {
return m.isWithinFunc(addr)
}
- return false
+ return true
}
func (m *mock) EachNeighbor(f topology.EachPeerFunc) error { | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package mock
import (
"context"
"sync"
"github.com/ethersphere/bee/pkg/p2p"
"github.com/ethersphere/bee/pkg/swarm"
"github.com/ethersphere/bee/pkg/top... | 1 | 15,102 | @acud The reason why the default is now `true` is because the chunk must be in the neighborhood of the storer peer with this change. The majority of the tests expect a valid receipt so the closest peers in the tests must be in the neighborhood. As of writing this, there is only one test that expects a peer to be out of... | ethersphere-bee | go |
@@ -44,6 +44,7 @@ import (
"go.temporal.io/server/common/log/tag"
_ "go.temporal.io/server/common/persistence/sql/sqlplugin/mysql" // needed to load mysql plugin
_ "go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql" // needed to load postgresql plugin
+ _ "go.temporal.io/server/common/persist... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 13,101 | This is what breaks the build. Apparently w/o this line, `sqlite` package is not even compiled. With this line it gets compiled but compilation fails because we don't use CGO for our production Linux builds and > ***Important: because this is a `CGO` enabled package you are required to set the environment variable `CGO... | temporalio-temporal | go |
@@ -58,7 +58,7 @@ test_get_size()
}
// Check sizes of FP/SIMD regs.
- for (uint i = 0; i < NUM_SIMD_SLOTS; i++) {
+ for (int i = 0; i < proc_num_simd_saved(); i++) {
ASSERT(reg_get_size((reg_id_t)DR_REG_H0 + i) == OPSZ_2);
ASSERT(reg_get_size((reg_id_t)DR_REG_S0 + i) == OPSZ_4);
... | 1 | /* **********************************************************
* Copyright (c) 2018 Arm Limited. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following condi... | 1 | 15,581 | This should be all slots | DynamoRIO-dynamorio | c |
@@ -66,7 +66,7 @@ public final class RegistryUtils {
serviceRegistry.run();
}
- public static void destory() {
+ public static void destroy() {
serviceRegistry.destroy();
}
| 1 | /*
* Copyright 2017 Huawei Technologies Co., Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable l... | 1 | 7,950 | Need to add deprecated annotation and call the new fixed method to avoid the API broken issue. | apache-servicecomb-java-chassis | java |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.