patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -1,9 +1,7 @@ # coding: utf-8 """Comparison of `binary` and `xentropy` objectives. - BLUF: The `xentropy` objective does logistic regression and generalizes to the case where labels are probabilistic (i.e. numbers between 0 and 1). - Details: Both `binary` and `xentropy` minimize the log loss and use `boost_fro...
1
# coding: utf-8 """Comparison of `binary` and `xentropy` objectives. BLUF: The `xentropy` objective does logistic regression and generalizes to the case where labels are probabilistic (i.e. numbers between 0 and 1). Details: Both `binary` and `xentropy` minimize the log loss and use `boost_from_average = TRUE` by def...
1
30,630
please revert all of these unrelated whitespace changes
microsoft-LightGBM
cpp
@@ -0,0 +1,15 @@ +package com.fsck.k9.mail; + +/** + * Enumeration of the different possible encryption protocol that can be used. + */ +public enum EncryptionType { + + NONE, + + INLINE, + + PGP_MIME, + + S_MIME +}
1
1
13,276
PGP_INLINE is clearer IMHO
k9mail-k-9
java
@@ -16,6 +16,8 @@ import ( "github.com/pkg/errors" "github.com/stretchr/testify/require" + "context" + "github.com/iotexproject/iotex-core/blockchain" "github.com/iotexproject/iotex-core/blockchain/action" "github.com/iotexproject/iotex-core/config"
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
11,911
Please group imports
iotexproject-iotex-core
go
@@ -102,7 +102,7 @@ public class TestHiveMetastore { .transportFactory(new TTransportFactory()) .protocolFactory(new TBinaryProtocol.Factory()) .minWorkerThreads(3) - .maxWorkerThreads(5); + .maxWorkerThreads(10); return new TThreadPoolServer(args); }
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
15,227
Would it make sense to expose this as a config option in `TestHiveMetastore`? A small number of worker threads helped us to catch a few connection leaks early on.
apache-iceberg
java
@@ -10,9 +10,12 @@ void im2col_cpu(const Dtype* data_im, const int channels, const int height, const int width, const int kernel_h, const int kernel_w, const int pad_h, const int pad_w, const int stride_h, const int stride_w, + const int dilation_h, const int dilation_w, Dtype* data_col) { - con...
1
#include <vector> #include "caffe/util/im2col.hpp" #include "caffe/util/math_functions.hpp" namespace caffe { template <typename Dtype> void im2col_cpu(const Dtype* data_im, const int channels, const int height, const int width, const int kernel_h, const int kernel_w, const int pad_h, const int pad_w, co...
1
35,877
Let's fix the extra spaces above.
BVLC-caffe
cpp
@@ -27,7 +27,7 @@ public interface SearchContext { * @return A list of all {@link WebElement}s, or an empty list if nothing matches * @see org.openqa.selenium.By */ - List<WebElement> findElements(By by); + <T extends WebElement> List<T> findElements(By by); /**
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
19,273
should a similar change be done for findElement?
SeleniumHQ-selenium
java
@@ -15,11 +15,17 @@ import ( var _ keystore.Service = (*Service)(nil) +// Service is the memory-based keystore.Service implementation. +// +// Keys are stored in the in-memory map, where the key is the name of the +// private key, and value is structure where actual private key and password are +// stored. type S...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package mem import ( "crypto/ecdsa" "fmt" "sync" "github.com/ethersphere/bee/pkg/crypto" "github.com/ethersphere/bee/pkg/keystore" ) var _ keystore.S...
1
12,838
// Keys are stored in an in-memory map, where the key is the name of the // private key, and the value is the structure where the actual private key and the password are // stored.
ethersphere-bee
go
@@ -59,6 +59,9 @@ var _ = duck.VerifyType(&PullSubscription{}, &duckv1.Conditions{}) // PullSubscriptionSpec defines the desired state of the PullSubscription. type PullSubscriptionSpec struct { + // This brings in CloudEventOverrides and Sink. + duckv1.SourceSpec + // Secret is the credential to use to create an...
1
/* Copyright 2019 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software dist...
1
9,627
I think this needs a json inline tag here
google-knative-gcp
go
@@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * field) { } else if (type->is_struct() || type->is_xception()) { return "#" + uncapitalize(type->get_name()) + "{}"; } else if (type->is_map()) { - return "dict()"; + return "dict:dict()"; } else if (type->is_set()) { retur...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ma...
1
10,413
Hi @cjimison good point but doesn't this break the compatibility with Erlang/OTP prior to 17.0? I think this could be done over an conditional macro defined in the rebar.config: `{erl_opts, [ {platform_define, "^R", pre17} ]}` and some additions with `-ifdef(pre17). ... -else. ... -endif.`
apache-thrift
c
@@ -210,7 +210,7 @@ func (pl *List) removeFromUnavailablePeers(p peer.Peer) { // Choose selects the next available peer in the round robin func (pl *List) Choose(ctx context.Context, req *transport.Request) (peer.Peer, func(error), error) { - if !pl.IsRunning() { + if err := pl.once.WaitForStart(ctx); err != nil { ...
1
// Copyright (c) 2017 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
12,368
should we change/wrap the error?
yarpc-yarpc-go
go
@@ -109,12 +109,12 @@ final class DeFramer extends ByteToMessageDecoder { try { peerInfo = HelloMessage.readFrom(message).getPeerInfo(); } catch (final RLPException e) { - LOG.debug("Received invalid HELLO message", e); + LOG.warn("Received invalid HELLO message, set log l...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
25,391
Are we sure that passing this log in warning does not risk spamming the logs of a node running on the mainnet or on ropsten etc ? Do we often receive invalid messages of this type ?
hyperledger-besu
java
@@ -397,10 +397,7 @@ class Parser # check for option to find list item text only # if skipped a line, assume a list continuation was # used and block content is acceptable - if (text_only = options[:text]) && skipped > 0 - options.delete(:text) - text_only = false - end + text_only = i...
1
module Asciidoctor # Public: Methods to parse lines of AsciiDoc into an object hierarchy # representing the structure of the document. All methods are class methods and # should be invoked from the Parser class. The main entry point is ::next_block. # No Parser instances shall be discovered running around. (Any attempt...
1
4,867
I'd like to avoid a method call here atm since this is an extremely hot line in the code.
asciidoctor-asciidoctor
rb
@@ -421,8 +421,7 @@ def parse_input(vds): def parse_witness(vds): n = vds.read_compact_size() - for i in range(n): - x = vds.read_bytes(vds.read_compact_size()) + return list(vds.read_bytes(vds.read_compact_size()).encode('hex') for i in xrange(n)) def parse_output(vds, i): d = {}
1
#!/usr/bin/env python # # Electrum - lightweight Bitcoin client # Copyright (C) 2011 Thomas Voegtlin # # Permission is hereby granted, free of charge, to any person # obtaining a copy of this software and associated documentation files # (the "Software"), to deal in the Software without restriction, # including without...
1
11,769
Is this a bugfix?
spesmilo-electrum
py
@@ -35,7 +35,6 @@ namespace Microsoft.DotNet.Build.Tasks GlobalPackagesFolder = PackagesDir, Sources = new List<string>(), - FallbackSources = new List<string>(), CacheContext = new SourceCacheContext(), RequestProviders = new List<IRe...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using Microsoft.Build.Framework; using Microsoft.Build.Utilities; using NuGet.Commands; using NuGet.Protocol.Core.T...
1
13,781
Is this a relevant change?
dotnet-buildtools
.cs
@@ -62,9 +62,9 @@ public final class JUnit5RuleUsage extends BugChecker implements BugChecker.Clas } static Matcher<ClassTree> hasVariable(Matcher<VariableTree> matcher) { - return (classTree, state) -> classTree.getMembers().stream() - .filter(tree -> tree instanceof VariableTree) - ...
1
/* * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless ...
1
7,910
@dansanduleac what do you think of this one? dots were aligned and no longer are
palantir-gradle-baseline
java
@@ -738,10 +738,6 @@ function deleteAllAppData(appId, fromAppDelete, params, app) { }, deleteEvents); } }); - - if (fromAppDelete) { - common.db.collection('graph_notes').remove({'_id': common.db.ObjectID(appId)}, function() {}); - } } /**
1
/** * This module is meant for managing apps * @module api/parts/mgmt/apps */ /** @lends module:api/parts/mgmt/apps */ var appsApi = {}, common = require('./../../utils/common.js'), log = common.log('mgmt:apps'), moment = require('moment-timezone'), crypto = require('crypto'), plugins = require('.....
1
13,317
Why we dont delete app specific notes when app is deleted?
Countly-countly-server
js
@@ -113,9 +113,17 @@ public class ConfigBuilderPlugin extends PluginBase { pluginList = MainApp.getPluginsList(); upgradeSettings(); loadSettings(); + setAlwaysEnabledPluginsEnabled(); MainApp.bus().post(new EventAppInitialized()); } + private void setAlwaysEnabledPl...
1
package info.nightscout.androidaps.plugins.ConfigBuilder; import android.content.Intent; import android.support.annotation.Nullable; import com.crashlytics.android.answers.CustomEvent; import com.squareup.otto.Subscribe; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import java.util.ArrayList; import in...
1
30,630
The _OverviewPlugin_ is forcefully enabled without the option to disable it, using _PluginDescription.alwaysEnabled_. That should also work for this plugin?
MilosKozak-AndroidAPS
java
@@ -220,6 +220,8 @@ public class SearchFields { * i.e. "Unpublished", "Draft" (multivalued) */ public static final String PUBLICATION_STATUS = "publicationStatus"; + + public static final String EXTERNAL_STATUS = "externalStatus"; /** * @todo reconcile different with Solr schema.xml w...
1
package edu.harvard.iq.dataverse.search; /** * We define Solr search fields here in one central place so they can be used * throughout the code but renamed here if need be. * * Note that there are many fields in Solr that are *not* here because their * values come from the database. For example "authorName" comes...
1
44,876
Can you facet on this new externalStatus Solr field?
IQSS-dataverse
java
@@ -132,11 +132,14 @@ module Blacklight end def filters - @filters ||= blacklight_config.facet_fields.each_value.map do |value| - f = filter(value) - - f if f.any? - end.compact + @filters ||= blacklight_config.facet_fields.each_value.reduce([]) do |acc, value| + if value...
1
# frozen_string_literal: true require 'blacklight/search_state/filter_field' module Blacklight # This class encapsulates the search state as represented by the query # parameters namely: :f, :q, :page, :per_page and, :sort class SearchState extend Deprecation attr_reader :blacklight_config # Must be ca...
1
8,843
I wonder if it would it make sense to push the pivot facet handling down into `FilterField` (or maybe a subclass, `PivotFilterField`?)?
projectblacklight-blacklight
rb
@@ -47,7 +47,12 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction end begin - result = func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true) + func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true) + ...
1
# frozen_string_literal: true require 'bolt/error' # Runs the `plan` referenced by its name passing giving arguments to it given as a hash of name to value mappings. # A plan is autoloaded from under <root>/plans if not already defined. # # @example defining and running a plan # plan myplan($x) { # # do things ...
1
8,450
Ah I see what you were saying about making it harder to validate types. We'll have to catch the return for that.
puppetlabs-bolt
rb
@@ -86,6 +86,7 @@ public abstract class BaseActivity extends AppCompatActivity implements BottomNa .setTarget(nav_cam) .setDismissText(getResources().getString(R.string.ok_button)) .setContentText(getResources().getString(R.string.camera_button)...
1
package org.fossasia.phimpme.base; import android.animation.Animator; import android.animation.AnimatorListenerAdapter; import android.content.Intent; import android.content.pm.PackageManager; import android.content.res.ColorStateList; import android.graphics.Color; import android.os.Bundle; import android.support.ann...
1
11,789
Try using using `.setDismissOnTouch(true)` instead
fossasia-phimpme-android
java
@@ -122,6 +122,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations } catch (Exception ex) { + if (scope != null) + { + // some fields aren't set till after execution, so populate anything missing + ...
1
#if !NETSTANDARD2_0 using System; using System.Collections.Generic; using System.Net.Http; using System.Threading; using System.Threading.Tasks; using Datadog.Trace.ClrProfiler.Emit; using Datadog.Trace.ExtensionMethods; using Datadog.Trace.Logging; using Datadog.Trace.Util; namespace Datadog.Trace.ClrProfiler.Integra...
1
16,376
Zach, is `UpdateSpan` of concern too? I see that it is called from `ExecuteAsyncInternal`.
DataDog-dd-trace-dotnet
.cs
@@ -26,7 +26,9 @@ import org.apache.iceberg.types.Type; import org.apache.iceberg.types.Types; import org.apache.orc.TypeDescription; -public class TypeConversion { +public final class TypeConversion { + + private TypeConversion() {} /** * Convert a given Iceberg schema to ORC.
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
13,947
Nit: its scope can be reduced to package default
apache-iceberg
java
@@ -15,5 +15,7 @@ namespace Microsoft.AspNetCore.Protocols.Features PipeScheduler InputWriterScheduler { get; } PipeScheduler OutputReaderScheduler { get; } + + PipeScheduler ApplicationScheduler { get; set; } } }
1
using System.Buffers; using System.IO.Pipelines; using System.Threading; namespace Microsoft.AspNetCore.Protocols.Features { public interface IConnectionTransportFeature { MemoryPool MemoryPool { get; } IDuplexPipe Transport { get; set; } IDuplexPipe Application { get; set; } ...
1
14,793
Why is this get;set;?
aspnet-KestrelHttpServer
.cs
@@ -77,6 +77,9 @@ bool StatefulReader::matched_writer_add(RemoteWriterAttributes& wdata) getRTPSParticipant()->createSenderResources(wdata.endpoint.remoteLocatorList, false); + + wdata.endpoint.unicastLocatorList = + mp_RTPSParticipant->network_factory().ShrinkLocatorLists({wdata.endpoint.unicastLoca...
1
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
13,055
Should we also create sender resources for unicast locators? Should we make a similar change on StatelessReader?
eProsima-Fast-DDS
cpp
@@ -130,7 +130,7 @@ namespace Datadog.Trace.RuntimeMetrics // Catching error UnauthorizedAccessException: Access to the registry key 'Global' is denied. // The 'Global' part seems consistent across localizations - Log.Error(ex, "The process does not have sufficient per...
1
// <copyright file="PerformanceCountersListener.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> #if NETFRA...
1
21,670
Can we use `dotnet` instead of `net`?
DataDog-dd-trace-dotnet
.cs
@@ -372,6 +372,13 @@ namespace Datadog.Trace return StartSpan(operationName, tags: null, parent, serviceName, startTime, ignoreActiveScope, spanId: null); } + /// <summary> + /// Forces the tracer to immediately flush pending traces and send them to the agent. + /// To be ca...
1
// <copyright file="Tracer.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> using System; using System.Coll...
1
21,292
Should this be `ForceFlushAsync`? Given we have the `async` suffix elsewhere.
DataDog-dd-trace-dotnet
.cs
@@ -48,8 +48,8 @@ class TestJMeterExecutor(BZTestCase): self.obj = get_jmeter() def tearDown(self): - if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx): - os.remove(self.obj.modified_jmx) + # if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx): + ...
1
# coding=utf-8 import json import logging import os import shutil import sys import time from math import ceil import yaml from bzt import ToolError, TaurusConfigError, TaurusInternalException from bzt.jmx import JMX from bzt.modules.aggregator import ConsolidatingAggregator, DataPoint from bzt.modules.blazemeter imp...
1
14,442
Is this change intentional?
Blazemeter-taurus
py
@@ -55,10 +55,7 @@ namespace Microsoft.CodeAnalysis.Sarif if (nativeOffset != -1) { - stackFrame.Properties = new Dictionary<string, string> - { - { "NativeOffset", nativeOffset.ToString(CultureInfo.InvariantCulture) } - }; + ...
1
// Copyright (c) Microsoft. All Rights Reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.Globalization; using System.Reflection; using System.Text; namespace Microsoft.CodeAnalysis.S...
1
10,754
This could be an integer property if we supported explicitly setting non-string-valued properties.
microsoft-sarif-sdk
.cs
@@ -14,8 +14,7 @@ use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface; class RouteCsrfProtector implements EventSubscriberInterface { public const CSRF_TOKEN_REQUEST_PARAMETER = 'routeCsrfToken'; - /** @access protected */ - const CSRF_TOKEN_ID_PREFIX = 'route_'; + public const CSRF_TOKEN_ID_P...
1
<?php namespace Shopsys\FrameworkBundle\Component\Router\Security; use Doctrine\Common\Annotations\Reader; use ReflectionMethod; use Shopsys\FrameworkBundle\Component\Router\Security\Annotation\CsrfProtection; use Symfony\Component\EventDispatcher\EventSubscriberInterface; use Symfony\Component\HttpKernel\Event\Filte...
1
17,612
this is not consistent with the previous annotation - is it because of the usage in `Admin\Content\Category\list.html.twig` twig template? Should not it be at least mentioned in the commit message? :slightly_smiling_face:
shopsys-shopsys
php
@@ -149,6 +149,7 @@ func ReadSecretFromStdin() (string, error) { case <-routineTerminate: return default: + return } } }()
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
23,330
why add `return` here?
iotexproject-iotex-core
go
@@ -82,7 +82,9 @@ namespace Nethermind.Network.Test.Discovery Assert.AreEqual(message.DestinationAddress, deserializedMessage.DestinationAddress); Assert.AreEqual(message.SourceAddress, deserializedMessage.SourceAddress); Assert.AreEqual(message.Version, deserializedMessage.Versio...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of...
1
24,145
put this hash in variable
NethermindEth-nethermind
.cs
@@ -5,11 +5,8 @@ package libkbfs import ( - "bytes" - "errors" "testing" - "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/logger" "github.com/keybase/client/go/protocol/keybase1" "github.com/keybase/go-framed-msgpack-rpc/rpc"
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "bytes" "errors" "testing" "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/logger" "github.com/keybase/client/go/prot...
1
15,290
Why not use `kbfsblock.ZeroRefNonce`?
keybase-kbfs
go
@@ -26,7 +26,7 @@ class EarlyStopException(Exception): # Callback environment used by callbacks CallbackEnv = collections.namedtuple( - "LightGBMCallbackEnv", + "CallbackEnv", ["model", "params", "iteration",
1
# coding: utf-8 """Callbacks library.""" import collections from operator import gt, lt from .basic import _ConfigAliases, _log_info, _log_warning class EarlyStopException(Exception): """Exception of early stopping.""" def __init__(self, best_iteration, best_score): """Create early stopping exceptio...
1
28,470
what mypy warning does this address? I'm confused by this change.
microsoft-LightGBM
cpp
@@ -3751,6 +3751,18 @@ void Player::addAttacked(const Player* attacked) attackedSet.insert(attacked->guid); } +void Player::removeAttacked(const Player* attacked) +{ + if (!attacked || attacked == this) { + return; + } + + auto it = attackedSet.find(attacked->guid); + if (it != attackedSet.end()) { + attackedSet...
1
/** * The Forgotten Server - a free and open-source MMORPG server emulator * Copyright (C) 2017 Mark Samman <mark.samman@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either...
1
13,830
Note that `hasAttacked` that is called before this function already performs this check. You probably don't need to check `hasAttacked` then.
otland-forgottenserver
cpp
@@ -0,0 +1,10 @@ +// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the "URL folder". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The fo...
1
1
12,138
Unfortunately, the site example only has access to imports from `components/index.js` that means that you can't import the items file `carousel-items.js`. You can import that file in all the other storybook files though.
salesforce-design-system-react
js
@@ -79,7 +79,7 @@ setup( 'locale/*/LC_MESSAGES/electrum.mo', ] }, - scripts=['electrum'], + scripts=['electrum', 'privkey2electrum'], data_files=data_files, description="Lightweight Bitcoin Wallet", author="Thomas Voegtlin",
1
#!/usr/bin/env python3 # python setup.py sdist --format=zip,gztar from setuptools import setup import os import sys import platform import imp import argparse version = imp.load_source('version', 'lib/version.py') if sys.version_info[:3] < (3, 4, 0): sys.exit("Error: Electrum requires Python version >= 3.4.0......
1
11,885
Leave this out and move the script to the scripts folder.
spesmilo-electrum
py
@@ -1656,7 +1656,7 @@ class TargetLocator { window(nameOrHandle) { return this.driver_.schedule( new command.Command(command.Name.SWITCH_TO_WINDOW). - setParameter('name', nameOrHandle), + setParameter('handle', nameOrHandle), 'WebDriver.switchTo().window(' + nameOrHandle...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,587
This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.
SeleniumHQ-selenium
java
@@ -0,0 +1,17 @@ +using System.Collections.Generic; +using System.IO.Pipelines; +using System.Threading.Tasks; +using Microsoft.AspNetCore.Http.Features; + +namespace Microsoft.AspNetCore.Connections +{ + public interface IConnection + { + IDuplexPipe Transport { get; } + IFeatureCollection Features...
1
1
15,380
TransferFormat.Text in general purpose connection interface? :/
aspnet-KestrelHttpServer
.cs
@@ -36,10 +36,17 @@ module Selenium SOCKET_LOCK_TIMEOUT = 45 STOP_TIMEOUT = 20 + @executable = nil + @missing = '' + + class << self + attr_accessor :executable, :missing_text + end + attr_accessor :host def initialize(executable_path, port, *extra_args)...
1
# encoding: utf-8 # # Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "Li...
1
13,879
Is this `@missing_text` ?
SeleniumHQ-selenium
py
@@ -485,6 +485,12 @@ func (c *client) processRouteInfo(info *Info) { if !s.getOpts().Cluster.NoAdvertise { s.addClientConnectURLsAndSendINFOToClients(info.ClientConnectURLs) } + + // This will allow us to determine the initial RTT without having to + // wait for first timer based PING. + c.mu.Lock() + c.s...
1
// Copyright 2013-2019 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
9,296
This work for both sides?
nats-io-nats-server
go
@@ -32,9 +32,12 @@ import { isDataZeroSearchConsole, } from '../dashboard/util'; -const { __, sprintf } = wp.i18n; -const { map } = lodash; -const { Component } = wp.element; +/** + * WordPress dependencies + */ +import { __, sprintf } from '@wordpress/i18n'; +import { map } from 'lodash'; +import { Component } fr...
1
/** * DashboardWidgetPopularKeywordsTable component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/...
1
24,754
`lodash` shouldn't be grouped under WordPress dependencies
google-site-kit-wp
js
@@ -117,6 +117,13 @@ class ComputeTest(unittest_utils.ForsetiTestCase): with self.assertRaises(expected_exception): list(self.gce_api_client.get_firewall_rules(self.project_id)) + + def test_get_global_operations(self): + """Test get_global_operations""" + http_mocks.mock_http_r...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
27,776
Include the standard parameterized error tests as well.
forseti-security-forseti-security
py
@@ -242,6 +242,16 @@ func runWeb(ctx *cli.Context) { m.Patch("/hooks/:id:int", bind(api.EditHookOption{}), v1.EditRepoHook) m.Get("/raw/*", middleware.RepoRef(), v1.GetRepoRawFile) m.Get("/archive/*", v1.GetRepoArchive) + m.Post("/forks", v1.ForkRepo) + + m.Get("/commits/:commitId", middleware...
1
// Copyright 2014 The Gogs Authors. All rights reserved. // Use of this source code is governed by a MIT-style // license that can be found in the LICENSE file. package cmd import ( "crypto/tls" "fmt" "html/template" "io/ioutil" "net/http" "net/http/fcgi" "os" "path" "strings" "github.com/Unknwon/macaron" ...
1
9,348
All lowercase in route rule.
gogs-gogs
go
@@ -61,8 +61,16 @@ export const actions = { const { dispatch } = yield Data.commonActions.getRegistry(); yield actions.receiveAccounts( response.accounts ); - dispatch( STORE_NAME ).receiveProperties( response.properties ); - dispatch( STORE_NAME ).receiveProfiles( response.profiles ); + + if ( response...
1
/** * modules/analytics data store: accounts. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/license...
1
28,518
I'd suggest we use `response.profiles[ 0 ].webPropertyId` here instead, to make sure it's based on the profiles retrieved. The value _should_ be the same, but I think it's a bit more accurate like that.
google-site-kit-wp
js
@@ -314,8 +314,8 @@ public class OverviewFragment extends Fragment implements View.OnClickListener, bgGraph.setOnLongClickListener(new View.OnLongClickListener() { @Override public boolean onLongClick(View v) { - rangeToDisplay += 6; - ...
1
package info.nightscout.androidaps.plugins.Overview; import android.annotation.SuppressLint; import android.app.Activity; import android.app.NotificationManager; import android.content.ActivityNotFoundException; import android.content.Context; import android.content.Intent; import android.content.pm.PackageManager; im...
1
30,488
This doesn't change the default of 6h, but will increase the displayed timeframe by 3h for each long press, before wrapping around to 3h. This requires 7 long-presses - quiet a journey ...
MilosKozak-AndroidAPS
java
@@ -91,6 +91,7 @@ type nodeChainReader interface { GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error) HeadEvents() *ps.PubSub Load(context.Context) error + SetHead(context.Context, types.TipSet) error Stop() }
1
package node import ( "context" "encoding/json" "fmt" "os" "sync" "time" ps "github.com/cskr/pubsub" "github.com/ipfs/go-bitswap" bsnet "github.com/ipfs/go-bitswap/network" bserv "github.com/ipfs/go-blockservice" "github.com/ipfs/go-cid" "github.com/ipfs/go-datastore" "github.com/ipfs/go-hamt-ipld" bsto...
1
19,360
We still need to figure out a way to get rid of this write method. Is this still necessary?
filecoin-project-venus
go
@@ -265,6 +265,11 @@ class KNNClassifierTest(unittest.TestCase): self.assertEquals(classifier.getNumPartitionIds(), 3) + # Check that the full set of partition ids is what we expect + self.assertItemsEqual(classifier.getPartitionIdPerPattern(), + [433, 213, np.inf, 433, 413]) + ...
1
#! /usr/bin/env python # ---------------------------------------------------------------------- # Numenta Platform for Intelligent Computing (NuPIC) # Copyright (C) 2015, Numenta, Inc. Unless you have an agreement # with Numenta, Inc., for a separate license for this software code, the # following terms and conditions...
1
20,396
`assertItemsEqual` compares the sequences after sorting them, is that intended?
numenta-nupic
py
@@ -170,8 +170,8 @@ module Selenium def macosx_path path = "/Applications/Firefox.app/Contents/MacOS/firefox-bin" - path = "~/Applications/Firefox.app/Contents/MacOS/firefox-bin" unless File.exist?(path) - path = Platform.find_binary("firefox-bin") unless File.exist?(path...
1
# encoding: utf-8 # # Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "Li...
1
12,881
I don't think this one needs to be changed since the only previous path is already an absolute one.
SeleniumHQ-selenium
java
@@ -13,8 +13,14 @@ namespace AutoRest.Swagger.Model.Utilities { public static class ValidationUtilities { - private static readonly string XmsPageable = "x-ms-pageable"; + private const string XmsPageable = "x-ms-pageable"; private static readonly Regex TrackedResRegEx = new Regex(@".+...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using AutoRest.Core.Utilities; using System; using System.Collections.Generic; using System.Linq; using System.Text; using System.Text.RegularExpressions; using ...
1
24,031
what's the goal of this?
Azure-autorest
java
@@ -49,6 +49,8 @@ type Node struct { // CborStore is a temporary interface for interacting with IPLD objects. CborStore *hamt.CborIpldStore + + pool *core.MessagePool } // Config is a helper to aid in the construction of a filecoin node.
1
package node import ( "context" "fmt" "gx/ipfs/QmNh1kGFFdsPu79KNSaL4NUKUPb4Eiz4KHdMtFY6664RDp/go-libp2p" "gx/ipfs/QmNmJZL7FQySMtE2BQuLMuZg2EB2CLEunJJUSVSc9YnnbV/go-libp2p-host" ds "gx/ipfs/QmPpegoMqhAEqjncrzArm7KVWAkCm78rqL2DPuNjhPrshg/go-datastore" logging "gx/ipfs/QmRb5jh8z2E8hMGN2tkvs1yHynUanqnZ3UeKwgN1i9P1F...
1
9,966
why is this here? We already have a message pool in the node.
filecoin-project-venus
go
@@ -1107,7 +1107,7 @@ func (s *activityReplicatorSuite) TestSyncActivity_ActivityRunning() { var versionHistories *persistence.VersionHistories s.mockMutableState.EXPECT().GetVersionHistories().Return(versionHistories).AnyTimes() s.mockMutableState.EXPECT().GetReplicationState().Return(&persistence.ReplicationSta...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
9,783
Another mess after all renames and enum conversions. Doesn't break anything though.
temporalio-temporal
go
@@ -17,7 +17,8 @@ class PluginSetup(unittest.TestCase): def test_a_statsd_timer_is_used_for_history_if_configured(self): settings = { "statsd_url": "udp://127.0.0.1:8125", - "includes": "kinto.plugins.history" + "includes": "kinto.plugins.history", + "storage_...
1
import json import re import unittest import mock from pyramid import testing from kinto import main as kinto_main from kinto.core.testing import get_user_headers, skip_if_no_statsd from .. import support class PluginSetup(unittest.TestCase): @skip_if_no_statsd def test_a_statsd_timer_is_used_for_history_...
1
10,974
I don't think it's necessary to change this for the history plugin tests?
Kinto-kinto
py
@@ -328,8 +328,8 @@ bool TCPv4Transport::compare_locator_ip_and_port( void TCPv4Transport::fill_local_ip( Locator& loc) const { - IPLocator::setIPv4(loc, "127.0.0.1"); loc.kind = LOCATOR_KIND_TCPv4; + IPLocator::setIPv4(loc, "127.0.0.1"); } ip::tcp::endpoint TCPv4Transport::generate_endpoint(
1
// Copyright 2018 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
23,501
In general, I suggest using the `kind()` getter inhereted from `TransportInterface`
eProsima-Fast-DDS
cpp
@@ -48,8 +48,6 @@ namespace NLog.Layouts /// </remarks> [Layout("Log4JXmlEventLayout")] [ThreadAgnostic] - [ThreadSafe] - [AppDomainFixedOutput] public class Log4JXmlEventLayout : Layout, IIncludeContext { /// <summary>
1
// // Copyright (c) 2004-2021 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
22,766
Is the removal of `[AppDomainFixedOutput]` on purpose? (looks like a copy-paste...euh..remove error)
NLog-NLog
.cs
@@ -1,4 +1,4 @@ -//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (IAM) users.] +//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (AWS IAM) users.] //snippet-keyword:[AWS SDK for Java v2] //snippet-ke...
1
//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (IAM) users.] //snippet-keyword:[AWS SDK for Java v2] //snippet-keyword:[Code Sample] //snippet-service:[AWS IAM] //snippet-sourcetype:[full-example] //snippet-sourcedate:[11/02/2020] //snippet-sourceauthor...
1
18,249
AWS Identity and Access Management (IAM)
awsdocs-aws-doc-sdk-examples
rb
@@ -163,6 +163,7 @@ type APIV1POSTTransactionSignRequest struct { WalletHandleToken string `json:"wallet_handle_token"` // swagger:strfmt byte Transaction []byte `json:"transaction"` + PublicKey crypto.PublicKey `json:"public_key"` WalletPassword string `json:"wallet_password"` }
1
// Copyright (C) 2019-2020 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
38,154
gofmt everything pls
algorand-go-algorand
go
@@ -243,6 +243,8 @@ type PodIOChaosStatus struct { } // +kubebuilder:object:root=true +// +kubebuilder:printcolumn:name="action",type=string,JSONPath=`.spec.action` +// +kubebuilder:printcolumn:name="duration",type=string,JSONPath=`.spec.duration` // PodIOChaosList contains a list of PodIOChaos type PodIOChaosL...
1
// Copyright 2021 Chaos Mesh Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to...
1
25,454
ditto, We do not need add this feature for PodXXXChaos
chaos-mesh-chaos-mesh
go
@@ -38,8 +38,9 @@ public class SampleNamer extends NameFormatterDelegator { /** * Returns the variable name of the service. */ - public String getServiceVarName(String apiTypeName) { - return localVarName(Name.lowerCamel(Name.upperCamel(apiTypeName).toLowerCamel(), "service")); + public String getServic...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
18,332
There is a simpler way to do this: 1. Don't bother with the whole lowerCamelApiTypeName in SampleConfig 2. Use this code: `return localVarName(Name.upperCamel(apiTypeName, "Service"));` Basically, each of the static creation methods of Name just need to have their arguments all be in the same casing, so you would just ...
googleapis-gapic-generator
java
@@ -28,7 +28,7 @@ using EdgeData = util::NodeBasedDynamicGraph::EdgeData; bool requiresAnnouncement(const EdgeData &from, const EdgeData &to) { - return !from.IsCompatibleTo(to); + return !from.CanCombineWith(to); } TurnAnalysis::TurnAnalysis(const util::NodeBasedDynamicGraph &node_based_graph,
1
#include "extractor/guidance/turn_analysis.hpp" #include "extractor/guidance/constants.hpp" #include "extractor/guidance/road_classification.hpp" #include "util/coordinate.hpp" #include "util/coordinate_calculation.hpp" #include "util/guidance/toolkit.hpp" #include "util/simple_logger.hpp" #include <cstddef> #include...
1
17,271
Can you explain this change to me?
Project-OSRM-osrm-backend
cpp
@@ -19,7 +19,7 @@ const ( OpenEBSArtifacts ArtifactSource = "../artifacts/openebs-ci.yaml" CStorPVCArtifacts ArtifactSource = "../artifacts/cstor-pvc.yaml" JivaPVCArtifacts ArtifactSource = "../artifacts/jiva-pvc.yaml" - SingleReplicaSC ArtifactSource = "../artifacts/single-replica.yaml" + SingleReplicaSC A...
1
package artifacts import ( "errors" "io/ioutil" "strings" k8s "github.com/openebs/maya/pkg/client/k8s/v1alpha1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "github.com/openebs/maya/pkg/artifact/v1alpha1" ) // ArtifactSource holds the path to fetch artifacts type ArtifactSource string type Artifact str...
1
12,465
let us rename the artifact to `storageclass-single-replica.yaml`
openebs-maya
go
@@ -5,7 +5,7 @@ using System; using System.Runtime.CompilerServices; using System.Runtime.InteropServices; -namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Networking +namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking { public class LibuvFunctions {
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Runtime.CompilerServices; using System.Runtime.InteropServices; namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Netwo...
1
12,533
Nit: I should have done this before, but rename the file to LibuvFunctions.cs. Make sure no other files are misnamed.
aspnet-KestrelHttpServer
.cs
@@ -100,6 +100,7 @@ public class JavaBinCodec implements PushWriter { MAP_ENTRY_ITER = 17, ENUM_FIELD_VALUE = 18, MAP_ENTRY = 19, + UUID = 20, // This is reserved to be used only in LogCodec // types that combine tag + length (or other info) in a single byte ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
29,193
We should not add new types unless absolutely required. I'm not sure `UUID` is requires a new type
apache-lucene-solr
java
@@ -461,3 +461,14 @@ class JUnitMirrorsManager(MirrorsManager): links.append(default_link) self.log.debug('Total mirrors: %d', len(links)) return links + + +class JavaEnv(object): + def get_additional_classpath(self): + pass + + def get_cp_from_files(self): + pass + + ...
1
""" Copyright 2017 BlazeMeter Inc. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software...
1
14,748
If only Gatling uses it, can we skip introducing new entity for now? Looks like overkill...
Blazemeter-taurus
py
@@ -54,6 +54,14 @@ type VersionsResponse struct { Versions []string `json:"versions"` } +// Response to `GET /versions` +// swagger:response VersionsResponse +type versionsResponse struct { + //Versions Response + //in:body + Body *VersionsResponse +} + // APIV1GETWalletsResponse is the response to `GET /v1/walle...
1
// Copyright (C) 2019-2021 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
42,166
rename -> info ?
algorand-go-algorand
go
@@ -135,6 +135,10 @@ class scheduler(Config): prune_on_get_work = parameter.BoolParameter(default=False) + upstream_status_when_all = parameter.BoolParameter(default=False, + config_path=dict(section='scheduler', + ...
1
# -*- coding: utf-8 -*- # # Copyright 2012-2015 Spotify AB # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law...
1
15,360
Remove the `config_path=dict(...)`, that is automatic!
spotify-luigi
py
@@ -23,9 +23,11 @@ function cleanupPlugins(resolve, reject) { }); }); - axe.utils.toArray(document.querySelectorAll('frame, iframe')).forEach(function (frame) { + var flattenedTree = axe.utils.getFlattenedTree(document.body) + + axe.utils.querySelectorAll(flattenedTree, 'iframe, frame').forEach(function (n...
1
function cleanupPlugins(resolve, reject) { 'use strict'; if (!axe._audit) { throw new Error('No audit configured'); } var q = axe.utils.queue(); // If a plugin fails it's cleanup, we still want the others to run var cleanupErrors = []; Object.keys(axe.plugins).forEach(function (key) { ...
1
11,508
I had to create a new flattened tree to support this functionality. The only other place in which a flattened tree is created is during the audit itself. Since `axe.cleanup` can be called at any arbitrary time, we can't reuse the same tree.
dequelabs-axe-core
js
@@ -52,9 +52,15 @@ public final class ConfigUtil { private static final String MICROSERVICE_CONFIG_LOADER_KEY = "cse-microservice-config-loader"; + private static ConfigModel model = new ConfigModel(); + private ConfigUtil() { } + public static void addConfigs(Map<String, Object> config) { + model.s...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,192
As this method is just set the internal cofigModel, it's better to use setConfigs instead of addConfigs.
apache-servicecomb-java-chassis
java
@@ -44,7 +44,13 @@ const ( // Timelimits for docker operations enforced above docker const ( // ListContainersTimeout is the timeout for the ListContainers API. - ListContainersTimeout = 10 * time.Minute + ListContainersTimeout = 10 * time.Minute + // LoadImageTimeout is the timeout for the LoadImage API. It's se...
1
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
15,539
Is this line needed?
aws-amazon-ecs-agent
go
@@ -20,6 +20,8 @@ import ( "context" "encoding/json" "fmt" + "github.com/google/knative-gcp/pkg/apis/events/v1alpha1" + "github.com/google/knative-gcp/pkg/apis/events/v1beta1" "net/url" "os" "time"
1
/* Copyright 2020 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software dist...
1
14,063
nit: import formatter
google-knative-gcp
go
@@ -118,9 +118,18 @@ namespace AutoRest.Swagger headerType = null; } + // Response format List<Stack<IModelType>> typesList = BuildResponses(method, headerType); + // if each of the responses have explicitly set their nullable property t...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.Diagnostics; using System.Globalization; using System.Linq; using System.Net; using System.Text; usin...
1
23,647
can you use LINQ's `All` instead? Should be a side-effects free one liner with that.
Azure-autorest
java
@@ -24,7 +24,9 @@ #include <inttypes.h> #include <netdb.h> #include <netinet/in.h> +#ifndef __ANDROID__ #include <spawn.h> +#endif #include <stdio.h> #include <stdlib.h> #include <sys/socket.h>
1
/* * Copyright (c) 2014-2016 DeNA Co., Ltd., Kazuho Oku * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, mo...
1
12,673
Could you please remove `#include <spawn.h>` as a whole and see what happens? I believe that this is no longer needed; it was necessary when we called `posix_spawnp` directly, but now we use `h2o_spawnp`.
h2o-h2o
c
@@ -94,10 +94,16 @@ func (in *fakeTwoPhaseChaos) GetStatus() *v1alpha1.ChaosStatus { return &in.Status } +// IsDeleted returns whether this resource has been deleted func (in *fakeTwoPhaseChaos) IsDeleted() bool { return in.Deleted } +// IsPaused returns whether this resource is paused +func (in *fakeTwoPhas...
1
package twophase_test import ( "context" "errors" "testing" "time" . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apimachinery/pkg/types" "k8s.io/client-go/kubernetes/sch...
1
14,337
`whether this resource is paused` to `whether this resource has been paused` ? To keep same doc style.
chaos-mesh-chaos-mesh
go
@@ -36,4 +36,11 @@ public interface PermissionManager { public boolean hasPermission(final String imageTypeName, final String userId, final Type type) throws ImageMgmtException; + /** + * Checks if the user has permission to manage high priority flows. + * @param userId + * @return + * @throws Imag...
1
/* * Copyright 2020 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
22,779
This method is validating permission for hp flow. Can you please rename this method to convey the same?
azkaban-azkaban
java
@@ -102,9 +102,7 @@ class MongoNetworkError extends MongoError { super(message); this.name = 'MongoNetworkError'; - if (options && options.beforeHandshake === true) { - this[kBeforeHandshake] = true; - } + this[kBeforeHandshake] = !!(options && options.beforeHandshake === true); } }
1
'use strict'; const kErrorLabels = Symbol('errorLabels'); /** * Creates a new MongoError * * @augments Error * @param {Error|string|object} message The error message * @property {string} message The error message * @property {string} stack The error call stack */ class MongoError extends Error { constructor(...
1
19,839
Just to confirm, do we actually want to explicitly set the `kBeforeHandshake` symbol on all network errors regardless of whether the options/property is passed in?
mongodb-node-mongodb-native
js
@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) { r.dirtyIfaces.Add(ifaceName) } +func (r *RouteTable) QueueResync() { + r.logCxt.Info("Queueing a resync.") + r.inSync = false +} + func (r *RouteTable) Apply() error { if !r.inSync { links, err := r.dataplane.LinkList()
1
// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ...
1
15,063
How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.
projectcalico-felix
go
@@ -172,9 +172,12 @@ func (g *gen) frame() []byte { } sort.Strings(imps) for _, path := range imps { - // TODO(light): Omit the local package identifier if it matches - // the package name. - fmt.Fprintf(&buf, "\t%s %q\n", g.imports[path], path) + // Omit the local package identifier if it matches the ...
1
// Copyright 2018 The Go Cloud Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agr...
1
11,031
While this is commonly correct, the more reliable check is to get the package's identifier from the type checker and check those for equality. The information should be there, just another matter of plumbing it.
google-go-cloud
go
@@ -168,6 +168,9 @@ def to_full_resource_name(full_parent_name, resource_type_name): Returns: str: full_resource_name of the child """ + # Strip out the fake composite root parent from the full resource name. + if full_parent_name == 'composite_root/root/': + return '{}/'.format(resource...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
33,527
Just to clarify, should this be 'composite_root/root/' or 'composite_root/'?
forseti-security-forseti-security
py
@@ -288,5 +288,6 @@ func (psb *PubSubBase) DeletePubSub(ctx context.Context, pubsubable duck.PubSuba return fmt.Errorf("failed to delete PullSubscription: %w", err) } status.SinkURI = nil + status.SubscriptionID = "" return nil }
1
/* Copyright 2019 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software dist...
1
20,108
Any reason not to move it to after line 281? These are all pubsub related fields IIUC.
google-knative-gcp
go
@@ -3,7 +3,7 @@ import { both, gt } from 'ramda'; import isNumber from './isNumber'; /** - * Checks if value is a negative `Number` primitive or object. + * Checks if value is a negative `Number` primitive or object. Zero is not considered negative. * * @func isNegative * @memberOf RA
1
import { both, gt } from 'ramda'; import isNumber from './isNumber'; /** * Checks if value is a negative `Number` primitive or object. * * @func isNegative * @memberOf RA * @since {@link https://char0n.github.io/ramda-adjunct/1.15.0|v1.15.0} * @category Type * @sig * -> Boolean * @param {*} val The value to t...
1
5,529
Checks if value is a negative `Number` primitive or object. Zero is considered neither positive nor negative.
char0n-ramda-adjunct
js
@@ -285,6 +285,11 @@ func (h Handler) buildEnv(r *http.Request, rule Rule, fpath string) (map[string] // Retrieve name of remote user that was set by some downstream middleware such as basicauth. remoteUser, _ := r.Context().Value(httpserver.RemoteUserCtxKey).(string) + requestScheme := "http" + if r.TLS != nil {...
1
// Copyright 2015 Light Code Labs, LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
12,316
Just a nit, but remove the empty line here. :)
caddyserver-caddy
go
@@ -385,6 +385,16 @@ func (p *Package) addFiles(cu *apb.CompilationUnit, root, base string, names []s Corpus: p.ext.DefaultCorpus, Path: trimmed, } + + if p.ext.Rules != nil { + v2, ok := p.ext.Rules.Apply(trimmed) + if ok { + vn.Corpus = v2.Corpus + vn.Root = v2.Root + vn.Path = v2.Path + ...
1
/* * Copyright 2015 The Kythe Authors. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by ap...
1
11,506
A `GoPackageInfo` details message should be added to the `CompilationUnit_FileInput` to ensure the import path remains the same.
kythe-kythe
go
@@ -1,10 +1,10 @@ package com.fsck.k9.activity; -import android.app.ListActivity; import android.os.Bundle; import android.view.KeyEvent; import android.view.MotionEvent; import android.widget.AdapterView; +import android.widget.ListAdapter; import android.widget.ListView; import com.fsck.k9.K9;
1
package com.fsck.k9.activity; import android.app.ListActivity; import android.os.Bundle; import android.view.KeyEvent; import android.view.MotionEvent; import android.widget.AdapterView; import android.widget.ListView; import com.fsck.k9.K9; import com.fsck.k9.activity.K9ActivityCommon.K9ActivityMagic; import com.fsc...
1
16,571
Please don't create new fields with the `m` prefix. I'd rather mix than introduce more of these.
k9mail-k-9
java
@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable { enableLazyFieldLoading = getBool("query/enableLazyFieldLoading", false); useCircuitBreakers = getBool("circuitBreaker/useCircuitBreakers", false); + cpuCircuitBreakerEnabled = getBool("circuitBreaker/cpuCircui...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,285
Can we please simplify these names? they are awfully verbose and repeating the parts that are already unique and obvious.
apache-lucene-solr
java
@@ -241,7 +241,7 @@ public class RecipientPresenter implements PermissionPingCallback { boolean alreadyVisible = recipientMvpView.isBccVisible(); boolean singleBccRecipientFromAccount = bccRecipients.length == 1 && bccRecipients[0].toString().equals(bccAddress); - ...
1
package com.fsck.k9.activity.compose; import java.util.ArrayList; import java.util.Arrays; import java.util.Collections; import java.util.List; import android.app.Activity; import android.app.LoaderManager; import android.app.PendingIntent; import android.content.Context; import android.content.Intent; import androi...
1
15,331
Flipped the logic here, was this actually wrong before?
k9mail-k-9
java
@@ -336,7 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb) .reason = CALI_REASON_UNKNOWN, }; struct calico_nat_dest *nat_dest = NULL; - bool nat_lvl1_drop = 0; + int res = 0; /* we assume we do FIB and from this point on, we only set it to false * if we decide not to do it.
1
// Project Calico BPF dataplane programs. // Copyright (c) 2020 Tigera, Inc. All rights reserved. // // This program is free software; you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation; either version 2 of the License, or // (at...
1
17,998
I think (a) should be initialized to `NAT_FE_LOOKUP_ALLOW` and (b) it should be probably the first thing in `calico_v4_nat_lookup2`
projectcalico-felix
go
@@ -36,7 +36,7 @@ public class TestManyPointsInOldIndex extends LuceneTestCase { // // Compile: // 1) temporarily remove 'extends LuceneTestCase' above (else java doesn't see our static void main) -// 2) ant compile-test +// 2) gradlew testClasses // // Run: // 1) java -cp ../build/backward-codecs/classes...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,632
I'd look as to what this class actually does... seems weird. Classpath below (under "run") is wrong for gradle.
apache-lucene-solr
java
@@ -17,6 +17,7 @@ package algod import ( + "github.com/algorand/go-algorand/data/basics" "path/filepath" "testing"
1
// Copyright (C) 2019 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) any l...
1
35,323
Group w/ algorand imports
algorand-go-algorand
go
@@ -28,12 +28,14 @@ package com.salesforce.androidsdk.store; import java.util.ArrayList; import java.util.List; +import java.util.Locale; import net.sqlcipher.database.SQLiteDatabase; import org.json.JSONException; import org.json.JSONObject; +import android.annotation.SuppressLint; import android.content...
1
/* * Copyright (c) 2011, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice, this...
1
14,015
I don't think this import is being used.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -5,7 +5,7 @@ const AnyKind = "*** any procedure kind ***" // Pattern represents an operator tree pattern // It can match itself against a query plan type Pattern interface { - Root() ProcedureKind + Roots() []ProcedureKind Match(Node) bool }
1
package plan const AnyKind = "*** any procedure kind ***" // Pattern represents an operator tree pattern // It can match itself against a query plan type Pattern interface { Root() ProcedureKind Match(Node) bool } // Pat returns a pattern that can match a plan node with the given ProcedureKind // and whose predece...
1
14,344
This is an interesting way to do this. I like it. An alternative way to implement a multiple kind pattern was to have this return `AnyKind` and then have match perform an actual check to see if it matches.
influxdata-flux
go
@@ -373,8 +373,9 @@ class SonataMediaExtension extends Extension implements PrependExtensionInterfac } if ($container->hasDefinition('sonata.media.cdn.fallback') && isset($config['cdn']['fallback'])) { + // NEXT_MAJOR: Do not fallback to master $container->getDefinition('sona...
1
<?php declare(strict_types=1); /* * This file is part of the Sonata Project package. * * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ namespace Sonata\MediaBundle\Dependenc...
1
12,718
You did not check this code
sonata-project-SonataMediaBundle
php
@@ -31,6 +31,10 @@ func EncodeValues(vals []*Value) ([]byte, error) { // DecodeValues decodes an array of abi values from the given buffer, using the // provided type information. func DecodeValues(data []byte, types []Type) ([]*Value, error) { + if len(types) > 0 && len(data) == 0 { + return nil, fmt.Errorf("expec...
1
package abi import ( "fmt" cbor "github.com/ipfs/go-ipld-cbor" "github.com/pkg/errors" ) // EncodeValues encodes a set of abi values to raw bytes. Zero length arrays of // values are normalized to nil func EncodeValues(vals []*Value) ([]byte, error) { if len(vals) == 0 { return nil, nil } var arr [][]byte ...
1
18,902
This was necessary due to a bug uncovered in testing. If an actor method which requires params is called without any params at all, not returning an error here causes a panic.
filecoin-project-venus
go
@@ -738,6 +738,7 @@ const htmlElms = { 'dialog', 'document', 'feed', + 'group', 'log', 'main', 'marquee',
1
// Source: https://www.w3.org/TR/html-aria/#allowed-aria-roles-states-and-properties // Source: https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings // Source https://html.spec.whatwg.org/multipage/dom.html#content-models // Source https://dom.spec.whatwg.org/#dom-element-attachshadow const htmlElms = { a: ...
1
17,260
Thanks for the pr. Would you be able to edit the file to use spaces rather than tabs? Normally we have prettier run on commit, but I guess file patches don't do that.
dequelabs-axe-core
js
@@ -111,7 +111,6 @@ public class TestHiveClientPool { "Another meta exception", () -> clients.run(client -> client.getTables("default", "t"))); } - @Test public void testConnectionFailureRestoreForMetaException() throws Exception { HiveMetaStoreClient hmsClient = newClient();
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
41,852
Is it intentional that we removed this annotation?
apache-iceberg
java
@@ -42,6 +42,18 @@ namespace AutoRest.Swagger.Validation /// </summary> public override Category Severity => Category.Warning; + /// <summary> + /// What kind of open api document type this rule should be applied to + /// </summary> + public override ServiceDefinitionDocu...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using AutoRest.Core.Logging; using AutoRest.Core.Properties; using AutoRest.Core.Utilities; using System.Collections.Generic; using AutoRest.Swagger.Model; using...
1
25,119
should be general?
Azure-autorest
java
@@ -153,7 +153,7 @@ namespace Nethermind.Blockchain private void LoadBestKnown() { long headNumber = Head?.Number ?? _syncConfig.PivotNumberParsed; - long left = Math.Max(_syncConfig.PivotNumberParsed, headNumber); + long left = Math.Max(LowestInsertedHea...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
23,887
if lowest inserted header is non null non zero then pivot should be higher and a better best known on the left. maybe Head?.Number ?? Math.Max(Pivot, LowestInsertedHeader))?
NethermindEth-nethermind
.cs
@@ -0,0 +1,14 @@ +package azkaban.execapp.fake; + +import azkaban.execapp.AzkabanExecutorServer; +import azkaban.execapp.jmx.JmxJobMBeanManager; +import azkaban.utils.Props; + +public class FakeApp extends AzkabanExecutorServer { + + public FakeApp() throws Exception { + super(new Props(), null, null, new FakeServe...
1
1
13,289
Is a FakeApp class needed? Can test use a Mockito mock instance instead?
azkaban-azkaban
java
@@ -1020,7 +1020,8 @@ VariableSP SymbolFilePDB::ParseVariableForPDBData( var_sp = std::make_shared<Variable>( var_uid, var_name.c_str(), mangled_cstr, type_sp, scope, context_scope, - ranges, &decl, location, is_external, is_artificial, is_static_member); + ranges, &decl, location, is_external, is...
1
//===-- SymbolFilePDB.cpp ---------------------------------------*- C++ -*-===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See https://llvm.org/LICENSE.txt for license information. // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception // //===---------------------------...
1
20,201
We should make this an enum.
apple-swift-lldb
cpp
@@ -15,7 +15,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk private const string TestRuleId = "TST0001"; private const string TestFormatSpecifier = "testFormatSpecifier"; private const string TestAnalysisTarget = @"C:\dir\file"; - private static readonly string DisplayedTarget ...
1
// Copyright (c) Microsoft. All rights reserved. // Licensed under the MIT license. See LICENSE file in the project root for full license information. using System.Collections.Generic; using FluentAssertions; using Xunit; namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk { // These tests test the extension metho...
1
10,255
@lgolding, note I fixed the forward slashes that appeared in the VS output (which was certainly not by design).
microsoft-sarif-sdk
.cs
@@ -724,7 +724,7 @@ class ElementPlot(BokehPlot, GenericElementPlot): else: self.handles['xaxis'] = plot.xaxis[0] self.handles['x_range'] = plot.x_range - self.handles['y_axis'] = plot.yaxis[0] + self.handles['yaxis'] = plot.yaxis[0] self.handles['y_...
1
import warnings import param import numpy as np import bokeh import bokeh.plotting from bokeh.core.properties import value from bokeh.models import (HoverTool, Renderer, Range1d, DataRange1d, Title, FactorRange, FuncTickFormatter, Tool, Legend) from bokeh.models.tickers import Ticker, BasicTi...
1
21,283
Minor unrelated fix that snuck in.
holoviz-holoviews
py