patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -19,13 +19,14 @@ package org.openqa.selenium.remote; import com.google.common.collect.ImmutableMap; +import org.openqa.selenium.DeviceRotation; import org.openqa.selenium.Rotatable; import org.openqa.selenium.ScreenOrientation; import java.lang.reflect.Method; public class AddRotatable implements Augmen...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,511
you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)
SeleniumHQ-selenium
rb
@@ -1955,15 +1955,7 @@ context 'Substitutions' do end test 'should passthrough math macro inside another passthrough' do - input = 'the text `asciimath:[x = y]` should be passed through as +literal+ text' - para = block_from_string input, attributes: { 'compat-mode' => '' } - assert...
1
# frozen_string_literal: true require_relative 'test_helper' # TODO # - test negatives # - test role on every quote type context 'Substitutions' do BACKSLASH = ?\\ context 'Dispatcher' do test 'apply normal substitutions' do para = block_from_string("[blue]_http://asciidoc.org[AsciiDoc]_ & [red]*Ruby*\n&...
1
6,692
What is this obscure syntax anyway? o.O
asciidoctor-asciidoctor
rb
@@ -756,6 +756,10 @@ class SPRegion(PyRegion): return spec + def getAlgorithm(self): + return self._sfdr + + def getParameter(self, parameterName, index=-1): """ Get the value of a NodeSpec parameter. Most parameters are handled
1
# ---------------------------------------------------------------------- # Numenta Platform for Intelligent Computing (NuPIC) # Copyright (C) 2013, Numenta, Inc. Unless you have an agreement # with Numenta, Inc., for a separate license for this software code, the # following terms and conditions apply: # # This progra...
1
20,130
I think we should have one for the CLA Classifier, and KNNClassifier as well. And how about RecordSensor?
numenta-nupic
py
@@ -0,0 +1,9 @@ +package com.fsck.k9.fragment; +import android.database.Cursor; +import android.view.ContextMenu; +/** + Created by Kamil Rajtar on 05.11.17. */ + +public interface ICursorContextMenuSupplier{ + void getCursorMenu(ContextMenu menu,Cursor cursor); +}
1
1
16,339
Missing new line.
k9mail-k-9
java
@@ -17,6 +17,9 @@ const populateModelSymbol = require('../symbols').populateModelSymbol; const schemaMixedSymbol = require('../../schema/symbols').schemaMixedSymbol; module.exports = function getModelsMapForPopulate(model, docs, options) { + if (model.schema.base.options.strictPopulate == false && options.strictPo...
1
'use strict'; const MongooseError = require('../../error/index'); const SkipPopulateValue = require('./SkipPopulateValue'); const get = require('../get'); const getDiscriminatorByValue = require('../discriminator/getDiscriminatorByValue'); const getConstructorName = require('../getConstructorName'); const getSchemaTyp...
1
14,848
`model.schema.base.options.strictPopulate != null`. Why hardcoding false? Also, `model.base.options` should work and be shorter. Finally, any way to move this up to the `populate()` function in `model.js` that calls `getModelsMapForPopulate()` and shallow clone the object before modifying? A bit random to modify this o...
Automattic-mongoose
js
@@ -35,10 +35,10 @@ namespace Nethermind.Core.Test ISpecProvider specProvider = new CustomSpecProvider((0, releaseSpec)); BlockValidator blockValidator = new BlockValidator(txValidator, AlwaysValidHeaderValidator.Instance, AlwaysValidOmmersValidator.Instance, specProvider, LimboLogs.Instance...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of...
1
23,095
We now have Prepare.A/Build.A/Builders.Build.A - what are the differences?
NethermindEth-nethermind
.cs
@@ -51,6 +51,12 @@ module Asciidoctor append_newline ? %(#{str}#{LF}) : str end + def preserve_backslash str + str = str. + gsub(/\\/, '\\e') + str + end + def skip_with_warning node, name = nil warn %(asciidoctor: WARNING: converter missing for #{name || node.node_name}...
1
module Asciidoctor # A built-in {Converter} implementation that generates the man page (troff) format. # # The output follows the groff man page definition while also trying to be # consistent with the output produced by the a2x tool from AsciiDoc Python. # # See http://www.gnu.org/software/groff/manual/htm...
1
5,130
Could you reduce this to one line and change the first argument to a single quoted backslash string? Perhaps we can add this as an option named `:preserve_backslash` to the manify method. That way, we don't need an extra method in the first two cases. Obviously, we still need it for the inline case.
asciidoctor-asciidoctor
rb
@@ -49,10 +49,10 @@ var _ = Context("with initialized Felix, etcd datastore, 3 workloads", func() { defaultProfile := api.NewProfile() defaultProfile.Name = "default" defaultProfile.Spec.LabelsToApply = map[string]string{"default": ""} - defaultProfile.Spec.EgressRules = []api.Rule{{Action: "allow"}} + defau...
1
// +build fvtests // Copyright (c) 2017 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unles...
1
15,865
`has(default)` i think is the preferred way of doing this
projectcalico-felix
c
@@ -235,7 +235,7 @@ public class BaseRewriteManifests extends SnapshotProducer<RewriteManifests> imp keptManifests.add(manifest); } else { rewrittenManifests.add(manifest); - try (ManifestReader reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsBy...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
20,466
Does this mean we can only do rewrites if there are no `DeleteFile`'s?
apache-iceberg
java
@@ -96,10 +96,12 @@ class InstallTest(QuiltTestCase): """ table_data, table_hash = self.make_table_data() file_data, file_hash = self.make_file_data() - contents, contents_hash = self.make_contents(table=table_hash, file=file_hash) + contents, contents_hash = self.make_contents(...
1
""" Tests for the install command. """ import hashlib import json import os import time import requests import responses from six import assertRaisesRegex from six.moves import urllib from ..tools import command from ..tools.const import HASH_TYPE from ..tools.core import ( decode_node, encode_node, hash...
1
15,831
Actually, these are fine; we're using 110 as the max line length. (it's also set in the .pylintrc)
quiltdata-quilt
py
@@ -17,6 +17,7 @@ package main import ( . "github.com/onsi/ginkgo" . "github.com/onsi/gomega" + "github.com/projectcalico/felix/k8sfv/leastsquares" )
1
// Copyright (c) 2017 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
15,292
No issue here, but what tool are you running to put these imports into the preferred organization? I have configuration to run `goimports` whenever I save a file, but it appears that that is not quite sufficient.
projectcalico-felix
c
@@ -131,6 +131,7 @@ public class DTAFileReaderSpi extends TabularDataFileReaderSpi{ @Override public boolean canDecodeInput(BufferedInputStream stream) throws IOException { + //who closes this stream? if (stream ==null){ throw new IllegalArgumentException("stream == null!"); ...
1
/* Copyright (C) 2005-2014, by the President and Fellows of Harvard College. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unle...
1
43,123
guessing this method could/should close it but I didn't see where it was getting called.
IQSS-dataverse
java
@@ -50,11 +50,13 @@ public class ExecutableFlow extends ExecutableFlowBase { public static final String AZKABANFLOWVERSION_PARAM = "azkabanFlowVersion"; public static final String IS_LOCKED_PARAM = "isLocked"; public static final String FLOW_LOCK_ERROR_MESSAGE_PARAM = "flowLockErrorMessage"; + public static f...
1
/* * Copyright 2013 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
19,793
Could you please use `camelCase` in the property name to follow the naming convention used in the rest of the properties?
azkaban-azkaban
java
@@ -12,7 +12,7 @@ import ( ) const ( - fmtErrPublicSubnetsFromEnv = "get public subnet IDs from environment %s: %w" + fmtErrPublicSubnetsFromEnv = "get public subnet IDs from environment %s: %w " fmtErrSecurityGroupsFromEnv = "get security groups from environment %s: %w" envSecurityGroupCFNLogicalIDTagKey ...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package task import ( "fmt" "github.com/aws/copilot-cli/internal/pkg/aws/ec2" "github.com/aws/copilot-cli/internal/pkg/aws/ecs" "github.com/aws/copilot-cli/internal/pkg/deploy" ) const ( fmtErrPublicSub...
1
16,604
Can we revert this change? looks like an extra space was added at the end
aws-copilot-cli
go
@@ -222,6 +222,9 @@ public class RubyPackageMetadataTransformer implements ModelToViewTransformer { productConfig, ImportSectionView.newBuilder().build(), surfaceNamer)) .hasSmokeTests(hasSmokeTests) .versionPath(surfaceNamer.getVersionIndexFileImportName()) + .versionNamespace...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
22,340
This just grabs any one of the proto services defined in the API, right? What happens when there are multiple (like with PubSub)?
googleapis-gapic-generator
java
@@ -40,7 +40,9 @@ def define_violation(model_name, dbengine): """ base = declarative_base() - violations_tablename = '{}_violations'.format(model_name) + # pylint: disable=too-many-format-args + violations_tablename = 'violations'.format(model_name) + # pylint: enable=too-many-format-args ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
28,388
Remove the pylint disable and remove the .format() from the string. The tablename is just 'violations'
forseti-security-forseti-security
py
@@ -8,6 +8,16 @@ class Trail < ActiveRecord::Base friendly_id :name, use: [:slugged, :finders] + # Override setters so it preserves the ordering + def exercise_ids=(new_exercise_ids) + super + new_exercise_ids = new_exercise_ids.reject(&:blank?).map(&:to_i) + + new_exercise_ids.each_with_index do |exe...
1
class Trail < ActiveRecord::Base extend FriendlyId validates :name, :description, presence: true has_many :steps, -> { order "position ASC" }, dependent: :destroy has_many :exercises, through: :steps friendly_id :name, use: [:slugged, :finders] def steps_remaining_for(user) ExerciseWithProgressQuery...
1
12,384
Will this implementation allow you to add new exercises to the trail?
thoughtbot-upcase
rb
@@ -76,9 +76,17 @@ func trapSignalsPosix() { caddyfileToUse = newCaddyfile } + // Backup old event hooks + oldEventHooks := cloneEventHooks() + + // Purge the old event hooks + purgeEventHooks() + // Kick off the restart; our work is done _, err = inst.Restart(caddyfileToUse) if ...
1
// Copyright 2015 Light Code Labs, LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
11,924
Actually there is race condition here, because pointer assignment isn't atomic on some platform. But this is a rare case we should hit, we can just let it go for now. Maybe this is one of the TODO list.
caddyserver-caddy
go
@@ -181,6 +181,10 @@ void lbann::distributed_io_buffer::calculate_num_iterations_per_epoch(int num_mo max_mini_batch_size = data_reader->get_num_data(); } + bool partitioned = data_reader->is_partitioned(); + //@todo "if (partitioned)" conditionals below assume one processor per model; + // this needs...
1
//////////////////////////////////////////////////////////////////////////////// // Copyright (c) 2014-2016, Lawrence Livermore National Security, LLC. // Produced at the Lawrence Livermore National Laboratory. // Written by the LBANN Research Team (B. Van Essen, et al.) listed in // the CONTRIBUTORS file. <lbann-dev@l...
1
13,029
We should check somewhere here and in the partitioned_io_buffer that the max_mini_batch_size is properly computed for each model and that it is not aggregate (sum) for all models. The global/max_mini_batch_size should be as specified by the user in the prototext/cmd line.
LLNL-lbann
cpp
@@ -132,7 +132,7 @@ const Capability = { * Defines how the driver should handle unexpected alerts. The value should * be one of "accept", "dismiss", or "ignore". */ - UNEXPECTED_ALERT_BEHAVIOR: 'unexpectedAlertBehavior', + UNEXPECTED_ALERT_BEHAVIOUR: 'unexpectedAlertBehaviour', /** Defines the browse...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
14,472
you can change the string value, but not the code constant
SeleniumHQ-selenium
rb
@@ -27,10 +27,10 @@ func TestBech32(t *testing.T) { {"split1checkupstagehandshakeupstreamerranterredcaperred2y9e2w", false}, // invalid checksum {"s lit1checkupstagehandshakeupstreamerranterredcaperredp8hs2p", false}, // invalid character (space) in hrp {"spl" + string(127) ...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
12,157
File is not `goimports`-ed
iotexproject-iotex-core
go
@@ -36,6 +36,6 @@ public class AzkabanExecServerModule extends AbstractModule { bind(AzkabanExecutorServer.class).in(Scopes.SINGLETON); bind(TriggerManager.class).in(Scopes.SINGLETON); bind(FlowRunnerManager.class).in(Scopes.SINGLETON); - + // TODO: add ExecMetrics when guicy } }
1
/* * Copyright 2017 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
13,718
Is this Todo necessary?
azkaban-azkaban
java
@@ -108,10 +108,7 @@ class ErrorHandler(object): message = value["value"] if not isinstance(message, basestring): value = message - try: - message = message['message'] - ...
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
14,481
I would recommend to leave out `None` because None is already the default.
SeleniumHQ-selenium
py
@@ -97,6 +97,10 @@ const ( taskIDFlag = "task-id" containerFlag = "container" + + valuesFlag = "values" + overwriteFlag = "overwrite" + inputFilePathFlag = "cli-input-yaml" ) // Short flag names.
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package cli import ( "fmt" "strings" "github.com/aws/copilot-cli/internal/pkg/manifest" "github.com/aws/copilot-cli/internal/pkg/template" ) // Long flag names. const ( // Common flags. nameFlag = ...
1
17,401
I may have missed previous discussion on this; apologies if that's the case. What do you think about just `input-yaml`, without the `cli-`?
aws-copilot-cli
go
@@ -57,13 +57,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal public async Task StartAsync(IConnectionHandler connectionHandler) { + Exception error = null; try { connectionHandler.OnConnection(this); ...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Buffers; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.IO.Pipelines; using Syste...
1
14,648
Nit: rename to sendError.
aspnet-KestrelHttpServer
.cs
@@ -7,6 +7,10 @@ Makes functions in .tools.command accessible directly from quilt. # None: CLI params have not yet been parsed to determine mode. _DEV_MODE = None +# Suppress numpy warnings for Python 2.7 +import warnings +warnings.filterwarnings("ignore", message="numpy.dtype size changed") + # Normally a try: ...
1
""" Makes functions in .tools.command accessible directly from quilt. """ # True: Force dev mode # False: Force normal mode # None: CLI params have not yet been parsed to determine mode. _DEV_MODE = None # Normally a try: except: block on or in main() would be better and simpler, # but we load a bunch of external mo...
1
16,943
`pylint` wants to know why this `import` isn't at the top of the file; and it's kinda right
quiltdata-quilt
py
@@ -0,0 +1,19 @@ +package de.danoeh.antennapod.core.feed; + +public class FeedUrlNotFoundException extends RuntimeException { + private final String artistName; + private final String trackName; + + public FeedUrlNotFoundException(String url, String trackName) { + this.artistName = url; + this.tr...
1
1
21,193
To me, using a `RuntimeException` for this feels a bit weird. I would just extend `Exception`, or maybe even `IoException`. Could you also please overwrite the `getMessage` function to return something like `"Result does not specify a feed url"`?
AntennaPod-AntennaPod
java
@@ -88,7 +88,8 @@ func convertStorage(ctx context.Context, msg *cepubsub.Message, sendMode ModeTyp } } event.SetDataContentType(*cloudevents.StringOfApplicationJSON()) - event.SetData(msg.Data) + event.Data = msg.Data + event.DataEncoded = true // Attributes are extensions. if msg.Attributes != nil && len(ms...
1
/* Copyright 2019 Google LLC Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software dist...
1
9,587
what was the issue here? why did you have to directly set?
google-knative-gcp
go
@@ -226,10 +226,8 @@ func (c *Command) proposals() { for _, proposal := range proposals { country := proposal.ServiceDefinition.LocationOriginate.Country var countryString string - if country != nil { - countryString = *country - } else { - countryString = "Unknown" + if len(country) == 0 { + country =...
1
package cli import ( "fmt" "github.com/chzyer/readline" "github.com/mysterium/node/cmd" tequilapi_client "github.com/mysterium/node/tequilapi/client" "io" "log" "strings" ) // NewCommand constructs CLI based with possibility to control quiting func NewCommand( historyFile string, tequilapi *tequilapi_client....
1
10,740
I'm confusied - Isn't `countryString` left empty if `len(country)` != 0?
mysteriumnetwork-node
go
@@ -53,7 +53,7 @@ DesktopSwitch::DesktopSwitch(const ILXQtPanelPluginStartupInfo &startupInfo) : mLabelType(static_cast<DesktopSwitchButton::LabelType>(-1)) { m_buttons = new QButtonGroup(this); - connect (m_pSignalMapper, SIGNAL(mapped(int)), this, SLOT(setDesktop(int))); + connect (m_pSignalMapper, Q...
1
/* BEGIN_COMMON_COPYRIGHT_HEADER * (c)LGPL2+ * * LXQt - a lightweight, Qt based, desktop toolset * https://lxqt.org * * Copyright: 2011 Razor team * Authors: * Petr Vanek <petr@scribus.info> * * This program or library is free software; you can redistribute it * and/or modify it under the terms of the GNU ...
1
6,816
Would you please update this by using `#if (QT_VERSION >= QT_VERSION_CHECK(5,15,0))` and `QSignalMapper::mappedInt` for Qt >= 5.15?
lxqt-lxqt-panel
cpp
@@ -262,6 +262,8 @@ func PopulateInstallRoot(installChroot *safechroot.Chroot, packagesToInstall []s filesystemPkg = "filesystem" ) + defer stopGPGAgent(installChroot) + ReportAction("Initializing RPM Database") installRoot := filepath.Join(rootMountPoint, installChroot.RootDir())
1
// Copyright (c) Microsoft Corporation. // Licensed under the MIT License. package installutils import ( "crypto/rand" "fmt" "os" "path" "path/filepath" "sort" "strconv" "strings" "syscall" "time" "microsoft.com/pkggen/imagegen/configuration" "microsoft.com/pkggen/imagegen/diskutils" "microsoft.com/pkgg...
1
12,131
This type of change opens a question on how we can cleanly shutdown or prevent all running agents so we do not run the risk of an agent holding kernel mountpoints, which can cause unsafe unmount/chroot exit. Will open a github issue to track this. This specific change itself is fine. It is a pointed change specifically...
microsoft-CBL-Mariner
go
@@ -3,6 +3,8 @@ package io.protostuff.runtime.model; +import com.google.protobuf.CodedOutputStream; + public final class ModelProtobuf { private ModelProtobuf() { }
1
// Generated by the protocol buffer compiler. DO NOT EDIT! // source: ModelProtobuf.proto package io.protostuff.runtime.model; public final class ModelProtobuf { private ModelProtobuf() { } public static void registerAllExtensions( com.google.protobuf.ExtensionRegistryLite registry) { } public stat...
1
7,907
this file is model generated by protobuf, just for compatible test it's better not change it.
apache-servicecomb-java-chassis
java
@@ -8,8 +8,8 @@ class Analytics @user = user end - def track_cancelled - track(event: "Cancelled", properties: {}) + def track_cancelled(reason) + track(event: "Cancelled", properties: { reason: reason }) end def track_updated
1
class Analytics include AnalyticsHelper class_attribute :backend self.backend = AnalyticsRuby def initialize(user) @user = user end def track_cancelled track(event: "Cancelled", properties: {}) end def track_updated backend.identify(user_id: user.id, traits: identify_hash(user)) end ...
1
13,590
It turns out we can send the reason as the property to Segment on the event. Then we can do whatever we want with it. In this case, I think we'll fire a web hook to Zapier which will add a note or message on the user in Intercom.
thoughtbot-upcase
rb
@@ -0,0 +1,17 @@ +class PromotedCatalog + def initialize(catalog) + @catalog = catalog + end + + def method_missing(message, *arguments) + catalog.send(message, *arguments).promoted + end + + def respond_to_missing?(message, include_all = false) + catalog.send(:respond_to?, message, include_all) + end + ...
1
1
9,446
This class is very similar to `Catalog`. Is there a way to have this class compose a `Catalog` instance or extract a common class which they can both compose?
thoughtbot-upcase
rb
@@ -164,9 +164,7 @@ TEST("pull as device usm from host-allocated homogen table") { row_accessor<const float>{ data } // .pull(q, { 1, 3 }, sycl::usm::alloc::device); - const auto data_arr_host = - la::matrix<float>::wrap(q, data_arr_device.get_data(), { row_count, column_count }) - ...
1
/******************************************************************************* * Copyright 2020-2021 Intel Corporation * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apa...
1
28,722
Why did you decide to drop the `queue` from parameters of `wrap` function? The agreement was that all functions for DPC++ case that accept non-host-accessible memory shall accept the queue directly.
oneapi-src-oneDAL
cpp
@@ -340,6 +340,11 @@ module RSpec # @return [Symbol] add_setting :detail_color + # @macro add_setting + # Hyperlink failed examples (default: `false`). + # @return [Boolean] + add_setting :hyperlink + # @macro add_setting # Don't print filter info i.e. "Run options: inc...
1
RSpec::Support.require_rspec_core "backtrace_formatter" RSpec::Support.require_rspec_core "ruby_project" RSpec::Support.require_rspec_core "formatters/deprecation_formatter" RSpec::Support.require_rspec_core "output_wrapper" module RSpec module Core # rubocop:disable Metrics/ClassLength # Stores runtime con...
1
17,324
I think this is a bad name, as its not clear what it does by name alone. If we merge this it should be something like `use_links_to_files_in_output` and should take either a custom scheme like `rspec` or default to `file`
rspec-rspec-core
rb
@@ -65,6 +65,7 @@ public final class BaselineErrorProne implements Plugin<Project> { .configure(ErrorProneOptions.class, errorProneOptions -> { errorProneOptions.check("Slf4jLogsafeArgs", CheckSeverity.OFF); error...
1
/* * (c) Copyright 2017 Palantir Technologies Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless ...
1
6,790
Arguably this is actually still valuable for perf, maybe it should just be a warning?
palantir-gradle-baseline
java
@@ -35,6 +35,14 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) { return } + s.Addressbook.Put(address, addr) + if err := s.TopologyDriver.AddPeer(address); err != nil { + s.Logger.Debugf("debug api: topologyDriver.AddPeer %s: %v", addr, err) + s.Logger.Errorf("unable to connect ...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package debugapi import ( "errors" "net/http" "github.com/ethersphere/bee/pkg/jsonhttp" "github.com/ethersphere/bee/pkg/p2p" "github.com/ethersphere/b...
1
8,920
didn't way say that the topology driver will actually insert the entries to the address book?
ethersphere-bee
go
@@ -24,11 +24,13 @@ import { removeNode } from '../util'; * Fragments that have siblings. In most cases, it starts out as `oldChildren[0]._dom`. */ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context, isSvg, excessDomChildren, mounts, ancestorComponent, oldDom) { - let childVNode, i, j,...
1
import { diff, unmount } from './index'; import { coerceToVNode, Fragment } from '../create-element'; import { EMPTY_OBJ, EMPTY_ARR } from '../constants'; import { removeNode } from '../util'; /** * Diff the children of a virtual node * @param {import('../internal').PreactElement} parentDom The DOM element whose * ...
1
13,235
This seems safe to me. My guess is the original checks were a combination of before + after `oldParentVNode` became reliably a `(vnode | null)`.
preactjs-preact
js
@@ -148,6 +148,10 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const { " --conform FILE Specify a schema the following schemas should be\n" " an evolution of. Gives errors if not.\n" " --conform-includes Include path for the schema given with...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
17,838
also in the `.md` please.
google-flatbuffers
java
@@ -7,7 +7,9 @@ module Unix::Pkg end def install_package name - if self['platform'] =~ /(fedora)|(centos)|(el)/ + if self['platform'] =~ /(el-4)|(redhat-4)/ + @logger.debug("Package installation not supported on rhel4") + elsif self['platform'] =~ /(fedora)|(centos)|(el)|(redhat)/ execute("...
1
module Unix::Pkg include PuppetAcceptance::CommandFactory def check_for_package name result = exec(PuppetAcceptance::Command.new("which #{name}"), :acceptable_exit_codes => (0...127)) result.exit_code == 0 end def install_package name if self['platform'] =~ /(fedora)|(centos)|(el)/ execute("...
1
4,513
RHEL is an acronym and is usually all caps. Why are you adding a redhat regex matcher?
voxpupuli-beaker
rb
@@ -193,16 +193,6 @@ public class VectorizedColumnIterator extends BaseColumnIterator { } } - public class FixedWidthTypeBinaryBatchReader extends BatchReader { - @Override - protected int nextBatchOf( - final FieldVector vector, final int expectedBatchSize, final int numValsInVector, final int ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
41,182
Maybe I am daft but it looks like you removed fixed width readers but I don't see where you added any readers?
apache-iceberg
java
@@ -16,6 +16,14 @@ import ( const DefaultManifestType = ManifestMantarayContentType +const ( + RootPath = "/" + WebsiteIndexDocumentSuffixKey = "website-index-document" + WebsiteErrorDocumentPathKey = "website-error-document" + EntryMetadataContentTypeKey = "Content-Type" + EntryMetadataFi...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. // Package manifest contains the abstractions needed for // collection representation in Swarm. package manifest import ( "context" "errors" "github.com...
1
14,464
@acud The reason I moved these here is because I need them in the traversal tests. The traversal package doesn't need this. I don't see any particular reason why any package apart from api would need this. api package imports traversal, so I cannot import api in traversal pkg. Also if these change in future, the traver...
ethersphere-bee
go
@@ -560,6 +560,7 @@ class AbstractTab(QWidget): self._mouse_event_filter = mouse.MouseEventFilter( self, widget_class=self.WIDGET_CLASS, parent=self) self.backend = None + self.pin = False # FIXME:qtwebengine Should this be public api via self.hints? # ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Softwa...
1
16,977
I'd prefer this to be called `pinned` - also it should probably be in the `TabData` class instead, which is accessible as the `.data` attribute of the `BrowserTab` object - otherwise, `BrowserTab` would have a lot of quite "random" attributes :wink:
qutebrowser-qutebrowser
py
@@ -24,4 +24,7 @@ final class ChromeDriverCommand { private ChromeDriverCommand() {} static final String LAUNCH_APP = "launchApp"; + static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS + = "sendCommandForDownloadChromeHeadLess"; + }
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
15,148
Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way.
SeleniumHQ-selenium
java
@@ -1,6 +1,9 @@ -/*global Audit, runRules, cleanupPlugins */ +/*global Audit */ /*eslint indent: 0*/ -function runCommand(data, keepalive, callback) { +import cleanupPlugins from './cleanup-plugins'; +import runRules from './run-rules'; + +const runCommand = (data, keepalive, callback) => { 'use strict'; var resol...
1
/*global Audit, runRules, cleanupPlugins */ /*eslint indent: 0*/ function runCommand(data, keepalive, callback) { 'use strict'; var resolve = callback; var reject = function(err) { if (err instanceof Error === false) { err = new Error(err); } callback(err); }; var context = (data && data.context) || {}; ...
1
15,459
Why not import audit as well?
dequelabs-axe-core
js
@@ -92,7 +92,9 @@ class CategoryDataFixture extends AbstractReferenceFixture . '(black-and-white), or in color, and in two or three dimensions', ] ); - $categoryData->parent = $this->getReference(self::CATEGORY_ELECTRONICS); + /** @var \Shopsys\ShopBundle\Model\Categ...
1
<?php namespace Shopsys\ShopBundle\DataFixtures\Demo; use Doctrine\Common\Persistence\ObjectManager; use Shopsys\FrameworkBundle\Component\DataFixture\AbstractReferenceFixture; use Shopsys\FrameworkBundle\Component\Domain\Domain; use Shopsys\FrameworkBundle\Model\Category\CategoryData; use Shopsys\FrameworkBundle\Mod...
1
16,271
OK, i think there will be more of those...
shopsys-shopsys
php
@@ -12,6 +12,6 @@ return [ | */ - 'failed' => 'These credentials do not match our records.', - 'throttle' => 'Too many login attempts. Please try again in :seconds seconds.', + 'failed' => 'Овие акредитиви не се совпаѓаат со нашите записи.', + 'throttle' => 'Премногу обиди за најавување. Оби...
1
<?php return [ /* |-------------------------------------------------------------------------- | Authentication Language Lines |-------------------------------------------------------------------------- | | The following language lines are used during authentication for various | messages th...
1
8,249
Can you add : 'password' => 'The provided password is incorrect.', ?
Laravel-Lang-lang
php
@@ -18,6 +18,7 @@ from logHandler import log from comtypes.gen.UIAutomationClient import * + #Some new win8 UIA constants that could be missing UIA_StyleIdAttributeId=40034 UIA_AnnotationAnnotationTypeIdPropertyId=30113
1
from ctypes import * from ctypes.wintypes import * import comtypes.client from comtypes.automation import VT_EMPTY from comtypes import * import weakref import threading import time import api import appModuleHandler import queueHandler import controlTypes import NVDAHelper import winKernel import winUser...
1
19,322
Extraneous blank line.
nvaccess-nvda
py
@@ -30,7 +30,7 @@ function ariaOwns(nodes, role) { if (nodes[index] === null) { continue; } - let virtualTree = axe.utils.getNodeFromTree(axe._tree[0], nodes[index]); + let virtualTree = axe.utils.getNodeFromTree(nodes[index]); if (owns(nodes[index], virtualTree, role, true)) { return true; }
1
const requiredOwned = axe.commons.aria.requiredOwned; const implicitNodes = axe.commons.aria.implicitNodes; const matchesSelector = axe.utils.matchesSelector; const idrefs = axe.commons.dom.idrefs; const reviewEmpty = options && Array.isArray(options.reviewEmpty) ? options.reviewEmpty : []; function owns(node, virtua...
1
14,370
nitpick: use `const virtualTree`, I know it was `let` earlier.
dequelabs-axe-core
js
@@ -464,7 +464,10 @@ func (j *mdJournal) convertToBranch( brmd.SetUnmerged() brmd.SetBranchID(bid) - // Delete the old "merged" version from the cache. + // Delete the old "merged" version from the cache. We aren't + // equipped here to cache the new version, but it will + // eventually get passed via an m...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "errors" "fmt" "io/ioutil" "os" "path/filepath" "time" "github.com/keybase/client/go/logger" "github.com/keybase/kbfs/kbfscodec" "git...
1
13,631
Actually, I think it might be easier to do it here. Rough outline: 1. Save a list of the md cache keys and new brmd while looping. 2. After the loop, for each entry: 2a. Look up the old cache entry. If it doesn't exist, continue. 2b. Otherwise, make a deep copy of it, and replace its brmd with the newly-generated one. ...
keybase-kbfs
go
@@ -253,6 +253,12 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine } source = source.Trim(); + + if(!FileHelper.IsRootedPath(source)) + { + source = FileHelper.CombinePath(source); + } + if (!FileHelper.Exists(source)) ...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT license. See LICENSE file in the project root for full license information. namespace Microsoft.VisualStudio.TestPlatform.CommandLine { using System; using System.Collections.Generic; using System.Globalization; usin...
1
11,663
We need tests for this
microsoft-vstest
.cs
@@ -47,11 +47,11 @@ func initProvider() func() { // `localhost:30080` address. Otherwise, replace `localhost` with the // address of your cluster. If you run the app inside k8s, then you can // probably connect directly to the service through dns - exp, err := otlp.NewExporter( - otlp.WithInsecure(), + config :=...
1
// Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
13,368
NewExporter takes in two arguments: a configuration for the metrics connection and one for the traces
open-telemetry-opentelemetry-go
go
@@ -241,6 +241,15 @@ import connectionManager from 'connectionManager'; navigator.mediaSession.setActionHandler('seekforward', function () { execute('fastForward'); }); + + /* eslint-disable-next-line compat/compat */ + navigator.mediaSession.setActionHandler('seekto', funct...
1
import playbackManager from 'playbackManager'; import nowPlayingHelper from 'nowPlayingHelper'; import events from 'events'; import connectionManager from 'connectionManager'; /* eslint-disable indent */ // Reports media playback to the device for lock screen control let currentPlayer; function seriesIma...
1
16,283
Why not use currentPlayer instead of playbackManager.getCurrentPlayer()?
jellyfin-jellyfin-web
js
@@ -15,7 +15,8 @@ class UsersController < Clearance::UsersController def create_user_from_params params.require(:user).permit( :email, :password, :name, :github_username, :bio, :organization, - :address1, :address2, :city, :state, :zip_code, :country + :address1, :address2, :city, :state, :zip_...
1
class UsersController < Clearance::UsersController before_filter :require_login, only: [:edit, :update] def edit end def update if current_user.update_attributes(create_user_from_params) redirect_to my_account_path, notice: I18n.t("users.flashes.update.success") else render action: :edit ...
1
17,531
Avoid comma after the last parameter of a method call, unless each item is on its own line.
thoughtbot-upcase
rb
@@ -52,7 +52,12 @@ type Config struct { // DataDir is the directory data is saved to in order to preserve state // across agent restarts. It is only used if "Checkpoint" is true as well. + // It is also used to keep the metadata of containers managed by the agent + // regardless of whether "Checkpoint" is set. ...
1
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
15,951
You should remove the outdated sentence.
aws-amazon-ecs-agent
go
@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener, "com.fsck.k9.activity.MessageCompose.quotedTextFormat"; private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = "numAttachmentsLoading"; private static final String STATE_KEY_WAITING_FOR_ATTACHM...
1
package com.fsck.k9.activity; import java.text.DateFormat; import java.util.ArrayList; import java.util.Collection; import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Locale; import java.util.Map; import java.util.regex.Matcher; import java.util.regex.Pattern; import android.ann...
1
13,429
Please restore the empty line after the group of `STATE_*` constants. This visual separation makes the code easier to read.
k9mail-k-9
java
@@ -213,9 +213,10 @@ module.exports = class GoldenRetriever extends Plugin { this.IndexedDBStore.delete(fileID) }) - this.core.on('core:success', (fileIDs) => { + this.core.on('core:complete', ({ successful }) => { + const fileIDs = successful.map((file) => file.id) this.deleteBlobs(file...
1
const Plugin = require('../Plugin') const ServiceWorkerStore = require('./ServiceWorkerStore') const IndexedDBStore = require('./IndexedDBStore') const MetaDataStore = require('./MetaDataStore') /** * The Golden Retriever plugin — restores selected files and resumes uploads * after a closed tab or a browser crash! * *...
1
10,113
Unsure why this is `RestoreFiles` now vs `GoldenRetriever`, thought we deprecated the first?
transloadit-uppy
js
@@ -436,6 +436,10 @@ namespace pwiz.Skyline.Controls.Graphs { // Match each file status with a progress control. bool first = true; + var width = flowFileStatus.Width - 2 - + (flowFileStatus.VerticalScroll.Visible + ? System...
1
/* * Original author: Don Marsh <donmarsh .at. u.washington.edu>, * MacCoss Lab, Department of Genome Sciences, UW * * Copyright 2013 University of Washington - Seattle, WA * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in complian...
1
12,839
Not sure what this is. Bad merge?
ProteoWizard-pwiz
.cs
@@ -171,7 +171,7 @@ func (v *veth) create(n *network, nspid int) (err error) { netlink.LinkDel(veth) } }() - if err := v.attach(&n.Network); err != nil { + if err = v.attach(&n.Network); err != nil { return err } child, err := netlink.LinkByName(n.TempVethPeerName)
1
// +build linux package libcontainer import ( "fmt" "io/ioutil" "net" "path/filepath" "strconv" "strings" "github.com/opencontainers/runc/libcontainer/configs" "github.com/opencontainers/runc/libcontainer/utils" "github.com/vishvananda/netlink" ) var strategies = map[string]networkStrategy{ "veth": &v...
1
14,423
I'm confused, what did this actually fix? Is there a reason we are setting `err` in the parent scope to `nil` in this round-about way?
opencontainers-runc
go
@@ -1103,6 +1103,10 @@ func TestApplyEnv_Image_HealthCheck(t *testing.T) { } } +func TestApplyEnv_Platform(t *testing.T) { + // TODO: Add test for platform in the next PR +} + func TestApplyEnv_Entrypoint(t *testing.T) { testCases := map[string]struct { inSvc func(svc *LoadBalancedWebService)
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package manifest import ( "testing" "time" "github.com/aws/aws-sdk-go/aws" "github.com/stretchr/testify/require" ) /** How to add `ApplyEnv` unit test to a new manifest field: When writing tests for a f...
1
18,808
Can we remove this ?
aws-copilot-cli
go
@@ -0,0 +1,7 @@ +class NewLanguageConfirmationsController < ApplicationController + def index + redirect_to welcome_to_upcase_path( + confirmation: true, language_selected: params[:language], + ), notice: "Thanks for signing up. We will be in touch!" + end +end
1
1
18,254
Put a comma after the last parameter of a multiline method call.
thoughtbot-upcase
rb
@@ -48,12 +48,13 @@ func TestBlockDAO(t *testing.T) { tsf3, err := testutil.SignedTransfer(testaddress.Addrinfo["charlie"].String(), testaddress.Keyinfo["charlie"].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0)) require.NoError(t, err) - // create testing votes - vote...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,582
line is 195 characters (from `lll`)
iotexproject-iotex-core
go
@@ -29,8 +29,11 @@ import ( "github.com/pkg/errors" k8serror "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" + klabels "k8s.io/apimachinery/pkg/labels" + "k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/util/runtime" "k8s.io/client-go/tools/cache" + "k8s.io/kubernete...
1
/* Copyright 2018 The OpenEBS Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, soft...
1
16,830
could not import k8s.io/kubernetes/pkg/util/slice (invalid package name: "") (from `typecheck`)
openebs-maya
go
@@ -29,4 +29,4 @@ describeComponent( expect(component._state).to.equal('inDOM'); }); } -); +);
1
/* jshint expr:true */ import {expect} from 'chai'; import { describeComponent, it } from 'ember-mocha'; describeComponent( 'gh-editor-save-button', 'Unit: Component: gh-editor-save-button', { unit: true, needs: [ 'component:gh-dropdown-button', 'component:gh...
1
7,552
@disordinary would you be able to configure your editor to use the `.editorconfig` file so that we can avoid final newline changes?
TryGhost-Admin
js
@@ -80,12 +80,9 @@ module.exports = function(realmConstructor, context) { const { DefaultNetworkTransport } = require('realm-network-transport'); realmConstructor._networkTransport = new DefaultNetworkTransport(); - Object.defineProperty(realmConstructor.Object.prototype, "toJSON", { - value: func...
1
//////////////////////////////////////////////////////////////////////////// // // Copyright 2016 Realm Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
18,955
I really think we should not use this style where unused arguments are named with underscore. While this eases the person writing the function it does it at an expense of readability and debugging. So next person who needs to actually use this argument will need to check the spec and rename this to `obj` and then use i...
realm-realm-js
js
@@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[]) // setup log4cxx QRLogger::initLog4cxx(QRLogger::QRL_LOB); // initialize lob globals - lobGlobals = new ExLobGlobals(); + lobGlobals = new ExLobGlobals(NULL); if (lobGlobals == NULL) return -1;
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
19,630
Thanks for avoiding the default value for the param. But, I think sending heap as NULL might make this program to fail. Have you tested this program? If you have tested this program already, then this PR is ready to be merged.
apache-trafodion
cpp
@@ -0,0 +1,18 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MS-PL license. +// See the LICENSE file in the project root for more information. + +using MvvmCross.Presenters.Attributes; +using Windows.UI.Xaml.Controls; + +namespace MvvmCr...
1
1
14,600
Don't make it sealed
MvvmCross-MvvmCross
.cs
@@ -278,6 +278,8 @@ func (a *Account) shallowCopy() *Account { } // JetStream na.jsLimits = a.jsLimits + // Server config account limits. + na.limits = a.limits return na }
1
// Copyright 2018-2021 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
14,286
Did we miss that for jwt before?
nats-io-nats-server
go
@@ -44,10 +44,10 @@ const ( // UART1 on the Trinket M0. var ( - UART1 = UART{Bus: sam.SERCOM1_USART, + UART1 = UART{ Buffer: NewRingBuffer(), - Mode: PinSERCOM, - IRQVal: sam.IRQ_SERCOM1, + Bus: sam.SERCOM0_USART, + SERCOM: 0, } )
1
// +build sam,atsamd21,trinket_m0 package machine import "device/sam" // used to reset into bootloader const RESET_MAGIC_VALUE = 0xf01669ef // GPIO Pins const ( D0 = PA08 // PWM available D1 = PA02 D2 = PA09 // PWM available D3 = PA07 // PWM available / UART0 RX D4 = PA06 // PWM available / UART0 TX D13 ...
1
7,821
It appears that using SERCOM1 was a bug: the only SERCOM that is supported on the TX/RX pins is SERCOM0. Previous UART support wouldn't have worked on the Trinket M0 TX/RX pins anyway (`PA06`/`PA07`). This PR fixes that, and should thereby add support for UART on the Trinket M0.
tinygo-org-tinygo
go
@@ -179,7 +179,8 @@ class Preference extends Model public function getLocaleOptions() { $localeOptions = [ - 'be' => [Lang::get('system::lang.locale.be'), 'flag-by'], + 'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'], + 'be' => [Lang::get('system::lang.locale.be'),...
1
<?php namespace Backend\Models; use App; use Lang; use Model; use Config; use Session; use BackendAuth; use DirectoryIterator; use DateTime; use DateTimeZone; use Carbon\Carbon; /** * Backend preferences for the backend user * * @package october\backend * @author Alexey Bobkov, Samuel Georges */ class Preference...
1
12,889
Spaces for indentation, not tabs
octobercms-october
php
@@ -117,15 +117,11 @@ cvdescriptorset::DescriptorSetLayoutDef::DescriptorSetLayoutDef(const VkDescript assert(bindings_.size() == binding_count_); assert(binding_flags_.size() == binding_count_); uint32_t global_index = 0; - binding_to_global_index_range_map_.reserve(binding_count_); - // Vector or...
1
/* Copyright (c) 2015-2019 The Khronos Group Inc. * Copyright (c) 2015-2019 Valve Corporation * Copyright (c) 2015-2019 LunarG, Inc. * Copyright (C) 2015-2019 Google Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You m...
1
10,966
doing this as a binding map was insane, but with the ConstBindingIterator to hide the binding->index gunk and avoid the hashes during access it sticks out.
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -27,6 +27,8 @@ TEST_EVENT_PATTERN = { 'Detail': [EVENT_DETAIL] } +TEST_EVENT_PATTERN_1 = {'detail': {'EventType': ['0', '1']}} + class EventsTest(unittest.TestCase): def setUp(self):
1
# -*- coding: utf-8 -*- import os import json import uuid import unittest from localstack import config from localstack.utils import testutil from localstack.utils.aws import aws_stack from localstack.utils.common import ( load_file, retry, short_uid, get_free_tcp_port, wait_for_port_open, to_str, get_service_proto...
1
12,413
nitpick: I'd rather move this into the test method directly (we should avoid variables at the root scope if they are not reused in multiple places). (not critical, though - shouldn't hold back the merge..)
localstack-localstack
py
@@ -212,7 +212,12 @@ namespace TestPerf // Note: tests in the "TestPerf" namespace only run when the { RunUI(() => importPeptideSearchDlg.ClickNextButtonNoCheck()); } - // Modifications are already set up, so that page should get skipped. + // Skip Match ...
1
/* * Original author: Brian Pratt <bspratt .at. u.washington.edu>, * MacCoss Lab, Department of Genome Sciences, UW * * Copyright 2016 University of Washington - Seattle, WA * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in complian...
1
14,200
You should do: AssertEx.AreEqual(importPeptideSearchDlg.CurrentPage, ImportPeptideSearchDlg.Pages.match_modifications_page);
ProteoWizard-pwiz
.cs
@@ -145,7 +145,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask { String schemaId = entry.getKey(); String content = entry.getValue(); GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas); - boolean exists = existSchema != null; + boolean exists = e...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,557
SC support batch register schemas we should swtich to new api be careful that maybe will send too big request, need to split to multi request by max size of limit.
apache-servicecomb-java-chassis
java
@@ -25,8 +25,8 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) { if err != nil { return nil, fmt.Errorf("could not read version from GOROOT (%v): %v", goroot, err) } - if major != 1 || minor < 11 || minor > 14 { - return nil, fmt.Errorf("requires go version 1.11, 1.12, 1.13, or 1.14...
1
package builder import ( "errors" "fmt" "github.com/tinygo-org/tinygo/compileopts" "github.com/tinygo-org/tinygo/goenv" ) // NewConfig builds a new Config object from a set of compiler options. It also // loads some information from the environment while doing that. For example, it // uses the currently active G...
1
10,426
At this point, maybe it would make more sense to write this as a range rather than listing specific versions?
tinygo-org-tinygo
go
@@ -255,6 +255,11 @@ func (p Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) { return http.StatusRequestEntityTooLarge, backendErr } + // TODO: write an 499 HTTP status as constant in someplace (and also change in proxy_test.go on line: expectedStatus, expectErr := 499, context.Canceled)...
1
// Copyright 2015 Light Code Labs, LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
12,741
I guess we can start by putting the `const StatusContextCancelled = 499` at the bottom of this file
caddyserver-caddy
go
@@ -100,6 +100,7 @@ func TestPaymentChannelVoucher(t *testing.T) { types.NewChannelID(5), types.NewAttoFILFromFIL(10), types.NewBlockHeight(0), + nil, ) require.NoError(err) assert.Equal(expectedVoucher.Channel, voucher.Channel)
1
package porcelain_test import ( "context" "testing" cbor "github.com/ipfs/go-ipld-cbor" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "github.com/filecoin-project/go-filecoin/actor" "github.com/filecoin-project/go-filecoin/actor/builtin/paymentbroker" "github.com/filecoin-project...
1
18,741
Blocking: populate a non-empty value and check it below.
filecoin-project-venus
go
@@ -194,7 +194,14 @@ public class Permission { // Users with this permission can upload projects when the property "lockdown.upload.projects" // is turned on UPLOADPROJECTS(0x0008000), - ADMIN(0x8000000); + ADMIN(0x8000000), + // Permissions for image management APIs. + CREATE(0x0000100), + ...
1
/* * Copyright 2012 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
20,741
What is this number value for? How is it used?
azkaban-azkaban
java
@@ -192,6 +192,11 @@ describe Travis::Build::Script::R, :sexp do assert: true, echo: true, retry: true, timing: true] end + it 'does BiocCheck if requested' do + data[:config][:bioc_check] = true + should include_sexp [:cmd, /.*BiocCheck.*/, + as...
1
require 'spec_helper' describe Travis::Build::Script::R, :sexp do let (:data) { payload_for(:push, :r) } let (:script) { described_class.new(data) } subject { script.sexp } it { store_example } it_behaves_like 'a build script sexp' it 'normalizes bioc-devel correctly' do pending('k...
1
16,119
This needs an end keyword
travis-ci-travis-build
rb
@@ -0,0 +1,17 @@ +// <copyright file="DependencyTelemetryData.cs" company="Datadog"> +// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. +// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. +// </copy...
1
1
25,725
I think this is the first record type in Datadog.Trace!
DataDog-dd-trace-dotnet
.cs
@@ -737,10 +737,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http { return Task.CompletedTask; } - else - { - return FireOnCompletedAwaited(onCompleted); - } + return FireOnCompletedAwaited(onComple...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Buffers; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.IO.Pipelines; using System...
1
14,823
Nit: missing newline above.
aspnet-KestrelHttpServer
.cs
@@ -76,6 +76,13 @@ func StartKubeProxy(k8s kubernetes.Interface, hostname string, } go func() { + // Before we start, scan for all finished / timed out connections to + // free up the conntrack table asap as it may take time to sync up the + // proxy and kick off the first full cleaner scan. + lc := conntrack...
1
// Copyright (c) 2020 Tigera, Inc. All rights reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
18,281
Since it's a one-off, worth putting an info log before and after.
projectcalico-felix
go
@@ -140,8 +140,10 @@ app.controller('CalController', ['$scope', 'Calendar', 'CalendarService', 'VEven $scope.$apply(); }); } else { - $scope.calendarsPromise = CalendarService.getPublicCalendar(constants.publicSharingToken).then(function(calendar) { - $scope.calendars = [calendar]; + constants.public...
1
/** * Calendar App * * @author Raghu Nayyar * @author Georg Ehrke * @copyright 2016 Raghu Nayyar <hey@raghunayyar.com> * @copyright 2016 Georg Ehrke <oc.list@georgehrke.com> * * This library is free software; you can redistribute it and/or * modify it under the terms of the GNU AFFERO GENERAL PUBLIC LICENSE *...
1
6,324
I'm sorry, but the indentation is still wrong. This should be indented by one tab.
nextcloud-calendar
js
@@ -360,6 +360,18 @@ class DataFrame(_Frame): self._sdf = sdf self._metadata = self._metadata.copy(column_fields=names) + @property + def dtypes(self): + """Return the dtypes in the DataFrame. + + This returns a Series with the data type of each column. The result's index is the ...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
8,492
can we add an example?
databricks-koalas
py
@@ -156,6 +156,13 @@ func identifyUID(ctx context.Context, nug normalizedUsernameGetter, func identifyUser(ctx context.Context, nug normalizedUsernameGetter, identifier identifier, username libkb.NormalizedUsername, uid keybase1.UID, isPublic bool) error { + + // check to see if identify should be skipped altogeth...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "errors" "fmt" "sync" "github.com/keybase/client/go/libkb" "github.com/keybase/client/go/protocol/keybase1" "golang.org/x/net/context" ...
1
16,329
We usually avoid blank lines at the start of functions.
keybase-kbfs
go
@@ -0,0 +1,18 @@ +<?php + +declare(strict_types=1); + +/* + * This file is part of the Sonata Project package. + * + * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> + * + * For the full copyright and license information, please view the LICENSE + * file that was distributed with this source code. + */ + +use Sym...
1
1
12,569
I dont think this line is needed
sonata-project-SonataMediaBundle
php
@@ -22,7 +22,12 @@ const ( // requests w.r.t a single Volume. func (s *HTTPServer) volumeSpecificRequest(resp http.ResponseWriter, req *http.Request) (interface{}, error) { // check the feature gate & switch if enabled - if util.CASTemplateFeatureGate() { + feature, err := util.CASTemplateFeatureGate() + if err != ...
1
package server import ( "fmt" "net/http" "strings" "github.com/golang/glog" "github.com/openebs/maya/pkg/util" "github.com/openebs/maya/types/v1" policies_v1 "github.com/openebs/maya/volume/policies/v1" "github.com/openebs/maya/volume/provisioners" ) const ( // NamespaceKey is used in request headers to get...
1
8,720
We should not panic here !!! We return error i.e. 500 http code
openebs-maya
go
@@ -1305,8 +1305,16 @@ nano: use nanosecond-precision (requires libpcap >= 1.5.0) else: pkt = pkt.__iter__() for p in pkt: + if not self.header_present: self._write_header(p) + + if self.linktype != conf.l2types.get(ty...
1
# This file is part of Scapy # See http://www.secdev.org/projects/scapy for more information # Copyright (C) Philippe Biondi <phil@secdev.org> # This program is published under a GPLv2 license """ General utility functions. """ from __future__ import absolute_import from __future__ import print_function from decimal ...
1
16,116
To avoid useless calls to `conf.l2types.get()` we could have a `set()` of types that are OK in this PCAP files. We could check if `p.__class__ not in self.l2_types_seen` first, only run this code block in that case, and add `self.l2_types_seen.add(p.__class__)`. I'm not sure if I'm clear here... let me know what you th...
secdev-scapy
py
@@ -129,6 +129,11 @@ public class Constants { // Used (or should be used) wherever a string representation of UTF_8 charset is needed: public static final String UTF_8 = java.nio.charset.StandardCharsets.UTF_8.toString(); + // Specifies the source(adhoc, scheduled, flow_trigger) from where flow execution is tr...
1
/* * Copyright 2018 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
19,792
Shouldn't "source" be a noun? How about? -EXECUTION_SOURCE_USER -EXECUTION_SOURCE_SCHEDULE -EXECUTION_SOURCE_EVENT (because it's an event based trigger mechanism)
azkaban-azkaban
java
@@ -1,6 +1,6 @@ _base_ = [ '../_base_/models/mask_rcnn_r50_fpn.py', - '../_base_/datasets/coco_instance.py', + '../_base_/datasets/lvis_v1_instance.py', '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py' ] model = dict(
1
_base_ = [ '../_base_/models/mask_rcnn_r50_fpn.py', '../_base_/datasets/coco_instance.py', '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py' ] model = dict( roi_head=dict( bbox_head=dict( num_classes=1203, cls_predictor_cfg=dict(type='NormedLinear', tem...
1
26,796
Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.
open-mmlab-mmdetection
py
@@ -24,6 +24,8 @@ describe('th-has-data-cells', function () { '<table>' + ' <tr> <th>hi</th> <td>hello</td> </tr>' + ' <tr> <th>hi</th> <td>hello</td> </tr>' + + ' <tr> <td>hello</td> <th>hi</th> </tr>' + + ' <tr> <td>hello</td> <th>hi</th> </tr>' + '</table>'; var node = fixture.querySelec...
1
describe('th-has-data-cells', function () { 'use strict'; var fixture = document.getElementById('fixture'); var checkContext = { _relatedNodes: [], _data: null, data: function (d) { this._data = d; }, relatedNodes: function (rn) { this._relatedNodes = rn; } }; afterEach(function () { fixture....
1
10,955
Last time I checked, this technique did not work on all major screen reader - browser combinations. What screen readers have you tested?
dequelabs-axe-core
js
@@ -180,6 +180,8 @@ namespace Datadog.Trace.Configuration TraceBatchInterval = source?.GetInt32(ConfigurationKeys.SerializationBatchInterval) ?? 100; + + AspnetRouteTemplateResourceNamesEnabled = IsFeatureFlagEnabled(ConfigurationKeys.FeatureFlags.AspnetRouteTemplateRe...
1
using System; using System.Collections.Concurrent; using System.Collections.Generic; using System.Linq; using System.Text.RegularExpressions; using Datadog.Trace.PlatformHelpers; using Datadog.Trace.Util; using Datadog.Trace.Vendors.Serilog; namespace Datadog.Trace.Configuration { /// <summary> /// Contains Tr...
1
19,401
Most tracer settings can be set in several ways: environment variables, `app.config`/`web.config` file, or in a json file (`~/datadog.json` by default). Most exceptions to this rule are settings in native code (where we use env vars only). Currently, `DD_TRACE_ASPNET_ROUTE_TEMPLATE_RESOURCE_NAMES_ENABLED` will only wor...
DataDog-dd-trace-dotnet
.cs
@@ -218,4 +218,10 @@ type Config struct { // TaskMetadataBurstRate specifies the burst rate throttle for the task metadata endpoint TaskMetadataBurstRate int + + // NoIID when set to true, specifies that the agent should not register the instance + // with instance identity document. This is required in order to ...
1
// Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
20,076
Would "DisableIID" be a better name? For example, we used DisableMetrics, ImageCleanupDisabled, ... etc. for other similar fields.
aws-amazon-ecs-agent
go
@@ -3908,7 +3908,7 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb) BBPRINT(bb, 3, "reached end pc " PFX ", stopping\n", bb->stop_pc); break; } - if (total_instrs > DYNAMO_OPTION(max_bb_instrs)) { + if (total_instrs == DYNAMO_OPTION(max_bb_instrs) - 1) { ...
1
/* ********************************************************** * Copyright (c) 2011-2021 Google, Inc. All rights reserved. * Copyright (c) 2001-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
24,506
So this is a swing of 2: but I think we only need to reduce by 1? The artificial jump added on truncation is not passed to clients: it's like other mangling added later. So if `-max_bb_instrs 4` means 4 app instrs passed to clients, we'd want ==, not ==-1, right? Plus, if we did want -1 and to stop at 3 instead of 4, t...
DynamoRIO-dynamorio
c
@@ -362,7 +362,7 @@ LmExprResult CreateLmOutputExpr(const NAType &formalType, // specified type t to be converted to/from C strings. The only // SQL types that do not need to be converted to C strings are: // -// INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION +// INT, SMALLINT, LARGEINT, FLOAT, REAL, DOU...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
15,408
Does Tinyint belong to this set of types? I suppose the answer is No, but thought it safer to check.
apache-trafodion
cpp
@@ -1110,6 +1110,17 @@ Blockly.WorkspaceSvg.prototype.isDeleteArea = function(e) { return Blockly.DELETE_AREA_NONE; }; +/** + * Is the mouse event outside the blocks UI, to the right of the workspace? + * @param {!Event} e Mouse move event. + * @return {boolean} True if event is outside the blocks UI. + */ +Block...
1
/** * @license * Visual Blocks Editor * * Copyright 2014 Google Inc. * https://developers.google.com/blockly/ * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apach...
1
9,093
I'm a bit leery of this implementation, because it assumes that the only "outside" is to the right side. Note that Blockly assumes that there's nothing useful to the "outside" of the toolbox, based on the configuration of the workspace, so it's not like we're doing the right thing either. I think this will break in RTL...
LLK-scratch-blocks
js
@@ -180,6 +180,7 @@ type Config struct { FailsafeOutboundHostPorts []ProtoPort `config:"port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail"` KubeNodePortRanges []numorstring.Port `config:"portrange-list;30000:32767"` + NatPortRange numorstring.Port `config:"portrange;;local"` ...
1
// Copyright (c) 2016-2018 Tigera, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by ap...
1
16,561
Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only
projectcalico-felix
go
@@ -2322,7 +2322,7 @@ bool DiscoveryDataBase::from_json( } // Add Participant - auto wit = writers_.insert(std::make_pair(guid_aux, dei)); + writers_.insert(std::make_pair(guid_aux, dei)); // Extra configurations for writers // Add writer to ...
1
// Copyright 2020 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
20,426
That's a tricky one, as the variable is indeed used in line 2346, which is a `logInfo` message that is not compiled unless `INTERNAL_DEBUG` is set or `CMAKE_BUILD_TYPE` is set to `Debug`. Our CI builds with `INTERNAL_DEBUG` to verify that all `logInfo` are correct, and thus we don't get the warning. The best is probabl...
eProsima-Fast-DDS
cpp
@@ -600,7 +600,7 @@ class L3PacketSocket(L2Socket): # type: (Packet) -> int iff = x.route()[0] if iff is None: - iff = conf.iface + iff = network_name(conf.iface) sdto = (iff, self.type) self.outs.bind(sdto) sn = self.outs.getsockname()
1
# This file is part of Scapy # See http://www.secdev.org/projects/scapy for more information # Copyright (C) Philippe Biondi <phil@secdev.org> # This program is published under a GPLv2 license """ Linux specific functions. """ from __future__ import absolute_import from fcntl import ioctl from select import select ...
1
19,620
I suspect L2Socket needs a similar change (line 502) for the case where `iface` is None (line 479)
secdev-scapy
py