patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -0,0 +1,3 @@ +ActiveAdmin.register LicensePermission do + permit_params :name, :description, :icon +end
1
1
9,107
Was this all that was needed to add CRUD operations for the LicensePermission model? :-)
blackducksoftware-ohloh-ui
rb
@@ -465,7 +465,7 @@ def installAddon(parentWindow, addonPath): prevAddon = None for addon in addonHandler.getAvailableAddons(): - if not addon.isPendingRemove and bundle.name==addon.manifest['name']: + if not addon.isPendingRemove and bundle.name.lower()==addon.manifest['name'].lower(): prevAddon=addon ...
1
#gui/addonGui.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2012-2018 NV Access Limited, Beqa Gozalishvili, Joseph Lee, Babbage B.V., Ethan Holliger import os import weakref import addonAPIVersion ...
1
24,758
Did you look for other locations that compare name? I expected there to be more.
nvaccess-nvda
py
@@ -47,6 +47,9 @@ public final class BaselineTesting implements Plugin<Project> { .findAny() .ifPresent(ignored -> enableJUnit5ForAllTestTasks(project)); }); + + // Never cache test tasks, until we work out the correct inputs for ETE / integratio...
1
/* * (c) Copyright 2019 Palantir Technologies Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless ...
1
7,107
There were some requests internally to allow users to opt out of this behaviour. We could expose a property that allows people to toggle ti
palantir-gradle-baseline
java
@@ -300,10 +300,11 @@ public class TestIndexWriterDelete extends LuceneTestCase { modifier.close(); dir.close(); } - + public void testDeleteAllNoDeadLock() throws IOException, InterruptedException { Directory dir = newDirectory(); - final RandomIndexWriter modifier = new RandomIndexWriter(ran...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,558
Nice -- this forced `merge-on-getReader/commit` to be used more often in this test?
apache-lucene-solr
java
@@ -221,6 +221,9 @@ type ConsensusParams struct { // sum of estimated op cost must be less than this LogicSigMaxCost uint64 + + // a precision for assets + SupportAssetsPrecision bool } // Consensus tracks the protocol-level settings for different versions of the
1
// Copyright (C) 2019 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) any l...
1
36,919
Instead of a `bool`, can we just call this `MaxAssetDecimals` and have it be a `uint8`/`uint16`/`uint32` whose value is 0 before the upgrade and 19 after (2**64 - 1 is 20 decimal digits)? We'll need to set a maximum value anyway, and that way there's only one new proto variable instead of two.
algorand-go-algorand
go
@@ -145,7 +145,10 @@ final class EntityRepository implements EntityRepositoryInterface if ($sortFieldIsDoctrineAssociation) { $sortFieldParts = explode('.', $sortProperty, 2); - $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]); + // ...
1
<?php namespace EasyCorp\Bundle\EasyAdminBundle\Orm; use Doctrine\ORM\QueryBuilder; use Doctrine\Persistence\ManagerRegistry; use EasyCorp\Bundle\EasyAdminBundle\Collection\FieldCollection; use EasyCorp\Bundle\EasyAdminBundle\Collection\FilterCollection; use EasyCorp\Bundle\EasyAdminBundle\Contracts\Orm\EntityReposit...
1
13,074
where `$aliases` is defined ? @javiereguiluz
EasyCorp-EasyAdminBundle
php
@@ -66,12 +66,9 @@ func (h *Handler) FetchJWTSVID(ctx context.Context, req *workload.JWTSVIDRequest var spiffeIDs []string identities := h.Manager.MatchingIdentities(selectors) if len(identities) == 0 { - telemetry_common.AddRegistered(counter, false) return nil, status.Errorf(codes.PermissionDenied, "no iden...
1
package workload import ( "bytes" "context" "crypto" "crypto/x509" "encoding/json" "errors" "fmt" "sync/atomic" "time" "github.com/golang/protobuf/jsonpb" structpb "github.com/golang/protobuf/ptypes/struct" "github.com/sirupsen/logrus" "github.com/spiffe/go-spiffe/proto/spiffe/workload" attestor "github...
1
11,836
what is the justification for the removal of the registered label? it doesn't seem to have high cardinality nor is it redundant. Seems useful to shed insight into understand situations where workloads aren't registered....
spiffe-spire
go
@@ -1835,3 +1835,7 @@ func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDepl DeploymentChain: dc, }, nil } + +func (a *WebAPI) ListEvents(ctx context.Context, req *webservice.ListEventsRequest) (*webservice.ListEventsResponse, error) { + return nil, status.Error(codes.Unimplemented, "Not...
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
24,564
`ctx` is unused in ListEvents
pipe-cd-pipe
go
@@ -101,6 +101,14 @@ public class SmartStoreTest extends SmartStoreTestCase { Assert.assertTrue("ENABLE_JSON1 flag not found in compile options", compileOptions.contains("ENABLE_JSON1")); } + /** + * Checking sqlcipher version + */ + @Test + public void testSQLCipherVersion() { + Assert.assertEquals("Wr...
1
/* * Copyright (c) 2011-present, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright noti...
1
17,255
We've had that test on iOS for years.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -37,7 +37,7 @@ namespace BenchmarkDotNet.Extensions .DontEnforcePowerPlan(); // make sure BDN does not try to enforce High Performance power plan on Windows // See https://github.com/dotnet/roslyn/issues/42393 - job = job.WithArguments(new Argument[] { new MsBui...
1
using System.Collections.Immutable; using System.IO; using BenchmarkDotNet.Columns; using BenchmarkDotNet.Configs; using BenchmarkDotNet.Diagnosers; using BenchmarkDotNet.Exporters.Json; using Perfolizer.Horology; using BenchmarkDotNet.Jobs; using BenchmarkDotNet.Reports; using System.Collections.Generic; using Report...
1
12,516
This is for creating binlog file for building bdn generated template project. I feel that it's may be helpful in general for bdn diagnostic purpose.
dotnet-performance
.cs
@@ -359,6 +359,18 @@ class QuteProc(testprocess.Process): else: self.send_cmd(':open ' + url) + def open_url(self, url, *, new_tab=False, new_window=False): + """Open the given url in qutebrowser.""" + if new_tab and new_window: + raise ValueError("new_tab and new_win...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2015-2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
14,378
Can you adjust `open_path` to simply call `path_to_url` and then `open_url` instead of duplicating the code?
qutebrowser-qutebrowser
py
@@ -24,10 +24,10 @@ import ( var logGraphsyncFetcher = logging.Logger("net.graphsync_fetcher") const ( - // Timeout for a single graphsync request (which may be for many blocks). - // We might prefer this timeout to scale with the number of blocks expected in the fetch, - // when that number is large. - requestTime...
1
package net import ( "context" "fmt" "time" blocks "github.com/ipfs/go-block-format" "github.com/ipfs/go-cid" "github.com/ipfs/go-graphsync" bstore "github.com/ipfs/go-ipfs-blockstore" logging "github.com/ipfs/go-log" "github.com/ipld/go-ipld-prime" ipldfree "github.com/ipld/go-ipld-prime/impl/free" cidlin...
1
21,500
I'm curious -- do we have information on the upper bound of the delay we would expect with high probability from a peer with no network issues? My intuition is that we want to set this as low as we can reasonably get away with before we start killing productive connections. My uninformed intuition is also that 10 secon...
filecoin-project-venus
go
@@ -44,7 +44,7 @@ public class SarOperation extends AbstractFixedCostOperation { } else { final int shiftAmountInt = shiftAmount.toInt(); - if (shiftAmountInt >= 256) { + if (shiftAmountInt >= 256 || shiftAmountInt < 0) { frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO); ...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
26,626
what happens if it's == 0
hyperledger-besu
java
@@ -27,10 +27,6 @@ module Bolt if @config['interpreters'] @config['interpreters'] = normalize_interpreters(@config['interpreters']) end - - if Bolt::Util.windows? && @config['run-as'] - raise Bolt::ValidationError, "run-as is not supported when using PowerShell" - ...
1
# frozen_string_literal: true require 'bolt/error' require 'bolt/config/transport/base' module Bolt class Config module Transport class Docker < Base OPTIONS = %w[ cleanup host interpreters service-url shell-command tmpdir tty ...
1
18,555
We could potentially log a message here instead that indicates the transport does not support `run-as` on Windows and will be ignored, just in case users expect it to and are surprised. Since it would _always_ be logged when using `--run-as` on Windows, even when the transport isn't being used, it would probably want t...
puppetlabs-bolt
rb
@@ -4,7 +4,7 @@ import ( neturl "net/url" "strings" - "github.com/bonitoo-io/go-sql-bigquery" + bigquery "github.com/bonitoo-io/go-sql-bigquery" "github.com/go-sql-driver/mysql" "github.com/influxdata/flux/codes" "github.com/influxdata/flux/dependencies/url"
1
package sql import ( neturl "net/url" "strings" "github.com/bonitoo-io/go-sql-bigquery" "github.com/go-sql-driver/mysql" "github.com/influxdata/flux/codes" "github.com/influxdata/flux/dependencies/url" "github.com/influxdata/flux/internal/errors" "github.com/snowflakedb/gosnowflake" ) // helper function to v...
1
16,781
Did we need this alias? Or is it just a holdout from development?
influxdata-flux
go
@@ -72,7 +72,7 @@ class EditTest < ActiveSupport::TestCase p.update_attributes(organization_id: org.id) edit = PropertyEdit.where(target: p, key: 'organization_id').first edit.project_id.must_equal p.id - edit.organization_id.must_equal org.id + edit.value.must_equal org.id.to_s end it 'tes...
1
require 'test_helper' class EditTest < ActiveSupport::TestCase before do @user = create(:account) @admin = create(:admin) project = create(:project, description: 'Linux') Edit.for_target(project).delete_all @edit = create(:create_edit, target: project) @previous_edit = create(:create_edit, va...
1
6,973
This should have failed before.
blackducksoftware-ohloh-ui
rb
@@ -56,7 +56,8 @@ namespace Datadog.Trace.Vendors.Serilog.Sinks.File "(?<" + PeriodMatchGroup + ">\\d{" + _periodFormat.Length + "})" + "(?<" + SequenceNumberMatchGroup + ">_[0-9]{3,}){0,1}" + Regex.Escape(_filenameSuffix) + - "$"); + "$",...
1
//------------------------------------------------------------------------------ // <auto-generated /> // This file was automatically generated by the UpdateVendors tool. //------------------------------------------------------------------------------ // Copyright 2013-2016 Serilog Contributors // // Licensed under the...
1
19,900
Slower construction, faster matching. I wonder if this will be noticeable in the relenv?
DataDog-dd-trace-dotnet
.cs
@@ -61,6 +61,9 @@ void ThroughputPublisher::DataPubListener::onPublicationMatched( if (info.status == MATCHED_MATCHING) { ++throughput_publisher_.data_discovery_count_; + std::cout << C_RED << "Pub: DATA Pub Matched " + << throughput_publisher_.data_discovery_count_ << "/" << throu...
1
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
17,843
I think that if `data_discovery_count_ > static_cast<int>(throughput_publisher_.subscribers_)`, then we should not proceed, since we have discovered some unexpected subscriber that can affect the test results. I'd change the comparison to `==` and have and `else if` contemplating the `>` case
eProsima-Fast-DDS
cpp
@@ -51,6 +51,7 @@ #include <iomanip> #include <stdexcept> #include <impl/Kokkos_Error.hpp> +#include <Cuda/Kokkos_Cuda_Error.hpp> //---------------------------------------------------------------------------- //----------------------------------------------------------------------------
1
/* //@HEADER // ************************************************************************ // // Kokkos v. 3.0 // Copyright (2020) National Technology & Engineering // Solutions of Sandia, LLC (NTESS). // // Under the terms of Contract DE-NA0003525 with NTESS, // the U.S. Govern...
1
23,626
Remove that include
kokkos-kokkos
cpp
@@ -130,6 +130,7 @@ class EasyAdminFormType extends AbstractType return function (Options $options, $value) { return array_replace(array( 'id' => sprintf('%s-%s-form', $options['view'], strtolower($options['entity'])), + 'class' => sprintf('%s-form', $options['view'...
1
<?php /* * This file is part of the EasyAdminBundle. * * (c) Javier Eguiluz <javier.eguiluz@gmail.com> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ namespace JavierEguiluz\Bundle\EasyAdminBundle\Form\Type; use JavierEguiluz\B...
1
10,006
IMO this should be defined in the form theme instead. This class should always be there. If the user configured additional css classes, it should be appended instead of replacing the `{view}-form` css class.
EasyCorp-EasyAdminBundle
php
@@ -36,6 +36,7 @@ import com.salesforce.androidsdk.auth.OAuth2.TokenEndpointResponse; import com.salesforce.androidsdk.rest.RestClient.AuthTokenProvider; import com.salesforce.androidsdk.rest.RestClient.ClientInfo; import com.salesforce.androidsdk.rest.RestRequest.RestMethod; +import com.salesforce.androidsdk.util.J...
1
/* * Copyright (c) 2011-present, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright noti...
1
15,880
These tests actually go to the server.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -147,6 +147,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests { var onStartingCalled = false; var onCompletedCalled = false; + var onCompleted = Task.Run(() => onCompletedCalled = true); var hostBuilder = TransportSelector.GetWebHostBuilde...
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.Linq; using System.Net; using System.Net.Http; u...
1
14,820
This test modification isn't correct. This task could run immediately and you wouldn't be able to tell if OnCompleted was called or not.
aspnet-KestrelHttpServer
.cs
@@ -20,11 +20,13 @@ export function setComponentProps(component, props, opts, context, mountAll) { if ((component.__ref = props.ref)) delete props.ref; if ((component.__key = props.key)) delete props.key; - if (!component.base || mountAll) { - if (component.componentWillMount) component.componentWillMount(); - }...
1
import { SYNC_RENDER, NO_RENDER, FORCE_RENDER, ASYNC_RENDER, ATTR_KEY } from '../constants'; import options from '../options'; import { extend } from '../util'; import { enqueueRender } from '../render-queue'; import { getNodeProps } from './index'; import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, remo...
1
11,921
I'd be open to loosening this check if it can help offset the size.
preactjs-preact
js
@@ -2017,6 +2017,9 @@ defaultdict(<class 'list'>, {'col..., 'col...})] Apply a function that takes pandas DataFrame and outputs pandas DataFrame. The pandas DataFrame given to the function is of a batch used internally. + See also `Transform and apply a function + <https://koalas.readt...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
14,980
I'm wondering which we should use, stable or latest?
databricks-koalas
py
@@ -25,7 +25,8 @@ public abstract class BftExtraDataCodec { protected enum EncodingType { ALL, EXCLUDE_COMMIT_SEALS, - EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER + EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER, + EXCLUDE_CMS // TODO-lucas How can we achieve this w/o changing the BftExtraDataCodec base class ...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
25,866
possibly extending EncodingType enum?
hyperledger-besu
java
@@ -26,6 +26,18 @@ describe "Selenium::WebDriver::TargetLocator" do end end + it "should switch to parent frame" do + driver.navigate.to url_for("iframes.html") + + iframe = driver.find_element(:tag_name => "iframe") + driver.switch_to.frame(iframe) + + driver.find_element(:name, 'login').should ...
1
require File.expand_path("../spec_helper", __FILE__) describe "Selenium::WebDriver::TargetLocator" do let(:wait) { Selenium::WebDriver::Wait.new } it "should find the active element" do driver.navigate.to url_for("xhtmlTest.html") driver.switch_to.active_element.should be_an_instance_of(WebDriver::Element...
1
11,085
I tested it only in Firefox (`./go //rb:firefox-test`)
SeleniumHQ-selenium
js
@@ -27,7 +27,7 @@ using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process; namespace OpenTelemetry.Exporter.Jaeger { - public class JaegerExporter : BaseExporter<Activity> + public class JaegerExporter : BaseExporter<Activity>, IProviderContainer<TracerProvider> { private readonly i...
1
// <copyright file="JaegerExporter.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache....
1
17,864
can we do this in the baseexporter itself? So that exporters just access this.Provider.Resource, and baseexporters take care of populating Provider?
open-telemetry-opentelemetry-dotnet
.cs
@@ -156,7 +156,9 @@ module.exports = function(grunt) { 'frontend/express/public/core/session-frequency/javascripts/countly.models.js', 'frontend/express/public/core/session-frequency/javascripts/countly.views.js', 'frontend/express/public/core/events/javasc...
1
module.exports = function(grunt) { grunt.initConfig({ eslint: { options: { configFile: './.eslintrc.json' }, target: ['./'] }, concat: { options: { separator: ';' }, dom: { ...
1
14,045
what is the difference between `/core/events/javascripts/countly.views.js` and `/core/events/javascripts/countly.events.views.js`
Countly-countly-server
js
@@ -16,6 +16,10 @@ axe.a11yCheck = function (context, options, callback) { options = {}; } + if (!('iframes' in options)) { + options.iframes = true; + } + var audit = axe._audit; if (!audit) { throw new Error('No audit configured');
1
/** * Starts analysis on the current document and its subframes * * @param {Object} context The `Context` specification object @see Context * @param {Array} options Optional RuleOptions * @param {Function} callback The function to invoke when analysis is complete; receives an array of `RuleResult`s */ ...
1
10,965
We should make sure this is also supported by `axe.run`. Perhaps moving it into run-rules would cover both API methods more easily?
dequelabs-axe-core
js
@@ -46,9 +46,9 @@ class MemoryBasedStorage(StorageBase): def set_record_timestamp(self, collection_id, parent_id, record, modified_field=DEFAULT_MODIFIED_FIELD, last_modified=None): - timestamp = self._bump_timestamp(collection_id, parent_id, recor...
1
import re import operator from collections import defaultdict from collections import abc import numbers from kinto.core import utils from kinto.core.decorators import synchronized from kinto.core.storage import ( StorageBase, exceptions, DEFAULT_ID_FIELD, DEFAULT_MODIFIED_FIELD, DEFAULT_DELETED_FIELD, MIS...
1
11,620
If the `MemoryBasedStorage` relies on a `self._bump_and_store_timestamp()`, then every child class will have to implement it. So it should not be prefixed with `_`. And should raise `NotImplementedError` etc. :)
Kinto-kinto
py
@@ -8,7 +8,6 @@ using System.Collections.Generic; namespace System.Diagnostics { - [MemoryDiagnoser] [BenchmarkCategory(Categories.Libraries)] public class Perf_Activity {
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using BenchmarkDotNet.Attributes; using MicroBenchmarks; using System.Collections.Generic; namespace System.Diagno...
1
12,054
why removed the MemoryDiagnoser attribute?
dotnet-performance
.cs
@@ -3939,7 +3939,16 @@ function getModelsMapForPopulate(model, docs, options) { foreignField = foreignField.call(doc); } - const ret = convertTo_id(utils.getValue(localField, doc)); + const localFieldPath = modelSchema.paths[localField]; + const localFieldGetters = localFieldPath ? localFieldPath...
1
'use strict'; /*! * Module dependencies. */ var Aggregate = require('./aggregate'); var ChangeStream = require('./cursor/ChangeStream'); var Document = require('./document'); var DocumentNotFoundError = require('./error').DocumentNotFoundError; var DivergentArrayError = require('./error').DivergentArrayError; var E...
1
13,822
Why do this instead of `localFieldPath.applyGetters(doc[localField], doc)` ?
Automattic-mongoose
js
@@ -186,15 +186,6 @@ SUBGRAPH_ISOMORPHISM_BADARG_TEST("Throws if match count is negative") { invalid_argument); } -SUBGRAPH_ISOMORPHISM_BADARG_TEST("Throws if match count is positive") { - REQUIRE_THROWS_AS( - (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_ty...
1
/******************************************************************************* * Copyright 2021 Intel Corporation * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.o...
1
31,175
Just for a check. Do you really want to delete this?
oneapi-src-oneDAL
cpp
@@ -10,8 +10,10 @@ import ( "context" "os" + "github.com/golang/protobuf/proto" "github.com/iotexproject/iotex-core/actpool" "github.com/iotexproject/iotex-core/blockchain" + "github.com/iotexproject/iotex-core/blockchain/action" "github.com/iotexproject/iotex-core/blocksync" "github.com/iotexproject/iote...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
12,056
github.com/golang/protobuf/proto group in next group
iotexproject-iotex-core
go
@@ -64,6 +64,7 @@ var rootSubcmdsDaemon = map[string]*cmds.Command{ "mining": miningCmd, "mpool": mpoolCmd, "orderbook": orderbookCmd, + "paych": paymentChannelCmd, "ping": pingCmd, "show": showCmd, "swarm": swarmCmd,
1
package commands import ( "context" "net" "os" "gx/ipfs/QmUf5GFfV2Be3UtSAPKDVkoRd1TwEBTmx9TSSCFGGjNgdQ/go-ipfs-cmds" cmdhttp "gx/ipfs/QmUf5GFfV2Be3UtSAPKDVkoRd1TwEBTmx9TSSCFGGjNgdQ/go-ipfs-cmds/http" "gx/ipfs/QmceUdzxkimdYsgtX733uNgzf1DLHyBKN6ehGSp85ayppM/go-ipfs-cmdkit" ) const ( // OptionAPI is the name of ...
1
12,155
Nit: what about just `pay`? Is there some other subcommand that would conflict with?
filecoin-project-venus
go
@@ -55,8 +55,13 @@ public class Scalars { if (!(input instanceof StringValue)) { throw new CoercingParseLiteralException("Value is not any Address : '" + input + "'"); } + String inputValue = ((StringValue) input).getValue(); + if (!inputValue.startsWith("0x")) { + ...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,834
Just for the sake of keeping things logically co-located, I'd like to see this functionality in `Quantity.java` which has a lot of utility methods related to this. Maybe a `static` method like `Quantity.isValid(String string)`?
hyperledger-besu
java
@@ -72,7 +72,7 @@ public abstract class FlinkTestBase extends AbstractTestBase { return tEnv; } - List<Object[]> sql(String query, Object... args) { + public List<Object[]> sql(String query, Object... args) { TableResult tableResult = getTableEnv().executeSql(String.format(query, args)); tableResu...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
26,653
How about use `protected` ?
apache-iceberg
java
@@ -32,6 +32,12 @@ func (ih *IntermediateHashes) WillUnloadBranchNode(prefixAsNibbles []byte, nodeH if len(prefixAsNibbles) == 0 || len(prefixAsNibbles)%2 == 1 { return } + + // special case. Store Account.Root for long time + if len(prefixAsNibbles) == common.HashLength*2 { + return + } + InsertCounter.Inc(1...
1
package state import ( "github.com/ledgerwatch/turbo-geth/common" "github.com/ledgerwatch/turbo-geth/common/dbutils" "github.com/ledgerwatch/turbo-geth/common/pool" "github.com/ledgerwatch/turbo-geth/ethdb" "github.com/ledgerwatch/turbo-geth/log" "github.com/ledgerwatch/turbo-geth/metrics" "github.com/ledgerwat...
1
21,470
Should it not be `common.HashLength*2 + common.IncarnationLength` ?
ledgerwatch-erigon
go
@@ -422,7 +422,8 @@ public class FlowRunner extends EventHandler implements Runnable { // If a job is seen as failed or killed due to failing SLA, then we set the parent flow to // FAILED_FINISHING - if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node.isKilledBySLA()...
1
/* * Copyright 2013 LinkedIn Corp * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in...
1
14,449
those change are done by save plugin.
azkaban-azkaban
java
@@ -37,7 +37,9 @@ public class MimeHeader { }; protected ArrayList<Field> mFields = new ArrayList<Field>(); - private String mCharset = null; + + // use UTF-8 as standard to prevent NullPointerExceptions + private String mCharset = "UTF-8"; public void clear() { mFields.clear();
1
package com.fsck.k9.mail.internet; import com.fsck.k9.helper.Utility; import java.io.BufferedWriter; import java.io.IOException; import java.io.OutputStream; import java.io.OutputStreamWriter; import java.nio.charset.Charset; import java.util.*; public class MimeHeader { private static final String[] EMPTY_STRI...
1
11,413
There were problems with NullPointerException and with german Umlauts in message titles (I know they're not allowed in the specifiation but they caused my K-9-Inbox to not work at all) I don't know if this is related to PGP/Mime
k9mail-k-9
java
@@ -0,0 +1,11 @@ +// <copyright file="IEvent.cs" company="Datadog"> +// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. +// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. +// </copyright> + +namespac...
1
1
21,551
This is an appsec concept right? Should it live in the Appsec namespace?
DataDog-dd-trace-dotnet
.cs
@@ -11,11 +11,10 @@ func main() { machine.I2C0.Configure(machine.I2CConfig{}) // Init BlinkM - machine.I2C0.WriteTo(0x09, []byte("o")) + machine.I2C0.WriteRegister(0x09, 'o', nil) version := []byte{0, 0} - machine.I2C0.WriteTo(0x09, []byte("Z")) - machine.I2C0.ReadFrom(0x09, version) + machine.I2C0.ReadRegist...
1
// Connects to an BlinkM I2C RGB LED. // http://thingm.com/fileadmin/thingm/downloads/BlinkM_datasheet.pdf package main import ( "machine" "time" ) func main() { machine.I2C0.Configure(machine.I2CConfig{}) // Init BlinkM machine.I2C0.WriteTo(0x09, []byte("o")) version := []byte{0, 0} machine.I2C0.WriteTo(0x0...
1
6,091
I'd personally recommend having the demo check for error, unless it's worthless.
tinygo-org-tinygo
go
@@ -582,7 +582,7 @@ public class DistributorTest { ); Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession(); - LOG.info(String.format("Firefox Session %d assigned to %s", i, chromeSession.getUri())); + LOG.finer(String.format("Firefox Session %d as...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,126
Since this is in a test, I imagine that the choice of `info` level was deliberate.
SeleniumHQ-selenium
rb
@@ -1,10 +1,10 @@ const Plugin = require('../../core/Plugin') const Translator = require('../../core/Translator') const dragDrop = require('drag-drop') -const Dashboard = require('./Dashboard') +const DashboardUI = require('./Dashboard') const StatusBar = require('../StatusBar') const Informer = require('../Inform...
1
const Plugin = require('../../core/Plugin') const Translator = require('../../core/Translator') const dragDrop = require('drag-drop') const Dashboard = require('./Dashboard') const StatusBar = require('../StatusBar') const Informer = require('../Informer') const { findAllDOMElements } = require('../../core/Utils') cons...
1
10,283
good call swapping these names! makes more sense this way i think
transloadit-uppy
js
@@ -13,8 +13,12 @@ import options from './options'; */ export function render(vnode, parentDom, replaceNode) { if (options._root) options._root(vnode, parentDom); - let oldVNode = replaceNode && replaceNode._children || parentDom._children; + let oldVNode = replaceNode && replaceNode._children || parentDom._chil...
1
import { EMPTY_OBJ, EMPTY_ARR } from './constants'; import { commitRoot, diff } from './diff/index'; import { createElement, Fragment } from './create-element'; import options from './options'; /** * Render a Preact virtual node into a DOM element * @param {import('./index').ComponentChild} vnode The virtual node to...
1
13,965
Maybe leaving this out will save some bytes as in let `let isHydrating = replaceNode === null`
preactjs-preact
js
@@ -298,6 +298,10 @@ class RustGenerator : public BaseGenerator { assert(!cur_name_space_); + // Generate imports for the global scope in case no namespace is used + // in the schema file. + GenNamespaceImports(0); + // Generate all code in their namespaces, once, because Rust does not // pe...
1
/* * Copyright 2018 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
14,831
Let's manually create one extra whitespace line here (code_ += "")
google-flatbuffers
java
@@ -138,6 +138,17 @@ func (bp *BucketPool) Count() uint64 { return bp.total.count } +// Construct returns a copy of the bucket pool +func (bp *BucketPool) Construct(enableSMStorage bool) *BucketPool { + pool := BucketPool{} + pool.enableSMStorage = enableSMStorage + pool.total = &totalAmount{ + amount: new(big.In...
1
// Copyright (c) 2020 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
22,199
nit: copy or clone
iotexproject-iotex-core
go
@@ -182,3 +182,14 @@ func (d Document) Decode(dec Decoder) error { } return decodeStruct(d.s, dec) } + +// RevisionOn returns whether or not we should write a revision value when we +// write a document. It could be either a map or a struct with a revision key or +// field named after revField. +func (d Document) ...
1
// Copyright 2019 The Go Cloud Development Kit Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
19,126
I think this can be called `HasField`, because that's what it's doing. It really is independent of revision.
google-go-cloud
go
@@ -16,7 +16,10 @@ import java.math.BigDecimal; import java.time.Year; import java.util.function.Predicate; -import static javaslang.API.*; +import static javaslang.API.$; +import static javaslang.API.Case; +import static javaslang.API.Match; +import static javaslang.API.run; import static javaslang.MatchTest_Deve...
1
/* / \____ _ _ ____ ______ / \ ____ __ _______ * / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG * _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io * /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ...
1
9,456
Is this to avoid collisions?
vavr-io-vavr
java
@@ -79,7 +79,7 @@ func MakeTransactionPool(ledger *ledger.Ledger, cfg config.Local) *TransactionPo expiredTxCount: make(map[basics.Round]int), ledger: ledger, statusCache: makeStatusCache(cfg.TxPoolSize), - logStats: cfg.EnableAssembleStats, + logStats: cfg.EnableProcessBlockStats...
1
// Copyright (C) 2019-2020 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
38,134
nit: a better name for this variable would be enableLogStats, but it's beyond the scope of your change.
algorand-go-algorand
go
@@ -256,7 +256,6 @@ class CheckerTestCase(object): # Init test_reporter = TestReporter() linter = PyLinter(pylint.config.Configuration()) -linter.set_reporter(test_reporter) linter.config.persistent = 0 checkers.initialize(PluginRegistry(linter))
1
# Copyright (c) 2012-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr> # Copyright (c) 2012 FELD Boris <lothiraldan@gmail.com> # Copyright (c) 2013-2017 Claudiu Popa <pcmanticore@gmail.com> # Copyright (c) 2013-2014 Google, Inc. # Copyright (c) 2013 buck@yelp.com <buck@yelp.com> # Copyright (c) 2014 LCD 47 <lcd047...
1
9,902
Because linters don't handle reports now, this was breaking the setup for _all_ tests. I deleted it so I could run my tests, but I didn't check the impact on other tests as many tests are failing at the moment.
PyCQA-pylint
py
@@ -138,6 +138,12 @@ func main() { updateCommand, } app.Before = func(context *cli.Context) error { + + // do nothing if logrus was already initialized in init.go + if logrus.StandardLogger().Out != logrus.New().Out { + return nil + } + if context.GlobalBool("debug") { logrus.SetLevel(logrus.DebugLev...
1
package main import ( "fmt" "io" "os" "strings" "github.com/opencontainers/runtime-spec/specs-go" "github.com/sirupsen/logrus" "github.com/urfave/cli" ) // version will be populated by the Makefile, read from // VERSION file of the source code. var version = "" // gitCommit will be the hash that the binary ...
1
16,700
I'm not really a fan of this -- why not set up logging for `init` here (or setting a global flag) rather than doing it this way?
opencontainers-runc
go
@@ -1,4 +1,14 @@ -/* global axe */ +/** + * Namespace `axe.imports` which holds required external dependencies + * + * @namespace imports + * @memberof axe + */ +export { default as axios } from 'axios'; +export { CssSelectorParser } from 'css-selector-parser'; +export { default as doT } from '@deque/dot'; +export { de...
1
/* global axe */ /** * Note: * This file is run via browserify to pull in the required dependencies. * See - './build/imports-generator' */ /** * Polyfill `Promise` * Reference: https://www.npmjs.com/package/es6-promise */ if (!('Promise' in window)) { require('es6-promise').polyfill(); } /** * Polyfill req...
1
15,088
This is my favorite part of this PR. Being able to `import` 3rd party tools will hugely improve our workflows. :heart:
dequelabs-axe-core
js
@@ -0,0 +1,19 @@ +/** + * BSD-style license; for more info see http://pmd.sourceforge.net/license.html + */ + +package net.sourceforge.pmd.lang.java.rule.multithreading; + +import java.security.MessageDigest; + +/** + * Using a MessageDigest which is static can cause + * unexpected results when used in a multi-threaded...
1
1
16,311
having this extend `UnsynchronizedStaticFormatterRule` seems semantically incorrect even if it works we should probably refactor `UnsynchronizedStaticFormatterRule` into a `UnsynchronizedStaticAccessRule` which can be configured through properties to track unsynchronized static access to any given types (with proper d...
pmd-pmd
java
@@ -126,6 +126,8 @@ namespace Nethermind.Synchronization.ParallelSync } public long FindBestHeader() => _blockTree.BestSuggestedHeader?.Number ?? 0; + + public Keccak FindBestHeaderHash() => _blockTree.BestSuggestedHeader?.Hash ?? Keccak.Zero; public long FindBestFullBlock(...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
24,152
Keccak.Zero should not be used to mean null
NethermindEth-nethermind
.cs
@@ -40,5 +40,12 @@ namespace OpenTelemetry.Metrics.Tests new object[] { "my_metric2" }, new object[] { new string('m', 63) }, }; + + public static IEnumerable<object[]> InvalidHistogramBounds + => new List<object[]> + { + ...
1
// <copyright file="MetricsTestData.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache...
1
22,389
perhaps add a couple more edge cases.
open-telemetry-opentelemetry-dotnet
.cs
@@ -4,11 +4,15 @@ package Example import "strconv" +/// Composite components of Monster color. type Color byte const ( ColorRed Color = 1 + /// \brief color Green + /// Green is bit_flag with value (1u << 1) ColorGreen Color = 2 + /// \brief color Blue (1u << 3) ColorBlue Color = 8 )
1
// Code generated by the FlatBuffers compiler. DO NOT EDIT. package Example import "strconv" type Color byte const ( ColorRed Color = 1 ColorGreen Color = 2 ColorBlue Color = 8 ) var EnumNamesColor = map[Color]string{ ColorRed: "Red", ColorGreen: "Green", ColorBlue: "Blue", } var EnumValuesColor = map...
1
15,961
Is this blank line needed, or typo?
google-flatbuffers
java
@@ -122,12 +122,6 @@ func (p *blockPrefetcher) run() { func (p *blockPrefetcher) request(priority int, kmd KeyMetadata, ptr BlockPointer, block Block, entryName string, doneCh, errCh chan<- struct{}) error { - if _, err := p.config.BlockCache().Get(ptr); err == nil { - return nil - } - if err := checkDataVersion(...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "io" "sort" "sync" "time" "github.com/keybase/client/go/logger" "github.com/keybase/kbfs/tlf" "github.com/pkg/errors" "golang.org/x/ne...
1
17,689
This was a major PitA to find: it was causing some huge goroutine leaks and unfinished prefetches.
keybase-kbfs
go
@@ -84,10 +84,8 @@ module Mongoid #:nodoc # # @since 2.1.8 def prohibited_methods - @prohibited_methods ||= MODULES.inject([]) do |methods, mod| - methods.tap do |mets| - mets << mod.instance_methods.map{ |m| m.to_sym } - end + @prohibited_methods ||= MODU...
1
# encoding: utf-8 module Mongoid #:nodoc module Components #:nodoc extend ActiveSupport::Concern # All modules that a +Document+ is composed of are defined in this # module, to keep the document class from getting too cluttered. included do extend ActiveModel::Translation extend Mongoid::...
1
9,488
you can use Enum#flat_map here.
mongodb-mongoid
rb
@@ -155,6 +155,7 @@ public class AbstractVmNode extends AbstractNode implements VmNode { */ @Deprecated public void dump(final String prefix, final boolean recurse, final Writer writer) { + @SuppressWarnings("PMD.CloseResource") final PrintWriter printWriter = writer instanceof PrintWrit...
1
package net.sourceforge.pmd.lang.vm.ast; /* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache Li...
1
16,250
Same potential FP: The stream is provided from outside (here as a method parameter), so we should not be responsible here to close it, should we?
pmd-pmd
java
@@ -26,11 +26,12 @@ Upcase::Application.configure do config.log_level = :info config.log_formatter = ::Logger::Formatter.new - config.middleware.use \ - Rack::SslEnforcer, - hsts: false, - strict: true, - redirect_to: "https://#{ENV["APP_DOMAIN"]}" + config.force_ssl = true + config.middleware.in...
1
require Rails.root.join('config/initializers/mail') Upcase::Application.configure do config.cache_classes = true config.consider_all_requests_local = false config.action_controller.perform_caching = true config.action_controller.asset_host = ENV.fetch("ASSET_HOST") config.assets.compile = false conf...
1
15,847
Put a comma after the last parameter of a multiline method call.
thoughtbot-upcase
rb
@@ -67,10 +67,8 @@ public class VerbsManager { output -> { final Value verbClass = (Value) output; - final Verb verb = verbClass.newInstance().as(Verb.class); - try { - verb.install(container); + ...
1
/* * Copyright (C) 2015-2017 PÂRIS Quentin * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is...
1
14,123
It seems like this is the only way to access javascript `static` methods from Java.
PhoenicisOrg-phoenicis
java
@@ -4,8 +4,6 @@ * A temporary workaround to ensure the same version of React * is always used across multiple entrypoints. * - * @private - * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License");
1
/** * WordPress Element shim. * * A temporary workaround to ensure the same version of React * is always used across multiple entrypoints. * * @private * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in c...
1
28,345
Why was this removed here?
google-site-kit-wp
js
@@ -4,12 +4,6 @@ package pslice -import "github.com/ethersphere/bee/pkg/swarm" - -func PSlicePeers(p *PSlice) []swarm.Address { - return p.peers -} - func PSliceBins(p *PSlice) []uint { return p.bins }
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package pslice import "github.com/ethersphere/bee/pkg/swarm" func PSlicePeers(p *PSlice) []swarm.Address { return p.peers } func PSliceBins(p *PSlice) []...
1
9,747
i am aware that you did not add these, but might i ask why we need these one-liner funcs instead of just exporting the struct fields in the first place?
ethersphere-bee
go
@@ -296,7 +296,7 @@ abstract class BaseTableScan implements TableScan { } requiredFieldIds.addAll(selectedIds); - return TypeUtil.select(schema, requiredFieldIds); + return TypeUtil.project(schema, requiredFieldIds); } else if (context.projectedSchema() != null) { return context....
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
40,620
I agree with this because it is the opposite of `GetProjectedIds` used above.
apache-iceberg
java
@@ -632,7 +632,7 @@ class InstanceAttribute(dict): 'disableApiTermination', 'instanceInitiatedShutdownBehavior', 'rootDeviceName', 'blockDeviceMapping', 'sourceDestCheck', - 'groupSet'] + 'groupSet', 'productCodes', 'ebsOpti...
1
# Copyright (c) 2006-2012 Mitch Garnaat http://garnaat.org/ # Copyright (c) 2010, Eucalyptus Systems, Inc. # Copyright (c) 2012 Amazon.com, Inc. or its affiliates. All Rights Reserved # # Permission is hereby granted, free of charge, to any person obtaining a # copy of this software and associated documentation files ...
1
11,404
add 'sriovNetSupport' also to this list
boto-boto
py
@@ -61,7 +61,9 @@ public class Preferences { } if ((newAccount != null) && newAccount.getAccountNumber() != -1) { accounts.put(newAccount.getUuid(), newAccount); - accountsInOrder.add(newAccount); + if (!accountsInOrder.contains(newAccount)) { + accoun...
1
package com.fsck.k9; import java.util.ArrayList; import java.util.Collection; import java.util.Collections; import java.util.HashMap; import java.util.LinkedList; import java.util.List; import java.util.Map; import android.content.Context; import android.util.Log; import com.fsck.k9.mail.store.RemoteStore; import c...
1
13,611
Code style issue: `if` body is not wrapped in braces.
k9mail-k-9
java
@@ -81,9 +81,8 @@ public class ItunesSearchFragment extends Fragment { if (result != null && result.size() > 0) { gridView.setVisibility(View.VISIBLE); txtvEmpty.setVisibility(View.GONE); - for (Podcast p : result) { - adapter.add(p); - } + + ...
1
package de.danoeh.antennapod.fragment; import android.content.Intent; import android.os.Bundle; import android.support.v4.app.Fragment; import android.support.v4.view.MenuItemCompat; import android.support.v7.widget.SearchView; import android.util.Log; import android.view.LayoutInflater; import android.view.Menu; impo...
1
13,041
Call requires API level 11 (we are on 10)
AntennaPod-AntennaPod
java
@@ -97,7 +97,7 @@ namespace Nethermind.AuRa.Test.Contract var gasLimitContract = new BlockGasLimitContract(new AbiEncoder(), blockGasLimitContractTransition.Value, blockGasLimitContractTransition.Key, new ReadOnlyTxProcessingEnv( DbProvider, - ...
1
// Copyright (c) 2021 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of...
1
25,088
do we need to pass the DB if it is the same
NethermindEth-nethermind
.cs
@@ -300,6 +300,14 @@ func (ccs *crChains) addOp(ptr BlockPointer, op op) error { } func (ccs *crChains) makeChainForOp(op op) error { + // Ignore gc ops -- their unref semantics differ from the other + // ops. Note that this only matters for old gcOps: new gcOps + // only unref the block ID, and not the whole poin...
1
// Copyright 2016 Keybase Inc. All rights reserved. // Use of this source code is governed by a BSD // license that can be found in the LICENSE file. package libkbfs import ( "fmt" "sort" "github.com/keybase/client/go/logger" "golang.org/x/net/context" ) // crChain represents the set of operations that happened...
1
12,719
Might be a good idea to rename the variable so it doesn't shadow the type.
keybase-kbfs
go
@@ -14,7 +14,13 @@ class Tag extends BaseItem { } static async noteIds(tagId) { - const rows = await this.db().selectAll('SELECT note_id FROM note_tags WHERE tag_id = ?', [tagId]); + // Get NoteIds of that are tagged with current tag or its descendants + const rows = await this.db().selectAll(`WITH RECURSIVE +...
1
const BaseModel = require('lib/BaseModel.js'); const BaseItem = require('lib/models/BaseItem.js'); const NoteTag = require('lib/models/NoteTag.js'); const Note = require('lib/models/Note.js'); const { _ } = require('lib/locale'); class Tag extends BaseItem { static tableName() { return 'tags'; } static modelType...
1
12,215
Again I'd prefer if this is done in JavaScript rather than in SQL.
laurent22-joplin
js
@@ -1848,7 +1848,7 @@ function fullyResolveKeys(obj) { * If there are no listeners registered with the flow, the error will be * rethrown to the global error handler. * - * Refer to the {@link ./promise} module documentation fora detailed + * Refer to the {@link ./promise} module documentation for a detailed ...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,750
there is still `2` spaces after `a` here.. :P
SeleniumHQ-selenium
java
@@ -25,6 +25,17 @@ import ( const defaultMountFlags = syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV +// setupDev returns true if /dev needs to be set up. +func needsSetupDev(config *configs.Config) (bool, error) { + setupDev := true + for _, m := range config.Mounts { + if m.Device == "bind" && m.Desti...
1
// +build linux package libcontainer import ( "fmt" "io" "io/ioutil" "os" "os/exec" "path" "path/filepath" "strings" "syscall" "time" "github.com/docker/docker/pkg/mount" "github.com/docker/docker/pkg/symlink" "github.com/opencontainers/runc/libcontainer/cgroups" "github.com/opencontainers/runc/libcont...
1
10,683
What we did in docker before, when working directly with libcontainer, is check if the source is `/dev` and the destination has a `/dev/` prefix. This implementation is probably ok. If someone is mounting their own `/dev` I would expect it to be pre-configured and not need the extra check for if it's the host's `/dev`....
opencontainers-runc
go
@@ -501,6 +501,10 @@ type Configuration struct { PleaseLocation string // buildEnvStored is a cached form of BuildEnv. buildEnvStored *storedBuildEnv + + FeatureFlags struct { + JavaBinaryExecutableByDefault bool `help:"Makes java_binary rules self executable by default. Target release version 16." var:"FF_JAVA_...
1
// Utilities for reading the Please config files. package core import ( "crypto/sha1" "fmt" "io" "os" "path" "path/filepath" "reflect" "runtime" "sort" "strconv" "strings" "sync" "time" "github.com/google/shlex" "github.com/jessevdk/go-flags" "github.com/peterebden/gcfg" "github.com/thought-machine...
1
9,266
you should add some help on the struct too so that `plz halp featureflags` has a bit of explanation. Might be worth mentioning that these generally won't remain around very long relative to other config options (i.e. they're typically enabling "preview" features for the next major).
thought-machine-please
go
@@ -302,7 +302,7 @@ func newSessionManagerFactory( nodeOptions node.Options, ) session.ManagerFactory { return func(dialog communication.Dialog) *session.Manager { - providerBalanceTrackerFactory := func(consumer, provider, issuer identity.Identity) (session.BalanceTracker, error) { + providerBalanceTrackerFacto...
1
/* * Copyright (C) 2018 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
13,593
Maybe `consumerID, receiverID, issuerID`, at least it's a convension in overal repo
mysteriumnetwork-node
go
@@ -14,6 +14,12 @@ // Package s3blob provides an implementation of blob using S3. // +// For blob.Open URLs, s3blob registers for the "s3" protocol. +// The URL's Host is used as the bucket name. +// The following query options are supported: +// - region: The AWS region for requests. +// Example URL: blob.Open("s3...
1
// Copyright 2018 The Go Cloud Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agr...
1
11,703
Where does the auth go?
google-go-cloud
go
@@ -119,7 +119,10 @@ func ClassifyActions(actions []SealedEnvelope) ([]*Transfer, []*Execution) { } func calculateIntrinsicGas(baseIntrinsicGas uint64, payloadGas uint64, payloadSize uint64) (uint64, error) { - if payloadGas == 0 || (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize { + if payloadGas == 0 {...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
24,111
0 < minimum gas price, `ErrUnderpriced` is more proper
iotexproject-iotex-core
go
@@ -12,7 +12,7 @@ from sqlalchemy import func from . import app, db from .const import (VALID_EMAIL_RE, VALID_USERNAME_RE, blacklisted_name, ACTIVATE_SALT, PASSWORD_RESET_SALT, MAX_LINK_AGE, - CODE_EXP_MINUTES) + CODE_EXP_MINUTES, TOKEN_EXP_DEFAULT) from .ma...
1
import base64 from datetime import datetime, timedelta import json import uuid from flask import redirect, request import itsdangerous import jwt from passlib.context import CryptContext from sqlalchemy import func from . import app, db from .const import (VALID_EMAIL_RE, VALID_USERNAME_RE, blacklisted_name, ...
1
16,860
these should be alphabetized
quiltdata-quilt
py
@@ -72,7 +72,7 @@ public class VectorizedDictionaryEncodedParquetValuesReader extends BaseVectoriz } void readBatchOfDictionaryEncodedLongs(FieldVector vector, int startOffset, int numValuesToRead, Dictionary dict, - NullabilityHolder nullabilityHolder) { + ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
18,276
These changes look concerning. It looks like the old offset (only index) must not have been correct. If so, there are places where `getDataBuffer().setLong(...)` and similar methods are called but aren't updated like these. Are those cases bugs as well?
apache-iceberg
java
@@ -164,7 +164,7 @@ type Counters struct { // flush writes the current state of in memory counters into the given db. func (cs *Counters) flush(db *shed.DB, batch *leveldb.Batch) error { - if cs.dirty.Load() > 1 { + if cs.dirty.Load() < 3 { return nil } cs.dirty.CAS(3, 2)
1
// Copyright 2021 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. // Package metrics provides service for collecting various metrics about peers. // It is intended to be used with the kademlia where the metrics are collecte...
1
15,321
the CAS call here is now wrong since dirty will never be 3 anymore. it might be useful to sweep through the entire usage of this field to see that everything is correct
ethersphere-bee
go
@@ -18,7 +18,11 @@ use Symfony\Component\Validator\Constraints\NotBlank; use Symfony\Component\Validator\Constraints\NotEqualTo; use Symfony\Component\Validator\ExecutionContextInterface; use Thelia\Core\Translation\Translator; +use Thelia\Model\Base\CountryQuery; use Thelia\Model\Base\LangQuery; +use Thelia\Model\...
1
<?php /*************************************************************************************/ /* This file is part of the Thelia package. */ /* */ /* Copyright (c) OpenStudio ...
1
10,094
Base model is imported here
thelia-thelia
php
@@ -16,6 +16,7 @@ */ package org.apache.servicecomb.serviceregistry.task; +import org.apache.servicecomb.foundation.common.event.EventManager; import org.apache.servicecomb.serviceregistry.RegistryUtils; import org.apache.servicecomb.serviceregistry.api.registry.Microservice; import org.apache.servicecomb.servi...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,508
import but not used
apache-servicecomb-java-chassis
java
@@ -193,7 +193,7 @@ public final class VectorizedParquetDefinitionLevelReader extends BaseVectorized case RLE: if (currentValue == maxDefLevel) { dictionaryEncodedValuesReader.readBatchOfDictionaryEncodedLongs(vector, - idx, numValues, dict, nullabilityHolder); + ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
18,275
What about the call in `case PACKED` just below? Does that also need to use the `typeWidth`?
apache-iceberg
java
@@ -8,13 +8,14 @@ import ( "errors" "github.com/ethersphere/bee/pkg/collection" + "github.com/ethersphere/bee/pkg/encryption" "github.com/ethersphere/bee/pkg/swarm" ) var ( _ = collection.Entry(&Entry{}) serializedDataSize = swarm.SectionSize * 2 - encryptedSerializedD...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package entry import ( "errors" "github.com/ethersphere/bee/pkg/collection" "github.com/ethersphere/bee/pkg/swarm" ) var ( _ ...
1
11,952
not sure i like this change. The encryption package does not need to know about references
ethersphere-bee
go
@@ -280,6 +280,7 @@ ifneq ($(MAKECMDGOALS),clean) ifeq ($(llvm_version),3.9.1) else ifeq ($(llvm_version),5.0.2) else ifeq ($(llvm_version),6.0.1) + else ifeq ($(llvm_version),7.0.0) # this is what is shipped with ubuntu bionic llvm-7 package right now else ifeq ($(llvm_version),7.0.1) else $(warni...
1
# Determine the operating system OSTYPE ?= ifeq ($(OS),Windows_NT) OSTYPE = windows else UNAME_S := $(shell uname -s) ifeq ($(UNAME_S),Linux) OSTYPE = linux ifndef AR ifneq (,$(shell which gcc-ar 2> /dev/null)) AR = gcc-ar endif endif ALPINE=$(wildcard /etc/alpine-release) ...
1
13,194
This shouldn't be added. It's not supported. It's not event the default. If we are going to support this, we need to have CI for it.
ponylang-ponyc
c
@@ -6,6 +6,5 @@ type API interface { Client() Client Daemon() Daemon Ping() Ping - RetrievalClient() RetrievalClient Swarm() Swarm }
1
// Package api holds the interface definitions for the Filecoin api. package api // API is the user interface to a Filecoin node. type API interface { Client() Client Daemon() Daemon Ping() Ping RetrievalClient() RetrievalClient Swarm() Swarm }
1
17,903
omg only four left!!!!
filecoin-project-venus
go
@@ -214,6 +214,12 @@ func (c *Client) InstallParticipationKeys(inputfile string) (part account.Partic return } + proto, ok := config.Consensus[protocol.ConsensusCurrentVersion] + if !ok { + err = fmt.Errorf("Unknown consensus protocol %s", protocol.ConsensusCurrentVersion) + return + } + // After successful ...
1
// Copyright (C) 2019 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) any l...
1
36,851
I'm not really sure how this would happen. once the binary is already compiled, the config.Consensus should already have the entry for protocol.ConsensusCurrentVersion.
algorand-go-algorand
go
@@ -160,7 +160,7 @@ class LuigiTestCase(unittest.TestCase): temp = CmdlineParser._instance try: CmdlineParser._instance = None - run_exit_status = luigi.run(['--local-scheduler', '--no-lock'] + args) + run_exit_status = luigi.run(args + ['--local-scheduler', '--no-lo...
1
# -*- coding: utf-8 -*- # # Copyright 2012-2015 Spotify AB # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law...
1
17,960
Is there a reason for the order swap here?
spotify-luigi
py
@@ -241,8 +241,9 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting } } - EqtTrace.Error("Unable to find path for dotnet host"); - return dotnetExeName; + string errorMessage = String.Format(Resources.NoDotnetDotExeFileExist, dotnetE...
1
// Copyright (c) Microsoft. All rights reserved. namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting { using System; using System.Collections.Generic; using System.Diagnostics; using System.IO; using System.Linq; using System.Runtime.InteropServices; using Microsoft.Visua...
1
11,382
Where will this exception get caught ?
microsoft-vstest
.cs
@@ -49,9 +49,10 @@ var mainEtherAccPass = "localaccount" type CliWallet struct { txOpts *bind.TransactOpts Owner common.Address - backend *ethclient.Client + Backend *ethclient.Client identityRegistry registry.IdentityRegistryTransactorSession tokens mysttoken.M...
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
11,642
Why this field is made public?
mysteriumnetwork-node
go
@@ -35,16 +35,16 @@ #include "proj_internal.h" #include "proj_internal.h" -static int is_nodata(float value) +static int is_nodata(float value, double vmultiplier) { /* nodata? */ /* GTX official nodata value if -88.88880f, but some grids also */ /* use other big values for nodata (e.g naptrans20...
1
/****************************************************************************** * Project: PROJ.4 * Purpose: Apply vertical datum shifts based on grid shift files, normally * geoid grids mapping WGS84 to NAVD88 or something similar. * Author: Frank Warmerdam, warmerdam@pobox.com * ******************...
1
10,244
Is the `vmultiplier` only used here for checking if a grid value is nodata?
OSGeo-PROJ
cpp
@@ -239,7 +239,7 @@ func signTestCert(key crypto.Signer) *x509.Certificate { SerialNumber: serialNumber, SignatureAlgorithm: x509.SHA256WithRSA, Subject: pkix.Name{ - Organization: []string{defaultOrganization}, + Organization: []string{"cert-manager"}, CommonName: commonName, }, No...
1
/* Copyright 2019 The Jetstack cert-manager contributors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed...
1
23,220
Is this deliberate? If so, why?
jetstack-cert-manager
go
@@ -5,7 +5,7 @@ from mitmproxy import exceptions from mitmproxy.net import tls as net_tls from mitmproxy.proxy.protocol import base -# taken from https://testssl.sh/openssl-rfc.mappping.html +# taken from https://testssl.sh/openssl-rfc.mapping.html CIPHER_ID_NAME_MAP = { 0x00: 'NULL-MD5', 0x01: 'NULL-MD5...
1
from typing import Optional # noqa from typing import Union from mitmproxy import exceptions from mitmproxy.net import tls as net_tls from mitmproxy.proxy.protocol import base # taken from https://testssl.sh/openssl-rfc.mappping.html CIPHER_ID_NAME_MAP = { 0x00: 'NULL-MD5', 0x01: 'NULL-MD5', 0x02: 'NULL-...
1
13,953
both URL works. I corrected it anyway.
mitmproxy-mitmproxy
py
@@ -43,12 +43,14 @@ import java.util.Collection; * @since 5.0 */ public class PrePostAdviceReactiveMethodInterceptor implements MethodInterceptor { - private Authentication anonymous = new AnonymousAuthenticationToken("key", "anonymous", - AuthorityUtils.createAuthorityList("ROLE_ANONYMOUS")); + private final Aut...
1
/* * Copyright 2002-2018 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by a...
1
15,633
Rather than have another member and and if/else statement, if the user passes in `PreInvocationAuthorizationAdvice` it could be adapted to match `PreInvocationAuthorizationReactiveAdvice`
spring-projects-spring-security
java
@@ -210,8 +210,7 @@ class Sync { /** * A callback passed to `Realm.App.Sync.setLogger` when instrumenting the Realm Sync client with a custom logger. * @callback Realm.App.Sync~logCallback - * @param {number} level The level of the log entry between 0 and 8 inclusively. - * Use this as an index...
1
//////////////////////////////////////////////////////////////////////////// // // Copyright 2016 Realm Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
19,568
The callback get the log level as a number.
realm-realm-js
js
@@ -71,6 +71,7 @@ setup( "hyperframe>=5.0, <6", "jsbeautifier>=1.6.3, <1.7", "kaitaistruct>=0.7, <0.8", + "ldap3>=2.2.0, <2.2.1", "passlib>=1.6.5, <1.8", "pyasn1>=0.1.9, <0.3", "pyOpenSSL>=16.0, <17.1",
1
import os import runpy from codecs import open from setuptools import setup, find_packages # Based on https://github.com/pypa/sampleproject/blob/master/setup.py # and https://python-packaging-user-guide.readthedocs.org/ here = os.path.abspath(os.path.dirname(__file__)) with open(os.path.join(here, 'README.rst'), en...
1
13,162
Is there any issue with 2.2.3? If not this should be `<2.3`.
mitmproxy-mitmproxy
py
@@ -1595,7 +1595,3 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils): # Only support for MultiIndex kser = ks.Series([10, -2, 4, 7]) self.assertRaises(ValueError, lambda: kser.unstack()) - - def test_item(self): - kser = ks.Series([10, 20]) - self.assertRaises(ValueError, ...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
15,237
Shall we keep this test?
databricks-koalas
py
@@ -102,12 +102,15 @@ class Tx_Solr_Backend_IndexingConfigurationSelectorField { /** * Renders a field to select which indexing configurations to initialize. * - * Uses TCEforms. + * Uses \TYPO3\CMS\Backend\Form\FormEngine. * * @return string Markup for the select field */ public function render()...
1
<?php /*************************************************************** * Copyright notice * * (c) 2013 Ingo Renner <ingo@typo3.org> * All rights reserved * * This script is part of the TYPO3 project. The TYPO3 project is * free software; you can redistribute it and/or modify * it under the terms of the GNU Genera...
1
5,454
When would this be the case? / When would SelectElement not be available? Is this change compatible with 6.2? (I'd like to roll a release that works with 6.2+ first, before moving on to 7.x)
TYPO3-Solr-ext-solr
php
@@ -257,6 +257,10 @@ public abstract class DataType implements Serializable { + ((long) (readBuffer[7] & 255) << 56)); } + public boolean isSameCatalog(DataType other) { + return false; + } + // all data should be read in little endian. public TiChunkColumnVector decodeChunkColumn(CodecDataInpu...
1
/* * Copyright 2017 PingCAP, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed ...
1
12,373
how about rename to shouldNarrowDataTypeTo?
pingcap-tispark
java
@@ -33,6 +33,9 @@ from .util import bokeh_version Store.renderers['bokeh'] = BokehRenderer.instance() +if len(Store.renderers) == 1: + Store.current_backend = 'bokeh' + associations = {Overlay: OverlayPlot, NdOverlay: OverlayPlot, GridSpace: GridPlot,
1
import numpy as np from ...core import (Store, Overlay, NdOverlay, Layout, AdjointLayout, GridSpace, GridMatrix, NdLayout) from ...element import (Curve, Points, Scatter, Image, Raster, Path, RGB, Histogram, Spread, HeatMap, Contours, Bars, Box, Boun...
1
17,175
Why not check that the one available renderer is 'bokeh'?
holoviz-holoviews
py