instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
bazelbuild/bazel/5307_5455 | bazelbuild/bazel | bazelbuild/bazel/5307 | bazelbuild/bazel/5455 | [
"timestamp(timedelta=0.0, similarity=0.8566144616384757)"
] | 88d1caeef07533429468515f63b3d4e2cb9a7a80 | 5b4462c434b2cf87a520abf15cf06926a63cd8d1 | [
"This is a reasonable feature request.\r\nShould be easy to implement."
] | [
"Why are we allocating a copy of the list here, only to throw it away?",
"Python allows only string or tuple-of-string here, not list of string, and so should we.",
"Done",
"Done",
"I believe we don't check the element type, that the `generic1` part of `ParamType` is just for documentation generation purpos... | 2018-06-23T00:15:24Z | [
"type: feature request",
"good first issue"
] | support passing tuples to str.startswith and str.endswith | Python supports passing a tuple to the first argument of `str.startswith` and `str.endswith` to allow testing multiple prefixes or suffixes in one go. I've now wanted this feature in Skylark a few times, so I'm formally submitting a request. | [
"src/main/java/com/google/devtools/build/lib/syntax/StringModule.java"
] | [
"src/main/java/com/google/devtools/build/lib/syntax/StringModule.java"
] | [
"src/test/skylark/testdata/string_misc.sky"
] | diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java b/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java
index e18c833097e384..2f2287911f31ff 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java
+++ b/src/main/java/com/google/devtools/build/li... | diff --git a/src/test/skylark/testdata/string_misc.sky b/src/test/skylark/testdata/string_misc.sky
index 901d7f3091ca7f..87708f9fae3b64 100644
--- a/src/test/skylark/testdata/string_misc.sky
+++ b/src/test/skylark/testdata/string_misc.sky
@@ -62,6 +62,26 @@ assert_eq('Apricot'.endswith('co', -1), False)
assert_eq('abc... | train | train | 2018-06-23T00:13:51 | 2018-06-01T01:52:04Z | benjaminp | test |
bazelbuild/bazel/5345_5650 | bazelbuild/bazel | bazelbuild/bazel/5345 | bazelbuild/bazel/5650 | [
"timestamp(timedelta=147727.0, similarity=0.8530386804142502)"
] | fc8b9bfe2fc81c0e264ba93a3f7f74e28f7c1643 | 7c97690869f17f8d60a4199f7b4aeebf6995c9e0 | [
"cc @katre",
"I think the only way to handle this will be to use two toolchain types: one for the bootstrapping, one for actual usage. If you write the implementation functions modularly, and use the same property names on the toolchain providers, you should be able to re-use a lot of code.\r\n\r\nI'm closing thi... | [] | 2018-07-21T15:44:18Z | [
"type: feature request",
"team-Configurability"
] | Support for execution-only "bootstrap" toolchains | ### Description of the problem / feature request:
I'd like to be able to define toolchains that only target the execution platform. This would be useful for bootstrap toolchains that build tools that run on the execution platform and are used in other toolchains.
### Feature requests: what underlying problem are ... | [
"src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java"
] | [
"src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java"
] | [
"src/test/shell/bazel/toolchain_test.sh"
] | diff --git a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java b/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
index 0ae17e2093b747..b2b56b9b3ada08 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/DependencyResolver.java
+++ b/src/main/java/com/... | diff --git a/src/test/shell/bazel/toolchain_test.sh b/src/test/shell/bazel/toolchain_test.sh
index 097e874641ca60..12b22f892e26f5 100755
--- a/src/test/shell/bazel/toolchain_test.sh
+++ b/src/test/shell/bazel/toolchain_test.sh
@@ -168,6 +168,25 @@ EOF
expect_log 'extra_str = "bar"'
}
+function test_toolchain_buil... | train | train | 2018-07-20T22:51:42 | 2018-06-07T19:01:48Z | jayconrod | test |
bazelbuild/bazel/5358_5363 | bazelbuild/bazel | bazelbuild/bazel/5358 | bazelbuild/bazel/5363 | [
"timestamp(timedelta=0.0, similarity=0.8992251828312009)"
] | c720152ec1936a537c9519d522d3cb41d19cff77 | b214aa6897a598fa7b1622cba5c1ffeb7a669c41 | [] | [] | 2018-06-11T12:03:59Z | [] | Broken link to mobile application tutorial in Java build tutorial | ### Description of the problem / feature request:
On the page https://docs.bazel.build/versions/master/tutorial/java.html, the link at the bottom of the page titled `mobile application tutorial` points to the URL https://docs.bazel.build/versions/master/tutorial/app.html but this page does not exist, so a 404 is dis... | [
"site/docs/tutorial/java.md"
] | [
"site/docs/tutorial/java.md"
] | [] | diff --git a/site/docs/tutorial/java.md b/site/docs/tutorial/java.md
index 4fbaefdbe7d19e..8352229a6b4adb 100644
--- a/site/docs/tutorial/java.md
+++ b/site/docs/tutorial/java.md
@@ -412,7 +412,8 @@ dependencies.
* The [C++ build tutorial](../tutorial/cpp.md) to get started with building
C++ projects with Bazel.
... | null | val | train | 2018-06-11T13:39:31 | 2018-06-09T18:24:00Z | karltk | test |
bazelbuild/bazel/5362_5364 | bazelbuild/bazel | bazelbuild/bazel/5362 | bazelbuild/bazel/5364 | [
"timestamp(timedelta=1.0, similarity=0.8610414419473065)"
] | c720152ec1936a537c9519d522d3cb41d19cff77 | cea4f10e14f801efa8bf33d31d1af2b5d74864a8 | [
"Thanks! If you feel like fixing it, here's the source for the doc file: https://github.com/bazelbuild/bazel/blob/master/site/docs/build-ref.html",
"(Otherwise someone else will fix it later.)"
] | [] | 2018-06-11T12:10:49Z | [
"type: bug",
"type: documentation (cleanup)"
] | Documentation does not list all attribute types | ### Description of the problem / feature request:
https://docs.bazel.build/versions/master/build-ref.html#rules says:
> The full set of types that an attribute can have is: integer, label, list of labels, string, list of strings, output label, list of output labels
But there are quite a few more types that are... | [
"site/docs/build-ref.html"
] | [
"site/docs/build-ref.html"
] | [] | diff --git a/site/docs/build-ref.html b/site/docs/build-ref.html
index 1b4d9ce3aa3562..944a692ff6bf0f 100644
--- a/site/docs/build-ref.html
+++ b/site/docs/build-ref.html
@@ -358,7 +358,7 @@ <h3 id="rules">Rules</h3>
the <a href='be/overview.html'>Build
Encyclopedia</a> for the full list of supported rules and th... | null | val | train | 2018-06-11T13:39:31 | 2018-06-11T11:26:30Z | ash2k | test |
bazelbuild/bazel/5389_5399 | bazelbuild/bazel | bazelbuild/bazel/5389 | bazelbuild/bazel/5399 | [
"timestamp(timedelta=77901.0, similarity=0.845440601490151)"
] | 522f76ae5e50ae9848b6f407acbcce62bb808016 | 6cccefdcdd486e9e21836dfae506ad8e4452b40c | [
"Please provide the contents of jvm.out.",
"> Please provide the contents of jvm.out.\r\n\r\nI ssh'd into CircleCI when this failure occurs and checked jvm.out and it an empty file after the crash. The failure looks like this:\r\n\r\n```\r\n[1] Segmentation fault\r\n[0] \r\n[0] Server terminated abruptly (error c... | [
"can assert_size itself be a test? then you don't need this extra rule, and dummy.sh can be hidden away.",
"Do nothing, feel better?",
"This is an interesting approach. What was the reasoning behind? assert_size is a nice Skylark rule, it only feels weird to be used like this in a BUILD file. Can you create and... | 2018-06-14T15:26:58Z | [
"under investigation",
"P1"
] | Memory usage regression in bazel 0.14.0 and 0.14.1 | On Angular and related projects, we run builds on CI in a docker container. We use the `--local_resources` flag to workaround
https://github.com/bazelbuild/bazel/issues/3645
which causes random failures where Bazel tries to allocate too much memory, since it asks the OS how much RAM is available rather than the cont... | [
"src/BUILD"
] | [
"src/BUILD",
"src/rule_size_test.bzl"
] | [] | diff --git a/src/BUILD b/src/BUILD
index d2431844fb6fed..0d8d060237f92b 100644
--- a/src/BUILD
+++ b/src/BUILD
@@ -1,6 +1,7 @@
# Packaging
load(":embedded_tools.bzl", "srcsfile")
+load(":rule_size_test.bzl", "rule_size_test")
md5_cmd = "set -e -o pipefail && cat $(SRCS) | sort | %s | awk '{ print $$1; }' > $@"
... | null | train | train | 2018-06-15T01:51:08 | 2018-06-13T23:20:35Z | alexeagle | test |
bazelbuild/bazel/5512_5600 | bazelbuild/bazel | bazelbuild/bazel/5512 | bazelbuild/bazel/5600 | [
"timestamp(timedelta=80842.0, similarity=0.8454423582900445)"
] | e14a7d4f156c28244a491c65083273f57734cdbe | 34e100abc472d795c4c77e2baf327156967ca4c0 | [
"I think this is all fixed now."
] | [
"Try not to introduce more `using std::type` aliases. When reader sees `mutex` in a function, it is not immediately clear if it is `std::mutex` or Bazel's own custom mutex implementation.\r\n\r\n`using MagicMap = std::unordered_map<std::string, MagicItem>` that saves significant amount of typing is strongly encoura... | 2018-07-16T13:35:49Z | [
"type: bug",
"P1",
"type: process",
"category: misc > misc"
] | Bazel server: ensure file streams are closed | ### Description of the problem / feature request:
The Bazel server (the Java code) sometimes opens streams without closing them, relying on the garbage collector to finalize the InputStream and close the file. This leads to Bazel holding on to files and (on Windows) being unable to delete them later.
### Bugs: wh... | [
"src/main/cpp/blaze.cc",
"src/main/cpp/blaze_util_platform.h",
"src/main/cpp/blaze_util_posix.cc",
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/main/cpp/blaze.cc",
"src/main/cpp/blaze_util_platform.h",
"src/main/cpp/blaze_util_posix.cc",
"src/main/cpp/blaze_util_windows.cc"
] | [] | diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc
index 09760fcba3c7f4..c50503379cbddb 100644
--- a/src/main/cpp/blaze.cc
+++ b/src/main/cpp/blaze.cc
@@ -878,8 +878,9 @@ static void StartServerAndConnect(const WorkspaceLayout *workspace_layout,
// A PureZipExtractorProcessor to extract the files from the blaz... | null | train | train | 2018-07-16T10:12:34 | 2018-07-04T11:46:48Z | laszlocsomor | test |
bazelbuild/bazel/5513_5527 | bazelbuild/bazel | bazelbuild/bazel/5513 | bazelbuild/bazel/5527 | [
"timestamp(timedelta=0.0, similarity=0.9050090693317487)"
] | bc898cabe7cece0cf868447392f6863cb134d85c | 102b05b49fa757361a4488d91745c69f8f41c828 | [] | [] | 2018-07-06T10:41:05Z | [
"type: bug"
] | Bazel server: race condition in JavaIoFileSystem.delete() | ### Description of the problem / feature request:
There's a race condition in: https://github.com/bazelbuild/bazel/blob/a320e4460f35767da7fc8eb824ce1f4b304b5e0f/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java#L353
If the directory is deleted or replaced by a file between the `file.isDirector... | [
"src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/BUILD",
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java"
] | [
"src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/BUILD",
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java b/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java
index ea541b4a1e020a..25fafac67bb3f7 100644
--- a/src/main/java/com/google/devtools/build/lib/vfs/JavaIoFileSystem.java
+++ b/src/main/java/com/google/devtools/build... | null | val | train | 2018-07-06T12:24:31 | 2018-07-04T11:55:36Z | laszlocsomor | test |
bazelbuild/bazel/5534_5535 | bazelbuild/bazel | bazelbuild/bazel/5534 | bazelbuild/bazel/5535 | [
"timestamp(timedelta=1.0, similarity=0.931227190370861)"
] | 3ac44db0427b7db46b6c39f7dbfab7b5f31f8c37 | 74afaca6f9e050c92e92a8d8aeaa4955ff2472a1 | [] | [] | 2018-07-07T01:56:41Z | [] | Skylint crashes on augmented assignments to IndexExpression. | ### Description of the problem / feature request:
> Skylint crashes when invoked on a snippet like:
```
d["foo"] += "bar"
```
### Feature requests: what underlying problem are you trying to solve with this feature?
> Skylint crash
### Bugs: what's the simplest, easiest way to reproduce this bug? Please p... | [
"src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java",
"src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java"
] | [
"src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java",
"src/tools/skylark/javatests/com/google/devtools/skylark/skylint/BadOperationCheckerTest.java"
] | [] | diff --git a/src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java b/src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java
index 09df8ff7fe7e0e..cb9460ad010a9b 100644
--- a/src/tools/skylark/java/com/google/devtools/skylark/skylint/BadOperationChecker.java
+++... | null | train | train | 2018-07-06T20:19:22 | 2018-07-07T01:55:37Z | ttsugriy | test |
bazelbuild/bazel/5585_6296 | bazelbuild/bazel | bazelbuild/bazel/5585 | bazelbuild/bazel/6296 | [
"timestamp(timedelta=1.0, similarity=0.9596030179739292)"
] | c5bb9b018764c257cf9d36c0e310423ec61a4594 | 1fc559620f9c0af78be1e5f545ca165b27d5ae46 | [
"Looking at this, support should be pretty simple it seems? Even almost working as-is?",
"Looking at the commit, never mind 😄 "
] | [] | 2018-10-03T18:07:49Z | [
"type: feature request",
"P2",
"team-Android"
] | Support NDK r18 | Expected release date: [September 2018](https://github.com/android-ndk/ndk/wiki#ndk-r18)
Beta 1 should be out later this month.
Roadmap: https://android.googlesource.com/platform/ndk/+/master/docs/Roadmap.md
Expected changes to Bazel:
- Remove support for non-`libc++` STLs
> libc++ has been the default f... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/StlImpl.java",
"src/mai... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/StlImpl.java",
"src/mai... | [] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java
index c4a1d77e278593..716135552158fe 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/and... | null | test | train | 2018-10-03T19:47:25 | 2018-07-12T20:30:17Z | jin | test |
bazelbuild/bazel/5589_5628 | bazelbuild/bazel | bazelbuild/bazel/5589 | bazelbuild/bazel/5628 | [
"timestamp(timedelta=0.0, similarity=0.9743079330526386)"
] | 80eb1935e9d8de5a566c36015f5457f8dca13a65 | 1d232fc59df9e6fc94e7b8d8df01fed15950f68d | [
"@meisterT for triage since this is perf related. I do agree that \"every 10 seconds full gc\" is not awesome.",
"I think we should delete this code. I have yet to see a benchmark showing that the application logic choosing to do a GC results in better performance than the JVM triggering the GC itself."
] | [
"I think it's better not to create the IdleServerTasks if we don't have to, so perhaps rename the option and check for nullness below. WDYT?",
"Contrary to my earlier statement, I think it's safer to default to the old behavior. Then, we can release it with the toggle and flip the default value in a later release... | 2018-07-18T17:52:13Z | [
"type: feature request"
] | add an option to disable the idle GC | If a Bazel server is idle for 10 seconds after finishing a command, it will invoke `System.gc()`. On HotSpot, `System.gc()` triggers an aggressive full GC. In practice, I see `System.gc()` in a Bazel server with a 2GB heap fully consume 4 cores for several seconds. This behavior is problematic for workflows that involv... | [
"src/main/cpp/blaze.cc",
"src/main/cpp/startup_options.cc",
"src/main/cpp/startup_options.h",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeServerStartupOptions.java",
"src/main/java/com/google/devtools/build/lib/server/G... | [
"src/main/cpp/blaze.cc",
"src/main/cpp/startup_options.cc",
"src/main/cpp/startup_options.h",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeRuntime.java",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeServerStartupOptions.java",
"src/main/java/com/google/devtools/build/lib/server/G... | [] | diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc
index 9e7d9798552d30..801a9314c00593 100644
--- a/src/main/cpp/blaze.cc
+++ b/src/main/cpp/blaze.cc
@@ -541,6 +541,11 @@ static vector<string> GetArgumentArray(
// being "null" to set the programmatic default in the server.
result.push_back("--digest_... | null | val | train | 2018-08-06T07:22:58 | 2018-07-13T06:22:45Z | benjaminp | test |
bazelbuild/bazel/5594_5894 | bazelbuild/bazel | bazelbuild/bazel/5594 | bazelbuild/bazel/5894 | [
"timestamp(timedelta=130064.0, similarity=0.8452684891346447)"
] | 8dece49bed76b5f372ff5d3a3f25a32b2a9c1f52 | 85b6b1d341d93c497e29609b2ed584c4bea12458 | [
"To confirm, is the request to support using the embedded JDK as the `--javabase`?\r\n\r\nIf the goal is to have `--javabase` versioned with your respository, have you considered versioning a separate JDK?",
"Not quite. What I'm really looking for is a way to completely eliminate uses of any JDKs found via `which... | [] | 2018-08-14T21:15:42Z | [
"type: feature request"
] | Only use JAVA_HOME/@local_jdk as the default --javabase | ### Description of the problem / feature request:
Since 849df36c5ad31ebe8791c4228321c38c6d0ae56c, bazel will always pick up a JDK from `which javac` or $JAVA_HOME in preference to an embedded one for `@local_jdk//`. I want to always use the embedded one instead. A startup option to do this would be fine.
### Feat... | [
"tools/jdk/BUILD",
"tools/jdk/DumpPlatformClassPath.java"
] | [
"tools/jdk/BUILD",
"tools/jdk/DumpPlatformClassPath.java"
] | [] | diff --git a/tools/jdk/BUILD b/tools/jdk/BUILD
index 8598fdfa9a72ed..ff52e25b1f49c6 100644
--- a/tools/jdk/BUILD
+++ b/tools/jdk/BUILD
@@ -176,8 +176,12 @@ genrule(
cmd = """
set -eu
TMPDIR=$$(mktemp -d -t tmp.XXXXXXXX)
-$(JAVABASE)/bin/javac $< -d $$TMPDIR
-$(JAVA) -cp $$TMPDIR DumpPlatformClassPath $@
+$(JAVAB... | null | train | train | 2018-08-15T02:55:14 | 2018-07-13T19:15:47Z | brian-peloton | test |
bazelbuild/bazel/5634_6360 | bazelbuild/bazel | bazelbuild/bazel/5634 | bazelbuild/bazel/6360 | [
"timestamp(timedelta=1.0, similarity=0.8469261201945434)"
] | aab8beefb70862c225bfd21732bb2d6e7f09a9a9 | ce2f86e2d33f5e654407ba3777b66c1a4c18b0b9 | [
"Thanks for the report. I don't plan to work on this until https://github.com/bazelbuild/bazel/issues/5187 is done. And I can see an universe in which we won't need so many env vars to tweak C++ toolchain. But nothing concrete yet. If this is urgent, let me know, and I will help the PR.",
"+1 to fixing this. This... | [] | 2018-10-11T18:33:37Z | [
"type: feature request",
"P2",
"team-Rules-CPP"
] | Stop unconditionally adding -B/usr/bin flag to C/C++ toolchains | The addition of this flag was done as a fix to Issue #760
The problem with this is that it completely breaks any custom toolchain setup because it forces use of tools such as `ld`, `as`, `ar` and others from /usr/bin. And since this is added so early in the process it is not possible override it in the build files.... | [
"tools/cpp/CROSSTOOL",
"tools/cpp/unix_cc_configure.bzl"
] | [
"tools/cpp/CROSSTOOL",
"tools/cpp/unix_cc_configure.bzl"
] | [
"src/test/java/com/google/devtools/build/lib/analysis/mock/MOCK_CROSSTOOL",
"src/test/shell/bazel/testdata/bazel_toolchain_test_data/tools/arm_compiler/CROSSTOOL"
] | diff --git a/tools/cpp/CROSSTOOL b/tools/cpp/CROSSTOOL
index a41b8822a964a4..5b9cd3d5356167 100644
--- a/tools/cpp/CROSSTOOL
+++ b/tools/cpp/CROSSTOOL
@@ -59,7 +59,6 @@ toolchain {
tool_path { name: "gcc" path: "/usr/bin/gcc" }
cxx_flag: "-std=c++0x"
linker_flag: "-lstdc++"
- linker_flag: "-B/usr/bin/"
#... | diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/MOCK_CROSSTOOL b/src/test/java/com/google/devtools/build/lib/analysis/mock/MOCK_CROSSTOOL
index 0ef230997778ed..3392cf5f3d153a 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/MOCK_CROSSTOOL
+++ b/src/test/java/com/google/devto... | train | train | 2018-10-11T21:08:25 | 2018-07-19T08:03:25Z | georgi-d | test |
bazelbuild/bazel/5720_5739 | bazelbuild/bazel | bazelbuild/bazel/5720 | bazelbuild/bazel/5739 | [
"timestamp(timedelta=1.0, similarity=0.9344559452588765)"
] | 78142a6bf3dbf802e3140c1098cf3fda8d4be883 | 99a58d0de6283cb79ba4f53ac665c342f46449a7 | [
"Thanks for reporting it!"
] | [
"This link downloads a \"visualcppbuildtools_full.exe\" which seems pretty confusing to say the least. Maybe we should link the page where all the Visual C++ Build Tools are?",
"I agree. Microsoft is notorious for orphaning download links.",
"Done."
] | 2018-08-02T07:15:34Z | [
"type: documentation (cleanup)",
"platform: windows",
"bazel.build"
] | Docs link to Visual C++ Build Tools 2015 is broken | ### Description of the problem / feature request:
Link to `Visual C++ Build Tools 2015` in https://docs.bazel.build/versions/master/windows.html lead to a 404
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Open https://docs.bazel.build/versions/m... | [
"site/docs/windows.md"
] | [
"site/docs/windows.md"
] | [] | diff --git a/site/docs/windows.md b/site/docs/windows.md
index 9049fbbdd63cdc..3f454b693c6798 100644
--- a/site/docs/windows.md
+++ b/site/docs/windows.md
@@ -58,7 +58,7 @@ To build C++ targets, you need:
features are not installed by default.
* Install the [Visual C++ Build
- Tools 2015 or lat... | null | train | train | 2018-08-02T04:26:50 | 2018-07-31T16:06:58Z | filipesilva | test |
bazelbuild/bazel/5751_5752 | bazelbuild/bazel | bazelbuild/bazel/5751 | bazelbuild/bazel/5752 | [
"timestamp(timedelta=0.0, similarity=0.9462255836554451)"
] | ed75f38d5857177bd7730b60c9fd3eb66dea5300 | 10187c568655e63d56713c58bf89fccb661ef16d | [] | [] | 2018-08-03T10:12:18Z | [
"type: bug",
"P1",
"platform: windows"
] | Windows,Bash detection: do not detect Git Bash | ### Description of the problem / feature request:
When `BAZEL_SH` envvar is not defined and Bazel searches for a suitable bash.exe, it should not look for Git Bash nor should it recommend installing it as a Bash implementation.
Git Bash does not support the full set of bintools that MSYS2 Bash does, nor does Git ... | [
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/main/cpp/blaze_util_windows.cc"
] | [] | diff --git a/src/main/cpp/blaze_util_windows.cc b/src/main/cpp/blaze_util_windows.cc
index e851ef041a5378..d811a944548df1 100644
--- a/src/main/cpp/blaze_util_windows.cc
+++ b/src/main/cpp/blaze_util_windows.cc
@@ -1413,58 +1413,6 @@ static string GetMsysBash() {
return string();
}
-// Implements heuristics to di... | null | train | train | 2018-08-03T11:53:31 | 2018-08-03T10:07:59Z | laszlocsomor | test |
bazelbuild/bazel/5803_5804 | bazelbuild/bazel | bazelbuild/bazel/5803 | bazelbuild/bazel/5804 | [
"timestamp(timedelta=96914.0, similarity=0.9177194223528519)"
] | f05c0a48dc298ad3e90f3acb399cc53c2944a801 | adbdea18f70b4d1aebdf574d9b6b782c68322251 | [
"Workaround for the time being (because of https://github.com/bazelbuild/bazel/issues/5802):\r\n- add a new `java_library` to `src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD.tools` called \"runfiles-deprecated\" with a `deprecation` attribute\r\n- change the `alias` rule in `tools/runfiles/BUILD.t... | [
"Clever!"
] | 2018-08-08T13:07:30Z | [
"type: process"
] | move the Java runfiles library to `@bazel_tools//tools/java/runfiles` | ### Description of the problem / feature request:
Every language's runfiles library is under `@bazel_tools//tools/<language>/runfiles`, Java being the only exception with `@bazel_tools//tools/runfiles:java-runfiles`.
### Feature requests: what underlying problem are you trying to solve with this feature?
Consi... | [
"src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD",
"src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD.tools",
"src/tools/runfiles/java/com/google/devtools/build/runfiles/Runfiles.java",
"tools/BUILD",
"tools/runfiles/BUILD.tools"
] | [
"src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD",
"src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD.tools",
"src/tools/runfiles/java/com/google/devtools/build/runfiles/Runfiles.java",
"tools/BUILD",
"tools/java/BUILD",
"tools/java/runfiles/BUILD",
"tools/java/runfiles/B... | [
"src/test/py/bazel/testdata/runfiles_test/bar/BUILD.mock",
"src/test/py/bazel/testdata/runfiles_test/foo/BUILD.mock"
] | diff --git a/src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD b/src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD
index 00f44a07d688e7..c988e826580808 100644
--- a/src/tools/runfiles/java/com/google/devtools/build/runfiles/BUILD
+++ b/src/tools/runfiles/java/com/google/devtools/build/runf... | diff --git a/src/test/py/bazel/testdata/runfiles_test/bar/BUILD.mock b/src/test/py/bazel/testdata/runfiles_test/bar/BUILD.mock
index 930884b45a9ef9..de3a5cf9d086bf 100644
--- a/src/test/py/bazel/testdata/runfiles_test/bar/BUILD.mock
+++ b/src/test/py/bazel/testdata/runfiles_test/bar/BUILD.mock
@@ -13,7 +13,7 @@ java_bi... | train | train | 2018-08-08T14:30:57 | 2018-08-08T12:28:01Z | laszlocsomor | test |
bazelbuild/bazel/5807_6014 | bazelbuild/bazel | bazelbuild/bazel/5807 | bazelbuild/bazel/6014 | [
"timestamp(timedelta=101070.0, similarity=0.878287860173537)"
] | 3987300d6651cf0e6e91b395696afac6913a7d66 | de4edef403090fcba0638772097c967d11d80b35 | [
"@filipesilva I have made some progress on this recently.\r\nNow with Bazel built from HEAD, symlink tree will be available on Windows when you pass `--experimental_enable_runfiles`. \r\nCan you try if it helps with https://github.com/bazelbuild/bazel/issues/5926?",
"@filipesilva Just found a bug when dealing wit... | [
"`FILE_FLAG_BACKUP_SEMANTICS` is required when and only when opening a directory or junction. When opening a file symlink, you must not use `FILE_FLAG_BACKUP_SEMANTICS`. I suggest trying to open it with `FILE_ATTRIBUTE_NORMAL | FILE_FLAG_OPEN_REPARSE_POINT` in case this `CreateFileW` call fails.\r\n\r\nFurthermore,... | 2018-08-28T14:12:31Z | [
"type: feature request",
"P2",
"platform: windows",
"area-Windows",
"team-OSS"
] | Use symlinked runfiles on Windows when supported | ### Description of the problem / feature request:
On Windows Bazel sets `RUNFILES_MANIFEST_ONLY` to `1` and does not generate symlinks to runfiles. This does not change if the current user can create symlinks.
On recent Windows 10 versions it is possible to enable symlinks for all users:
> Now in Windows 10 Cr... | [
"src/main/cpp/util/file_platform.h",
"src/main/cpp/util/file_windows.cc"
] | [
"src/main/cpp/util/file_platform.h",
"src/main/cpp/util/file_windows.cc"
] | [] | diff --git a/src/main/cpp/util/file_platform.h b/src/main/cpp/util/file_platform.h
index 76e94d175732ed..868d3c90f21d82 100644
--- a/src/main/cpp/util/file_platform.h
+++ b/src/main/cpp/util/file_platform.h
@@ -209,6 +209,16 @@ void ForEachDirectoryEntry(const std::string &path,
std::wstring GetCwdW();
bool MakeDirec... | null | train | train | 2018-08-29T03:49:14 | 2018-08-08T16:44:27Z | filipesilva | test |
bazelbuild/bazel/5807_6024 | bazelbuild/bazel | bazelbuild/bazel/5807 | bazelbuild/bazel/6024 | [
"timestamp(timedelta=2227.0, similarity=0.8835729751180569)"
] | 206c19bf4cf8e9a3bc33289fe071700fcac1e2c6 | eb1695979c7b0c69a783138790e18a8f625bbeb5 | [
"@filipesilva I have made some progress on this recently.\r\nNow with Bazel built from HEAD, symlink tree will be available on Windows when you pass `--experimental_enable_runfiles`. \r\nCan you try if it helps with https://github.com/bazelbuild/bazel/issues/5926?",
"@filipesilva Just found a bug when dealing wit... | [
"Have you thought of using a `typedef`? I think that'd be more type-safe and more readable than a macro.",
"Have you thought of using an unnamed namespace? That restricts visibility and the binary will not export these symbols.\r\n\r\n(See https://google.github.io/styleguide/cppguide.html#Unnamed_Namespaces_and_S... | 2018-08-29T16:14:45Z | [
"type: feature request",
"P2",
"platform: windows",
"area-Windows",
"team-OSS"
] | Use symlinked runfiles on Windows when supported | ### Description of the problem / feature request:
On Windows Bazel sets `RUNFILES_MANIFEST_ONLY` to `1` and does not generate symlinks to runfiles. This does not change if the current user can create symlinks.
On recent Windows 10 versions it is possible to enable symlinks for all users:
> Now in Windows 10 Cr... | [
"src/main/cpp/util/BUILD",
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java",
"src/main/tools/BUILD",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/main/cpp/util/BUILD",
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java",
"src/main/tools/BUILD",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/test/py/bazel/runfiles_test.py",
"src/test/shell/integration/BUILD",
"src/test/shell/integration/runfiles_test.sh"
] | diff --git a/src/main/cpp/util/BUILD b/src/main/cpp/util/BUILD
index 9df4e558d8f472..bc799aba338af7 100644
--- a/src/main/cpp/util/BUILD
+++ b/src/main/cpp/util/BUILD
@@ -55,6 +55,7 @@ cc_library(
visibility = [
":ijar",
"//src/test/cpp/util:__pkg__",
+ "//src/main/tools:__pkg__",
... | diff --git a/src/test/py/bazel/runfiles_test.py b/src/test/py/bazel/runfiles_test.py
index 50506f63918e8a..36aba0d7678642 100644
--- a/src/test/py/bazel/runfiles_test.py
+++ b/src/test/py/bazel/runfiles_test.py
@@ -21,16 +21,6 @@
class RunfilesTest(test_base.TestBase):
- def testAttemptToBuildRunfilesOnWindows(se... | val | train | 2018-08-29T18:09:19 | 2018-08-08T16:44:27Z | filipesilva | test |
bazelbuild/bazel/5810_6636 | bazelbuild/bazel | bazelbuild/bazel/5810 | bazelbuild/bazel/6636 | [
"timestamp(timedelta=2799.0, similarity=0.9213884834542884)"
] | c543992dea17f88190f1cda9980491ca858f10a0 | 262c4e1debac828601e38c0f67f2ff0b281892a3 | [
"Revamped in https://github.com/bazelbuild/bazel/commit/92b14d3f5ada6c857ba9a3cefbfcf7affaf16450"
] | [
"how about \"This tutorial does not require experience with Bazel or Android app development.\"",
"hmm, this seems to contradict the Android Studio being in Prerequisites?",
"\"Initialize the project's workspace\"?",
"this reassurance feels a bit odd, since presumably people are here because they want to work... | 2018-11-08T21:51:28Z | [
"type: feature request",
"P2",
"team-Android"
] | Refresh Android build tutorial on docs.bazel.build | Link: https://docs.bazel.build/versions/master/tutorial/android-app.html
Ideas:
- [ ] Remove references to OS specific commands. e.g. `touch`, `export`, `WORKSPACE` environment variables.
- [ ] Update versions
- [ ] Improve the flow of the tutorial. It asks the user to add snippets or create files that already ... | [
"site/docs/tutorial/android-app.md"
] | [
"site/docs/tutorial/android-app.md"
] | [] | diff --git a/site/docs/tutorial/android-app.md b/site/docs/tutorial/android-app.md
index 20db3e2ac81f78..20d6baef3126f5 100644
--- a/site/docs/tutorial/android-app.md
+++ b/site/docs/tutorial/android-app.md
@@ -3,140 +3,151 @@ layout: documentation
title: Build Tutorial - Android
---
-Introduction to Bazel: Buildin... | null | train | train | 2018-11-08T22:45:14 | 2018-08-08T18:24:45Z | jin | test |
bazelbuild/bazel/5821_9156 | bazelbuild/bazel | bazelbuild/bazel/5821 | bazelbuild/bazel/9156 | [
"timestamp(timedelta=0.0, similarity=0.8801452286846743)"
] | 406915b1ff80ee42455f35ff5dbfde1ddbce3dfc | ea6a7895b60d86a94aeb08a6561a933f408fcca9 | [
"@iirina,\nhave we removed the blockers from this?\nWe still haven't been able to move rules_scala to the new one AFAIR and\nunfortunately due to the strict-deps false negative we're also stuck with a\nrather old rules_scala version\n\nOn Thu, Aug 9, 2018 at 1:32 AM c-parsons <notifications@github.com> wrote:\n\n> ... | [] | 2019-08-13T07:34:30Z | [
"P2",
"team-Rules-Java",
"incompatible-change"
] | incompatible_disallow_legacy_javainfo: Remove legacy (deprecated) JavaInfo constructors | This is a tracking issue for offering a migration solution for
`--incompatible_disallow_legacy_javainfo`
| [
"src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java",
"src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java"
] | [
"src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java",
"src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java"
] | [
"src/test/java/com/google/devtools/build/lib/rules/java/JavaInfoSkylarkApiTest.java",
"src/test/shell/bazel/bazel_java_test.sh"
] | diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
index 8f8fe4dcb2b852..a7c881250024c4 100644
--- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java
+++ b/... | diff --git a/src/test/java/com/google/devtools/build/lib/rules/java/JavaInfoSkylarkApiTest.java b/src/test/java/com/google/devtools/build/lib/rules/java/JavaInfoSkylarkApiTest.java
index acf7976ee2d227..7ac2224737ff97 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/java/JavaInfoSkylarkApiTest.java
+++ b/... | train | train | 2019-08-13T01:05:06 | 2018-08-08T22:32:03Z | c-parsons | test |
bazelbuild/bazel/5863_5864 | bazelbuild/bazel | bazelbuild/bazel/5863 | bazelbuild/bazel/5864 | [
"timestamp(timedelta=0.0, similarity=0.909201512789194)"
] | 468f177334d4375f762e1dcdb13c51feeed11dfb | f432c10c1cdeb62e78179c04888ddd32db4ba999 | [] | [] | 2018-08-11T11:50:55Z | [
"team-Rules-Java",
"untriaged"
] | java_import_external rule is partly broken | On most recent Bazel master (d0a3c5eb67320906e4b937df5434f0e673cb6dce), combining `neverlink = True` and `generated_linkable_rule_name = "foo"` attributes seems to be broken:
```
def external_plugin_deps():
java_import_external(
name = "javamelody-core",
jar_sha256 = "eb2806497676da54e257840626b64e8e53... | [
"tools/build_defs/repo/jvm.bzl"
] | [
"tools/build_defs/repo/jvm.bzl"
] | [] | diff --git a/tools/build_defs/repo/jvm.bzl b/tools/build_defs/repo/jvm.bzl
index 1538ea1b7e892d..dfa17f4692b176 100644
--- a/tools/build_defs/repo/jvm.bzl
+++ b/tools/build_defs/repo/jvm.bzl
@@ -91,7 +91,7 @@ def _jvm_import_external(repository_ctx):
repository_ctx.attr.generated_linkable_rule_name):
... | null | val | train | 2018-08-11T08:38:44 | 2018-08-11T10:53:48Z | davido | test |
bazelbuild/bazel/5914_5969 | bazelbuild/bazel | bazelbuild/bazel/5914 | bazelbuild/bazel/5969 | [
"timestamp(timedelta=1.0, similarity=0.8811939021390516)"
] | 56fd4fe5a955d99f7467003fd399228ea87270ac | 31a70e20a3ec2c749d87a18dd3655023eb0588c7 | [
"Suggestion: enforce that Identifiers are either\r\n * `lower_snake_case`,\r\n * `UPPER_SNAKE_CASE`, or\r\n * `UpperCamelCaseWithSuffixInfo`"
] | [
"Someone told me the message could be improved:\r\n\r\n> I think this is confusing, made me think of \"information about a suffix\", not of the literal suffix \"Info\".\r\n> How about \"UpperCamelCase and end in \\\"Info\\\" (for providers; example: FooBarInfo)\" ?"
] | 2018-08-23T13:16:37Z | [
"type: bug",
"P2"
] | Skylint should allow UpperCamelCase identifiers for provider aliases | Currently identifiers are only allowed to be `lower_snake_case` or `UPPER_SNAKE_CASE` in most cases, and also allowed to be `UpperCamelCase` if they are being [declared as a provider](https://github.com/bazelbuild/bazel/blob/901cc6c7474e2a6cc8c3812d156177f44dcb76ed/src/tools/skylark/java/com/google/devtools/skylark/sky... | [
"site/docs/skylark/skylint.md",
"src/tools/skylark/java/com/google/devtools/skylark/skylint/NamingConventionsChecker.java",
"src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java"
] | [
"site/docs/skylark/skylint.md",
"src/tools/skylark/java/com/google/devtools/skylark/skylint/NamingConventionsChecker.java",
"src/tools/skylark/javatests/com/google/devtools/skylark/skylint/NamingConventionsCheckerTest.java"
] | [] | diff --git a/site/docs/skylark/skylint.md b/site/docs/skylark/skylint.md
index 686ad5cd752cf9..14a282bf901e1c 100644
--- a/site/docs/skylark/skylint.md
+++ b/site/docs/skylark/skylint.md
@@ -188,9 +188,8 @@ In detail, the rules are the following:
* **Constants** that are **immutable**. The variable must not be r... | null | train | train | 2018-09-05T19:56:52 | 2018-08-16T17:51:37Z | JaredNeil | test |
bazelbuild/bazel/5943_5999 | bazelbuild/bazel | bazelbuild/bazel/5943 | bazelbuild/bazel/5999 | [
"timestamp(timedelta=0.0, similarity=0.8711573184192934)"
] | 8d84a630c59047fd3953f5b6f444e4a75c324db2 | fcd15a73b59c5515687a27edef2e68bb0b58f468 | [
"We love contributions @Profpatsch :-)",
"> We love contributions @Profpatsch :-)\r\n\r\nI will open a pull request, do you have any preference on what the `perl` interpreter should replaced with? I think we can assume command line arguments will only use ASCII characters, is that correct?",
"I don't but @aehli... | [] | 2018-08-27T11:47:33Z | [
"untriaged",
"team-Bazel"
] | bash completion requires perl | ### Description of the problem / feature request:
The bash completion uses a very small perl invocation in two places:
```
perl -ne 'print uc'
```
https://github.com/bazelbuild/bazel/blob/master/scripts/bazel-complete-template.bash#L151-L170
As far as I understand this uppercases letters. It also introduc... | [
"scripts/bazel-complete-template.bash"
] | [
"scripts/bazel-complete-template.bash"
] | [] | diff --git a/scripts/bazel-complete-template.bash b/scripts/bazel-complete-template.bash
index d3f89bb6f86544..531e3296d85e6c 100644
--- a/scripts/bazel-complete-template.bash
+++ b/scripts/bazel-complete-template.bash
@@ -154,7 +154,8 @@ _bazel__package_path() {
_bazel__options_for() {
local options
if [[ "${BA... | null | train | train | 2018-08-27T12:08:45 | 2018-08-21T11:32:32Z | Profpatsch | test |
bazelbuild/bazel/5952_5953 | bazelbuild/bazel | bazelbuild/bazel/5952 | bazelbuild/bazel/5953 | [
"timestamp(timedelta=0.0, similarity=0.9003379059109604)"
] | c5a2f81ce8fc1dee4bcfa92cf3059a9c50bf2d85 | b274a9dc3a3812f6b4e1dc69909e523f1592bee4 | [
"I'm about to submit a pull request which fixes this issue.",
"Here's the pull request: https://github.com/bazelbuild/bazel/pull/5953"
] | [
"I think the changes in this file are no longer necessary and can be reverted?",
"I think we don't want to clear the pipeline but actually fail if there's anything in there.\r\nIt would be a bug in our code if the pipeline were not empty.",
"Good point, I'll revert this back since the exception handler should c... | 2018-08-21T21:41:11Z | [
"untriaged"
] | Race condition in HttpBlobStore.releaseUploadChannel | ### Description of the problem / feature request:
Builds can fail with `java.lang.RuntimeException: Unrecoverable error while evaluating node 'ActionLookupData{...}' ...
Caused by: java.util.NoSuchElementException: io.netty.handler.codec.http.HttpRequestEncoder` when using the HttpBlobStore to cache builds.
It ap... | [
"src/main/java/com/google/devtools/build/lib/remote/blobstore/http/HttpBlobStore.java"
] | [
"src/main/java/com/google/devtools/build/lib/remote/blobstore/http/HttpBlobStore.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/remote/blobstore/http/HttpBlobStore.java b/src/main/java/com/google/devtools/build/lib/remote/blobstore/http/HttpBlobStore.java
index ca9a8ebff47012..a3d363616b8108 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/blobstore/http/HttpBlobStore.java
... | null | train | train | 2018-08-21T23:12:24 | 2018-08-21T21:38:04Z | geoffmaddox | test |
bazelbuild/bazel/6019_6024 | bazelbuild/bazel | bazelbuild/bazel/6019 | bazelbuild/bazel/6024 | [
"timestamp(timedelta=102305.0, similarity=0.9405752619525384)"
] | 206c19bf4cf8e9a3bc33289fe071700fcac1e2c6 | eb1695979c7b0c69a783138790e18a8f625bbeb5 | [
"We already have an issue here: https://github.com/bazelbuild/bazel/issues/5807\r\nClosing this one due to duplication."
] | [
"Have you thought of using a `typedef`? I think that'd be more type-safe and more readable than a macro.",
"Have you thought of using an unnamed namespace? That restricts visibility and the binary will not export these symbols.\r\n\r\n(See https://google.github.io/styleguide/cppguide.html#Unnamed_Namespaces_and_S... | 2018-08-29T16:14:45Z | [
"type: feature request",
"P2",
"platform: windows",
"area-Windows",
"team-OSS"
] | Implement build-runfiles on Windows | On Windows, runfiles tree is disabled because creating symlink needs admin right or Windows 10 Creator Update (or later) and developer is enabled. But Bazel should be able to build runfiles tree if users can ensure one of those requirements.
Enabling runfiles tree on Windows would help resolve https://github.com/baz... | [
"src/main/cpp/util/BUILD",
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java",
"src/main/tools/BUILD",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/main/cpp/util/BUILD",
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java",
"src/main/tools/BUILD",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/test/py/bazel/runfiles_test.py",
"src/test/shell/integration/BUILD",
"src/test/shell/integration/runfiles_test.sh"
] | diff --git a/src/main/cpp/util/BUILD b/src/main/cpp/util/BUILD
index 9df4e558d8f472..bc799aba338af7 100644
--- a/src/main/cpp/util/BUILD
+++ b/src/main/cpp/util/BUILD
@@ -55,6 +55,7 @@ cc_library(
visibility = [
":ijar",
"//src/test/cpp/util:__pkg__",
+ "//src/main/tools:__pkg__",
... | diff --git a/src/test/py/bazel/runfiles_test.py b/src/test/py/bazel/runfiles_test.py
index 50506f63918e8a..36aba0d7678642 100644
--- a/src/test/py/bazel/runfiles_test.py
+++ b/src/test/py/bazel/runfiles_test.py
@@ -21,16 +21,6 @@
class RunfilesTest(test_base.TestBase):
- def testAttemptToBuildRunfilesOnWindows(se... | test | train | 2018-08-29T18:09:19 | 2018-08-29T07:42:41Z | meteorcloudy | test |
bazelbuild/bazel/6061_6068 | bazelbuild/bazel | bazelbuild/bazel/6061 | bazelbuild/bazel/6068 | [
"timestamp(timedelta=29963.0, similarity=0.9261200312519905)"
] | 411ab49f8317ac0ff60c833672422fdb0df358ea | c1c46dcefa3120b18f83416768e23e5c8c398411 | [
"Why am I assigned to this @laszlocsomor?",
"IIRC you updated Protobuf in the past. If so, you have domain expertise. Am I confusing it with gRPC though?",
"I have, so have other people. I currently have multiple P1s I am working on and don't have time to update protobuf anytime soon. There's a detailed descrip... | [
"please put `load()` statements at the top of the file"
] | 2018-09-04T08:49:23Z | [
"P1",
"type: process"
] | Update Protobuf to 3.6.1 | ### Description of the problem / feature request:
Please update Bazel's Protocol Buffer version to 3.6.1
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
This is breaking Bazel at HEAD when built with Visual C++ 2017 on Windows.
See https://gith... | [
"WORKSPACE",
"src/main/protobuf/BUILD",
"third_party/protobuf/3.6.1/BUILD",
"third_party/protobuf/BUILD",
"third_party/protobuf/README.md"
] | [
"WORKSPACE",
"src/main/protobuf/BUILD",
"third_party/protobuf/3.6.1/BUILD",
"third_party/protobuf/3.6.1/compiler_config_setting.bzl",
"third_party/protobuf/BUILD",
"third_party/protobuf/README.md"
] | [
"src/test/shell/bazel/testdata/embedded_tools_srcs_deps",
"src/test/shell/testenv.sh"
] | diff --git a/WORKSPACE b/WORKSPACE
index 634894979f5bd7..cf6dd6c1a2bccb 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -69,20 +69,20 @@ bind(
new_local_repository(
name = "com_google_protobuf",
- build_file = "./third_party/protobuf/3.6.0/BUILD",
- path = "./third_party/protobuf/3.6.0/",
+ build_file = "./t... | diff --git a/src/test/shell/bazel/testdata/embedded_tools_srcs_deps b/src/test/shell/bazel/testdata/embedded_tools_srcs_deps
index 5f373788af0ba7..07704af47d52ed 100644
--- a/src/test/shell/bazel/testdata/embedded_tools_srcs_deps
+++ b/src/test/shell/bazel/testdata/embedded_tools_srcs_deps
@@ -2,7 +2,6 @@
@com_google_... | val | train | 2018-09-04T16:25:55 | 2018-09-03T09:03:28Z | laszlocsomor | test |
bazelbuild/bazel/6061_6082 | bazelbuild/bazel | bazelbuild/bazel/6061 | bazelbuild/bazel/6082 | [
"timestamp(timedelta=7101.0, similarity=0.8553772038536177)"
] | 27303d79c38f2bfa3b64ee7cd7a6ef03a9a87842 | 13670057b9d02a8316508297458fd9a4b5cc202e | [
"Why am I assigned to this @laszlocsomor?",
"IIRC you updated Protobuf in the past. If so, you have domain expertise. Am I confusing it with gRPC though?",
"I have, so have other people. I currently have multiple P1s I am working on and don't have time to update protobuf anytime soon. There's a detailed descrip... | [] | 2018-09-05T08:02:36Z | [
"P1",
"type: process"
] | Update Protobuf to 3.6.1 | ### Description of the problem / feature request:
Please update Bazel's Protocol Buffer version to 3.6.1
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
This is breaking Bazel at HEAD when built with Visual C++ 2017 on Windows.
See https://gith... | [
"third_party/protobuf/README.md"
] | [
"third_party/protobuf/README.md"
] | [] | diff --git a/third_party/protobuf/README.md b/third_party/protobuf/README.md
index e2a428a2afa9dd..a678ab5b02426f 100644
--- a/third_party/protobuf/README.md
+++ b/third_party/protobuf/README.md
@@ -1,40 +1,100 @@
# Updating protobuf
+You will create and merge the following Pull Requests.
-1) Fetch the desired pro... | null | train | train | 2018-09-05T08:45:59 | 2018-09-03T09:03:28Z | laszlocsomor | test |
bazelbuild/bazel/6099_6100 | bazelbuild/bazel | bazelbuild/bazel/6099 | bazelbuild/bazel/6100 | [
"timestamp(timedelta=0.0, similarity=0.8646177122156461)"
] | 236e6ed3f1158ccaf928c114017bcba45961bb12 | 6a47303955f6361f126494372e5a2f2438e6cbed | [
"I found the root cause: similarly to https://github.com/bazelbuild/bazel/issues/2576, it's the java log path. Turns out we must pass the path with escaped backslashes instead of forward slashes. Working on a fix.",
"How come it worked in 0.17rc1 then?",
"I don't know yet. What I do know is that (a) the fix sol... | [
"Isn't this quadratic? Mind you, not that the strings in question are very long (cue PATH_MAX), but if there is a simple way...",
"You're fully right. Let me fix that.",
"nit: `std::count` could be used to count these numbers, but I'm not at all sure if it would result in simpler code.",
"nit: you overwrite i... | 2018-09-07T14:35:26Z | [] | Windows, Bazel 0.17.0rc2, regression: bazel no longer writes java.log | ### Description of the problem / feature request:
0.17.0 rc2 regression over rc1: Bazel on Windows no longer writes `<output_base>/java.log`.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Build anything with 0.17.0 rc1, then run `bazel info outp... | [
"src/main/cpp/startup_options.cc",
"src/main/cpp/util/path_windows.cc"
] | [
"src/main/cpp/startup_options.cc",
"src/main/cpp/util/path_windows.cc"
] | [
"src/test/shell/integration/execution_phase_tests.sh",
"src/test/shell/integration/server_logging_test.sh"
] | diff --git a/src/main/cpp/startup_options.cc b/src/main/cpp/startup_options.cc
index 05ec6de69ac7b5..fbf34679d32e55 100644
--- a/src/main/cpp/startup_options.cc
+++ b/src/main/cpp/startup_options.cc
@@ -537,8 +537,9 @@ blaze_exit_code::ExitCode StartupOptions::AddJVMArguments(
void StartupOptions::AddJVMLoggingArgumen... | diff --git a/src/test/shell/integration/execution_phase_tests.sh b/src/test/shell/integration/execution_phase_tests.sh
index 74b3e1b14d98e2..71951a21f55f21 100755
--- a/src/test/shell/integration/execution_phase_tests.sh
+++ b/src/test/shell/integration/execution_phase_tests.sh
@@ -105,9 +105,6 @@ function assert_cache... | train | train | 2018-09-07T15:36:57 | 2018-09-07T12:39:38Z | laszlocsomor | test |
bazelbuild/bazel/6141_6142 | bazelbuild/bazel | bazelbuild/bazel/6141 | bazelbuild/bazel/6142 | [
"timestamp(timedelta=0.0, similarity=0.9339910474624503)"
] | 46e65d1fb236d0eea9d2f8511e7412d98b534fc6 | 62c66e5401d06c6bafebc8f818b25b4d5a133bad | [] | [
"Just curious: Do relative paths still work when prefixed with `\\\\?\\` ?",
"Sorry - ignore that. I somehow thought that this method can also produce relative paths (GitHub showed the diff in a strange way, until I refreshed the page and suddenly it's 10x as large)",
"TIL: you can have a directory named with `... | 2018-09-13T15:40:58Z | [
"platform: windows",
"area-Windows",
"team-OSS"
] | Windows,Bazel client: bug in C++ impl. of NormalizeWindowsPath | `NormalizeWindowsPath` strips leading `../` from relative paths. | [
"src/main/cpp/util/path_platform.h",
"src/main/cpp/util/path_windows.cc"
] | [
"src/main/cpp/util/path_platform.h",
"src/main/cpp/util/path_windows.cc"
] | [
"src/test/cpp/util/file_windows_test.cc",
"src/test/cpp/util/path_windows_test.cc"
] | diff --git a/src/main/cpp/util/path_platform.h b/src/main/cpp/util/path_platform.h
index b0fb88de51c0ad..2b99dba00a40dc 100644
--- a/src/main/cpp/util/path_platform.h
+++ b/src/main/cpp/util/path_platform.h
@@ -82,28 +82,11 @@ std::pair<std::wstring, std::wstring> SplitPathW(const std::wstring &path);
bool IsRootDir... | diff --git a/src/test/cpp/util/file_windows_test.cc b/src/test/cpp/util/file_windows_test.cc
index 6c1ec2f4769a98..cae80e23d687b4 100644
--- a/src/test/cpp/util/file_windows_test.cc
+++ b/src/test/cpp/util/file_windows_test.cc
@@ -44,9 +44,6 @@ using std::string;
using std::unique_ptr;
using std::wstring;
-// Metho... | val | train | 2018-09-13T17:09:19 | 2018-09-13T09:51:31Z | laszlocsomor | test |
bazelbuild/bazel/6162_8821 | bazelbuild/bazel | bazelbuild/bazel/6162 | bazelbuild/bazel/8821 | [
"timestamp(timedelta=86914.0, similarity=0.8436393502010401)"
] | a988673b45c18d0d51e10e12d570dee348481afa | 9d69b734e019c6f7a10b3d25c0c88d76079e29cd | [
"Thanks for bringing this to my attention. We're actually in the middle of a documentation audit this week, and this is exactly the type of issue we want to flag."
] | [] | 2019-07-08T18:39:11Z | [
"type: documentation (cleanup)",
"P2",
"team-Configurability"
] | Toolchain tutorial contradicts ToolchainInfo reference documentation | ### Description of the problem / feature request:
Reference documentation:
https://docs.bazel.build/versions/master/skylark/lib/platform_common.html#ToolchainInfo
> The provider constructor for ToolchainInfo. The constructor takes the type of the toolchain, and a map of the toolchain's data.
Tutorial:
https://... | [
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/ToolchainInfoApi.java"
] | [
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/ToolchainInfoApi.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/ToolchainInfoApi.java b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/ToolchainInfoApi.java
index ab37760d34563f..868c2801950cfa 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/Tool... | null | val | train | 2019-07-08T19:40:00 | 2018-09-16T01:44:39Z | endobson | test |
bazelbuild/bazel/6162_8823 | bazelbuild/bazel | bazelbuild/bazel/6162 | bazelbuild/bazel/8823 | [
"timestamp(timedelta=1.0, similarity=0.8645373485183019)"
] | a988673b45c18d0d51e10e12d570dee348481afa | 88ffc8adddc0c1be28afa1395410c935eea34bc0 | [
"Thanks for bringing this to my attention. We're actually in the middle of a documentation audit this week, and this is exactly the type of issue we want to flag."
] | [] | 2019-07-08T18:39:31Z | [
"type: documentation (cleanup)",
"P2",
"team-Configurability"
] | Toolchain tutorial contradicts ToolchainInfo reference documentation | ### Description of the problem / feature request:
Reference documentation:
https://docs.bazel.build/versions/master/skylark/lib/platform_common.html#ToolchainInfo
> The provider constructor for ToolchainInfo. The constructor takes the type of the toolchain, and a map of the toolchain's data.
Tutorial:
https://... | [
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/PlatformCommonApi.java"
] | [
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/PlatformCommonApi.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/PlatformCommonApi.java b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/PlatformCommonApi.java
index 5db6e4652af868..e07a30b3d20c7f 100644
--- a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/platform/Pl... | null | test | train | 2019-07-08T19:40:00 | 2018-09-16T01:44:39Z | endobson | test |
bazelbuild/bazel/6193_6202 | bazelbuild/bazel | bazelbuild/bazel/6193 | bazelbuild/bazel/6202 | [
"timestamp(timedelta=0.0, similarity=0.9159548986968176)"
] | 7454417833dc240f6ba359ecb2539f19d8da625d | cf9049d5e5b5cdf7027a6b56b5284097ae4f9ae1 | [
"Just for completeness, which NDK revision are you on?",
"@jin r17b"
] | [] | 2018-09-21T15:16:11Z | [
"team-Android",
"untriaged"
] | Cross-compiling for Android (arm) is missing debug symbols (-g) | ### Description of the problem / feature request:
According to the [Compilation Mode Docs](https://docs.bazel.build/versions/master/user-manual.html#flag--compilation_mode), building with `--compilation_mode=dbg` should include `--copt=-g` to request debug symbols.
When building for Android (arm), this flag is no... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r10e/ArmCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r11/ArmCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r12/ArmCrosstools.java",... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r10e/ArmCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r11/ArmCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r12/ArmCrosstools.java",... | [] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r10e/ArmCrosstools.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r10e/ArmCrosstools.java
index b2a7c4a826f156..440b2c9fcd4e8e 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/r... | null | train | train | 2018-09-21T15:28:12 | 2018-09-20T18:43:52Z | jgavris | test |
bazelbuild/bazel/6212_6213 | bazelbuild/bazel | bazelbuild/bazel/6212 | bazelbuild/bazel/6213 | [
"timestamp(timedelta=0.0, similarity=0.9232423870207832)"
] | c1a7b4c574f956c385de5c531383bcab2e01cadd | 6482fcfad739813ddc734646b556b551f4fc7c9a | [] | [] | 2018-09-24T12:05:54Z | [
"type: bug",
"platform: linux"
] | runfiles, python: runfiles library doesn't work for sandboxed binaries | If a `py_binary` runs in a sandbox and uses Bazel's runfiles library (in `@bazel_tools//tools/python/runfiles`), the library fails to initialize.
Repro:
1. create a py_binary with a data-dependency that uses the runfiles library to look up the runfile
2. create a genrule, add the py_binary to its `tools`
3. in th... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt"
] | [
"src/test/py/bazel/BUILD",
"src/test/py/bazel/runfiles_sandboxed_test.py"
] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt b/src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_template.txt
index b4ab41f3312f39..d5fb78fafc3dc3 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/python/python_stub_temp... | diff --git a/src/test/py/bazel/BUILD b/src/test/py/bazel/BUILD
index 57a1671d2f968d..18807473d0bf84 100644
--- a/src/test/py/bazel/BUILD
+++ b/src/test/py/bazel/BUILD
@@ -120,6 +120,18 @@ py_test(
],
)
+py_test(
+ name = "runfiles_sandboxed_test",
+ timeout = "long",
+ srcs = ["runfiles_sandboxed_test.... | test | train | 2018-09-24T14:45:38 | 2018-09-24T11:21:29Z | laszlocsomor | test |
bazelbuild/bazel/6223_6287 | bazelbuild/bazel | bazelbuild/bazel/6223 | bazelbuild/bazel/6287 | [
"timestamp(timedelta=0.0, similarity=0.8708933620718008)"
] | 645a35e1ce0f9f0025e9120399f2e7b77b4841b8 | 483fb2af62fe399aed2916e4d6c54cf1f3da3a67 | [
"`DEVELOPER_DIR` is also missing from the persistent worker env here",
"Ok I think I discovered why this is the case. When building locally we hit this codepath: https://github.com/bazelbuild/bazel/blob/18bd7dec9609ff8924d9ebed5f14be523df4eec0/src/main/java/com/google/devtools/build/lib/sandbox/DarwinSandboxedSpa... | [
"I've seen some different things passed for `/tmp` here, I assume there's something other than this to be more platform agnostic that I should pass?"
] | 2018-10-01T23:32:01Z | [] | Some environment variables not passed to persistent workers | I'm working on creating a persistent worker to support incremental compilation [for Swift](https://github.com/bazelbuild/rules_swift/issues/48). In doing so, the first issue I hit, was the lack of required environment variables being passed to the newly created persistent workers.
When running the builds normally, t... | [
"src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java",
"src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java"
] | [
"src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java",
"src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java b/src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java
index 46bb0dc554547c..df23d6d5d8ad0f 100644
--- a/src/main/java/com/google/devtools/build/lib/worker/WorkerModule.java
+++ b/src/main/java/com/google/devtools/build/li... | null | train | train | 2018-10-01T22:05:13 | 2018-09-24T21:53:21Z | keith | test |
bazelbuild/bazel/6257_6258 | bazelbuild/bazel | bazelbuild/bazel/6257 | bazelbuild/bazel/6258 | [
"timestamp(timedelta=0.0, similarity=0.9999999999999998)"
] | 4348e3ca10f6e2bc1bed925c51524ed78d0059ef | null | [] | [
"Can you use CppFileTypes.C_SOURCE + CPP_SOURCE?",
"That means packing an additional dependency into bazel_tools which makes the binary bigger. I copied those values to Constants.CC_EXTENSIONS and use it here to check if the file is a cc file."
] | 2018-09-26T12:31:49Z | [
"P2",
"coverage",
"team-Rules-CPP"
] | Include coverage results for cc binaries called from sh_test in the Bazel coverage output file | Currently Bazel only outputs coverage results for java binaries called within a sh_test. | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/sh/ShBinary.java"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/sh/ShBinary.java"
] | [
"src/test/shell/bazel/bazel_coverage_test.sh",
"tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Constants.java",
"tools/test/CoverageOutputGenerator/java/com/google/devtools/coverageoutputgenerator/Coverage.java",
"tools/test/CoverageOutputGenerator/java/com/google/devtools... | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java
index 45f5203c76f1e8..c969e4578e22a3 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/rules/sh/BazelShTestRule.java
+++ b/src/main/... | diff --git a/src/test/shell/bazel/bazel_coverage_test.sh b/src/test/shell/bazel/bazel_coverage_test.sh
index a725d214aec057..fa8bf021bc9b8c 100755
--- a/src/test/shell/bazel/bazel_coverage_test.sh
+++ b/src/test/shell/bazel/bazel_coverage_test.sh
@@ -77,7 +77,7 @@ function assert_coverage_result() {
local expected... | train | train | 2018-09-26T14:18:55 | 2018-09-26T12:20:14Z | iirina | test |
bazelbuild/bazel/6271_6936 | bazelbuild/bazel | bazelbuild/bazel/6271 | bazelbuild/bazel/6936 | [
"timestamp(timedelta=21605.0, similarity=0.9246448239924371)"
] | c67dceca77a93646961fc4bb863826e344fda5e0 | 7f3b91a3f332af569a0c062d66518a9feae8a255 | [
"Sounds like a great idea!",
"Just hit this too. It looks like the fix is trivial (adding a no-op `doc` parameter), so I've mailed https://github.com/bazelbuild/bazel/pull/6936 . Note that rules using this param won't work with any older Bazel versions."
] | [] | 2018-12-15T18:40:58Z | [
"type: feature request",
"P2",
"team-ExternalDeps"
] | `repository_rule` should have a `doc` argument | `repository_rule` is similar to `rule`, except it lives on the `WORKSPACE` level. `rule` has a nice `doc` attribute which is extracted by documentation tools. It would be nice if `repository_rule` followed suit.
In [`rules_nixpkgs`](https://github.com/tweag/rules_nixpkgs) and [`rules_haskell`](https://github.com/twe... | [
"src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java",
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/repository/RepositoryModuleApi.java",
"src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java",
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/repository/RepositoryModuleApi.java",
"src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java"
] | [
"src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl"
] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java
index 31846125fc0e6b..d68fff2a12eac6 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/repositor... | diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl b/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl
index d083028376cf84..24a75a703bd7d2 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl
+++ b/src/te... | train | train | 2019-01-17T20:26:01 | 2018-09-28T16:07:35Z | Profpatsch | test |
bazelbuild/bazel/6271_7401 | bazelbuild/bazel | bazelbuild/bazel/6271 | bazelbuild/bazel/7401 | [
"timestamp(timedelta=1.0, similarity=0.9242516503873975)"
] | 5263093ee0cae01e2dd7a36ed83f29bb90850c12 | 0c4541e618d148a6617232147d4b652f27394f35 | [
"Sounds like a great idea!",
"Just hit this too. It looks like the fix is trivial (adding a no-op `doc` parameter), so I've mailed https://github.com/bazelbuild/bazel/pull/6936 . Note that rules using this param won't work with any older Bazel versions."
] | [] | 2019-02-12T11:51:47Z | [
"type: feature request",
"P2",
"team-ExternalDeps"
] | `repository_rule` should have a `doc` argument | `repository_rule` is similar to `rule`, except it lives on the `WORKSPACE` level. `rule` has a nice `doc` attribute which is extracted by documentation tools. It would be nice if `repository_rule` followed suit.
In [`rules_nixpkgs`](https://github.com/tweag/rules_nixpkgs) and [`rules_haskell`](https://github.com/twe... | [
"src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java",
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/repository/RepositoryModuleApi.java",
"src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java",
"src/main/java/com/google/devtools/build/lib/skylarkbuildapi/repository/RepositoryModuleApi.java",
"src/main/java/com/google/devtools/build/skydoc/fakebuildapi/repository/FakeRepositoryModule.java"
] | [
"src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl"
] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/skylark/SkylarkRepositoryModule.java
index a1532dad894b31..61e3884706789c 100644
--- a/src/main/java/com/google/devtools/build/lib/bazel/repositor... | diff --git a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl b/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl
index d083028376cf84..24a75a703bd7d2 100644
--- a/src/test/java/com/google/devtools/build/skydoc/testdata/misc_apis_test/input.bzl
+++ b/src/te... | train | train | 2019-02-12T12:41:53 | 2018-09-28T16:07:35Z | Profpatsch | test |
bazelbuild/bazel/6297_8097 | bazelbuild/bazel | bazelbuild/bazel/6297 | bazelbuild/bazel/8097 | [
"timestamp(timedelta=65146.0, similarity=0.9342796586228654)"
] | a626990141cb77cc7e7973596fce4db7031e92a6 | 21f1c93e527f6c567ee1f8160c66e7b94b75c8f2 | [
"r19 beta 2 is available, r19 is expected to ship soon.\r\n\r\nhttps://developer.android.com/ndk/downloads/",
"NDK 19 has dropped: https://developer.android.com/ndk/downloads/#stable-downloads",
"Link to changelog: https://github.com/android-ndk/ndk/wiki/Changelog-r19",
"After speaking with @hlopko, the right... | [] | 2019-04-18T22:07:45Z | [
"type: feature request",
"P1",
"team-Android"
] | Support NDK r19 | Expected release: Q4 2018
Changes: https://android.googlesource.com/platform/ndk/+/master/docs/Roadmap.md#ndk-r19
* Make all toolchains be standalone toolchains
> Now that the NDK is down to a single compiler and STL, if we just taught the Clang driver to emit -D__ANDROID_API__=foo and to link libc.so.18 ins... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r19/AndroidNdkCrosstoolsR19.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r19/ApiLevel... | [
"src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java",
"src/test/shell/bazel/android/android_ndk_integration_test.sh"
] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java
index d595dfe5b340d2..ab4bd6e30dd20a 100644
--- a/src/main/java/com/google/devtools/build/lib/baz... | diff --git a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java
index c75bad7eb217d4..5260e67ec454c1 100644
--- a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/And... | test | train | 2019-05-31T00:34:50 | 2018-10-03T18:25:55Z | jin | test |
bazelbuild/bazel/6297_8524 | bazelbuild/bazel | bazelbuild/bazel/6297 | bazelbuild/bazel/8524 | [
"timestamp(timedelta=641.0, similarity=0.9231411341872593)"
] | 536a166270590a8dbc701718550383f3a07cc763 | 7446e1fbf85259f3cbb5be3740813e0601f46e54 | [
"r19 beta 2 is available, r19 is expected to ship soon.\r\n\r\nhttps://developer.android.com/ndk/downloads/",
"NDK 19 has dropped: https://developer.android.com/ndk/downloads/#stable-downloads",
"Link to changelog: https://github.com/android-ndk/ndk/wiki/Changelog-r19",
"After speaking with @hlopko, the right... | [] | 2019-05-30T23:43:08Z | [
"type: feature request",
"P1",
"team-Android"
] | Support NDK r19 | Expected release: Q4 2018
Changes: https://android.googlesource.com/platform/ndk/+/master/docs/Roadmap.md#ndk-r19
* Make all toolchains be standalone toolchains
> Now that the NDK is down to a single compiler and STL, if we just taught the Clang driver to emit -D__ANDROID_API__=foo and to link libc.so.18 ins... | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java"
] | [
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r19/AndroidNdkCrosstoolsR19.java",
"src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/r19/ApiLevel... | [
"src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/android/ndkcrosstools/AndroidNdkCrosstools.java
index d595dfe5b340d2..a97ea71b692abe 100644
--- a/src/main/java/com/google/devtools/build/lib/baz... | diff --git a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java b/src/test/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryTest.java
index 0ce4aa1802d6cd..4bfc3cc0dcbdcd 100644
--- a/src/test/java/com/google/devtools/build/lib/bazel/rules/android/And... | train | train | 2019-05-31T01:41:31 | 2018-10-03T18:25:55Z | jin | test |
bazelbuild/bazel/6321_6322 | bazelbuild/bazel | bazelbuild/bazel/6321 | bazelbuild/bazel/6322 | [
"timestamp(timedelta=0.0, similarity=0.9904610207971085)"
] | 2a207cac61e2eb3a308f35ef7feb5a5964526fce | 9226fe4a5c00957645ddde0d2d6bf3d08da0a170 | [
"Release blocker for 0.18 #5963 "
] | [
"the legacy behavior would be to have this hidden behind --master_blazerc, in case that matters to you at this point"
] | 2018-10-05T14:05:44Z | [
"P0"
] | Temporarily restore processing of workspace-wide tools/bazel.rc file | Mitigate widespread breakage that occured after landing https://github.com/bazelbuild/bazel/issues/5765 by implementing the fix proposed in https://groups.google.com/d/msg/bazel-discuss/ycDacctX2vw/EGFxGLibAgAJ.
This introduces a weird new behavior that not fully compatible with either the old or the new (per #5765)... | [
"src/main/cpp/option_processor.cc"
] | [
"src/main/cpp/option_processor.cc"
] | [
"src/test/cpp/rc_file_test.cc"
] | diff --git a/src/main/cpp/option_processor.cc b/src/main/cpp/option_processor.cc
index 04f7f4f8ff60c8..8fc06b66b4a86a 100644
--- a/src/main/cpp/option_processor.cc
+++ b/src/main/cpp/option_processor.cc
@@ -322,6 +322,9 @@ blaze_exit_code::ExitCode OptionProcessor::GetRcFiles(
SearchNullaryOption(cmd_line->start... | diff --git a/src/test/cpp/rc_file_test.cc b/src/test/cpp/rc_file_test.cc
index 711e7b655e8843..f0a9744d19deb0 100644
--- a/src/test/cpp/rc_file_test.cc
+++ b/src/test/cpp/rc_file_test.cc
@@ -261,8 +261,39 @@ TEST_F(GetRcFileTest, GetRcFilesWarnsAboutIgnoredMasterRcFiles) {
// read as expected.
EXPECT_THAT(output,... | train | train | 2018-10-05T13:14:34 | 2018-10-05T14:02:28Z | dslomov | test |
bazelbuild/bazel/6323_6326 | bazelbuild/bazel | bazelbuild/bazel/6323 | bazelbuild/bazel/6326 | [
"timestamp(timedelta=0.0, similarity=0.8946550413544082)"
] | 3aca5780154f2bc177e90b87186a421bdd14cc91 | 8a13698d24a81980d35d6bbba326cab109855301 | [
"This can also be reproduced easily on a Linux system directly:\r\n\r\n- Check out the Bazel source code.\r\n- Change the line endings of `tools/genrule/genrule-setup.sh` to CRLF (e.g., using `:set ff=dos` in Vim and saving the file).\r\n- Run it directly using Bash. It will print the same errors as shown above."
] | [] | 2018-10-05T20:24:13Z | [
"P1",
"area-Windows",
"untriaged",
"team-OSS"
] | On Windows, genrule-setup.sh contains carriage returns | ### Description of the problem / feature request:
On both a Linux and a Windows box, I have Bazel 0.17.2 installed. On the Linux system, the copy of `tools/genrule/genrule-setup.sh` is 858 bytes in size, whereas the copy shipped with the Windows version of Bazel is 882 bytes in size. The former uses NL, whereas the ... | [
".gitattributes"
] | [
".gitattributes"
] | [] | diff --git a/.gitattributes b/.gitattributes
index c0f7b6a44d1b9c..35e4e72eeb31a1 100644
--- a/.gitattributes
+++ b/.gitattributes
@@ -1,3 +1,6 @@
*.bzl linguist-language=Python
BUILD linguist-language=Python
site/* linguist-documentation
+
+# Files that should not use CRLF line endings, even on Windows.
+tools/genr... | null | train | train | 2018-10-05T22:14:03 | 2018-10-05T17:39:31Z | EdSchouten | test |
bazelbuild/bazel/6351_7473 | bazelbuild/bazel | bazelbuild/bazel/6351 | bazelbuild/bazel/7473 | [
"timestamp(timedelta=0.0, similarity=0.873985520432397)"
] | a57c879dbca95316ecf50f5e96143eb9f7d1acb8 | 8517554049a44c6935d73eeac9e557e85c97509c | [
"@laszlocsomor there should be only one team label. Is that better for your team or for External dependencies?",
"I cannot tell. We have the Windows expertise, the Ext.Deps team has the rule logic expertise.",
"I spent some time with #7063 so I'm also investigating this bug now.",
"More observation:\r\n- When... | [] | 2019-02-20T09:31:32Z | [
"type: bug",
"P1",
"area-Windows",
"team-OSS"
] | Windows: new_local_repository doesn't reevaluate glob | ### Description of the problem / feature request:
If a "new_local_repository" rule with "build_file_content" creates a rule with a glob, and a rule in the main repo depends on this one, then Bazel on Windows won't detect changes of the glob. (It does on Linux.)
### Bugs: what's the simplest, easiest way to reprod... | [
"src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/DirectoryListingStateFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ExternalFilesHelper.java",
"src/main/java/com/google/devtools/build/lib/skyfr... | [
"src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/DirectoryListingStateFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ExternalFilesHelper.java",
"src/main/java/com/google/devtools/build/lib/skyfr... | [
"src/test/shell/bazel/BUILD",
"src/test/shell/bazel/new_local_repo_test.sh"
] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java b/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java
index ee2141dce465bc..f037d79339f5e8 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryFunction.java
... | diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD
index dc9f3033f44de2..547c888b35ec9b 100644
--- a/src/test/shell/bazel/BUILD
+++ b/src/test/shell/bazel/BUILD
@@ -806,3 +806,10 @@ sh_test(
data = [":test-deps"],
deps = ["@bazel_tools//tools/bash/runfiles"],
)
+
+sh_test(
+ name = "new_... | train | train | 2019-02-20T09:55:17 | 2018-10-10T20:41:48Z | laszlocsomor | test |
bazelbuild/bazel/6362_6424 | bazelbuild/bazel | bazelbuild/bazel/6362 | bazelbuild/bazel/6424 | [
"timestamp(timedelta=0.0, similarity=0.8539077854347784)"
] | 486a2fb12281408187951d83e7c46c3c80e96afd | 2328f423155e44183e507078ff075bd219ed1e2b | [
"Can you provide example output showing where the message should be?",
"This is a snippet from an output from a failed build for TF:\r\n\r\nERROR: /tmpfs/tmp/bazel/external/org_tensorflow/third_party/toolchains/preconfig/ubuntu14.04/cuda9.0-cudnn7/cuda/BUILD:206:1: Couldn't build file external/org_tensorflow/thir... | [
"nit: Bogus indentation, here and below.",
"Why null? Why cannot we use the same value as in the branch below?",
"Why all these no-op changes here? I mean, I guess they're fine, but they make it harder to see what actually changed :)",
"Sorry, I just wanted to shorten my new target, but my regex was a little ... | 2018-10-17T15:49:53Z | [
"type: feature request",
"P1",
"team-Configurability"
] | Print platform info with error message when -versbose_failures is selected |
### Description of the problem / feature request:
Feature Request: Print platform info with error message when -verbose_failures is selected.
If a user passes the verbose_failures and the build fails, the error message should include some info about which platform was used to run the failed action.
### Featu... | [
"src/main/java/com/google/devtools/build/lib/BUILD",
"src/main/java/com/google/devtools/build/lib/actions/BUILD",
"src/main/java/com/google/devtools/build/lib/exec/AbstractSpawnStrategy.java",
"src/main/java/com/google/devtools/build/lib/query2/BUILD",
"src/main/java/com/google/devtools/build/lib/sandbox/Ab... | [
"src/main/java/com/google/devtools/build/lib/BUILD",
"src/main/java/com/google/devtools/build/lib/actions/BUILD",
"src/main/java/com/google/devtools/build/lib/exec/AbstractSpawnStrategy.java",
"src/main/java/com/google/devtools/build/lib/query2/BUILD",
"src/main/java/com/google/devtools/build/lib/sandbox/Ab... | [
"src/test/java/com/google/devtools/build/lib/BUILD",
"src/test/java/com/google/devtools/build/lib/util/CommandFailureUtilsTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/BUILD b/src/main/java/com/google/devtools/build/lib/BUILD
index 42c7e7fd28831a..3ed78099f9601c 100644
--- a/src/main/java/com/google/devtools/build/lib/BUILD
+++ b/src/main/java/com/google/devtools/build/lib/BUILD
@@ -100,7 +100,7 @@ java_library(
"//con... | diff --git a/src/test/java/com/google/devtools/build/lib/BUILD b/src/test/java/com/google/devtools/build/lib/BUILD
index 147f68e698923a..31a9ef2225b561 100644
--- a/src/test/java/com/google/devtools/build/lib/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -318,9 +318,12 @@ java_test(
":guava_... | train | train | 2018-10-17T17:12:26 | 2018-10-11T19:03:06Z | nlopezgi | test |
bazelbuild/bazel/6405_6609 | bazelbuild/bazel | bazelbuild/bazel/6405 | bazelbuild/bazel/6609 | [
"timestamp(timedelta=1.0, similarity=0.8519683283943104)"
] | 6a30ed637c7d2e4c33edca566d0912a8f9235792 | 2732641bfdd471e2dcff4ebaaf1a290768e34d38 | [] | [] | 2018-11-06T10:56:20Z | [
"type: bug",
"P2",
"category: misc > testing",
"area-EngProd",
"team-OSS"
] | Bazel CI: not running tests for Singlejar | ### Description of the problem / feature request:
It seems that the Bazel CI does not run tests in `//src/tools/singlejar:*`. | [
".bazelci/postsubmit.yml",
".bazelci/presubmit.yml"
] | [
".bazelci/postsubmit.yml",
".bazelci/presubmit.yml"
] | [] | diff --git a/.bazelci/postsubmit.yml b/.bazelci/postsubmit.yml
index 4ec4608b7ee5f9..e09d58352b38ee 100644
--- a/.bazelci/postsubmit.yml
+++ b/.bazelci/postsubmit.yml
@@ -13,10 +13,9 @@ platforms:
- "--"
- "//scripts/..."
- "//src/test/..."
+ - "//src/tools/singlejar/..."
- "//third_party/ijar/..... | null | train | train | 2018-11-06T11:54:39 | 2018-10-16T12:00:35Z | laszlocsomor | test |
bazelbuild/bazel/6412_6446 | bazelbuild/bazel | bazelbuild/bazel/6412 | bazelbuild/bazel/6446 | [
"timestamp(timedelta=2.0, similarity=0.8870653956623342)"
] | 021684f61aba4a3f27231f5fbac642f635339e50 | 7a66d27c1eaac0ef8da8f46c71d0fa4c6d9fa689 | [
"I think such PR will be welcome - any objections @philwo ?",
"That would be great, yes. Thanks!"
] | [] | 2018-10-18T21:37:02Z | [
"type: feature request",
"P2",
"area-EngProd",
"team-OSS"
] | Debian package should only suggest JDK instead of depending on it | Right now the published Debian / Ubuntu package declares a (hard) dependency to a Java SDK. But the bazel version included in the `deb` file is already a standalone one that comes with a bundled Java runtime.
Would you accept a PR which downgrades the `Depends` to a `Suggests`? The [Debian Policy](https://www.debian... | [
"scripts/packages/debian/BUILD",
"scripts/packages/debian/control"
] | [
"scripts/packages/debian/BUILD",
"scripts/packages/debian/control"
] | [] | diff --git a/scripts/packages/debian/BUILD b/scripts/packages/debian/BUILD
index b809983fab3b15..a54e43cad39027 100644
--- a/scripts/packages/debian/BUILD
+++ b/scripts/packages/debian/BUILD
@@ -9,12 +9,12 @@ load("//tools/build_defs/pkg:pkg.bzl", "pkg_tar", "pkg_deb")
pkg_tar(
name = "bazel-bin",
srcs = [
-... | null | test | train | 2018-10-24T21:50:51 | 2018-10-16T23:18:14Z | gjasny | test |
bazelbuild/bazel/6449_6620 | bazelbuild/bazel | bazelbuild/bazel/6449 | bazelbuild/bazel/6620 | [
"timestamp(timedelta=0.0, similarity=0.8461699383865314)"
] | c67dceca77a93646961fc4bb863826e344fda5e0 | d007bc19054e23aaf35d119212cae8036b4042c9 | [
"Confirmed the behavior you're seeing.\r\n\r\nFrom what I can see from the review history, it looks like there was never any design intention to exclude config_setting from aliases. Pinging @lberki for confirmation or rebuttal.\r\n\r\nAs to your deeper goal, that's an interesting use of the feature. It seems like a... | [
"Are you sure this works for `package_group` and `test_suite`? Is this functionality tested? `test_suite` rules are (unfortunately) special-cased in a number of ways e.g. in `bazel query` and other places expanding them (unfortunately, we have more than one) and I have no idea whether aliases are taken into account... | 2018-11-07T02:51:07Z | [
"type: documentation (cleanup)",
"P3",
"team-Configurability"
] | Documentation/behavior mismatch with alias + config_setting | ### Description of the problem / feature request:
The [documentation](https://docs.bazel.build/versions/master/be/general.html#alias) claims that:
> Aliasing only works for "regular" targets. In particular, package_group, config_setting and test_suite rules cannot be aliased.
However, this does not seem to be accu... | [
"src/main/java/com/google/devtools/build/lib/rules/Alias.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/Alias.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/Alias.java b/src/main/java/com/google/devtools/build/lib/rules/Alias.java
index ed8d164f02a61d..806a91199e954d 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/Alias.java
+++ b/src/main/java/com/google/devtools/build/lib/rules/Alias.java
@@ -9... | null | train | train | 2019-01-17T20:26:01 | 2018-10-19T13:41:59Z | jfancher | test |
bazelbuild/bazel/6462_7666 | bazelbuild/bazel | bazelbuild/bazel/6462 | bazelbuild/bazel/7666 | [
"timestamp(timedelta=0.0, similarity=0.8592612044934141)"
] | de0612ad3ef7cc8c44069261befdeb0d15b97c10 | a8e7a2073ca86039a730b7c0fa13111c886deeac | [
"This is a bad first-time experience. See https://github.com/bazelbuild/bazel/issues/5254",
"@laszlocsomor \r\n\r\nI get the same error: `Bazel on Windows requires MSYS2 Bash, but we could not find it` for every command using the binaries for Bazel provided by the `@bazel/bazel` v0.20.0 npm package.\r\n\r\nSo th... | [] | 2019-03-07T14:15:25Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows: Bazel requires MSYS for every command | ### Description of the problem / feature request:
On a fresh Windows 10 installation with only Bazel 0.18.0 and MSVC redistributable DLLs [1] and _without_ MSYS, running any command in a minimal workspace (just an empty WORKSPACE file) requires MSYS bash.
[1] https://download.microsoft.com/download/9/3/F/93FCF1E7... | [
"src/main/cpp/blaze.cc",
"src/main/cpp/blaze_util_platform.h",
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/main/cpp/blaze.cc",
"src/main/cpp/blaze_util_platform.h",
"src/main/cpp/blaze_util_windows.cc"
] | [] | diff --git a/src/main/cpp/blaze.cc b/src/main/cpp/blaze.cc
index f31155ff0a6cdb..da1dc5ff175c5b 100644
--- a/src/main/cpp/blaze.cc
+++ b/src/main/cpp/blaze.cc
@@ -1546,7 +1546,7 @@ int Main(int argc, const char *argv[], WorkspaceLayout *workspace_layout,
// Must be done before command line parsing.
// ParseOption... | null | test | train | 2019-03-07T15:08:49 | 2018-10-22T13:23:23Z | laszlocsomor | test |
bazelbuild/bazel/6463_6466 | bazelbuild/bazel | bazelbuild/bazel/6463 | bazelbuild/bazel/6466 | [
"timestamp(timedelta=0.0, similarity=0.843525691914465)"
] | 2087584e6085c72bbbd63f108b09773b75306314 | 623f8a41190d703b39bba4a52b1c3c0640fffddb | [
"This is a bad first-time experience. See https://github.com/bazelbuild/bazel/issues/5254"
] | [] | 2018-10-22T14:28:43Z | [
"type: bug",
"P3",
"area-Windows",
"team-OSS"
] | Windows: Bazel ostensibly requires Python for every command | ### Description of the problem / feature request:
Bazel complains if it cannot find Python on that PATH, for every command. However, it also carries out the commands successfully.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
On a fresh Windows ... | [
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/test/py/bazel/BUILD",
"src/test/py/bazel/first_time_use_test.py"
] | diff --git a/src/main/cpp/blaze_util_windows.cc b/src/main/cpp/blaze_util_windows.cc
index 3f3f8bfbb935e1..8d57784d3f8ff0 100644
--- a/src/main/cpp/blaze_util_windows.cc
+++ b/src/main/cpp/blaze_util_windows.cc
@@ -1437,7 +1437,6 @@ static string GetBinaryFromPath(const string& binary_name) {
start = end + 1;
}... | diff --git a/src/test/py/bazel/BUILD b/src/test/py/bazel/BUILD
index 1116e039c247ff..d5f59d680c4530 100644
--- a/src/test/py/bazel/BUILD
+++ b/src/test/py/bazel/BUILD
@@ -166,6 +166,12 @@ py_test(
}),
)
+py_test(
+ name = "first_time_use_test",
+ srcs = ["first_time_use_test.py"],
+ deps = [":test_base... | train | train | 2018-10-22T14:28:20 | 2018-10-22T13:29:09Z | laszlocsomor | test |
bazelbuild/bazel/6469_6910 | bazelbuild/bazel | bazelbuild/bazel/6469 | bazelbuild/bazel/6910 | [
"timestamp(timedelta=25713.0, similarity=0.851142177143935)"
] | c10468878027305d9b1ccc1a9dfbde956b788dc6 | 5a062b974a1421bad2e4c4424fc1a232c9c0f7f9 | [
"cc @katre, since this is new in `0.19` (#6116), but probably not a release blocker.",
"This is a small enough use-case that I don't want to risk a breakage due to cherrypick. We should try and address it for 0.20, however.",
"I'm getting the same error message for **non-symlinks** on Windows with Bazel 0.19.0:... | [
"nit: not that this is very important, but can you maybe get away with `$TEST_TMPDIR` instead? It's kinda confusing because `$HOME` usually means, well, the home directory of some user.",
"nit: DedupeBazelRcPaths? (it's not a getter)\r\n\r\nAlso, why \"Existing\"? It doesn't check existence, does it?",
"On Linu... | 2018-12-13T10:03:16Z | [
"untriaged",
"team-Bazel"
] | Bazel shows bogus WARNING for the rc files, if they are symlinks. | ### Description of the problem / feature request:
Bazel shows bogus `WARNING` for the rc files, if they are symlinks:
```
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
/tmp/workspace/.bazelrc
```
But the rc fi... | [
"src/main/cpp/blaze_util.cc",
"src/main/cpp/blaze_util.h",
"src/main/cpp/blaze_util_windows.cc",
"src/main/cpp/option_processor-internal.h",
"src/main/cpp/option_processor.cc",
"src/main/cpp/rc_file.cc",
"src/main/cpp/rc_file.h",
"src/main/cpp/startup_options.cc"
] | [
"src/main/cpp/blaze_util.cc",
"src/main/cpp/blaze_util.h",
"src/main/cpp/blaze_util_windows.cc",
"src/main/cpp/option_processor-internal.h",
"src/main/cpp/option_processor.cc",
"src/main/cpp/rc_file.cc",
"src/main/cpp/rc_file.h",
"src/main/cpp/startup_options.cc"
] | [
"src/test/cpp/rc_file_test.cc"
] | diff --git a/src/main/cpp/blaze_util.cc b/src/main/cpp/blaze_util.cc
index d8ec359515f779..858ac4e73ad1e5 100644
--- a/src/main/cpp/blaze_util.cc
+++ b/src/main/cpp/blaze_util.cc
@@ -181,6 +181,10 @@ void SetDebugLog(bool enabled) {
}
}
+bool IsRunningWithinTest() {
+ return !GetEnv("TEST_TMPDIR").empty();
+}
+
... | diff --git a/src/test/cpp/rc_file_test.cc b/src/test/cpp/rc_file_test.cc
index 01a4d5aecd37f4..a358ba712f2c0b 100644
--- a/src/test/cpp/rc_file_test.cc
+++ b/src/test/cpp/rc_file_test.cc
@@ -173,8 +173,8 @@ TEST_F(GetRcFileTest, GetRcFilesLoadsAllDefaultBazelrcs) {
ASSERT_EQ(2, parsed_rcs.size());
const std::dequ... | test | train | 2018-12-13T01:31:06 | 2018-10-23T00:13:25Z | PiotrSikora | test |
bazelbuild/bazel/6474_6497 | bazelbuild/bazel | bazelbuild/bazel/6474 | bazelbuild/bazel/6497 | [
"timestamp(timedelta=1.0, similarity=0.9130243255272305)"
] | 6c17197df37533b179cbe2e239e2e10b9f01b746 | 3f2efb99cb6af46c127f2340813b188c3f80f120 | [
"This is a bad first-time user experience: MSYS is required just to run `bazel info`. (And also to build C++ without any genrule dependencies.) See https://github.com/bazelbuild/bazel/issues/5254",
"The reason I care about this scenario, even though the repro requires commenting out code, is because I'd like to f... | [
"2018?",
"don't you have to enable extensions to use `::` for comments?",
"stale comment?",
"`exit /b 1` ?",
"Flipping the branches to get `if [condition] then [action] else [alternative]` is easier to read than `if not [condition] then [alternative] else [action]`.",
"Done",
"No, `::` is just like `#` ... | 2018-10-24T11:55:47Z | [
"type: bug",
"area-Windows",
"team-OSS"
] | Windows, C++: windows_cc_configure.bzl requires BAZEL_SH | ### Description of the problem / feature request:
`windows_cc_configure.bzl` breaks if `BAZEL_SH` is unset.
Setting `BAZEL_SH` to point to a fake Bash (`c:\src\fake-msys\usr\bin\bash.exe` -- a binary I wrote that just dumps its arguments and exits with 1) works around the problem.
### Bugs: what's the simplest... | [
"tools/cpp/vc_installation_error.bat.tpl",
"tools/cpp/windows_cc_configure.bzl"
] | [
"tools/cpp/msys_gcc_installation_error.bat",
"tools/cpp/vc_installation_error.bat.tpl",
"tools/cpp/windows_cc_configure.bzl"
] | [] | diff --git a/tools/cpp/msys_gcc_installation_error.bat b/tools/cpp/msys_gcc_installation_error.bat
new file mode 100644
index 00000000000000..25c35534f97533
--- /dev/null
+++ b/tools/cpp/msys_gcc_installation_error.bat
@@ -0,0 +1,23 @@
+:: Copyright 2018 The Bazel Authors. All rights reserved.
+::
+:: Licensed under th... | null | test | train | 2018-10-24T13:43:30 | 2018-10-23T12:20:12Z | laszlocsomor | test |
bazelbuild/bazel/6544_6562 | bazelbuild/bazel | bazelbuild/bazel/6544 | bazelbuild/bazel/6562 | [
"timestamp(timedelta=0.0, similarity=0.9244399942700263)"
] | 5e5832cc7d258dbdbcc2123d58fa6835a7f21333 | bde6c0fd57f9d5d9651cf0c06814c681a302ed25 | [
"A small enhancement: discovering the issue(s) the contributor's commit(s) closes, and linking to those issues too.\r\n\r\ne.g.\r\n\r\n```\r\nThis release contains contributions from many people at Google, as well as:\r\n\r\n* Jane Doe: #1234 Fixes foo bug, #1235 Added bar feature\r\n* John Doe: #1236 Improved baz ... | [] | 2018-10-31T15:01:34Z | [
"type: feature request",
"P2",
"area-EngProd",
"team-OSS"
] | Release note generator should add contributors list | Currently, we're manually adding the list of contributors to thank to the release notes: we should instead be generating this.
Current script:
```
git log <previous version baseline>..<current version baseline> --format="%aN <%aE>" | sort | uniq | grep -v 'google\.com' | cut -d '<' -f 1
``` | [
"scripts/release/relnotes.sh"
] | [
"scripts/release/relnotes.sh"
] | [] | diff --git a/scripts/release/relnotes.sh b/scripts/release/relnotes.sh
index c1598c6f50aec6..6557cefe23c214 100755
--- a/scripts/release/relnotes.sh
+++ b/scripts/release/relnotes.sh
@@ -124,8 +124,9 @@ function __format_release_notes() {
# Create the release notes since commit $1 ($2...${[#]} are the cherry-picks,
#... | null | train | train | 2018-10-31T15:53:37 | 2018-10-29T17:07:38Z | katre | test |
bazelbuild/bazel/6558_6564 | bazelbuild/bazel | bazelbuild/bazel/6558 | bazelbuild/bazel/6564 | [
"timestamp(timedelta=0.0, similarity=0.944254643173867)"
] | 2126d94b7c415aeed2343175aa60410626edd6c3 | 0cb92d09fe44a04283d3bbd11a6d81f0d8ad5486 | [
"@spomorski, we have https://docs.bazel.build/versions/master/be/common-definitions.html, where should the `exec_compatible_with` attribute be documented? It can currently be used with any test rule, and shell rule, or genrule, but we may expand that set in the future.",
"I think that page is fine. You didn't men... | [
"\"The\" -> \"A\" and mention they're not the only ones. How about:\r\n\r\n> A list of <...>constraint_values</...> that must be present in the execution platform for this target. This is in addition to any constraints already imposed by the rule type. Constraints are used to restrict the list of available executio... | 2018-10-31T16:51:11Z | [
"type: documentation (cleanup)",
"P1",
"team-Configurability"
] | Document the exec_compatible_with attribute | We should document the `exec_compatible_with` attribute that can be used to influence the execution platform for a specific target. | [
"site/docs/platforms.md",
"site/docs/toolchains.md",
"src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java"
] | [
"site/docs/platforms.md",
"site/docs/toolchains.md",
"src/main/java/com/google/devtools/build/docgen/PredefinedAttributes.java",
"src/main/java/com/google/devtools/build/docgen/templates/attributes/common/exec_compatible_with.html"
] | [] | diff --git a/site/docs/platforms.md b/site/docs/platforms.md
index 8935ebbff69e1d..4c3079e2b59e52 100644
--- a/site/docs/platforms.md
+++ b/site/docs/platforms.md
@@ -27,8 +27,7 @@ appropriate
for build actions. Platforms can also be used in combination with the
[config_setting](be/general.html#config_setting)
rule ... | null | train | train | 2018-10-31T17:14:43 | 2018-10-30T19:18:19Z | katre | test |
bazelbuild/bazel/6589_6599 | bazelbuild/bazel | bazelbuild/bazel/6589 | bazelbuild/bazel/6599 | [
"timestamp(timedelta=6128.0, similarity=0.8487044611062099)"
] | a8e2c2e2dbc7e5db02ab08c1077f31a2f9873e56 | 6b9f2aa65849f4a115a0135a00934e433fcdeec3 | [
"Thanks for the detailed bug report! :) I agree that this should be cleaned up.\r\nI think your suggestion to guard this #define with an #ifndef block is fine.\r\n\r\nI'll fix this right now."
] | [] | 2018-11-05T18:50:29Z | [
"type: bug",
"P2",
"category: misc > misc",
"area-EngProd",
"team-OSS"
] | __STDC_FORMAT_MACROS warning when bootstrapping on macOS | ### Description of the problem / feature request:
When building Bazel "from scratch" on macOS, the following warning is emitted:
```
INFO: From Compiling src/tools/singlejar/output_jar.cc:
In file included from src/tools/singlejar/output_jar.cc:18:
In file included from ./src/tools/singlejar/output_jar.h:31:
... | [
"src/tools/singlejar/transient_bytes.h"
] | [
"src/tools/singlejar/transient_bytes.h"
] | [] | diff --git a/src/tools/singlejar/transient_bytes.h b/src/tools/singlejar/transient_bytes.h
index c7577aeee3294d..fb239620e39740 100644
--- a/src/tools/singlejar/transient_bytes.h
+++ b/src/tools/singlejar/transient_bytes.h
@@ -14,6 +14,7 @@
#ifndef SRC_TOOLS_SINGLEJAR_TRANSIENT_BYTES_H_
#define SRC_TOOLS_SINGLEJAR_TR... | null | train | train | 2018-11-05T19:44:50 | 2018-11-04T04:26:54Z | apjanke | test |
bazelbuild/bazel/6592_7335 | bazelbuild/bazel | bazelbuild/bazel/6592 | bazelbuild/bazel/7335 | [
"timestamp(timedelta=46216.0, similarity=0.8406726706695553)"
] | 9b1fe14802fbf74c2ad1257d0a614d663d7818bd | c5856c75ff754061b80385f8da1b5309c8c1ef30 | [
"Cc @lberki @iirina ",
"Related: #6661.",
"@Monnoroch There's no requirement anymore to have the same embedded JDK version as we use for the host javabase so #6661 is talking about updating the JDK version, it's a different JDK.\r\n\r\nIndependently, we also plan to upgrade the embedded JDK after we have submit... | [] | 2019-02-02T23:24:52Z | [
"type: feature request",
"P2",
"area-EngProd",
"team-Rules-Java",
"team-OSS"
] | Update embedded JDK to 11 to fix a host of docker related issues | ### Description of the problem / feature request:
As far as I can tell bazel is currently coming embedded with openjdk 9 and it is having issues with easily running out of memory in docker containers (most prominently CircleCI it seems), or more generically not respecting cgroups for resource limits.
issues I cou... | [
"WORKSPACE"
] | [
"WORKSPACE"
] | [] | diff --git a/WORKSPACE b/WORKSPACE
index 7f4b66eb29a675..1b8f7685255a43 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -131,9 +131,9 @@ http_file(
http_file(
name = "openjdk_linux_vanilla",
downloaded_file_path = "zulu-linux-vanilla.tar.gz",
- sha256 = "232b1c3511f0d26e92582b7c3cc363be7ac633e371854ca2f2e9f2b50... | null | train | train | 2019-02-02T17:40:48 | 2018-11-05T08:28:52Z | Globegitter | test |
bazelbuild/bazel/6613_6616 | bazelbuild/bazel | bazelbuild/bazel/6613 | bazelbuild/bazel/6616 | [
"timestamp(timedelta=73717.0, similarity=0.845320405934995)"
] | ee28af4f86783fa84cc1c0d96ca0eca9bb7bf1d0 | 57bb91e794eb89f2989f6b7bffca09333305e011 | [
"After some debugging, the problem is much simpler: the `--extra_toolchains` flag was not allowing multiple uses, so the last value passed was replacing the previous ones.\r\n\r\nI'll send a patch to fix that, until that is released you can use the multiple value format:\r\n```\r\nbazel build --extra_toolchains=//t... | [] | 2018-11-06T19:33:39Z | [
"type: bug",
"P2",
"team-Configurability"
] | Multiple toolchain rules unable to use same implementation | ### Description of the problem / feature request:
Look at the toolchain rules added by https://github.com/bazelbuild/rules_docker/pull/559 in //toolchains/docker/BUILD. There are three toolchains of //toolchains/docker:toolchain_type using the same implementation function. Bazel appears to arbitrarily pick one of th... | [
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainContext.java",
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ToolchainR... | [
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainContext.java",
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ToolchainResolutionFunction.java",
"src/main/java/com/google/devtools/build/lib/skyframe/ToolchainR... | [
"src/test/java/com/google/devtools/build/lib/BUILD",
"src/test/java/com/google/devtools/build/lib/analysis/ToolchainResolverTest.java",
"src/test/java/com/google/devtools/build/lib/rules/platform/ToolchainTestCase.java",
"src/test/java/com/google/devtools/build/lib/skyframe/RegisteredToolchainsFunctionTest.ja... | diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ToolchainContext.java b/src/main/java/com/google/devtools/build/lib/analysis/ToolchainContext.java
index 35c70054e8a508..368b53f4140407 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/ToolchainContext.java
+++ b/src/main/java/com/google... | diff --git a/src/test/java/com/google/devtools/build/lib/BUILD b/src/test/java/com/google/devtools/build/lib/BUILD
index 4a2b649c335f24..d29b4a78684b04 100644
--- a/src/test/java/com/google/devtools/build/lib/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -812,6 +812,7 @@ java_test(
"//src/ma... | val | train | 2018-11-06T20:30:11 | 2018-11-06T16:36:37Z | smukherj1 | test |
bazelbuild/bazel/6619_7061 | bazelbuild/bazel | bazelbuild/bazel/6619 | bazelbuild/bazel/7061 | [
"timestamp(timedelta=0.0, similarity=0.916451556493324)"
] | bb3989bfe2f3bc824d4c3cddd044db91d6d19662 | e037f6930224fcdf958563d0ae5732bb86332de6 | [
"cc @lberki ",
"Doc for java_import is also broken:\r\n\r\n0.20.0: https://docs.bazel.build/versions/0.20.0/be/java.html#java_import \r\n\r\njava_import(name, deps, data, compatible_with, constraints, deprecation, distribs, exports, features, jars, licenses, neverlink, proguard_specs, restricted_to, runtime_deps,... | [] | 2019-01-08T22:29:36Z | [
"type: documentation (cleanup)",
"P1",
"team-Rules-Java"
] | Documentation for certain rules is missing | ### Description of the problem / feature request:
Documentation for certain rules (for example `java_toolchain`) is missing on latest docs.build.bazel.
### Feature requests: what underlying problem are you trying to solve with this feature?
Read the docs.
### Bugs: what's the simplest, easiest way to reprod... | [
"src/main/java/com/google/devtools/build/lib/BUILD"
] | [
"src/main/java/com/google/devtools/build/lib/BUILD"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/BUILD b/src/main/java/com/google/devtools/build/lib/BUILD
index 72ceb6e411f4b3..d8ca8af2c5dadc 100644
--- a/src/main/java/com/google/devtools/build/lib/BUILD
+++ b/src/main/java/com/google/devtools/build/lib/BUILD
@@ -1385,6 +1385,7 @@ filegroup(
"//src/... | null | train | train | 2019-01-08T23:12:32 | 2018-11-07T02:34:18Z | uri-canva | test |
bazelbuild/bazel/6626_6629 | bazelbuild/bazel | bazelbuild/bazel/6626 | bazelbuild/bazel/6629 | [
"timestamp(timedelta=21022.0, similarity=0.8786289929358719)"
] | 250da1022b34c31d562246a0ca3760a7bde8f07e | 5c84ee1b77c5b12f9a0ce3b0bc4149df5f0ec63a | [
"@laurentlb, is this possibly related to ea4840042b0c087685ab4faffab58ba6906b06f5?",
"Testing locally, the docs render correctly.",
"Actually, no, they just break differently. Still investigating.",
"There are two issues, I think.\r\n\r\n- The HTML is broken. I'm fixing it. With the fix, page should render co... | [] | 2018-11-07T19:20:32Z | [
"type: bug",
"type: documentation (cleanup)",
"P1",
"team-Bazel"
] | Broken formatting for packaging rules | See [packaging rules docs](https://docs.bazel.build/versions/master/be/pkg.html#pkg_tar).
Formatting is very broken, tables render correctly but headers do not, italics start and stop at various places.
![packaging_rules_formatting](https://user-images.githubusercontent.com/326527/48152495-14fc9400-e292-11e8-8994-1... | [
"tools/build_defs/pkg/README.md"
] | [
"tools/build_defs/pkg/README.md"
] | [] | diff --git a/tools/build_defs/pkg/README.md b/tools/build_defs/pkg/README.md
index b1b962fc42136b..445e38602f82c5 100644
--- a/tools/build_defs/pkg/README.md
+++ b/tools/build_defs/pkg/README.md
@@ -118,7 +118,7 @@ Creates a tar file from a list of inputs.
<code>String, default to 'tar'</code>
<p>
... | null | val | train | 2018-11-07T20:18:09 | 2018-11-07T18:36:12Z | katre | test |
bazelbuild/bazel/6685_7023 | bazelbuild/bazel | bazelbuild/bazel/6685 | bazelbuild/bazel/7023 | [
"timestamp(timedelta=0.0, similarity=0.8540919667945694)"
] | 40d1dc94dbd1c86acda8d0632445da1a42054506 | 08f53c26313d2eeca0617072b87af6aa9f0de749 | [
"I also had this issue with Chrome. I have no idea why this error exists but you could just add in a DisplayName with the registry editor. I went into regedit to: `Computer\\HKEY_CURRENT_USER\\Software\\Microsoft\\Windows\\CurrentVersion\\Uninstall\\Google Chrome` and added in a new `String Value` and called it \"D... | [] | 2019-01-02T12:37:00Z | [
"type: bug",
"P3",
"area-Windows",
"team-OSS"
] | Windows: "Failed to query DisplayName of" in Bazel client | ### Description of the problem / feature request:
Bazel displays:
```
ERROR: Failed to query DisplayName of HKCU\Software\Microsoft\Windows\CurrentVersion\Uninstall\Free mp3 Wma Converter
```
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
http... | [
"src/main/cpp/blaze_util_windows.cc"
] | [
"src/main/cpp/blaze_util_windows.cc"
] | [] | diff --git a/src/main/cpp/blaze_util_windows.cc b/src/main/cpp/blaze_util_windows.cc
index 1483dfb9b76a22..a8ccacba1096e9 100644
--- a/src/main/cpp/blaze_util_windows.cc
+++ b/src/main/cpp/blaze_util_windows.cc
@@ -1358,9 +1358,9 @@ static string GetMsysBash() {
value, // _Out_opt_ L... | null | val | train | 2019-01-02T10:47:59 | 2018-11-15T11:15:56Z | laszlocsomor | test |
bazelbuild/bazel/6769_6774 | bazelbuild/bazel | bazelbuild/bazel/6769 | bazelbuild/bazel/6774 | [
"timestamp(timedelta=0.0, similarity=0.8694351320346887)"
] | 453edb5e876659cbb3b978bd0fbe0ed20f1be5b7 | 2583f1f288fe73a8105c4af7acd321a1fe3a0964 | [] | [
"This accesses the same information via a provider rather than via attribute (deprecated way to do that?).\r\nDocumentation says `default_runfiles` may return `None` so I've added a check.\r\nhttps://docs.bazel.build/versions/master/skylark/lib/DefaultInfo.html#default_runfiles",
"Attribute `files_map` does not e... | 2018-11-27T12:03:57Z | [
"team-Rules-Server",
"untriaged"
] | pkg_tar duplicate files with include_runfiles=True | ### Description of the problem / feature request:
I'd like to use pkg_tar and have it package runfiles for my targets. I tried using the undocumented (should be documented?) flag `include_runfiles` but it turns out the implementation (https://github.com/bazelbuild/bazel/pull/5044) is buggy and it includes runfiles t... | [
"tools/build_defs/pkg/pkg.bzl"
] | [
"tools/build_defs/pkg/pkg.bzl"
] | [] | diff --git a/tools/build_defs/pkg/pkg.bzl b/tools/build_defs/pkg/pkg.bzl
index 7c98838e69745a..d3bd88517be8f5 100644
--- a/tools/build_defs/pkg/pkg.bzl
+++ b/tools/build_defs/pkg/pkg.bzl
@@ -40,7 +40,6 @@ def _pkg_tar_impl(ctx):
remap_paths = ctx.attr.remap_paths
# Start building the arguments.
- build_t... | null | train | train | 2018-12-03T22:05:34 | 2018-11-27T03:44:43Z | ash2k | test |
bazelbuild/bazel/6820_6822 | bazelbuild/bazel | bazelbuild/bazel/6820 | bazelbuild/bazel/6822 | [
"timestamp(timedelta=0.0, similarity=0.8793758775672843)"
] | 7fc967c4d6435de2bb4e34aac00ca2e499f55fca | f63b0e158101e7414bbfa740b7d41a7c8a668827 | [
"Thanks for the report!\r\n\r\nThe error comes from here:\r\nhttps://github.com/bazelbuild/bazel/blob/7fc967c4d6435de2bb4e34aac00ca2e499f55fca/src/tools/singlejar/mapped_file_windows.inc#L66\r\n\r\nThe caller is here:\r\nhttps://github.com/bazelbuild/bazel/blob/7fc967c4d6435de2bb4e34aac00ca2e499f55fca/src/tools/sin... | [] | 2018-12-03T11:41:03Z | [
"type: bug",
"P2",
"platform: windows",
"area-Windows",
"team-OSS"
] | C++ SingleJar on Windows can't deal with empty files | > ATTENTION! Please read and follow:
> - if this is a _question_ about how to build / test / query / deploy using Bazel, ask it on StackOverflow instead: https://stackoverflow.com/questions/tagged/bazel
> - if this is a _discussion starter_, send it to bazel-discuss@googlegroups.com
> - if this is a _bug_ or _featur... | [
"src/tools/singlejar/mapped_file_windows.inc",
"src/tools/singlejar/output_jar_shell_test.sh"
] | [
"src/tools/singlejar/mapped_file_windows.inc",
"src/tools/singlejar/output_jar_shell_test.sh"
] | [] | diff --git a/src/tools/singlejar/mapped_file_windows.inc b/src/tools/singlejar/mapped_file_windows.inc
index 43e524ae12302a..a35702874baffa 100644
--- a/src/tools/singlejar/mapped_file_windows.inc
+++ b/src/tools/singlejar/mapped_file_windows.inc
@@ -50,8 +50,7 @@ bool MappedFile::Open(const std::string& path) {
siz... | null | train | train | 2018-12-03T11:12:38 | 2018-12-03T10:36:35Z | philwo | test |
bazelbuild/bazel/6949_6967 | bazelbuild/bazel | bazelbuild/bazel/6949 | bazelbuild/bazel/6967 | [
"timestamp(timedelta=169092.0, similarity=0.8650940885209347)"
] | d0e6e06be3adbf625b065b787db2053e630be5f1 | 86b8204af1ecfb84994e34f97e40cc9715c2c510 | [
"Closing this as a dupe of https://github.com/bazelbuild/bazel/issues/1707"
] | [] | 2018-12-19T16:53:27Z | [
"type: documentation (cleanup)",
"P2",
"team-Bazel"
] | Document the build processes of the Bazel websites | This impacts {www, docs, blog}.bazel.build.
The three web assets share a significant part of their build processes. These processes are lightly documented in the [READMEs](https://github.com/bazelbuild/bazel-website#bazel-website) or in code themselves.
It would be useful to document how the Bazel web assets are ... | [
"scripts/docs/doc_versions.bzl",
"site/_config.yml"
] | [
"scripts/docs/doc_versions.bzl",
"site/_config.yml"
] | [] | diff --git a/scripts/docs/doc_versions.bzl b/scripts/docs/doc_versions.bzl
index 4e4b76a5ffc52e..09f2c80aacfdd9 100644
--- a/scripts/docs/doc_versions.bzl
+++ b/scripts/docs/doc_versions.bzl
@@ -22,6 +22,10 @@
"""This module contains the versions and hashes of Bazel's documentation tarballs."""
DOC_VERSIONS = [
+ ... | null | test | train | 2018-12-19T17:29:59 | 2018-12-17T18:12:21Z | jin | test |
bazelbuild/bazel/6988_8935 | bazelbuild/bazel | bazelbuild/bazel/6988 | bazelbuild/bazel/8935 | [
"timestamp(timedelta=0.0, similarity=0.840598533354835)"
] | 46fb33c1ce3b4526611882e7b266f141fe3a4efd | fd4403830e2d6f300c71e53fb6558d340db1a917 | [] | [] | 2019-07-19T10:11:52Z | [
"type: documentation (cleanup)",
"P3"
] | Starlark language docs link to list instead of tuple | On https://docs.bazel.build/versions/master/skylark/lib/string.html#endswith the link to "tuple" in "tuple of strings" actually points at the list documentation. Which then gave me a syntax error because I needed the "tuple" syntax with parentheses instead of square brackets. I'm also not sure where this documentation ... | [
"src/main/java/com/google/devtools/build/docgen/skylark/SkylarkDoc.java"
] | [
"src/main/java/com/google/devtools/build/docgen/skylark/SkylarkDoc.java"
] | [
"src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkDoc.java b/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkDoc.java
index 95f740e002ee79..f2a38819fa84d0 100644
--- a/src/main/java/com/google/devtools/build/docgen/skylark/SkylarkDoc.java
+++ b/src/main/java/com/google/devtools/bu... | diff --git a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java b/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java
index 07c684f73d714c..7796c5d8cbdb23 100644
--- a/src/test/java/com/google/devtools/build/docgen/SkylarkDocumentationTest.java
+++ b/src/test/java/com/... | test | train | 2019-07-19T12:25:23 | 2018-12-21T17:34:28Z | LStAmour | test |
bazelbuild/bazel/7063_7076 | bazelbuild/bazel | bazelbuild/bazel/7063 | bazelbuild/bazel/7076 | [
"timestamp(timedelta=0.0, similarity=0.8635947801373915)"
] | 94e50162088bd788c9f4e18f9a1a79987398b213 | 0665cf2589c2285c5f3243376017b572ca1ee8c8 | [
"Workaround: call `bazel shutdown` then `bazel run //src:foo` again.",
"I bet this is some symlink-related issue. I suspect Bazel on Windows copies files in the roots of external repositories instead of symlinking them, and that's why it doesn't notice the change.\r\n\r\nI'll proceed to check this theory.",
"My... | [] | 2019-01-10T12:02:09Z | [
"type: bug",
"P1",
"area-Windows",
"team-OSS"
] | Windows, external repositories: correctness bug with Starlark rule in external repo | ### Description of the problem / feature request:
On Windows, if `//src:foo` depends on `@repo2//:gen`, which is a Starlark rule whose definition is in `@repo1//:gen_cc.bzl`, then changing `gen_cc.bzl` does not trigger a rebuild of `//src:foo` even though it should.
On Linux, the same thing works correctly.
##... | [
"src/main/java/com/google/devtools/build/lib/rules/repository/NewLocalRepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDirectoryValue.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/repository/NewLocalRepositoryFunction.java",
"src/main/java/com/google/devtools/build/lib/rules/repository/RepositoryDirectoryValue.java"
] | [
"src/test/py/bazel/bazel_external_repository_test.py"
] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/repository/NewLocalRepositoryFunction.java b/src/main/java/com/google/devtools/build/lib/rules/repository/NewLocalRepositoryFunction.java
index 5c164c7d807ddc..9c4c4aa3c325ce 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/repository/NewLocal... | diff --git a/src/test/py/bazel/bazel_external_repository_test.py b/src/test/py/bazel/bazel_external_repository_test.py
index 3ed67f9b264802..2950ade954ea82 100644
--- a/src/test/py/bazel/bazel_external_repository_test.py
+++ b/src/test/py/bazel/bazel_external_repository_test.py
@@ -131,5 +131,50 @@ def testNewHttpArchi... | train | train | 2019-01-10T12:28:06 | 2019-01-09T08:32:10Z | laszlocsomor | test |
bazelbuild/bazel/7079_7185 | bazelbuild/bazel | bazelbuild/bazel/7079 | bazelbuild/bazel/7185 | [
"timestamp(timedelta=0.0, similarity=0.8615181094211928)"
] | 94078453f8f13a124e72d18093a5518ddc9fe9b3 | 4b24ab520d92b5b36d8b801201d16a8fcdd5d559 | [
"/sub",
"Debugging so far (by running tests in parallel and debugging linux vs windows:\r\nThe location of the bazel_tools repo is different in the Windows tests: on Linux it is (correctly) bazel_tools_workspace (set via /workspace/WORKSPACE). On windows, the default value from /DEFAULT.WORKSPACE (which is /usr/l... | [] | 2019-01-18T20:43:55Z | [
"type: bug",
"P2",
"team-Configurability"
] | Enable LocalConfigPlatformFunctionTest on Windows | Currently it fails with the error:
```
1) generateConfigRepository(com.google.devtools.build.lib.bazel.repository.LocalConfigPlatformFunctionPosixTest$FunctionTest)
java.lang.AssertionError: ERROR /usr/local/google/_blaze_jrluser/FAKEMD5/external/local_config_platform_test/BUILD.bazel:3:1: no such package '@bazel_to... | [
"src/main/java/com/google/devtools/build/lib/util/CPU.java",
"src/main/java/com/google/devtools/build/lib/util/OS.java"
] | [
"src/main/java/com/google/devtools/build/lib/util/CPU.java",
"src/main/java/com/google/devtools/build/lib/util/OS.java"
] | [
"src/test/java/com/google/devtools/build/lib/bazel/repository/BUILD",
"src/test/java/com/google/devtools/build/lib/bazel/repository/LocalConfigPlatformFunctionTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/util/CPU.java b/src/main/java/com/google/devtools/build/lib/util/CPU.java
index 78545906487ca6..8a6de0f2c2ffb1 100644
--- a/src/main/java/com/google/devtools/build/lib/util/CPU.java
+++ b/src/main/java/com/google/devtools/build/lib/util/CPU.java
@@ -44,23 +44,14 ... | diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/BUILD b/src/test/java/com/google/devtools/build/lib/bazel/repository/BUILD
index 355cb47e9543e6..7e191f5c1e2dd1 100644
--- a/src/test/java/com/google/devtools/build/lib/bazel/repository/BUILD
+++ b/src/test/java/com/google/devtools/build/lib/baze... | train | train | 2019-01-18T20:49:56 | 2019-01-10T15:03:50Z | katre | test |
bazelbuild/bazel/7081_9109 | bazelbuild/bazel | bazelbuild/bazel/7081 | bazelbuild/bazel/9109 | [
"timestamp(timedelta=0.0, similarity=0.9200953409301609)"
] | e0f1c1c0f5227c1bcbcfe460889bbcf1c65de5e8 | 890cbc06726d3d6ccd21b509bf0fff6bfb0989ca | [
"This flag is part of the work on #6849 .",
"Changed the targetted flag-flip release, since this will require extensive testing and may need to wait for the projected migration plan for the cpu flag.",
"Hey @katre, I just re-discovered this flag, what's needed to flip this? Or at least to get to a place where w... | [
"Is this line still within the char limit? Unsure whether this can be visualized in github review...",
"One l too many in untill.",
"Yes, 99 characters long according to vim.",
"Fixed."
] | 2019-08-07T15:20:06Z | [
"P1",
"team-Configurability",
"incompatible-change"
] | incompatible_auto_configure_host_platform: Switch to new auto-configured host platforms | Flag: --incompatible_auto_configure_host_platform
Available since: 0.23
Will be flipped in: 1.0
**ADDED CONTEXT**
This also affects platforms that inherit from platforms in `@bazel_tools//platforms`.
**Symptoms**: your build works with Bazel 0.29.1 but fails with 'no matching toolchains found' error on local... | [
"src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java"
] | [
"src/test/java/com/google/devtools/build/lib/rules/platform/PlatformTest.java",
"src/test/java/com/google/devtools/build/lib/skyframe/PlatformMappingFunctionTest.java",
"src/test/java/com/google/devtools/build/lib/skyframe/PlatformMappingValueTest.java",
"src/test/java/com/google/devtools/build/lib/testutil/T... | diff --git a/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java b/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java
index 45e50ab9df2e18..d6f9d6600ed2ab 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/PlatformOptions.java
+++ b/src/main/java/com/google/de... | diff --git a/src/test/java/com/google/devtools/build/lib/rules/platform/PlatformTest.java b/src/test/java/com/google/devtools/build/lib/rules/platform/PlatformTest.java
index b8fb9623df9d20..d2f6d0b6d6e6f3 100644
--- a/src/test/java/com/google/devtools/build/lib/rules/platform/PlatformTest.java
+++ b/src/test/java/com/... | train | train | 2019-08-08T18:23:40 | 2019-01-10T16:38:51Z | katre | test |
bazelbuild/bazel/7137_7617 | bazelbuild/bazel | bazelbuild/bazel/7137 | bazelbuild/bazel/7617 | [
"timestamp(timedelta=0.0, similarity=0.9179705795408803)"
] | 7ff1bae119a3b6537ed0e0aa8fb4c8517461f1b0 | a27c9602771e4ffd6a94951fb3ae111ff5d96aa8 | [
"We need to fix this for remote execution and caching across all protocols. In the case of remote execution, we'll also need to set `skip_cache_lookup` to `true` in order to ensure re-execution."
] | [
"So \"we don't cache failed actions\" is no longer correct for Bazel? If so, this comment is no longer true (even if Bazel won't cache failed actions itself).",
"s/missed cache/cache miss/",
"Why do we need to test for the metadata?",
"why do you think the asserts below this line are valuable for the test?",
... | 2019-03-04T16:05:29Z | [
"type: bug",
"P1",
"team-Remote-Exec"
] | remote: treat failed actions as a cache miss | If a remote cache returns a failed action (exit code != 0) then Bazel should treat this as a cache miss and attempt to re-execute the action. See for details https://gitlab.com/BuildGrid/buildgrid/issues/151 | [
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java"
] | [
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java"
] | [
"src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java",
"src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
index f86de075f83ad4..7d9d2bde32eb2c 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java
+++ b/src/main/java/com/google/devto... | diff --git a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java b/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java
index d50adcf11d191e..da2ff6f327a5dc 100644
--- a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java
+++ b/src/test/java/com/... | val | train | 2019-03-18T08:56:31 | 2019-01-16T09:10:05Z | buchgr | test |
bazelbuild/bazel/7167_7172 | bazelbuild/bazel | bazelbuild/bazel/7167 | bazelbuild/bazel/7172 | [
"timestamp(timedelta=1.0, similarity=0.8952493440993834)"
] | 356ad221eaa9a81ae7ef0b967195b895e9e0d217 | e545447562c4583c682bffd75b329d9614793653 | [
"cc @meisterT "
] | [] | 2019-01-18T08:27:24Z | [
"P2",
"area-EngProd",
"team-Rules-Java",
"team-OSS"
] | //scripts/packages:without-jdk/bazel includes a jdk | `//scripts/packages:rename-bazel-bin-without-jdk`, which produces `//scripts/packages:without-jdk/bazel` includes `//src:bazel`[0], which due to semi-recent changes, now **includes** a jdk. It should be changed to `//src:bazel_nojdk` to support generating a bazel.sh without an embedded JDK. This change seems to have be... | [
"scripts/packages/BUILD"
] | [
"scripts/packages/BUILD"
] | [] | diff --git a/scripts/packages/BUILD b/scripts/packages/BUILD
index 5a66400d1f440c..7e9ec210b2578e 100644
--- a/scripts/packages/BUILD
+++ b/scripts/packages/BUILD
@@ -93,7 +93,7 @@ genrule(
genrule(
name = "rename-bazel-bin-without-jdk",
- srcs = ["//src:bazel"],
+ srcs = ["//src:bazel_nojdk"],
outs ... | null | train | train | 2019-01-18T07:50:46 | 2019-01-17T20:02:36Z | emidln | test |
bazelbuild/bazel/7171_7189 | bazelbuild/bazel | bazelbuild/bazel/7171 | bazelbuild/bazel/7189 | [
"timestamp(timedelta=90479.0, similarity=0.8733058587681826)"
] | 199368ca895c00e38b88ba225ade5e91661186d0 | b03facd2576e2018da4a5464053ddf9c59db1f03 | [
"Thanks for the report, I'll look into this today. It should definitely be a warning, not a hard crash.",
"The actual cycle is this:\r\n- //tests:expansion_test\r\n- needs a toolchain of type @io_bazel_rules_m4//m4:toolchain_type\r\n- depends on all registered toolchains\r\n- includes @io_bazel_rules_m4//m4/toolc... | [] | 2019-01-19T19:09:00Z | [
"P2",
"team-Configurability"
] | java.lang.IllegalStateException when referencing ToolchainInfo targets instead of ToolchainRuleInfo | Bazel's toolchain registration involves two targets: a "toolchain info" that returns a `platform_common.ToolchainInfo` with arbitrary content, and a "toolchain" that registers the toolchain info with execution constraints.
If the user confuses these two (either when calling `native.register_toolchains()` or with the... | [
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java"
] | [
"src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java b/src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java
index 1f3470a8a1eac0..283780d12588cf 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/ToolchainResolver.java
+++ b/src/main/java/com/goo... | null | test | train | 2019-01-19T18:33:38 | 2019-01-18T06:13:33Z | jmillikin | test |
bazelbuild/bazel/7196_7423 | bazelbuild/bazel | bazelbuild/bazel/7196 | bazelbuild/bazel/7423 | [
"timestamp(timedelta=0.0, similarity=0.8850649384482638)"
] | b7bd7a1e8014a638e9b4475be8bb75e97fc53af5 | dd6f7e823d2c54cb73ef09098386c055f98beba8 | [
"For this flag and the one in #7197 - what if users don't want to download this archive, or want to change the location/manner in which this archive is obtained? This would be important for CI systems with no internet connectivity, and orgs that want to audit/control build-time dependencies (both in terms of artifa... | [] | 2019-02-13T15:09:10Z | [
"incompatible-change"
] | incompatible_use_remote_java_toolchain: use remote Java tools instead of the embedded deploy jars | The option `--incompatible_use_remote_java_toolchain` will download the remote Java tools (archive of deploy jars) for the target configuration instead of using the corresponding embedded deploy jars. Enabling this flag only affects users of the Java rules.
# Migration Notes
There are no actions required from the... | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java",
"src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
index d4a72fdff59878..70e0c0679b2257 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
+++ b/src/main/java/com/google/devtools... | diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java b/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
index e58cd0e121b1f8..9f0557f2c4b487 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
+++ b/src/te... | val | train | 2019-02-13T14:30:01 | 2019-01-21T10:49:02Z | iirina | test |
bazelbuild/bazel/7197_7423 | bazelbuild/bazel | bazelbuild/bazel/7197 | bazelbuild/bazel/7423 | [
"timestamp(timedelta=157133.0, similarity=0.8819002292370186)"
] | b7bd7a1e8014a638e9b4475be8bb75e97fc53af5 | dd6f7e823d2c54cb73ef09098386c055f98beba8 | [] | [] | 2019-02-13T15:09:10Z | [
"incompatible-change"
] | incompatible_use_remote_host_java_toolchain: use remote Java tools instead of the embedded deploy jars | The option `--incompatible_use_remote_host_java_toolchain` will download the remote Java tools (archive of deploy jars) for the host configuration instead of using the corresponding embedded deploy jars. Enabling this flag only affects users of the Java rules.
# Migration Notes
There are no actions required from ... | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java",
"src/test/java/com/google/devtools/build/lib/rules/java/JavaSkylarkApiTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
index d4a72fdff59878..70e0c0679b2257 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
+++ b/src/main/java/com/google/devtools... | diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java b/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
index e58cd0e121b1f8..9f0557f2c4b487 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
+++ b/src/te... | val | train | 2019-02-13T14:30:01 | 2019-01-21T10:49:45Z | iirina | test |
bazelbuild/bazel/7204_8276 | bazelbuild/bazel | bazelbuild/bazel/7204 | bazelbuild/bazel/8276 | [
"timestamp(timedelta=153861.0, similarity=0.9533572855750213)"
] | 1df1635b0db2175191998d993052b8e37dadae7c | a68f135b19ac77b9150ea6b0c6b861cf48026500 | [
"deprecated in https://github.com/bazelbuild/bazel/pull/7985 \r\nWill be removed in #7895 "
] | [] | 2019-05-09T13:11:43Z | [
"P2",
"type: support / not a bug (process)",
"team-Remote-Exec"
] | remote: remove --experimental_remote_retry_* flags | Simplify to just `--remote_retries=NUM` with a `0` value disabling retries. | [
"src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
index 755b6e5ea7da18..c5a72a1bbbd133 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
+++ b/src/main/java/c... | null | val | train | 2019-05-09T14:50:15 | 2019-01-21T16:05:45Z | buchgr | test |
bazelbuild/bazel/7232_7243 | bazelbuild/bazel | bazelbuild/bazel/7232 | bazelbuild/bazel/7243 | [
"timestamp(timedelta=1.0, similarity=0.9491581201419624)"
] | 4f48981dbe5b9e432bd39f92155228769467f60b | 32981566073d824bb046c0eaee645e2a13e29031 | [
"cc @benjaminp "
] | [
"The javadoc needs a update.",
"In the `RemoteSpawnCache`, the equivalent condition was moved before the concurrent modification check. It probably doesn't matter, but it doesn't hurt to be consistent either way.",
"Is it worthwhile to keep the `containsExactly` by adding the `actionKey` to the list here?",
"... | 2019-01-24T17:07:46Z | [
"type: bug",
"P2",
"team-Remote-Exec"
] | remote: don't upload failed action outputs | For historical reasons we are currently uploading the outputs of failed actions. This was mostly so that `test.log` and `test.xml` of failed tests would be uploaded when BES was enabled. However, we have had local file uploads in BES for a while now and thus this (unexpected) feature is now obsolete. | [
"src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java",
"src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java... | [
"src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java",
"src/main/java/com/google/devtools/build/lib/remote/GrpcRemoteCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java",
"src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java... | [
"src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java",
"src/test/java/com/google/devtools/build/lib/remote/GrpcRemoteCacheTest.java",
"src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnCacheTest.java",
"src/test/java/com/google/devtools/build/lib/remote/RemoteSpa... | diff --git a/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java b/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java
index 6b0b96c1b7eba8..0d742f5b198910 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java
+++ b/src... | diff --git a/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java b/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java
index da5e8218dca333..f4f6026a3efec6 100644
--- a/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests... | val | train | 2019-01-25T10:22:12 | 2019-01-24T09:36:50Z | buchgr | test |
bazelbuild/bazel/7259_8017 | bazelbuild/bazel | bazelbuild/bazel/7259 | bazelbuild/bazel/8017 | [
"timestamp(timedelta=1760.0, similarity=0.8561444596451517)"
] | 0dbbb4c07e17df4112ea89825da9dc3e9dbabbac | 34d9c6717593ca134713dcc46a44529bddd2ab66 | [
"I need this for properly fixing #6400 (support for grpc.enable_http_proxy channel arg was added in gRPC 1.14).",
"@tetromino this is about the gRPC Java dependency. I believe you need https://github.com/bazelbuild/bazel/issues/2804",
"The Google auth library in third_party/auth is quite old. It did not work w... | [] | 2019-04-12T10:52:54Z | [
"P2",
"type: process",
"team-Remote-Exec"
] | remote: update grpc and google auth library to latest | [
"third_party/BUILD"
] | [
"third_party/BUILD"
] | [] | diff --git a/third_party/BUILD b/third_party/BUILD
index c927b759969b42..90ab565687731f 100644
--- a/third_party/BUILD
+++ b/third_party/BUILD
@@ -226,8 +226,8 @@ java_import(
java_import(
name = "auth",
jars = [
- "auth/google-auth-library-oauth2-http-0.6.0.jar",
- "auth/google-auth-library-cr... | null | train | train | 2019-04-12T12:33:51 | 2019-01-25T16:56:01Z | buchgr | test | |
bazelbuild/bazel/7297_7299 | bazelbuild/bazel | bazelbuild/bazel/7297 | bazelbuild/bazel/7299 | [
"timestamp(timedelta=36669.0, similarity=0.8402573714705566)"
] | ee1107a6ada146666f50aa7e834e9f954153de32 | e77af453c4fae5ad07175d871f48f4751446abda | [
"Hmm, I thought I had updated it: 9259683c6b460629d1ca83759ce26fa76839558d\r\n\r\nAre you building with any `--incompatible_` flags?",
"I think the problem is that there's also `third_party/java/java_tools/turbine_deploy.jar`.",
"I hacked up an integration test to demonstrate the problem:\r\n```\r\n$ git diff\r... | [
"nit: Isn't this duplicated from the 0.22 (see line 38 in the same file?)",
"The file didn't have a trailing newline, the only thing that changed on this line was trailing whitespace.",
"Oh, also, I think the duplication with 38 is deliberate? The script is printing the list of files that change in each update,... | 2019-01-30T06:07:33Z | [
"team-Rules-Java"
] | javac turbine needs to be updated | Since d42a026e63872efb9f9f3879248ddf4431c65d20, I've been seeing failures like this:
```
java -Xverify:none -Xbootclasspath/p:external/bazel_tools/third_party/java/jdk/langtools/javac-9+181-r4173-1.jar -jar external/bazel_tools/tools/jdk/turbine_deploy.jar --output ... (remaining 221 argument(s) skipped)
Use --sandb... | [
"third_party/java/java_tools/README.md",
"third_party/java/java_tools/update_java_tools.sh"
] | [
"third_party/java/java_tools/README.md",
"third_party/java/java_tools/update_java_tools.sh"
] | [] | diff --git a/third_party/java/java_tools/README.md b/third_party/java/java_tools/README.md
index 408669c11285fc..fd029df6fe0751 100644
--- a/third_party/java/java_tools/README.md
+++ b/third_party/java/java_tools/README.md
@@ -21,4 +21,20 @@ third_party/java/java_tools/SingleJar_deploy.jar
The following tools were bui... | null | train | train | 2019-01-30T00:33:53 | 2019-01-29T22:55:30Z | benjaminp | test |
bazelbuild/bazel/7331_7491 | bazelbuild/bazel | bazelbuild/bazel/7331 | bazelbuild/bazel/7491 | [
"timestamp(timedelta=0.0, similarity=0.8577877964005944)"
] | 1898f41b807d846d3553db645e6d718ba2348a60 | ae3cd77654e233ee82ac066a54b283016afbf98b | [
"Not team-Starlark?\r\nI'm tagging @c-parsons since `{s,}he` has opened the original deprecation issue. ",
"It's probably my fault, sorry about that.\r\nI'm looking at it.",
"@laurentlb I guess you did too much refactoring on https://github.com/bazelbuild/bazel/commit/2b3ad18eec4e6b968d840777249c809e478b2e13 ... | [] | 2019-02-21T14:44:22Z | [
"P1",
"bad error messaging"
] | bad error messaging when using the deprecated `PACKAGE_NAME` or `REPOSITORY_NAME` | ### Description of the problem / feature request:
Instead of a nice deprecation warning / error, I got this ambiguous error: `builtin variable 'REPOSITORY_NAME' is referenced before assignment.`.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Use... | [
"src/main/java/com/google/devtools/build/lib/syntax/Identifier.java"
] | [
"src/main/java/com/google/devtools/build/lib/syntax/Identifier.java"
] | [
"src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java b/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java
index 98e7d5b69ba855..a246ee5e93ecc8 100644
--- a/src/main/java/com/google/devtools/build/lib/syntax/Identifier.java
+++ b/src/main/java/com/google/devtools/build/lib/synt... | diff --git a/src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java b/src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java
index 354fb0c58be645..239fcba012ec0c 100644
--- a/src/test/java/com/google/devtools/build/lib/packages/PackageFactoryTest.java
+++ b/src/test/java/com/... | train | train | 2019-02-21T15:42:28 | 2019-02-02T06:40:08Z | Reflexe | test |
bazelbuild/bazel/7349_7350 | bazelbuild/bazel | bazelbuild/bazel/7349 | bazelbuild/bazel/7350 | [
"timestamp(timedelta=0.0, similarity=0.9373832826710414)"
] | 0cd3594dcabd508636d6f3af8867de4d1a044aac | eeea9db75e3ed152a761879968836277916c550f | [] | [
"when does this happen?",
"If `path` itself was empty.\r\nShall I move this check above the conversion?",
"Yes please.",
"Done."
] | 2019-02-05T10:58:49Z | [
"type: bug",
"P1",
"area-Windows",
"team-OSS"
] | Windows, java_binary: MakeDirectoriesW fail in launcher | ### Description of the problem / feature request:
If you copy a java_binary's outputs somewhere out of bazel-bin and try to run it from the current working directory, the launcher will fail with a MakeDirectoriesW error.
BUILD:
```
java_binary(
name = "foo",
srcs = ["Main.java"],
main_class = "Main",
... | [
"src/main/cpp/util/file_windows.cc"
] | [
"src/main/cpp/util/file_windows.cc"
] | [] | diff --git a/src/main/cpp/util/file_windows.cc b/src/main/cpp/util/file_windows.cc
index cc2225ed37ae72..a71db514216aca 100644
--- a/src/main/cpp/util/file_windows.cc
+++ b/src/main/cpp/util/file_windows.cc
@@ -755,22 +755,28 @@ void SyncFile(const string& path) {
}
bool MakeDirectoriesW(const wstring& path, unsign... | null | train | train | 2019-02-05T11:51:41 | 2019-02-05T10:50:39Z | laszlocsomor | test |
bazelbuild/bazel/7370_7484 | bazelbuild/bazel | bazelbuild/bazel/7370 | bazelbuild/bazel/7484 | [
"timestamp(timedelta=1.0, similarity=0.8840656578174207)"
] | 53b5170eadaf60ec20a0595da6347a791d680aeb | 85b23f4b8639e35d2c440d081130ed0e401e01d8 | [
"If I'm understanding my build errors correctly, this change re-broke the py2/3 compatibility on make_deb.py that #6818 had previously fixed.\r\n\r\n```\r\n File \".../bazel-out/k8-opt/bin/external/bazel_tools/tools/build_defs/pkg/make_deb.runfiles/bazel_tools/tools/build_defs/pkg/make_deb.py\", line 301, in GetFl... | [
"Can you add \r\n # -*- coding: utf-8 -*-\r\nat the top of this file and build_test.sh ",
"I think it is safer to do the decode at the top of the method on the incoming value.\r\nOr, better yet, the transform from bytes to unicode string should happen in GetFlagValue.",
"If you would like to do future mainta... | 2019-02-20T22:31:58Z | [
"P4",
"team-Rules-Server"
] | pkg_deb fails when control fields contain unicode/utf-8 encoded characters | ### Description of the problem:
pkg_deb fails when control fields contain unicode characters or the contents of utf-8 encoded files.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
Using the following:
```shell
~/utf8-test$ ls
BUILD WORKSPACE
... | [
"tools/build_defs/pkg/BUILD",
"tools/build_defs/pkg/build_test.sh",
"tools/build_defs/pkg/make_deb.py"
] | [
"tools/build_defs/pkg/BUILD",
"tools/build_defs/pkg/build_test.sh",
"tools/build_defs/pkg/make_deb.py"
] | [] | diff --git a/tools/build_defs/pkg/BUILD b/tools/build_defs/pkg/BUILD
index f3c8b4c86e995f..c7e9e26997d5a6 100644
--- a/tools/build_defs/pkg/BUILD
+++ b/tools/build_defs/pkg/BUILD
@@ -1,3 +1,4 @@
+# -*- coding: utf-8 -*-
licenses(["notice"]) # Apache 2.0
filegroup(
@@ -213,7 +214,7 @@ pkg_deb(
"dep1",
... | null | train | train | 2019-02-20T23:06:14 | 2019-02-07T05:41:44Z | imcginnis | test |
bazelbuild/bazel/7375_8440 | bazelbuild/bazel | bazelbuild/bazel/7375 | bazelbuild/bazel/8440 | [
"timestamp(timedelta=160224.0, similarity=0.8566001287297237)"
] | 207c24f04453ef026c202f2962e55d2a125e388f | 923c45faecaabd00e0214ff7d178507623958b37 | [
"(Plan is to use this work to also address #4815, rather than implement an ad hoc solution to that bug.)",
"Design doc [here](https://github.com/bazelbuild/rules_python/blob/master/proposals/2019-02-12-design-for-a-python-toolchain.md).\r\n\r\nDiscussion can proceed in this thread. Initial reviewers are @katre (B... | [
"Can the input `bash_binary` ever be just `bash.exe` for example, which would mean \"whatever is on the PATH\"?",
"I think there are two ways to tell which shell binary to use, `BAZEL_SH` or `--shell_executable`. Both way requires user to set an absolute path. The only case `bash_binary` is a relative path (runfi... | 2019-05-22T12:24:59Z | [
"type: feature request",
"P1",
"team-Rules-Python"
] | Switch Python rules to use toolchains | This bug tracks designing, implementing, and migrating built-in Python rules to use the toolchain mechanism for resolving the Python runtime. This replaces the legacy mechanism of specifying `--python_top` to globally make all Python targets look at a specific `py_runtime`, or omitting `--python_top` to use the system ... | [
"src/tools/launcher/bash_launcher.cc",
"src/tools/launcher/python_launcher.cc"
] | [
"src/tools/launcher/bash_launcher.cc",
"src/tools/launcher/python_launcher.cc"
] | [] | diff --git a/src/tools/launcher/bash_launcher.cc b/src/tools/launcher/bash_launcher.cc
index 0020d5f92d55d3..67f0a5d53a2b51 100644
--- a/src/tools/launcher/bash_launcher.cc
+++ b/src/tools/launcher/bash_launcher.cc
@@ -30,6 +30,14 @@ static constexpr const char* BASH_BIN_PATH = "bash_bin_path";
ExitCode BashBinaryLa... | null | train | train | 2019-05-22T12:19:28 | 2019-02-07T15:09:57Z | brandjon | test |
bazelbuild/bazel/7376_7437 | bazelbuild/bazel | bazelbuild/bazel/7376 | bazelbuild/bazel/7437 | [
"timestamp(timedelta=0.0, similarity=0.8402525541748938)"
] | 3d88d7517744d600bd6c77e3facc2b52724de212 | 5575d63af6ef89be39000a2aa4fe7c98ca0e3e5f | [
"@petemounce -- could you please take a look?",
"FYI, @petemounce is currently on holiday, will be back in ~2 weeks, so I don't expect this to be addressed until late Feb/early March.",
"@RNabel , thanks for the heads-up!\r\n\r\n@vmax , is this issue blocking you? Can you work around it until the package is upd... | [] | 2019-02-15T13:48:34Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Package provided in Chocolatey does not declare a dependency | ### Description of the problem / feature request:
`bazel` installed via Chocolatey does not declare dependency on VC Redist
### Feature requests: what underlying problem are you trying to solve with this feature?
I'm trying to use `bazel` to build code on Windows instance on GCE (specifically `windows-2019/win... | [
"scripts/packages/chocolatey/bazel.nuspec.template"
] | [
"scripts/packages/chocolatey/bazel.nuspec.template"
] | [] | diff --git a/scripts/packages/chocolatey/bazel.nuspec.template b/scripts/packages/chocolatey/bazel.nuspec.template
index 761d43f0e552c6..da5f5198aed3f4 100644
--- a/scripts/packages/chocolatey/bazel.nuspec.template
+++ b/scripts/packages/chocolatey/bazel.nuspec.template
@@ -78,6 +78,7 @@ Supply like `--params="/option:... | null | val | train | 2019-05-08T00:07:05 | 2019-02-07T15:16:26Z | vmax | test |
bazelbuild/bazel/7407_8512 | bazelbuild/bazel | bazelbuild/bazel/7407 | bazelbuild/bazel/8512 | [
"timestamp(timedelta=41156.0, similarity=0.9193090360911036)"
] | 3290e22356b59371274849ee51297635b9435285 | 72c9357191f34d6c91559c4ec22f3e3c48b6178f | [
"CC @katre ",
"Seems like the flag wasn't flipped. Changing breaking-change label to 0.26"
] | [] | 2019-05-30T08:53:32Z | [
"P1",
"team-Rules-CPP",
"incompatible-change"
] | incompatible_dont_enable_host_nonhost_crosstool_features: Do not automatically enable "host" and "nonhost" crosstool features | **Flag:** `--incompatible_dont_enable_host_nonhost_crosstool_features`
**Available since:** 0.24 (March 2019 release)
**Will be flipped in:** 0.25 (April 2019 release)
**Tracking issue:** #6516
# Motivation
With the move of C++ rules to use platforms/toolchains (tracked in #6516), we are removing host specific... | [
"src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java",
"tools/cpp/BUILD"
] | [
"src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java",
"tools/cpp/BUILD"
] | [
"src/test/java/com/google/devtools/build/lib/analysis/mock/cc_toolchain_config.bzl",
"src/test/java/com/google/devtools/build/lib/rules/cpp/CcLibraryConfiguredTargetTest.java",
"src/test/java/com/google/devtools/build/lib/rules/cpp/CompileBuildVariablesTest.java",
"src/test/java/com/google/devtools/build/lib/... | diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
index 58fd83c8ef7275..abe07496f948ef 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppOptions.java
+++ b/src/main/java/com/google/devtools/build... | diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/cc_toolchain_config.bzl b/src/test/java/com/google/devtools/build/lib/analysis/mock/cc_toolchain_config.bzl
index 656604fd01c85f..9de5293b924356 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/cc_toolchain_config.bzl
+++ b/src... | train | train | 2019-05-30T01:35:13 | 2019-02-12T17:45:58Z | hlopko | test |
bazelbuild/bazel/7425_7426 | bazelbuild/bazel | bazelbuild/bazel/7425 | bazelbuild/bazel/7426 | [
"timestamp(timedelta=0.0, similarity=0.8598241582022159)"
] | b109a5f69edb35572d65332fe677d032ccdc5282 | eadd1e9f702e3443719748a2da7b4e3acf41fd88 | [] | [] | 2019-02-14T09:18:00Z | [
"incompatible-change"
] | incompatible_java_coverage: allow coverage collection for JVM languages | The option `--incompatible_java_coverage`:
- makes possible collecting coverage for Starlark JVM languages and jars imported with `java_import`
- only includes JVM files in the coverage report (dismisses data files, for example `.js` files that shouldn't have been in the report in the first place)
- the report inc... | [
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java"
] | [
"src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
index 4347d97681d619..0732a81409504f 100644
--- a/src/main/java/com/google/devtools/build/lib/analysis/config/BuildConfiguration.java
+++... | null | train | train | 2019-02-14T10:07:12 | 2019-02-14T08:44:05Z | iirina | test |
bazelbuild/bazel/7454_7645 | bazelbuild/bazel | bazelbuild/bazel/7454 | bazelbuild/bazel/7645 | [
"timestamp(timedelta=0.0, similarity=0.868161844385077)"
] | 426f434d0ee01b77fff0b0940d248dca8b46c1c3 | 3eabbbacdae10edcf6d008e099c162848e99d4e5 | [
"Fixed by https://github.com/laszlocsomor/bazel/commit/363016efe0973f12f28ac42e43c79c84bb0a05df. Closing issue. ",
"No, https://github.com/laszlocsomor/bazel/commit/363016efe0973f12f28ac42e43c79c84bb0a05df was not merged! This flag is not a breaking change in 0.25",
"Sorry about that, thanks for updating the la... | [] | 2019-03-06T14:13:35Z | [
"area-Windows",
"incompatible-change",
"team-OSS"
] | incompatible_windows_style_arg_escaping: enables correct subprocess argument escaping on Windows | # Description
The option `--incompatible_windows_style_arg_escaping` enables correct subprocess argument escaping on Windows. This flag has NO effect on other platforms.
When enabled, [WindowsSubprocessFactory will use ShellUtils.windowsEscapeArg to escape command line arguments](https://github.com/bazelbuild/baz... | [
"src/main/cpp/bazel_startup_options.cc",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeServerStartupOptions.java"
] | [
"src/main/cpp/bazel_startup_options.cc",
"src/main/java/com/google/devtools/build/lib/runtime/BlazeServerStartupOptions.java"
] | [] | diff --git a/src/main/cpp/bazel_startup_options.cc b/src/main/cpp/bazel_startup_options.cc
index f4d494fe8d0d1b..b6cce11db7a6fb 100644
--- a/src/main/cpp/bazel_startup_options.cc
+++ b/src/main/cpp/bazel_startup_options.cc
@@ -29,7 +29,7 @@ BazelStartupOptions::BazelStartupOptions(
use_workspace_rc(true),
... | null | train | train | 2019-04-08T16:29:34 | 2019-02-18T10:02:17Z | laszlocsomor | test |
bazelbuild/bazel/7454_7957 | bazelbuild/bazel | bazelbuild/bazel/7454 | bazelbuild/bazel/7957 | [
"timestamp(timedelta=10802.0, similarity=0.857245402727535)"
] | 466bf40f3f41fa6edf66f6401c5c16cb9b53510d | 6d4223b51218f4f2ffad0f118006dee2f777a96e | [
"Fixed by https://github.com/laszlocsomor/bazel/commit/363016efe0973f12f28ac42e43c79c84bb0a05df. Closing issue. ",
"No, https://github.com/laszlocsomor/bazel/commit/363016efe0973f12f28ac42e43c79c84bb0a05df was not merged! This flag is not a breaking change in 0.25",
"Sorry about that, thanks for updating the la... | [] | 2019-04-05T14:10:44Z | [
"area-Windows",
"incompatible-change",
"team-OSS"
] | incompatible_windows_style_arg_escaping: enables correct subprocess argument escaping on Windows | # Description
The option `--incompatible_windows_style_arg_escaping` enables correct subprocess argument escaping on Windows. This flag has NO effect on other platforms.
When enabled, [WindowsSubprocessFactory will use ShellUtils.windowsEscapeArg to escape command line arguments](https://github.com/bazelbuild/baz... | [
"src/tools/launcher/util/BUILD"
] | [
"src/tools/launcher/util/BUILD"
] | [
"src/test/py/bazel/BUILD",
"src/test/py/bazel/printargs.cc",
"src/test/py/bazel/test_wrapper_test.py",
"tools/test/BUILD",
"tools/test/windows/tw.cc"
] | diff --git a/src/tools/launcher/util/BUILD b/src/tools/launcher/util/BUILD
index 5077e2300775eb..e3aa79a8fe6ad7 100644
--- a/src/tools/launcher/util/BUILD
+++ b/src/tools/launcher/util/BUILD
@@ -1,6 +1,6 @@
package(default_visibility = ["//src/tools/launcher:__subpackages__"])
-load("//src/tools/launcher:win_rules.b... | diff --git a/src/test/py/bazel/BUILD b/src/test/py/bazel/BUILD
index d5f59d680c4530..ae947e2c9ba5c8 100644
--- a/src/test/py/bazel/BUILD
+++ b/src/test/py/bazel/BUILD
@@ -164,6 +164,16 @@ py_test(
"//src/conditions:windows": [":test_base"],
"//conditions:default": [],
}),
+ data = select({
+ ... | test | train | 2019-04-05T16:48:05 | 2019-02-18T10:02:17Z | laszlocsomor | test |
bazelbuild/bazel/7480_8286 | bazelbuild/bazel | bazelbuild/bazel/7480 | bazelbuild/bazel/8286 | [
"timestamp(timedelta=0.0, similarity=0.8428690127330948)"
] | efdd3b270faaaf9bca6439da4fc177e97296c1bd | 480849fb0cc81fd1c3aaad7b974350d620dcca6b | [
"/sub",
"Thanks @philwo ! This looks helpful.\r\n\r\nWe moved over to just using ```--spawn_strategy=linux-sandbox``` based on your advice in late 2017. That means we no longer have a patch for that.\r\n\r\nDoes this replace ```--remote_local_fallback_strategy=linux-sandbox``` ?",
"Yes.\r\nUnder `incompatible... | [] | 2019-05-10T09:24:38Z | [
"incompatible-change",
"team-Remote-Exec"
] | incompatible_list_based_execution_strategy_selection: List-based explicit spawn strategy selection. | For more detailed description visit our blog post: https://blog.bazel.build/2019/06/19/list-strategy.html
## :no_good_man: Current situation:
- The user can set the execution strategy in general and for individual action mnemonics using the flags `--spawn_strategy=`, `--strategy=Mnemonic=` and `--strategy_regexp=Re... | [
"src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java"
] | [
"src/test/shell/bazel/remote/remote_execution_test.sh",
"src/test/shell/integration/bazel_worker_test.sh",
"src/test/shell/integration/execution_strategies_test.sh"
] | diff --git a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
index 843178d3669721..205e5eb54284f7 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java
+++ b/src/main/java/com/google/devtools/bu... | diff --git a/src/test/shell/bazel/remote/remote_execution_test.sh b/src/test/shell/bazel/remote/remote_execution_test.sh
index 4fe983c09be561..7e1c8a0b460838 100755
--- a/src/test/shell/bazel/remote/remote_execution_test.sh
+++ b/src/test/shell/bazel/remote/remote_execution_test.sh
@@ -104,7 +104,6 @@ EOF
bazel cl... | train | train | 2019-05-10T11:03:48 | 2019-02-20T14:45:07Z | philwo | test |
bazelbuild/bazel/7486_7646 | bazelbuild/bazel | bazelbuild/bazel/7486 | bazelbuild/bazel/7646 | [
"timestamp(timedelta=1.0, similarity=0.8981737770239935)"
] | 85c70fbd0df0a0ba0d38dfa249c589c4dcb73b89 | c2cb0e0d28da02aa397b121b4841a74efcd06918 | [
"Seems like the flag has been flipped to true in https://github.com/bazelbuild/bazel/commit/2029b1a2332b336f64ee8d9f6433b205aecefc91. I'm closing the issue. ",
"The flag is not yet flipped: https://github.com/bazelbuild/bazel/blob/b137071ea03537ac00592a572dc0140fab985c53/src/main/java/com/google/devtools/build/li... | [] | 2019-03-06T14:15:37Z | [
"area-Windows",
"incompatible-change",
"team-OSS"
] | incompatible_windows_escape_jvm_flags: on Windows, enables tokenization and escaping of jvm_flags | # Description
Add --incompatible_windows_escape_jvm_flags flag (default: false). This flag only affects builds on Windows.
This flag has no effect on Linux/macOS/non-Windows.
## Background
When you build a java_binary or java_test on Windows, one of the outputs is an .exe file. This is called the launcher, ... | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
index 53420f5ad18524..7d1d28590db9d9 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
+++ b/src/main/java/com/google/devtools... | null | train | train | 2019-03-06T15:13:27 | 2019-02-21T10:29:19Z | laszlocsomor | test |
bazelbuild/bazel/7502_8116 | bazelbuild/bazel | bazelbuild/bazel/7502 | bazelbuild/bazel/8116 | [
"timestamp(timedelta=0.0, similarity=0.8546884341422669)"
] | 137019fe22d88f04840e04a2c2a9db8a783a4cbe | a8b6c5b5e9e050c808be85f5d6ed6f968a8e25c9 | [
"Making a change in android_common jars will typically incur a lot of changes internally - please let us (@ahumesky / myself) know if you stumble upon any roadblocks. ",
"@jin to be clear: I still count on you / the Android team to work on unbundling the tools (#1055).\r\nThis issue is to keep track of the remova... | [] | 2019-04-23T11:05:25Z | [
"P2",
"team-Performance"
] | Remove dependency on the java.desktop module | It contributes 13MB to the the size of the embedded JDK which is ~40MB in total right now.
This list describes the paths in the `server.jar` which contain classes that depend on the java.desktop module:
- [x] `javax/xml/bind`
- [x] `com/android/ddmlib`
- [ ] `com/android/ide/common/util`
- [ ] `com/android/ide/c... | [
"WORKSPACE"
] | [
"WORKSPACE"
] | [] | diff --git a/WORKSPACE b/WORKSPACE
index 5f03fb422aa173..607da272ad6b9d 100644
--- a/WORKSPACE
+++ b/WORKSPACE
@@ -192,9 +192,9 @@ http_file(
http_file(
name = "openjdk_linux_minimal",
downloaded_file_path = "zulu-linux-minimal.tar.gz",
- sha256 = "734cbfc9a5264e6cff4877d6694acb2305359531a503748879a84d499... | null | val | train | 2019-04-23T11:24:54 | 2019-02-22T09:01:15Z | meisterT | test |
bazelbuild/bazel/7517_8401 | bazelbuild/bazel | bazelbuild/bazel/7517 | bazelbuild/bazel/8401 | [
"timestamp(timedelta=0.0, similarity=0.8626522113942371)"
] | ce8d52834c9acf9e1bda4f342d073d8cfd5a6737 | ca225c06177ed198c1457e6851895214e2e6b23e | [
"I notice that Bazel already uses ASM 7.0, which is the main dep of jacoco. Maybe upgrading wouldn't be a huge yak shave?",
"I've tried modifying Bazel to upgrade the jar myself, locally, but there's one jar I can't figure out how it was created: https://github.com/bazelbuild/bazel/tree/master/third_party/java/ja... | [] | 2019-05-20T09:45:34Z | [
"P1",
"team-Rules-Java"
] | bazel coverage crashes, likely due to old jacoco | ### Description of the problem / feature request:
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
`bazel coverage //projects/batfish-common-protocol/...` crashes in https://github.com/batfish/batfish/
The stack trace includes the following
```
9... | [
"src/java_tools/buildjar/java/com/google/devtools/build/buildjar/BUILD"
] | [
"src/java_tools/buildjar/java/com/google/devtools/build/buildjar/BUILD"
] | [
"src/java_tools/junitrunner/java/com/google/testing/coverage/BUILD",
"src/java_tools/junitrunner/java/com/google/testing/coverage/BranchDetailAnalyzer.java",
"src/java_tools/junitrunner/java/com/google/testing/coverage/MethodProbesMapper.java",
"src/test/java/com/google/devtools/build/android/desugar/BUILD"
] | diff --git a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/BUILD b/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/BUILD
index 2abd4be4544179..c1c859445a04d6 100644
--- a/src/java_tools/buildjar/java/com/google/devtools/build/buildjar/BUILD
+++ b/src/java_tools/buildjar/java/com/google... | diff --git a/src/java_tools/junitrunner/java/com/google/testing/coverage/BUILD b/src/java_tools/junitrunner/java/com/google/testing/coverage/BUILD
index 3be31af97b56e0..1a39e31d735ac1 100644
--- a/src/java_tools/junitrunner/java/com/google/testing/coverage/BUILD
+++ b/src/java_tools/junitrunner/java/com/google/testing/... | train | train | 2019-05-20T12:44:06 | 2019-02-22T21:48:49Z | dhalperi | test |
bazelbuild/bazel/7580_7581 | bazelbuild/bazel | bazelbuild/bazel/7580 | bazelbuild/bazel/7581 | [
"timestamp(timedelta=0.0, similarity=0.9072992591320629)"
] | 4b79c5311417c1ffbccfce0dbcd871e8c97ff90c | 765cb061ab1f9a0c14db0e2925d91655bc28ae7f | [
"Similar error in `incremental_install.py`:\r\n```\r\n File \"\\\\?\\c:\\tmp\\Bazel.runfiles_fbx84su6\\runfiles\\bazel_tools\\tools\\android\\incremental_install.py\", line 839, in <module>\r\n main()\r\n File \"\\\\?\\c:\\tmp\\Bazel.runfiles_fbx84su6\\runfiles\\bazel_tools\\tools\\android\\incremental_install... | [] | 2019-02-28T12:12:58Z | [
"type: bug",
"P2",
"team-Android"
] | Android, Windows: mobile-install fails with Python3 | ### Description of the problem / feature request:
> Replace this line with your answer.
### Feature requests: what underlying problem are you trying to solve with this feature?
> Replace this line with your answer.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal ex... | [
"tools/android/incremental_install.py",
"tools/android/stubify_manifest.py"
] | [
"tools/android/incremental_install.py",
"tools/android/stubify_manifest.py"
] | [] | diff --git a/tools/android/incremental_install.py b/tools/android/incremental_install.py
index 0638c1b34a4235..d7b9c48d7f29cc 100644
--- a/tools/android/incremental_install.py
+++ b/tools/android/incremental_install.py
@@ -173,6 +173,8 @@ def _Exec(self, adb_args):
# Check these first so that the more specific e... | null | train | train | 2019-02-28T11:49:27 | 2019-02-28T11:54:14Z | laszlocsomor | test |
bazelbuild/bazel/7705_7712 | bazelbuild/bazel | bazelbuild/bazel/7705 | bazelbuild/bazel/7712 | [
"timestamp(timedelta=66892.0, similarity=0.8556415768193818)"
] | 7901dd9f6d84ea0342261e17706ad9c1e14b999d | 38fa0725eae5770cff51f051e8415cfdd6f9460b | [
"/cc @asuffield"
] | [] | 2019-03-13T16:30:51Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows, Bazel client: envvars cannot have UNC paths | ### Description of the problem / feature request:
Bazel mishandles envvars with UNC paths.
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
```
C:\src\tmp>set java
JAVA_HOME=C:\Program Files\Java\jdk1.8.0_162
C:\src\tmp>set JAVA_HOME=\\?\%JAVA... | [
"src/main/cpp/util/file_windows.cc",
"src/main/cpp/util/path_platform.h",
"src/main/cpp/util/path_windows.cc",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/main/cpp/util/file_windows.cc",
"src/main/cpp/util/path_platform.h",
"src/main/cpp/util/path_windows.cc",
"src/main/tools/build-runfiles-windows.cc"
] | [
"src/test/cpp/util/path_windows_test.cc"
] | diff --git a/src/main/cpp/util/file_windows.cc b/src/main/cpp/util/file_windows.cc
index 62a19f6f21ac63..9fd150e2851612 100644
--- a/src/main/cpp/util/file_windows.cc
+++ b/src/main/cpp/util/file_windows.cc
@@ -625,17 +625,7 @@ string MakeCanonical(const char* path) {
return "";
}
- // Convert the path to lo... | diff --git a/src/test/cpp/util/path_windows_test.cc b/src/test/cpp/util/path_windows_test.cc
index ef29083dfd962c..28c7514597ed02 100644
--- a/src/test/cpp/util/path_windows_test.cc
+++ b/src/test/cpp/util/path_windows_test.cc
@@ -245,13 +245,13 @@ TEST(PathWindowsTest, TestAsWindowsPath) {
EXPECT_TRUE(error.find("U... | train | train | 2019-03-13T17:31:02 | 2019-03-13T09:32:39Z | laszlocsomor | test |
bazelbuild/bazel/7767_7785 | bazelbuild/bazel | bazelbuild/bazel/7767 | bazelbuild/bazel/7785 | [
"timestamp(timedelta=0.0, similarity=0.911151360643512)"
] | 15b70bb63e5495290900de9303cbebb0ff12210b | 36ef38d1c62cfc2a84a8a5596eefaf18c80fa6a2 | [
"@iirina could you take a look please?",
"You can use a newer version of jarjar with the following repos/build targets:\r\n```python\r\nJCENTER = \"http://jcenter.bintray.com\"\r\njvm_maven_import_external(\r\n name = \"com_google_jarjar\",\r\n licenses = [\"notice\"],\r\n artifact = \"org.pantsbuild:jar... | [] | 2019-03-20T22:35:46Z | [
"P1",
"team-Rules-Java"
] | @bazel_tools//third_party/jarjar was removed | ### Description of the problem / feature request:
androidx.test (github/android/android_test) is broken HEAD with bazel 0.23.2 with the following error:
Step #2: ERROR: /workspace/ext/junit/java/androidx/test/ext/junit/BUILD.bazel:38:1: no such package '@bazel_tools//third_party/jarjar': BUILD file not found on packa... | [
"src/BUILD",
"src/create_embedded_tools.py",
"third_party/jarjar/BUILD",
"tools/jdk/BUILD"
] | [
"src/BUILD",
"src/create_embedded_tools.py",
"third_party/jarjar/BUILD",
"third_party/jarjar/BUILD.tools",
"tools/jdk/BUILD"
] | [] | diff --git a/src/BUILD b/src/BUILD
index 111a1e26e7b2f3..ec9c7870096f28 100644
--- a/src/BUILD
+++ b/src/BUILD
@@ -124,6 +124,7 @@ JAVA_TOOLS = [
"//src/tools/singlejar:embedded_tools",
"//src/java_tools/import_deps_checker/java/com/google/devtools/build/importdeps:embedded_tools",
"//third_party/java/ja... | null | train | train | 2019-03-20T23:20:12 | 2019-03-19T16:40:04Z | brettchabot | test |
bazelbuild/bazel/7794_7796 | bazelbuild/bazel | bazelbuild/bazel/7794 | bazelbuild/bazel/7796 | [
"timestamp(timedelta=1.0, similarity=0.883872832229377)"
] | 074c9c494b6d4d1252a1f8d31094da3f36b30fdf | b0b058d65be8dabad673e8c0e54b3498532097e5 | [
"Does this issue only happen when `test.log` is very large?",
"no it's independent of the test.log size.",
"The workaround for this issue is to use `--experimental_split_xml_generation=false`"
] | [] | 2019-03-21T14:54:14Z | [
"P1",
"team-Remote-Exec"
] | pass platform and execution requirements to xml generating spawn | The fix for https://github.com/bazelbuild/bazel/issues/4608 splits a test action into two spawns. The first spawn runs the actual test and the second spawn declares the `test.log` as an input and produces a test.xml file.
We found an issue where a `sh_test` target was marked as `no-remote` but the test.xml-generati... | [
"src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java"
] | [
"src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java"
] | [
"src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java b/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
index 43e72787d289c8..cc483672c9d046 100644
--- a/src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
+++ b/src/main/java/com/... | diff --git a/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java b/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java
index 771958614fb948..219d89e041e650 100644
--- a/src/test/java/com/google/devtools/build/lib/exec/StandaloneTestStrategyTest.java
+++ b/src/te... | train | train | 2019-03-21T14:49:42 | 2019-03-21T12:48:05Z | buchgr | test |
bazelbuild/bazel/7848_8251 | bazelbuild/bazel | bazelbuild/bazel/7848 | bazelbuild/bazel/8251 | [
"timestamp(timedelta=0.0, similarity=0.8714233050078801)"
] | 21521541d5e7e7d786a160af5c3b4c7c8fce82e9 | c357eb0400b2de0bd9dfdd8e0d0dd2b637e554a0 | [] | [] | 2019-05-07T12:37:10Z | [
"type: bug",
"P4",
"area-Windows",
"team-OSS"
] | Windows: Bazel binary has no icon | ### Description of the problem / feature request:
Regression from earlier versions.
The Bazel binary no longer has an icon on Windows.
See message thread: https://github.com/bazelbuild/bazel/commit/f8128c3ce2160e5d6243a2dfd94b399d11ee282e
### What operating system are you running Bazel on?
Windows 10
... | [
"src/main/cpp/BUILD",
"src/main/native/windows/BUILD"
] | [
"src/main/cpp/BUILD",
"src/main/native/windows/BUILD"
] | [] | diff --git a/src/main/cpp/BUILD b/src/main/cpp/BUILD
index 483df2cd70925f..fea97a8d6b7014 100644
--- a/src/main/cpp/BUILD
+++ b/src/main/cpp/BUILD
@@ -79,7 +79,7 @@ cc_binary(
"global_variables.h",
"main.cc",
] + select({
- "//src/conditions:windows": ["//src/main/native/windows:resources"... | null | train | train | 2019-05-07T14:02:19 | 2019-03-27T09:12:50Z | laszlocsomor | test |
bazelbuild/bazel/7886_8100 | bazelbuild/bazel | bazelbuild/bazel/7886 | bazelbuild/bazel/8100 | [
"timestamp(timedelta=0.0, similarity=0.8459304991416536)"
] | 375f72b29ab28db3df093531b978c4370b059d54 | dca6527e02f1b1f811883f02d46e6ae5b6e34d99 | [
"Is this really EngProd or RulesServer? That's a trick question, all package building should be a separate project and not part of Bazel itself.\r\n\r\nThat aside. I think the least cost way to get there is to add a depends_file attribute. Implement just like version/version_file.\r\n\r\n- the user still needs a g... | [] | 2019-04-19T13:27:17Z | [
"area-EngProd",
"untriaged",
"team-OSS"
] | pkg_deb should support a way of embedding version into control fields | ### Description of the problem / feature request:
Cannot add `pkg_deb`'s version from `version_file` into Debian control field (i.e. `Depends:`)
### Feature requests: what underlying problem are you trying to solve with this feature?
I have several dependent packages (say, `A` and `B` depending on `A`) which I... | [
"tools/build_defs/pkg/make_deb.py",
"tools/build_defs/pkg/pkg.bzl"
] | [
"tools/build_defs/pkg/make_deb.py",
"tools/build_defs/pkg/pkg.bzl"
] | [] | diff --git a/tools/build_defs/pkg/make_deb.py b/tools/build_defs/pkg/make_deb.py
index 47056754a16e35..f58e920654f5ee 100644
--- a/tools/build_defs/pkg/make_deb.py
+++ b/tools/build_defs/pkg/make_deb.py
@@ -329,7 +329,7 @@ def main(unused_argv):
maintainer=FLAGS.maintainer,
section=FLAGS.section,
a... | null | train | train | 2019-04-18T23:30:09 | 2019-03-29T10:44:54Z | vmax | test |
bazelbuild/bazel/7893_7894 | bazelbuild/bazel | bazelbuild/bazel/7893 | bazelbuild/bazel/7894 | [
"timestamp(timedelta=162812.0, similarity=0.8754590941708571)"
] | 46b180f1873a77d55345b440036c7d37268d2f78 | 98b6498be546a4493b3b3e4325d33d6022994ff5 | [] | [] | 2019-03-29T13:55:25Z | [] | bazel_repository_cache_test is very flaky | Latest example:
https://buildkite.com/bazel/google-bazel-presubmit/builds/17442#111594d7-068e-4e24-abaa-d57840e067af
I'll remove this test from the presubmit pipeline since it takes 20 minutes. | [
".bazelci/presubmit.yml"
] | [
".bazelci/presubmit.yml"
] | [] | diff --git a/.bazelci/presubmit.yml b/.bazelci/presubmit.yml
index e39fbeb5e3b034..90b5176d937116 100644
--- a/.bazelci/presubmit.yml
+++ b/.bazelci/presubmit.yml
@@ -24,6 +24,8 @@ platforms:
- "-//src/test/shell/bazel:bazel_determinism_test"
# Re-enable once fixed: https://github.com/bazelbuild/bazel/issues/... | null | train | train | 2019-03-29T14:54:12 | 2019-03-29T13:53:05Z | fweikert | test |
bazelbuild/bazel/7895_8276 | bazelbuild/bazel | bazelbuild/bazel/7895 | bazelbuild/bazel/8276 | [
"timestamp(timedelta=0.0, similarity=0.8984530232799471)"
] | 1df1635b0db2175191998d993052b8e37dadae7c | a68f135b19ac77b9150ea6b0c6b861cf48026500 | [] | [] | 2019-05-09T13:11:43Z | [
"team-Remote-Exec"
] | Remove deprecated remote flags | As Part of #7205 a few flags got deprecated, for instance, `exeprimental_retry-*`
Those flags have to be removed, including related functionality/tests (see TODOs in the code). | [
"src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java"
] | [] | diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
index 755b6e5ea7da18..c5a72a1bbbd133 100644
--- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java
+++ b/src/main/java/c... | null | train | train | 2019-05-09T14:50:15 | 2019-03-29T14:11:53Z | ishikhman | test |
bazelbuild/bazel/7907_7909 | bazelbuild/bazel | bazelbuild/bazel/7907 | bazelbuild/bazel/7909 | [
"timestamp(timedelta=75653.0, similarity=0.9415962211982463)"
] | 976876d21de9f502bd64156b1acd9967028d2e95 | f9de95b026af74b9ae7469bdec11be0db82617f5 | [] | [] | 2019-04-01T14:21:23Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows: Path.readSymbolicLink fails for junctions | ### Description of the problem / feature request:
Path.readSymbolicLink calls FileSystem.readSymbolicLink:
https://github.com/bazelbuild/bazel/blob/d7aa53ec68f573f9f130be18ac3ac1350d1d6be6/src/main/java/com/google/devtools/build/lib/vfs/Path.java#L599
On Windows, this calls into JavaIoFileSystem, which calls jav... | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java b/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
index d39173a5dba482..8244c7565b7ddf 100644
--- a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
+++ b/src/main/java/com/google... | diff --git a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java b/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java
index e5470749b0ea68..c8a4343967f245 100644
--- a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java
+++ b/src/test/jav... | test | train | 2019-04-01T16:09:08 | 2019-04-01T11:48:09Z | laszlocsomor | test |
bazelbuild/bazel/7907_7929 | bazelbuild/bazel | bazelbuild/bazel/7907 | bazelbuild/bazel/7929 | [
"timestamp(timedelta=0.0, similarity=0.9161274648519767)"
] | 0f569b0783d4a64ef210c9f9ddfd515b965fc04a | 0ae1cd8e79be3bc5403fce7a1889ac39abe5adbf | [] | [
"Why comment here? Is `READ_SYMLINK_OR_JUNCTION_ERROR` set or used anywhere?",
"For documentation, and to indicate that the value exists. The variable is not used anywhere (handled by `switch.default`).\r\n\r\nRemoved.",
"Nit: maybe 1, 2, 3, 4,?",
"These values match constants in `src/main/native/windows/file... | 2019-04-03T13:18:02Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows: Path.readSymbolicLink fails for junctions | ### Description of the problem / feature request:
Path.readSymbolicLink calls FileSystem.readSymbolicLink:
https://github.com/bazelbuild/bazel/blob/d7aa53ec68f573f9f130be18ac3ac1350d1d6be6/src/main/java/com/google/devtools/build/lib/vfs/Path.java#L599
On Windows, this calls into JavaIoFileSystem, which calls jav... | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java b/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
index d39173a5dba482..ee457b70652b5d 100644
--- a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
+++ b/src/main/java/com/google... | diff --git a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java b/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java
index e5470749b0ea68..b0c9454d5121dc 100644
--- a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java
+++ b/src/test/jav... | train | train | 2019-04-04T11:07:47 | 2019-04-01T11:48:09Z | laszlocsomor | test |
bazelbuild/bazel/7907_7931 | bazelbuild/bazel | bazelbuild/bazel/7907 | bazelbuild/bazel/7931 | [
"timestamp(timedelta=15588.0, similarity=0.8937945245048657)"
] | b9fd6f2c109c99d6523c0da92a5663f6ac4fdd69 | 69d575f35cb57d9a3d060712a18857d70083cc6f | [] | [] | 2019-04-03T15:26:42Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows: Path.readSymbolicLink fails for junctions | ### Description of the problem / feature request:
Path.readSymbolicLink calls FileSystem.readSymbolicLink:
https://github.com/bazelbuild/bazel/blob/d7aa53ec68f573f9f130be18ac3ac1350d1d6be6/src/main/java/com/google/devtools/build/lib/vfs/Path.java#L599
On Windows, this calls into JavaIoFileSystem, which calls jav... | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java",
"src/main/java/com/google/devtools/build/lib/windows/jni/WindowsFileOperations.java",
"src/main/native/windows/file-jni.cc",
"src/main/native/windows/file.cc",
"src/main/native/windows/file.h"
] | [
"src/test/java/com/google/devtools/build/lib/windows/WindowsFileOperationsTest.java",
"src/test/java/com/google/devtools/build/lib/windows/WindowsFileSystemTest.java",
"src/test/native/windows/file_test.cc"
] | diff --git a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java b/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
index ee457b70652b5d..5b3669b8ed5a8c 100644
--- a/src/main/java/com/google/devtools/build/lib/windows/WindowsFileSystem.java
+++ b/src/main/java/com/google... | diff --git a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileOperationsTest.java b/src/test/java/com/google/devtools/build/lib/windows/WindowsFileOperationsTest.java
index c5a50d32ab7895..11ceed1d74192c 100644
--- a/src/test/java/com/google/devtools/build/lib/windows/WindowsFileOperationsTest.java
+++ b/... | val | train | 2019-04-04T13:00:02 | 2019-04-01T11:48:09Z | laszlocsomor | test |
bazelbuild/bazel/7947_8440 | bazelbuild/bazel | bazelbuild/bazel/7947 | bazelbuild/bazel/8440 | [
"timestamp(timedelta=0.0, similarity=0.852926208408941)"
] | 207c24f04453ef026c202f2962e55d2a125e388f | 923c45faecaabd00e0214ff7d178507623958b37 | [
"cc @brandjon ",
"Ok, I played around with our windows sandbox vm and think I understand. The most likely situation is that your `py_runtime`'s `interpreter_path` attribute doesn't correctly identify a `Python.exe` binary. Please double check the path, and if you don't think that's the problem, please post the `p... | [
"Can the input `bash_binary` ever be just `bash.exe` for example, which would mean \"whatever is on the PATH\"?",
"I think there are two ways to tell which shell binary to use, `BAZEL_SH` or `--shell_executable`. Both way requires user to set an absolute path. The only case `bash_binary` is a relative path (runfi... | 2019-05-22T12:24:59Z | [
"type: bug",
"P1",
"team-Rules-Python"
] | Neither python_top nor python toolchain works with starlark actions on windows | ### Description of the problem / feature request:
Trying to use a `py_binary()` target as executable with `actions.run()` fails on windows if `py_runtime()` is used. Error Message:
```
LAUNCHER ERROR: Cannot launch process: "python.exe" ${PATH}\my_py_binary.zip ${ARGS}
Reason: (error: 2): The system cannot find t... | [
"src/tools/launcher/bash_launcher.cc",
"src/tools/launcher/python_launcher.cc"
] | [
"src/tools/launcher/bash_launcher.cc",
"src/tools/launcher/python_launcher.cc"
] | [] | diff --git a/src/tools/launcher/bash_launcher.cc b/src/tools/launcher/bash_launcher.cc
index 0020d5f92d55d3..67f0a5d53a2b51 100644
--- a/src/tools/launcher/bash_launcher.cc
+++ b/src/tools/launcher/bash_launcher.cc
@@ -30,6 +30,14 @@ static constexpr const char* BASH_BIN_PATH = "bash_bin_path";
ExitCode BashBinaryLa... | null | train | train | 2019-05-22T12:19:28 | 2019-04-04T19:31:03Z | pziggo | test |
bazelbuild/bazel/7956_7957 | bazelbuild/bazel | bazelbuild/bazel/7956 | bazelbuild/bazel/7957 | [
"timestamp(timedelta=0.0, similarity=0.9244978617764588)"
] | 466bf40f3f41fa6edf66f6401c5c16cb9b53510d | 6d4223b51218f4f2ffad0f118006dee2f777a96e | [] | [] | 2019-04-05T14:10:44Z | [
"type: bug",
"P2",
"area-Windows",
"team-OSS"
] | Windows: native test wrapper incorrectly escapes arguments [blocking #6622] | ### Description of the problem / feature request:
The Windows-native test wrapper should escape arguments when running the test.
To escape them, it should use https://github.com/bazelbuild/bazel/blob/afeb8d0b7fef619159fc8fbaaeb8bd41dd2619bd/src/tools/launcher/util/launcher_util.h#L61
### Bugs: what's the simples... | [
"src/tools/launcher/util/BUILD"
] | [
"src/tools/launcher/util/BUILD"
] | [
"src/test/py/bazel/BUILD",
"src/test/py/bazel/printargs.cc",
"src/test/py/bazel/test_wrapper_test.py",
"tools/test/BUILD",
"tools/test/windows/tw.cc"
] | diff --git a/src/tools/launcher/util/BUILD b/src/tools/launcher/util/BUILD
index 5077e2300775eb..e3aa79a8fe6ad7 100644
--- a/src/tools/launcher/util/BUILD
+++ b/src/tools/launcher/util/BUILD
@@ -1,6 +1,6 @@
package(default_visibility = ["//src/tools/launcher:__subpackages__"])
-load("//src/tools/launcher:win_rules.b... | diff --git a/src/test/py/bazel/BUILD b/src/test/py/bazel/BUILD
index d5f59d680c4530..ae947e2c9ba5c8 100644
--- a/src/test/py/bazel/BUILD
+++ b/src/test/py/bazel/BUILD
@@ -164,6 +164,16 @@ py_test(
"//src/conditions:windows": [":test_base"],
"//conditions:default": [],
}),
+ data = select({
+ ... | test | train | 2019-04-05T16:48:05 | 2019-04-05T13:53:47Z | laszlocsomor | test |
bazelbuild/bazel/7990_8973 | bazelbuild/bazel | bazelbuild/bazel/7990 | bazelbuild/bazel/8973 | [
"timestamp(timedelta=0.0, similarity=0.9344735508098679)"
] | eab8ae8a33138f26abf25bd736065083d867ca44 | 3a7c1eb7db8ea1e1555b9c72e2997d0249680f65 | [
"Hi Liam, could you pls update this issue to follow https://bazel.build/breaking-changes-guide.html? (e.g. the title of the issue is not right, I could fix that myself but that link is quite nicely written and contains useful advice :).",
"The docs say the title should start with the name of the flag, which is `i... | [] | 2019-07-24T14:02:33Z | [
"team-Rules-Java",
"incompatible-change"
] | incompatible_require_java_toolchain_header_compiler_direct | See: https://github.com/bazelbuild/bazel/commit/2ebb0a20b6caee1766820f17bf001350d5463e16. `java_toolchain.header_compiler_direct` should always be set when toolchain resolution is enabled.
No migration is needed for the built-in toolchains, or for custom toolchains using `default_java_toolchain`. | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java"
] | [
"src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java",
"src/test/java/com/google/devtools/build/lib/testutil/FoundationTestCase.java"
] | diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
index b824ea67be7755..85059953a65ab3 100644
--- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
+++ b/src/main/java/com/google/devtools... | diff --git a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java b/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
index 2b7c242d7f4729..2b1f235a28d652 100644
--- a/src/test/java/com/google/devtools/build/lib/analysis/mock/BazelAnalysisMock.java
+++ b/src/te... | train | train | 2019-08-09T11:34:41 | 2019-04-10T06:07:57Z | cushon | test |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.