Datasets:
feedback-to-code
/
mozzarella

Dataset card Data Studio Files
xet
 Community
1
instance_id
stringlengths
17
39
repo
stringclasses
8 values
issue_id
stringlengths
14
34
pr_id
stringlengths
14
34
linking_methods
listlengths
1
3
base_commit
stringlengths
40
40
merge_commit
stringlengths
0
40
⌀
hints_text
listlengths
0
106
resolved_comments
listlengths
0
119
created_at
timestamp[ns, tz=UTC]
labeled_as
listlengths
0
7
problem_title
stringlengths
7
174
problem_statement
stringlengths
0
55.4k
gold_files
listlengths
0
10
gold_files_postpatch
listlengths
1
10
test_files
listlengths
0
60
gold_patch
stringlengths
220
5.83M
test_patch
stringlengths
386
194k
⌀
split_random
stringclasses
3 values
split_time
stringclasses
3 values
issue_start_time
timestamp[ns]
issue_created_at
timestamp[ns, tz=UTC]
issue_by_user
stringlengths
3
21
split_repo
stringclasses
3 values
bazelbuild/bazel/8004_9274
bazelbuild/bazel
bazelbuild/bazel/8004
bazelbuild/bazel/9274
[ "timestamp(timedelta=168348.0, similarity=0.8569972656944206)" ]
902e7e5e79e4ec0530c1e011116763c8061dba31
76e8613774ed259bd1cacfc15d9cd1299190e599
[ "Related to: https://github.com/bazelbuild/bazel/issues/4680", "Done as of 58d3f17. Follow-up in #8830 " ]
[]
2019-08-28T16:09:34Z
[ "type: feature request", "team-Remote-Exec" ]
Tags to execution requirements propagation in Native Rules
It is not a secret that by default bazel does not propagate tags to the actions' execution requirements, the only exception would be the rules that are specifically adopted to do the propagation (e.g. test related tags are already propagated by the test runner). Tags should be propagated to the action from targets f...
[ "src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java", "src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileActionBuilder.java", "src/main/java/com/google/devtools/build/lib/rules/java/JavaInfoBuildHelper.java", "src/main/java/com/google/devtools/build/lib/rul...
[ "src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java", "src/main/java/com/google/devtools/build/lib/rules/java/JavaHeaderCompileActionBuilder.java", "src/main/java/com/google/devtools/build/lib/rules/java/JavaInfoBuildHelper.java", "src/main/java/com/google/devtools/build/lib/rul...
[ "src/test/shell/bazel/tags_propagation_native_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java b/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java index cfc20bcc494691..0a31a9daa54a57 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/java/JavaCompilationHelper.java +++ b/src...
diff --git a/src/test/shell/bazel/tags_propagation_native_test.sh b/src/test/shell/bazel/tags_propagation_native_test.sh index 7ffee2fab58800..969f3fbf549761 100755 --- a/src/test/shell/bazel/tags_propagation_native_test.sh +++ b/src/test/shell/bazel/tags_propagation_native_test.sh @@ -98,6 +98,119 @@ EOF assert_con...
val
train
2019-08-30T14:08:23
2019-04-11T12:25:19Z
ishikhman
test
bazelbuild/bazel/8005_8075
bazelbuild/bazel
bazelbuild/bazel/8005
bazelbuild/bazel/8075
[ "timestamp(timedelta=0.0, similarity=0.9048184539213349)" ]
0e8c8a9aefb5290cc03571477c5c01d507eb02e0
0af34a59ba15725dc5bcb5e077844bf6e88e5279
[ "Mostly out of curiosity because I was filing https://github.com/bazelbuild/bazel/issues/10245 and this bug turned out as suggested.\r\n\r\nHow was this fixed? If I'm reading things correctly, Bazel now kills the process group on Windows, right? But do you wait for the subprocesses at all? If not, you'd be subject ...
[]
2019-04-17T10:28:52Z
[ "type: bug", "P2", "area-Windows", "team-OSS" ]
Windows: native test wrapper waits for all grandchild processes
### Description of the problem / feature request: The Windows-native test wrapper waits for all subprocesses of the test to terminate, even after the test itself terminated. I believe the test wrapper should use job objects: https://github.com/bazelbuild/bazel/blob/c6c303009c207dae2e6342eee9b8a25e37ca20ca/src/mai...
[ "src/main/native/windows/process.cc", "src/main/native/windows/process.h", "src/main/native/windows/processes-jni.cc" ]
[ "src/main/native/windows/process.cc", "src/main/native/windows/process.h", "src/main/native/windows/processes-jni.cc" ]
[ "tools/test/BUILD", "tools/test/windows/tw.cc" ]
diff --git a/src/main/native/windows/process.cc b/src/main/native/windows/process.cc index 82fec19a2150cc..5b7976add1a9f2 100644 --- a/src/main/native/windows/process.cc +++ b/src/main/native/windows/process.cc @@ -33,6 +33,7 @@ bool WaitableProcess::Create(const std::wstring& argv0, const...
diff --git a/tools/test/BUILD b/tools/test/BUILD index 6deb7dde275004..d259336de9c535 100644 --- a/tools/test/BUILD +++ b/tools/test/BUILD @@ -79,6 +79,7 @@ cc_library( "//src/main/cpp/util:filesystem", "//src/main/cpp/util:strings", "//src/main/native/windows:lib-file", + ...
train
train
2019-04-17T11:37:34
2019-04-11T13:56:41Z
laszlocsomor
test
bazelbuild/bazel/8061_9062
bazelbuild/bazel
bazelbuild/bazel/8061
bazelbuild/bazel/9062
[ "timestamp(timedelta=0.0, similarity=0.9152128395372776)" ]
2c046486f5febb9e475a5589b59abae77f14245e
d45bff50170be3bf8936b36603e079672ee0a744
[ "Hi @ishikhman, just in the improbable case you didn't see it, we have a page with infomation how to roll out breaking changes over at https://bazel.build/breaking-changes-guide.html. There are some minor things missing in this issue (title format, missing migration-ready label)\r\n\r\nThanks!", "thanks @hlopko! ...
[]
2019-08-02T15:02:47Z
[ "incompatible-change", "team-Remote-Exec" ]
incompatible_tls_enabled_removed: flip it and enable tls by default while deprecating tls_enabled flag
`--tls_enabled` flag is deprecated and should be removed in one of the next releases. If `--incompatible_tls_enabled_removed` flag set to true, an error is rised in case tls_enabled is still in use. **Migration** * gRPC + enabled TLS: Replace `--tls_enabled=true` and `--remote_cache=localhost:1234` with : `--remo...
[ "src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java", "src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java" ]
[ "src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java", "src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java" ]
[ "src/test/shell/bazel/remote/remote_execution_tls_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java b/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java index 1a0540b4c3f0b2..a92454d8a5ebc1 100644 --- a/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java +++ b/src/main/java/c...
diff --git a/src/test/shell/bazel/remote/remote_execution_tls_test.sh b/src/test/shell/bazel/remote/remote_execution_tls_test.sh index 9766a25fabb99c..c9205b93caeeee 100755 --- a/src/test/shell/bazel/remote/remote_execution_tls_test.sh +++ b/src/test/shell/bazel/remote/remote_execution_tls_test.sh @@ -86,16 +86,15 @@ f...
train
train
2019-08-02T16:16:20
2019-04-16T13:03:47Z
ishikhman
test
bazelbuild/bazel/8111_8112
bazelbuild/bazel
bazelbuild/bazel/8111
bazelbuild/bazel/8112
[ "timestamp(timedelta=0.0, similarity=0.9391538612296311)" ]
2419cb3d7d8b5dd8f1a8bad7b57760d276730c4d
019fbf3d5df715272eb2fc353d0d2075136c0719
[ "We could accept this. Could you please send a PR?", "@oquenchil, there is a linked PR, I've just updated it to resolve a conflict." ]
[]
2019-04-23T07:03:50Z
[ "P3", "team-Rules-CPP" ]
Accept .h++ as an extension for C++ headers
### Description of the problem / feature request: This is very similar to #302. I am trying to build an existing project ([libconfig](https://github.com/hyperrealm/libconfig)) which uses `.h++` as the extension for C++ header files but this extension is not supported by Bazel. This would affect anyone else working w...
[ "src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java index 1ccaf58a3ee020..2db8ed95ca1de7 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java +++ b/src/main/java/com/google/devtools...
null
train
train
2019-06-06T10:23:25
2019-04-23T07:01:37Z
macbutch
test
bazelbuild/bazel/8124_9377
bazelbuild/bazel
bazelbuild/bazel/8124
bazelbuild/bazel/9377
[ "timestamp(timedelta=0.0, similarity=0.8410558750698534)" ]
41a8dfd2c511933a8d7d7b5014da1258b8e5b07d
bb8563909ec0dacce2ef8040b270f2a9bd718d48
[]
[]
2019-09-12T21:04:34Z
[ "P2", "team-Rules-Java" ]
Unclear documentation for JavaInfo transitive
https://docs.bazel.build/versions/master/skylark/lib/JavaInfo.html It is unclear what the difference is between `transitive_compile_time_jars` and `transitive_deps`. It is unclear what the difference is between `transitive_runtime_deps` and `transitive_runtime_jars`.
[ "src/main/java/com/google/devtools/build/lib/skylarkbuildapi/java/JavaInfoApi.java" ]
[ "src/main/java/com/google/devtools/build/lib/skylarkbuildapi/java/JavaInfoApi.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/java/JavaInfoApi.java b/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/java/JavaInfoApi.java index e05196d42418c1..1ccb862e7bf738 100644 --- a/src/main/java/com/google/devtools/build/lib/skylarkbuildapi/java/JavaInfoApi.java +++ b/src...
null
train
train
2019-09-12T20:45:16
2019-04-24T02:07:59Z
pauldraper
test
bazelbuild/bazel/8136_9105
bazelbuild/bazel
bazelbuild/bazel/8136
bazelbuild/bazel/9105
[ "timestamp(timedelta=1533.0, similarity=0.9142795228005521)" ]
320e45abe7bb12b954cb6e4566084bdbd45985eb
fd08307b6e5feb2a717365e4ed8355946b9631ba
[ "According to https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/191#annotation-flags_ready_to_flip this is ready to go after 0.29 is cut.", "This flag is now flipped." ]
[]
2019-08-07T14:03:47Z
[ "team-Configurability", "incompatible-change" ]
incompatible_disallow_rule_execution_platform_constraints_allowed: Disallow the execution_platform_constraints_allowed attribute to rule
As part of #8134, we need to remove the `execution_platform_constraints_allowed` attribute to Starlark's `rule()` function. After the attribute is removed, all targets will be able to use `exec_compatible_with` to add restrictions on the execution platform. # Migration Remove any existing uses of `execution_platf...
[ "src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java", "src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java" ]
[ "src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java", "src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java" ]
[ "src/test/shell/bazel/toolchain_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 0b28c8635390e1..ed59d033834f2c 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/...
diff --git a/src/test/shell/bazel/toolchain_test.sh b/src/test/shell/bazel/toolchain_test.sh index 5b4f707b4c5905..1b75ce1155fa5d 100755 --- a/src/test/shell/bazel/toolchain_test.sh +++ b/src/test/shell/bazel/toolchain_test.sh @@ -1003,7 +1003,6 @@ sample_rule = rule( implementation = _impl, attrs = {}, toolch...
train
train
2019-08-07T16:37:42
2019-04-24T18:47:20Z
katre
test
bazelbuild/bazel/8216_9338
bazelbuild/bazel
bazelbuild/bazel/8216
bazelbuild/bazel/9338
[ "timestamp(timedelta=0.0, similarity=0.8506912288053868)" ]
d3f8efca72a0e2013467c033df1bf58dd76e8a10
b74767dab209b193181af25af79c866178cb71ac
[ "I agree. disk cache should always be read/write and the `remote_upload_local_results` flag should only apply to remote caching.", "Hey @ishikhman! Have you had a chance to look any further into this?", "@SrodriguezO we love contributions :)", "We're happy to help! Just wanted to avoid duplicate efforts, sinc...
[ "Suggested rephrasing:\r\n\r\n\"If set to true, --noremote_upload_local_results will not apply to the disk cache. If a combined cache is used, --noremote_upload_local_results will cause results to be written to the disk cache, but not uploaded to the remote cache. See #8216 for details.\"", "Thanks.", "I find t...
2019-09-05T19:20:55Z
[ "type: bug", "team-Remote-Exec" ]
--disk_cache overrides --noremote_upload_local_results
### Description of the feature request: I would like to be able to use the `--disk_cache` as a read/write cache, but the remote cache as a read-only cache. I thought `--noremote_upload_local_results` would do this, but it seems that flag is just overridden by the `--disk_cache` option. It seems this is the expected ...
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteCacheClientFactory.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/disk/BUILD", "src/main/j...
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteCacheClientFactory.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/disk/BUILD", "src/main/j...
[ "src/test/shell/bazel/remote/remote_execution_http_test.sh", "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteCacheClientFactory.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteCacheClientFactory.java index a5944544bf79bc..2a8d9ddd98f7a4 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/RemoteCacheClientFactory.java +++ b/src/ma...
diff --git a/src/test/shell/bazel/remote/remote_execution_http_test.sh b/src/test/shell/bazel/remote/remote_execution_http_test.sh index 2925a1a12a55d2..0bfafd14fc9644 100755 --- a/src/test/shell/bazel/remote/remote_execution_http_test.sh +++ b/src/test/shell/bazel/remote/remote_execution_http_test.sh @@ -364,6 +364,10...
train
train
2019-11-29T11:55:32
2019-05-01T21:39:17Z
JaredNeil
test
bazelbuild/bazel/8224_8914
bazelbuild/bazel
bazelbuild/bazel/8224
bazelbuild/bazel/8914
[ "timestamp(timedelta=1.0, similarity=0.9213581146036626)" ]
87506825333846359462f37d92b6f7bd2119f109
2cbd78014fef74158b94c4accbccba5afa6fc4e6
[ "This makes sense, and definitely needs to happen. Thanks for catching it.", "@buchgr did you mean `--remote_default_platform_properties` flag?", "Yes!" ]
[ "maybe introduce a new reason?", "sure, just wanted to make sure that it works this way first, and it is!\r\n\r\nI also spend some time trying to avoid using actionKeyContext - no good alternative so far - requires tooo many changes (like a lot). Will try add it to the BuildOptions maybe in the next experiment's ...
2019-07-17T11:16:48Z
[ "type: bug", "team-Remote-Exec" ]
--remote_default_host_platform_properties should invalidate actions
If the contents of this flag change then skyframe actions should also be invalidated. cc @katre
[ "src/main/java/com/google/devtools/build/lib/actions/ActionCacheChecker.java", "src/main/java/com/google/devtools/build/lib/actions/cache/ActionCache.java", "src/main/java/com/google/devtools/build/lib/actions/cache/CompactPersistentActionCache.java", "src/main/java/com/google/devtools/build/lib/skyframe/Acti...
[ "src/main/java/com/google/devtools/build/lib/actions/ActionCacheChecker.java", "src/main/java/com/google/devtools/build/lib/actions/cache/ActionCache.java", "src/main/java/com/google/devtools/build/lib/actions/cache/CompactPersistentActionCache.java", "src/main/java/com/google/devtools/build/lib/skyframe/Acti...
[ "src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java", "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/actions/ActionCacheChecker.java b/src/main/java/com/google/devtools/build/lib/actions/ActionCacheChecker.java index ca6195da22a3bc..899e05bb2cc847 100644 --- a/src/main/java/com/google/devtools/build/lib/actions/ActionCacheChecker.java +++ b/src/main/java/com/goo...
diff --git a/src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java b/src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java index 42ac908cc9f065..8c77f24bb41d52 100644 --- a/src/test/java/com/google/devtools/build/lib/actions/ActionCacheCheckerTest.java +++ b/src/test/...
train
train
2019-09-19T17:44:36
2019-05-02T11:27:05Z
buchgr
test
bazelbuild/bazel/8283_8510
bazelbuild/bazel
bazelbuild/bazel/8283
bazelbuild/bazel/8510
[ "timestamp(timedelta=0.0, similarity=0.9104500804793587)" ]
3290e22356b59371274849ee51297635b9435285
35a7e26254007e2736b56339959bcbe78c3456cd
[ "In preparing for the new 64 bit support requirment incoming for August 1st https://developer.android.com/distribute/best-practices/develop/64-bit\r\n\r\nI have come across this issue as well. Is there a recommended workaround? Right now our best option seems to be to generate both versions separately, merge them a...
[]
2019-05-29T23:40:54Z
[ "P1", "team-Android" ]
`--fat_apk_cpu` doesn't pack multi-arch libraries from aar_import targets
If an aar contains .so files for multiple architectures (e.g. foo and bar), and an android_binary depends on this aar, `--fat_apk_cpu=foo,bar` doesn't pack both so files into the final APK correctly. The current behavior only packs the .so for one target configuration into the APK.
[ "src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java" ]
[ "src/test/shell/bazel/android/BUILD", "src/test/shell/bazel/android/aar_integration_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java b/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java index 8d85efc9cff4f5..c6d74a62fb3296 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AndroidBinary.java +++ b/src/main/java/com/...
diff --git a/src/test/shell/bazel/android/BUILD b/src/test/shell/bazel/android/BUILD index e630e7f4cd7ca8..f3fd31364bf44e 100644 --- a/src/test/shell/bazel/android/BUILD +++ b/src/test/shell/bazel/android/BUILD @@ -55,6 +55,7 @@ sh_test( srcs = ["aar_integration_test.sh"], data = [ ":android_helper",...
train
train
2019-05-30T01:35:13
2019-05-09T22:14:30Z
jin
test
bazelbuild/bazel/8310_8314
bazelbuild/bazel
bazelbuild/bazel/8310
bazelbuild/bazel/8314
[ "timestamp(timedelta=0.0, similarity=0.887577316376066)" ]
cad310fdd047659fb1435ba16bcb1802dabe0ada
85c96d91f3186f93b2d3ad6ce8890b106e686751
[ "@meteorcloudy : do you have time to fix this or shall I?", "Can you fix this? Thanks!", "Will do, thanks!" ]
[ "Can we set default to None here? If so, we don't need enable_warning = False, either.", "We can't, because then `_get_path_env_var` fail when SYSTEMROOT is undefined.", "But we could just set default to `c:\\windows`, let me do that.", "Sounds good, but for \"BAZEL_VC\" and \"BAZEL_VS\", I guess we can set t...
2019-05-14T11:37:12Z
[ "type: feature request", "P2", "area-Windows", "team-OSS" ]
Windows: BAZEL_* envvars should support quotes
### Description of the problem / feature request: Allow `BAZEL_VC` and other `BAZEL_*` envvars to have quotes in them. Quotes are never allows in Windows paths, so the quote cannot be part of the path, so de-quoting is safe. Quotes appear when using TAB-completion in cmd.exe, as one sets the envvar. A tab-comp...
[ "tools/cpp/windows_cc_configure.bzl" ]
[ "tools/cpp/windows_cc_configure.bzl" ]
[]
diff --git a/tools/cpp/windows_cc_configure.bzl b/tools/cpp/windows_cc_configure.bzl index 84f755b43ea4bb..35d0d664a173db 100644 --- a/tools/cpp/windows_cc_configure.bzl +++ b/tools/cpp/windows_cc_configure.bzl @@ -26,6 +26,36 @@ load( "resolve_labels", ) +def _get_path_env_var(repository_ctx, name): + """Re...
null
train
train
2019-05-14T05:36:38
2019-05-14T07:25:54Z
laszlocsomor
test
bazelbuild/bazel/8316_9134
bazelbuild/bazel
bazelbuild/bazel/8316
bazelbuild/bazel/9134
[ "timestamp(timedelta=1.0, similarity=0.8444108793819863)" ]
71288e62330b5a8d3ba174112f4e7ed8fcf86558
a9c9bbf72faa4b7408a7de24e361e00effbc47e8
[ "Since this is Windows-specific and @meteorcloudy is in the Windows subteam, can we label this as \"team-Windows\"?", "This is not entirely Windows specific, we will also enable native patch on other platforms. But since we are doing the work, I don't mind labeling it as \"team-Windows\"", "Is this on track for...
[]
2019-08-09T13:20:45Z
[ "type: feature request", "P1", "area-Windows", "team-OSS" ]
incompatible_use_native_patch: Use native patch in http_archive and git_repository rules
# Description Bazel's [repository rules](https://github.com/bazelbuild/bazel/tree/master/tools/build_defs/repo) depends on `patch` and bash tools on all platforms. This requires users to install MSYS2 on Windows. We need to break the bash dependency from repository rule. To break the dependency on the patch command...
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java index 8081d54484d4bc..ce2ad4afdabd76 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryOptions.java +++...
null
train
train
2019-08-09T15:00:05
2019-05-14T12:45:17Z
meteorcloudy
test
bazelbuild/bazel/8340_8341
bazelbuild/bazel
bazelbuild/bazel/8340
bazelbuild/bazel/8341
[ "timestamp(timedelta=0.0, similarity=0.9040380497836834)" ]
eaf066b3b8c2f6533cce1caed559540b1ca10252
d6677fce4f93f388b436957fc7cf5800eb4d968f
[ "cc @ahumesky " ]
[]
2019-05-15T22:14:24Z
[ "team-Android", "untriaged" ]
Improve build speed by not registering ImportDepsChecker actions in aar_import when --experimental_import_deps_checker is "off"
Since import deps checker is off by default in Bazel, don't register the action and create the jdeps output. Only register it if the levels are `warning` or `error`. Build profiles for https://github.com/google/google-authenticator-android on a 12 core linux machine: With importdepschecker: ![ss](https://user...
[ "src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java" ]
[ "src/test/java/com/google/devtools/build/lib/rules/android/AarImportTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java b/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java index b532c7dd1b029d..78008faac27e0f 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java +++ b/src/main/java/com/google/devto...
diff --git a/src/test/java/com/google/devtools/build/lib/rules/android/AarImportTest.java b/src/test/java/com/google/devtools/build/lib/rules/android/AarImportTest.java index 3d5851acb9795e..e9bed20e0df358 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/android/AarImportTest.java +++ b/src/test/java/com/...
train
train
2019-05-15T23:14:14
2019-05-15T22:13:35Z
jin
test
bazelbuild/bazel/8393_8428
bazelbuild/bazel
bazelbuild/bazel/8393
bazelbuild/bazel/8428
[ "timestamp(timedelta=0.0, similarity=0.859437736938755)" ]
ddce7235ef29a0aba727c265eae865d15af4ed09
7c7f2fc72bea165971ed2efbe5f616c41ef60d77
[ "That's not an intended change (@agoulti). I think it should be possible to negate all our flags. WDYT @ishikhman?", "I agree, we should keep the possibility to negate/disable all flags. It feels to me like a bug in a recent change that introduced a new set of flags.", "Note that I just discovered that this is ...
[]
2019-05-21T22:17:12Z
[ "type: bug", "team-Remote-Exec" ]
--execution_log_binary_file negation
Using bazel 0.26.0rc10 and `--execution_log_binary_file`, you cannot negate the argument with `--execution_log_binary_file=` as you could with `experimental_execution_log_file`. I'm not sure if it was intentional behavior before but previously passing: ``` bazel build //... --experimental_execution_log_file=foo.log...
[ "src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java" ]
[ "src/test/shell/bazel/bazel_execlog_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java b/src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java index dea75cf9938187..a2bb9cd30c96dd 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/SpawnLogModule.java +++ b/src/main/java/com/google/devtools/build...
diff --git a/src/test/shell/bazel/bazel_execlog_test.sh b/src/test/shell/bazel/bazel_execlog_test.sh index 6dfbdc251048f8..89b9e8443559d0 100755 --- a/src/test/shell/bazel/bazel_execlog_test.sh +++ b/src/test/shell/bazel/bazel_execlog_test.sh @@ -119,4 +119,28 @@ EOF wc output || fail "no output produced" } +func...
train
train
2019-05-22T00:10:20
2019-05-17T23:08:34Z
keith
test
bazelbuild/bazel/8411_8440
bazelbuild/bazel
bazelbuild/bazel/8411
bazelbuild/bazel/8440
[ "timestamp(timedelta=2039.0, similarity=0.8498988494004115)" ]
207c24f04453ef026c202f2962e55d2a125e388f
923c45faecaabd00e0214ff7d178507623958b37
[]
[ "Can the input `bash_binary` ever be just `bash.exe` for example, which would mean \"whatever is on the PATH\"?", "I think there are two ways to tell which shell binary to use, `BAZEL_SH` or `--shell_executable`. Both way requires user to set an absolute path. The only case `bash_binary` is a relative path (runfi...
2019-05-22T12:24:59Z
[ "P1", "type: process", "team-Rules-Python" ]
Ensure Python tests run under Windows
We [currently disable](https://github.com/bazelbuild/bazel/blob/bdc6c10b674757df38982e71752aab8eddab47a0/src/test/shell/bazel/BUILD#L724-L725) some Python tests under Windows because until recently our CI machines didn't have both Python 2 and Python 3 available. Now that that's resolved, we should enable them. P1 b...
[ "src/tools/launcher/bash_launcher.cc", "src/tools/launcher/python_launcher.cc" ]
[ "src/tools/launcher/bash_launcher.cc", "src/tools/launcher/python_launcher.cc" ]
[]
diff --git a/src/tools/launcher/bash_launcher.cc b/src/tools/launcher/bash_launcher.cc index 0020d5f92d55d3..67f0a5d53a2b51 100644 --- a/src/tools/launcher/bash_launcher.cc +++ b/src/tools/launcher/bash_launcher.cc @@ -30,6 +30,14 @@ static constexpr const char* BASH_BIN_PATH = "bash_bin_path"; ExitCode BashBinaryLa...
null
val
train
2019-05-22T12:19:28
2019-05-20T19:18:33Z
brandjon
test
bazelbuild/bazel/8422_8426
bazelbuild/bazel
bazelbuild/bazel/8422
bazelbuild/bazel/8426
[ "timestamp(timedelta=0.0, similarity=0.8609879841428745)" ]
b7a961517f928e6539b62f73bcb5b1c311396559
0bcdab22965da92139731bb5c696d1da9ff273f3
[ "This should have been fixed by https://github.com/bazelbuild/bazel/commit/231270c67d5aa771462245531fa9b2ee7d3d0ae8, you're definitely on 0.25.2? It definitely appears to be in that tag https://github.com/bazelbuild/bazel/blob/0.25.2/tools/osx/xcode_locator.m#L181-L188\r\n\r\ncc @sayrer ", "> you're definitely on...
[]
2019-05-21T21:44:32Z
[ "type: bug", "P2", "z-team-Apple" ]
xcode-locator fails in macOS-10.12
### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. ```bash git clone https://github.com/bazelbuild/examples.git cd cpp-tutorial/stage1 bazel build //... ``` Error: ``` Starting local Bazel server and connecting to it... INFO: Analyzed target //ma...
[ "tools/osx/xcode_locator.m" ]
[ "tools/osx/xcode_locator.m" ]
[]
diff --git a/tools/osx/xcode_locator.m b/tools/osx/xcode_locator.m index 90c00fafcc5b74..18f77bdab1ac14 100644 --- a/tools/osx/xcode_locator.m +++ b/tools/osx/xcode_locator.m @@ -177,16 +177,7 @@ static void AddEntryToDictionary( url, version, expandedVersion); NSURL *versionPlistUrl = [url URLByAppen...
null
test
train
2019-05-21T20:52:46
2019-05-21T18:07:09Z
soonho-tri
test
bazelbuild/bazel/8475_8480
bazelbuild/bazel
bazelbuild/bazel/8475
bazelbuild/bazel/8480
[ "timestamp(timedelta=0.0, similarity=0.8496345730895418)" ]
15a67757a3c9d7face58aba5caf74902429d9f60
252b34bd042bfb64f497cb21faa816338a035386
[ "Thanks for working on the fix! :)", "FYI, this issue also breaks tulsi (https://buildkite.com/bazel/tulsi-bazel-darwin/builds/161). CC @DavidGoldman. Patch release with the fix is being prepared." ]
[]
2019-05-28T15:10:57Z
[ "P1", "breakage" ]
"WORKSPACE file can not be a symlink" exception thrown: backward-incompatible bug
Bazel 0.26, if the WORKSPACE file is a symlink, an exception is thrown. This is not intended change, it should be thrown only if managed directories are used in the project.
[ "src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java" ]
[ "src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java" ]
[ "src/test/java/com/google/devtools/build/lib/blackbox/tests/manageddirs/ManagedDirectoriesBlackBoxTest.java", "src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace/WorkspaceBlackBoxTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java b/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java index a760a30b578f41..0e474f66a79c44 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/SequencedSkyframeExecutor.java +++...
diff --git a/src/test/java/com/google/devtools/build/lib/blackbox/tests/manageddirs/ManagedDirectoriesBlackBoxTest.java b/src/test/java/com/google/devtools/build/lib/blackbox/tests/manageddirs/ManagedDirectoriesBlackBoxTest.java index 0c949c8391575e..e3ea58f30afc65 100644 --- a/src/test/java/com/google/devtools/build/l...
val
train
2019-05-28T16:45:31
2019-05-28T10:42:40Z
irengrig
test
bazelbuild/bazel/8507_8519
bazelbuild/bazel
bazelbuild/bazel/8507
bazelbuild/bazel/8519
[ "timestamp(timedelta=0.0, similarity=0.9806730409642898)" ]
221c67fc1dceb9f06c4fdbaf8e839f8dfa83e358
5e3a794cb4f6077037f61cb5d175590f4e443a2a
[ "I can take a stab at this." ]
[]
2019-05-30T15:27:33Z
[ "P1", "bad error messaging" ]
Improve error message for incompatible_string_join_requires_strings
When the flag `--incompatible_string_join_requires_strings` is enabled, Baze checks that each element is a string (see https://github.com/bazelbuild/bazel/issues/7802). However, the error message is just a type error. This can be confusing for users who are upgrading Bazel. The error message should at least include ...
[ "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[ "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java b/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java index 1d4cf1bca70c4f..4e2e46ba5a12be 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/StringModule.java +++ b/src/main/java/com/google/devtools/build/li...
null
train
train
2019-05-30T16:39:34
2019-05-29T22:13:30Z
laurentlb
test
bazelbuild/bazel/8572_9273
bazelbuild/bazel
bazelbuild/bazel/8572
bazelbuild/bazel/9273
[ "timestamp(timedelta=157322.0, similarity=0.8757402397972228)" ]
c099341dd3426508f940f566c40ac2d3d93e2506
fe27ce112454077fce1ac3108d94a855406aadf5
[ "Is there a release candidate available? ", "@or-shachar the target RC date is in August. ", "@or-shachar I plan to cut the release on Thursday morning (NYC time).", "https://github.com/bazelbuild/bazel/issues/6790, deemed a requirement for Bazel 1.0, requires an incompatible flag that has not been submitted ...
[]
2019-08-28T15:00:22Z
[ "release" ]
Release 0.29 - August 2019 (stable)
Target RC date - August 1st, 2019. This release will have no [breaking changes](https://docs.bazel.build/versions/master/backward-compatibility.html). See the [blog post](https://blog.bazel.build/2019/06/06/Bazel-Semantic-Versioning.html) for some details
[ "scripts/docs/doc_versions.bzl", "site/_config.yml" ]
[ "scripts/docs/doc_versions.bzl", "site/_config.yml" ]
[]
diff --git a/scripts/docs/doc_versions.bzl b/scripts/docs/doc_versions.bzl index 45fbb43e6e0471..5d57e0a89822a1 100644 --- a/scripts/docs/doc_versions.bzl +++ b/scripts/docs/doc_versions.bzl @@ -22,6 +22,10 @@ """This module contains the versions and hashes of Bazel's documentation tarballs.""" DOC_VERSIONS = [ + ...
null
train
train
2019-08-28T16:36:11
2019-06-06T08:35:43Z
dslomov
test
bazelbuild/bazel/8596_8600
bazelbuild/bazel
bazelbuild/bazel/8596
bazelbuild/bazel/8600
[ "timestamp(timedelta=0.0, similarity=0.9495789907343556)" ]
10a42618daec9596969d32cf5189197b7610326a
23e2f6e4551850a7014d407d5ef2a706a7086a56
[ "CC @katre, @gregce, @aiuto." ]
[ "Is this deterministic? (IIRC we set the timestamps to some constant on the final zip call, but it would be nice to get change pruning in this step, too)", "This looks somewhat complicated... (I'm not sure if there is a simpler way to cut the first few path segments, though)", "+1!\r\n", "Which part worries y...
2019-06-11T12:53:54Z
[ "type: feature request", "P1", "team-Configurability" ]
Embed a release of @platforms into the Bazel binary
This is a tracking issue implementing the effort described at [Migrating @bazel_tools to @platforms](https://docs.google.com/document/d/1EArrWYUDugqJzBcb0-OxY5BH1FFPYV3jxLIXbJpD9RY/edit?pli=1#heading=h.5mcn15i0e1ch) design doc. The main goal is to bundle a snapshot of [@platforms](https://github.com/bazelbuild/platf...
[ "WORKSPACE", "src/BUILD", "src/main/java/com/google/devtools/build/lib/bazel/repository/local_config_platform.WORKSPACE", "src/package-bazel.sh" ]
[ "WORKSPACE", "src/BUILD", "src/main/java/com/google/devtools/build/lib/bazel/repository/local_config_platform.WORKSPACE", "src/package-bazel.sh" ]
[ "src/test/shell/bazel/BUILD", "src/test/shell/bazel/platforms_test.sh" ]
diff --git a/WORKSPACE b/WORKSPACE index 18156c2ca601a7..05b16806e0b133 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -117,6 +117,8 @@ distdir_tar( "8ccf4f1c351928b55d5dddf3672e3667f6978d60.tar.gz", "0.16.2.zip", "android_tools_pkg-0.5.tar.gz", + # bazelbuild/platforms + "441afe1bfd...
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD index 86868870eb1b78..391bcb4f397c1d 100644 --- a/src/test/shell/bazel/BUILD +++ b/src/test/shell/bazel/BUILD @@ -1080,6 +1080,12 @@ sh_test( deps = ["@bazel_tools//tools/bash/runfiles"], ) +sh_test( + name = "platforms_test", + srcs = [...
train
train
2019-06-11T14:41:28
2019-06-11T09:16:45Z
hlopko
test
bazelbuild/bazel/8623_8661
bazelbuild/bazel
bazelbuild/bazel/8623
bazelbuild/bazel/8661
[ "timestamp(timedelta=98643.0, similarity=0.8408936388185629)" ]
479cf339d1e3a2638fa3e8af4e8654a46b5def9a
null
[ "@philwo found out this important fix is lost after refactoring: https://github.com/bazelbuild/bazel/commit/39688b2454965eb45aa2f02a3f078adeee06ccd1", "The breakage has been fixed by rollback" ]
[]
2019-06-18T11:43:57Z
[ "type: bug", "P1", "breakage", "team-ExternalDeps" ]
Bazel CI: Downstream jobs are broken by git_repository refactoring
ERROR: type should be string, got "https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1035\r\n\r\nBazel Codelabs\r\n```\r\nERROR: An error occurred during the fetch of repository 'org_golang_google_grpc':\r\n--\r\n  | Traceback (most recent call last):\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git.bzl\", line 158\r\n  | _clone_or_update(ctx)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git.bzl\", line 31, in _clone_or_update\r\n  | git_repo(ctx, directory)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git_worker.bzl\", line 91, in git_repo\r\n  | _update(ctx, git_repo)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git_worker.bzl\", line 104, in _update\r\n  | reset(ctx, git_repo)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git_worker.bzl\", line 124, in reset\r\n  | _git(ctx, git_repo, \"reset\", \"--hard\", git_re...)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git_worker.bzl\", line 142, in _git\r\n  | _error(ctx.name, (start + list(args)), st.s...)\r\n  | File \"/var/lib/buildkite-agent/.cache/bazel/_bazel_buildkite-agent/9dba31623650bde83bfd5e4fc944f26a/external/bazel_tools/tools/build_defs/repo/git_worker.bzl\", line 164, in _error\r\n  | fail((\"error running '%s' while worki...)))\r\n  | error running 'git reset --hard 2fdaae294f38ed9a121193c51ec99fecd3b13eb7' while working with @org_golang_google_grpc:\r\n  | fatal: Could not parse object '2fdaae294f38ed9a121193c51ec99fecd3b13eb7'.\r\n\r\n```\r\nCulprit: 50a2d6c9b9c55776ec747a656a2edd971e723771\r\nhttps://buildkite.com/bazel/culprit-finder/builds/165\r\n\r\n/cc @irengrig \r\n\r\nFYI @buchgr for Green Team rotation."
[ "tools/build_defs/repo/git.bzl" ]
[ "tools/build_defs/repo/git.bzl", "tools/build_defs/repo/git_worker.bzl" ]
[ "src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestContext.java", "src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace/BUILD", "src/test/java/com/google/devtools/build/lib/blackbox/tests/workspace/GitRepositoryBlackBoxTest.java", "src/test/java/com/google/devtools/bui...
diff --git a/tools/build_defs/repo/git.bzl b/tools/build_defs/repo/git.bzl index 22692baf618b9d..22c07918bc39c7 100644 --- a/tools/build_defs/repo/git.bzl +++ b/tools/build_defs/repo/git.bzl @@ -13,7 +13,8 @@ # limitations under the License. """Rules for cloning external git repositories.""" -load(":utils.bzl", "pa...
diff --git a/src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestContext.java b/src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestContext.java index 0525f34f82533f..98583f05b7fee9 100644 --- a/src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestCont...
train
train
2019-06-18T12:48:46
2019-06-13T08:48:54Z
meteorcloudy
test
bazelbuild/bazel/8646_8648
bazelbuild/bazel
bazelbuild/bazel/8646
bazelbuild/bazel/8648
[ "timestamp(timedelta=0.0, similarity=0.8454864151265358)" ]
620d21c40cdd9bf9187fe74263ade3db1edaa009
4ef5f4ed104f7037f742bcc8c7f21cd07f039e9b
[ "The fix is to call `SpawnExecutionContext.lockOutputfiles()` before starting downloading of outputs." ]
[ "Reword: \"Ensure that we are the only ones writing to the output files when using the dynamic spawn strategy.\"\r\n\r\nAlso not sure why the bug link in the code is necessary. Yes, there was a bug that's fixed with this change. Reference it in the commit description instead?" ]
2019-06-17T12:21:02Z
[ "untriaged", "team-Remote-Exec" ]
the dynamic spawn strategy is broken for remote execution
We have received several bug reports about the dynamic spawn strategy not working properly with remote execution / caching. I took some time to look through the code to better understand the issue. I believe to now understand the heart of the issue. The dynamic spawn strategy in a single line: ``` SpawnResult resu...
[ "src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java", "src/test/java/com/google/devtools/build/lib/remote/GrpcRemoteCacheTest.java", "src/test/java/com/google/devtools/build/lib/remote/GrpcRemoteExecutionClientTest.java", "src/test/java/com/google/devtools/build/lib/remote/...
diff --git a/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java b/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java index 1e9b65026482e6..438210dbc4f8f1 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCache.java +++ b/src...
diff --git a/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java b/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests.java index 2c4b95bb6c1e57..68d2d53d47fd74 100644 --- a/src/test/java/com/google/devtools/build/lib/remote/AbstractRemoteActionCacheTests...
train
train
2019-06-18T14:24:12
2019-06-17T11:27:23Z
buchgr
test
bazelbuild/bazel/8671_8692
bazelbuild/bazel
bazelbuild/bazel/8671
bazelbuild/bazel/8692
[ "timestamp(timedelta=1.0, similarity=0.8610517730434353)" ]
c01a43a22e7fa25c08b42d0018a47feb379f2815
e52d7345536769feb154660919ccd077902b6815
[ "This is something we'll want to add, but we'll have to find time to finish this up", "Amazing. Thank you!\r\n" ]
[]
2019-06-21T00:02:54Z
[ "type: feature request", "P2", "team-Android" ]
aar_import does not offer a srcjar option
### Description of the problem / feature request: aar_import doesn't provide a facility to link a source-jar, which limits IDEs abilities to materialize the sources of imported .aar libraries. ### Feature requests: what underlying problem are you trying to solve with this feature? Improved IDE integration. ...
[ "src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java", "src/main/java/com/google/devtools/build/lib/rules/android/AarImportBaseRule.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java", "src/main/java/com/google/devtools/build/lib/rules/android/AarImportBaseRule.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java b/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java index 624286b9727dc3..6fb4bd43aabd76 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/AarImport.java +++ b/src/main/java/com/google/devto...
null
train
train
2019-07-18T19:50:34
2019-06-18T18:40:07Z
cgruber
test
bazelbuild/bazel/8676_8793
bazelbuild/bazel
bazelbuild/bazel/8676
bazelbuild/bazel/8793
[ "timestamp(timedelta=61290.0, similarity=0.8450222084353815)" ]
e1e074c9160affea3fe49062f01e0f331622f405
8bf2d10c11e62d5804e67aa4290dd20acbc63348
[ "/cc @meisterT ", "Can you try with an explicit argument for `-Xmx`, e.g.\r\n`bazel --host_jvm_args=-Xmx4g info`?", "Great idea! I didn't think about it. Unfortunately I will test it on Monday.", "Unfortunately\r\n```bash\r\nPS H:\\> bazel --host_jvm_args=-Xmx4g info\r\nFATAL: ExecuteProgram(C:\\Users\\krzysk...
[ "Although looks like this solves the problem, but we also need to make sure this doesn't leak any file handles other than `stdin`, `stdout` and `stderr` into the subprocess. ", "I verified that it doesn't:\r\n- created a program that uses the exact same code to create a subprocess\r\n- the program also opens a fi...
2019-07-04T11:41:14Z
[ "type: bug", "P2", "area-Windows", "team-OSS" ]
Insufficient system resources exist to complete the requsted service.
### Description of the problem / feature request: Bazel installed by scoop or downlaoded binary crashes on run. Prerequisites + curl + versions/python27 installed. ``` PS H:\> bazel --version bazel 0.27.0 PS H:\> bazel help FATAL: ExecuteProgram(C:\Users\krzyskar/_bazel_krzyskar/install/388981886003af3376cd5aa...
[ "src/main/native/windows/process.cc", "src/main/native/windows/util.h" ]
[ "src/main/native/windows/process.cc", "src/main/native/windows/util.h" ]
[]
diff --git a/src/main/native/windows/process.cc b/src/main/native/windows/process.cc index 05bb0f40385498..f00b76691f8578 100644 --- a/src/main/native/windows/process.cc +++ b/src/main/native/windows/process.cc @@ -50,14 +50,18 @@ static bool DupeHandle(HANDLE h, AutoHandle* out, std::wstring* error) { bool WaitablePr...
null
train
train
2019-07-04T13:21:05
2019-06-19T11:40:44Z
KrzysztofKarol
test
bazelbuild/bazel/8717_8734
bazelbuild/bazel
bazelbuild/bazel/8717
bazelbuild/bazel/8734
[ "timestamp(timedelta=1.0, similarity=0.8767897775547835)" ]
458292d63bfcded1ec926592b12e0032dc718d56
c7e0e2f58c62fcc5dacb53676d2947e47e19c5b7
[ "Here is an example of output with the failure\"\r\n\r\n```\r\nRunning bazel from D:\\src\\studio\\studio-master-dev\\tools\\base\\bazel\\bazel.cmd\r\nINFO: Invocation ID: 05193316-ecc5-4ade-aadf-8bfb69e76e45\r\nINFO: Analysed target //tools/adt/idea/android:artifacts (0 packages loaded, 0 targets configured).\r\nI...
[ "@laszlocsomor If I changed the filename from 260 `'A'` to 250 `'A'`, the test will pass. Do you know if long path support of Win32 API has the restriction that each path component cannot exceed certain length even with `\\\\?`' prefix? Don't see anything from https://docs.microsoft.com/en-us/windows/desktop/FileIO...
2019-06-27T04:05:46Z
[ "type: bug", "P2", "area-Windows", "team-OSS" ]
Singlejar: Add support for long paths on Windows
### Description of the problem / feature request: Invoking "singlejar.exe" sometimes fails on Windows when then argument file (the ".params" file) is located in a path longer than 260 chracters. ### Feature requests: what underlying problem are you trying to solve with this feature? Add support for long path...
[ "src/tools/singlejar/BUILD", "src/tools/singlejar/token_stream.h", "src/tools/singlejar/token_stream_test.cc" ]
[ "src/tools/singlejar/BUILD", "src/tools/singlejar/token_stream.h", "src/tools/singlejar/token_stream_test.cc" ]
[]
diff --git a/src/tools/singlejar/BUILD b/src/tools/singlejar/BUILD index 2cf4acbd8e3ee4..e969cee73b8bd4 100644 --- a/src/tools/singlejar/BUILD +++ b/src/tools/singlejar/BUILD @@ -453,7 +453,10 @@ cc_library( cc_library( name = "token_stream", hdrs = ["token_stream.h"], - deps = [":diag"], + deps = [ + ...
null
test
train
2019-06-27T00:43:14
2019-06-25T22:41:20Z
rpaquay
test
bazelbuild/bazel/8721_8747
bazelbuild/bazel
bazelbuild/bazel/8721
bazelbuild/bazel/8747
[ "timestamp(timedelta=0.0, similarity=0.8522146160996319)" ]
5d72d4ea54fdcb6e963cacb7181fda847e01bc50
171992cf3e51ce1e132adeff6265bcc02e9e6d48
[ "cc @meteorcloudy @hlopko ", "I don't think I'll have the capacity to design/implement this, but I'll gladly review the proposal.", "This won't be hard to implement it, I will do it!" ]
[ "We have to explicitly use `bin\\amd64\\VCVARS64.BAT` because the `VCVARSALL.BAT` in VC 2015 falls back to `vcbuildtools.bat` when VC 2017 or VC 2019 is installed. But `vcbuildtools.bat` doesn't support specifying Windows SDK. I also double checked, if no Windows SDK version is passed, `vcbuildtools.bat` sets the e...
2019-06-28T13:25:24Z
[ "type: feature request", "P2", "area-Windows", "team-OSS" ]
Windows, C++: support selecting the Windows SDK
### Feature requests: what underlying problem are you trying to solve with this feature? If multiple Windows SDK versions are installed, the user may want to select which one to use. Currently there's no way to do so. ### What operating system are you running Bazel on? Windows 10 ### What's the output of `b...
[ "site/docs/windows.md", "tools/cpp/cc_configure.bzl", "tools/cpp/windows_cc_configure.bzl" ]
[ "site/docs/windows.md", "tools/cpp/cc_configure.bzl", "tools/cpp/windows_cc_configure.bzl" ]
[]
diff --git a/site/docs/windows.md b/site/docs/windows.md index 262cc569ead958..3e128ace0db331 100644 --- a/site/docs/windows.md +++ b/site/docs/windows.md @@ -184,7 +184,19 @@ To build C++ targets, you need: SDK](https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk). The Windows SDK contai...
null
val
train
2019-07-01T06:11:48
2019-06-26T07:26:11Z
laszlocsomor
test
bazelbuild/bazel/8767_8769
bazelbuild/bazel
bazelbuild/bazel/8767
bazelbuild/bazel/8769
[ "timestamp(timedelta=147055.0, similarity=0.8411963463355797)" ]
2e374a9c6e3d4ed71f0145de287c4b2fe43c76d6
0f700e0844ef6361ef5c8bb52b47ad6f18d14fa0
[ "I'm having second thoughts about this idea.\r\n\r\nIn light of https://github.com/bazelbuild/bazel/issues/7627, namely that Windows will case-sensitivity on a per-directory basis, I'm starting to doubt the feasibility and usefulness of case-insensitive glob().\r\n\r\nMore, if glob remained case-sensitive, then Baz...
[]
2019-07-02T11:12:40Z
[ "P2", "area-Windows", "incompatible-change", "team-OSS" ]
incompatible_windows_case_ignoring_glob: enables case-insensitive glob() on Windows
# Description The `--[no]incompatible_windows_case_ignoring_glob` shall control whether `glob()` is case-sensitive (false) or case-ignoring (true) on Windows. ## Affected platforms This flag only affects Windows. It is a no-op on other platforms. ## Semantics - When disabled (default): `glob()`'s include...
[ "src/main/java/com/google/devtools/build/lib/packages/GlobCache.java", "src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java", "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java", "src/main/java/com/google/devtools/build/lib/vfs/FileSystem.java", "src/main/java/com/...
[ "src/main/java/com/google/devtools/build/lib/packages/GlobCache.java", "src/main/java/com/google/devtools/build/lib/skyframe/GlobFunction.java", "src/main/java/com/google/devtools/build/lib/skyframe/PackageFunction.java", "src/main/java/com/google/devtools/build/lib/vfs/FileSystem.java", "src/main/java/com/...
[ "src/test/java/com/google/devtools/build/lib/BUILD", "src/test/java/com/google/devtools/build/lib/skyframe/GlobFunctionTest.java", "src/test/java/com/google/devtools/build/lib/vfs/GlobTest.java", "src/test/java/com/google/devtools/build/lib/vfs/WindowsGlobTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/GlobCache.java b/src/main/java/com/google/devtools/build/lib/packages/GlobCache.java index 8d1bb74115d9dc..db58cfc813df11 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/GlobCache.java +++ b/src/main/java/com/google/devtools/build/lib/p...
diff --git a/src/test/java/com/google/devtools/build/lib/BUILD b/src/test/java/com/google/devtools/build/lib/BUILD index fbf4d421a713a4..8199ba1e9d8cf5 100644 --- a/src/test/java/com/google/devtools/build/lib/BUILD +++ b/src/test/java/com/google/devtools/build/lib/BUILD @@ -9,6 +9,7 @@ package( CROSS_PLATFORM_WINDOWS_...
test
train
2019-07-01T21:35:58
2019-07-02T10:10:28Z
laszlocsomor
test
bazelbuild/bazel/8842_8853
bazelbuild/bazel
bazelbuild/bazel/8842
bazelbuild/bazel/8853
[ "timestamp(timedelta=0.0, similarity=0.856552085349893)" ]
37824ac264e5569e08b69341b7a838cdce94acc9
ac70bc94fa74a2eacf2b7f4020419feab742a705
[ "I used `build_file_content` as workaround instead." ]
[]
2019-07-10T18:12:58Z
[ "P1", "team-Rules-CPP" ]
Outdated docs for configuring C++ toolchains
### Description of the problem / feature request: `emscripten` could not be configured as it's described in tutorial in docs: * https://docs.bazel.build/versions/master/tutorial/cc-toolchain-config.html ``` example@docker:~/examples/cpp-tutorial/stage1$ bazel build --config=asmjs //main:helloworld.js INFO: ...
[ "site/docs/tutorial/cc-toolchain-config.md" ]
[ "site/docs/tutorial/cc-toolchain-config.md" ]
[]
diff --git a/site/docs/tutorial/cc-toolchain-config.md b/site/docs/tutorial/cc-toolchain-config.md index c971271a176579..6cebaeba71e276 100644 --- a/site/docs/tutorial/cc-toolchain-config.md +++ b/site/docs/tutorial/cc-toolchain-config.md @@ -332,6 +332,13 @@ using an older release of Bazel, look for the "Configuring C...
null
train
train
2019-07-10T19:55:58
2019-07-09T20:57:48Z
alexanderilyin
test
bazelbuild/bazel/8871_8918
bazelbuild/bazel
bazelbuild/bazel/8871
bazelbuild/bazel/8918
[ "timestamp(timedelta=0.0, similarity=0.8969837483467104)" ]
66a577385539887743bd99b9239b9b70fc55b4f8
dea685e8bd6c1ddfc402b2649a006d2fe6acd7d4
[ "I got it to work by adding the following in a custom build file:\r\n```\r\ntoolchain(\r\n name = \"android\",\r\n target_compatible_with = [\r\n \"@bazel_tools//platforms:android\",\r\n \"@bazel_tools//platforms:aarch64\",\r\n ],\r\n toolchain = \"@androidndk//:aarch64-linux-android-clang...
[ "Why can't the existing android_ndk_repository rule handle this directly?", "How do you register toolchains from a native RepositoryFunction? ", "There's no direct native equivalent to `register_toolchains`, but it wouldn't be hard to add. I feel like the improved usability would be helpful (but this could be i...
2019-07-17T15:11:52Z
[ "P2", "team-Android" ]
androidndk doesn't register toolchains
### Description of the problem / feature request: `@androidndk` toolchains/compiler are not registered, and thus skipped from toolchain resolution. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. Clone https://github.com/steeve/rules_go_bazel_tool...
[ "site/docs/android-ndk.md", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_cc_toolchain_template.txt" ]
[ "site/docs/android-ndk.md", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_cc_toolchain_template.txt" ]
[ "src/test/shell/bazel/android/android_ndk_integration_test.sh" ]
diff --git a/site/docs/android-ndk.md b/site/docs/android-ndk.md index b75ca67d11e0de..d9fa1257388dec 100644 --- a/site/docs/android-ndk.md +++ b/site/docs/android-ndk.md @@ -255,6 +255,77 @@ cc_library( ) ``` +## Integration with platforms and toolchains + +Bazel's configuration model is moving towards +[platform...
diff --git a/src/test/shell/bazel/android/android_ndk_integration_test.sh b/src/test/shell/bazel/android/android_ndk_integration_test.sh index c8e85e7ee304a4..2172ed6c54aa85 100755 --- a/src/test/shell/bazel/android/android_ndk_integration_test.sh +++ b/src/test/shell/bazel/android/android_ndk_integration_test.sh @@ -4...
train
train
2019-07-17T17:04:04
2019-07-11T22:13:39Z
steeve
test
bazelbuild/bazel/8899_9298
bazelbuild/bazel
bazelbuild/bazel/8899
bazelbuild/bazel/9298
[ "timestamp(timedelta=0.0, similarity=0.8421463928137695)" ]
403496540806f3f5404e20919202e28fb4b68f18
2f4ed9cc2064502a72c8316e3cc557cbc471294a
[ "Thanks for filing the issue. I see what you mean now. You are indeed correct the run command is not supported (yet).", "Hi @buchgr,\r\n\r\nI just wanted to give a quick ping on this issue. Can you think of any workaround? We have a deploy target that we generally run from our CI, but we are unable to run it with...
[]
2019-08-30T14:54:21Z
[ "type: feature request", "team-Remote-Exec" ]
support run command for experimental_remote_download_outputs
### Description of the problem / feature request: experimental_remote_download_outputs does not properly download all runtime dependencies. ### Feature requests: what underlying problem are you trying to solve with this feature? Attempting to use the new remote builds without the bytes (#6862) ### Bugs: wha...
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java"...
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java"...
[ "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java index 4f0fb92bef4be8..535bba18a467d6 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java +++...
diff --git a/src/test/shell/bazel/remote/remote_execution_test.sh b/src/test/shell/bazel/remote/remote_execution_test.sh index 2f0e0021f01530..3fcedff8ab956c 100755 --- a/src/test/shell/bazel/remote/remote_execution_test.sh +++ b/src/test/shell/bazel/remote/remote_execution_test.sh @@ -61,6 +61,23 @@ function tear_down...
val
train
2019-09-02T12:07:40
2019-07-15T22:50:00Z
phb
test
bazelbuild/bazel/8899_9307
bazelbuild/bazel
bazelbuild/bazel/8899
bazelbuild/bazel/9307
[ "timestamp(timedelta=59723.0, similarity=0.8513738939647085)" ]
403496540806f3f5404e20919202e28fb4b68f18
3868ce83b902987e82b0d9624a2263c471aeac28
[ "Thanks for filing the issue. I see what you mean now. You are indeed correct the run command is not supported (yet).", "Hi @buchgr,\r\n\r\nI just wanted to give a quick ping on this issue. Can you think of any workaround? We have a deploy target that we generally run from our CI, but we are unable to run it with...
[]
2019-09-02T11:10:10Z
[ "type: feature request", "team-Remote-Exec" ]
support run command for experimental_remote_download_outputs
### Description of the problem / feature request: experimental_remote_download_outputs does not properly download all runtime dependencies. ### Feature requests: what underlying problem are you trying to solve with this feature? Attempting to use the new remote builds without the bytes (#6862) ### Bugs: wha...
[ "src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java" ]
[ "src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java" ]
[ "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java b/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java index b03b2c136d2374..7f3167c55e72fc 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/options/RemoteOptions.java +++ b/src/main/java/c...
diff --git a/src/test/shell/bazel/remote/remote_execution_test.sh b/src/test/shell/bazel/remote/remote_execution_test.sh index 2f0e0021f01530..7c781193b2d69e 100755 --- a/src/test/shell/bazel/remote/remote_execution_test.sh +++ b/src/test/shell/bazel/remote/remote_execution_test.sh @@ -805,7 +805,7 @@ EOF function t...
train
train
2019-09-02T12:07:40
2019-07-15T22:50:00Z
phb
test
bazelbuild/bazel/8934_8947
bazelbuild/bazel
bazelbuild/bazel/8934
bazelbuild/bazel/8947
[ "timestamp(timedelta=1.0, similarity=0.8600812184559062)" ]
8ef17990f607b9e57d6d4336b807d329f3c0fff9
f001848c8fd7930c57e448327f9506579c20c8cf
[ "have you tried `--experimental_remote_download_outputs=toplevel`. I believe this does what you want :). Please re-open this bug if it doesn't.", "@buchgr No `toplevel` is not what I want. I don't want test binaries are downloaded because they are fat, in Envoy it is around 80GB and even larger for sanitizer bui...
[]
2019-07-22T12:00:37Z
[ "untriaged", "team-Remote-Exec" ]
feature request: A mode for --experimental_remote_download_outputs to download testlogs only
### Description of the problem / feature request: ### Feature requests: what underlying problem are you trying to solve with this feature? While setting up Bazel RBE with Envoy CI, we want the CI download less artifacts from RBE to save network bandwidth and disk, while we want to be able to inspect testlogs indi...
[ "src/main/java/com/google/devtools/build/lib/remote/BUILD", "src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/jav...
[ "src/main/java/com/google/devtools/build/lib/remote/BUILD", "src/main/java/com/google/devtools/build/lib/remote/RemoteActionContextProvider.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnCache.java", "src/main/jav...
[ "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/remote/BUILD b/src/main/java/com/google/devtools/build/lib/remote/BUILD index 020c2cb3755613..cb4ae3fe036b49 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/BUILD +++ b/src/main/java/com/google/devtools/build/lib/remote/BUILD @@ -19,6 +19,7 @@ jav...
diff --git a/src/test/shell/bazel/remote/remote_execution_test.sh b/src/test/shell/bazel/remote/remote_execution_test.sh index 5de687eb85c25c..a568c7bb406d2a 100755 --- a/src/test/shell/bazel/remote/remote_execution_test.sh +++ b/src/test/shell/bazel/remote/remote_execution_test.sh @@ -1058,8 +1058,62 @@ EOF [[ -f...
test
train
2019-07-22T13:24:06
2019-07-19T00:47:07Z
lizan
test
bazelbuild/bazel/8970_9332
bazelbuild/bazel
bazelbuild/bazel/8970
bazelbuild/bazel/9332
[ "timestamp(timedelta=0.0, similarity=0.8974316343048264)" ]
25caae266b7e1859377336c036077a40c8dd50b5
b290eeba02095e370eb0b6384d3d790e53523056
[]
[ "That text might be a little long for a help text. Consider changing it to \r\n\r\n`Accepts a comma-separated list of strategies from highest to lowest priority. For each action Bazel picks the strategy with the highest priority that can execute the action. The default value is \"remote,worker,sandboxed,local\". Se...
2019-09-05T13:06:09Z
[ "type: bug", "team-Remote-Exec" ]
clean-up after enabling list based execution strategy
List based execution strategy was recently introduced at #7480. After it's been enabled, certain scenarios are not possible anymore => code clean-up would be a great thing to do :) Some places to look at: - [x] update docs - [x] `incompatible_list_based_execution_strategy_selection` can be deleted with all r...
[ "src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java", "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java", "src/test/shell/integration/execution_strategies_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java b/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java index 7e04b6768ea9e2..ec83dc053f88fc 100644 --- a/src/main/java/com/google/devtools/build/lib/exec/ExecutionOptions.java +++ b/src/main/java/com/google/devtools/bu...
diff --git a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java b/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java index b8beb81f54d6be..29a549aede99fa 100644 --- a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java +++ b/src/test/java/c...
val
train
2019-09-16T03:51:31
2019-07-24T07:29:13Z
ishikhman
test
bazelbuild/bazel/9056_9057
bazelbuild/bazel
bazelbuild/bazel/9056
bazelbuild/bazel/9057
[ "timestamp(timedelta=1.0, similarity=0.870290773571367)" ]
09ec89352c77f442109b779ef8735fa11f91bc4f
1b3fb1069c9a5cae19a46603517fbb24fd53013d
[ "Website deployed, all works now." ]
[ "could you explain why this is needed?", "accident, removed" ]
2019-08-02T09:22:42Z
[ "type: bug", "P0", "team-OSS" ]
"Updating Bazel" link on https://docs.bazel.build/versions/0.28.0/bazel-overview.html 404s
The leftnav bar is not versioned with the rest of the documentation, and if the link target in the navbar does not exist in a particular version, the link 404s. It has happened with recently added https://docs.bazel.build/versions/master/updating-bazel.html (added in https://github.com/bazelbuild/bazel/commit/4285...
[ "site/_layouts/documentation.html" ]
[ "site/_layouts/documentation.html" ]
[]
diff --git a/site/_layouts/documentation.html b/site/_layouts/documentation.html index d963a8d81628ed..da01c8fc0103ba 100644 --- a/site/_layouts/documentation.html +++ b/site/_layouts/documentation.html @@ -6,6 +6,14 @@ <!-- /versions/0.12.3/baz.md -> ["0.12.3", "baz.md"] --> {% assign versioned_url_parts = page.url ...
null
train
train
2019-08-02T06:59:25
2019-08-02T09:20:28Z
dslomov
test
bazelbuild/bazel/9084_9179
bazelbuild/bazel
bazelbuild/bazel/9084
bazelbuild/bazel/9179
[ "timestamp(timedelta=0.0, similarity=0.9223419713715402)" ]
d570771d38937984940ed9af7edfc493503e6cf7
06a8028ffbd8d01a148c3ac274bf83a0063d0267
[]
[ "That cast isn't sound, and it should result in an \"unchecked\" warning. Do you know how (and why) these are suppressed in the Bazel codebase? They should really be treated as errors.", "I am not sure actually why they are suppressed. I removed the cast anyway.", "This incurs an unnecessary copy that was not p...
2019-08-15T14:15:03Z
[ "type: feature request", "P3" ]
enumerate, join, extend functions not accepting dicts
### Description of the problem: When trying to pass a `dict` object to any of the Starlark functions `enumerate`, `string.join` or `list.extend`, the error `expected value of type 'sequence' for parameter ...` is thrown. According to the spec: - A `dict` is both an `Iterable` and a `Sequence`. (see [sequence typ...
[ "src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java", "src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java", "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[ "src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java", "src/main/java/com/google/devtools/build/lib/syntax/SkylarkList.java", "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[ "src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java", "src/test/starlark/testdata/list_mutation.sky", "src/test/starlark/testdata/string_misc.sky" ]
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java b/src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java index 62fe34b901f259..830ca5672e75fe 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/MethodLibrary.java +++ b/src/main/java/com/google/devtools/build...
diff --git a/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java b/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java index 62875a76b6ef09..7f024d79ebcd57 100644 --- a/src/test/java/com/google/devtools/build/lib/syntax/MethodLibraryTest.java +++ b/src/test/java/com/google/de...
val
train
2019-08-17T03:31:09
2019-08-06T00:09:12Z
Quarz0
test
bazelbuild/bazel/9089_9090
bazelbuild/bazel
bazelbuild/bazel/9089
bazelbuild/bazel/9090
[ "timestamp(timedelta=0.0, similarity=0.9163717359713671)" ]
b7d300c6be3e130dec0e62a4f19493105f595d57
7d02c0aea7529d40158d91ff0f85894dca601330
[ "Example:\r\n```\r\nDEBUG: /tmp/winsdk/51c9aa8f783c7ef42fa88749bcc55eec/external/bazel_tools/tools/cpp/lib_cc_configure.bzl:118:5: \r\nAuto-Configuration Warning: registry query result for VC 8.0: \r\n\r\nSTDOUT(start)\r\n\r\nSTDOUT(end)\r\nSTDERR(start):\r\njava.io....
[]
2019-08-06T11:42:14Z
[ "type: bug", "P2", "area-Windows", "team-OSS" ]
Windows: winsdk_configure errors on other platforms
### Description of the problem / feature request: Bazel workspace's `winsdk_configure()` repository rule runs (and throws java.io.IOExceptions) on every platform, not just Windows. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. 1. get https://git...
[ "src/main/res/winsdk_configure.bzl" ]
[ "src/main/res/winsdk_configure.bzl" ]
[]
diff --git a/src/main/res/winsdk_configure.bzl b/src/main/res/winsdk_configure.bzl index 2eb7d0e2ef838e..3b77acbc8a537b 100644 --- a/src/main/res/winsdk_configure.bzl +++ b/src/main/res/winsdk_configure.bzl @@ -14,6 +14,16 @@ """Configure local Resource Compilers for every available target platform. +Platform supp...
null
train
train
2019-08-06T13:26:10
2019-08-06T11:24:54Z
laszlocsomor
test
bazelbuild/bazel/9097_9107
bazelbuild/bazel
bazelbuild/bazel/9097
bazelbuild/bazel/9107
[ "timestamp(timedelta=71449.0, similarity=0.8616046097426532)" ]
d2de8ee925710b757a637bc8ad1036546a030756
4596a99e3f1ff8b84d077b889e2ef0ca84f1d0f0
[ "Ccing @laurentlb and @gregestren for comment.", "Does this need to be the rally call for Starlark customization? Could we get away with natively disabling toolchain resolution for all rule classes that are build settings?", "In other words: if a `rule` has a `build_setting` attribute, automatically disable too...
[]
2019-08-07T14:07:53Z
[ "type: feature request", "P2" ]
Starlark rules need to be able to opt out of toolchain resolution
Currently, native rules can use [`RuleClass.Builder.useToolchainResolution`](https://source.bazel.build/bazel/+/a8353612b4791531ae4e2ed463cf0e5d8a4009e8:src/main/java/com/google/devtools/build/lib/packages/RuleClass.java;l=1393;bpt=1) to disable toolchain resolution. This is used for configuration-related rules like `p...
[ "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java" ]
[ "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java index f4119496292500..0a08231e4c6bc0 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java +++ b/src/main/java/com/google/devtools/build/lib/p...
null
train
train
2019-08-07T15:45:46
2019-08-06T18:20:43Z
katre
test
bazelbuild/bazel/9099_9107
bazelbuild/bazel
bazelbuild/bazel/9099
bazelbuild/bazel/9107
[ "timestamp(timedelta=0.0, similarity=0.9519790750988617)" ]
d2de8ee925710b757a637bc8ad1036546a030756
4596a99e3f1ff8b84d077b889e2ef0ca84f1d0f0
[ "Thanks for fixing this!\r\n\r\ncc @lberki " ]
[]
2019-08-07T14:07:53Z
[ "type: feature request", "P2", "team-Configurability" ]
build_setting rules should not use toolchain resolution
Following from #9097. Rules created using the build_setting features (https://docs.bazel.build/versions/master/skylark/config.html#instantiating-build-settings) should disable toolchain resolution (and probably also be non-configurable).
[ "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java" ]
[ "src/main/java/com/google/devtools/build/lib/packages/RuleClass.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java b/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java index f4119496292500..0a08231e4c6bc0 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/RuleClass.java +++ b/src/main/java/com/google/devtools/build/lib/p...
null
train
train
2019-08-07T15:45:46
2019-08-06T20:01:24Z
katre
test
bazelbuild/bazel/9102_9117
bazelbuild/bazel
bazelbuild/bazel/9102
bazelbuild/bazel/9117
[ "timestamp(timedelta=78916.0, similarity=0.8579835952566022)" ]
858412781d76b7d27c39dc58b7f24cf645bdf035
8965cdaeb395980cb61a0e513c6a4f768f8678c0
[ "It looks like this is being treated as a single filename?\r\n\r\nbazel-out\\android-armeabi-v7a-fastbuild\\bin\\external\\maven\\androidx_arch_core_core_runtime_2_0_0_symbols\\symbols.zip;bazel-out\\android-armeabi-v7a-fastbuild\\bin\\external\\maven\\androidx_lifecycle_lifecycle_livedata_core_2_0_0_symbols\\symbo...
[]
2019-08-07T23:11:09Z
[ "type: bug", "P1", "breakage", "team-Android" ]
Bazel CI: Android build is failing on Windows
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1128 ``` (02:09:04) ERROR: D:/b/zqacmrtc/external/maven/BUILD:359:1: Couldn't build file external/maven/androidx_lifecycle_lifecycle_livedata_2_0_0_files/androidx_lifecycle_lifecycle_livedata_2_0_0_resources_aapt2-src.jar: Linking static android resourc...
[ "src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java", "src/tools/android/java/com/google/devtools/build/android/aapt2/ProtoApk.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java", "src/tools/android/java/com/google/devtools/build/android/aapt2/ProtoApk.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java index eb61855b672152..bbb6579df4b34a 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java +++...
null
val
train
2019-08-08T00:02:11
2019-08-07T08:05:26Z
meteorcloudy
test
bazelbuild/bazel/9102_9118
bazelbuild/bazel
bazelbuild/bazel/9102
bazelbuild/bazel/9118
[ "timestamp(timedelta=70702.0, similarity=0.8579835952566022)" ]
00e9d16d69b191bdfdc32bfd6b2bed203e5af844
fa90d78a716423ee270c99a3e8db350b016848ce
[ "It looks like this is being treated as a single filename?\r\n\r\nbazel-out\\android-armeabi-v7a-fastbuild\\bin\\external\\maven\\androidx_arch_core_core_runtime_2_0_0_symbols\\symbols.zip;bazel-out\\android-armeabi-v7a-fastbuild\\bin\\external\\maven\\androidx_lifecycle_lifecycle_livedata_core_2_0_0_symbols\\symbo...
[]
2019-08-07T23:14:23Z
[ "type: bug", "P1", "breakage", "team-Android" ]
Bazel CI: Android build is failing on Windows
https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1128 ``` (02:09:04) ERROR: D:/b/zqacmrtc/external/maven/BUILD:359:1: Couldn't build file external/maven/androidx_lifecycle_lifecycle_livedata_2_0_0_files/androidx_lifecycle_lifecycle_livedata_2_0_0_resources_aapt2-src.jar: Linking static android resourc...
[ "src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java", "src/tools/android/java/com/google/devtools/build/android/aapt2/ProtoApk.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java", "src/tools/android/java/com/google/devtools/build/android/aapt2/ProtoApk.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java b/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java index eb61855b672152..bbb6579df4b34a 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/android/BusyBoxActionBuilder.java +++...
null
train
train
2019-08-08T01:12:32
2019-08-07T08:05:26Z
meteorcloudy
test
bazelbuild/bazel/9106_9123
bazelbuild/bazel
bazelbuild/bazel/9106
bazelbuild/bazel/9123
[ "timestamp(timedelta=0.0, similarity=0.9013943924457664)" ]
6ad1623ed35bee162caf363e51b8c35c4b10fc3c
4b685fa6659161951ce0418644483a07e440c48e
[]
[]
2019-08-08T11:16:27Z
[ "type: bug", "P1", "area-Windows", "team-OSS" ]
Windows: bash-less run argument quoting is wrong
### Description of the problem / feature request: The Bash-less "bazel run" (see https://github.com/bazelbuild/bazel/issues/8240) quotes arguments incorrectly. It works correctly in `--batch` mode, but adds extra `" "` around escaped arguments in server mode. ### Bugs: what's the simplest, easiest way to repro...
[ "src/main/cpp/BUILD", "src/main/cpp/blaze.cc", "src/main/cpp/blaze_util_platform.h", "src/main/cpp/blaze_util_posix.cc", "src/main/cpp/blaze_util_windows.cc", "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java", "src/tools/launcher/util/BUILD" ]
[ "src/main/cpp/BUILD", "src/main/cpp/blaze.cc", "src/main/cpp/blaze_util_platform.h", "src/main/cpp/blaze_util_posix.cc", "src/main/cpp/blaze_util_windows.cc", "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java", "src/tools/launcher/util/BUILD" ]
[ "src/test/shell/integration/py_args_escaping_test.sh" ]
diff --git a/src/main/cpp/BUILD b/src/main/cpp/BUILD index 7de595dddebf4f..9e18a2b19121e5 100644 --- a/src/main/cpp/BUILD +++ b/src/main/cpp/BUILD @@ -64,6 +64,7 @@ cc_library( "//src/main/cpp/util:logging", ] + select({ "//src/conditions:windows": [ + "//src/tools/launcher/util", ...
diff --git a/src/test/shell/integration/py_args_escaping_test.sh b/src/test/shell/integration/py_args_escaping_test.sh index 59bf5b14bb2337..f3d4ed42c48d89 100755 --- a/src/test/shell/integration/py_args_escaping_test.sh +++ b/src/test/shell/integration/py_args_escaping_test.sh @@ -231,11 +231,41 @@ function test_args_...
train
train
2019-08-08T12:13:36
2019-08-07T14:04:39Z
laszlocsomor
test
bazelbuild/bazel/9108_9123
bazelbuild/bazel
bazelbuild/bazel/9108
bazelbuild/bazel/9123
[ "timestamp(timedelta=1.0, similarity=0.9128970231544254)" ]
6ad1623ed35bee162caf363e51b8c35c4b10fc3c
4b685fa6659161951ce0418644483a07e440c48e
[ "https://github.com/bazelbuild/bazel/pull/9123 will fix this" ]
[]
2019-08-08T11:16:27Z
[ "type: bug", "P1", "area-Windows", "team-OSS" ]
Windows: bazel --batch run //foo:sh_binary argument quoting is wrong
### Description of the problem / feature request: On Windows, in `--batch` mode, either `bazel run` or the sh_binary launcher incorrectly quote arguments for sh_binary. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. `BUILD`: ``` sh_binary( ...
[ "src/main/cpp/BUILD", "src/main/cpp/blaze.cc", "src/main/cpp/blaze_util_platform.h", "src/main/cpp/blaze_util_posix.cc", "src/main/cpp/blaze_util_windows.cc", "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java", "src/tools/launcher/util/BUILD" ]
[ "src/main/cpp/BUILD", "src/main/cpp/blaze.cc", "src/main/cpp/blaze_util_platform.h", "src/main/cpp/blaze_util_posix.cc", "src/main/cpp/blaze_util_windows.cc", "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java", "src/tools/launcher/util/BUILD" ]
[ "src/test/shell/integration/py_args_escaping_test.sh" ]
diff --git a/src/main/cpp/BUILD b/src/main/cpp/BUILD index 7de595dddebf4f..9e18a2b19121e5 100644 --- a/src/main/cpp/BUILD +++ b/src/main/cpp/BUILD @@ -64,6 +64,7 @@ cc_library( "//src/main/cpp/util:logging", ] + select({ "//src/conditions:windows": [ + "//src/tools/launcher/util", ...
diff --git a/src/test/shell/integration/py_args_escaping_test.sh b/src/test/shell/integration/py_args_escaping_test.sh index 59bf5b14bb2337..f3d4ed42c48d89 100755 --- a/src/test/shell/integration/py_args_escaping_test.sh +++ b/src/test/shell/integration/py_args_escaping_test.sh @@ -231,11 +231,41 @@ function test_args_...
val
train
2019-08-08T12:13:36
2019-08-07T14:12:25Z
laszlocsomor
test
bazelbuild/bazel/9155_9169
bazelbuild/bazel
bazelbuild/bazel/9155
bazelbuild/bazel/9169
[ "timestamp(timedelta=0.0, similarity=0.8786687211720238)" ]
2f42d174cefa9b7def2e4cb5117a43d434bbbf12
3635f8286626a3ceb8274a8014b498d603ad39dc
[]
[ "Do we want to recommend //src:bazel-dev.exe instead?", "Good idea! Yes.\r\nWill do in internal review." ]
2019-08-14T12:22:09Z
[ "type: documentation (cleanup)", "P2", "team-OSS" ]
Building bazel Docs missing install info
> ATTENTION! Please read and follow: > - if this is a _question_ about how to build / test / query / deploy using Bazel, or a _discussion starter_, send it to bazel-discuss@googlegroups.com > - if this is a _bug_ or _feature request_, fill the form below as best as you can. ### Description of the problem / feature...
[ "site/_layouts/documentation.html", "site/docs/install-compile-source.md" ]
[ "site/_layouts/documentation.html", "site/docs/install-compile-source.md" ]
[]
diff --git a/site/_layouts/documentation.html b/site/_layouts/documentation.html index 0f8515e292431c..a43ac66ff8741a 100644 --- a/site/_layouts/documentation.html +++ b/site/_layouts/documentation.html @@ -10,7 +10,7 @@ {% if version_components.size < 2 %} {% assign major_version = "master" %} {% assign minor_v...
null
train
train
2019-08-14T12:36:00
2019-08-13T04:56:08Z
antofthy
test
bazelbuild/bazel/9181_9228
bazelbuild/bazel
bazelbuild/bazel/9181
bazelbuild/bazel/9228
[ "timestamp(timedelta=0.0, similarity=0.869423019751391)" ]
18e8981fab5e2beaf7643df4948f0f5027341764
d4da8a8dbb8c3fc08292cbdfef1229cc61971117
[]
[ "I think renaming this would be a breaking change. May need to keep the old name for now.", "Yes, it's clearly breaking! The question is if it's a change that's allowed to be made according to the compatability policy, the [Backwards Compatability document](https://docs.bazel.build/versions/master/backward-compat...
2019-08-22T20:49:19Z
[ "type: bug", "P2" ]
string.replace incorrectly handles negative value for count
### Description of the problem: According to the [spec](https://github.com/bazelbuild/starlark/blob/master/spec.md#stringreplace), a negative value for `count` in `string.replace` should be ignored and this is also what python and the Go implementation do. ``` # Current implementation "abc".replace("a", "z", -1) ...
[ "src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java", "src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java", "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[ "src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java", "src/main/java/com/google/devtools/build/lib/syntax/StarlarkSemantics.java", "src/main/java/com/google/devtools/build/lib/syntax/StringModule.java" ]
[ "src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java", "src/test/java/com/google/devtools/build/lib/syntax/StringModuleTest.java", "src/test/starlark/testdata/string_misc.sky" ]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java b/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java index 01769336fe6b85..531801020d11a3 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StarlarkSemanticsOptions.java +++ b/...
diff --git a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java b/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsistencyTest.java index 3539c6f7946283..1aeb40851b419e 100644 --- a/src/test/java/com/google/devtools/build/lib/packages/SkylarkSemanticsConsis...
train
train
2020-04-28T23:32:03
2019-08-15T14:49:51Z
Quarz0
test
bazelbuild/bazel/9284_9287
bazelbuild/bazel
bazelbuild/bazel/9284
bazelbuild/bazel/9287
[ "timestamp(timedelta=1.0, similarity=0.8663329225639275)" ]
a32bc59d2472b9cd33c5bf54c2fc10431b9f5358
696739255ab09e63f5bca8eecfe9abbe5f8a8fc5
[ "I am investigating with @v-mr ", "We're seeing same issue in envoyproxy/envoy#8074, seems this only happens when `--nocache_test_results` is passed to bazel. I can reproduce it with `--nocache_test_results` but not without it.", "Thank you for the data point, @lizan.\r\n\r\n@v-mr has given me a repoduction cas...
[]
2019-08-30T06:44:48Z
[ "type: bug", "P1", "team-Remote-Exec" ]
Bazel 0.29 contains a regression with Remote Build Execution backend
### Description of the problem / feature request: Bazel 0.29.0 (https://github.com/bazelbuild/bazel/issues/8572) has regression with Remote Build Execution backend. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. ERROR: <redacted>/test/BUILD:205:5...
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java" ]
[ "src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java", "src/test/shell/bazel/remote/remote_execution_http_test.sh", "src/test/shell/bazel/remote/remote_execution_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java b/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java index 56c2d8407f9448..8ff410f230c67d 100644 --- a/src/main/java/com/google/devtools/build/lib/remote/RemoteSpawnRunner.java +++ b/src/main/java/com/google/de...
diff --git a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java b/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java index 6c787cbc488bb1..36d06126920f71 100644 --- a/src/test/java/com/google/devtools/build/lib/remote/RemoteSpawnRunnerTest.java +++ b/src/test/java/c...
val
train
2019-08-30T08:23:09
2019-08-29T19:36:51Z
v-mr
test
bazelbuild/bazel/9321_9454
bazelbuild/bazel
bazelbuild/bazel/9321
bazelbuild/bazel/9454
[ "timestamp(timedelta=0.0, similarity=0.8412470147148741)" ]
51421724b6038844838a74886e894df16b1bcaf1
001563f7166f9c2e987d43663d65f4fe95fadfec
[ "cc @laszlocsomor \r\n", "Chatted about this with @meteorcloudy this week. We don't expand them in the manifest as we do in the runfiles tree. Will send a fix.", "@buchgr This looks like a different issue, `_dotd/main/gen_tree/foo.obj.d` shouldn't be required on Windows.", "Maybe using tree artifact triggered...
[ "Can you add a comment here what this is for?", "Can you please also mark dotdTreeArtifact as @Nullable?", "Done", "Thanks, done!" ]
2019-10-01T10:23:57Z
[ "type: bug", "P2", "team-Rules-CPP" ]
Tree artifacts don't seem to work on Windows
### Description of the problem / feature request: Tree artifacts don't seem to work on Windows. ### Feature requests: what underlying problem are you trying to solve with this feature? Generate a `cc_library` from an unknown number of source files, e.g. because they are produced by a tool. ### Bugs: what's ...
[ "src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java", "src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java", "src/main/java/com/google/devtools/build/lib/rules/cpp/CppCompileActionTemplate.java" ]
[ "src/test/py/bazel/bazel_windows_cpp_test.py" ]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java index 4b8a101c3229e6..d7261db061fca0 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/cpp/CcCompilationHelper.java +++ b/src/main/jav...
diff --git a/src/test/py/bazel/bazel_windows_cpp_test.py b/src/test/py/bazel/bazel_windows_cpp_test.py index 3b20bec3537259..6299439cb2396d 100644 --- a/src/test/py/bazel/bazel_windows_cpp_test.py +++ b/src/test/py/bazel/bazel_windows_cpp_test.py @@ -701,6 +701,66 @@ def testCacheBetweenWorkspaceWithDifferentNames(self...
test
train
2019-10-01T10:13:32
2019-09-03T15:22:24Z
ale64bit
test
bazelbuild/bazel/9348_9349
bazelbuild/bazel
bazelbuild/bazel/9348
bazelbuild/bazel/9349
[ "timestamp(timedelta=0.0, similarity=0.8850462468852704)" ]
6fef731669a83cc22f7cc435befe3561e99fd0e5
65ff599a5951331ce95f6051e93c0415e4be77e2
[]
[]
2019-09-09T07:53:39Z
[ "untriaged", "team-OSS" ]
bash-completion should not be a hard dependency in the .deb package
### Description of the problem / feature request: The bazel .deb package includes a hard dependency on the bash-completion package, which makes it annoying for users who don't want bash-completion features. I think bash-completion should be moved to a weaker dependency type, preferably Suggests ("This is used to ...
[ "scripts/packages/debian/BUILD", "scripts/packages/debian/control" ]
[ "scripts/packages/debian/BUILD", "scripts/packages/debian/control" ]
[]
diff --git a/scripts/packages/debian/BUILD b/scripts/packages/debian/BUILD index cffa82cb27b6e6..44e7375e23ec41 100644 --- a/scripts/packages/debian/BUILD +++ b/scripts/packages/debian/BUILD @@ -79,7 +79,6 @@ pkg_deb( # Keep in sync with Depends section in ./control "g++", "zlib1g-dev", - ...
null
train
train
2019-09-08T22:41:41
2019-09-09T07:46:31Z
mostynb
test
bazelbuild/bazel/9364_9385
bazelbuild/bazel
bazelbuild/bazel/9364
bazelbuild/bazel/9385
[ "timestamp(timedelta=1.0, similarity=0.8471437419443348)" ]
6300cf0b989491a9e653b0c3ab12043adf0c1fa2
e1b762be4170e40c54cd411ffdb25aaec056732a
[ "What message would you suggest?", "Just to clarify @meisterT's question.\r\n\r\nThe [quoted issue](https://github.com/bazelbuild/bazel-gazelle/issues/609)\r\n\r\n> Please see [bazelbuild/bazel-gazelle#609 (comment)](https://github.com/bazelbuild/bazel-gazelle/issues/609#issuecomment-530017922)\r\n\r\n[states](ht...
[]
2019-09-13T21:47:52Z
[ "P1", "more data needed", "team-ExternalDeps", "untriaged", "bad error messaging" ]
Error messaging when BUILD file not present at top level directory is unclear
### Description of the problem / feature request: `go_repository` now reads a configuration file, which, by default is WORKSPACE in the main workspace. The implementation of this feature is such that the error messaging when the file is not present is as follows: ``` ERROR: Analysis of target '//src/hack/projec...
[ "src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java" ]
[ "src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java" ]
[ "src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java b/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java index 080d1bd392eff1..bafd17aae901f6 100644 --- a/src/main/java/com/google/devtools/build/lib/skyframe/PackageLookupFunction.java +++ b/src/main/...
diff --git a/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java b/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest.java index 6cf030fb119a85..3c81a15c1a626d 100644 --- a/src/test/java/com/google/devtools/build/lib/analysis/AnalysisFailureReportingTest...
train
train
2019-09-13T22:57:05
2019-09-10T17:00:29Z
nlopezgi
test
bazelbuild/bazel/9391_9394
bazelbuild/bazel
bazelbuild/bazel/9391
bazelbuild/bazel/9394
[ "timestamp(timedelta=2220.0, similarity=0.878363727447357)" ]
b6f33cd4b23f6aafe35cf42079a6ccb8d522b8cf
1479eca4471ae71df1ff8c31f1cc3fd2bbd9893d
[ "@davido Thank you for the detailed bug report, it's great! :) Indeed I checked and the implementation for [java_host_runtime_alias](https://github.com/bazelbuild/bazel/blob/master/tools/jdk/java_toolchain_alias.bzl#L46) doesn't add its files to runfiles. @cushon is there a reason why `java_host_runtime_alias` does...
[]
2019-09-16T19:54:43Z
[ "P2", "team-Rules-Java" ]
sh_test: @bazel_tools//tools/jdk:current_host_java_runtime is not provided in runfiles directory
While `"@bazel_tools//tools/jdk:current_java_runtime"` is provided in runfiles dierctory (as expected), `"@bazel_tools//tools/jdk:current_host_java_runtime"` is not. Working reproducer: WORKSPACE: ```python workspace(name = "foo") ``` BUILD: ```python sh_test( name = "bar", args = ["$(JAVABASE)/...
[ "tools/jdk/java_toolchain_alias.bzl" ]
[ "tools/jdk/java_toolchain_alias.bzl" ]
[]
diff --git a/tools/jdk/java_toolchain_alias.bzl b/tools/jdk/java_toolchain_alias.bzl index 81b78120673933..f9c2a7123cc881 100644 --- a/tools/jdk/java_toolchain_alias.bzl +++ b/tools/jdk/java_toolchain_alias.bzl @@ -46,10 +46,14 @@ java_runtime_alias = rule( def _java_host_runtime_alias(ctx): """An experimental im...
null
val
train
2019-09-16T19:33:10
2019-09-16T14:05:19Z
davido
test
bazelbuild/bazel/10023_10034
bazelbuild/bazel
bazelbuild/bazel/10023
bazelbuild/bazel/10034
[ "timestamp(timedelta=66.0, similarity=0.8444135097695894)" ]
8d0ae20c124fb5e0bf9594f8ca4fa8dc07b47b77
cf62fd11b2682ebe685a953b4c205f6442a7f9e5
[ "cc @hlopko who created the release", "It looks related to the error prone upgrade in https://github.com/bazelbuild/bazel/pull/9372, I'm rebuilding the tools and update this thread when I confirm the culprit.", "@meisterT I can confirm the error prone upgrade to 2.3.3 is the culprit. The new error prone release...
[]
2019-10-15T08:44:33Z
[ "P1", "team-Rules-Java" ]
java_tools release broken
### Description of the problem: java_tools release probably broke a couple of Java projects (with Dagger?) See for a full list of breakages in downstream: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/1234#a822417e-f2f7-4927-abe7-b01289011f67 (Note that it includes more problems than this par...
[ "WORKSPACE", "src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE" ]
[ "WORKSPACE", "src/main/java/com/google/devtools/build/lib/bazel/rules/java/jdk.WORKSPACE" ]
[ "src/test/shell/bazel/testdata/jdk_http_archives" ]
diff --git a/WORKSPACE b/WORKSPACE index d905b52ee1e339..b53508d82aa81b 100644 --- a/WORKSPACE +++ b/WORKSPACE @@ -119,9 +119,9 @@ distdir_tar( archives = [ "e0b0291b2c51fbe5a7cfa14473a1ae850f94f021.zip", "f83cb8dd6f5658bc574ccd873e25197055265d1c.tar.gz", - "java_tools_javac11_linux-v6.0.z...
diff --git a/src/test/shell/bazel/testdata/jdk_http_archives b/src/test/shell/bazel/testdata/jdk_http_archives index 2181de92fd4e20..5e81598248e3ba 100644 --- a/src/test/shell/bazel/testdata/jdk_http_archives +++ b/src/test/shell/bazel/testdata/jdk_http_archives @@ -47,23 +47,23 @@ http_archive( ################### Re...
train
train
2019-10-15T11:51:15
2019-10-14T17:41:50Z
meisterT
test
bazelbuild/bazel/10039_10052
bazelbuild/bazel
bazelbuild/bazel/10039
bazelbuild/bazel/10052
[ "timestamp(timedelta=0.0, similarity=0.848263207399211)" ]
5a74742d83f1ff68e4d019eca6e4a0643a8eb2cb
d878f5811fa13f1ca7d3afcbcea127ef61c41eee
[ "This is worth at least clarifying which part of the code base is failing to make the connection. From there we can prioritize the right fix. ", "PR to support Starlark-defined flags starting with `--@`: https://github.com/bazelbuild/bazel/pull/10052" ]
[]
2019-10-17T03:33:51Z
[ "P2", "team-Configurability" ]
Support custom skylark build flags in external dependencies
### Description of the problem / feature request: The implementation of Skylark support for custom build flags (#5577) does not work for custom build flags in external repositories. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. Given the follow...
[ "src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java", "src/main/java/com/google/devtools/common/options/OptionsParser.java", "src/main/java/com/google/devtools/common/options/OptionsParserImpl.java" ]
[ "src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java", "src/main/java/com/google/devtools/common/options/OptionsParser.java", "src/main/java/com/google/devtools/common/options/OptionsParserImpl.java" ]
[ "src/test/java/com/google/devtools/build/lib/skylark/StarlarkOptionsParsingTest.java", "src/test/shell/integration/starlark_configurations_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java b/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java index 027fa3432a4401..53d3cdb3ee0e28 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/BlazeCommandDispatcher.java +++ b/src/main/...
diff --git a/src/test/java/com/google/devtools/build/lib/skylark/StarlarkOptionsParsingTest.java b/src/test/java/com/google/devtools/build/lib/skylark/StarlarkOptionsParsingTest.java index cce15bc6571645..26e375d3195414 100644 --- a/src/test/java/com/google/devtools/build/lib/skylark/StarlarkOptionsParsingTest.java +++...
val
train
2019-10-17T05:29:19
2019-10-15T12:29:26Z
moroten
test
bazelbuild/bazel/10094_10095
bazelbuild/bazel
bazelbuild/bazel/10094
bazelbuild/bazel/10095
[ "timestamp(timedelta=1.0, similarity=0.8938632633421661)" ]
01138c8f9a1164c47dc6bb06f7c71c5a3f9f694f
52100d85fa55651c1b7b0b88c3c1d16e6e92b37d
[ "`//src/test/java/com/google/devtools/build/lib/bazel:bazel-rules-tests` is failing. Please take a look at that. It's probably because the mocked NDK doesn't have these files..?" ]
[ "This is not a unique name, if `toolchain.getTargetCpu()` is common between the outer crosstools loop.", "Thanks for this, I've changed the rule name to contain the toolchain name, and it seems to have fixed the tests." ]
2019-10-24T11:56:50Z
[ "team-Android" ]
Android NDK package: add filegroup for Vulkan validation layers
### Description of the feature request: Provide a mean to access Vulkan validation layers which are precompiled dynamic libraries shipped in Android NDK. Android NDK BUILD file is generated by Bazel itself (`@androidndk`), and offers predefined rules/target related to the NDK. Currently, I cannot find an easy way...
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_build_file_template.txt" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_build_file_template.txt", "src/main/java/com/google/devtools/build/lib/bazel/rules/android/android_ndk_vulkan_validation_layers_templa...
[]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/android/AndroidNdkRepositoryFunction.java index dc33d59a0aa264..7c5cd30e452b2f 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/and...
null
train
train
2020-04-23T08:54:55
2019-10-24T09:43:13Z
hevrard
test
bazelbuild/bazel/10154_10301
bazelbuild/bazel
bazelbuild/bazel/10154
bazelbuild/bazel/10301
[ "timestamp(timedelta=79204.0, similarity=0.8918293338897928)" ]
fc287a3fda683f267ff586fdf45ca7ec06ffe316
ca93782b924a0e4f94443c33061d0518fea31dd4
[ "Easiest note first: As the error reports, we currently only support a single argument to `--platforms`. The flag is plural in order to allow for a future migration to supporting multiplatform builds without requiring everyone to change their flag settings, but we are not there currently. However, this should not b...
[ "Is this commented out code intentional? If yes please include a TODO explaining its purpose.", "I initially added it, then realized it changes semantics and broke tests, and forgot to completely remove. Now it's really gone." ]
2019-11-25T15:53:59Z
[ "type: bug", "P1", "team-Configurability" ]
Crash when specifying multiple platforms
### Description of the problem / feature request: When porting `--cpu` and `--compiler` and other command line options to `constraint_setting`, it makes sense to have multiple platforms, for example one for the cpu and one for the compiler. Specifying multiple `--platforms` will ignore all but the last. Using a c...
[ "src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java", "src/main/java/com/google/devtools/build/lib/skyframe/PlatformMappingValue.java" ]
[ "src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java", "src/main/java/com/google/devtools/build/lib/skyframe/PlatformMappingValue.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java index 756fb44b1e1e1c..12344564ede28c 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java +++ b/src/main/...
null
train
train
2019-11-25T11:51:57
2019-11-01T20:47:30Z
moroten
test
bazelbuild/bazel/10176_10577
bazelbuild/bazel
bazelbuild/bazel/10176
bazelbuild/bazel/10577
[ "timestamp(timedelta=0.0, similarity=0.880780684099557)" ]
3a5b187603808959337372a12217e1abbe73f156
103a7895bbe36df97c0453cf584e1bac99dc9b8b
[]
[ "This is a new dependency, and it's totally unnecessary. There is already code in StructImpl.java to escape Java strings into JSON notation (see L319); please re-use it.", "Don't use String.valueOf(x) here; it's equivalent to x.toString() except when x is null, which can't happen because this statement is dominat...
2020-01-14T00:22:39Z
[ "type: bug", "P3", "good first issue" ]
struct.to_json doesn't escape keys
### Description of the problem / feature request: struct.to_json doesn't escape keys. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. ```python print(struct(**{ "\"": 1 }).to_json()) # outputs {""":1} ``` ### What operating system are you run...
[ "src/main/java/com/google/devtools/build/lib/packages/StructImpl.java" ]
[ "src/main/java/com/google/devtools/build/lib/packages/StructImpl.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/packages/StructImpl.java b/src/main/java/com/google/devtools/build/lib/packages/StructImpl.java index 0b0cc35526cd19..5030af2ca86f6e 100644 --- a/src/main/java/com/google/devtools/build/lib/packages/StructImpl.java +++ b/src/main/java/com/google/devtools/build/li...
null
test
val
2020-02-24T23:06:32
2019-11-06T12:07:04Z
ashi009
test
bazelbuild/bazel/10215_10337
bazelbuild/bazel
bazelbuild/bazel/10215
bazelbuild/bazel/10337
[ "timestamp(timedelta=0.0, similarity=0.852479485346196)" ]
d3f8efca72a0e2013467c033df1bf58dd76e8a10
bb795521426ea9315ff59cc93ad520e69e3ae541
[ "The problem could well be alleviated by skipping lines that begin with a `#`. This is probably somewhere in the `read_netrc` function in `tools/build_defs/repo/utils.bzl` at around line 231, where `continue`ing after passing a check for `line.startswith(\"#\")` might suffice. ", "@shs96c https://github.com/bazel...
[]
2019-11-29T05:44:16Z
[ "team-ExternalDeps", "untriaged" ]
.netrc files with comments break http_archive downloads
### Description of the problem / feature request: With the following `~/.netrc`, `bazel build ...` fails when the `WORKSPACE` has an un-downloaded repository: ```ini # Production machine build.company login foo password bar machine build-prod.company login foo password bar # Staging machine build.stage.com...
[ "tools/build_defs/repo/utils.bzl" ]
[ "tools/build_defs/repo/utils.bzl" ]
[ "src/test/shell/bazel/skylark_repository_test.sh" ]
diff --git a/tools/build_defs/repo/utils.bzl b/tools/build_defs/repo/utils.bzl index a369f61954155b..3866b0c23bad5a 100644 --- a/tools/build_defs/repo/utils.bzl +++ b/tools/build_defs/repo/utils.bzl @@ -228,7 +228,10 @@ def read_netrc(ctx, filename): currentmacro = "" cmd = None for line in contents.spli...
diff --git a/src/test/shell/bazel/skylark_repository_test.sh b/src/test/shell/bazel/skylark_repository_test.sh index 3b753e42abbc78..3ed8f489d8c0bf 100755 --- a/src/test/shell/bazel/skylark_repository_test.sh +++ b/src/test/shell/bazel/skylark_repository_test.sh @@ -1604,6 +1604,7 @@ cd pub mget * quit +# this is a...
test
train
2019-11-29T11:55:32
2019-11-11T22:09:33Z
segiddins
test
bazelbuild/bazel/10282_10301
bazelbuild/bazel
bazelbuild/bazel/10282
bazelbuild/bazel/10301
[ "timestamp(timedelta=2126.0, similarity=0.8618771476892152)" ]
fc287a3fda683f267ff586fdf45ca7ec06ffe316
ca93782b924a0e4f94443c33061d0518fea31dd4
[]
[ "Is this commented out code intentional? If yes please include a TODO explaining its purpose.", "I initially added it, then realized it changes semantics and broke tests, and forgot to completely remove. Now it's really gone." ]
2019-11-25T15:53:59Z
[ "type: bug", "P1", "team-Configurability" ]
Cycle error when --platforms is not a platform
### Description of the problem / feature request: If you try to use a number of things as a platform, you get a massive garbage error from the cycle detector. Examples include: * `sh_binary` * `rust_binary` * `config_setting` ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a...
[ "src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java", "src/main/java/com/google/devtools/build/lib/skyframe/PlatformMappingValue.java" ]
[ "src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java", "src/main/java/com/google/devtools/build/lib/skyframe/PlatformMappingValue.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java b/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java index 756fb44b1e1e1c..12344564ede28c 100644 --- a/src/main/java/com/google/devtools/build/lib/analysis/PlatformConfiguration.java +++ b/src/main/...
null
test
train
2019-11-25T11:51:57
2019-11-20T20:19:18Z
m3rcuriel
test
bazelbuild/bazel/10335_10745
bazelbuild/bazel
bazelbuild/bazel/10335
bazelbuild/bazel/10745
[ "timestamp(timedelta=0.0, similarity=0.9347991512158604)" ]
fa5280b15e63c9e93f6aef45bf71eb43b9330d3b
0d58ce0e91946ccc4ac28c01c25a5c1ec1d91d94
[ "@irengrig This flag was added in https://github.com/bazelbuild/bazel/commit/613de1fbbff10de5d6f99f15882fb145a5007f7e. Can you add the labels to get this tested on the incompatible pipeline?", "If this flag is not available in 2.0 and 2.1, can we remove the labels so bazelisk works well?", "We're supposed to cu...
[]
2020-02-10T18:55:57Z
[ "P2", "team-Rules-Server", "incompatible-change" ]
incompatible_load_proto_toolchain_for_javalite_from_com_google_protobuf: Use javalite toolchain from Protobuf master
Flag: `--incompatible_load_proto_toolchain_for_javalite_from_com_google_protobuf` Available since: 2.2 Will be flipped in: 3.0 Tracking issue: #9992 Historically, the runtime for `java_lite_proto_library` was developed in a dedicated branch of the [Protobuf repository](https://github.com/protocolbuffers/protobuf/...
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoAspect.java", "src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoAspect.java", "src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoAspect.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/proto/BazelJavaLiteProtoAspect.java index 636aab18349995..1e9e4f79409828 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/...
null
val
val
2020-02-10T19:21:51
2019-11-28T18:15:27Z
Yannic
test
bazelbuild/bazel/10350_10351
bazelbuild/bazel
bazelbuild/bazel/10350
bazelbuild/bazel/10351
[ "timestamp(timedelta=0.0, similarity=0.8538744602440044)" ]
18d01e7f6d8a3f5b4b4487e9d61a6d4d0f74f33a
4d165601acdd106ec896c202ad4efd33412df490
[ "Thank you for the fix!\r\n\r\nOn CentOS 7 this is what I get:\r\n\r\n```\r\n$ ~/bazel-master/bazel-bin/third_party/ijar/zipper Cc foo.zip @args.txt\r\nFile bart does not seem to exist.\r\n```\r\n\r\nEven though args.txt says `bar`, not `bart`. I guess that's the memory junk your PR fixes. Thanks!" ]
[]
2019-12-02T17:55:58Z
[]
zipper: File foo�ؖ� does not seem to exist.
### Description of the problem / feature request: When invoking zipper with an argument file (`@args.txt`), it occasionally fails with an error of `File <yourfilename> <junk> does not seem to exist`. It looks like a string termination bug. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please p...
[ "third_party/ijar/zip_main.cc" ]
[ "third_party/ijar/zip_main.cc" ]
[]
diff --git a/third_party/ijar/zip_main.cc b/third_party/ijar/zip_main.cc index eac095e136c042..b375da39ecc236 100644 --- a/third_party/ijar/zip_main.cc +++ b/third_party/ijar/zip_main.cc @@ -251,11 +251,12 @@ char **read_filelist(char *filename) { } size_t sizeof_array = sizeof(char *) * (nb_entries + 1); - vo...
null
train
train
2019-12-02T18:25:07
2019-12-02T17:48:17Z
ghost
test
bazelbuild/bazel/10421_10426
bazelbuild/bazel
bazelbuild/bazel/10421
bazelbuild/bazel/10426
[ "timestamp(timedelta=1.0, similarity=0.8747858287546479)" ]
8a8a4345da87967f4c7229fb527442bf839f4a87
a151626df7d33b11a44bff722aca089cac60d845
[ "Why aren't you parsing the proto message (instead of using grep/sed)?\r\n\r\nIf that isn't an option for you, perhaps you can just use proto2json step in between, e.g. using https://developers.google.com/protocol-buffers/docs/reference/java/com/google/protobuf/util/JsonFormat.html?", "@meisterT \r\n\r\n> Why are...
[ "nit: Indentation.", "We can probably pass this in as an argument in the constructor? Makes it easier to test.", "nit: Indentation.", "Same for the rest of the instances of `jsonPrinter`.", "Makes what easier to test?", "For the textproto case we call `TextFormat.print()`, a static method that does not pe...
2019-12-16T20:47:28Z
[ "P3", "team-Performance" ]
Add JSON output format to aquery
### Description of the problem / feature request: Add --output=json to `bazel aquery` ### Feature requests: what underlying problem are you trying to solve with this feature? I recently encountered the need to use aquery to find all the outputs being generated by a particular set of rules. The results needed...
[ "src/main/java/com/google/devtools/build/lib/BUILD", "src/main/java/com/google/devtools/build/lib/query2/BUILD", "src/main/java/com/google/devtools/build/lib/query2/aquery/ActionGraphProtoOutputFormatterCallback.java", "src/main/java/com/google/devtools/build/lib/query2/aquery/ActionGraphQueryEnvironment.java...
[ "src/main/java/com/google/devtools/build/lib/BUILD", "src/main/java/com/google/devtools/build/lib/query2/BUILD", "src/main/java/com/google/devtools/build/lib/query2/aquery/ActionGraphProtoOutputFormatterCallback.java", "src/main/java/com/google/devtools/build/lib/query2/aquery/ActionGraphQueryEnvironment.java...
[ "src/test/shell/integration/aquery_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/BUILD b/src/main/java/com/google/devtools/build/lib/BUILD index 875cf2473a2ba9..08cff8593d537c 100644 --- a/src/main/java/com/google/devtools/build/lib/BUILD +++ b/src/main/java/com/google/devtools/build/lib/BUILD @@ -685,6 +685,7 @@ java_library( "//thi...
diff --git a/src/test/shell/integration/aquery_test.sh b/src/test/shell/integration/aquery_test.sh index 30425c154a8b8e..e57d63e6f79288 100755 --- a/src/test/shell/integration/aquery_test.sh +++ b/src/test/shell/integration/aquery_test.sh @@ -132,7 +132,6 @@ EOF assert_not_contains "echo unused" output } - funct...
train
train
2019-12-18T09:15:00
2019-12-16T10:20:14Z
devnev
test
bazelbuild/bazel/10476_10477
bazelbuild/bazel
bazelbuild/bazel/10476
bazelbuild/bazel/10477
[ "timestamp(timedelta=1.0, similarity=0.8933290516067647)" ]
223ef9d28bc8ec03ead471c74c32cd86f0baf835
c1362f559d4eb34acf8db2d20afdbaa82e15dbb9
[ "Sorry for the unintended breakage and thank you for catching and fixing it!" ]
[ "Code review brought up the question of why not just use `-f` here instead of `! -d`:\r\n\r\n```\r\nif [[ -x \"$wrapper\" && -f \"$wrapper\" ]]; then\r\n```\r\n\r\nIt looks fine to me, because symlinks are handled correctly that way, too (\"If file is a symbolic link, test will fully dereference it and then evaluat...
2019-12-22T16:13:48Z
[ "type: bug", "P1", "team-OSS" ]
bazel.sh attempts to exec directory {WORKSPACE_DIR}/tools/bazel
### Description of the problem / feature request: Using Bazel installed via apt, since 2.0.0 it attempts to exec `{WORKSPACE}/tools/bazel` if it exists, even as directory. This path is commonly used as a directory for storing Bazel related tools and the path is not obviously documented as being special. The error...
[ "scripts/packages/bazel.sh" ]
[ "scripts/packages/bazel.sh" ]
[]
diff --git a/scripts/packages/bazel.sh b/scripts/packages/bazel.sh index 7ffb79b7aac8b6..055641dd1cbf96 100755 --- a/scripts/packages/bazel.sh +++ b/scripts/packages/bazel.sh @@ -191,7 +191,7 @@ if [[ ! -x $BAZEL_REAL ]]; then fi readonly wrapper="${workspace_dir}/tools/bazel" -if [[ -x "$wrapper" ]]; then +if [[ -...
null
test
train
2019-12-22T02:16:53
2019-12-22T16:06:55Z
aaliddell
test
bazelbuild/bazel/10484_10493
bazelbuild/bazel
bazelbuild/bazel/10484
bazelbuild/bazel/10493
[ "timestamp(timedelta=0.0, similarity=0.9135102898837365)" ]
e06c2e8365fecbc6a7f8b42f627637fba94ffb91
9056773c28979edc23782d8c0484c1ac0f011a76
[ "cc @cushon ", "Suspecting a combination of https://github.com/bazelbuild/bazel/commit/a5ee2c4d979441e663cf53b2ace4daa05e5033d8 and https://github.com/bazelbuild/bazel/commit/46c95dcbe2889e515a2b44b9dec00d6c13f7e9fa (/cc @lberki).\r\n\r\nSubmitted #10493 to fix this for now.\r\nLonger-term, we should make `ProtoI...
[ "Using direct instead of transitive sources un-does a change made in 01df1e5c3aaf709e9388293514ae978e59ae2cbb that I think is going to break some uses of `proto_lang_toolchain.blacklisted_protos`.", "Yep, this is exactly what I found out after debugging the aforementioned test failures. Adding _both_ here isn't v...
2019-12-27T15:10:50Z
[ "team-Rules-Server", "untriaged" ]
proto_lang_toolchain and blacklisted_protos with ProtoInfo not propagated correctly
### Description of the problem / feature request: With protobuf's `proto_lang_toolchain`, after this change https://github.com/protocolbuffers/protobuf/commit/7b28278c7d4f4175e70aef2f89d304696eb85ae3 it seems the `blacklisted_protos` are no longer working correctly and removing that field has no effect on the build....
[ "src/main/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchain.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchain.java" ]
[ "src/test/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchainTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchain.java b/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchain.java index ea124b56ee52cb..5f011d81bb5d24 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchain.java +++ b/src/main/...
diff --git a/src/test/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchainTest.java b/src/test/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchainTest.java index dd09ca1189405c..ad2ab914537e03 100644 --- a/src/test/java/com/google/devtools/build/lib/rules/proto/ProtoLangToolchainTest.java +++...
train
train
2020-01-08T20:43:38
2019-12-23T23:08:03Z
keith
test
bazelbuild/bazel/10535_10732
bazelbuild/bazel
bazelbuild/bazel/10535
bazelbuild/bazel/10732
[ "timestamp(timedelta=0.0, similarity=0.8829708662674945)" ]
8ce7fd1222cf3f9f5fc487d774b96cbaf89b999a
5d87b3170461ae23b76fba851da55f9ca0502e60
[ "@borkaehw @SrodriguezO ", "Sounds like a good suggestion. I will check if I have bandwidth in the following few weeks. Anyone is welcome to implement this as well. Thanks." ]
[ "It looks like a bad idea. Can someone help?", "Yes, I don't think this will work (reliably), because the WorkerSpawnRunner instance is shared for all worker strategy executions (multiplex and non-multiplex). I think this might cause the name of all running worker actions to change to \"multiplex-worker\" or \"wo...
2020-02-07T23:42:31Z
[ "type: feature request", "P3", "team-Local-Exec" ]
Show debug information about multiplex worker vs regular persistent worker
### Description of the problem / feature request: Currently when we replace our persistent worker with [multiplex worker](https://docs.bazel.build/versions/master/multiplex-worker.html), it is unclear which one is being used. `--worker_verbose` shows "Create new ... worker (id #)", but does not display the debug inf...
[ "src/main/java/com/google/devtools/build/lib/worker/WorkerFactory.java", "src/main/java/com/google/devtools/build/lib/worker/WorkerKey.java", "src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java" ]
[ "src/main/java/com/google/devtools/build/lib/worker/WorkerFactory.java", "src/main/java/com/google/devtools/build/lib/worker/WorkerKey.java", "src/main/java/com/google/devtools/build/lib/worker/WorkerSpawnRunner.java" ]
[ "src/test/java/com/google/devtools/build/lib/worker/WorkerKeyTest.java", "src/test/shell/integration/bazel_worker_multiplexer_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/worker/WorkerFactory.java b/src/main/java/com/google/devtools/build/lib/worker/WorkerFactory.java index be835737dfa77f..7e879f1afbb2a5 100644 --- a/src/main/java/com/google/devtools/build/lib/worker/WorkerFactory.java +++ b/src/main/java/com/google/devtools/build...
diff --git a/src/test/java/com/google/devtools/build/lib/worker/WorkerKeyTest.java b/src/test/java/com/google/devtools/build/lib/worker/WorkerKeyTest.java index a0a0fe2feae249..83bbc01ad11e58 100644 --- a/src/test/java/com/google/devtools/build/lib/worker/WorkerKeyTest.java +++ b/src/test/java/com/google/devtools/build...
train
val
2020-02-27T19:53:16
2020-01-07T18:50:29Z
fenghaolw
test
bazelbuild/bazel/10541_10677
bazelbuild/bazel
bazelbuild/bazel/10541
bazelbuild/bazel/10677
[ "timestamp(timedelta=1.0, similarity=0.919713396807798)" ]
75ed889beae02388800a022831f20e6c78be98dd
73ab9d2dd921d32453a67fded47db1d15ffd2bec
[ "Super-useful! \r\n\r\nHappy to help with (at least) configuration-related terms." ]
[ "Non-alphabetical order?", "Replace italics with link to phase entries?", "Replace italics with links?\r\n\r\nMore generally, I think italics signify highlighting of a newly introduced concept. Which is the same role a link to a glossary definition provides (and in a better way). \r\n\r\nI know we used italics ...
2020-01-29T11:58:02Z
[ "type: feature request", "type: documentation (cleanup)", "untriaged", "team-OSS" ]
Documentation: create a Bazel glossary
Feature request: create a glossary for abstractions used in the Bazel build system and ecosystem. Work in progress: https://github.com/jin/bazel-glossary
[ "site/_layouts/documentation.html" ]
[ "site/_layouts/documentation.html", "site/docs/glossary.md" ]
[]
diff --git a/site/_layouts/documentation.html b/site/_layouts/documentation.html index 36d154a35bb56c..a70c35b277c08e 100644 --- a/site/_layouts/documentation.html +++ b/site/_layouts/documentation.html @@ -268,6 +268,8 @@ <h3>Rules</h3> <h3>Reference</h3> <ul class="sidebar-nav"> ...
null
train
val
2020-02-08T01:44:42
2020-01-08T21:00:26Z
jin
test
bazelbuild/bazel/10541_10824
bazelbuild/bazel
bazelbuild/bazel/10541
bazelbuild/bazel/10824
[ "timestamp(timedelta=5250.0, similarity=0.8448289083933646)" ]
0447bf95eb996cca7530259b93db4882b95bcb84
null
[ "Super-useful! \r\n\r\nHappy to help with (at least) configuration-related terms." ]
[]
2020-02-19T17:21:45Z
[ "type: feature request", "type: documentation (cleanup)", "untriaged", "team-OSS" ]
Documentation: create a Bazel glossary
Feature request: create a glossary for abstractions used in the Bazel build system and ecosystem. Work in progress: https://github.com/jin/bazel-glossary
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[ ".travis.yml", "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[]
diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000000000..8af1e3ba247017 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,29 @@ +os: linux +arch: ppc64le +sudo: required +language: go +go: +- "1.13.x" + +jobs: + include: + - dist: xenial + env: dist_version=16.04 + - dist: bionic + en...
null
train
val
2020-02-19T18:11:40
2020-01-08T21:00:26Z
jin
test
bazelbuild/bazel/10574_10632
bazelbuild/bazel
bazelbuild/bazel/10574
bazelbuild/bazel/10632
[ "timestamp(timedelta=163663.0, similarity=0.9634503299492746)" ]
539e5f4778cdb3702aa68f27b73e8a3d21c4a5a4
bc9c3eda453d206bf6c51bf14dfaa067eb85aa89
[ "Contributions welcome. I expect this'd be easy by simply adding a new entry here:\r\n\r\nhttps://github.com/bazelbuild/bazel/blob/605eaccabe2fed0a1d188d77baa2206f6346becd/src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java#L207-L209\r\n\r\ni.e. clone and modify:\r\n\r\nh...
[ "Does your PR included a file that defines this class?\r\n", "Ok, so what I'm reading from your last error report is compilation fails because the parameters you're passing to CqueryThreadsafeCallback's constructor are different than what the constructor expects: https://github.com/bazelbuild/bazel/blob/ebca24c5...
2020-01-22T11:19:55Z
[ "P3", "good first issue", "team-Configurability" ]
add `label_kind` to `--output` for cquery
`bazel cquery` with `--output label_kind` gives ERROR: Invalid output format 'label_kind'. Valid values are: label, transitions, proto, textproto, build
[ "src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java", "src/main/java/com/google/devtools/build/lib/query2/cquery/CqueryOptions.java", "src/main/java/com/google/devtools/build/lib/query2/cquery/LabelAndConfigurationOutputFormatterCallback.java" ]
[ "src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java", "src/main/java/com/google/devtools/build/lib/query2/cquery/CqueryOptions.java", "src/main/java/com/google/devtools/build/lib/query2/cquery/LabelAndConfigurationOutputFormatterCallback.java" ]
[ "src/test/shell/integration/configured_query_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java b/src/main/java/com/google/devtools/build/lib/query2/cquery/ConfiguredTargetQueryEnvironment.java index 61ce4d8e8e9f09..ae05a7050eb013 100644 --- a/src/main/java/com/google/devtools/build/lib/query2/cquery/Confi...
diff --git a/src/test/shell/integration/configured_query_test.sh b/src/test/shell/integration/configured_query_test.sh index e3019fdc333358..6f73a165636bc5 100755 --- a/src/test/shell/integration/configured_query_test.sh +++ b/src/test/shell/integration/configured_query_test.sh @@ -90,6 +90,17 @@ EOF assert_contains ...
val
val
2020-01-22T09:11:11
2020-01-13T20:49:50Z
ahumesky
test
bazelbuild/bazel/10582_10583
bazelbuild/bazel
bazelbuild/bazel/10582
bazelbuild/bazel/10583
[ "timestamp(timedelta=0.0, similarity=0.8435984294146742)" ]
1c0a9a37623ea4253e9204f9a869a5c0a6538d0f
0ebce746fc54c3770dd0c8846d847324e5a3e609
[ "Setting -arch to `\"<architecture>\"` for watchos_arm64_32 certainly seems to be the wrong thing to do. Thank you for the PR, I'll ping some potential reviewers." ]
[]
2020-01-14T14:05:19Z
[ "type: bug", "P2", "z-team-Apple" ]
Building for arm64_32 fails
### Description of the problem / feature request: Building a watch application for arm64_32 results in clang failing with `clang: error: invalid arch name '-arch <architecture>'` ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible. Build any `watchos_app...
[ "tools/osx/crosstool/cc_toolchain_config.bzl" ]
[ "tools/osx/crosstool/cc_toolchain_config.bzl" ]
[]
diff --git a/tools/osx/crosstool/cc_toolchain_config.bzl b/tools/osx/crosstool/cc_toolchain_config.bzl index 12027dadf49442..495edef6d270e2 100644 --- a/tools/osx/crosstool/cc_toolchain_config.bzl +++ b/tools/osx/crosstool/cc_toolchain_config.bzl @@ -337,8 +337,7 @@ def _impl(ctx): else: cpp_header_parsin...
null
val
val
2020-01-14T14:51:02
2020-01-14T13:31:10Z
AlessandroPatti
test
bazelbuild/bazel/10621_10646
bazelbuild/bazel
bazelbuild/bazel/10621
bazelbuild/bazel/10646
[ "timestamp(timedelta=1.0, similarity=0.876917838799279)" ]
5b956632c436492545a5be5b13765700b8a01b5f
cac23920a6be380d4a408d1f2c36fdf4ad330b34
[ "Thanks for the report.\r\nI can repro locally, with a trivial cc_test.\r\n\r\nfoo/BUILD:\r\n```\r\ncc_test(name = \"x\", srcs = [\"x.cc\"])\r\n```\r\n\r\nfoo/x.cc:\r\n```\r\nint main() { return 0; }\r\n```\r\n\r\n```\r\nbazel run //foo:x\r\n(...)\r\nExecuting tests from //foo:x\r\n---------------------------------...
[]
2020-01-24T11:33:06Z
[ "type: bug", "P2", "area-Windows", "team-OSS" ]
`bazel run` before `bazel test` fails with `Could not chdir` on Windows
### Description of the problem / feature request: On Windows, if you run a test target with `bazel run` before you run that same test with `bazel test` (after a clean) then the test will fail with `Could not chdir` on Windows. This was originally reported in #7387 and marked as resolved so it may have regressed a...
[ "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java" ]
[ "src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java" ]
[ "src/test/shell/bazel/BUILD", "src/test/shell/bazel/run_test.sh", "src/test/shell/integration/run_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java b/src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java index 3fa05a91f638bd..6be15b3c5b205a 100644 --- a/src/main/java/com/google/devtools/build/lib/runtime/commands/RunCommand.java +++ b/src/main/java/com/...
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD index 1a2efa50a50123..98dccd0264d092 100644 --- a/src/test/shell/bazel/BUILD +++ b/src/test/shell/bazel/BUILD @@ -1230,3 +1230,10 @@ sh_test( data = [":test-deps"], deps = ["@bazel_tools//tools/bash/runfiles"], ) + +sh_test( + name = "ru...
test
val
2020-01-24T12:01:13
2020-01-21T00:50:27Z
gregmagolan
test
bazelbuild/bazel/10735_11030
bazelbuild/bazel
bazelbuild/bazel/10735
bazelbuild/bazel/11030
[ "timestamp(timedelta=0.0, similarity=0.8570088458054608)" ]
7c4d35d7dd71717a0ee59d7e614326818e49c371
6d0ab951fe6a8cc9c8db5136760b890cdff07c85
[ "I'm interested in seeing this happen. Bazel remote execution currently doesn't support a lot of authentication options out of the box, and I can think of use cases where this is more appropriate than Google access tokens." ]
[]
2020-03-26T20:56:39Z
[ "untriaged", "team-Remote-Exec" ]
FR: mutual tls auth for remote cache/executor
### Description of the problem / feature request: I was under impression that [--tls_certificate](https://docs.bazel.build/versions/2.0.0/command-line-reference.html#flag--tls_certificate) can be used for mutual tls, but in code I see that it only configures trusted CA certs: [GoogleAuthUtils.java#L117](https://gith...
[ "src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java", "src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java", "src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/RemoteWorker.java", "src/tools/remote/src/main/java/com/google/devtools/build/...
[ "src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java", "src/main/java/com/google/devtools/build/lib/authandtls/GoogleAuthUtils.java", "src/tools/remote/src/main/java/com/google/devtools/build/remote/worker/RemoteWorker.java", "src/tools/remote/src/main/java/com/google/devtools/build/...
[ "src/test/shell/bazel/remote/BUILD", "src/test/shell/bazel/remote/remote_execution_tls_test.sh", "src/test/testdata/test_tls_certificate/ca.crt", "src/test/testdata/test_tls_certificate/client.crt", "src/test/testdata/test_tls_certificate/client.pem", "src/test/testdata/test_tls_certificate/server.crt", ...
diff --git a/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java b/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java index c5ab8a2d19b6da..cd0d8ff4701a60 100644 --- a/src/main/java/com/google/devtools/build/lib/authandtls/AuthAndTLSOptions.java +++ b/src/main/java/c...
diff --git a/src/test/shell/bazel/remote/BUILD b/src/test/shell/bazel/remote/BUILD index d3848dd90c28d1..0aa83be1c615dd 100644 --- a/src/test/shell/bazel/remote/BUILD +++ b/src/test/shell/bazel/remote/BUILD @@ -47,6 +47,20 @@ sh_test( size = "large", timeout = "eternal", srcs = ["remote_execution_tls_tes...
train
val
2020-03-26T21:18:47
2020-02-08T14:15:28Z
amkartashov
test
bazelbuild/bazel/10746_10759
bazelbuild/bazel
bazelbuild/bazel/10746
bazelbuild/bazel/10759
[ "timestamp(timedelta=1.0, similarity=0.8410750965459701)" ]
37aad0e0a67e0c70476ad686cba74c1870cd3229
b7d82994577918f3987307af91b8a9b8077ef2e6
[ "@alandonovan -- i've tried to figure out how to get this to build and can't. i thought maybe it was because we build using the local jdk, but i think that's the default now. i also tried that on x86 and this works fine. so now i'm guessing there's some place i can't find with an `linux_x86_64` option and a blank ...
[]
2020-02-11T18:30:58Z
[]
building bazel libcpu_profiler fails to find jni_md.h (ppc64le)
### Description of the problem / feature request: compiling from master on ppc64le fails: > bazel-out/ppc-fastbuild/bin/external/bazel_tools/tools/jdk/include/jni.h:45:10: fatal error: jni_md.h: No such file or directory ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal e...
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/syntax/BUILD b/src/main/java/com/google/devtools/build/lib/syntax/BUILD index 45aab0f4953301..b1918666a337a4 100644 --- a/src/main/java/com/google/devtools/build/lib/syntax/BUILD +++ b/src/main/java/com/google/devtools/build/lib/syntax/BUILD @@ -165,6 +165,7 @@ c...
null
train
val
2020-02-20T19:40:22
2020-02-10T20:00:01Z
clnperez
test
bazelbuild/bazel/10791_10819
bazelbuild/bazel
bazelbuild/bazel/10791
bazelbuild/bazel/10819
[ "timestamp(timedelta=90222.0, similarity=0.8497456594812841)" ]
ac745853146dd6dfa4738f2e6795e5ea000915d0
bc3210aa47e9dc839e9f44ac182eeb938032f356
[]
[ "For this and all other level2+ headers, should we use **Capitalize All Words** formatting or **Only first word**?\r\n\r\nThis and the the very next header disagree. And we have inconsistent use all throughout the docset. I'm happy to do a docset-wide refactoring if we can agree on the answer.\r\n\r\nI suspect the ...
2020-02-19T03:44:29Z
[ "type: feature request", "type: documentation (cleanup)", "P1" ]
Bazel docs - style upgrade
Tracks the effort to productionize https://groups.google.com/g/bazel-dev/c/hjRP7JTtZ_U/m/9SZYZUSBDAAJ. Prototype at https://bazel-docs-staging.netlify.com/versions/master/bazel-overview.html
[ "site/docs/bazel-vision.md" ]
[ "site/docs/bazel-vision.md" ]
[]
diff --git a/site/docs/bazel-vision.md b/site/docs/bazel-vision.md index d0aad8a996f545..7e2680f2ac9ae5 100644 --- a/site/docs/bazel-vision.md +++ b/site/docs/bazel-vision.md @@ -5,9 +5,9 @@ title: Bazel Vision # Bazel Vision -<font size='+1'>Any software developer can efficiently build, test, and package +<p><fon...
null
train
val
2020-02-19T04:33:02
2020-02-14T23:15:59Z
gregestren
test
bazelbuild/bazel/10791_10824
bazelbuild/bazel
bazelbuild/bazel/10791
bazelbuild/bazel/10824
[ "timestamp(timedelta=108349.0, similarity=0.8824954897643075)" ]
0447bf95eb996cca7530259b93db4882b95bcb84
null
[]
[]
2020-02-19T17:21:45Z
[ "type: feature request", "type: documentation (cleanup)", "P1" ]
Bazel docs - style upgrade
Tracks the effort to productionize https://groups.google.com/g/bazel-dev/c/hjRP7JTtZ_U/m/9SZYZUSBDAAJ. Prototype at https://bazel-docs-staging.netlify.com/versions/master/bazel-overview.html
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[ ".travis.yml", "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[]
diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000000000..8af1e3ba247017 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,29 @@ +os: linux +arch: ppc64le +sudo: required +language: go +go: +- "1.13.x" + +jobs: + include: + - dist: xenial + env: dist_version=16.04 + - dist: bionic + en...
null
val
val
2020-02-19T18:11:40
2020-02-14T23:15:59Z
gregestren
test
bazelbuild/bazel/10792_10819
bazelbuild/bazel
bazelbuild/bazel/10792
bazelbuild/bazel/10819
[ "timestamp(timedelta=88609.0, similarity=0.8609747650576375)" ]
ac745853146dd6dfa4738f2e6795e5ea000915d0
bc3210aa47e9dc839e9f44ac182eeb938032f356
[]
[ "For this and all other level2+ headers, should we use **Capitalize All Words** formatting or **Only first word**?\r\n\r\nThis and the the very next header disagree. And we have inconsistent use all throughout the docset. I'm happy to do a docset-wide refactoring if we can agree on the answer.\r\n\r\nI suspect the ...
2020-02-19T03:44:29Z
[ "type: documentation (cleanup)", "P1" ]
Bazel docs - lightweight organizational refresh
This tracks productionizing https://groups.google.com/g/bazel-dev/c/hjRP7JTtZ_U/m/a4SDZkzPBAAJ. docs.bazel.build gets first priority. We'll also cover blog.bazel.build and https://bazel.build/contributing.html as time permits.
[ "site/docs/bazel-vision.md" ]
[ "site/docs/bazel-vision.md" ]
[]
diff --git a/site/docs/bazel-vision.md b/site/docs/bazel-vision.md index d0aad8a996f545..7e2680f2ac9ae5 100644 --- a/site/docs/bazel-vision.md +++ b/site/docs/bazel-vision.md @@ -5,9 +5,9 @@ title: Bazel Vision # Bazel Vision -<font size='+1'>Any software developer can efficiently build, test, and package +<p><fon...
null
test
val
2020-02-19T04:33:02
2020-02-14T23:19:10Z
gregestren
test
bazelbuild/bazel/10792_10824
bazelbuild/bazel
bazelbuild/bazel/10792
bazelbuild/bazel/10824
[ "timestamp(timedelta=106736.0, similarity=0.8783042216074869)" ]
0447bf95eb996cca7530259b93db4882b95bcb84
null
[]
[]
2020-02-19T17:21:45Z
[ "type: documentation (cleanup)", "P1" ]
Bazel docs - lightweight organizational refresh
This tracks productionizing https://groups.google.com/g/bazel-dev/c/hjRP7JTtZ_U/m/a4SDZkzPBAAJ. docs.bazel.build gets first priority. We'll also cover blog.bazel.build and https://bazel.build/contributing.html as time permits.
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[ ".travis.yml", "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[]
diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000000000..8af1e3ba247017 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,29 @@ +os: linux +arch: ppc64le +sudo: required +language: go +go: +- "1.13.x" + +jobs: + include: + - dist: xenial + env: dist_version=16.04 + - dist: bionic + en...
null
val
val
2020-02-19T18:11:40
2020-02-14T23:19:10Z
gregestren
test
bazelbuild/bazel/10794_10819
bazelbuild/bazel
bazelbuild/bazel/10794
bazelbuild/bazel/10819
[ "timestamp(timedelta=88665.0, similarity=0.8432832893471068)" ]
ac745853146dd6dfa4738f2e6795e5ea000915d0
bc3210aa47e9dc839e9f44ac182eeb938032f356
[]
[ "For this and all other level2+ headers, should we use **Capitalize All Words** formatting or **Only first word**?\r\n\r\nThis and the the very next header disagree. And we have inconsistent use all throughout the docset. I'm happy to do a docset-wide refactoring if we can agree on the answer.\r\n\r\nI suspect the ...
2020-02-19T03:44:29Z
[ "type: documentation (cleanup)", "P1" ]
Bazel docs - do lightweight content formatting fixes
For example, make https://docs.bazel.build/versions/2.1.0/bazel-vision.html less wall-o'-texty. The broader goal is to make docs inviting, accessible, not intimidating. The less encyclopedic (i.e. dense) each page is the better. https://github.com/bazelbuild/bazel/issues/10791 should also help by using bigger fon...
[ "site/docs/bazel-vision.md" ]
[ "site/docs/bazel-vision.md" ]
[]
diff --git a/site/docs/bazel-vision.md b/site/docs/bazel-vision.md index d0aad8a996f545..7e2680f2ac9ae5 100644 --- a/site/docs/bazel-vision.md +++ b/site/docs/bazel-vision.md @@ -5,9 +5,9 @@ title: Bazel Vision # Bazel Vision -<font size='+1'>Any software developer can efficiently build, test, and package +<p><fon...
null
train
val
2020-02-19T04:33:02
2020-02-14T23:27:17Z
gregestren
test
bazelbuild/bazel/10794_10824
bazelbuild/bazel
bazelbuild/bazel/10794
bazelbuild/bazel/10824
[ "timestamp(timedelta=106792.0, similarity=0.8437765051650821)" ]
0447bf95eb996cca7530259b93db4882b95bcb84
null
[]
[]
2020-02-19T17:21:45Z
[ "type: documentation (cleanup)", "P1" ]
Bazel docs - do lightweight content formatting fixes
For example, make https://docs.bazel.build/versions/2.1.0/bazel-vision.html less wall-o'-texty. The broader goal is to make docs inviting, accessible, not intimidating. The less encyclopedic (i.e. dense) each page is the better. https://github.com/bazelbuild/bazel/issues/10791 should also help by using bigger fon...
[ "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[ ".travis.yml", "src/main/java/com/google/devtools/build/lib/syntax/BUILD" ]
[]
diff --git a/.travis.yml b/.travis.yml new file mode 100644 index 00000000000000..8af1e3ba247017 --- /dev/null +++ b/.travis.yml @@ -0,0 +1,29 @@ +os: linux +arch: ppc64le +sudo: required +language: go +go: +- "1.13.x" + +jobs: + include: + - dist: xenial + env: dist_version=16.04 + - dist: bionic + en...
null
test
val
2020-02-19T18:11:40
2020-02-14T23:27:17Z
gregestren
test
bazelbuild/bazel/10867_10915
bazelbuild/bazel
bazelbuild/bazel/10867
bazelbuild/bazel/10915
[ "timestamp(timedelta=0.0, similarity=0.9220770627435996)" ]
0f99c3cc0b7b82e198c8f365254493fc4713edcd
b5ae666a5563fa2a4c0cdac45bee8438eeee0d1c
[]
[]
2020-03-06T13:54:41Z
[ "type: feature request", "P2", "area-Windows", "team-OSS" ]
Make %USERPROFILE%\_netrc the default location for the netrc file on Windows
### Description of the problem / feature request: Bazel has a default "netrc" file location under Linux and Mac OS, but not under Windows. This is identified as "TODO" in [http.bzl](https://github.com/bazelbuild/bazel/blob/master/tools/build_defs/repo/http.bzl#L55) ### Feature requests: what underlying problem ar...
[ "tools/build_defs/repo/http.bzl" ]
[ "tools/build_defs/repo/http.bzl" ]
[ "src/test/shell/bazel/BUILD", "src/test/shell/bazel/skylark_repository_test.sh", "src/test/shell/bazel/testing_server.py", "src/test/shell/testenv.sh" ]
diff --git a/tools/build_defs/repo/http.bzl b/tools/build_defs/repo/http.bzl index 587dff0c192529..04efba860e305f 100644 --- a/tools/build_defs/repo/http.bzl +++ b/tools/build_defs/repo/http.bzl @@ -45,14 +45,17 @@ def _get_auth(ctx, urls): netrc = read_netrc(ctx, ctx.attr.netrc) return use_netrc(netr...
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD index d47e4d4af52810..12448cd1b7d387 100644 --- a/src/test/shell/bazel/BUILD +++ b/src/test/shell/bazel/BUILD @@ -729,7 +729,6 @@ sh_test( ], shard_count = 6, tags = [ - "no_windows", "requires-network", ], ) diff ...
train
val
2020-03-10T00:09:43
2020-02-26T16:19:35Z
plule-ansys
test
bazelbuild/bazel/10913_10970
bazelbuild/bazel
bazelbuild/bazel/10913
bazelbuild/bazel/10970
[ "timestamp(timedelta=1.0, similarity=0.8844322909199289)" ]
3d2d8b627500307f7317ad9c7b0eecdf20b81674
088a910d5c843a72736bfad2336a5a1ea577e583
[ "/cc @meteorcloudy " ]
[ "We can use bit-operators here to test for the bits in the permission bitmask :)\r\n\r\nExecutable is `0b001 = 1`\r\nWritable is `0b010 = 2`\r\nReadable is `0b100 = 4`\r\n\r\nSo we can replace this with:\r\n\r\n```java\r\nreturn permission & 4;\r\n```", "Similarly:\r\n```java\r\nreturn permission & 2;\r\n```", ...
2020-03-16T16:49:46Z
[ "type: bug", "P2" ]
Native patch doesn't preserve executable bit
### Description of the problem / feature request: Native patch doesn't preserve the executable bit of the patched file. If you're trying to patch an executable file in a repository, the file will become a non-executable file. ### Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minim...
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java" ]
[ "src/test/java/com/google/devtools/build/lib/bazel/repository/PatchUtilTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java index 8c0a2da84a7715..8ab52cdbd56794 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/PatchUtil.java +++ b/src/main/java/com/goo...
diff --git a/src/test/java/com/google/devtools/build/lib/bazel/repository/PatchUtilTest.java b/src/test/java/com/google/devtools/build/lib/bazel/repository/PatchUtilTest.java index 5fbcace554a2b1..64fb6d0eea7a63 100644 --- a/src/test/java/com/google/devtools/build/lib/bazel/repository/PatchUtilTest.java +++ b/src/test/...
train
val
2020-03-16T16:29:47
2020-03-06T05:59:43Z
thii
test
bazelbuild/bazel/10931_10935
bazelbuild/bazel
bazelbuild/bazel/10931
bazelbuild/bazel/10935
[ "timestamp(timedelta=0.0, similarity=0.9054300288928118)" ]
ff4673260dc2f5de6e0aae3b66af18edf62cadd1
73b4c37b025e31156e1daef0cc1bbc9cbd08346e
[ "See also https://github.com/bazelbuild/bazel/blob/master/src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java#L70" ]
[]
2020-03-10T11:17:47Z
[ "area-Windows", "untriaged", "team-OSS" ]
FilterTestHeaderOutputStream doesn't respect system line separator
`private static final int NEWLINE = '\n';` https://github.com/bazelbuild/bazel/blob/59f17d6e0550bf63a0b6ef182e2d63474e058ede/src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java#L95 cc @meteorcloudy
[ "src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java" ]
[ "src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java" ]
[ "src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java b/src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java index 409c10d903a9ce..5023a26af9a3d4 100644 --- a/src/main/java/com/google/devtools/build/lib/exec/TestLogHelper.java +++ b/src/main/java/com/google/devtools/build/lib/e...
diff --git a/src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java b/src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java index cc04eadf9d1051..fb044675176cdd 100644 --- a/src/test/java/com/google/devtools/build/lib/exec/StreamedTestOutputTest.java +++ b/src/test/java/com/...
train
val
2020-03-10T11:05:47
2020-03-09T19:55:02Z
laurentlb
test
bazelbuild/bazel/11040_11113
bazelbuild/bazel
bazelbuild/bazel/11040
bazelbuild/bazel/11113
[ "timestamp(timedelta=1.0, similarity=0.8547104776867628)" ]
59dd64c6eb1347fcca72374fd5758e226f77b5ee
a5bc750eaf13d8debfe537c0f565f20096bb58a5
[ "Bisecting the problem:\r\n\r\nebb86fcdc202c440a362a54f6b0de8a049dfa84b is the first bad commit\r\n\"bazel packages: record Starlark stack in RuleClass at creation\"\r\n\r\n//CC @alandonovan ", "cc @laurentlb This is a UI regression.", "cc/ +Alan Donovan <adonovan@google.com>\n\nOn Sat, Apr 4, 2020 at 8:33 AM J...
[]
2020-04-10T20:22:37Z
[ "type: bug", "P0" ]
Warning: Rule '<every remote repository rule>' indicated that a canonical reproducible form can be obtained by dropping arguments ["generator_name", "generator_function"]
I'm seeing these warnings for every remote repository rule on Bazel@HEAD (5c1c0d1ed8643c90fba239d1bc642e4ebd044c2c). Here are the warnings for [gitiles](https://gerrit.googlesource.com/gitiles) repository: ``` $ bazel build :gitiles Starting local Bazel server and connecting to it... INFO: Invocation ID: 0e7...
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryResolvedEvent.java" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryResolvedEvent.java" ]
[ "src/test/shell/bazel/workspace_resolved_test.sh" ]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryResolvedEvent.java b/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryResolvedEvent.java index a77d6fa8816fd4..5520eaa70b5d1b 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/repository/RepositoryReso...
diff --git a/src/test/shell/bazel/workspace_resolved_test.sh b/src/test/shell/bazel/workspace_resolved_test.sh index 12bf50be264349..9a82cf744e4173 100755 --- a/src/test/shell/bazel/workspace_resolved_test.sh +++ b/src/test/shell/bazel/workspace_resolved_test.sh @@ -1216,4 +1216,51 @@ EOF expect_log " TEST_TMPDIR/....
val
val
2020-04-10T22:05:55
2020-03-29T09:25:40Z
davido
test
bazelbuild/bazel/11095_11096
bazelbuild/bazel
bazelbuild/bazel/11095
bazelbuild/bazel/11096
[ "timestamp(timedelta=0.0, similarity=0.9228630271523497)" ]
1af5e991cf205c61f9fdcc9687691c3c5515122e
1786eb0674379a1f75261c9137924e105e267a56
[ "cc @gregestren ", "Figured out the problem:\r\n\r\n```\r\n$ TMP=`mktemp -d /tmp/tmp.XXXXXXXXXX` && bazel-out/host/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer --jvm_flag=-Dio.bazel.EnableJni=0 --batch --install_base=${TMP} --output_base=${TMP}/output/ --output_user_root=${TMP} help everythin...
[ "This is obviously unneeded, but it also makes sense to copy over a tricky preamble like this without changes. So I'm calling it out as OK, in spite of it looking funny.", "grep -q ....\r\nwill just set an exit status without doing any output.", "Nice, done." ]
2020-04-08T07:11:05Z
[ "type: documentation (cleanup)", "breakage" ]
//src/main/java/com/google/devtools/build/lib:gen_command-line-reference is broken
Bisected to 09924273efc7050a2e342cd89b823a619ca073f8 (cc @anakanemison) ``` $ bazel build //src/main/java/com/google/devtools/build/lib:gen_command-line-reference --verbose_failures ... INFO: Analyzed target //src/main/java/com/google/devtools/build/lib:gen_command-line-reference (0 packages loaded, 0 targets c...
[ "site/BUILD", "src/main/java/com/google/devtools/build/lib/BUILD" ]
[ "site/BUILD", "src/main/java/com/google/devtools/build/lib/BUILD" ]
[ "src/test/shell/bazel/BUILD", "src/test/shell/bazel/bazel_docgen_test.sh" ]
diff --git a/site/BUILD b/site/BUILD index d9b4b153d6f4ca..ef3d4ba3c00401 100644 --- a/site/BUILD +++ b/site/BUILD @@ -155,6 +155,15 @@ jekyll_build( srcs = [ "@jekyll_tree_%s//file" % DOC_VERSION["version"].replace(".", "_") for DOC_VERSION in DOC_VERSIONS - ] + [":jekyll-tree"], # jekyll-tr...
diff --git a/src/test/shell/bazel/BUILD b/src/test/shell/bazel/BUILD index c0f0772756f839..3f69d81de57ab9 100644 --- a/src/test/shell/bazel/BUILD +++ b/src/test/shell/bazel/BUILD @@ -597,8 +597,9 @@ sh_test( name = "bazel_docgen_test", size = "large", srcs = ["bazel_docgen_test.sh"], - data = ["//src/...
test
val
2020-04-08T09:31:35
2020-04-08T06:54:24Z
jin
test
bazelbuild/bazel/11105_11213
bazelbuild/bazel
bazelbuild/bazel/11105
bazelbuild/bazel/11213
[ "timestamp(timedelta=34109.0, similarity=0.8699825378818541)" ]
241904e3a26b7dfb39fe97085c1281e9f91c2359
a48ee432b7ce82f44f7d66f7488aed21fc8e0090
[ "There simply is not enough to triage this.\r\nHow did you build the container that causes this?\r\nIs this actually an error in container setup, or a normal use case?", "Hi,\r\nlooks like I am running in to the same problem.\r\n\r\nI have a proxmox server and created a LXC Debain 10 container in it.\r\n\r\n\r\n\...
[ "Just change this into `memInfo = ImmutableMap.copyOf(newMemInfo);`, and drop the builder variable above. No need to create three maps if two are enough.", "The code implements first wins, but this asserts last wins. Did you actually run the test?", "good point, changed", "No, since I where confused by the do...
2020-04-24T11:49:42Z
[ "more data needed", "untriaged", "team-Local-Exec" ]
Duplicate entries in `/proc/meminfo` make bazel server crash
### Description of the problem / feature request: running `bazel build //:hello_world` leads to ``` $ bazel build //:hello_world Starting local Bazel server and connecting to it... Server terminated abruptly (error code: 14, error message: 'Socket closed', log file: '/home/dark/.cache/bazel/_bazel_dark/37e...
[ "src/main/java/com/google/devtools/build/lib/unix/ProcMeminfoParser.java" ]
[ "src/main/java/com/google/devtools/build/lib/unix/ProcMeminfoParser.java" ]
[ "src/test/java/com/google/devtools/build/lib/unix/ProcMeminfoParserTest.java" ]
diff --git a/src/main/java/com/google/devtools/build/lib/unix/ProcMeminfoParser.java b/src/main/java/com/google/devtools/build/lib/unix/ProcMeminfoParser.java index dcfe8086f8eb68..92dd93cc2d6a77 100644 --- a/src/main/java/com/google/devtools/build/lib/unix/ProcMeminfoParser.java +++ b/src/main/java/com/google/devtools...
diff --git a/src/test/java/com/google/devtools/build/lib/unix/ProcMeminfoParserTest.java b/src/test/java/com/google/devtools/build/lib/unix/ProcMeminfoParserTest.java index 059c58ae24fdc8..fff62cddfafdae 100644 --- a/src/test/java/com/google/devtools/build/lib/unix/ProcMeminfoParserTest.java +++ b/src/test/java/com/goo...
val
val
2020-04-24T10:43:26
2020-04-09T01:06:02Z
DarkDimius
test
bazelbuild/bazel/11186_11190
bazelbuild/bazel
bazelbuild/bazel/11186
bazelbuild/bazel/11190
[ "timestamp(timedelta=0.0, similarity=0.8680651548178261)" ]
990a7de2a07a33d4a50d3ec55085728074e5b2b4
78451bda21c192a757e50e47c83d349c47ecbf03
[]
[ "very attentive :)", "isn't this supposed to be `file://` (note the double slash?)", "(I keep forgetting that this syntax exists)", "No, the syntax is, apparently, file:(path), where path can be relative to the current directory or absolute. This matches the previous implementation.", "Me too." ]
2020-04-22T13:33:09Z
[ "type: bug", "P2", "team-Rules-Java" ]
java_stub_template improperly qualifies paths
In [java_stub_template.txt](https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt;drc=02f8da948bf3955304a4cef9399bd3907430bbc4;l=298), when building the classpath for the manifest file, every path entry is first qualified with the working directory...
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt" ]
[ "src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt b/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt index 1aac7f8c90c131..41b3362ba863f6 100644 --- a/src/main/java/com/google/devtools/build/lib/bazel/rules/java/java_stub_template.txt +++...
null
train
val
2020-04-22T15:03:47
2020-04-22T12:18:10Z
katre
test
bazelbuild/bazel/11223_11225
bazelbuild/bazel
bazelbuild/bazel/11223
bazelbuild/bazel/11225
[ "timestamp(timedelta=1.0, similarity=0.8557589510761733)" ]
76d895aa28d0511bcd9c42c1961644ef03a6088c
519da8e908695f6a754cef8d040742fb77ec2073
[ "I've submitted a potential fix for this that appears to solve my repro case locally https://github.com/bazelbuild/bazel/pull/11225" ]
[ "```suggestion\r\n ImmutableSet<Artifact> ccLibs = ImmutableSet.copyOf(objcProvider.getCcLibraries());\r\n```", "Thanks! I was trying to find the nicer invocation here", "`copyOf` is most likely more efficient too. Depending on the type of `getCcLibraries` it can allocate a set of right size and copy element...
2020-04-25T00:08:50Z
[ "type: bug", "P3", "team-Rules-CPP" ]
Duplicate symbols from apple_static_library with Swift
When using the `ios_static_framework` rule from rules_apple, which has an underlying `apple_static_library` target. If you have a dependency tree like this: ``` ios_static_framework swift_library objc_library cc_library ``` The symbols from the `cc_library` target end up duplicated in the final binary. Our a...
[ "src/main/java/com/google/devtools/build/lib/rules/objc/ObjcVariablesExtension.java" ]
[ "src/main/java/com/google/devtools/build/lib/rules/objc/ObjcVariablesExtension.java" ]
[]
diff --git a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcVariablesExtension.java b/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcVariablesExtension.java index 969e419e418ed1..160ca6939a6aac 100644 --- a/src/main/java/com/google/devtools/build/lib/rules/objc/ObjcVariablesExtension.java +++ b/...
null
val
val
2020-10-29T01:52:17
2020-04-24T23:29:04Z
keith
test
provectus/kafka-ui/21_23
provectus/kafka-ui
provectus/kafka-ui/21
provectus/kafka-ui/23
[ "timestamp(timedelta=0.0, similarity=0.8520123272679944)", "connected" ]
c26edd1316e7878376d60223206ecb767240f6d7
bdea7099cbc16a56fda4cf62960f77f9be75a33b
[]
[]
2020-04-09T14:20:23Z
[ "scope/frontend" ]
customizable: Time to retain data
Field Time to retain data in topic creation should be customizable. Now it's only allow to choose from enum
[ "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/New/New.tsx", "kafka-ui-react-app/src/lib/constants.ts" ]
[ "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/New/New.tsx", "kafka-ui-react-app/src/components/Topics/New/TimeToRetain.tsx", "kafka-ui-react-app/src/lib/constants.ts" ]
[]
diff --git a/kafka-ui-react-app/package-lock.json b/kafka-ui-react-app/package-lock.json index 4a2ad5ff718..1ba845e9bae 100644 --- a/kafka-ui-react-app/package-lock.json +++ b/kafka-ui-react-app/package-lock.json @@ -10478,6 +10478,11 @@ "json-parse-better-errors": "^1.0.1" } }, + "parse-ms": { ...
null
val
train
2020-04-07T10:15:48
2020-04-09T11:27:18Z
germanosin
train
provectus/kafka-ui/24_26
provectus/kafka-ui
provectus/kafka-ui/24
provectus/kafka-ui/26
[ "timestamp(timedelta=1.0, similarity=0.8749427837031752)", "connected" ]
ea9426e8dd817e8a667679d9f2a17a738c4b2a42
e2918b41ca928283339f256e552b0643e501bc92
[]
[ "```suggestion\r\n \"pre-commit\": \"yarn tsc --noEmit && lint-staged\"\r\n```", "For preventing of commit uncompilable ts code.", "Is it really need?", "my bad, when I was reinstalling husky looks like it overwrote the pre-commit hook", "@workshur @Gataniel What do you think about switch on that rule...
2020-04-10T13:54:28Z
[ "type/enhancement", "scope/frontend" ]
Add ESlint
Please add ESlint with strict config. Ask @aMoRRoMa about best config
[ "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParamValue.tsx" ]
[ "kafka-ui-react-app/.editorconfig", "kafka-ui-react-app/.eslintrc.json", "kafka-ui-react-app/.prettierrc", "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParamValue.tsx" ]
[]
diff --git a/kafka-ui-react-app/.editorconfig b/kafka-ui-react-app/.editorconfig new file mode 100644 index 00000000000..11695dbd4ce --- /dev/null +++ b/kafka-ui-react-app/.editorconfig @@ -0,0 +1,9 @@ +root = true + +[*] +end_of_line = lf +indent_style = space +indent_size = 2 +charset = utf-8 +trim_trailing_whitespac...
null
val
train
2020-04-13T11:20:44
2020-04-09T15:42:00Z
workshur
train
provectus/kafka-ui/14_27
provectus/kafka-ui
provectus/kafka-ui/14
provectus/kafka-ui/27
[ "connected" ]
e2918b41ca928283339f256e552b0643e501bc92
ef1edba34b242051206e7ae5cf7d1a03d6cc2cae
[]
[]
2020-04-13T10:03:55Z
[ "scope/frontend" ]
Add custom parameters to topic creation form
### AC The user is able to: - add multiple custom parameters to topic creation form - select available custom topic parameter from list - update value of added parameter - remove added parameter - review validation error & update custom params <img width="546" alt="Screenshot 2020-02-27 22 37 49" src="https:/...
[ "kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParams.tsx", "kafka-ui-react-app/src/redux/api/topics.ts" ]
[ "kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParams.tsx", "kafka-ui-react-app/src/redux/api/topics.ts" ]
[]
diff --git a/kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParams.tsx b/kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParams.tsx index 8fe22db0368..64bb6866052 100644 --- a/kafka-ui-react-app/src/components/Topics/New/CustomParams/CustomParams.tsx +++ b/kafka-ui-react-app/src/compone...
null
test
train
2020-04-14T14:36:05
2020-02-27T19:41:22Z
workshur
train
provectus/kafka-ui/128_129
provectus/kafka-ui
provectus/kafka-ui/128
provectus/kafka-ui/129
[ "timestamp(timedelta=1.0, similarity=0.8466043474292333)", "connected" ]
3c4ccf9eb42a7380f0827e0a228e193cf397b047
4ec04223574e967d3f012652a0cceaa5605a8bab
[]
[ "I would suggest to add multiline attr instead\r\n```suggestion\r\n multiline?: boolean;\r\n```\r\nor \r\n```suggestion\r\n levelClassName?: 'level-multiline';\r\n```", "Done👌 " ]
2020-11-25T23:31:08Z
[ "type/enhancement", "scope/frontend" ]
Brokers, Topic Overview: Show space usage
[ "kafka-ui-react-app/src/components/Brokers/Brokers.tsx", "kafka-ui-react-app/src/components/Brokers/BrokersContainer.ts", "kafka-ui-react-app/src/components/Topics/Details/Overview/Overview.tsx", "kafka-ui-react-app/src/components/common/Dashboard/Indicator.tsx", "kafka-ui-react-app/src/components/common/Da...
[ "kafka-ui-react-app/src/components/Brokers/Brokers.tsx", "kafka-ui-react-app/src/components/Brokers/BrokersContainer.ts", "kafka-ui-react-app/src/components/Topics/Details/Overview/Overview.tsx", "kafka-ui-react-app/src/components/common/BytesFormatted/BytesFormatted.tsx", "kafka-ui-react-app/src/components...
[]
diff --git a/kafka-ui-react-app/src/components/Brokers/Brokers.tsx b/kafka-ui-react-app/src/components/Brokers/Brokers.tsx index 4b8eb4683e4..e84cfdbf36f 100644 --- a/kafka-ui-react-app/src/components/Brokers/Brokers.tsx +++ b/kafka-ui-react-app/src/components/Brokers/Brokers.tsx @@ -6,6 +6,7 @@ import cx from 'classna...
null
train
train
2020-11-24T11:25:15
2020-11-25T23:29:59Z
soffest
train
provectus/kafka-ui/149_150
provectus/kafka-ui
provectus/kafka-ui/149
provectus/kafka-ui/150
[ "connected" ]
4bd5f7d9da21e0dad4b86d7c94a63dfb0a181e02
fbc2ab306e451758e466487f21235207ea8c37b7
[]
[ "It's not a good idea to put it here. I think we can run it separate if needed " ]
2020-12-25T14:06:57Z
[]
Consumer groups screen (ui/clusters/xxx/consumer-groups) stays empty
running as container on K8s version 0.0.8 JS stack trace: ``` react-dom.production.min.js:216 TypeError: Cannot read property 'consumerGroupId' of undefined at List.tsx:56 at Array.map (<anonymous>) at ar (List.tsx:54) at oi (react-dom.production.min.js:157) at qu (react-dom.production.min...
[ "kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts" ]
[ "kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts" ]
[]
diff --git a/kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts b/kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts index 7973d600b72..6776dbcc586 100644 --- a/kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts +++ b/kafka-ui-react-app/src/redux/reducers/consumerGroups/reducer.ts...
null
train
train
2020-12-15T13:26:37
2020-12-24T13:23:28Z
christophfroeschl
train
provectus/kafka-ui/138_159
provectus/kafka-ui
provectus/kafka-ui/138
provectus/kafka-ui/159
[ "connected" ]
c27dfb8ff9c91e5e2f94268a86f259d650be9974
9f3ae3a6146f3f77ba088a18d6c7b334e8f88ac6
[]
[ "Please remove these extra spaces.", "I'm not sure we need to update pom files manually. @soffest could you please take a look?" ]
2021-01-19T14:29:17Z
[ "good first issue", "scope/frontend" ]
Update node version of react app to the latest LTS version (v14)
- Add engine filed to package.json https://docs.npmjs.com/cli/v6/configuring-npm/package-json#engines - update .nvmrc - update pom.xml
[ "kafka-ui-react-app/.nvmrc", "kafka-ui-react-app/package.json", "pom.xml" ]
[ "kafka-ui-react-app/.nvmrc", "kafka-ui-react-app/package.json", "pom.xml" ]
[]
diff --git a/kafka-ui-react-app/.nvmrc b/kafka-ui-react-app/.nvmrc index 28193ca74f5..9a0c3d3f455 100644 --- a/kafka-ui-react-app/.nvmrc +++ b/kafka-ui-react-app/.nvmrc @@ -1,1 +1,1 @@ -v12.13.1 +v14.15.4 diff --git a/kafka-ui-react-app/package.json b/kafka-ui-react-app/package.json index bd301d8f2d9..417cf021764 10064...
null
val
train
2021-01-20T12:38:05
2020-12-07T11:59:36Z
workshur
train
provectus/kafka-ui/132_160
provectus/kafka-ui
provectus/kafka-ui/132
provectus/kafka-ui/160
[ "connected" ]
9f3ae3a6146f3f77ba088a18d6c7b334e8f88ac6
3c843e1266981a7ff0e21a3adad823f7d578a18c
[]
[ "@Guzel738 Can you disable `no-console` rule for the whole file instead commenting single lines?", "There is no need to disable `no-console` rule for the whole project. We can disable it for `serviceWorker.ts` file.", "@Guzel738 Could you please remove `no-console` rule from this config?\r\n```suggestion\r\n\r\...
2021-01-20T12:38:54Z
[ "good first issue", "scope/frontend" ]
Get rid of all unexpected "any" types.
1. Run `npm run lint` from `/kafka-ui-react-app` 2. Specify a correct type instead of `any` for all cases from the list ``` src/components/Topics/Details/Messages/Messages.tsx Line 41:29: Unexpected any. Specify a different type @typescript-eslint/no-explicit-any Line 76:13: Unexpected any. Specify a di...
[ "kafka-ui-react-app/.eslintrc.json", "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/redux/store/configureStore/dev.ts", "kafka-ui-react-app/src/serviceWorker.ts" ]
[ "kafka-ui-react-app/.eslintrc.json", "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/redux/store/configureStore/dev.ts", "kafka-ui-react-app/src/serviceWorker.ts" ]
[]
diff --git a/kafka-ui-react-app/.eslintrc.json b/kafka-ui-react-app/.eslintrc.json index 6ffce16d636..b35f0e2732f 100644 --- a/kafka-ui-react-app/.eslintrc.json +++ b/kafka-ui-react-app/.eslintrc.json @@ -28,7 +28,8 @@ "prettier/prettier": "error", "@typescript-eslint/explicit-module-boundary-types": "off", ...
null
test
train
2021-01-26T10:45:03
2020-12-02T13:56:21Z
workshur
train
provectus/kafka-ui/154_167
provectus/kafka-ui
provectus/kafka-ui/154
provectus/kafka-ui/167
[ "connected" ]
1d60db44df81ed0a1c8a935f49bdbe4c7ad4ead6
cc097e9327c8253699c31dd47cdf2ae5ff3fcada
[]
[ "This should read like a sentence. `It renders PageLoader`\r\n```suggestion\r\n it('renders PageLoader', () => {\r\n```", "The structure of test in general should be:\r\n```\r\ndescribe Messages Component\r\n- describe Initial State\r\n - it. renders loader \r\n- describe MessageTable\r\n - describe with mes...
2021-02-01T08:33:00Z
[ "scope/frontend" ]
Configure project to support tests
For better stability of the project, we need to write tests. The first step is to add support for them in the project. 1. Add the required packages: `jest` and any react support library `enzyme` or `react-test-renderer` 2. Configure them 3. Cover one component with tests 4. Add integration to the git hooks
[ "kafka-ui-react-app/.eslintrc.json", "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/setupTests.ts" ]
[ "kafka-ui-react-app/.eslintrc.json", "kafka-ui-react-app/jest.config.js", "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/setupTests.ts" ]
[ "kafka-ui-react-app/src/tests/Topics/Details/Messages/Messages.spec.tsx" ]
diff --git a/kafka-ui-react-app/.eslintrc.json b/kafka-ui-react-app/.eslintrc.json index b35f0e2732f..abde6f187d3 100644 --- a/kafka-ui-react-app/.eslintrc.json +++ b/kafka-ui-react-app/.eslintrc.json @@ -1,7 +1,8 @@ { "env": { "browser": true, - "es6": true + "es6": true, + "jest": true }, "glo...
diff --git a/kafka-ui-react-app/src/tests/Topics/Details/Messages/Messages.spec.tsx b/kafka-ui-react-app/src/tests/Topics/Details/Messages/Messages.spec.tsx new file mode 100644 index 00000000000..76c09cc51d8 --- /dev/null +++ b/kafka-ui-react-app/src/tests/Topics/Details/Messages/Messages.spec.tsx @@ -0,0 +1,156 @@ +i...
val
train
2021-01-29T13:24:59
2021-01-13T09:09:43Z
whotake
train
provectus/kafka-ui/141_174
provectus/kafka-ui
provectus/kafka-ui/141
provectus/kafka-ui/174
[ "timestamp(timedelta=0.0, similarity=0.8420617960466731)", "connected" ]
cc097e9327c8253699c31dd47cdf2ae5ff3fcada
10a27ba60eb4c2c9569eaec253bb219869bd0ba5
[]
[ "1. Use {}\r\n2. This condition looks wrong. It was\r\n```\r\n{message.content && getMessageContentBody(message.content as Record<string, unknown>)}\r\n```\r\nyou did it \r\n```\r\n{content ? <> : content}\r\n```", "I would suggest moving it out of the component. It could be a separate `util` file in case it coul...
2021-02-02T09:22:26Z
[ "good first issue", "scope/frontend" ]
Topic messages: Decompose component
Messages component is too big, overcomplicated and is hard to read, so it should be decomposed and refactored. `kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx`
[ "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/redux/reducers/topics/reducer.ts" ]
[ "kafka-ui-react-app/src/components/Topics/Details/Messages/MessageItem.tsx", "kafka-ui-react-app/src/components/Topics/Details/Messages/Messages.tsx", "kafka-ui-react-app/src/components/Topics/Details/Messages/MessagesTable.tsx", "kafka-ui-react-app/src/redux/reducers/topics/reducer.ts" ]
[]
diff --git a/kafka-ui-react-app/src/components/Topics/Details/Messages/MessageItem.tsx b/kafka-ui-react-app/src/components/Topics/Details/Messages/MessageItem.tsx new file mode 100644 index 00000000000..e168ef042a4 --- /dev/null +++ b/kafka-ui-react-app/src/components/Topics/Details/Messages/MessageItem.tsx @@ -0,0 +1,...
null
train
train
2021-02-04T09:04:21
2020-12-15T12:32:16Z
soffest
train
provectus/kafka-ui/166_178
provectus/kafka-ui
provectus/kafka-ui/166
provectus/kafka-ui/178
[ "connected" ]
c49006d2c1cf25bc4680abf9b824156ffb139ab8
ba4e1748ee092d31a4596131dcd2f16bffbb8e93
[ "Thank your for your issue, We'll try to fix it soon." ]
[]
2021-02-10T08:05:10Z
[ "type/bug", "scope/backend" ]
Protobuf not working
Hi, Really interesting project :wink: #116 seems to add protobuf supports but when I try to read message serialized with protobuf I get this error message: ``` ERROR io.confluent.kafka.schemaregistry.client.CachedSchemaRegistryClient - Invalid schema type PROTOBUF ``` Full stacktrace: ``` 11:38:45.932 [...
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java" ]
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java" ]
[]
diff --git a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java index a64aded30a7..00544a109dc 100644 --- a/kafka-ui-api/src/main/java/com/provec...
null
train
train
2021-02-09T09:30:30
2021-01-29T11:45:08Z
gaetancollaud
train
provectus/kafka-ui/180_185
provectus/kafka-ui
provectus/kafka-ui/180
provectus/kafka-ui/185
[ "timestamp(timedelta=0.0, similarity=0.8949657276459652)", "connected" ]
40d85643bb1a5ec69cd364ac30aee58cef04c289
b9e92114e603c77874a41037c94b2f4e86d6fad5
[ "@imoisey thank you for your issue. This bug will be fixed soon by https://github.com/provectus/kafka-ui/pull/185", "Thanks" ]
[ "Let's pass a zookeeper connection timeout from the Java class/app properties\r\n" ]
2021-02-10T19:25:58Z
[ "type/bug", "scope/backend" ]
Too many connections to Zookeeper
I have a problem with many connections to Zookeeper from kafka-ui. Zookeeper logs: ![image](https://user-images.githubusercontent.com/2510489/107490229-aa3a1180-6b9a-11eb-9994-55bc960908c3.png) docker-compose.yml Kafka UI: ![image](https://user-images.githubusercontent.com/2510489/107490589-22083c00-6b9b-1...
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/SchemaRegistryService.java", "kafka-ui-api/src/main/java/com/provectus/kafka/ui/zookeeper/ZookeeperService.java" ]
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/SchemaRegistryService.java", "kafka-ui-api/src/main/java/com/provectus/kafka/ui/zookeeper/ZookeeperService.java" ]
[]
diff --git a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/SchemaRegistryService.java b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/SchemaRegistryService.java index 609edb27634..b67ce348d36 100644 --- a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/service/SchemaReg...
null
test
train
2021-02-10T10:12:59
2021-02-10T09:29:40Z
imoisey
train
provectus/kafka-ui/191_201
provectus/kafka-ui
provectus/kafka-ui/191
provectus/kafka-ui/201
[ "connected" ]
78a971193b8804fda050c932a8e289b3ba2a9138
b4a243f47000463f664b5ee1f7c0291f5241541a
[]
[]
2021-02-17T15:01:59Z
[ "type/bug", "scope/frontend" ]
UI : wrong links
On the dashboard view When clicking on a cluster property (like brokers, topics...), this will always redirect to "brokers" page of this cluster It could be better to redirect to the proper page when available. Version used: 0.0.9 ![image](https://user-images.githubusercontent.com/29728596/107579729-df278200-...
[ "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Dashboard/ClustersWidget/ClusterWidget.tsx", "kafka-ui-react-app/src/components/common/BytesFormatted/BytesFormatted.tsx", "kafka-ui-react-app/src/lib/utils/formatBytes.ts", "kafka-ui-react-app/sr...
[ "kafka-ui-react-app/package-lock.json", "kafka-ui-react-app/package.json", "kafka-ui-react-app/src/components/Dashboard/ClustersWidget/ClusterWidget.tsx", "kafka-ui-react-app/src/components/Dashboard/ClustersWidget/__test__/ClusterWidget.spec.tsx", "kafka-ui-react-app/src/components/Dashboard/ClustersWidget...
[]
diff --git a/kafka-ui-react-app/package-lock.json b/kafka-ui-react-app/package-lock.json index 06510c1fe53..8f40ba383be 100644 --- a/kafka-ui-react-app/package-lock.json +++ b/kafka-ui-react-app/package-lock.json @@ -4962,9 +4962,9 @@ "dev": true }, "bulma": { - "version": "0.8.2", - "resolve...
null
train
train
2021-02-17T10:03:18
2021-02-10T22:15:35Z
giom-l
train
provectus/kafka-ui/222_223
provectus/kafka-ui
provectus/kafka-ui/222
provectus/kafka-ui/223
[ "keyword_pr_to_issue" ]
be96bbc3813977ef6f6e20628b92c3a33c748c15
58df6c1a7ee5eda3dacc69832395445fd9c9a26f
[]
[]
2021-03-03T11:10:11Z
[ "type/bug", "scope/backend" ]
Error while trying to read messages from _schemas topic
Kafka UI seems to be unable to read messages from SchemaRegistry's _schemas topic. ### How to recreate the issue 1) Run docker-compose file (with kafka-ui) from master branch (current commit is 73f8991) 2) Go to the cluster "local" -> Topics -> _schemas -> Messages ### Expected behaviour: Messages' content and m...
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java" ]
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java" ]
[ "kafka-ui-api/src/test/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializerTest.java" ]
diff --git a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializer.java index 00544a109dc..a9e3887dbbf 100644 --- a/kafka-ui-api/src/main/java/com/provec...
diff --git a/kafka-ui-api/src/test/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializerTest.java b/kafka-ui-api/src/test/java/com/provectus/kafka/ui/cluster/deserialization/SchemaRegistryRecordDeserializerTest.java new file mode 100644 index 00000000000..3dbc716b21c --- /dev/null +++ b/k...
train
train
2021-03-03T11:08:51
2021-03-01T20:15:20Z
DementevNikita
train
provectus/kafka-ui/212_225
provectus/kafka-ui
provectus/kafka-ui/212
provectus/kafka-ui/225
[ "timestamp(timedelta=0.0, similarity=0.9108878573288014)", "connected" ]
a9cb9567d6a7b3599512605cac709f1495cba0a2
1a215865ef3b4332a4594decc959e579b4096ace
[]
[ "I would suggest to just check that last Li contains `child`", "Please add specs to test updated code", "I would also suggest to wrap all this code into `try catch`", "Please add examples with incorrect input props", "I think that adding a snapshot will allow you to cover the part of the code that you are t...
2021-03-03T18:16:09Z
[ "good first issue", "scope/frontend" ]
Cover common components with tests
As an engineer using kafka-ui in production, I would like to have 100% test coverage. Please add specs to all common components (src/components/common)
[ "kafka-ui-react-app/src/components/common/Breadcrumb/Breadcrumb.tsx", "kafka-ui-react-app/src/components/common/BytesFormatted/BytesFormatted.tsx" ]
[ "kafka-ui-react-app/src/components/common/Breadcrumb/Breadcrumb.tsx", "kafka-ui-react-app/src/components/common/Breadcrumb/__tests__/Breadcrumb.spec.tsx", "kafka-ui-react-app/src/components/common/Breadcrumb/__tests__/__snapshots__/Breadcrumb.spec.tsx.snap", "kafka-ui-react-app/src/components/common/BytesForm...
[]
diff --git a/kafka-ui-react-app/src/components/common/Breadcrumb/Breadcrumb.tsx b/kafka-ui-react-app/src/components/common/Breadcrumb/Breadcrumb.tsx index b3b7a2c5c08..2e93e2a6855 100644 --- a/kafka-ui-react-app/src/components/common/Breadcrumb/Breadcrumb.tsx +++ b/kafka-ui-react-app/src/components/common/Breadcrumb/Br...
null
val
train
2021-03-04T15:51:18
2021-02-28T20:27:18Z
workshur
train
provectus/kafka-ui/197_226
provectus/kafka-ui
provectus/kafka-ui/197
provectus/kafka-ui/226
[ "keyword_pr_to_issue", "timestamp(timedelta=0.0, similarity=0.856367744457547)" ]
36a5bbf9b11058112e91cc352eb6e37aed8a38d6
e29ea3599d952b682abc2c36fc7ce3468f6647b5
[]
[]
2021-03-04T06:20:38Z
[]
Upgrade confluent platform from `5.1.0` to at least `5.2.x`
[ "docker/kafka-clusters-only.yaml", "docker/kafka-ui.yaml", "kafka-ui-api/src/main/resources/application-local.yml" ]
[ "docker/kafka-clusters-only.yaml", "docker/kafka-ui.yaml", "kafka-ui-api/src/main/resources/application-local.yml" ]
[]
diff --git a/docker/kafka-clusters-only.yaml b/docker/kafka-clusters-only.yaml index 6911054ceb7..16cb50b6596 100644 --- a/docker/kafka-clusters-only.yaml +++ b/docker/kafka-clusters-only.yaml @@ -3,7 +3,7 @@ version: '2' services: zookeeper0: - image: confluentinc/cp-zookeeper:5.1.0 + image: confluentinc/c...
null
train
train
2021-03-03T18:56:28
2021-02-12T11:32:01Z
RamazanYapparov
train
provectus/kafka-ui/168_227
provectus/kafka-ui
provectus/kafka-ui/168
provectus/kafka-ui/227
[ "keyword_pr_to_issue" ]
36a5bbf9b11058112e91cc352eb6e37aed8a38d6
ae1acbce9b33dbb7bd25e72b924b14aebab2c77e
[ "Thank you for your issue. Will try to fix it soon. ", "@andormarkus Kafka UI uses internal cache for rest requests. By default it updates once in a 30 seconds. I just checked that new topic created outside of Kafka UI successfully appeared in 30 seconds. Could you please verify that this was an issue for you? "...
[]
2021-03-04T07:59:28Z
[ "type/bug", "scope/backend" ]
bug: External topics not refreshed on page reload
Hi Team, We are configuring our topic with Terraform or Kafka CLI therefore these topic are "External" topic. I have deleted topic "navisioncompany" and created new topic "navision.Company". This new topic show up in Kafka client without error. However these changes are not picked up by Kafka UI. To track these ...
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java" ]
[ "kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java" ]
[]
diff --git a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java b/kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java index 82ff081ada0..d26afd07ebf 100644 --- a/kafka-ui-api/src/main/java/com/provectus/kafka/ui/kafka/KafkaService.java +++ b/kafka-ui-api/src/main/java/com/pr...
null
train
train
2021-03-03T18:56:28
2021-02-01T10:12:27Z
andormarkus
train
provectus/kafka-ui/143_233
provectus/kafka-ui
provectus/kafka-ui/143
provectus/kafka-ui/233
[ "keyword_pr_to_issue", "timestamp(timedelta=0.0, similarity=0.8893082753952145)" ]
c00f21a3baef790f8b4272486269cee278e285eb
f3535d94ff840f00210a30550b4d0bd772330e0d
[]
[]
2021-03-09T14:12:38Z
[ "type/documentation", "good first issue" ]
Add Contributing Guide
[]
[ "CODE-OF-CONDUCT.md", "CONTRIBUTING.md" ]
[]
diff --git a/CODE-OF-CONDUCT.md b/CODE-OF-CONDUCT.md new file mode 100644 index 00000000000..3c2882277ce --- /dev/null +++ b/CODE-OF-CONDUCT.md @@ -0,0 +1,132 @@ + +# Contributor Covenant Code of Conduct + +## Our Pledge + +We as members, contributors, and leaders pledge to make participation in our +community a harass...
null
val
train
2021-03-09T15:06:32
2020-12-17T10:17:30Z
Evanto
train
provectus/kafka-ui/142_233
provectus/kafka-ui
provectus/kafka-ui/142
provectus/kafka-ui/233
[ "keyword_pr_to_issue" ]
c00f21a3baef790f8b4272486269cee278e285eb
f3535d94ff840f00210a30550b4d0bd772330e0d
[]
[]
2021-03-09T14:12:38Z
[ "type/documentation", "good first issue" ]
Add CoC (Code of Conduct)
[]
[ "CODE-OF-CONDUCT.md", "CONTRIBUTING.md" ]
[]
diff --git a/CODE-OF-CONDUCT.md b/CODE-OF-CONDUCT.md new file mode 100644 index 00000000000..3c2882277ce --- /dev/null +++ b/CODE-OF-CONDUCT.md @@ -0,0 +1,132 @@ + +# Contributor Covenant Code of Conduct + +## Our Pledge + +We as members, contributors, and leaders pledge to make participation in our +community a harass...
null
train
train
2021-03-09T15:06:32
2020-12-17T10:16:47Z
Evanto
train