instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
iluwatar/java-design-patterns/955_959 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/955 | iluwatar/java-design-patterns/959 | [
"timestamp(timedelta=143575.0, similarity=0.8550195875763785)"
] | 90ea4506caa653711f69fabb99ee7ac26c4ecce7 | a6fdcd4a34802deb13e9301ec15089fb3f430b28 | [
"Currently all the patterns belong to the unnamed module since they have not been modularized. The next step would be to add `module-info.java` to each of the patterns to make them real modules."
] | [] | 2019-10-06T09:25:19Z | [
"info: help wanted",
"type: support",
"epic: design"
] | Java 11 support: Modules | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Java 9 introduces the Java Platform Module System. How should it be utilized in this project? In this task we create a plan what kind of modules are going to be created. Would it be possible ... | [
".travis.yml",
"exclude-pmd.properties",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml"
] | [
".travis.yml",
"exclude-pmd.properties",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 58edddeb416e..474732c166b3 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,7 @@
language: java
dist: trusty # Xenial build environment won't allow installation of Java 8
jdk:
-- oraclejdk8
+- openjdk11
env:
global:
@@ -21,12 +21,6 @@ after_success:
- mvn cl... | null | test | train | 2019-10-08T17:29:59 | 2019-10-05T15:31:30Z | iluwatar | train |
iluwatar/java-design-patterns/933_960 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/933 | iluwatar/java-design-patterns/960 | [
"keyword_pr_to_issue",
"timestamp(timedelta=188.0, similarity=0.9065034689810998)"
] | 94ca25462667b15d2d4f7d5120c94a0733f53bf7 | 84c4b034a9f282a0d8739ef7bd4cd83813a7c454 | [
"HI @iluwatar \r\nI would like to take this up",
"Ok @hbothra15 ",
"is this still work in progress or shall i pick up ? @hbothra15 @iluwatar ",
"Ping @hbothra15 ",
"@iluwatar Want to take this issue. Is there anything else we need to do apart from upgrading the concerned dependencies?",
"@gaurav9822 updat... | [
"What if the `topping` is not present? We should handle also the error case. Maybe throw the `CakeBakingException`?",
"`findById` returns an `Optional`, probably we don't want to log that but its contents",
"Returns an `Optional`.."
] | 2019-10-06T10:40:17Z | [
"type: bug",
"info: good first issue",
"epic: build issue"
] | Github reports security vulnerabilities | 
| [
"layers/pom.xml",
"layers/src/main/java/com/iluwatar/layers/CakeBakingServiceImpl.java",
"layers/src/main/resources/applicationContext.xml",
"pom.xml",
"repository/pom.xml",
"repository/src/main/java/com/iluwatar/repository/App.java",
"repository/src/main/java/com/iluwatar/repository/AppConfig.java",
... | [
"layers/pom.xml",
"layers/src/main/java/com/iluwatar/layers/CakeBakingServiceImpl.java",
"layers/src/main/resources/applicationContext.xml",
"pom.xml",
"repository/pom.xml",
"repository/src/main/java/com/iluwatar/repository/App.java",
"repository/src/main/java/com/iluwatar/repository/AppConfig.java",
... | [
"eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/AggregatorRouteTest.java",
"eip-splitter/src/test/java/com/iluwatar/eip/splitter/routes/SplitterRouteTest.java",
"eip-wire-tap/src/test/java/com/iluwatar/eip/wiretap/routes/WireTapRouteTest.java",
"repository/src/test/java/com/iluwatar/repositor... | diff --git a/layers/pom.xml b/layers/pom.xml
index 8237c8f4f6e0..a6d3d17199f6 100644
--- a/layers/pom.xml
+++ b/layers/pom.xml
@@ -41,7 +41,11 @@
</dependency>
<dependency>
<groupId>org.hibernate</groupId>
- <artifactId>hibernate-entitymanager</artifactId>
+ <artifactId>hibernate-core</artifactId>
+ </d... | diff --git a/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/AggregatorRouteTest.java b/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/AggregatorRouteTest.java
index 2c7d207d6f53..2b831e01958b 100644
--- a/eip-aggregator/src/test/java/com/iluwatar/eip/aggregator/routes/AggregatorRouteTe... | test | train | 2019-10-06T18:06:39 | 2019-09-30T15:44:26Z | iluwatar | train |
iluwatar/java-design-patterns/496_967 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/496 | iluwatar/java-design-patterns/967 | [
"timestamp(timedelta=100.0, similarity=0.8719039795684427)"
] | 94ca25462667b15d2d4f7d5120c94a0733f53bf7 | f903d7e9a9379c79742ecc61a3901bdbe2a0a318 | [
"Working on it\n",
"Ok @ghost-60 \n",
"@ghost-60 are you still working on this?",
"Sorry.... not yet\n\nOn Feb 12, 2017 05:02, \"Ilkka Seppälä\" <notifications@github.com> wrote:\n\n> @ghost-60 <https://github.com/ghost-60> are you still working on this?\n>\n> —\n> You are receiving this because you were ment... | [
"We can leave this chapter if there are no aliases",
"We can link to https://java-design-patterns.com/principles/#single-responsibility-principle"
] | 2019-10-06T17:12:55Z | [
"epic: pattern"
] | Pipeline pattern | https://msdn.microsoft.com/en-us/library/ff963548.aspx
| [
"pom.xml"
] | [
"pipeline/README.md",
"pipeline/pom.xml",
"pipeline/src/main/java/com.iluwatar.pipeline/App.java",
"pipeline/src/main/java/com.iluwatar.pipeline/ConvertToCharArrayHandler.java",
"pipeline/src/main/java/com.iluwatar.pipeline/Handler.java",
"pipeline/src/main/java/com.iluwatar.pipeline/Pipeline.java",
"pi... | [
"pipeline/src/test/java/com.iluwatar.pipeline/AppTest.java",
"pipeline/src/test/java/com.iluwatar.pipeline/PipelineTest.java"
] | diff --git a/pipeline/README.md b/pipeline/README.md
new file mode 100644
index 000000000000..e990affd62c7
--- /dev/null
+++ b/pipeline/README.md
@@ -0,0 +1,37 @@
+---
+layout: pattern
+title: Pipeline
+folder: pipeline
+permalink: /patterns/pipeline/
+categories: Behavioral
+tags:
+ - Java
+ - Functional
+ - Difficult... | diff --git a/pipeline/src/test/java/com.iluwatar.pipeline/AppTest.java b/pipeline/src/test/java/com.iluwatar.pipeline/AppTest.java
new file mode 100644
index 000000000000..79524575c13c
--- /dev/null
+++ b/pipeline/src/test/java/com.iluwatar.pipeline/AppTest.java
@@ -0,0 +1,37 @@
+/**
+ * The MIT License
+ * Copyright (... | test | train | 2019-10-06T18:06:39 | 2016-09-25T19:20:32Z | iluwatar | train |
iluwatar/java-design-patterns/838_968 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/838 | iluwatar/java-design-patterns/968 | [
"keyword_pr_to_issue"
] | 94ca25462667b15d2d4f7d5120c94a0733f53bf7 | f5455f9887f2613ef2b8ca16eb594d6a962196d8 | [
"I would like to try my hand at resolving this issue",
"Ok @Kevinyl3, the issue is yours",
"I have checked through all the dependencies in all the pom.xml's\r\n\r\n- logback-classic: This dependency is already at version 1.2.3 \r\n- slf4j-api: This dependency is already at version 1.7.30\r\n- httpclient: I cann... | [] | 2019-10-07T02:05:13Z | [
"type: bug",
"epic: build issue"
] | Buggy dependencies | Hi, there!
We are a research team working on third-party library analysis. We have found that some widely-used third-party libraries in your project have major/critical bugs, which will degrade the quality of your project. We highly recommend you to update those libraries to new versions.
We have attached the buggy t... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index acaaef6181c5..539da396b2d8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -43,12 +43,12 @@
<camel.version>2.16.1</camel.version>
<guava.version>19.0</guava.version>
<mockito.version>1.10.19</mockito.version>
- <apache-httpcomponents.version>4.5.2</apache-htt... | null | test | train | 2019-10-06T18:06:39 | 2019-01-13T18:03:43Z | iluwatar | train |
iluwatar/java-design-patterns/549_971 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/549 | iluwatar/java-design-patterns/971 | [
"keyword_pr_to_issue"
] | 55b0341c8dc28ab84412d535bee9ecbb461fa081 | 1d4a7681e2d8699457c557fbab3d69d5f8aa105b | [
"Can't we consider \r\n\r\n` try (CloseableHttpClient httpClient = HttpClients.createDefault()) {\r\n HttpGet httpGet = new HttpGet(\"http://localhost:51515/information\");\r\n try (CloseableHttpResponse httpResponse = httpClient.execute(httpGet)) {\r\n response = EntityUtils.toString(httpRespon... | [
"`ProductInventoryClientImpl` does not return null but 0 when exception occurs. Perhaps returning null would be the correct way, so the change should be implemented in the client.."
] | 2019-10-07T20:35:04Z | [
"type: enhancement",
"info: good first issue",
"epic: code quality"
] | "Aggregator microservices" design pattern doesn't show exception handling | "Aggregator microservices" design pattern doesn't show how exception handling would be done if the one or multiple services used are down and how client calling the aggregator microservice would cope in this situation. | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClient.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwata... | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClient.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwata... | [] | diff --git a/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java b/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java
index e96ac9d43c2c..dbed50fc6610 100644
--- a/aggregator-microservices/aggregator... | null | train | train | 2019-10-31T19:01:39 | 2017-03-26T17:51:56Z | neerajmahajan | train |
iluwatar/java-design-patterns/973_975 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/973 | iluwatar/java-design-patterns/975 | [
"timestamp(timedelta=7881.0, similarity=0.869720833449218)"
] | 71f26c3e59f45d0e62b7137a75705a522d43cdec | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | [
"Can I try this out?",
"Go ahead @JasonSarwar ",
"See `.travis.yml` in https://github.com/iluwatar/java-design-patterns/pull/959",
"Set Travis to build on both openjdk8 and openjdk 11 in commits https://github.com/iluwatar/java-design-patterns/commit/795b6be17d270e93ccfc871fa4976f052c33a181 and https://github... | [] | 2019-10-10T12:57:41Z | [
"info: good first issue",
"epic: build issue"
] | Java 11 support: Update Travis to build on JDK 11 | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
The purpose is to update the Travis CI build to use JDK 11, instead of the old JDK 8. | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml",
"trampoline/pom.xml"
] | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/exclude-pmd.properties",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index beb195473ced..fc89a93b7c79 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@@ -39,4 +39,25 @@
<artifactId>hibernate-core</artifactId>
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>jdk11-deps</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activati... | null | train | train | 2019-10-11T18:37:28 | 2019-10-08T15:06:02Z | iluwatar | train |
iluwatar/java-design-patterns/948_975 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/948 | iluwatar/java-design-patterns/975 | [
"timestamp(timedelta=83635.0, similarity=0.8724987719835455)"
] | 71f26c3e59f45d0e62b7137a75705a522d43cdec | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | [
"Lets give it a try..",
"Ok @perwramdemark ",
"@iluwatar would it be possible to setup CI build with JDK11?",
"Added issue https://github.com/iluwatar/java-design-patterns/issues/973 where this is resolved",
"Build with JDK11 from current master branch (commit 90ea4506caa653711f69fabb99ee7ac26c4ecce7) produ... | [] | 2019-10-10T12:57:41Z | [
"epic: build issue"
] | Java 11 support: Run the build on JDK 11 | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
In this task we run the regular build entirely on the newer JDK 11 in a way that lets us gather all errors instead of stopping the build to the first failure (see https://blog.codefx.org/java... | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml",
"trampoline/pom.xml"
] | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/exclude-pmd.properties",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index beb195473ced..fc89a93b7c79 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@@ -39,4 +39,25 @@
<artifactId>hibernate-core</artifactId>
</dependency>
</dependencies>
+ <profiles>
+ <profile>
+ <id>jdk11-deps</id>
+ <activation>
+ <jdk>[11,)</jdk>
+ </activati... | null | train | train | 2019-10-11T18:37:28 | 2019-10-04T05:30:43Z | iluwatar | train |
iluwatar/java-design-patterns/977_979 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/977 | iluwatar/java-design-patterns/979 | [
"timestamp(timedelta=79.0, similarity=0.9455374395355424)"
] | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | fcc1c0a27cbf92f07d4a2d9164598c883da74416 | [
"Hello.\r\nCan I claim this? :)",
"Sure @Shumyk I'll assign it to you"
] | [] | 2019-10-11T19:30:07Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies"
] | Remove maven-pmd-plugin from project | We are using SonarCloud for static source code analysis so maven-pmd-plugin is included really for no particular reason. Let's remove it from the project. | [
"exclude-pmd.properties",
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/exclude-pmd.properties b/exclude-pmd.properties
deleted file mode 100644
index 5a4bb138834e..000000000000
--- a/exclude-pmd.properties
+++ /dev/null
@@ -1,27 +0,0 @@
-#
-# The MIT License
-# Copyright (c) 2014-2016 Ilkka Seppälä
-#
-# Permission is hereby granted, free of charge, to any person obtaining a ... | null | val | train | 2019-10-11T20:55:48 | 2019-10-11T17:24:02Z | iluwatar | train |
iluwatar/java-design-patterns/964_980 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/964 | iluwatar/java-design-patterns/980 | [
"timestamp(timedelta=37400.0, similarity=0.878957276479159)"
] | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | 6faec9901a2380800aa50af538c8669539997176 | [
"Also see if https://github.com/iluwatar/java-design-patterns/issues/838 can be closed after the dependency update",
"This issue can be closed as we are already JDK11 compliant"
] | [] | 2019-10-11T19:50:31Z | [
"info: help wanted",
"resolution: won't fix",
"epic: dependencies"
] | Java 11 support: Upgrade dependencies | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Upgrade project dependencies so that they support Java 11. Most of the dependencies can be found in main `pom.xml` dependencyManagement section.
Links:
https://www.infoq.com/articles/upgr... | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 84b031fadcc1..45323dcfd457 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,6 @@
language: java
dist: xenial
jdk:
-- openjdk8
- openjdk11
env:
diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index fc89a93b7c79..9c9458505aba 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@... | null | val | train | 2019-10-11T20:55:48 | 2019-10-06T16:22:26Z | iluwatar | train |
iluwatar/java-design-patterns/976_980 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/976 | iluwatar/java-design-patterns/980 | [
"timestamp(timedelta=887.0, similarity=0.8643342372704113)"
] | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | 6faec9901a2380800aa50af538c8669539997176 | [
"@lbroman @perwramdemark working on this?",
"PR #975 should take care of this. Building through the project now, will push the PR in a few minutes.",
"Sorry, wrong issue I was editing. Reopened.",
"In my PR #980 I have left language source and target at 8 for the naked-objects/dom module. This is because java... | [] | 2019-10-11T19:50:31Z | [
"epic: build issue",
"epic: dependencies"
] | Java 11 support: Build with JDK11 | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Configure Maven plugins to use Java 11 and verify that build works using JDK11 (see https://winterbe.com/posts/2018/08/29/migrate-maven-projects-to-java-11-jigsaw/ and https://www.baeldung.co... | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 84b031fadcc1..45323dcfd457 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,6 @@
language: java
dist: xenial
jdk:
-- openjdk8
- openjdk11
env:
diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index fc89a93b7c79..9c9458505aba 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@... | null | train | train | 2019-10-11T20:55:48 | 2019-10-10T19:50:26Z | iluwatar | train |
iluwatar/java-design-patterns/950_980 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/950 | iluwatar/java-design-patterns/980 | [
"timestamp(timedelta=90918.0, similarity=0.8647862011261235)"
] | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | 6faec9901a2380800aa50af538c8669539997176 | [
"E.g. `/usr/lib/jvm/java-11-openjdk-amd64/bin/jdeps -jdkinternals async-method-invocation/target/async-method-invocation-1.22.0-SNAPSHOT.jar`",
"Get the list of jars to be inspected\r\n`find -name \"*-1.22.0-SNAPSHOT.jar\" > list.txt`\r\n\r\nCheck the jars with the following scritpt\r\n```\r\n#!/bin/bash\r\n\r\ns... | [] | 2019-10-11T19:50:31Z | [
"epic: build issue"
] | Java 11 support: JDeps | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
There’s a tool, JDeps, that’s part of the JDK 11 that you can run with a flag of -jdkinternals to check to see if a set of classes is using something it shouldn’t. Run JDeps on the project an... | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 84b031fadcc1..45323dcfd457 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,6 @@
language: java
dist: xenial
jdk:
-- openjdk8
- openjdk11
env:
diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index fc89a93b7c79..9c9458505aba 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@... | null | test | train | 2019-10-11T20:55:48 | 2019-10-04T05:44:04Z | iluwatar | train |
iluwatar/java-design-patterns/949_980 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/949 | iluwatar/java-design-patterns/980 | [
"timestamp(timedelta=30765.0, similarity=0.870099769949494)"
] | e36bbbb22bad5e24c15ea2d185309033580f2ba8 | 6faec9901a2380800aa50af538c8669539997176 | [
"No need to do this anymore since we have already transitioned to JDK11"
] | [] | 2019-10-11T19:50:31Z | [
"info: help wanted",
"resolution: won't fix",
"epic: build issue"
] | Java 11 support: Run the project against Java 11 runtime | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Build the project using the old JDK 8, but try to run some of the pattern examples we have against a newer Java 11 runtime (see https://blog.codefx.org/java/planning-your-java-9-update/). Rec... | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [
".travis.yml",
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"naked-objects/dom/pom.xml",
"naked-objects/integtests/pom.xml",
"pom.xml",
"service-layer/pom.xml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 84b031fadcc1..45323dcfd457 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,6 @@
language: java
dist: xenial
jdk:
-- openjdk8
- openjdk11
env:
diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index fc89a93b7c79..9c9458505aba 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@... | null | train | train | 2019-10-11T20:55:48 | 2019-10-04T05:35:26Z | iluwatar | train |
iluwatar/java-design-patterns/413_986 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/413 | iluwatar/java-design-patterns/986 | [
"timestamp(timedelta=64.0, similarity=0.8955927821338747)"
] | 088bb764f35ec5d37e58ef1eb66bfce80378db5d | 7e698a90dd7664e119ec0b082883ea48dc12ae2e | [
"From the implementation, CircuitBreaker-State Pattern is a great pattern\ncompound to use for our implementation. The state pattern is to map\ndifferent state of the CircuitBreaker. I love this pattern.\n\nOn Thu, Mar 31, 2016 at 6:30 AM, Narendra Pathai notifications@github.com\nwrote:\n\n> http://martinfowler.c... | [
"The plugins are already defined in parent pom.xml and not needed here",
"You can use local-variable type inference here (var)",
"Use final where member variables don't change",
"Use local-variable type inference (var)",
"Could it be constant? Looks a bit cryptic",
"The calculation here is hard to underst... | 2019-10-12T14:37:04Z | [
"epic: pattern"
] | Circuit Breaker pattern | http://martinfowler.com/bliki/CircuitBreaker.html
The basic idea behind the circuit breaker is very simple. You wrap a protected function call in a circuit breaker object, which monitors for failures. Once the failures reach a certain threshold, the circuit breaker trips, and all further calls to the circuit breaker r... | [
"pom.xml"
] | [
"circuit-breaker/README.md",
"circuit-breaker/pom.xml",
"circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/App.java",
"circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/CircuitBreaker.java",
"circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DelayedService.java",
"circuit-breaker/s... | [
"circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/CircuitBreakerTest.java",
"circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/DelayedServiceTest.java",
"circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/MonitoringServiceTest.java"
] | diff --git a/circuit-breaker/README.md b/circuit-breaker/README.md
new file mode 100644
index 000000000000..db75ca58c0d0
--- /dev/null
+++ b/circuit-breaker/README.md
@@ -0,0 +1,188 @@
+---
+layout: pattern
+title: CircuitBreaker
+folder: circuit-breaker
+permalink: /patterns/circuit-breaker/
+categories: Other
+tags:
... | diff --git a/circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/CircuitBreakerTest.java b/circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/CircuitBreakerTest.java
new file mode 100644
index 000000000000..5780e9355c58
--- /dev/null
+++ b/circuit-breaker/src/test/java/com/iluwatar/circuitbreaker/CircuitBr... | test | train | 2019-10-14T19:25:35 | 2016-03-31T10:29:51Z | npathai | train |
iluwatar/java-design-patterns/988_992 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/988 | iluwatar/java-design-patterns/992 | [
"timestamp(timedelta=81254.0, similarity=0.846215572962624)"
] | 9ebbc421dd96b84c50808ca8ac4a520042e73b8f | 7de53f9853d575c7a341eefeac77949e6d660349 | [
"I'd be interested in looking into this, can I go ahead and try?",
"Ok @oconnelc ",
"Which version of JDK should I compile against? Should I use Oracle or Openjdk? ",
"We have just switched to openjdk11"
] | [] | 2019-10-12T19:34:43Z | [
"type: enhancement",
"info: good first issue",
"epic: dependencies",
"epic: architecture",
"type: refactoring"
] | Java 11 support: HttpClient | This task is part of the Java 11 transition plan https://github.com/iluwatar/java-design-patterns/wiki/16.-Java-11-Transition
Patterns Aggregator Microservices and API Gateway are currently using Apache HttpClient in their implementation. Java 11 provides its own HttpClient and we should switch to that instead to ge... | [
"aggregator-microservices/aggregator-service/pom.xml",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.... | [
"aggregator-microservices/aggregator-service/pom.xml",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInformationClientImpl.java",
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/ProductInventoryClientImpl.... | [] | diff --git a/aggregator-microservices/aggregator-service/pom.xml b/aggregator-microservices/aggregator-service/pom.xml
index 6ad8c3c8c5a4..f1ea05a6ec4d 100644
--- a/aggregator-microservices/aggregator-service/pom.xml
+++ b/aggregator-microservices/aggregator-service/pom.xml
@@ -53,10 +53,6 @@
<artifactId>m... | null | test | train | 2019-10-12T19:05:54 | 2019-10-12T15:19:26Z | iluwatar | train |
iluwatar/java-design-patterns/996_997 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/996 | iluwatar/java-design-patterns/997 | [
"timestamp(timedelta=0.0, similarity=0.8628434739492639)",
"keyword_pr_to_issue"
] | 9ebbc421dd96b84c50808ca8ac4a520042e73b8f | 72b174619fa8f936bff553ef19e741f4a11efb6c | [
"\r\n"
] | [] | 2019-10-13T14:26:59Z | [
"type: bug",
"epic: build issue"
] | Sonar analysis in master branch is failing | 
| [
".sonarcloud.properties",
".travis.yml",
"pom.xml"
] | [
".travis.yml",
"pom.xml"
] | [] | diff --git a/.sonarcloud.properties b/.sonarcloud.properties
deleted file mode 100644
index c6b26bf5df8b..000000000000
--- a/.sonarcloud.properties
+++ /dev/null
@@ -1,38 +0,0 @@
-#
-# The MIT License
-# Copyright © 2014-2019 Ilkka Seppälä
-#
-# Permission is hereby granted, free of charge, to any person obtaining a co... | null | val | train | 2019-10-12T19:05:54 | 2019-10-13T13:31:58Z | iluwatar | train |
iluwatar/java-design-patterns/554_998 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/554 | iluwatar/java-design-patterns/998 | [
"timestamp(timedelta=100.0, similarity=0.9294577700353882)"
] | 7e698a90dd7664e119ec0b082883ea48dc12ae2e | a5646b63c19455051fb49fd5a455a28159708d49 | [
"Hello @iluwatar I would like to take this pattern. Thanks!",
"Ok @szokekristof ",
"@szokekristof are you still implementing this?",
"The task is free to take",
"@iluwatar May I pick up this issue?",
"Sure go ahead @Azureyjt "
] | [
"New dependencies should be introduced in parent pom.xml, and then referenced in submodule. See for example the junit dependency above.",
"You can use Java's local variable type inference (var) in code like this. Please check it elsewhere too.",
"typo there",
"typo there",
"Fixed in commit 87c55b338aa0e32b9... | 2019-10-13T15:20:49Z | [
"epic: pattern",
"type: feature"
] | Subclass Sandbox pattern | http://gameprogrammingpatterns.com/subclass-sandbox.html | [
"pom.xml"
] | [
"pom.xml",
"subclass-sandbox/README.md",
"subclass-sandbox/pom.xml",
"subclass-sandbox/src/main/java/com/iluwatar/subclasssandbox/App.java",
"subclass-sandbox/src/main/java/com/iluwatar/subclasssandbox/GroundDive.java",
"subclass-sandbox/src/main/java/com/iluwatar/subclasssandbox/SkyLaunch.java",
"subcl... | [
"subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/AppTest.java",
"subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/GroundDiveTest.java",
"subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/SkyLaunchTest.java"
] | diff --git a/pom.xml b/pom.xml
index 9e61e716b864..36d501a92054 100644
--- a/pom.xml
+++ b/pom.xml
@@ -61,6 +61,7 @@
<jaxb-api.version>2.3.1</jaxb-api.version>
<jaxb-impl.version>2.3.2</jaxb-impl.version>
<annotation-api.version>1.3.2</annotation-api.version>
+ <system-rules.version>1.... | diff --git a/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/AppTest.java b/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/AppTest.java
new file mode 100644
index 000000000000..207c71ef9ef0
--- /dev/null
+++ b/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/AppTest.java
@@ -0,0 +1,3... | train | train | 2019-10-14T20:32:19 | 2017-04-01T08:54:15Z | iluwatar | train |
iluwatar/java-design-patterns/1001_1008 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1001 | iluwatar/java-design-patterns/1008 | [
"keyword_pr_to_issue"
] | 7e698a90dd7664e119ec0b082883ea48dc12ae2e | 27c131c2cb850a92b5b346b24dce20eae91cc84f | [
"Fixed intermittent issue #1001",
"Didn't see @afflato already took this, sorry!"
] | [] | 2019-10-14T20:41:48Z | [
"type: bug",
"info: good first issue",
"epic: build issue"
] | Intermittent test failure in Spatial Partition pattern | 
| [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Rect.java"
] | [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Rect.java"
] | [] | diff --git a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/Rect.java b/spatial-partition/src/main/java/com/iluwatar/spatialpartition/Rect.java
index 3d2f01d77d3d..71d4eda5bfa7 100644
--- a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/Rect.java
+++ b/spatial-partition/src/main/java/com/i... | null | test | train | 2019-10-14T20:32:19 | 2019-10-14T16:59:14Z | iluwatar | train |
iluwatar/java-design-patterns/1007_1015 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1007 | iluwatar/java-design-patterns/1015 | [
"keyword_pr_to_issue"
] | a5646b63c19455051fb49fd5a455a28159708d49 | 880b234d8fa328619e2505650849fec4c319d9fa | [
"I got this at work today as well, and we solved it with the above suggested solution. I can prepare a PR for it if noone else already did it?",
"Sure @lbroman, PR is welcome",
"Instead of inserting `junit-platform-commons` in each of the ~120 module poms a better fix would be to just update JUnit 5 to the most... | [] | 2019-10-17T13:23:12Z | [
"type: bug",
"info: good first issue",
"epic: build issue",
"epic: ide issue",
"epic: dependencies"
] | JUnit5 test are not able to run in Eclipse | Steps to recreate:
1. In Eclipse, select a unit test to run by right-clicking and selecting: "Run Configurations." Select a JUnit execution and ensure that the JUnit5 runner is selected:
1. Click the Run... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 020c784c62fd..22dedc14a59e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,7 +39,7 @@
<spring-data.version>2.0.14.RELEASE</spring-data.version>
<h2.version>1.4.190</h2.version>
<junit.version>4.12</junit.version>
- <junit-jupiter.version>5.0.2</junit-jupi... | null | train | train | 2019-10-16T17:21:06 | 2019-10-14T19:36:18Z | oconnelc | train |
iluwatar/java-design-patterns/1011_1017 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1011 | iluwatar/java-design-patterns/1017 | [
"keyword_issue_to_pr"
] | 880b234d8fa328619e2505650849fec4c319d9fa | c308ca09e5018aecd9ee409d6fdddb0d18d3a3de | [
"I would like to take a look, if no one else is interested.",
"I just submitted #1017 to address. ",
"Ok @oconnelc "
] | [] | 2019-10-18T00:03:50Z | [
"type: bug",
"info: good first issue",
"epic: code quality"
] | SonarCloud reports vulnerabilities | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blocker level vulnerabilities. In this task those are fixed or marked as false positives. To mark false positives, `SuppressWarnings` annotation should be used in code as explained in the linked documentation.... | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java",
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java",
"naked-objects/webapp/src/main/webapp/about/index.html"
] | [
"aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java",
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ApiGateway.java",
"naked-objects/webapp/src/main/webapp/about/index.html"
] | [] | diff --git a/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java b/aggregator-microservices/aggregator-service/src/main/java/com/iluwatar/aggregator/microservices/Aggregator.java
index cd30afc4807c..ccbe6f2fe68c 100644
--- a/aggregator-microservices/aggregator... | null | test | train | 2019-10-17T20:00:32 | 2019-10-15T17:51:01Z | iluwatar | train |
iluwatar/java-design-patterns/1016_1018 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1016 | iluwatar/java-design-patterns/1018 | [
"timestamp(timedelta=0.0, similarity=0.8630280494323783)",
"keyword_pr_to_issue"
] | 2982db456db68f5a1e30eb7f53bea1dac054f974 | 0c60a95d8f0da0275db6b16f685444db96fe1837 | [
"Why does the `maven-checkstyle-plugin` in the root pom use an execution? As a consequence running `mvn checkstyle:checkstyle-aggregate` on the command line doesn't use this configuration...",
"I think the source of the configuration has been the instructions on the plugin's web site https://maven.apache.org/plug... | [] | 2019-10-18T11:13:28Z | [
"info: good first issue",
"epic: ide issue",
"type: refactoring",
"epic: code quality"
] | Checkstyle should use google_checks.xml | At the moment maven-checkstyle-plugin in main pom.xml has been configured to use custom rules defined in checkstyle.xml. However there shouldn't be many modifications compared to the builtin google_checks.xml and it would be beneficial to start using this so that own rules wouldn't have to be maintained. | [
"checkstyle.xml",
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/checkstyle.xml b/checkstyle.xml
deleted file mode 100644
index d66281f178c6..000000000000
--- a/checkstyle.xml
+++ /dev/null
@@ -1,197 +0,0 @@
-<?xml version="1.0"?>
-<!--
-
- The MIT License
- Copyright © 2014-2019 Ilkka Seppälä
-
- Permission is hereby granted, free of charge, to any person obta... | null | val | train | 2019-10-18T22:09:27 | 2019-10-17T17:57:14Z | iluwatar | train |
iluwatar/java-design-patterns/1010_1023 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1010 | iluwatar/java-design-patterns/1023 | [
"timestamp(timedelta=1432.0, similarity=0.8563808740103421)"
] | f671f03d13966c9c5b3b65625224912336db86dd | 82f9a6c2323b412036965fc51e5ec155b6cf7741 | [
"I started taking a look at these errors and I think the first one will be a false positive. Specifically the rule: \"Loops should not be infinite\" in the file \"api-gateway/.../java/com/iluwatar/api/gateway/ApiGateway.java\" Based on the documentation in the above link, it seems like there are two options:\r\n\r\... | [] | 2019-10-19T21:10:08Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports bugs | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blocker and critical severity bugs. In this task those are fixed or marked as false positives. To mark false positives, `SuppressWarnings` annotation should be used in code as explained in the linked documenta... | [
"hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/CellPool.java"
] | [
"hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/CellPool.java"
] | [] | diff --git a/hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java b/hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java
index bc4e963e1808..29a9d3233889 100644
--- a/hexagonal/src/main/java/com/iluwatar/hexagonal/sampledata/SampleData.java
+++ b/hexagonal/src/main/java/com/ilu... | null | test | train | 2019-10-19T21:14:01 | 2019-10-15T17:46:38Z | iluwatar | train |
iluwatar/java-design-patterns/1009_1030 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1009 | iluwatar/java-design-patterns/1030 | [
"timestamp(timedelta=67.0, similarity=0.8773917989038774)"
] | acaa6cdc62b92e874357f02239dd8f51dc155f6b | 1cb1bdcb5778f911f67af70068f4d304f9094097 | [
"@jjjimenez100 yes I think we should clean up. Can you point out some example where this redeclaration occurs?",
"Looking at the parent pom, we already have the `mockito-core` dependency specified in [here](https://github.com/iluwatar/java-design-patterns/blob/master/pom.xml#L276).\r\n\r\nSome of the child poms l... | [] | 2019-10-24T17:22:08Z | [
"info: good first issue",
"epic: dependencies",
"type: refactoring"
] | Redundant dependency declarations on child poms | I've noticed that there are redeclaration of dependencies (e.g: junit 5 engine/mockito) on our modules. I don't think we'll be needing those since they are already specified on the parent pom.
Might be a good idea to have an issue that will do cleanups on child poms. Wdyt? @iluwatar | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"trampoline/pom.xml"
] | [
"cqrs/pom.xml",
"eip-aggregator/pom.xml",
"eip-splitter/pom.xml",
"eip-wire-tap/pom.xml",
"trampoline/pom.xml"
] | [] | diff --git a/cqrs/pom.xml b/cqrs/pom.xml
index b3afda05c226..feab9d1acacb 100644
--- a/cqrs/pom.xml
+++ b/cqrs/pom.xml
@@ -50,8 +50,8 @@
<dependency>
<groupId>com.sun.xml.bind</groupId>
<artifactId>jaxb-impl</artifactId>
- <scope>test</scope>
<version>2.1.17</version>
+ <scope>test</scope>
</depen... | null | train | train | 2019-10-23T16:25:45 | 2019-10-15T12:43:42Z | jjjimenez100 | train |
iluwatar/java-design-patterns/1037_1045 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1037 | iluwatar/java-design-patterns/1045 | [
"timestamp(timedelta=0.0, similarity=0.897763655876506)"
] | fadad43f8b85daabc06f87fb55784a4aac9c2a54 | 5d47488fe9165374821d2c3d3c0bf84a421cf110 | [] | [] | 2019-10-26T17:18:14Z | [
"type: bug",
"info: help wanted",
"info: good first issue",
"epic: build issue"
] | Error when building from submodule directories | When running `mvn clean install` from project's submodules, the following error message is outputted
```
Failed to execute goal com.mycila:license-maven-plugin:3.0:format (install-format) on project adapter: Resource license-plugin-header-style.xml not found in file system, classpath or URL: no protocol: license-pl... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index b6c1b4472a88..1bcf73b8b4d5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -406,6 +406,31 @@
</executions>
</plugin>
+ <!-- Resolves ${projectRoot} to the project root directory.
+ Used by the license-maven-plugin to find the correct l... | null | val | train | 2019-10-26T17:58:56 | 2019-10-26T06:17:57Z | iluwatar | train |
iluwatar/java-design-patterns/1161_1214 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1161 | iluwatar/java-design-patterns/1214 | [
"timestamp(timedelta=0.0, similarity=0.886218809180579)",
"keyword_pr_to_issue"
] | be1c0b81433ab4965be95f76c072c49908ca1378 | 751b3b945206bed390730f780070a73f5fe2d500 | [
"Thanks for reporting @karthikmucheli. Would you like to create a pull request for that?"
] | [] | 2020-03-27T02:22:05Z | [
"type: bug",
"info: help wanted",
"epic: web site",
"info: good first issue"
] | Aggregator Microservices | Credits link in Aggregator Microservices is responded with a blank page.
The current link is http://blog.arungupta.me/microservice-design-patterns/ | [
"aggregator-microservices/README.md"
] | [
"aggregator-microservices/README.md"
] | [] | diff --git a/aggregator-microservices/README.md b/aggregator-microservices/README.md
index 4d64178a66a5..74a411fc5cfb 100644
--- a/aggregator-microservices/README.md
+++ b/aggregator-microservices/README.md
@@ -27,4 +27,4 @@ Use the Aggregator Microservices pattern when you need a unified API for various
## Credits
... | null | train | train | 2020-03-26T20:14:44 | 2020-01-21T03:01:22Z | karthikmucheli | train |
iluwatar/java-design-patterns/1218_1221 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1218 | iluwatar/java-design-patterns/1221 | [
"timestamp(timedelta=327.0, similarity=0.8903223199668275)"
] | 751b3b945206bed390730f780070a73f5fe2d500 | 1c26bd741615e73579e5b70fdc84d96ca23c69e8 | [
"hi im a beginner. can u elaborate more? so what should be done?",
"For me it sounds just like a different name for Given-When-Then.\r\nhttps://en.wikipedia.org/wiki/Given-When-Then",
"> For me it sounds just like a different name for Given-When-Then.\r\n> https://en.wikipedia.org/wiki/Given-When-Then\r\n\r\nI ... | [
"We don't have an existing tag yet, but I would propose to use `Testing` here. Then we need to amend file https://github.com/iluwatar/java-design-patterns-web/blob/master/_data/tags.yml. See https://github.com/iluwatar/java-design-patterns/wiki/07.-Categories-and-Tags.",
"Changed in 882b569"
] | 2020-04-14T14:15:35Z | [
"epic: pattern",
"info: good first issue",
"type: feature"
] | Arrange, Act, Assert pattern | AAA is a way to structure your unit tests so they're easier to read, maintain, and enhance.
Reference: https://blog.ncrunch.net/post/arrange-act-assert-aaa-testing.aspx
| [
"pom.xml"
] | [
"arrange-act-assert/README.md",
"arrange-act-assert/etc/arrange-act-assert.urm.puml",
"arrange-act-assert/pom.xml",
"arrange-act-assert/src/main/java/com/iluwatar/arrangeactassert/Cash.java",
"pom.xml"
] | [
"arrange-act-assert/src/test/java/com/iluwatar/arrangeactassert/CashAAATest.java",
"arrange-act-assert/src/test/java/com/iluwatar/arrangeactassert/CashAntiAAATest.java"
] | diff --git a/arrange-act-assert/README.md b/arrange-act-assert/README.md
new file mode 100644
index 000000000000..02b7ee8b7398
--- /dev/null
+++ b/arrange-act-assert/README.md
@@ -0,0 +1,30 @@
+---
+layout: pattern
+title: Arrange/Act/Assert
+folder: arrange-act-assert
+permalink: /patterns/arrange-act-assert/
+categor... | diff --git a/arrange-act-assert/src/test/java/com/iluwatar/arrangeactassert/CashAAATest.java b/arrange-act-assert/src/test/java/com/iluwatar/arrangeactassert/CashAAATest.java
new file mode 100644
index 000000000000..d7841843db37
--- /dev/null
+++ b/arrange-act-assert/src/test/java/com/iluwatar/arrangeactassert/CashAAAT... | train | train | 2020-03-28T19:26:37 | 2020-03-31T16:33:40Z | iluwatar | train |
iluwatar/java-design-patterns/1339_1342 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1339 | iluwatar/java-design-patterns/1342 | [
"keyword_pr_to_issue",
"timestamp(timedelta=31.0, similarity=0.9313792829300822)"
] | 4b88214baef78c362806311d88f96bebb0cd4d21 | 54c0b1725c522666e7dbdcb973719cefb7a9daed | [] | [] | 2020-07-26T20:59:59Z | [
"type: bug",
"info: help wanted",
"epic: pattern"
] | Service Layer logging broken | At the moment the Service Layer pattern example does not produce log output at all. | [
"service-layer/src/main/resources/logback.xml"
] | [
"service-layer/src/main/resources/logback.xml"
] | [] | diff --git a/service-layer/src/main/resources/logback.xml b/service-layer/src/main/resources/logback.xml
index 47fe422366d8..e6678aff2e8f 100644
--- a/service-layer/src/main/resources/logback.xml
+++ b/service-layer/src/main/resources/logback.xml
@@ -43,6 +43,7 @@
<logger name="com.iluwatar" additivity="false">
... | null | val | train | 2020-07-26T21:47:33 | 2020-07-26T16:24:07Z | iluwatar | train |
iluwatar/java-design-patterns/1324_1472 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1324 | iluwatar/java-design-patterns/1472 | [
"timestamp(timedelta=204.0, similarity=0.854523537744862)"
] | 9ff5b9e7c09277cc51c3b26224608c699b457156 | 97285d37244fd0d524b6e9d9aa8dae48f1fa0cc3 | [
"Yes, I agree that would be the typical scenario and in this case it would suit the example fine.\r\n",
"@ravening let's leave the issue open if somebody wants to implement it",
"@iluwatar I can work on it if you are ok with it.\r\nShould I write separate classes/interfaces or rewrite the existing abstract clas... | [] | 2020-08-03T14:57:32Z | [
"epic: pattern",
"type: enhancement",
"info: good first issue"
] | Inheritence in Command pattern | I see that the `Command` is a class instead of `interface` and all the target actions extends this class.
Typically `Command` should be interface and the targets should implement the interface.
So should we rewrite the command pattern to implement interface rather than using inheritance? | [
"command/README.md",
"command/etc/command.urm.puml",
"command/src/main/java/com/iluwatar/command/Command.java",
"command/src/main/java/com/iluwatar/command/InvisibilitySpell.java",
"command/src/main/java/com/iluwatar/command/ShrinkSpell.java"
] | [
"command/README.md",
"command/etc/command.urm.puml",
"command/src/main/java/com/iluwatar/command/Command.java",
"command/src/main/java/com/iluwatar/command/InvisibilitySpell.java",
"command/src/main/java/com/iluwatar/command/ShrinkSpell.java"
] | [] | diff --git a/command/README.md b/command/README.md
index fc0a11d9ffe8..b763cf4dd1c5 100644
--- a/command/README.md
+++ b/command/README.md
@@ -75,19 +75,18 @@ public class Wizard {
Next we present the spell hierarchy.
```java
-public abstract class Command {
+public interface Command {
- public abstract void exe... | null | train | train | 2020-08-03T15:49:46 | 2020-07-21T15:33:23Z | ravening | train |
iluwatar/java-design-patterns/1338_1485 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1338 | iluwatar/java-design-patterns/1485 | [
"timestamp(timedelta=60.0, similarity=0.9630152057325821)"
] | 1e90d0d645e637cb716b1f3f40d259345fd8bf9d | 2c6f1832b0d328240e270dc0051d4c9e1af682ee | [
"I can work on it, if you would like it to assign it to me?",
"Thanks @amit1307 please go ahead",
"Hey, I was trying to start on this one but might need some more info if that's okay.\r\n\r\nMy understanding of this issue is that we don't have any logger configured for `api-gateway` but after it seems like ther... | [] | 2020-08-09T13:37:03Z | [
"type: bug",
"epic: pattern",
"info: good first issue"
] | Logging in API Gateway | At the moment api-gateway pattern does not use a proper logger as in other examples. In this issue we fix that. | [
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ImageClientImpl.java",
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/PriceClientImpl.java",
"api-gateway/image-microservice/src/main/java/com/iluwatar/image/microservice/ImageController.java",
"api-gateway/price-... | [
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ImageClientImpl.java",
"api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/PriceClientImpl.java",
"api-gateway/image-microservice/src/main/java/com/iluwatar/image/microservice/ImageController.java",
"api-gateway/price-... | [] | diff --git a/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ImageClientImpl.java b/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/ImageClientImpl.java
index 52dd065ffc35..6fea815fc86d 100644
--- a/api-gateway/api-gateway-service/src/main/java/com/iluwatar/api/gateway/Imag... | null | train | train | 2020-08-08T21:44:51 | 2020-07-26T13:00:00Z | iluwatar | train |
iluwatar/java-design-patterns/1500_1505 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1500 | iluwatar/java-design-patterns/1505 | [
"keyword_issue_to_pr",
"connected"
] | 6d83ceba285fb2a62119f6169d8041ec05c196c4 | 15d795bf8a92c65cbb42a5889a351e317729c031 | [
"I'd like to take this issue. Thank you in advance.",
"Yes @ToxicDreamz, go ahead ☺️ ",
"Half way through upgrading, one test case seems to be causing an issue, within the **Serverless** module, in specific the **`SavePersonApiHandlerTest#handleRequestSavePersonException()`** method. I do not have any knowledge... | [] | 2020-08-24T21:18:02Z | [
"info: help wanted",
"epic: build issue",
"epic: dependencies",
"type: refactoring"
] | Use the same JUnit version everywhere | At the moment there are some modules that are still using JUnit 4. Most of the codebase uses JUnit 5, but even with that there are different versions. For example `unit-of-work` and `partial-response` declare their own versions.
In this ticket let's try to apply the same version of JUnit 5 everywhere upgrading from ... | [
"pom.xml",
"subclass-sandbox/pom.xml"
] | [
"pom.xml",
"subclass-sandbox/pom.xml"
] | [
"subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/GroundDiveTest.java",
"subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/SkyLaunchTest.java"
] | diff --git a/pom.xml b/pom.xml
index 1275ce115c83..3b7ad35686b6 100644
--- a/pom.xml
+++ b/pom.xml
@@ -52,7 +52,7 @@
<jaxb-api.version>2.3.1</jaxb-api.version>
<jaxb-impl.version>2.3.2</jaxb-impl.version>
<annotation-api.version>1.3.2</annotation-api.version>
- <system-rules.version>1.... | diff --git a/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/GroundDiveTest.java b/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/GroundDiveTest.java
index 97e2ac67d16f..3b379946c6f0 100644
--- a/subclass-sandbox/src/test/java/com/iluwatar/subclasssandbox/GroundDiveTest.java
+++ b/subclass-sand... | train | train | 2020-08-23T17:53:57 | 2020-08-21T14:32:50Z | iluwatar | train |
iluwatar/java-design-patterns/1486_1507 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1486 | iluwatar/java-design-patterns/1507 | [
"timestamp(timedelta=86.0, similarity=0.927805650729066)"
] | 9dd46d7b4a4329d07956b263dd627272e25db707 | 9b464e0be1a54f26bd50508d619f294d2147fa8d | [
"I can look into it if you can assign it to me please.",
"Ok @amit1307 ",
"@amit1307 Can we get an update on the status of this issue?",
"Hey, sorry I was out of the town for few days and came back this week. Just catching up the stuff. I should get back with some progress soon. Hope that's fine."
] | [] | 2020-08-25T23:11:06Z | [
"type: enhancement",
"epic: dependencies"
] | Upgrade mockito | The current version declared in the main `pom.xml` is very old:
```
<mockito.version>1.10.19</mockito.version>
```
Let's try to upgrade it to a newer version in this task. | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 56b95520435e..6d779700f9f5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -39,7 +39,7 @@
<commons-dbcp.version>1.4</commons-dbcp.version>
<camel.version>2.24.0</camel.version>
<guava.version>19.0</guava.version>
- <mockito.version>1.10.19</mockito.version>
+... | null | test | train | 2020-08-25T20:42:42 | 2020-08-09T14:58:02Z | iluwatar | train |
iluwatar/java-design-patterns/1313_1522 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1313 | iluwatar/java-design-patterns/1522 | [
"timestamp(timedelta=213.0, similarity=0.8767148070795346)"
] | ef326ee77e03077714f38df36f92ffa58ebaffa9 | ebc0e8b3cd79ce644c927ad0a64dd0539d6da4e3 | [
"May I take this up and implement this pattern?",
"Sure @swarajsaaj, go ahead!"
] | [
"In a sense it's architectural, but I would put it under `Structural` since this the scope is so small.",
"Please add explanation for term `SPI` here, since it may not be familiar to everybody.",
"Naming, I would suggest `DomesticTaxCalculator`",
"Naming, `ForeignTaxCalculator` maybe?",
"```suggestion\r\n ... | 2020-09-09T21:32:18Z | [
"epic: pattern",
"type: feature"
] | Separated Interface pattern | https://www.youtube.com/watch?v=d3k-hOA7k2Y | [
"pom.xml"
] | [
"pom.xml",
"separated-interface/README.md",
"separated-interface/etc/separated-interface.urm.puml",
"separated-interface/pom.xml",
"separated-interface/src/main/java/com/iluwatar/separatedinterface/App.java",
"separated-interface/src/main/java/com/iluwatar/separatedinterface/invoice/InvoiceGenerator.java"... | [
"separated-interface/src/test/java/com/iluwatar/separatedinterface/AppTest.java",
"separated-interface/src/test/java/com/iluwatar/separatedinterface/invoice/InvoiceGeneratorTest.java",
"separated-interface/src/test/java/com/iluwatar/separatedinterface/taxes/DomesticTaxCalculatorTest.java",
"separated-interfac... | diff --git a/pom.xml b/pom.xml
index da3084ab2c51..1026685881db 100644
--- a/pom.xml
+++ b/pom.xml
@@ -196,6 +196,7 @@
<module>transaction-script</module>
<module>filterer</module>
<module>factory</module>
+ <module>separated-interface</module>
</modules>
<repositories>
dif... | diff --git a/separated-interface/src/test/java/com/iluwatar/separatedinterface/AppTest.java b/separated-interface/src/test/java/com/iluwatar/separatedinterface/AppTest.java
new file mode 100644
index 000000000000..4114f9bb73d0
--- /dev/null
+++ b/separated-interface/src/test/java/com/iluwatar/separatedinterface/AppTest... | train | train | 2020-09-06T18:56:07 | 2020-07-07T18:04:05Z | iluwatar | train |
iluwatar/java-design-patterns/1500_1529 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1500 | iluwatar/java-design-patterns/1529 | [
"connected"
] | a125879d15e82af50b757baa9f7d81efbd1c3235 | f0067828058d87352bcc7a072a53837b47f235b8 | [
"I'd like to take this issue. Thank you in advance.",
"Yes @ToxicDreamz, go ahead ☺️ ",
"Half way through upgrading, one test case seems to be causing an issue, within the **Serverless** module, in specific the **`SavePersonApiHandlerTest#handleRequestSavePersonException()`** method. I do not have any knowledge... | [] | 2020-09-27T13:31:51Z | [
"info: help wanted",
"epic: build issue",
"epic: dependencies",
"type: refactoring"
] | Use the same JUnit version everywhere | At the moment there are some modules that are still using JUnit 4. Most of the codebase uses JUnit 5, but even with that there are different versions. For example `unit-of-work` and `partial-response` declare their own versions.
In this ticket let's try to apply the same version of JUnit 5 everywhere upgrading from ... | [
"trampoline/pom.xml",
"trampoline/src/main/java/com/iluwatar/trampoline/Trampoline.java"
] | [
"trampoline/pom.xml",
"trampoline/src/main/java/com/iluwatar/trampoline/Trampoline.java"
] | [
"trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java"
] | diff --git a/trampoline/pom.xml b/trampoline/pom.xml
index fff117bf8a72..d78236473725 100644
--- a/trampoline/pom.xml
+++ b/trampoline/pom.xml
@@ -35,11 +35,6 @@
</parent>
<artifactId>trampoline</artifactId>
<dependencies>
- <dependency>
- <groupId>junit</groupId>
- <artifact... | diff --git a/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java b/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
index c5d6571cdd51..664a95634f5c 100644
--- a/trampoline/src/test/java/com/iluwatar/trampoline/TrampolineAppTest.java
+++ b/trampoline/src/test/java/com/iluwatar... | test | train | 2020-09-26T12:01:58 | 2020-08-21T14:32:50Z | iluwatar | train |
iluwatar/java-design-patterns/1500_1542 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1500 | iluwatar/java-design-patterns/1542 | [
"keyword_issue_to_pr",
"connected"
] | c3c90e2bd451cdd60947704d1250c8b245881199 | 903453229cb7d5996f4f52a5f5d88f34e6eb1d5a | [
"I'd like to take this issue. Thank you in advance.",
"Yes @ToxicDreamz, go ahead ☺️ ",
"Half way through upgrading, one test case seems to be causing an issue, within the **Serverless** module, in specific the **`SavePersonApiHandlerTest#handleRequestSavePersonException()`** method. I do not have any knowledge... | [
"Could you please describe this change a bit, why is it needed? This particular snippet is also part of the pattern's `README.md` (which is rendered on the https://java-design-patterns.com web site) so all the changes should be reflected there.",
"@charlesfinley can you please clarify on this part as why we modif... | 2020-10-02T03:16:36Z | [
"info: help wanted",
"epic: build issue",
"epic: dependencies",
"type: refactoring"
] | Use the same JUnit version everywhere | At the moment there are some modules that are still using JUnit 4. Most of the codebase uses JUnit 5, but even with that there are different versions. For example `unit-of-work` and `partial-response` declare their own versions.
In this ticket let's try to apply the same version of JUnit 5 everywhere upgrading from ... | [
"pom.xml",
"saga/pom.xml",
"trampoline/src/main/java/com/iluwatar/trampoline/Trampoline.java",
"update-method/pom.xml"
] | [
"pom.xml",
"saga/pom.xml",
"trampoline/src/main/java/com/iluwatar/trampoline/Trampoline.java",
"update-method/pom.xml"
] | [
"saga/src/test/java/com/iluwatar/saga/choreography/SagaApplicationTest.java",
"saga/src/test/java/com/iluwatar/saga/choreography/SagaChoreographyTest.java",
"saga/src/test/java/com/iluwatar/saga/orchestration/SagaApplicationTest.java",
"saga/src/test/java/com/iluwatar/saga/orchestration/SagaOrchestratorIntern... | diff --git a/pom.xml b/pom.xml
index 48fa6fdcf801..8b00646c5e2b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,8 +41,8 @@
<spring-data.version>2.0.14.RELEASE</spring-data.version>
<h2.version>1.4.190</h2.version>
<junit.version>4.12</junit.version>
- <junit-jupiter.version>5.5.2</junit-jupi... | diff --git a/saga/src/test/java/com/iluwatar/saga/choreography/SagaApplicationTest.java b/saga/src/test/java/com/iluwatar/saga/choreography/SagaApplicationTest.java
index 52b407b57294..67ac0f2fae1d 100644
--- a/saga/src/test/java/com/iluwatar/saga/choreography/SagaApplicationTest.java
+++ b/saga/src/test/java/com/iluwa... | train | train | 2021-03-01T15:50:34 | 2020-08-21T14:32:50Z | iluwatar | train |
iluwatar/java-design-patterns/1310_1543 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1310 | iluwatar/java-design-patterns/1543 | [
"timestamp(timedelta=0.0, similarity=0.8966570528077739)",
"keyword_pr_to_issue",
"connected"
] | 428cbc1027594794cc0aaab17be35e3cacb2b117 | 14c4710435e89218404086816682012eff023497 | [
"Hi @iluwatar \r\nI would like to work on it.",
"Ok @viveksb007 ",
"Hi @iluwatar,\r\n\r\nI understood that Registry Pattern is similar to `Multiton` pattern, the only difference is no restrictions on numbers of objects.\r\nIn simple words, it stores <key, object> and there is no restriction on number of objects... | [
"Add an empty line after this",
"Done"
] | 2020-10-02T14:34:12Z | [
"epic: pattern",
"type: feature"
] | Registry pattern | https://www.martinfowler.com/eaaCatalog/registry.html
https://stackoverflow.com/questions/16744424/whats-the-difference-between-singleton-and-registry-design-pattern
https://wiki.c2.com/?RegistryPattern | [
"pom.xml"
] | [
"pom.xml",
"registry/README.md",
"registry/etc/registry.urm.puml",
"registry/pom.xml",
"registry/src/main/java/com/iluwatar/registry/App.java",
"registry/src/main/java/com/iluwatar/registry/Customer.java",
"registry/src/main/java/com/iluwatar/registry/CustomerRegistry.java"
] | [
"registry/src/test/java/com/iluwatar/registry/CustomerRegistryTest.java"
] | diff --git a/pom.xml b/pom.xml
index e7fd2e4b3f87..86cefa13386a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -195,6 +195,7 @@
<module>strangler</module>
<module>arrange-act-assert</module>
<module>transaction-script</module>
+ <module>registry</module>
<module>filterer</module>
... | diff --git a/registry/src/test/java/com/iluwatar/registry/CustomerRegistryTest.java b/registry/src/test/java/com/iluwatar/registry/CustomerRegistryTest.java
new file mode 100644
index 000000000000..2919390b9270
--- /dev/null
+++ b/registry/src/test/java/com/iluwatar/registry/CustomerRegistryTest.java
@@ -0,0 +1,44 @@
+... | train | train | 2020-12-07T19:25:59 | 2020-07-07T18:00:12Z | iluwatar | train |
iluwatar/java-design-patterns/1569_1570 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1569 | iluwatar/java-design-patterns/1570 | [
"timestamp(timedelta=0.0, similarity=0.8769966537858309)",
"connected"
] | a94615ac54300326b8912a5a365418caed9306bd | 5bc61c8c28e770f9b2805a3dc56bfde5fdbbc238 | [
"@siavashsoleymani Please provide us some solid references to this pattern.",
"Created follow-up ticket https://github.com/iluwatar/java-design-patterns/issues/1617"
] | [
"add an extra line",
"add an extra line",
"Done, thanks for your suggestions",
"A suggestion. You can use Lombok packages from this repo which avoids all the boilerplate code",
"agree with you @ravening "
] | 2020-10-16T12:37:42Z | [
"epic: pattern",
"type: enhancement"
] | Data transfer object pattern using Enums | I'm going to implement a DTO pattern using java Enums.
In this way the code is going to be more **Type safe**, **Consistent Syntax**, **Consistent Semantics**, and more **Readable & Maintainable**. | [
"pom.xml"
] | [
"data-transfer-object-enum-impl/README.md",
"data-transfer-object-enum-impl/etc/data-transfer-object-enum-impl.urm.puml",
"data-transfer-object-enum-impl/pom.xml",
"data-transfer-object-enum-impl/src/main/java/com/iluwatar/datatransferenum/App.java",
"data-transfer-object-enum-impl/src/main/java/com/iluwata... | [
"data-transfer-object-enum-impl/src/test/java/com/iluwatar/datatransferenum/AppTest.java"
] | diff --git a/data-transfer-object-enum-impl/README.md b/data-transfer-object-enum-impl/README.md
new file mode 100644
index 000000000000..7e6dbc365319
--- /dev/null
+++ b/data-transfer-object-enum-impl/README.md
@@ -0,0 +1,54 @@
+---
+layout: pattern
+title: Data Transfer Object
+folder: data-transfer-object
+permalink... | diff --git a/data-transfer-object-enum-impl/src/test/java/com/iluwatar/datatransferenum/AppTest.java b/data-transfer-object-enum-impl/src/test/java/com/iluwatar/datatransferenum/AppTest.java
new file mode 100644
index 000000000000..bba131e64163
--- /dev/null
+++ b/data-transfer-object-enum-impl/src/test/java/com/iluwat... | test | train | 2020-12-08T06:28:39 | 2020-10-16T09:44:26Z | siavashsoleymani | train |
iluwatar/java-design-patterns/1601_1604 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1601 | iluwatar/java-design-patterns/1604 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9508714178765859)",
"connected"
] | c282ab80fdd4785a1a8d5bb8b2e5bfe519fd12be | f5a616104497d85f03754ed0b15be316794fcd7f | [
"I am new to this. Can I take up this?",
"@ohbus when handling issues set the correct labels and on close set the milestone",
"> @ohbus when handling issues set the correct labels and on close set the milestone\n\nThank you for this guiding me on this.\n\nAnd Hacktoberfest is over, I guess we should remove this... | [] | 2020-11-30T09:58:31Z | [
"type: bug",
"epic: pattern",
"info: good first issue"
] | Word mistake in factory/README.md | 
Lines 83-84: Could not find CarSimpleFactory. Isn't it CarsFactory? | [
"factory/README.md"
] | [
"factory/README.md"
] | [] | diff --git a/factory/README.md b/factory/README.md
index a1b6208fd736..0112c92c0f06 100644
--- a/factory/README.md
+++ b/factory/README.md
@@ -81,7 +81,7 @@ public enum CarType {
}
```
Then we have the static method `getCar` to create car objects encapsulated in the factory class
-`CarSimpleFactory`.
+`CarsFactory`... | null | train | train | 2020-12-01T21:48:24 | 2020-11-25T19:43:50Z | seungryeolpark | train |
iluwatar/java-design-patterns/1600_1610 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1600 | iluwatar/java-design-patterns/1610 | [
"keyword_pr_to_issue"
] | 29ceac2fb06a4ffb85bdd327cdf3824ba6ccdaec | e9f73bcf0b79ef90076ce0bde93f85b8cb6a7557 | [
"line 13 : 包装器 should be 装饰器 。\r\n装饰器 is well known than 包装器 in China",
"@xiaod-dev could you check this issue?",
"> line 13 : 包装器 should be 装饰器 。\r\n> 装饰器 is well known than 包装器 in China\r\n\r\nThank your feedback. the line 36 was corrected, and about the line13, the original text is \" Wrapper\", not \"deco... | [] | 2020-12-06T13:15:30Z | [
"type: bug",
"info: good first issue",
"epic: documentation"
] | careless grammer mistake in zh/decorator/README.md | line 36:程序mple. First of all we have a simple troll implementing the troll interface
should be 程序example. First of all we have a simple troll implementing the troll interface
Thank you! | [
"zh/decorator/README.md"
] | [
"zh/bridge/README.md",
"zh/callback/README.md",
"zh/command/README.md",
"zh/decorator/README.md",
"zh/dependency-injection/README.md",
"zh/iterator/README.md",
"zh/state/README.md",
"zh/template-method/README.md"
] | [] | diff --git a/zh/bridge/README.md b/zh/bridge/README.md
new file mode 100644
index 000000000000..cd9f40ac496a
--- /dev/null
+++ b/zh/bridge/README.md
@@ -0,0 +1,205 @@
+---
+layout: pattern
+title: Bridge
+folder: bridge
+permalink: /patterns/bridge/
+categories: Structural
+tags:
+ - Gang of Four
+---
+
+## 又被称为
+
+手柄/... | null | train | train | 2020-12-05T09:56:00 | 2020-11-24T08:11:34Z | HKTangShuo | train |
iluwatar/java-design-patterns/1469_1631 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1469 | iluwatar/java-design-patterns/1631 | [
"timestamp(timedelta=0.0, similarity=0.8514845503470311)"
] | 25ed2540f4b5d6fc2709c1e178082461a1da222d | 18a1a725ee763dbf8f9c10025e23226f038cbb1c | [
"Please assign to me thx",
"Ok @maheshsv ",
"Do we need to implement Strategy Pattern using Lambda Expressions in Java 8",
"Yes, that would be great addition to this pattern example",
"ok can i create a branch and work on it, ?",
"Go ahead @maheshsv ",
"Hi, I want to solve this issue if it is still open... | [] | 2021-01-18T17:50:25Z | [
"epic: pattern",
"type: enhancement"
] | Functional implementation of Strategy pattern | Strategy has been implemented using Java classes. In modern Java about the same can be achieved by passing methods. Let's amend the Strategy example with functional style implementation. | [
"strategy/README.md",
"strategy/etc/strategy.urm.puml",
"strategy/src/main/java/com/iluwatar/strategy/App.java"
] | [
"strategy/README.md",
"strategy/etc/strategy.urm.puml",
"strategy/src/main/java/com/iluwatar/strategy/App.java",
"strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java"
] | [] | diff --git a/strategy/README.md b/strategy/README.md
index b2330ceb84ce..2d2cbf9c4823 100644
--- a/strategy/README.md
+++ b/strategy/README.md
@@ -122,6 +122,51 @@ Program output:
You cast the spell of disintegration and the dragon vaporizes in a pile of dust!
```
+What's more, the new feature Lambda Expres... | null | train | train | 2021-01-16T20:00:23 | 2020-08-01T11:15:53Z | iluwatar | train |
iluwatar/java-design-patterns/1638_1650 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1638 | iluwatar/java-design-patterns/1650 | [
"connected"
] | 03bc4a6b9a6d43f20b14fa90758b848c6f4a08c5 | 846d05672a66e4464ebca61c56d061eb964df4c6 | [
"Can I work on this?",
"Go ahead @richardmr36 ",
"hey @iluwatar @richardmr36 can you please give more info about the issue",
"@raghuvanshi65 The link mentioned in the issue gives enough details I guess. It is easier to understand if you are aware about default parameters feature of JavaScript ES6. Let us kno... | [
"add an extra line after this",
"add an extra line",
"Done!",
"Done!",
"You can remove this \\<p>\r\n```suggestion\r\n * The Parameter Object is simply a wrapper object for all parameters of a method.\r\n```",
"Use documentation commenting.\r\n\r\n```suggestion\r\n/**\r\n * Below two methods of name `sear... | 2021-02-10T19:20:44Z | [
"epic: pattern",
"info: good first issue",
"type: feature"
] | Parameter Object idiom | It's a simple workaround for Java not having default parameters:
http://dolszewski.com/java/java-default-parameters/ | [
"pom.xml"
] | [
"parameter-object/README.md",
"parameter-object/etc/parameter-object.urm.puml",
"parameter-object/pom.xml",
"parameter-object/src/main/java/com/iluwatar/parameter/object/App.java",
"parameter-object/src/main/java/com/iluwatar/parameter/object/ParameterObject.java",
"parameter-object/src/main/java/com/iluw... | [
"parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java",
"parameter-object/src/test/java/com/iluwatar/parameter/object/ParameterObjectTest.java",
"parameter-object/src/test/java/com/iluwatar/parameter/object/SearchServiceTest.java"
] | diff --git a/parameter-object/README.md b/parameter-object/README.md
new file mode 100644
index 000000000000..9783879f1472
--- /dev/null
+++ b/parameter-object/README.md
@@ -0,0 +1,138 @@
+---
+layout: pattern
+title: Parameter Object
+folder: parameter-object
+permalink: /patterns/parameter-object/
+categories: Behavi... | diff --git a/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java b/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
new file mode 100644
index 000000000000..809e41f3677c
--- /dev/null
+++ b/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
@@ -0,0 +... | train | train | 2021-02-21T14:21:11 | 2021-01-28T15:39:37Z | iluwatar | train |
iluwatar/java-design-patterns/1663_1664 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1663 | iluwatar/java-design-patterns/1664 | [
"keyword_pr_to_issue"
] | 0220f3df129e9b1c22f34bc48fc33ac57a009e37 | c3c90e2bd451cdd60947704d1250c8b245881199 | [] | [] | 2021-02-28T13:04:42Z | [
"type: feature",
"epic: code quality"
] | feature: Run sonar analysis on pull requests | ⭐ This feature will help us review pull requests easier by helping us reviewing the modified or newly added code 👨🏻💻 by SonarCloud and comment out the report in the pull request.
✔️ This is going to help the contributor to increase their code quality and the coverage while removing static code errors.
✔️ Overa... | [
".mvn/wrapper/MavenWrapperDownloader.java",
"mvnw.cmd",
"parameter-object/pom.xml",
"parameter-object/src/main/java/com/iluwatar/parameter/object/App.java",
"parameter-object/src/main/java/com/iluwatar/parameter/object/ParameterObject.java",
"parameter-object/src/main/java/com/iluwatar/parameter/object/Se... | [
".circleci/config.yml",
".mvn/wrapper/MavenWrapperDownloader.java",
"mvnw.cmd",
"parameter-object/pom.xml",
"parameter-object/src/main/java/com/iluwatar/parameter/object/App.java",
"parameter-object/src/main/java/com/iluwatar/parameter/object/ParameterObject.java",
"parameter-object/src/main/java/com/il... | [
"parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java",
"parameter-object/src/test/java/com/iluwatar/parameter/object/ParameterObjectTest.java",
"parameter-object/src/test/java/com/iluwatar/parameter/object/SearchServiceTest.java"
] | diff --git a/.circleci/config.yml b/.circleci/config.yml
new file mode 100644
index 000000000000..3e35aee712dd
--- /dev/null
+++ b/.circleci/config.yml
@@ -0,0 +1,52 @@
+#
+# The MIT License
+# Copyright © 2014-2021 Ilkka Seppälä
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of t... | diff --git a/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java b/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
index 809e41f3677c..16baef96fba6 100644
--- a/parameter-object/src/test/java/com/iluwatar/parameter/object/AppTest.java
+++ b/parameter-object/src/test/java/... | val | train | 2021-02-28T10:51:47 | 2021-02-28T12:37:13Z | ohbus | train |
iluwatar/java-design-patterns/1319_1742 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1319 | iluwatar/java-design-patterns/1742 | [
"timestamp(timedelta=358.0, similarity=0.8814113081186224)",
"keyword_pr_to_issue"
] | 122e6edb38a3a1335363447a8a3f638826a6dab6 | e498c25675856e00a8c122be5e01bf390f748a72 | [
"Could I take this？ @iluwatar ",
"Sure thing @tao-sun2 \r\n\r\nPlease mention a timeline for when can we expect a PR against this issue.",
"I will finish this issue within a week."
] | [
"```suggestion\r\ncategories: Structural\r\n```",
"Is there console output that we could show here?",
"```suggestion\r\n- The application only uses a few shared common table-oriented data structures.\r\n```",
"Add a comment to describe what happens in this section",
"Could we use try-with-resources statemen... | 2021-05-02T15:23:48Z | [
"epic: pattern",
"type: feature"
] | Table Module pattern | https://inviqa.com/blog/architecture-patterns-domain-model-and-friends | [
"pom.xml"
] | [
"pom.xml",
"table-module/README.md",
"table-module/etc/table-module.urm.puml",
"table-module/pom.xml",
"table-module/src/main/java/com/iluwatar/tablemodule/App.java",
"table-module/src/main/java/com/iluwatar/tablemodule/User.java",
"table-module/src/main/java/com/iluwatar/tablemodule/UserTableModule.jav... | [
"table-module/src/test/java/com/iluwatar/tablemodule/AppTest.java",
"table-module/src/test/java/com/iluwatar/tablemodule/UserTableModuleTest.java",
"table-module/src/test/java/com/iluwatar/tablemodule/UserTest.java"
] | diff --git a/pom.xml b/pom.xml
index 1b8f30e92b83..8173972bd27a 100644
--- a/pom.xml
+++ b/pom.xml
@@ -225,6 +225,7 @@
<module>active-object</module>
<module>model-view-viewmodel</module>
<module>composite-entity</module>
+ <module>table-module</module>
<module>presentation</m... | diff --git a/table-module/src/test/java/com/iluwatar/tablemodule/AppTest.java b/table-module/src/test/java/com/iluwatar/tablemodule/AppTest.java
new file mode 100644
index 000000000000..cafae7cdbe38
--- /dev/null
+++ b/table-module/src/test/java/com/iluwatar/tablemodule/AppTest.java
@@ -0,0 +1,16 @@
+package com.iluwat... | train | train | 2021-05-14T17:56:41 | 2020-07-07T18:12:15Z | iluwatar | train |
iluwatar/java-design-patterns/1747_1748 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1747 | iluwatar/java-design-patterns/1748 | [
"keyword_pr_to_issue"
] | 1dd26289e5836ee31dca18b6077666f357322ca3 | 1388e38744b7b83ea4bfa473a719e764ef83534a | [
"Thanks, @DEV-VRUPER for mentioning the problem.\r\n\r\nThere seems to be an error due to an additional hyphen at the end of the URL.\r\n\r\nPlease do let me know if you want to raise a PR for fixing this.",
"@ohbus I have fixed it and raised the PR . Please could you review .\r\n\r\nThanks."
] | [
"```suggestion\r\n[](#contributors)\r\n```\r\n\r\nCan you explain why did you decrease the value of the number of contributors?",
"There was merge conflicts earlier and so to make it consistent with master i reduced... | 2021-05-08T15:14:53Z | [
"info: help wanted",
"info: good first issue",
"epic: documentation"
] | Issue with all contributors badge in Readme.md file | Observed that when we click on the `all contributors` badge on the project page , it does not re-direct us to the sections where all the project contributors are listed .
**Possible fix will be to corr... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index 971fe9073997..8c520b741499 100644
--- a/README.md
+++ b/README.md
@@ -10,7 +10,7 @@
[](https://sonarcloud.io/dashboard?id=iluwatar_java-design-patterns)
[![Join t... | null | train | train | 2021-05-09T16:00:47 | 2021-05-07T14:40:52Z | DEV-VRUPER | train |
iluwatar/java-design-patterns/1821_1823 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1821 | iluwatar/java-design-patterns/1823 | [
"timestamp(timedelta=107.0, similarity=0.8905420145123631)"
] | 42eb7950aef44e00b9a5363e681762a1bf1271c3 | 0ff4e16f0c5ed3960e08df16a6ebb67470bcaf28 | [
"@iluwatar I want to work on this issue. Please assign it to me.",
"Sounds awesome @chandrikadeb7, please go ahead",
"@chandrikadeb7 and @iluwatar While all contributors have been allowing us to mention contributions on the doc, especially the Wiki, I am not sure how or if we will be able to identify them at al... | [] | 2021-10-01T04:04:55Z | [
"type: enhancement",
"resolution: won't fix",
"epic: documentation"
] | Readme Update: Show Project Contributors automatically without adding them in successive commits | - Using dynamic web app [contributors-img](https://contrib.rocks/preview)
- Reduces commits made for successive contributors
- Takes less space in Readme file and increases the count automatically.
**Example screenshot**
![Screenshot 2021-09-30 at 9 35 05 AM](https://user-images.githubusercontent.com/29686102/135... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index c7c137fa3d5c..a28380099c06 100644
--- a/README.md
+++ b/README.md
@@ -74,271 +74,10 @@ This project is licensed under the terms of the MIT license.
<!-- ALL-CONTRIBUTORS-LIST:START - Do not remove or modify this section -->
<!-- prettier-ignore-start -->
<!-- markdownlint-dis... | null | train | train | 2021-09-28T20:43:31 | 2021-09-30T04:10:12Z | chandrikadeb7 | train |
iluwatar/java-design-patterns/1803_1828 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1803 | iluwatar/java-design-patterns/1828 | [
"timestamp(timedelta=0.0, similarity=0.9120354148911209)"
] | 42eb7950aef44e00b9a5363e681762a1bf1271c3 | 57f9c2e9687d959a9753297ab7641ded639947da | [
"Thanks @beooo79 for reporting. Although we currently claim to support only JDK11, I would like to see Lombok in the most recent version. If someone is willing to work on this, update Lombok to the latest version and test that the build and the tests still work.",
"> Thanks @beooo79 for reporting. Although we cur... | [] | 2021-10-03T16:10:18Z | [
"epic: build issue",
"epic: dependencies",
"type: feature"
] | Update Lombok version (possible migration issue for JDK17) | Lombok does not work in the current master branch when using JDK16.
`[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project abstract-factory: Fatal error compiling: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed modul... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index cb726a43e352..3e5e51abfbc5 100644
--- a/pom.xml
+++ b/pom.xml
@@ -71,7 +71,7 @@
<system-lambda.version>1.1.0</system-lambda.version>
<urm.version>2.0.0</urm.version>
<mockito-junit-jupiter.version>3.5.0</mockito-junit-jupiter.version>
- <lombok.vers... | null | train | train | 2021-09-28T20:43:31 | 2021-07-21T06:14:32Z | beooo79 | train |
iluwatar/java-design-patterns/1012_1833 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1012 | iluwatar/java-design-patterns/1833 | [
"connected"
] | ddb9b14eedfe317e4c95571bc5197f2e5e1ed596 | 5a644f1092079f4f0152641b704dec1d668727ff | [
"Can I take this issue?",
"Sure @ykayacan ",
"This issue is free for taking again.",
"I would like to take this issue.",
"Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. \r\n\r\nExam... | [] | 2021-10-04T18:51:15Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports issues | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be u... | [
"async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java",
"bytecode/src/main/java/com/iluwatar/bytecode/App.java",
"caching/src/main/java/com/iluwatar/caching/DbManager.java"
] | [
"async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java",
"bytecode/src/main/java/com/iluwatar/bytecode/App.java",
"caching/src/main/java/com/iluwatar/caching/DbManager.java"
] | [] | diff --git a/async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java b/async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java
index b7d5e386b83a..ca63520be298 100644
--- a/async-method-invocation/src/main/java/com/iluwatar/async/method/invocation/App.java
+++ b/a... | null | train | train | 2021-10-08T19:47:25 | 2019-10-15T17:54:46Z | iluwatar | train |
iluwatar/java-design-patterns/1875_1879 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1875 | iluwatar/java-design-patterns/1879 | [
"keyword_pr_to_issue"
] | 90b1b922e1f60b25e73493f6f71fa6ad8a10fdee | 72bb189dc06d8edd4e8e3ef1a92b9201043087cd | [] | [
"Perhaps this should be called just `build` since the other is called `build-and-analyze`?",
"Here too, maybe we can call it just `Build on JDK 11`",
"I suggest `Build and run Sonar analysis on JDK 11.0.3`",
"This comment is not related to any line, but it would be great to have some comments above the code t... | 2021-10-21T18:28:12Z | [
"type: enhancement",
"epic: build issue"
] | Make a separate build line in for Sonar analysis | I have overlooked that there will be two simultaneous reports generated for Sonar issues which I have overlooked.
- [ ] Dismiss Matrix building of the project.
- [ ] We need to split into two build pipelines, one for running sonar analysis against the latest `zulu` build, and one with the latest JDK build.
- [ ] L... | [
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [] | diff --git a/.github/workflows/maven-ci.yml b/.github/workflows/maven-ci.yml
index 94406095e02a..3b1bcafb0630 100644
--- a/.github/workflows/maven-ci.yml
+++ b/.github/workflows/maven-ci.yml
@@ -24,6 +24,9 @@
# This workflow will build a Java project with Maven
# For more information see: https://help.github.com/acti... | null | train | train | 2021-10-21T20:15:45 | 2021-10-21T15:42:52Z | ohbus | train |
iluwatar/java-design-patterns/1012_1896 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1012 | iluwatar/java-design-patterns/1896 | [
"keyword_pr_to_issue"
] | bee1283371d25dd5f0c5e7d4bac66b4c05f9aeac | 36c6ce1df7f0008c71d82a6eb784df788505a9b3 | [
"Can I take this issue?",
"Sure @ykayacan ",
"This issue is free for taking again.",
"I would like to take this issue.",
"Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. \r\n\r\nExam... | [] | 2021-10-27T17:07:34Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports issues | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be u... | [
"factory-method/src/main/java/com/iluwatar/factory/method/App.java"
] | [
"factory-method/src/main/java/com/iluwatar/factory/method/App.java"
] | [] | diff --git a/factory-method/src/main/java/com/iluwatar/factory/method/App.java b/factory-method/src/main/java/com/iluwatar/factory/method/App.java
index b76a918d1876..d903ee7c7fee 100644
--- a/factory-method/src/main/java/com/iluwatar/factory/method/App.java
+++ b/factory-method/src/main/java/com/iluwatar/factory/metho... | null | train | train | 2021-10-24T16:27:24 | 2019-10-15T17:54:46Z | iluwatar | train |
iluwatar/java-design-patterns/1012_1898 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1012 | iluwatar/java-design-patterns/1898 | [
"keyword_pr_to_issue"
] | 72bb189dc06d8edd4e8e3ef1a92b9201043087cd | 22ddd571467f811e120d37a43dae0edbc9071779 | [
"Can I take this issue?",
"Sure @ykayacan ",
"This issue is free for taking again.",
"I would like to take this issue.",
"Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. \r\n\r\nExam... | [] | 2021-10-28T04:38:30Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports issues | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be u... | [
"strategy/src/main/java/com/iluwatar/strategy/App.java"
] | [
"strategy/src/main/java/com/iluwatar/strategy/App.java"
] | [] | diff --git a/strategy/src/main/java/com/iluwatar/strategy/App.java b/strategy/src/main/java/com/iluwatar/strategy/App.java
index 383712c39806..d54c06008692 100644
--- a/strategy/src/main/java/com/iluwatar/strategy/App.java
+++ b/strategy/src/main/java/com/iluwatar/strategy/App.java
@@ -41,6 +41,10 @@
@Slf4j
public cl... | null | train | train | 2021-10-27T20:44:00 | 2019-10-15T17:54:46Z | iluwatar | train |
iluwatar/java-design-patterns/1908_1909 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1908 | iluwatar/java-design-patterns/1909 | [
"timestamp(timedelta=147.0, similarity=0.8948982414844022)"
] | 0a7b524bd10b0eb67ac6045d12415759b1dc7fd0 | 89b20721316f256994c3194b8dedb589ca6b7362 | [
"I have submitted a PR for fixing this bug, please review. @iluwatar @ohbus "
] | [] | 2021-11-10T06:13:15Z | [
"type: bug",
"epic: pattern"
] | Concurrency problems in leader-followers pattern | I have found a bug in the leader-followers pattern during unit test. In the state of concurrency, there is a small chance that no new leader will be promoted. The reason is that in the worker class, there is no double check before calling the wait method of workercenter. It causes the thread which should become leader ... | [
"leader-followers/src/main/java/com/iluwatar/leaderfollowers/Worker.java"
] | [
"leader-followers/src/main/java/com/iluwatar/leaderfollowers/Worker.java"
] | [] | diff --git a/leader-followers/src/main/java/com/iluwatar/leaderfollowers/Worker.java b/leader-followers/src/main/java/com/iluwatar/leaderfollowers/Worker.java
index 6c7caed244b7..21326bb0a77c 100644
--- a/leader-followers/src/main/java/com/iluwatar/leaderfollowers/Worker.java
+++ b/leader-followers/src/main/java/com/il... | null | train | train | 2021-10-31T08:12:05 | 2021-11-10T06:11:24Z | npczwh | train |
iluwatar/java-design-patterns/1871_1956 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1871 | iluwatar/java-design-patterns/1956 | [
"timestamp(timedelta=0.0, similarity=0.9090095920491283)"
] | dde31bfe349fabf800c2ddcf0ac36e69acf8bf8c | b51bca1a6744f2d18d69f52047e70fd5948131f7 | [
"I strongly recommend @Dev-AliGhasemi to take this up.",
"I do it but @ohbus i don't know where is the problem ! can you give me some tips to solve it ?",
"@Dev-AliGhasemi You need to add your monitor pattern to the parent pom.\r\n\r\nJust like all the patterns are added as modules here in this line. You need t... | [] | 2022-01-29T15:55:16Z | [
"type: bug",
"info: good first issue",
"epic: build issue"
] | Monitor pattern is not being built | In https://github.com/iluwatar/java-design-patterns/pull/1640 we merged the monitor pattern but noticed that it's not included in the main `pom.xml` and not being built. Let's fix that in this issue. | [
"monitor/pom.xml",
"monitor/src/main/java/com/iluwatar/monitor/Bank.java",
"monitor/src/main/java/com/iluwatar/monitor/Main.java",
"pom.xml"
] | [
"monitor/pom.xml",
"monitor/src/main/java/com/iluwatar/monitor/Bank.java",
"monitor/src/main/java/com/iluwatar/monitor/Main.java",
"pom.xml"
] | [
"monitor/src/test/java/com/iluwatar/monitor/BankTest.java",
"monitor/src/test/java/com/iluwatar/monitor/MainTest.java"
] | diff --git a/monitor/pom.xml b/monitor/pom.xml
index f337350190a0..9246f33caff9 100644
--- a/monitor/pom.xml
+++ b/monitor/pom.xml
@@ -21,9 +21,9 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://mave... | diff --git a/monitor/src/main/test/java/com/iluwater/java/BankTest.java b/monitor/src/main/test/java/com/iluwater/java/BankTest.java
deleted file mode 100644
index eab7d7a3c59d..000000000000
--- a/monitor/src/main/test/java/com/iluwater/java/BankTest.java
+++ /dev/null
@@ -1,55 +0,0 @@
-package com.iluwater.java;
-
-im... | test | train | 2022-02-12T19:14:44 | 2021-10-19T17:34:01Z | iluwatar | train |
iluwatar/java-design-patterns/1299_1978 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1299 | iluwatar/java-design-patterns/1978 | [
"timestamp(timedelta=89669.0, similarity=0.8460100922676592)"
] | 4cdc309e65f3a1eae597ecb3b22e5ad6b7abbd41 | f6a8e26f620322de21e0bf3c0cb7bb2c0719c191 | [
"@iluwatar Can I take this? I can probably finish this before this Sunday.",
"⭐ Sure thing! Thanks for your interest in our project 😃 ",
"Hello @iluwatar, @ohbus and @SuperNovaExtrem, I read the links you provided in the issue and I would like to work on this issue.\r\nI found that pull request #1773 already m... | [
"```suggestion\r\ntitle: Identity Field\r\n```",
"Please use the version from the parent pom.xml",
"The configuration seems overly verbose. Can you check how maven-assembly-plugin has been configured in the other patterns?",
"This should be left out. Use the Java version that's coming from the parent pom.xml ... | 2022-04-04T12:22:54Z | [
"epic: pattern",
"type: feature"
] | Identity Map pattern | https://www.sourcecodeexamples.net/2018/04/identity-map-pattern.html
https://en.wikipedia.org/wiki/Identity_map_pattern | [
"pom.xml"
] | [
"identity-field/README.md",
"identity-field/etc/identity-field.puml",
"identity-field/pom.xml",
"identity-field/src/main/java/com/iluwatar/identityfield/App.java",
"identity-field/src/main/java/com/iluwatar/identityfield/Person.java",
"pom.xml"
] | [
"identity-field/src/test/java/com/iluwatar/identityfield/AppTest.java",
"identity-field/src/test/java/com/iluwatar/identityfield/PersonTest.java"
] | diff --git a/identity-field/README.md b/identity-field/README.md
new file mode 100644
index 000000000000..055d6a685b39
--- /dev/null
+++ b/identity-field/README.md
@@ -0,0 +1,64 @@
+---
+layout: pattern
+title: Identity-Field
+folder: identity-field
+permalink: /patterns/identity-fields/
+categories: Structural
+tags:
... | diff --git a/identity-field/src/test/java/com/iluwatar/identityfield/AppTest.java b/identity-field/src/test/java/com/iluwatar/identityfield/AppTest.java
new file mode 100644
index 000000000000..955618df68c9
--- /dev/null
+++ b/identity-field/src/test/java/com/iluwatar/identityfield/AppTest.java
@@ -0,0 +1,41 @@
+/*
+ *... | train | train | 2022-04-16T19:46:59 | 2020-07-07T17:38:27Z | iluwatar | train |
iluwatar/java-design-patterns/1957_1994 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1957 | iluwatar/java-design-patterns/1994 | [
"keyword_pr_to_issue"
] | 4cdc309e65f3a1eae597ecb3b22e5ad6b7abbd41 | a143af638c04cf8797e9788d1d66111d7bfe35f1 | [
"@MaheshMadushan can you explain what this issue is about?",
"Hi @iluwatar , There is a small casting issue. \r\n\r\n",
"Hi @MaheshMadushan @iluwatar .\r\nI'm beginner in java and during learning the j... | [] | 2022-05-06T02:15:26Z | [
"type: bug",
"info: good first issue",
"epic: code quality"
] | Casting Issue | 
| [
"circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java"
] | [
"circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java"
] | [] | diff --git a/circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java b/circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java
index 2194d75cbd2a..8c59f394bee1 100644
--- a/circuit-breaker/src/main/java/com/iluwatar/circuitbreaker/DefaultCircuitBreaker.java
+++ ... | null | train | train | 2022-04-16T19:46:59 | 2022-01-30T02:53:04Z | MaheshMadushan | train |
iluwatar/java-design-patterns/1968_2023 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1968 | iluwatar/java-design-patterns/2023 | [
"keyword_pr_to_issue"
] | 5edcb2341c67feb003c5a5510fc4e6a0c6dcecb6 | a568656036a135492bfe35ba767b77e52e9d3019 | [
"By the way, happy to pick this fix up if you all agree that this is indeed an issue 😄 ",
"Thanks for raising the issue @yonatankarp. I'd like to see the improvement implemented.",
"After reading a bit deeper about this design pattern in multiple sources (see below), it seems like the design itself is (almost)... | [] | 2022-09-10T15:52:41Z | [
"epic: pattern",
"type: enhancement"
] | Visitor pattern code example violate SOLID | In the current example of the Visitor patter the `UnitVisitor` described as follow:
```java
public interface UnitVisitor {
void visitSoldier(Soldier soldier);
void visitSergeant(Sergeant sergeant);
void visitCommander(Commander commander);
}
```
This interface violate the interface segregation p... | [
"visitor/README.md",
"visitor/src/main/java/com/iluwatar/visitor/Commander.java",
"visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java",
"visitor/src/main/java/com/iluwatar/visitor/Sergeant.java",
"visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java",
"visitor/src/main/java/com/il... | [
"visitor/README.md",
"visitor/src/main/java/com/iluwatar/visitor/Commander.java",
"visitor/src/main/java/com/iluwatar/visitor/CommanderVisitor.java",
"visitor/src/main/java/com/iluwatar/visitor/Sergeant.java",
"visitor/src/main/java/com/iluwatar/visitor/SergeantVisitor.java",
"visitor/src/main/java/com/il... | [
"visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java",
"visitor/src/test/java/com/iluwatar/visitor/SergeantTest.java",
"visitor/src/test/java/com/iluwatar/visitor/SoldierTest.java",
"visitor/src/test/java/com/iluwatar/visitor/VisitorTest.java"
] | diff --git a/visitor/README.md b/visitor/README.md
index 38df87d284cc..dae82966bf0f 100644
--- a/visitor/README.md
+++ b/visitor/README.md
@@ -72,7 +72,7 @@ public class Commander extends Unit {
@Override
public void accept(UnitVisitor visitor) {
- visitor.visitCommander(this);
+ visitor.visit(this);
... | diff --git a/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java b/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java
index 1e68955509f5..a6054f7244f3 100644
--- a/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java
+++ b/visitor/src/test/java/com/iluwatar/visitor/CommanderTest.java
@@ -4... | train | train | 2022-09-10T15:43:39 | 2022-02-26T18:32:18Z | yonatankarp | train |
iluwatar/java-design-patterns/2034_2038 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2034 | iluwatar/java-design-patterns/2038 | [
"timestamp(timedelta=132.0, similarity=0.8836069126259878)"
] | 7e87cf9005edea0cedb354e305598eb3feb18f65 | 57fe447f9c0f0ca07a65adafdadcae808d2be344 | [
"@iluwatar : I will update those hotfixes for java 17. Will create separate branch and create pr for the same.",
"Ok @karshil2309 "
] | [] | 2022-09-30T19:48:22Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies",
"type: feature"
] | Upgrade Lombok version to support Java 17 | This issue is a part of the Java 17 transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition.
According to https://github.com/projectlombok/lombok/issues/2898, Lombok supports Java 17 since version 1.18.22. Our version is a bit behind that, so let's upgrade to the latest.
Ac... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index a9477de828d8..3e02bfd45eb2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -66,7 +66,7 @@
<system-lambda.version>1.1.0</system-lambda.version>
<urm.version>2.0.0</urm.version>
<mockito-junit-jupiter.version>3.5.0</mockito-junit-jupiter.version>
- <lombok.version>1.18.20</lom... | null | train | train | 2022-09-25T20:16:42 | 2022-09-28T16:17:38Z | iluwatar | train |
iluwatar/java-design-patterns/2045_2046 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2045 | iluwatar/java-design-patterns/2046 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9312632156071167)"
] | 7e87cf9005edea0cedb354e305598eb3feb18f65 | 84f733d137313af6f9bf1847fa140b07ea390d1f | [
"Ok @aitorfi "
] | [] | 2022-10-02T10:31:21Z | [
"epic: web site",
"info: good first issue",
"type: feature",
"epic: documentation"
] | Translate abstract-document readme to Spanish | I'll translate the readme file of the abstract-document design pattern to Spanish and place it under localization.es.abstract-document. | [] | [
"localization/es/abstract-document/README.md"
] | [] | diff --git a/localization/es/abstract-document/README.md b/localization/es/abstract-document/README.md
new file mode 100644
index 000000000000..f9b698b939cc
--- /dev/null
+++ b/localization/es/abstract-document/README.md
@@ -0,0 +1,183 @@
+---
+layout: pattern
+title: Abstract Document
+folder: abstract-document
+perma... | null | train | train | 2022-09-25T20:16:42 | 2022-10-02T09:29:24Z | aitorfi | train |
iluwatar/java-design-patterns/1099_2057 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1099 | iluwatar/java-design-patterns/2057 | [
"keyword_issue_to_pr"
] | 4c1f5cf7fe8cf4ecd427fb5603158bbe17a51406 | 67f01d43aaa06a8b1191e55665f3fa5b6805c1c9 | [
"Yes, I agree with you.",
"That‘s right.",
"@iluwatar can you please assign this to me?",
"@iluwatar @dgruntz \r\nwhere would you want to put this new comment?\r\n`To make sure that subclasses don’t override the template method, we should make it final.`",
"I do not want to add this comment but rather chang... | [] | 2022-10-05T09:23:02Z | [
"type: enhancement",
"info: good first issue",
"epic: design"
] | Template Method | As statet in the referenced tutorial [Template-method Pattern Tutorial](https://www.journaldev.com/1763/template-method-design-pattern-in-java)
I would add a note in the pattern description that the template method should be declared `final`.
> To make sure that subclasses don’t override the template method, we sh... | [
"template-method/README.md",
"template-method/pom.xml",
"template-method/src/main/java/com/iluwatar/templatemethod/StealingMethod.java"
] | [
"template-method/README.md",
"template-method/pom.xml",
"template-method/src/main/java/com/iluwatar/templatemethod/StealingMethod.java"
] | [
"template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java"
] | diff --git a/template-method/README.md b/template-method/README.md
index 7209176f2255..ba34441e0ca8 100644
--- a/template-method/README.md
+++ b/template-method/README.md
@@ -39,6 +39,10 @@ Wikipedia says
**Programmatic Example**
Let's first introduce the template method class along with its concrete implementation... | diff --git a/template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java b/template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java
index eaf7699acffd..9f802597394e 100644
--- a/template-method/src/test/java/com/iluwatar/templatemethod/HalflingThiefTest.java
+++ b/template-m... | train | val | 2022-10-04T19:42:31 | 2019-11-17T14:25:21Z | dgruntz | train |
iluwatar/java-design-patterns/2066_2072 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2066 | iluwatar/java-design-patterns/2072 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9493204817788601)"
] | ec07dda65899c5bdcd079a6513e4138b6a96c1a5 | d43b21472dfd18ca07ca9f9ec30c31ef0ab2af3c | [
"All right @aitorfi ",
"Hello Sir,\r\nI would like to contribute to this project,\r\nI am new to hacktoctoberfest and this would be a great beginning.\r\nThank you..."
] | [] | 2022-10-09T10:10:33Z | [
"epic: web site",
"info: good first issue",
"type: feature",
"epic: documentation"
] | Translate the abstract-factory readme to Spanish | I'll translate the readme file of the abstract-factory design pattern to Spanish and place it under localization.es.abstract-factory. | [
"localization/es/abstract-document/README.md"
] | [
"localization/es/abstract-document/README.md",
"localization/es/abstract-factory/README.md"
] | [] | diff --git a/localization/es/abstract-document/README.md b/localization/es/abstract-document/README.md
index f9b698b939cc..2baf94551b09 100644
--- a/localization/es/abstract-document/README.md
+++ b/localization/es/abstract-document/README.md
@@ -21,7 +21,7 @@ Ejemplo del mundo real
> Toma como ejemplo un coche que... | null | val | val | 2022-10-09T09:00:16 | 2022-10-08T15:05:32Z | aitorfi | train |
iluwatar/java-design-patterns/2054_2073 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2054 | iluwatar/java-design-patterns/2073 | [
"keyword_pr_to_issue"
] | ec07dda65899c5bdcd079a6513e4138b6a96c1a5 | 09f97206a72f8e13a4da6b3d998bd94802afd43e | [] | [] | 2022-10-09T11:48:53Z | [
"type: bug",
"epic: build issue",
"epic: code quality"
] | Sonar analysis failing due to obsolete Node version | This came up in a recent pull request build:
> [ERROR] Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.8.0.2131:sonar (default-cli) on project java-design-patterns:
> [ERROR]
> [ERROR] The version of node.js (12) you have used to run this analysis is deprecated and we stopped accepting it... | [
".circleci/config.yml"
] | [
".circleci/config.yml"
] | [] | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 3e35aee712dd..dad7997a8699 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -26,12 +26,14 @@ version: 2
jobs:
sonar-pr:
docker:
- - image: circleci/openjdk:11-node
+ - image: cimg/openjdk:11.0-node
steps:
- checko... | null | train | val | 2022-10-09T09:00:16 | 2022-10-04T17:23:28Z | iluwatar | train |
iluwatar/java-design-patterns/2077_2078 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2077 | iluwatar/java-design-patterns/2078 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9470861963188459)"
] | 8a7c7b6f21200e33d724fff350c8449964d02c08 | 505454cbae5fbb58bfd2df51beb48b3307c4f6e6 | [
"Ok @aitorfi ",
"Hello Sir,\r\nI would like to contribute to this project,\r\nI am new to hacktoctoberfest and this would be a great beginning.\r\nThank you...",
"Hello Sir\r\nI want to contribute in this project.\r\nIt will be a great beginning for me if you assign me this issue.\r\nThank you"
] | [] | 2022-10-09T19:50:28Z | [
"epic: web site",
"info: good first issue",
"type: feature",
"epic: documentation"
] | Translate the active-object readme to Spanish | I'll translate the readme file of the active-object design pattern to Spanish and place it under localization.es.active-object. | [] | [
"localization/es/active-object/README.md"
] | [] | diff --git a/localization/es/active-object/README.md b/localization/es/active-object/README.md
new file mode 100644
index 000000000000..617d07b77eab
--- /dev/null
+++ b/localization/es/active-object/README.md
@@ -0,0 +1,130 @@
+---
+layout: pattern
+title: Active Object
+folder: active-object
+permalink: /patterns/acti... | null | test | val | 2022-10-09T19:49:58 | 2022-10-09T19:09:23Z | aitorfi | train |
iluwatar/java-design-patterns/2089_2090 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2089 | iluwatar/java-design-patterns/2090 | [
"timestamp(timedelta=1.0, similarity=0.9474253277262119)",
"keyword_pr_to_issue"
] | 1e232d855267274a0dd7b2d46ab11728015612b8 | 03feaa9faf7bb8de209b8fa72a8d3559629e6c64 | [] | [] | 2022-10-14T14:33:18Z | [
"info: good first issue",
"type: feature",
"epic: documentation"
] | Translate the acyclic-visitor readme to Spanish | I'll translate the readme file of the acyclic-visitor design pattern to Spanish and place it under localization.es.acyclic-visitor. | [] | [
"localization/es/acyclic-visitor/README.md"
] | [] | diff --git a/localization/es/acyclic-visitor/README.md b/localization/es/acyclic-visitor/README.md
new file mode 100644
index 000000000000..08d016b80430
--- /dev/null
+++ b/localization/es/acyclic-visitor/README.md
@@ -0,0 +1,162 @@
+---
+layout: pattern
+title: Acyclic Visitor
+folder: acyclic-visitor
+permalink: /pat... | null | val | val | 2022-10-10T18:28:06 | 2022-10-14T13:14:28Z | aitorfi | train |
iluwatar/java-design-patterns/2096_2099 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2096 | iluwatar/java-design-patterns/2099 | [
"timestamp(timedelta=1.0, similarity=0.9787524512303212)"
] | 1e232d855267274a0dd7b2d46ab11728015612b8 | 250bb5be3fc351231b3f9ce93946706facf71082 | [
"Also, I noticed that a lot of modules in the project has the same situation, should we create one issue per each, since a module is not coupled or you suggest another approach @iluwatar ",
"I have opened 2 PRS, haven't noticed the bot who handles contributors (sorry about that)",
"> Also, I noticed that a lot ... | [] | 2022-10-16T14:48:05Z | [
"type: enhancement",
"info: good first issue",
"epic: code quality"
] | Add lombok to data-transfer-object pattern | I noticed that the pattern is well written but is using a lot of getters and setters without need. We can add lombok to it and have it cleaner to read and understand | [
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java",
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/product/Product.java",
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/product/ProductResource.java"
] | [
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java",
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/product/Product.java",
"data-transfer-object/src/main/java/com/iluwatar/datatransfer/product/ProductResource.java"
] | [] | diff --git a/data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java b/data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java
index 8a731303a664..e9164600ce7e 100644
--- a/data-transfer-object/src/main/java/com/iluwatar/datatransfer/App.java
+++ b/data-transfer-object/src/main/java/com/iluw... | null | test | val | 2022-10-10T18:28:06 | 2022-10-16T14:17:52Z | burno1 | train |
iluwatar/java-design-patterns/2107_2108 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2107 | iluwatar/java-design-patterns/2108 | [
"timestamp(timedelta=2.0, similarity=0.9866990623376677)"
] | 505454cbae5fbb58bfd2df51beb48b3307c4f6e6 | 3454a9817509ab455a14cf73fb367e591ff717a2 | [
"PR created, waiting for review."
] | [] | 2022-10-17T13:15:30Z | [
"type: enhancement",
"info: good first issue",
"epic: code quality"
] | Add lombok to step-builder pattern | This pattern doesn't have lombok added to it, we should add to have cleaner code. | [
"step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java"
] | [
"step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java"
] | [] | diff --git a/step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java b/step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java
index 6f04fc09d6eb..05ba3e733c48 100644
--- a/step-builder/src/main/java/com/iluwatar/stepbuilder/Character.java
+++ b/step-builder/src/main/java/com/iluwatar/stepbuilder/... | null | test | val | 2022-10-16T18:25:36 | 2022-10-17T13:14:10Z | burno1 | train |
iluwatar/java-design-patterns/2082_2109 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2082 | iluwatar/java-design-patterns/2109 | [
"timestamp(timedelta=1.0, similarity=0.9237463224564836)"
] | 505454cbae5fbb58bfd2df51beb48b3307c4f6e6 | 608f6d21cf94cb7a8621b910d865df415b34ed1a | [
"!assign\r\n",
"Ok @seongkyu-lim ",
"Hello Sir,\r\nI would like to contribute to this project,\r\nI am new to hacktoctoberfest and this would be a great beginning.\r\nThank you...",
"Hello sir,\r\nCan you please assign me this issue."
] | [] | 2022-10-17T15:05:44Z | [
"info: good first issue",
"type: feature",
"epic: documentation"
] | Translate template-method pattern readme to Korean | I'll translate the readme file of the template-method design pattern to Korean and place it under localization/ko/template-method. | [] | [
"localization/ko/template-method/README.md"
] | [] | diff --git a/localization/ko/template-method/README.md b/localization/ko/template-method/README.md
new file mode 100644
index 000000000000..4aeae0c3c738
--- /dev/null
+++ b/localization/ko/template-method/README.md
@@ -0,0 +1,148 @@
+---
+layout: pattern
+title: Template method
+folder: template-method
+permalink: /pat... | null | train | val | 2022-10-16T18:25:36 | 2022-10-11T13:48:28Z | seongkyu-lim | train |
iluwatar/java-design-patterns/2124_2126 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2124 | iluwatar/java-design-patterns/2126 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.945691482234587)"
] | 3dcda6f2457b27e4b0652ddd9f07e9c6b5b6d4c1 | df52e1fd4e57abde9356b581e4b0f87d5eba5ccd | [
"Ok @aitorfi ",
"Subtask of #2277 "
] | [
"Please check the new yaml frontmatter requirements at https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute"
] | 2022-10-19T20:37:48Z | [
"info: good first issue",
"epic: documentation"
] | Translate the adapter readme to Spanish | I'll translate the readme file of the adapter design pattern to Spanish and place it under localization.es.adapter. | [
"adapter/README.md"
] | [
"adapter/README.md",
"localization/es/adapter/README.md"
] | [] | diff --git a/adapter/README.md b/adapter/README.md
index 2539d0b45fee..7fa4af751b32 100644
--- a/adapter/README.md
+++ b/adapter/README.md
@@ -112,12 +112,12 @@ Use the Adapter pattern when
Class and object adapters have different trade-offs. A class adapter
* Adapts Adaptee to Target by committing to a concrete Ad... | null | val | val | 2022-10-26T19:43:25 | 2022-10-19T19:12:52Z | aitorfi | train |
iluwatar/java-design-patterns/1261_2134 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1261 | iluwatar/java-design-patterns/2134 | [
"timestamp(timedelta=141.0, similarity=0.8914670140645583)"
] | 03feaa9faf7bb8de209b8fa72a8d3559629e6c64 | fcaf72fdf8ccfe4da7d4207f6c042d1a43b3d535 | [
"Hello, I would like to work on this issue. I manage to finish it within a month.",
"Great to have you onboarded @santyelegy!\r\n\r\nWe are expecting the PR for this by the end of May '21",
"Hey @iluwatar, may I please pick up on this issue? I am interested in working on this.",
"Ok @JoshuaSinglaANU ",
"@il... | [
"Check out yaml frontmatter requirements at https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute",
"I suggest category `Idiom` and tags `Generic`. See https://github.com/iluwatar/java-design-patterns/wiki/07.-Categories-and-Tags",
"```suggestion\r\n## Name\r\n```",
"```suggestion\r\nIn ... | 2022-10-21T13:10:21Z | [
"epic: pattern",
"type: feature"
] | Collecting Parameter pattern | https://wiki.c2.com/?CollectingParameter | [
"pom.xml"
] | [
"collecting-parameter/README.md",
"collecting-parameter/etc/collecting-parameter.urm.puml",
"collecting-parameter/pom.xml",
"collecting-parameter/src/main/java/com/iluwatar/collectingparameter/App.java",
"collecting-parameter/src/main/java/com/iluwatar/collectingparameter/PaperSizes.java",
"collecting-par... | [
"collecting-parameter/src/test/java/com/iluwatar/collectingparameter/AppTest.java",
"collecting-parameter/src/test/java/com/iluwatar/collectingparameter/CollectingParameterTest.java",
"collecting-parameter/src/test/java/com/iluwatar/collectingparameter/PrinterQueueTest.java"
] | diff --git a/collecting-parameter/README.md b/collecting-parameter/README.md
new file mode 100644
index 000000000000..a57b8d2991da
--- /dev/null
+++ b/collecting-parameter/README.md
@@ -0,0 +1,197 @@
+---
+title: Collecting Parameter
+category: Idiom
+language: en
+tags:
+- Generic
+---
+
+## Name
+Collecting Paramete... | diff --git a/collecting-parameter/src/test/java/com/iluwatar/collectingparameter/AppTest.java b/collecting-parameter/src/test/java/com/iluwatar/collectingparameter/AppTest.java
new file mode 100644
index 000000000000..57f9037778ae
--- /dev/null
+++ b/collecting-parameter/src/test/java/com/iluwatar/collectingparameter/A... | train | val | 2022-10-17T19:34:33 | 2020-07-07T15:42:55Z | iluwatar | train |
iluwatar/java-design-patterns/1275_2150 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1275 | iluwatar/java-design-patterns/2150 | [
"timestamp(timedelta=382.0, similarity=0.9292875799799427)",
"keyword_pr_to_issue"
] | 953f9a4e0c0acf12342937bb96fe724393189875 | b103e44ecd61c24f9eb0550fe01d6ca2419b6abd | [
"Hi iluwatar, I'd like to volunteer to take a crack at this and try to fix in November/December if you're okay with that.",
"I'm happy to hear you're interested @komminen. You're welcome to take a shot!",
"Can I take this?",
"Ok, you're assigned @JurenXu ",
"> Ok, you're assigned @JurenXu\r\n\r\nThank you! ... | [
"Please check the updated YAML frontmatter requirements in https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute",
"Describe the pattern and explain how this example implements it",
"We need comments explaining what is going on",
"Use logger",
"Use logger",
"> Use logger\r\n\r\nI hav... | 2022-10-23T15:37:51Z | [
"epic: pattern",
"type: feature"
] | Serialized Entity pattern | https://www.oreilly.com/library/view/j2ee-design-patterns/0596004273/re21.html | [
"pom.xml",
"servant/pom.xml"
] | [
"pom.xml",
"serialized-entity/README.md",
"serialized-entity/etc/serialize-entity.urm.puml",
"serialized-entity/pom.xml",
"serialized-entity/src/main/java/com/iluwatar/serializedentity/App.java",
"serialized-entity/src/main/java/com/iluwatar/serializedentity/Country.java",
"serialized-entity/src/main/ja... | [
"serialized-entity/src/test/java/com/iluwatar/serializedentity/AppTest.java",
"serialized-entity/src/test/java/com/iluwatar/serializedentity/CountryTest.java"
] | diff --git a/pom.xml b/pom.xml
index 7ed97bcae754..c0ead428cba0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -215,6 +215,7 @@
<module>composite-view</module>
<module>metadata-mapping</module>
<module>service-to-worker</module>
+ <module>serialized-entity</module>
<module>identity-map</module>
</modul... | diff --git a/serialized-entity/src/test/java/com/iluwatar/serializedentity/AppTest.java b/serialized-entity/src/test/java/com/iluwatar/serializedentity/AppTest.java
new file mode 100644
index 000000000000..52ac9cd6e026
--- /dev/null
+++ b/serialized-entity/src/test/java/com/iluwatar/serializedentity/AppTest.java
@@ -0,... | train | val | 2022-11-13T08:19:39 | 2020-07-07T16:31:44Z | iluwatar | train |
iluwatar/java-design-patterns/1288_2155 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1288 | iluwatar/java-design-patterns/2155 | [
"timestamp(timedelta=1.0, similarity=0.8645788493327409)",
"keyword_pr_to_issue"
] | 9c4829ea56ebeaf54deda9445a0ef0a0ac3c269c | fd402fc876613282aaf855fd8fb5b92413af8522 | [
"I would like to work on this issue. Could you assign me this?",
"Yes, please go ahead @nakul251197 ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\n",
"@nakul251197, the PR build i... | [
"See the YAML frontmatter requirements in https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute\r\n\r\nPlease pick the category and the tags from the existing list, if applicable. See https://github.com/iluwatar/java-design-patterns/wiki/07.-Categories-and-Tags",
"Please add at least the pro... | 2022-10-24T14:04:23Z | [
"epic: pattern",
"type: feature"
] | Client Session State pattern | https://dzone.com/articles/practical-php-patterns/practical-php-patterns-client | [
"pom.xml"
] | [
"client-session/README.md",
"client-session/pom.xml",
"client-session/src/main/java/com/iluwatar/client/session/App.java",
"client-session/src/main/java/com/iluwatar/client/session/Request.java",
"client-session/src/main/java/com/iluwatar/client/session/Server.java",
"client-session/src/main/java/com/iluw... | [
"client-session/src/test/java/com/iluwatar/client/session/AppTest.java",
"client-session/src/test/java/com/iluwatar/client/session/ServerTest.java"
] | diff --git a/client-session/README.md b/client-session/README.md
new file mode 100644
index 000000000000..82204eb3495d
--- /dev/null
+++ b/client-session/README.md
@@ -0,0 +1,114 @@
+---
+title: Client Session Pattern
+category: Architectural
+language: en
+tags:
+- Decoupling
+---
+
+## Name
+
+[Client Session pattern... | diff --git a/client-session/src/test/java/com/iluwatar/client/session/AppTest.java b/client-session/src/test/java/com/iluwatar/client/session/AppTest.java
new file mode 100644
index 000000000000..0e33f74f460b
--- /dev/null
+++ b/client-session/src/test/java/com/iluwatar/client/session/AppTest.java
@@ -0,0 +1,38 @@
+/*
... | val | val | 2022-12-29T10:22:22 | 2020-07-07T17:18:53Z | iluwatar | train |
iluwatar/java-design-patterns/1762_2165 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1762 | iluwatar/java-design-patterns/2165 | [
"keyword_pr_to_issue"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | 13cb2e8d482d2e6505d8d68722625e5af220c40f | [
"Thank you so much for your interest @marouaneaba.\r\n\r\nPlease let us know if you are willing to work on this issue.",
"I'm not entirely sure what we need to do here. Please elaborate @marouaneaba what pattern are you referring to and where exactly do you see a problem?",
"> Ambiguity mapper pattern definitio... | [] | 2022-10-25T12:11:47Z | [
"type: enhancement",
"epic: documentation"
] | Ambiguity mapper pattern definition. | Ambiguity mapper pattern definition.
Defining the mapper model for a specific problem case (fetching data) that produces a definition is not correct.
we need an explanation on how/why to use this design template. | [
"data-mapper/README.md"
] | [
"data-mapper/README.md"
] | [] | diff --git a/data-mapper/README.md b/data-mapper/README.md
index 7766ca0b625c..b36414807612 100644
--- a/data-mapper/README.md
+++ b/data-mapper/README.md
@@ -3,21 +3,53 @@ title: Data Mapper
category: Architectural
language: en
tags:
- - Decoupling
+- Decoupling
---
## Intent
A layer of mappers that mo... | null | val | val | 2022-10-23T15:29:49 | 2021-05-20T00:21:47Z | marouaneaba | train |
iluwatar/java-design-patterns/2160_2171 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2160 | iluwatar/java-design-patterns/2171 | [
"timestamp(timedelta=1.0, similarity=0.8968537004113961)"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | e063bd14e032fd1de78f17dc473a61642c76e75e | [
"Ok @seongkyu-lim ",
"Subtask of #2282 "
] | [] | 2022-10-26T04:57:29Z | [
"info: good first issue",
"type: feature",
"epic: documentation"
] | I'll translate the readme file of the proxy design pattern to Korean | I'll translate the readme file of the proxy design pattern to Korean and place it under localization/ko/proxy.
| [] | [
"localization/ko/proxy/README.md"
] | [] | diff --git a/localization/ko/proxy/README.md b/localization/ko/proxy/README.md
new file mode 100644
index 000000000000..95eb9dca992b
--- /dev/null
+++ b/localization/ko/proxy/README.md
@@ -0,0 +1,160 @@
+---
+title: Proxy
+category: Structural
+language: ko
+tags:
+- Gang Of Four
+- Decoupling
+---
+
+## 또한 ~으로 알려진
+
+... | null | train | val | 2022-10-23T15:29:49 | 2022-10-25T03:02:48Z | seongkyu-lim | train |
iluwatar/java-design-patterns/2161_2172 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2161 | iluwatar/java-design-patterns/2172 | [
"timestamp(timedelta=0.0, similarity=0.8990843545354169)"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | d9b4965eb94cf96693a765ebce7450a76f967836 | [
"Ok @seongkyu-lim ",
"Subtask of #2282 "
] | [] | 2022-10-26T04:58:12Z | [
"info: good first issue",
"type: feature",
"epic: documentation"
] | I'll translate the readme file of the builder design pattern to Korean | I'll translate the readme file of the builder design pattern to Korean and place it under localization/ko/builder.
| [] | [
"localization/ko/builder/README.md"
] | [] | diff --git a/localization/ko/builder/README.md b/localization/ko/builder/README.md
new file mode 100644
index 000000000000..25a93f5fe0fb
--- /dev/null
+++ b/localization/ko/builder/README.md
@@ -0,0 +1,144 @@
+---
+title: Builder
+category: Creational
+language: ko
+tags:
+- Gang of Four
+---
+
+## 의도
+
+동일한 구성 프로세스가 ... | null | train | val | 2022-10-23T15:29:49 | 2022-10-25T03:04:07Z | seongkyu-lim | train |
iluwatar/java-design-patterns/2162_2173 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2162 | iluwatar/java-design-patterns/2173 | [
"timestamp(timedelta=1.0, similarity=0.9050173816098842)"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | cfeee239570226f50b857770676686bc65b495df | [
"Thanks for contributing back to the community @seongkyu-lim 😄 Looking forward to the next pull request!",
"Subtask of #2282 "
] | [] | 2022-10-26T04:59:52Z | [
"info: good first issue",
"type: feature",
"epic: documentation"
] | I'll translate the readme file of the iterator design pattern to Korean | I'll translate the readme file of the iterator design pattern to Korean and place it under localization/ko/iterator.
---
Contributing to the repo is almost my first contribution.
And I realized that contributing to translation helped me a lot in my own learning.
Thank you for creating this opportunity! @iluwatar ... | [] | [
"localization/ko/iterator/README.md"
] | [] | diff --git a/localization/ko/iterator/README.md b/localization/ko/iterator/README.md
new file mode 100644
index 000000000000..54f2e564032e
--- /dev/null
+++ b/localization/ko/iterator/README.md
@@ -0,0 +1,150 @@
+---
+title: Iterator
+categories: Behavioral
+language: ko
+tags:
+- Gang of Four
+---
+
+## 또한 ~으로 알려진
+
+... | null | train | val | 2022-10-23T15:29:49 | 2022-10-25T03:07:00Z | seongkyu-lim | train |
iluwatar/java-design-patterns/1012_2175 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1012 | iluwatar/java-design-patterns/2175 | [
"keyword_pr_to_issue"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | 925996fcbde0465c2dcca5068a6a90420fcc8535 | [
"Can I take this issue?",
"Sure @ykayacan ",
"This issue is free for taking again.",
"I would like to take this issue.",
"Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. \r\n\r\nExam... | [] | 2022-10-26T09:58:11Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports issues | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be u... | [
"composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java"
] | [
"composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java"
] | [] | diff --git a/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java b/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java
index 02aeab1b3497..7de1982a31bb 100644
--- a/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java
+++ b/composite-view/src/main/java/com/iluw... | null | test | val | 2022-10-23T15:29:49 | 2019-10-15T17:54:46Z | iluwatar | train |
iluwatar/java-design-patterns/1012_2176 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1012 | iluwatar/java-design-patterns/2176 | [
"timestamp(timedelta=320.0, similarity=0.8876821951891944)",
"keyword_pr_to_issue"
] | 4108f86177254b72cec4f05c3c2e0dab35e63536 | 6f21b1060767e6cbc222430f6f4eb5af3fd24226 | [
"Can I take this issue?",
"Sure @ykayacan ",
"This issue is free for taking again.",
"I would like to take this issue.",
"Through out checking the files causing issues on SonarCloud, I've encountered test cases that are not properly named to the functionality that they are to be tested against. \r\n\r\nExam... | [] | 2022-10-26T10:49:10Z | [
"type: bug",
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | SonarCloud reports issues | The project is using SonarCloud static code analysis. The latest results are showing that it has found several blockers and critical severity code smells (major, minor, and info level we ignore). In this task, those are fixed or marked as false positives. To mark false positives, SuppressWarnings annotation should be u... | [
"special-case/src/main/java/com/iluwatar/specialcase/App.java"
] | [
"special-case/src/main/java/com/iluwatar/specialcase/App.java"
] | [] | diff --git a/special-case/src/main/java/com/iluwatar/specialcase/App.java b/special-case/src/main/java/com/iluwatar/specialcase/App.java
index 43157d9ab395..5c6a10602543 100644
--- a/special-case/src/main/java/com/iluwatar/specialcase/App.java
+++ b/special-case/src/main/java/com/iluwatar/specialcase/App.java
@@ -37,6 ... | null | val | val | 2022-10-23T15:29:49 | 2019-10-15T17:54:46Z | iluwatar | train |
iluwatar/java-design-patterns/2141_2186 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2141 | iluwatar/java-design-patterns/2186 | [
"keyword_issue_to_pr"
] | 3dcda6f2457b27e4b0652ddd9f07e9c6b5b6d4c1 | 370d851ab0c9b5fb8448088c631953dbe1768699 | [
"Ok @m-inh ",
"Hi @iluwatar , I have opened a PR #2186 to close this issue, pls take a look when you have time, thanks",
"Subtask of #2288",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributi... | [] | 2022-10-27T16:46:14Z | [
"info: good first issue",
"status: stale",
"epic: documentation"
] | Translate abstract-factory pattern to Vietnamese | I would like to translate `abstract-factory` pattern to Vietnamese and add it under `/localization/vi/` folder. | [] | [
"localization/vi/abstract-factory/README.md"
] | [] | diff --git a/localization/vi/abstract-factory/README.md b/localization/vi/abstract-factory/README.md
new file mode 100644
index 000000000000..25be6d86f860
--- /dev/null
+++ b/localization/vi/abstract-factory/README.md
@@ -0,0 +1,230 @@
+---
+title: Abstract Factory
+category: Creational
+language: vi
+tags:
+ - Gang of... | null | test | val | 2022-10-26T19:43:25 | 2022-10-22T11:23:53Z | m-inh | train |
iluwatar/java-design-patterns/2187_2188 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2187 | iluwatar/java-design-patterns/2188 | [
"timestamp(timedelta=2.0, similarity=0.9880140783072036)",
"keyword_pr_to_issue"
] | 3dcda6f2457b27e4b0652ddd9f07e9c6b5b6d4c1 | 3fde35ac77467c98c0ec4e89ed6638a18d95035d | [
"Ok @burno1 "
] | [] | 2022-10-27T23:55:17Z | [
"info: good first issue",
"type: refactoring",
"epic: code quality"
] | Add lombok to MVC pattern | The pattern currently runs without lombok, I'm adding it so we can have the code more similar to new generation code | [
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/Fatigue.java",
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/GiantModel.java",
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/Health.java",
"model-view-controller/src/main/java/com/iluwat... | [
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/Fatigue.java",
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/GiantModel.java",
"model-view-controller/src/main/java/com/iluwatar/model/view/controller/Health.java",
"model-view-controller/src/main/java/com/iluwat... | [] | diff --git a/model-view-controller/src/main/java/com/iluwatar/model/view/controller/Fatigue.java b/model-view-controller/src/main/java/com/iluwatar/model/view/controller/Fatigue.java
index 0cf9941ce4c3..00cced2407a2 100644
--- a/model-view-controller/src/main/java/com/iluwatar/model/view/controller/Fatigue.java
+++ b/m... | null | train | val | 2022-10-26T19:43:25 | 2022-10-27T23:53:54Z | burno1 | train |
iluwatar/java-design-patterns/2269_2270 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2269 | iluwatar/java-design-patterns/2270 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8840390487492057)"
] | e4990df5816ca6c9f016e9a1414fe5d01f033183 | f8a3d93f33b5c4150af4483db937ae7c05a2a545 | [] | [] | 2022-10-29T20:55:02Z | [
"type: task"
] | Integrate stale bot | There is a handy [stale bot](https://github.com/probot/stale) that can monitor issues and pull requests and mark them as stale when nothing happens for a period of time. Let's integrate it in this issue.
Acceptance criteria
- Stale bot has been integrated into the repository
| [] | [
".github/stale.yml"
] | [] | diff --git a/.github/stale.yml b/.github/stale.yml
new file mode 100644
index 000000000000..f756aa30a3d0
--- /dev/null
+++ b/.github/stale.yml
@@ -0,0 +1,59 @@
+# Configuration for probot-stale - https://github.com/probot/stale
+
+# Number of days of inactivity before an Issue or Pull Request becomes stale
+daysUntilSt... | null | val | val | 2022-10-29T08:31:41 | 2022-10-29T20:35:32Z | iluwatar | train |
iluwatar/java-design-patterns/1842_2271 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1842 | iluwatar/java-design-patterns/2271 | [
"timestamp(timedelta=0.0, similarity=0.8620750919234087)",
"keyword_pr_to_issue"
] | 0793c50363d67851f88316e38f9b43144cec5ad7 | 7be2828c8ac7747e91107d71606cc82484039e92 | [
"There is a concrete example about currying in Java on Baeldung's website: https://www.baeldung.com/java-currying",
"hi @iluwatar , can I work on this issue for Hacktoberfest?",
"Sure @januslinhc, it's now assigned to you",
"Hey @iluwatar, could I work on this issue?",
"All right @hkattt, you're free to pro... | [
"Please implement the yaml frontmatter according to https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute",
"Use Lombok to reduce boilerplate",
"Doesn't look useful"
] | 2022-10-29T22:21:03Z | [
"epic: pattern",
"type: feature"
] | Currying | I's a functional programming design pattern. As far as I understand you call a function with less parameters than usual and it can be used to defer processing when it has many steps involved.
UML example
```
@startuml
'https://plantuml.com/class-diagram
interface BiFunction <ParamType1, ParamType2, ResultTyp... | [
"pom.xml"
] | [
"currying/README.md",
"currying/etc/currying.urm.puml",
"currying/pom.xml",
"currying/src/main/java/com/iluwatar/currying/App.java",
"currying/src/main/java/com/iluwatar/currying/Book.java",
"currying/src/main/java/com/iluwatar/currying/Genre.java",
"pom.xml"
] | [
"currying/src/test/java/com/iluwatar/currying/AppTest.java",
"currying/src/test/java/com/iluwatar/currying/BookCurryingTest.java"
] | diff --git a/currying/README.md b/currying/README.md
new file mode 100644
index 000000000000..72e0e89d46df
--- /dev/null
+++ b/currying/README.md
@@ -0,0 +1,191 @@
+---
+title: Currying
+category: Functional
+language: en
+tag:
+- Decoupling
+---
+
+## Name / classification
+Currying
+
+## Intent
+Currying decomposes ... | diff --git a/currying/src/test/java/com/iluwatar/currying/AppTest.java b/currying/src/test/java/com/iluwatar/currying/AppTest.java
new file mode 100644
index 000000000000..83fd99363e52
--- /dev/null
+++ b/currying/src/test/java/com/iluwatar/currying/AppTest.java
@@ -0,0 +1,39 @@
+/*
+ * This project is licensed under t... | val | val | 2022-12-03T19:46:22 | 2021-10-07T16:29:23Z | javatlacati | train |
iluwatar/java-design-patterns/2242_2302 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2242 | iluwatar/java-design-patterns/2302 | [
"timestamp(timedelta=2101.0, similarity=0.9059112988313126)"
] | cfeee239570226f50b857770676686bc65b495df | 24bd93999d1acd583fc4c866b41dd363b2cb1616 | [
"@iluwatar Raised PR# https://github.com/iluwatar/java-design-patterns/pull/2302 Kindly review.\r\nThanks"
] | [] | 2022-11-01T12:23:56Z | [
"type: feature",
"epic: documentation"
] | Explanation for Model-View-Controller | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"model-view-controller/README.md"
] | [
"model-view-controller/README.md"
] | [] | diff --git a/model-view-controller/README.md b/model-view-controller/README.md
index a94fb56c12b1..f4d2be8d8471 100644
--- a/model-view-controller/README.md
+++ b/model-view-controller/README.md
@@ -12,6 +12,132 @@ the model, the view and the controller. Let the model manage the data, the view
display the data and the... | null | test | val | 2022-10-30T21:26:27 | 2022-10-29T19:59:49Z | iluwatar | train |
iluwatar/java-design-patterns/2243_2302 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2243 | iluwatar/java-design-patterns/2302 | [
"timestamp(timedelta=2170.0, similarity=0.8789116389588582)"
] | cfeee239570226f50b857770676686bc65b495df | 24bd93999d1acd583fc4c866b41dd363b2cb1616 | [
"@iluwatar Raised PR https://github.com/iluwatar/java-design-patterns/pull/2303 . Kindly review.\r\n\r\nThanks"
] | [] | 2022-11-01T12:23:56Z | [
"type: feature",
"epic: documentation"
] | Explanation for Model-View-Presenter | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"model-view-controller/README.md"
] | [
"model-view-controller/README.md"
] | [] | diff --git a/model-view-controller/README.md b/model-view-controller/README.md
index a94fb56c12b1..f4d2be8d8471 100644
--- a/model-view-controller/README.md
+++ b/model-view-controller/README.md
@@ -12,6 +12,132 @@ the model, the view and the controller. Let the model manage the data, the view
display the data and the... | null | train | val | 2022-10-30T21:26:27 | 2022-10-29T19:59:52Z | iluwatar | train |
iluwatar/java-design-patterns/2297_2317 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2297 | iluwatar/java-design-patterns/2317 | [
"timestamp(timedelta=1.0, similarity=0.8465203046542189)"
] | e6f5b691df3033ad3a73c14f6ad9671efa49bb03 | c4307db0a60c7b4612397ab1e1b911e0a78ccf13 | [
"@iluwatar , is solution is to update the version of H2 database or something else .\r\nAbove issue is also mentioned here officially in H2 database repo [issue](https://github.com/h2database/h2database/issues/3195).",
"Yes, update the version (see the acceptance criteria). Would you like to try it @bhati00 ?",
... | [] | 2022-11-06T19:24:21Z | [
"epic: dependencies"
] | Security vulnerability in H2 database | The currently used H2 database version 1.4.190 has multiple security vulnerabilities. To mention a few:
1. - H2 Console before 2.1.210 allows remote attackers to execute arbitrary code via a jdbc:h2:mem JDBC URL containing the IGNORE_UNKNOWN_SETTINGS=TRUE;FORBID_CREATION=FALSE;INIT=RUNSCRIPT substring, a different vul... | [
"domain-model/src/main/java/com/iluwatar/domainmodel/App.java",
"metadata-mapping/README.md",
"metadata-mapping/src/main/java/com/iluwatar/metamapping/utils/DatabaseUtil.java",
"metadata-mapping/src/main/resources/com/iluwatar/metamapping/model/User.hbm.xml",
"pom.xml",
"transaction-script/src/main/java/c... | [
"domain-model/src/main/java/com/iluwatar/domainmodel/App.java",
"metadata-mapping/README.md",
"metadata-mapping/src/main/java/com/iluwatar/metamapping/utils/DatabaseUtil.java",
"metadata-mapping/src/main/resources/com/iluwatar/metamapping/model/User.hbm.xml",
"pom.xml",
"transaction-script/src/main/java/c... | [] | diff --git a/domain-model/src/main/java/com/iluwatar/domainmodel/App.java b/domain-model/src/main/java/com/iluwatar/domainmodel/App.java
index 80058fb89a7a..681e7c4fc72a 100644
--- a/domain-model/src/main/java/com/iluwatar/domainmodel/App.java
+++ b/domain-model/src/main/java/com/iluwatar/domainmodel/App.java
@@ -60,8 ... | null | test | val | 2022-11-06T14:36:50 | 2022-10-30T18:10:05Z | iluwatar | train |
iluwatar/java-design-patterns/2326_2327 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2326 | iluwatar/java-design-patterns/2327 | [
"keyword_pr_to_issue"
] | dd456d4440406b920492485549e79fbc324a9382 | a05cf33643dffdfbd624186dc98ab7aee4327c87 | [] | [] | 2022-11-10T23:06:05Z | [
"type: refactoring",
"epic: code quality"
] | Minor enchancements to flyweight | Minor enhancements to flyweight:
- AlchemistShopTest : line 59: use a Set<>(potions).size() than streaming
- PotionFactory - small refactoring to reduce code duplication by adding the potion after each siwtch case. | [
"feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java",
"flyweight/src/main/java/com/iluwatar/flyweight/PotionFactory.java"
] | [
"feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java",
"flyweight/src/main/java/com/iluwatar/flyweight/PotionFactory.java"
] | [
"flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java"
] | diff --git a/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java b/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java
index 91b75f548655..d01c5735d19e 100644
--- a/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java
+++ b/feature-toggle/src/main/j... | diff --git a/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java b/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java
index 0448554384d3..79a70611ea95 100644
--- a/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java
+++ b/flyweight/src/test/java/com/iluwatar/flywei... | train | val | 2022-11-09T21:03:04 | 2022-11-10T23:00:31Z | StefanelStan | train |
iluwatar/java-design-patterns/2325_2327 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2325 | iluwatar/java-design-patterns/2327 | [
"keyword_pr_to_issue"
] | dd456d4440406b920492485549e79fbc324a9382 | a05cf33643dffdfbd624186dc98ab7aee4327c87 | [] | [] | 2022-11-10T23:06:05Z | [
"type: bug",
"info: good first issue",
"epic: documentation"
] | Feature Toggle mispelled comments | A small typo error: all ready (incorrect) instead of already | [
"feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java",
"flyweight/src/main/java/com/iluwatar/flyweight/PotionFactory.java"
] | [
"feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java",
"flyweight/src/main/java/com/iluwatar/flyweight/PotionFactory.java"
] | [
"flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java"
] | diff --git a/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java b/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java
index 91b75f548655..d01c5735d19e 100644
--- a/feature-toggle/src/main/java/com/iluwatar/featuretoggle/user/UserGroup.java
+++ b/feature-toggle/src/main/j... | diff --git a/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java b/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java
index 0448554384d3..79a70611ea95 100644
--- a/flyweight/src/test/java/com/iluwatar/flyweight/AlchemistShopTest.java
+++ b/flyweight/src/test/java/com/iluwatar/flywei... | train | val | 2022-11-09T21:03:04 | 2022-11-10T22:43:59Z | StefanelStan | train |
iluwatar/java-design-patterns/2035_2331 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2035 | iluwatar/java-design-patterns/2331 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9820342106713623)"
] | 10fb952d85e93386a5b79e3b898fbd7361d5de4d | 37bfecce30969c25a519d939eafcbff8023f60a7 | [
"@iluwatar ,\r\nCan I work on this",
"Yes, go ahead @harikesh409 ",
"Is this already fixed in master branch? I've built the current state against JDK17 and have no errors.",
"For me, it fails during naked objects integration tests",
"@iluwatar Could I work on this?",
"@harikesh409 I'll assign @robertvolkm... | [] | 2022-11-13T09:01:02Z | [
"info: good first issue",
"epic: build issue",
"type: feature"
] | Build with JDK 17 | This task is part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. Here we address the issues that come up when building the project with JDK 17 using language level Java 11.
Acceptance criteria
- Build the project with JDK 17 while keeping the maven-compiler... | [
".circleci/config.yml",
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [
".circleci/config.yml",
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [] | diff --git a/.circleci/config.yml b/.circleci/config.yml
index dad7997a8699..714bd108889a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -26,14 +26,14 @@ version: 2
jobs:
sonar-pr:
docker:
- - image: cimg/openjdk:11.0-node
+ - image: cimg/openjdk:17.0-node
steps:
- checkout... | null | val | val | 2022-11-21T17:59:09 | 2022-09-28T16:31:17Z | iluwatar | train |
iluwatar/java-design-patterns/2036_2331 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2036 | iluwatar/java-design-patterns/2331 | [
"timestamp(timedelta=132693.0, similarity=0.9544008291454945)"
] | 10fb952d85e93386a5b79e3b898fbd7361d5de4d | 37bfecce30969c25a519d939eafcbff8023f60a7 | [
" I want to help in this issue\r\n ",
"Ok @ArinCodes ",
"Can I help in this isssue ..?\r\n",
"\r\nI want to help in this issue\r\n\r\n",
"@iluwatar Could I work on this?",
"@ArinCodes I'll assign this issue to @robertvolkmann as well since this is high priority."
] | [] | 2022-11-13T09:01:02Z | [
"info: good first issue",
"epic: build issue",
"type: feature"
] | Run with Java 17 | This is part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. In this issue, we build the project using JDK 11 and try to run it with Java 17 runtime.
Acceptance criteria
- The project is built with JDK 11
- The pattern examples are executed with Java 17 run... | [
".circleci/config.yml",
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [
".circleci/config.yml",
".github/workflows/maven-ci.yml",
".github/workflows/maven-pr-builder.yml"
] | [] | diff --git a/.circleci/config.yml b/.circleci/config.yml
index dad7997a8699..714bd108889a 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -26,14 +26,14 @@ version: 2
jobs:
sonar-pr:
docker:
- - image: cimg/openjdk:11.0-node
+ - image: cimg/openjdk:17.0-node
steps:
- checkout... | null | val | val | 2022-11-21T17:59:09 | 2022-09-28T16:36:33Z | iluwatar | train |
iluwatar/java-design-patterns/2329_2332 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2329 | iluwatar/java-design-patterns/2332 | [
"keyword_pr_to_issue"
] | df735cb956a9a3c6555ded781e714fcbe24f24db | 40fb6dda74f742298468f8952ba26ad774d973bf | [] | [] | 2022-11-13T10:18:32Z | [
"type: bug",
"info: help wanted",
"epic: pattern"
] | Fix pattern categories | Some patterns have a small defect in the yaml frontmatter (README.md). Categories key should be renamed to category so that everything shows up correctly on the website.
Acceptance criteria
- The pattern yaml frontmatters have been checked to conform with https://github.com/iluwatar/java-design-patterns/wiki/01.-How-... | [
"identity-map/README.md",
"intercepting-filter/README.md",
"interpreter/README.md",
"iterator/README.md"
] | [
"identity-map/README.md",
"intercepting-filter/README.md",
"interpreter/README.md",
"iterator/README.md"
] | [] | diff --git a/identity-map/README.md b/identity-map/README.md
index a5bb4d38695a..6594f54eda9e 100644
--- a/identity-map/README.md
+++ b/identity-map/README.md
@@ -1,6 +1,6 @@
---
title: Identity Map
-categories: Behavioral
+category: Behavioral
language: en
tags:
- Performance
diff --git a/intercepting-filter/READ... | null | train | val | 2022-11-13T08:46:45 | 2022-11-13T07:37:14Z | iluwatar | train |
iluwatar/java-design-patterns/2335_2338 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2335 | iluwatar/java-design-patterns/2338 | [
"timestamp(timedelta=29.0, similarity=0.9406253421342035)"
] | ab81f7e3d128c28ffbf5fa75b60da7845c4d371b | 8596d38ebaecb99654f3660714b01935f8da4a91 | [] | [
"The yaml frontmatter keys are not supposed to be translated, only values. ",
"```suggestion\r\ntitle: Aggregator Microservices\r\n```",
"```suggestion\r\ncategory: Architectural\r\n```",
"```suggestion\r\n- Cloud distributed\r\n```",
"```suggestion\r\n- Decoupling\r\n```",
"```suggestion\r\n- Microservic... | 2022-11-16T12:01:10Z | [
"type: feature",
"epic: translation"
] | Translate the aggregator-microservices readme to Spanish | Hi all! Following [01.-How to contribute document](https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute) I create this issue because I want to contribute to actually open issue #2277 translating [aggregator-microservices/README.md](https://github.com/iluwatar/java-design-patterns/blob/master/agg... | [] | [
"localization/es/aggregator-microservices/README.md"
] | [] | diff --git a/localization/es/aggregator-microservices/README.md b/localization/es/aggregator-microservices/README.md
new file mode 100644
index 000000000000..2c1c6aab8ce0
--- /dev/null
+++ b/localization/es/aggregator-microservices/README.md
@@ -0,0 +1,107 @@
+---
+title: Aggregator Microservices
+category: Architectur... | null | train | val | 2022-12-29T12:07:01 | 2022-11-15T12:01:11Z | KarmaTashiCat | train |
iluwatar/java-design-patterns/2037_2357 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2037 | iluwatar/java-design-patterns/2357 | [
"keyword_pr_to_issue"
] | 2d309b89283e824f3e9e252b99f7537e975e3642 | 9181210f8144ff7730938aa2d343b8e8923ba856 | [
"Hi I am interested in your project \r\nPlease Hire me",
"I would like to work on this issue . Please assign it to me\r\n",
"I can work on this issue. Assign it to me",
"To be fair, @akhilpamwani expressed interest first",
"Hey, its been 9 days since... do we have any upgrade ? . If not then I would like to... | [] | 2022-11-20T20:54:37Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies",
"type: feature"
] | Upgrade dependencies to support Java 17 | This issue is a part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. Here we upgrade the dependencies so that they support Java 17.
Acceptance criteria
- Project dependencies have been upgraded so that each of them supports Java 17
| [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index ee3465ca3cfe..74e54db37856 100644
--- a/pom.xml
+++ b/pom.xml
@@ -41,7 +41,8 @@
<jacoco.version>0.8.8</jacoco.version>
<commons-dbcp.version>1.4</commons-dbcp.version>
<htmlunit.version>2.66.0</htmlunit.version>
- <guice.version>4.0</guice.version>
+ <gson.versi... | null | train | val | 2022-12-04T10:25:57 | 2022-09-28T16:38:59Z | iluwatar | train |
iluwatar/java-design-patterns/2037_2358 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2037 | iluwatar/java-design-patterns/2358 | [
"keyword_pr_to_issue"
] | 10fb952d85e93386a5b79e3b898fbd7361d5de4d | cececd4f6402a96ee1b830d5695fbb00580cc226 | [
"Hi I am interested in your project \r\nPlease Hire me",
"I would like to work on this issue . Please assign it to me\r\n",
"I can work on this issue. Assign it to me",
"To be fair, @akhilpamwani expressed interest first",
"Hey, its been 9 days since... do we have any upgrade ? . If not then I would like to... | [
"Need to import this package com.google.gson.JsonParser.parseReader(reader)and can be used \r\n JsonParser.parseReader(reader);",
"Works only if I rename the class `JsonParser` otherwise we have a name conflict.",
"Is there any other solution to fix it. Because, it is not looks good as per code readability."
] | 2022-11-22T16:09:18Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies",
"type: feature"
] | Upgrade dependencies to support Java 17 | This issue is a part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. Here we upgrade the dependencies so that they support Java 17.
Acceptance criteria
- Project dependencies have been upgraded so that each of them supports Java 17
| [
"event-sourcing/pom.xml",
"pom.xml",
"typeobjectpattern/pom.xml",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/App.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/CellPool.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/JsonParser.java",
"typeobjectpattern/src... | [
"event-sourcing/pom.xml",
"pom.xml",
"typeobjectpattern/pom.xml",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/App.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/CellPool.java",
"typeobjectpattern/src/main/java/com/iluwatar/typeobject/JsonParser.java",
"typeobjectpattern/src... | [] | diff --git a/event-sourcing/pom.xml b/event-sourcing/pom.xml
index 047c1ea0d293..ae609d67e76b 100644
--- a/event-sourcing/pom.xml
+++ b/event-sourcing/pom.xml
@@ -39,11 +39,9 @@
<artifactId>junit-jupiter-engine</artifactId>
<scope>test</scope>
</dependency>
- <!-- https://mvnrepository.com/artifac... | null | train | val | 2022-11-21T17:59:09 | 2022-09-28T16:38:59Z | iluwatar | train |
iluwatar/java-design-patterns/2037_2359 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2037 | iluwatar/java-design-patterns/2359 | [
"keyword_pr_to_issue"
] | 10fb952d85e93386a5b79e3b898fbd7361d5de4d | 9600a69b1e20419524c1661eea5cc21965a9c3c5 | [
"Hi I am interested in your project \r\nPlease Hire me",
"I would like to work on this issue . Please assign it to me\r\n",
"I can work on this issue. Assign it to me",
"To be fair, @akhilpamwani expressed interest first",
"Hey, its been 9 days since... do we have any upgrade ? . If not then I would like to... | [] | 2022-11-22T16:28:40Z | [
"info: good first issue",
"epic: build issue",
"epic: dependencies",
"type: feature"
] | Upgrade dependencies to support Java 17 | This issue is a part of the transition plan at https://github.com/iluwatar/java-design-patterns/wiki/19.-Java-17-transition. Here we upgrade the dependencies so that they support Java 17.
Acceptance criteria
- Project dependencies have been upgraded so that each of them supports Java 17
| [
"acyclic-visitor/pom.xml"
] | [
"acyclic-visitor/pom.xml"
] | [] | diff --git a/acyclic-visitor/pom.xml b/acyclic-visitor/pom.xml
index 34f16caa06ef..52604048e127 100644
--- a/acyclic-visitor/pom.xml
+++ b/acyclic-visitor/pom.xml
@@ -33,19 +33,7 @@
<version>1.26.0-SNAPSHOT</version>
</parent>
<artifactId>acyclic-visitor</artifactId>
- <properties>
- <project.build.sourc... | diff --git a/acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitorTest.java b/acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/ConfigureForDosVisitorTest.java
deleted file mode 100644
index c6aec8bef971..000000000000
--- a/acyclic-visitor/src/test/java/com/iluwatar/acyclicvisitor/Con... | val | val | 2022-11-21T17:59:09 | 2022-09-28T16:38:59Z | iluwatar | train |
iluwatar/java-design-patterns/2369_2370 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2369 | iluwatar/java-design-patterns/2370 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8499777834642155)"
] | 37bfecce30969c25a519d939eafcbff8023f60a7 | 7a3d61776971236688b73bd59d5c5609a4dffd37 | [] | [] | 2022-11-30T21:19:37Z | [
"info: help wanted",
"epic: build issue",
"type: refactoring"
] | Reduce build logging | Currrently, the build with tests enabled produces a zipped log file of about 65MB. This is a bit too large to analyze effectively. Let's try to reduce the logging a bit while keeping the most important parts.
Acceptance criteria
- Build and tests produce more compact logs
| [
"monitor/src/main/java/com/iluwatar/monitor/Bank.java",
"monitor/src/main/java/com/iluwatar/monitor/Main.java"
] | [
"monitor/src/main/java/com/iluwatar/monitor/Bank.java",
"monitor/src/main/java/com/iluwatar/monitor/Main.java",
"monitor/src/test/resources/logback.xml"
] | [
"monitor/src/test/java/com/iluwatar/monitor/MainTest.java"
] | diff --git a/monitor/src/main/java/com/iluwatar/monitor/Bank.java b/monitor/src/main/java/com/iluwatar/monitor/Bank.java
index 6ff65f28cb9a..3f19e0f593a7 100644
--- a/monitor/src/main/java/com/iluwatar/monitor/Bank.java
+++ b/monitor/src/main/java/com/iluwatar/monitor/Bank.java
@@ -78,12 +78,14 @@ public synchronized v... | diff --git a/monitor/src/test/java/com/iluwatar/monitor/MainTest.java b/monitor/src/test/java/com/iluwatar/monitor/MainTest.java
index 360a897fd6a6..4d1c217372d7 100644
--- a/monitor/src/test/java/com/iluwatar/monitor/MainTest.java
+++ b/monitor/src/test/java/com/iluwatar/monitor/MainTest.java
@@ -25,6 +25,7 @@
packag... | train | val | 2022-11-30T18:02:38 | 2022-11-30T17:15:55Z | iluwatar | train |
iluwatar/java-design-patterns/1295_2384 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1295 | iluwatar/java-design-patterns/2384 | [
"timestamp(timedelta=173.0, similarity=0.9952417275087242)"
] | 7d2832f4124a1ccbe1ba67c003330ad78b188207 | b2eb312b5e18179051f5dc12bddff27a1c6388fe | [
"Hi can I work on this issue?",
"Yes, @kevinjplee. Please proceed!",
"Thank you!\r\n\r\n> \r\n> \r\n> Yes, @kevinjplee. Please proceed!\r\n\r\n",
"Can I work on this issue?",
"Hi, can I take up this issue as a part of an Australian National University group project? Thanks @iluwatar ",
"Assigned to @shivu... | [] | 2022-12-04T11:12:00Z | [
"epic: pattern",
"type: feature"
] | Embedded Value pattern | https://www.youtube.com/watch?v=6n5O5mCdnew | [
"pom.xml"
] | [
"embedded-value/README.md",
"embedded-value/etc/embedded-value.urm.puml",
"embedded-value/pom.xml",
"embedded-value/src/main/java/com/iluwatar/embedded/value/App.java",
"embedded-value/src/main/java/com/iluwatar/embedded/value/DataSource.java",
"embedded-value/src/main/java/com/iluwatar/embedded/value/Dat... | [
"embedded-value/src/test/java/com/iluwatar/embedded/value/AppTest.java"
] | diff --git a/embedded-value/README.md b/embedded-value/README.md
new file mode 100644
index 000000000000..dc924cb45a0f
--- /dev/null
+++ b/embedded-value/README.md
@@ -0,0 +1,124 @@
+---
+title: Embedded Value
+category: Structural
+language: en
+tag:
+ - Data Access
+ - Enterprise Application Pattern
+---
+
+## Also... | diff --git a/embedded-value/src/test/java/com/iluwatar/embedded/value/AppTest.java b/embedded-value/src/test/java/com/iluwatar/embedded/value/AppTest.java
new file mode 100644
index 000000000000..1e97bfabc36f
--- /dev/null
+++ b/embedded-value/src/test/java/com/iluwatar/embedded/value/AppTest.java
@@ -0,0 +1,41 @@
+/*
... | val | val | 2022-12-04T10:53:17 | 2020-07-07T17:33:47Z | iluwatar | train |
iluwatar/java-design-patterns/2399_2400 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2399 | iluwatar/java-design-patterns/2400 | [
"keyword_pr_to_issue"
] | 9a92930dfae8945c6a3ba61e73ee147296e825b3 | 3be7664dd463c9ba7bc41cc55b05bba9152ca341 | [
"Kind of works, see https://github.com/iluwatar/java-design-patterns/pull/2398, but maybe we can improve it"
] | [] | 2022-12-17T20:41:11Z | [
"type: bug",
"epic: build issue"
] | Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties | When you try to build the project using `./mvnw clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonarit` gives the following error:
### Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.8.0.2131:sonar (default-cli) on project java-design-patterns: Project not found. Please check... | [
".github/workflows/maven-pr-builder.yml"
] | [
".github/workflows/maven-pr-builder.yml"
] | [] | diff --git a/.github/workflows/maven-pr-builder.yml b/.github/workflows/maven-pr-builder.yml
index 51ffbbcb9089..f2699a9c9c93 100644
--- a/.github/workflows/maven-pr-builder.yml
+++ b/.github/workflows/maven-pr-builder.yml
@@ -28,6 +28,7 @@ name: Java PR Builder
on:
pull_request:
+ pull_request_target:
bran... | null | train | val | 2022-12-10T15:56:47 | 2022-12-17T14:07:33Z | girolamo-giordano | train |
iluwatar/java-design-patterns/2399_2402 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2399 | iluwatar/java-design-patterns/2402 | [
"keyword_pr_to_issue"
] | 3be7664dd463c9ba7bc41cc55b05bba9152ca341 | 9262dc52b400845fae37e08ce17382de6f53ca75 | [
"Kind of works, see https://github.com/iluwatar/java-design-patterns/pull/2398, but maybe we can improve it"
] | [] | 2022-12-18T13:18:32Z | [
"type: bug",
"epic: build issue"
] | Project not found. Please check the 'sonar.projectKey' and 'sonar.organization' properties | When you try to build the project using `./mvnw clean verify org.sonarsource.scanner.maven:sonar-maven-plugin:sonarit` gives the following error:
### Failed to execute goal org.sonarsource.scanner.maven:sonar-maven-plugin:3.8.0.2131:sonar (default-cli) on project java-design-patterns: Project not found. Please check... | [
".github/workflows/maven-pr-builder.yml"
] | [
".github/workflows/maven-pr-builder.yml"
] | [] | diff --git a/.github/workflows/maven-pr-builder.yml b/.github/workflows/maven-pr-builder.yml
index f2699a9c9c93..fb1fdbe84f7d 100644
--- a/.github/workflows/maven-pr-builder.yml
+++ b/.github/workflows/maven-pr-builder.yml
@@ -27,7 +27,6 @@
name: Java PR Builder
on:
- pull_request:
pull_request_target:
bra... | null | val | val | 2022-12-17T22:25:09 | 2022-12-17T14:07:33Z | girolamo-giordano | train |
iluwatar/java-design-patterns/2421_2429 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2421 | iluwatar/java-design-patterns/2429 | [
"timestamp(timedelta=76.0, similarity=0.9296612699032656)"
] | 6205f7dd82098bc4bb2102dec3ec8747abe1fa59 | 95203520bc910fd7b4e261d30d8bc17f8d86104a | [
"Subtask of https://github.com/iluwatar/java-design-patterns/issues/2282"
] | [] | 2023-01-05T12:40:00Z | [
"type: feature",
"epic: translation"
] | Translate event-driven-architecture readme file into Korean | I wanna translate `event-driven-architecture` readme file into Korean, if possible. | [] | [
"localization/ko/event-driven-architecture/README.md"
] | [] | diff --git a/localization/ko/event-driven-architecture/README.md b/localization/ko/event-driven-architecture/README.md
new file mode 100644
index 000000000000..0296076db582
--- /dev/null
+++ b/localization/ko/event-driven-architecture/README.md
@@ -0,0 +1,33 @@
+---
+title: Event Driven Architecture
+category: Architec... | null | train | val | 2023-01-05T17:20:56 | 2023-01-04T14:15:19Z | hwan33 | train |
iluwatar/java-design-patterns/2428_2430 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2428 | iluwatar/java-design-patterns/2430 | [
"timestamp(timedelta=113.0, similarity=0.8610188056997489)"
] | 6205f7dd82098bc4bb2102dec3ec8747abe1fa59 | acf55c934f88a577d4ab2ba2297da3ab16bc9c23 | [] | [] | 2023-01-05T12:40:23Z | [
"type: bug",
"epic: documentation"
] | Typo in javadoc of event-driven-architecture | I found some typos in javadoc.
It's such a minor things, but I want to correct them. | [
"event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserCreatedEvent.java",
"event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserUpdatedEvent.java",
"event-driven-architecture/src/main/java/com/iluwatar/eda/framework/EventDispatcher.java",
"event-driven-architecture/src/main/java/co... | [
"event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserCreatedEvent.java",
"event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserUpdatedEvent.java",
"event-driven-architecture/src/main/java/com/iluwatar/eda/framework/EventDispatcher.java",
"event-driven-architecture/src/main/java/co... | [
"event-driven-architecture/src/test/java/com/iluwatar/eda/AppTest.java"
] | diff --git a/event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserCreatedEvent.java b/event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserCreatedEvent.java
index f7be8cb6cb0e..245f79b4cbca 100644
--- a/event-driven-architecture/src/main/java/com/iluwatar/eda/event/UserCreatedEvent.java
+++ ... | diff --git a/event-driven-architecture/src/test/java/com/iluwatar/eda/AppTest.java b/event-driven-architecture/src/test/java/com/iluwatar/eda/AppTest.java
index f4d1f18a8d43..17f3bddaa4a2 100644
--- a/event-driven-architecture/src/test/java/com/iluwatar/eda/AppTest.java
+++ b/event-driven-architecture/src/test/java/com... | train | val | 2023-01-05T17:20:56 | 2023-01-05T12:31:18Z | hwan33 | train |
iluwatar/java-design-patterns/2438_2439 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2438 | iluwatar/java-design-patterns/2439 | [
"timestamp(timedelta=83.0, similarity=0.9618551908347523)"
] | 919d7d0339d7717ad01a307c3d6f0374383910db | 2263e248bde25c3be7549058fd489c46497b7f41 | [] | [
"remove the extra newline",
"Sorry. I'll check it more carefully next time 🤗"
] | 2023-01-06T14:39:09Z | [
"type: feature",
"epic: translation"
] | Translate event-sourcing readme file into Korean | I'll translate. | [] | [
"localization/ko/event-sourcing/README.md"
] | [] | diff --git a/localization/ko/event-sourcing/README.md b/localization/ko/event-sourcing/README.md
new file mode 100644
index 000000000000..1d3bd584061c
--- /dev/null
+++ b/localization/ko/event-sourcing/README.md
@@ -0,0 +1,36 @@
+---
+title: Event Sourcing
+category: Architectural
+language: ko
+tag:
+- Performance
+- ... | null | val | val | 2023-01-06T11:34:08 | 2023-01-06T12:54:39Z | hwan33 | train |
iluwatar/java-design-patterns/2441_2442 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2441 | iluwatar/java-design-patterns/2442 | [
"timestamp(timedelta=37.0, similarity=0.9219567665722146)"
] | 6ba6988d5ee225b6e1b9796bb2587fad4003b8d9 | 186b5b6ff284c1c232072b19372620a0e6e493cd | [] | [] | 2023-01-07T13:35:26Z | [
"type: feature",
"epic: documentation"
] | Fix typos in javadocs of Event sourcing | I'll correct typos and grammatical errors suggested by ide or sonarlint :) | [
"event-sourcing/README.md",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/app/App.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/domain/Account.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/AccountCreateEvent.java",
"event-sourcing/src/main/java/com/ilu... | [
"event-sourcing/README.md",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/app/App.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/domain/Account.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/AccountCreateEvent.java",
"event-sourcing/src/main/java/com/ilu... | [
"event-sourcing/src/test/java/IntegrationTest.java"
] | diff --git a/event-sourcing/README.md b/event-sourcing/README.md
index 8bec3c52a4e8..423f892cb24a 100644
--- a/event-sourcing/README.md
+++ b/event-sourcing/README.md
@@ -16,7 +16,7 @@ Instead of storing just the current state of the data in a domain, use an append
## Applicability
Use the Event Sourcing pattern when... | diff --git a/event-sourcing/src/test/java/IntegrationTest.java b/event-sourcing/src/test/java/IntegrationTest.java
index 6d30a89fc582..9e15a2163bcc 100644
--- a/event-sourcing/src/test/java/IntegrationTest.java
+++ b/event-sourcing/src/test/java/IntegrationTest.java
@@ -37,7 +37,7 @@
import org.junit.jupiter.api.Test;... | test | test | 2023-01-06T18:30:02 | 2023-01-07T13:33:55Z | hwan33 | train |
iluwatar/java-design-patterns/2281_2444 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2281 | iluwatar/java-design-patterns/2444 | [
"keyword_pr_to_issue"
] | 42ba121977da2961b990512bba1de2de6c426629 | 4da36e7826ea418909924a113bbfe11ddbe6044d | [
"Hi @iluwatar, I will work on this because I'm Japanese! It seems there are fewer materials that were translated into Japanese compared to other languages..."
] | [
"Could you check that the image is found in this location? I think it currently resides in `localization/ja/decorator/decorator.urm.png`",
"@iluwatar \r\nOops... Sorry about that. I moved the image under `etc` directory\r\n\r\nhttps://github.com/iluwatar/java-design-patterns/pull/2444/commits/2832ffa4461868153178... | 2023-01-08T10:08:06Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Translate to Japanese | This task tracks the translation of the patterns. More information about the translation process is available at https://github.com/iluwatar/java-design-patterns/wiki/15.-Support-for-multiple-languages
Acceptance criteria
- The patterns have been translated
- The patterns can be browsed in Github and on the website h... | [] | [
"localization/ja/decorator/README.md"
] | [] | diff --git a/localization/ja/decorator/README.md b/localization/ja/decorator/README.md
new file mode 100644
index 000000000000..d67bfb805459
--- /dev/null
+++ b/localization/ja/decorator/README.md
@@ -0,0 +1,160 @@
+---
+title: Decorator
+category: Structural
+language: ja
+tag:
+ - Gang of Four
+ - Extensibility
+---
... | null | test | test | 2023-01-08T09:15:59 | 2022-10-30T08:12:02Z | iluwatar | train |
iluwatar/java-design-patterns/2451_2455 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2451 | iluwatar/java-design-patterns/2455 | [
"timestamp(timedelta=765.0, similarity=0.8822402075876062)"
] | fb7ec9b37533df8a84c233d0d7ad5f91080eff96 | c741814b367f004787ef2f87665cc00b5f07b35e | [
"@iluwatar \r\nHere is a PR that I started:\r\n[https://github.com/iluwatar/java-design-patterns/pull/2464](https://github.com/iluwatar/java-design-patterns/pull/2464)\r\n\r\nNo new source code added from my side. Just the code/class name/method formatting as per checkstyle and respective changes in pom.xml and sup... | [] | 2023-01-16T22:00:51Z | [
"type: enhancement",
"epic: build issue",
"epic: dependencies"
] | Update Checkstyle to 3.2.0 | The project currently uses Checkstyle 3.1.0, but there is a newer version 3.2.0 available. According to dependabot's pull request https://github.com/iluwatar/java-design-patterns/pull/2449, the upgrade is not straightforward.
Acceptance criteria
- Checkstyle upgraded to 3.2.0
- Any build issues that arise have been r... | [
"pom.xml"
] | [
"pom.xml"
] | [] | diff --git a/pom.xml b/pom.xml
index 8405ac144b2b..6ea0d2bbdb61 100644
--- a/pom.xml
+++ b/pom.xml
@@ -45,7 +45,7 @@
<guice.version>5.1.0</guice.version>
<system-lambda.version>1.1.0</system-lambda.version>
<maven-surefire-plugin.version>3.0.0-M8</maven-surefire-plugin.version>
- <maven-checkstyle-plu... | null | train | test | 2023-02-04T18:20:54 | 2023-01-14T06:42:17Z | iluwatar | train |
iluwatar/java-design-patterns/2453_2456 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2453 | iluwatar/java-design-patterns/2456 | [
"timestamp(timedelta=95.0, similarity=0.9512614915718197)"
] | 13d0416045261c98fbd7adb5309daee06e87f2fa | 6b0a90ee61fcc5c3bd02af1810fbb66492b5d13f | [
"Related to https://github.com/iluwatar/java-design-patterns/issues/2277"
] | [] | 2023-01-16T23:58:51Z | [
"type: feature",
"epic: translation"
] | Translate: Translate the ambassador readme to Spanish (Task of issue #2277 ) | Hi again, I will follow with next pattern, ambassador readme translation to Spanish, with this issue related PR | [] | [
"localization/es/ambassador/README.md"
] | [] | diff --git a/localization/es/ambassador/README.md b/localization/es/ambassador/README.md
new file mode 100644
index 000000000000..fcc63208e54e
--- /dev/null
+++ b/localization/es/ambassador/README.md
@@ -0,0 +1,208 @@
+---
+title: Ambassador
+category: Structural
+language: es
+tag:
+ - Decoupling
+ - Cloud distribut... | null | test | test | 2023-01-15T09:35:28 | 2023-01-16T18:57:03Z | KarmaTashiCat | train |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.