instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
mockito/mockito/642_646 | mockito/mockito | mockito/mockito/642 | mockito/mockito/646 | [
"keyword_issue_to_pr"
] | db06504e1c1a41d4343dcf5951c6f4a1b0feb2ec | a4aa848a9b59ce46a6abb5f6e4ad551afa063648 | [
"I think we can push `2.1.0` next week since RC has been available for a little while now. Also I submitted a (random) PR to Google Guava and 850k+ tests did not fail :tada: https://github.com/google/guava/pull/2567\n",
"Shall I publish a RC tomorrow after merging #646 ?\n",
"-1 for merging #646 unless it's saf... | [
"Why would this be abstract? It has a private constructor anyways.\n",
"To keep it consistent, let's make these constant Strings too.\n",
"Space after `if`?\n",
"I would reverse this, to make the conditional equivalent to the name of the method. Very small nit though, but I had to think about it for a second ... | 2016-09-22T08:33:22Z | [
"epic"
] | Release 2.1.0 final | The purpose of this ticket is to collect all actions and requirements for getting 2.1.0 final. Let's not wait too long :)
- [x] investigate #638
- [x] identify opportunities to promo the RC and get more feedback
- [x] decide how long do we wait for feedback before publishing final version
- [x] @TimvdLippe review the ... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/CachingMockBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/CachingMockBytecodeGenerator.java",
"src/main/java/org/mockito/internal/util/Platform.java"
] | [
"src/test/java/org/mockito/internal/util/PlatformTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java
index 907ebd0276..9d165f6899 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java
+++ b/src/main/java/org/mocki... | diff --git a/src/test/java/org/mockito/internal/util/PlatformTest.java b/src/test/java/org/mockito/internal/util/PlatformTest.java
new file mode 100644
index 0000000000..f146666620
--- /dev/null
+++ b/src/test/java/org/mockito/internal/util/PlatformTest.java
@@ -0,0 +1,98 @@
+package org.mockito.internal.util;
+
+impor... | train | train | 2016-09-24T23:12:43 | 2016-09-17T15:57:32Z | mockitoguy | train |
mockito/mockito/640_646 | mockito/mockito | mockito/mockito/640 | mockito/mockito/646 | [
"keyword_pr_to_issue"
] | db06504e1c1a41d4343dcf5951c6f4a1b0feb2ec | a4aa848a9b59ce46a6abb5f6e4ad551afa063648 | [
"Can be closed...\n"
] | [
"Why would this be abstract? It has a private constructor anyways.\n",
"To keep it consistent, let's make these constant Strings too.\n",
"Space after `if`?\n",
"I would reverse this, to make the conditional equivalent to the name of the method. Very small nit though, but I had to think about it for a second ... | 2016-09-22T08:33:22Z | [
"enhancement"
] | Improve exception message to hint at upgrading java minor version to latest | Driven by #636
| [
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/CachingMockBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/CachingMockBytecodeGenerator.java",
"src/main/java/org/mockito/internal/util/Platform.java"
] | [
"src/test/java/org/mockito/internal/util/PlatformTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java
index 907ebd0276..9d165f6899 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java
+++ b/src/main/java/org/mocki... | diff --git a/src/test/java/org/mockito/internal/util/PlatformTest.java b/src/test/java/org/mockito/internal/util/PlatformTest.java
new file mode 100644
index 0000000000..f146666620
--- /dev/null
+++ b/src/test/java/org/mockito/internal/util/PlatformTest.java
@@ -0,0 +1,98 @@
+package org.mockito.internal.util;
+
+impor... | train | train | 2016-09-24T23:12:43 | 2016-09-17T15:27:23Z | mockitoguy | train |
mockito/mockito/650_651 | mockito/mockito | mockito/mockito/650 | mockito/mockito/651 | [
"timestamp(timedelta=1.0, similarity=0.9526223644965176)",
"keyword_pr_to_issue"
] | 88329aa20973fdc71cb2816139f165148587e0ac | 329a8f46ad685b6bfb315f649232b1d8ec5b8cc8 | [] | [] | 2016-09-24T14:20:27Z | [] | Update AssertJ to 3 | Since AssertJ 3 relies on Java 8, we can now update on master. It seems that there are very few breaking changes so hopefully this should not be a big hassle.
| [
"build.gradle"
] | [
"build.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index 33f03bff72..946fd0d943 100644
--- a/build.gradle
+++ b/build.gradle
@@ -67,7 +67,7 @@ dependencies {
testCompile 'org.ow2.asm:asm:5.1'
- testCompile 'org.assertj:assertj-core:1.7.1'
+ testCompile 'org.assertj:assertj-core:3.5.2'
testRuntime configurat... | null | val | train | 2016-09-17T17:38:04 | 2016-09-24T09:34:15Z | TimvdLippe | train |
mockito/mockito/653_654 | mockito/mockito | mockito/mockito/653 | mockito/mockito/654 | [
"timestamp(timedelta=1.0, similarity=0.8851382101039562)"
] | bde8b406f7988a7434d9edd2866e61817c13e05e | 83d76ea7fcea66be81bf70802a44c08cb4f6cca2 | [
"PR? :)\n",
"Check. See #654.\n"
] | [] | 2016-09-27T14:33:49Z | [
"refactoring"
] | Typos in FailureDetecter | `FailureDetecter` should be `FailureDetector`. Its method `isSussessful()` should probably be `isSuccessful()`.
| [
"src/main/java/org/mockito/internal/runners/StrictRunner.java",
"src/main/java/org/mockito/internal/runners/util/FailureDetecter.java"
] | [
"src/main/java/org/mockito/internal/runners/StrictRunner.java",
"src/main/java/org/mockito/internal/runners/util/FailureDetector.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/runners/StrictRunner.java b/src/main/java/org/mockito/internal/runners/StrictRunner.java
index 6138865488..0c4a347abd 100644
--- a/src/main/java/org/mockito/internal/runners/StrictRunner.java
+++ b/src/main/java/org/mockito/internal/runners/StrictRunner.java
@@ -6,7 +6,7 ... | null | val | train | 2016-09-24T23:16:33 | 2016-09-27T11:57:26Z | odrotbohm | train |
mockito/mockito/655_656 | mockito/mockito | mockito/mockito/655 | mockito/mockito/656 | [
"timestamp(timedelta=0.0, similarity=0.9690160524901865)"
] | 83d76ea7fcea66be81bf70802a44c08cb4f6cca2 | dbab2de80d29fa30cc2d641bed78190444b0fb77 | [] | [] | 2016-09-27T16:15:03Z | [] | Typo in JUnitDetecter class name | `JUnitDetecter` class should be renamed to `JUnitDetector` and accordingly the variables in `FriendlyExceptionMaker` and `JUnitTool` should be renamed from detecter to detector.
| [
"src/main/java/org/mockito/internal/junit/FriendlyExceptionMaker.java",
"src/main/java/org/mockito/internal/junit/JUnitDetecter.java",
"src/main/java/org/mockito/internal/junit/JUnitTool.java"
] | [
"src/main/java/org/mockito/internal/junit/FriendlyExceptionMaker.java",
"src/main/java/org/mockito/internal/junit/JUnitDetector.java",
"src/main/java/org/mockito/internal/junit/JUnitTool.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/junit/FriendlyExceptionMaker.java b/src/main/java/org/mockito/internal/junit/FriendlyExceptionMaker.java
index 2900f7267b..3c122c9afe 100644
--- a/src/main/java/org/mockito/internal/junit/FriendlyExceptionMaker.java
+++ b/src/main/java/org/mockito/internal/junit/FriendlyE... | null | val | train | 2016-09-27T16:50:34 | 2016-09-27T16:09:54Z | vtorosyan | train |
mockito/mockito/661_662 | mockito/mockito | mockito/mockito/661 | mockito/mockito/662 | [
"timestamp(timedelta=0.0, similarity=0.9684891101898311)",
"keyword_pr_to_issue"
] | 7ec39e50872f8533d9bef191b0285cfe6898fa2f | 2fac43f833e585ebbaa0148de28b1db3f6098c0a | [] | [] | 2016-09-30T05:15:15Z | [] | Update Gradle to 3.1 | Keep mockito up-to-date with Gradle. 3.1 is released and it brings some performance improvements, fixes and features: https://docs.gradle.org/3.1/release-notes
| [
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [] | diff --git a/build.gradle b/build.gradle
index 614c141c2a..bdede4725f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -123,7 +123,7 @@ apply from: 'gradle/release.gradle'
apply from: 'gradle/pom.gradle'
task wrapper(type: Wrapper) {
- gradleVersion = '3.0'
+ gradleVersion = '3.1'
}
task ciBuild {
diff --g... | null | test | train | 2016-09-29T15:16:56 | 2016-09-30T05:07:41Z | jonatan-ivanov | train |
mockito/mockito/543_698 | mockito/mockito | mockito/mockito/543 | mockito/mockito/698 | [
"timestamp(timedelta=2.0, similarity=0.9517652425385589)"
] | a002a673de13d0f28a7451efc535a6cf344d4498 | af0763cc028fb27967a6b9c90a6e3622a24a556c | [] | [
"`out` could be `StringBuilder` instead of just `String`.\n",
"Formatting.\n",
"`String.format()` to improve readability?\n",
"Why not to mark it with `@Override` to force a deletion? AFAIR Mockito does not support Java 5 any longer.\n",
"It would be nice to prefer AssertJ assertions over Junit they have a ... | 2016-10-17T04:07:32Z | [
"new feature"
] | new MockingDetails.printInvocations() API for debugging tests and edge cases | Let's add new MockingDetails.printInvocations() API. We already provide it silently via Mockito.debug().printInvocations(). Since the code is in place, let's expose it and get rid of the Mockito.debug()
- [ ] move Mockito.debug().printInvocations() to MockingDetails, move tests, too
- [ ] document new API addition some... | [
"src/main/java/org/mockito/MockingDetails.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/MockitoDebugger.java",
"src/main/java/org/mockito/internal/debugging/MockitoDebuggerImpl.java",
"src/main/java/org/mockito/internal/debugging/WarningsCollector.java",
"src/main/java/org/mo... | [
"src/main/java/org/mockito/MockingDetails.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/MockitoDebugger.java",
"src/main/java/org/mockito/internal/debugging/InvocationsPrinter.java",
"src/main/java/org/mockito/internal/debugging/MockitoDebuggerImpl.java",
"src/main/java/org/m... | [
"src/test/java/org/mockito/internal/util/DefaultMockingDetailsTest.java",
"src/test/java/org/mockitousage/debugging/InvocationsPrinterTest.java"
] | diff --git a/src/main/java/org/mockito/MockingDetails.java b/src/main/java/org/mockito/MockingDetails.java
index 794582dc6a..6ac617c55d 100644
--- a/src/main/java/org/mockito/MockingDetails.java
+++ b/src/main/java/org/mockito/MockingDetails.java
@@ -14,6 +14,7 @@
/**
* Provides mocking information.
* For example,... | diff --git a/src/test/java/org/mockito/internal/util/DefaultMockingDetailsTest.java b/src/test/java/org/mockito/internal/util/DefaultMockingDetailsTest.java
index 4de9518b36..8af561bb3e 100644
--- a/src/test/java/org/mockito/internal/util/DefaultMockingDetailsTest.java
+++ b/src/test/java/org/mockito/internal/util/Defa... | train | train | 2016-10-16T16:18:07 | 2016-08-10T00:45:21Z | mockitoguy | train |
mockito/mockito/707_711 | mockito/mockito | mockito/mockito/707 | mockito/mockito/711 | [
"timestamp(timedelta=0.0, similarity=0.8775874955528284)"
] | f9f6d21974d530030ea731f21ad2da016ce14ada | 5d74ab11bc7358b195429e275c9fe8f29fb55ffe | [
"Given how Answer is supposed to be used it is a safe change to do. Plus, it is marked as @Incubating :)\n"
] | [] | 2016-10-24T10:31:38Z | [
"bug"
] | Improve usability of arity Answers with regards to checked exceptions | Recently introduced Answer1 style answers don't declare Throwable. They should! Otherwise the user is forced to add boilerplate code to AnswerX implementations, whenever they use methods that declare checked exceptions. Plus, AnswerX should behave exactly as good old Answer interface!
Reported via the [mailing-list](h... | [
"src/main/java/org/mockito/stubbing/Answer1.java",
"src/main/java/org/mockito/stubbing/Answer2.java",
"src/main/java/org/mockito/stubbing/Answer3.java",
"src/main/java/org/mockito/stubbing/Answer4.java",
"src/main/java/org/mockito/stubbing/Answer5.java",
"src/main/java/org/mockito/stubbing/VoidAnswer1.jav... | [
"src/main/java/org/mockito/stubbing/Answer1.java",
"src/main/java/org/mockito/stubbing/Answer2.java",
"src/main/java/org/mockito/stubbing/Answer3.java",
"src/main/java/org/mockito/stubbing/Answer4.java",
"src/main/java/org/mockito/stubbing/Answer5.java",
"src/main/java/org/mockito/stubbing/VoidAnswer1.jav... | [] | diff --git a/src/main/java/org/mockito/stubbing/Answer1.java b/src/main/java/org/mockito/stubbing/Answer1.java
index 23bf06c66b..dcc3ce9083 100644
--- a/src/main/java/org/mockito/stubbing/Answer1.java
+++ b/src/main/java/org/mockito/stubbing/Answer1.java
@@ -3,13 +3,36 @@
import org.mockito.Incubating;
/**
- * One ... | null | train | train | 2016-10-24T06:17:32 | 2016-10-21T22:28:34Z | bric3 | train |
mockito/mockito/609_754 | mockito/mockito | mockito/mockito/609 | mockito/mockito/754 | [
"keyword_pr_to_issue"
] | 2025a1830ff356124c808bffb9306582a5d40c6f | 0d24b6391fe99d1af7cf176b1c09f295cda964d0 | [
"https://github.com/mockito/mockito/issues/384#issuecomment-243044175\n",
"@szczepiq This is not the javadoc but I've mentioned a bit the runner in the what's new / migration guide in the wiki in the improvement section \n\nhttps://github.com/mockito/mockito/wiki/What%27s-new-in-Mockito-2\n",
"Per https://githu... | [] | 2016-11-14T05:07:55Z | [
"docs"
] | Silent JUnit runner and quiet JUnit rule are better expose in the docs | See great feedback from a user in #384
| [
"src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java"
] | [
"src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java"
] | [
"src/test/java/org/mockitousage/junitrunner/UnusedStubsExceptionMessageTest.java"
] | diff --git a/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java b/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java
index 39fbae80ee..603dc349e1 100644
--- a/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java
+++ b/src/main/java/org... | diff --git a/src/test/java/org/mockitousage/junitrunner/UnusedStubsExceptionMessageTest.java b/src/test/java/org/mockitousage/junitrunner/UnusedStubsExceptionMessageTest.java
index 3760e64467..637f7acac5 100644
--- a/src/test/java/org/mockitousage/junitrunner/UnusedStubsExceptionMessageTest.java
+++ b/src/test/java/org... | train | train | 2016-11-12T17:08:33 | 2016-08-29T16:18:39Z | mockitoguy | train |
mockito/mockito/762_763 | mockito/mockito | mockito/mockito/762 | mockito/mockito/763 | [
"keyword_pr_to_issue"
] | b30b33f8b56605d9dd7711d0b25e704b2e419eed | 235fd4d850a2fe25a2c871bfacf35d7672708e3c | [] | [
"This change does not work, see https://github.com/mockito/mockito/pull/760#issuecomment-261229080\n"
] | 2016-11-17T13:13:53Z | [
"docs"
] | Public javadoc offers links to internal classes | In few places in public javadoc we offer links to internal classes. Instead, we should document the public API without links to private classes. How to find offenders? Generate javadoc and look for:
- \<code\>ReturnsEmptyValues
- \<code\>org.mockito.internal | [
"build.gradle",
"buildSrc/src/main/java/org/mockito/javadoc/JavadocExclude.java",
"gradle/javadoc.gradle",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/except... | [
"build.gradle",
"gradle/javadoc.gradle",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/exceptions/stacktrace/StackTraceCleaner.java",
"src/main/java/org/mockit... | [
"subprojects/testng/testng.gradle"
] | diff --git a/build.gradle b/build.gradle
index ada4849ffb..4a6588f14f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -6,7 +6,7 @@ buildscript {
dependencies {
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.2' //publishing to bintray
- classpath'nl.javadude.gradle.plugins:license-gra... | diff --git a/subprojects/testng/testng.gradle b/subprojects/testng/testng.gradle
index 42f2c1a17c..ac90dac0eb 100644
--- a/subprojects/testng/testng.gradle
+++ b/subprojects/testng/testng.gradle
@@ -35,6 +35,8 @@ artifacts {
archives sourcesJar
}
+tasks.javadoc.enabled = false
+
uploadArchives {
repositor... | train | train | 2016-11-17T13:41:02 | 2016-11-17T05:52:17Z | mockitoguy | train |
mockito/mockito/755_763 | mockito/mockito | mockito/mockito/755 | mockito/mockito/763 | [
"keyword_issue_to_pr"
] | b30b33f8b56605d9dd7711d0b25e704b2e419eed | 235fd4d850a2fe25a2c871bfacf35d7672708e3c | [
"Was fixed in #763"
] | [
"This change does not work, see https://github.com/mockito/mockito/pull/760#issuecomment-261229080\n"
] | 2016-11-17T13:13:53Z | [
"docs"
] | Tidy-up javadoc generation | I investigated the need for Javadoc doclet rule that currently is kept in buildSrc.
- currently, some javadoc links from public API lead to internal API, which gives 404 error (search for ReturnEmptyValues in public Mockito.html, click the link, 404).
- excluding files at the Javadoc task level does not prevent Jav... | [
"build.gradle",
"buildSrc/src/main/java/org/mockito/javadoc/JavadocExclude.java",
"gradle/javadoc.gradle",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/except... | [
"build.gradle",
"gradle/javadoc.gradle",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/exceptions/stacktrace/StackTraceCleaner.java",
"src/main/java/org/mockit... | [
"subprojects/testng/testng.gradle"
] | diff --git a/build.gradle b/build.gradle
index ada4849ffb..4a6588f14f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -6,7 +6,7 @@ buildscript {
dependencies {
classpath 'com.jfrog.bintray.gradle:gradle-bintray-plugin:1.2' //publishing to bintray
- classpath'nl.javadude.gradle.plugins:license-gra... | diff --git a/subprojects/testng/testng.gradle b/subprojects/testng/testng.gradle
index 42f2c1a17c..ac90dac0eb 100644
--- a/subprojects/testng/testng.gradle
+++ b/subprojects/testng/testng.gradle
@@ -35,6 +35,8 @@ artifacts {
archives sourcesJar
}
+tasks.javadoc.enabled = false
+
uploadArchives {
repositor... | val | train | 2016-11-17T13:41:02 | 2016-11-14T05:29:00Z | mockitoguy | train |
mockito/mockito/781_782 | mockito/mockito | mockito/mockito/781 | mockito/mockito/782 | [
"timestamp(timedelta=1.0, similarity=0.9228255909277773)"
] | 2e0533f3ed48ea838cf38a7dbeaaf4bcc11317b8 | db40b8c2fb5436c47da33c753bf3c6482de8460f | [
"When mockito runs on Java 8 it already provide default answers for `Optional` / `Stream`",
"I tested that before filing this issue; that's true for `Optional`, but not for `OptionalInt` and friends.",
"Oh ok I read too fast the issue description. Sorry ;)\r\n\r\nlooking forward the PR.",
"No worries :). PR f... | [
"It just asks to simplify it with parameterized tests, e.g. with https://github.com/Pragmatists/JUnitParams/wiki/Quickstart . @Stephan202, would you dare to do it? ;)",
"@szpak: I'm fine opening an extra PR, but I think the Mockito team should first decide on which parameterized test framework to use. The one you... | 2016-11-25T17:56:09Z | [] | Add default answers for java.util.Optional{Double,Int,Long} and java.util.stream.{Double,Int,Long}Stream | A natural generalization of #191 and #429 is to add default answers for the primitive `Optional` and `Stream` variants as well. I'm working on a PR proposal; will file soonish. | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java",
"src/main/java/org/mockito/internal/util/JavaEightUtil.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java",
"src/main/java/org/mockito/internal/util/JavaEightUtil.java"
] | [
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValuesTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java
index 58e40c2c01..2216cca7aa 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java
+++ b/src/main... | diff --git a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValuesTest.java b/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValuesTest.java
index b1553542b4..480a9a1c7f 100644
--- a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValuesTest.java
++... | train | train | 2016-11-25T18:24:20 | 2016-11-25T17:37:36Z | Stephan202 | train |
mockito/mockito/756_795 | mockito/mockito | mockito/mockito/756 | mockito/mockito/795 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8926900290820838)"
] | 75d7316fe9c80b7973597ba890c843b71c7a7a7e | d52d8f4d6c543a8666991f4aec41098434e27639 | [
"Fantastic bug report: reproducible sample, clear motivation. Thanks! I'm looking at it now.\n",
"I was able to repro this with a smaller example that does not use netty. It's a bug that needs to be fixed. Thank you for reporting!\n\n``` java\n@RunWith(MockitoJUnitRunner.class)\npublic class MockitoDeepStubsTest ... | [
"Could you add one more call after `getFoo()` to make sure it does not crash on a second invocation? Just to make sure and base on the original bug report.",
"Absolutely, good idea.\r\n\r\n(My test does reproduce the incorrect the behavior)."
] | 2016-12-01T06:22:22Z | [
"bug"
] | Deep stubbing and UnnecessaryStubbingException | Mocks that return deep stubs sometimes cause UnnecessaryStubbingExceptions to be thrown, when I don't think that they should. Here's a small self-contained example.
```
package some.package;
import org.jboss.netty.channel.ChannelFuture;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockit... | [
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/test/java/org/mockitousage/junitrunner/DeepStubbingWithJUnitRunnerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java b/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java
index f283f5227c..5fd76c096e 100644
--- a/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java
+++ b/src/main/java/org/mockito/internal/stu... | diff --git a/src/test/java/org/mockitousage/junitrunner/DeepStubbingWithJUnitRunnerTest.java b/src/test/java/org/mockitousage/junitrunner/DeepStubbingWithJUnitRunnerTest.java
new file mode 100644
index 0000000000..77ea85b879
--- /dev/null
+++ b/src/test/java/org/mockitousage/junitrunner/DeepStubbingWithJUnitRunnerTest.... | test | train | 2016-11-30T15:12:05 | 2016-11-14T22:01:19Z | bschelberg | train |
mockito/mockito/798_813 | mockito/mockito | mockito/mockito/798 | mockito/mockito/813 | [
"timestamp(timedelta=43.0, similarity=0.9208988661090468)"
] | 6eaa2d0bab532196468d364d84cc1e9f44f77dea | 5ee677b834032c69edc430464d27b1e58916e364 | [
"Release approaching ;)",
"`0.7.8` has been released: https://github.com/jacoco/jacoco/issues/467#issuecomment-266305876",
"Fixed by #798."
] | [] | 2016-12-12T21:10:32Z | [
"java-9"
] | Update Jacoco to stable minor version 0.7.8 when released | See https://github.com/jacoco/jacoco/issues/467#issuecomment-264311016
The snapshot version of Jacoco are removed and could fail our CI. The version of Jacoco is required to build on JDK9 | [
"gradle/coverage.gradle"
] | [
"gradle/coverage.gradle"
] | [] | diff --git a/gradle/coverage.gradle b/gradle/coverage.gradle
index 9ad6740879..86fc3a190b 100644
--- a/gradle/coverage.gradle
+++ b/gradle/coverage.gradle
@@ -2,14 +2,8 @@ apply plugin: 'jacoco'
// TODO later include subprojects, possible ideas https://gist.github.com/aalmiray/e6f54aa4b3803be0bcac
-repositories {
... | null | val | train | 2016-12-02T01:16:19 | 2016-12-01T23:22:33Z | TimvdLippe | train |
mockito/mockito/820_821 | mockito/mockito | mockito/mockito/820 | mockito/mockito/821 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | c2261b5d6df55a68302875a5b70503856c51a296 | 40ab88b61d0a37c55d3f0bc39e07bb5c9efb8a49 | [
"I think your second example has a typo, since there are no var args in the example",
"thanks fixed",
"Good catch!\r\nBy the way, the mock reference is both foo and mock",
"While it is source and binary compatible, vararg method are different than plain old array method, reflection allows to distinguish that.... | [
"French comment? 😂 ",
"spacing",
"haha yes, I'm sick, so my brain had to think in french and slowly"
] | 2016-12-14T18:01:23Z | [
"bug"
] | [VarArgs] unexpected behaviour of returnsArgAt(int) | I stumble about a test that failed after refactoring an array parameter to an varargs.
The following test succeed:
```java
interface Foo{
int[] getOdd(int[] input);
}
@Test
public void test() throws Exception {
when(foo.getOdd(any())).then(returnsArgAt(0));
int[] odd = mock.getOdd... | [
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java"
] | [
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java",
"src/test/java/org/mockitousage/IMethods.java",
"src/test/java/org/mockitousage/MethodsImpl.java"
] | diff --git a/src/main/java/org/mockito/AdditionalAnswers.java b/src/main/java/org/mockito/AdditionalAnswers.java
index 348743da04..287e4b1830 100644
--- a/src/main/java/org/mockito/AdditionalAnswers.java
+++ b/src/main/java/org/mockito/AdditionalAnswers.java
@@ -36,20 +36,44 @@
*/
@SuppressWarnings("unchecked")
pub... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java b/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java
index 5ccdbd0926..f72005aeaa 100644
--- a/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java
+++ b/src/test/java/org/mo... | train | train | 2017-01-02T17:48:41 | 2016-12-14T14:40:38Z | ChristianSchwarz | train |
mockito/mockito/838_839 | mockito/mockito | mockito/mockito/838 | mockito/mockito/839 | [
"keyword_pr_to_issue"
] | 799b70da90b75982746665fed7e2533b9b5e1fc7 | 1193d14587bfa2344ce07e2e16adbc5ba32c4be4 | [
"As the question is answered in SO, you can negate matchers using `AdditionalMatchers.not()`.\r\n\r\nI think I can close this issue.",
"OK... but this question highlights the fact that the online documentation and tutorials are not optional, they are essential ... and they are currently inadequate. People who ar... | [] | 2016-12-22T13:50:01Z | [
"enhancement"
] | Feature request: ArgumentMatchers.matches(Pattern regex) | you ladies and gentlemen are geniuses by the way.
ArgumentMatchers.match( String regex ) exists... but wouldn't it be slightly better if it were match( Pattern regex )? (i.e. catering for multi-line Strings, etc.).
Also, devising a regex which distinctly does NOT match a given String is non-trivial. And yet not ... | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/internal/matchers/Matches.java"
] | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/internal/matchers/Matches.java"
] | [
"src/test/java/org/mockito/internal/matchers/MatchersToStringTest.java",
"src/test/java/org/mockitousage/matchers/MatchersTest.java"
] | diff --git a/src/main/java/org/mockito/ArgumentMatchers.java b/src/main/java/org/mockito/ArgumentMatchers.java
index 66d05a7ac0..56ff53311f 100644
--- a/src/main/java/org/mockito/ArgumentMatchers.java
+++ b/src/main/java/org/mockito/ArgumentMatchers.java
@@ -4,8 +4,6 @@
*/
package org.mockito;
-import static org.m... | diff --git a/src/test/java/org/mockito/internal/matchers/MatchersToStringTest.java b/src/test/java/org/mockito/internal/matchers/MatchersToStringTest.java
index c62756bcd4..9611dee2a6 100644
--- a/src/test/java/org/mockito/internal/matchers/MatchersToStringTest.java
+++ b/src/test/java/org/mockito/internal/matchers/Mat... | train | train | 2016-12-21T06:35:10 | 2016-12-21T21:27:04Z | Mrodent | train |
mockito/mockito/845_847 | mockito/mockito | mockito/mockito/845 | mockito/mockito/847 | [
"timestamp(timedelta=1.0, similarity=0.8883307402829964)"
] | 18320605e0f1b161581263864c97848f41b1a9f6 | 228e3a5b171a782cc5dcf022d123064c23ef2d31 | [
"If the renaming is only needed when creating a distribution jar, you can customize the jar task with something like this:\r\n\r\n`jar {\r\n rename \"org/mockito/internal/creation/bytebuddy/MockMethodDispatcher.class\", \"org/mockito/internal/creation/bytebuddy/MockMethodDispatcher.raw\"\r\n}`\r\n\r\nIf you need t... | [
"In order for this to work reliably, we need to also set one more task dependency on compileJava. Let me try to update the code in the branch...",
"Above change makes the compiled classes directory contain both: the 'raw' and normal class. Is this what we want?",
"Yes, for the time until packaging the jar. This... | 2016-12-26T15:08:05Z | [
"android",
"final-class-or-methods"
] | Rename MockMethodDispatcher.class to MockMethodDispatcher.raw on build | The `org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.class` file should be renamed to `org.mockito.internal.creation.bytebuddy.MockMethodDispatcher.raw` on building Mockito. This way, class loaders are no longer capable of loading the class directly what should never happen. Doing so, the bootstrap injecti... | [
"build.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"build.gradle",
"gradle/mockito-core/inline-mock.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java",
"src/test/java/org/mockito/internal/junit/JUnitRuleTest.java",
"src/test/java/org/mockitointegration/NoJUnitDependenciesTest.java"
] | diff --git a/build.gradle b/build.gradle
index fdd11d9b4a..08d1c3d37b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -23,7 +23,7 @@ ext {
artifactName = 'mockito-core'
bintrayAutoPublish = true
bintrayRepo = 'maven'
- mavenCentralSync = false
+ mavenCentralSync = true
}
allprojects {
@@ -69,6 ... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java
index 3b5256dae4..ee36f6de77 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java... | test | train | 2016-12-26T06:52:39 | 2016-12-26T12:25:45Z | raphw | train |
mockito/mockito/866_867 | mockito/mockito | mockito/mockito/866 | mockito/mockito/867 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8665890352634279)"
] | d972c99572ed038078c5a755c4afd41b0e8f9d28 | f86a598594e4c732a13193fc95a00b5775099631 | [
"This is a bug in the user code. Yet Mockito should handle that gracefully.\r\n\r\nThanks for reporting."
] | [
"Actually I'd rather make the check in `ConditionalStackTraceFilter.filter()`. And if throwable is null, just return.",
"Ok! already changed,please review. ",
"Sorry it seems I was wrong. It seems that indeed your previous attempt was correct.\r\n\r\n```java\r\n if (t == null) {\r\n throw thro... | 2017-01-04T14:16:26Z | [
"bug"
] | When custom exception fillInstackTrace() returns null, Exception mock cannot work properly | ```java
public class CustomException extends Exception {
public CustomException() {
super();
}
@Override
public Exception fillInStackTrace() {
return null;
}
}
```
TestCase like this
```java
when(demo.process()).thenThrow(new CustomException())
//... test code
... | [
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java"
] | [
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java"
] | [
"src/test/java/org/mockitousage/bugs/NPEWhenCustomExceptionStackTraceReturnNullTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java b/src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java
index d323e80b9e..037520fee3 100644
--- a/src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java
+++ b/src/main/java/org/mockito/internal/stu... | diff --git a/src/test/java/org/mockitousage/bugs/NPEWhenCustomExceptionStackTraceReturnNullTest.java b/src/test/java/org/mockitousage/bugs/NPEWhenCustomExceptionStackTraceReturnNullTest.java
new file mode 100644
index 0000000000..50acbad954
--- /dev/null
+++ b/src/test/java/org/mockitousage/bugs/NPEWhenCustomExceptionS... | val | train | 2017-01-04T15:52:28 | 2017-01-03T08:29:31Z | wuwen5 | train |
mockito/mockito/879_880 | mockito/mockito | mockito/mockito/879 | mockito/mockito/880 | [
"timestamp(timedelta=50952.0, similarity=0.9218907831467025)"
] | 64c2f61274a59eb3d86f1f122d71a80d9a1231be | fd2a49b33d878d5080c70dfe876bc5da2fed7cf1 | [
"@TimvdLippe should this issue be closed now that the PR is merged, or should this fix be backported to the 2.x branch too?",
"@mureinik Oh right it was to the wrong branch 😭 That's my mistake. I will backport it manually"
] | [] | 2017-01-12T20:38:56Z | [] | Grammar issue in ArgumentMatchers' javadoc. | [`ArgumentMatchers`' javadoc](https://static.javadoc.io/org.mockito/mockito-core/2.6.1/org/mockito/ArgumentMatchers.html) states that:
> This implementation is due static type safety imposed by java compiler.
There's a word missing there. It should read:
> This implementation is due **to** static type safety ... | [
"src/main/java/org/mockito/ArgumentMatchers.java"
] | [
"src/main/java/org/mockito/ArgumentMatchers.java"
] | [] | diff --git a/src/main/java/org/mockito/ArgumentMatchers.java b/src/main/java/org/mockito/ArgumentMatchers.java
index 56ff53311f..a28eaafe36 100644
--- a/src/main/java/org/mockito/ArgumentMatchers.java
+++ b/src/main/java/org/mockito/ArgumentMatchers.java
@@ -91,7 +91,7 @@
* <p>
* Matcher methods like <code>anyObjec... | null | val | train | 2017-01-04T16:02:14 | 2017-01-12T20:35:12Z | mureinik | train |
mockito/mockito/882_884 | mockito/mockito | mockito/mockito/882 | mockito/mockito/884 | [
"timestamp(timedelta=42649.0, similarity=0.9349826054048819)"
] | fd2a49b33d878d5080c70dfe876bc5da2fed7cf1 | 695eb9bf2cd8c76cdcdb91bf68b9292894249d44 | [] | [] | 2017-01-14T09:11:11Z | [
"java-9"
] | Upgrading to Objenesis 2.5 | Mockito already uses Objenesis 2.4.
However Objenesis 2.5 was just released and supports the latest [JDK 9 build 151 jigsaw](http://objenesis.org/notes.html) | [
"build.gradle",
"gradle/mockito-core/osgi.gradle"
] | [
"build.gradle",
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index f363fd2557..72a2e65524 100644
--- a/build.gradle
+++ b/build.gradle
@@ -50,7 +50,7 @@ dependencies {
compile 'net.bytebuddy:byte-buddy-agent:1.5.12'
provided "junit:junit:4.12", "org.hamcrest:hamcrest-core:1.3"
- compile "org.objenesis:objenesis:2.4"
+ co... | null | train | train | 2017-01-12T21:45:02 | 2017-01-13T15:05:44Z | bric3 | train |
mockito/mockito/871_886 | mockito/mockito | mockito/mockito/871 | mockito/mockito/886 | [
"keyword_pr_to_issue"
] | 9ff4fa2e0e6246035c3441fac172cc179590e4f3 | 307cffd4201395ab304c3842bc74dc11336243ae | [
"I think the easiest solution is to not assert the GH_TOKEN if the build is a pull request",
"Can't we just disable the checks if the repo is not mockito/mockito ?",
"Pull requests always have `mockito/mockito` as repository?",
"No only ours, external contributors have a fork. Since the GH_TOKEN assertion don... | [] | 2017-01-15T18:57:07Z | [
"bug",
"continuous integration"
] | Travis builds from non-core developers fail on assertEnvVariables | Example build: https://travis-ci.org/mockito/mockito/jobs/188911380
Seems that this does not affect core developers, as my build has been succesful: https://travis-ci.org/mockito/mockito/builds/188321204 as well as those in #865 and #859 | [
"gradle/root/release.gradle"
] | [
"gradle/root/release.gradle"
] | [] | diff --git a/gradle/root/release.gradle b/gradle/root/release.gradle
index 44d938bc72..821070ff99 100644
--- a/gradle/root/release.gradle
+++ b/gradle/root/release.gradle
@@ -254,10 +254,10 @@ task pushChanges(type: Exec) {
}
releaseWorkflow {
- step assertEnvVariables
- step assertCleanWorkingCopy
step ... | null | val | train | 2017-01-13T11:58:06 | 2017-01-06T14:41:43Z | TimvdLippe | train |
mockito/mockito/882_887 | mockito/mockito | mockito/mockito/882 | mockito/mockito/887 | [
"timestamp(timedelta=0.0, similarity=0.9349826054048819)"
] | 307cffd4201395ab304c3842bc74dc11336243ae | b6e844d69b0cbec90fc5714513b09be7c0676a4e | [] | [] | 2017-01-15T20:51:27Z | [
"java-9"
] | Upgrading to Objenesis 2.5 | Mockito already uses Objenesis 2.4.
However Objenesis 2.5 was just released and supports the latest [JDK 9 build 151 jigsaw](http://objenesis.org/notes.html) | [
"build.gradle",
"gradle/mockito-core/osgi.gradle"
] | [
"build.gradle",
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index 2eac447f58..7b9b8da4a3 100644
--- a/build.gradle
+++ b/build.gradle
@@ -49,7 +49,7 @@ dependencies {
compile 'net.bytebuddy:byte-buddy-agent:1.6.2'
provided "junit:junit:4.12", "org.hamcrest:hamcrest-core:1.3"
- compile "org.objenesis:objenesis:2.4"
+ com... | null | test | train | 2017-01-15T20:13:00 | 2017-01-13T15:05:44Z | bric3 | train |
mockito/mockito/895_896 | mockito/mockito | mockito/mockito/895 | mockito/mockito/896 | [
"timestamp(timedelta=0.0, similarity=0.9721334097970477)",
"keyword_pr_to_issue"
] | e983acdef8da0076f1980f622363d179e1eff680 | 46aab5420904b731c4351c6fcd250f647a8f90ba | [
"I am going to submit a Pull Request, adding an additional clarification with code example in the docs."
] | [
"I'd rephrase to : \r\n\r\n```\r\n<strong>Warning</strong> : if instead of chaining {@code .thenReturn()} calls, multiple stubbing with same matchers or arguments are used then each stubbing will override the previous one :\r\n```",
"Sure, sounds much better. I'm going to update the PR to this."
] | 2017-01-20T15:51:46Z | [
"docs"
] | Documentation missing clarification for consecutive stubbing | The [documentation](https://static.javadoc.io/org.mockito/mockito-core/2.6.3/org/mockito/Mockito.html#10) for consecutive stubbing is missing a clarification.
When multiple when/thenReturn statements are being used instead of chaining .thenReturn() statements, each stubbing overrides the existing one.
| [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 228997d4b0..27f0768054 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -452,6 +452,16 @@
* .thenReturn("one", "two", "three");
* </code></pre>
*
+ * <strong>Warn... | null | train | train | 2017-01-19T18:12:14 | 2017-01-20T15:42:19Z | dimosr | train |
mockito/mockito/876_897 | mockito/mockito | mockito/mockito/876 | mockito/mockito/897 | [
"keyword_pr_to_issue"
] | 695eb9bf2cd8c76cdcdb91bf68b9292894249d44 | 783d1fa37e3a7d483ed56907262424631a3442d9 | [
"Do you mean argument matcher or mock return values?",
"I mean default return value of a mock.",
"Here is a quick fix, sadly I can't push throu the firewall.\r\n\r\n```java\r\nif (type.isArray()) {\r\n Class<?> componentType = type.getComponentType();\r\n return Array.newInstance(componentType, 0);\r\n}\... | [
"If this class now only returns an emptry String, why don't we remove this class and move the empty string to `ReturnsEmptyValues`?",
"Actually I don't think that's part of this PR. And I find that returning empty string instead of `null` more debattable (hence a separate PR).",
"Oh nice! It's good to take adva... | 2017-01-21T13:48:22Z | [
"enhancement",
"in progress"
] | Mockito should return an empty array for default values | Mockito returns by default interesting default values for some types :
* Long ⇒ 0
* Optional ⇒ Optional.empty
* List => new ArrayList(0)
But it don't return an empty array currently. | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java",
"src/main/java/org/mockito/internal/util/JavaEightUtil.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java",
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValuesTest.java",
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValuesTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java
index 2216cca7aa..e667b19811 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java
+++ b/src/main... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java b/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java
index 4406499946..734a6ace7d 100644
--- a/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java
+++ b/src/test/java/org/mockito/... | test | train | 2017-01-15T10:12:31 | 2017-01-11T15:48:36Z | bric3 | train |
mockito/mockito/814_905 | mockito/mockito | mockito/mockito/814 | mockito/mockito/905 | [
"keyword_pr_to_issue"
] | de0a7725667bbc025f1bd78310fbbf8cde4d8bb6 | d8f529ee4b254c57edc1a97d0505ac57da7c7225 | [
"I don't see what you mean I have no problem for that : \r\n\r\n* https://static.javadoc.io/org.mockito/mockito-core/2.3.0/org/mockito/Mockito.html#40\r\n* https://static.javadoc.io/org.mockito/mockito-core/2.3.0/org/mockito/Mockito.html#strict_mockito",
"At first it seems to be working, but the actual issue is t... | [] | 2017-01-23T14:39:51Z | [
"docs"
] | Javadoc links in main Mockito doc are not linkable | The links to line items in the main [Mockito documentation](https://static.javadoc.io/org.mockito/mockito-core/2.3.0/org/mockito/Mockito.html) are not linkable, e.g. I cannot create a link to item no. 40 in the list. | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 27f0768054..895607bd25 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -82,7 +82,7 @@
* <a href="#40">40. (**new**) Improved productivity and cleaner tests with "... | null | val | train | 2017-01-23T14:52:08 | 2016-12-13T07:14:18Z | mockitoguy | train |
mockito/mockito/426_907 | mockito/mockito | mockito/mockito/426 | mockito/mockito/907 | [
"keyword_pr_to_issue"
] | f967b930042c624fa75c059aa6a5b1c5d013f6af | 8f9d6ff2fd674bce3ee3aaba2a282d816eed2e60 | [
"@raphw thanks for merging the PR that fast! Would you mind reopening this ticket? There are more classes that can be refactored that way, I would like to extend the list.\n",
"Big :+1: for me btw, but please keep the pull requests managable and as small as possible. Preferably refactoring 1 method at a time. Th... | [] | 2017-01-26T12:17:39Z | [] | Refactor instance based utility classes to static utility classes | The internal implementation of Mockito contains numerous helper classed that serve as a container for useful methods. By its nature these classes don't have a state. Currently some them are instance based in other word you need to create the utility class to call a helper method. This not only pollutes the heap but als... | [
"src/main/java/org/mockito/internal/verification/Calls.java",
"src/main/java/org/mockito/internal/verification/Times.java",
"src/main/java/org/mockito/internal/verification/checkers/NonGreedyNumberOfInvocationsInOrderChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocationsC... | [
"src/main/java/org/mockito/internal/verification/Calls.java",
"src/main/java/org/mockito/internal/verification/Times.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocationsChecker.java"
] | [
"src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsCheckerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsInOrderCheckerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/verification/Calls.java b/src/main/java/org/mockito/internal/verification/Calls.java
index e7e7eeef0d..3d9bc84fa7 100644
--- a/src/main/java/org/mockito/internal/verification/Calls.java
+++ b/src/main/java/org/mockito/internal/verification/Calls.java
@@ -5,20 +5,18 @@
... | diff --git a/src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsCheckerTest.java b/src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsCheckerTest.java
index d692fac57d..af9d3cb801 100644
--- a/src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsC... | val | train | 2017-01-23T15:53:02 | 2016-06-11T13:23:18Z | ChristianSchwarz | train |
mockito/mockito/903_932 | mockito/mockito | mockito/mockito/903 | mockito/mockito/932 | [
"keyword_pr_to_issue"
] | c81d80100f713c87dde74126e0352eb530931b99 | 441540c9c6cca8b58e822d39eda3d1dcefe309be | [
"I have to push the code style decided a few months ago, maybe gradle can generate a section with the mockito style for IDEA (and eclipse and netbeans)",
"Absolutely great idea. Perhaps it's worth waiting for Mockito3 before we do that to avoid merging problems?"
] | [
"Don't we also need the dev dependency for checkstyle?",
"Not sure what you mean by this. Could you please elaborate?\r\n",
"@TimvdLippe, we don't need any extra dependency. checkstyle plugin is a part of Gradle distribution. Good question!",
"@mureinik, do we need separate checker configurations per submodul... | 2017-02-05T21:37:13Z | [
"refactoring"
] | Review usage of linter during build | Given the amount of stylistic changes lately in primarily @bric3 PRs, I think we should consider installing a linter to make sure the style is enforced project wide. In my opinion this linter should be extremely lenient, just enforce some very simple rules.
We can look into configuring Checkstyle such that it checks... | [
"build.gradle",
"gradle/java-library.gradle",
"src/main/java/org/mockito/internal/stubbing/answers/DoesNothing.java"
] | [
"build.gradle",
"config/checkstyle/checkstyle.xml",
"config/checkstyle/checkstyle.xsl",
"gradle/java-library.gradle",
"src/main/java/org/mockito/internal/stubbing/answers/DoesNothing.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/DoesNothingTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/InvocationInfoTest.java",
"src/test/java/org/mockitousage/IMethods.java"
] | diff --git a/build.gradle b/build.gradle
index 2f85ad0e54..f5ab5b4fbd 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,6 +35,10 @@ allprojects {
options.warnings = false
options.encoding = 'UTF-8'
}
+ apply plugin: 'checkstyle'
+ checkstyle {
+ configFile = rootProject.file('config... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/DoesNothingTest.java b/src/test/java/org/mockito/internal/stubbing/answers/DoesNothingTest.java
index 06f950e2ba..f3c83ffad0 100644
--- a/src/test/java/org/mockito/internal/stubbing/answers/DoesNothingTest.java
+++ b/src/test/java/org/mockito/internal/stu... | val | train | 2017-02-16T22:12:08 | 2017-01-23T10:23:07Z | TimvdLippe | train |
mockito/mockito/927_933 | mockito/mockito | mockito/mockito/927 | mockito/mockito/933 | [
"keyword_pr_to_issue"
] | 3e9a94b7b9938dbdb882e28c24c2b163c2d19390 | 275586ecf3a00da078b6fb7e9cc4508231cc4301 | [] | [
"Spacing around `=`",
"Very nice! Thank you for updating the documentation diligently."
] | 2017-02-06T12:43:14Z | [] | Mockito can't unbox Void | Hi,
The following [bug](https://github.com/powermock/powermock/issues/708) was created for PowerMock:
> PowerMockito doesn't seem to unbox java.lang.Void.
> I am writing a test for my code that uses Google cloud storage API to delete a file. Google API returns Void for deleting a file. Code works fine but when... | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/DoesNothing.java",
"src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java"
] | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/DoesNothing.java",
"src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java"
] | [
"src/test/java/org/mockito/internal/junit/UnusedStubbingsTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/DoesNothingTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/InvocationInfoTest.java",
"src/test/java/org/mockitousage/IMethods.java",
"src/test/java/org/mockitousage/Meth... | diff --git a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
index 9f1f8db523..f768cc829f 100644
--- a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
+++ b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
@@ -6,12 +6,1... | diff --git a/src/test/java/org/mockito/internal/junit/UnusedStubbingsTest.java b/src/test/java/org/mockito/internal/junit/UnusedStubbingsTest.java
index 5ea343a6c3..cfff121d7e 100644
--- a/src/test/java/org/mockito/internal/junit/UnusedStubbingsTest.java
+++ b/src/test/java/org/mockito/internal/junit/UnusedStubbingsTes... | train | train | 2017-02-06T16:04:22 | 2017-02-03T18:42:17Z | thekingn0thing | train |
mockito/mockito/894_934 | mockito/mockito | mockito/mockito/894 | mockito/mockito/934 | [
"timestamp(timedelta=0.0, similarity=0.8756630753506662)",
"keyword_pr_to_issue"
] | 3e9a94b7b9938dbdb882e28c24c2b163c2d19390 | 64ab2f7f52c2cc8f0a3381df5fecbc8d30b5d765 | [
"I tried to add in previous Open JDK 8 (102) but the option is not recognized\r\n\r\n```\r\noption.addStringOption('--allow-script-in-comments')\r\noption.addStringOption('-allow-script-in-comments')\r\noption.addStringOption('allow-script-in-comments')\r\n```\r\n\r\nI'll try later with the same JDK (121)",
"Coul... | [
"Thank you for fixing the problem and documenting it diligently!"
] | 2017-02-06T14:34:05Z | [
"java-8",
"continuous integration"
] | Javadoc generation fails with jdk1.8.0_121 | When I set the jdk to jdk1.8.0_121 the build fails javadoc error.
Full log including steps to reproduce:
```
~/mockito/src$ export JAVA_HOME=/Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/
~/mockito/src$ ./gradlew javadoc -i
...
javadoc: error - Argument for -top contains JavaScript.
... | [
"gradle/mockito-core/javadoc.gradle"
] | [
"gradle/mockito-core/javadoc.gradle"
] | [] | diff --git a/gradle/mockito-core/javadoc.gradle b/gradle/mockito-core/javadoc.gradle
index 5bb5203299..a8d4be36ec 100644
--- a/gradle/mockito-core/javadoc.gradle
+++ b/gradle/mockito-core/javadoc.gradle
@@ -66,8 +66,18 @@ javadoc {
""".replaceAll(/\r|\n|[ ]{8}/, ""))
if (JavaVersion.current().isJava8Compatibl... | null | val | train | 2017-02-06T16:04:22 | 2017-01-20T15:07:48Z | mockitoguy | train |
mockito/mockito/680_942 | mockito/mockito | mockito/mockito/680 | mockito/mockito/942 | [
"timestamp(timedelta=0.0, similarity=0.9999999999999999)",
"keyword_pr_to_issue"
] | 64ab2f7f52c2cc8f0a3381df5fecbc8d30b5d765 | bba71f645680a33d0d21fef49aa916399c0bc9b9 | [
"> mock(DM.class, withSettings().useDefaultMethods())\n\nI like that. 'spyDefaultMethods'?\n\nBTW. What's better/more intuitive default for default methods? real method invocation or empty/unstubbed value?\n",
"I think that depends on the mocked type. I'd say :\n- interface => use default methods by default\n- co... | [
"Nice! Thank you for updating the test!",
"Nice and clean! Thank you!"
] | 2017-02-12T21:29:48Z | [
"new feature",
"java-8",
"noteworthy",
"please contribute"
] | Allow spying on interfaces so that it is convenient to work with Java 8 default methods | ## Problem
While Mockito supports and stubs by default the _default methods_ in interfaces, the stubbing code can be a bit non intuitive, e.g.
``` java
interface DM {
int contract();
default int default_contract() { return contract() + 1; }
}
DM dm = mock(DM.class);
given(dm.contract()).willReturn... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/configuration/SpyAnnotationEngine.java"
] | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/configuration/SpyAnnotationEngine.java"
] | [
"src/test/java/org/mockitousage/annotation/SpyAnnotationTest.java",
"src/test/java/org/mockitousage/annotation/WrongSetOfAnnotationsTest.java",
"src/test/java/org/mockitousage/constructor/CreatingMocksWithConstructorTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 8582cce078..35697eafd3 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -64,7 +64,7 @@
* <a href="#27">27. Delegate calls to real instance (Since 1.9.5)</a><br/>
... | diff --git a/src/test/java/org/mockitousage/annotation/SpyAnnotationTest.java b/src/test/java/org/mockitousage/annotation/SpyAnnotationTest.java
index 157e08a65c..82c530b1f3 100644
--- a/src/test/java/org/mockitousage/annotation/SpyAnnotationTest.java
+++ b/src/test/java/org/mockitousage/annotation/SpyAnnotationTest.ja... | train | train | 2017-02-08T11:10:42 | 2016-10-07T09:29:53Z | bric3 | train |
mockito/mockito/960_966 | mockito/mockito | mockito/mockito/960 | mockito/mockito/966 | [
"timestamp(timedelta=0.0, similarity=0.9276498021435603)",
"keyword_pr_to_issue"
] | a59cc571674ba23acedc47003a09d129603a98c6 | b413bbeee9f6dc4b61bee8fb394c0c376dc48075 | [] | [
"I'll also add : \r\n\r\n```\r\ncharset=utf-8\r\n```\r\n\r\n",
"I've met in some placed that option disabled for markdown files:\r\n\r\n```\r\n[*.md]\r\ntrim_trailing_whitespace = false\r\n```\r\n\r\nHowever, I'm not sure if it was a copy-paste from one source or there is a valid use case where new whitespace in ... | 2017-02-25T15:34:04Z | [] | Add editor configuration to ease the process of adhering to Checkstyle | We recently added the enforcement of Checkstyle. @ChristianSchwarz requested in https://github.com/mockito/mockito/pull/908#issuecomment-281468837 to also include a default template or at least provide steps for developers to automatically adhere to the style guide. E.g. no manual labor required, the IDE fixes it for t... | [
".github/CONTRIBUTING.md"
] | [
".editorconfig",
".github/CONTRIBUTING.md"
] | [] | diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 0000000000..88fd9c2e0b
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,8 @@
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+trim_trailing_whitespace = true
+indent_style = space
+indent_size = 4
diff --git a/.github/CONTRIBUTING.md b... | null | val | train | 2017-02-21T21:43:08 | 2017-02-21T20:27:00Z | TimvdLippe | train |
mockito/mockito/982_983 | mockito/mockito | mockito/mockito/982 | mockito/mockito/983 | [
"timestamp(timedelta=0.0, similarity=0.9999999999999998)"
] | 64a1180ec625f9ef50fc35a8a6c1e80b6f665b04 | 723d341ed8fc5decb7c358e557c76852ff219441 | [
"That seems like a reasonable issue. Looking forward to your pull request @paulduffin !",
"Should I make the change in release/2.x?\n\nOn 8 March 2017 at 12:57, Tim van der Lippe <notifications@github.com>\nwrote:\n\n> That seems like a reasonable issue. Looking forward to your pull request\n> @paulduffin <https:... | [] | 2017-03-08T16:38:10Z | [
"bug",
"1.* incompatible"
] | Break cyclical compile time dependency on hideRecursiveCall | I am working on upgrading the version of mockito in AOSP to 2.7.13 using byte buddy and byte buddy android rather than dexmaker.
As part of that I need to exclude a number of classes which will not compile on Android because it does not support Java agents/instrumentation. The mockito code has always been very well ... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java
index a98629564c..0258b67985 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java
+++ b/src/m... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java
index ee36f6de77..445c6f8905 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java... | train | train | 2017-03-06T00:25:41 | 2017-03-08T11:30:26Z | paulduffin | train |
mockito/mockito/981_985 | mockito/mockito | mockito/mockito/981 | mockito/mockito/985 | [
"timestamp(timedelta=0.0, similarity=0.931699655929002)"
] | 1599dfe84f953d5ef85c17471296fabbdd1b9a2b | d9a1e515f7d7ec1fd291292b3203995eafcf01a5 | [] | [] | 2017-03-10T09:54:11Z | [
"please contribute"
] | Update documentation about mockito-inline artifact | Mockito documentation currently does not explain "mockito-inline" artifact that is used for inline mocking (mocking finals). The main Mockito class still contains information on how to configure the inline mocking using a classpath resource. | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 5e74aa7790..f886627f56 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -36,6 +36,7 @@
* <b>
* <a href="#0">0. Migrating to Mockito 2</a><br/>
* <a href="... | null | train | train | 2017-03-09T13:05:05 | 2017-03-07T13:46:15Z | mockitoguy | train |
mockito/mockito/989_995 | mockito/mockito | mockito/mockito/989 | mockito/mockito/995 | [
"keyword_pr_to_issue"
] | 62a1d8828e7afb0f06dc6f4d135b54824d5eccf8 | 17db34508543150a70573fba3ca04bc4ba37a821 | [
"This was fixed in #989"
] | [
"Let's add a `@deprecated since 3.0.0` here, so we don't accidently remove it in the wrong version (which we did previously)",
"Since we deprecate the method anyways, is this test really required?",
"This still needs a `@since`",
"I would rather not name it with `2`. Probably better as `should_remove_all_inte... | 2017-03-21T08:43:15Z | [
"2.* incompatible",
"feedback-needed"
] | Misleading behavior of Mockito.verifyZeroInteractions() | ## Problem
Mockito.verifyZeroInteractions() actually does not do what it advertises. The purpose of this ticket is to discuss whether to change the behavior of this method in Mockito 3.
## Details
Based on user feedback at #977, from @ffissore, "verifyZeroInteractions" API can be misleading. When you read that... | [
"src/main/java/org/mockito/BDDMockito.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/MockitoCore.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/verification/VerificationModeFactory.java"
] | [
"src/main/java/org/mockito/BDDMockito.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/MockitoCore.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/verification/NoInteractions.java",
"src/main/java/org/mockito/int... | [
"src/test/java/org/mockito/MockitoTest.java",
"src/test/java/org/mockito/internal/InvalidStateDetectionTest.java",
"src/test/java/org/mockito/internal/verification/NoInteractionsTest.java",
"src/test/java/org/mockitousage/basicapi/ResetTest.java",
"src/test/java/org/mockitousage/customization/BDDMockitoTest... | diff --git a/src/main/java/org/mockito/BDDMockito.java b/src/main/java/org/mockito/BDDMockito.java
index 9090fa891d..ef478a1082 100644
--- a/src/main/java/org/mockito/BDDMockito.java
+++ b/src/main/java/org/mockito/BDDMockito.java
@@ -259,6 +259,12 @@ public interface Then<T> {
* @since 2.1.0
*/
... | diff --git a/src/test/java/org/mockito/MockitoTest.java b/src/test/java/org/mockito/MockitoTest.java
index 3b96aff3b0..c25be8d28f 100644
--- a/src/test/java/org/mockito/MockitoTest.java
+++ b/src/test/java/org/mockito/MockitoTest.java
@@ -12,6 +12,7 @@
import java.util.List;
import org.junit.Test;
import org.mockito... | val | train | 2017-03-26T19:46:52 | 2017-03-16T04:44:21Z | mockitoguy | train |
mockito/mockito/1059_1062 | mockito/mockito | mockito/mockito/1059 | mockito/mockito/1062 | [
"keyword_pr_to_issue"
] | 802a43e78a9e9aff45bdd7362d3fdc0c22616dd6 | e34fe9279057dbc11f05fa70a3422475e12c8914 | [
"Waiting for review / merge: https://github.com/mockito/mockito-release-tools/pull/103",
"Fix seems fine to me. Have not executed it locally though.",
"I don't know if this is related, but the release process currently [fails](https://travis-ci.org/mockito/mockito/jobs/230865593#L796) with:\r\n> remote: Invalid... | [] | 2017-05-01T01:17:25Z | [
"continuous integration"
] | Release automation endless loop issue | Recently I introduced a problem (PR: https://github.com/mockito/mockito/pull/1057) that created endless loop with our releases. Fallout / clean up needed:
- [x] - stop the endless loop by reverting the commit. Thank you @TimvdLippe spotting the issue and reverting the change!
- [x] - remove unnecessary tags
- [x]... | [
"gradle.properties"
] | [
"gradle.properties"
] | [] | diff --git a/gradle.properties b/gradle.properties
index efadf69c1a..6d27b51dde 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -2,4 +2,4 @@ org.gradle.daemon=true
org.gradle.parallel=true
#Declared the dependency here to avoid duplication across build.gradle files
-dependencies.mockito-release-tools=grad... | null | train | train | 2017-05-01T03:30:23 | 2017-04-30T17:50:35Z | mockitoguy | train |
mockito/mockito/1071_1076 | mockito/mockito | mockito/mockito/1071 | mockito/mockito/1076 | [
"keyword_pr_to_issue"
] | a8d1f37ec282294dd7ec18028f679b958c2f78ea | 761de40d05b4eddae8328ab1d7e5bdacd882a3be | [
"@troig Mockito checks if the argument type is compatible with the return type to make a misuse ot the API as soon as posible visible. In this case the argument-type Object is inferred from the generic type T, due to type erasure. Since Object is not a subtype of String Mockito throws the exception you see.\r\n\r\... | [] | 2017-05-10T11:47:32Z | [] | Mockito AdditionalAnswers.returnsFirstArg() doesn't work with generic first arg | _Issue concerning [this stackoverflow question](http://stackoverflow.com/questions/30670275/mockito-returnsfirstarg-doesnt-work-with-generic-first-arg).
I've checked it's not working both Mockito 1.x and 2.x._
-------------------
I'm trying to mock the typed method `getNameElement` of Interface `RoomGenera... | [
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java"
] | [
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java",
"src/test/java/org/mockitousage/IMethods.java",
"src/test/java/org/mockitousage/MethodsImpl.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java b/src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java
index 7c0a144b71..5419819647 100644
--- a/src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java
+++ b/src/main/java/org/mockito/intern... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java b/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java
index 8bb0451e0c..3a817cb5a1 100644
--- a/src/test/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAtTest.java
+++ b/src/test/java/org/mo... | val | train | 2017-05-06T14:48:08 | 2017-05-05T13:31:05Z | troig | train |
mockito/mockito/1088_1091 | mockito/mockito | mockito/mockito/1088 | mockito/mockito/1091 | [
"keyword_pr_to_issue"
] | db7dbc3d5f7d97d0625683b4e41f282818f9b87c | bbceeb3d8d57c30ff47231e26310802ab7fb4a2c | [
"What would you consider to be the correct behaviour here? At a push I might propose a slight change in naming to \"TooFewActualInvocations\" but the core behaviour is the same.\r\n\r\nYour example is confusing because your \"atLeast(2)\" verification is on .add(\"five times\"), which suggests five invocations of a... | [] | 2017-05-26T07:51:19Z | [
"docs",
"please contribute"
] | Javadoc Example Throws Unexpected Exception | Verify(mockedList, atLeast(2)).add("five times"); - would throw
org.mockito.exceptions.verification.TooLittleActualInvocations
Correcting this would help to make sure new devs are not confused by the verify use case there.
<img width="678" alt="screen shot 2017-05-17 at 8 40 03 pm" src="https://cloud.githubuser... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index cd4955a63d..8f389455cf 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -293,7 +293,7 @@
*
* //verification using atLeast()/atMost()
* verify(mockedList, atLeastOnc... | null | val | train | 2017-05-23T00:44:49 | 2017-05-18T00:46:16Z | Abasifreke | train |
mockito/mockito/1107_1109 | mockito/mockito | mockito/mockito/1107 | mockito/mockito/1109 | [
"keyword_pr_to_issue"
] | dc554a084c55d5f6249d2e8069626268771d818d | f4a00def6ebd825454939e47602776725d0faa6a | [
"No, I haven't seen anything like that before. There were no changes in .travis.yml and I have no idea what one of the jobs is missing. Probably (I hope) it will be automatically fixed by the next commit. It may be good to report it to Travis.",
"Just merged another PR, will see how many child jobs Travis trigger... | [] | 2017-06-05T04:58:17Z | [
"bug",
"continuous integration"
] | No release build for 2.8.39 - possible bug in Travis CI | For some reason, Travis CI did not trigger the main build for version 2.8.39. In the travis dashboard for that build I can see only [3 child jobs](https://travis-ci.org/mockito/mockito/builds/237813636) whereas normally there are [4 child jobs](https://travis-ci.org/mockito/mockito/builds/237433149).
@szpak, have yo... | [
".travis.yml"
] | [
".travis.yml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 7f4507d163..88d3f36acf 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -25,11 +25,9 @@ before_install:
- export TRAVIS_COMMIT_MESSAGE=$(git log --format=%B -n 1 $TRAVIS_COMMIT)
- echo "$TRAVIS_COMMIT_MESSAGE"
-jdk:
- - oraclejdk7
-
matrix:
include:
+ - jdk: oracl... | null | train | train | 2017-06-02T15:06:14 | 2017-06-01T17:03:21Z | mockitoguy | train |
mockito/mockito/1117_1122 | mockito/mockito | mockito/mockito/1117 | mockito/mockito/1122 | [
"timestamp(timedelta=1.0, similarity=0.8727445117873299)"
] | 3cf29be1d7cbf701ed4fac7ccb4ccf914cad7d8a | 04961ae3cc8093916f563d7edc223224d757a4a1 | [
"If the implementation is clean and generic, I would be in favor of it",
"@szpak For what version is that feature planned (Or has it been already released)?"
] | [] | 2017-06-12T22:22:38Z | [
"new feature",
"noteworthy"
] | Answer with delay in mock or spy to improve testing of asynchronous code | I'm currently using Mockito for component testing of microservices. All code should be run, up to the boundary at which another microservice is called. In the component test, the mocks return very quickly, but obviously in integration testing, the real calls return much more slowly. Some threading problems are revea... | [
"src/main/java/org/mockito/AdditionalAnswers.java"
] | [
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/internal/stubbing/answers/AnswersWithDelay.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/AnswersWithDelayTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingWithAdditionalAnswersTest.java"
] | diff --git a/src/main/java/org/mockito/AdditionalAnswers.java b/src/main/java/org/mockito/AdditionalAnswers.java
index 287e4b1830..214eaa5c47 100644
--- a/src/main/java/org/mockito/AdditionalAnswers.java
+++ b/src/main/java/org/mockito/AdditionalAnswers.java
@@ -5,6 +5,8 @@
package org.mockito;
import java.util.Col... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/AnswersWithDelayTest.java b/src/test/java/org/mockito/internal/stubbing/answers/AnswersWithDelayTest.java
new file mode 100644
index 0000000000..35c526555b
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/answers/AnswersWithDelayTest.java
@... | test | train | 2017-06-10T20:41:06 | 2017-06-08T15:22:57Z | myrle-krantz | train |
mockito/mockito/1127_1129 | mockito/mockito | mockito/mockito/1127 | mockito/mockito/1129 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8675876474461881)"
] | e8829b53996fb152c8a4271de768a783868a8ffe | c295a53539316b8549663caa86463a90fe984e27 | [
"I think we need to set a property on our project, looking at the line above in the Travis build you linked: \r\n```\r\nproject property 'maven-central-release' exists: false\r\n```",
"Looking! Thank you for reporting!",
"Great bug report guys! It was very easy to nail down the issue!",
"Please review / merge... | [
"👍 "
] | 2017-06-15T14:35:35Z | [
"question",
"continuous integration"
] | Version not released to Maven Central | 2 days ago I requested a [build](https://github.com/mockito/mockito/commit/04961ae3cc8093916f563d7edc223224d757a4a1) with Maven Central sync (having notable changes merged). Looking into release configuration I used `[ci maven-central-release]` and it seems to be [enabled](https://travis-ci.org/mockito/mockito/jobs/242... | [
"gradle/shipkit.gradle"
] | [
"gradle/shipkit.gradle"
] | [] | diff --git a/gradle/shipkit.gradle b/gradle/shipkit.gradle
index 24ac169368..2c9efd7e35 100644
--- a/gradle/shipkit.gradle
+++ b/gradle/shipkit.gradle
@@ -84,4 +84,5 @@ static boolean shouldReleaseToCentral(project) {
project.afterEvaluate {
project.tasks.performRelease.doLast { logger.lifecycle(message) ... | null | train | train | 2017-06-13T17:03:39 | 2017-06-14T09:56:30Z | szpak | train |
mockito/mockito/1144_1145 | mockito/mockito | mockito/mockito/1144 | mockito/mockito/1145 | [
"timestamp(timedelta=131388.0, similarity=0.8609656881228989)",
"keyword_pr_to_issue"
] | 48856d8fc844d70b21c804d55f5be624d3687ac3 | 6d6361fc72c16c947ef5f2f587fd9269a9d47f23 | [
"This should be fixed now."
] | [] | 2017-07-06T18:21:49Z | [
"bug",
"continuous integration"
] | Unnecessary release was triggered | It seems that Shipkit was not able to avoid unnecessary release (see the [release notes](https://github.com/mockito/mockito/blob/release/2.x/doc/release-notes/official.md)). I will look into that. Our goal is not avoid shipping new version if binaries don't change. | [
"gradle.properties"
] | [
"gradle.properties"
] | [] | diff --git a/gradle.properties b/gradle.properties
index d7832b247d..946ba4c5d3 100644
--- a/gradle.properties
+++ b/gradle.properties
@@ -2,4 +2,4 @@ org.gradle.daemon=true
org.gradle.parallel=true
#Declared the dependency here to avoid duplication across build.gradle files
-dependencies.shipkit=org.shipkit:shipki... | null | train | train | 2017-07-06T19:43:14 | 2017-07-06T17:56:32Z | mockitoguy | train |
mockito/mockito/1155_1162 | mockito/mockito | mockito/mockito/1155 | mockito/mockito/1162 | [
"keyword_pr_to_issue"
] | 9e4de546d7ea2ec675e15d8b6960a3b8ffe324f7 | f1ceb5097298872aef63725e758a80293417c5c1 | [
"I am going to fix this. \r\n\r\nThrowsExceptionClass must simply implement ValidableAnswer...\r\n\r\n\r\n\r\n",
"Thank you for reporting. Indeed it is a bug."
] | [
"Missing the ewuals here",
"Missing equals here",
"Missing equals here",
"Can you give me some more infos? We expect the instance to be thrown that was passed to the stubbing, right?",
"Lets better use: `exception.expect(sameInstance(expected));`",
"Sorry, this one is correct. I misread"
] | 2017-08-12T11:57:33Z | [] | thenThrow(Class) should only throw checked exceptions that match the signature of the stubbed method | Hi,
- mockito-core 2.8.47
```java
public class FooTest {
@Test(expected = MockitoException.class)
public void using_thenThrow_Throwable() {
C mock = mock(C.class);
// Set a checked exception that does not matche the method signature
when(mock.doIt()).thenThrow(new Exception... | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/OngoingStubbingImpl.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsExceptionClass.java"
] | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/OngoingStubbingImpl.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java"
] | [
"src/test/java/org/mockitousage/stubbing/StubbingWithThrowablesTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
index c55c82b99a..ddb9a8dcb9 100644
--- a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
+++ b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
@@ -4,26 ... | diff --git a/src/test/java/org/mockitousage/stubbing/StubbingWithThrowablesTest.java b/src/test/java/org/mockitousage/stubbing/StubbingWithThrowablesTest.java
index 0ccf14f268..1931bd1de2 100644
--- a/src/test/java/org/mockitousage/stubbing/StubbingWithThrowablesTest.java
+++ b/src/test/java/org/mockitousage/stubbing/S... | test | train | 2017-09-08T18:08:12 | 2017-08-03T13:49:41Z | tmurakami | train |
mockito/mockito/1182_1184 | mockito/mockito | mockito/mockito/1182 | mockito/mockito/1184 | [
"keyword_pr_to_issue"
] | 1c61f1a91a7d5d8367b3dbddb6270afdd96c8f6a | 500b5770523c93fcc7860821a798f08361779b9c | [
"This was fixed in #1184"
] | [] | 2017-09-04T21:39:42Z | [
"continuous integration"
] | Travis CI ERROR: JAVA_HOME is set to an invalid directory | Travis CI builds started failing with "ERROR: JAVA_HOME is set to an invalid directory: /usr/lib/jvm/java-7-oracle". [Example failure](https://travis-ci.org/mockito/mockito/jobs/270842998).
```
$ ./gradlew build idea -s -PcheckJava6Compatibility && ./gradlew ciPerformRelease
ERROR: JAVA_HOME is set to an invalid d... | [
".travis.yml"
] | [
".travis.yml"
] | [] | diff --git a/.travis.yml b/.travis.yml
index e626d42d1a..096880fcb6 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -15,11 +15,7 @@ language: java
matrix:
include:
- - jdk: oraclejdk7
- - jdk: oraclejdk7
- env: SKIP_RELEASE=true MOCK_MAKER=mock-maker-inline
- jdk: oraclejdk8
- env: SKIP_RELEASE=true
-... | null | train | train | 2017-09-04T23:38:20 | 2017-09-01T16:00:09Z | mockitoguy | train |
mockito/mockito/1189_1195 | mockito/mockito | mockito/mockito/1189 | mockito/mockito/1195 | [
"timestamp(timedelta=2.0, similarity=0.8418935844654968)"
] | bf98a225a43e0a910ce84faed907fb08ef8b7799 | 5a5c409f561c853c04974c1542fe2f65c999c263 | [
"If we can make this work on JDK6-8, I am all for it. If you can, please submit a PR that we can review :)",
"This change is compatible with JDK6-8, because you only add an entry to `MANIFEST.mf` file. Older Java versions simply ignore it, and JDK9 uses it as a stable automatic module name (instead of generating ... | [] | 2017-10-04T16:23:03Z | [
"java-9",
"please contribute"
] | JDK9: set a stable module name with `Automatic-Module-Name` entry in MANIFEST | JDK9 is out and introduces a module system.
Mockito does not currently use modules. When we use it in a JDK9 modular application, Java turns the JAR into a so-called automatic module, whose name is derived from the JAR archive name (*mockito*, in this case). However, the default name does not follow the recommended ... | [
"gradle/mockito-core/osgi.gradle"
] | [
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/gradle/mockito-core/osgi.gradle b/gradle/mockito-core/osgi.gradle
index 2b0eb65fee..90a32eb6f8 100644
--- a/gradle/mockito-core/osgi.gradle
+++ b/gradle/mockito-core/osgi.gradle
@@ -27,6 +27,8 @@ afterEvaluate {
'org.mockito.*'
instruction '-removeheaders', 'Private-Pack... | null | train | train | 2017-10-04T14:02:50 | 2017-09-24T15:16:58Z | zyxist | train |
mockito/mockito/1212_1226 | mockito/mockito | mockito/mockito/1212 | mockito/mockito/1226 | [
"timestamp(timedelta=165622.0, similarity=0.8636678635689894)"
] | e10c5409e460c3ecd6b2ef9513a0b3802351d85f | fb3f09de77e6992973499a2d779113c44e8fe3e8 | [
"What's more even using the old Silent `@RunWith(org.mockito.runners.MockitoJUnitRunner.Silent.class)` still causes `UnnecessaryStubbingException`. The new one (`@RunWith(org.mockito.junit.MockitoJUnitRunner.Silent.class)`) has to be used to keep test passing.",
"https://github.com/mockito/mockito/blob/e10c5409e4... | [
"Curious why changing the public modifier?\r\n\r\nI suspect that this change may not be binary compatible in case somebody extends the runner.",
"The code works as designed (https://github.com/mockito/mockito/issues/1212#issuecomment-340266646).\r\n\r\nIf you want to keep the PR I suggest that we add a unit test ... | 2017-10-27T13:12:40Z | [
"question",
"wontfix",
"strictness"
] | MockitoJUnitRunner too strict by default? | In one of the projects being migrated to Mockito 2 I've observed that deprecated `org.mockito.runners.MockitoJUnitRunner` (tested with 2.11.0) works in a strict mode by default (fails a test on unnecessary stubbing). I wonder if it is an expected behavior?
Even Mockito rule works in a "warn" mode by default. It make... | [
"src/main/java/org/mockito/junit/MockitoJUnitRunner.java",
"src/main/java/org/mockito/runners/MockitoJUnitRunner.java"
] | [
"src/main/java/org/mockito/junit/MockitoJUnitRunner.java",
"src/main/java/org/mockito/runners/MockitoJUnitRunner.java"
] | [] | diff --git a/src/main/java/org/mockito/junit/MockitoJUnitRunner.java b/src/main/java/org/mockito/junit/MockitoJUnitRunner.java
index 2a1558719b..fbdbfcf5eb 100644
--- a/src/main/java/org/mockito/junit/MockitoJUnitRunner.java
+++ b/src/main/java/org/mockito/junit/MockitoJUnitRunner.java
@@ -152,7 +152,7 @@ public Mockit... | null | train | train | 2017-10-22T16:21:02 | 2017-10-19T13:23:38Z | szpak | train |
mockito/mockito/1130_1228 | mockito/mockito | mockito/mockito/1130 | mockito/mockito/1228 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8800423002840884)"
] | e10c5409e460c3ecd6b2ef9513a0b3802351d85f | 08c13b2a00a2d8c00d9bb62d40cc4e454aa3d7cb | [
"That seems fine to me. Please submit a pull request :smile: "
] | [
"Shouldn't it be RetentionPolicy.RUNTIME? Annotations with RetentionPolicy.CLASS are not preserved for the vm runtime execution, which is what I assume Findbugs needs.",
"Since this annotation is on our core public API methods, can you add a paragraph describing what this annotation means for the end users, writt... | 2017-10-27T13:38:24Z | [] | Mockito should annotate when() methods with a custom annotation @CheckReturnValue | Static code checkers like error-Prone and FindBugs will help detecting invalid usage of Mockito in single-call situations if Mockito source code were annotated with @CheckReturnValue.
See:
* https://github.com/joel-costigliola/assertj-core/issues/157
* http://errorprone.info/bugpattern/CheckReturnValue
* https://... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/CheckReturnValue.java",
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/CheckReturnValue.java b/src/main/java/org/mockito/CheckReturnValue.java
new file mode 100644
index 0000000000..42c7545bff
--- /dev/null
+++ b/src/main/java/org/mockito/CheckReturnValue.java
@@ -0,0 +1,28 @@
+package org.mockito;
+
+import java.lang.annotation.ElementType;
+import ... | null | train | train | 2017-10-22T16:21:02 | 2017-06-16T09:01:04Z | tkruse | train |
mockito/mockito/1070_1229 | mockito/mockito | mockito/mockito/1070 | mockito/mockito/1229 | [
"timestamp(timedelta=0.0, similarity=0.9091651390028943)",
"keyword_pr_to_issue"
] | e10c5409e460c3ecd6b2ef9513a0b3802351d85f | b8c2811276a3cf8f1eb8b81c5f785369046c3d77 | [] | [
"Maybe it would be better to iterate over subprojects and depend on \"test\" task (by a type or by a name) and use that list to generate also files to include (istead of looking for `*.exec` file)?\r\n\r\nIt would be even less fragile to have an optional exclusions for specific modules if needed.",
"Do we really ... | 2017-10-27T14:14:32Z | [
"enhancement",
"kotlin",
"please contribute"
] | Fix coverage for subprojects | In #1032, the new coverage was incorrectly tracked by jacoco. A quick search showed this TODO (https://github.com/mockito/mockito/blob/release/2.x/gradle/root/coverage.gradle#L3) that points out it is actually not generating coverage for subprojects. Would like to see this fixed! | [
"gradle/root/coverage.gradle",
"subprojects/extTest/extTest.gradle",
"subprojects/kotlinTest/kotlinTest.gradle"
] | [
"gradle/root/coverage.gradle",
"subprojects/extTest/extTest.gradle",
"subprojects/kotlinTest/kotlinTest.gradle"
] | [] | diff --git a/gradle/root/coverage.gradle b/gradle/root/coverage.gradle
index 9196ad2cd4..a0f0448562 100644
--- a/gradle/root/coverage.gradle
+++ b/gradle/root/coverage.gradle
@@ -1,15 +1,27 @@
-apply plugin: 'jacoco'
+//TODO: Standard JaCoCo coverage doesn't work in Android module
+task mockitoCoverage(type: JacocoRepo... | null | test | train | 2017-10-22T16:21:02 | 2017-05-05T12:38:36Z | TimvdLippe | train |
mockito/mockito/1239_1242 | mockito/mockito | mockito/mockito/1239 | mockito/mockito/1242 | [
"timestamp(timedelta=0.0, similarity=0.969590801230008)",
"keyword_pr_to_issue"
] | b8c2811276a3cf8f1eb8b81c5f785369046c3d77 | ae314e5b41f947dc83d5b1e5ee268d289b61e837 | [
"Think it makes sense to add a check since we have it. Without it, the project will just always be inconsistent.",
"Absolutely +1. Thank you!"
] | [
"Coudn't we apply it automatically to all projects that apply Java plugin? Similar way it is done with JaCoCo - to do not miss another module once added.",
"Uh, yeah maybe. Not a Gradle expert, but I can give it a shot tomorrow!",
"Done. Please take a look :+1: ",
"Do we use that plugin to handle any other ty... | 2017-11-03T12:23:46Z | [] | Enable Checkstyle rule for checking existence of license headers | Whenever we add new files to the repository, we usually forget to add our license headers. This results in PRs such as #1227 where retroactively we add the license headers.
CheckStyle has a rule called [`Header`](http://checkstyle.sourceforge.net/config_header.html) which can enforce that we add our license header. ... | [
"build.gradle",
"config/checkstyle/checkstyle.xml",
"doc/licenses/HEADER.txt",
"gradle/mockito-core/license.gradle",
"src/main/java/org/mockito/CheckReturnValue.java",
"subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidByteBuddyMockMaker.java",
"subprojects/android/src/main/... | [
"build.gradle",
"config/checkstyle/checkstyle.xml",
"config/checkstyle/java.header",
"doc/licenses/HEADER.txt",
"gradle/license.gradle",
"src/main/java/org/mockito/CheckReturnValue.java",
"subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidByteBuddyMockMaker.java",
"subproj... | [
"src/test/java/org/mockitousage/bugs/GenericsMockitoAnnotationsTest.java",
"src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java",
"subprojects/extTest/src/test/java/org/mockitousage/plugins/stacktrace/MyStackTraceCleanerProvider.java",
"subprojects/extTest/src/test/java/org/mockitousag... | diff --git a/build.gradle b/build.gradle
index 34b7d0fc3c..575662ecff 100644
--- a/build.gradle
+++ b/build.gradle
@@ -32,12 +32,12 @@ apply from: 'gradle/root/ide.gradle'
apply from: 'gradle/root/gradle-fix.gradle'
apply from: 'gradle/root/java6-compatibility.gradle'
apply from: 'gradle/java-library.gradle'
+apply ... | diff --git a/src/test/java/org/mockitousage/bugs/GenericsMockitoAnnotationsTest.java b/src/test/java/org/mockitousage/bugs/GenericsMockitoAnnotationsTest.java
index f6ee1d8575..51f23693bc 100644
--- a/src/test/java/org/mockitousage/bugs/GenericsMockitoAnnotationsTest.java
+++ b/src/test/java/org/mockitousage/bugs/Gener... | train | train | 2017-11-02T11:57:10 | 2017-11-02T15:10:19Z | TimvdLippe | train |
mockito/mockito/1254_1257 | mockito/mockito | mockito/mockito/1254 | mockito/mockito/1257 | [
"keyword_pr_to_issue"
] | 442277f4647ebf24930132b080b9971d3eef9e63 | dad7ca814ea76937b1c9af35f02ad97ba5f9b3c5 | [
"I'm observing a similar issue. Only happens with `mockito-inline`. Don't have time right now to distill the affected tests into a minimal reproduction case. Maybe @raphw has a hunch.",
"Alright, decided to look for a minimal reproduction case after all. This is what I came up with:\r\n```java\r\npackage com.exam... | [
"With the issue fixed, this comment is no longer true. Would leave it out to avoid head-scratching.",
"Indeed, poorly copy-pasted. Thanks.",
"Can you add a code comment explaining why we need this? Please make it thorough, it would be great to share understanding! :)",
"Can we make the message more actionable... | 2017-11-13T21:30:41Z | [
"bug"
] | Wanted but not invoked on 2.12.0, but not on 2.11.0 | After updating Mockito from 2.11.0 to 2.12.0 the following test fails with `Wanted but not invoked`.
The weird thing is this happens only when running tests using Gradle. Android Studio runs the same test as successful. Just like #1183.
```java
package package.redacted;
import org.junit.Test;
import org.mock... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java",
"src/main/java/org/mockito/internal/util/concurrent/WeakConcurrentMap.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java",
"src/main/java/org/mockito/internal/util/concurrent/WeakConcurrentMap.java"
] | [
"subprojects/inline/src/test/java/org/mockitoinline/RecursionTest.java",
"subprojects/inline/src/test/java/org/mockitoinline/SuperCallTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java b/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
index 7d9f347f6c..02882a2274 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
+++ b/src/main/java/org/mockito/int... | diff --git a/subprojects/inline/src/test/java/org/mockitoinline/RecursionTest.java b/subprojects/inline/src/test/java/org/mockitoinline/RecursionTest.java
new file mode 100644
index 0000000000..2a4494e03e
--- /dev/null
+++ b/subprojects/inline/src/test/java/org/mockitoinline/RecursionTest.java
@@ -0,0 +1,21 @@
+/*
+ * ... | test | train | 2017-11-21T15:33:59 | 2017-11-10T10:07:26Z | arturdryomov | train |
mockito/mockito/1067_1258 | mockito/mockito | mockito/mockito/1067 | mockito/mockito/1258 | [
"keyword_pr_to_issue"
] | 907e3de8a47c3733220c1ebf58741945c21df899 | cd5265ac9c1bc0e7b30f5f8e28c6d342f7451ab8 | [
"It seems to me as if you are defining circular class loading hierarchies. With Mockito 2, we are applying more fine grained locking to improve concurrency. The difference is displayed in the stack trace where `findOrInsert` aquires a lock for the class loader of the mock class before creating a mock. The previous ... | [
"@raphw, can we lock always using BOOTSTRAP_LOCK?\r\n\r\nIn JVM that runs tests, we have one instance of BOOTSTRAP_LOCK and (typically) one instance of the classloader. If using classloader is a performance tweak, do we have an evidence how much value it adds? Also, the lock is only used for \"new\" classes (not ye... | 2017-11-13T21:31:29Z | [] | Deadlock after upgrading to Mockito 2 and parallel tests execution | I updated Mockito and ScalaTest today from ScalaTest 2.x and Mockito 1.x and my tests suddenly froze in SBT (not in IntelliJ). After some playing around, I noticed every test class by itself passes and when I disabled running tests in parallel in SBT, the tests would work again.
I used jstack and came across this de... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java
index 34c31feef2..ea51edf780 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java... | null | train | train | 2017-11-07T12:04:36 | 2017-05-03T22:52:41Z | mmlac | train |
mockito/mockito/1086_1280 | mockito/mockito | mockito/mockito/1086 | mockito/mockito/1280 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9041043942633712)"
] | 2316a320012c09c6b815bfdf00b008732a3ffe75 | 5caabead07bc8f796a243d81d1988925179449cf | [
"Yes, it is by design.\r\n\r\n\"Strict stubs\" are not \"strict mocks\", e.g. we detect unused or incorrectly declared stubs but we don't force the user to verify all interactions.\r\n\r\nIf above is not clear in the documentation, can you suggest and update to the Javadoc that would make this clear? Perhaps on Str... | [] | 2017-12-27T09:52:28Z | [
"docs",
"please contribute"
] | Documentation update - MockitoJUnit.strictness(STRICT_STUBS) does not do verifyNoMoreInteractions | ### Problem
Our documentation about "strict stubs" does not clearly indicate the difference between "strict mocks" (described at #1097). In short, "strict stubs" are not "strict mocks", e.g. we detect unused or incorrectly declared stubs but we don't force the user to verify all interactions.
### Suggested implem... | [
"src/main/java/org/mockito/quality/Strictness.java"
] | [
"src/main/java/org/mockito/quality/Strictness.java"
] | [] | diff --git a/src/main/java/org/mockito/quality/Strictness.java b/src/main/java/org/mockito/quality/Strictness.java
index 4e1126ae85..c9da8d367c 100644
--- a/src/main/java/org/mockito/quality/Strictness.java
+++ b/src/main/java/org/mockito/quality/Strictness.java
@@ -80,7 +80,8 @@ public enum Strictness {
* <... | null | train | train | 2017-12-11T03:35:26 | 2017-05-16T08:34:02Z | vanniktech | train |
mockito/mockito/1306_1307 | mockito/mockito | mockito/mockito/1306 | mockito/mockito/1307 | [
"keyword_pr_to_issue"
] | 1a3bc2e7cfdaf126f67645b8a954cf315172e580 | de894403247eae574d90bac5011647c97666a7fc | [] | [
"Nit: no need to add `final` here",
"done"
] | 2018-02-06T22:58:21Z | [] | InvocationFactory.createInvocation's realmethod cannot throw a Throwable | InvocationFactory.createInvocation takes a Callable that is used to call the real method of the Invocation. If the Invocation throws an Exception the Exception is forwarded from the Callable. Unfortunately Callable can only throw an Exception, not a Throwable.
Hence if the real method throws a Throwable that is neit... | [
"src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java",
"src/main/java/org/mockito/internal/invocation/RealMethod.java",
"src/main/java/org/mockito/invocation/InvocationFactory.java",
"version.properties"
] | [
"src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java",
"src/main/java/org/mockito/internal/invocation/RealMethod.java",
"src/main/java/org/mockito/invocation/InvocationFactory.java",
"version.properties"
] | [
"src/test/java/org/mockito/InvocationFactoryTest.java",
"src/test/java/org/mockito/StaticMockingExperimentTest.java"
] | diff --git a/src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java b/src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java
index af8fd3d5fb..03ee54bea1 100644
--- a/src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java
+++ b/src/main/java/org/mockito/int... | diff --git a/src/test/java/org/mockito/InvocationFactoryTest.java b/src/test/java/org/mockito/InvocationFactoryTest.java
new file mode 100644
index 0000000000..893f95f465
--- /dev/null
+++ b/src/test/java/org/mockito/InvocationFactoryTest.java
@@ -0,0 +1,81 @@
+/*
+ * Copyright (c) 2018 Mockito contributors
+ * This pr... | train | train | 2018-01-27T23:43:44 | 2018-02-06T21:31:53Z | moltmann | train |
mockito/mockito/1314_1319 | mockito/mockito | mockito/mockito/1314 | mockito/mockito/1319 | [
"keyword_pr_to_issue"
] | cbc7a99db706621bdb6728cb64d2b0d9be6a8034 | 92a3e07e2b31c2b13e3cd072c15ee9feb28f505d | [
"Good idea. Do you want to submit a PR?",
"@mockitoguy I can work on it.\r\nAlso, to make it consistent I would suggest to extend the message to include all the invocations for other cases. As example for `TooLittleActualInvocations`.",
"Submitted PR #1319 "
] | [
"Not sure if it follows the convention since the `*` was used before and `java.*` imports were listed below.",
"`invocations` → `locations`?",
"Indentation might have changed.",
"`infocation` → `location`?",
"`allLocations` → `locations`? At this point it not entirely consistent with other calls if I unders... | 2018-02-21T13:34:58Z | [
"please contribute"
] | Undesired invocation message improvements | Let’s take a look at the following code.
```kotlin
package whatever
import org.junit.Test
import org.mockito.Mockito
class MultipleUndesiredInvocations {
interface Inner {
fun call()
}
interface SideEffect {
fun call()
class Impl(private val inner: Inner) : Sid... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/invocation/InvocationsFinder.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocatio... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/invocation/InvocationsFinder.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocatio... | [
"src/test/java/org/mockito/internal/invocation/InvocationsFinderTest.java",
"src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsCheckerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsInOrderCheckerTest.java",
"src/test/java/org/mockitousage/ver... | diff --git a/src/main/java/org/mockito/internal/exceptions/Reporter.java b/src/main/java/org/mockito/internal/exceptions/Reporter.java
index 57094c0fa0..17823ffe5e 100644
--- a/src/main/java/org/mockito/internal/exceptions/Reporter.java
+++ b/src/main/java/org/mockito/internal/exceptions/Reporter.java
@@ -5,9 +5,27 @@
... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationsFinderTest.java b/src/test/java/org/mockito/internal/invocation/InvocationsFinderTest.java
index b07ece43cd..7172998c7e 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationsFinderTest.java
+++ b/src/test/java/org/mockito/internal/inv... | train | train | 2018-03-25T10:57:40 | 2018-02-16T07:53:37Z | arturdryomov | train |
mockito/mockito/1313_1321 | mockito/mockito | mockito/mockito/1313 | mockito/mockito/1321 | [
"keyword_pr_to_issue"
] | 6a56f6e0995732a14772630701d979c5759bdbe6 | 018a2e0c2746072fbb19de58d77cc87b1e12d00c | [
"Fantastic analysis, thank you! Do you want to take a stab at fixing it?\r\n\r\n(ping @raphw, original author of the this mock maker).",
"I will have a look. Great analysis indeed. We will have to weakly reference any mock instance stored in Mockito. This is a straight forwars fi, I hope.",
"I will do it once I... | [] | 2018-02-21T17:35:28Z | [] | InlineByteBuddyMockMaker does not clean up stale mocks | **Repro:**
1. Mockito 2.15.2 using mockito-inline
2. With -Xmx64m run
```
@RunWith(JUnit4.class)
public class Stress {
private static final int NUM_RUNS = 20000;
public static class TestClass {
public String returnA() {
return "A";
}
}
/**
* Test that ... | [
"gradle/java-library.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java",
"src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java",
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"subprojects/inline/inline.gradle",
"versi... | [
"gradle/java-library.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java",
"src/main/java/org/mockito/internal/invocation/DefaultInvocationFactory.java",
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"src/main/java/org/mockito/internal/invocati... | [
"src/test/java/org/mockito/internal/invocation/InvocationBuilder.java",
"src/test/java/org/mockito/internal/invocation/mockref/MockWeakReferenceTest.java",
"src/test/java/org/mockitoutil/TestBase.java",
"subprojects/inline/src/test/java/org/mockitoinline/StressTest.java"
] | diff --git a/gradle/java-library.gradle b/gradle/java-library.gradle
index d41e3406b8..45c72f11d2 100644
--- a/gradle/java-library.gradle
+++ b/gradle/java-library.gradle
@@ -9,6 +9,7 @@ targetCompatibility = 1.6
test {
include "**/*Test.class"
+
testLogging {
exceptionFormat 'full'
showC... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java b/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
index c8943b180e..b3106a6993 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
+++ b/src/test/java/org/mockito/internal/invocation/Invo... | train | train | 2018-03-05T16:48:40 | 2018-02-15T23:19:06Z | moltmann | train |
mockito/mockito/1323_1324 | mockito/mockito | mockito/mockito/1323 | mockito/mockito/1324 | [
"timestamp(timedelta=5.0, similarity=0.8825254719575555)"
] | d4a508e65dcfaeb8033c48ec4321f59a4ed2cb99 | c8893962d79a5790c81a02f65579b3a8ba9e3d23 | [] | [
"This is the current behavior, correct? E.g. your PR did not change it?",
"This comment explains what the code does but does not explain why (which is the point of code comments). Unfortunately, I don't know either :) I think it was a judgement call years ago and we will stick to it to keep compatibility. Thank y... | 2018-02-23T19:00:21Z | [] | Improve BaseStubbing & ThrowsException internals | I'd discovered some exception-stubbing related code that may express its intent more clearly during #1322 investigation.
Please see the PR for more details: #1324 | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java"
] | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java",
"src/test/java/org/mockitousage/bugs/FillInStackTraceScenariosTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingConsecutiveAnswersTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingWithThrowablesTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
index ddb9a8dcb9..6dd99cd802 100644
--- a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
+++ b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
@@ -24,7 ... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java b/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java
index 8b553aae98..2e71102aaf 100644
--- a/src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java
+++ b/src/test/java/org/mockito/... | train | train | 2018-03-13T05:04:39 | 2018-02-23T18:55:25Z | dmitry-timofeev | train |
mockito/mockito/1326_1327 | mockito/mockito | mockito/mockito/1326 | mockito/mockito/1327 | [
"keyword_pr_to_issue",
"timestamp(timedelta=6.0, similarity=0.8442294612501725)"
] | 723300cc655e14c719233901d8adfdbfbf91ab52 | 1ecfc7ab5ab447b4eb0a3fef9aff84b338f406f6 | [] | [] | 2018-03-01T17:51:44Z | [] | Reduce memory consumption of the typical LocationImpl | I recently noticed very heavy memory usage on our testsuite (which is using mockito) so I started profiling.
I eventually found #1313 but that's already being worked on. Also spotted a low hanging fruit: our testsuite is allocating about 6 *million* instances of `LocationImpl`.
It looks like I can't avoid that easi... | [
"src/main/java/org/mockito/internal/debugging/LocationImpl.java"
] | [
"src/main/java/org/mockito/internal/debugging/LocationImpl.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/debugging/LocationImpl.java b/src/main/java/org/mockito/internal/debugging/LocationImpl.java
index ce3de04a0a..8561b62d3e 100644
--- a/src/main/java/org/mockito/internal/debugging/LocationImpl.java
+++ b/src/main/java/org/mockito/internal/debugging/LocationImpl.java
@@ -1... | null | train | train | 2018-02-19T06:48:55 | 2018-03-01T17:49:29Z | Sanne | train |
mockito/mockito/1346_1349 | mockito/mockito | mockito/mockito/1346 | mockito/mockito/1349 | [
"timestamp(timedelta=0.0, similarity=0.9362691284832727)",
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 34877f1d9641e44b566dd95af1869aa9a9537cc0 | d10a54335d0cc6c0e65d747c01b1cef281ef6ae8 | [
"Hm that seems really weird. Could you please post the implementation of `TacticalStation` and `SpaceShip` (although I am assuming they are simple POJO's?)",
"(Oh never mind, I missed the small link at the end of the example to https://github.com/szpak/code-examples-and-poc/tree/mockito2junit5-bug/mockito2-junit5... | [
"Lets use `isSame` here, as we literally want this object to be there.",
"Good catch, have changed it. Thanks!",
"I have amended the previous commit as it's a simple and small change"
] | 2018-03-26T09:44:50Z | [
"bug",
"injection",
"junit5"
] | Different mocks are used for @Mock and @InjectMock in the same test class with JUnit 5 extension | I've been playing with the new JUnit 5 support in Mockito 2.17.0. I have found that with `@Mock` and `@InjectMocks` used in the same test class different mocks are injected. I would expect to have the same mock reused (as it works with JUnit 4 or manual `@Mock` initialization).
Sample code:
```
@ExtendWith(Mockito... | [
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java"
] | diff --git a/subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java b/subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java
index e8e576bd3d..349217474a 100644
--- a/subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
index 3ce8c9c8f7..47361589a5 100644
--- a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
+++ b/subprojects/junit-ju... | train | train | 2018-03-25T15:09:22 | 2018-03-25T12:31:24Z | szpak | train |
mockito/mockito/1348_1350 | mockito/mockito | mockito/mockito/1348 | mockito/mockito/1350 | [
"timestamp(timedelta=0.0, similarity=0.8727645311881962)",
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | c5ebb9c7339aa04a7c2f9e5f9dd6de37d5c8e681 | 6e94d29d1e049cf773ad2423ca55485ed71be558 | [
"I am 👍 for this feature with the following use case:\r\n\r\nInitialization of local variable mocks. Previously this would be `Mock<Generic> mock = mock(Mock.class)`. However, this loses the type-signature of `Generic`. With parameter mocks, we can do `@Mock Mock<Generic> mock` and still maintain the generic type ... | [] | 2018-03-26T13:38:17Z | [
"junit5"
] | Support @Mock injection in JUnit 5 method parameters | JUnit 5 has the ability to "inject" parameters into test methods via an extensible ``ParameterResolver`` interface. The JUnit 5 users guide provides an example that shows how such a ``ParameterResolver`` can supply mock objects as test parameters as follows (shamelessly copied from https://junit.org/junit5/docs/curren... | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java"
] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 7a3cdfa2a7..784db4b47d 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -5,7 +5,7 @@ ext {
def versions = [:]
versions.bytebuddy = '1.8.15'
-versions.junitJupiter = '5.1.0'
+versions.junitJupiter = '5.1.1'
libra... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
index 47361589a5..df9fce5e88 100644
--- a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
+++ b/subprojects/junit-ju... | test | train | 2018-07-27T06:35:15 | 2018-03-25T21:08:04Z | smoyer64 | train |
mockito/mockito/1346_1350 | mockito/mockito | mockito/mockito/1346 | mockito/mockito/1350 | [
"keyword_issue_to_pr"
] | c5ebb9c7339aa04a7c2f9e5f9dd6de37d5c8e681 | 6e94d29d1e049cf773ad2423ca55485ed71be558 | [
"Hm that seems really weird. Could you please post the implementation of `TacticalStation` and `SpaceShip` (although I am assuming they are simple POJO's?)",
"(Oh never mind, I missed the small link at the end of the example to https://github.com/szpak/code-examples-and-poc/tree/mockito2junit5-bug/mockito2-junit5... | [] | 2018-03-26T13:38:17Z | [
"bug",
"injection",
"junit5"
] | Different mocks are used for @Mock and @InjectMock in the same test class with JUnit 5 extension | I've been playing with the new JUnit 5 support in Mockito 2.17.0. I have found that with `@Mock` and `@InjectMocks` used in the same test class different mocks are injected. I would expect to have the same mock reused (as it works with JUnit 4 or manual `@Mock` initialization).
Sample code:
```
@ExtendWith(Mockito... | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java"
] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 7a3cdfa2a7..784db4b47d 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -5,7 +5,7 @@ ext {
def versions = [:]
versions.bytebuddy = '1.8.15'
-versions.junitJupiter = '5.1.0'
+versions.junitJupiter = '5.1.1'
libra... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
index 47361589a5..df9fce5e88 100644
--- a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
+++ b/subprojects/junit-ju... | val | train | 2018-07-27T06:35:15 | 2018-03-25T12:31:24Z | szpak | train |
mockito/mockito/1386_1387 | mockito/mockito | mockito/mockito/1386 | mockito/mockito/1387 | [
"timestamp(timedelta=2.0, similarity=0.8688001584516274)"
] | f5c988689df5313d3af311e78169c73e31f569da | 61655a491643f042a85203c1ea9433f717799d93 | [] | [] | 2018-05-13T21:56:54Z | [] | Add AtMostOnce(),rename one testClass and one TODO. | Hi,
I would like to make a quick contribution on this project.
I add atMostOnce(), it seem's not to be a big feature. I just want to highlight the fact you have the function atLeastOnce() but nothing for the atMostOnce case.
I rename the testClass ThreadVerifiesContinuoslyInteractingMockTest on ThreadVerifies... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/verification/VerificationModeFactory.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapper.java",
"src/main/java/org/mockito/verific... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/verification/VerificationModeFactory.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapper.java",
"src/main/java/org/mockito/verific... | [
"src/test/java/org/concurrentmockito/ThreadVerifiesContinuouslyInteractingMockTest.java",
"src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java",
"src/test/java/org/mockitousage/verification/AtMostXVerificationTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 5066eec3d7..ec710a66a5 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -320,6 +320,7 @@
* verify(mockedList, never()).add("never happened");
*
* //verification usi... | diff --git a/src/test/java/org/concurrentmockito/ThreadVerifiesContinuoslyInteractingMockTest.java b/src/test/java/org/concurrentmockito/ThreadVerifiesContinuouslyInteractingMockTest.java
similarity index 94%
rename from src/test/java/org/concurrentmockito/ThreadVerifiesContinuoslyInteractingMockTest.java
rename to src... | train | train | 2019-05-03T13:37:18 | 2018-05-13T21:23:03Z | Ingvir | train |
mockito/mockito/1390_1391 | mockito/mockito | mockito/mockito/1390 | mockito/mockito/1391 | [
"keyword_pr_to_issue"
] | 758ca3782fba18b8eaf1faed5d68084145f8802d | 3f96f3b5adc7618ab0dc95d712a7b19b6b6e85ac | [] | [] | 2018-05-17T09:26:34Z | [
"junit5"
] | MockitoExtension cannot be registered as a global junit5 extension. | `MockitoExtension` doesn't expose its constructor so it can't be loaded by `ServiceLoader.`
When trying to register `MockitoExtension` for automatic use using a file named `META-INF\services\org.junit.jupiter.api.extension.Extension` and content `org.mockito.junit.jupiter.MockitoExtension`
the below error is thro... | [
"settings.gradle",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"settings.gradle",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java",
"subprojects/junitJupiterExtensionTest/junitJupiterExtensionTest.gradle"
] | [
"subprojects/junitJupiterExtensionTest/src/test/java/org/mockitousage/NoExtendsTest.java",
"subprojects/junitJupiterExtensionTest/src/test/resources/META-INF/services/org.junit.jupiter.api.extension.Extension",
"subprojects/junitJupiterExtensionTest/src/test/resources/junit-platform.properties"
] | diff --git a/settings.gradle b/settings.gradle
index 67fdf19066..74b7a84452 100644
--- a/settings.gradle
+++ b/settings.gradle
@@ -5,6 +5,7 @@ include 'extTest'
include 'kotlinTest'
include 'android'
include 'junit-jupiter'
+include 'junitJupiterExtensionTest'
rootProject.name = 'mockito'
diff --git a/subprojec... | diff --git a/subprojects/junitJupiterExtensionTest/src/test/java/org/mockitousage/NoExtendsTest.java b/subprojects/junitJupiterExtensionTest/src/test/java/org/mockitousage/NoExtendsTest.java
new file mode 100644
index 0000000000..a0d545c6b1
--- /dev/null
+++ b/subprojects/junitJupiterExtensionTest/src/test/java/org/moc... | train | train | 2018-04-28T11:45:47 | 2018-05-17T09:25:55Z | anuraaga | train |
mockito/mockito/1401_1402 | mockito/mockito | mockito/mockito/1401 | mockito/mockito/1402 | [
"keyword_pr_to_issue",
"timestamp(timedelta=5.0, similarity=0.8708289949970366)"
] | 6ab43cd4651bde6aac54071caa9594dce55526f6 | c2034ea73dda4c4ef0f4fdcfdfa0981230e5dfc1 | [] | [] | 2018-06-06T16:33:06Z | [] | VarargsMatcher doesn't work correctly when using HamcrestMatchers in Mockito 2 | ```
class A {
private B b;
public A(B b) {
this.b = b;
}
public Integer perform() {
return b.run("abcd", 1L, 2L);
}
}
class B {
public Integer run(String str, Long... price) {
return 10;
}
}
class HamcrestVarArgsMatcher extends TypeSafeMatcher<Long>... | [
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrategy.java"
] | [
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrategy.java"
] | [
"src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java"
] | diff --git a/src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java b/src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java
index f5216eefa1..9892422e77 100644
--- a/src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java
+++ b/src/main/java/org/mockito/internal/ham... | diff --git a/src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java b/src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java
index ce389b09b0..46a75eb25e 100644
--- a/src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java
+++ b/src/test/ja... | train | train | 2018-06-05T16:33:56 | 2018-06-06T16:29:09Z | aj-jaswanth | train |
mockito/mockito/1419_1426 | mockito/mockito | mockito/mockito/1419 | mockito/mockito/1426 | [
"timestamp(timedelta=0.0, similarity=0.8555848687526292)",
"keyword_pr_to_issue"
] | 4f72147c464c1a8a642d01fc3334e98e92b464cd | 5fc152d778584e2c4890d5ffd453f95b9df700de | [
"asm 6.2 alone does not fix this, neither does upgrading to latest bytebuddy help here.\r\nThe combination of asm 6.2, latest bytebuddy, a minor code change in mockito and setting `-Dnet.bytebuddy.experimental=true` helps here.",
"mockito-core-2.21.0.jar \t\r\nbyte-buddy-1.8.15.jar\r\n\r\nwith org.mockito.plugins... | [] | 2018-07-10T12:04:36Z | [
"java-11"
] | Provide Java 11 compatibility | I ran tests with JAva 11 and getting the follwing exception. may be asm 6.2 fixes this?
org.mockito.exceptions.base.MockitoException:
Mockito cannot mock this class: interface de.espirit.firstspirit.access.Language.
If you're not sure why you're getting this error, please report to the mailing list.
Java... | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index c1af6f9ed6..7f64f84d2c 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.8.10'
+versions.bytebuddy = '1.8.13'
versions.junitJupiter = '5.1.0'
libra... | null | val | train | 2018-06-15T14:56:43 | 2018-07-02T11:12:56Z | andrepdo | train |
mockito/mockito/1431_1433 | mockito/mockito | mockito/mockito/1431 | mockito/mockito/1433 | [
"keyword_issue_to_pr"
] | 198bdc373b803aa85bf90ac150c2723802fbb678 | 68f5a0782009708d649505b7e2dad5d30445846c | [
"Interesting. Thanks for the bug report.\r\n\r\nI noticed a change in serialization in the release notes (http://www.oracle.com/technetwork/java/javase/8u181-relnotes-4479407.html) yesterday.\r\n\r\n> core-libs/java.io:serialization\r\n> ➜ Better stack walking\r\n> New access checks have been added during the obje... | [] | 2018-07-18T13:34:04Z | [
"bug",
"java-8",
"java-10",
"build"
] | Mockito not able to be built with OracleJDK8u181-b13 | Oracle has released [JDK8u181-b13](http://www.oracle.com/technetwork/java/javase/downloads/jdk8-downloads-2133151.html) today. I tried to build Mockito with JDK8u181 but some of the Mockito unit tests failed at the build.
```
org.mockitousage.basicapi.MocksSerializationForAnnotationTest > should_serialize_object_mo... | [
"src/main/java/org/mockito/internal/matchers/Any.java"
] | [
"src/main/java/org/mockito/internal/matchers/Any.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/matchers/Any.java b/src/main/java/org/mockito/internal/matchers/Any.java
index f9f0069bd9..58b6404355 100644
--- a/src/main/java/org/mockito/internal/matchers/Any.java
+++ b/src/main/java/org/mockito/internal/matchers/Any.java
@@ -9,13 +9,10 @@
import org.mockito.Argum... | null | test | train | 2018-07-16T09:06:13 | 2018-07-18T01:44:11Z | ghost | train |
mockito/mockito/1438_1439 | mockito/mockito | mockito/mockito/1438 | mockito/mockito/1439 | [
"timestamp(timedelta=40740.0, similarity=0.8866171351360362)"
] | 2613e0ba972c54dab34d1e2e36d37ec95dad366f | 6b6e1a74c530d1708c4a981b0b2ff4bedec0edc8 | [
"Thank you for contribution!"
] | [] | 2018-07-21T16:47:04Z | [
"docs"
] | ignoreStubs documentation should be updated for strictness | Driven by #1436, we need to update 'ignoreStubs' docs to include information about Mockito strictness (effectively replaces the need for 'ignoreStubs'). | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 44d6b3e0dd..4471b83b92 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -2535,7 +2535,10 @@ public static InOrder inOrder(Object... mocks) {
/**
* Ignores st... | null | val | train | 2018-07-21T14:50:26 | 2018-07-21T12:43:51Z | mockitoguy | train |
mockito/mockito/1444_1446 | mockito/mockito | mockito/mockito/1444 | mockito/mockito/1446 | [
"keyword_pr_to_issue",
"timestamp(timedelta=162048.0, similarity=0.8437745467741583)"
] | 101c588e06f44a81a6bd600234cb4907ff2ada20 | 56019897f07e370087224533f42ee7b89acadb18 | [
"It's a bug. Thank you for reporting!",
"@epeee, can you take a look at this?",
"Upstream bug in Shipkit: https://github.com/mockito/shipkit/issues/741",
"@mockitoguy sorry, I was busy yesterday. \r\nI can have a look at the upstream bug in shipkit tomorrow.",
"Not sure if it is related but the `2.20.1` is ... | [] | 2018-07-26T03:39:08Z | [] | Artifact ID changes | Since `2.20.0` Mockito Maven artifact IDs [have changed](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22org.mockito%22).
* `mockito-android` → `android`
* `mockito-inline` → `inline`
* `mockito-junit-jupiter` → `junit-jupiter`
Not sure if it is an intended change or not, so decided to clarify things a bit. S... | [
"build.gradle",
"doc/release-notes/official.md",
"gradle/java-library.gradle"
] | [
"build.gradle",
"doc/release-notes/official.md",
"gradle/java-library.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index 9045d4c59e..b6f4a2ddc7 100644
--- a/build.gradle
+++ b/build.gradle
@@ -98,3 +98,14 @@ buildScan {
licenseAgreementUrl = 'https://gradle.com/terms-of-service'
licenseAgree = 'yes'
}
+
+//workaround for #1444, delete when Shipkit bug is fixed
+subprojects {
+ ... | null | train | train | 2018-07-24T06:36:25 | 2018-07-25T08:09:20Z | arturdryomov | train |
mockito/mockito/1510_1525 | mockito/mockito | mockito/mockito/1510 | mockito/mockito/1525 | [
"keyword_issue_to_pr"
] | 57d877de14e72c301d78d9163d9c5c5442754b4b | a2fc469fd9063e0e9a98adb1f3e35c29561dfff2 | [
"This is probably broken by https://github.com/mockito/mockito/commit/28fa11092b55595727eb3c40059a5f632f3f29cc Could you revert the Bytebuddy version and see if that fixes it?",
"Sure thing, @TimvdLippe - I'm not 100% sure on the best way to go about that, though. Any pointers on how to most easily pull down and ... | [
"Version 3.0.1 requires Java 8. If this is an issue, we need to keep using the older version.",
"I reverted this change."
] | 2018-10-30T06:42:01Z | [
"android"
] | Newest Mockito Android fails on Android P | The latest releases of Mockito Android appear to break compatibility with Android P. Specifically in instrumentation tests, I encounter an error when attempting to mock an Android framework class. Here's the mocking code I'm using:
```
@Override
protected ConnectivityManager provideConnectivityManager_impl(Con... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index e5f96c5002..6b43944095 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.9.0'
+versions.bytebuddy = '1.9.3'
versions.junitJupiter = '5.1.1'
librari... | null | train | train | 2018-10-19T16:09:01 | 2018-10-05T19:31:53Z | tmtrademarked | train |
mockito/mockito/1541_1544 | mockito/mockito | mockito/mockito/1541 | mockito/mockito/1544 | [
"timestamp(timedelta=1.0, similarity=0.8680414470106933)"
] | 30d3127ee2c4e41452787a058a31b7a553ba3b00 | 8dd8d1ad916c37fdebfccbfe72d46534fd82f5fa | [
"Great investigation! Do you have a suggestion on how to resolve this?",
"Tried different approaches. I believe I found one solution that works well. Created a PR."
] | [] | 2018-11-24T17:50:01Z | [] | Mock object premature garbage collected when using 'One-liner stubs' | ### Problem:
'One-liner stubs' may throw an exception because the actual mock object is already garbage collected when trying to return the mock.
### Reproduce:
1. Mockito 2.23.5 using mockito-inline
2. -Xmx256m
```
public class OneLinerStubStressTest {
public class TestClass {
public String g... | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/ConsecutiveStubbing.java",
"src/main/java/org/mockito/internal/stubbing/OngoingStubbingImpl.java",
"subprojects/inline/inline.gradle"
] | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/ConsecutiveStubbing.java",
"src/main/java/org/mockito/internal/stubbing/OngoingStubbingImpl.java",
"subprojects/inline/inline.gradle"
] | [
"subprojects/inline/src/test/java/org/mockitoinline/OneLinerStubStressTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
index 6dd99cd802..4c86cbd05d 100644
--- a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
+++ b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
@@ -4,17 ... | diff --git a/subprojects/inline/src/test/java/org/mockitoinline/OneLinerStubStressTest.java b/subprojects/inline/src/test/java/org/mockitoinline/OneLinerStubStressTest.java
new file mode 100644
index 0000000000..44ff95959e
--- /dev/null
+++ b/subprojects/inline/src/test/java/org/mockitoinline/OneLinerStubStressTest.jav... | train | train | 2018-11-21T00:13:43 | 2018-11-22T22:32:39Z | maxgrabenhorst | train |
mockito/mockito/1545_1546 | mockito/mockito | mockito/mockito/1545 | mockito/mockito/1546 | [
"timestamp(timedelta=1.0, similarity=0.9250358639836104)"
] | ceb1d29743c1abf733c2014bb3aa0bc364cf9007 | 51a77d3228bd6dc83e3ae36bb168eb5098602809 | [] | [
"Great! We don't want local cache on CI.",
"Why do we need this setting or the next one? Can we rely on Gradle's defaults?",
"good question, let's rely on defaults for now and adjust them if needed later on."
] | 2018-11-26T21:02:18Z | [
"please contribute",
"build"
] | Enable Gradle Build cache for faster local builds | Let's enable Gradle build cache for faster local builds.
https://docs.gradle.org/current/userguide/build_cache.html | [
".gitignore",
"gradle.properties",
"settings.gradle"
] | [
".gitignore",
"gradle.properties",
"settings.gradle"
] | [] | diff --git a/.gitignore b/.gitignore
index b91f27c74a..9d0c115582 100644
--- a/.gitignore
+++ b/.gitignore
@@ -14,6 +14,7 @@ bin/
# Gradle & builds
build
+build-cache
target
out
.gradle
diff --git a/gradle.properties b/gradle.properties
index 41f55a5303..5970e287bb 100644
--- a/gradle.properties
+++ b/gradle.pro... | null | train | train | 2018-11-26T17:06:01 | 2018-11-26T17:06:16Z | mockitoguy | train |
mockito/mockito/1514_1549 | mockito/mockito | mockito/mockito/1514 | mockito/mockito/1549 | [
"timestamp(timedelta=0.0, similarity=0.8578591718360361)",
"keyword_pr_to_issue"
] | 16271ee313350e47855dc4a225e1edcb048a9a91 | d49c667860fce0758a0da9290c7290d06db78f7e | [
"A fix (if this **is** an issue) might be simple:\r\n\r\n```\r\nIndex: src/main/java/org/mockito/internal/stubbing/StubberImpl.java\r\nIDEA additional info:\r\nSubsystem: com.intellij.openapi.diff.impl.patch.CharsetEP\r\n<+>UTF-8\r\n===================================================================\r\n--- src/main... | [] | 2018-11-27T16:56:06Z | [
"bug"
] | Mockito remains in unfinished stubbing state if a stubbing fails | If one of `doThrow` instructions failed due to InstantiationError, Mockito remains in "unfinished stubbing" state and can no longer mock anything.
I had this issue in a single JUnit 4 test, but the fact that Mockito remained in "unfinished stubbing" state used to result in _all_ tests being marked as failed (I could... | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java"
] | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java"
] | [
"src/test/java/org/mockitousage/stubbing/StubbingWithBadThrowablesTest.java",
"subprojects/junit-jupiter/src/test/java/org/mockitousage/UninstantiableThrowableTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
index 2172809e36..42795a723b 100644
--- a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
+++ b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
@@ -87,12 +87... | diff --git a/src/test/java/org/mockitousage/stubbing/StubbingWithBadThrowablesTest.java b/src/test/java/org/mockitousage/stubbing/StubbingWithBadThrowablesTest.java
new file mode 100644
index 0000000000..b0c29d5bee
--- /dev/null
+++ b/src/test/java/org/mockitousage/stubbing/StubbingWithBadThrowablesTest.java
@@ -0,0 +1... | test | train | 2018-11-27T17:45:54 | 2018-10-09T18:09:07Z | dmitry-timofeev | train |
mockito/mockito/1553_1554 | mockito/mockito | mockito/mockito/1553 | mockito/mockito/1554 | [
"timestamp(timedelta=9.0, similarity=0.9413523180519786)"
] | 613c94a69ed6e455700544419921d1c9977844ef | bf16d192f013629115e5c3b1a40bbc394ccd700e | [] | [] | 2018-11-28T23:07:03Z | [
"build"
] | VerifyError thrown when JUnit 3 is in the classpath | With JUnit 3 in the classpath, VerifyError will be thrown during JUnit detection in ExceptionFactory. This is because JUnit's ComparisonFailure class only starts extending AssertionError in JUnit 4.
**Expected Behavior**
When JUnit 3 is in the classpath, Mockito should behave as if JUnit was not there at all.
... | [
"src/main/java/org/mockito/internal/junit/ExceptionFactory.java"
] | [
"src/main/java/org/mockito/internal/junit/ExceptionFactory.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/junit/ExceptionFactory.java b/src/main/java/org/mockito/internal/junit/ExceptionFactory.java
index 3664aea1a8..ee288d614a 100644
--- a/src/main/java/org/mockito/internal/junit/ExceptionFactory.java
+++ b/src/main/java/org/mockito/internal/junit/ExceptionFactory.java
@@ -3... | null | train | train | 2018-11-28T17:19:50 | 2018-11-28T22:58:55Z | tjni | train |
mockito/mockito/1068_1566 | mockito/mockito | mockito/mockito/1068 | mockito/mockito/1566 | [
"timestamp(timedelta=8.0, similarity=0.8412190641305102)"
] | 18990118a96da215a28feccf709d86025d04a06b | a6bb28dcb72cbd08ac9e6848e523f37f1d362dd7 | [
"Given that @brachi-wernick opened a PR for this and it appears that we never commented on this issue: I don't think we should allow this. You should use the real Function in all cases, as a spy of the function would just delegate to the actual function.\r\n\r\nTherefore I am inclined to close this issue and corres... | [] | 2018-12-11T16:16:03Z | [] | feature request: spying on lambdas | Here's some Java8 code that works today (even with Mockito 1.x):
```
Function<Integer, Integer> incrementer = x -> x + 1;
Function<Integer, Integer> spyIncrementer =
mock(Function.class, AdditionalAnswers.delegatesTo(incrementer));
```
I then use `spyIncrementer` as an argument to the code that I really ... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/test/java/org/mockito/MockitoTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index e2a0ade374..24ee6da878 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -1805,6 +1805,34 @@ public static <T> T mock(Class<T> classToMock) {
return mock(classToM... | diff --git a/src/test/java/org/mockito/MockitoTest.java b/src/test/java/org/mockito/MockitoTest.java
index ca8c4d4342..7253ba1c43 100644
--- a/src/test/java/org/mockito/MockitoTest.java
+++ b/src/test/java/org/mockito/MockitoTest.java
@@ -6,10 +6,13 @@
package org.mockito;
import static org.assertj.core.api.Asserti... | val | train | 2018-12-04T22:23:48 | 2017-05-04T13:31:59Z | danwallach | train |
mockito/mockito/1472_1583 | mockito/mockito | mockito/mockito/1472 | mockito/mockito/1583 | [
"keyword_issue_to_pr"
] | eb54a7e72ce7c39c1ac3ccc3193f13d518946fe0 | 9838a7c0f27340f3fdb9f24a17c282a09d0fa369 | [
"I suppose it's worth noting that in the (hopefully) very short term, adding this class in the appropriate package is a simple workaround if you don't want to generalize setting the suggested property:\r\n\r\n```java\r\npackage android.support.test;\r\n\r\nimport android.content.Context;\r\n\r\npublic class Instrum... | [
"Can you refactor the common part into a method so that only the String is different? That makes maintaining this piece of code a bit easier.",
"done"
] | 2019-01-08T18:19:56Z | [
"android"
] | mockito-android "Could not look up implicit location for storing generated classes" with Jetpack (androidx) | I have Android emulator tests with these basic dependencies:
```
androidTestImplementation 'androidx.test:runner:1.1.0-alpha4'
androidTestImplementation 'androidx.test:rules:1.1.0-alpha4'
androidTestImplementation 'org.mockito:mockito-android:2.21.0'
```
Attempting to mock any interface results in exceptions sim... | [
"subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidTempFileLocator.java"
] | [
"subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidTempFileLocator.java"
] | [] | diff --git a/subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidTempFileLocator.java b/subprojects/android/src/main/java/org/mockito/android/internal/creation/AndroidTempFileLocator.java
index a79816c4f5..34e179b40f 100644
--- a/subprojects/android/src/main/java/org/mockito/android/internal/... | null | val | train | 2019-01-06T21:48:15 | 2018-08-10T21:51:10Z | sjudd | train |
mockito/mockito/1584_1585 | mockito/mockito | mockito/mockito/1584 | mockito/mockito/1585 | [
"keyword_pr_to_issue"
] | 467a1bfb75b03a7ec526b5256629639cd990a7e0 | 00cc06b387c3af8aaaed3a14fcb38df7d69db6c1 | [
"@raphw FYI"
] | [] | 2019-01-09T16:11:43Z | [] | ClassLoader built by mockito is not able to load declared types in the hierarchy in OSGi | We develop in OSGi environment and we are using latest version of mockito available on maven central 2.23.4
We got an issue when we mock classes given to guice (sisu) for injection. Sisu/Guice analyse all declared fields and methods for the input type and its super classes to built a sort of index of known types. In... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
index 1985e80863..75b13fcfd9 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
+++ b/sr... | null | train | train | 2019-01-14T22:54:07 | 2019-01-09T11:37:11Z | nfalco79 | train |
mockito/mockito/1587_1588 | mockito/mockito | mockito/mockito/1587 | mockito/mockito/1588 | [
"timestamp(timedelta=0.0, similarity=0.9093045693735561)",
"keyword_pr_to_issue"
] | be2faef4195d55484cbc58c27951849eebd9fc35 | 03432660ffd186bc04e53f62ca53178fa60b62ea | [] | [] | 2019-01-10T12:19:16Z | [
"injection"
] | InjectingAnnotationEngine does an unnecessary loop. | processInjectMocks method of InjectingAnnotationEngine does unnecessary work. It might call injectMocks several times while it is sufficient to call injectMocks once.
private void processInjectMocks(final Class<?> clazz, final Object testInstance) {
Class<?> classContext = clazz;
while (classCo... | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java b/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
index 6cb5fb123b..20d967d07e 100644
--- a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
+++ b/src/main/java/org... | null | train | train | 2019-01-10T00:02:00 | 2019-01-10T12:16:12Z | LihMeh | train |
mockito/mockito/1595_1602 | mockito/mockito | mockito/mockito/1595 | mockito/mockito/1602 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8999167219580725)"
] | 467a1bfb75b03a7ec526b5256629639cd990a7e0 | 1ae82bc15462b933573d932ed554662e78cdebfa | [
"My machine is still on JVM 11.0.1. Going to have to go through Travis this time around to debug this issue..."
] | [] | 2019-01-28T17:25:20Z | [
"java-11",
"build"
] | Gradle javadoc plugin fails with latest JDK 11 release | The javadoc plugin fails with a status code 1 on current JVM 11.0.2 releases. | [
"build.gradle"
] | [
"build.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index a047ced6a9..0dac0c72f3 100644
--- a/build.gradle
+++ b/build.gradle
@@ -59,6 +59,12 @@ allprojects { proj ->
options.warnings = false
options.encoding = 'UTF-8'
}
+ tasks.withType(Javadoc) {
+ options.addStringOption('Xdoclint:none', '-quie... | null | test | train | 2019-01-14T22:54:07 | 2019-01-19T14:46:33Z | raphw | train |
mockito/mockito/1615_1617 | mockito/mockito | mockito/mockito/1615 | mockito/mockito/1617 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8977929713305419)"
] | f11705be91ee3545bc006908b34425f1fc359898 | faeae6ac604e0103229a2ef23e35f88e10e026dd | [
"Suspiciously, the type is again in the `java.util` package. That leads me to believe any type definitive in there can't be mocked.",
"> That leads me to believe any type definitive in there can't be mocked.\r\n\r\nUsing `2.24.0`. It works with the older version.",
"The package should not be an issue, but I'll ... | [] | 2019-02-11T15:27:29Z | [
"java-12"
] | Issue with mocking type in "java.util.*", Java 12 | After upgrading Mockito from `2.23.4` to `2.24.0` we can't run JUnit 5's tests anymore. The error message reads:
```
org.mockito.exceptions.base.MockitoException:
Mockito cannot mock this class: interface java.util.concurrent.locks.Lock.
Mockito can only mock non-private & non-final classes.
If yo... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/test/java/org/mockitousage/serialization/AcrossClassLoaderSerializationTest.java",
"subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleHandlingTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
index 8968b9e8e4..093978dd22 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
+++ b/sr... | diff --git a/src/test/java/org/mockitousage/serialization/AcrossClassLoaderSerializationTest.java b/src/test/java/org/mockitousage/serialization/AcrossClassLoaderSerializationTest.java
index 240cf7d027..f8a262d15d 100644
--- a/src/test/java/org/mockitousage/serialization/AcrossClassLoaderSerializationTest.java
+++ b/sr... | train | val | 2019-02-05T00:24:14 | 2019-02-10T16:09:00Z | sormuras | train |
mockito/mockito/1618_1620 | mockito/mockito | mockito/mockito/1618 | mockito/mockito/1620 | [
"keyword_pr_to_issue"
] | 34ebca1a8cd88465dd6e8ba395f78a6593522958 | d9cbe3e8ec9cafa521e61371d9e9600b7262cda7 | [
"We have observed similar things before. It seems like a mock is something keeping a hard reference to a listener. @TimvdLippe Do you remember me mentioning to having observed this some times? Were you working with the listener parts originally?",
"Yes I recall that discussion. The listener parts were introduced ... | [] | 2019-02-12T23:00:27Z | [] | Serializable flag doesn't make mock serializable | I have a simple example test like this (I'm using junit5 with mockito-junit-jupiter extension)
```
@ExtendWith(MockitoExtension.class)
class ExampleTest {
@Mock(serializable = true) private Iterable<?> it;
@Test
void shouldSerializeAndDeserializeIt() throws IOException, ClassNotFoundException {
// ... | [
"src/main/java/org/mockito/internal/junit/DefaultStubbingLookupListener.java"
] | [
"src/main/java/org/mockito/internal/junit/DefaultStubbingLookupListener.java"
] | [
"src/test/java/org/mockitousage/serialization/StrictStubsSerializableTest.java"
] | diff --git a/src/main/java/org/mockito/internal/junit/DefaultStubbingLookupListener.java b/src/main/java/org/mockito/internal/junit/DefaultStubbingLookupListener.java
index 21212a6754..b6a80c64a3 100644
--- a/src/main/java/org/mockito/internal/junit/DefaultStubbingLookupListener.java
+++ b/src/main/java/org/mockito/int... | diff --git a/src/test/java/org/mockitousage/serialization/StrictStubsSerializableTest.java b/src/test/java/org/mockitousage/serialization/StrictStubsSerializableTest.java
new file mode 100644
index 0000000000..9d786695fc
--- /dev/null
+++ b/src/test/java/org/mockitousage/serialization/StrictStubsSerializableTest.java
@... | train | val | 2019-02-12T14:20:41 | 2019-02-12T21:47:14Z | SimY4 | train |
mockito/mockito/1638_1639 | mockito/mockito | mockito/mockito/1638 | mockito/mockito/1639 | [
"timestamp(timedelta=6.0, similarity=0.853894488049074)"
] | d41ad6cb1c1018b334769ae595214c6c025f67a4 | 1df5e49043fb032106f5c0fc0eec97ca9251241f | [] | [] | 2019-02-28T02:45:54Z | [] | Mockito.java contains inaccessible links to articles. | The monkeyisland.pl domain is no longer available.
List of inaccessible articles:
http://monkeyisland.pl/2009/01/13/subclass-and-override-vs-partial-mocking-vs-refactoring
http://monkeyisland.pl/2008/07/12/should-i-worry-about-the-unexpected
http://monkeyisland.pl/2008/04/26/asking-and-telling
http://monkeyislan... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index e2a0ade374..afbe082d9e 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -207,7 +207,7 @@
*
* //Although it is possible to verify a stubbed invocation, usually <b>it's... | null | train | val | 2019-02-28T02:19:18 | 2019-02-28T02:35:41Z | PawelPamula | train |
mockito/mockito/1642_1644 | mockito/mockito | mockito/mockito/1642 | mockito/mockito/1644 | [
"keyword_pr_to_issue",
"timestamp(timedelta=8.0, similarity=0.9119012286113053)"
] | b745b5d48e9c110fa419fd007b3159ff612b8643 | 73f1d17e5b0ec1410e54a72334639da077e984f4 | [
"Update: I found that the lazy verification works properly when you use `VerificationCollector` directly. However, if you try and use it as a JUnit rule that's when this bug manifests.\r\n\r\nI have updated `VerificationCollectorImplTest` to properly test for this situation and fail as appropriate. I will have a qu... | [] | 2019-03-04T03:52:22Z | [] | VerificationCollector doesn't work for invocations with non-matching args | I found the incubating `VerificationCollector` (#287), which is similar to AssertJ `SoftAssertion`s in that it collects multiple verifications and then asserts on the whole, rather than throwing an exception on the first one and skipping the rest of the verifications. Very useful for complicated testing.
However, I ... | [
"src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java"
] | [
"src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java"
] | [
"src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java"
] | diff --git a/src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java b/src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java
index 7c19d35652..e54d47864e 100644
--- a/src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java
+++ b/src/main/java/org/mockito/internal/junit/... | diff --git a/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java b/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java
index 8f4c420eca..9b4cc1ec1c 100644
--- a/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java
+++ b/src/test/java/org/mockitousag... | train | val | 2019-03-01T14:13:09 | 2019-03-03T23:45:20Z | kriegfrj | train |
mockito/mockito/1609_1646 | mockito/mockito | mockito/mockito/1609 | mockito/mockito/1646 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8876214866028436)"
] | ab645dd40bf7152743c6a0ee45b8c9cd692e7639 | 2a7489d316b2a733aa6306b3a829d2e8fedb46ae | [
"For more information see the error-prone bugpattern: https://errorprone.info/bugpattern/TypeParameterUnusedInFormals",
"@mockitoguy WDYT? I think it makes sense to have a simple API for local assignments or in return statements, but we would still need the Class to be explicit.",
"Looking...",
"Good idea! Fe... | [] | 2019-03-04T15:13:15Z | [] | Add back InvocationOnMock.getArgument<T>(int, Class<T>) | In https://github.com/mockito/mockito/issues/365 we replaced the existing `getArgumentAt<T>(int, Class<T>)` API with the current `getArgument(int)` API. However, when integrating this change within Google, we ran into numerous issues.
An example:
```java
invocation.getArgumentAt(0, Runnable.class).run()
```
... | [
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/MockitoFramework.java",
"src/main/java/org/mockito/MockitoSession.java",
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"src/main/java/org/mockito/invocation/InvocationOnMock.java",
"src/main/java/org/mo... | [
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/MockitoFramework.java",
"src/main/java/org/mockito/MockitoSession.java",
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"src/main/java/org/mockito/invocation/InvocationOnMock.java",
"src/main/java/org/mo... | [] | diff --git a/src/main/java/org/mockito/MockSettings.java b/src/main/java/org/mockito/MockSettings.java
index 95fcfe3236..07af55e377 100644
--- a/src/main/java/org/mockito/MockSettings.java
+++ b/src/main/java/org/mockito/MockSettings.java
@@ -44,6 +44,7 @@
* Firstly, to make it easy to add another mock setting when t... | null | test | val | 2019-03-08T17:48:53 | 2019-02-05T16:53:30Z | TimvdLippe | train |
mockito/mockito/1645_1647 | mockito/mockito | mockito/mockito/1645 | mockito/mockito/1647 | [
"keyword_pr_to_issue"
] | 19adbf3dea958acbbdcb078b550a6797e3e7557d | 3701597af7fcf306684c5e86d18e613f618b5d77 | [
"@TimvdLippe it looks like we fixed this one in https://github.com/mockito/shipkit/pull/782.\r\nI can do some local testing and provide a PR for this one soon (shipkit version update).",
"Thanks for that @epeee Looking forward to that PR.",
"Thank you guys!"
] | [] | 2019-03-04T17:36:20Z | [] | Release build is failing | After the latest Shipkit update, our Travis is failing: https://travis-ci.org/mockito/mockito/jobs/501397895#L1693 It fails with
```
[commit] 2 files changed, 11 insertions(+), 2 deletions(-)
[performRelease] External process [commit] completed.
[performRelease] [tag] fatal: tag 'v2.24.8' already exists
```
... | [
"build.gradle",
"version.properties"
] | [
"build.gradle",
"version.properties"
] | [] | diff --git a/build.gradle b/build.gradle
index c8142db658..4285ff16ff 100644
--- a/build.gradle
+++ b/build.gradle
@@ -11,7 +11,7 @@ buildscript {
classpath 'net.ltgt.gradle:gradle-errorprone-plugin:0.6'
//Using buildscript.classpath so that we can resolve shipkit from maven local, during local test... | null | train | val | 2019-03-04T16:20:43 | 2019-03-04T15:12:41Z | TimvdLippe | train |
mockito/mockito/1664_1665 | mockito/mockito | mockito/mockito/1664 | mockito/mockito/1665 | [
"keyword_pr_to_issue"
] | d6098a6bbdfbafd966a2078627a90d9ffbedc7ea | ac5bd58ab33e7d8a5b4a38fa4cf2fe10c78a5d22 | [] | [
"What is the reasoning for making this protected? It is an internal class, so it should not be subclassed.",
"I don't see these being used anywhere else. Moreover, they are not on the interface `Invocation`. If we were to add them, they have to be on the interface.",
"I currently need to extend it to replace th... | 2019-03-16T20:12:52Z | [] | Make invocation to drive its printing | Right now the `toString()` of an `Invocation` is ignored when it's being printed for a verification error, this prevents mockito-scala from providing a custom representation of the arguments via the implicit context.
With a simple change to drive the printing from within the `Invocation` the problem can be solved | [
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/reporting/PrintSettings.java",
"src/main/java/org/mockito/invocation/Invocation.java"
] | [
"src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/reporting/PrintSettings.java",
"src/main/java/org/mockito/invocation/Invocation.java"
] | [
"src/test/java/org/mockito/internal/invocation/InvocationBuilder.java",
"src/test/java/org/mockito/internal/verification/checkers/MissingInvocationCheckerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java b/src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java
index 37cc451829..ec1fcba173 100644
--- a/src/main/java/org/mockito/internal/invocation/InterceptedInvocation.java
+++ b/src/main/java/org/mockito/internal/inv... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java b/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
index 4fc5cb1c1c..4e01535027 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
+++ b/src/test/java/org/mockito/internal/invocation/Invo... | train | val | 2019-03-23T15:50:20 | 2019-03-16T20:11:36Z | ultrasecreth | train |
mockito/mockito/1663_1667 | mockito/mockito | mockito/mockito/1663 | mockito/mockito/1667 | [
"timestamp(timedelta=0.0, similarity=0.9492359482839157)"
] | a323b8132de6f6e1c29d738de245469f8ce009b0 | 56a30b31a00060a4a952c87d49c53f871ade4d75 | [
"Changing the exception type is an incompatible change in a strict sense. However, we need to be able to improve the framework by tweaking the exceptions if needed. We always strive to be compatible. There are no known legit use cases why our users would want to catch & handle specific Mockito exceptions. It's OK t... | [
"We will get to that when we switch to Java 1.8. Let's remove these comments for now.",
"Done.",
"Great! \"compileOnly\" is exactly the way to go!",
"Let's just say \"JUnit\", instead of \"JUnit 3\" in the javadocs. It will be less confusing.",
"Let's change \"JUnit 3\" -> \"Junit\" in all new javadoc",
"... | 2019-03-18T09:19:25Z | [] | Improve IDE UX comparison failure for JUnit5 | When JUnit4 is used and the test is invoked from IDE (IDEA or Eclipse), and we are getting "arguments are different" MockitoVerificationError, the IDE gets nice "click to see the difference" link in the test failure, providing neat comparison pop-up.
We want to provide this feature for JUnit5, too. We do not want to... | [
"build.gradle",
"gradle/dependencies.gradle",
"gradle/mockito-core/osgi.gradle",
"src/main/java/org/mockito/exceptions/verification/ArgumentsAreDifferent.java",
"src/main/java/org/mockito/exceptions/verification/junit/package-info.java",
"src/main/java/org/mockito/internal/junit/ExceptionFactory.java"
] | [
"build.gradle",
"gradle/dependencies.gradle",
"gradle/mockito-core/osgi.gradle",
"src/main/java/org/mockito/exceptions/verification/ArgumentsAreDifferent.java",
"src/main/java/org/mockito/exceptions/verification/junit/package-info.java",
"src/main/java/org/mockito/exceptions/verification/opentest4j/Argume... | [
"src/test/java/org/mockito/StaticMockingExperimentTest.java",
"src/test/java/org/mockito/internal/junit/ExceptionFactoryTest.java",
"src/test/java/org/mockito/internal/verification/VerificationOverTimeImplTest.java",
"src/test/java/org/mockito/internal/verification/checkers/MissingInvocationCheckerTest.java",... | diff --git a/build.gradle b/build.gradle
index 4285ff16ff..daee5a92b5 100644
--- a/build.gradle
+++ b/build.gradle
@@ -78,7 +78,7 @@ configurations {
dependencies {
compile libraries.bytebuddy, libraries.bytebuddyagent
- compileOnly libraries.junit4, libraries.hamcrest
+ compileOnly libraries.junit4, libr... | diff --git a/src/test/java/org/mockito/StaticMockingExperimentTest.java b/src/test/java/org/mockito/StaticMockingExperimentTest.java
index cc8a5988e4..c6312e75e0 100644
--- a/src/test/java/org/mockito/StaticMockingExperimentTest.java
+++ b/src/test/java/org/mockito/StaticMockingExperimentTest.java
@@ -8,7 +8,7 @@
impo... | test | val | 2019-03-15T18:25:52 | 2019-03-15T19:15:17Z | mockitoguy | train |
mockito/mockito/1668_1669 | mockito/mockito | mockito/mockito/1668 | mockito/mockito/1669 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8940422539486178)"
] | a323b8132de6f6e1c29d738de245469f8ce009b0 | 2a95f86c49ac35e6364bdacae86e98e4a3c3aa07 | [] | [
"I think the JUnit dependency should be kept at 4.12, we should avoid depending on a beta version.",
"Shall we keep a lower target, to allow benefit for older platforms ?",
"ErrorProne must run on Java 8: https://errorprone.info/docs/installation\r\n\r\nEdit: Although we could bump the target compatibility, I w... | 2019-03-18T15:13:04Z | [
"enhancement",
"new feature"
] | Add subproject for errorprone Mockito plugins | We heavily rely on ErrorProne plugins to prohibit certain usage of Mockito. Examples include disallowing the usages of Mockito internals or extending interfaces annotated by `@NotExtensible`.
These plugins are beneficial to the Java community and we would like to open source them to the project. The extra subproject... | [
"gradle/dependencies.gradle",
"gradle/root/java-compatibility-check.gradle",
"settings.gradle"
] | [
"gradle/dependencies.gradle",
"gradle/root/java-compatibility-check.gradle",
"settings.gradle",
"subprojects/errorprone/errorprone.gradle",
"subprojects/errorprone/src/main/java/org/mockito/errorprone/bugpatterns/MockitoNotExtensible.java"
] | [
"subprojects/errorprone/src/test/java/org/mockito/errorprone/bugpatterns/MockitoNotExtensibleTest.java"
] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index f164631907..ed5f763cbe 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -6,6 +6,7 @@ def versions = [:]
versions.bytebuddy = '1.9.7'
versions.junitJupiter = '5.1.1'
+versions.errorprone = '2.3.2'
libraries.junit... | diff --git a/subprojects/errorprone/src/test/java/org/mockito/errorprone/bugpatterns/MockitoNotExtensibleTest.java b/subprojects/errorprone/src/test/java/org/mockito/errorprone/bugpatterns/MockitoNotExtensibleTest.java
new file mode 100644
index 0000000000..4e0f3f7152
--- /dev/null
+++ b/subprojects/errorprone/src/test... | test | val | 2019-03-15T18:25:52 | 2019-03-18T14:47:55Z | TimvdLippe | train |
mockito/mockito/1606_1673 | mockito/mockito | mockito/mockito/1606 | mockito/mockito/1673 | [
"keyword_pr_to_issue"
] | d6098a6bbdfbafd966a2078627a90d9ffbedc7ea | 43f737632647ed429233f0d9a96742de765a4412 | [
"I am also getting the same error. Reverting back to `2.23.+` fixes the issue.",
"Seems like you are loading the wrong version of ByteBuddy. What version are\nyou using?\n\nOn Mon, 4 Feb 2019, 10:49 Taher, <notifications@github.com> wrote:\n\n> I am also getting the same error. Reverting back to 2.23.+ fixes the\... | [
"I don't think this warrants a new minor release. I think this should be just 2.25.5",
"No probs. I generally like to publish new minor every few weeks. It's arbitrary what we warrant a new minor release, and that's OK.\r\n\r\nI need to finally set up the automation that automatically pushes to MavenCentral if th... | 2019-03-23T17:08:56Z | [] | Unexpected error (Mockito can only mock non-private & non-final classes.) in version 2.24.0 | Hi,
Since version 2.24.0 I got the error "Mockito can only mock non-private & non-final classes.". Reverting back to Mockito 2.23.4 resolves the problem.
**Stacktrace**
`Underlying exception : java.lang.IllegalArgumentException: Could not create type
at nl.tkp.ddw.pensioenaangifte.test.model.unittesten.Aanleve... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index fe5509e557..c6462ed7e3 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.9.7'
+versions.bytebuddy = '1.9.11'
versions.junitJupiter = '5.1.1'
versions... | null | test | val | 2019-03-23T15:50:20 | 2019-02-04T10:48:15Z | frankvanderkuur | train |
mockito/mockito/1542_1701 | mockito/mockito | mockito/mockito/1542 | mockito/mockito/1701 | [
"keyword_pr_to_issue"
] | a1a78ef7539a6b7527acbec6e2323413d0c2dfa3 | 1ae32bda7ea485f94374c74c085fcdbd8b000e53 | [
"Nice report, thank you! Do you want to take a stub at fixing it? I suspect that we need to tweak the reporting, so that we print other interactions, too. We do something like that for regular verification failures (as opposed to verification failures due to mismatched arguments)",
"I can try and take a look at t... | [] | 2019-05-02T17:27:15Z | [
"please contribute"
] | when mock is called multiple times, and verify fails, the error message reports only the first invocation | AS A diligent dev,
I WANT TO verify that a mock will eventually get called with the specified parameters,
SO THAT I can properly test my builder class
SCENARIO
I have a builder class exposing a .with(String key, String value) method.
I created a test for testing that at a certain point the method gets called wit... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/SmartPrinter.java",
"src/main/java/org/mockito/internal/verification/checkers/MissingInvocationChecker.java"
] | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/SmartPrinter.java",
"src/main/java/org/mockito/internal/verification/checkers/MissingInvocationChecker.java"
] | [
"src/test/java/org/mockito/internal/verification/SmartPrinterTest.java",
"src/test/java/org/mockito/internal/verification/checkers/MissingInvocationCheckerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/MissingInvocationInOrderCheckerTest.java",
"src/test/java/org/mockitousage/verificati... | diff --git a/src/main/java/org/mockito/internal/exceptions/Reporter.java b/src/main/java/org/mockito/internal/exceptions/Reporter.java
index 1b68fbb657..30513525f4 100644
--- a/src/main/java/org/mockito/internal/exceptions/Reporter.java
+++ b/src/main/java/org/mockito/internal/exceptions/Reporter.java
@@ -299,17 +299,3... | diff --git a/src/test/java/org/mockito/internal/verification/SmartPrinterTest.java b/src/test/java/org/mockito/internal/verification/SmartPrinterTest.java
index 4918991d3d..d786762a8d 100644
--- a/src/test/java/org/mockito/internal/verification/SmartPrinterTest.java
+++ b/src/test/java/org/mockito/internal/verification... | val | val | 2019-05-01T17:33:47 | 2018-11-23T15:17:22Z | erikologic | train |
mockito/mockito/1623_1708 | mockito/mockito | mockito/mockito/1623 | mockito/mockito/1708 | [
"timestamp(timedelta=4.0, similarity=0.9213547190073447)",
"keyword_pr_to_issue"
] | 237e915e76a42292965dbc737c61790c32cf7735 | 53e8a93141e1f8c41d6b6d4fd72c20488826269a | [
"I would welcome a PR for this :smile: "
] | [] | 2019-05-06T15:05:32Z | [
"enhancement"
] | Consider renaming TooLittleActualInvocations | I agree with the commenter [here](https://github.com/mockito/mockito/issues/1088#issuecomment-303374289) that the exception name `TooLittleActualInvocations` is not ideal.
The correct English would be `TooFewActualInvocations` (where "few" is the opposite of "many" - as used in `TooManyActualInvocations`).
I appr... | [
"src/main/java/org/mockito/exceptions/verification/TooLittleActualInvocations.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/Numb... | [
"src/main/java/org/mockito/exceptions/verification/TooFewActualInvocations.java",
"src/main/java/org/mockito/exceptions/verification/TooLittleActualInvocations.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvoca... | [
"src/test/java/org/mockito/internal/exceptions/ReporterTest.java",
"src/test/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsCheckerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/NumberOfInvocationsCheckerTest.java",
"src/test/java/org/mockito/internal/verific... | diff --git a/src/main/java/org/mockito/exceptions/verification/TooFewActualInvocations.java b/src/main/java/org/mockito/exceptions/verification/TooFewActualInvocations.java
new file mode 100644
index 0000000000..5ffbb2f83b
--- /dev/null
+++ b/src/main/java/org/mockito/exceptions/verification/TooFewActualInvocations.jav... | diff --git a/src/test/java/org/mockito/internal/exceptions/ReporterTest.java b/src/test/java/org/mockito/internal/exceptions/ReporterTest.java
index c0bb512df2..e7c92bc92c 100644
--- a/src/test/java/org/mockito/internal/exceptions/ReporterTest.java
+++ b/src/test/java/org/mockito/internal/exceptions/ReporterTest.java
@... | train | val | 2019-05-05T22:06:05 | 2019-02-18T11:22:32Z | hdpe | train |
mockito/mockito/1717_1718 | mockito/mockito | mockito/mockito/1717 | mockito/mockito/1718 | [
"keyword_pr_to_issue"
] | 71603d46ebd8d1e35a55e4d54651b77ae46ccb49 | d86b9a33ee95eb87c95f86e2002ee7631a57b4d9 | [
"For reference, the change was introduced in JaCoCo with jacoco/jacoco#845."
] | [] | 2019-05-24T12:45:41Z | [] | Incompatibility between the inline mocks and JaCoCo 0.8.4 | # Versions
Mockito 2.27.0
JaCoCo 0.8.4
# Problem
JaCoCo 0.8.4 introduced the use of the Conditional Dynamic instruction when running with Java 11+, which triggers an exception in the [`MethodVisitor`](https://github.com/mockito/mockito/blob/v2.27.0/src/main/java/org/mockito/internal/creation/bytebuddy/InlineB... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
index e160e3cb2d..34b1e89855 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
+++ b/src/main... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java
index eebdb962d7..7d3647e6e8 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java... | train | val | 2019-05-24T21:17:40 | 2019-05-24T12:36:19Z | fpavageau | train |
mockito/mockito/1655_1783 | mockito/mockito | mockito/mockito/1655 | mockito/mockito/1783 | [
"keyword_pr_to_issue"
] | 98e8743b6b5c0cca64cf3cb3c46a9b96b25fd9b6 | 28bce89b411ffb58387b3208acfae43a31022172 | [
"Any thoughts on this one? I'm just curious to know."
] | [] | 2019-09-25T00:53:55Z | [] | Stubbing not stopped properly when running suite of tests | Hey,
I'm not sure the title describes the problem in the best way but I found the following.
Consider the two tests:
```java
public class MockitoMisusingUnitTest {
@Test
public void givenNotASpy_whenDoReturn_thenThrowNotAMock() {
try {
List<String> list = new ArrayList<St... | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java"
] | [
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java"
] | [
"src/test/java/org/mockitousage/stubbing/MisusingStubbingTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
index 5a599c78aa..84f1e3c2e5 100644
--- a/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
+++ b/src/main/java/org/mockito/internal/stubbing/StubberImpl.java
@@ -4,6 +4,7 ... | diff --git a/src/test/java/org/mockitousage/stubbing/MisusingStubbingTest.java b/src/test/java/org/mockitousage/stubbing/MisusingStubbingTest.java
new file mode 100644
index 0000000000..2e5bf26d2c
--- /dev/null
+++ b/src/test/java/org/mockitousage/stubbing/MisusingStubbingTest.java
@@ -0,0 +1,35 @@
+/*
+ * Copyright (c... | train | val | 2019-09-17T17:13:23 | 2019-03-05T22:45:40Z | JonCook | train |
mockito/mockito/1786_1787 | mockito/mockito | mockito/mockito/1786 | mockito/mockito/1787 | [
"keyword_pr_to_issue"
] | 16328dbe6562056d382cd5aa7cba0d6695de9665 | f8581c6e875dc3fb587fe31e85d025ef4d110a3f | [] | [] | 2019-09-27T20:03:05Z | [] | Difference between 'timeout' and 'after' not immediately clear | The first few lines of the JavaDoc for both methods do not exactly specify their difference. From `timeout` you have to jump to `after` where at the end of the JavaDoc the difference is explained.
I think this can be improved. The first sentence in `timeout` could be more specific to highlight the difference directl... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 786b716a51..2f247045a2 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -2820,14 +2820,13 @@ public static VerificationMode only() {
}
/**
- * Verificatio... | null | train | val | 2019-09-25T17:00:40 | 2019-09-27T19:58:25Z | SimplyDanny | train |
mockito/mockito/1630_1788 | mockito/mockito | mockito/mockito/1630 | mockito/mockito/1788 | [
"keyword_pr_to_issue"
] | 16328dbe6562056d382cd5aa7cba0d6695de9665 | 112919971c0a985b0918a2e0c29b145c14e0d7d8 | [
"Hey! Can you take a look at our FAQ wiki. We documented how Mockito supports parallel execution.",
"I took a look at the wiki, but found just a very short section about parallel testing in the FAQ section. I issued the bug, because the parallel execution of whole test cases with JUnit 5 seems to be broken. I do ... | [] | 2019-09-28T01:31:15Z | [
"junit5"
] | Mockito JUnit Jupiter extension does not correctly support parallel test execution | Sorry for not being able to provide the required information, but we just noticed that the MockitoExtension (mockito-junit-jupiter 2.24.5) leads to spurious test failures (e.g. due to calls to mocks not being recorded) when using "junit.jupiter.execution.parallel.enabled=true" with surefire. Prior we used our much simp... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/MultiLevelNestedTest.java"
] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 7ac37ad658..2626d222e0 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -5,7 +5,7 @@ ext {
def versions = [:]
versions.bytebuddy = '1.9.10'
-versions.junitJupiter = '5.1.1'
+versions.junitJupiter = '5.4.2'
version... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/MultiLevelNestedTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/MultiLevelNestedTest.java
new file mode 100644
index 0000000000..58a42f97e4
--- /dev/null
+++ b/subprojects/junit-jupiter/src/test/java/org/mockitousage/MultiLevelNe... | test | val | 2019-09-25T17:00:40 | 2019-02-25T12:54:15Z | markusheiden | train |
mockito/mockito/1630_1789 | mockito/mockito | mockito/mockito/1630 | mockito/mockito/1789 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 214d4652aa1971cb554c434b0ac13b376aea33a7 | 30c50fa3442004996dc9c7b2bcfdae7aaaae3ce6 | [
"Hey! Can you take a look at our FAQ wiki. We documented how Mockito supports parallel execution.",
"I took a look at the wiki, but found just a very short section about parallel testing in the FAQ section. I issued the bug, because the parallel execution of whole test cases with JUnit 5 seems to be broken. I do ... | [
"Instead of having a boolean here, can we pass in `context.getParent()` on line 164. E.g. we pass the first parent in already, but then we keep all the other logic the same. That seems a little bit nicer to me and easier to follow. The comment can then be placed before line 164 instead.",
"Please push a commit to... | 2019-09-28T22:08:17Z | [
"junit5"
] | Mockito JUnit Jupiter extension does not correctly support parallel test execution | Sorry for not being able to provide the required information, but we just noticed that the MockitoExtension (mockito-junit-jupiter 2.24.5) leads to spurious test failures (e.g. due to calls to mocks not being recorded) when using "junit.jupiter.execution.parallel.enabled=true" with surefire. Prior we used our much simp... | [
"settings.gradle.kts",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"settings.gradle.kts",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java",
"subprojects/junitJupiterParallelTest/junitJupiterParallelTest.gradle"
] | [
"subprojects/junitJupiterParallelTest/src/test/java/org/mockito/ParallelBugTest.java",
"subprojects/junitJupiterParallelTest/src/test/resources/junit-platform.properties"
] | diff --git a/settings.gradle.kts b/settings.gradle.kts
index d57b84e560..dc31ca1f32 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -8,7 +8,8 @@ include("deprecatedPluginsTest",
"junitJupiterExtensionTest",
"module-test",
"memory-test",
- "errorprone")
+ "errorprone",
+ "junitJupit... | diff --git a/subprojects/junitJupiterParallelTest/src/test/java/org/mockito/ParallelBugTest.java b/subprojects/junitJupiterParallelTest/src/test/java/org/mockito/ParallelBugTest.java
new file mode 100644
index 0000000000..e3e1f8bb40
--- /dev/null
+++ b/subprojects/junitJupiterParallelTest/src/test/java/org/mockito/Para... | test | val | 2019-09-28T21:08:43 | 2019-02-25T12:54:15Z | markusheiden | train |
mockito/mockito/1791_1798 | mockito/mockito | mockito/mockito/1791 | mockito/mockito/1798 | [
"keyword_pr_to_issue"
] | ded29efbfbd7be6e3a0a2fdae07d370d099be625 | e4b27d1d99800b09c757ec1854a70f8c295943cd | [
"Feel free to send a PR!"
] | [] | 2019-10-05T08:57:05Z | [] | Typo in Mockito.java Javadoc: "verification" in wiki link | https://github.com/mockito/mockito/blob/f8581c6e875dc3fb587fe31e85d025ef4d110a3f/src/main/java/org/mockito/Mockito.java#L2579
There's a missing "i" in the wiki link:
```
https://github.com/mockito/mockito/wiki/Greedy-algorithm-of-verfication-InOrder
https://github.com/mockito/mockito/wiki/Greedy-algorithm-of-ve... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 2f247045a2..3c8cdf7478 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -2576,7 +2576,7 @@ public static Stubber doReturn(Object toBeReturned, Object... toBeReturnedNext)... | null | val | val | 2019-10-04T20:59:47 | 2019-09-30T19:34:37Z | mjustin | train |
mockito/mockito/1631_1810 | mockito/mockito | mockito/mockito/1631 | mockito/mockito/1810 | [
"keyword_issue_to_pr"
] | a9c5105f8fda310a00b6d784a8bf9fb694a94610 | 5225b593d6dc11fbc63bb1d0c6ba7f7f0503f0da | [
"Is there any update on this? This has broken our tests as well attempting to upgrade our version of Mockito. The usage of an @InjectMocks as well as a @Spy & @InjectMocks makes sense from the perspective of integration testing of two components that act as one cohesive unit. ",
"Here's a pseudo code to describe ... | [
"Can we assert here on `target.getBar()`. Also please add another assertion with `assertEquals(target.foo, foo)`",
"Thanks. applied your feedback.",
"Why would you iterate over the super classes of the Test class ???",
"This behaviour does not reflect the docs of the annotation",
"This test only works if I ... | 2019-10-24T23:29:02Z | [
"injection"
] | Regression: @Spy with @InjectMock are not injected anymore | Hi,
- [x] The mockito message in the stacktrace have useful information, but it didn't help
java.lang.NullPointerException
at org.test.TestedService.servivce(TestedService.java:16)
at org.test.TestedServiceTest.mockSpyAndInjectAll(TestedServiceTest.java:33)
- [x] The problematic code (if that's possible)... | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java b/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
index 20d967d07e..6cb5fb123b 100644
--- a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
+++ b/src/main/java/org... | diff --git a/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java b/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java
new file mode 100644
index 0000000000..7a8b064f68
--- /dev/null
+++ b/src/test/java/org/mockito/internal/configuration/InjectingAnnotatio... | val | val | 2019-10-25T15:18:30 | 2019-02-26T15:29:04Z | arnor2000 | train |
mockito/mockito/1587_1810 | mockito/mockito | mockito/mockito/1587 | mockito/mockito/1810 | [
"keyword_pr_to_issue"
] | a9c5105f8fda310a00b6d784a8bf9fb694a94610 | 5225b593d6dc11fbc63bb1d0c6ba7f7f0503f0da | [] | [
"Can we assert here on `target.getBar()`. Also please add another assertion with `assertEquals(target.foo, foo)`",
"Thanks. applied your feedback.",
"Why would you iterate over the super classes of the Test class ???",
"This behaviour does not reflect the docs of the annotation",
"This test only works if I ... | 2019-10-24T23:29:02Z | [
"injection"
] | InjectingAnnotationEngine does an unnecessary loop. | processInjectMocks method of InjectingAnnotationEngine does unnecessary work. It might call injectMocks several times while it is sufficient to call injectMocks once.
private void processInjectMocks(final Class<?> clazz, final Object testInstance) {
Class<?> classContext = clazz;
while (classCo... | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java b/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
index 20d967d07e..6cb5fb123b 100644
--- a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
+++ b/src/main/java/org... | diff --git a/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java b/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java
new file mode 100644
index 0000000000..7a8b064f68
--- /dev/null
+++ b/src/test/java/org/mockito/internal/configuration/InjectingAnnotatio... | train | val | 2019-10-25T15:18:30 | 2019-01-10T12:16:12Z | LihMeh | train |
mockito/mockito/1815_1818 | mockito/mockito | mockito/mockito/1815 | mockito/mockito/1818 | [
"keyword_pr_to_issue"
] | 68bc593ebb79efa515a211f8cdff77c7c3746a6a | 9603fb28158de0fb519611d58e931bf7b4bbc33c | [
"That would makes sense to me. Feel free to open a PR to add these methods.\r\n\r\n@mockito/developers We have a lot of evidence of `long`s being misused in common API's. Do you have any concerns if we deprecate the `after(long)` in favor of `after(java.time.Duration)` (and the same for `timeout`)?",
"Ideally we'... | [
"This example is for the `timeout(Duration)` method. I think we should revert the sample in this method, but add an additional sentence above that this is discouraged and `Duration.ofMillis` should be used instead.",
"Same as above.",
"Would it make sense to change this comparison to the relevant `Duration` me... | 2019-11-06T14:33:31Z | [] | FR: add Mockito.timeout(java.time.Duration) and after(java.time.Duration) | Representing durations as `long`'s is very error prone. We've seen (and fixed) hundreds of unit mismatch bugs inside of Google.
We (Guava) have recently updated most of our public APIs to add `java.time.Duration`-based overloads. [Caffeine](https://github.com/ben-manes/caffeine/issues/221) and [Selenium](https://git... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/util/Timer.java",
"src/main/java/org/mockito/internal/verification/VerificationOverTimeImpl.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapper... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/util/Timer.java",
"src/main/java/org/mockito/internal/verification/VerificationOverTimeImpl.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapper... | [
"src/test/java/org/mockito/internal/util/TimerTest.java",
"src/test/java/org/mockito/internal/verification/VerificationOverTimeImplTest.java",
"src/test/java/org/mockito/verification/TimeoutTest.java",
"src/test/java/org/mockitousage/verification/VerificationWithTimeoutTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index af1ceb22e9..aea283881e 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -4,6 +4,8 @@
*/
package org.mockito;
+import java.time.Duration;
+
import org.mockito.except... | diff --git a/src/test/java/org/mockito/internal/util/TimerTest.java b/src/test/java/org/mockito/internal/util/TimerTest.java
index 8a4a173e02..2f2885b0da 100644
--- a/src/test/java/org/mockito/internal/util/TimerTest.java
+++ b/src/test/java/org/mockito/internal/util/TimerTest.java
@@ -4,6 +4,8 @@
*/
package org.moc... | train | val | 2019-11-06T11:59:06 | 2019-11-06T01:27:23Z | kluever | train |
mockito/mockito/1827_1828 | mockito/mockito | mockito/mockito/1827 | mockito/mockito/1828 | [
"keyword_pr_to_issue"
] | d6cec3963eb37db6eb025c490136e277b75cc269 | 3dd936c7834a396f3676c2d07772e43b11578b87 | [
"We had same issues with Java 13. I just overrode Mockito Byte Buddy dependency to a newer version (1.10.3), and it solved inline mock failures in our tests.\r\n\r\nSubmitted the upgrade in Mockito itself: #1828",
"Please do not mock Inputstream, but create a real example with fake data instead. That said, we wil... | [] | 2019-11-26T18:57:00Z | [] | Cannot mock this class: class java.io.InputStream with Java 13 | ## Versions
* Mockito: 3.1.0
* JDK: 13.0.1+9
* OS: macOS 10.13
* XCode: 10.1-19
## Code causing the error
```
InputStream in = mock(InputStream.class);
```
## Error:
```
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.015 s <<< FAILURE! - in uk.gov.nationalarchives.droid.core.in... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 79cc490052..0e6b448762 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.10.2'
+versions.bytebuddy = '1.10.3'
versions.junitJupiter = '5.4.2'
version... | null | train | val | 2019-11-20T13:42:42 | 2019-11-24T10:28:30Z | adamretter | train |
mockito/mockito/1839_1840 | mockito/mockito | mockito/mockito/1839 | mockito/mockito/1840 | [
"keyword_pr_to_issue"
] | 186a966054aa933b5ea9463ae908aa963107ffa7 | ae8117f6b72350788f429168292bafe13e231e04 | [] | [
"Same as on the website PR, let's keep this `mockito-development` and fix the bug in Shipkit instead.",
"OK, I've reverted that change. Sadly, it means that #1839 is not going to be fully fixed by this PR. At least \"Download\" would become \"Bintray\", so that users won't expect it to the **the** download link."... | 2019-12-05T20:56:36Z | [] | Bintray badge is out of date | The badges in README.md show:
```
maven-central 3.2.0 Download 3.1.13
```
That makes the project looks sloppy, as if the developers forgot to update their downloads. "Download" is actually a link to Bintray, which should be clarified.
Bintray does have version 3.2.0. The old version is shown because the package ... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index 8d03229ad3..a69f94874a 100644
--- a/README.md
+++ b/README.md
@@ -6,12 +6,14 @@
Most popular mocking framework for Java
-[](https://travis-ci.org/mockito/mockito) [![Coverage Status](https://img.sh... | null | train | val | 2019-11-29T17:19:01 | 2019-12-05T20:50:59Z | proski | train |
mockito/mockito/1841_1842 | mockito/mockito | mockito/mockito/1841 | mockito/mockito/1842 | [
"keyword_pr_to_issue"
] | 49c3b4ffd25f574cbd64a2f85b9ea4b9bfbfe623 | fe1141bcea74838fc1a5c1867ec932f180b8eb45 | [] | [] | 2019-12-11T20:12:44Z | [] | Update byte-buddy to 1.10.5 | Hi,
Byte-buddy had a bug that prevented running tests in IntelliJ due to space in the executable name: https://github.com/raphw/byte-buddy/issues/732 This was fixed in [1.10.5](https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.10.5) so it would make sense to update it in Mockito as well. | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 0e6b448762..cebf8058cb 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.10.3'
+versions.bytebuddy = '1.10.5'
versions.junitJupiter = '5.4.2'
version... | null | train | val | 2019-12-07T18:57:47 | 2019-12-11T20:10:38Z | villesau | train |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.