instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
mockito/mockito/1846_1847 | mockito/mockito | mockito/mockito/1846 | mockito/mockito/1847 | [
"keyword_pr_to_issue"
] | 204f9c169aa81f613334dc4301e0a062627565a5 | ce1632ddd6c55a7e85bec606536aa582a3b3aea1 | [
"Nice catch! I'll review the PR!",
"Hey @mockitoguy @andreisilviudragnea, I think this PR has introduced a new bug (or a regression if you like).\r\n\r\nThe problem arises when using Deep Stubs, as every call in a deep stub counts as used stubbing, but if you end up stubbing that mock for real this change will ch... | [
"Testing for arguments won't work in all cases, just use ```s.matches(invocation)```",
"There is no need to search for stubbed invocation this way. You can grab it from ```this.invocationForStubbing.getInvocation()```.",
"This is good work! We can pass null to \"reset\" the stubbing state. Do you mind updating ... | 2019-12-16T22:42:05Z | [] | Broken unused stubbing reporting when matching previous stubbed call | When stubbing the same method call twice, and the second stub setup matches to first stubbed call, the first stub is not reported as unused, because Mockito detects the next stub setup as a usage of the previous stub setup. This is an example test:
```
public class UnnecessaryStubbingWithImplicitEqMatchers {
@Mo... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/Pluralizer.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/StubbedInvocationMatcher.java",
"src/main/java/org/mockito/i... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/Pluralizer.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/StubbedInvocationMatcher.java",
"src/main/java/org/mockito/i... | [
"src/test/java/org/mockito/internal/reporting/PluralizerTest.java",
"src/test/java/org/mockitousage/junitrule/StrictJUnitRuleTest.java",
"src/test/java/org/mockitousage/junitrunner/UnusedStubsExceptionMessageTest.java",
"src/test/java/org/mockitousage/stubbing/StrictStubbingTest.java"
] | diff --git a/src/main/java/org/mockito/internal/exceptions/Reporter.java b/src/main/java/org/mockito/internal/exceptions/Reporter.java
index f661b81e5c..ab94fd1551 100644
--- a/src/main/java/org/mockito/internal/exceptions/Reporter.java
+++ b/src/main/java/org/mockito/internal/exceptions/Reporter.java
@@ -5,6 +5,7 @@
... | diff --git a/src/test/java/org/mockito/internal/reporting/PluralizerTest.java b/src/test/java/org/mockito/internal/reporting/PluralizerTest.java
index c1be4382c1..3e9a2fc28f 100644
--- a/src/test/java/org/mockito/internal/reporting/PluralizerTest.java
+++ b/src/test/java/org/mockito/internal/reporting/PluralizerTest.ja... | train | val | 2019-12-16T13:23:04 | 2019-12-16T22:36:01Z | andreisilviudragnea | train |
mockito/mockito/1880_1881 | mockito/mockito | mockito/mockito/1880 | mockito/mockito/1881 | [
"keyword_pr_to_issue"
] | 434556a4bd4bb288bf7d12fd4d21ce3a244ce4ba | 06b131f7aca0ec1d7f20f1b4ed767936ad440362 | [
"Could you send us a PR to fix this?",
"Wouldn't it be easier if you just added the missing `</code>` and `of`? It's just two words.",
"Yeah, if you could open a PR to make that change we can fix it 😄 ",
"Closed due to too complicated workflow.",
"Let's reopen so that someone else can make the PR."
] | [] | 2020-02-28T22:12:07Z | [
"please contribute"
] | Unbalanced HTML tags in Javadoc of UnnecessaryStubbingException | In the [Javadoc of that class](https://javadoc.io/static/org.mockito/mockito-core/3.3.1/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html), the `<code` is not closed properly. Because of this, the following paragraphs are rendered in monospace font as well.
While here, `effect not` should be `effect ... | [
"src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java"
] | [
"src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java"
] | [] | diff --git a/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java b/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java
index 2d4605b4f6..6078437038 100644
--- a/src/main/java/org/mockito/exceptions/misusing/UnnecessaryStubbingException.java
+++ b/src/main/java/org... | null | test | val | 2020-02-26T23:18:27 | 2020-02-28T09:10:09Z | rillig-tk | train |
mockito/mockito/1875_1890 | mockito/mockito | mockito/mockito/1875 | mockito/mockito/1890 | [
"keyword_pr_to_issue"
] | 560adf377677a4a2c658a0b24e2f9c2e0b373c20 | 5b63b6fa0d5649a6552ebd75a7113206ad863e03 | [
"Hello, I've taken a look at the issue and it is still apparent in commit 560adf377677a4a2c658a0b24e2f9c2e0b373c20. It appears to be that `thenThrow(Class)` instantiates the Throwable when it is called rather than instantiating it upon mock interaction.\r\n\r\n### Background\r\nTo why this leads to the behaviour de... | [
"Instead of `expected = `, use `assertThrows` and assert on the exception that it is of the correct exception class and it has the correct message.",
"Let's name this `ThrowsExceptionForClassType` to make it clear we are passing in the `.class` itself.",
"The change has been done. The class, references and asso... | 2020-03-20T17:12:48Z | [
"please contribute"
] | thenThrow(Class) no longer creates new instances | As of #1162, `thenThrow(Class)` no longer creates new instances for each invocation. We had tests that were reliant on that behavior; for example:
```
@Test
public void thenThrow() {
Supplier<Object> r = mock(Supplier.class);
when(r.get()).thenThrow(RuntimeException.class);
RuntimeException first = null;... | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java"
] | [
"src/main/java/org/mockito/internal/stubbing/BaseStubbing.java",
"src/main/java/org/mockito/internal/stubbing/StubberImpl.java",
"src/main/java/org/mockito/internal/stubbing/answers/AbstractThrowsException.java",
"src/main/java/org/mockito/internal/stubbing/answers/ThrowsException.java",
"src/main/java/org/... | [
"src/test/java/org/mockito/internal/stubbing/answers/AbstractThrowsExceptionTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionForClassTypeTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/ThrowsExceptionTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingW... | diff --git a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
index 73dab853d5..b3bd074428 100644
--- a/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
+++ b/src/main/java/org/mockito/internal/stubbing/BaseStubbing.java
@@ -7,11 ... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/AbstractThrowsExceptionTest.java b/src/test/java/org/mockito/internal/stubbing/answers/AbstractThrowsExceptionTest.java
new file mode 100644
index 0000000000..8fa4d86f58
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/answers/AbstractThrow... | train | val | 2020-03-13T14:59:53 | 2020-02-19T15:59:36Z | brettkail-wk | train |
mockito/mockito/1891_1892 | mockito/mockito | mockito/mockito/1891 | mockito/mockito/1892 | [
"keyword_pr_to_issue"
] | 872358c810a7e750cccac6a6614b3191269732db | ab4bd0c533977497697ac4ab629f301c66596ffc | [
"Feel free to open a PR and we can take a look 😄 "
] | [
"Nit: Use full Java block comments (e.g. lines starting with `*`)",
"Nit: change this link to https://github.com/gradle/gradle/blob/58538513a3bff3b7015718976fe1304e23f40694/subprojects/core/src/main/java/org/gradle/api/internal/file/archive/ZipCopyAction.java#L42-L57",
"This runs the tests as well, which is not... | 2020-03-22T23:38:23Z | [] | Build is not reproducible | Repeated subsequent builds of the project create outputs which are not byte-for-byte identical, and so cannot be reproduced locally (see: [Reproducible Builds](https://reproducible-builds.org/))
This is due to:
* File modification timestamps in JARs.
* Non-deterministic file ordering in JARs.
* OSGi bundle emb... | [
".gitignore",
".travis.yml",
"build.gradle",
"gradle/mockito-core/osgi.gradle"
] | [
".gitignore",
".travis.yml",
"build.gradle",
"gradle/mockito-core/osgi.gradle",
"gradle/mockito-core/reproducible-build.gradle"
] | [] | diff --git a/.gitignore b/.gitignore
index 9d0c115582..09ab494393 100644
--- a/.gitignore
+++ b/.gitignore
@@ -21,3 +21,6 @@ out
classes
.gradletasknamecache
*.log
+
+# Used to check reproducibility of Mockito jars
+checksums/
\ No newline at end of file
diff --git a/.travis.yml b/.travis.yml
index 26c444f3ef..43f61... | null | train | val | 2020-03-23T18:55:58 | 2020-03-22T22:46:59Z | mrwilson | train |
mockito/mockito/1894_1895 | mockito/mockito | mockito/mockito/1894 | mockito/mockito/1895 | [
"keyword_pr_to_issue"
] | ab4bd0c533977497697ac4ab629f301c66596ffc | 4e1ae5155f5e67f5afb1934f95bc8af9283da76b | [
"Could you paste the full build output? You can wrap it in `<details></details>` here on github to prevent a wall of text.\r\n\r\nAlso, feel free to open your PR and happy to take a look.",
"PR created - https://github.com/mockito/mockito/pull/1895 \r\nplease verify on unix\r\n\r\n(there are 2 commits because at ... | [] | 2020-03-24T20:20:22Z | [] | Checkstyle error on windows | Hi, I can't build the project on windows. It ends with error:
<details>
$ ./gradlew clean build --parallel
> Configure project :
Building version '2.28.3' (value loaded from 'version.properties' file).
> Task :deprecatedPluginsTest:checkstyleTest FAILED
> Task :android:checkstyleMain FAILED
> Task :error... | [
"config/checkstyle/checkstyle.xml"
] | [
"config/checkstyle/checkstyle.xml"
] | [
"src/test/java/org/mockitousage/matchers/MatchersTest.java"
] | diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 2a5094bcda..b000ccb311 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -28,7 +28,7 @@
</module>
</module>
<module name="RegexpHeader">
- <property name="headerFile" va... | diff --git a/src/test/java/org/mockitousage/matchers/MatchersTest.java b/src/test/java/org/mockitousage/matchers/MatchersTest.java
index 8c4b45afed..ca3e94de2f 100644
--- a/src/test/java/org/mockitousage/matchers/MatchersTest.java
+++ b/src/test/java/org/mockitousage/matchers/MatchersTest.java
@@ -608,7 +608,7 @@ publi... | train | val | 2020-03-24T15:00:35 | 2020-03-24T19:25:13Z | mikolajczykmarcin | train |
mockito/mockito/1898_1942 | mockito/mockito | mockito/mockito/1898 | mockito/mockito/1942 | [
"keyword_pr_to_issue"
] | 662017026f1cb0a50bc28cb32e4b5806dfbdb552 | 3c10616de9284f13e7f76604dc0d9ecc50ab9877 | [] | [] | 2020-05-31T00:29:41Z | [
"please contribute"
] | RETURNS_DEEP_STUBS override a mock's toString to `null` | This example describes the issue:
```
@Test
public void mocksWithDeepStubsReturnNameOnToString() {
Object proudMock = Mockito.mock(
Object.class,
Mockito.withSettings()
.name("I'm a mock!")
.defaultAnswer(Mockito.RETURNS_DEEP_STUBS));
// fails, toString()... | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java
index 939b8b8f5d..a0c537fe79 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java
+++ b/src/main/java/... | diff --git a/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java b/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
index 3740a28b9d..d1297a059e 100644
--- a/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
+++ b/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
@@ -6,6 +... | train | val | 2020-05-27T09:18:33 | 2020-04-01T22:04:43Z | strulovich | train |
mockito/mockito/1712_1949 | mockito/mockito | mockito/mockito/1712 | mockito/mockito/1949 | [
"keyword_pr_to_issue"
] | 397b4d247c74bd36761007d10f9c36f74d3aa310 | 0ed81f72359b1a0625fa22956d34e54fdfc1d7ce | [
"Not pretty but this seems to work if I use a `VerificationListener` and manually log the error:\r\n\r\n\r\n```\r\nimport static org.mockito.Mockito.description;\r\nimport static org.mockito.Mockito.spy;\r\nimport static org.mockito.Mockito.verify;\r\n\r\nimport org.junit.Test;\r\nimport org.mockito.Mockito;\r\nimp... | [] | 2020-06-16T13:48:30Z | [] | "description" not printing when verify args don't match | Mockito version 2.27.0
I have a test that uses `description` inside a `verify` method. The `description` is correctly printing when the test fails because we don't interact with the mock
```
import static org.mockito.Mockito.description;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.... | [
"src/main/java/org/mockito/exceptions/base/MockitoAssertionError.java",
"src/main/java/org/mockito/internal/verification/Description.java"
] | [
"src/main/java/org/mockito/exceptions/base/MockitoAssertionError.java",
"src/main/java/org/mockito/internal/verification/Description.java"
] | [
"src/test/java/org/mockito/DescriptionTest.java",
"src/test/java/org/mockito/internal/verification/DescriptionTest.java"
] | diff --git a/src/main/java/org/mockito/exceptions/base/MockitoAssertionError.java b/src/main/java/org/mockito/exceptions/base/MockitoAssertionError.java
index a3e046c479..5e463c7288 100644
--- a/src/main/java/org/mockito/exceptions/base/MockitoAssertionError.java
+++ b/src/main/java/org/mockito/exceptions/base/MockitoA... | diff --git a/src/test/java/org/mockito/DescriptionTest.java b/src/test/java/org/mockito/DescriptionTest.java
new file mode 100644
index 0000000000..32565e4b6c
--- /dev/null
+++ b/src/test/java/org/mockito/DescriptionTest.java
@@ -0,0 +1,58 @@
+/*
+ * Copyright (c) 2020 Mockito contributors
+ * This program is made avai... | train | val | 2020-06-19T23:29:16 | 2019-05-18T00:57:54Z | tir38 | train |
mockito/mockito/1972_1973 | mockito/mockito | mockito/mockito/1972 | mockito/mockito/1973 | [
"keyword_pr_to_issue"
] | 05b39bfc5e4558f4c1c6853d5b454f534bdfefe0 | eda22b7c8b4e2d6611d87f3c8f72f18c51bb2ed8 | [
"Feel free to open a PR with the version bump 😄 "
] | [] | 2020-07-15T10:50:01Z | [
"please contribute"
] | Update dependency to byte buddy version 1.10.13 | https://github.com/mockito/mockito/blob/release/3.x/gradle/dependencies.gradle#L7
1.10.13 is available: https://github.com/raphw/byte-buddy/releases/tag/byte-buddy-1.10.13 | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index bda27edc28..2de0a0008d 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.10.10'
+versions.bytebuddy = '1.10.13'
versions.junitJupiter = '5.4.2'
versi... | null | test | val | 2020-07-10T21:38:11 | 2020-07-15T10:38:43Z | mickroll | train |
mockito/mockito/1855_1974 | mockito/mockito | mockito/mockito/1855 | mockito/mockito/1974 | [
"keyword_pr_to_issue"
] | cbabc53c2202a8ecc93dfa86f1405463181c2bdf | 6b09281bd11221fc4df60306b6b0919dac863097 | [
"I think this commit is part of the problem: https://github.com/mockito/mockito/pull/1567/files",
"> I think this commit is part of the problem: https://github.com/mockito/mockito/pull/1567/files\r\n\r\nI tried with mockito 2.22.0, which should be a release before the commit, but the error is still there. https:... | [] | 2020-07-16T18:45:36Z | [
"please contribute"
] | javax.tools.ToolProvider could not be found in InlineByteBuddyMockMaker | Hi guys
I'm encountering a crash when I run `AndroidTest` that contain mocking class cause the ByteBuddy didn't found `javax.tools.ToolProvider`. I tried to reinstall JDK 8 but doesn't work. It seems to be `javax.tools.ToolProvider` not existing in it.
Could you guys help me please?
Cheer,
Natthawut
## ... | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java"
] | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMaker.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java b/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
index 2f6667015c..59239a4674 100644
--- a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
+++ b/src/main/java/org... | null | train | val | 2020-07-17T13:49:56 | 2020-01-07T05:52:55Z | nuxzero | train |
mockito/mockito/1985_1986 | mockito/mockito | mockito/mockito/1985 | mockito/mockito/1986 | [
"keyword_pr_to_issue"
] | c53f9b39243ac563cd40c774358fb0f7d4f2da83 | 0c56b3a8da97fa5ccfeef2adaa0a2314db3d6bd0 | [
"Feel free to open a PR :)"
] | [] | 2020-07-20T12:46:13Z | [
"please contribute"
] | README should refer the latest available documentation | **Actual:**
README contains link `latest documentation`
http://javadoc.io/page/org.mockito/mockito-core/2/org/mockito/Mockito.html
which redirects to
https://javadoc.io/static/org.mockito/mockito-core/2.9.0/org/mockito/Mockito.html
(Note: version is `2.9.0`)
**Expected:**
The link `latest documentation` sh... | [
"README.md"
] | [
"README.md"
] | [] | diff --git a/README.md b/README.md
index a69f94874a..12b36459aa 100644
--- a/README.md
+++ b/README.md
@@ -27,7 +27,7 @@ The maintainers of org.mockito:mockito-core and thousands of other packages are
## Development
-Mockito [continuously delivers](https://github.com/mockito/mockito/wiki/Continuous-Delivery-Overvi... | null | train | val | 2020-07-20T08:53:30 | 2020-07-20T12:42:32Z | valfirst | train |
mockito/mockito/1992_1998 | mockito/mockito | mockito/mockito/1992 | mockito/mockito/1998 | [
"keyword_pr_to_issue"
] | b87fad310bf59b94035028dc478089ded2a9198a | 32684d1acd6df8f1d143827a16ef5de5e4dc4d6a | [
"I would be happy to review a PR that updates our version of Objenesis 😄 ",
"I'll check the contribution guide, though I can't promise much. So far Java 11 compile is not top priority in my team."
] | [] | 2020-08-09T09:50:17Z | [
"please contribute"
] | Update to org.objenesis 3.x | Hi all,
we are slowly updating our product to Java 11; we've managed to move to Java 11 runtime, now we are trying to also compile with Java 11.
We ran into a problem with `org.easymock` (it doesn't work with Java 11 compiled classes, https://github.com/easymock/easymock/issues/218). The problem is resolved in 4.... | [
"gradle/dependencies.gradle",
"gradle/mockito-core/osgi.gradle"
] | [
"gradle/dependencies.gradle",
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index d089c4d73d..9ae3679927 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -25,8 +25,7 @@ libraries.errorproneTestApi = "com.google.errorprone:error_prone_test_helpers:${
libraries.autoservice = "com.google.auto.servic... | null | train | val | 2020-08-05T22:12:27 | 2020-08-07T14:57:09Z | trancexpress | train |
mockito/mockito/2011_2023 | mockito/mockito | mockito/mockito/2011 | mockito/mockito/2023 | [
"keyword_pr_to_issue"
] | 929840ab691b2f502b9958ac9483104bfd88a9ee | f31ba850384fa789278e11aea41efc3b1c877a48 | [
"I just discovered that the error happens when I launch all my unit tests in the Maven module, but it's fine if I run the test or the test class only.\r\n\r\n```sh\r\n$ cd myproject/my-mvn-module-1\r\n$ mvn test\r\n#\r\n# [ERROR] MyBeanTest.test1 » StackOverflow\r\n#\r\n$ mvn -Dtest=MyBeanTest test\r\n# \r\n# Tes... | [] | 2020-08-25T22:10:20Z | [] | Stackoverflow error when upgrading to v3.5.2 | I tried to upgrade from Mockito v3.4.6 to v3.5.2 and I'm getting a stackoverflow error (same error with v3.5.0) when running some tests (not all of them, just a few ; even in the same class : some tests pass and others don't).
Stacktrace :
```
java.lang.StackOverflowError
at java.base/java.lang.ThreadLocal.get(T... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"subprojects/inline/src/test/java/org/mockitoinline/InitializationTest.java",
"subprojects/inline/src/test/java/org/mockitoinline/PluginTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
index 409f58201c..067dea7a04 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
+++ b/src/main... | diff --git a/subprojects/inline/src/test/java/org/mockitoinline/InitializationTest.java b/subprojects/inline/src/test/java/org/mockitoinline/InitializationTest.java
new file mode 100644
index 0000000000..c4f62f400f
--- /dev/null
+++ b/subprojects/inline/src/test/java/org/mockitoinline/InitializationTest.java
@@ -0,0 +1... | train | val | 2020-08-25T00:21:12 | 2020-08-20T11:42:48Z | jdussouillez | train |
mockito/mockito/2007_2024 | mockito/mockito | mockito/mockito/2007 | mockito/mockito/2024 | [
"keyword_pr_to_issue"
] | 8007df7a25d6c59eb561c1f6023d724d3b3c167f | 626d4573c702625611d2024463bae606a4e8cca4 | [
"Should be fixed with #2006",
"We still have issues with 3.5.2. We are unable to update to new version and use `assembleAndroidTest` task.\r\n\r\n```\r\n/usr/local/gradle/caches/transforms-2/files-2.1/225c46d0e9f10ff5ef3f4d9a009c4924/jetified-objenesis-3.1.jar: D8: MethodHandle.invoke and MethodHandle.invokeExact... | [
"Can we make this version `[2.6, 3.0[`, so that we also allow all Objenesis 2.x versions?",
"```suggestion\r\n 'Objenesis 3.x does not work with android api 25 and below.\\n' +\r\n 'If you have mockito-android or mockito-kotlin, exclude mockito-core from them.\\n' +\r\n ... | 2020-08-26T17:05:23Z | [
"android",
"please contribute"
] | Android instrumentation test packaging fails for mockito-android 3.5.0 with minSdk < 26 | We've upgraded from `mockito-android:3.4.6` to `mockito-android:3.5.0`. I'm attempting to package up my instrumented tests by running the `assembleAndroidTest` gradle task. The task fails with the following errors:
```
/Users/<me>/.gradle/caches/transforms-2/files-2.1/fb7959dc5bfc8ebb26ad0660efa1929e/jetified-mockito... | [
"build.gradle",
"gradle/dependencies.gradle",
"subprojects/android/android.gradle"
] | [
"build.gradle",
"gradle/dependencies.gradle",
"subprojects/android/android.gradle"
] | [
"subprojects/osgi-test/osgi-test.gradle"
] | diff --git a/build.gradle b/build.gradle
index 217f71d4b2..e30ddb1a5a 100644
--- a/build.gradle
+++ b/build.gradle
@@ -88,7 +88,7 @@ dependencies {
compile libraries.bytebuddy, libraries.bytebuddyagent
compileOnly libraries.junit4, libraries.hamcrest, libraries.opentest4j
- compile libraries.objenesis
+ ... | diff --git a/subprojects/osgi-test/osgi-test.gradle b/subprojects/osgi-test/osgi-test.gradle
index 8ebcc042f3..ad5964c543 100644
--- a/subprojects/osgi-test/osgi-test.gradle
+++ b/subprojects/osgi-test/osgi-test.gradle
@@ -23,7 +23,7 @@ configurations {
dependencies {
testRuntimeBundles project.rootProject
t... | train | val | 2020-08-26T00:39:16 | 2020-08-18T00:37:46Z | DeuceTheCoder | train |
mockito/mockito/1980_2042 | mockito/mockito | mockito/mockito/1980 | mockito/mockito/2042 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 5a664cfd68bd50d3f3447ce44879d60045b199ec | e098342c3cfad32a8b183593aa6719fb66b72674 | [
"In this case, the mock is not registered correctly. Mockito has no knowledge of Spring and could not do much about this. Have you adressed this issue with Spring? How do you get hold of this proxied instance?",
"``` java\r\n@SpringBootTest\r\n@RunWith(SpringJUnit4ClassRunner.class)\r\n@AutoConfigureMockMvc\r\npu... | [
"Nit: extract this out in a private method and use that below as well.",
"Can we add a test that uses multiple resolvers? I can think of the following scenarios:\r\n\r\n1. Multiple resolvers, no match\r\n2. Multiple resolvers, one match\r\n3. Multiple resolvers, multiple match\r\n\r\nFor scenario 3, should we thr... | 2020-09-14T20:12:59Z | [
"awaiting response"
] | mockito3.4.0 InlineByteBuddyMockMaker can't work with spring cglib proxy, but ByteBuddyMockMaker works | I upgrade mockito to 3.4.0, and the mockMaker is InlineByteBuddyMockMaker, I use SpyBean to spy a spring bean, and then verify the bean, it throws NotAMockException.
then i debug, find that the mocks.get(m... | [
"src/main/java/org/mockito/internal/configuration/plugins/PluginFinder.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginInitializer.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginLoader.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginRegistr... | [
"src/main/java/org/mockito/internal/configuration/plugins/PluginFinder.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginInitializer.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginLoader.java",
"src/main/java/org/mockito/internal/configuration/plugins/PluginRegistr... | [
"subprojects/extTest/src/test/java/org/mockitousage/plugins/resolver/MockResolverTest.java",
"subprojects/extTest/src/test/java/org/mockitousage/plugins/resolver/MyMockResolver.java",
"subprojects/extTest/src/test/java/org/mockitousage/plugins/switcher/PluginSwitchTest.java",
"subprojects/extTest/src/test/res... | diff --git a/src/main/java/org/mockito/internal/configuration/plugins/PluginFinder.java b/src/main/java/org/mockito/internal/configuration/plugins/PluginFinder.java
index 7385afb184..3ca2ac5cd4 100644
--- a/src/main/java/org/mockito/internal/configuration/plugins/PluginFinder.java
+++ b/src/main/java/org/mockito/intern... | diff --git a/subprojects/extTest/src/test/java/org/mockitousage/plugins/resolver/MockResolverTest.java b/subprojects/extTest/src/test/java/org/mockitousage/plugins/resolver/MockResolverTest.java
new file mode 100644
index 0000000000..bd51fe6dc2
--- /dev/null
+++ b/subprojects/extTest/src/test/java/org/mockitousage/plug... | test | val | 2020-09-17T23:34:18 | 2020-07-17T15:10:00Z | jacky1193610322 | train |
mockito/mockito/1997_2047 | mockito/mockito | mockito/mockito/1997 | mockito/mockito/2047 | [
"keyword_pr_to_issue"
] | 3ef9966abc9f7ead85a5a48640f0bfe952298287 | 240d6e4b8eb3954cdd3285e345c6f8982bb76796 | [
"Fragments can be a bit of a pain.\r\n\r\n@rotty3000 could offer some advice here - he did the OSGi metadata port for the JUnit 5 project itself. They had a similar problem, in that some of the bundles relied on internal packages of other bundles. I think that they ended up exporting the \"internal\" packages, but ... | [
"It's not clear to me why this part was removed and what changed it. Could you please add a comment to the functionality that replaces it to explain why we need it? (E.g. reproducible jars) And could you update your commit message to explain the change that was made.",
"Could you add an example in the comment wha... | 2020-09-17T03:11:56Z | [] | MockitoExtension cannot be used with JUnit 5 in OSGi integration tests | The Mockito junit-jupiter JAR is missing OSGi bundle manifest entries so it cannot be used in OSGi integration tests.
We run some OSGi integration tests (using bnd) that have `@Mock`s so it would be easier if these mocks can be initialized by annotating classes with `@MockitoExtension` instead of using `MockitoAnnot... | [
"gradle/mockito-core/osgi.gradle",
"subprojects/junit-jupiter/junit-jupiter.gradle"
] | [
"gradle/mockito-core/osgi.gradle",
"subprojects/junit-jupiter/junit-jupiter.gradle"
] | [] | diff --git a/gradle/mockito-core/osgi.gradle b/gradle/mockito-core/osgi.gradle
index 2fa0b78354..0c6f395e8b 100644
--- a/gradle/mockito-core/osgi.gradle
+++ b/gradle/mockito-core/osgi.gradle
@@ -1,12 +1,3 @@
-import java.nio.file.attribute.FileTime
-import java.util.jar.Attributes
-import java.util.jar.JarEntry
-import... | null | train | val | 2020-12-17T14:15:55 | 2020-08-08T08:59:25Z | wborn | train |
mockito/mockito/2007_2053 | mockito/mockito | mockito/mockito/2007 | mockito/mockito/2053 | [
"keyword_pr_to_issue"
] | e338d9167cb5a6acb4b3ec5f02bec3eb4769e4ae | 079e847891959a7a3cbb5a8390efa65eba583b7a | [
"Should be fixed with #2006",
"We still have issues with 3.5.2. We are unable to update to new version and use `assembleAndroidTest` task.\r\n\r\n```\r\n/usr/local/gradle/caches/transforms-2/files-2.1/225c46d0e9f10ff5ef3f4d9a009c4924/jetified-objenesis-3.1.jar: D8: MethodHandle.invoke and MethodHandle.invokeExact... | [] | 2020-09-24T12:32:32Z | [
"android",
"please contribute"
] | Android instrumentation test packaging fails for mockito-android 3.5.0 with minSdk < 26 | We've upgraded from `mockito-android:3.4.6` to `mockito-android:3.5.0`. I'm attempting to package up my instrumented tests by running the `assembleAndroidTest` gradle task. The task fails with the following errors:
```
/Users/<me>/.gradle/caches/transforms-2/files-2.1/fb7959dc5bfc8ebb26ad0660efa1929e/jetified-mockito... | [
"subprojects/android/android.gradle"
] | [
"subprojects/android/android.gradle"
] | [] | diff --git a/subprojects/android/android.gradle b/subprojects/android/android.gradle
index bd5a6959a2..508cd7ed05 100644
--- a/subprojects/android/android.gradle
+++ b/subprojects/android/android.gradle
@@ -9,7 +9,7 @@ dependencies {
compile libraries.bytebuddyandroid
compile(libraries.objenesis2) {
... | null | train | val | 2020-09-19T01:53:42 | 2020-08-18T00:37:46Z | DeuceTheCoder | train |
mockito/mockito/2083_2084 | mockito/mockito | mockito/mockito/2083 | mockito/mockito/2084 | [
"keyword_pr_to_issue"
] | caac3535daaeb9370cd25f23694d3d059a72d8d9 | 5570aba3efde807d2c9af4fc8cdc0a1e004a8469 | [
"Seems like we hit this issue after we fixed an initial typo in #2070. Do you mind sending a PR to change it to a capital V?",
"Done, thanks for quick response!"
] | [] | 2020-10-28T21:44:40Z | [] | Issue with Bundle-Version manifest header when used in Eclipse PDE development | The MANIFEST.MF currently contains e.g.: `Bundle-version: 3.6.0`
Due to the lowercase 'v' this appears to not be properly recognised by Eclipse PDE so is giving me errors on min versioned require bundle directives.
The standard headers at https://www.osgi.org/bundle-headers-reference/ define it as `Bundle-Versio... | [
"gradle/mockito-core/osgi.gradle"
] | [
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/gradle/mockito-core/osgi.gradle b/gradle/mockito-core/osgi.gradle
index cdee44287b..f44ea9c18b 100644
--- a/gradle/mockito-core/osgi.gradle
+++ b/gradle/mockito-core/osgi.gradle
@@ -14,7 +14,7 @@ jar {
bnd(
'Bundle-Name': 'Mockito Mock Library for Java. Core bundle requires Byte Buddy and Obj... | null | train | val | 2020-10-27T03:25:33 | 2020-10-28T21:41:43Z | joeshannon | train |
mockito/mockito/2095_2101 | mockito/mockito | mockito/mockito/2095 | mockito/mockito/2101 | [
"keyword_pr_to_issue"
] | 3b09f8e8e0e8aa60039b7f17207a18032d8e7a8f | c0bdf43e11467ca7af2c594dc38c65b2901251c3 | [] | [] | 2020-11-12T16:04:13Z | [
"continuous integration"
] | Implement [ci skip release] in the CI pipeline | Make it possible to skip release when pushing changes to the repo. Our README.md currently documents that we can skip releases by adding "ci skip release" keyword to the commit message.
Reference example: https://github.com/shipkit/shipkit-auto-version/commit/7a8ada573e3d8f183b9101b716a261612db30f87 | [
".github/workflows/ci.yml"
] | [
".github/workflows/ci.yml"
] | [] | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d8a3b831f6..db9a46240d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -1,3 +1,10 @@
+#
+# CI build that assembles artifacts and runs tests.
+# If validation is successful this workflow releases from the main dev branch.
+#
+... | null | train | val | 2020-11-11T18:50:35 | 2020-11-09T16:16:44Z | mockitoguy | train |
mockito/mockito/2097_2103 | mockito/mockito | mockito/mockito/2097 | mockito/mockito/2103 | [
"keyword_pr_to_issue"
] | c0bdf43e11467ca7af2c594dc38c65b2901251c3 | 24cf496bed1bfd313c2ff83cf490bfc62ec4d5a7 | [] | [] | 2020-11-14T05:25:40Z | [
"continuous integration"
] | Consider reducing CI execution footprint | Right now we are running CI for:
- branch pushes
- PRs
This causes redundant builds to be triggered (example, see actions triggered for PR #2096). Redundant builds clutter the UI (reducing dev experience) and may count against our quota of free open source builds. This issue has been discussed on GH before: http... | [
".github/workflows/ci.yml"
] | [
".github/workflows/ci.yml"
] | [] | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index db9a46240d..bf41083077 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -9,7 +9,7 @@ name: CI
on:
push:
- branches: ['**']
+ branches: ['release/3.x']
tags-ignore: [v*] # release tags are automatically generat... | null | train | val | 2020-11-12T17:40:07 | 2020-11-10T16:33:26Z | mockitoguy | train |
mockito/mockito/2108_2109 | mockito/mockito | mockito/mockito/2108 | mockito/mockito/2109 | [
"keyword_pr_to_issue"
] | 78b22fcf814c33e87585afed387cd9db0b6d36a5 | fde5abb9f044a6b614eeb6a8c63d25fffe2df210 | [
"@mockitoguy might be able to provide more insight, but I think we create our Jar on this line: https://github.com/mockito/mockito/blob/78b22fcf814c33e87585afed387cd9db0b6d36a5/gradle/java-publication.gradle#L32\r\n\r\nWe would welcome PRs for this issue. Hopefully the link provides enough context to figure out how... | [] | 2020-11-23T22:41:26Z | [
"please contribute",
"build"
] | JarInputStream fails to get Manifest from published mockito-core | Using mockito-core in a JPMS based gradle build fails due to a known but odd behaviour of JarInputStream. The latter only provides access to the Jar's manifest if it is the 1st or 2nd entry in the Jar. As discussed in:
* https://bugs.openjdk.java.net/browse/JDK-8031748
* https://bugs.openjdk.java.net/browse/JDK-821... | [
"gradle/mockito-core/osgi.gradle"
] | [
"gradle/mockito-core/osgi.gradle"
] | [] | diff --git a/gradle/mockito-core/osgi.gradle b/gradle/mockito-core/osgi.gradle
index f44ea9c18b..2fa0b78354 100644
--- a/gradle/mockito-core/osgi.gradle
+++ b/gradle/mockito-core/osgi.gradle
@@ -71,7 +71,8 @@ class RemoveOsgiLastModifiedHeader {
this.artifact
.entries()
- ... | null | test | val | 2020-11-21T16:56:55 | 2020-11-23T21:37:49Z | hdecarne | train |
mockito/mockito/2110_2111 | mockito/mockito | mockito/mockito/2110 | mockito/mockito/2111 | [
"keyword_pr_to_issue"
] | fde5abb9f044a6b614eeb6a8c63d25fffe2df210 | 98abe38177afc38c102bc8a6cb45bfbcf233272c | [
"on it",
"Should work now and there is a version in maven central: https://bintray.com/mockito/maven/mockito/3.6.28#central"
] | [] | 2020-11-25T02:51:06Z | [
"bug",
"continuous integration"
] | Release process misses commit message tag | https://github.com/mockito/mockito/runs/1447478222#step:4:168
https://github.com/mockito/mockito/commit/fde5abb9f044a6b614eeb6a8c63d25fffe2df210 did contain `[ci maven-central-release]` and therefore should have published. | [
".github/workflows/ci.yml",
"gradle/shipkit.gradle"
] | [
".github/workflows/ci.yml",
"gradle/shipkit.gradle"
] | [] | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index b67cd75e35..236a08feab 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -91,5 +91,6 @@ jobs:
- name: Build and publish
run: ./gradlew bintrayUpload githubRelease --scan
env:
+ MAVEN_CENTRAL_RELEASE: $... | null | val | val | 2020-11-24T12:43:23 | 2020-11-24T14:12:09Z | TimvdLippe | train |
mockito/mockito/2159_2160 | mockito/mockito | mockito/mockito/2159 | mockito/mockito/2160 | [
"keyword_pr_to_issue"
] | a6b0e7cfa4b6045c7c216af038ca394fd6c950a3 | 9126184434294d9091f259f2e9b68a9e10bc65ae | [] | [] | 2020-12-30T19:30:16Z | [] | Mockito published maven artifact is missing .module files | Around Gradle 5.3 new Gradle metadata was introduced (see https://docs.gradle.org/current/userguide/publishing_gradle_module_metadata.html) This allows Gradle builds to publish more detail about dependencies than the lagacy maven pom.
Mockito is generating those files, but they aren't getting uploaded to Maven Centr... | [
"gradle/java-publication.gradle"
] | [
"gradle/java-publication.gradle"
] | [] | diff --git a/gradle/java-publication.gradle b/gradle/java-publication.gradle
index e7e03d444c..9fa7d62a5c 100644
--- a/gradle/java-publication.gradle
+++ b/gradle/java-publication.gradle
@@ -25,6 +25,10 @@ artifacts {
archives javadocJar
}
+tasks.withType(GenerateModuleMetadata) {
+ enabled = false
+}
+
//G... | null | train | val | 2020-12-21T09:15:54 | 2020-12-30T17:25:32Z | checketts | train |
mockito/mockito/2173_2179 | mockito/mockito | mockito/mockito/2173 | mockito/mockito/2179 | [
"keyword_pr_to_issue"
] | 79f06bae95074c7c6d8ce862db100ab74edddf6e | 7b940bcead5240bd030bbe7acbb51c10be0a452b | [
"No, this might be a simple oversight. @raphw I think we can reverse the order? We would need to add an overload and then deprecate the existing one, which we can delete in Mockito 4.0.0.",
"No, I don't think I had an intention with the order, possibly to have the lambda last what often works better with language... | [] | 2021-01-16T10:04:39Z | [
"please contribute"
] | Feature request: Unify order of parameters | Hello,
I just stumbled accross the switched order of the VerificationMode parameter
org.mockito.Mockito.verify(T, VerificationMode)
vs
org.mockito.MockedStatic.verify(VerificationMode, Verification)
Is there a reason, the VerificationMode from MockitoStatic is at first position? | [
"src/main/java/org/mockito/MockedStatic.java",
"src/main/java/org/mockito/internal/MockedStaticImpl.java"
] | [
"src/main/java/org/mockito/MockedStatic.java",
"src/main/java/org/mockito/internal/MockedStaticImpl.java"
] | [] | diff --git a/src/main/java/org/mockito/MockedStatic.java b/src/main/java/org/mockito/MockedStatic.java
index ac291ba33c..b1089cdbf0 100644
--- a/src/main/java/org/mockito/MockedStatic.java
+++ b/src/main/java/org/mockito/MockedStatic.java
@@ -35,14 +35,21 @@ public interface MockedStatic<T> extends ScopedMock {
*... | null | test | val | 2021-01-15T13:08:26 | 2021-01-12T14:26:35Z | bohni | train |
mockito/mockito/2154_2193 | mockito/mockito | mockito/mockito/2154 | mockito/mockito/2193 | [
"keyword_pr_to_issue"
] | fbe50583ad5e66087be58d0a8ad28a079ffc72d6 | 8a19d46c19fc00c56bfcaa01274bb2195d9ac6fe | [
"The release diff (https://github.com/mockito/mockito/compare/v3.6.0...v3.6.28) points to #2098 most likely. Can you do a bisect to figure out if that is indeed the problematic PR?",
"Possibly related and maybe helpful in diagnosing is that attempting to work around this issue by adding an explicit stub for `toSt... | [] | 2021-02-01T13:00:21Z | [
"please contribute"
] | `toString()` seems to be broken on 3.6.28 | Hi guys, I think the `toString()` method was broken recently, I have a test for mockito-scala that checks a mock `toString` invocation returns its name, but if I try to update to said version it returns the standard `Object` implementation of `toString`.
I tried with the "pure" Java API of Mockito and the same thing... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
index 5fc47cd7cb..7db8afe97f 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineBytecodeGenerator.java
+++ b/src/main... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java
index bfc16b4d15..dfa6d8192f 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineByteBuddyMockMakerTest.java... | test | test | 2021-01-27T20:35:37 | 2020-12-23T19:39:33Z | ultrasecreth | train |
mockito/mockito/2212_2213 | mockito/mockito | mockito/mockito/2212 | mockito/mockito/2213 | [
"keyword_pr_to_issue"
] | 84774556217c23472e54ff9ffe32bc041a40426d | 900552416c42a494c564a314a34072afc3cc0502 | [
"Sadly we can't guarantee yet that Mockito fully works on JDK 17, given that Gradle doesn't support JDK 16+ (https://github.com/mockito/mockito/pull/2211#issuecomment-782884920) That said, I can publish a new release to Maven Central this week, which seems appropriate regardless of JDK 17 support."
] | [] | 2021-02-22T18:46:04Z | [] | Please do a release, as we want to use mockito on jdk 17. | Hi.
I'm tracking why commons-io will fail ci on JDK17.
After tracking I finally found out the latest mockito relase use ASM 9.0 which cannot handle jdk 17.
As you are using 9.1 now, who can handle JDK17, I hope we can get it a release...
Thanks!
https://github.com/xenoamess-fork/commons-io/runs/1945142044
chec... | [
"version.properties"
] | [
"version.properties"
] | [] | diff --git a/version.properties b/version.properties
index 84772019f6..032fc68655 100644
--- a/version.properties
+++ b/version.properties
@@ -1,2 +1,2 @@
# Used by Shipkit Auto Version Gradle plugin: https://github.com/shipkit/shipkit-auto-version
-version=3.7.*
+version=3.8.*
| null | train | test | 2021-02-15T20:23:25 | 2021-02-21T13:00:11Z | XenoAmess | train |
mockito/mockito/2007_2249 | mockito/mockito | mockito/mockito/2007 | mockito/mockito/2249 | [
"keyword_pr_to_issue"
] | c5be5c3144af9198acf3f33190c0f45718627a2f | ec341883c673c2edbd3213f18b99ee64b3d3a612 | [
"Should be fixed with #2006",
"We still have issues with 3.5.2. We are unable to update to new version and use `assembleAndroidTest` task.\r\n\r\n```\r\n/usr/local/gradle/caches/transforms-2/files-2.1/225c46d0e9f10ff5ef3f4d9a009c4924/jetified-objenesis-3.1.jar: D8: MethodHandle.invoke and MethodHandle.invokeExact... | [] | 2021-03-31T14:53:06Z | [
"android",
"please contribute"
] | Android instrumentation test packaging fails for mockito-android 3.5.0 with minSdk < 26 | We've upgraded from `mockito-android:3.4.6` to `mockito-android:3.5.0`. I'm attempting to package up my instrumented tests by running the `assembleAndroidTest` gradle task. The task fails with the following errors:
```
/Users/<me>/.gradle/caches/transforms-2/files-2.1/fb7959dc5bfc8ebb26ad0660efa1929e/jetified-mockito... | [
"build.gradle",
"gradle/dependencies.gradle",
"subprojects/android/android.gradle"
] | [
"build.gradle",
"gradle/dependencies.gradle",
"subprojects/android/android.gradle"
] | [
"subprojects/osgi-test/osgi-test.gradle"
] | diff --git a/build.gradle b/build.gradle
index b9637fd2f1..caafccfae5 100644
--- a/build.gradle
+++ b/build.gradle
@@ -84,7 +84,7 @@ dependencies {
compile libraries.bytebuddy, libraries.bytebuddyagent
compileOnly libraries.junit4, libraries.hamcrest, libraries.opentest4j
- compile libraries.objenesis3
+... | diff --git a/subprojects/osgi-test/osgi-test.gradle b/subprojects/osgi-test/osgi-test.gradle
index ad5964c543..8ebcc042f3 100644
--- a/subprojects/osgi-test/osgi-test.gradle
+++ b/subprojects/osgi-test/osgi-test.gradle
@@ -23,7 +23,7 @@ configurations {
dependencies {
testRuntimeBundles project.rootProject
t... | train | test | 2021-03-29T22:47:13 | 2020-08-18T00:37:46Z | DeuceTheCoder | train |
mockito/mockito/2242_2263 | mockito/mockito | mockito/mockito/2242 | mockito/mockito/2263 | [
"keyword_pr_to_issue"
] | 52d38f1f0b4d7d03d718eeab9c92ef3bd0afe4f8 | 2fa2a635e63c3a2f3010b73d6416506d56e0e614 | [
"PRs welcome 😄 "
] | [] | 2021-04-09T18:39:54Z | [
"please contribute"
] | InOrder.verify with non-mock should perhaps give standard non-mock warning | Minor, but I noticed today when I accidentally passed in a non-mock to an `InOrder.verify` call that it warned me that it can only verify mocks that were passed in during creation of `InOrder`. While correct, it seems like perhaps using the standard "non-mock" warning would be more helpful as it has better hinting for... | [
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"src/test/java/org/mockitousage/verification/BasicVerificationInOrderTest.java"
] | diff --git a/src/main/java/org/mockito/internal/InOrderImpl.java b/src/main/java/org/mockito/internal/InOrderImpl.java
index 15e861b9f2..db55c62396 100644
--- a/src/main/java/org/mockito/internal/InOrderImpl.java
+++ b/src/main/java/org/mockito/internal/InOrderImpl.java
@@ -4,12 +4,11 @@
*/
package org.mockito.inter... | diff --git a/src/test/java/org/mockitousage/verification/BasicVerificationInOrderTest.java b/src/test/java/org/mockitousage/verification/BasicVerificationInOrderTest.java
index 834af414c7..f424fab706 100644
--- a/src/test/java/org/mockitousage/verification/BasicVerificationInOrderTest.java
+++ b/src/test/java/org/mocki... | train | test | 2021-04-08T14:46:23 | 2021-03-25T21:06:49Z | mjustin | train |
mockito/mockito/2266_2267 | mockito/mockito | mockito/mockito/2266 | mockito/mockito/2267 | [
"keyword_pr_to_issue"
] | 2fa2a635e63c3a2f3010b73d6416506d56e0e614 | 09df1111e3b5a5ebdae658f376461103e4ad889e | [] | [] | 2021-04-14T01:46:02Z | [] | Swallowed illegal access exceptions make it harder to debug modularity-related issues | ### Issue Summary
In FieldReader and ReflectionMemberAccessor, if an IllegalAccessException is thrown, it will be suppressed.
At the very least, Mockito should include the original exception. When testing a modular application, it is common to have packages encapsulated by default.
### Stacktrace
In FieldRe... | [
"src/main/java/org/mockito/internal/util/reflection/FieldReader.java"
] | [
"src/main/java/org/mockito/internal/util/reflection/FieldReader.java"
] | [
"subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleAccessTest.java",
"subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleUtil.java"
] | diff --git a/src/main/java/org/mockito/internal/util/reflection/FieldReader.java b/src/main/java/org/mockito/internal/util/reflection/FieldReader.java
index e202c714a0..6c3c120ee9 100644
--- a/src/main/java/org/mockito/internal/util/reflection/FieldReader.java
+++ b/src/main/java/org/mockito/internal/util/reflection/Fi... | diff --git a/subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleAccessTest.java b/subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleAccessTest.java
index 6382a253b8..55923e77b5 100644
--- a/subprojects/module-test/src/test/java/org/mockito/moduletest/ModuleAccessTest.java
+++ b/subproje... | val | test | 2021-04-12T12:30:06 | 2021-04-14T01:32:32Z | A248 | train |
mockito/mockito/2273_2274 | mockito/mockito | mockito/mockito/2273 | mockito/mockito/2274 | [
"keyword_pr_to_issue"
] | c86fe047d557bd2ec364d59a99430792f3920e96 | 823e4ff90ddf76732656179a3ca834291410e482 | [] | [] | 2021-04-23T15:25:03Z | [] | Example in javadoc of ArgumentMatcher has missing parenthesis | check that
- [x] The problematic code (if that's possible) is copied here;
Note that some configuration are impossible to mock via Mockito
- [x] Read the [contributing guide](https://github.com/mockito/mockito/blob/release/3.x/.github/CONTRIBUTING.md)
The javadoc for ArgumentMatcher contains some e... | [
"src/main/java/org/mockito/ArgumentMatcher.java"
] | [
"src/main/java/org/mockito/ArgumentMatcher.java"
] | [] | diff --git a/src/main/java/org/mockito/ArgumentMatcher.java b/src/main/java/org/mockito/ArgumentMatcher.java
index a1e27c98d6..f51d7e5f79 100644
--- a/src/main/java/org/mockito/ArgumentMatcher.java
+++ b/src/main/java/org/mockito/ArgumentMatcher.java
@@ -61,7 +61,7 @@
*
* List mock = mock(List.class);
*
- * when(... | null | train | test | 2021-04-21T22:27:52 | 2021-04-23T15:22:46Z | mvitz | train |
mockito/mockito/1930_2280 | mockito/mockito | mockito/mockito/1930 | mockito/mockito/2280 | [
"keyword_pr_to_issue"
] | 80374488162380d006b8ae6da915d940cbf68c7c | 8f95dcaa68e7bb76b597353739046274929da418 | [
"@adrianhescalante You can try mockk instead if you use kotlin",
"Yes, I migrated the project to Mockk in the end. Thank you.",
"For Kotlin projects, we now recommend `mockito-kotlin`: https://github.com/mockito/mockito-kotlin If you can still reproduce this issue, please open an issue over there and we can inv... | [
"These appear to be unavailable. Can we remove these and the annotations?",
"The same would be required here, assuming that `unbox-impl` also has a pre-known method signature?",
"I think we can use `org.mockito.internal.stubbing.answers.InvocationInfo` here, in a similar fashion to how `Returns` uses it: https:... | 2021-04-30T02:42:41Z | [] | Kotlin Result seems to behave weirdly when trying to be returned with Mockito | I am facing an issue when trying to use the Kotlin Result in my project. I am trying to mock the return value as shown here:
```kotlin
`when`(useCase.getA()).thenReturn(Result.success(ObjectA("testName")))
```
The exception when trying to use that returned Result is this one: `java.lang.ClassCastException: kotlin.R... | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/stubbing/answers/Returns.java",
"subprojects/kotlinTest/kotlinTest.gradle"
] | [
"gradle/dependencies.gradle",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/stubbing/answers/Returns.java",
"src/main/java/org/mockito/internal/util/KotlinInlineClassUtil.java",
"subprojects/kotlinTest/kotlinTest.gradle"
] | [
"subprojects/kotlinTest/src/test/kotlin/org/mockito/kotlin/InlineClassTest.kt"
] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index 570e6dcd21..25bfecbe66 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -36,7 +36,7 @@ libraries.bndGradle = 'biz.aQute.bnd:biz.aQute.bnd.gradle:5.2.0'
libraries.groovy = 'org.codehaus.groovy:groovy:3.0.8'
-def k... | diff --git a/subprojects/kotlinTest/src/test/kotlin/org/mockito/kotlin/InlineClassTest.kt b/subprojects/kotlinTest/src/test/kotlin/org/mockito/kotlin/InlineClassTest.kt
new file mode 100644
index 0000000000..a1a64ce0b0
--- /dev/null
+++ b/subprojects/kotlinTest/src/test/kotlin/org/mockito/kotlin/InlineClassTest.kt
@@ -... | train | test | 2021-04-29T11:07:21 | 2020-05-10T23:42:16Z | adrianhescalante | train |
mockito/mockito/2303_2306 | mockito/mockito | mockito/mockito/2303 | mockito/mockito/2306 | [
"keyword_pr_to_issue"
] | c2715ea34a4f32325aad9f00221a24ce6c95bc86 | 66998ea7f81c6adf49983cea081586e19760b7a0 | [
"Rafael, I took a look at this code and it wasn't completely clear to my why we are failing here. The reason that is probably happening is that Mockito first adds the mocked type (https://github.com/mockito/mockito/blob/6f9108b833323345bd926f10914224d3e0a11b80/src/main/java/org/mockito/internal/creation/bytebuddy/S... | [
"I'd prefer to avoid the static import here as it's the only use and we tend to not use static imports.",
"Not quite sure, why not most specific anymore?",
"Move comment to one line.",
"Interfaces might declare interfaces of their own.",
"We already did this on line 99 in the current implementation, so we d... | 2021-05-25T18:52:03Z | [] | "The type is not public and its mock class is loaded by a different class loader" with a context classloader that delegates | Repro case:
```java
package com.google.clm.mockitobug;
import static org.mockito.Mockito.mock;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.JUnit4;
/**
* My goal is to create a context classloader that is identical in every way to the existing one,
* except that it h... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
index efe977fa85..edb9640afb 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
+++ b/sr... | diff --git a/src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java b/src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java
new file mode 100644
index 0000000000..e01365ba99
--- /dev/null
+++ b/src/test/java/org/mockitousage/bugs/creation/PackageP... | train | test | 2021-05-25T12:41:21 | 2021-05-18T16:29:47Z | charlesmunger | train |
mockito/mockito/2082_2312 | mockito/mockito | mockito/mockito/2082 | mockito/mockito/2312 | [
"keyword_issue_to_pr"
] | d4753548bc3e9be3f95395c52ce856b5cf518b13 | 92cbac227d930f9b306527e8292a89bdb0cde348 | [
"Thanks for filing the issue. Could you please provide us a minimal reproduction case that we can clone/download to debug the issue? Thanks in advance!",
"Facing a similar issue. It can be reproduced by following these steps: https://www.baeldung.com/mockito-final\r\nand then debugging through the code. For any v... | [] | 2021-06-02T00:55:23Z | [] | 'this' is not available - when enabling mock-maker-inline | When we enable `mock-maker-inline` in our project and debug a class with `@Spy` annotated on it IntelliJ reports that `'this' is not available`:
When we unset `mock-maker-inline` then things work as expected... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java"
] | [
"src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
index edb9640afb..70abf95fb9 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/SubclassBytecodeGenerator.java
+++ b/sr... | diff --git a/src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java b/src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoaderTest.java
index e01365ba99..4f6ffbee19 100644
--- a/src/test/java/org/mockitousage/bugs/creation/PackagePrivateWithContextClassLoader... | train | test | 2021-05-31T14:06:52 | 2020-10-28T17:37:26Z | leonroy | train |
mockito/mockito/2340_2351 | mockito/mockito | mockito/mockito/2340 | mockito/mockito/2351 | [
"keyword_pr_to_issue"
] | c790ed8e00144b9758b8d078db3c6dc96f98c27d | 847b41bd383b6fb12c9a85f74938b7082586c833 | [
"Some more outfall in the Android ecosystem @raphw 😭 ",
"@robpridham-bbc I understand that you were not the initial reporters that warranted the 3.11.1 and 3.11.2 releases, but would you maybe be able to contribute regression tests for these setups? We have several subprojects already (https://github.com/mockito... | [] | 2021-07-05T18:04:08Z | [] | Mockito 3.11.2 (?) fails with "can't load this type of class file" | **Broken version**: 3.11.2?
**Working versions:** 3.10.0
**Description**
All was working OK with 3.8.0 and we upgraded to 3.11.2 but this presented the problem below. I have sequentially downgraded and it seems 3.10.0 doesn't present me with any problems.
I have not been able to confidently isolate it to this... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index eb894e3864..d536ad0bf7 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.11.5'
+versions.bytebuddy = '1.11.6'
versions.junitJupiter = '5.7.2'
version... | null | test | test | 2021-06-28T20:11:59 | 2021-06-22T20:47:28Z | robpridham-bbc | train |
mockito/mockito/2349_2351 | mockito/mockito | mockito/mockito/2349 | mockito/mockito/2351 | [
"keyword_pr_to_issue"
] | c790ed8e00144b9758b8d078db3c6dc96f98c27d | 847b41bd383b6fb12c9a85f74938b7082586c833 | [
"This will be fixed soonish. In the mean time, run with - Dnet.bytebuddy.experimental=true"
] | [] | 2021-07-05T18:04:08Z | [] | mockito-inline:3.11.2 | Unsupported class file major version 62 | I'm using a Java 18 early access build and while using mockito-core:3.11.2 everything was working fine, but when I switched to mockito-inline:3.11.2 (in order to use static mocks), I got the following error for the previously working tests. However the tests involving only static mocks seem to work fine.
I already t... | [
"gradle/dependencies.gradle"
] | [
"gradle/dependencies.gradle"
] | [] | diff --git a/gradle/dependencies.gradle b/gradle/dependencies.gradle
index eb894e3864..d536ad0bf7 100644
--- a/gradle/dependencies.gradle
+++ b/gradle/dependencies.gradle
@@ -4,7 +4,7 @@ ext {
def versions = [:]
-versions.bytebuddy = '1.11.5'
+versions.bytebuddy = '1.11.6'
versions.junitJupiter = '5.7.2'
version... | null | train | test | 2021-06-28T20:11:59 | 2021-07-01T17:59:46Z | AminCS | train |
mockito/mockito/2331_2369 | mockito/mockito | mockito/mockito/2331 | mockito/mockito/2369 | [
"keyword_pr_to_issue"
] | aedcd719eb6a2b8512ed7d519827ab8b19bdcd79 | 123beb8311ed6303ba71d682cff8434fe36b7f0f | [
"To create a mock a subclass of a mock is created through SubclassBytecodeGenerator.mockClass() here we can see that hashCode method is intercepted and handled by MockMethodInterceptor.ForHashCode. Here the code returns System.identityHashCode(thiz) as the hashcode where thiz is the object returned by Mockito.spy()... | [
"I am not sure if I follow why this line was changed. Could you elaborate as to why?",
"Consider the test [PartialMockingWithSpiesTest.shouldAllowStubbingOfMethodsThatDelegateToOtherMethods](https://github.com/mockito/mockito/blob/6f9108b833323345bd926f10914224d3e0a11b80/src/test/java/org/mockitousage/spies/Parti... | 2021-07-30T05:13:46Z | [] | Spy doesn't forward hashcode/equals to actual object | ### Mockito 3.11.1
```
public class MockitoTest {
private static class ValueHolder {
private final String value;
public ValueHolder( String value ) {
this.value = value;
}
public String getValue() {
return value;
}
@Overrid... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockFeatures.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebu... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/MockFeatures.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/SubclassByteBuddyMockMaker.java",
"src/main/java/org/mockito/internal/creation/bytebu... | [
"src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java",
"src/test/java/org/mockitousage/spies/SpyingOnRealObjectsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java
index 553a02e248..7178927cd9 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMo... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java
index d0ed772a68..6ffe72950f 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBy... | train | test | 2021-07-28T22:01:34 | 2021-06-16T18:14:49Z | cdalexndr | train |
mockito/mockito/2363_2379 | mockito/mockito | mockito/mockito/2363 | mockito/mockito/2379 | [
"keyword_pr_to_issue"
] | 5891de126d398ec09a040711b688176ff27b7d7c | f32973d4e709830a5a9fb19c54f32659023d2b03 | [
"Just to double-check that I understand the behavior of `@CheckReturnValue`. If we were to add it to `org.mockito.Mockito`, it can automatically ignore any method that returns `void`?",
"Indeed, it only affects non-void methods. Additionally, it's often easier to add it to the class, and if there are methods wher... | [] | 2021-08-02T11:10:23Z | [
"please contribute"
] | Apply @CheckReturnValue more aggressively | Mockito has a local copy of [`@CheckReturnValue`](https://github.com/mockito/mockito/blob/main/src/main/java/org/mockito/CheckReturnValue.java) (presumably to avoid a dependency on [errorprone](https://github.com/google/error-prone), but it's only used on a few APIs. There's a _lot_ of additional APIs that it could be... | [
"src/main/java/org/mockito/ArgumentCaptor.java",
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/stubbing/Stubber.java"
] | [
"src/main/java/org/mockito/ArgumentCaptor.java",
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/stubbing/Stubber.java"
] | [
"src/test/java/org/mockito/StaticMockingExperimentTest.java",
"src/test/java/org/mockito/internal/InvalidStateDetectionTest.java",
"src/test/java/org/mockitousage/misuse/DetectingMisusedMatchersTest.java",
"src/test/java/org/mockitousage/stacktrace/ClickableStackTracesWhenFrameworkMisusedTest.java",
"src/te... | diff --git a/src/main/java/org/mockito/ArgumentCaptor.java b/src/main/java/org/mockito/ArgumentCaptor.java
index 12df16bb75..f027de5c60 100644
--- a/src/main/java/org/mockito/ArgumentCaptor.java
+++ b/src/main/java/org/mockito/ArgumentCaptor.java
@@ -59,6 +59,7 @@
* @see Captor
* @since 1.8.0
*/
+@CheckReturnValu... | diff --git a/src/test/java/org/mockito/StaticMockingExperimentTest.java b/src/test/java/org/mockito/StaticMockingExperimentTest.java
index afe049e202..361ac13857 100644
--- a/src/test/java/org/mockito/StaticMockingExperimentTest.java
+++ b/src/test/java/org/mockito/StaticMockingExperimentTest.java
@@ -180,7 +180,7 @@ p... | test | test | 2021-08-02T22:42:00 | 2021-07-19T15:47:05Z | kluever | train |
mockito/mockito/2378_2380 | mockito/mockito | mockito/mockito/2378 | mockito/mockito/2380 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | f8da4cea9269ec35a0199b9a988de7a9d558287f | 88bd3066a198dcbd32b5aa827b2fa3513ac8561a | [
"Yes, I ran into the same issue. Fix is up at #2380 Apologies for the breakage!"
] | [] | 2021-08-02T15:31:58Z | [] | how to solve gradle sync failed after 'Add basic Android instrumented and unit tests' | Hello
I got gradle sync fail with 'Add basic Android instrumented and unit tests'(#2360).
> This version of the Android Support plugin for IntelliJ IDEA (or Android Studio) cannot open this project, please retry with version 4.2 or newer.
I think that it is caused with below.
build.gradle
> classpath 'com.... | [
"build.gradle"
] | [
"build.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index 0587470df7..eb7bed5197 100644
--- a/build.gradle
+++ b/build.gradle
@@ -14,7 +14,7 @@ buildscript {
classpath 'org.shipkit:shipkit-auto-version:1.1.19'
classpath 'com.google.googlejavaformat:google-java-format:1.10.0'
- classpath 'com.android.too... | null | train | test | 2021-07-30T20:12:31 | 2021-08-01T01:32:57Z | chaehwanli | train |
mockito/mockito/2394_2395 | mockito/mockito | mockito/mockito/2394 | mockito/mockito/2395 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | a53c3d451e756b51a96700624f517f4fcdd07aed | da6e8f73d805b8ed845bae32e745e3d6bf35a261 | [
"I am experiencing a similar issue after upgrading to version 3.12.0.\r\nMore specifically, the `AnnotatedSagaRepositoryTest#testLoadedFromNestedUnitOfWorkAfterCreateAndStore` test (found [here](https://github.com/AxonFramework/AxonFramework/blob/2eeacc4e225d0f3739b0c7d4e4ba37358795407c/modelling/src/test/java/org/... | [] | 2021-08-20T13:54:57Z | [] | Regression with InOrder verification after #2369 | The following test starts failing after https://github.com/mockito/mockito/commit/123beb8311ed6303ba71d682cff8434fe36b7f0f. It looks like the change to call actual `equals` and `hashCode` methods is catching a call to `equals` inside the implementation of `InOrder`.
```java
package com.test;
import static org.mo... | [
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"src/test/java/org/mockitousage/spies/SpiesWithRealEqualsAndInOrderTest.java"
] | diff --git a/src/main/java/org/mockito/internal/InOrderImpl.java b/src/main/java/org/mockito/internal/InOrderImpl.java
index 7fc0b5f27a..af852e49ae 100644
--- a/src/main/java/org/mockito/internal/InOrderImpl.java
+++ b/src/main/java/org/mockito/internal/InOrderImpl.java
@@ -6,7 +6,7 @@
import static org.mockito.inte... | diff --git a/src/test/java/org/mockitousage/spies/SpiesWithRealEqualsAndInOrderTest.java b/src/test/java/org/mockitousage/spies/SpiesWithRealEqualsAndInOrderTest.java
new file mode 100644
index 0000000000..e2dabe9515
--- /dev/null
+++ b/src/test/java/org/mockitousage/spies/SpiesWithRealEqualsAndInOrderTest.java
@@ -0,0... | test | test | 2021-08-19T20:19:47 | 2021-08-19T20:39:25Z | cushon | train |
mockito/mockito/2399_2400 | mockito/mockito | mockito/mockito/2399 | mockito/mockito/2400 | [
"keyword_pr_to_issue"
] | b04c7039031c170dae5f90acb3ec74c16289886f | 4f81d4f1de676f845d6ee111eb6285dbdd5935c6 | [
"I have the same issue after upgrade from `3.11.2` to `3.12.1`, i.e. the mock is not equal to itself.\r\nHere is an example of the recent failure in CI https://github.com/real-logic/agrona/runs/3401033492?check_suite_focus=true:\r\n```\r\n\r\nBroadcastReceiverTest > shouldReceiveTwoMessagesFromBuffer() FAILED\r\n ... | [] | 2021-08-24T10:22:54Z | [] | Sporadic mock verification failures related to hashCode/equals on 3.12.1 | Since updating from `3.11.2` to `3.12.0` (and getting similar errors on `3.12.1`), I have seen some strange sometimes-reproducible verification failures on Mockito for tests which previously passed consistently.
I can't yet establish a pattern or simple reproduction; it feels like it is somehow dependent on the orde... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java",
"src/test/java/org/mockitousage/spies/MockCreationShouldNotAffectSpyTest.java",
"src/test/java/org/mockitousage/spies/SpyCreationShouldNotAffectMockTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java
index 30ed949bf5..5ce57b1115 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java
index 6ffe72950f..e26b36d531 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBy... | test | test | 2021-08-20T20:23:14 | 2021-08-23T13:45:47Z | chadlwilson | train |
mockito/mockito/2412_2413 | mockito/mockito | mockito/mockito/2412 | mockito/mockito/2413 | [
"keyword_pr_to_issue"
] | d57deb6dcdb73221ffcc6f171c680a7203d7a1c4 | 66a4a5c05fc332b7973602e447060e5c0cdde3db | [
"> I have a PR that is almost ready for this, and would gladly submit it.\r\n\r\nYes that seems good to me, looking forward to it!"
] | [] | 2021-08-29T17:15:20Z | [] | Some VerificationModes don't have a toString implementation. | Some user-facing VerificationModes don't have a `toString()` implementation. This includes:
- `AtMost`
- `Only`
- `After`
- `Timeout`
I ran into this issue while using Mockito with a proprietary [Jasmine](https://jasmine.github.io/)-like library for JUnit. Here is a short example written with JUnit and the ope... | [
"src/main/java/org/mockito/internal/verification/AtMost.java",
"src/main/java/org/mockito/internal/verification/Only.java",
"src/main/java/org/mockito/verification/After.java",
"src/main/java/org/mockito/verification/Timeout.java"
] | [
"src/main/java/org/mockito/internal/verification/AtMost.java",
"src/main/java/org/mockito/internal/verification/Only.java",
"src/main/java/org/mockito/verification/After.java",
"src/main/java/org/mockito/verification/Timeout.java"
] | [
"src/test/java/org/mockito/internal/verification/DummyVerificationMode.java",
"src/test/java/org/mockitousage/verification/AtMostXVerificationTest.java",
"src/test/java/org/mockitousage/verification/OnlyVerificationTest.java",
"src/test/java/org/mockitousage/verification/VerificationWithAfterTest.java",
"sr... | diff --git a/src/main/java/org/mockito/internal/verification/AtMost.java b/src/main/java/org/mockito/internal/verification/AtMost.java
index 57dedc4c66..72c0d00275 100644
--- a/src/main/java/org/mockito/internal/verification/AtMost.java
+++ b/src/main/java/org/mockito/internal/verification/AtMost.java
@@ -51,4 +51,9 @@... | diff --git a/src/test/java/org/mockito/internal/verification/DummyVerificationMode.java b/src/test/java/org/mockito/internal/verification/DummyVerificationMode.java
index 92b3b640d4..6b5f4c028f 100644
--- a/src/test/java/org/mockito/internal/verification/DummyVerificationMode.java
+++ b/src/test/java/org/mockito/intern... | train | test | 2021-08-29T09:37:13 | 2021-08-28T18:05:32Z | LeMikaelF | train |
mockito/mockito/2389_2444 | mockito/mockito | mockito/mockito/2389 | mockito/mockito/2444 | [
"keyword_pr_to_issue"
] | 929188bd38a2cde7b3684b251287671a8ed8daee | b77aee1a3f5c20ae4a85f31d6b6fc60e412ba7e4 | [] | [] | 2021-10-12T01:56:23Z | [] | Parallel use of mocks with deep stubbing may lead to ConcurrentModificationException | Java8 / JUnit5
Mockito version: 3.11.2
Test class:
```
import org.junit.jupiter.api.RepeatedTest;
import org.mockito.Answers;
import java.util.List;
import java.util.stream.IntStream;
import static org.mockito.Mockito.mock;
class ConcurrencyTest {
@RepeatedTest(value = 1000)
void test() {
... | [
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java"
] | [
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubsConcurrentTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java b/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java
index 849300e61e..3091670fb1 100644
--- a/src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java
+++ b/src/main/java/org/mockito/internal/stu... | diff --git a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubsConcurrentTest.java b/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubsConcurrentTest.java
new file mode 100644
index 0000000000..b3658342ed
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/d... | val | test | 2021-10-12T15:41:31 | 2021-08-06T21:01:48Z | antonantsyferov | train |
mockito/mockito/2489_2546 | mockito/mockito | mockito/mockito/2489 | mockito/mockito/2546 | [
"keyword_pr_to_issue"
] | faa6e92aec0c5b854c11422224e0628fa787a1cb | 8cdf0cce796a3497460de93abbe395108feae74c | [
"Do you mind sending us a PR with the regression test and a corresponding fix? That would be awesome 🎉 ",
"I'm thinking about some fix the last few days and I don't know if I'll be able to provide any generic-enough fix.\r\n\r\nMaybe that's just my lack of knowledge of why is this stack trace cleaning implemente... | [] | 2022-01-21T21:30:33Z | [
"please contribute"
] | Incomplete stack trace returned from spy inside another spy | Hi,
due to the fix of issue #2238, the returned stack trace is not complete when an exception is thrown from a spy inside another spy.
The problem appeared in released version 3.9.0 (specifically 3.8.14) and still exists in 4.1.0.
I wrote a unit test simulating this behavior:
https://github.com/holubec-petr/moc... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMakerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java b/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
index 1490501eae..580f22b309 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
+++ b/src/main/java/org/mockito/int... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMakerTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMakerTest.java
index e27605640b..3d42f3a377 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByt... | train | test | 2022-01-18T18:24:53 | 2021-11-26T14:28:05Z | holubec-petr | train |
mockito/mockito/2201_2547 | mockito/mockito | mockito/mockito/2201 | mockito/mockito/2547 | [
"keyword_pr_to_issue"
] | f8ffebe54fbfd4aee36dd755b27a9d25b3d1d5cd | f6ce1bb04fe0d0ca65f88e4395dea528b6b749bc | [
"Hi @TimvdLippe !\r\nI am a new open source contributor and would love to solve this issue, could you help me understand the issue better by providing some extra references ? \r\nIs this is issue open to contribute ?",
"isn't it expected behavior?\r\nFrom the user perspective , it look like that method can throw ... | [
"I am not 100% sure, but I think we should also recursively walk up the parent class hierarchy in case the direct parent doesn't define the method. E.g. I think the current regression tests still fails:\r\n\r\n```java\r\npublic interface Foo {\r\n void bar() throws IOException; \r\n}\r\npublic abstract class Baz... | 2022-01-23T18:19:17Z | [
"please contribute"
] | Calling getExceptionTypes() on concrete object that is used as interface doesn't return exception types from interface | org.mockito.internal.stubbing.answers.InvocationInfo#isValidException is doing validation on the exception types that can be thrown from this method.
In my codebase, I'm programming against an interface, but in fact, a spy is created from an instance that is implementing the interface, that drops the exception types... | [
"src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java"
] | [
"src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java"
] | [
"src/test/java/org/mockito/internal/invocation/InvocationBuilder.java",
"src/test/java/org/mockito/internal/stubbing/answers/InvocationInfoExceptionTest.java",
"src/test/java/org/mockito/internal/stubbing/answers/InvocationInfoTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java b/src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java
index 8bfffca2fe..c159906af0 100644
--- a/src/main/java/org/mockito/internal/stubbing/answers/InvocationInfo.java
+++ b/src/main/java/org/mockito/internal/stubbi... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java b/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
index 281d41b3c3..9900db9d98 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationBuilder.java
+++ b/src/test/java/org/mockito/internal/invocation/Invo... | train | test | 2022-01-25T14:10:55 | 2021-02-11T17:59:10Z | henrykuijpers | train |
mockito/mockito/2548_2549 | mockito/mockito | mockito/mockito/2548 | mockito/mockito/2549 | [
"keyword_pr_to_issue"
] | 8cdf0cce796a3497460de93abbe395108feae74c | 02d63565aa6ccca12a148c6f2f1ac5cf19357672 | [
"As a Mockito user I would love to have this new feature @mirkoalicastro ",
"> As a Mockito user I would love to have this new feature @mirkoalicastro\r\n\r\nI made it more clear that there is already a possible implementation with the mentioned PR, which includes tests as well, of course. I hope someone will loo... | [
"Nit: for readability, I would prefer this to not be inlined. E.g. let's put this try-catch in each of the methods to make it clear where the `MockedStatic` is coming from. (This is mostly for test code, as for production code this would have been a fine way to solve it)",
"Nit: it's easier to use `org.assertj.co... | 2022-01-24T21:02:43Z | [] | [PR open] Add feature to verify static methods calls in order | **TL;DR** Mockito doesn't allow verifying static methods calls in order. I have implemented this feature here: https://github.com/mockito/mockito/pull/2549. If possible, I'd like to contribute; or discuss other ways to achieve the same.
---
Hey Mockito team.
This discussion relates to: https://groups.google.co... | [
"src/main/java/org/mockito/InOrder.java",
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"src/main/java/org/mockito/InOrder.java",
"src/main/java/org/mockito/internal/InOrderImpl.java"
] | [
"subprojects/inline/src/test/java/org/mockitoinline/InOrderVerificationTest.java"
] | diff --git a/src/main/java/org/mockito/InOrder.java b/src/main/java/org/mockito/InOrder.java
index 02ea019c01..3cb047a4c4 100644
--- a/src/main/java/org/mockito/InOrder.java
+++ b/src/main/java/org/mockito/InOrder.java
@@ -4,6 +4,8 @@
*/
package org.mockito;
+import static org.mockito.Mockito.times;
+
import org.... | diff --git a/subprojects/inline/src/test/java/org/mockitoinline/InOrderVerificationTest.java b/subprojects/inline/src/test/java/org/mockitoinline/InOrderVerificationTest.java
new file mode 100644
index 0000000000..fb35adc76f
--- /dev/null
+++ b/subprojects/inline/src/test/java/org/mockitoinline/InOrderVerificationTest.... | train | test | 2022-01-22T10:19:10 | 2022-01-24T18:59:51Z | mirkoalicastro | train |
mockito/mockito/2602_2603 | mockito/mockito | mockito/mockito/2602 | mockito/mockito/2603 | [
"keyword_pr_to_issue"
] | e3e100fa0ee73d85b0ae7ce65b824ae79248b083 | 8497f1752331acd30987d666dd099b089c69c68d | [
"> But I have not tested this change. I can not foresee what implications this would have\r\n\r\nIf you add your use case as a regression test to https://github.com/mockito/mockito/tree/main/subprojects/junit-jupiter/src/test/java/org/mockitousage and all tests pass with your fix, it is safe to merge 😄 Good catch!... | [
"As a user, I think the behavior as described in this test makes sense. Therefore, I would like to keep it. That said, it would be ideal if we can keep this behavior as-is, while also fixing your issue. Do you think that is feasible or are they mutually exclusive?",
"1. This test tests a behaviour that was never ... | 2022-03-24T12:13:50Z | [] | mockito-core MockitoAnnotations::openMocks initializes class twice if said class has super class | ## Short, Self Contained, Correct (Compilable), Example:
Have a look [here ](https://github.com/1-alex98/mre-mockito/tree/master/src/test/java).
You will find a `Works` class and a `DoesNotWork` class. Both are essentially the same with a small difference being the `DoesNotWork` class does fail and extends and empty... | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/InjectMocksTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java b/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
index ef9933d9d6..eeb019ade5 100644
--- a/src/main/java/org/mockito/internal/configuration/InjectingAnnotationEngine.java
+++ b/src/main/java/org... | diff --git a/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java b/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTest.java
deleted file mode 100644
index 274db3beca..0000000000
--- a/src/test/java/org/mockito/internal/configuration/InjectingAnnotationEngineTes... | test | test | 2023-06-13T23:43:03 | 2022-03-19T11:30:53Z | 1-alex98 | train |
mockito/mockito/2648_2650 | mockito/mockito | mockito/mockito/2648 | mockito/mockito/2650 | [
"keyword_pr_to_issue"
] | d7a8ae040ec7f04e3011026857630aa9116f844d | 70cf2d2f48506fca24f16963e9c3d2223898ae5a | [
"I would have though that we supported this feature with our `MockSettings`. While looking that up, I discovered that we do ship [`lenient()`](https://javadoc.io/static/org.mockito/mockito-core/4.5.1/org/mockito/MockSettings.html#lenient()), but we don't ship an equivalent API to set the strictness to `STRICT_STUBS... | [
"Nit: `@since 4.6.0` since we will include this in the next minor release",
"Nit: the default is the default of the runner. If you use the lenient runner, it will be lenient. I suggest to formulate it the following way:\r\n\r\n```\r\nThe default strictness level is determined by the rule/runner used. If you are u... | 2022-05-23T04:18:41Z | [] | Any way to enable Strict Stubbing when using Mockito.mock() without using @Mock? | Hi,
I am using mockito-core 4.5.1 and JUnit 5. I can use `MockitoExtension` and `@Mock` annotation and by default I get Strict Stubbing behaviour. However, if I use `Mockito.Mock(MyClass.class)` to create mock it seems Strictness is not enabled. Even if I stub unnecessary methods it is not giving any error.
I know... | [
"src/main/java/org/mockito/Mock.java",
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"src/main/java/org/mockito/internal/creation/MockSettingsImpl.java",
"src/main/java/org/mockito/i... | [
"src/main/java/org/mockito/Mock.java",
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/configuration/MockAnnotationProcessor.java",
"src/main/java/org/mockito/internal/creation/MockSettingsImpl.java",
"src/main/java/org/mockito/i... | [
"src/test/java/org/mockito/internal/creation/MockSettingsImplTest.java",
"src/test/java/org/mockitousage/strictness/StrictnessMockAnnotationTest.java",
"src/test/java/org/mockitousage/strictness/StrictnessWithSettingsTest.java"
] | diff --git a/src/main/java/org/mockito/Mock.java b/src/main/java/org/mockito/Mock.java
index 62c4faa2df..7c3e036083 100644
--- a/src/main/java/org/mockito/Mock.java
+++ b/src/main/java/org/mockito/Mock.java
@@ -13,6 +13,7 @@
import java.lang.annotation.Target;
import org.mockito.junit.MockitoJUnitRunner;
+import or... | diff --git a/src/test/java/org/mockito/internal/creation/MockSettingsImplTest.java b/src/test/java/org/mockito/internal/creation/MockSettingsImplTest.java
index 9e8d68d5d8..dc8af35423 100644
--- a/src/test/java/org/mockito/internal/creation/MockSettingsImplTest.java
+++ b/src/test/java/org/mockito/internal/creation/Moc... | test | test | 2022-05-20T10:32:39 | 2022-05-20T23:39:30Z | sivaprasadreddy | train |
mockito/mockito/2644_2664 | mockito/mockito | mockito/mockito/2644 | mockito/mockito/2664 | [
"keyword_pr_to_issue"
] | 770d95a578c4aee1085cf926f5879838f5ddd493 | ce4e64dc782a132e4f32faf56a2630187a703a00 | [
"I've had a bit of a dig and it looks like a bug to me. `returnsArgAt` has similar issues. I'm happy to have a look into this.",
"Thanks for the fix @big-andy-coates & @TimvdLippe, appreciated!",
"(Verified in our project that the fix indeed fixes the original problem. Thanks! :pray:)",
"Semi-related issue ... | [
"Note the existing cast of `InvocationOnMock` to `Invocation` to access the `getRawArguments` method. \r\n\r\nWhat do you think to exposing `getRawArguments` on the `InvocationOnMock` interface, and thereby removing the need for lots of casts to get to the `Invocation`?",
"When this is invoked, both `getArgument... | 2022-06-02T00:20:24Z | [] | Varargs methods cause `ClassCastException` in `AnswerFunctionalInterfaces` | Hi,
The other day, I discovered that this code does not work:
```java
doAnswer(answerVoid((VoidAnswer2<String, Object[]>)
logger::info
)).when(mock)
.info(any(), (Object[]) any());
// This call will throw an exception
mock.info("Some message ... | [
"src/main/java/org/mockito/internal/stubbing/answers/AnswerFunctionalInterfaces.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java",
"src/main/java/org/mockito/invocation/Invocation.java",
... | [
"src/main/java/org/mockito/internal/stubbing/answers/AnswerFunctionalInterfaces.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java",
"src/main/java/org/mockito/invocation/Invocation.java",
... | [
"src/test/java/org/mockitousage/IMethods.java",
"src/test/java/org/mockitousage/MethodsImpl.java",
"src/test/java/org/mockitousage/stubbing/StubbingWithAdditionalAnswersTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/answers/AnswerFunctionalInterfaces.java b/src/main/java/org/mockito/internal/stubbing/answers/AnswerFunctionalInterfaces.java
index e4692f26d9..d9b3271d91 100644
--- a/src/main/java/org/mockito/internal/stubbing/answers/AnswerFunctionalInterfaces.java
+++ b/src/m... | diff --git a/src/test/java/org/mockitousage/IMethods.java b/src/test/java/org/mockitousage/IMethods.java
index 12897422da..06492f09cb 100644
--- a/src/test/java/org/mockitousage/IMethods.java
+++ b/src/test/java/org/mockitousage/IMethods.java
@@ -133,8 +133,26 @@ String simpleMethod(
String threeArgumentMethodWi... | train | test | 2022-06-05T21:25:17 | 2022-05-17T09:15:40Z | perlun | train |
mockito/mockito/2616_2685 | mockito/mockito | mockito/mockito/2616 | mockito/mockito/2685 | [
"keyword_pr_to_issue"
] | ec278300c6d66e65ca58998f323502657bca6703 | 807b121cc9b677e22a3497509ac594525f0bc6a2 | [] | [] | 2022-06-14T10:20:35Z | [] | Mock static class seems records wrong invocations if called nested method throws exception | If mocking a static class where method calls another static method within same class and inner class is throwing an expception the
the stubbing does not work as expected (instead of returning stubbed answer the execption is thrown)
Class `StaticTest.java`:
```
import java.util.concurrent.atomic.AtomicInteger;
... | [
"src/main/java/org/mockito/internal/handler/MockHandlerImpl.java"
] | [
"src/main/java/org/mockito/internal/handler/MockHandlerImpl.java"
] | [
"src/test/java/org/mockitousage/spies/SpyAsDefaultMockUsageTest.java",
"subprojects/inline/src/test/java/org/mockitoinline/bugs/OngoingStubShiftTest.java"
] | diff --git a/src/main/java/org/mockito/internal/handler/MockHandlerImpl.java b/src/main/java/org/mockito/internal/handler/MockHandlerImpl.java
index 17b967efcf..e58659a166 100644
--- a/src/main/java/org/mockito/internal/handler/MockHandlerImpl.java
+++ b/src/main/java/org/mockito/internal/handler/MockHandlerImpl.java
@... | diff --git a/src/test/java/org/mockitousage/misuse/SpyStubbingMisuseTest.java b/src/test/java/org/mockitousage/spies/SpyAsDefaultMockUsageTest.java
similarity index 61%
rename from src/test/java/org/mockitousage/misuse/SpyStubbingMisuseTest.java
rename to src/test/java/org/mockitousage/spies/SpyAsDefaultMockUsageTest.j... | train | test | 2022-06-13T20:30:29 | 2022-04-10T15:53:08Z | mariohofmann | train |
mockito/mockito/2686_2687 | mockito/mockito | mockito/mockito/2686 | mockito/mockito/2687 | [
"keyword_pr_to_issue"
] | ec278300c6d66e65ca58998f323502657bca6703 | 512ee3949484e4765038a0410cd7a7f1b73cc655 | [] | [] | 2022-06-14T15:12:24Z | [] | RETURNS_SELF breaks methods with generic return type | I'm trying to use RETURNS_SELF to mock a builder with a generic method:
```Java
private static class HttpBuilder {
private String uri;
public HttpBuilder withUri(String uri) {
this.uri = uri;
return this
}
...
public <T> T request(T result) {
return result; // Do typed request
... | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/TriesToReturnSelf.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/TriesToReturnSelf.java"
] | [
"src/test/java/org/mockitousage/stubbing/StubbingReturnsSelfTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/TriesToReturnSelf.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/TriesToReturnSelf.java
index 58a64d722e..f5643c565b 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/TriesToReturnSelf.java
+++ b/src/main/ja... | diff --git a/src/test/java/org/mockitousage/stubbing/StubbingReturnsSelfTest.java b/src/test/java/org/mockitousage/stubbing/StubbingReturnsSelfTest.java
index 4e75dfb5c6..28b9cea895 100644
--- a/src/test/java/org/mockitousage/stubbing/StubbingReturnsSelfTest.java
+++ b/src/test/java/org/mockitousage/stubbing/StubbingRe... | train | test | 2022-06-13T20:30:29 | 2022-06-14T14:25:44Z | mlichtblau | train |
mockito/mockito/2679_2689 | mockito/mockito | mockito/mockito/2679 | mockito/mockito/2689 | [
"keyword_pr_to_issue"
] | 807b121cc9b677e22a3497509ac594525f0bc6a2 | b984aac2810a1cb488c7ccb44941becec553ff1f | [
"I would be happy to review a PR that removes the sentence altogether",
"I am ready to prepare PR, but I don't have permissions to push "
] | [] | 2022-06-19T10:48:41Z | [] | Update javadoc of `Strictness.STRICT_STUBS` | https://github.com/mockito/mockito/blob/c4cce85decc1639db41209696131d41e6d722d2f/src/main/java/org/mockito/quality/Strictness.java#L68
https://github.com/mockito/mockito/blob/c4cce85decc1639db41209696131d41e6d722d2f/src/main/java/org/mockito/MockSettings.java#L371
It looks like despite of the plan, `LENIENT` is s... | [
"src/main/java/org/mockito/quality/Strictness.java"
] | [
"src/main/java/org/mockito/quality/Strictness.java"
] | [] | diff --git a/src/main/java/org/mockito/quality/Strictness.java b/src/main/java/org/mockito/quality/Strictness.java
index b25cab33e6..76cd552b38 100644
--- a/src/main/java/org/mockito/quality/Strictness.java
+++ b/src/main/java/org/mockito/quality/Strictness.java
@@ -65,7 +65,6 @@ public enum Strictness {
* Ensure... | null | train | test | 2022-06-18T11:41:01 | 2022-06-10T22:13:35Z | happylynx | train |
mockito/mockito/2823_2829 | mockito/mockito | mockito/mockito/2823 | mockito/mockito/2829 | [
"keyword_pr_to_issue"
] | abbd2c86d9bf0af961e47927520e05f6c6726dea | 048731e9fc955789fe90efba6828262ce6e4f5d6 | [
"@TimvdLippe I think I do have time to look at it, feel free to assign it to me, thank you.",
"@TimvdLippe It seems like issue was caused by one test case, `ProgrammaticMockMakerTest`, which was conflicting with default mock maker strategies (by programmatically manipulating mock makers). I have extracted this te... | [] | 2022-12-20T21:26:44Z | [
"please contribute"
] | AssertionError in `MockUtil.getMockHandlerOrNull` in our regression test suite | We appear to be hitting the following assertion in our test suites: https://github.com/mockito/mockito/blob/e2e628918518b73de7381692f28556ac6caa4710/src/main/java/org/mockito/internal/util/MockUtil.java#L160
Example error from [the logs](https://github.com/mockito/mockito/actions/runs/3612965923/jobs/6088416494#logs... | [
"settings.gradle.kts"
] | [
"settings.gradle.kts"
] | [
"subprojects/programmatic-test/programmatic-test.gradle"
] | diff --git a/settings.gradle.kts b/settings.gradle.kts
index 3fdc394e6a..551d0fa05f 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -19,7 +19,8 @@ include("subclass",
"junitJupiterParallelTest",
"osgi-test",
"bom",
- "errorprone")
+ "errorprone",
+ "programmatic-test")
if (!Java... | diff --git a/subprojects/programmatic-test/programmatic-test.gradle b/subprojects/programmatic-test/programmatic-test.gradle
new file mode 100644
index 0000000000..365dad93e3
--- /dev/null
+++ b/subprojects/programmatic-test/programmatic-test.gradle
@@ -0,0 +1,18 @@
+plugins {
+ id 'java'
+}
+
+description = "Test s... | train | test | 2022-12-19T21:09:39 | 2022-12-14T21:15:12Z | TimvdLippe | train |
mockito/mockito/1593_2835 | mockito/mockito | mockito/mockito/1593 | mockito/mockito/2835 | [
"keyword_pr_to_issue"
] | 4ef3ce8563eb1800b0d68e47271d8ff1d95bc5f9 | 064fe9028993a11ccf0ae12b5975b96baffcf305 | [
"I can fix it.",
"try this as workaround:\r\n`Mockito.when(good.call((String[])Mockito.any())).thenReturn(1L);`",
"the problem is matches method from internal class VarArgAware in InstanceOf. It need to be override.",
"Hi @jjDevPL \r\n\r\nThanks for tracking the version that changed the behavior ! This was do... | [
"This test has been removed as `any()` now matches a single value passed to a varargs parameter. So this test fails with new impl. Fixing it requires changing:\r\n\r\n```java\r\ngiven(mock.methodWithVarargAndNonVarargVariants((String[]) any()))\r\n .willReturn(\"var arg method\");\r\n```\r\n\r\nto\r\... | 2022-12-23T06:14:58Z | [
"enhancement"
] | Mockito confuses varargs and single-param methods (regression) | In Mockito 2.2.5 and later, when setting expectations for mocking a varargs method, using an array doesn't work:
```Java
Mockito.when(good.call(Mockito.any(String[].class))).thenReturn(1L);
```
And instead the contained type must be used:
```Java
Mockito.when(good.call(Mockito.any(String.class))).thenReturn(1L);
... | [
"src/main/java/org/mockito/ArgumentMatcher.java",
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/hamcrest/MockitoHamcrest.java",
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrateg... | [
"src/main/java/org/mockito/ArgumentMatcher.java",
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/hamcrest/MockitoHamcrest.java",
"src/main/java/org/mockito/internal/hamcrest/HamcrestArgumentMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrateg... | [
"src/test/java/org/mockito/internal/invocation/InvocationMatcherTest.java",
"src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java",
"src/test/java/org/mockito/internal/matchers/InstanceOfTest.java",
"src/test/java/org/mockito/internal/util/reflection/ParameterizedConstructorInstan... | diff --git a/src/main/java/org/mockito/ArgumentMatcher.java b/src/main/java/org/mockito/ArgumentMatcher.java
index ad52e1ecae..5d68132d82 100644
--- a/src/main/java/org/mockito/ArgumentMatcher.java
+++ b/src/main/java/org/mockito/ArgumentMatcher.java
@@ -161,7 +161,7 @@ public interface ArgumentMatcher<T> {
* <p>... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationMatcherTest.java b/src/test/java/org/mockito/internal/invocation/InvocationMatcherTest.java
index ab53be545f..a217d4d8d3 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationMatcherTest.java
+++ b/src/test/java/org/mockito/internal/inv... | train | test | 2022-12-29T18:12:54 | 2019-01-17T16:44:17Z | lewisd32 | train |
mockito/mockito/2892_2893 | mockito/mockito | mockito/mockito/2892 | mockito/mockito/2893 | [
"keyword_pr_to_issue"
] | 50b21cf68b400a29369de58b9286d29e368212a7 | e9784550dc773c14efbddba8880f9d6750cb9f9b | [
"I am seeing some failures on CI with the new API 33 level job:\r\n\r\n```\r\n> Task :androidTest:connectedDebugAndroidTest\r\nException thrown during onBeforeAll invocation of plugin com.google.testing.platform.plugin.android.AndroidDevicePlugin.\r\nFailed to install APK(s): /Users/runner/work/mockito/mockito/subp... | [
"You probably don't even need these two steps, because Android Gradle Plugin will download everything automatically (what is needed) and GitHub Actions hosted runners are set up with Android SDK already.\r\n\r\n`3.` is only necessary if you use self-hosted runners.\r\n`4.` is not necessary if you use Gradle.",
"C... | 2023-01-31T00:59:53Z | [] | Set up Android Github Action pipeline | Coming from https://github.com/mockito/mockito/issues/2890#issuecomment-1409200309:
> we started an effort to set up some basic Android tests for us: https://github.com/mockito/mockito/tree/main/subprojects/androidTest However, this stalled as we couldn't get it to work on CI. If anybody affected here would like to ... | [
".github/workflows/ci.yml"
] | [
".github/workflows/ci.yml"
] | [
"subprojects/androidTest/src/androidTest/java/org/mockitousage/androidtest/BasicInstrumentedTests.kt"
] | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0c57e59086..6ea135eac2 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -85,6 +85,38 @@ jobs:
chmod +x codecov
./codecov
+ #
+ # Android build job
+ #
+ android:
+ runs-on: macos-latest
+ if: "! c... | diff --git a/subprojects/androidTest/src/androidTest/java/org/mockitousage/androidtest/BasicInstrumentedTests.kt b/subprojects/androidTest/src/androidTest/java/org/mockitousage/androidtest/BasicInstrumentedTests.kt
index 2fa04c8bd6..07378171fc 100644
--- a/subprojects/androidTest/src/androidTest/java/org/mockitousage/a... | val | test | 2023-01-30T23:22:40 | 2023-01-31T00:40:00Z | reta | train |
mockito/mockito/2905_2908 | mockito/mockito | mockito/mockito/2905 | mockito/mockito/2908 | [
"keyword_pr_to_issue"
] | 10515bcd940c405ec058d7fb82d729c57bab2384 | 51535267e574cc80fac453aff25e56c7bc21e41b | [] | [] | 2023-02-08T22:24:04Z | [] | StackOverflow while mocking a ThreadLocal on Mockito 5.1.1 | Hello Folks,
I'm upgrading Mockito in a Java application from 4.9.0 to 5.1.1. We are on JDK 11 (I personally use Temurin 11.0.13).
So, I've a test failing due to a StackOverflow
```
java.lang.StackOverflowError
at org.mockito.internal.creation.bytebuddy.inject.MockMethodDispatcher.get(MockMethodDispatcher.j... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java"
] | [
"src/test/java/org/mockitousage/bugs/ThreadLocalTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java b/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
index 1dd744171f..6074eef038 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/MockMethodAdvice.java
+++ b/src/main/java/org/mockito/int... | diff --git a/src/test/java/org/mockitousage/bugs/ThreadLocalTest.java b/src/test/java/org/mockitousage/bugs/ThreadLocalTest.java
new file mode 100644
index 0000000000..8c113d90a6
--- /dev/null
+++ b/src/test/java/org/mockitousage/bugs/ThreadLocalTest.java
@@ -0,0 +1,66 @@
+/*
+ * Copyright (c) 2007 Mockito contributors... | test | test | 2023-02-06T22:55:15 | 2023-02-08T08:28:10Z | robertotru | train |
mockito/mockito/2934_2942 | mockito/mockito | mockito/mockito/2934 | mockito/mockito/2942 | [
"keyword_pr_to_issue"
] | b6861e3e10cf437ccd3ef5a8e3634e3e8cd9eef5 | 393f0a16982ef3060d5db164bf51bfba8ce09a48 | [] | [] | 2023-03-14T19:52:17Z | [] | Feature suggestion: TerminalMockCandidateFilter should report error when more than one candidate left | Hi,
when stumbling over #2921 , I realized that Mockito will silently fail to inject `@Mock` objects when there is more than one candidate. Usually, DI containers will throw an exception in that case, otherwise the user first has to understand what went wrong (no injection happened), and then start wondering *why* it ... | [
"src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java"
] | [
"src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockMultipleMatchesTest.java",
"subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java b/src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java
index 0c40478daa..343605f370 100644
--- a/src/main/java/org/mockito/internal/configuration/injection/filter/TypeB... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockMultipleMatchesTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockMultipleMatchesTest.java
new file mode 100644
index 0000000000..323008eb63
--- /dev/null
+++ b/subprojects/junit-jupiter/src/test/java/o... | test | test | 2023-03-14T20:17:44 | 2023-03-09T10:45:22Z | jfrantzius | train |
mockito/mockito/2285_2949 | mockito/mockito | mockito/mockito/2285 | mockito/mockito/2949 | [
"keyword_pr_to_issue"
] | 5486617f7ac759d24e99ee9d8d03e969acdd460f | 6ffd23e1bf3866dc39ab13c86ebe1f667e07398d | [
"I also like the idea about removing this `return true` statement when I wrote something which is more \"assertion\" than \"matching\".\r\n\r\nBut it seems there is some limitation about this, see : [**`argThat` plus asserts**](https://stackoverflow.com/a/57281503/5088764).\r\nNot sure to understand details, maybe ... | [
"I just realized that throwing an exception might cause stateful problems in our tracking mechanism. E.g. if we match on arguments and we throw an exception somewhere, I am not sure how Mockito recovers. Given that this PR passes the checks, I think this is fine, but let's codify this explicitly.\r\n\r\nCan we add ... | 2023-03-25T19:56:49Z | [] | Assertions on parameters during verification | ### Suggestion
I would like to suggest adding an API allowing for assertions during parameter verification without argument captors in simple cases.
### Motivation
In my projects I generally use Mockito and AssertJ for testing. For non trivial method parameters, I often encounter the following ArgumentCaptor patte... | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/Mockito.java"
] | [
"src/test/java/org/mockitousage/matchers/MatchersTest.java"
] | diff --git a/src/main/java/org/mockito/ArgumentMatchers.java b/src/main/java/org/mockito/ArgumentMatchers.java
index de87f298a1..1743ce164b 100644
--- a/src/main/java/org/mockito/ArgumentMatchers.java
+++ b/src/main/java/org/mockito/ArgumentMatchers.java
@@ -14,6 +14,7 @@
import java.util.List;
import java.util.Map;
... | diff --git a/src/test/java/org/mockitousage/matchers/MatchersTest.java b/src/test/java/org/mockitousage/matchers/MatchersTest.java
index 777c49a063..f89b44b731 100644
--- a/src/test/java/org/mockitousage/matchers/MatchersTest.java
+++ b/src/test/java/org/mockitousage/matchers/MatchersTest.java
@@ -20,6 +20,7 @@
import... | train | test | 2023-03-25T13:30:31 | 2021-05-06T16:15:22Z | Saberos | train |
mockito/mockito/2958_2962 | mockito/mockito | mockito/mockito/2958 | mockito/mockito/2962 | [
"keyword_pr_to_issue"
] | f9fbf50bd63b71d1b4ec86426a02b3bcb6cdd3f3 | 84a5eee1ce5bb0171532eb5da3d21ba9d1741bf9 | [
"Probably a regression introduced in #2923. @jfrantzius can you please take a look?",
"Looking at it...",
"That's an interesting somehow recursive construct that I'm surprised the compiler accepts, but then there surely shouldn't be a `ClassCastException` anyway ...\r\n```java\r\npublic class ConcreteJob exten... | [] | 2023-04-03T15:57:45Z | [] | ClassCastException when combining InjectMocks with generified Mock field | When calling `MockitoAnnotations.openMocks(this);` on a class that contains an `@InjectMocks` target, a ClassCastException occurs when the target has a field that is generified and provided by one of the mocks in said class.
```java
public class OpenMocksTest
{
@InjectMocks
protected ConcreteJob job;
@Mock... | [
"src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java"
] | [
"src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java"
] | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java b/src/main/java/org/mockito/internal/configuration/injection/filter/TypeBasedCandidateFilter.java
index 343605f370..a66ab52144 100644
--- a/src/main/java/org/mockito/internal/configuration/injection/filter/TypeB... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockTest.java
index a837f0149b..4decb2e2e2 100644
--- a/subprojects/junit-jupiter/src/test/java/org/mockitousage/GenericTypeMockTest.java
+++ b/subprojects... | test | test | 2023-03-31T21:53:29 | 2023-03-31T14:59:11Z | jsteenbeeke | train |
mockito/mockito/2915_2989 | mockito/mockito | mockito/mockito/2915 | mockito/mockito/2989 | [
"keyword_pr_to_issue"
] | 747b15e1c2fd3eef8fde54b06f86c6077fadec0f | 7c3641bcef717ffa7d765f2c86b847d0aab1aac9 | [
"I have the same issue on upgrade. I believe the issue is using `spy(mock(Foo.class))` - I see this in your upgrade and in the test that failed on my upgrade. I removed the outer `spy()` and my test works as expected again. Spying on a mock doesn't make sense, I don't think - imo Mockito should error in this scenar... | [] | 2023-04-25T16:23:44Z | [
"please contribute"
] | Verify on Spy Interface incorrect count of actual invocation | Hi,
At first, thanks for this awesome library.
During a migration from mockito 4.4.0 to mockito 5.1.1 one of my test began to fail.
It reported that the spied mock has 2 call one a method instead of one.
I figured that it has something to do with the new default [mockmaker](https://github.com/mockito/mock... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/test/java/org/mockitousage/constructor/CreatingMocksWithConstructorTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 428655e4a8..e97adac6cf 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -10,6 +10,7 @@
import org.mockito.internal.creation.MockSettingsImpl;
import org.mockito.interna... | diff --git a/src/test/java/org/mockitousage/constructor/CreatingMocksWithConstructorTest.java b/src/test/java/org/mockitousage/constructor/CreatingMocksWithConstructorTest.java
index a70b5b25cc..76dbacbad1 100644
--- a/src/test/java/org/mockitousage/constructor/CreatingMocksWithConstructorTest.java
+++ b/src/test/java/... | train | test | 2023-04-30T20:07:16 | 2023-02-17T15:21:23Z | bmaggi | train |
mockito/mockito/2998_3003 | mockito/mockito | mockito/mockito/2998 | mockito/mockito/3003 | [
"keyword_pr_to_issue"
] | 6e0c22890a5da72f4a919ede3fb2ae25b9eeab8e | e90aa5eba206d4906d10ae09920d1eb6bd198d70 | [
"This breaking change is listed in the release notes of Mockito 5: https://github.com/mockito/mockito/releases/tag/v5.0.0",
"@hensan64 Good catch on the wrong JavaDoc for these methods. Let me add these caveats to the JavaDoc."
] | [] | 2023-05-07T09:40:29Z | [] | Mockito 5 any() does not match a vararg int[] argument anymore. I need to use any(int[].class) to get the ArgumentMatcher to work | Mockito 5.2.0/5.3.1 any() ArgumentMatcher does not match a vararg int[] argument anymore.
I need to use any(int[].class) to get the ArgumentMatcher to work.
This mocking does NOT WORK:
when(myMock.myMethod(eq(myOtherMock), any()).thenReturn(myResultMap);
This mocking DOES WORK:
when(myMock.myMethod(eq(myOtherM... | [
"src/main/java/org/mockito/ArgumentMatchers.java"
] | [
"src/main/java/org/mockito/ArgumentMatchers.java"
] | [] | diff --git a/src/main/java/org/mockito/ArgumentMatchers.java b/src/main/java/org/mockito/ArgumentMatchers.java
index 6e83f8e847..05580a7c29 100644
--- a/src/main/java/org/mockito/ArgumentMatchers.java
+++ b/src/main/java/org/mockito/ArgumentMatchers.java
@@ -115,7 +115,7 @@
public class ArgumentMatchers {
/**
-... | null | train | test | 2023-05-06T16:04:27 | 2023-05-03T19:35:58Z | hensan64 | train |
mockito/mockito/2955_3020 | mockito/mockito | mockito/mockito/2955 | mockito/mockito/3020 | [
"keyword_pr_to_issue"
] | 296a25799365dd6c8ee78704dd3bc1a201d323df | 2280cac9ebb5849165731040eb9d720525ee9edb | [
"@ByoungJoonIm Feel free to send us a PR that fixes this.",
"Hi I made a pr that fixes this, thank you"
] | [] | 2023-05-25T16:32:27Z | [
"please contribute"
] | Function name is incorrect. | I saw [DoAnswerStyleStubbing](https://github.com/mockito/mockito/blob/96eb5e0cbff80a1545b1093db1baf4e33a2041e7/src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java#L27-L29) class code.
I thought that below is correct.
```java
boolean isSet() {
return !answers.isEmpty();
}
```
After execut... | [
"src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java"
] | [
"src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java b/src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java
index e143379362..c15fc025b4 100644
--- a/src/main/java/org/mockito/internal/stubbing/DoAnswerStyleStubbing.java
+++ b/src/main/java/org/mockito/internal/stubbing/... | null | val | test | 2023-05-24T22:14:52 | 2023-03-31T03:59:06Z | ByoungJoonIm | train |
mockito/mockito/3031_3032 | mockito/mockito | mockito/mockito/3031 | mockito/mockito/3032 | [
"keyword_pr_to_issue"
] | be9809086b74390ef05ab413801209954d2a4a6a | 5daf51ada3dc6bff5073683105fe7130aeff787d | [
"Thank you!\r\n"
] | [] | 2023-06-07T23:26:54Z | [] | Documentation about MockMakers slightly outdated in some places | There are some places that say "subclass mockMaker is the default" or "in the future, inline will be the default", e.g.
- https://javadoc.io/static/org.mockito/mockito-core/5.3.1/org/mockito/Mockito.html#mock_maker_plugin ("proxy generation engine" sounds wrong)
- https://javadoc.io/static/org.mockito/mockito-core... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java"
] | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 8336c81bfa..98c46e1c80 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -162,7 +162,8 @@
* }
* </code></pre>
*
- * Be aware that this artifact may be abolished when... | null | train | test | 2023-06-03T07:55:11 | 2023-06-07T16:09:38Z | mr1chter | train |
mockito/mockito/3046_3060 | mockito/mockito | mockito/mockito/3046 | mockito/mockito/3060 | [
"keyword_pr_to_issue"
] | 69e0a6c54f21ae26f5bd7927e8326bd567934fef | f008531496ac1d22a7356a4a51018d248dd04e9b | [
"Yes that is certainly true. Do you mind sending us a PR to improve the wording?"
] | [] | 2023-07-13T11:02:32Z | [] | Mockito#reset Condescending Documentation | Hello,
I just realised that the method `Mockito.reset()` existed at all. The documentation in the most recent version states:
> Smart Mockito users hardly use this feature because they know it could be a sign of poor tests.
At the core, I totally agree, this shouldn't be necessary. Nevertheless, the first sen... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 98c46e1c80..ee5a133038 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -749,7 +749,7 @@
*
* <h3 id="17">17. <a class="meaningful_link" href="#resetting_mocks" name="... | null | val | test | 2023-07-08T21:59:41 | 2023-06-28T09:56:06Z | Blafasel3 | train |
mockito/mockito/3077_3078 | mockito/mockito | mockito/mockito/3077 | mockito/mockito/3078 | [
"keyword_pr_to_issue"
] | f5ad9e9f9a338bcea6180fc474a562acc13f2c84 | ece6107a22f0e4ea89dca7a9cfd7791f6a362a26 | [
"I've held off on providing a reproducible example as I hope the description is clear enough; can give it a shot if more detail is required, though.",
"Added a unit test case to #3078 that gives a decent picture of what this describes, but without some of the outer context (e.g., Gradle and JUnit exclusion catego... | [
"Why does this need to be `volatile`? We try to stay away of that as much as we can, as multi-threading is already a difficult story with Mockito. As I see it, there is no need for this to be shared across instances, so I think this is not necessary?",
"Ah thanks, good catch! I wasn't familiar with the threading ... | 2023-08-04T17:31:09Z | [] | Unused stubbings are not reported when filters are used | Unused stubbings are not reported when a filter is used during the test run. This is documented clearly in the [StrictRunner class](https://github.com/mockito/mockito/blob/f5ad9e9f9a338bcea6180fc474a562acc13f2c84/src/main/java/org/mockito/internal/runners/StrictRunner.java#L47-L52):
```java
// only report when:
//... | [
"src/main/java/org/mockito/internal/runners/StrictRunner.java"
] | [
"src/main/java/org/mockito/internal/runners/StrictRunner.java"
] | [
"src/test/java/org/mockitousage/junitrunner/StrictRunnerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/runners/StrictRunner.java b/src/main/java/org/mockito/internal/runners/StrictRunner.java
index b3ea7749b0..b57b7c0c49 100644
--- a/src/main/java/org/mockito/internal/runners/StrictRunner.java
+++ b/src/main/java/org/mockito/internal/runners/StrictRunner.java
@@ -16,7 +16,... | diff --git a/src/test/java/org/mockitousage/junitrunner/StrictRunnerTest.java b/src/test/java/org/mockitousage/junitrunner/StrictRunnerTest.java
index 47ed6886e6..87700bd43a 100644
--- a/src/test/java/org/mockitousage/junitrunner/StrictRunnerTest.java
+++ b/src/test/java/org/mockitousage/junitrunner/StrictRunnerTest.ja... | val | test | 2023-08-02T21:57:05 | 2023-08-04T16:45:32Z | C0urante | train |
mockito/mockito/3035_3095 | mockito/mockito | mockito/mockito/3035 | mockito/mockito/3095 | [
"keyword_pr_to_issue"
] | 076e8ac837c17e81347854feaad69687cd7d2b83 | 741fe8102eba820dcabc66f57ce9f5bb82694120 | [
"I have opened the PR #3095, which would ease this issue, by changing the locking scheme in TypeCachingBytecodeGenerator from a single global lock to cacheLocks with size 16.\r\nThe used TypeCachingLock from cacheLocks depends on the hashcode of MockitoMockKey, which aggregates the types and\r\nsettings to mock.\r\... | [] | 2023-08-17T18:03:51Z | [] | Excessive locking in TypeCachingBytecodeGenerator#BOOTSTRAP_LOCK | The TypeCachingBytecodeGenerator#BOOTSTRAP_LOCK is resulting in excessive BLOCKED threads when running several thousand tests concurrently. Byte-buddy TypeCache's findOrInsert without monitor seems to handle concurrency. Is this global lock needed ?
Mockito-Inline 4.10, Byte-Buddy 1.12.19
`
"ForkJoinPool-1-work... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java"
] | [
"src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java b/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java
index 30ed949bf5..3a8af3afa7 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/TypeCachingBytecodeGenerator.java... | diff --git a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java b/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBytecodeGeneratorTest.java
index 026fba3bfb..56878b8cc8 100644
--- a/src/test/java/org/mockito/internal/creation/bytebuddy/TypeCachingMockBy... | train | test | 2023-08-17T21:50:59 | 2023-06-10T01:19:59Z | aswath80 | train |
mockito/mockito/2865_3097 | mockito/mockito | mockito/mockito/2865 | mockito/mockito/3097 | [
"keyword_pr_to_issue"
] | c637192ccca905fab8f58bdb967f1e9e061cd590 | 63d1cd405066886c6fb041ecc1ae502fe4b8a782 | [
"This should have been covered in https://github.com/mockito/mockito/blob/0aba0d5b031b4282c9b6686add2b443bda761817/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java#L132 but I am not sure why that is breaking. #2731 is supposed to tackle that, but it needs to be rebased. Feel free t... | [
"In this answer, on line 68 we already call `delegate().answer()` where the delegate is `ReturnsEmptyValues`. This class in turn already returns an empty optional: https://github.com/mockito/mockito/blob/076e8ac837c17e81347854feaad69687cd7d2b83/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmpty... | 2023-08-17T19:53:16Z | [
"please contribute"
] | Default mock of `Optional` is not `empty` when using `RETURN_DEEP_STUBS` | Version affected: Mockito: 4.x & 5.x
If you create a mock with `RETURN_DEEP_STUBS`, then any method that returns a collection will, by default, return an empty collection, i.e. `isEmpty` returns `true`, etc. This is great, as it means no additional configuration of the mock is required before passing to logic that ... | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java",
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsEmptyValues.java"
] | [
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsOptionalMocksTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java
index 8356c1b79b..27faed9d9a 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsDeepStubs.java
+++ b/src/main/java/... | diff --git a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsOptionalMocksTest.java b/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsOptionalMocksTest.java
new file mode 100644
index 0000000000..3364b6d984
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/defaultanswer... | train | test | 2023-08-22T10:16:19 | 2023-01-14T11:36:42Z | big-andy-coates | train |
mockito/mockito/3128_3129 | mockito/mockito | mockito/mockito/3128 | mockito/mockito/3129 | [
"keyword_pr_to_issue"
] | edc624371009ce981bbc11b7d125ff4e359cff7e | fb48e093c06c2a0ee45f432cc12d8328ebd73e6d | [
"Yes I think that's fair to publicly expose, as users already interact with it via the resources. E.g. the names are already part of the public api there."
] | [
"This is a good test case, but needs to be in a separate test method.",
"Should we mark this one deprecated in favor of this new method?",
"This interface can be implemented, meaning that we can break downstream projects. We should add a default implementation and probably also mark this interface with `@NotExt... | 2023-10-05T06:42:58Z | [] | Make MockUtil.getMockMaker() public or public Mockito API | **Proposal:**
Make the method `org.mockito.internal.util.MockUtil.getMockMaker(String)` public or better part of the public Mockito Plugin-API.
The existing `org.mockito.plugins.MockitoPlugins.getInlineMockMaker()` creates a new `mock-maker-inline` instance when called.
**Reason:**
I am currently working on a... | [
"src/main/java/org/mockito/internal/configuration/plugins/DefaultMockitoPlugins.java",
"src/main/java/org/mockito/internal/util/MockUtil.java",
"src/main/java/org/mockito/plugins/MockitoPlugins.java"
] | [
"src/main/java/org/mockito/internal/configuration/plugins/DefaultMockitoPlugins.java",
"src/main/java/org/mockito/internal/util/MockUtil.java",
"src/main/java/org/mockito/plugins/MockitoPlugins.java"
] | [
"src/test/java/org/mockito/internal/configuration/plugins/DefaultMockitoPluginsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/plugins/DefaultMockitoPlugins.java b/src/main/java/org/mockito/internal/configuration/plugins/DefaultMockitoPlugins.java
index 365c350e93..c7644257fb 100644
--- a/src/main/java/org/mockito/internal/configuration/plugins/DefaultMockitoPlugins.java
+++ b/src/m... | diff --git a/src/test/java/org/mockito/internal/configuration/plugins/DefaultMockitoPluginsTest.java b/src/test/java/org/mockito/internal/configuration/plugins/DefaultMockitoPluginsTest.java
index 61fc8e8ed1..01024f6275 100644
--- a/src/test/java/org/mockito/internal/configuration/plugins/DefaultMockitoPluginsTest.java... | train | test | 2023-10-03T21:04:27 | 2023-10-04T13:47:45Z | AndreasTu | train |
mockito/mockito/1382_3133 | mockito/mockito | mockito/mockito/1382 | mockito/mockito/3133 | [
"keyword_pr_to_issue"
] | edc624371009ce981bbc11b7d125ff4e359cff7e | 6f4eb023ac76f2d59020f59a5a8e8c602a094235 | [
"Is there any update on this issue? \r\n\r\nIt would be very handy to write following with Junit 5:\r\n\r\n```java\r\n@Test\r\nvoid test( @Mock ClassToMock mock, @Captor ArgumentCaptor<String> argument )\r\n{\r\n verify( mock ).doStuff( argument.capture() );\r\n}\r\n```\r\n\r\nUnfortunately, this does not work be... | [] | 2023-10-05T19:45:36Z | [
"please contribute"
] | Support @Captor injection in JUnit 5 method parameters | There is already an open PR #1350 that proposes and adds support for `@Mock`. This issue is to extend on that PR if / when it gets merged to also support the `@Captor` annotation in method parameters. This would allow to inject method specific generic `ArgumentCaptor` that can't be caught with `ArgumentCaptor.of(Class)... | [
"src/main/java/org/mockito/Captor.java",
"src/main/java/org/mockito/internal/configuration/CaptorAnnotationProcessor.java",
"src/main/java/org/mockito/internal/util/reflection/GenericMaster.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java"
] | [
"src/main/java/org/mockito/Captor.java",
"src/main/java/org/mockito/internal/configuration/CaptorAnnotationProcessor.java",
"src/main/java/org/mockito/internal/util/reflection/GenericMaster.java",
"subprojects/junit-jupiter/src/main/java/org/mockito/junit/jupiter/MockitoExtension.java",
"subprojects/junit-j... | [
"subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java"
] | diff --git a/src/main/java/org/mockito/Captor.java b/src/main/java/org/mockito/Captor.java
index 0de9f72b2e..cedd60e242 100644
--- a/src/main/java/org/mockito/Captor.java
+++ b/src/main/java/org/mockito/Captor.java
@@ -46,6 +46,6 @@
* @since 1.8.3
*/
@Retention(RetentionPolicy.RUNTIME)
-@Target(ElementType.FIELD)
... | diff --git a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java b/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
index 31abe2e610..8ecd9d223a 100644
--- a/subprojects/junit-jupiter/src/test/java/org/mockitousage/JunitJupiterTest.java
+++ b/subprojects/junit-ju... | val | test | 2023-10-03T21:04:27 | 2018-05-07T17:49:43Z | filiphr | train |
mockito/mockito/2984_3167 | mockito/mockito | mockito/mockito/2984 | mockito/mockito/3167 | [
"keyword_pr_to_issue"
] | b6554b29ed6c204a0dd4b8a670877fe0ba2e808b | 74633b856efa0bba224ff74db6c75f58d3afe413 | [
"The working code fails if `answer` is changed to `RETURNS_DEEP_STUBS`",
"@SenorPez Can you please provide a full running sample including the referenced classes and enums.\r\nI can't reproduce your issue. \r\n\r\nMy Test class is working as expected:\r\n\r\n```java \r\npublic class DeepStubReturnsEnumTest {\r\n\... | [
"Instead of a new sourceset on the main project, let's define a separate subproject for this. Instead of setting to 17 (which is non-LTS), let's use 21 for this. E.g. create `subprojects/java21`. We can use it for #3167 as well",
"Rather than swallowing the exception here, I would prefer to always throw the excep... | 2023-11-02T09:19:58Z | [] | Deep Stubs Incompatible With Mocking Enum | **The following code works:**
```
@ExtendWith(MockitoExtension.class)
class BoardTest {
@Mock
Piece piece;
private Board instance;
@BeforeEach
void setUp() {
instance = new Board(piece, 10);
}
@Test
void getCostPerSpace() {
when(piece.getPiece()).then... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java"
] | [
"src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava11Test.java",
"subprojects/java21/src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava21Test.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java
index 4cb0b40c0f..e03d11b9e3 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMo... | diff --git a/src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava11Test.java b/src/test/java/org/mockito/internal/stubbing/answers/DeepStubReturnsEnumJava11Test.java
new file mode 100644
index 0000000000..70b7b54968
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/answers/DeepStubR... | train | test | 2023-11-28T07:57:26 | 2023-04-22T03:31:05Z | SenorPez | train |
mockito/mockito/3160_3173 | mockito/mockito | mockito/mockito/3160 | mockito/mockito/3173 | [
"keyword_pr_to_issue"
] | bfee15dda7acc41ef497d8f8a44c74dacce2933a | b6554b29ed6c204a0dd4b8a670877fe0ba2e808b | [] | [] | 2023-11-20T04:31:24Z | [] | Annotation-based spying on a generic class breaks existing final/inline Spies | Hello,
I encountered an issue with JUnit5/Mockito when using `@Spy` annotation with generic types.
Such configuration seems to break existing spies of Java `record` instances (inline mocks). The issue also occurs when using `Mockito.spy()` directly instead of the `@Spy` annotation. Example:
```java
@ExtendWith(... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java"
] | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java"
] | [
"subprojects/java21/src/test/java/org/mockito/java21/RecordTest.java"
] | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMockMaker.java
index 227df4cd15..4cb0b40c0f 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InlineDelegateByteBuddyMo... | diff --git a/subprojects/java21/src/test/java/org/mockito/java21/RecordTest.java b/subprojects/java21/src/test/java/org/mockito/java21/RecordTest.java
new file mode 100644
index 0000000000..ba69b7a9d3
--- /dev/null
+++ b/subprojects/java21/src/test/java/org/mockito/java21/RecordTest.java
@@ -0,0 +1,26 @@
+/*
+ * Copyri... | test | test | 2023-11-27T23:30:52 | 2023-10-27T14:59:50Z | matej-staron | train |
mockito/mockito/3179_3180 | mockito/mockito | mockito/mockito/3179 | mockito/mockito/3180 | [
"keyword_pr_to_issue"
] | ed1019560452f1723ee5d1fe66667aee88e696cb | a0cc22d73c184d0367f38c4d4d34de71c030c9b7 | [] | [] | 2023-11-27T00:52:11Z | [] | Need separate module for java 21 tests | As requested [here](https://github.com/mockito/mockito/pull/3173#issuecomment-1826754327) and [here](https://github.com/mockito/mockito/pull/3167#discussion_r1405377557), Mockito would benefit from a separate module with java 21 language level for testing newer language features that aren't available in Java 11.
Not... | [
"settings.gradle.kts"
] | [
"settings.gradle.kts",
"subprojects/java21/java21.gradle"
] | [] | diff --git a/settings.gradle.kts b/settings.gradle.kts
index ecc1e15460..b90dea2ee6 100644
--- a/settings.gradle.kts
+++ b/settings.gradle.kts
@@ -22,7 +22,8 @@ include(
"osgi-test",
"bom",
"errorprone",
- "programmatic-test"
+ "programmatic-test",
+ "java21"
)
// https://developer.android.c... | null | val | test | 2023-11-23T20:05:15 | 2023-11-27T00:36:53Z | LeMikaelF | train |
kestra-io/kestra/22_27 | kestra-io/kestra | kestra-io/kestra/22 | kestra-io/kestra/27 | [
"keyword_pr_to_issue"
] | 5b4706feb5b56f1e3c7e083f6cee0980ec2aa824 | 1b93e3987a5934f25f2429eeccfcd546d2ebd3fe | [] | [] | 2020-01-13T15:33:33Z | [
"bug"
] | Trigger execution from webui don't display the execution when some lag | When we create the execution from the webui, the execution is created and return directly.
But the indexer could not have the time to index the execution on the backend.
This lead by a 404 on `/api/v1/executions/{{executionId}}` and the ui freeze here.
Difficult use case here, I think the better will be to use o... | [
"ui/src/components/executions/ExecutionRoot.vue",
"ui/src/components/executions/Overview.vue",
"ui/src/components/flows/ExecutionConfiguration.vue"
] | [
"ui/src/components/executions/ExecutionRoot.vue",
"ui/src/components/executions/Overview.vue",
"ui/src/components/flows/ExecutionConfiguration.vue"
] | [] | diff --git a/ui/src/components/executions/ExecutionRoot.vue b/ui/src/components/executions/ExecutionRoot.vue
index fbd5d94cb5..c906e692d5 100644
--- a/ui/src/components/executions/ExecutionRoot.vue
+++ b/ui/src/components/executions/ExecutionRoot.vue
@@ -24,6 +24,7 @@ import Trigger from "vue-material-design-icons/Cogs... | null | train | train | 2020-01-13T16:11:36 | 2020-01-07T20:51:26Z | tchiotludo | train |
kestra-io/kestra/59_63 | kestra-io/kestra | kestra-io/kestra/59 | kestra-io/kestra/63 | [
"keyword_pr_to_issue"
] | dd8937bf77e3a20dc6d636045a9b6bf3c284e089 | e34062bc2cf3a98fcba07926f51709299e348ba8 | [] | [] | 2020-02-11T12:54:20Z | [] | Execution Ui : 2 call to ExecutionController not needed any more | on 49f829e, we introduced a new feature that return last execution if terminated on `executions/{executionId}/follow`, we don't need anymore to call `executions/{executionId}` | [
"ui/src/components/executions/ExecutionRoot.vue"
] | [
"ui/src/components/executions/ExecutionRoot.vue"
] | [] | diff --git a/ui/src/components/executions/ExecutionRoot.vue b/ui/src/components/executions/ExecutionRoot.vue
index 0990bda65b..b848cd263e 100644
--- a/ui/src/components/executions/ExecutionRoot.vue
+++ b/ui/src/components/executions/ExecutionRoot.vue
@@ -45,9 +45,6 @@ export default {
};
},
created()... | null | train | train | 2020-02-11T13:46:39 | 2020-02-10T11:24:49Z | tchiotludo | train |
kestra-io/kestra/61_68 | kestra-io/kestra | kestra-io/kestra/61 | kestra-io/kestra/68 | [
"keyword_pr_to_issue"
] | e80c6bbd3c5859d662ef5b67ce568efa4f1ff48f | 70b4097a2a0bd37695c11e654cc3ef2081436ecc | [
"The ui logic must follow backen constraints. So we have to define the appropriate behavior.\r\n\r\nFor this issue we can :\r\n* Allo id change ( which is obviously not what is possible and desired now)\r\n* Clone flow with new name ans ns on clone operation\r\n* Clone and delete flow\r\n* Manage virtual flows or ... | [
"add revision also here please :) ",
"done !"
] | 2020-02-13T20:10:35Z | [] | Update a flow and changing id or namespace failed | Changing the namespace or the id will led to a 404 on the update from the webui.
It's a normal behaviour on the `FlowControler` we ask and update on a flow that don't exists.
This led to 2 issues :
* 404 are not catch and loading bar keep growing, this must be capture and displayed as error.
* How can we renam... | [
"ui/src/components/flows/FlowEdit.vue"
] | [
"ui/src/components/flows/FlowEdit.vue"
] | [] | diff --git a/ui/src/components/flows/FlowEdit.vue b/ui/src/components/flows/FlowEdit.vue
index 57a2c7ae42..c7d2b183c8 100644
--- a/ui/src/components/flows/FlowEdit.vue
+++ b/ui/src/components/flows/FlowEdit.vue
@@ -42,14 +42,28 @@ export default {
},
data() {
return {
- content: ""
+ ... | null | train | train | 2020-02-19T22:41:22 | 2020-02-10T12:29:14Z | tchiotludo | train |
kestra-io/kestra/84_89 | kestra-io/kestra | kestra-io/kestra/84 | kestra-io/kestra/89 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.8891556077077057)"
] | c427540b35e8ad49646f74fdb7862dd0b18a0867 | bf3a60628a7ddeb5b47cef3cd64118b8d5d7daf3 | [
"we should have automatic tests for this in CI. I will fix this and produce tests.",
":+1: "
] | [] | 2020-03-11T10:21:38Z | [
"bug"
] | Flow page: empty page on nav click | Switching between tabs on flow page lead to an empty page :
We need to press F5 to have the current page displayed well | [
"ui/src/components/flows/FlowEdit.vue"
] | [
"ui/src/components/flows/FlowEdit.vue"
] | [] | diff --git a/ui/src/components/flows/FlowEdit.vue b/ui/src/components/flows/FlowEdit.vue
index 3b9a259a75..84765d0a61 100644
--- a/ui/src/components/flows/FlowEdit.vue
+++ b/ui/src/components/flows/FlowEdit.vue
@@ -170,9 +170,6 @@ export default {
});
}
}
- },
- destroye... | null | test | train | 2020-03-11T11:02:02 | 2020-03-09T08:34:55Z | tchiotludo | train |
kestra-io/kestra/106_113 | kestra-io/kestra | kestra-io/kestra/106 | kestra-io/kestra/113 | [
"keyword_pr_to_issue"
] | 00bb7b9aff548633c21c6ef78a669daef5b64dcf | e7b858ca8d914cae736f11043adb97f57ad4600c | [] | [] | 2020-05-20T13:29:15Z | [
"bug"
] | Flow list page don't allow pagination & sort | On flow page (home) :
* The pagination is not working
* The sort is not working also | [
"core/src/main/java/org/kestra/core/services/FlowService.java"
] | [
"core/src/main/java/org/kestra/core/services/FlowService.java"
] | [] | diff --git a/core/src/main/java/org/kestra/core/services/FlowService.java b/core/src/main/java/org/kestra/core/services/FlowService.java
index d1ba9bb3d1..161818a89e 100644
--- a/core/src/main/java/org/kestra/core/services/FlowService.java
+++ b/core/src/main/java/org/kestra/core/services/FlowService.java
@@ -38,7 +38,... | null | val | train | 2020-05-14T11:32:12 | 2020-04-20T11:09:58Z | tchiotludo | train |
kestra-io/kestra/107_116 | kestra-io/kestra | kestra-io/kestra/107 | kestra-io/kestra/116 | [
"keyword_pr_to_issue"
] | 7fd66b192b18a0194be3bfc5d7371c74e14367c2 | 81c90600a475440260f7630b5cd018aef1e8887a | [
"@tchiotludo it's good for this version.\r\nfor now the chart bar click redirects to execution page with state selection using a the dedicated status filter select. But it still filters execution using the free search bar.\r\nGoing a step beyond will be done in issue https://github.com/kestra-io/kestra/issues/124\r... | [] | 2020-05-28T06:57:42Z | [] | Flow list : allow to filter execution based on status directly on flow list | we are displaying usefull stats on flow list page.
It can be really useful to have a link directly on execution from this charts.
* The lowest effort will be to go to execution filter for current date.
... | [
"core/src/main/java/org/kestra/core/repositories/ExecutionRepositoryInterface.java",
"repository-elasticsearch/src/main/java/org/kestra/repository/elasticsearch/ElasticSearchExecutionRepository.java",
"repository-memory/src/main/java/org/kestra/repository/memory/MemoryExecutionRepository.java",
"ui/src/compon... | [
"core/src/main/java/org/kestra/core/repositories/ExecutionRepositoryInterface.java",
"repository-elasticsearch/src/main/java/org/kestra/repository/elasticsearch/ElasticSearchExecutionRepository.java",
"repository-memory/src/main/java/org/kestra/repository/memory/MemoryExecutionRepository.java",
"ui/src/compon... | [] | diff --git a/core/src/main/java/org/kestra/core/repositories/ExecutionRepositoryInterface.java b/core/src/main/java/org/kestra/core/repositories/ExecutionRepositoryInterface.java
index b808b9954f..7258e48e63 100644
--- a/core/src/main/java/org/kestra/core/repositories/ExecutionRepositoryInterface.java
+++ b/core/src/ma... | null | test | train | 2020-06-22T14:30:23 | 2020-04-20T11:18:01Z | tchiotludo | train |
kestra-io/kestra/108_129 | kestra-io/kestra | kestra-io/kestra/108 | kestra-io/kestra/129 | [
"keyword_pr_to_issue"
] | 26aaaaf5c9b9127254aad4780cf5b1ea4dbbbb5e | 3f257797d37f6af2c4ba0aecf9ba2383b5aca273 | [
"don't work as expected : `each-sequential-nested` are displayed like : \r\n\r\n\r\nbut the 2 one are sequential :thinking: "
] | [] | 2020-06-27T13:13:43Z | [
"bug"
] | Dag view : first sequential flow are displayed parallel | Example with this flow : http://kestra:8080/ui/flows/org.kestra.tests/inputs?tab=overview
All tasks are sequential, tree seems to be good :
```json
{
"folded": false,
"task": {
... | [
"ui/src/components/graph/TopologyTree.vue"
] | [
"ui/src/components/graph/TopologyTree.vue"
] | [] | diff --git a/ui/src/components/graph/TopologyTree.vue b/ui/src/components/graph/TopologyTree.vue
index efef4dc457..c6b2b1f37e 100644
--- a/ui/src/components/graph/TopologyTree.vue
+++ b/ui/src/components/graph/TopologyTree.vue
@@ -57,15 +57,15 @@ import VectorCircle from "vue-material-design-icons/Circle";
const paren... | null | val | train | 2020-06-26T10:31:21 | 2020-04-20T13:02:09Z | tchiotludo | train |
kestra-io/kestra/128_131 | kestra-io/kestra | kestra-io/kestra/128 | kestra-io/kestra/131 | [
"keyword_pr_to_issue"
] | 26aaaaf5c9b9127254aad4780cf5b1ea4dbbbb5e | d99dff1c8c12cd9fe920f5bef54329b8d2fb22b6 | [] | [] | 2020-06-27T13:38:39Z | [] | Input values are not well displayed | this part is wrong :
```html
<template v-slot:cell(value)="row">
<span
v-if="['string', 'optional', 'float', 'int', 'instant'].includes(row.item.key)"
>{{row.item.value}}</span>
<b-link
... | [
"ui/src/components/executions/Overview.vue"
] | [
"ui/src/components/executions/Overview.vue"
] | [] | diff --git a/ui/src/components/executions/Overview.vue b/ui/src/components/executions/Overview.vue
index d4964a3925..f07fec6288 100644
--- a/ui/src/components/executions/Overview.vue
+++ b/ui/src/components/executions/Overview.vue
@@ -28,15 +28,13 @@
class="mb-0"
>
<templa... | null | test | train | 2020-06-26T10:31:21 | 2020-06-25T12:03:43Z | tchiotludo | train |
kestra-io/kestra/1_156 | kestra-io/kestra | kestra-io/kestra/1 | kestra-io/kestra/156 | [
"keyword_pr_to_issue"
] | afc2c85ec8cda42690a21d8ce4bfaf850e1aee0e | 378ad0a7c88ca51dad1adc78323d15f2b25119f7 | [] | [] | 2020-09-12T09:01:06Z | [
"enhancement"
] | This is a test issue to validate my self hosted instance | ```yaml
id: errors
namespace: org.floworc.tests
tasks:
- id: failed
type: org.floworc.core.tasks.scripts.Bash
commands:
- 'exit 1'
errors:
- id: 2nd
type: org.floworc.core.tasks.debugs.Echo
format: second {{task.id}}
```
The errors will not be triggers, need to be global to work or on... | [
"core/src/main/java/org/kestra/core/models/tasks/Task.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachSequential.java",
"core/src/main/java/org/kestra/core/tasks/flows/Sequential.java",
"core/src/main/java/org/kestra/core/tasks/flows/Switch.java"
] | [
"core/src/main/java/org/kestra/core/models/tasks/Task.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachSequential.java",
"core/src/main/java/org/kestra/core/tasks/flows/Sequential.java",
"core/src/main/java/org/kestra/core/tasks/flows/Switch.java"
] | [
"core/src/test/resources/flows/valids/all-flowable.yaml"
] | diff --git a/core/src/main/java/org/kestra/core/models/tasks/Task.java b/core/src/main/java/org/kestra/core/models/tasks/Task.java
index 5617726de5..d85255fecd 100644
--- a/core/src/main/java/org/kestra/core/models/tasks/Task.java
+++ b/core/src/main/java/org/kestra/core/models/tasks/Task.java
@@ -43,9 +43,6 @@ abstrac... | diff --git a/core/src/test/resources/flows/valids/all-flowable.yaml b/core/src/test/resources/flows/valids/all-flowable.yaml
index c95a7e962f..17984a8ddc 100644
--- a/core/src/test/resources/flows/valids/all-flowable.yaml
+++ b/core/src/test/resources/flows/valids/all-flowable.yaml
@@ -19,15 +19,10 @@ tasks:
... | val | train | 2020-09-10T19:33:25 | 2019-11-27T17:43:51Z | tchiotludo | train |
kestra-io/kestra/193_196 | kestra-io/kestra | kestra-io/kestra/193 | kestra-io/kestra/196 | [
"keyword_pr_to_issue"
] | 81ff922634e50ffd27c64a12fbaec50353e8e31a | 214bf2b3c51bc3b1016407278360ec55573fcac7 | [] | [] | 2020-11-03T14:16:46Z | [
"bug"
] | Execution / TaskRun list : remove click on status button | [
"ui/src/components/executions/Executions.vue"
] | [
"ui/src/components/executions/Executions.vue"
] | [] | diff --git a/ui/src/components/executions/Executions.vue b/ui/src/components/executions/Executions.vue
index b9522c106c..905f9e2b7f 100644
--- a/ui/src/components/executions/Executions.vue
+++ b/ui/src/components/executions/Executions.vue
@@ -46,7 +46,6 @@
</template>
<template... | null | test | train | 2020-11-03T14:50:18 | 2020-11-02T17:48:08Z | tchiotludo | train | |
kestra-io/kestra/229_230 | kestra-io/kestra | kestra-io/kestra/229 | kestra-io/kestra/230 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9214185093816237)"
] | 213317cb1c7eeb758786c2284195f39abc408e34 | b93f0988909625a3f3273e544c0ec27fd8448529 | [] | [] | 2020-11-26T20:08:08Z | [
"bug",
"backend"
] | Remove trigger last execution when we remove the trigger | When the user remove a trigger the last trigger is not removed.
If the user recreate the same trigger, the previous value is kept and the backfill will start previous date.
Just delete the lastrigger on this case to reset all previous job | [
"core/src/main/java/org/kestra/core/models/triggers/Trigger.java",
"core/src/main/java/org/kestra/core/queues/QueueInterface.java",
"core/src/main/java/org/kestra/core/services/FlowService.java",
"indexer-kafka-elasticsearch/src/main/java/org/kestra/indexer/KafkaElasticIndexer.java",
"repository-elasticsear... | [
"core/src/main/java/org/kestra/core/models/triggers/Trigger.java",
"core/src/main/java/org/kestra/core/queues/QueueInterface.java",
"core/src/main/java/org/kestra/core/services/FlowService.java",
"core/src/main/java/org/kestra/core/utils/ListUtils.java",
"indexer-kafka-elasticsearch/src/main/java/org/kestra... | [
"core/src/test/java/org/kestra/core/repositories/AbstractFlowRepositoryTest.java",
"indexer-kafka-elasticsearch/src/test/java/org/kestra/indexer/KafkaElasticIndexerTest.java"
] | diff --git a/core/src/main/java/org/kestra/core/models/triggers/Trigger.java b/core/src/main/java/org/kestra/core/models/triggers/Trigger.java
index ab54eddc00..86aa1599b2 100644
--- a/core/src/main/java/org/kestra/core/models/triggers/Trigger.java
+++ b/core/src/main/java/org/kestra/core/models/triggers/Trigger.java
@... | diff --git a/core/src/test/java/org/kestra/core/repositories/AbstractFlowRepositoryTest.java b/core/src/test/java/org/kestra/core/repositories/AbstractFlowRepositoryTest.java
index 802ac43880..1e78e978f5 100644
--- a/core/src/test/java/org/kestra/core/repositories/AbstractFlowRepositoryTest.java
+++ b/core/src/test/jav... | train | train | 2020-11-27T15:22:47 | 2020-11-26T14:57:56Z | tchiotludo | train |
kestra-io/kestra/227_232 | kestra-io/kestra | kestra-io/kestra/227 | kestra-io/kestra/232 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9383190619506541)"
] | e7ece58ac059c2c432d9bfe01628ae21ed7eb81a | bab9d3fa226bee47401ce7cde8bde889381d8d62 | [] | [] | 2020-12-01T14:44:17Z | [] | Allow Bash & Python task to have some outputs & metrics | For now, Bash & Python take the whole log as output.
This output is unusable and can crash the executor.
We need to remove the log from output !
But at the same time, we will let log special string that will be let have some outputs & metrics !
I think mostly to issue the same concept than [github actions](... | [
"core/src/main/java/org/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/org/kestra/core/tasks/scripts/Node.java",
"core/src/main/java/org/kestra/core/tasks/scripts/Python.java"
] | [
"core/src/main/java/org/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/org/kestra/core/tasks/scripts/Node.java",
"core/src/main/java/org/kestra/core/tasks/scripts/Python.java",
"core/src/main/resources/scripts/kestra.js",
"core/src/main/resources/scripts/kestra.py"
] | [
"core/src/test/java/org/kestra/core/docs/JsonSchemaGeneratorTest.java",
"core/src/test/java/org/kestra/core/tasks/BashTest.java",
"core/src/test/java/org/kestra/core/tasks/NodeTest.java",
"core/src/test/java/org/kestra/core/tasks/PythonTest.java",
"webserver/src/test/java/org/kestra/webserver/controllers/Pl... | diff --git a/core/src/main/java/org/kestra/core/tasks/scripts/AbstractBash.java b/core/src/main/java/org/kestra/core/tasks/scripts/AbstractBash.java
index 9e8ba3d02b..68728123ed 100644
--- a/core/src/main/java/org/kestra/core/tasks/scripts/AbstractBash.java
+++ b/core/src/main/java/org/kestra/core/tasks/scripts/Abstrac... | diff --git a/core/src/test/java/org/kestra/core/docs/JsonSchemaGeneratorTest.java b/core/src/test/java/org/kestra/core/docs/JsonSchemaGeneratorTest.java
index b45d64c140..0c88524d3a 100644
--- a/core/src/test/java/org/kestra/core/docs/JsonSchemaGeneratorTest.java
+++ b/core/src/test/java/org/kestra/core/docs/JsonSchema... | train | train | 2020-11-30T10:47:13 | 2020-11-25T19:52:17Z | tchiotludo | train |
kestra-io/kestra/223_238 | kestra-io/kestra | kestra-io/kestra/223 | kestra-io/kestra/238 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9406367837200768)"
] | e3a4219d56da8981f36265883c99b6049b9445a3 | 80bba59c7b069655a594a66df94f2e8f0f3d8fa2 | [] | [] | 2020-12-03T17:44:21Z | [
"bug",
"backend"
] | Prevent FlowableTask to hit Workers | For now, executor send FlowableTask to the WorkerTask queue and the worker will change it to RUNNING.
There is no need to have to hit worker for FlowableTask, so we need to keep it on the executor only for this.
Also it can have some side effect (WorkerInstance restarted, ...) | [
"runner-kafka/src/main/java/org/kestra/runner/kafka/KafkaExecutor.java",
"runner-kafka/src/main/java/org/kestra/runner/kafka/streams/DeduplicationTransformer.java",
"runner-kafka/src/main/java/org/kestra/runner/kafka/streams/ExecutionNextsDeduplicationTransformer.java",
"runner-memory/src/main/java/org/kestra... | [
"runner-kafka/src/main/java/org/kestra/runner/kafka/KafkaExecutor.java",
"runner-kafka/src/main/java/org/kestra/runner/kafka/streams/DeduplicationTransformer.java",
"runner-kafka/src/main/java/org/kestra/runner/kafka/streams/ExecutionNextsDeduplicationTransformer.java",
"runner-memory/src/main/java/org/kestra... | [] | diff --git a/runner-kafka/src/main/java/org/kestra/runner/kafka/KafkaExecutor.java b/runner-kafka/src/main/java/org/kestra/runner/kafka/KafkaExecutor.java
index 44bde4225f..9c712d0afa 100644
--- a/runner-kafka/src/main/java/org/kestra/runner/kafka/KafkaExecutor.java
+++ b/runner-kafka/src/main/java/org/kestra/runner/ka... | null | train | train | 2020-12-03T17:21:27 | 2020-11-24T10:16:03Z | tchiotludo | train |
kestra-io/kestra/226_239 | kestra-io/kestra | kestra-io/kestra/226 | kestra-io/kestra/239 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9079460917010321)"
] | 9018ba6bc418aa82c127a354ac6e59e645dcb7be | 1408bb3a4750efca1c9097b5680d0382ebe88b70 | [] | [] | 2020-12-03T20:24:50Z | [
"bug",
"backend"
] | Handle null value on Each | if you are using evaluation on Each `value`, sometime there can have a `null`.
You don't want this !
There will be `value` set to `[null]` and on child task `{{ taskrun.value }}` will not exist (the serialization will remove it).
If you must raise an exception if only null values | [
"core/src/main/java/org/kestra/core/exceptions/IllegalVariableEvaluationException.java",
"core/src/main/java/org/kestra/core/runners/AbstractExecutor.java",
"core/src/main/java/org/kestra/core/runners/FlowableUtils.java",
"runner-memory/src/main/java/org/kestra/runner/memory/MemoryExecutor.java"
] | [
"core/src/main/java/org/kestra/core/exceptions/IllegalVariableEvaluationException.java",
"core/src/main/java/org/kestra/core/runners/AbstractExecutor.java",
"core/src/main/java/org/kestra/core/runners/FlowableUtils.java",
"runner-memory/src/main/java/org/kestra/runner/memory/MemoryExecutor.java"
] | [
"core/src/test/java/org/kestra/core/Helpers.java",
"core/src/test/java/org/kestra/core/tasks/flows/EachSequentialTest.java",
"core/src/test/resources/flows/valids/each-null.yaml",
"runner-kafka/src/test/java/org/kestra/runner/kafka/KafkaRunnerTest.java",
"runner-kafka/src/test/resources/application.yml"
] | diff --git a/core/src/main/java/org/kestra/core/exceptions/IllegalVariableEvaluationException.java b/core/src/main/java/org/kestra/core/exceptions/IllegalVariableEvaluationException.java
index d5ce098205..9844269478 100644
--- a/core/src/main/java/org/kestra/core/exceptions/IllegalVariableEvaluationException.java
+++ b... | diff --git a/core/src/test/java/org/kestra/core/Helpers.java b/core/src/test/java/org/kestra/core/Helpers.java
index ada1667b9c..1be6e6e1a1 100644
--- a/core/src/test/java/org/kestra/core/Helpers.java
+++ b/core/src/test/java/org/kestra/core/Helpers.java
@@ -17,7 +17,7 @@
import java.util.function.BiConsumer;
publi... | train | train | 2020-12-03T21:40:28 | 2020-11-25T16:28:26Z | tchiotludo | train |
kestra-io/kestra/212_245 | kestra-io/kestra | kestra-io/kestra/212 | kestra-io/kestra/245 | [
"keyword_pr_to_issue"
] | 68dde209f3893f2f0835c6a5e62d2419a59e522f | e8d7a2ea2497294ee770338f20785580dcd7c62b | [] | [] | 2020-12-04T12:53:17Z | [
"backend"
] | Allow to iterate with an Each with object or KeyValue for example | For now, we can only iterate through a `List<String>` :
https://github.com/kestra-io/kestra/blob/6d33b89025b32becd1905c1b6ba5d1b3f4ec10b5/core/src/main/java/org/kestra/core/runners/FlowableUtils.java#L163
Some normal case can be to iterate through a `List<Object>` no matter the type, for example a Key Value and or q... | [
"core/src/main/java/org/kestra/core/runners/FlowableUtils.java",
"core/src/main/java/org/kestra/core/runners/handlebars/helpers/JsonHelper.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachParallel.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachSequential.java"
] | [
"core/src/main/java/org/kestra/core/runners/FlowableUtils.java",
"core/src/main/java/org/kestra/core/runners/handlebars/helpers/JsonHelper.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachParallel.java",
"core/src/main/java/org/kestra/core/tasks/flows/EachSequential.java"
] | [
"core/src/test/java/org/kestra/core/Helpers.java",
"core/src/test/java/org/kestra/core/tasks/flows/EachSequentialTest.java",
"core/src/test/resources/flows/valids/each-null.yaml",
"core/src/test/resources/flows/valids/each-object.yaml"
] | diff --git a/core/src/main/java/org/kestra/core/runners/FlowableUtils.java b/core/src/main/java/org/kestra/core/runners/FlowableUtils.java
index be07caa3ca..b191a2aa0c 100644
--- a/core/src/main/java/org/kestra/core/runners/FlowableUtils.java
+++ b/core/src/main/java/org/kestra/core/runners/FlowableUtils.java
@@ -1,6 +... | diff --git a/core/src/test/java/org/kestra/core/Helpers.java b/core/src/test/java/org/kestra/core/Helpers.java
index 1be6e6e1a1..0e5f2ec5eb 100644
--- a/core/src/test/java/org/kestra/core/Helpers.java
+++ b/core/src/test/java/org/kestra/core/Helpers.java
@@ -17,7 +17,7 @@
import java.util.function.BiConsumer;
publi... | train | train | 2020-12-04T12:47:05 | 2020-11-12T17:00:12Z | tchiotludo | train |
kestra-io/kestra/270_274 | kestra-io/kestra | kestra-io/kestra/270 | kestra-io/kestra/274 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9105063309054171)"
] | 4d2ac52e603cb92bc45a36aa2ec8b6319564bba6 | 0cb75dcf7fae1e775a69d31aeb6c7562a832114e | [] | [] | 2021-01-29T23:53:23Z | [
"backend"
] | Display file size on the ui | When we display a link in order to download a file, it will be nice to have the filesize | [
"core/src/main/java/org/kestra/core/storages/StorageInterface.java",
"storage-local/src/main/java/org/kestra/storage/local/LocalStorage.java",
"ui/package-lock.json",
"ui/src/components/executions/VarValue.vue",
"ui/src/utils/utils.js",
"webserver/src/main/java/org/kestra/webserver/controllers/ExecutionCo... | [
"core/src/main/java/org/kestra/core/models/storage/FileMetas.java",
"core/src/main/java/org/kestra/core/storages/StorageInterface.java",
"storage-local/src/main/java/org/kestra/storage/local/LocalStorage.java",
"ui/package-lock.json",
"ui/src/components/executions/VarValue.vue",
"ui/src/utils/utils.js",
... | [
"storage-local/src/test/java/org/kestra/storage/local/LocalStorageTest.java",
"webserver/src/test/java/org/kestra/webserver/controllers/ExecutionControllerTest.java"
] | diff --git a/core/src/main/java/org/kestra/core/models/storage/FileMetas.java b/core/src/main/java/org/kestra/core/models/storage/FileMetas.java
new file mode 100644
index 0000000000..a6b2b08758
--- /dev/null
+++ b/core/src/main/java/org/kestra/core/models/storage/FileMetas.java
@@ -0,0 +1,13 @@
+package org.kestra.cor... | diff --git a/storage-local/src/test/java/org/kestra/storage/local/LocalStorageTest.java b/storage-local/src/test/java/org/kestra/storage/local/LocalStorageTest.java
index ca78211012..903b3007d4 100644
--- a/storage-local/src/test/java/org/kestra/storage/local/LocalStorageTest.java
+++ b/storage-local/src/test/java/org/... | train | train | 2021-02-24T21:06:58 | 2021-01-22T10:37:13Z | tchiotludo | train |
kestra-io/kestra/282_296 | kestra-io/kestra | kestra-io/kestra/282 | kestra-io/kestra/296 | [
"keyword_pr_to_issue"
] | 05f546d0b5b7ac7cc6600dc85fc5470184cd3ff9 | 4d2ac52e603cb92bc45a36aa2ec8b6319564bba6 | [
"Easy one here :) \r\n```yaml\r\ninputs:\r\n - name: \"wrong one\"\r\n description: \"what is this ?\"\r\n```\r\nand add the info on the ui execute tabs :) "
] | [] | 2021-02-20T09:30:43Z | [
"backend"
] | Allow description on input fields on flow | [
"core/src/main/java/org/kestra/core/models/flows/Input.java",
"ui/src/components/flows/ExecutionConfiguration.vue"
] | [
"core/src/main/java/org/kestra/core/models/flows/Input.java",
"ui/src/components/flows/ExecutionConfiguration.vue"
] | [
"core/src/test/java/org/kestra/core/runners/InputsTest.java"
] | diff --git a/core/src/main/java/org/kestra/core/models/flows/Input.java b/core/src/main/java/org/kestra/core/models/flows/Input.java
index 29b2a2cfc8..05848fb59f 100644
--- a/core/src/main/java/org/kestra/core/models/flows/Input.java
+++ b/core/src/main/java/org/kestra/core/models/flows/Input.java
@@ -25,6 +25,8 @@ pub... | diff --git a/core/src/test/java/org/kestra/core/runners/InputsTest.java b/core/src/test/java/org/kestra/core/runners/InputsTest.java
index 9098226460..98e68066fe 100644
--- a/core/src/test/java/org/kestra/core/runners/InputsTest.java
+++ b/core/src/test/java/org/kestra/core/runners/InputsTest.java
@@ -8,6 +8,7 @@
impo... | test | train | 2021-02-24T17:14:38 | 2021-02-09T13:36:22Z | eregnier | train | |
kestra-io/kestra/337_340 | kestra-io/kestra | kestra-io/kestra/337 | kestra-io/kestra/340 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8723767710825444)"
] | c67be115b2a562bfbb87018cd39baec26eca9cb7 | 065c07808415c0c0ab45a062aab793dd8d1cb138 | [] | [] | 2021-05-11T16:36:09Z | [
"bug",
"backend"
] | taskDefault are not applied on Flowable task | [
"cli/src/main/java/io/kestra/cli/commands/sys/RestoreQueueCommand.java",
"core/src/main/java/io/kestra/core/runners/AbstractExecutor.java",
"core/src/main/java/io/kestra/core/services/TaskDefaultService.java",
"runner-kafka/src/main/java/io/kestra/runner/kafka/KafkaExecutor.java",
"runner-kafka/src/main/jav... | [
"cli/src/main/java/io/kestra/cli/commands/sys/RestoreQueueCommand.java",
"cli/src/main/java/io/kestra/cli/services/RestoreQueueService.java",
"core/src/main/java/io/kestra/core/runners/AbstractExecutor.java",
"core/src/main/java/io/kestra/core/services/TaskDefaultService.java",
"runner-kafka/src/main/java/i... | [
"core/src/test/java/io/kestra/core/runners/RunContextTest.java",
"core/src/test/java/io/kestra/core/runners/TaskDefaultsCaseTest.java",
"core/src/test/java/io/kestra/core/services/TaskDefaultServiceTest.java",
"core/src/test/resources/flows/tests/task-defaults.yaml",
"runner-kafka/src/test/java/io/kestra/ru... | diff --git a/cli/src/main/java/io/kestra/cli/commands/sys/RestoreQueueCommand.java b/cli/src/main/java/io/kestra/cli/commands/sys/RestoreQueueCommand.java
index 9b88631973..cbea85bac5 100644
--- a/cli/src/main/java/io/kestra/cli/commands/sys/RestoreQueueCommand.java
+++ b/cli/src/main/java/io/kestra/cli/commands/sys/Re... | diff --git a/core/src/test/java/io/kestra/core/runners/RunContextTest.java b/core/src/test/java/io/kestra/core/runners/RunContextTest.java
index cb97a1c9f2..f870f4b9a9 100644
--- a/core/src/test/java/io/kestra/core/runners/RunContextTest.java
+++ b/core/src/test/java/io/kestra/core/runners/RunContextTest.java
@@ -1,25 ... | train | train | 2021-05-12T10:31:50 | 2021-05-07T15:15:50Z | tchiotludo | train | |
kestra-io/kestra/191_351 | kestra-io/kestra | kestra-io/kestra/191 | kestra-io/kestra/351 | [
"keyword_pr_to_issue"
] | 3e5731a65e5836cbc86629f78f4ffef66f13dd53 | b7d19221331b84e89ec2d905f553dfb26a9c492b | [
"where is this documentation plugin located ? there is no such information in the core.\r\nEdit : I think I found one plugin where there is such information."
] | [] | 2021-06-07T11:35:03Z | [
"documentation",
"backend"
] | Handle property Duration on documentation | For now, displayed like that :
| [
"core/src/main/java/io/kestra/core/docs/ClassPluginDocumentation.java",
"core/src/main/java/io/kestra/core/docs/DocumentationGenerator.java",
"core/src/main/java/io/kestra/core/docs/JsonSchemaGenerator.java",
"core/src/main/java/io/kestra/core/runners/VariableRenderer.java",
"core/src/main/resources/docs/ta... | [
"core/src/main/java/io/kestra/core/docs/ClassPluginDocumentation.java",
"core/src/main/java/io/kestra/core/docs/DocumentationGenerator.java",
"core/src/main/java/io/kestra/core/docs/JsonSchemaGenerator.java",
"core/src/main/java/io/kestra/core/runners/VariableRenderer.java",
"core/src/main/java/io/kestra/co... | [
"core/src/test/java/io/kestra/core/docs/ClassPluginDocumentationTest.java",
"core/src/test/java/io/kestra/core/docs/DocumentationGeneratorTest.java",
"core/src/test/java/io/kestra/core/docs/JsonSchemaGeneratorTest.java",
"core/src/test/java/io/kestra/core/runners/VariableRendererTest.java"
] | diff --git a/core/src/main/java/io/kestra/core/docs/ClassPluginDocumentation.java b/core/src/main/java/io/kestra/core/docs/ClassPluginDocumentation.java
index b2dc65e370..3d976edf69 100644
--- a/core/src/main/java/io/kestra/core/docs/ClassPluginDocumentation.java
+++ b/core/src/main/java/io/kestra/core/docs/ClassPlugin... | diff --git a/core/src/test/java/io/kestra/core/docs/ClassPluginDocumentationTest.java b/core/src/test/java/io/kestra/core/docs/ClassPluginDocumentationTest.java
index c32d69f6e5..afae871f70 100644
--- a/core/src/test/java/io/kestra/core/docs/ClassPluginDocumentationTest.java
+++ b/core/src/test/java/io/kestra/core/docs... | val | train | 2021-06-04T22:36:07 | 2020-11-02T16:13:45Z | tchiotludo | train |
kestra-io/kestra/362_364 | kestra-io/kestra | kestra-io/kestra/362 | kestra-io/kestra/364 | [
"keyword_pr_to_issue"
] | 07550381df47a26b0f005041a6b3a0e363931e66 | 12652244344085b006266160033a40693d933ba3 | [] | [] | 2021-08-05T16:17:44Z | [] | Worker temporary files cleanup | Handle globally worker cleanup that use temporary files, for example [here](https://github.com/kestra-io/kestra/blob/develop/core/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java#L330).
It will be better to have a global function to handle this to be sure that plugins will not forgot to delete temporary fi... | [
"core/src/main/java/io/kestra/core/models/tasks/RunnableTask.java",
"core/src/main/java/io/kestra/core/models/tasks/Task.java",
"core/src/main/java/io/kestra/core/runners/Worker.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/io/kestra/core/tasks/scripts/Abstr... | [
"core/src/main/java/io/kestra/core/models/tasks/RunnableTask.java",
"core/src/main/java/io/kestra/core/models/tasks/Task.java",
"core/src/main/java/io/kestra/core/runners/Worker.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/io/kestra/core/tasks/scripts/Abstr... | [] | diff --git a/core/src/main/java/io/kestra/core/models/tasks/RunnableTask.java b/core/src/main/java/io/kestra/core/models/tasks/RunnableTask.java
index e08a37a9c9..2b2cf3df68 100644
--- a/core/src/main/java/io/kestra/core/models/tasks/RunnableTask.java
+++ b/core/src/main/java/io/kestra/core/models/tasks/RunnableTask.ja... | null | train | train | 2021-08-02T11:50:41 | 2021-08-03T12:34:35Z | tchiotludo | train |
kestra-io/kestra/401_402 | kestra-io/kestra | kestra-io/kestra/401 | kestra-io/kestra/402 | [
"keyword_pr_to_issue"
] | 1003843b34f288c9e947d08b91a2ae54b09837e1 | cf12a2044743ae43de1d56b347259485bedfa28a | [] | [] | 2021-11-18T17:46:29Z | [
"bug",
"backend"
] | Template properties should not be return by webserver | This [property](https://github.com/kestra-io/kestra/blob/d1837d17a649b1d5a844fe23a36a9543478d1465/core/src/main/java/io/kestra/core/tasks/flows/Template.java#L119) is need by serialization internaly for executor but for now this property is returned by webserver and should not (diff in terraform plan).
Find a way to h... | [
"core/src/main/java/io/kestra/core/tasks/flows/Template.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractPython.java",
"runner-kafka/src/main/java/io/kestra/runner/kafka/streams/FlowJoinerTransformer.java",
"runner-memory/src/main/java/io/kestra/runner/memory/MemoryExecutor.java"
] | [
"core/src/main/java/io/kestra/core/tasks/flows/Template.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractPython.java",
"runner-kafka/src/main/java/io/kestra/runner/kafka/streams/FlowJoinerTransformer.java",
"runner-memory/src/main/java/io/kestra/runner/memory/MemoryExecutor.java"
] | [] | diff --git a/core/src/main/java/io/kestra/core/tasks/flows/Template.java b/core/src/main/java/io/kestra/core/tasks/flows/Template.java
index b9e9cc3524..0e882a23e6 100644
--- a/core/src/main/java/io/kestra/core/tasks/flows/Template.java
+++ b/core/src/main/java/io/kestra/core/tasks/flows/Template.java
@@ -1,6 +1,5 @@
... | null | train | train | 2021-11-17T18:53:39 | 2021-11-18T15:37:51Z | tchiotludo | train |
kestra-io/kestra/399_415 | kestra-io/kestra | kestra-io/kestra/399 | kestra-io/kestra/415 | [
"keyword_pr_to_issue"
] | a9ab424843ade3ab61b4165c0dc14d025401a1cc | c65aa746c77fa164fdd342f1ae76426dee7ab98b | [] | [
"It seems that the simple `humanizeDuration(this.delta());` produce a better result I think ",
"Take care here, some time we passed an execution, some time an taskrun (on loglist), we should adapt between both",
"see comment below about taskrun & execution, it may be better to have 2 props `execution` or `taskr... | 2021-12-13T22:59:42Z | [] | Executions log tab: should be more realtime | Right now, we don't see a lot of information on running tasks.
We should at least display duration counter move to properly understand that the execution is running | [
"ui/src/components/executions/Gantt.vue",
"ui/src/components/executions/Logs.vue",
"ui/src/components/logs/LogList.vue"
] | [
"ui/src/components/executions/Gantt.vue",
"ui/src/components/executions/Logs.vue",
"ui/src/components/executions/RealTime.vue",
"ui/src/components/logs/LogList.vue"
] | [] | diff --git a/ui/src/components/executions/Gantt.vue b/ui/src/components/executions/Gantt.vue
index 1b32155807..27b6ca6011 100644
--- a/ui/src/components/executions/Gantt.vue
+++ b/ui/src/components/executions/Gantt.vue
@@ -3,7 +3,9 @@
<table class="table table-sm mb-0">
<thead>
<t... | null | train | train | 2021-12-14T21:38:23 | 2021-11-18T13:31:26Z | tchiotludo | train |
kestra-io/kestra/392_419 | kestra-io/kestra | kestra-io/kestra/392 | kestra-io/kestra/419 | [
"keyword_pr_to_issue"
] | 1fa26318993455b61475ce8e3abd34f740172399 | 7e8b1269354e73d6a5f0aa1f4a5ec00cfa24284e | [] | [] | 2021-12-16T07:57:47Z | [] | Logs : add a full screen, copy & download button | 
| [
"ui/src/App.vue",
"ui/src/components/executions/ChangeStatus.vue",
"ui/src/components/executions/Logs.vue",
"ui/src/components/executions/Restart.vue",
"ui/src/components/logs/LogList.vue",
"ui/src/stores/logs.js",
"ui/src/translations.json"
] | [
"ui/src/App.vue",
"ui/src/components/executions/ChangeStatus.vue",
"ui/src/components/executions/Logs.vue",
"ui/src/components/executions/Restart.vue",
"ui/src/components/logs/LogList.vue",
"ui/src/stores/logs.js",
"ui/src/translations.json"
] | [] | diff --git a/ui/src/App.vue b/ui/src/App.vue
index 6aa5aeeb21..e115c0159f 100644
--- a/ui/src/App.vue
+++ b/ui/src/App.vue
@@ -11,6 +11,10 @@
<errors :code="error" />
</template>
</div>
+ <b-modal hide-header hide-footer scrollable id="log-fullscreen-modal" ... | null | train | train | 2021-12-15T22:25:05 | 2021-10-29T09:26:39Z | tchiotludo | train |
kestra-io/kestra/405_421 | kestra-io/kestra | kestra-io/kestra/405 | kestra-io/kestra/421 | [
"keyword_pr_to_issue"
] | e4f51ea38a36d0257b0599db5e0a6554497ca37f | 2eabed6befdd8bd7dc73d68b07da07ca0a113326 | [] | [] | 2021-12-21T17:21:15Z | [] | Bash Task : add a property warningOnStdErr | [
"core/src/main/java/io/kestra/core/models/tasks/Output.java",
"core/src/main/java/io/kestra/core/runners/Worker.java",
"core/src/main/java/io/kestra/core/runners/WorkerTask.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/io/kestra/core/tasks/scripts/ScriptOutp... | [
"core/src/main/java/io/kestra/core/models/tasks/Output.java",
"core/src/main/java/io/kestra/core/runners/Worker.java",
"core/src/main/java/io/kestra/core/runners/WorkerTask.java",
"core/src/main/java/io/kestra/core/tasks/scripts/AbstractBash.java",
"core/src/main/java/io/kestra/core/tasks/scripts/ScriptOutp... | [
"core/src/test/java/io/kestra/core/Helpers.java",
"core/src/test/java/io/kestra/core/docs/JsonSchemaGeneratorTest.java",
"core/src/test/java/io/kestra/core/tasks/BashTest.java",
"core/src/test/resources/flows/valids/bash-warning.yaml",
"webserver/src/test/java/io/kestra/webserver/controllers/PluginControlle... | diff --git a/core/src/main/java/io/kestra/core/models/tasks/Output.java b/core/src/main/java/io/kestra/core/models/tasks/Output.java
index 62c3e3e5f7..24ca7e50f0 100644
--- a/core/src/main/java/io/kestra/core/models/tasks/Output.java
+++ b/core/src/main/java/io/kestra/core/models/tasks/Output.java
@@ -1,10 +1,16 @@
pa... | diff --git a/core/src/test/java/io/kestra/core/Helpers.java b/core/src/test/java/io/kestra/core/Helpers.java
index bdeb79c4a5..ae3d6c475b 100644
--- a/core/src/test/java/io/kestra/core/Helpers.java
+++ b/core/src/test/java/io/kestra/core/Helpers.java
@@ -20,7 +20,7 @@
import java.util.function.Consumer;
public clas... | train | train | 2021-12-20T21:31:04 | 2021-11-26T13:30:13Z | tchiotludo | train | |
kestra-io/kestra/542_549 | kestra-io/kestra | kestra-io/kestra/542 | kestra-io/kestra/549 | [
"keyword_pr_to_issue"
] | a481bdd1cb1f077a049465d8dfadb432ac343eec | 1f227d8106516acddc7a59ee8206b8e79e36030f | [
"Hi, I'm interested in this project and would like to work on this. Can you please provide some guidance on where to start with this task?",
"Just need to think a little more. \r\nMy last thought was to use the [Pause task](https://kestra.io/plugins/core/tasks/flows/io.kestra.core.tasks.flows.Pause.html) and add ... | [] | 2022-04-10T19:45:33Z | [
"backend"
] | Trigger a flow after some delay | on [Flow](https://kestra.io/plugins/core/tasks/flows/io.kestra.core.tasks.flows.Flow.html), a nice feature will be allow to trigger the flow after xx minutes / seconds / hour.
When the flow is trigger, instead of sending directly to the Queue, just keep it on a Kafka State store and use `punctuate` to send it later
| [
"core/src/main/java/io/kestra/core/models/flows/State.java",
"core/src/main/java/io/kestra/core/runners/Executor.java",
"core/src/main/java/io/kestra/core/runners/ExecutorService.java",
"core/src/main/java/io/kestra/core/tasks/flows/Pause.java",
"runner-kafka/src/main/java/io/kestra/runner/kafka/executors/E... | [
"core/src/main/java/io/kestra/core/models/flows/State.java",
"core/src/main/java/io/kestra/core/runners/ExecutionDelay.java",
"core/src/main/java/io/kestra/core/runners/Executor.java",
"core/src/main/java/io/kestra/core/runners/ExecutorService.java",
"core/src/main/java/io/kestra/core/tasks/flows/Pause.java... | [
"core/src/test/java/io/kestra/core/Helpers.java",
"core/src/test/java/io/kestra/core/tasks/flows/PauseTest.java",
"core/src/test/resources/flows/valids/pause-delay.yaml",
"runner-kafka/src/test/java/io/kestra/runner/kafka/KafkaExecutorTest.java"
] | diff --git a/core/src/main/java/io/kestra/core/models/flows/State.java b/core/src/main/java/io/kestra/core/models/flows/State.java
index 54ebc04ad8..4f2f002b60 100644
--- a/core/src/main/java/io/kestra/core/models/flows/State.java
+++ b/core/src/main/java/io/kestra/core/models/flows/State.java
@@ -91,6 +91,14 @@ public... | diff --git a/core/src/test/java/io/kestra/core/Helpers.java b/core/src/test/java/io/kestra/core/Helpers.java
index ae3d6c475b..b9aef3a5a5 100644
--- a/core/src/test/java/io/kestra/core/Helpers.java
+++ b/core/src/test/java/io/kestra/core/Helpers.java
@@ -20,7 +20,7 @@
import java.util.function.Consumer;
public clas... | train | train | 2022-04-07T10:53:48 | 2022-04-06T06:03:02Z | tchiotludo | train |
kestra-io/kestra/660_661 | kestra-io/kestra | kestra-io/kestra/660 | kestra-io/kestra/661 | [
"keyword_pr_to_issue"
] | df6aa29fccf92333e325f944a5855937d9eba080 | 5a259fd6db98c315059436ceefa6493329df81b9 | [
"Thanks for the report \r\nMaybe you can add create a PR with trim last `/` on `basePath` ?"
] | [] | 2022-07-21T01:13:02Z | [
"bug"
] | theme uri invalid with extra "/" | ### Expected Behavior
Access /ui/flows get all extra resources.
### Actual Behaviour
Can't get theme-light.js and theme-light.css, here is actual URI, Please note there is an extra "/" after ui/
```
<link rel="stylesheet" href="/ui//css/theme-light.00305fce.css" data-theme="theme-light">
```
https://gith... | [
"ui/src/App.vue"
] | [
"ui/src/App.vue"
] | [] | diff --git a/ui/src/App.vue b/ui/src/App.vue
index 0b233b5993..ec676de08e 100644
--- a/ui/src/App.vue
+++ b/ui/src/App.vue
@@ -98,11 +98,11 @@
if (r.endsWith(".js")) {
elem = document.createElement("script");
elem... | null | test | train | 2022-07-08T21:57:43 | 2022-07-20T12:37:18Z | mengzhuo | train |
kestra-io/kestra/721_735 | kestra-io/kestra | kestra-io/kestra/721 | kestra-io/kestra/735 | [
"keyword_pr_to_issue"
] | 0aaa275b1bb747fd5708b26411189753e70bf31b | a19b707e3552aa7ec644dfaa50e62260ec3db98d | [] | [] | 2022-09-09T08:22:20Z | [
"bug",
"backend"
] | Template don't support description | [Template](https://github.com/kestra-io/kestra/blob/f0b0ad541f67c6d6cf6f520839c4de0af66b7e63/core/src/main/java/io/kestra/core/models/templates/Template.java#L27) don't have any description, we need to support it | [
"core/src/main/java/io/kestra/core/models/templates/Template.java",
"ui/src/components/templates/Templates.vue"
] | [
"core/src/main/java/io/kestra/core/models/templates/Template.java",
"ui/src/components/templates/Templates.vue"
] | [
"webserver/src/test/java/io/kestra/webserver/controllers/TemplateControllerTest.java"
] | diff --git a/core/src/main/java/io/kestra/core/models/templates/Template.java b/core/src/main/java/io/kestra/core/models/templates/Template.java
index 8ce6aca733..573a49e6c8 100644
--- a/core/src/main/java/io/kestra/core/models/templates/Template.java
+++ b/core/src/main/java/io/kestra/core/models/templates/Template.ja... | diff --git a/webserver/src/test/java/io/kestra/webserver/controllers/TemplateControllerTest.java b/webserver/src/test/java/io/kestra/webserver/controllers/TemplateControllerTest.java
index 24e6ed2e2a..df1980efc7 100644
--- a/webserver/src/test/java/io/kestra/webserver/controllers/TemplateControllerTest.java
+++ b/webse... | val | train | 2022-09-08T11:34:47 | 2022-09-06T20:10:48Z | tchiotludo | train |
kestra-io/kestra/775_815 | kestra-io/kestra | kestra-io/kestra/775 | kestra-io/kestra/815 | [
"keyword_pr_to_issue"
] | b347a30df897a3e483a7a7382c56c5ab26fae9f5 | 7d48b51c5345adb546ac9024da735e1f8c6b6d8c | [] | [] | 2022-11-15T16:35:07Z | [
"bug"
] | Tasks with big id are blocking the `Eval expression` button | ### Expected Behavior
Click on the "Eval expression" button, in the "Outputs" panel
### Actual Behaviour
<img width="1468" alt="image" src="https://user-images.githubusercontent.com/1302218/194127164-af079cde-793e-4af8-bd9b-dd575857cbad.png">
Button is blocked by the very long id text
### Steps To Reproduce
_No... | [
".github/CONTRIBUTING.md",
".gitignore"
] | [
".github/CONTRIBUTING.md",
".gitignore"
] | [] | diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index fb2834b300..ddb6772c1b 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -65,7 +65,17 @@ The frontend is located on `/ui` folder.
- create a files `ui/.env.development.local` with content `VUE_APP_API_URL=http://localhost:8080` (o... | null | train | train | 2022-12-21T17:52:09 | 2022-10-05T17:48:32Z | Melkaz | train |
kestra-io/kestra/768_825 | kestra-io/kestra | kestra-io/kestra/768 | kestra-io/kestra/825 | [
"keyword_pr_to_issue"
] | 01df11778511bdf77fa940440cd00a44b22b65a2 | b347a30df897a3e483a7a7382c56c5ab26fae9f5 | [] | [] | 2022-11-22T14:22:39Z | [
"bug"
] | Fix container-image tag displayed in logs | ### Expected Behavior
Should show `Image pulled [ubuntu:20.04]`
### Actual Behaviour
Currently shows: `Image pulled [ubuntu:20.04:20.04]`
### Steps To Reproduce
_No response_
### Environment Information
- Kestra Version: 0.5.2-SNAPSHOT
- Operating System (OS / Docker / Kubernetes): Docker
### Example flow
_... | [
"core/src/main/java/io/kestra/core/tasks/scripts/runners/DockerScriptRunner.java"
] | [
"core/src/main/java/io/kestra/core/tasks/scripts/runners/DockerScriptRunner.java"
] | [] | diff --git a/core/src/main/java/io/kestra/core/tasks/scripts/runners/DockerScriptRunner.java b/core/src/main/java/io/kestra/core/tasks/scripts/runners/DockerScriptRunner.java
index 888aa59545..651aedaa59 100644
--- a/core/src/main/java/io/kestra/core/tasks/scripts/runners/DockerScriptRunner.java
+++ b/core/src/main/jav... | null | train | train | 2022-12-09T22:12:05 | 2022-10-04T10:16:48Z | Melkaz | train |
kestra-io/kestra/894_895 | kestra-io/kestra | kestra-io/kestra/894 | kestra-io/kestra/895 | [
"keyword_pr_to_issue"
] | 31826015dcb5baa9b787f7998dcaddf7c95d8cd5 | 6845f826240883e439f8726524a13673cfd0f61c | [
"Yes for sure PR will be appreciate! \r\nWe move to vite few days ago and forgot this part 😬"
] | [] | 2023-01-14T21:10:34Z | [
"bug"
] | Contributing.md frontend config out of date | ### Issue description
Hey, while setting the project locally I've noticed some of the configuration steps for the frontend were out of date.
- VUE_APP_API_URL -> VITE_APP_API_URL
- npm run serve -> npm run dev
I can submit a PR if you're ok with it. | [
".github/CONTRIBUTING.md"
] | [
".github/CONTRIBUTING.md"
] | [] | diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 34370d12fd..1a77ce1d41 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -73,20 +73,24 @@ python3 -m pip install virtualenv
The frontend is made with [Vue.js](https://vuejs.org/) and located on the `/ui` folder.
- `npm install`... | null | train | train | 2023-01-14T21:29:38 | 2023-01-14T19:36:28Z | simonpic | train |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.