source
large_stringclasses
2 values
subject
large_stringclasses
112 values
code
large_stringclasses
112 values
critique
large_stringlengths
61
3.04M
metadata
dict
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Hi Roman, On Mon, Jan 26, 2026 at 6:50 PM Roman Gushchin <roman.gushchin@linux.dev> wrote: [snip] I was worried about concurrency with cgroup ops until I saw cgroup_bpf_detach_struct_ops() takes cgroup_lock() internally (since you take it inline sometimes below I falsely assumed it wasn't present). In any case, I'm w...
{ "author": "Josh Don <joshdon@google.com>", "date": "Tue, 27 Jan 2026 19:10:35 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Thanks Roman! On Mon, Jan 26, 2026 at 6:51 PM Roman Gushchin <roman.gushchin@linux.dev> wrote: If bpf claims to have freed memory but didn't actually do so, that seems like something potentially worth alerting to. Perhaps something to add to the oom header output?
{ "author": "Josh Don <joshdon@google.com>", "date": "Tue, 27 Jan 2026 19:26:57 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Tue 27-01-26 21:12:56, Roman Gushchin wrote: Could you explain this a bit more. This must be some BPF magic because they are getting a standard pointer to oom_control. Yes, something like OOM_BACKOFF, OOM_PROCESSED, OOM_FAILED. Counters usually do not work very well for async operations. In this case there is ...
{ "author": "Michal Hocko <mhocko@suse.com>", "date": "Wed, 28 Jan 2026 09:00:45 +0100", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Tue 27-01-26 21:01:48, Roman Gushchin wrote: Sure. Essentially an expected structure of the handler. What is the API it can use, what is has to do and what it must not do. Essentially a single place you can read and get enough information to start developing your oom handler. Examples are really great but having ...
{ "author": "Michal Hocko <mhocko@suse.com>", "date": "Wed, 28 Jan 2026 09:06:14 +0100", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Once additional point I forgot to mention previously On Mon 26-01-26 18:44:10, Roman Gushchin wrote: Should this check for is_sysrq_oom and always use the in kernel OOM handling for Sysrq triggered ooms as a failsafe measure? -- Michal Hocko SUSE Labs
{ "author": "Michal Hocko <mhocko@suse.com>", "date": "Wed, 28 Jan 2026 12:19:42 +0100", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:05PM -0800, Roman Gushchin wrote: Assigning 0 to cgrp_id would technically be incorrect, right? Like, cgroup_id() for !CONFIG_CGROUPS default to returning 1, and for CONFIG_CGROUPS the ID allocation is done via the idr_alloc_cyclic() API using a range between 1 and INT_MAX. Perhaps here i...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Wed, 28 Jan 2026 11:25:31 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:04PM -0800, Roman Gushchin wrote: Looks OK to me: Acked-by: Matt Bobrowski <mattbobrowski@google.com>
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Wed, 28 Jan 2026 11:28:48 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Wed, Jan 28, 2026 at 12:06 AM Michal Hocko <mhocko@suse.com> wrote: Production ready bpf-oom program(s) must be part of this set. We've seen enough attempts to add bpf st_ops in various parts of the kernel without providing realistic bpf progs that will drive those hooks. It's great to have flexibility and people n...
{ "author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>", "date": "Wed, 28 Jan 2026 08:59:34 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Alexei Starovoitov <alexei.starovoitov@gmail.com> writes: In my case it's not about hiding, it's a chicken and egg problem: the upstream first model contradicts with the idea to include the production results into the patchset. In other words, I want to settle down the interface before shipping something to prod. I ...
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 10:23:34 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Michal Hocko <mhocko@suse.com> writes: Yes, but bpf programs (unlike kernel modules) are going through the verifier when being loaded to the kernel. The verifier ensures that programs are safe: e.g. they can't access memory outside of safe areas, they can't can infinite loops, dereference a NULL pointer etc. So even...
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 10:44:46 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Josh Don <joshdon@google.com> writes: Hi Josh! Sure, good point. Agree, will add. Thanks!
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 10:52:05 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Michal Hocko <mhocko@suse.com> writes: Yep, good point. Will implement in v4. Thanks!
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 10:53:20 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Wed, Jan 28, 2026 at 10:23 AM Roman Gushchin <roman.gushchin@linux.dev> wrote: Works for me. Agree. That's the flexibility part that makes the whole thing worth while and the reason to do such oom policy as bpf progs. But something tangible and useful needs to be there from day one. systmed-oomd-like sounds very ...
{ "author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>", "date": "Wed, 28 Jan 2026 10:53:50 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Josh Don <joshdon@google.com> writes: Michal pointed at a more fundamental problem: if a bpf handler performed some actions (e.g. killed a program), how to safely allow other bpf handlers to exit without performing redundant destructive operations? Now it works on marking victim processes, so that subsequent kernel o...
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 11:03:16 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Matt Bobrowski <mattbobrowski@google.com> writes: Yes. Idk, maybe (u64)-1 works better here, I don't have a strong opinion. Realistically I doubt there are too many bpf users with !CONFIG_CGROUPS. Alexei even suggested in the past to make CONFIG_MEMCG mandatory, which implies CONFIG_CGROUPS. I'll try, thanks! Idk...
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Wed, 28 Jan 2026 11:18:36 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:12PM -0800, Roman Gushchin wrote: If contended and we end up waiting here, some forward progress could have been made in the interim. Enough such that this pending OOM event initiated by the call into bpf_out_of_memory() may no longer even be warranted. What do you think about adding an e...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Wed, 28 Jan 2026 20:21:54 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On 1/26/26 6:44 PM, Roman Gushchin wrote: [ ... ] iiuc, this will allow only one oom_ops to be attached to a cgroup. Considering oom_ops is the only user of the cgrp->bpf.struct_ops_links (added in patch 2), the list should have only one element for now. Copy some context from the patch 2 commit log. > This chan...
{ "author": "Martin KaFai Lau <martin.lau@linux.dev>", "date": "Thu, 29 Jan 2026 13:00:11 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
Martin KaFai Lau <martin.lau@linux.dev> writes: Hi Martin! Sorry, I'm not quite sure what do you mean, can you please elaborate more? We decided (in conversations at LPC) that 1 bpf oom policy for memcg is good for now (with a potential to extend in the future, if there will be use cases). But it seems like there i...
{ "author": "Roman Gushchin <roman.gushchin@linux.dev>", "date": "Fri, 30 Jan 2026 15:29:31 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Wed, Jan 28, 2026 at 08:59:34AM -0800, Alexei Starovoitov wrote: For the auto-loading capability you speak of here, I'm currently interpreting it as being some form of conceptually similar extension to the BPF preload functionality. Have I understood this correctly? If so, I feel as though something like this would...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 2 Feb 2026 03:26:07 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:09PM -0800, Roman Gushchin wrote: This code has been changed in the mm-tree and you can directly use mem_cgroup_get_from_id() after changes in the mm-tree.
{ "author": "Shakeel Butt <shakeel.butt@linux.dev>", "date": "Sun, 1 Feb 2026 19:50:48 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Tue, Jan 27, 2026 at 09:12:56PM +0000, Roman Gushchin wrote: Yes, please, this is something that I had mentioned to you the other day too. With this kind of BPF kfunc, we'll basically be able to handle memcg scoped OOM events inline without necessarily being forced to kill off anything.
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 2 Feb 2026 04:06:32 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:11PM -0800, Roman Gushchin wrote: task->signal->oom_score_adj == OOM_SCORE_ADJ_MIN is also representative of an unkillable task, so why not fold this up into the above conditional? Also, why not bother checking states like mm_flags_test(MMF_OOM_SKIP, task->mm) and in_vfork() here too? In...
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 2 Feb 2026 04:49:09 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:08PM -0800, Roman Gushchin wrote: This is fine. Feel free to add: Acked-by: Matt Bobrowski <mattbobrowski@google.com>
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 2 Feb 2026 04:56:57 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Mon, Jan 26, 2026 at 06:44:13PM -0800, Roman Gushchin wrote: Why not just do a direct memory read (i.e., task->signal->oom_mm) within the BPF program? I'm not quite convinced that a BPF kfunc wrapper for something like tsk_is_oom_victim() is warranted as you can literally achieve the same semantics without one.
{ "author": "Matt Bobrowski <mattbobrowski@google.com>", "date": "Mon, 2 Feb 2026 05:39:48 +0000", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Sun, Feb 1, 2026 at 9:39 PM Matt Bobrowski <mattbobrowski@google.com> wrote: +1 there is no need for this kfunc.
{ "author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>", "date": "Mon, 2 Feb 2026 09:30:23 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH bpf-next v3 00/17] mm: BPF OOM
This patchset adds an ability to customize the out of memory handling using bpf. It focuses on two parts: 1) OOM handling policy, 2) PSI-based OOM invocation. The idea to use bpf for customizing the OOM handling is not new, but unlike the previous proposal [1], which augmented the existing task ranking policy, this o...
On Sun, Feb 1, 2026 at 7:26 PM Matt Bobrowski <mattbobrowski@google.com> wrote: It's not a hard prerequisite, but it has to be thought through. bpf side is ready today. bpf preload is an example of it. The oom side needs to design an interface to do it. sysctl to enable builtin bpf-oom policy is probably too rigid. Ma...
{ "author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>", "date": "Mon, 2 Feb 2026 09:50:05 -0800", "thread_id": "CAADnVQL5g8imKNGbHGQ4HA8_qNT4MYwM8P3aCTFUG7uwiuTeuw@mail.gmail.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The "qup-memory" interconnect path is optional and may not be defined in all device trees. Unroll the loop-based ICC path initialization to allow specific error handling for each path type. The "qup-core" and "qup-config" paths remain mandatory and will fail probe if missing, while "qup-memory" is now handled as optio...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:11 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add a new function geni_icc_set_bw_ab() that allows callers to set average bandwidth values for all ICC (Interconnect) paths in a single call. This function takes separate parameters for core, config, and DDR average bandwidth values and applies them to the respective ICC paths. This provides a more convenient API for...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:12 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate code for initializing shared resources such as clocks and interconnect paths. Introduce a new helper API, geni_se_resources_init(), to centralize this initialization logic, improving modularity and simplifying the probe function. Signed-off-by:...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:13 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource activation/deactivation sequences independently, leading to code duplication. Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to power on/off resources.The activate function enables ICC, clocks, and TLMM whereas the deactiva...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:14 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle the attachment of power domains. This often leads to duplicated code logic across different driver probe functions. Introduce a new helper API, geni_se_domain_attach(), to centralize the logic for attaching "power" and "perf" domains to the GENI SE...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:15 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine (SE) drivers (I2C, SPI, and SERIAL) currently manage performance levels and operating points directly. This resulting in code duplication across drivers. such as configuring a specific level or find and apply an OPP based on a clock frequency. Introduce two new helper APIs, geni_se_set_perf_leve...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:16 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add DT bindings for the QUP GENI I2C controller on sa8255p platforms. SA8255p platform abstracts resources such as clocks, interconnect and GPIO pins configuration in Firmware. SCMI power and perf protocol are utilized to request resource configurations. SA8255p platform does not require the Serial Engine (SE) common...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:17 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Refactor the resource initialization in geni_i2c_probe() by introducing a new geni_i2c_resources_init() function and utilizing the common geni_se_resources_init() framework and clock frequency mapping, making the probe function cleaner. Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> --- v1->v2: - Upda...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:19 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Moving the serial engine setup to geni_i2c_init() API for a cleaner probe function and utilizes the PM runtime API to control resources instead of direct clock-related APIs for better resource management. Enables reusability of the serial engine initialization like hibernation and deep sleep features where hardware co...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:18 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
To manage GENI serial engine resources during runtime power management, drivers currently need to call functions for ICC, clock, and SE resource operations in both suspend and resume paths, resulting in code duplication across drivers. The new geni_se_resources_activate() and geni_se_resources_deactivate() helper APIs...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:20 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
To avoid repeatedly fetching and checking platform data across various functions, store the struct of_device_id data directly in the i2c private structure. This change enhances code maintainability and reduces redundancy. Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> --- drivers/i2c/busses/i2c-qcom-...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:21 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:22 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Mukesh, Anyone from Qualcomm willing to take a look here, please? Mukesh? Viken? Thanks, Andi
{ "author": "Andi Shyti <andi.shyti@kernel.org>", "date": "Wed, 14 Jan 2026 16:05:53 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Minor comment. Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> On 1/12/2026 4:17 PM, Praveen Talari wrote: Double space.
{ "author": "Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>", "date": "Wed, 21 Jan 2026 13:17:20 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> On 1/12/2026 4:17 PM, Praveen Talari wrote:
{ "author": "Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>", "date": "Wed, 21 Jan 2026 14:27:22 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> On 1/12/2026 4:17 PM, Praveen Talari wrote:
{ "author": "Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>", "date": "Wed, 21 Jan 2026 14:28:46 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> On 1/12/2026 4:17 PM, Praveen Talari wrote:
{ "author": "Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>", "date": "Wed, 21 Jan 2026 14:29:33 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> On 1/12/2026 4:17 PM, Praveen Talari wrote:
{ "author": "Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>", "date": "Wed, 21 Jan 2026 15:51:16 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: This calls dev_pm_opp_set_rate(se->dev, 0), dropping the performance state vote, but the other function doesn't have a counterpart to bring it back Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:05:21 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: The second argument is a NOP after patch 1.. originally I think I had a cross-subsys patch to get rid of that, neither solution is exactly pretty.. But otherwise, this looks good Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:10:15 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: [...] All clk APIs already perform a null-check internally, perhaps this call could be merged into geni_se_clks_off()? Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:11:31 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: [...] Please sprinkle somewhere into this kerneldoc that this is specifically for the SCMI-auto-VM setup, otherwise "the necessary power domains" is at best confusing to an external reader Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:12:59 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: [...] This function is never used I think with the SPI driver in mind (which seems to do a simple rateset for both backends) we could do: Then, we can do struct device * perf_dev = se->dev; if (se->pd_list && se->pd_list->pd_devs[DOMAIN_IDX_PERF]) perf_dev = se->pd_li...
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:23:12 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: Again, this should be a NOP after patch 1, that we can drop Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:29:28 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/12/26 11:47 AM, Praveen Talari wrote: [...] This means, on SCMI devices you won't don't the vote on the POWER domain (or PERF for that matter) and switch the GPIOs to a _suspend state - is that by design? Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 13:34:47 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Konrad, On 1/30/2026 6:04 PM, Konrad Dybcio wrote: With PD_FLAG_DEV_LINK_ON enabled, every pm_runtime_get_sync() or pm_runtime_put_sync() on the device triggers a corresponding genpd on/off transition. These transitions are translated into SCMI power‑domain commands, allowing the firmware (GearVM) to perform th...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 22:14:12 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Konrad, On 1/30/2026 5:35 PM, Konrad Dybcio wrote: This does not apply to I²C, since I²C lacks an OPP table, so the callback is only relevant for SPI and UART. All the refactored APIs were added as generic interfaces shared across I²C, SPI, and UART. Thanks, Praveen Talari
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 22:18:07 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Konrad On 1/30/2026 5:53 PM, Konrad Dybcio wrote: it will be used by UART driver, not for I2C/SPI. APIs were added as generic interfaces shared across I²C/SPI which is specific to firmware control, not Linux control. I don't think, it is needed since this is specific to firmware control, not Linux control. Th...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 22:24:06 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/30/2026 5:42 PM, Konrad Dybcio wrote: will update in next patch. Thanks. Praveen Talari
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 22:25:12 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Konrad On 1/30/2026 5:40 PM, Konrad Dybcio wrote: I will drop the second argument once these changes are ported across UART and SPI as well. Thanks, Praveen Talari
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Fri, 30 Jan 2026 22:30:04 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
On 1/30/26 5:44 PM, Praveen Talari wrote: Does that handle the >1 pd case too? If so, then all good Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 15:53:53 +0100", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi Konrad, On 1/30/2026 5:59 PM, Konrad Dybcio wrote: Will do in next patch. Thanks, Praveen
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 21:49:07 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi On 1/30/2026 5:42 PM, Konrad Dybcio wrote: Sure, will do in next patch. Thanks, Praveen
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 21:49:37 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Hi On 1/30/2026 5:41 PM, Konrad Dybcio wrote: Sure, will do in next patch. Thanks, Praveen
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 21:50:09 +0530", "thread_id": "20260112104722.591521-1-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 0/3] bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg
From: Chengkaitao <chengkaitao@kylinos.cn> When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2]. When writing test cases...
From: Chengkaitao <chengkaitao@kylinos.cn> For the following scenario: struct tree_node { struct bpf_rb_node node; struct request __kptr *req; u64 key; }; struct bpf_rb_root tree_root __contains(tree_node, node); struct bpf_spin_lock tree_lock; If we need to traverse all nodes in the rbtree, retrieve the ...
{ "author": "Chengkaitao <pilgrimtao@gmail.com>", "date": "Mon, 2 Feb 2026 17:00:49 +0800", "thread_id": "20260202090051.87802-1-pilgrimtao@gmail.com.mbox.gz" }
lkml
[PATCH v4 0/3] bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg
From: Chengkaitao <chengkaitao@kylinos.cn> When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2]. When writing test cases...
From: Chengkaitao <chengkaitao@kylinos.cn> When traversing an rbtree using bpf_rbtree_left/right, if bpf_kptr_xchg is used to access the __kptr pointer contained in a node, it currently requires first removing the node with bpf_rbtree_remove and clearing the NON_OWN_REF flag, then re-adding the node to the original rb...
{ "author": "Chengkaitao <pilgrimtao@gmail.com>", "date": "Mon, 2 Feb 2026 17:00:50 +0800", "thread_id": "20260202090051.87802-1-pilgrimtao@gmail.com.mbox.gz" }
lkml
[PATCH v4 0/3] bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg
From: Chengkaitao <chengkaitao@kylinos.cn> When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2]. When writing test cases...
From: Chengkaitao <chengkaitao@kylinos.cn> 1. Allow using bpf_kptr_xchg while holding a lock. 2. When the rb_node contains a __kptr pointer, we do not need to perform a remove-read-add operation. This patch implements the following workflow: 1. Construct a rbtree with 16 elements. 2. Traverse the rbtree, locate th...
{ "author": "Chengkaitao <pilgrimtao@gmail.com>", "date": "Mon, 2 Feb 2026 17:00:51 +0800", "thread_id": "20260202090051.87802-1-pilgrimtao@gmail.com.mbox.gz" }
lkml
[PATCH v4 0/3] bpf/verifier: Expand the usage scenarios of bpf_kptr_xchg
From: Chengkaitao <chengkaitao@kylinos.cn> When using bpf_kptr_xchg, we triggered the following error: 31: (85) call bpf_kptr_xchg#194 function calls are not allowed while holding a lock bpf_kptr_xchg can now be used in lock-held contexts, so we extended its usage scope in [patch 1/2]. When writing test cases...
On Mon, Feb 2, 2026 at 1:01 AM Chengkaitao <pilgrimtao@gmail.com> wrote: You ignored earlier feedback. This is not ok. pw-bot: cr
{ "author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>", "date": "Mon, 2 Feb 2026 09:56:50 -0800", "thread_id": "20260202090051.87802-1-pilgrimtao@gmail.com.mbox.gz" }
lkml
[PATCH v3 0/3] Convert 64-bit x86/mm/pat to ptdescs
x86/mm/pat should be using ptdescs. One line has already been converted to pagetable_free(), while the allocation sites use get_free_pages(). This causes issues separately allocating ptdescs from struct page. These patches convert the allocation/free sites to use ptdescs. In the short term, this helps enable Matthew's...
In order to separately allocate ptdescs from pages, we need all allocation and free sites to use the appropriate functions. Convert these pte allocation/free sites to use ptdescs. Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> --- arch/x86/mm/pat/set_memory.c | 15 +++++++++------ 1 file changed, 9 ins...
{ "author": "\"Vishal Moola (Oracle)\" <vishal.moola@gmail.com>", "date": "Mon, 2 Feb 2026 09:20:03 -0800", "thread_id": "20260202172005.683870-4-vishal.moola@gmail.com.mbox.gz" }
lkml
[PATCH v3 0/3] Convert 64-bit x86/mm/pat to ptdescs
x86/mm/pat should be using ptdescs. One line has already been converted to pagetable_free(), while the allocation sites use get_free_pages(). This causes issues separately allocating ptdescs from struct page. These patches convert the allocation/free sites to use ptdescs. In the short term, this helps enable Matthew's...
In order to separately allocate ptdescs from pages, we need all allocation and free sites to use the appropriate functions. split_large_page() allocates a page to be used as a page table. This should be allocating a ptdesc, so convert it. Signed-off-by: Vishal Moola (Oracle) <vishal.moola@gmail.com> --- arch/x86/mm/...
{ "author": "\"Vishal Moola (Oracle)\" <vishal.moola@gmail.com>", "date": "Mon, 2 Feb 2026 09:20:05 -0800", "thread_id": "20260202172005.683870-4-vishal.moola@gmail.com.mbox.gz" }
lkml
[PATCH v3 0/3] Convert 64-bit x86/mm/pat to ptdescs
x86/mm/pat should be using ptdescs. One line has already been converted to pagetable_free(), while the allocation sites use get_free_pages(). This causes issues separately allocating ptdescs from struct page. These patches convert the allocation/free sites to use ptdescs. In the short term, this helps enable Matthew's...
In order to separately allocate ptdescs from pages, we need all allocation and free sites to use the appropriate functions. Convert these pmd allocation/free sites to use ptdescs. populate_pgd() also allocates pagetables that may later be freed by try_to_free_pmd_page(), so allocate ptdescs there as well. Signed-off-...
{ "author": "\"Vishal Moola (Oracle)\" <vishal.moola@gmail.com>", "date": "Mon, 2 Feb 2026 09:20:04 -0800", "thread_id": "20260202172005.683870-4-vishal.moola@gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
On Sun, May 25, 2025 at 10:08 PM 戸田晃太 <kota.toda@gmo-cybersecurity.com> wrote: I do not see any barrier ? All these updates probably need WRITE_ONCE(), and corresponding READ_ONCE() on reader sides, at a very minimum ... RCU would even be better later.
{ "author": "Eric Dumazet <edumazet@google.com>", "date": "Mon, 26 May 2025 01:23:18 -0700", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
Thank you for your review. 2025年5月26日(月) 17:23 Eric Dumazet <edumazet@google.com>: I believe that locking is not necessary in this patch. The update of `header_ops` only happens when a slave is newly enslaved to a bond. Under such circumstances, members of `header_ops` are not called in parallel with updating. Therefo...
{ "author": "=?UTF-8?B?5oi455Sw5pmD5aSq?= <kota.toda@gmo-cybersecurity.com>", "date": "Wed, 28 May 2025 23:35:59 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
On Wed, May 28, 2025 at 7:36 AM 戸田晃太 <kota.toda@gmo-cybersecurity.com> wrote: bond_dev can certainly be live, and packets can flow. I have seen enough syzbot reports hinting at this precise issue.
{ "author": "Eric Dumazet <edumazet@google.com>", "date": "Wed, 28 May 2025 08:10:08 -0700", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
2025年5月29日(木) 0:10 Eric Dumazet <edumazet@google.com>: Hi Eric, Thank you for reviewing the patch. At the beginning of `bond_setup_by_slave`, `dev_close(bond_dev)` is called, meaning bond_dev is down and no packets can flow during the update of `bond_header_ops`. The syzbot report (you mentioned in the conversation...
{ "author": "=?UTF-8?B?5oi455Sw5pmD5aSq?= <kota.toda@gmo-cybersecurity.com>", "date": "Fri, 6 Jun 2025 16:16:31 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
Hello, Eric and other maintainers, I'm deeply sorry to have left the patch suggestion for this long period. I became extremely busy, and that took its toll on my health, causing me to take sick leave for nearly half a year (And my colleague Kota had been waiting for me to come back). As fortunately I've recovered and ...
{ "author": "=?UTF-8?B?5bCP5rGg5oKg55Sf?= <yuki.koike@gmo-cybersecurity.com>", "date": "Mon, 22 Dec 2025 17:20:02 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
Hello, Eric and other maintainers, I hope you’re doing well. I’m following up on our email, sent during the holiday season, in case it got buried. When you have a moment, could you please let us know if you had a chance to review it? Thank you in advance, and I look forward to your response. Best regards, Kota Toda...
{ "author": "=?UTF-8?B?5oi455Sw5pmD5aSq?= <kota.toda@gmo-cybersecurity.com>", "date": "Thu, 15 Jan 2026 19:33:36 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
On Thu, Jan 15, 2026 at 11:33 AM 戸田晃太 <kota.toda@gmo-cybersecurity.com> wrote: I think it would be nice to provide an actual stack trace of the bug, on a recent kernel tree. We had recent patches dealing with dev->hard_header_len changes.
{ "author": "Eric Dumazet <edumazet@google.com>", "date": "Thu, 15 Jan 2026 12:06:56 +0100", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
Thanks for your quick response. The following information is based on Linux kernel version 6.12.65, the latest release in the 6.12 tree. The kernel config is identical to that of the kernelCTF instance (available at: https://storage.googleapis.com/kernelctf-build/releases/lts-6.12.65/.config) This type confusion occ...
{ "author": "=?UTF-8?B?5oi455Sw5pmD5aSq?= <kota.toda@gmo-cybersecurity.com>", "date": "Mon, 19 Jan 2026 14:36:04 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
On Mon, Jan 19, 2026 at 6:36 AM 戸田晃太 <kota.toda@gmo-cybersecurity.com> wrote: OK thanks. I will repeat my original feedback : I do not see any barriers in the patch you sent. Assuming bond_setup_by_slave() can be called multiple times during one master lifetime, I do not think your patch is enough. Also, please cla...
{ "author": "Eric Dumazet <edumazet@google.com>", "date": "Mon, 19 Jan 2026 10:30:09 +0100", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
Here is the patch with the barriers added, based on v6.12.67. However, as Yuki said, we are wondering if this would be considered an acceptable change from the perspective of the maintainers (or in terms of Linux kernel culture). This is because the patch adds `READ_ONCE` to several locations outside of bonding subsys...
{ "author": "=?UTF-8?B?5oi455Sw5pmD5aSq?= <kota.toda@gmo-cybersecurity.com>", "date": "Wed, 28 Jan 2026 19:46:44 +0900", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH net] bonding: Fix header_ops type confusion
In bond_setup_by_slave(), the slave’s header_ops are unconditionally copied into the bonding device. As a result, the bonding device may invoke the slave-specific header operations on itself, causing netdev_priv(bond_dev) (a struct bonding) to be incorrectly interpreted as the slave's private-data type. This type-conf...
On Wed, Jan 28, 2026 at 11:46 AM 戸田晃太 <kota.toda@gmo-cybersecurity.com> wrote: Could you try to cook a patch series perhaps ? The READ_ONCE()/WRITE_ONCE() on dev->header_ops->cache could be done separately. Thanks.
{ "author": "Eric Dumazet <edumazet@google.com>", "date": "Mon, 2 Feb 2026 18:11:26 +0100", "thread_id": "CANn89iLVEJKoBtYNbAdLgxsPr03Fkgi9CJmTh1a0y0L5fV-HNA@mail.gmail.com.mbox.gz" }
lkml
[PATCH] staging: sm750fb: rename Bpp to bpp
Rename the Bpp parameter to bpp to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st...
On Mon, Feb 02, 2026 at 04:54:13PM +0200, yehudis9982 wrote: What does "bpp" stand for? Perhaps spell it out further? thanks, greg k-h
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Mon, 2 Feb 2026 16:01:17 +0100", "thread_id": "20260202165719.133879-1-y0533159982@gmail.com.mbox.gz" }
lkml
[PATCH] staging: sm750fb: rename Bpp to bpp
Rename the Bpp parameter to bpp to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st...
Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm...
{ "author": "yehudis9982 <y0533159982@gmail.com>", "date": "Mon, 2 Feb 2026 18:46:45 +0200", "thread_id": "20260202165719.133879-1-y0533159982@gmail.com.mbox.gz" }
lkml
[PATCH] staging: sm750fb: rename Bpp to bpp
Rename the Bpp parameter to bpp to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st...
Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm...
{ "author": "yehudis9982 <y0533159982@gmail.com>", "date": "Mon, 2 Feb 2026 18:57:18 +0200", "thread_id": "20260202165719.133879-1-y0533159982@gmail.com.mbox.gz" }
lkml
[PATCH] staging: sm750fb: rename Bpp to bpp
Rename the Bpp parameter to bpp to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st...
Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl. Signed-off-by: yehudis9982 <y0533159982@gmail.com> --- drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sm...
{ "author": "yehudis9982 <y0533159982@gmail.com>", "date": "Mon, 2 Feb 2026 19:12:43 +0200", "thread_id": "20260202165719.133879-1-y0533159982@gmail.com.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 06:27:38PM +0530, Pradeep P V K wrote: I think this patch just papers over the bug. If dma_need_unmap can't be trusted before the dma_map_* call, we've not saved the unmap information and the unmap won't work properly. So we'll need to extend the core code to tell if a mapping will set dma_sk...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Mon, 2 Feb 2026 15:35:48 +0100", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On 2026-02-02 2:35 pm, Christoph Hellwig wrote: The dma_need_unmap() kerneldoc says: "This function must be called after all mappings that might need to be unmapped have been performed." Trying to infer anything from it beforehand is definitely a bug in the caller. I don't see that being possible - at best we c...
{ "author": "Robin Murphy <robin.murphy@arm.com>", "date": "Mon, 2 Feb 2026 15:16:50 +0000", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 03:35:48PM +0100, Christoph Hellwig wrote: Agree There are two paths that lead to SWIOTLB in dma_direct_map_phys(). The first is is_swiotlb_force_bounce(dev), which dma_need_unmap() can easily evaluate. The second is more problematic, as it depends on dma_addr and size, neither of which...
{ "author": "Leon Romanovsky <leon@kernel.org>", "date": "Mon, 2 Feb 2026 17:22:52 +0200", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On 2026-02-02 3:22 pm, Leon Romanovsky wrote: This will always be true if a default SWIOTLB buffer exists at all, and thus pretty much defeat the point of whatever optimisation the caller is trying to make. Thanks, Robin.
{ "author": "Robin Murphy <robin.murphy@arm.com>", "date": "Mon, 2 Feb 2026 15:26:25 +0000", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 03:16:50PM +0000, Robin Murphy wrote: At least for HMM, dma_need_unmap() works as expected. HMM doesn't work with SWIOTLB. Thanks
{ "author": "Leon Romanovsky <leon@kernel.org>", "date": "Mon, 2 Feb 2026 17:58:04 +0200", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 03:16:50PM +0000, Robin Murphy wrote: Well that doesn't really make sense. No matter how many mappings the driver has done, there will always be more. ?
{ "author": "Keith Busch <kbusch@kernel.org>", "date": "Mon, 2 Feb 2026 10:13:24 -0700", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 06:27:38PM +0530, Pradeep P V K wrote: So the return of dma_need_unmap() may change after any call to dma_map_*? Does it only go from false -> true, and never back to false? Since we didn't allocate the dma_vecs here, doesn't that mean the completion side is leaking the mapping?
{ "author": "Keith Busch <kbusch@kernel.org>", "date": "Mon, 2 Feb 2026 10:18:12 -0700", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On Mon, Feb 02, 2026 at 10:13:24AM -0700, Keith Busch wrote: Yeah. It's more like if this returns true, all future calls, plus the previous one (which might have caused this). For that something like the patch below should work in nvme. Totally untested as I'm about to head away from the desk and prepare dinner. ...
{ "author": "Christoph Hellwig <hch@lst.de>", "date": "Mon, 2 Feb 2026 18:36:24 +0100", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH V1] nvme-pci: Fix NULL pointer dereference in nvme_pci_prp_iter_next
Fix a NULL pointer dereference that occurs in nvme_pci_prp_iter_next() when SWIOTLB bounce buffering becomes active during runtime. The issue occurs when SWIOTLB activation changes the device's DMA mapping requirements at runtime, creating a mismatch between iod->dma_vecs allocation and access logic. The problem mani...
On 2026-02-02 5:13 pm, Keith Busch wrote: But equally the fact that none of the mappings made so far happened to not need bouncing still doesn't mean that future ones won't. This is not guaranteed to be a static property of the device, but nor is it really a property of the *device* at all; it's a property of a set...
{ "author": "Robin Murphy <robin.murphy@arm.com>", "date": "Mon, 2 Feb 2026 17:39:14 +0000", "thread_id": "aYDcVDVFTWrBwzw_@kbusch-mbp.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The "qup-memory" interconnect path is optional and may not be defined in all device trees. Unroll the loop-based ICC path initialization to allow specific error handling for each path type. The "qup-core" and "qup-config" paths remain mandatory and will fail probe if missing, while "qup-memory" is now handled as optio...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:11 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add a new function geni_icc_set_bw_ab() that allows callers to set average bandwidth values for all ICC (Interconnect) paths in a single call. This function takes separate parameters for core, config, and DDR average bandwidth values and applies them to the respective ICC paths. This provides a more convenient API for...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:12 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate code for initializing shared resources such as clocks and interconnect paths. Introduce a new helper API, geni_se_resources_init(), to centralize this initialization logic, improving modularity and simplifying the probe function. Signed-off-by:...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:13 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource activation/deactivation sequences independently, leading to code duplication. Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to power on/off resources.The activate function enables ICC, clocks, and TLMM whereas the deactiva...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:14 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle the attachment of power domains. This often leads to duplicated code logic across different driver probe functions. Introduce a new helper API, geni_se_domain_attach(), to centralize the logic for attaching "power" and "perf" domains to the GENI SE...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:15 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine (SE) drivers (I2C, SPI, and SERIAL) currently manage performance levels and operating points directly. This resulting in code duplication across drivers. such as configuring a specific level or find and apply an OPP based on a clock frequency. Introduce two new helper APIs, geni_se_set_perf_leve...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:16 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add DT bindings for the QUP GENI I2C controller on sa8255p platforms. SA8255p platform abstracts resources such as clocks, interconnect and GPIO pins configuration in Firmware. SCMI power and perf protocol are utilized to request resource configurations. SA8255p platform does not require the Serial Engine (SE) common...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:17 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Refactor the resource initialization in geni_i2c_probe() by introducing a new geni_i2c_resources_init() function and utilizing the common geni_se_resources_init() framework and clock frequency mapping, making the probe function cleaner. Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com> --- v1->v2: - Upda...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:19 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v3 00/12] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Moving the serial engine setup to geni_i2c_init() API for a cleaner probe function and utilizes the PM runtime API to control resources instead of direct clock-related APIs for better resource management. Enables reusability of the serial engine initialization like hibernation and deep sleep features where hardware co...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 12 Jan 2026 16:17:18 +0530", "thread_id": "61ef66ac-3919-48e3-a78e-eef54001ae6f@oss.qualcomm.com.mbox.gz" }