source large_stringclasses 2
values | subject large_stringclasses 112
values | code large_stringclasses 112
values | critique large_stringlengths 61 3.04M ⌀ | metadata dict |
|---|---|---|---|---|
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Functions do not need to state return at the end, unless skipping
unwind. These can safely be dropped.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index a10f71620e732..4a64b4f37aeb3 1... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:24 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Extract the copying of the tree location from one maple state to another
into its own function. This is used more later.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_t... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:29 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Instead of using the maple big node, use the maple copy node for reduced
stack usage and aligning with mas_wr_rebalance() and
mas_wr_spanning_store().
Splitting a node is similar to rebalancing, but a new evaluation of when
to ascend is needed. The only other difference is that the data is
pushed and never rebalanced... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:31 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Stop using the maple big node for rebalance operations by changing to
more align with spanning store. The rebalance operation needs its own
data calculation in rebalance_data().
In the event of too much data, the rebalance tries to push the data
using push_data_sib(). If there is insufficient data, the rebalance
ope... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:27 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | This is the same as mas_leaf_max_gap(), but the information necessary is
known without a maple state in future code. Adding this function now
simplifies the review for a subsequent patch.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 48 ++++++++++++++++++++++++++++------------------... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:20 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Add plumbing work for using maple copy as a normal node for a source of
copy operations. This is needed later.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
include/linux/maple_tree.h | 1 +
lib/maple_tree.c | 5 +++++
2 files changed, 6 insertions(+)
diff --git a/include/linux/maple_tree.h... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:21 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | The split and rebalance store types both go through the same function
that uses the big node. Separate the code paths so that each can be
updated independently.
No functional change intended
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 47 +++++++++++++++++++++++-------------------... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:25 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Use the wr_mas instead of creating another variable on the stack. Take
the opportunity to remove l_mas from being used anywhere but in the
maple_subtree_state.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
dif... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:12 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | mas_extend_spanning_null() was not modifying the range min and range max
of the resulting store operation. The result was that the maple write
state no longer matched what the write was doing. This was not an issue
as the values were previously not used, but to make the ma_wr_state
usable in future changes, the range... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:11 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Figure out the end internally. This is necessary for future cleanups.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 064357a44906e..c9c63246f721c 100644
--- a/lib/maple_... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:34 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | When the maple copy node converges into a single entry, then certain
operations can stop ascending the tree.
This is used more later.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/lib/maple_tree.c b/li... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:30 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | During the big node removal, an incorrect rebalance step went too far up
the tree causing insufficient nodes. Test the faulty condition by
recreating the scenario in the userspace testing.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
tools/testing/radix-tree/maple.c | 125 ++++++++++++++++++++++++++++... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:28 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Instead of copying the data into the big node and finding out that the
data may need to be moved or appended to, calculate the data space up
front (in the maple copy node) and set up another source for the copy.
The additional copy source is tracked in the maple state sib (short for
sibling), and is put into the maple... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:19 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Spanning store had some corner cases which showed up during rcu stress
testing. Add explicit tests for those cases.
At the same time add some locking for easier visibility of the rcu
stress testing. Only a single dump of the tree will happen on the first
detected issue instead of flooding the console with output.
S... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:17 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | mas_wmb_replace() is called in three places with the same setup, move
the setup into the function itself. The function needs to be relocated
as it calls mtree_range_walk().
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 60 ++++++++++++++++++++----------------------------
1 file chan... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:33 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | The new_end does not need to be passed in as the data is already being
checked. This allows for other areas to skip getting the node new_end
in the calling function.
The type was incorrectly void * instead of void __rcu *, which isn't an
issue but is technically incorrect.
Move the variable assignment to after the d... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:35 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Stop using the maple subtree state and big node in favour of using three
destinations in the maple copy node. That is, expand the way leaves
were handled to all levels of the tree and use the maple copy node to
track the new nodes.
Extract out the sibling init into the data calculation since this is
where the insuffi... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:22 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Now that no one uses the structures and functions, drop the dead code.
Signed-off-by: Liam R. Howlett <Liam.Howlett@oracle.com>
---
lib/maple_tree.c | 1184 ----------------------------------------------
1 file changed, 1184 deletions(-)
diff --git a/lib/maple_tree.c b/lib/maple_tree.c
index 5813ad17ea6fe..1cfbed6fa... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Fri, 30 Jan 2026 15:59:32 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | On Fri, 30 Jan 2026 15:59:05 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
Updated, thanks.
What are your thoughts on adding this to 6.19? I'd expect to move it
into mm-stable Feb 17ish.
Below is how v3 altered mm.git:
--- a/lib/maple_tree.c~b
+++ a/lib/maple_tree.c
@@ -314,6 +314,13 @@ static inline ... | {
"author": "Andrew Morton <akpm@linux-foundation.org>",
"date": "Sat, 31 Jan 2026 12:27:24 -0800",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | Hello,
On Fri, 30 Jan 2026 15:59:26 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
I just found the above makes my build test using an old version compiler fails.
Fortunately, seems it is same to the one we discussed before [1], and same
mitigation like below attached patch works, at least for my test setu... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Sat, 31 Jan 2026 16:10:42 -0800",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | * SeongJae Park <sj@kernel.org> [260131 19:10]:
Thanks SJ.
This is still with gcc 8.1.0?
I thought debian stable would be old enough.
Thanks,
Liam | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Mon, 2 Feb 2026 09:58:31 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | * Andrew Morton <akpm@linux-foundation.org> [260131 15:27]:
I think the chance of making 6.19 has passed.
Can we please target getting this into testing in linux-next as soon as
6.19 ships?
The priority for me is to ensure this is rock-solid prior to release.
My concerns are corner cases and arch specific issues, wh... | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Mon, 2 Feb 2026 10:40:06 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | On Mon, 2 Feb 2026 09:58:31 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
My pleasure :)
Yes. The test code is available at GitHub [1].
Nonetheless, another test [2] that is using 9.3.0 was also failing.
[1] https://github.com/damonitor/damon-tests/blob/master/corr/tests/build_m68k.sh
[2] https://git... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 2 Feb 2026 07:56:26 -0800",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | * SeongJae Park <sj@kernel.org> [260202 10:56]:
You have two failures: one in 8.1 and one in 9.3?
I was planning to test 7.5.0 and ensure everything works, but this
implies my plan will not catch everything? | {
"author": "\"Liam R. Howlett\" <Liam.Howlett@oracle.com>",
"date": "Mon, 2 Feb 2026 12:01:53 -0500",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | On Mon, 2 Feb 2026 12:01:53 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
Yes. FYI, I picked the compiler versions for no good reason but just because
there were reports of DAMON build failures on the compilers in the past.
building kernel is 8.1. So gcc 7.5.0 might not need to be ensured for?
I have ... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 2 Feb 2026 09:53:53 -0800",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v3 00/30] maple_tree: Replace big node with maple copy | The big node struct was created for simplicity of splitting,
rebalancing, and spanning store operations by using a copy buffer to
create the data necessary prior to breaking it up into 256B nodes.
Certain operations were rather tricky due to the restriction of keeping
NULL entries together and never at the end of a nod... | On Mon, 2 Feb 2026 10:40:06 -0500 "Liam R. Howlett" <Liam.Howlett@oracle.com> wrote:
Sounds good, I'll push this back into mm-new until -rc1. | {
"author": "Andrew Morton <akpm@linux-foundation.org>",
"date": "Mon, 2 Feb 2026 10:31:54 -0800",
"thread_id": "20260202103154.ad1aa05611c79d21b070a861@linux-foundation.org.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The "qup-memory" interconnect path is optional and may not be defined
in all device trees. Unroll the loop-based ICC path initialization to
allow specific error handling for each path type.
The "qup-core" and "qup-config" paths remain mandatory and will fail
probe if missing, while "qup-memory" is now handled as optio... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:10 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | Add a new function geni_icc_set_bw_ab() that allows callers to set
average bandwidth values for all ICC (Interconnect) paths in a single
call. This function takes separate parameters for core, config, and DDR
average bandwidth values and applies them to the respective ICC paths.
This provides a more convenient API for... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:11 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate
code for initializing shared resources such as clocks and interconnect
paths.
Introduce a new helper API, geni_se_resources_init(), to centralize this
initialization logic, improving modularity and simplifying the probe
function.
Signed-off-by:... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:12 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | Currently, core clk is handled individually in protocol drivers like
the I2C driver. Move this clock management to the common clock APIs
(geni_se_clks_on/off) that are already present in the common GENI SE
driver to maintain consistency across all protocol drivers.
Core clk is now properly managed alongside the other ... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:13 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource
activation/deactivation sequences independently, leading to code
duplication.
Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to
power on/off resources.The activate function enables ICC, clocks, and TLMM
whereas the deactiva... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:14 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle
the attachment of power domains. This often leads to duplicated code
logic across different driver probe functions.
Introduce a new helper API, geni_se_domain_attach(), to centralize
the logic for attaching "power" and "perf" domains to the GENI SE... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:15 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The GENI Serial Engine (SE) drivers (I2C, SPI, and SERIAL) currently
manage performance levels and operating points directly. This resulting
in code duplication across drivers. such as configuring a specific level
or find and apply an OPP based on a clock frequency.
Introduce two new helper APIs, geni_se_set_perf_leve... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:16 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | Add DT bindings for the QUP GENI I2C controller on sa8255p platforms.
SA8255p platform abstracts resources such as clocks, interconnect and
GPIO pins configuration in Firmware. SCMI power and perf protocol
are utilized to request resource configurations.
SA8255p platform does not require the Serial Engine (SE) common... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:17 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | Moving the serial engine setup to geni_i2c_init() API for a cleaner
probe function and utilizes the PM runtime API to control resources
instead of direct clock-related APIs for better resource management.
Enables reusability of the serial engine initialization like
hibernation and deep sleep features where hardware co... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:18 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | Refactor the resource initialization in geni_i2c_probe() by introducing
a new geni_i2c_resources_init() function and utilizing the common
geni_se_resources_init() framework and clock frequency mapping, making the
probe function cleaner.
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Signed-off-by: Pravee... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:19 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | To manage GENI serial engine resources during runtime power management,
drivers currently need to call functions for ICC, clock, and
SE resource operations in both suspend and resume paths, resulting in
code duplication across drivers.
The new geni_se_resources_activate() and geni_se_resources_deactivate()
helper APIs... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:20 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | To avoid repeatedly fetching and checking platform data across various
functions, store the struct of_device_id data directly in the i2c
private structure. This change enhances code maintainability and reduces
redundancy.
Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>
Signed-off-by: Praveen Talari <prave... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:21 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | The Qualcomm automotive SA8255p SoC relies on firmware to configure
platform resources, including clocks, interconnects and TLMM.
The driver requests resources operations over SCMI using power
and performance protocols.
The SCMI power protocol enables or disables resources like clocks,
interconnect paths, and TLMM (GP... | {
"author": "Praveen Talari <praveen.talari@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:39:22 +0530",
"thread_id": "20260202180922.1692428-13-praveen.talari@oss.qualcomm.com.mbox.gz"
} |
lkml | [PATCH] mm/zswap: remove SWP_SYNCHRONOUS_IO swapcache bypass
workaround | From: Kairui Song <kasong@tencent.com>
Since commit f1879e8a0c60 ("mm, swap: never bypass the swap cache even
for SWP_SYNCHRONOUS_IO"), all swap-in operations go through the swap
cache, including those from SWP_SYNCHRONOUS_IO devices like
zram. Which means the workaround for swap cache bypassing
introduced by commit 2... | On Mon, Feb 2, 2026 at 1:47 AM Kairui Song <ryncsn@gmail.com> wrote:
LGTM, thanks!
Reviewed-by: Barry Song <baohua@kernel.org> | {
"author": "Barry Song <21cnbao@gmail.com>",
"date": "Mon, 2 Feb 2026 00:46:32 +0800",
"thread_id": "CACePvbUQaAw5Upz86kV0Wc9E71UHEm6MATYPAPajy2X2O=eWew@mail.gmail.com.mbox.gz"
} |
lkml | [PATCH] mm/zswap: remove SWP_SYNCHRONOUS_IO swapcache bypass
workaround | From: Kairui Song <kasong@tencent.com>
Since commit f1879e8a0c60 ("mm, swap: never bypass the swap cache even
for SWP_SYNCHRONOUS_IO"), all swap-in operations go through the swap
cache, including those from SWP_SYNCHRONOUS_IO devices like
zram. Which means the workaround for swap cache bypassing
introduced by commit 2... | On Sun, Feb 1, 2026 at 9:47 AM Kairui Song <ryncsn@gmail.com> wrote:
Acked-by: Chris Li <chrisl@kernel.org>
Chris | {
"author": "Chris Li <chrisl@kernel.org>",
"date": "Mon, 2 Feb 2026 10:22:45 -0800",
"thread_id": "CACePvbUQaAw5Upz86kV0Wc9E71UHEm6MATYPAPajy2X2O=eWew@mail.gmail.com.mbox.gz"
} |
lkml | [PATCH] mm/zswap: remove SWP_SYNCHRONOUS_IO swapcache bypass
workaround | From: Kairui Song <kasong@tencent.com>
Since commit f1879e8a0c60 ("mm, swap: never bypass the swap cache even
for SWP_SYNCHRONOUS_IO"), all swap-in operations go through the swap
cache, including those from SWP_SYNCHRONOUS_IO devices like
zram. Which means the workaround for swap cache bypassing
introduced by commit 2... | On Mon, Feb 02, 2026 at 01:47:32AM +0800, Kairui Song wrote:
Acked-by: Yosry Ahmed <yosry.ahmed@linux.dev>
Thanks! | {
"author": "Yosry Ahmed <yosry.ahmed@linux.dev>",
"date": "Mon, 2 Feb 2026 18:32:04 +0000",
"thread_id": "CACePvbUQaAw5Upz86kV0Wc9E71UHEm6MATYPAPajy2X2O=eWew@mail.gmail.com.mbox.gz"
} |
lkml | [PATCH v2] ext4: publish jinode after initialization | ext4_inode_attach_jinode() publishes ei->jinode to concurrent users.
It used to set ei->jinode before jbd2_journal_init_jbd_inode(),
allowing a reader to observe a non-NULL jinode with i_vfs_inode
still unset.
The fast commit flush path can then pass this jinode to
jbd2_wait_inode_data(), which dereferences i_vfs_inod... | On Fri 30-01-26 10:53:38, Li Chen wrote:
Looks pretty good. Some small comments below.
...
After some thought these two are guaranteed to be called about
EXT4_I(inode)->jinode is set and once set jinode never changes so I don't
think we need to change anything here (and it's actually somewhat
confusing because if... | {
"author": "Jan Kara <jack@suse.cz>",
"date": "Mon, 2 Feb 2026 17:37:48 +0100",
"thread_id": "vrtwp467z7npa2uppdntauxfzexgaa4vja3nueqdcn7z6e7zll@hj3tjryw2dst.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The TCSR block is described in two places: clock/qcom,sm8550-tcsr.yaml
and mfd/qcom,tcsr.yaml.
The former refers to the version of the block containing various gate
clocks, downstream from the main system refclk.
The latter refers to a version lacking that, instea... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:33 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
On SM8750 specifically, the TLMM block register space contains a number
of gates that forward the system XO (reference) clock to various IP
blocks.
Allow '#clock-cells' (since it provides clocks) and 'clocks' (so that
the parent clock may be consumed and linked wit... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:34 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Certain platforms (at least SM8750) had a number of registers
(responsible for gating refclk output to various consumers) moved to
TLMM. They're simple on/off toggles.
Expose them from the msm-pinctrl driver to allow for a reasonable DT
representation.
Signed-off-... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:35 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The gating toggles were moved to the TLMM register space on this
platform. They lived inside TCSR a generation prior and are back there
again a generation after.
Expose them, so that they can be consumed by other blocks.
Signed-off-by: Konrad Dybcio <konrad.dybcio... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:36 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
On SM8750 specifically, the block which provides various reference
clocks does *NOT* live inside TCSR, but rather TLMM.
With the former now being able to properly expose them, switch over to
the proper source.
Now, the TCSR still exists as a block for various tuna... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:37 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
This is now handled from within the pinctrl subsystem, since there is
no "CC" block inside SM8750's TCSR, as the corresponding hardware is
present within TLMM. Remove the leftovers.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
drivers/clk/qcom... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:38 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
SM8750 features a TCSR block (like any other Qualcomm platform),
however unlike its sibling platforms, it most notably does NOT contain
a clock controller, where XO-fed gates would reside.
Describe it.
Cc: <stable+noautosel@kernel.org> # complex dependencies, no i... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:39 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
The driver and the config option have been removed. Clean it up.
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
arch/arm64/configs/defconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/def... | {
"author": "Konrad Dybcio <konradybcio@kernel.org>",
"date": "Mon, 02 Feb 2026 15:57:40 +0100",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [RFC PATCH 0/8] Fix TCSR representation on SM8750 | As sparked by this thread:
<20260112151725.2308971-1-mukesh.ojha@oss.qualcomm.com>
The current representation of TCSR is wrong.
On platforms post and including SM8550, the TCSR had a sub-block in it,
containing gate clocks used for distributing the XO output to various
consumers. This is what we refer to as TCSR_CC u... | On Mon, Feb 02, 2026 at 03:57:32PM +0100, Konrad Dybcio wrote:
Thanks Konrad for taking this forward, while I was also working on your
suggestion to make tlmm a clock provider.
--
-Mukesh Ojha | {
"author": "Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>",
"date": "Mon, 2 Feb 2026 23:49:17 +0530",
"thread_id": "20260202181917.imo5lk3smwott2ue@hu-mojha-hyd.qualcomm.com.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Change '(x - 1) + x' to '2 * (x - 1) + 1' to avoid expanding the
non-trivial __type_half_max() twice.
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
include/linux/overflow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/l... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:18 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Since the type is always unsigned (T)-1 is always the correct value
so there is no need to use type_max().
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
include/linux/bits.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/includ... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:25 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Compile-time tests being added to BIT() make it an 'integer constant
expression' rather than a pre-processor expression for W=1 builds.
Change the BIT(PLANE_INDEX_BITS) != VIDEO_MAX_PLANES test to use
static_assert() so the code compiles.
Signed-off-by: David Laight ... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:20 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
The check for invalid 'compile time constant' parameters can easily be
changed to return 'failed' rather than generating a compile time error.
Add some tests for negative, swapped and overlarge values.
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
li... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:31 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Some compile time checks significantly bloat the pre-processor output
(particularly when the get nested).
Since the checks aren't really needed on every compilation enable with
W=c (adds -DKBUILD_EXTRA_WARNc) so the checks can be enabled per-build.
Make W=1 imply W=c s... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:19 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Compile-time tests being added to BIT() make it an 'integer constant
expression' rather than a pre-processor expression for W=1 builds.
Change the FRAC_ACC != BDS_UNIT test to use static_assert() so the code
compiles.
Signed-off-by: David Laight <david.laight.linux@g... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:21 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
asm/tlb.h isn't part of the vdso, use the linux/bits.h header.
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
arch/x86/include/asm/tlb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/tlb.h b/arch/x86/include/... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:24 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Casting the value of BIT_U*() and GENMASK_U8() to (u8) is pointless.
Although it changes what typeof(BIT_U8()) returns the value will
always be promoted to 'signed int' before it is used.
Instead force the expression to be an unsigned type.
Avoids unexpected sign exte... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:26 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
thread_info_tif.h isn't part of the vdso, use the linux/bits.h header.
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
include/asm-generic/thread_info_tif.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/asm-generic/thread_... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:23 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
The assembler only supports one type of signed integers, so expressions
using BITS_PER_LONG (etc) cannot be guaranteed to be correct.
Use ((2 << (h)) - (1 << (l))) for all assembler GENMASK() expansions and
add definitions of BIT_Uxx() as (1 << (nr)).
Note that 64bit... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:27 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Compile-time tests being added to BIT() make it an 'integer constant
expression' rather than a pre-processor expression for W=1 builds.
This means BIT() can't be used in pre-processor conditional that
checks 'PAGE_SIZE > IXGBE_MAX_DATA_PER_TXD'.
Change to use a normal... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:22 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
The current checks in GENMASK/BIT (eg reversed high/low) only work
for 'integer constant expressions' not 'compile-time constants'.
This is true for const_true() and -Wshift-count-overflow/negative.
While compile-time constants may be unusual, they can happen through
f... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:28 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
Since all the GENMASK() values are compile-time constants they can
be tested with BUILD_BUG_ON() rather than KUNIT_EXPECT_EQ().
Signed-off-by: David Laight <david.laight.linux@gmail.com>
---
lib/tests/test_bits.c | 90 +++++++++++++++++++++----------------------
1 fi... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:30 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | From: David Laight <david.laight.linux@gmail.com>
The definition of BIT() was moved from linux/bits.h to vdso/bits.h to
isolate the vdso from 'normal' kernel headers.
BIT_ULL() was then moved to be defined in the same place for consistency.
Since then linux/bits.h had gained BIT_Unn() and it really makes sense
for BI... | {
"author": "david.laight.linux@gmail.com",
"date": "Wed, 21 Jan 2026 14:57:29 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 02:57:29PM +0000, david.laight.linux@gmail.com wrote:
This is ugly.
Why can't the vDSO code make use of those checks, too?
Or use _BITUL() from the UAPI in the vDSO and remove vdso/bits.h. | {
"author": "Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>",
"date": "Wed, 21 Jan 2026 16:17:18 +0100",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On 21/01/2026 at 15:57, david.laight.linux@gmail.com wrote:
Did those new checks actually found any real problem in the code? This
adds a lot of complexity so I am not sure whether this is a winning
trade-off.
But then, you only solve that shift problem for GENMASK() and
BIT(). Any other usage of the left/right shif... | {
"author": "Vincent Mailhol <mailhol@kernel.org>",
"date": "Wed, 21 Jan 2026 19:43:07 +0100",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, 21 Jan 2026 19:43:07 +0100
Vincent Mailhol <mailhol@kernel.org> wrote:
Not in an x86-64 allmodconfig build.
They might in a 32bit one where there have definitely been issues.
I suspect the compiler test will find more than sparse.
I liked getting that to work, but maybe it is OTT.
But the W=c is more gener... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Wed, 21 Jan 2026 19:14:48 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, 21 Jan 2026 16:17:18 +0100
Thomas Weißschuh <thomas.weissschuh@linutronix.de> wrote:
It works :-)
I could have put an #ifndef BIT in vdso/bits.h instead.
I didn't actually find anything that just needed vdso/bits.h
linux/bits.h would get included - eg (IIRC) because of warn_on_once().
I'm not that sure why... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Wed, 21 Jan 2026 19:24:51 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 02:57:18PM +0000, david.laight.linux@gmail.com wrote:
Sure!
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook | {
"author": "Kees Cook <kees@kernel.org>",
"date": "Wed, 21 Jan 2026 12:59:36 -0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20260120]
url: https://github.com/intel-lab-lkp/linux/commits/david-laight-linux-gmail-com/overflow-Reduce-expansion-of-__type_max/20260122-013456
base: next-20260120
patch link: https://lore.kernel.org/r/20260121145731.... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Thu, 22 Jan 2026 08:50:22 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20260120]
url: https://github.com/intel-lab-lkp/linux/commits/david-laight-linux-gmail-com/overflow-Reduce-expansion-of-__type_max/20260122-013456
base: next-20260120
patch link: https://lore.kernel.org/r/20260121145731.... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Thu, 22 Jan 2026 09:11:53 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | Hi,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20260120]
url: https://github.com/intel-lab-lkp/linux/commits/david-laight-linux-gmail-com/overflow-Reduce-expansion-of-__type_max/20260122-013456
base: next-20260120
patch link: https://lore.kernel.org/r/20260121145731.... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Thu, 22 Jan 2026 09:23:16 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on next-20260120]
url: https://github.com/intel-lab-lkp/linux/commits/david-laight-linux-gmail-com/overflow-Reduce-expansion-of-__type_max/20260122-013456
base: next-20260120
patch link: https://lore.kernel.org/r/20260121145... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Thu, 22 Jan 2026 12:41:22 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 07:24:51PM +0000, David Laight wrote:
The #ifndef in vdso/bits.h is not much better IMO.
Given that there a multiple nicer options why not use on of those?
That is a bug. The vdso code should only include the vdso/ namespace.
Right now the inclusions are all over the place. I'd like to clean ... | {
"author": "Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <thomas.weissschuh@linutronix.de>",
"date": "Thu, 22 Jan 2026 08:39:42 +0100",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, 22 Jan 2026 09:11:53 +0800
kernel test robot <lkp@intel.com> wrote:
...
This might be a real bug.
The bit of mm.h is:
#define PP_DMA_INDEX_SHIFT (1 + __fls(PP_SIGNATURE - POISON_POINTER_DELTA))
#if POISON_POINTER_DELTA > 0
/* PP_SIGNATURE includes POISON_POINTER_DELTA, so limit the size of the DMA
* index ... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Thu, 22 Jan 2026 10:25:54 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, 22 Jan 2026 09:23:16 +0800
kernel test robot <lkp@intel.com> wrote:
...
Unless I change BIT() back I'll change that to a static_assert().
David | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Thu, 22 Jan 2026 10:30:29 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, 22 Jan 2026 12:41:22 +0800
kernel test robot <lkp@intel.com> wrote:
Can we stop sparse complaining about sizeof(VLA) ?
David | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Thu, 22 Jan 2026 10:33:37 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, Jan 22, 2026 at 10:33:37AM +0000, David Laight wrote:
First of all, the LKP should install the fork of sparse by Al Viro. That will
fix tons of warnings that are related to modules and speed up the process
itself.
--
With Best Regards,
Andy Shevchenko | {
"author": "Andy Shevchenko <andriy.shevchenko@linux.intel.com>",
"date": "Thu, 22 Jan 2026 16:26:44 +0200",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, 22 Jan 2026 16:26:44 +0200
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
The problem I have is I want to generate a compile time error inside:
__builtin_choose_expr(__is_constexpr(x), x && error_a(),
statically_true(y) && error_b());
Neither static_assert() nor a negative bitfield can be used ... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Thu, 22 Jan 2026 14:55:56 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, 22 Jan 2026 10:25:54 +0000
David Laight <david.laight.linux@gmail.com> wrote:
I've managed to do an s390 cross build.
It is all quite obvious really.
For s390 PAGE_OFFSET is usually zero (I think kernel and user mappings are separate?).
This make PP_DMA_INDEX_BITS 0.
PP_SIGNATURE is 64 - so PP_DMA_INDEX_SHIFT... | {
"author": "David Laight <david.laight.linux@gmail.com>",
"date": "Thu, 22 Jan 2026 20:10:20 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, Jan 22, 2026 at 10:33:37AM +0000, David Laight wrote:
Got it, we will avoid the direct report this 'sparse: Variable length array is used' warning. | {
"author": "Philip Li <philip.li@intel.com>",
"date": "Fri, 23 Jan 2026 09:24:50 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Thu, Jan 22, 2026 at 04:26:44PM +0200, Andy Shevchenko wrote:
Thanks Andy, i will switch to the repo from Al Viro for sparse. | {
"author": "Philip Li <philip.li@intel.com>",
"date": "Fri, 23 Jan 2026 09:25:36 +0800",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | Adding the relevant parties to the discussion:
+To: Al Viro
+To: Chris Li
On 23/01/2026 at 02:25, Philip Li wrote:
Al Viro's fork just adds 8 commit on top of the upstream sparse repo.
Wouldn't it be possible to just merge those?
That would be much less confusing.
Yours sincerely,
Vincent Mailhol | {
"author": "Vincent Mailhol <mailhol@kernel.org>",
"date": "Fri, 23 Jan 2026 09:01:04 +0100",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Fri, Jan 23, 2026 at 09:01:04AM +0100, Vincent Mailhol wrote:
Ideally yes, but you also should kick the distro's asses to update it, and
the sparse should bump its version...
Seems Al become a sparse maintainer de facto :-)
--
With Best Regards,
Andy Shevchenko | {
"author": "Andy Shevchenko <andriy.shevchenko@linux.intel.com>",
"date": "Fri, 23 Jan 2026 10:11:19 +0200",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Fri, Jan 23, 2026 at 10:11:19AM +0200, Andy Shevchenko wrote:
Huh? What happened to Chris? FWIW, I do have some followups to that series
sitting locally; need to get that finished (mostly for proper __VA_OPT__
handling; that got stalled on the lovely corner cases where the interplay
with side effects of macro ex... | {
"author": "Al Viro <viro@zeniv.linux.org.uk>",
"date": "Fri, 23 Jan 2026 08:20:27 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Fri, Jan 23, 2026 at 08:20:27AM +0000, Al Viro wrote:
I don't know, but upstream sparse haven't applied any solution for
MODULE*("FOO") stuff, nor reaction on my ping in that discussion
(I did it like week or so ago).
Thanks for doing all this!
--
With Best Regards,
Andy Shevchenko | {
"author": "Andy Shevchenko <andriy.shevchenko@linux.intel.com>",
"date": "Fri, 23 Jan 2026 10:24:01 +0200",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On 23/01/2026 at 09:24, Andy Shevchenko wrote:
After the project hiatus, I can imagine that there is some confusion :)
But Chris is back in his role of maintainer since September 2025. See:
- https://lore.kernel.org/linux-sparse/CACePvbXDO1ZybDu3RaFhED9D-9gC6LTMpWrxoh5xD+ZO5SLdzA@mail.gmail.com/
- https://git.ke... | {
"author": "Vincent Mailhol <mailhol@kernel.org>",
"date": "Fri, 23 Jan 2026 09:32:39 +0100",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Fri, Jan 23, 2026 at 09:32:39AM +0100, Vincent Mailhol wrote:
...
My ping: https://lore.kernel.org/all/aV9vo7_turBr84bs@black.igk.intel.com/
But now I realised that there was another version of the series, and Chris
seems active there.
https://lore.kernel.org/all/CACePvbU5Pqo=bw_j8arOq16o1JBOSwPtuMZBVozy4FV7YsSLG... | {
"author": "Andy Shevchenko <andriy.shevchenko@linux.intel.com>",
"date": "Fri, 23 Jan 2026 10:46:37 +0200",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 02:57:22PM +0000, david.laight.linux@gmail.com wrote:
Thanks David,
Other than the motivation above, I appreciate that this removes two
#ifdefs, improving readability (subjective) and compile coverage
(objective) of this code.
As an aside: I'm Not sure what your merge plan is for this patchse... | {
"author": "Simon Horman <horms@kernel.org>",
"date": "Fri, 23 Jan 2026 15:44:25 +0000",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 02:57:18PM +0000, david.laight.linux@gmail.com wrote:
Thanks!
Reviewed-by: Yury Norov <ynorov@nvidia.com> | {
"author": "Yury Norov <ynorov@nvidia.com>",
"date": "Mon, 2 Feb 2026 11:45:28 -0500",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH next 00/14] bits: De-bloat expansion of GENMASK() | From: David Laight <david.laight.linux@gmail.com>
The expansion of GENMASK() is a few hundred bytes, this is often multiplied
when the value is passed to other #defines (eg FIELD_PREP).
Part of the size is due to the compile-type check (for reversed arguments),
the rest from the way the value is defined.
Nothing in t... | On Wed, Jan 21, 2026 at 02:57:19PM +0000, david.laight.linux@gmail.com wrote:
Honestly I don't understand this. AFAIU, you've outlined a list of
compiler warnings that slow the compilation down, and you group them
under 'W=c' option.
What is the use case for it outside of your series. I think, a typical
user would fi... | {
"author": "Yury Norov <ynorov@nvidia.com>",
"date": "Mon, 2 Feb 2026 13:33:22 -0500",
"thread_id": "aYDUqBEnevBJLU53@yury.mbox.gz"
} |
lkml | [PATCH] staging: sm750fb: rename Bpp to bpp | Rename the Bpp parameter to bpp to avoid CamelCase, as reported by
checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st... | On Mon, Feb 02, 2026 at 04:54:13PM +0200, yehudis9982 wrote:
What does "bpp" stand for? Perhaps spell it out further?
thanks,
greg k-h | {
"author": "Greg KH <gregkh@linuxfoundation.org>",
"date": "Mon, 2 Feb 2026 16:01:17 +0100",
"thread_id": "20260202145413.132435-1-y0533159982@gmail.com.mbox.gz"
} |
lkml | [PATCH] staging: sm750fb: rename Bpp to bpp | Rename the Bpp parameter to bpp to avoid CamelCase, as reported by
checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st... | Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/sm... | {
"author": "yehudis9982 <y0533159982@gmail.com>",
"date": "Mon, 2 Feb 2026 18:46:45 +0200",
"thread_id": "20260202145413.132435-1-y0533159982@gmail.com.mbox.gz"
} |
lkml | [PATCH] staging: sm750fb: rename Bpp to bpp | Rename the Bpp parameter to bpp to avoid CamelCase, as reported by
checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st... | Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/sm... | {
"author": "yehudis9982 <y0533159982@gmail.com>",
"date": "Mon, 2 Feb 2026 18:57:18 +0200",
"thread_id": "20260202145413.132435-1-y0533159982@gmail.com.mbox.gz"
} |
lkml | [PATCH] staging: sm750fb: rename Bpp to bpp | Rename the Bpp parameter to bpp to avoid CamelCase, as reported by
checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/sm750fb/sm750_accel.c b/drivers/st... | Rename the Bpp parameter to bytes_per_pixel for clarity and to avoid CamelCase, as reported by checkpatch.pl.
Signed-off-by: yehudis9982 <y0533159982@gmail.com>
---
drivers/staging/sm750fb/sm750_accel.c | 26 +++++++++++++-------------
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/sm... | {
"author": "yehudis9982 <y0533159982@gmail.com>",
"date": "Mon, 2 Feb 2026 19:12:43 +0200",
"thread_id": "20260202145413.132435-1-y0533159982@gmail.com.mbox.gz"
} |
lkml | [syzbot] [hfs?] kernel BUG in may_open (3) | Hello,
syzbot found the following issue on:
HEAD commit: b6151c4e60e5 Merge tag 'erofs-for-6.19-rc5-fixes' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15d45922580000
kernel config: https://syzkaller.appspot.com/x/.config?x=7b058fb1d7dbe6b1
dashboard link: https://... | On Mon, Jan 12, 2026 at 12:51:33AM -0800, syzbot wrote:
This is hfsplus adding inodes with a non-valid mode. | {
"author": "Christian Brauner <brauner@kernel.org>",
"date": "Mon, 12 Jan 2026 10:27:14 +0100",
"thread_id": "de541759cfa4d216e342bf15b07f93a21f46498b.camel@ibm.com.mbox.gz"
} |
lkml | [syzbot] [hfs?] kernel BUG in may_open (3) | Hello,
syzbot found the following issue on:
HEAD commit: b6151c4e60e5 Merge tag 'erofs-for-6.19-rc5-fixes' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15d45922580000
kernel config: https://syzkaller.appspot.com/x/.config?x=7b058fb1d7dbe6b1
dashboard link: https://... | For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.
***
Subject: Private message regarding: [syzbot] [hfs?] kernel BUG in may_open (3)
Author: kapoorarnav43@gmail.com
#syz test
From: Arnav Kapoor <kapoorarnav43@gmail.com>
Date: Sun, 12 Jan 202... | {
"author": "syzbot <syzbot+f98189ed18c1f5f32e00@syzkaller.appspotmail.com>",
"date": "Mon, 12 Jan 2026 01:31:21 -0800",
"thread_id": "de541759cfa4d216e342bf15b07f93a21f46498b.camel@ibm.com.mbox.gz"
} |
lkml | [syzbot] [hfs?] kernel BUG in may_open (3) | Hello,
syzbot found the following issue on:
HEAD commit: b6151c4e60e5 Merge tag 'erofs-for-6.19-rc5-fixes' of git:/..
git tree: upstream
console output: https://syzkaller.appspot.com/x/log.txt?x=15d45922580000
kernel config: https://syzkaller.appspot.com/x/.config?x=7b058fb1d7dbe6b1
dashboard link: https://... | Since commit af153bb63a33 ("vfs: catch invalid modes in may_open()")
requires any inode be one of S_IFDIR/S_IFLNK/S_IFREG/S_IFCHR/S_IFBLK/
S_IFIFO/S_IFSOCK type, use S_IFREG for special inodes.
Reported-by: syzbot <syzbot+f98189ed18c1f5f32e00@syzkaller.appspotmail.com>
Closes: https://syzkaller.appspot.com/bug?extid=f... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Mon, 12 Jan 2026 18:39:23 +0900",
"thread_id": "de541759cfa4d216e342bf15b07f93a21f46498b.camel@ibm.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.