source large_stringclasses 2
values | subject large_stringclasses 112
values | code large_stringclasses 112
values | critique large_stringlengths 61 3.04M ⌀ | metadata dict |
|---|---|---|---|---|
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/31 9:43, Chen Ridong wrote:
I saw in patch 2/2 that isolated_cpus_updating is described as "protected by
cpuset_top_mutex." This could be a bit ambiguous: the caller need to hold either
cpus_read_lock or cpus_write_lock and cpuset_mutex to protect
isolated_cpus_updating.
--
Best regards,
Ridong | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 09:49:04 +0800",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/31 9:45, Waiman Long wrote:
This is somewhat confusing. cpuset_locked is only set to true when the "full
lock" has been acquired. If cpuset_locked is false, that should mean we are
outside of any critical region. Conversely, if we are inside a critical region,
cpuset_locked should be true.
The situation is ... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 10:05:21 +0800",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/30 23:42, Waiman Long wrote:
Introducing a new global lock warrants careful consideration. I wonder if we
could make all updates to isolated_cpus asynchronous. If that is feasible, we
could avoid adding a global lock altogether. If not, we need to clarify which
updates must remain synchronous and which ones ... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 10:53:28 +0800",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 9:05 PM, Chen Ridong wrote:
There is a comment above "cpuset_locked" which state which lock protect
it. The locking situation is becoming more complicated. I think I will
add a new patch to more clearly document what each global variable is
being protected by.
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Sat, 31 Jan 2026 18:00:02 -0500",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 9:53 PM, Chen Ridong wrote:
Almost all the cpuset code are run with cpuset_mutex held with either
cpus_read_lock or cpus_write_lock. So there is no concurrent
access/update to any of the cpuset internal data. The new
cpuset_top_mutex is aded to resolve the possible deadlock scenarios with
the new housek... | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Sat, 31 Jan 2026 18:13:09 -0500",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/2/1 7:00, Waiman Long wrote:
Yes, We need that.
--
Best regards,
Ridong | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Mon, 2 Feb 2026 08:58:49 +0800",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/2/1 7:13, Waiman Long wrote:
I agree with that point. However, we already have paths where isolated_cpus is
updated asynchronously, meaning parallel concurrent access/update is already
happening. Therefore, we cannot entirely avoid such scenarios, so why not keep
the locking simple(make all updates to isolated... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Mon, 2 Feb 2026 09:11:45 +0800",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On Fri, Jan 30, 2026 at 10:42:53AM -0500, Waiman Long wrote:
I agree with Chen that this is bloody terrible.
At the very least this should have:
lockdep_assert_held(&cpuset_mutex);
But ideally you'd do patches against this and tip/locking/core that add
proper __guarded_by() annotations to this. | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 14:05:26 +0100",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2/2/26 8:05 AM, Peter Zijlstra wrote:
Yes, I am going to remove cpuset_locked in the next version. As for
__guarded_by() annotation, I need to set up a clang environment that I
can use to test it before I will work on that. I usually just use gcc
for my compilation need.
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Mon, 2 Feb 2026 13:21:43 -0500",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2/1/26 8:11 PM, Chen Ridong wrote:
isolated_cpus should only be updated in isolated_cpus_update() where
both cpuset_mutex and callback_lock are held. It can be read
asynchronously if either cpuset_mutex or callback_lock is held. Can you
show me the places where this rule isn't followed?
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Mon, 2 Feb 2026 13:29:36 -0500",
"thread_id": "20260130154254.1422113-1-longman@redhat.com.mbox.gz"
} |
lkml | linux-next: manual merge of the ftrace tree with the bpf-next tree | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
from the bpf-next tree and commit:
f2cc020d7876 ("tracing: Fix various typos in comments")
from the ftrace tree.
I fixed it up... | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/Kconfig
between commit:
25e4e3565d45 ("ftrace: Introduce FTRACE_OPS_FL_JMP")
from the bpf-next tree and commit:
f93a7d0caccd ("ftrace: Allow tracing of some of the tracing code")
from the ftrace tree.
I fixed it up (see be... | {
"author": "Stephen Rothwell <sfr@canb.auug.org.au>",
"date": "Mon, 1 Dec 2025 09:33:43 +1100",
"thread_id": "20260202120430.760a448f@gandalf.local.home.mbox.gz"
} |
lkml | linux-next: manual merge of the ftrace tree with the bpf-next tree | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
from the bpf-next tree and commit:
f2cc020d7876 ("tracing: Fix various typos in comments")
from the ftrace tree.
I fixed it up... | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
93f0d09697613 ("bpf: move recursion detection logic to helpers")
from the bpf-next tree and commit:
f7d327654b886 ("bpf: Have __bpf_trace_run() use rcu_read_lock_dont_migrate()")
from the ftrace ... | {
"author": "Mark Brown <broonie@kernel.org>",
"date": "Mon, 2 Feb 2026 14:30:14 +0000",
"thread_id": "20260202120430.760a448f@gandalf.local.home.mbox.gz"
} |
lkml | linux-next: manual merge of the ftrace tree with the bpf-next tree | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
from the bpf-next tree and commit:
f2cc020d7876 ("tracing: Fix various typos in comments")
from the ftrace tree.
I fixed it up... | On Mon, 2 Feb 2026 14:30:14 +0000
Mark Brown <broonie@kernel.org> wrote:
Thanks Mark, the fix looks good to me. The conflict was caused by ftrace
doing a small change that was recommended by Alexei so I hope this isn't a
complex conflict ;-)
-- Steve | {
"author": "Steven Rostedt <rostedt@goodmis.org>",
"date": "Mon, 2 Feb 2026 11:20:10 -0500",
"thread_id": "20260202120430.760a448f@gandalf.local.home.mbox.gz"
} |
lkml | linux-next: manual merge of the ftrace tree with the bpf-next tree | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
from the bpf-next tree and commit:
f2cc020d7876 ("tracing: Fix various typos in comments")
from the ftrace tree.
I fixed it up... | On Mon, Feb 2, 2026 at 8:19 AM Steven Rostedt <rostedt@goodmis.org> wrote:
yep.
Conflict resolution is correct.
I wonder whether we should take the whole srcu_fast in tracepoints
patch set into bpf-next to avoid this conflict ?
Probably not worth it in the last week before the merge window.
Just a thought. | {
"author": "Alexei Starovoitov <alexei.starovoitov@gmail.com>",
"date": "Mon, 2 Feb 2026 08:42:55 -0800",
"thread_id": "20260202120430.760a448f@gandalf.local.home.mbox.gz"
} |
lkml | linux-next: manual merge of the ftrace tree with the bpf-next tree | Hi all,
Today's linux-next merge of the ftrace tree got a conflict in:
kernel/trace/bpf_trace.c
between commit:
d9c9e4db186a ("bpf: Factorize bpf_trace_printk and bpf_seq_printf")
from the bpf-next tree and commit:
f2cc020d7876 ("tracing: Fix various typos in comments")
from the ftrace tree.
I fixed it up... | On Mon, 2 Feb 2026 08:42:55 -0800
Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
It's already in next where it would require a revert to get rid of.
There's just one patch that touches the bpf code, so it still makes more
sense to keep it in the tracing tree.
-- Steve | {
"author": "Steven Rostedt <rostedt@goodmis.org>",
"date": "Mon, 2 Feb 2026 12:04:30 -0500",
"thread_id": "20260202120430.760a448f@gandalf.local.home.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | The update_isolation_cpumasks() function can be called either directly
from regular cpuset control file write with cpuset_full_lock() called
or via the CPU hotplug path with cpus_write_lock and cpuset_mutex held.
As we are going to enable dynamic update to the nozh_full housekeeping
cpumask (HK_TYPE_KERNEL_NOISE) soon... | {
"author": "Waiman Long <longman@redhat.com>",
"date": "Fri, 30 Jan 2026 10:42:53 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | The current cpuset partition code is able to dynamically update
the sched domains of a running system and the corresponding
HK_TYPE_DOMAIN housekeeping cpumask to perform what is essentally the
"isolcpus=domain,..." boot command line feature at run time.
The housekeeping cpumask update requires flushing a number of di... | {
"author": "Waiman Long <longman@redhat.com>",
"date": "Fri, 30 Jan 2026 10:42:54 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/30 23:42, Waiman Long wrote:
Can this happen?
cpu0 cpu1
[...]
isolated_cpus_updating = true;
...
// 'full_lock' is not acquired
update_isolation_cpumasks
// exec worker concurrently
isolcpus_workfn
cpuset_full_lock
isolated_cpus_updating = false;
cpuset_full_unlock();
// This r... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 08:47:37 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/30 23:42, Waiman Long wrote:
Adding a global variable makes this difficult to handle, especially in
concurrent scenarios, since we could read it outside of a critical region.
I suggest removing cpuset_locked and adding async_update_isolation_cpumasks
instead, which can indicate to the caller it should call ... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 08:58:40 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 7:47 PM, Chen Ridong wrote:
Note this statement.
That is not true. Either cpus_read_lock or cpus_write_lock and
cpuset_mutex are held when update_isolation_cpumasks() is called. So
there is mutual exclusion.
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Fri, 30 Jan 2026 20:06:33 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/31 9:06, Waiman Long wrote:
Thank you for reminder.
Eh, we currently assume that it can only be called from existing scenarios, so
it's okay for now. But I'm concerned that if we later use
update_isolation_cpumasks without realizing that we need to hold either
cpus_write_lock or (cpus_read_lock && cpuset_m... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 09:43:07 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 7:58 PM, Chen Ridong wrote:
No, cpuset_locked is always read from or written into inside a critical
section. It is under cpuset_mutex up to this point and then with the
cpuset_top_mutex with the next patch.
The point of this global variable is to distinguish between calling from
CPU hotplug and the other... | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Fri, 30 Jan 2026 20:45:52 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/31 9:43, Chen Ridong wrote:
I saw in patch 2/2 that isolated_cpus_updating is described as "protected by
cpuset_top_mutex." This could be a bit ambiguous: the caller need to hold either
cpus_read_lock or cpus_write_lock and cpuset_mutex to protect
isolated_cpus_updating.
--
Best regards,
Ridong | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 09:49:04 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/31 9:45, Waiman Long wrote:
This is somewhat confusing. cpuset_locked is only set to true when the "full
lock" has been acquired. If cpuset_locked is false, that should mean we are
outside of any critical region. Conversely, if we are inside a critical region,
cpuset_locked should be true.
The situation is ... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 10:05:21 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/1/30 23:42, Waiman Long wrote:
Introducing a new global lock warrants careful consideration. I wonder if we
could make all updates to isolated_cpus asynchronous. If that is feasible, we
could avoid adding a global lock altogether. If not, we need to clarify which
updates must remain synchronous and which ones ... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Sat, 31 Jan 2026 10:53:28 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 9:05 PM, Chen Ridong wrote:
There is a comment above "cpuset_locked" which state which lock protect
it. The locking situation is becoming more complicated. I think I will
add a new patch to more clearly document what each global variable is
being protected by.
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Sat, 31 Jan 2026 18:00:02 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 1/30/26 9:53 PM, Chen Ridong wrote:
Almost all the cpuset code are run with cpuset_mutex held with either
cpus_read_lock or cpus_write_lock. So there is no concurrent
access/update to any of the cpuset internal data. The new
cpuset_top_mutex is aded to resolve the possible deadlock scenarios with
the new housek... | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Sat, 31 Jan 2026 18:13:09 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/2/1 7:00, Waiman Long wrote:
Yes, We need that.
--
Best regards,
Ridong | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Mon, 2 Feb 2026 08:58:49 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2026/2/1 7:13, Waiman Long wrote:
I agree with that point. However, we already have paths where isolated_cpus is
updated asynchronously, meaning parallel concurrent access/update is already
happening. Therefore, we cannot entirely avoid such scenarios, so why not keep
the locking simple(make all updates to isolated... | {
"author": "Chen Ridong <chenridong@huaweicloud.com>",
"date": "Mon, 2 Feb 2026 09:11:45 +0800",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On Fri, Jan 30, 2026 at 10:42:53AM -0500, Waiman Long wrote:
I agree with Chen that this is bloody terrible.
At the very least this should have:
lockdep_assert_held(&cpuset_mutex);
But ideally you'd do patches against this and tip/locking/core that add
proper __guarded_by() annotations to this. | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Mon, 2 Feb 2026 14:05:26 +0100",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2/2/26 8:05 AM, Peter Zijlstra wrote:
Yes, I am going to remove cpuset_locked in the next version. As for
__guarded_by() annotation, I need to set up a clang environment that I
can use to test it before I will work on that. I usually just use gcc
for my compilation need.
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Mon, 2 Feb 2026 13:21:43 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH/for-next v2 0/2] cgroup/cpuset: Fix partition related locking issues | v2:
- Change patch 1 to use workqueue instead of task run as it is a
per-cpu kthread that performs the cpuset shutdown and bringup work.
- Simplify and streamline some of the code.
After booting the latest cgroup for-next debug kernel with the latest
cgroup changes as well as Federic's "cpuset/isolation: Hono... | On 2/1/26 8:11 PM, Chen Ridong wrote:
isolated_cpus should only be updated in isolated_cpus_update() where
both cpuset_mutex and callback_lock are held. It can be read
asynchronously if either cpuset_mutex or callback_lock is held. Can you
show me the places where this rule isn't followed?
Cheers,
Longman | {
"author": "Waiman Long <llong@redhat.com>",
"date": "Mon, 2 Feb 2026 13:29:36 -0500",
"thread_id": "c8a56031-023d-4bbe-b7af-53e91c6d1dfc@redhat.com.mbox.gz"
} |
lkml | [PATCH v2 0/2] ARM64 support for doorbell and intercept SINTs | From: "Anirudh Rayabharam (Microsoft)" <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hyper... | From: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>
Rename mshv_synic_init() to mshv_synic_cpu_init() and
mshv_synic_cleanup() to mshv_synic_cpu_exit() to better reflect that
these functions handle per-cpu synic setup and teardown.
Use mshv_synic_init/cleanup() to perform init/cleanup that is not per-cpu.
Mo... | {
"author": "Anirudh Rayabharam <anirudh@anirudhrb.com>",
"date": "Mon, 2 Feb 2026 18:27:05 +0000",
"thread_id": "20260202182706.648192-2-anirudh@anirudhrb.com.mbox.gz"
} |
lkml | [PATCH v2 0/2] ARM64 support for doorbell and intercept SINTs | From: "Anirudh Rayabharam (Microsoft)" <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hyper... | From: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hypervi... | {
"author": "Anirudh Rayabharam <anirudh@anirudhrb.com>",
"date": "Mon, 2 Feb 2026 18:27:06 +0000",
"thread_id": "20260202182706.648192-2-anirudh@anirudhrb.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Extend the DPLL core to support associating a DPLL pin with a firmware
node. This association is required to allow other subsystems (such as
network drivers) to locate and request specific DPLL pins defined in
the Device Tree or ACPI.
* Add a .fwnode field to the struct dpll_pin
* Introduce dpll_pin_fwnode_set() helpe... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:30 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Associate the registered DPLL pin with its firmware node by calling
dpll_pin_fwnode_set().
This links the created pin object to its corresponding DT/ACPI node
in the DPLL core. Consequently, this enables consumer drivers (such as
network drivers) to locate and request this specific pin using the
fwnode_dpll_pin_find()... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:31 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | From: Petr Oros <poros@redhat.com>
Currently, the DPLL subsystem reports events (creation, deletion, changes)
to userspace via Netlink. However, there is no mechanism for other kernel
components to be notified of these events directly.
Add a raw notifier chain to the DPLL core protected by dpll_lock. This
allows othe... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:32 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Allow drivers to register DPLL pins without manually specifying a pin
index.
Currently, drivers must provide a unique pin index when calling
dpll_pin_get(). This works well for hardware-mapped pins but creates
friction for drivers handling virtual pins or those without a strict
hardware indexing scheme.
Introduce DPL... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:33 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Add parsing for the "mux" string in the 'connection-type' pin property
mapping it to DPLL_PIN_TYPE_MUX.
Recognizing this type in the driver allows these pins to be taken as
parent pins for pin-on-pin pins coming from different modules (e.g.
network drivers).
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:34 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Refactor the reference counting mechanism for DPLL devices and pins to
improve consistency and prevent potential lifetime issues.
Introduce internal helpers __dpll_{device,pin}_{hold,put}() to
centralize reference management.
Update the internal XArray reference helpers (dpll_xa_ref_*) to
automatically grab a referen... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:35 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Add support for the REF_TRACKER infrastructure to the DPLL subsystem.
When enabled, this allows developers to track and debug reference counting
leaks or imbalances for dpll_device and dpll_pin objects. It records stack
traces for every get/put operation and exposes this information via
debugfs at:
/sys/kernel/debug... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:36 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | Update existing DPLL drivers to utilize the DPLL reference count
tracking infrastructure.
Add dpll_tracker fields to the drivers' internal device and pin
structures. Pass pointers to these trackers when calling
dpll_device_get/put() and dpll_pin_get/put().
This allows developers to inspect the specific references hel... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:37 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH net-next v4 0/9] dpll: Core improvements and ice E825-C SyncE support | This series introduces Synchronous Ethernet (SyncE) support for the Intel
E825-C Ethernet controller. Unlike previous generations where DPLL
connections were implicitly assumed, the E825-C architecture relies
on the platform firmware (ACPI) to describe the physical connections
between the Ethernet controller and extern... | From: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
Implement SyncE support for the E825-C Ethernet controller using the
DPLL subsystem. Unlike E810, the E825-C architecture relies on platform
firmware (ACPI) to describe connections between the NIC's recovered clock
outputs and external DPLL inputs.
Implement... | {
"author": "Ivan Vecera <ivecera@redhat.com>",
"date": "Mon, 2 Feb 2026 18:16:38 +0100",
"thread_id": "20260202171638.17427-1-ivecera@redhat.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | Change TEGRA_USB_HOSTPC1_DEVLC_PTS_HSIC to its literal value instead of
using the BIT macro, as it is an enumeration. Correct the spelling in the
comment and rename uhsic_registers_shift to uhsic_registers_offset.
These changes are cosmetic and do not affect code behavior.
Signed-off-by: Svyatoslav Ryhel <clamor95@gma... | {
"author": "Svyatoslav Ryhel <clamor95@gmail.com>",
"date": "Mon, 2 Feb 2026 10:05:23 +0200",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | Return exact error value from utmi_wait_register during HSIC power on.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/usb/phy/phy-tegra-usb.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c
index 3a7a74f01... | {
"author": "Svyatoslav Ryhel <clamor95@gmail.com>",
"date": "Mon, 2 Feb 2026 10:05:24 +0200",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | The parallel transceiver select used in HSIC mode differs on Tegra20,
where it uses the UTMI value (0), whereas Tegra30+ uses a dedicated HSIC
value. Reflect this in the SoC config.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/usb/phy/phy-tegra-usb.c | 7 +++----
include/linux/usb/tegra_usb_phy.... | {
"author": "Svyatoslav Ryhel <clamor95@gmail.com>",
"date": "Mon, 2 Feb 2026 10:05:25 +0200",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | The PORTSC1 register has a different offset in Tegra20 compared to
Tegra30+, yet they share a crucial set of registers required for HSIC
functionality. Reflect this register offset change in the SoC config.
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
---
drivers/usb/phy/phy-tegra-usb.c | 17 ++++++---------... | {
"author": "Svyatoslav Ryhel <clamor95@gmail.com>",
"date": "Mon, 2 Feb 2026 10:05:26 +0200",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | On Monday, February 2, 2026 5:05 PM Svyatoslav Ryhel wrote:
Series
Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com> | {
"author": "Mikko Perttunen <mperttunen@nvidia.com>",
"date": "Mon, 02 Feb 2026 17:10:37 +0900",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | On 2/2/26 11:05 AM, Svyatoslav Ryhel wrote:
This initialization seems pointless -- the newly added variable gets overwritten
by you later...
[...]
MBR, Sergey | {
"author": "Sergey Shtylyov <sergei.shtylyov@gmail.com>",
"date": "Mon, 2 Feb 2026 15:05:03 +0300",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | пн, 2 лют. 2026 р. о 14:05 Sergey Shtylyov <sergei.shtylyov@gmail.com> пише:
So? let it better be initialized and rewritten then later on catch errors. | {
"author": "Svyatoslav Ryhel <clamor95@gmail.com>",
"date": "Mon, 2 Feb 2026 14:14:13 +0200",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v1 0/4] usb: phy: tegra: HSIC adjustments | Followup to a recent HSIC bringup with a few small improvements.
Svyatoslav Ryhel (4):
usb: phy: tegra: cosmetic fixes
usb: phy: tegra: return error value from utmi_wait_register
usb: phy: tegra: parametrize HSIC PTS value
usb: phy: tegra: parametrize PORTSC1 register offset
drivers/usb/phy/phy-tegra-usb.c ... | On 2/2/26 3:14 PM, Svyatoslav Ryhel wrote:
I'm not sure what errors you mean here. To me, it (contrariwise) seems to
mask the possible errors when you forget to set err to e.g. -ENOMEM before
returning (when adding a call to kmalloc() or any other function that doesn't
return an error code itself)...
I'm pretty ... | {
"author": "Sergey Shtylyov <sergei.shtylyov@gmail.com>",
"date": "Mon, 2 Feb 2026 21:01:36 +0300",
"thread_id": "20260202080526.23487-1-clamor95@gmail.com.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | When CONFIG_MODULE_SIG is disabled set_module_sig_enforced() is defined
as an empty stub, so the check is unnecessary.
The specific configuration option for set_module_sig_enforced() is
about to change and removing the check avoids some later churn.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
arch/powe... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:46 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | When configuration settings are disabled the guarded functions are
defined as empty stubs, so the check is unnecessary.
The specific configuration option for set_module_sig_enforced() is
about to change and removing the checks avoids some later churn.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
securit... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:47 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | From: Coiby Xu <coxu@redhat.com>
Currently if set_module_sig_enforced is called with CONFIG_MODULE_SIG=n
e.g. [1], it can lead to a linking error,
ld: security/integrity/ima/ima_appraise.o: in function `ima_appraise_measurement':
security/integrity/ima/ima_appraise.c:587:(.text+0xbbb): undefined reference to ... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:45 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | Switching the types will make some later changes cleaner.
size_t is also the semantically correct type for this field.
As both 'size_t' and 'unsigned int' are always the same size, this
should be risk-free.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/module/internal.h | 2 +-
kernel/module/main... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:49 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The loading policy functionality will also be used by the hash-based
module validation. Split it out from CONFIG_MODULE_SIG so it is usable
by both.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/linux/module.h | 8 ++++----
kernel/module/Kconfig | 5 ++++-
kernel/module/main.c | 26 ++++++... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:53 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | With the addition of hash-based integrity checking, the configuration
matrix is easier to represent in a dedicated function and with explicit
usage of IS_ENABLED().
Drop the now unnecessary stub for module_sig_check().
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/module/internal.h | 7 -------
... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:54 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The upcoming module hashes functionality will build the modules in
between the generation of the BTF data and the final link of vmlinux.
At this point vmlinux is not yet built and therefore can't be used for
module BTF generation. vmlinux.unstripped however is usable and
sufficient for BTF generation.
Signed-off-by: T... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:51 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The lockdown check buried in module_sig_check() will not compose well
with the introduction of hash-based module validation.
Move it into module_integrity_check() which will work better.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/module/main.c | 6 +++++-
kernel/module/signing.c | 3 +--
2 f... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:55 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | It is not used outside of signing.c.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/module/internal.h | 1 -
kernel/module/signing.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/module/internal.h b/kernel/module/internal.h
index 618202578b42..e68fbcd60c35 100644
---... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:48 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The new hash-based module integrity checking will also be able to
satisfy the requirements of lockdown.
Such an alternative is not representable with "select", so use
"depends on" instead.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
security/lockdown/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 de... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:58 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The upcoming CONFIG_MODULE_HASHES will introduce a signature type.
This needs to be handled by callers differently than PKCS7 signatures.
Report the signature type to the caller and let them verify it.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/linux/module_signature.h | 2 +-
kernel/modu... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:57 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | CONFIG_MODULE_HASHES needs to process the modules at build time in the
exact form they will be loaded at runtime. If the modules are stripped
afterwards they will not be loadable anymore.
Also evaluate INSTALL_MOD_STRIP at build time and build the hashes based
on modules stripped this way.
If users specify inconsiste... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:29:01 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The logic to extract the signature bits from a module file are
duplicated between the module core and IMA modsig appraisal.
Unify the implementation.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
include/linux/module_signature.h | 4 +--
kernel/module/signing.c | 52 +++++++--------------... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:52 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | To allow CONFIG_MODULE_HASHES in combination with INSTALL_MOD_STRIP,
this logc will also be used by Makefile.modfinal.
Move it to a shared location to enable reuse.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
scripts/Makefile.lib | 32 ++++++++++++++++++++++++++++++++
scripts/Makefile.modinst | 37... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:29:00 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The signature splitting will also be used by CONFIG_MODULE_HASHES.
Move it up the callchain, so the result can be reused.
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
kernel/module/internal.h | 2 +-
kernel/module/main.c | 13 ++++++++++++-
kernel/module/signing.c | 21 +++++++--------------
3 fi... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:56 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The upcoming module hashes functionality will build the modules in
between the generation of the BTF data and the final link of vmlinux.
Having a dependency from the modules on vmlinux would make this
impossible as it would mean having a cyclic dependency.
Break this cyclic dependency by introducing a new target.
Sign... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:50 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | {
"author": "=?utf-8?q?Thomas_Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Tue, 13 Jan 2026 13:28:59 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On 2026-01-13 13:28:59 [+0100], Thomas Weißschuh wrote:
…
This and a few other instances below could be optimized to avoid
hashing. I probably forgot to let you know.
-> https://git.kernel.org/pub/scm/linux/kernel/git/bigeasy/mtree-hashed-mods.git/commit/?id=10b565c123c731da37befe862de13678b7c54877
Sebastian | {
"author": "Sebastian Andrzej Siewior <bigeasy@linutronix.de>",
"date": "Tue, 13 Jan 2026 15:56:35 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On 1/13/26 1:28 PM, Thomas Weißschuh wrote:
The patch looks to modify the behavior when mangled_module is true.
Previously, module_sig_check() didn't attempt to extract the signature
in such a case and treated the module as unsigned. The err remained set
to -ENODATA and the function subsequently consulted module_sig_... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Tue, 27 Jan 2026 16:20:15 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On 1/13/26 1:28 PM, Thomas Weißschuh wrote:
I suggest moving the IS_ENABLED(CONFIG_MODULE_SIG) block under the
new IS_ENABLED(CONFIG_MODULE_SIG_POLICY) section. I realize that
CONFIG_MODULE_SIG implies CONFIG_MODULE_SIG_POLICY, but I believe this
change makes it more apparent that this it the case. Otherwise, one
migh... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Thu, 29 Jan 2026 15:41:43 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On 1/13/26 1:28 PM, Thomas Weißschuh wrote:
The new else branch means that if the user chooses not to configure any
module integrity policy, they will no longer be able to load any
modules. I think this entire if-else part should be moved under the
IS_ENABLED(CONFIG_MODULE_SIG_POLICY) block above, as I'm mentioning on... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Thu, 29 Jan 2026 15:44:31 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On 1/13/26 1:28 PM, Thomas Weißschuh wrote:
I wonder if this dependency cycle could be resolved by utilizing the
split into vmlinux.unstripped and vmlinux that occurred last year.
The idea is to create the following ordering: vmlinux.unstripped ->
modules -> vmlinux, and to patch in .module_hashes only when building
... | {
"author": "Petr Pavlu <petr.pavlu@suse.com>",
"date": "Fri, 30 Jan 2026 18:06:20 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On Tue, Jan 13, 2026 at 01:28:46PM +0100, Thomas Weißschuh wrote:
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
--
Aaron Tomlin | {
"author": "Aaron Tomlin <atomlin@atomlin.com>",
"date": "Fri, 30 Jan 2026 15:43:09 -0500",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On Tue, Jan 13, 2026 at 01:28:47PM +0100, Thomas Weißschuh wrote:
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
--
Aaron Tomlin | {
"author": "Aaron Tomlin <atomlin@atomlin.com>",
"date": "Fri, 30 Jan 2026 15:49:16 -0500",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On Tue, Jan 13, 2026 at 01:28:48PM +0100, Thomas Weißschuh wrote:
Reviewed-by: Aaron Tomlin <atomlin@atomlin.com>
--
Aaron Tomlin | {
"author": "Aaron Tomlin <atomlin@atomlin.com>",
"date": "Fri, 30 Jan 2026 15:53:50 -0500",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packaging process much more complicated.
I think there is a middle ground whe... | {
"author": "=?UTF-8?q?Mihai-Drosi=20C=C3=A2ju?= <mcaju95@gmail.com>",
"date": "Sat, 31 Jan 2026 09:36:36 +0200",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | Hi Mihai-Drosi,
thanks for taking an interest into these patches!
On 2026-01-31 09:36:36+0200, Mihai-Drosi Câju wrote:
The goal is to make the distro kernel packages rebuildable by the
general public. Any involvement of secret values will break this goal.
I am not familiar with NixOS and its secret management.
Thi... | {
"author": "Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>",
"date": "Sun, 1 Feb 2026 17:22:12 +0100",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | Mihai-Drosi Câju <mcaju95@gmail.com> wrote:
There is another issue too: If you have a static private key that you use to
sign modules (and probably other things), someone will likely give you a GPL
request to get it.
One advantage of using a transient key every build and deleting it after is
that no one has the key.... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Sun, 01 Feb 2026 17:09:48 +0000",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On Sun, Feb 01, 2026 at 05:09:48PM +0000, David Howells wrote:
It sounds like hash-based module authentication is just better, then.
If the full set of authentic modules is known at kernel build time, then
signatures are unnecessary to verify their authenticity: a list of
hashes built into the kernel image is perfectl... | {
"author": "Eric Biggers <ebiggers@kernel.org>",
"date": "Sun, 1 Feb 2026 12:12:18 -0800",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | Eric Biggers <ebiggers@kernel.org> wrote:
Because it's not just signing of modules and it's not just modules built with
the kernel. Also a hash table just of module hashes built into the core
kernel image will increase the size of the kernel by around a third of a meg
(on Fedora 43 and assuming SHA512) with uncompre... | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 02 Feb 2026 09:21:19 +0000",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | On Mon, Feb 02, 2026 at 09:21:19AM +0000, David Howells wrote:
Module signing is indeed about the signing of modules.
Could you give more details on this use case and why it needs
signatures, as opposed to e.g. loading an additional Merkle tree root
into the kernel to add to the set of allowed modules?
This patchs... | {
"author": "Eric Biggers <ebiggers@kernel.org>",
"date": "Mon, 2 Feb 2026 10:30:55 -0800",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v4 00/17] module: Introduce hash-based integrity checking | The current signature-based module integrity checking has some drawbacks
in combination with reproducible builds. Either the module signing key
is generated at build time, which makes the build unreproducible, or a
static signing key is used, which precludes rebuilds by third parties
and makes the whole build and packa... | Eric Biggers <ebiggers@kernel.org> wrote:
The signature verification stuff in the kernel isn't just used for modules.
kexec, for instance; wifi restriction database for another.
Because we don't want to, for example, include all the nvidia drivers in our
kernel SRPM.
David | {
"author": "David Howells <dhowells@redhat.com>",
"date": "Mon, 02 Feb 2026 18:38:51 +0000",
"thread_id": "20260202183055.GB2036@quark.mbox.gz"
} |
lkml | [PATCH v2] hfsplus: fix s_fs_info leak on mount setup failure | Syzkaller reported a memory leak in hfsplus where s_fs_info (sbi) is
allocated in hfsplus_init_fs_context() but never freed if the mount
setup fails during setup_bdev_super().
In get_tree_bdev_flags(), if setup_bdev_super() fails, the superblock
is torn down via deactivate_locked_super(). Since this failure occurs
bef... | On Sun, 2026-02-01 at 18:42 +0530, Shardul Bankar wrote:
The patch [1] fixes the issue and it in HFS/HFS+ tree already.
Thanks,
Slava.
[1]
https://lore.kernel.org/linux-fsdevel/20251201222843.82310-3-mehdi.benhadjkhelifa@gmail.com/ | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Mon, 2 Feb 2026 17:53:57 +0000",
"thread_id": "cace4df975e1ae6e31af0103efcbca9cdb8b8350.camel@ibm.com.mbox.gz"
} |
lkml | [PATCH v2 0/2] ARM64 support for doorbell and intercept SINTs | From: "Anirudh Rayabharam (Microsoft)" <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hyper... | From: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>
Rename mshv_synic_init() to mshv_synic_cpu_init() and
mshv_synic_cleanup() to mshv_synic_cpu_exit() to better reflect that
these functions handle per-cpu synic setup and teardown.
Use mshv_synic_init/cleanup() to perform init/cleanup that is not per-cpu.
Mo... | {
"author": "Anirudh Rayabharam <anirudh@anirudhrb.com>",
"date": "Mon, 2 Feb 2026 18:27:05 +0000",
"thread_id": "20260202182706.648192-1-anirudh@anirudhrb.com.mbox.gz"
} |
lkml | [PATCH v2 0/2] ARM64 support for doorbell and intercept SINTs | From: "Anirudh Rayabharam (Microsoft)" <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hyper... | From: Anirudh Rayabharam (Microsoft) <anirudh@anirudhrb.com>
On x86, the HYPERVISOR_CALLBACK_VECTOR is used to receive synthetic
interrupts (SINTs) from the hypervisor for doorbells and intercepts.
There is no such vector reserved for arm64.
On arm64, the INTID for SINTs should be in the SGI or PPI range. The
hypervi... | {
"author": "Anirudh Rayabharam <anirudh@anirudhrb.com>",
"date": "Mon, 2 Feb 2026 18:27:06 +0000",
"thread_id": "20260202182706.648192-1-anirudh@anirudhrb.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | On Mon, Feb 02, 2026 at 12:03:11PM +0200, Bogdan Sandu wrote:
Was this an AI generated patch?
Either way, it needs to be properly broken up into "one logical change
per patch" like all others.
thanks,
greg k-h | {
"author": "Greg KH <gregkh@linuxfoundation.org>",
"date": "Mon, 2 Feb 2026 11:14:26 +0100",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | I can assure you, it is not AI-generated.
per patch" like all others.
Understood. I'll resend it afterwards.
Thank you for your patience. | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 12:18:43 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 12:18:44 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | On Mon, Feb 02, 2026 at 12:18:44PM +0200, Bogdan Sandu wrote:
You resent the same thing again?
confused,
greg k-h | {
"author": "Greg KH <gregkh@linuxfoundation.org>",
"date": "Mon, 2 Feb 2026 11:32:15 +0100",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | The previous patch has now been separated into four smaller ones, each one fixing a specific type of checkpatch.pl issue.
Bogdan Sandu (4):
media: ipu3: fix alignment
media: ipu3: use tabs
media: ipu3: avoid ending lines with paranthesis
media: ipu3: use BIT()
drivers/staging/media/ipu3/ipu3-css.c | 39 ++++... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 19:50:29 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | Fix alignment with parentheses.
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/media/ipu3/ipu3-css.c | 22 +++++++++++-----------
drivers/staging/media/ipu3/ipu3-v4l2.c | 11 +++++------
drivers/staging/media/ipu3/ipu3.c | 4 ++--
3 files changed, 18 insertions(+), 19 deletions(-... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 19:50:30 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | Use tabs instead of spaces.
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/media/ipu3/ipu3-css.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c
index 145501e90..e990eb5b3 100644
--- a/... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 19:50:31 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | Don't end line with paranthesis.
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/media/ipu3/ipu3-css.c | 13 +++++--------
drivers/staging/media/ipu3/ipu3.c | 3 +--
2 files changed, 6 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/stagi... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 19:50:32 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] Cleanup ipu3 driver | Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3
More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/medi... | Prefer BIT() macro over manual bitshift.
Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com>
---
drivers/staging/media/ipu3/ipu3-mmu.c | 2 +-
drivers/staging/media/ipu3/ipu3-mmu.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/me... | {
"author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>",
"date": "Mon, 2 Feb 2026 19:50:33 +0200",
"thread_id": "20260202175033.8640-1-bogdanelsandu2011@gmail.com.mbox.gz"
} |
lkml | [PATCH] hwmon: gpio-fan: allow to stop FANs when CONFIG_PM is
disabled | When CONFIG_PM is disabled, the GPIO controlled FANs can't be stopped by
using the sysfs attributes since commit 0d01110e6356 ("hwmon: (gpio-fan)
Add regulator support").
Using either the 'pwm1' or the 'fan1_target' attribute fails the same way:
$ echo 0 > /sys/class/hwmon/hwmon1/pwm1
ash: write error: Function n... | On Mon, Feb 02, 2026 at 04:58:57PM +0100, Gabor Juhos wrote:
Applied.
Thanks,
Guenter | {
"author": "Guenter Roeck <linux@roeck-us.net>",
"date": "Mon, 2 Feb 2026 08:58:33 -0800",
"thread_id": "12798a6f-ab17-40aa-9b0c-eb44a2684ce3@roeck-us.net.mbox.gz"
} |
lkml | [iwl-net PATCH v3] idpf: change IRQ naming to match netdev and
ethtool queue numbering | The code uses the vidx for the IRQ name but that doesn't match ethtool
reporting nor netdev naming, this makes it hard to tune the device and
associate queues with IRQs. Sequentially requesting irqs starting from
'0' makes the output consistent.
This commit changes the interrupt numbering but preserves the name
format... | Dear Brian,
Thank you for your patch.
Am 26.01.26 um 22:55 schrieb Brian Vazquez via Intel-wired-lan:
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul | {
"author": "Paul Menzel <pmenzel@molgen.mpg.de>",
"date": "Mon, 26 Jan 2026 23:33:18 +0100",
"thread_id": "CANn89i+ioEJFnZF3B36xGXcCPgtiLevZOs9pncXhgLKb80sm_g@mail.gmail.com.mbox.gz"
} |
lkml | [iwl-net PATCH v3] idpf: change IRQ naming to match netdev and
ethtool queue numbering | The code uses the vidx for the IRQ name but that doesn't match ethtool
reporting nor netdev naming, this makes it hard to tune the device and
associate queues with IRQs. Sequentially requesting irqs starting from
'0' makes the output consistent.
This commit changes the interrupt numbering but preserves the name
format... | On Mon, Jan 26, 2026 at 10:56 PM Brian Vazquez <brianvv@google.com> wrote:
Reviewed-by: Eric Dumazet <edumazet@google.com> | {
"author": "Eric Dumazet <edumazet@google.com>",
"date": "Tue, 27 Jan 2026 17:38:16 +0100",
"thread_id": "CANn89i+ioEJFnZF3B36xGXcCPgtiLevZOs9pncXhgLKb80sm_g@mail.gmail.com.mbox.gz"
} |
lkml | [PATCH] rtmutex: Introduce __cleanup() based infrastructure | Commit 54da6a092431 ("locking: Introduce __cleanup() based
infrastructure") introduced lock guards for mutexes in
include/linux/mutex.h, but, presumably as PREEMPT_RT wasn't merged at
the time, the guard for rt_mutex was never created. Do this now so this
infrastructure exists for rt_mutex as well.
Signed-off-by: Thom... | On 2026-02-02 18:04:43 [+0100], Thomas Böhler wrote:
Wait, what? rt_mutex can be used independently of PREEMPT_RT.
I suggest you focus on what this patch does in its description and
repost it with the locking maintainer in Cc.
Do you plan to have any users of this?
Sebastian | {
"author": "Sebastian Andrzej Siewior <bigeasy@linutronix.de>",
"date": "Mon, 2 Feb 2026 18:58:40 +0100",
"thread_id": "20260202175840.-IHSZ_Fn@linutronix.de.mbox.gz"
} |
lkml | [PATCH v7 0/6] i2c: xiic: use generic device property accessors | Switch to generic device property accessors.
Switch to managed devm_ functions to simplify error handling.
Skip clock setup on non-OF systems where clock cannot be provided.
Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
Changes in v7:
- Drop the dt-bindings patch.
- Skip clock setup on non-OF syste... | From: Abdurrahman Hussain <abdurrahman@nexthop.ai>
The devm_request_threaded_irq() already prints an error message. Remove
the duplicate.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Abdurrahman Hussain <abdurrahman@nexthop.ai>
---
drivers/i2c/bu... | {
"author": "Abdurrahman Hussain via B4 Relay <devnull+abdurrahman.nexthop.ai@kernel.org>",
"date": "Thu, 29 Jan 2026 21:43:15 +0000",
"thread_id": "7B60C48F-B2BA-4443-A4B7-F5086667A1F1@nexthop.ai.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.