data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | The EPF driver currently stores the incoming doorbell as a vector number
(irq_no + 1) in db_val and db_clear() clears all bits unconditionally.
This breaks db_read()/db_clear() semantics when multiple doorbells are
used.
Store doorbells as a bitmask (BIT_ULL(vector)) and make
db_clear(db_bits) clear only the specified... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:54 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | Implement .db_vector_count and .db_vector_mask so ntb core/clients can
map doorbell events to per-vector work.
Report vectors as 0..(db_count - 2) (skipping the unused slot) and
return BIT_ULL(db_vector) for the corresponding doorbell bit.
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Reviewed-by: Frank Li <Frank.Li... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:55 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | Implement .db_vector_count and .db_vector_mask so ntb core/clients can map
doorbell events to per-vector work and avoid the thundering-herd behavior.
pci-epf-vntb reserves two slots in db_count: slot 0 for link events and
slot 1 which is historically unused. Therefore the number of doorbell
vectors is (db_count - 2).
... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:49:50 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | On Fri, Feb 27, 2026 at 05:49:45PM +0900, Koichiro Den wrote:
Sorry, I accidentally used an incorrect series title.
The correct subject should be:
[PATCH v2 00/10] NTB: epf: Enable per-doorbell bit handling while keeping legacy offset
For reference, v1 is:
https://lore.kernel.org/linux-pci/20260224133459.1741537-1... | {
"author": "Koichiro Den <den@valinux.co.jp>",
"date": "Fri, 27 Feb 2026 17:57:40 +0900",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | On Fri, Feb 27, 2026 at 05:49:47PM +0900, Koichiro Den wrote:
Does it need call disable_work_sync() in unbind or remove() function?
Frank | {
"author": "Frank Li <Frank.li@nxp.com>",
"date": "Fri, 27 Feb 2026 10:49:28 -0500",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | On Fri, Feb 27, 2026 at 05:49:50PM +0900, Koichiro Den wrote:
Reviewed-by: Frank Li <Frank.Li@nxp.com> | {
"author": "Frank Li <Frank.li@nxp.com>",
"date": "Fri, 27 Feb 2026 10:50:28 -0500",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | This series fixes doorbell bit/vector handling for the EPF-based NTB
pair (ntb_hw_epf <-> pci-epf-*ntb). Its primary goal is to enable safe
per-db-vector handling in the NTB core and clients (e.g. ntb_transport),
without changing the on-the-wire doorbell mapping.
Background / problem
====================
ntb_hw_epf ... | null | null | null | [PATCH v2 00/10] PCI: endpoint: pci-epf-vntb: Document legacy MSI doorbell offset | On Fri, Feb 27, 2026 at 05:49:52PM +0900, Koichiro Den wrote:
Reviewed-by: Frank Li <Frank.Li@nxp.com> | {
"author": "Frank Li <Frank.li@nxp.com>",
"date": "Fri, 27 Feb 2026 10:51:18 -0500",
"is_openbsd": false,
"thread_id": "aaG9COYXPJamIvTx@lizhi-Precision-Tower-5810.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Instead of requiring -o inlinecrypt to enable inline encryption, allow
having s_cop->has_per_extent_encryption to indicate that this file
system supports inline encryption.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.com>
---
v5: ... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:34 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Previously we were wiping the master key secret when we do
FS_IOC_REMOVE_ENCRYPTION_KEY, and then using the fact that it was
cleared as the mechanism from keeping new users from being setup. This
works with inode based encryption, as the per-inode key is derived at
setup time,... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:36 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
This adds the code necessary for per-extent encryption. We will store a
nonce for every extent we create, and then use the inode's policy and
the extents nonce to derive a per-extent key.
This is meant to be flexible, if we choose to expand the on-disk extent
information in t... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:33 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We have fscrypt_file_open() which is meant to be called on files being
opened so that their key is loaded when we start reading data from them.
However for btrfs send we are opening the inode directly without a filp,
so we need a different helper to make sure we can load the f... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:35 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Btrfs does checksumming, and the checksums need to match the bytes on
disk. In order to facilitate this add a process bio callback for the
blk-crypto layer. This allows the file system to specify a callback and
then can process the encrypted bio as necessary.
For btrfs, writ... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:37 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
This will allow file systems to set a process_bio hook for inline
encryption. This will be utilized by btrfs in order to make sure the
checksumming work is done on the encrypted bio's.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.c... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:38 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
btrfs stores its data structures, including filenames in directories, in
its own buffer implementation, struct extent_buffer, composed of
several non-contiguous pages. We could copy filenames into a
temporary buffer and use fscrypt_match_name() against that buffer, such
extens... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:39 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Add a couple of sections to the fscrypt documentation about per-extent
encryption.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.com>
---
v5: https://lore.kernel.org/linux-btrfs/7b2cc4dd423c3930e51b1ef5dd209164ff11c05a.1706116485.gi... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:40 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
In order to appropriately encrypt, create, open, rename, and various
symlink operations must call fscrypt hooks. These determine whether the
inode should be encrypted and do other preparatory actions. The
superblock must have fscrypt operations registered, so implement the
min... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:42 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
When we add fscrypt support we're going to have fscrypt objects hanging
off of extent_maps. This includes a block key, which if we're the last
one freeing the key we may have to unregister it from the block layer.
This requires taking a semaphore in the block layer, which mean... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:41 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
fscrypt stores a context item with encrypted inodes that contains the
related encryption information. fscrypt provides an arbitrary blob for
the filesystem to store, and it does not clearly fit into an existing
structure, so this goes in a new item type.
Signed-off-by: Omar ... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:43 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
As encrypted files will be incompatible with older filesystem versions,
new filesystems should be created with an incompat flag for fscrypt,
which will gate access to the encryption ioctls.
Signed-off-by: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Sweet Tea Dorminy <s... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:44 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
These ioctls allow encryption to actually be used.
The set_encryption_policy ioctl is the thing which actually turns on
encryption, and therefore sets the ENCRYPT flag in the superblock.
This prevents the filesystem from being loaded on older kernels.
fscrypt provides CONFIG... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:47 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
For encrypted or unencrypted names, we calculate the offset for the dir
item by hashing the name for the dir item. However, this doesn't work
for a long nokey name, where we do not have the complete ciphertext.
Instead, fscrypt stores the filesystem-provided hash in... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:46 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Omar Sandoval <osandov@osandov.com>
Deleting an encrypted file must always be permitted, even if the user
does not have the appropriate key. Therefore, for listing an encrypted
directory, so-called 'nokey' names are provided, and these nokey names
must be sufficient to look up and delete the appropriate encrypte... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:45 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We need this to make sure the appropriate encryption algorithms are
turned on in our config if we have FS_ENCRYPTION enabled, and
additionally we only support inline encryption with the fallback block
crypto, so we need to make sure we pull in those dependencies.
Signed-off-by... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:48 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Each extent_map will end up with a pointer to its associated
fscrypt_info if any, which should have the same lifetime as the
extent_map. We are also going to need to track the encryption_type
for the file extent items. Add the fscrypt_info to the extent_map and
th... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:51 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We're going to need these to update the file extent items once the
writes are complete. Add them and add the pieces necessary to assign
them and free everything.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.com>
---
v5: https://lo... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:52 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Since extent encryption requires inline encryption, even though we
expect to use the inlinecrypt software fallback most of the time, we
need to enumerate all the devices in use by btrfs.
Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Signed-off-by: J... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:49 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
This puts the long-preserved 1-byte encryption field to work, storing
whether the extent is encrypted. Update the tree-checker to allow for
the encryption bit to be set to our valid types.
Signed-off-by: Sweet Tea Dorminy <sweettea-kernel@dorminy.me>
Signed-off-by... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:50 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
The fscrypt_extent_info will be tied to the extent_map lifetime, so it
will be created when we create the IO em, or it'll already exist in the
NOCOW case. Use this fscrypt_info when creating the ordered extent to
make sure everything is passed through properly.
Signed-off-by:... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:54 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We keep track of this information in the ordered extent for writes, but
we need it for reads as well. Add fscrypt_extent_info and orig_start to
the dio_data so we can populate this on reads. This will be used later
when we attach the fscrypt context to the bios.
Signed-off-b... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:55 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We're going to be getting fscrypt_info from the extent maps. Pass the
fscrypt_info to helpers using the file_extent structure and use that
to set the encryption type on the ordered extent.
For prealloc extents we create an em, since we already have the context
loaded from the... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:53 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Now that we have the fscrypt_extnet_info in all of the supporting
structures, pass this through and set the file extent encryption bit
accordingly from the supporting structures. In subsequent patches code
will be added to populate these appropriately.
Signed-off-by: Josef Ba... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:57 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
The fscrypt encryption context will be stored as a new tree item type.
This gives us flexibility to include different things in the future.
Also update the tree-checker to validate the new item type.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vace... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:56 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
New extents for encrypted inodes must have a fscrypt_extent_info, which
has the necessary keys and does all the registration at the block layer
for them. This is passed through all of the infrastructure we've
previously added to make sure the context gets saved properly with t... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:59 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
This patch implements the necessary hooks from fscrypt to support
per-extent encryption. There's two main entry points
btrfs_fscrypt_load_extent_info
btrfs_fscrypt_save_extent_info
btrfs_fscrypt_load_extent_info gets called when we create the extent
maps from the file extent... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:22:58 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Now that we have the fscrypt_info plumbed through everywhere, add the
code to setup the bio encryption context from the extent context.
We use the per-extent fscrypt_extent_info for encryption/decryption.
We use the offset into the extent as the lblk for fscrypt. So the start... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:01 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
For extent encryption we have to use a logical block nr as input for the
IV. For btrfs we're using the offset into the extent we're operating
on. For most ordered extents this is the same as the file_offset,
however for prealloc and NOCOW we have to use the original offset.
... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:00 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We only ever needed the bbio in btrfs_csum_one_bio, since that has the
bio embedded in it. However with encryption we'll have a different bio
with the encrypted data in it, and the original bbio. Update
btrfs_csum_one_bio to take the bio we're going to csum as an argument,
wh... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:02 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We are going to be checksumming the encrypted data, so we have to
implement the ->process_bio fscrypt callback. This will provide us with
the original bio and the encrypted bio to do work on. For WRITE's this
will happen after the encrypted bio has been encrypted. For READ's... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:04 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
In send we're going to be looking up file names from back references and
putting them into the send stream. If we are encrypted use the helper
for decrypting names and copy the decrypted name into the buffer.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Da... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:09 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
For the fallback encrypted writes it allocates a bounce buffer to
encrypt, and if the bio is larger than 256 segments it splits the bio we
send down. This wreaks havoc on us because we need our actual original
bio to be passed into the process_cb callback in order to get at ou... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:03 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
In order to do read repair we will allocate sectorsize bio's and read
them one at a time, repairing any sectors that don't match their csum.
In order to do this we re-submit the IO's after it's failed, and at this
point we still need the fscrypt_extent_info for these new bio's.... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:05 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
btrfs/330 uncovered a problem where we were accidentally turning off the
free space tree when we do the transition from ro->rw. This happens
because we don't update
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.com>
---
v5: https:/... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:11 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We will drop the inode and re-look it up to do defrag with auto defrag,
which means we could lose the encryption policy.
Auto defrag needs to be reworked to just hold onto the inode for
scheduling later so we don't lose the context. For now just disable it
if the file is encr... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:13 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
In order to enable more thorough testing of fscrypt enable the
test_dummy_encryption mount option. This is used by fscrypt users to
easily enable fscrypt on the file system for testing without needing to
do the key setup and everything.
The only deviation from other file syst... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:06 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
send needs to track the dir item values to see if files were renamed
when doing an incremental send. There is code to decrypt the names, but
this breaks the code that checks to see if something was overwritten.
Until this gap is closed we need to disable send on encrypted file... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:15 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
We use this helper for inode-resolve and path resolution in send, so
update this helper to properly decrypt any encrypted names it finds.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@suse.com>
---
v5: https://lore.kernel.org/linux-btrfs... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:07 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Send needs to send the decrypted value of the symlinks, handle the case
where the inode is encrypted and decrypt the symlink name into a buffer
and copy this buffer into our fs_path struct.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Daniel Vacek <neelx@su... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:08 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
For send we will read the pages and copy them into our buffer. Use the
fscrypt_inode_open helper to make sure the key is loaded properly before
trying to read from the inode so the contents are properly decrypted.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Signed-off-b... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:10 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
Log replay needs a few tweaks in order to make sure everything works
with encryption.
1. Copy in the fscrypt context if we find one in the log.
2. Set NEEDS_FULL_SYNC when we update the inode context so all of the
items are copied into the log at fsync time.
This makes rep... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:12 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | From: Josef Bacik <josef@toxicpanda.com>
The RAID5/6 code will re-arrange bios and submit them through a
different mechanism. This is problematic with inline encryption as we
have to get the bio and csum it after it's been encrypted, and the
radi5/6 bio's don't have the btrfs_bio embedded, so we have no way to
get th... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:23:14 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Heads up,
I also have related btrfs-progs and xfs-tests changes matching this
series. But I won't be able to send them before my vacation next week.
That also means I will (most likely) not be able to get back to review
feedback before Feb 16. But for sure, any feedback is appreciated.
Thank you,
Daniel
On Fri, 6 Fe... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 6 Feb 2026 19:42:44 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On 2/6/26 10:22 AM, Daniel Vacek wrote:
alongside
omissions
policy; all other policies
systems; the amount of
--
~Randy | {
"author": "Randy Dunlap <rdunlap@infradead.org>",
"date": "Fri, 6 Feb 2026 10:43:24 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 05:14:57 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:02:41 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:08:09 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:10:49 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:12:12 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:16:31 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:18:57 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:22:37 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:28:21 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:35:32 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:36:25 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | Daniel Vacek <neelx@suse.com> wrote:
Hi everyone,
I'm running the btrfs for-next branch, along with the encryption patch set
through my AI review prompts:
https://github.com/masoncl/review-prompts
I'm working on some btrfs specific instructions, but hopefully these reviews
are already useful. I've kept the headers... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Sun, 8 Feb 2026 07:44:45 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Fri, 6 Feb 2026 at 19:43, Randy Dunlap <rdunlap@infradead.org> wrote:
Thanks Randy. I'll amend all these in the next iteration.
--nX | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Tue, 17 Feb 2026 15:48:20 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:46, Chris Mason <clm@meta.com> wrote:
True. Fixed with the below hunk. Thanks!
--- a/fs/btrfs/inode.c
+++ b/fs/btrfs/inode.c
@@ -6574,7 +6574,7 @@ int btrfs_new_inode_prepare(struct
btrfs_new_inode_args *args,
ret = fscrypt_prepare_new_inode(dir, inode, &args->encrypt);
if (ret) {
... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Tue, 17 Feb 2026 16:26:38 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:38, Chris Mason <clm@meta.com> wrote:
That's correct. Good catch!
--- a/fs/btrfs/fscrypt.c
+++ b/fs/btrfs/fscrypt.c
@@ -155,7 +155,7 @@ static int btrfs_fscrypt_set_context(struct inode
*inode, const void *ctx,
btrfs_release_path(path);
if (fs_data)
- return ret;
+ go... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 14:18:28 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:36, Chris Mason <clm@meta.com> wrote:
This still seems correct to me. While rebasing, however, I missed that
the return type changed in 41e4ea0bf555 ("btrfs: make
btrfs_readdir_delayed_dir_index() return a bool instead").
If I'm not mistaken, we can just `return true;` here:
--- a/fs/btrfs/de... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 15:05:37 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:30, Chris Mason <clm@meta.com> wrote:
Should `name->crypto_buf.name` equal to `name->disk_name.name` in this case?
How about this:
--- a/fs/btrfs/dir-item.c
+++ b/fs/btrfs/dir-item.c
@@ -243,10 +243,18 @@ static int ensure_disk_name_from_dir_item(struct
btrfs_path *path,
... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 15:50:42 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:25, Chris Mason <clm@meta.com> wrote:
That's correct.
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -18,6 +18,7 @@ config BTRFS_FS
select XXHASH
select FS_ENCRYPTION_ALGS if FS_ENCRYPTION
select FS_ENCRYPTION_INLINE_CRYPT if FS_ENCRYPTION
+ select BLK_INLINE_ENCRYPTION if... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 16:02:29 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:20, Chris Mason <clm@meta.com> wrote:
`entry->fscrypt_info` is set in the very next patch "[21/43] btrfs:
plumb through setting the fscrypt_info for ordered extents". The
series is meant to be applied as a whole. It's just factored into
implementation steps.
This was actually changed from in... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 16:29:04 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On 2/18/26 10:29 AM, Daniel Vacek wrote:
The prompts try to flag any patch series that don't follow best
practices around bisectability. There isn't a ton of instruction about
what those best practices are beyond if commit A makes bug and then
commit B fixes the bug, flag it.
This patch set is pretty unusual because... | {
"author": "Chris Mason <clm@meta.com>",
"date": "Wed, 18 Feb 2026 10:50:04 -0500",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Wed, 18 Feb 2026 at 16:50, Chris Mason <clm@meta.com> wrote:
I understand that. I was checking every commit to ensure it builds
correctly. But not really testing for bugs or regressions.
Hmm, that's what I did. There was a 4 bytes hole.
Nah, I see. I just moved it. It's not a big deal then. The structure's
size r... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 17:11:13 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sun, 8 Feb 2026 at 16:17, Chris Mason <clm@meta.com> wrote:
Right, the original error should be returned. We do not care that much
about the latter if the former failed.
This should do the trick:
--- a/fs/btrfs/file.c
+++ b/fs/btrfs/file.c
@@ -549,12 +549,16 @@ int btrfs_drop_extents(struct btrfs_trans_handle *tra... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Wed, 18 Feb 2026 18:25:07 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Fri, Feb 06, 2026 at 07:22:32PM +0100, Daniel Vacek wrote:
Where does this series apply to? There's no base-commit or git tree,
and it doesn't apply to mainline or btrfs/for-next.
- Eric | {
"author": "Eric Biggers <ebiggers@kernel.org>",
"date": "Sat, 21 Feb 2026 12:56:06 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | I lost all my original comments on this patch due to a computer crash,
so apologies if this sounds a bit rushed. (I should know better than to
run the latest mainline kernel. Would be nice if kernel developers
focused on quality over new features...)
Above comment should document that this is used only when the fil... | {
"author": "Eric Biggers <ebiggers@kernel.org>",
"date": "Sat, 21 Feb 2026 14:11:53 -0800",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | Hello,
These are the remaining parts from former series [1] from Omar, Sweet Tea
and Josef. Some bits of it were split into the separate set [2] before.
Notably, at this stage encryption is not supported with RAID5/6 setup
and send is also isabled for now.
There are a few changes since v5:
* Rebased to btrfs/for-n... | null | null | null | [PATCH v6 00/43] btrfs: add fscrypt support | On Sat, 21 Feb 2026 at 21:56, Eric Biggers <ebiggers@kernel.org> wrote:
Hi Eric,
My apologies, I did not explicitly mention the base. I'll do it next time.
This was based on for-next @20260127 (commit 80dbfe6512d9c).
Since then, some changes occurred that will require additional
touches. No wonder it does not apply a... | {
"author": "Daniel Vacek <neelx@suse.com>",
"date": "Fri, 27 Feb 2026 16:50:57 +0100",
"is_openbsd": false,
"thread_id": "CAPjX3Fet5M2C=1TDNRhrqmanvJ2=aFdtQXfXK7MuxiOkz2rNUw@mail.gmail.com.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | Convert `pub use ffi` to `pub mod ffi` in lib.rs and create the
corresponding `rust/kernel/ffi/mod.rs` module file. Also re-export all C
type definitions from `ffi` crate so that existing `kernel::ffi::c_int`
etc. paths continue to work.
This prepares the ffi module to host additional sub-modules in later
patches (cli... | {
"author": "Joel Fernandes <joelagnelf@nvidia.com>",
"date": "Tue, 24 Feb 2026 17:27:33 -0500",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | Add a new module `clist` for working with C's doubly circular linked
lists. Provide low-level iteration over list nodes.
Typed iteration over actual items is provided with a `clist_create`
macro to assist in creation of the `CList` type.
Cc: Nikola Djukic <ndjukic@nvidia.com>
Reviewed-by: Daniel Almeida <daniel.almei... | {
"author": "Joel Fernandes <joelagnelf@nvidia.com>",
"date": "Tue, 24 Feb 2026 17:27:34 -0500",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On Wed Feb 25, 2026 at 7:27 AM JST, Joel Fernandes wrote:
Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>
(with one small comment below)
Acked-by: Alexandre Courbot <acourbot@nvidia.com>
<snip>
`item_ptr` does not exist. | {
"author": "\"Alexandre Courbot\" <acourbot@nvidia.com>",
"date": "Wed, 25 Feb 2026 17:09:22 +0900",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On Wed Feb 25, 2026 at 5:09 PM JST, Alexandre Courbot wrote:
Actually, one more. When trying to build the GPU buddy series on top of
this, I got this warning:
warning: this macro expands metavariables in an unsafe block
--> ../rust/kernel/ffi/clist.rs:336:9
|
336 | unsafe { $crate::ffi::clist::CList::<... | {
"author": "\"Alexandre Courbot\" <acourbot@nvidia.com>",
"date": "Wed, 25 Feb 2026 17:25:47 +0900",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On Wed, 25 Feb 2026 17:09:22 +0900, Alexandre Courbot wrote:
<snip>
Good catch, thanks! Fixed.
--
Joel Fernandes | {
"author": "Joel Fernandes <joelagnelf@nvidia.com>",
"date": "Wed, 25 Feb 2026 19:24:17 -0500",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On 2/25/26 06:27, Joel Fernandes wrote:
Hi,
Joel
Thanks for the clist abstraction. The Tyr debugfs [1] I'm implementing
needs to iterate over a GpuVm's VA list, and I'd like to switch that to
a CList-based implementation.
Could you make CListHeadIter public and expose a public constructor?
Or do you have a better sug... | {
"author": "Alvin Sun <alvin.sun@linux.dev>",
"date": "Fri, 27 Feb 2026 00:23:34 +0800",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On Fri, 27 Feb 2026, Alvin Sun wrote:
Thanks for looking into using CList for this!
I think this can be handled without exposing CListHeadIter. See below.
Looking at the Tyr code, both GpuVa and KernelGpuVa are
#[repr(transparent)] wrappers over the same C struct (drm_gpuva), linked
through the same list_head fiel... | {
"author": "Joel Fernandes <joelagnelf@nvidia.com>",
"date": "Thu, 26 Feb 2026 14:34:42 -0500",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | This series provides the clist module needed for nova-core memory management.
These patches are being sent separately from the rest of the preparatory
patches (DRM buddy movement, GPU buddy bindings, etc.) as they can go in
independently.
The clist module provides Rust abstractions for iterating over C
list_head-based... | null | null | null | [PATCH v11 0/2] rust: clist patches for nova-core memory management | On 2/27/26 03:34, Joel Fernandes wrote:
That's a good idea! I will try to implement GpuVaIter based on CListIter.
Thanks,
Alvin Sun | {
"author": "Alvin Sun <alvin.sun@linux.dev>",
"date": "Fri, 27 Feb 2026 23:50:59 +0800",
"is_openbsd": false,
"thread_id": "1d3c1c86-7382-4c2a-ab3e-3e6938d055ec@linux.dev.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | A follow-up patch adds a new variant driver for s390 ISM devices. Since
this device uses a 256 TiB BAR 0 that is never mapped, the variant
driver needs its own ISM_VFIO_PCI_OFFSET_MASK. To minimally mirror the
functionality of vfio_pci_config_rw() with such a custom mask, export
vfio_config_do_rw(). To better distingui... | {
"author": "Julian Ruess <julianr@linux.ibm.com>",
"date": "Tue, 24 Feb 2026 13:34:32 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | ism_vfio_pci is a new kernel component that allows
to use the ISM device from userspace. Add myself
as a maintainer.
Signed-off-by: Julian Ruess <julianr@linux.ibm.com>
---
MAINTAINERS | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 55af015174a54e17cc7449e5a80b6cdc83aa6fde..8... | {
"author": "Julian Ruess <julianr@linux.ibm.com>",
"date": "Tue, 24 Feb 2026 13:34:34 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | Add a vfio_pci variant driver for the s390-specific Internal Shared
Memory (ISM) devices used for inter-VM communication.
This enables the development of vfio-pci-based user space drivers for
ISM devices.
On s390, kernel primitives such as ioread() and iowrite() are switched
over from function handle based PCI load/s... | {
"author": "Julian Ruess <julianr@linux.ibm.com>",
"date": "Tue, 24 Feb 2026 13:34:33 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | On Tue, 2026-02-24 at 13:34 +0100, Julian Ruess wrote:
Looks good to me, thanks!
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com> | {
"author": "Niklas Schnelle <schnelle@linux.ibm.com>",
"date": "Thu, 26 Feb 2026 20:36:56 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | On Tue, 2026-02-24 at 13:34 +0100, Julian Ruess wrote:
--- snip ---
I think this comment could be improved but it's not wrong either so no
strong opinion. Maybe something like:
/*
* Use __zpci_load() to bypass automatic use of PCI MIO instructions
* which are not supported on ISM devices
*/
Note for the interes... | {
"author": "Niklas Schnelle <schnelle@linux.ibm.com>",
"date": "Thu, 26 Feb 2026 22:02:25 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | On Tue, 2026-02-24 at 13:34 +0100, Julian Ruess wrote:
Thanks for volunteering :)
Reviewed-by: Niklas Schnelle <schnelle@linux.ibm.com> | {
"author": "Niklas Schnelle <schnelle@linux.ibm.com>",
"date": "Thu, 26 Feb 2026 22:04:32 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Hi all,
This series adds a vfio_pci variant driver for the s390-specific
Internal Shared Memory (ISM) devices used for inter-VM communication
including SMC-D.
This is a prerequisite for an in-development open-source user space
driver stack that will allow to use ISM devices to provide remote
console and block device ... | null | null | null | [PATCH v2 0/3] vfio/pci: Introduce vfio_pci driver for ISM devices | On 24.02.26 13:34, Julian Ruess wrote:
[...]
Why do you need 'struct ism_vfio_pci_core_device'?
Unlike other vfio_pci variant drivers your struct only has a single member.
I see it is used below as well, but couldn't you directly use 'struct vfio_pci_core_device'
in all places?
As you know something like
} else ... | {
"author": "Alexandra Winter <wintera@linux.ibm.com>",
"date": "Fri, 27 Feb 2026 16:52:54 +0100",
"is_openbsd": false,
"thread_id": "20260224-vfio_pci_ism-v2-0-f010945373fa@linux.ibm.com.mbox.gz"
} |
lkml_critique | lkml | Qualcomm kaanapali platform have a newer generation of video IP iris4.
The hardware have evolved mostly with respect to higher number of power
domains as well as multiple clock sources.
Considering iris as a client driver, it adds the handling for multiple
stream ids from VPU via iommu-map.
This series is depend o... | null | null | null | [PATCH v2 0/7] media: iris: add support for kaanapali platform | On 27/02/2026 16:50, Krzysztof Kozlowski wrote:
Although when iommu-map is properly written listing items, then it would
use that. Anyway, we don't use definitions but defs (see git grep).
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 16:55:59 +0100",
"is_openbsd": false,
"thread_id": "4dcbbd06-18eb-46c6-a52c-07a4b17205cd@kernel.org.mbox.gz"
} |
lkml_critique | lkml | Add an option called TIMERLAT_ALIGN to osnoise/options, together with a
corresponding setting osnoise/timerlat_align_us.
This option sets the alignment of wakeup times between different
timerlat threads, similarly to cyclictest's -A/--aligned option. If
TIMERLAT_ALIGN is set, the first thread that reaches the first cy... | null | null | null | [PATCH] tracing/osnoise: Add option to align tlat threads | On Fri, 27 Feb 2026 16:04:20 +0100
Tomas Glozar <tglozar@redhat.com> wrote:
Is it set to 50 or 20?
As the increments are off by 20 and not 50.
So the first one here sets 'align_next' and all others fall into this path.
As 'align_next' is a static variable for this function, what happens if you
run timerlat a sec... | {
"author": "Steven Rostedt <rostedt@goodmis.org>",
"date": "Fri, 27 Feb 2026 10:52:07 -0500",
"is_openbsd": false,
"thread_id": "20260227105207.01473471@gandalf.local.home.mbox.gz"
} |
lkml_critique | lkml | When a font is set on an invisible console, the screen will not update.
However, the fontbuffer is not updated to match the new font dimensions.
This inconsistency leads to out-of-bounds memory access when writing to
the tty bound to fbcon, as demonstrated by the following KASAN report:
BUG: KASAN: slab-out-of-bounds... | null | null | null | [RFC PATCH] fbcon: Fix out-of-bounds memory in fbcon_putcs | Hi,
thanks for the patch.
Am 27.02.26 um 15:43 schrieb Chen Jun:
I looked through vc_resize() but cannot quite find the logic that calls
fbcon_rotate_font(). Can you please point to correct place?
Best regards
Thomas
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankens... | {
"author": "Thomas Zimmermann <tzimmermann@suse.de>",
"date": "Fri, 27 Feb 2026 16:56:07 +0100",
"is_openbsd": false,
"thread_id": "bc9a37ac-43d2-451b-81b7-e0b23827006f@suse.de.mbox.gz"
} |
lkml_critique | lkml | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On 02/23, Bobby Eshleman wrote:
What about the other similar check in validate_xmit_unreadable_skb?
I don't have a strong opinion, but it feels like as long as we are not
using these ->dev pointers (and we are only using them for comparisons),
we should be fine (plus, memory tearing for u64 is not something that
can ... | {
"author": "Stanislav Fomichev <stfomichev@gmail.com>",
"date": "Tue, 24 Feb 2026 17:49:42 -0800",
"is_openbsd": false,
"thread_id": "aaG+ibeUBEHohG68@devvm11784.nha0.facebook.com.mbox.gz"
} |
lkml_critique | lkml | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On Tue, Feb 24, 2026 at 05:49:42PM -0800, Stanislav Fomichev wrote:
Makes sense. I don't think it presents a current problem, its just
defensive (e.g., someday other functions referencing binding->dev get
inlined here and the compiler does load omission or invented loads). I
didn't know about u64 being immune to memor... | {
"author": "Bobby Eshleman <bobbyeshleman@gmail.com>",
"date": "Wed, 25 Feb 2026 07:14:46 -0800",
"is_openbsd": false,
"thread_id": "aaG+ibeUBEHohG68@devvm11784.nha0.facebook.com.mbox.gz"
} |
lkml_critique | lkml | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On Wed, Feb 25, 2026 at 7:14 AM Bobby Eshleman <bobbyeshleman@gmail.com> wrote:
Looks correct to me, and AFAIU Stan is right, we might as well
annotate all the reads of ->dev as technically there could be a dmabuf
uninstall happing concurrently on another CPU. I also think it's
probably good to annotate potential race... | {
"author": "Mina Almasry <almasrymina@google.com>",
"date": "Wed, 25 Feb 2026 09:31:48 -0800",
"is_openbsd": false,
"thread_id": "aaG+ibeUBEHohG68@devvm11784.nha0.facebook.com.mbox.gz"
} |
lkml_critique | lkml | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On Wed, Feb 25, 2026 at 09:31:48AM -0800, Mina Almasry wrote:
Sounds good. I'll take a look at some of the other fields while my mind
is in this space.
I agree about it being non-critical, good point about TX passing through
fine on failed check.
Best,
Bobby | {
"author": "Bobby Eshleman <bobbyeshleman@gmail.com>",
"date": "Wed, 25 Feb 2026 11:49:31 -0800",
"is_openbsd": false,
"thread_id": "aaG+ibeUBEHohG68@devvm11784.nha0.facebook.com.mbox.gz"
} |
lkml_critique | lkml | From: Bobby Eshleman <bobbyeshleman@meta.com>
binding->dev is protected on the write-side in
mp_dmabuf_devmem_uninstall() against concurrent writes, but due to the
concurrent bare read in net_devmem_get_binding() it should be wrapped in
a READ_ONCE/WRITE_ONCE pair to make sure no compiler optimizations play
with the u... | null | null | null | [PATCH net] net: devmem: use READ_ONCE/WRITE_ONCE on binding->dev | On Wed, Feb 25, 2026 at 11:49:31AM -0800, Bobby Eshleman wrote:
I looked through the other fields of binding and binding->dev is the
only one that wants READ_ONCE/WRITE_ONCE AFAICT. Most of them are only
modified after the refcount hits zero (dmabuf, tx_vec, chunk_pool,
attachment, etc..) and I think binding->list is ... | {
"author": "Bobby Eshleman <bobbyeshleman@gmail.com>",
"date": "Fri, 27 Feb 2026 07:55:53 -0800",
"is_openbsd": false,
"thread_id": "aaG+ibeUBEHohG68@devvm11784.nha0.facebook.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.