data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | netdev | From: Feng Yang <yangfeng@kylinos.cn>
Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap
Changes in v8:
- set ret to an error code before goto out.
- Link to v7: https://lore.kernel.org/all/20260226095156.117996-1-yangfeng59949@163.com/
Changes in v7:
- Use ip6_null_entry to avoid. Thanks, Martin KaFai... | null | null | null | [PATCH v8 bpf-next 0/2] Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap | From: Feng Yang <yangfeng@kylinos.cn>
The bpf_lwt_xmit_push_encap helper needs to access skb_dst(skb)->dev to
calculate the needed headroom:
err = skb_cow_head(skb,
len + LL_RESERVED_SPACE(skb_dst(skb)->dev));
But skb->_skb_refdst may not be initialized when the skb is set up by
bpf_prog_test_run_skb function... | {
"author": "Feng Yang <yangfeng59949@163.com>",
"date": "Fri, 27 Feb 2026 16:21:32 +0800",
"is_openbsd": false,
"thread_id": "20260227082133.96951-3-yangfeng59949@163.com.mbox.gz"
} |
lkml_critique | netdev | From: Feng Yang <yangfeng@kylinos.cn>
Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap
Changes in v8:
- set ret to an error code before goto out.
- Link to v7: https://lore.kernel.org/all/20260226095156.117996-1-yangfeng59949@163.com/
Changes in v7:
- Use ip6_null_entry to avoid. Thanks, Martin KaFai... | null | null | null | [PATCH v8 bpf-next 0/2] Fix the null pointer dereference issue in bpf_lwt_xmit_push_encap | From: Feng Yang <yangfeng@kylinos.cn>
Calling bpf_lwt_xmit_push_encap will not cause a crash when dst is missing.
Signed-off-by: Feng Yang <yangfeng@kylinos.cn>
---
.../selftests/bpf/progs/verifier_lwt.c | 20 +++++++++++++++++++
1 file changed, 20 insertions(+)
diff --git a/tools/testing/selftests/bpf/progs... | {
"author": "Feng Yang <yangfeng59949@163.com>",
"date": "Fri, 27 Feb 2026 16:21:33 +0800",
"is_openbsd": false,
"thread_id": "20260227082133.96951-3-yangfeng59949@163.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>
Add retry mechanism for indirect Admin Queue (AQ) commands. To do so we
need to keep the command buffer.
This technically reverts commit 43a630e37e25
("ice: remove unused buffer copy code in ice_sq_send_cmd_retry()"),
but combines it with a fix in the logi... | {
"author": "Dawid Osuchowski <dawid.osuchowski@linux.intel.com>",
"date": "Tue, 13 Jan 2026 20:38:16 +0100",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | From: Jakub Staniszewski <jakub.staniszewski@linux.intel.com>
Executing ethtool -m can fail reporting a netlink I/O error while firmware
link management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0... | {
"author": "Dawid Osuchowski <dawid.osuchowski@linux.intel.com>",
"date": "Tue, 13 Jan 2026 20:38:17 +0100",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | [Cc: +Michal]
Dear Dawid, dear Jakub,
Am 13.01.26 um 20:38 schrieb Dawid Osuchowski:
At least Michal was not in the (visible) Cc: list
Unrelated change?
The diff looks good otherwise.
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul | {
"author": "Paul Menzel <pmenzel@molgen.mpg.de>",
"date": "Tue, 13 Jan 2026 23:31:20 +0100",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | Hey Paul,
On 2026-01-13 11:31 PM, Paul Menzel wrote:
...
Interesting. I was using 'git send-email' without any suppression of Cc
or similar options. In the direct email sent from me Michal is in Cc,
seems the mailing list for some reason stripped him...
...
During internal review it was pointed out that this ... | {
"author": "Dawid Osuchowski <dawid.osuchowski@linux.intel.com>",
"date": "Wed, 14 Jan 2026 09:15:59 +0100",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | Dear Dawid, dear Jakub,
Thank you for your patch.
Am 13.01.26 um 20:38 schrieb Dawid Osuchowski:
Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de>
Kind regards,
Paul | {
"author": "Paul Menzel <pmenzel@molgen.mpg.de>",
"date": "Wed, 14 Jan 2026 10:16:29 +0100",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | The Admin Queue (AQ) command 0x06EE can return EBUSY when firmware link
management holds the i2c bus used to communicate with the module.
According to Intel(R) Ethernet Controller E810 Datasheet Rev 2.8 [1]
Section 3.3.10.4 Read/Write SFF EEPROM (0x06EE)
request should be retried upon receiving EBUSY from firmware.
I... | null | null | null | [PATCH iwl-net 0/2] ice: fix AQ command 0x06EE usage by retrying | (AQ) command with opcode 0x06EE to the list of commands that should be retried on receiving EBUSY from firmware.
Tested-by: Rinitha S <sx.rinitha@intel.com> (A Contingent worker at Intel) | {
"author": "\"Rinitha, SX\" <sx.rinitha@intel.com>",
"date": "Fri, 27 Feb 2026 06:06:03 +0000",
"is_openbsd": false,
"thread_id": "20260113193817.582-3-dawid.osuchowski@linux.intel.com.mbox.gz"
} |
lkml_critique | netdev | Enable DP83TG720 PHY driver as a module to support TI's DP83TG720
1000BASE-T1 Automotive Ethernet PHY. This is required for the
DP83TG720-IND-SPE-EVM daughter card used with AM642 EVM ICSSG0
interface.
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertio... | null | null | null | [RESEND PATCH] arm64: defconfig: Enable DP83TG720 PHY driver | On 26/02/2026 19:54, Meghana Malladi wrote:
Grepping for DP83TG720 or IND-SPE-EVM gives me no results. Are you sure
this is the board supported upstream?
Why do you have dependencies in defconfig?
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 07:42:14 +0100",
"is_openbsd": false,
"thread_id": "d6768751-4fee-4ba5-9807-eb64d727a16d@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Enable DP83TG720 PHY driver as a module to support TI's DP83TG720
1000BASE-T1 Automotive Ethernet PHY. This is required for the
DP83TG720-IND-SPE-EVM daughter card used with AM642 EVM ICSSG0
interface.
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertio... | null | null | null | [RESEND PATCH] arm64: defconfig: Enable DP83TG720 PHY driver | On 2/27/26 12:12, Krzysztof Kozlowski wrote:
Yes, this series adds support adds support for the board:
https://lore.kernel.org/all/20231212054144.87527-1-o.rempel@pengutronix.de/
You're right - the prerequisite-patch-id line shouldn't be in the
defconfig patch. The defconfig change itself has no code dependencies;... | {
"author": "Meghana Malladi <m-malladi@ti.com>",
"date": "Fri, 27 Feb 2026 12:45:39 +0530",
"is_openbsd": false,
"thread_id": "d6768751-4fee-4ba5-9807-eb64d727a16d@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Enable DP83TG720 PHY driver as a module to support TI's DP83TG720
1000BASE-T1 Automotive Ethernet PHY. This is required for the
DP83TG720-IND-SPE-EVM daughter card used with AM642 EVM ICSSG0
interface.
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertio... | null | null | null | [RESEND PATCH] arm64: defconfig: Enable DP83TG720 PHY driver | On 27/02/2026 08:15, Meghana Malladi wrote:
I still wonder why there is no DTS for this.
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 08:21:10 +0100",
"is_openbsd": false,
"thread_id": "d6768751-4fee-4ba5-9807-eb64d727a16d@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Enable DP83TG720 PHY driver as a module to support TI's DP83TG720
1000BASE-T1 Automotive Ethernet PHY. This is required for the
DP83TG720-IND-SPE-EVM daughter card used with AM642 EVM ICSSG0
interface.
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertio... | null | null | null | [RESEND PATCH] arm64: defconfig: Enable DP83TG720 PHY driver | On 2/27/26 12:51, Krzysztof Kozlowski wrote:
I posted DTS patch separately for this:
https://lore.kernel.org/all/20260226115454.1730618-1-m-malladi@ti.com/
Does it make more sense to post them together as a series ? | {
"author": "Meghana Malladi <m-malladi@ti.com>",
"date": "Fri, 27 Feb 2026 12:54:28 +0530",
"is_openbsd": false,
"thread_id": "d6768751-4fee-4ba5-9807-eb64d727a16d@kernel.org.mbox.gz"
} |
lkml_critique | netdev | Enable DP83TG720 PHY driver as a module to support TI's DP83TG720
1000BASE-T1 Automotive Ethernet PHY. This is required for the
DP83TG720-IND-SPE-EVM daughter card used with AM642 EVM ICSSG0
interface.
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
---
arch/arm64/configs/defconfig | 1 +
1 file changed, 1 insertio... | null | null | null | [RESEND PATCH] arm64: defconfig: Enable DP83TG720 PHY driver | On 27/02/2026 08:24, Meghana Malladi wrote:
Of course, you target the same subsystem - soc. Why triggering all these
investigations and questions...
Best regards,
Krzysztof | {
"author": "Krzysztof Kozlowski <krzk@kernel.org>",
"date": "Fri, 27 Feb 2026 08:29:21 +0100",
"is_openbsd": false,
"thread_id": "d6768751-4fee-4ba5-9807-eb64d727a16d@kernel.org.mbox.gz"
} |
lkml_critique | netdev | The PTP subsystem has grown beyond the original IEEE 1588/NIC use case
and today contains both network-oriented PHC drivers and various
emulated/virtual clock implementations.
Prepare for clearer ownership and future maintenance by refactoring
drivers/ptp/ to make the split explicit. Keep the PTP core
infrastructure i... | null | null | null | [RFC v2 1/2] ptp: split clock drivers into two subdirectories | Hi all,
This RFC v2 is a follow-up to [1].
# Background
The PTP Hardware Clock (PHC) interface (/dev/ptpX and the standard PTP_*
ioctls) was originally introduced for IEEE 1588 / network oriented clock
drivers. Over time, it has also become a common userspace API for many non-NIC
high-precision clock implementation... | {
"author": "Wen Gu <guwen@linux.alibaba.com>",
"date": "Fri, 27 Feb 2026 16:19:32 +0800",
"is_openbsd": false,
"thread_id": "4a9af4b1-6820-4173-8daf-4201bb1bcca5@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | The PTP subsystem has grown beyond the original IEEE 1588/NIC use case
and today contains both network-oriented PHC drivers and various
emulated/virtual clock implementations.
Prepare for clearer ownership and future maintenance by refactoring
drivers/ptp/ to make the split explicit. Keep the PTP core
infrastructure i... | null | null | null | [RFC v2 1/2] ptp: split clock drivers into two subdirectories | Update MAINTAINERS to match the new drivers/ptp/ directory layout after
splitting emulated and IEEE 1588 network-oriented drivers into
subdirectories.
Adjust file patterns and per-driver entries to point to their new
locations, and add a dedicated MAINTAINERS entry for the emulated PTP
clock drivers.
Signed-off-by: W... | {
"author": "Wen Gu <guwen@linux.alibaba.com>",
"date": "Fri, 27 Feb 2026 16:19:34 +0800",
"is_openbsd": false,
"thread_id": "4a9af4b1-6820-4173-8daf-4201bb1bcca5@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | The PTP subsystem has grown beyond the original IEEE 1588/NIC use case
and today contains both network-oriented PHC drivers and various
emulated/virtual clock implementations.
Prepare for clearer ownership and future maintenance by refactoring
drivers/ptp/ to make the split explicit. Keep the PTP core
infrastructure i... | null | null | null | [RFC v2 1/2] ptp: split clock drivers into two subdirectories | On Fri, 2026-02-27 at 16:19 +0800, Wen Gu wrote:
While no ABI changes are intended in *this* patch series, we do need
some.
These 'emulated' clocks mostly exist not to emulate IEEE1588 per se,
but as a way to provide a precision real time clock to systems
(especially virtual guests).
We have already discussed the ne... | {
"author": "David Woodhouse <dwmw2@infradead.org>",
"date": "Fri, 27 Feb 2026 10:25:56 +0000",
"is_openbsd": false,
"thread_id": "4a9af4b1-6820-4173-8daf-4201bb1bcca5@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | The PTP subsystem has grown beyond the original IEEE 1588/NIC use case
and today contains both network-oriented PHC drivers and various
emulated/virtual clock implementations.
Prepare for clearer ownership and future maintenance by refactoring
drivers/ptp/ to make the split explicit. Keep the PTP core
infrastructure i... | null | null | null | [RFC v2 1/2] ptp: split clock drivers into two subdirectories | On 2026/2/27 18:25, David Woodhouse wrote:
As mentioned in RFC v1, the use cases for drivers in the emulated PHC category
are expected to be quite diverse, and not limited to the virtualization/guest
time sync use case. For example, existing drivers such as ptp_ocp [1] and
upcoming ones such as mhi_phc [2] are not rel... | {
"author": "Wen Gu <guwen@linux.alibaba.com>",
"date": "Fri, 27 Feb 2026 20:25:11 +0800",
"is_openbsd": false,
"thread_id": "4a9af4b1-6820-4173-8daf-4201bb1bcca5@linux.alibaba.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | From: Théo Lebrun <theo.lebrun@bootlin.com>
mog_alloc_rx_buffers(), getting called at open, does not do rx buffer
alloc on GEM. The bulk of the work is done by gem_rx_refill() filling
up all slots with valid buffers.
gem_rx_refill() is called at link up by
gem_init_rings() == bp->macbgem_ops.mog_init_rings().
Move o... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:25 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is a preparation commit as the field in later patches will no
longer accomomdate skbuffs, but more generic frames.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence/macb.h | 2 +-
drivers/net/ethernet/cadence/macb_main.c | 24 ++++++++++++------------
2 files changed, 13 i... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:26 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | gem_get_ethtool_stats calculates the size of the statistics
data to copy always considering maximum number of queues.
The patch makes sure the statistics are copied only for the
active queues as returned in the string set count op.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence/m... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:28 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Use the page pool allocator for the data buffers and enable skb
recycling support, instead of relying on netdev_alloc_skb
allocating the entire skb during the refill.
The patch also add support for receiving network frames that span
multiple DMA descriptors in the Cadence MACB/GEM Ethernet driver.
The patch removes t... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:27 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Introduce basic XDP support for macb/gem with the XDP_PASS,
XDP_DROP, XDP_REDIRECT verdict support.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence/macb.h | 3 +
drivers/net/ethernet/cadence/macb_main.c | 207 ++++++++++++++++++++---
2 files changed, 188 insertions(+), 22 de... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:29 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | The macb_tx_skb structure is renamed to macb_tx_buff with
no functional changes.
This is a preparatory step for adding xdp xmit support.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence/macb.h | 10 +--
drivers/net/ethernet/cadence/macb_main.c | 96 ++++++++++++------------
2 ... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:30 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Rename macb_tx_buff member skb to ptr and introduce macb_tx_buff_type
to identify the buffer type macb_tx_buff represents.
This is the last preparatory step for xdp xmit support.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence/macb.h | 23 +++++++++++-----
drivers/net/etherne... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:31 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Add XDP_TX verdict support, also introduce ndo_xdp_xmit function for
redirection, and update macb_tx_unmap() to handle both skbs and xdp
frames advertising NETDEV_XDP_ACT_NDO_XMIT capability and the ability
to process XDP_TX verdicts.
Signed-off-by: Paolo Valerio <pvalerio@redhat.com>
---
drivers/net/ethernet/cadence... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Mon, 23 Feb 2026 19:26:32 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Hi Paolo,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Paolo-Valerio/net-macb-move-Rx-buffers-alloc-from-link-up-to-open/20260224-023220
base: net-next/main
patch link: https://lore.kernel.org/r/20260223... | {
"author": "kernel test robot <lkp@intel.com>",
"date": "Tue, 24 Feb 2026 07:23:12 +0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: macb: move Rx buffers alloc from link up to open
This commit moves Rx buffer allocation to macb... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 16:08:32 -0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: macb: add XDP support for gem
This patch introduces basic XDP support for the macb/gem driver w... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 16:08:44 -0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: macb: make macb_tx_skb generic
The macb_tx_skb structure is renamed to macb_tx_buff with no fun... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 16:08:51 -0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: macb: make tx path skb agnostic
This commit renames the skb member of macb_tx_buff to ptr and i... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 16:09:00 -0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | This is an AI-generated review of your patch. The human sending this
email has considered the AI review valid, or at least plausible.
For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
---
net: macb: introduce xmit support
This commit adds XDP_TX verdict support and introduces ndo_xdp_xmi... | {
"author": "Jakub Kicinski <kuba@kernel.org>",
"date": "Mon, 23 Feb 2026 16:09:02 -0800",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | On 23 Feb 2026 at 04:08:32 PM, Jakub Kicinski <kuba@kernel.org> wrote:
yes, this definitely is not intentional. Must have been left/reintroduced
by mistake while rebasing v2, sorry. | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Wed, 25 Feb 2026 19:29:24 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | On 23 Feb 2026 at 04:08:44 PM, Jakub Kicinski <kuba@kernel.org> wrote:
argh, I missed this patch removing the initialization while rebasing.
I guess gem_xdp_valid_mtu() can depend only on XDP_PACKET_HEADROOM and
just check against it and drop the dependency with bp->rx_headroom.
This makes sense. Will require so... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Wed, 25 Feb 2026 19:30:16 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | On 23 Feb 2026 at 04:09:00 PM, Jakub Kicinski <kuba@kernel.org> wrote:
The branch on MACB_TYPE_SKB is a bit redundant, so I guess we
can either remove that or initialize skb at declaration to improve
clarity. There should be no potential NULL dereference anyways
(for the note below).
Next patch initializes the local... | {
"author": "Paolo Valerio <pvalerio@redhat.com>",
"date": "Wed, 25 Feb 2026 19:36:10 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | Tested on Raspberry Pi 5.
All the changes are intended for gem only.
The series consists of two main changes:
- Migration from netdev_alloc_skb() to page pool allocation model,
enabling skb recycling.
This also adds support for multi-descriptor frame reception,
removing the previous single-descriptor approach a... | null | null | null | [PATCH net-next v2 0/8] net: macb: Add XDP support and page pool integration | Hello Paolo,
On Wed Feb 25, 2026 at 7:30 PM CET, Paolo Valerio wrote:
[...]
I debugged a nasty bug yesterday, which ended up being this typo
combined with the fact that we call gem_init_rings() through the
mog_init_rings function pointer twice at open. Once near the end of
macb_alloc_consistent() and once from macb_o... | {
"author": "=?utf-8?q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>",
"date": "Fri, 27 Feb 2026 11:52:27 +0100",
"is_openbsd": false,
"thread_id": "DGPORITW7CFW.1DBYQHGBZ8CEC@bootlin.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | The nlsk field in struct netns_xfrm is RCU-protected, as seen by
the use of rcu_assign_pointer() and RCU_INIT_POINTER() when updating
it.
However, the field lacks the __rcu annotation, and most read-side
accesses don't use rcu_dereference().
Add the missing __rcu annotation and convert all read-side accesses to
use rc... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:42:01 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | These assignments are overwritten within the same function further down
commit e8961c50ee9cc ("xfrm: Refactor migration setup
during the cloning process")
x->props.family = m->new_family;
Which actually moved it in the
commit e03c3bba351f9 ("xfrm: Fix xfrm migrate issues
when address family changes")
And the initial... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:42:23 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | The current code prevents migrating an SA from UDP encapsulation to
plain ESP. This is needed when moving from a NATed path to a non-NATed
one, for example when switching from IPv4+NAT to IPv6.
Only copy the existing encapsulation during migration if the encap
attribute is explicitly provided.
Note: PF_KEY's SADB_X_M... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:42:40 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | In preparation for a later patch in this series s/reqid/old_reqid/.
No functional change.
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
include/net/xfrm.h | 2 +-
net/key/af_key.c | 10 +++++-----
net/xfrm/xfrm_policy.c | 4 ++--
net/xfrm/xfrm_state.c | 6 +++---
net/xfrm/xfrm_user.c | ... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:42:54 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | To prepare for subsequent patches, split
xfrm_state_migrate() into two functions:
- xfrm_state_migrate_create(): creates the migrated state
- xfrm_state_migrate_install(): installs it into the state table
splitting will help to avoid SN/IV reuse when migrating AEAD SA.
And add const whenever possible.
No functional c... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:43:09 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Add descriptive(extack) error messages for all error paths
in state migration. This improves diagnostics by
providing clear feedback when migration fails.
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
v4->v5: - added this patch
---
net/xfrm/xfrm_state.c | 13 ++++++++++---
1 file changed, 10 insertions... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:43:42 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Add a new netlink method to migrate a single xfrm_state.
Unlike the existing migration mechanism (SA + policy), this
supports migrating only the SA and allows changing the reqid.
The reqid is invariant in the old migration.
Signed-off-by: Antony Antony <antony.antony@secunet.com>
---
v1->v2: merged next patch here to... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:44:11 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Add xfrm_migrate_sync() to synchronize curlft and replay state after
state installation, this can be called under lock without memory
allocation. In preparation for a subsequent patch in this series.
This ensures the migrated state captures the latest lifetime counters
and replay state from the original after install... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Tue, 27 Jan 2026 11:50:46 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-01-27, 11:42:40 +0100, Antony Antony wrote:
Are we sure nobody out there relies on this behavior (silently copying
the existing UDP encap without having to explicitly request it in the
MIGRATE request)? If there are, this patch would break their setup by
clearing the encap that they expect to still be present.
-... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Fri, 30 Jan 2026 12:28:19 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-01-27, 11:43:42 +0100, Antony Antony wrote:
When xfrm_state_clone_and_setup fails it's because some allocation
failed and the user won't be able to do much about this, right? I
don't feel extack in those situations is super helpful.
xfrm_init_state itself doesn't handle extack, but it's just a wrapper
around fu... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Fri, 30 Jan 2026 13:14:39 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | On Fri, Jan 30, 2026 at 12:28:19 +0100, Sabrina Dubroca wrote:
Libreswan and Android are the main users of migrate method. Libreswan sets the
value in every call. I am guessing Android does that too.
Yan, would this patch cause regression in Android?
Without this fix migrating from v4 nat to v6 and no v4 nat won't ... | {
"author": "Antony Antony <antony.antony@secunet.com>",
"date": "Mon, 2 Feb 2026 13:57:56 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | On Mon, Feb 02, 2026 at 10:15:24AM -0800, Nathan Harold via Devel wrote:
Thanks Nathan. It is good to know.
The next question is how do you feel about changing the behavior in
Android? Would you be willing re-send ports every time the SA has it?
This will allow more flexible migration. Migrating from NAT to no NAT a... | {
"author": "Antony Antony <antony@phenome.org>",
"date": "Mon, 2 Feb 2026 20:38:35 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-01-27, 11:44:11 +0100, Antony Antony wrote:
[...]
I'm not entirely clear on why this struct has those fields (maybe, in
particular, new_saddr but no old_saddr, assuming that id.daddr is
old_daddr). My guess is:
- usersa_id because it's roughly equivalent to a GETSA request,
which makes the old_saddr unnece... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Tue, 3 Feb 2026 22:25:15 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Hi Antony,
Sorry for the late reply. We’ve prototyped this and confirmed that
Android can be changed to explicitly provide the encap_tmpl in the
MIGRATE requests. Also we are excited to have kernel support for
encap-to-non-encap migration.
Thanks,
Yan and Nathan
On Mon, Feb 2, 2026 at 11:38 AM Antony Antony <antony@... | {
"author": "Yan Yan <evitayan@google.com>",
"date": "Mon, 23 Feb 2026 19:28:06 -0800",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | On Fri, Jan 30, 2026 at 01:14:39PM +0100, Sabrina Dubroca via Devel wrote:
I felt it was usefaul to know, and to log this happened. May not a great
idea.
That is a great idea. May be in a future patch set. For now, I will drop
this patch from this series. To move forward quickly.
Fair point, but logging it still... | {
"author": "Antony Antony <antony@phenome.org>",
"date": "Thu, 26 Feb 2026 16:43:22 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Hi Sabrina,
Thanks for your extensive review. Along the way I also noticed a couple of
more minor issues and fixed them. I will send
a v6 addressing the points from this email.
On Tue, Feb 03, 2026 at 10:25:15PM +0100, Sabrina Dubroca via Devel wrote:
Yes, exactly. The SA is looked up via xfrm_usersa_id, which uniq... | {
"author": "Antony Antony <antony@phenome.org>",
"date": "Thu, 26 Feb 2026 16:46:49 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Hi Yan,
On Mon, Feb 23, 2026 at 07:28:06PM -0800, Yan Yan wrote:
Thanks for the confirmation and prototype testing. I will send out v6 soon.
Would you like to add any tags Tested or Reviewd...
-antony | {
"author": "Antony Antony <antony@phenome.org>",
"date": "Thu, 26 Feb 2026 16:41:45 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-02-26, 16:43:22 +0100, Antony Antony wrote:
I don't have a super strong opinion. IIRC that was the approach I
picked when I added extack (no extack for kernel events that the user
can't do anything about and don't result from an invalid netlink
message), but maybe that kind of stuff deserves an extack too.
Also,... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Thu, 26 Feb 2026 17:59:52 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-01-27, 11:42:01 +0100, Antony Antony wrote:
BTW, after this, sparse will complain about the other accesses to nlsk
in net/xfrm/xfrm_user.c (in the nlmsg_unicast(net->xfrm.nlsk, ...)
calls).
I have a patch adding this __rcu annotation, and fixing the warnings
that it causes. It's part of the series I'm planning t... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Thu, 26 Feb 2026 18:07:41 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-02-26, 16:46:49 +0100, Antony Antony wrote:
Thanks Antony.
Just a few things related to your reply:
Thanks. Maybe worth adding a small note in the commit message to
describe the behavior of that new op? (pretty much what you wrote
here)
I know the old stuff isn't documented much, I'm not asking for an
extensi... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Thu, 26 Feb 2026 19:05:59 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | Hi Antony,
May I request that we also support updating the XFRMA_SET_MARK as part
of the new XFRM_MSG_MIGRATE_STATE message?
In Android, the primary use case for migration is switching the
underlying physical network for an IPsec tunnel (e.g. VPN, Wifi
calling). Currently, due to the limits of XFRM_MSG_MIGRATE, we ar... | {
"author": "Yan Yan <evitayan@google.com>",
"date": "Thu, 26 Feb 2026 17:44:51 -0800",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | The current XFRM_MSG_MIGRATE interface is tightly coupled to policy and
SA migration, and it lacks the information required to reliably migrate
individual SAs. This makes it unsuitable for IKEv2 deployments,
dual-stack setups (IPv4/IPv6), and scenarios where policies are managed
externally (e.g., by daemons other than ... | null | null | null | [PATCH ipsec-next v5 0/8] xfrm: XFRM_MSG_MIGRATE_STATE new netlink message | 2026-02-26, 17:44:51 -0800, Yan Yan via Devel wrote:
I think this raises a wider question: clearly definining and
documenting which attributes need to be explicitly provided
("omit-to-clear" as you write), and which will be implicitly copied.
Currently it looks like we copy:
- all the crypto stuff (aalg/aead/etc)
-... | {
"author": "Sabrina Dubroca <sd@queasysnail.net>",
"date": "Fri, 27 Feb 2026 12:26:00 +0100",
"is_openbsd": false,
"thread_id": "CADHa2dAxVFQULCKnsjSmSPrK+VTJyyT-5P5BAYGdhO5wKDKqig@mail.gmail.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | In double VLAN mode (DVM), outer VLAN is located a word earlier in
the field vector compared to the single VLAN mode. We already modify
ICE_SW_LKUP_VLAN to use it but ICE_SW_LKUP_MAC_VLAN was left untouched,
causing the lookup to match any packet with one or no layer of Dot1q.
This change enables to fix cross-vlan loo... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:12 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | Among other uses, MAC filters are currently used to forward loopback
traffic between VSIs. However, they only match destination MAC addresses
making them prone to mistakes when handling traffic within multiple
VLANs and especially across the boundaries.
Allows the driver to create MAC,VLAN filters in the same flow as... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:13 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | Currently, lan_en and lb_en are determined based on switching mode,
destination MAC, and the lookup type, action type and flags of the rule
in question. This gives little to no options for the user (such as
ice_fltr.c) to enforce rules to behave in a specific way.
Such functionality is needed to work with pairs of ru... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:14 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | When changing into VEPA mode MAC rules are modified to forward all traffic
to the wire instead of allowing some packets to go into the loopback.
MAC,VLAN rules may and will also be used to forward loopback traffic
in VEB, so when we switch to VEPA, we want them to behave similarly to
MAC-only rules.
ice_vsi_update_bri... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:15 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | PVID information is set across two structs and several members depending
primarily on DVM support and VSI type. Add function that guess whether
PVID is set and where and allow to access raw VLAN ID set. This is
intended to be used later on to decide what MAC{,VLAN} filters to set
for a VSI.
Reviewed-by: Michal Swiat... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:16 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Allow mac vlan filters to be managed by filters API in ice driver.
Together with mac-only filters they will be used to forward traffic
intended for loopback in VEB mode.
Signed-off-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Reviewed-by: Al... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:17 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Currently, packets that match MAC address of a VF will be sent to loopback
even if they would cross VLAN boundaries. Effectively, this drops them.
In this patch series, we aim to address this behaviour by adding MAC,VLAN
to complement what MAC-only filters do to select packets for loopback.
To reproduce the issue hav... | null | null | null | [PATCH iwl-next v4 0/7] ice: in VEB, prevent "cross-vlan" traffic | In Virtual Ethernet Bridge (VEB) mode, we use MAC filters to forward
traffic between two VFs. We also use VLAN filters to prune potential
destinations, so that they don't cross VLANs. In case a VF in VLAN X
sends a packet to a MAC address matching another VF but in VLAN Y, both
these filters will be hit. Packet will... | {
"author": "Jakub Slepecki <jakub.slepecki@intel.com>",
"date": "Wed, 4 Feb 2026 16:44:18 +0100",
"is_openbsd": false,
"thread_id": "IA3PR11MB8985050DB8947781F2E2B1C08F73A@IA3PR11MB8985.namprd11.prod.outlook.com.mbox.gz"
} |
lkml_critique | netdev | Avoid load/store tearing of 64-bit values on 32-bit architectures.
v2: https://lore.kernel.org/r/20260224112411.1561917-1-mmyangfl@gmail.com
- git rid of print_port_err()
- remove unused variable
v1: https://lore.kernel.org/r/20260203171305.95085-1-mmyangfl@gmail.com
- use functions instead of macros
- rework ... | null | null | null | [PATCH net-next v3 0/2] net: dsa: yt921x: Use u64_stats_t for MIB stats | This is a prerequisite for another patch. It does not change the
behavior on the success path.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/dsa/yt921x.c | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/yt921x.c b/drivers/net/dsa/yt921x.c
index 98e8915dd... | {
"author": "David Yang <mmyangfl@gmail.com>",
"date": "Fri, 27 Feb 2026 21:50:53 +0800",
"is_openbsd": false,
"thread_id": "20260227135057.2730254-2-mmyangfl@gmail.com.mbox.gz"
} |
lkml_critique | netdev | Avoid load/store tearing of 64-bit values on 32-bit architectures.
v2: https://lore.kernel.org/r/20260224112411.1561917-1-mmyangfl@gmail.com
- git rid of print_port_err()
- remove unused variable
v1: https://lore.kernel.org/r/20260203171305.95085-1-mmyangfl@gmail.com
- use functions instead of macros
- rework ... | null | null | null | [PATCH net-next v3 0/2] net: dsa: yt921x: Use u64_stats_t for MIB stats | 64-bit variables might not be atomic on 32-bit architectures, and could
lead to load/store tearing. Use u64_stats_t to ensure consistency.
Signed-off-by: David Yang <mmyangfl@gmail.com>
---
drivers/net/dsa/yt921x.c | 197 +++++++++++++++++++++++----------------
drivers/net/dsa/yt921x.h | 114 ++++++++++++----------
2... | {
"author": "David Yang <mmyangfl@gmail.com>",
"date": "Fri, 27 Feb 2026 21:50:54 +0800",
"is_openbsd": false,
"thread_id": "20260227135057.2730254-2-mmyangfl@gmail.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Support .suspend and .resume and Wake-on-LAN.
Implement ethtool ops .get_wol and .set_wol to support Wake-on-LAN
function. WOL requires hardware board support which is identified by
subsystem device ID. Magic packets are checked by firmware, and
currently only WAKE_MAGIC is supported.
And WOL related operations are a... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:47 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Remove duplicate-defined register macros, move the WOL implementation to
the library module. So that the WOL functions can be reused in txgbe
later.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
.../net/ethernet/wangxun/libwx/wx_ethtool.c | 34 ++++++++++++++++++
.../net/ethernet/wangxun/libwx/wx_ethtool.h... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:43 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Implement .ndo_tx_timeout to handle Tx side timeout event. When Tx
timeout event occur, it will triger driver into reset process.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/libwx/Makefile | 2 +-
drivers/net/ethernet/wangxun/libwx/wx_err.c | 126 ++++++++++++++++++
drive... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:49 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Implement power management function for txgbe. Clean up the same code in
the two drivers, to make more use of lib functions.
Add Tx timeout process and pci_error_handlers ops, to recover the devices.
v2:
- Split NCSI changes from the WOL patch.
- Properly return and handle error codes.
- Fix the typos.
- Remove the c... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:42 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Add function pointer wx->close_suspend() and adjust wx->do_reset(), so
that PCI driver ops such as .shutdown can be called in libwx.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
.../net/ethernet/wangxun/libwx/wx_ethtool.c | 2 +-
drivers/net/ethernet/wangxun/libwx/wx_lib.c | 89 +++++++++++++-
driver... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:46 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Implement wx->do_reset() for ngbe driver, and improve the specific reset
flow.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
.../net/ethernet/wangxun/ngbe/ngbe_ethtool.c | 1 -
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 49 +++++++++++++++++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 1 +
3 fi... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:45 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Since function ops wx->setup_tc() is set in txgbe and ngbe,
ethtool_ops.set_channels can be implemented in libwx to reduce
duplicated code.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/libwx/wx_ethtool.c | 2 +-
drivers/net/ethernet/wangxun/ngbe/ngbe_ethtool.c | 15 +--------... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:48 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | NGBE_NCSI_SUP and NGBE_NCSI_MASK are duplicate-defined, they can be
replaced by the macros defined in libwx. Just remove them.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/ngbe/ngbe_main.c | 4 ++--
drivers/net/ethernet/wangxun/ngbe/ngbe_type.h | 3 ---
2 files changed, 2 insert... | null | null | null | [PATCH net-next v2 2/8] net: ngbe: remove redundant macros | Support AER driver to handle the PCIe errors.
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
drivers/net/ethernet/wangxun/libwx/wx_err.c | 98 +++++++++++++++++++
drivers/net/ethernet/wangxun/libwx/wx_err.h | 2 +
drivers/net/ethernet/wangxun/libwx/wx_lib.c | 3 +-
drivers/net/ethernet/wangxun/libwx/w... | {
"author": "Jiawen Wu <jiawenwu@trustnetic.com>",
"date": "Fri, 27 Feb 2026 15:34:50 +0800",
"is_openbsd": false,
"thread_id": "20260227073450.23680-6-jiawenwu@trustnetic.com.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | Wrap the arguments for priv->plat->mac_finish() to avoid an overly long
line.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c ... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:08 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | There are repeated instances of:
fwnode = priv->plat->port_node;
if (!fwnode)
fwnode = dev_fwnode(priv->device);
However, the only place that ->port_node is set is
stmmac_probe_config_dt():
struct device_node *np = pdev->dev.of_node;
...
/* PHYLINK automatically parses the phy-handle property */
plat->port_no... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:13 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | No code calls stmmac_get_tx_owner(). Remove the macro, its associated
function pointer, and all implementations.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 6 ------
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 ------
drive... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:19 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | No code calls stmmac_get_tx_ls(). Remove this macro, its associated
function pointer, and all implementations.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 7 -------
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 ------
driver... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:24 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | No code calls stmmac_get_tx_len(). Remove this macro, its associated
function pointer, and all implementations.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_descs.c | 6 ------
drivers/net/ethernet/stmicro/stmmac/dwxgmac2_descs.c | 6 ------
driver... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:29 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | Remove the DMA_CHAN_INTR_DEFAULT_[TR]X* definitions, which are aliases
of their respective DMA_CHAN_INTR_ENA_[TR]IE definitions.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/dwmac4_dma.h | 4 ----
drivers/net/ethernet/stmicro/stmmac/dwmac4_lib.c | 16 +++++... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:34 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | As a result of the previous cleanup, it is now obvious that there are
no differences between the dwmac4 and dwmac410 versions of the DMA
interrupt enable/disable functions.
Moreover, dwmac410_disable_dma_irq() is completely unused; instead,
dwmac4_disable_dma_irq() is used to disable the interrupts for v4.10a
cores wh... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:39 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | mac->xlgmac is only ever written to by the dwxlgmac2_quirk() function.
Remove mac->xlgmac, and the quirk function that then becomes redundant.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/common.h | 1 -
drivers/net/ethernet/stmicro/stmmac/hwif.c | 7 ----... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:44 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | extend_desc is a boolean, so make it so, and use "true" to assign it.
Add a comment to describe what this member does.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/hwif.c | 2 +-
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 6 +++++-
2 files changed, 6 ... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:49 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | priv->chain_mode is only tested for non-zero, so it can be a boolean.
Change its type to boolean, and add a comment describing this member.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac.h | 3 ++-
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:54 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | struct stmmac_dma_cfg mixed_burst/fixed_burst members are both boolean
in nature - of_property_read_bool() are used to read these from DT, and
they are only tested for non-zero values. Use bool to avoid unnecessary
padding in this structure.
Update dwmac-intel to initialise these using true rather than '1', and
remove... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:53:59 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | Move the initialisation of priv->plat->dma_cfg->atds, which indicates
that 8 32-bit word descriptors are being used for pre-v4.0 cores, after
the call to stmmac_hwif_init(), which will initialise priv->extend_desc
and priv->mode (the descriptor mode.)
We don't need to re-evaluate this in stmmac_init_dma_engine() - as ... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:54:05 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | atds is boolean, and there is only one place that its value is changed.
Simplify this to a boolean assignment.
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:54:10 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Hi,
Yet another bunch of patches cleaning up the stmmac driver.
We start off by cleaning up the formatting for stmmac_mac_finish(). Then
remove a plat_dat->port_node which is redundant, followed by several
descriptor methods that aren't called.
We then remove useless dwmac4 interrupt definitions, and realise that
v4... | null | null | null | [PATCH net-next 00/14] net: stmmac: further cleanups | Move the DMA configuration validation from stmmac_init_dma_engine()
to the start of the driver probe function. The platform glue is
expected to supply the DMA configuration, and a non-zero programmable
burst length (bpl).
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
---
drivers/net/ethernet/stmic... | {
"author": "\"Russell King (Oracle)\" <rmk+kernel@armlinux.org.uk>",
"date": "Fri, 27 Feb 2026 09:54:15 +0000",
"is_openbsd": false,
"thread_id": "E1vvuXy-0000000Avnk-10Q8@rmk-PC.armlinux.org.uk.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Change the inode hash/lookup VFS API functions to accept u64 parameters
instead of unsigned long for inode numbers and hash values. This is
preparation for widening i_ino itself to u64, which will allow
filesystems to store full 64-bit inode numbers on 32-bit architectures.
Since unsigned long implicitly widens to u64... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:03 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Change the type of i_ino in struct inode from unsigned long to u64.
On 64-bit architectures, unsigned long is already 64 bits, so this is
effectively a type alias change with no runtime impact. On 32-bit
architectures, this widens i_ino from 32 to 64 bits, allowing
filesystems like NFS, CIFS, XFS, Ceph, and FUSE to st... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:04 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update trace event definitions in VFS-layer trace headers to use u64
instead of ino_t/unsigned long for inode number fields, and change
format strings from %lu/%lx to %llu/%llx to match.
This is needed because i_ino is now u64. Changing trace event field
types changes the binary trace format, but the self-describing f... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:05 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update ext4 trace events and filesystem code for u64 i_ino:
- Change __field(ino_t, ...) to __field(u64, ...) in trace events
- Update all %lu format strings to %llu for inode numbers
- Cast to (unsigned long long) where needed in TP_printk
- Update __ext4_grp_locked_error() ino parameter to u64
- Update ext_debug() f... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:06 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update %lu to %llu in jbd2 debug/warning messages that print i_ino,
since i_ino is now u64.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/jbd2/journal.c | 4 ++--
fs/jbd2/transaction.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
index cb2c5... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:07 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update f2fs trace events and filesystem code for u64 i_ino:
- Change __field(ino_t, ...) to __field(u64, ...) in trace events
- Update show_dev_ino() macro format strings from %lu to %llu
- Cast inode numbers to (unsigned long long) in TP_printk
- Update format string in fs/f2fs/node.c
Signed-off-by: Jeff Layton <jla... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:08 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update format strings from %ld/%lu to %lld/%llu for i_ino, which is
now a u64.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/lockd/svclock.c | 8 ++++----
fs/lockd/svcsubs.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fs/lockd/svclock.c b/fs/lockd/svclock.c
index 255a847ca0b6b9f7ab... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:09 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update NFS for u64 i_ino:
- Simplify nfs_fileid_to_ino_t() to return u64 directly, since i_ino
can now store a full 64-bit fileid without folding on 32-bit
- Update nfs_fattr_to_ino_t() to return u64
- Update format strings from %lu/%lx to %llu/%llx
- Remove unnecessary (unsigned long) casts on i_ino
Signed-off-by:... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:10 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Now that i_ino is u64, these helpers are trivial identity functions that
just return the fileid unchanged. Remove them and use fattr->fileid
directly at the two call sites.
nfs_fileid_to_ino_t() had no callers at all.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfs/inode.c | 17 +++--------------
... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:11 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Now that i_ino is u64, the VFS stat path handles 64-bit inode numbers
natively. The truncation to 32-bit st_ino (with -EOVERFLOW) is handled
by cp_new_stat() and cp_compat_stat() in the generic stat code, so the
NFS-specific XOR-folding hack is no longer needed.
Remove nfs_compat_user_ino64() and have callers pass the... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:12 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | The enable_ino64 module parameter controlled whether NFS presented
64-bit or XOR-folded 32-bit inode numbers to userspace. With i_ino now
being u64 and the compat folding function removed, this parameter has
no remaining consumers.
Remove the parameter, the NFS_64_BIT_INODE_NUMBERS_ENABLED macro, and
the enable_ino64 ... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:13 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
lkml_critique | netdev | Christian said [1] to "just do it" when I proposed this, so here we are!
For historical reasons, the inode->i_ino field is an unsigned long,
which means that it's 32 bits on 32 bit architectures. This has caused a
number of filesystems to implement hacks to hash a 64-bit identifier
into a 32-bit field, and deprives us... | null | null | null | [PATCH 00/61] vfs: change inode->i_ino from unsigned long to u64 | Update format strings from %ld/%lu to %lld/%llu for i_ino, which is
now a u64.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfsd/export.c | 2 +-
fs/nfsd/nfs4state.c | 4 ++--
fs/nfsd/nfsfh.c | 4 ++--
fs/nfsd/vfs.c | 2 +-
4 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/fs/nfsd/... | {
"author": "Jeff Layton <jlayton@kernel.org>",
"date": "Thu, 26 Feb 2026 10:55:14 -0500",
"is_openbsd": false,
"thread_id": "20260227-herab-wolken-c52d560f40d5@brauner.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.