data_type large_stringclasses 3
values | source large_stringclasses 29
values | code large_stringlengths 98 49.4M | filepath large_stringlengths 5 161 ⌀ | message large_stringclasses 234
values | commit large_stringclasses 234
values | subject large_stringclasses 418
values | critique large_stringlengths 101 1.26M ⌀ | metadata dict |
|---|---|---|---|---|---|---|---|---|
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, 23 Feb 2026 12:32:29 +0000 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Thank you for catching this, Ravi! So, this is a fix for the RFC patch series
[1] that not yet merged, right? I think this fix is better to be carried with
the series, and squashed into the broken commit to not introduce unnecessa... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 23 Feb 2026 17:40:11 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, 23 Feb 2026 12:32:30 +0000 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Nice finding, thank you for sharing this!
But this code is written in the way because the current code assumes zero 'esz'
means it is not being used and therefore be ignored. This change should be ok
for your use case, but could ... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 23 Feb 2026 17:54:52 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, 23 Feb 2026 12:32:31 +0000 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Looks good in general! I have some comments about trivials and the design
below, though.
Nit. Let's wrap the line for 80 columns limit.
I understand this could make it time-efficient. That is, without this, you
will need to i... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 23 Feb 2026 20:27:33 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | Hello Ravi,
On Mon, 23 Feb 2026 12:32:28 +0000 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Thank you for keep working on and sharing this :)
This perfectly aligns with the direction we agreed on the previous discussion.
Sounds good and reasonable to me.
I'm not very sure if this is really needed, though. ... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 23 Feb 2026 21:36:33 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, 23 Feb 2026 12:32:32 +0000 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
I agree this can happen, and could be problematic on some setup.
But, I feel this might be too overfit solution for a specific setup.
The size of the change is quite big. I'm now curious if the problem is
significant enough for... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Mon, 23 Feb 2026 21:54:50 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, Feb 23, 2026 at 9:36 PM SeongJae Park <sj@kernel.org> wrote:
Thank you for the detailed review!
Great, glad the approach makes sense.
Understood. I consciously separated the cache implementation (patch 4)
from the core metrics (patch 3) because the cache is ONE possible approach to
handle detection lag - n... | {
"author": "Ravi Jonnalagadda <ravis.opensrc@gmail.com>",
"date": "Wed, 25 Feb 2026 10:19:11 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, Feb 23, 2026 at 5:40 PM SeongJae Park <sj@kernel.org> wrote:
Yes. Please go ahead and squash it into your series.
Agreed. Please make that change when you apply it. | {
"author": "Ravi Jonnalagadda <ravis.opensrc@gmail.com>",
"date": "Wed, 25 Feb 2026 10:23:09 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, Feb 23, 2026 at 5:54 PM SeongJae Park <sj@kernel.org> wrote:
Thanks!
I understand. Please take your time. I'm happy to test whatever approach
you come up with. | {
"author": "Ravi Jonnalagadda <ravis.opensrc@gmail.com>",
"date": "Wed, 25 Feb 2026 10:28:30 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, Feb 23, 2026 at 8:27 PM SeongJae Park <sj@kernel.org> wrote:
Thank you for the detailed review!
Will fix it.
Got it. I'll change it to simply iterate regions per goal.
Got it. If we ever need to implement the optimization, will follow the
dynamic allocation path.
Got it. I'll add handling for regions t... | {
"author": "Ravi Jonnalagadda <ravis.opensrc@gmail.com>",
"date": "Wed, 25 Feb 2026 10:46:56 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Mon, Feb 23, 2026 at 9:54 PM SeongJae Park <sj@kernel.org> wrote:
Thank you for acknowledging the issue.
I understand. The cache was consciously separated as patch 4 because it
represents ONE possible approach to handle detection lag - not
necessarily THE approach.
My goal was to share what was needed to achieve ... | {
"author": "Ravi Jonnalagadda <ravis.opensrc@gmail.com>",
"date": "Wed, 25 Feb 2026 10:58:15 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 10:19:11 -0800 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
My pleasure!
[...]
That was indeed helpful for reviewing, thank you!
Thank you, I will do!
[...]
Thank you for sharing the pain point. I recently added a few more DAMOS
tracepoints motivated by our offline discussion. I'm pl... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Wed, 25 Feb 2026 16:52:46 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 10:23:09 -0800 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Thank you, I will do!
Thanks,
SJ
[...] | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Wed, 25 Feb 2026 16:53:48 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 10:28:30 -0800 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
Thank you for being flexible, I will do!
Thanks,
SJ
[...] | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Wed, 25 Feb 2026 16:54:34 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 10:46:56 -0800 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
[...]
Thank you for flexibly accepting my suggestions and listing those again here.
All looks good and catching all the points!
I hope you a great break!
Thanks,
SJ
[...] | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Wed, 25 Feb 2026 16:57:31 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 10:58:15 -0800 Ravi Jonnalagadda <ravis.opensrc@gmail.com> wrote:
[...]
Thank you for flexibly accepting my suggestion, Ravi. I hope to continue more
discussions on the issue later.
Thanks,
SJ
[...] | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Wed, 25 Feb 2026 16:59:15 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
This series introduces two new DAMON quota goal metrics for controlling
memory migration in heterogeneous memory systems (e.g., DRAM and CXL
memory tiering) using physical address (PA) mode monitoring.
v2: https://lore.kernel.or... | null | null | null | [RFC PATCH v3 0/4] mm/damon: Introduce node_eligible_mem_bp and node_ineligible_mem_bp Quota Goal Metrics | On Wed, 25 Feb 2026 16:53:48 -0800 SeongJae Park <sj@kernel.org> wrote:
I now think it is better to just remove the damon_new_scheme() internal
initialization. I added the detail [1] to the original thread. I'll keep your
Co-developed-by: tag with the new fix though, unless you mind. Let's keep
discussing there if... | {
"author": "SeongJae Park <sj@kernel.org>",
"date": "Thu, 26 Feb 2026 18:04:42 -0800",
"is_openbsd": false,
"thread_id": "20260227020443.91984-1-sj@kernel.org.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Ahead of adding support for D128 pgtables, refactor places that print
PTE values to use the new __PRIpte format specifier and __PRIpte_args()
macro to prepare the argument(s). When using D128 pgtables in future,
we can simply redefine __PRIpte and __PTIpte_args().
Besides there is also an assumption about pxd_val() be... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:38 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Currently vma->vm_page_prot is safely read from and written to, without any
locks with READ_ONCE() and WRITE_ONCE(). But with introduction of D128 page
tables on arm64 platform, vm_page_prot grows to 128 bits which can't safely
be handled with READ_ONCE() and WRITE_ONCE().
Add read and write accessors for vm_page_prot... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:39 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Replace READ_ONCE() with the existing standard page table accessor for PUD
aka pudp_get() in pud_trans_unstable(). This does not create any functional
change for platforms that do not override pudp_get(), which still defaults
to READ_ONCE().
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: David Hildenbrand <david@ke... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:40 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Replace READ_ONCE() with standard page table accessors i.e pxdp_get() which
anyways default into READ_ONCE() in cases where platform do not override.
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: li... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:41 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Convert all READ_ONCE() based PMD accesses as pmdp_get() instead which will
support both D64 and D128 translation regime going forward.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@li... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:42 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Convert all READ_ONCE() based PUD accesses as pudp_get() instead which will
support both D64 and D128 translation regime going forward.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@li... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:43 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Convert all READ_ONCE() based P4D accesses as p4dp_get() instead which will
support both D64 and D128 translation regime going forward.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@li... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:44 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Convert all READ_ONCE() based PGD accesses as pgdp_get() instead which will
support both D64 and D128 translation regime going forward.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-kernel@li... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:45 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Define arm64 platform specific implementations for new pXdp_get() helpers.
These resolve into READ_ONCE(), thus ensuring required single copy atomic
semantics for the page table entry reads.
In future this infrastructure can be used for D128 to maintain single copy
atomicity semantics with inline asm blocks.
Cc: Cata... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:46 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Currently ptdesc_set() is defined as WRITE_ONCE() but this will change for
D128 pgtable builds, for which WRITE_ONCE() is not sufficient for single
copy atomicity.
In future this infrastructure can be used for D128 to maintain single copy
atomicity semantics with inline asm blocks.
Cc: Catalin Marinas <catalin.marina... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:47 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Route all cmpxchg() operations performed on various page table entries to a
new ptdesc_cmpxchg_relaxed() helper. Similarly route all xchg() operations
performed on page table entries to a new ptdesc_xchg_relaxed() helper.
Currently these helpers just forward to the same APIs that were previously
called direct, but in ... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:48 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Ahead of adding support for D128 pgtables, refactor places that print
PTE values to use the new __PRIpte format specifier and __PRIpte_args()
macro to prepare the argument(s). When using D128 pgtables in future,
we can simply redefine __PRIpte and __PTIpte_args().
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:49 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Override pgprot_[read|write]_once() accessors using ptdesc_[get|set]()
providing required single copy atomic operation for vma->vm_page_prot.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.roberts@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: linux-arm-ker... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:50 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Enable fixmap with 5 level page table when required. This creates table
entries at the PGD level. Add a fallback stub for pgd_page_paddr() when
(PGTBALE_LEVELS <= 4) which helps in intercepting any unintended usage.
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: Ryan Roberts <ryan.... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:51 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | From: Linu Cherian <linu.cherian@arm.com>
Existing __tlb_level macro uses encoded arguments for TLBI instructions
which is not compatible with TLBIP instructions required with FEAT_D128
both for level hint and range based operations.
Add two new macros __tlb_asid_level and __tlb_range that will work both
with existin... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:52 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | Add build time support for FEAT_D128 page tables with a new Kconfig option
i.e CONFIG_ARM64_D128. When selected, PTE types become 128 bits wide and
PTE bits are mapped to their new locations. Besides the basic page table
geometry is also updated since each table page now holds half the number
of entries (aka PTRS_PER_P... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 10:41:53 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, Feb 24, 2026 at 10:41:41AM +0530, Anshuman Khandual wrote:
This is a bit silly, no? All of them should always be READ_ONCE(), with
the exception of pte_get() on PAE like scenarios. | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Tue, 24 Feb 2026 09:48:04 +0100",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, Feb 24, 2026 at 10:41:41AM +0530, Anshuman Khandual wrote:
For each of the patches where you make this sort of change, please
explain in the commit message *why* it is necessary to do this.
IIUC the entire point of this is that in subsequent patches, arm64 will
need to use something other than READ_ONCE() for... | {
"author": "Mark Rutland <mark.rutland@arm.com>",
"date": "Tue, 24 Feb 2026 10:08:21 +0000",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, Feb 24, 2026 at 10:08:21AM +0000, Mark Rutland wrote:
That, and only being sent *one* patch, I have no clue what the rest of
them are doing. Didn't even get 0/n.
I hate people sending me just one patch; just send the whole series
already. | {
"author": "Peter Zijlstra <peterz@infradead.org>",
"date": "Tue, 24 Feb 2026 11:41:34 +0100",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 24/02/2026 10:41, Peter Zijlstra wrote:
Perhaps Anshuman can forward you the rest of the series, but FWIW, the cover
letter is here:
https://lore.kernel.org/all/20260224051153.3150613-1-anshuman.khandual@arm.com/
High level summary is that we are adding support for 128 bit page tables on
arm64. Existing places tha... | {
"author": "Ryan Roberts <ryan.roberts@arm.com>",
"date": "Tue, 24 Feb 2026 11:22:54 +0000",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 24/02/26 4:11 PM, Peter Zijlstra wrote:
Sorry about that. I normally gather emails from all individual patches
in the series while creating the Cc list for the cover letter, so that
every one receives the entire series regardless of the subsystem.
But this was the only patch that did not belong either to mm or arm... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 18:09:50 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 24/02/26 4:52 PM, Ryan Roberts wrote:
I have already forwarded the entire series to Peter.
That summarizes the intent for this change - will update the commit message
as required. Thanks Ryan for such a detailed explanation. | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 18:19:06 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 24/02/26 3:38 PM, Mark Rutland wrote:
Sure will explain the intent better for these patches.
Right.
Got it. | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Tue, 24 Feb 2026 18:23:06 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, 24 Feb 2026 10:41:38 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
Hi Anshuman,
The original format had a space between values ("pgd:%08llx p4d:%08llx").
The replacement loses the space separator producing output like
"pgd:123p4d:456" instead of "pgd:123 p4d:456". The same issue exists
in other ... | {
"author": "Usama Arif <usama.arif@linux.dev>",
"date": "Thu, 26 Feb 2026 04:34:39 -0800",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, 24 Feb 2026 10:41:47 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
The ptdesc_set() and ptdesc_get() macros are defined in
arch/arm64/include/asm/pgtable.h and are arm64-specific. This change is
in mm/debug_vm_pgtable.c which is generic code compiled for all
architectures. Other architectures do ... | {
"author": "Usama Arif <usama.arif@linux.dev>",
"date": "Thu, 26 Feb 2026 04:37:45 -0800",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 26/02/26 6:04 PM, Usama Arif wrote:
There needs to be a forward single space before p4d starts.
pr_alert("pgd:%" __PRIpte " p4d:%" __PRIpte "\n"
^^^
Will fix all the instances. | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Thu, 26 Feb 2026 18:19:45 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 26/02/26 6:07 PM, Usama Arif wrote:
Agreed. Probably will add a local fallback for ptdesc_set() which
defaults to WRITE_ONCE() for platforms not overriding. OR does it
require making ptdesc_get/set() much more generic construct ?
Probably missed this problem while building on some other platforms
as DEBUG_VM_PGTAB... | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Thu, 26 Feb 2026 18:24:51 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 26/02/2026 12:54, Anshuman Khandual wrote:
I don't think there is any need for WRITE_ONCE() in this file? (and I feel like
this has come up before in some other context). Could you just change it to a
plain C assignment? Or even better, pmd_clear()? | {
"author": "Ryan Roberts <ryan.roberts@arm.com>",
"date": "Thu, 26 Feb 2026 13:19:13 +0000",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On Tue, 24 Feb 2026 10:41:53 +0530 Anshuman Khandual <anshuman.khandual@arm.com> wrote:
Should this say, If unsure, say N?
[...]
Does 12 over here represent PAGE_SHIFT? If so, would it break 16K and 64K PAGE_SIZE? | {
"author": "Usama Arif <usama.arif@linux.dev>",
"date": "Thu, 26 Feb 2026 06:10:23 -0800",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | FEAT_D128 is a new arm architecture feature adding support for VMSAv9-128
translation system. FEAT_D128 is an optional feature from ARMV9.3 onwards.
So with this feature arm64 platforms could have two different translation
systems, VMSAv8-64 and VMSAv9-128 could selectively be enabled.
FEAT_D128 adds 128 bit page tabl... | null | null | null | [RFC V1 00/16] arm64/mm: Enable 128 bit page table entries | On 26/02/26 6:49 PM, Ryan Roberts wrote:
Agreed and just sent a patch in this regard.
https://lore.kernel.org/all/20260227061204.2215395-1-anshuman.khandual@arm.com/ | {
"author": "Anshuman Khandual <anshuman.khandual@arm.com>",
"date": "Fri, 27 Feb 2026 11:49:09 +0530",
"is_openbsd": false,
"thread_id": "7f59b3ea-9346-46eb-b6c1-ae27b718f7e6@arm.com.mbox.gz"
} |
lkml_critique | linux-mm | Hello,
I hit a deadlock related to CMA mem allocation attempting to flush all work
while holding some wifi related mutex, and with a work-queue attempting to process a wifi regdomain
work item. I really don't see any good way to fix this,
it would seem that any code that was holding a mutex that could block a work-qu... | null | null | null | 6.18.13 iwlwifi deadlock allocating cma while work-item is active. | On 2/23/26 14:36, Ben Greear wrote:
I tried using a kthread to do the regulatory domain processing instead of worker item,
and that seems to have solved the problem. If that seems reasonable approach to
wifi stack folks, I can post a patch.
Thanks,
Ben | {
"author": "Ben Greear <greearb@candelatech.com>",
"date": "Fri, 27 Feb 2026 08:31:05 -0800",
"is_openbsd": false,
"thread_id": "18c4bfed-caca-bef3-a139-63d7fa48940a@candelatech.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Fri, 2025-10-03 at 03:45 +0100, George Anthony Vernon wrote:
Let's pay respect to previous efforts. I am suggesting to add this line:
Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Are you OK with it?
I think we can declare like this:
static inline
bool is_valid_cnid(unsigned long cnid, s8 ty... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Fri, 3 Oct 2025 22:40:16 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Fri, Oct 03, 2025 at 10:40:16PM +0000, Viacheslav Dubeyko wrote:
I agree with paying respect to Tetsuo. The kernel docs indicate that the SoB tag
isn't used like that. Would the Suggested-by: tag be more appropriate?
Because struct inode's inode number is an unsigned long.
Because the type field of struct hfs_cat_r... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Sat, 4 Oct 2025 02:25:16 +0100",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Sat, 2025-10-04 at 02:25 +0100, George Anthony Vernon wrote:
Frankly speaking, I don't see how Suggested-by is applicable here. :)
My point was that if you mentioned the previous discussion, then it
means that you read it. And it sounds to me that your patch is
following to the points are discussed there. So, your ... | {
"author": "Viacheslav Dubeyko <slava@dubeyko.com>",
"date": "Tue, 07 Oct 2025 06:40:50 -0700",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | I found this patch. Please CC: me when posting V2.
On 2025/10/07 22:40, Viacheslav Dubeyko wrote:
I'm not suggesting this change. Therefore, Cc: might match.
But I don't like
Tested-by: syzbot+97e301b4b82ae803d21b@syzkaller.appspotmail.com
line, for syzbot only tested one cnid which was embedded in the
reproduce... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Thu, 9 Oct 2025 21:57:33 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | Hi Tetsuo,
On Thu, Oct 09, 2025 at 09:57:33PM +0900, Tetsuo Handa wrote:
Sorry I forgot to CC you last time :)
Sure, I have added a CC tag for you in V2 which I'm currently testing.
I think HFS_POR_CNID case should be disallowed. There is no real
underlying file with that CNID. If we ever found a record with that... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Wed, 29 Oct 2025 03:20:37 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/10/29 12:20, George Anthony Vernon wrote:
Hmm, your interpretation does not match what Viacheslav Dubeyko interpreted
hfs_read_inode() can be called for the root directory and parent of
the root cases. So, HFS_POR_CNID and HFS_ROOT_CNID are legitimate values.
at https://lkml.kernel.org/r/9a18338da59460bd... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Wed, 29 Oct 2025 19:06:46 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | Changes from V1->V2:
- is_valid_cnid prototype now takes u32 and u8 types
- Add fsck advice in dmesg
- Replace make_bad_inode calls in hfs_read_inode with gotos
- Reuse same check in hfs_write_inode
- Disallow HFS_POR_CNID, HFS_BAD_CNID, and HFS_EXCH_CNID
- Add Tetsuo's patch to mine and make it a patch series
This pa... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Tue, 4 Nov 2025 01:47:35 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Tue, 4 Nov 2025 01:47:36 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | syzbot is reporting that BUG() in hfs_write_inode() fires upon unmount
operation when the inode number of the record retrieved as a result of
hfs_cat_find_brec(HFS_ROOT_CNID) is not HFS_ROOT_CNID, for commit
b905bafdea21 ("hfs: Sanity check the root record") checked the record
size and the record type but did not check... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Tue, 4 Nov 2025 01:47:37 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-04 at 01:47 +0000, George Anthony Vernon wrote:
The TN1150 technical note describes HFS+ file system and it needs to take into
account the difference between HFS and HFS+. So, it is not completely correct
for the case of HFS to follow to the TN1150 technical note as it is.
HFS is ancient file system ... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 4 Nov 2025 22:34:15 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-04 at 01:47 +0000, George Anthony Vernon wrote:
This check is completely unnecessary. Because, we have hfs_iget() then [1]:
res = hfs_find_init(HFS_SB(sb)->cat_tree, &fd);
if (res)
goto bail_no_root;
res = hfs_cat_find_brec(sb, HFS_ROOT_CNID, &fd);
if (!res) {
if (fd.entrylength != sizeof(rec.... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 4 Nov 2025 23:01:31 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, Nov 04, 2025 at 11:01:31PM +0000, Viacheslav Dubeyko wrote:
I think Tetsuo's concern is that a directory catalog record with
cnid > 15 might be returned as a result of hfs_bnode_read, which
is_valid_cnid() would not protect against. I've satisfied myself that
hfs_bnode_read() in hfs_fill_super() will populate ... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Mon, 10 Nov 2025 23:03:57 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Mon, 2025-11-10 at 23:03 +0000, George Anthony Vernon wrote:
Technically speaking, we can adopt this check to be completely sure that nothing
will be wrong during the mount operation. But I believe that is_valid_cnid()
should be good enough to manage this. Potential argument could be that the check
of rec.dir.DirID... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Mon, 10 Nov 2025 23:34:39 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, Nov 04, 2025 at 10:34:15PM +0000, Viacheslav Dubeyko wrote:
I've checked Inside Macintosh: Files Chapter 2 page 70 to make sure HFS
is the same (CNIDs 1 - 5 are assigned, and all of 1-15 are reserved).
I will add this to the commit message for V3.
HFS_BAD_CNID is reserved for internal use of the filesystem
i... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Tue, 11 Nov 2025 00:00:57 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Mon, Nov 10, 2025 at 11:34:39PM +0000, Viacheslav Dubeyko wrote:
Agreed we're not worried about speed that the mount operation can reach
fail case. The check would have value if the bnode populated in
hfs_find_data fd by hfs_cat_find_brec() is bad. That would be very
defensive, I'm not sure it's necessary.
Maybe i... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Tue, 11 Nov 2025 00:23:12 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-11 at 00:23 +0000, George Anthony Vernon wrote:
CNID is abbreviation of Catalog Node ID. So, is_valid_catalog_cnid() will sound
like Catalog Catalog Node ID. :)
Thanks,
Slava. | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 11 Nov 2025 00:34:40 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-11 at 00:00 +0000, George Anthony Vernon wrote:
Yes, we don't want to use it on Linux kernel side. But, potentially, the file
for bad block management could or was been created/used on Mac OS side. And if
anyone tries to mount the HFS volume with the bad block file, then we will
refuse to mount it on t... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 11 Nov 2025 00:48:28 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/11/11 9:23, George Anthony Vernon wrote:
With my patch, mount() syscall fails with EIO unless rec.dir.DirID == 2.
Without my patch, mount() syscall succeeds and EIO is later returned when
trying to read the root directory of the mounted filesystem.
This is not a problem of speed. Fuzzing unreadable root direc... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Tue, 11 Nov 2025 23:26:07 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/11/04 10:47, George Anthony Vernon wrote:
Is it guaranteed that hfs_write_inode() and make_bad_inode() never run in parallel?
If no, this check is racy because make_bad_inode() makes S_ISDIR(inode->i_mode) == false. | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Tue, 11 Nov 2025 23:39:14 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-11 at 23:39 +0900, Tetsuo Handa wrote:
Any inode should be completely created before any hfs_write_inode() call can
happen. So, I don't see how hfs_write_inode() and make_bad_inode() could run in
parallel.
But, maybe, I am not completely right that we need to call is_bad_inode() in
hfs_write_in... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 11 Nov 2025 22:42:09 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, 2025-11-11 at 23:26 +0900, Tetsuo Handa wrote:
The file system is mounted only if hfs_fill_super() created root node and return
0 [1]. However, if hfs_iget() return bad inode [2] and we will call
is_bad_inode() here [3]:
root_inode = hfs_iget(sb, &fd.search_key->cat, &rec);
hfs_find_exit(&fd);
if (... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 11 Nov 2025 22:56:51 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/11/12 7:56, Viacheslav Dubeyko wrote:
Do you admit that mounting (and optionally fuzzing on) a bad inode (an inode
which was subjected to make_bad_inode()) is useless?
Adding is_bad_inode() check without corresponding iput() in error path causes
an inode leak bug. Also, error code will differ (my patch return... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Fri, 14 Nov 2025 23:18:02 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Fri, 2025-11-14 at 23:18 +0900, Tetsuo Handa wrote:
Mount will fail in the case of bad root inode. I don't see any issue here.
I don't see any problem to add iput(root_inode) as part of failure management in
hfs_fill_super(). And we can return any proper error code for the case of bad
root inode.
If Catalog Fil... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Fri, 14 Nov 2025 21:00:41 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, Nov 11, 2025 at 12:48:28AM +0000, Viacheslav Dubeyko wrote:
The mount operation only requires reading the root inode, so the
proposed change does not mean we would refuse to mount an HFS volume.
It is okay if HFS_BAD_CNID already exists in the btree, we simply won't
ever try to read or write it from disk.
I w... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Mon, 24 Nov 2025 22:33:15 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, Nov 11, 2025 at 12:34:40AM +0000, Viacheslav Dubeyko wrote:
Indeed, I think my thinking got muddled up late at night :)
Thanks,
George | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Mon, 24 Nov 2025 22:56:11 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Tue, Nov 11, 2025 at 10:42:09PM +0000, Viacheslav Dubeyko wrote:
Could we not read the same inode a second time, during the execution of
hfs_write_inode()?
Then I believe we could hit make_bad_inode() in hfs_read_inode() once we
had already entered hfs_write_inode(), and so test a cnid against the
wrong i_mode.
T... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Mon, 24 Nov 2025 23:46:49 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Mon, 2025-11-24 at 22:33 +0000, George Anthony Vernon wrote:
The function is_valid_cnid() doesn't limit the context of it using. Logically,
HFS_BAD_CNID is valid CNID because the record with such CNID could present in
Catalog File. And if anybody tries to use is_valid_cnid() for checking the
Catalog File's record (... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 25 Nov 2025 19:02:25 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Mon, 2025-11-24 at 23:46 +0000, George Anthony Vernon wrote:
Maybe, I am missing something in your point. But your explanation sounds
slightly strange to me.
At first, VFS code tries to find inode object in the cache of already created
inodes. So, if we created inode, then it should be in inode cache. It mea... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Tue, 25 Nov 2025 19:15:48 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/11/25 8:46, George Anthony Vernon wrote:
My "Is it guaranteed that hfs_write_inode() and make_bad_inode() never run in parallel?"
question does not assume "make_bad_inode() for HFS is called from only hfs_read_inode()".
write_inode() already checks for !is_bad_inode(inode) before calling
filesystem's write_in... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Sun, 30 Nov 2025 19:07:13 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2025/11/30 19:07, Tetsuo Handa wrote:
In a different thread, it turned out that make_bad_inode() must not be called
once the inode is fully visible
( https://lkml.kernel.org/r/wqkxevwtev5p77czk2com5zvbbwcpxxeucrt7zbgjciqxjyivx@c7624klburuh ),
requiring "make_bad_inode() for HFS is called from only hfs_read_inode()"... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Tue, 6 Jan 2026 19:21:39 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On 2026/01/06 19:21, Tetsuo Handa wrote:
I'm testing https://lkml.kernel.org/r/427fcb57-8424-4e52-9f21-7041b2c4ae5b@I-love.SAKURA.ne.jp
in linux-next.git tree since next-20260202, and syzbot did not find problems; ready to send to
linux.git tree if we need more time before getting next version of your patch. | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Wed, 11 Feb 2026 21:54:54 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | syzbot is reporting that BUG() in hfs_write_inode() fires
when the inode number of the record retrieved as a result of
hfs_cat_find_brec(HFS_ROOT_CNID) is not HFS_ROOT_CNID, for
commit b905bafdea21 ("hfs: Sanity check the root record") checked
the record size and the record type but did not check the inode number.
Rep... | {
"author": "Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>",
"date": "Wed, 18 Feb 2026 22:28:50 +0900",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Wed, 2026-02-18 at 22:28 +0900, Tetsuo Handa wrote:
If you would like to finish George Anthony Vernon's work, then you are welcome.
We have multiple issues in HFS/HFS+ code base. And I don't see any priority in
this issue. So, I don't see the point to accept not the fix but a workaround. I
am not working on th... | {
"author": "Viacheslav Dubeyko <Slava.Dubeyko@ibm.com>",
"date": "Wed, 18 Feb 2026 22:13:38 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | hfs_read_inode previously did not validate CNIDs read from disk, thereby
allowing inodes to be constructed with disallowed CNIDs and placed on
the dirty list, eventually hitting a bug on writeback.
Validate reserved CNIDs according to Apple technical note TN1150.
This issue was discussed at length on LKML previously,... | null | null | null | [PATCH] hfs: Validate CNIDs in hfs_read_inode | On Wed, Feb 11, 2026 at 09:54:54PM +0900, Tetsuo Handa wrote:
Thanks for your patience Tetsuo, I've been focussed on work for the past
few months following a change of employer. I will review the most recent
feedback this weekend and respin the patch.
I appreciate your feedback on previous versions of the patch. It wi... | {
"author": "George Anthony Vernon <contact@gvernon.com>",
"date": "Fri, 27 Feb 2026 00:39:22 +0000",
"is_openbsd": false,
"thread_id": "aaDnuqeArrGyAty-@Bertha.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Refactor the logic in io_register_pbuf_ring() into generic helpers:
- io_copy_and_validate_buf_reg(): Copy out user arg and validate user
arg and buffer registration parameters
- io_alloc_new_buffer_list(): Allocate and initialize a new buffer
list for the given buffer group ID
- io_setup_pbuf_ring(): Sets up the p... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:42 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Use the more generic name io_unregister_buf_ring() as this function will
be used for unregistering both provided buffer rings and kernel-managed
buffer rings.
This is a preparatory change for upcoming kernel-managed buffer ring
support.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
io_uring/kbuf.c | 2... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:43 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Add support for kernel-managed buffer rings (kmbuf rings), which allow
the kernel to allocate and manage the backing buffers for a buffer
ring, rather than requiring the application to provide and manage them.
This introduces two new registration opcodes:
- IORING_REGISTER_KMBUF_RING: Register a kernel-managed buffer ... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:44 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Add support for mmapping kernel-managed buffer rings (kmbuf) to
userspace, allowing applications to access the kernel-allocated buffers.
Similar to application-provided buffer rings (pbuf), kmbuf rings use the
buffer group ID encoded in the mmap offset to identify which buffer ring
to map. The implementation follows t... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:45 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Allow kernel-managed buffers to be selected. This requires modifying the
io_br_sel struct to separate the fields for address and val, since a
kernel address cannot be distinguished from a negative val when error
checking.
Auto-commit any selected kernel-managed buffer.
Signed-off-by: Joanne Koong <joannelkoong@gmail.... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:46 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Add kernel APIs to pin and unpin buffer rings, preventing userspace from
unregistering a buffer ring while it is pinned by the kernel.
This provides a mechanism for kernel subsystems to safely access buffer
ring contents while ensuring the buffer ring remains valid. A pinned
buffer ring cannot be unregistered until ex... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:47 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Add an interface for buffers to be recycled back into a kernel-managed
buffer ring.
This is a preparatory patch for fuse over io-uring.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
include/linux/io_uring/cmd.h | 11 +++++++++
io_uring/kbuf.c | 44 ++++++++++++++++++++++++++++++++++++
2 files... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:48 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | io_uring_is_kmbuf_ring() returns true if there is a kernel-managed
buffer ring at the specified buffer group.
This is a preparatory patch for upcoming fuse kernel-managed buffer
support, which needs to ensure the buffer ring registered by the server
is a kernel-managed buffer ring.
Signed-off-by: Joanne Koong <joanne... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:49 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Export io_ring_buffer_select() so that it may be used by callers who
pass in a pinned bufring without needing to grab the io_uring mutex.
This is a preparatory patch that will be needed by fuse io-uring, which
will need to select a buffer from a kernel-managed bufring while the
uring mutex may already be held by in-pr... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:50 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | Return the id of the selected buffer in io_buffer_select(). This is
needed for kernel-managed buffer rings to later recycle the selected
buffer.
Signed-off-by: Joanne Koong <joannelkoong@gmail.com>
---
include/linux/io_uring/cmd.h | 2 +-
include/linux/io_uring_types.h | 2 ++
io_uring/kbuf.c | 7 +++... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:51 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | When uring_cmd operations select a buffer, the completion queue entry
should indicate which buffer was selected.
Set IORING_CQE_F_BUFFER on the completed entry and encode the buffer
index if a buffer was selected.
This will be needed for fuse, which needs to relay to userspace which
selected buffer contains the data.... | {
"author": "Joanne Koong <joannelkoong@gmail.com>",
"date": "Mon, 9 Feb 2026 16:28:52 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/9/26 5:28 PM, Joanne Koong wrote:
I think you want:
if (WARN_ON_ONCE((__u16)(br->tail - bl->head) >= bl->nr_entries))
here to avoid int promotion from messing this up if tail has wrapped.
In general, across the patches for the WARN_ON_ONCE(), it's not a huge
issue to have a litter of them for now. Hopefully w... | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Mon, 9 Feb 2026 17:52:42 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/9/26 5:28 PM, Joanne Koong wrote:
I'm probably missing something here, but why can't the caller just use
req->buf_index for this?
--
Jens Axboe | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Mon, 9 Feb 2026 17:53:39 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/9/26 5:28 PM, Joanne Koong wrote:
Generally looks pretty good - for context, do you have a branch with
these patches and the users on top too? Makes it a bit easier for cross
referencing, as some of these really do need an exposed user to make a
good judgement on the helpers.
I know there's the older series, but... | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Mon, 9 Feb 2026 17:55:03 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/9/26 5:28 PM, Joanne Koong wrote:
For this, I think just add another helper - leave io_pbuf_get_region()
and add a bl->flags & IOBL_KERNEL_MANAGED error check in there, and
add a io_kbuf_get_region() or similar and have a !(bl->flags &
IOBL_KERNEL_MANAGED) error check in that one.
That's easier to read, and ther... | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Mon, 9 Feb 2026 18:02:37 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/9/26 5:28 PM, Joanne Koong wrote:
Probably use the usual struct io_buffer_list *bl here and either use an
ERR_PTR return, or rename the passed on **bl to **blret or something.
Usually done as:
if ((bl->flags & (IOBL_BUF_RING|IOBL_PINNED)) == (IOBL_BUF_RING|IOBL_PINNED))
and maybe then just have an earlier
... | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Mon, 9 Feb 2026 18:07:49 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/10/26 00:28, Joanne Koong wrote:
If you're creating a region, there should be no reason why it
can't work with user passed memory. You're fencing yourself off
optimisations that are already there like huge pages.
...
Please use io_create_region(), the new function does nothing new
and only violates abstractions... | {
"author": "Pavel Begunkov <asml.silence@gmail.com>",
"date": "Tue, 10 Feb 2026 16:34:47 +0000",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On Mon, Feb 9, 2026 at 5:07 PM Jens Axboe <axboe@kernel.dk> wrote:
FWIW, modern compilers will perform this optimization automatically.
They'll even optimize it further to !(~bl->flags &
(IOBL_BUF_RING|IOBL_PINNED)): https://godbolt.org/z/xGoP4TfhP
Best,
Caleb | {
"author": "Caleb Sander Mateos <csander@purestorage.com>",
"date": "Tue, 10 Feb 2026 09:57:08 -0800",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
lkml_critique | linux-fsdevel | Currently, io_uring buffer rings require the application to allocate and
manage the backing buffers. This series introduces kernel-managed buffer
rings, where the kernel allocates and manages the buffers on behalf of
the application.
This is split out from the fuse over io_uring series in [1], which needs the
kernel t... | null | null | null | [PATCH v1 00/11] io_uring: add kernel-managed buffer rings | On 2/10/26 10:57 AM, Caleb Sander Mateos wrote:
Sure, it's not about that, it's more about the common way of doing it,
which makes it easier to read for people. FWIW, your example is easier
to read too than the original.
--
Jens Axboe | {
"author": "Jens Axboe <axboe@kernel.dk>",
"date": "Tue, 10 Feb 2026 11:00:54 -0700",
"is_openbsd": false,
"thread_id": "CAJnrk1YoaHnCmuwQra0XwOxf0aC_PQGby-DT1y_p=YRzotiE-w@mail.gmail.com.mbox.gz"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.